Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: styx Type: enhancement | Status: assigned Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review vote-styx vote-andrew_b Blocking: | Blockedby: --+- Changes (by styx): * owner: metux = styx * status: accepted = assigned -- Ticket URL: www.midnight-commander.org/ticket/188#comment:18 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: styx Type: enhancement | Status: testing Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: fixed|Keywords: review vote-styx vote-andrew_b approved commited-master Blocking: | Blockedby: --+- Changes (by styx): * keywords: review vote-styx vote-andrew_b = review vote-styx vote- andrew_b approved commited-master * status: assigned = testing * resolution: = fixed -- Ticket URL: www.midnight-commander.org/ticket/188#comment:19 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: styx Type: enhancement | Status: testing Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: fixed|Keywords: commited-master Blocking: | Blockedby: --+- Changes (by styx): * keywords: review vote-styx vote-andrew_b approved commited-master = commited-master -- Ticket URL: www.midnight-commander.org/ticket/188#comment:20 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review vote-styx Blocking: | Blockedby: --+- Comment(by winnie): Why changed you the owner from styx to you? Please don't do that in future. If someone has accepted a bug he works on it. -- Ticket URL: www.midnight-commander.org/ticket/188#comment:16 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Changes (by metux): * keywords: review mandriva = review mandriva vote-metux * owner: = metux * status: new = accepted Old description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup New description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:e5b736cf4a598657b14b6c59fae5cfc308fe1f37 -- -- Ticket URL: www.midnight-commander.org/ticket/188#comment:3 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Changes (by andrew_b): * version: 4.6.1 = 4.6.2 Comment: I fixed memory leak in init_my_statfs() function. Patch is attached. Please review. -- Ticket URL: www.midnight-commander.org/ticket/188#comment:4 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Description changed by metux: Old description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:e5b736cf4a598657b14b6c59fae5cfc308fe1f37 New description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:059f076bce7eaa0396abc183631bfd7330595382 -- -- Ticket URL: www.midnight-commander.org/ticket/188#comment:5 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Comment(by styx): I think original patch needs to be reworked. Some const's for options count like in option.c is done. Why new option has index 0? This one makes useless changes in source code. It should be with the last index... -- Ticket URL: www.midnight-commander.org/ticket/188#comment:6 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Comment(by styx): my vote for mountlist-free_mount_list.patch but not for branch 188_show_free_space Please, don't merge this into master. -- Ticket URL: www.midnight-commander.org/ticket/188#comment:7 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review mandriva vote-metux Blocking: | Blockedby: --+- Comment(by styx): I'll try to rework this -- Ticket URL: www.midnight-commander.org/ticket/188#comment:8 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: styx Type: enhancement | Status: assigned Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: rework Blocking: | Blockedby: --+- Changes (by styx): * owner: metux = styx * status: accepted = assigned -- Ticket URL: www.midnight-commander.org/ticket/188#comment:10 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by metux): * owner: styx = metux Old description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:059f076bce7eaa0396abc183631bfd7330595382 New description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:186cb259c08be7a955298b57b060dd1a1aff6617 -- Comment: rebased to master: changeset:186cb259c08be7a955298b57b060dd1a1aff6617 -- Ticket URL: www.midnight-commander.org/ticket/188#comment:13 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review Blocking: | Blockedby: --+- Description changed by metux: Old description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup branch:188_show_free_space changeset:186cb259c08be7a955298b57b060dd1a1aff6617 New description: http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup master branch:188_show_free_space changeset:186cb259c08be7a955298b57b060dd1a1aff6617 -- -- Ticket URL: www.midnight-commander.org/ticket/188#comment:14 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: metux Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review vote-styx Blocking: | Blockedby: --+- Changes (by styx): * keywords: review = review vote-styx -- Ticket URL: www.midnight-commander.org/ticket/188#comment:15 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: styx Type: enhancement | Status: accepted Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.2 Resolution: |Keywords: review Blocking: | Blockedby: --+- Changes (by styx): * keywords: rework = review -- Ticket URL: www.midnight-commander.org/ticket/188#comment:12 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: Type: enhancement | Status: new Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review mandriva Blocking: | Blockedby: --+- Comment(by andrew_b): I've modified this patch (see attachment). Differences: * info format is changed from (as an example) 5M (50%) of 10M to 5M/10M (50%) . So we don't need to translate it. * show_free_space() function is moved from main.c to screen.c. Now this function is called in show_dir() function only. Related global variables are moved into show_free_space() and made static. But there is a problem as in Mandriva/RH patch as in mine one. The init_my_statfs() function is called many times, therefore we have the memory leak. -- Ticket URL: www.midnight-commander.org/ticket/188#comment:2 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space -+-- Reporter: metux| Owner: Type: defect | Status: new Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Keywords: review mandriva |Blocking: Blockedby: | -+-- http://svn.mandriva.com/cgi- bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc- showfree.patch?view=markup -- Ticket URL: www.midnight-commander.org/ticket/188 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Midnight Commander] #188: (mandriva) show free space
#188: (mandriva) show free space --+- Reporter: metux| Owner: Type: enhancement | Status: new Priority: major| Milestone: 4.7 Component: mc-core | Version: 4.6.1 Resolution: |Keywords: review mandriva Blocking: | Blockedby: --+- Changes (by metux): * type: defect = enhancement -- Ticket URL: www.midnight-commander.org/ticket/188#comment:1 Midnight Commander www.midnight-commander.org Midnight Development Center ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
