[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

Update of bug #21331 (project mc):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

Follow-up Comment #8, bug #21331 (project mc):

1) Viewing an unreadable file not producing an error box is a bug not related
to FISH which was revealed by my patch.

2) cd-ing into unreadable fish directories is a bug in fish.


I'll try to fix both. In the meantime I'll check in the attached patch since
I found no evidence that it is related to the bugs above.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[G. Karageorgiev]

Follow-up Comment #7, bug #21331 (project mc):

My mistake. Attempt to copy a unreadable file from a remote system produces
an error box indeed. 
But I was always trying to view the file first. This is silently ignored
without error box. Also no error box when I try to enter a directory on the
remote panel to which I don't have access rights. It simply appears as empty.
When I try the same on a "local" panel, there is a corresponding error box
displayed. 

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

Follow-up Comment #6, bug #21331 (project mc):

Today I had the opportunity to test the patch on MacOS. Trying to copy a
unreadable file from a remote system I got and error dialog box. I'd like to
understand why it doesn't work for you as expected - please, explain what are
you trying to do so that I can reproduce.


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[G. Karageorgiev]

Follow-up Comment #5, bug #21331 (project mc):

I noticed that the ChangeLog is updated and in the same time the patch below
is not in the repository. I think it is worth to have the patch in 4.6.2
(unless it does not break something else, of course). I use the latest mc from
the repository with this patch and I have not had problems so far. The lack of
error panels does not bother me very much.

Regards.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[G. Karageorgiev]

Follow-up Comment #4, bug #21331 (project mc):

I am sure. Later I replied that I checked out from the CVS because I could
not download the patch.
+verbose+
$ cvs -z3 -q diff vfs/fish.c
Index: vfs/fish.c
===
RCS file: /cvsroot/mc/mc/vfs/fish.c,v
retrieving revision 1.122
diff -r1.122 fish.c
621a622,628
> 
> /*
>  * Check whether the remote file is readable by using `dd' to copy 
>  * a single byte from the remote file to /dev/null. If `dd' completes
>  * with exit status of 0 use `cat' to send the file contents to the
>  * standard output (i.e. over the network).
>  */
623a631,632
>   "if dd if=/%s of=/dev/null bs=1 count=1 2>/dev/null ;n"
>   "thenn"
630,631c639,643
<   "echo '### 200'n", 
<   name, name, name );
---
>   "echo '### 200'n"
>   "elsen"
>   "echo '### 500'n" 
>   "fin",
>   name, name, name, name );
-verbose-

What I forgot to tell in my previous comment is that the attempt to view a
remote unreadable file is ignored and the remote unreadable directories appear
empty. Error panels are displayed however, when these attempts are done on a
local file system.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

Follow-up Comment #3, bug #21331 (project mc):

Are you sure about that ? Perhaps you applied the patch to a modified copy of
MC ? According to one of your comments on
bug #21302 you made some changes when you tried to fix the unreadable file
hang.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[G. Karageorgiev]

Follow-up Comment #2, bug #21331 (project mc):

I tested the patch, here are the results:
- The hanging seems to be fixed, mc doesn't hang on unreadable file or
directory
- The messed-up directories after an error occurs seems to be fixed as well
- A minor problem though - there is no error message box.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

Follow-up Comment #1, bug #21331 (project mc):

I am attaching a patch. It should fix the hang and display an error message
box. The message is not precise enough i.e. "Access denied.", but getting the
real cause of the error would require the remote user group/id to be retrieved
and matched against the file mode/permissions either locally or on the remote
system - I am not really sure that we want that.

Please, test the patch and let me know if there are any problems with it.


(file #14135)
___

Additional Item Attachment:

File name: mc-fish-retr-unreadable-fix.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #21331] FISH: Retrieving an unreadable file causes MC to hang

[Pavel Tsekov]

URL:
  

 Summary: FISH: Retrieving an unreadable file causes MC to
hang
 Project: GNU Midnight Commander
Submitted by: ptsekov
Submitted on: Friday 10/12/2007 at 10:50
Category: VFS
Severity: 3 - Normal
  Status: None
 Privacy: Public
 Assigned to: ptsekov
 Open/Closed: Open
 Discussion Lock: Any
 Release: All versions
Operating System: All

___

Details:






___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel