[bug #9631] Cannot put tabs only where I want them
Update of bug #9631 (project mc): Status:None = Fixed ___ Follow-up Comment #18: I am closing this bug report as fixed. Feel free to reopen if needed. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #7, bug #9631 (project mc): Btw what about the wordprocessor mode ? It would still keep indenting the old way... ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #6, bug #9631 (project mc): I think this patch is reasonable. In fact the old implementation is very questionable. I'll commit your patch if you (and anyone interested) help me a little. First of all I am not sure which variant of your patch would be best. I think it is worth to include both variants and made them configurable. Would you mind extending your patch to add a radio button to the configuration dialog of mcedit ? It is not a big deal but if you don't want to do it I can do it for you - in any case I'll need the right wording for each of the two variants. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #9, bug #9631 (project mc): re wordprocessor mode: i have no idea. i tried dynamic paragraphing and it behaved exactly like no wrap at all. typewriter did no indentation at all, so it seems to be unaffected. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Nachricht geschickt von/durch Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #11, bug #9631 (project mc): what _exact_ option set should i choose to see the mode in question? what would be an appropriate text layout for a demo? from what i've seen so far, i'd say leave the rest alone - because i haven't seen anything special. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Nachricht geschickt von/durch Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #8, bug #9631 (project mc): i for one would commit the patch as is. the creation of whitespace-only lines is already annoying enough as it is (the currently enabled variant of my patch does not change it in any direction). enabling the other variant would be a regression in this respect, so i really think it does not make sense to enable it (even optionally) until trailing whitespace removal is implemented, and experience from other editors shows that it is non-trivial to get right (well, it depends on the architecture - i didn't try it for mcedit, yet). ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Nachricht geschickt von/durch Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #12, bug #9631 (project mc): Btw I am missing the changelog for your patch. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #10, bug #9631 (project mc): Your patch doesn't affect wordprocessing mode. I was asking whether we should change indentation in wordprocessing mode to reflect the changes introduced with your patch ? ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #13, bug #9631 (project mc): Oswald, if you agree I'll commit the attached (slightly changed) patch once you submit the changelog entry. ___ Additional Item Attachment: File name: edit_auto_indent.patch Size:1 KB http://savannah.gnu.org/bugs/download.php?item_id=9631item_file_id=3315 ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #14, bug #9631 (project mc): the patch seems ok - i guess the p != 0 assertion can be safely made. :) regarding the log: this is exactly the kind of nitpicking i think you should not do. doing it yourself this time and adding a hint next time please submit a ChangeLog entry with the patch would be appropriate, i think. anyway, here we go: * edit.c (edit_auto_indent): Remove redundand parameters and change the indentation strategy to copy whitespace from the previous line instead of filling up with allegedly equivalent whitespace depending on the tab setting. fwiw, if you're a total pedant you can split off the removal of the redundand parameters into another patch (to be applied first), but i won't waste my time on it ... :) ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Nachricht geschickt von/durch Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #15, bug #9631 (project mc): You got it wrong this time - I am not doing it because I am pedantic or because I am lazy. I am doing it because I just cannot explain it properly in words. As you can see here: http://mail.gnome.org/archives/mc-devel/2006-January/msg00053.html I did exactly as you suggest. You have got the wrong impression of me. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #16, bug #9631 (project mc): I've commited Oswald's patch. Thanks, Oswald! However, before closing this bug report as fixed I'd like to hear a word from Jozef Behran. So, Jozef, if you are reading this, please, give mcedit from cvs a try. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #17, bug #9631 (project mc): ah, ok, sorry then. i'm always forgetting that people might have even bigger problems finding the right words than me. :} thanks for committing. :-) ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Update of bug #9631 (project mc): Status:None = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #1: When Fill tabs with spaces is set the editor will insert spaces for both indents as when pressing tabs. Not sure if this behaviour was incorrect for 4.5.55, but for current CVS (and 4.6.0 I believe) this behaviour is consistent. You either get spaces (if the option is set) or tabs (if the option is not set) both on indentation and on pressing tab. When reporting bugs please try the latest version of mc to confirm the issue has not been fixed. Closing fixed. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #2, bug #9631 (project mc): leonard didn't get the idea. :-P this bug is _not_ fixed; nothing changed here for years. i posted this patch some months ago, but nobody cared to notice. ___ Additional Item Attachment: File name: mcedit-autoindent.diff Size:1 KB patch to make autoindent sane http://savannah.gnu.org/bugs/download.php?item_id=9631item_file_id=2500 ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Update of bug #9631 (project mc): Status: Fixed = None Open/Closed: Closed = Open ___ Follow-up Comment #3: Reopening as there seems to be an issue here :) . When the Fill tabs with spaces is off, the autoindent feature replaces each eight spaces with a tab (which I don't want) and TAB inserts tabs into the file. This inconsistency I cannot reproduce. I either get tabs in both cases or spaces if the option is set. Maybe you could try to rephrase the issue? ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #4, bug #9631 (project mc): Duh. Not reading this properly I guess. Please disregard my comment about fixed inconsitencies. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #9631] Cannot put tabs only where I want them
Follow-up Comment #5, bug #9631 (project mc): this one is really a hard birth ... it has two years of history already ... :) disclaimer: i freely interpret the original report as being the same as my wish, because the request makes little sense when implemented literally. :) ok, here is the mail i sent along with the patch: once upon a time, i wrote: proski wrote: ossi wrote: the type of white-space used by auto-indent should not be based on the fill tabs with spaces setting. instead, the leading whitespace from the above line should be copied. otherwise it's impossible to use a tabbing style like tabif (...) tabtabif (cond1 function(par1, tabtab par2)) tabtabtabstatement; [to say it in words: tab for indentation, space for padding] (which is _the_ tabbing style). I have no idea what you mean. preserving the already present indentation style as much as possible. take the above example and imagine i want to add par3 to the function call. when i press enter on the first closing paren, the new line should be identical to the par2 line up to the point where the cursor is placed (below the p of par2, obviouly). and this time i have a patch. i implemented two variants, therefore the ifdef. the first variant takes the nearest line with any non-whitespace as a template, like current mcedit does. but unlike the current code, it does not truncate the indentation to the current column (this can happen if the line we are coming from is whitespace only and shorter than the template line). this is also the way the old borland editors behaved, but it's a true nightmare if you have no trailing whitespace removal. the second variant just copies the leading whitespace of the previous line, even if it is whitespace-only or even empty. i think this is perfectly reasonable. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=9631 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
