Re: Fw: [patch] Synchronization of the panels (fwd)
Hello Pavel, - Original Message - From: Pavel Tsekov [EMAIL PROTECTED] To: Siver Andrey [EMAIL PROTECTED] Cc: mc-devel@gnome.org Sent: Wednesday, March 09, 2005 6:48 PM Subject: Re: Fw: [patch] Synchronization of the panels (fwd) Hello Andrey, On Wed, 16 Mar 2005, Siver Andrey wrote: - Original Message - From: Miguel de Icaza [EMAIL PROTECTED] To: Pavel Tsekov [EMAIL PROTECTED] Cc: MC dev mc-devel@gnome.org Sent: Saturday, February 26, 2005 7:40 PM Subject: Re: [patch] Synchronization of the panels (fwd) Hello, Configure patches, fall back patches are missing as well. I would like to ask somebody to update configure scripts (WITH_SYNC need to be defined if kernel version = 2.4. If it's not defined - the patch gives nothing new, so I do not understand what do you mean by fall back patches). Is anybody ready to do it? It must be you . You can get some help/advice in the process of reviewing your patch - but do not expect others to do your job. Do you know how to detect kernel version = 2.4 at configure time and how to add corresponding parameter to gcc? Andrey ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Fw: [patch] Synchronization of the panels (fwd)
Hello Andrey, On Wed, 16 Mar 2005, Siver Andrey wrote: - Original Message - From: Miguel de Icaza [EMAIL PROTECTED] To: Pavel Tsekov [EMAIL PROTECTED] Cc: MC dev mc-devel@gnome.org Sent: Saturday, February 26, 2005 7:40 PM Subject: Re: [patch] Synchronization of the panels (fwd) Hello, The patch still needs a lot of work, for example, why do we have an include file at all with the code? (The core of the code lives in sync.inc). It's not a problem if it's the last problem (it's easy to embed sync.inc straight into main.c). Well, it is even easier to create a new set of files (.h and .c) devoted to this new feature and then patch the Makefile.am files to include the new module in the build. Configure patches, fall back patches are missing as well. I would like to ask somebody to update configure scripts (WITH_SYNC need to be defined if kernel version = 2.4. If it's not defined - the patch gives nothing new, so I do not understand what do you mean by fall back patches). Is anybody ready to do it? It must be you . You can get some help/advice in the process of reviewing your patch - but do not expect others to do your job. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [patch] Synchronization of the panels (fwd)
Hello, This is an updated version of the dnotify patch from Andrey Siver. The patch still needs a lot of work, for example, why do we have an include file at all with the code? (The core of the code lives in sync.inc). Configure patches, fall back patches are missing as well. Miguel. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel