[patch #4162] detach on quick-save

2006-03-17 Thread Oswald Buddenhagen 

Follow-up Comment #2, patch #4162 (project mc):

you put the mc_close() outside an else branch; you'll now close an arbitrary
handle if the file is not local; closing -1 is not too nice, either.
other than that it looks ok.

btw, edit_save_as_cmd() uses mc_open() to fake an mc_stat() - i think it
would make sense to change it.


___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=4162

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

2006-03-17 Thread Pavel Tsekov 

Follow-up Comment #3, patch #4162 (project mc):

Right! My bad. The logic was pretty twisted anyway. I'll fix the patch and
commit it.

I also noted that mc_open() is used to emulate stat() on at least one more
place but I didn't want to change it since I might miss something .



___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=4162

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #4162] detach on quick-save

2006-03-17 Thread Pavel Tsekov 

Update of patch #4162 (project mc):

  Status: In Progress = Done   
 Open/Closed:Open = Closed 

___

Follow-up Comment #4:

I've commited the patch.

Thanks!


___

Reply to this item at:

  http://savannah.gnu.org/patch/?func=detailitemitem_id=4162

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel