Re: AMC merge patch #2
Hello!
The saga continues, this time with EXTfs and Syntax files updates:
Changes included in patch: (all merged in from AMC version mc-4.1.35-A12pre)
- EXTFS Support for the ESP archiver ('uesp' added where needed)
I have never heard of ESP.
Icon=compressed.xpm is wrong. There is no compressed.xpm in the current
code. If you don't check your changes, somebody else will have to do it
for you.
That's precisely a defect that cannot be found by the end users. You are
adding an obsolete keyword, which has no effect. However, add 100
obsolete keywords, and mc.ext becomes much harder to understand by
developers, let alone users trying to customize it.
- (commented out) support for .deb on dpkg-less systems
(users just need to move # 2 lines up :))
Believe me, 99% of users won't know about that commented piece. The fix
belongs to the udeb script that should be able to fallback to using ar
if dpkg is missing or doesn't work.
- New .syntax files for BAssPasC, Macro-HTML, J(Dis)Asm languages
I only heard of jdisasm of all those. I'm not sure that most *.mac files
are written in Macro-HTML. I think I'll put this to the contrib section
of the website.
- (mostly) Color changes in HTML, LSM, Makefile .syntax files, to make
them (more) readable on blue background
(who the fsck thought that dark brown on dark red is readable?)
I don't remember seeing dark brown on dark red in any highlighted files.
If you mean dark brown on dark blue, that question was raised already, and
the right fix would be to implement macro definitions for colors. Then
you could define the color for comments in one place, and it would affect
all syntax files using that definition.
-context !-- -- brown
- spellcheck
+# modified by A'rpi/ESP-team [EMAIL PROTECTED]
-context ! brightred/orange
Please avoid placing your name everywhere you change something. You are
not the first and hopefully not the last person modifying any given piece
of code. This comment is adding exactly nothing.
If I find this in the release, I won't know what was modified, when and
why. I won't know if any further modifications have been done in that
code. I won't know if I should ask you about all lines below that
comment or only about the next line.
+# Syntax hilight definition file for Midnight Commander / CoolEdit
highlightCooledit
--
Regards,
Pavel Roskin
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC merge patch #2
Hi,
The saga continues, this time with EXTfs and Syntax files updates:
Changes included in patch: (all merged in from AMC version mc-4.1.35-A12pre)
- EXTFS Support for the ESP archiver ('uesp' added where needed)
I have never heard of ESP.
Is it enough reason to refuse the patch?
It's an old DOS archived written by me and some others. It was widely used
around '97 under DOS. SInce I have lots of .esp files i've ported the
archiver to linux few years ago and added support for it in mc too.
Icon=compressed.xpm is wrong. There is no compressed.xpm in the current
possible. what is the replacement?
it comes from 4.1.35 where it did exists (probably) at least i copied it
from another archiver's (probably .zip i don't remember) entry.
since i'm using mc on console, i don't see icons so hard to notice if no
such icon...
code. If you don't check your changes, somebody else will have to do it
for you.
That's precisely a defect that cannot be found by the end users. You are
adding an obsolete keyword, which has no effect. However, add 100
obsolete keywords, and mc.ext becomes much harder to understand by
developers, let alone users trying to customize it.
ok
- (commented out) support for .deb on dpkg-less systems
(users just need to move # 2 lines up :))
Believe me, 99% of users won't know about that commented piece. The fix
belongs to the udeb script that should be able to fallback to using ar
if dpkg is missing or doesn't work.
yes it was discussed later (after i sent the patch)
- New .syntax files for BAssPasC, Macro-HTML, J(Dis)Asm languages
I only heard of jdisasm of all those.
great...
I'm not sure that most *.mac files
are written in Macro-HTML. I think I'll put this to the contrib section
of the website.
basspasc is an old assembly extension language for DOS, written by me and
others... (as usual) unless you was interested in asm optimization under DOS
that times it's no wondenr if you don't know it.
macro-html is not a widely known thing, i've wrote it to generate webpages
from templates using basspasc-like syntax macros...
- (mostly) Color changes in HTML, LSM, Makefile .syntax files, to make
them (more) readable on blue background
(who the fsck thought that dark brown on dark red is readable?)
I don't remember seeing dark brown on dark red in any highlighted files.
see the comments (// or /* */) in any .c file... unreadable!
maybe i should buy an LCD/TFT instead of my CRT monitor?
If you mean dark brown on dark blue, that question was raised already, and
the right fix would be to implement macro definitions for colors. Then
you could define the color for comments in one place, and it would affect
all syntax files using that definition.
it would be great!
-context !-- -- brown
- spellcheck
+# modified by A'rpi/ESP-team [EMAIL PROTECTED]
-context ! brightred/orange
Please avoid placing your name everywhere you change something. You are
sorry. i'm used to add comments where i modify in other's files, so i can
easily look up where did i touch it. with cvs it has no much sense it's
right, it's an old (and wrong) habbit...
+# Syntax hilight definition file for Midnight Commander / CoolEdit
highlightCooledit
i've seen 'hi-lite' used at too many places (other editors) while never
meet highlight. also teh meaning of highlight is a bit funny, at least
high light is nothing close to syntax coloring, imho.
what about the other (much more important) patch-set (AMC #1) ?
yes i know that touching the .c files is very very bad and i shouldn't do
that etc...
A'rpi / Astral ESP-team
--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
However, many people beg for its inclusion in Debian. Why? - Gabucino
Because having new software in Debian is good. - Josselin Mouette
Because having good software in Debian is new. - Gabucino
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC merge patch #2
On Tue, Feb 11, 2003 at 03:00:14PM -0500, bulia byak wrote:
Why not apply the same approach here? Especially given that such
additions are very unlikely to break anything else in mc.
On the other side nearly every programmer has written some tools for
his own use, to learn something new, just for fun or to fix some
problems with widely available tools. Often only the creator and some
friends use it.
Do you really think we should put extfs for JSR ('John Smith's
Archiver'), JSOPL ('John Smith's Own Programming Language') syntax
file, vfs for 'John Smith's Personal Filesystem' (JSPF), etc. into
official mc archive???
There must be some selection - and it would fit well into 'contrib'
cvs directory. Arpi, this mail is not to offend you, I also have some
toys created by me I enjoy. I just think there is no point including
things in mc that 99,9% users wouldn't use.
Regards
alpha
ps. When 'contrib' will be created, could sb move 'hp48' and 'bpp'
extfses there? Its an example of (nearly) useless extfs.
--
_.|._ |_ _.: Adam Byrtek, alpha@(irc.pl|debian.org)
(_|||_)| |(_|: gg 1802819, pgp 0xB25952C0
|: jid alpha.pl(at)jabber.org
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC merge patch #2
Hello! - .sytnax file mapping for .syntax files moved to top, so editing files like Makefile.syntax is colored now :) (it matched the Makefile.* rule) I've applied this part now, and everything else will be applied after 4.6.0 release. Thank you for porting your patches. Actually, I hoped to make the release yesterday, but I have a lot of work and I don't feel safe about making a major release when I'm not getting enough sleep and when there are still messages in this list that I haven't even seen since the vacation. Anyway, the release will happen before the weekend. -- Regards, Pavel Roskin ___ Mc-devel mailing list [EMAIL PROTECTED] http://mail.gnome.org/mailman/listinfo/mc-devel
AMC merge patch #2
Hi,
The saga continues, this time with EXTfs and Syntax files updates:
Changes included in patch: (all merged in from AMC version mc-4.1.35-A12pre)
- EXTFS Support for the ESP archiver ('uesp' added where needed)
- (commented out) support for .deb on dpkg-less systems
(users just need to move # 2 lines up :))
- New .sytnax files for BAssPasC, Macro-HTML, J(Dis)Asm languages
- (mostly) Color changes in HTML, LSM, Makefile .syntax files, to make
them (more) readable on blue background
(who the fsck thought that dark brown on dark red is readable?)
- .sytnax file mapping for .syntax files moved to top, so editing files
like Makefile.syntax is colored now :) (it matched the Makefile.* rule)
patch:
diff -Naur mc-2003-01-24-21.patched/lib/mc.ext.in mc-2003-01-24-21.patch2/lib/mc.ext.in
--- mc-2003-01-24-21.patched/lib/mc.ext.in Wed Dec 25 01:26:23 2002
+++ mc-2003-01-24-21.patch2/lib/mc.ext.in Sat Jan 25 22:40:37 2003
@@ -422,6 +422,13 @@
Open=%cd %p#uarj
View=%view{ascii} unarj l %f
+# esp
+regex/\.e(sp|[0-9][0-9])$
+ Open=%cd %p#uesp
+ View=%view{ascii} unesp v %f
+ Extract=unesp x %f
+ Icon=compressed.xpm
+
# ha
regex/\.(ha|HA|Ha)$
Open=%cd %p#uha
@@ -495,6 +502,9 @@
regex/\.deb$
Open=%cd %p#deb
View=%view{ascii} dpkg-deb -c %f
+# for dpkg-less systems:
+# Open=%cd %p#uar
+# View=%view{ascii} ar p %f control.tar.gz | tar xzO control ./control
+2/dev/null ; echo ; echo Filelist: ; ar p %f data.tar.gz | tar tzv
### Default ###
diff -Naur mc-2003-01-24-21.patched/syntax/Makefile.am
mc-2003-01-24-21.patch2/syntax/Makefile.am
--- mc-2003-01-24-21.patched/syntax/Makefile.am Sun Sep 22 02:06:27 2002
+++ mc-2003-01-24-21.patch2/syntax/Makefile.am Sat Jan 25 22:39:31 2003
@@ -35,6 +35,9 @@
tcl.syntax \
texinfo.syntax \
unknown.syntax \
- xml.syntax
+ xml.syntax \
+ bapc.syntax \
+ mhtml.syntax\
+ jasm.syntax
EXTRA_DIST = $(syntax_DATA)
diff -Naur mc-2003-01-24-21.patched/syntax/Syntax mc-2003-01-24-21.patch2/syntax/Syntax
--- mc-2003-01-24-21.patched/syntax/Syntax Fri Dec 13 09:12:52 2002
+++ mc-2003-01-24-21.patch2/syntax/Syntax Sat Jan 25 20:08:49 2003
@@ -17,6 +17,9 @@
# brightcyan
# white
+file [Ss]yntax$ Syntax\sHighlighting\sdefinitions ^#\ssyntax\srules\sversion\s
+include syntax.syntax
+
file ..\*\\.(diff|rej|patch)$ Diff\sOutput ^(diff|Index:)\s
include diff.syntax
@@ -71,6 +74,15 @@
file ..\*\\.(php|PHP)[0-9]?$ PHP\sProgram
include php.syntax
+file ..\*\\.(bap|bp2|bp3|bpp|bpe|lib|l32)$ BAssPasC\sProgram
+include bapc.syntax
+
+file ..\*\\.(mhtml|mac)$ Macro-HTML\sSource
+include mhtml.syntax
+
+file ..\*\\.(jasm)$ JVM\sAssembly
+include jasm.syntax
+
file ..\*\\.(java|JAVA|Java|jav)$ Java\sProgram
include java.syntax
@@ -112,9 +124,6 @@
file Don_t_match_me Mail\sfolder ^From\s
include mail.syntax
-
-file [Ss]yntax$ Syntax\sHighlighting\sdefinitions ^#\ssyntax\srules\sversion\s
-include syntax.syntax
file .\* unknown
include unknown.syntax
diff -Naur mc-2003-01-24-21.patched/syntax/bapc.syntax
mc-2003-01-24-21.patch2/syntax/bapc.syntax
--- mc-2003-01-24-21.patched/syntax/bapc.syntax Thu Jan 1 01:00:00 1970
+++ mc-2003-01-24-21.patch2/syntax/bapc.syntax Sat Jan 25 20:56:42 2003
@@ -0,0 +1,209 @@
+# BAssPasC syntax definitions v1.0 for Midnight Commander 4.1.35 and 4.5.x
+# (C) 1999 by A'rpi/ESP-team [EMAIL PROTECTED]
+# BAPC is a programming language, visit http://esp-team.scene.hu for details!
+
+context default brightcyan
+
+# main BAPC commands:
+keyword whole VAR white
+keyword whole CONST white
+
+keyword whole USES white
+keyword whole INDIRECT white
+keyword whole INDIRECTALL white
+keyword whole INCLUDEPROC white
+keyword whole INCLUDE white
+keyword wholeleft INCLUDED white
+keyword whole ALIGN white
+
+keyword whole SMOV white
+keyword whole RMOV white
+keyword whole LDDM white
+keyword whole SDDM white
+keyword whole LDD white
+keyword whole SDD white
+
+# IF-EQU
+keyword whole if white
+keyword whole ifn white
+keyword whole else white
+keyword whole endif white
+
+# BAPC conditionals:
+keyword whole IF white
+keyword whole IFS white
+keyword whole IFN white
+keyword whole IFNS white
+keyword whole DO white
+keyword whole DOCMD white
+keyword whole THEN white
+keyword whole THENCMD white
+keyword whole ELSE white
+keyword whole ENDIF white
+keyword whole WHILE white
+keyword whole ENDWHILE white
+keyword whole REPEAT white
+keyword whole UNTIL white
+keyword whole WITH white
+keyword whole ENDWITH white
+keyword whole CASE white
+keyword whole END white
+keyword whole ENDCASE white
+keyword whole ENDM white
+# FOR is too complex, include only the most importants:
+
