Feature request with patch: fish shell prompt

[Chris Owen]

Hi,

I'm new to mc-devel so I thought I'd say hello. I've been using mc for a month 
or so and have recently started using fish shell too. Current support for fish 
subshell doesn't show a prompt, because the fish_prompt function is overridden 
to pass current path to mc.

I've made a patch containing a change to allow a prompt to be used. I created a 
trac item here with an explanation and a diff: 
https://www.midnight-commander.org/ticket/3232

Chris

  ___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx   
  Type:  enhancement  |  Status:  testing
  Priority:  minor|   Milestone:  4.7
 Component:  mc-core  | Version: 
Resolution:  fixed|Keywords:  commited-master
  Blocking:   |   Blockedby: 
--+-
Changes (by styx):

  * keywords:  vote-angel_il vote-andrew_b approved => commited-master
  * status:  accepted => testing
  * resolution:  => fixed


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx
  Type:  enhancement  |  Status:  accepted
  Priority:  minor|   Milestone:  4.7 
 Component:  mc-core  | Version:  
Resolution:   |Keywords:  vote-angel_il vote-andrew_b approved
  Blocking:   |   Blockedby:  
--+-
Changes (by andrew_b):

  * keywords:  vote-angel_il => vote-angel_il vote-andrew_b approved


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx 
  Type:  enhancement  |  Status:  accepted 
  Priority:  minor|   Milestone:  4.7  
 Component:  mc-core  | Version:   
Resolution:   |Keywords:  vote-angel_il
  Blocking:   |   Blockedby:   
--+-
Changes (by angel_il):

  * keywords:  review => vote-angel_il


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx
  Type:  enhancement  |  Status:  accepted
  Priority:  minor|   Milestone:  4.7 
 Component:  mc-core  | Version:  
Resolution:   |Keywords:  review  
  Blocking:   |   Blockedby:  
--+-

Comment(by styx):

 How to test:
 Start at: .
 Filename: *
 [x] Find recursively
 [x] case Sensitive
 [x] Regular expression
 [ ] Skip .hidden files and dirs

 result:
 ./
 hid2
 1
 visible
 .hidden
 ./.hidden/
 3
 ./visible/
 2
 ./hid2/
 .hh



 Start at: .
 Filename: *
 [x] Find recursively
 [x] case Sensitive
 [x] Regular expression
 [x] Skip .hidden files and dirs

 result:
 ./
 hid2
 1
 visible
 ./visible/
 2

-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx
  Type:  enhancement  |  Status:  accepted
  Priority:  minor|   Milestone:  4.7 
 Component:  mc-core  | Version:  
Resolution:   |Keywords:  review  
  Blocking:   |   Blockedby:  
--+-
Changes (by styx):

  * version:  4.6.1 =>


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx
  Type:  enhancement  |  Status:  accepted
  Priority:  minor|   Milestone:  4.7 
 Component:  mc-core  | Version:  4.6.1   
Resolution:   |Keywords:  review  
  Blocking:   |   Blockedby:  
--+-
Changes (by styx):

  * keywords:  => review


Comment:

 have a look at: 132_search_skip_hidden

-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
--+-
  Reporter:  metux|   Owner:  styx
  Type:  enhancement  |  Status:  accepted
  Priority:  minor|   Milestone:  4.7 
 Component:  mc-core  | Version:  4.6.1   
Resolution:   |Keywords:  
  Blocking:   |   Blockedby:  
--+-
Changes (by styx):

  * owner:  => styx
  * status:  new => accepted


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Midnight Commander] #34: [FtReq] DAR archive support (was: savannah: Feature request, please add support for dar archives)

[Ticket System]

#34: [FtReq] DAR archive support
--+-
  Reporter:  slavazanko   |   Owner: 
  Type:  enhancement  |  Status:  new
  Priority:  minor|   Milestone: 
 Component:  vfs  | Version: 
Resolution:   |Keywords: 
  Blocking:   |   Blockedby: 
--+-
Changes (by metux):

  * priority:  trivial => minor
  * type:  task => enhancement


-- 
Ticket URL: 
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[Midnight Commander] #132: Feature-Request: ignore dot-files on search

[Ticket System]

#132: Feature-Request: ignore dot-files on search
-+--
 Reporter:  metux|   Owner:   
 Type:  enhancement  |  Status:  new  
 Priority:  minor|   Milestone:   
Component:  mc-core  | Version:  4.6.1
 Keywords:   |Blocking:   
Blockedby:   |  
-+--
 It would be great if the search tool would have an option to hidden files.

-- 
Ticket URL: <http://midnight-commander.org/ticket/132>
Midnight Commander 
Midnight Development Center
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[Pavel Tsekov]

Update of bug #13500 (project mc):

  Status:None => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #5:

I've commited the patch.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[Pavel Tsekov]

Follow-up Comment #3, bug #13500 (project mc):

Patch attached.
___

Additional Item Attachment:

File name: mc-hotlist-dotdot.patchSize:3 KB
Add .. entry to hotlist subgroups


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[Pavel Tsekov]

Follow-up Comment #4, bug #13500 (project mc):

Sorry, the previous patch was bad:

1) I forgot to add `..' entry when adding a new group from the hotlist
dialog

2) The label and the destionation of the `..' entries were not
g_strdup()-ed which caused MC to crash

Please, give the update patch a try - it's should be fine.
___

Additional Item Attachment:

File name: mc-hotlist-dotdot-updated.patch Size:3 KB



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [RFE] [PATCH] star vfs and xattr feature request

[Pavel Tsekov]

On Tue, 31 Jan 2006, Curtis Doty wrote:

> Pavel Tsekov wrote:
>
> >On Mon, 30 Jan 2006, Curtis Doty wrote:
> >
> >>Hi, I'm the original poster of this patch to the redhat bugzilla. Where
> >>it was closed summarily. However, I really thing adding support for
> >>tarball extended attributes is increasingly valuable on selinux systems.
> >>
> >>And star seems to be the best tool for the job. Are there other ways of
> >>safely extracting files from a tarball with these extensions? I'm happy
> >>to rebuild the patch against the mc cvs if there is positive feedback.
> >>
> >>another reference:
> >>http://cdrecord.berlios.de/old/private/star.html
> >>
> >>
> >
> >Since star archives are esentially tar archives with extended information
> >I don't see why a extfs solution is necessary. We can just update the
> >tar code to support the required extension keywords. It's just a matter of
> >parsing a few strings.
> >
> >
> Hrmm, maybe I'm over-thinking the problem, but according to this
> http://cvs.fedora.redhat.com/viewcvs/devel/star/star-1.5-selinux.patch
> it had to be compiled against the selinux headers. Is that an
> appropriate direction for mc/vfs/tar.c?

I think - yes. Btw there was at least one request (in bugzilla or the
mailing list) about adding support for extended attributes to MC.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [RFE] [PATCH] star vfs and xattr feature request

[Curtis Doty]

Pavel Tsekov wrote:

  On Mon, 30 Jan 2006, Curtis Doty wrote:

  
  
Hi, I'm the original poster of this patch to the redhat bugzilla. Where
it was closed summarily. However, I really thing adding support for
tarball extended attributes is increasingly valuable on selinux systems.

And star seems to be the best tool for the job. Are there other ways of
safely extracting files from a tarball with these extensions? I'm happy
to rebuild the patch against the mc cvs if there is positive feedback.

another reference:
http://cdrecord.berlios.de/old/private/star.html

  
  
Since star archives are esentially tar archives with extended information
I don't see why a extfs solution is necessary. We can just update the
tar code to support the required extension keywords. It's just a matter of
parsing a few strings.
  

Hrmm, maybe I'm over-thinking the problem, but according to this
http://cvs.fedora.redhat.com/viewcvs/devel/star/star-1.5-selinux.patch
it had to be compiled against the selinux headers. Is that an
appropriate direction for mc/vfs/tar.c?

../C


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [RFE] [PATCH] star vfs and xattr feature request

[Pavel Tsekov]

On Mon, 30 Jan 2006, Curtis Doty wrote:

> Hi, I'm the original poster of this patch to the redhat bugzilla. Where
> it was closed summarily. However, I really thing adding support for
> tarball extended attributes is increasingly valuable on selinux systems.
>
> And star seems to be the best tool for the job. Are there other ways of
> safely extracting files from a tarball with these extensions? I'm happy
> to rebuild the patch against the mc cvs if there is positive feedback.
>
> another reference:
> http://cdrecord.berlios.de/old/private/star.html

Since star archives are esentially tar archives with extended information
I don't see why a extfs solution is necessary. We can just update the
tar code to support the required extension keywords. It's just a matter of
parsing a few strings.

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [RFE] [PATCH] star vfs and xattr feature request

[Curtis Doty]

Jindrich Novy wrote:


Hello mc-devel,

Curtis Doty sent me a patch for star vfs support, where he says:
---
Here's a patch that attempts to add star filesystem support. Which is
fairly important IMHO now that Fedora is using selinux (or anything that
uses extended attributes).

Star also seems very forgiving; allowing the same view/extract command to work
across native archives or those compressed with various programs.

However, I couldn't get #utar to work so had to write the little #ustar script;
which is dog slow. So I'm hearby requesting a new feature: can the #utar extfs
be made to extract from starchives that contain selinux security descriptors?
---

references:
http://bugzilla.redhat.com/174918
http://www.nsa.gov/selinux/

Regards,
Jindrich 
 

Hi, I'm the original poster of this patch to the redhat bugzilla. Where 
it was closed summarily. However, I really thing adding support for 
tarball extended attributes is increasingly valuable on selinux systems.


And star seems to be the best tool for the job. Are there other ways of 
safely extracting files from a tarball with these extensions? I'm happy 
to rebuild the patch against the mc cvs if there is positive feedback.


another reference:
http://cdrecord.berlios.de/old/private/star.html

../C
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[Pavel Tsekov]

Follow-up Comment #2, bug #13500 (project mc):

Uhh, sorry. I've misread your report. Please, disregard comment #1. This
request is still valid.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #15057] Feature request, please add support for dar archives

[Roland Illig]

Update of bug #15057 (project mc):

Category:None => VFS


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[RFE] [PATCH] star vfs and xattr feature request

[Jindrich Novy]

Hello mc-devel,

Curtis Doty sent me a patch for star vfs support, where he says:
---
Here's a patch that attempts to add star filesystem support. Which is
fairly important IMHO now that Fedora is using selinux (or anything that
uses extended attributes).

Star also seems very forgiving; allowing the same view/extract command to work
across native archives or those compressed with various programs.

However, I couldn't get #utar to work so had to write the little #ustar script;
which is dog slow. So I'm hearby requesting a new feature: can the #utar extfs
be made to extract from starchives that contain selinux security descriptors?
---

references:
http://bugzilla.redhat.com/174918
http://www.nsa.gov/selinux/

Regards,
Jindrich 
-- 
Jindrich Novy <[EMAIL PROTECTED]>, http://people.redhat.com/jnovy/
(o_   _o)
//\  The worst evil in the world is refusal to think. //\
V_/_ _\_V

--- mc-4.6.1a/lib/mc.ext.in.star	2005-12-03 19:27:17.0 -0800
+++ mc-4.6.1a/lib/mc.ext.in	2005-12-03 19:28:22.0 -0800
@@ -134,6 +134,11 @@
 	Open=%cd %p#utar
 	View=%view{ascii} tar tvvf %f
 
+# star - standard archive
+regex/\.(star|STAR)(|\.(bz2|gz))$
+	Open=%cd %p#ustar
+	View=%view{ascii} star tvf %f 2>/dev/null
+
 # lha
 type/^LHa\ .*archive
 	Open=%cd %p#ulha
--- mc-4.6.1a/vfs/extfs/extfs.ini.star	2005-07-20 12:03:54.0 -0700
+++ mc-4.6.1a/vfs/extfs/extfs.ini	2005-12-03 19:29:35.0 -0800
@@ -54,3 +54,6 @@
 
 # ISO image
 iso9660
+
+# standard archive
+ustar
+++ mc-4.6.1a/vfs/extfs/ustar	2005-12-03 18:51:00.0 -0800
@@ -0,0 +1,29 @@
+#!/bin/sh
+
+mcstarfs_list() {
+	star -tv -f="$1" 2>/dev/null |awk '{
+		size = $1
+		perms = substr($2,1,10)
+		split($3,own,"/")
+		month = $4 ; day = $5 ; time = $6 ; year = $7
+		filename = substr($0, index($0,$8) )
+		printf "%s 1 %s %s %i %s %2i %i %s %s\n",
+			perms, own[1], own[2], size, month, day, year, time, filename
+	}'
+}
+
+mcstarfs_copyout() {
+	#star -no-statistics -f="$1" -x -to-stdout "$2" >"$3"
+	# grumble mumble...can't have stderr because we need
+	# leading / and turning it off with -/ doesn't work
+	star -f="$1" -x -to-stdout "$2" >"$3" 2>/dev/null
+}
+
+cmd="$1"
+shift
+case "$cmd" in
+	list)		mcstarfs_list "$@" ;;
+	copyout)	mcstarfs_copyout "$@" ;;
+	*)		exit 1 ;;
+esac
+exit 0
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #15057] Feature request, please add support for dar archives

[Martin Seifert]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15057>

 Summary: Feature request, please add support for dar
archives
 Project: GNU Midnight Commander
Submitted by: puntarenas
Submitted on: Fr 25.11.2005 um 05:39
Category: None
Severity: 3 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Release: 4.6.1
Platform Version: GNU/Linux

___

Details:

Disk ARchive from http://dar.linux.free.fr/ is a shell command that backs up
directory trees and files. I don`t know if it is possible to add support for
*.dar files, so one could "browse" them like it is already working for *.tar
archives.

Kind regards

Martin Seifert







___

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15057>

___
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Feature request: Changing colors

[Efim]

Hmm... First of all I'd like to say Hallo to all of MC developers.

Then I'd like to say THANK YOU VERY MUCH FOR THIS PROGRAM!!! I've been using MC 
for nearly 3 years
and I really like it.

But there is one feature, IMHO, MC must have. This feature is changing colors 
of text, panels and
of editor's screen and text. I wrote some things using Ncurses, so I can guess 
that it's possible
to add this feature. Of course, I don't know SLang at all, but I've seen 
sources of MC and
I saw that there are colors definitions. I don't ask you to write a 
configurator, it will be good
if you just add such a feature to MC config files...

So, thanks for reading my letter. I hope you'll add this feature in further 
releases. Thank you
again.

With a great respect to 
you, Efim A. Efim
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [bug #13500] Feature request: .. entry in directory hotlist subgroups

[Leonard den Ottolander]

Hi Pavel,

On Wed, 2005-06-22 at 15:31, Pavel Tsekov wrote:
> http://mail.gnome.org/archives/mc-devel/2005-April/msg00010.html
> 
> `..' was removed on purpose.

That was my first thought as well, but that is not what he is asking.

> P.S. It would be a good idea to login to Savannah before posting bugs.

That is definitely true. Could this be arranged with the Savannah
admins?

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[Pavel Tsekov]

Follow-up Comment #1, bug #13500 (project mc):

Please, read this and the links inside it.

http://mail.gnome.org/archives/mc-devel/2005-April/msg00010.html

`..' was removed on purpose.

P.S. It would be a good idea to login to Savannah before posting bugs.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13500] Feature request: .. entry in directory hotlist subgroups

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=13500>

 Summary: Feature request: .. entry in directory hotlist
subgroups
 Project: GNU Midnight Commander
Submitted by: None
Submitted on: Wed 06/22/2005 at 09:06
Category: None
Severity: 3 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Release: All versions
Platform Version: GNU/Linux

___

Details:

I'd like to suggest adding a .. entry at the top of every subgroup in the
directory hotlist. When hitting Enter over it, it should do what "Up" does ie.
take you one level up.

Reasons:
* It's more intuitive this way, because it would imitate directory
navigation.
* It's easier to use and remember. Home followed by Enter I suspect is a combo
used very often by most MC users. Meta+U, however, is more awkward.






___

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=13500>

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: File exists: duplicate key accel; and a feature request

[David Martin]

 Beware of this, please. If you change it now you may break translations.


 --- On Wed 06/08, wwp < [EMAIL PROTECTED] > wrote:
From: wwp [mailto: [EMAIL PROTECTED]
To: mc@gnome.org
Date: Wed, 8 Jun 2005 08:03:23 +0200
Subject: File exists: duplicate key accel; and a feature request

Hi there!I've noticed a long standing duplicate accel when mc asks if a copied filehas to override an already existing one.The dialog's title is: File existsThe questions: Overwrite this target ? Y N A   Overwrite all targets? A U N ISee how 'A' is twice possible.. but pressing A does the second one.BTW I would like to submit a feature request..When a file I/O error is encountered (several possible reasons as forinstance: not being able to set permissions when copying a file from ext2 tovfat, but it could be any read or write error), we get a Skip/Retry/Abortdialog. Would it be possible to add a [skip All] that would skip all furthererrors that match this one? That would be really user-friendly, IMO.Regards,-- wwp___Mc mailing listhttp://mail.gnome.org/mailman/listinfo/mcJoin 
Excite! - http://www.excite.comThe most personalized portal on the Web!
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[BARTHAZI Andras]

Hi!

> Could you please use "diff -u" for patches?  It can make them 
> less readable than the whole files, but at least it shows 
> what you are removing, not just what your are adding.  It's 
> important to see to make sure that you are not breaking 
> something unintentionally.
I understand it, but you can do it, too. The diff file, for editoptions
can be downloadable from:
http://www.wish.hu/editoptions.udiff
 
> In fact, I cannot apply your patch unless I know that you 
> have made it yourself, that you have looked at it, and you 
> are sure that you didn't make any unintended changes.  That's 
> not sufficient, but it's required. Nobody knows better than 
> you what changes were intentional.
What I still have to do, that I didn't? I'm sure that I made just safe
changes. I'm using the modified mc, and it works well, the changes I've
made I know and I understood. So, I'm sure it is OK at this moment.

> If you used GNU indent on this function, then please check 
> the flags - they are documented in doc/DEVEL.  And by the 
I just copied edit_move_to_line header, it has the same syntax. The
space is there in the snapshot version, too (and not just at these
routines, some other, too).

Bye,
  Andras


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[Pavel Roskin]

Hello!

Could you please use "diff -u" for patches?  It can make them less
readable than the whole files, but at least it shows what you are
removing, not just what your are adding.  It's important to see to make
sure that you are not breaking something unintentionally.

In fact, I cannot apply your patch unless I know that you have made it
yourself, that you have looked at it, and you are sure that you didn't
make any unintended changes.  That's not sufficient, but it's required.
Nobody knows better than you what changes were intentional.

> /* move cursor to column 'column' */
> void edit_move_to_column (WEdit * e, long column)

If you used GNU indent on this function, then please check the flags -
they are documented in doc/DEVEL.  And by the way, here's the patch for
GNU indent 2.2.8 that fixes the space between "*" and "e".  indent thinks
it's multiplication, not a function declaration.

===
--- src/indent.c
+++ src/indent.c
@@ -1039,7 +1039,7 @@ static exit_values_ty indent (
 }
 }

-parser_state_tos->want_blank = true;
+parser_state_tos->want_blank = !is_procname_definition;
 break;

 case postop:/* got a trailing ++ or -- */
===

-- 
Regards,
Pavel Roskin
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[BARTHAZI Andras]

Hello!

And a patch to my patch (there was a silly bug in this routine):

edit/edit.c

/* move cursor to column 'column' */
void edit_move_to_column (WEdit * e, long column)
{
edit_cursor_to_bol(e);
while (e->curs1curs1) && e->curs_colsearch_start = e->curs1;
e->prev_col = edit_get_col (e);
edit_scroll_screen_over_cursor (e);
}

Bye,
  Andras


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[BARTHAZI Andras]

Hi!

> I simplified editoptions.c, so make your patch against new
The modified version is available at the end of this letter.
Unfortunatly I was not able to compile the CVS version, but
copying this file to the snapshot version worked (I think
that the problem is that files are missing, but I don't
care :).

> patch itself. man patch should help you, take a look at -p option.
Thanks, I will use it.

> BTW, please send patches to mc-devel only.
OK.

Bye,
  Andras

(if attaching file this way won't work, I can make it downloadable
from the net)

/* editor options dialog box

   Copyright (C) 1996, 1997 the Free Software Foundation

   Authors: 1996, 1997 Paul Sheer

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 2 of the License, or
   (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program; if not, write to the Free Software
   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
   02111-1307, USA.
*/

#include 
#include "edit.h"
#include "src/wtools.h" /* QuickDialog */

#define OPT_DLG_H 17
#define OPT_DLG_W 72

#ifndef USE_INTERNAL_EDIT
#define USE_INTERNAL_EDIT 1
#endif

static char *key_emu_str[] =
{N_("Intuitive"), N_("Emacs"), NULL};

static char *wrap_str[] =
{N_("None"), N_("Dynamic paragraphing"), N_("Type writer wrap"), NULL};

static void
i18n_translate_array (char *array[])
{
while (*array!=NULL) {
*array = _(*array);
array++;
}
}

void edit_options_dialog (void)
{
char wrap_length[32], tab_spacing[32], *p, *q;
int wrap_mode = 0;
int tedit_key_emulation = edit_key_emulation;
int toption_fill_tabs_with_spaces = option_fill_tabs_with_spaces;
int toption_save_position = option_save_position;
int tedit_confirm_save = edit_confirm_save;
int tedit_syntax_highlighting = option_syntax_highlighting;
int toption_return_does_auto_indent =
option_return_does_auto_indent;
int toption_backspace_through_tabs = option_backspace_through_tabs;
int toption_fake_half_tabs = option_fake_half_tabs;

QuickWidget quick_widgets[] =
{
/*0 */
{quick_button, 6, 10, OPT_DLG_H - 3, OPT_DLG_H, N_("&Cancel"),
0, B_CANCEL, 0,
 0, NULL},
/*1 */
{quick_button, 2, 10, OPT_DLG_H - 3, OPT_DLG_H, N_("&OK"), 0,
B_ENTER, 0,
 0, NULL},
/*2 */
{quick_label, OPT_DLG_W / 2, OPT_DLG_W, OPT_DLG_H - 5,
OPT_DLG_H, N_("Word wrap line length : "), 0, 0,
 0, 0, NULL},
/*3 */
{quick_input, OPT_DLG_W / 2 + 24, OPT_DLG_W, OPT_DLG_H - 5,
OPT_DLG_H, "", OPT_DLG_W / 2 - 4 - 24, 0,
 0, 0, "edit-word-wrap"},
/*4 */
{quick_label, OPT_DLG_W / 2, OPT_DLG_W, OPT_DLG_H - 6,
OPT_DLG_H, N_("Tab spacing : "), 0, 0,
 0, 0, NULL},
/*5 */
{quick_input, OPT_DLG_W / 2 + 24, OPT_DLG_W, OPT_DLG_H - 6,
OPT_DLG_H, "", OPT_DLG_W / 2 - 4 - 24, 0,
 0, 0, "edit-tab-spacing"},
/*6 */
#ifdef HAVE_SYNTAXH
#define OA 1
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 8,
OPT_DLG_H, N_("synta&X highlighting"), 8, 0,
 0, 0, NULL},
#else
#define OA 0
#endif /* !HAVE_SYNTAXH */
/*6+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 9,
OPT_DLG_H, N_("save file &Position"), 0, 0,
 0, 0, NULL},
/*7+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 10,
OPT_DLG_H, N_("confir&M before saving"), 6, 0,
 0, 0, NULL},
/*8+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 11,
OPT_DLG_H, N_("fill tabs with &Spaces"), 0, 0,
 0, 0, NULL},
/*9+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 12,
OPT_DLG_H, N_("&Return does autoindent"), 0, 0,
 0, 0, NULL},
/*10+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 13,
OPT_DLG_H, N_("&Backspace through tabs"), 0, 0,
 0, 0, NULL},
/*11+OA */
{quick_checkbox, OPT_DLG_W / 2 + 1, OPT_DLG_W, OPT_DLG_H - 14,
OPT_DLG_H, N_("&Fake half tabs"), 0, 0,
 0, 0, NULL},
/*12+OA */
{quick_radio, 5, OPT_DLG_W, OPT_DLG_H - 7, OPT_DLG_H, "", 3, 0,
 0, wrap_str, "wrapm"},
/*13+OA */
{quick_label, 4, OPT_DLG_W, OPT_DLG_H - 8, OPT_DLG_H, N_("Wrap
mode"), 0, 0,
 0, 0, NULL},
/*14+OA */
{quick_radio, 5, OPT_DLG_W, OPT_DLG_H - 13, OPT_DLG_H, "", 2, 0,
   0, key_emu_str, "keyemu"},
/*15+OA */
{quick_label, 4, OPT_DLG_W, OPT_DLG_H - 14, OPT_DLG_H, N_("Key
emulation"), 0, 0,
 0, 0, NULL},
{0}};

static int i18n_flag = 0;
   
if (!i18n_flag) {
i18n_translate_array (k

RE: midnight bug - feature request

[BÁRTHÁZI András]

Hi!

> > Additionally I'm not familiar in developing and 
> distributing programs 
> > under Linux, so the downloadable version (the zip file) is all the 
> > files I got after a "make clean" command. Makefiles are 
> still exists. 
> > I think I should remove the
> 
> There is magic target "dist" for make in mc's Makefiles.  But make 
> distcheck is ever better :-)

Thanks a lot! :) It works... ;)

The distro package it created can be downloaded from
http://www.wish.hu/mc-2002-11-20-17-patched2.tar.gz
 
> > all and some other files, too, but I don't want to do it 
> one-by-one, 
> > and don't know the way to do it automagically.
> 
> Making patches is not too hard after reading man diff.  Unified diffs 
> are more welcomed among mc developers (diff -u).  Pavel Roskin 

Patches in unified diff format:
http://www.wish.hu/mc-2002-11-20-17-patched.udiff

> distribute usefull shell script called ldiff for making 
> patches. You need to backup files with some extention (say 
> orig) before you 
> change these ones, and after hacking you just need to run
> ldiff .orig > patchname.patch
> from mc source directory.  There are should not be symlinks in the 
> source tree because find -path ignores symlinked directories.

Sounds good. I'll do it this way next time. Where can I get ldiff?
Can you help me to find a program that can do patching using the patch
file?

Bye,
  Andras


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[BÁRTHÁZI András]

Hi, again!

> It will be fine if you upload patches somethere and give us 
> URLs. Your changes will be never commited to CVS until you 
> produce patches. It is not too hard to produce patches and it 
> saves a lot of time for developers because it is more clear 
> what is changed. On other hand I will never download too 
> tarballs just to see 
> differences. It will take some days to download over 33.6 
> Kbod modem. And don't use zip, please.  This one is not from 
> Unix world.
You are right, but I don't know the way to do patch files. Actually a
friend of me offered to make the patches.
 
> Anyway it is good to see new contributors here.  Go ahead, 
> and we will help.
:)

I've found a bug in my patches. The updated distribution can be
downloaded from:

http://www.wish.hu/mc-2002-11-20-17-patched.tar.gz

Here is a diff file, I don't know if it is usable, or not, I should tell
you again, I'm not familiar with creating patches, distributing
programs:

http://www.wish.hu/mc-2002-11-20-17-patched.diff

We will send a real patch version, too, as soon as possible.

Bye,
  Andras


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: midnight bug - feature request

[Andrew V. Samoilov]

BÁRTHÁZI András wrote:



Sounds good. I'll do it this way next time. Where can I get ldiff?


See http://cvs.gnome.org/lxr/source/mc/maint/ldiff?raw=1
I simplified editoptions.c, so make your patch against new version
(http://cvs.gnome.org/lxr/source/mc/edit/editoptions.c?raw=1, wait some 
hours, there is some lag between committing)

Can you help me to find a program that can do patching using the patch
file?


patch itself. man patch should help you, take a look at -p option.

BTW, please send patches to mc-devel only.

Good by till Monday.

--
Regards,
Andrew V. Samoilov



___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: midnight bug - feature request

[Andrew V. Samoilov]

BÁRTHÁZI András wrote:

Hi!



I've read in the archive, that somebody else has asked 


for position 

saving before. You told, that there's no really need for 


it. I don't 

think so: all the people I know using Midnight told me during our 
conversations, that it would be a good feature.


Max Schedriviy even proposed a patch. 
http://mail.gnome.org/archives/mc-devel/2001-July/msg3.html


I've made two patches:

bracket matching

the original version highlights just the matching bracket. my version
highlights both the current and matching brackets. additionally when you
are on the next character after a closing bracket, it works like if you
are on that bracket. i think it works great, and _very_ usable. bracket
jumping (Meta/Alt-B) is working the same way: if you are after a closing
bracket, it jumps to its matching opening bracket.

file position saving

the original version doesn't stores file position. my version, based on
Max Schedrivy's patch above, can save file positions for the last 1024
files edited. Max's version just stored file line, i improved it to
store column, too. file position saving can be turned on/off in the
editor's configuration, at the "General" options.

You can download my version from:
http://www.wish.hu/mc-2002-11-20-17-patched.zip

The version I've patched:
http://www.wish.hu/mc-2002-11-20-17.tar.gz

I'm not really tested them, I'm glad to get bug reports! I think no
problem can be with bracket matching, but position saving is more
difficult.

Warning, warning! :)) Actually it was my first adventure in the world of
C, these are my first usable lines in C, so please look my patches like
this (I'm normally programming in the wonderful Perl). Additionally I'm
not familiar in developing and distributing programs under Linux, so the
downloadable version (the zip file) is all the files I got after a "make
clean" command. Makefiles are still exists. I think I should remove the


There is magic target "dist" for make in mc's Makefiles.  But make 
distcheck is ever better :-)

all and some other files, too, but I don't want to do it one-by-one, and
don't know the way to do it automagically.


Making patches is not too hard after reading man diff.  Unified diffs 
are more welcomed among mc developers (diff -u).  Pavel Roskin 
distribute usefull shell script called ldiff for making patches.
You need to backup files with some extention (say orig) before you 
change these ones, and after hacking you just need to run
ldiff .orig > patchname.patch
from mc source directory.  There are should not be symlinks in the 
source tree because find -path ignores symlinked directories.

Good luck.

--
Regards,
Andrew V. Samoilov



___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: midnight bug - feature request

[Andrew V. Samoilov]

BÁRTHÁZI András wrote:

Hi!



I've read in the archive, that somebody else has asked 


for position 

saving before. You told, that there's no really need for 


it. I don't 

think so: all the people I know using Midnight told me during our 
conversations, that it would be a good feature.


Max Schedriviy even proposed a patch. 
http://mail.gnome.org/archives/mc-devel/2001-July/msg3.html


I've made two patches:

bracket matching

the original version highlights just the matching bracket. my version
highlights both the current and matching brackets. additionally when you
are on the next character after a closing bracket, it works like if you
are on that bracket. i think it works great, and _very_ usable. bracket
jumping (Meta/Alt-B) is working the same way: if you are after a closing
bracket, it jumps to its matching opening bracket.

file position saving

the original version doesn't stores file position. my version, based on
Max Schedrivy's patch above, can save file positions for the last 1024
files edited. Max's version just stored file line, i improved it to
store column, too. file position saving can be turned on/off in the
editor's configuration, at the "General" options.

You can download my version from:
http://www.wish.hu/mc-2002-11-20-17-patched.zip

The version I've patched:
http://www.wish.hu/mc-2002-11-20-17.tar.gz



It will be fine if you upload patches somethere and give us URLs.
Your changes will be never commited to CVS until you produce patches.
It is not too hard to produce patches and it saves a lot of time for
developers because it is more clear what is changed.
On other hand I will never download too tarballs just to see 
differences. It will take some days to download over 33.6 Kbod modem.
And don't use zip, please.  This one is not from Unix world.

Anyway it is good to see new contributors here.  Go ahead, and we will help.

--
Regards,
Andrew V. Samoilov



___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

RE: midnight bug - feature request

[BÁRTHÁZI András]

Hi!

> I've read in the archive, that somebody else has asked 
> for position 
> saving before. You told, that there's no really need for 
> it. I don't 
> think so: all the people I know using Midnight told me during our 
> conversations, that it would be a good feature.
> >>>
> 
> Max Schedriviy even proposed a patch. 
> http://mail.gnome.org/archives/mc-devel/2001-July/msg3.html

I've made two patches:

bracket matching

the original version highlights just the matching bracket. my version
highlights both the current and matching brackets. additionally when you
are on the next character after a closing bracket, it works like if you
are on that bracket. i think it works great, and _very_ usable. bracket
jumping (Meta/Alt-B) is working the same way: if you are after a closing
bracket, it jumps to its matching opening bracket.

file position saving

the original version doesn't stores file position. my version, based on
Max Schedrivy's patch above, can save file positions for the last 1024
files edited. Max's version just stored file line, i improved it to
store column, too. file position saving can be turned on/off in the
editor's configuration, at the "General" options.

You can download my version from:
http://www.wish.hu/mc-2002-11-20-17-patched.zip

The version I've patched:
http://www.wish.hu/mc-2002-11-20-17.tar.gz

I'm not really tested them, I'm glad to get bug reports! I think no
problem can be with bracket matching, but position saving is more
difficult.

Warning, warning! :)) Actually it was my first adventure in the world of
C, these are my first usable lines in C, so please look my patches like
this (I'm normally programming in the wonderful Perl). Additionally I'm
not familiar in developing and distributing programs under Linux, so the
downloadable version (the zip file) is all the files I got after a "make
clean" command. Makefiles are still exists. I think I should remove the
all and some other files, too, but I don't want to do it one-by-one, and
don't know the way to do it automagically.

If somebody can make a patch file from the above, or can make a diff, I
think these patches can be useful for other users, too.

Have fun with them! (If you find useful my patches, please, please tell
me. :)

I'm not on the devel list, just the mc@, so please send me a copy mails
on that list about this thread - thanks.

Bye,
  Andras


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Feature request

[Pavel Roskin]

Hello!

> Pressing "Alt+a" in a directory that has space(s) in its name copies
> the space(s) to the cmd line without quoting.
> "Alt+Enter", on the other hand, does the right thing: it copies spaces
> as "\ " to the cmd line.
> 
> Could the behavior of the "Alt+a" thing be changed so that it also
> quotes the spaces?

Fixed.  Thank you!

-- 
Regards,
Pavel Roskin

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Feature request

[Arpad Biro]

Hi,

Pressing "Alt+a" in a directory that has space(s) in its name copies
the space(s) to the cmd line without quoting.
"Alt+Enter", on the other hand, does the right thing: it copies spaces
as "\ " to the cmd line.

Could the behavior of the "Alt+a" thing be changed so that it also
quotes the spaces?


Arpad Biro


__
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Feature Request for mc

[Pavel Roskin]

Hello!

> I was wondering why not add sftp support to Midnight
> Commander... Using the cli based sftp tool to upload
> stuff on SourceForge sometimes is a pain process ;-))

Please add this feature it to GNOME VFS.  VFS in MC is unsecure by design
and should be replaced with GNOME VFS as soon as the later is ready.  
There is no point in improving the code that is going to be removed.  

Search on www.google.com for "GNOME VFS"

-- 
Regards,
Pavel Roskin

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Feature Request for mc

[The Clock]

Hi All!

I was wondering why not add sftp support to Midnight
Commander... Using the cli based sftp tool to upload
stuff on SourceForge sometimes is a pain process ;-))

Thanks for your time.

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: feature request: delete after copy

[Andrew V. Samoilov]

Hello!

On Sun, Dec 09, 2001 at 10:20:15AM +0100, Klaus Ridder wrote:
> I have the following problem with mc
> 
> I have to move a lot of data to a filesystem which is remotely mounted by
> smb through a ssh tunnel.
> The problem is, that I cannot chown, so I am not able to use the "move"
> command of midnight commander, but "copy" insted (with switching off
> "preserve attributes".
> However, one copy session can take some hours or even days, and it would be
> great if mc really could remove sigle files as soon as they are transfered
> (as move does).
> 
> So I suggest to either
> - implement the option "preserve attributes" also to the mv option
> - implement an option "delete each file after successfully copied" to the
> copy dialogue.
> 
> It would be one of thos could be implemented.
> Is there probably a workaround for me at the current time?
> 

Can you test patch below?

Regards,
Andrew.

ChangeLog:
* filegui.c (file_mask_dialog): Enable "preserve Attributes"
and "follow Links" features in Move dialog.

Index: filegui.c
===
RCS file: /cvs/gnome/mc/src/filegui.c,v
retrieving revision 1.21
diff -u -p -u -p -r1.21 filegui.c
--- filegui.c   2002/01/21 20:47:06 1.21
+++ filegui.c   2002/01/30 10:59:28
@@ -906,11 +908,10 @@ file_mask_dialog (FileOpContext *ctx, Fi
 
 if (operation == OP_COPY) {
Quick_input.class = "quick_file_mask_copy";
-   Quick_input.widgets = fmd_widgets;
 } else { /* operation == OP_MOVE */
Quick_input.class = "quick_file_mask_move";
-   Quick_input.widgets = fmd_widgets + 2;
 }
+Quick_input.widgets = fmd_widgets;
 fmd_widgets [FMDI0].text = text;
 fmd_widgets [FMDI2].text = def_text;
 fmd_widgets [FMDI2].str_result = &dest_dir;
@@ -922,12 +923,12 @@ ask_file_mask:
 if ((val = quick_dialog_skip (&Quick_input, SKIP)) == B_CANCEL)
return 0;
 
-if (ctx->follow_links && operation != OP_MOVE)
+if (ctx->follow_links)
ctx->stat_func = (mc_stat_fn) mc_stat;
 else
ctx->stat_func = (mc_stat_fn) mc_lstat;
 
-if (ctx->op_preserve || operation == OP_MOVE) {
+if (ctx->op_preserve) {
ctx->preserve = 1;
ctx->umask_kill = 077;
ctx->preserve_uidgid = (geteuid () == 0) ? 1 : 0;
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: feature request: delete after copy

[Pavel Roskin]

Hi, Klaus!

> I have to move a lot of data to a filesystem which is remotely mounted by
> smb through a ssh tunnel.
> The problem is, that I cannot chown, so I am not able to use the "move"
> command of midnight commander, but "copy" insted (with switching off
> "preserve attributes".

Even if you cannot chown you should be able to use the "move" command.  
That's the problem that needs to be fixed.  If you can reproduce it with
the latest version of mc please report it as a bug and give more
information.

> However, one copy session can take some hours or even days, and it would be
> great if mc really could remove sigle files as soon as they are transfered
> (as move does).
> 
> Is there probably a workaround for me at the current time?

You should use a script.  MC is an interactive program.  It's not the best 
choice for the operations that take days to complete.

-- 
Regards,
Pavel Roskin

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel

feature request: delete after copy

[Klaus Ridder]

I have the following problem with mc

I have to move a lot of data to a filesystem which is remotely mounted by
smb through a ssh tunnel.
The problem is, that I cannot chown, so I am not able to use the "move"
command of midnight commander, but "copy" insted (with switching off
"preserve attributes".
However, one copy session can take some hours or even days, and it would be
great if mc really could remove sigle files as soon as they are transfered
(as move does).

So I suggest to either
- implement the option "preserve attributes" also to the mv option
- implement an option "delete each file after successfully copied" to the
copy dialogue.

It would be one of thos could be implemented.
Is there probably a workaround for me at the current time?

Please sende me a "cc" on replies, as I am not subscribed on the
mailinglist.
Thank you very much!

Regards,
Klaus Ridder

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel