Re: Highlighting trailing spaces

2003-02-06 Thread Vlad Romanenko
 On Wed, 05 Feb 2003, Pavel Roskin wrote:
 
  On Sun, 2 Feb 2003 03:34:10 +0100 Arpi [EMAIL PROTECTED] wrote:
 
   Btw, the Makefile syntax ruleset also contains an ugly part,
showing TABs
   with bright red backround. It's even worse, as TABs are correct
there.
 
  I like it - I don't forget to add TABs when adding new lines to
Makefiles the
  Maybe it should be made less ugly?
 
 I tried but could not find any better color.

What about black? I found it better then bright red.

Vlad Romanenko.
--
Ukrainian Postnuke translator
http://uanuke.sourceforge.net/

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel



RE: Highlighting trailing spaces

2003-02-02 Thread BÁRTHÁZI András
Hi!

 new (ok new for me:)) mcedig shows DOS newlines with ^M on 
 black backround. it's 1. looks ugly 2. messes with column 
 number, it's 1 char in file but it shift column by 2
   (ok it's rare to have ^M in the middle of a line)
 imho:
I like this feature. Some of my files are very ugly because I both
edited under DOS and under Lx, and some ^M are in the middle of the
line. Before this feature I didn't realized it, nothing was showed, and
Perl was not like it. After I'm able to see it, i can fix it easily
(see later).

 1. it should be made optional
Anyway, I agee.

 2. it should be 1 char wide, is show only 'M' on black background
   (and same for other 32 control codes)
It seem's to be a good idea.

 3. mcedit should support editing files with CR+LF newlines
   (so pressing ENTER should insert not only #10, but #13 too, 
 and should
hide ^M's, handle them as part of the newline code)
It's OK and a good feature, but please don't hide them when they're in
the middle of the line... :) MC did it, and I didn't realized where are
they, what's the problem.
 
And a question. Is there any way I can search'n'replace the ^M
characters with nothing in my code? I didn't found the way for it, and
it's not a good game to do it by hand. I know I know that I can write a
program for it, but I think the answer shouldn't be this.

Bye,
  Andras

-
 (@) WiSH iNTERNET Consulting | www.wish.hu


___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel



Re: Highlighting trailing spaces

2003-02-02 Thread Nerijus Baliunas
On Sun, 2 Feb 2003 03:34:10 +0100 Arpi [EMAIL PROTECTED] wrote:

 Btw, the Makefile syntax ruleset also contains an ugly part, showing TABs
 with bright red backround. It's even worse, as TABs are correct there.

I like it - I don't forget to add TABs when adding new lines to Makefiles then.
Maybe it should be made less ugly?

Regards,
Nerijus

___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel



Highlighting trailing spaces

2003-01-31 Thread Pavel Roskin
Hello, Andrew!

I have noticed that you added highlighting for trailing spaces in C.  I
believe that your patch should be reverted, at least for the 4.6.0
release.  I don't want to see it reported like a bug.

Some people (myself included) use the internal editor to read other
people's code.  I don't want to fix minor sloppiness in the code I didn't
write.  Highlighting for trailing spaces reduces readability of the code.
If my job is to fix a bug and submit a minimal patch to the author, the
red tails will distract me from my job.

From the mcedit manual:

   Also remember that the aim of syntax highlighting is to make
   programming less prone to error, not to make code look pretty.

I would also add not to enforce formatting rules.  It's annoying and
should be applied only to the person who is fully in control of the code.
mcedit just cannot do it.

That's my opinion, but I'd like to hear from other developers.  I'm
leaving the patch in CVS for now, but I'll remove it before the release
unless somebody comes with serious arguments in favor of keeping it.

-- 
Regards,
Pavel Roskin
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel