Re: Midnight Commander 4.8.19 released
On Sun, 05 Mar 2017 16:26:54 +0100 "Yury V. Zaytsev"wrote: > Hi, > > I'm glad to announce the immediate availability of mc-4.8.19! [ Using correct source address this time ] Yay! Looks like a set of vfs shell helpers were added in here. When running 'make check' I have single extfs test failure: # FAIL: 1 See tests/src/vfs/extfs/helpers-list/test-suite.log [ attached ] The log file is missing actual diff. I suggest adding diff output inline to ease bug reporting. Most of test don't like tool versions (or flavours?) I have: Diffing manually: > /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/rpm.custom.output > /tmp/rpm.actual-parsed-output.A09GDxro differ: char 42, line 1 1. rpm: $ diff -U0 /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/rpm.custom.output /tmp/rpm.actual-parsed-output.A09GDxro --- /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/rpm.custom.output 2017-01-22 16:42:40.730438199 + +++ /tmp/rpm.actual-parsed-output.A09GDxro 2017-03-05 23:14:49.741128300 + @@ -1 +1 @@ --r--r--r-- 100539 2017-01-05 00:00:00 HEADER +-r--r--r-- 100597 2017-01-05 00:00:00 HEADER @@ -15,0 +16 @@ +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/SUMMARY @@ -30,0 +32,7 @@ +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/PACKAGER +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/URL +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/EPOCH +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/LICENSE +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/REQUIRES +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/OBSOLETES +-r--r--r-- 100 0 2017-01-05 00:00:00 INFO/PROVIDES I don't have 'rpm' installed but I have 'rpm2targz'. But not sure from the output which tool was actually used. > /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/u7z.complex.output > /tmp/u7z.actual-parsed-output.DTg79ID0 differ: char 38, line 1 2. u7z $ diff -U0 /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/u7z.complex.output /tmp/u7z.actual-parsed-output.DTg79ID0 --- /home/slyfox/dev/git/mc/tests/src/vfs/extfs/helpers-list/data/u7z.complex.output 2017-01-22 16:42:40.731438194 + +++ /tmp/u7z.actual-parsed-output.DTg79ID0 2017-03-05 23:14:49.822129852 + @@ -1,7 +1,6 @@ --rw-r--r-- 1 <> <> 469920 2011-11-03 02:33:04 cpuidsdk64.dll --rw-r--r-- 1 <> <> 445814 2011-11-03 02:33:04 cpuidsdk.dll --rw-r--r-- 1 <> <>1178084 2011-11-03 02:33:04 Geekbench22.exe --rw-r--r-- 1 <> <> 101652 2011-11-03 02:33:04 geekbench.exe --rw-r--r-- 1 <> <> 737580 2011-11-03 02:33:04 geekbench.plar --rw-r--r-- 1 <> <>1058731 2011-11-03 02:33:06 geekbench_x86_32.exe --rw-r--r-- 1 <> <>1192155 2011-11-03 02:33:06 geekbench_x86_64.exe +-rw-r--r-- 1 <> <> 6144 2007-07-07 07:07:07 $PLUGINSDIR/AdvSplash.dll +-rw-r--r-- 1 <> <> 8005 2007-07-07 07:07:07 $PLUGINSDIR/InstallOptions.dll +-rw-r--r-- 1 <> <> 3328 2007-07-07 07:07:07 $PLUGINSDIR/StartMenu.dll +-rw-r--r-- 1 <> <>134 2007-11-15 01:12:38 $PLUGINSDIR/ioSpecial.ini +-rw-r--r-- 1 <> <> 1886 2003-09-24 00:34:00 $PLUGINSDIR/modern-wizard.bmp +-rw-r--r-- 1 <> <> 28016 2006-08-11 23:49:28 $PLUGINSDIR/splash.bmp @@ -12 +10,0 @@ --rw-r--r-- 1 <> <> 9854 2011-11-03 02:23:16 $_OUTDIR/html/ui/heading-bg.gif @@ -13,0 +12 @@ +-rw-r--r-- 1 <> <> 9854 2011-11-03 02:23:16 $_OUTDIR/html/ui/heading-bg.gif @@ -16 +14,0 @@ --rw-r--r-- 1 <> <> 1425 2011-11-03 02:23:16 $_OUTDIR/html/ui/nav-arrows-bg.gif @@ -18 +16 @@ --rw-r--r-- 1 <> <> 2885 2011-11-03 02:23:16 $_OUTDIR/html/ui/table-wrapper-bg-repeat.gif +-rw-r--r-- 1 <> <> 1425 2011-11-03 02:23:16 $_OUTDIR/html/ui/nav-arrows-bg.gif @@ -19,0 +18 @@ +-rw-r--r-- 1 <> <> 2885 2011-11-03 02:23:16 $_OUTDIR/html/ui/table-wrapper-bg-repeat.gif @@ -21,6 +20,7 @@ --rw-r--r-- 1 <> <> 6144 2007-07-07 07:07:07 $PLUGINSDIR/AdvSplash.dll --rw-r--r-- 1 <> <> 8005 2007-07-07 07:07:07 $PLUGINSDIR/InstallOptions.dll --rw-r--r-- 1 <> <>134 2007-11-15 01:12:38 $PLUGINSDIR/ioSpecial.ini --rw-r--r-- 1 <> <> 1886 2003-09-24 00:34:00 $PLUGINSDIR/modern-wizard.bmp --rw-r--r-- 1 <> <> 28016 2006-08-11 23:49:28 $PLUGINSDIR/splash.bmp --rw-r--r-- 1 <> <> 3328 2007-07-07 07:07:07 $PLUGINSDIR/StartMenu.dll +-rw-r--r-- 1 <> <>1178084 2011-11-03 02:33:04 Geekbench22.exe +-rw-r--r-- 1 <> <> 445814 2011-11-03 02:33:04 cpuidsdk.dll +-rw-r--r-- 1 <> <> 469920 2011-11-03 02:33:04
Re: Midnight Commander 4.8.19 released
On Mon, 6 Mar 2017 07:24:38 +0100 (CET) "Yury V. Zaytsev"wrote: > One thing is clear though, something's gone wrong here, could you please > be so kind to create a ticket? Thanks! Sure. Filed http://midnight-commander.org/ticket/3781 -- Sergei pgp5KArhda1Tz.pgp Description: Цифровая подпись OpenPGP ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Midnight Commander 4.8.19 released
Hi, On Sun, 5 Mar 2017, Sergei Trofimovich wrote: Yay! Looks like a set of vfs shell helpers were added in here. If I remember correctly, no new helpers, but many existing helpers turned out to be broken and were fixed after the test suite was introduced. When running 'make check' I have single extfs test failure: # FAIL: 1 See tests/src/vfs/extfs/helpers-list/test-suite.log Thanks, we'll have a look. The log file is missing actual diff. I suggest adding diff output inline to ease bug reporting. Might be a good idea, I thought the diff was generated in the temporary directory, but apparently, this is not the case. And a few others. These tests look fragile. That's very curious, because the tests shouldn't be actually using the tools themselves, but they should rather be only checking whether the extfs scripts are still able to parse pre-recorded output of the tools. Therefore, I would hope that it's not version drift of the tools, but rather coreutils / awk / ... whatever the scripts depend upon to parse pre-recorded output, and as such you have identified a valid problem with parsing not being robust enough / working differently with newer coreutils / awk / etc. Or else, in your case, real output is used instead of mocked stuff, which would be truly bizarre, but would also point to a valid problem with the test suite. One thing is clear though, something's gone wrong here, could you please be so kind to create a ticket? Thanks! -- Sincerely yours, Yury V. Zaytsev ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: Midnight Commander 4.8.19 released
Le dimanche 05 mars 2017 à 16:26 +0100, Yury V. Zaytsev a écrit : > Hi, > > I'm glad to announce the immediate availability of mc-4.8.19! > > This is a maintenance release which includes many bugfixes and > several > new exciting features, the most notable of which are support for True > Color capable terminals (and first skins!) contributed by Egmont > Koblinger and support for timestamps with nanosecond precision on > Linux > contributed by Andrey Gursky. > > For the detailed list of changes since the last release, please refer > to > the release notes. > > Download page: http://ftp.midnight-commander.org/?C=N;O=D > Release notes: http://www.midnight-commander.org/wiki/NEWS-4.8.19 > > Traditionally, big thanks goes to our hero committer Andrew Borodin, > as > well as our regular contributors Mooffie, Andreas Mohr and others, > including our translators. > > This time I have the particular pleasure to welcome Mooffie of the > friendly mc^2 fork's fame as our new committer, and note how he has > already delivered many valuable additions to mc for this release, > including an actual test suite for the extfs helpers! > > As always, we hope to accept more patches for the next version, with > many waiting for reviews and tests, of which we sadly have way too > few, > but our resources are constrained as ever, so bear with us. > > Having that said, we in full choir hail thy approach, O Spring! > > ___ > mc mailing list > https://mail.gnome.org/mailman/listinfo/mc Hi Yuri, all. First, thanks to all of you for that release. I’ve updated « my » packages on OpenSuSe Build Service to 4.8.19 for the following distros: CentOS and Scientific Linux 6 i586 and x86_64. CentOS and Scientific Linux 7 x86_64. Fedora 24, 25, i586 and x86_64. I’ve used official tar.xz package, and mc was built with the following options: --with-screen=slang \ --enable-charset \ --with-x \ --with-gpm-mouse \ --disable-rpath \ --enable-vfs-smb \ --enable-vfs-sftp \ --enable-aspell You can get packages here: https://build.opensuse.org/package/repositories/home:laurentwandrebeck: mc/mc Thanks, -- Laurent Wandrebeck___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Midnight Commander 4.8.19 released
Hi, I'm glad to announce the immediate availability of mc-4.8.19! This is a maintenance release which includes many bugfixes and several new exciting features, the most notable of which are support for True Color capable terminals (and first skins!) contributed by Egmont Koblinger and support for timestamps with nanosecond precision on Linux contributed by Andrey Gursky. For the detailed list of changes since the last release, please refer to the release notes. Download page: http://ftp.midnight-commander.org/?C=N;O=D Release notes: http://www.midnight-commander.org/wiki/NEWS-4.8.19 Traditionally, big thanks goes to our hero committer Andrew Borodin, as well as our regular contributors Mooffie, Andreas Mohr and others, including our translators. This time I have the particular pleasure to welcome Mooffie of the friendly mc^2 fork's fame as our new committer, and note how he has already delivered many valuable additions to mc for this release, including an actual test suite for the extfs helpers! As always, we hope to accept more patches for the next version, with many waiting for reviews and tests, of which we sadly have way too few, but our resources are constrained as ever, so bear with us. Having that said, we in full choir hail thy approach, O Spring! -- Sincerely yours, Yury V. Zaytsev signature.asc Description: This is a digitally signed message part ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel