Re: Issues with recent utf8 patch
On Thu, 22 Nov 2007, Rafa?~B Mu??y?~Bo wrote: It seems that the problem comes from the way ncurses move() works. If I understand it correctly, if move range is outside (0..screen width) / (0..screen height) it moves to the previous/next column/line. When I changed If the move is outside the screen, wmove() returns an error and does not move at all... terminal size to 80x20, I got some really silly results when I've gone up and down File menu several times. Slang variant at least paints it correctly, though if menu is longer than the term, you can select an option you don't see. Of course, I don't now pretty much anything about ncurses, but some bounds checking (no move() outside screen) might help. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Issues with recent utf8 patch
It seems that the problem comes from the way ncurses move() works. If I understand it correctly, if move range is outside (0..screen width) / (0..screen height) it moves to the previous/next column/line. When I changed terminal size to 80x20, I got some really silly results when I've gone up and down File menu several times. Slang variant at least paints it correctly, though if menu is longer than the term, you can select an option you don't see. Of course, I don't now pretty much anything about ncurses, but some bounds checking (no move() outside screen) might help. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Issues with recent utf8 patch
A surprise: dialogbox issue is NOT patch related, it comes from original mc code. In src/dialog.c in draw_box(Dlg_head *h, int y, int x, int ys, int xs) lies the problem. If slang is used a box is drawn, otherwise code is used that in most cases works correctly. It fails, however if box drawn is bigger than the terminal. It's hard to notice, cause most dialogs fit the screen. In 80x24 term this can be noticed in File menu, its two last rows are repainted at the top o the screen, second to last is covered by menubar, last is mostly covered by File menu, so only its corners are visible on the same line as the top of File menu box. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Issues with recent utf8 patch
On Wed, 21 Nov 2007 12:30:30 +0100, Rafał Mużyło <[EMAIL PROTECTED]> wrote: > I decided to give those patches a try and they mostly work. > As it's the first (known to me) release that should work with ncursesw I > tested only that (cause fc slang patches work for me after a simple > correction - they have a problem with double-width chars). > Following issues were found: > 1. MC_WITH_NCURSESW is incorrect > If it was a simple copy/paste it would probably work, > however it's not. AC_CHECK_LIB and AC_SEARCH_LIBS differ in a very > important point. AC_SEARCH_LIBS always sets LIBS var with found libs, > AC_CHECK_LIB does that only if no other action is named. As such checks > for ESCDELAY and resizeterm work in MC_WITH_NCURSES but always fail in > MC_WITH_NCURSESW. I have thought that I could made MC_WITH_NCURSESW simpler than MC_WITH_NCURSES. Wrong decision. Now I use copy/paste method and hope it will work better. But someone experienced in configuration scripts shall check it. > 2. src/strutilutf8.c has #include > This include is unneeded and breaks compile if slang is not found. removed. > 3. Options/Configuration dialog > Most of the dialogs I managed to check seem fine, this one is, however, > broken. > (May be important LANG=pl_PL.UTF-8) If I have understand to the second email well, there is/was a difference between ncursesw and slang version of the configuration dialog? On my system seems to be same both. all three tarballs actualized. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Issues with recent utf8 patch
On Wed, 21 Nov 2007 13:48:26 +0100, Rafał Mużyło <[EMAIL PROTECTED]> wrote: > First, I appologize: I missed the post stating that editor is not > working. I decided to check slang, too. > New issue: > a strange crash (screen type independant) > I searched for 'enable-charset' in mc sources. Several results were > found. I chose one and pressed F3. mc ran out of memory and was killed > by the system. > And configuration dialog displays fine with slang. > ___ > Mc-devel mailing list > http://mail.gnome.org/mailman/listinfo/mc-devel View built cache incorrectly, when view->data_area.width was set to zero. This was not a problem until view_load tried to set start position (need cache) before first call of view_compute_areas (set view->data_area.width). I have solved it and I have added additional call of view_compute_areas into view_load, too (it is not necessary, but it is better). patches will be updated in hour or two. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: Issues with recent utf8 patch
First, I appologize: I missed the post stating that editor is not working. I decided to check slang, too. New issue: a strange crash (screen type independant) I searched for 'enable-charset' in mc sources. Several results were found. I chose one and pressed F3. mc ran out of memory and was killed by the system. And configuration dialog displays fine with slang. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
