Re: file timestamps not preserved
On Sat, 6 May 2017, Nerijus Baliunas wrote: On Fri, 5 May 2017 23:31:50 +0200 Andrey Gurskywrote: I've downloaded the original mc 4.8.19 release, applied the patches, run autoreconf, then configure, make install and it works for me. Have you tested with the file you've sent me? If yes, I'm curious what could be else different?.. BTW, if I call autoconf instead of autoreconf, I cannot see anything happens. With autoreconf instead of autoconf it is OK. Thanks. You have to use ./autogen.sh to bootstrap the build system. -- Sincerely yours, Yury V. Zaytsev ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Fri, 5 May 2017 23:31:50 +0200 Andrey Gurskywrote: > I've downloaded the original mc 4.8.19 release, applied the patches, > run autoreconf, then configure, make install and it works for me. Have > you tested with the file you've sent me? If yes, I'm curious what could > be else different?.. > > BTW, if I call autoconf instead of autoreconf, I cannot see anything > happens. With autoreconf instead of autoconf it is OK. Thanks. Regards, Nerijus ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Fri, 5 May 2017 22:20:56 +0300 Nerijus Baliunas wrote: > And one more bug report with zip/rar files: if I copy files only, > their timestamps are OK, but if I copy directories, timestamps > of files inside of them are lost. Nerijus, thanks for the report. I can reproduce this (at least with zip) and will look into. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
Hi Nerijus, On Fri, 5 May 2017 17:43:34 +0300 Nerijus Baliunas wrote: > On Wed, 19 Apr 2017 01:36:49 +0200 Andrey Gursky> wrote: > > > I received the file and was able to reproduce the issue. > > I applied both patches to 4.8.19: > [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present > [PATCH] Remove unused check in configure.ac > > Ran autoconf. Just FYI, configure output before patches: > checking for uid_t in sys/types.h... yes > checking for struct stat.st_blocks... yes > checking for struct stat.st_blksize... yes > checking for struct stat.st_rdev... yes > checking sys/param.h usability... yes > > after the patches: > checking for uid_t in sys/types.h... yes > checking for struct stat.st_blksize... yes > checking for struct stat.st_rdev... yes > checking for struct stat.st_mtim... yes > checking sys/param.h usability... yes > > But still the files copied from cpio or tar.gz do not preserve timestamps. The configure output seems to be good. I've downloaded the original mc 4.8.19 release, applied the patches, run autoreconf, then configure, make install and it works for me. Have you tested with the file you've sent me? If yes, I'm curious what could be else different?.. BTW, if I call autoconf instead of autoreconf, I cannot see anything happens. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
And one more bug report with zip/rar files: if I copy files only, their timestamps are OK, but if I copy directories, timestamps of files inside of them are lost. ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Wed, 19 Apr 2017 01:36:49 +0200 Andrey Gurskywrote: > I received the file and was able to reproduce the issue. I applied both patches to 4.8.19: [PATCH] Initialize struct stat st_[acm]tim.tv_nsec when present [PATCH] Remove unused check in configure.ac Ran autoconf. Just FYI, configure output before patches: checking for uid_t in sys/types.h... yes checking for struct stat.st_blocks... yes checking for struct stat.st_blksize... yes checking for struct stat.st_rdev... yes checking sys/param.h usability... yes after the patches: checking for uid_t in sys/types.h... yes checking for struct stat.st_blksize... yes checking for struct stat.st_rdev... yes checking for struct stat.st_mtim... yes checking sys/param.h usability... yes But still the files copied from cpio or tar.gz do not preserve timestamps. Regards, Nerijus ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Tue, 18 Apr 2017 17:06:57 +0200 Andrey Gursky wrote: > On Tue, 18 Apr 2017 15:55:58 +0200 Andrey Gursky wrote: > > > On Tue, 18 Apr 2017 16:30:36 +0300 Nerijus Baliūnas wrote: > > > > > 2017-04-18 16:09, Andrey Gursky rašė: > > > > Hi Nerijus, > > > > > > > > On Tue, 18 Apr 2017 15:33:50 +0300 Nerijus Baliunas wrote: > > > > > > > >> Hello, > > > >> > > > >> mc 4.8.19 does not preserve timestamps of files, if they are copied > > > >> from > > > >> tar.gz, cpio > > > >> archives. But copying from zip is OK. > > > > > > > > I've built now mc (git master) on Debian testing, entered a tar.gz > > > > archive and copied a file on ext4 fs. The timestamp of the extracted > > > > file was OK. > > > > > > > > For me more info for reproducing would be needed. > > > > > > It's latest Fedora package. It is pure mc-4.8.19.tar.xz with one minor > > > patch: > > > -#define TMPDIR_DEFAULT "/tmp" > > > +#define TMPDIR_DEFAULT "/var/tmp" > > > > > > Build flags are: > > > %configure \ > > > CFLAGS="%{optflags} -Wno-strict-aliasing" \ > > > --disable-rpath \ > > > --enable-aspell \ > > > --enable-charset \ > > > --enable-largefile \ > > > --enable-vfs-cpio \ > > > --enable-vfs-extfs \ > > > --enable-vfs-fish \ > > > --enable-vfs-ftp \ > > > --enable-vfs-sfs \ > > > --enable-vfs-sftp \ > > > --enable-vfs-smb \ > > > --enable-vfs-tar \ > > > --without-x \ > > > --with-gpm-mouse \ > > > --with-screen=ncurses \ > > > %{nil} > > > > I've tested also cpio and for it I can confirm the issue. > > I'll propose a patch for this (hopefully shortly). > > For tar.gz I'd need a preferably small sample file. I received the file and was able to reproduce the issue. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Tue, 18 Apr 2017 15:55:58 +0200 Andrey Gursky wrote: > On Tue, 18 Apr 2017 16:30:36 +0300 Nerijus Baliūnas wrote: > > > 2017-04-18 16:09, Andrey Gursky rašė: > > > Hi Nerijus, > > > > > > On Tue, 18 Apr 2017 15:33:50 +0300 Nerijus Baliunas wrote: > > > > > >> Hello, > > >> > > >> mc 4.8.19 does not preserve timestamps of files, if they are copied from > > >> tar.gz, cpio > > >> archives. But copying from zip is OK. > > > > > > I've built now mc (git master) on Debian testing, entered a tar.gz > > > archive and copied a file on ext4 fs. The timestamp of the extracted > > > file was OK. > > > > > > For me more info for reproducing would be needed. > > > > It's latest Fedora package. It is pure mc-4.8.19.tar.xz with one minor > > patch: > > -#define TMPDIR_DEFAULT "/tmp" > > +#define TMPDIR_DEFAULT "/var/tmp" > > > > Build flags are: > > %configure \ > > CFLAGS="%{optflags} -Wno-strict-aliasing" \ > > --disable-rpath \ > > --enable-aspell \ > > --enable-charset \ > > --enable-largefile \ > > --enable-vfs-cpio \ > > --enable-vfs-extfs \ > > --enable-vfs-fish \ > > --enable-vfs-ftp \ > > --enable-vfs-sfs \ > > --enable-vfs-sftp \ > > --enable-vfs-smb \ > > --enable-vfs-tar \ > > --without-x \ > > --with-gpm-mouse \ > > --with-screen=ncurses \ > > %{nil} > > I've tested also cpio and for it I can confirm the issue. I'll propose a patch for this (hopefully shortly). For tar.gz I'd need a preferably small sample file. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
On Tue, 18 Apr 2017 16:30:36 +0300 Nerijus Baliūnas wrote: > 2017-04-18 16:09, Andrey Gursky rašė: > > Hi Nerijus, > > > > On Tue, 18 Apr 2017 15:33:50 +0300 Nerijus Baliunas wrote: > > > >> Hello, > >> > >> mc 4.8.19 does not preserve timestamps of files, if they are copied from > >> tar.gz, cpio > >> archives. But copying from zip is OK. > > > > I've built now mc (git master) on Debian testing, entered a tar.gz > > archive and copied a file on ext4 fs. The timestamp of the extracted > > file was OK. > > > > For me more info for reproducing would be needed. > > It's latest Fedora package. It is pure mc-4.8.19.tar.xz with one minor patch: > -#define TMPDIR_DEFAULT "/tmp" > +#define TMPDIR_DEFAULT "/var/tmp" > > Build flags are: > %configure \ > CFLAGS="%{optflags} -Wno-strict-aliasing" \ > --disable-rpath \ > --enable-aspell \ > --enable-charset \ > --enable-largefile \ > --enable-vfs-cpio \ > --enable-vfs-extfs \ > --enable-vfs-fish \ > --enable-vfs-ftp \ > --enable-vfs-sfs \ > --enable-vfs-sftp \ > --enable-vfs-smb \ > --enable-vfs-tar \ > --without-x \ > --with-gpm-mouse \ > --with-screen=ncurses \ > %{nil} I've tested also cpio and for it I can confirm the issue. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
2017-04-18 16:09, Andrey Gursky rašė: Hi Nerijus, On Tue, 18 Apr 2017 15:33:50 +0300 Nerijus Baliunas wrote: Hello, mc 4.8.19 does not preserve timestamps of files, if they are copied from tar.gz, cpio archives. But copying from zip is OK. I've built now mc (git master) on Debian testing, entered a tar.gz archive and copied a file on ext4 fs. The timestamp of the extracted file was OK. For me more info for reproducing would be needed. It's latest Fedora package. It is pure mc-4.8.19.tar.xz with one minor patch: -#define TMPDIR_DEFAULT "/tmp" +#define TMPDIR_DEFAULT "/var/tmp" Build flags are: %configure \ CFLAGS="%{optflags} -Wno-strict-aliasing" \ --disable-rpath \ --enable-aspell \ --enable-charset \ --enable-largefile \ --enable-vfs-cpio \ --enable-vfs-extfs \ --enable-vfs-fish \ --enable-vfs-ftp \ --enable-vfs-sfs \ --enable-vfs-sftp \ --enable-vfs-smb \ --enable-vfs-tar \ --without-x \ --with-gpm-mouse \ --with-screen=ncurses \ %{nil} ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel
Re: file timestamps not preserved
Hi Nerijus, On Tue, 18 Apr 2017 15:33:50 +0300 Nerijus Baliunas wrote: > Hello, > > mc 4.8.19 does not preserve timestamps of files, if they are copied from > tar.gz, cpio > archives. But copying from zip is OK. I've built now mc (git master) on Debian testing, entered a tar.gz archive and copied a file on ext4 fs. The timestamp of the extracted file was OK. For me more info for reproducing would be needed. Regards, Andrey ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel