Re: [Fwd: Re: memory leak with quick view]
On Tue, 2009-12-29 at 14:00 +0100, Yury V. Zaytsev wrote: Ticket #1918 (Quick view corruption) created by zyv http://www.midnight-commander.org/ticket/1918 There's a patch proposed by Andrew, could you please confirm that it fixes the issue for you? Ticket #1919 (Directories are not highlighted on default install on Debian) created by zyv http://www.midnight-commander.org/ticket/1919 I apparently fixed the Debian packaging bug in the latest release, although the file lists still need careful inspection. -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Yury V. Zaytsev said: (by the date of Sun, 03 Jan 2010 13:46:56 +0100) Ticket #1918 (Quick view corruption) created by zyv http://www.midnight-commander.org/ticket/1918 There's a patch proposed by Andrew, could you please confirm that it fixes the issue for you? unfortunately not. Here's what I have done right now, so you can confirm that I indeed have used this patch: mkdir ZZ ; cd ZZ svn co svn://svn.debian.org/svn/pkg-mc/trunk git clone git://midnight-commander.org/git/mc.git mv trunk/debian mc cd mc # go to website http://www.midnight-commander.org/changeset/121875c21965f6654307c8979287a89e8fddb22f # click on bottom of that page Download in other formats: Unified Diff patch -p0 changeset_r121875c21965f6654307c8979287a89e8fddb22f.diff # patch got applied without errors fakeroot debian/rules binary sudo dpkg -i ../mc_4.7.0.1-1_amd64.deb That's the version from mc -V: ja...@atak:~$ mc -V GNU Midnight Commander 4.7.0.1-17-g3900dfa Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish With builtin Editor Using system-installed S-Lang library with terminfo database With subshell support as default With support for background operations With mouse support on xterm and Linux console With support for X11 events With internationalization support With multiple codepages support Data types: char 8 int 32 long 64 void * 64 off_t 64 ecs_char 8 Also, since in patch description you assumed that it goes wrong when used without utf8, I checked this - and I have found a way to workaround this patch. I only need to: LANG=POSIX Then it is not messed up, and looks like on attached screenshot. Ticket #1919 (Directories are not highlighted on default install on Debian) created by zyv http://www.midnight-commander.org/ticket/1919 I apparently fixed the Debian packaging bug in the latest release, although the file lists still need careful inspection. this one seems is fixed - directories have white color now. -- Janek Kozicki | attachment: scr_2842.png___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Janek Kozicki said: (by the date of Sun, 3 Jan 2010 14:40:57 +0100) Also, since in patch description you assumed that it goes wrong when used without utf8, I checked this - and I have found a way to workaround this patch. I only need to: LANG=POSIX Then it is not messed up, and looks like on attached screenshot. I want to report an undefined behaviour: The LANG=POSIX workaround works about 50% of tries. I just open an xterm, and type: LANG=POSIX mc That's really weird. Also I tried this on mc without your proposed patch. Same behaviour. Even more weird is that I can get following: $ LANG=POSIX mc # here it works, so F10, quit mc, and run it again in same xterm: $ LANG=POSIX mc # now it doesn't work -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Hi! On Tue, 2009-12-22 at 11:28 +0100, Janek Kozicki wrote: In fact I'm unable to create a condition when those two bugs do not appear :) Otherwise I would be able to tell you how to fix it, and that would help you to identify the bug. The issues have been reproduced and are being worked on. In meantime you might wish to subscribe the the corresponding trac tickets to track the developments on these fronts. Ticket #1918 (Quick view corruption) created by zyv http://www.midnight-commander.org/ticket/1918 Ticket #1919 (Directories are not highlighted on default install on Debian) created by zyv http://www.midnight-commander.org/ticket/1919 Thank you for helping us making mc a better user experience! -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
Yury V. Zaytsev said: (by the date of Mon, 21 Dec 2009 13:17:49 +0100) Hi! On Mon, 2009-12-21 at 14:59 +0300, Andrew Borodin wrote: On Sun, 20 Dec 2009 16:30:48 +0100 Janek Kozicki wrote: Those problems are still present. Do I need to select some other skin? - gray directory names (not white) This works for me. Probably there's a problem with the color palette of your terminal emulator. I created a separate user account to be sure that there isn't any leftover configuration. And I can reproduce this bug in text console (not under X), and also under xterm launched without any extra arguments. Both under a fresh user account. - quick view on binary files breaks display It's known bug. The viewer in panel is created with wrong coordinates and sizes. I could reproduce it with LANG=C mc and quick view on the left panel. Care to post the ticket number? Sly Ilia didn't seem to be able to reproduce it yesterday??? In fact I'm unable to create a condition when those two bugs do not appear :) Otherwise I would be able to tell you how to fix it, and that would help you to identify the bug. best regards -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
OK, I've tested this. In 4.7.0-pre4-206-g8791773 this bug does not exist. But I cannot use this version (I even made a debian package of it), because the skins are broken and mc looks really terrible. +--- Warning + | Unable to load 'default' skin. | | Default skin has been loaded | ++ Can you tell me what was the fix, so that I could apply the patch to an older debian version and fix the memory leak? Or eventually how to fix the skin problem, but I suppose that it is debian specific (the location of skins, etc). best regards -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [Fwd: Re: memory leak with quick view]
On Sun, 2009-12-20 at 14:45 +0100, Janek Kozicki wrote: During compilation of debian package there were some problems with file called mc.menu.sr, maybe that's related. I had to copy the file in realtime to the proper place into dir `debian/tmp/.../usr/mc` during compilation. Only then the `debian/rules binary` wouldn't crash during *.deb generation. I used the debian packaging scripts from squeeze. You should have used latest SVN as I indicated earlier: http://packages.qa.debian.org/m/mc.html http://svn.debian.org/wsvn/pkg-mc svn://svn.debian.org/svn/pkg-mc -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
Yury V. Zaytsev said: (by the date of Fri, 11 Dec 2009 22:09:23 +0100) Check out the trac for the instructions: http://www.midnight-commander.org/ The latest package snapshot can be found here: http://svn.debian.org/viewsvn/pkg-mc/ thanks, time limited, but I hope to check this tomorrow. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
memory leak with quick view
Hi, GNU Midnight Commander 4.7.0-pre1 Did anybody already report the memory leak with C-x q Quick view after you resize terminal window? Maybe that's already fixed, and my mc version is just too old? To see this error, you need to quick view on a big .xml file, then resize the terminal window few times. -- Janek Kozicki | ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
On Fri, 2009-12-11 at 21:06 +0100, Janek Kozicki wrote: Did anybody already report the memory leak with C-x q Quick view after you resize terminal window? Are you able to reproduce this on current git master? -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: memory leak with quick view
On Fri, 2009-12-11 at 21:53 +0100, Janek Kozicki wrote: I can check that, but I never used git, and I only build debian packages with apt-get source mc and fakeroot debian/rules binary. I'm not installing anything on my PC without a debian package. You don't have to install it, just run the binary straight out of the source tree. Or else you can install it to some prefix within your home dir and wipe it when you're done. Don't forget to backup your ~/.mc though. how do I download your git master. I can try to fiddle with that source to compile it into debian package, but maybe you have some hints that will save me time. Check out the trac for the instructions: http://www.midnight-commander.org/ The latest package snapshot can be found here: http://svn.debian.org/viewsvn/pkg-mc/ -- Sincerely yours, Yury V. Zaytsev ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel