Re[3]: start time

[Andrew V. Samoilov]

Hello, Pavel!

 Patch was committed into mc-current and mc-pre.

Thx, can you apply next one?

-- 
Regards,
Andrew V. Samoilov


GET INTERNET ACCESS FROM BCS! http://www.bcs.zp.ua
Join BCS today! For your FREE webmail, visit: http://email.zp.ua/
src/ChangeLog

* utilunix.c (mc_realpath) [USE_SYSTEM_REALPATH]: Use realpath().

--- utilunix.c~ Wed Feb  2 09:28:13 2005
+++ utilunix.c  Wed Feb  2 16:23:16 2005
@@ -711,6 +711,9 @@ putenv (char *string)
 char *
 mc_realpath (const char *path, char resolved_path[])
 {
+#ifdef USE_SYSTEM_REALPATH
+return realpath (path, resolved_path);
+#else
 char copy_path[PATH_MAX];
 char link_path[PATH_MAX];
 char got_path[PATH_MAX];
@@ -821,4 +824,5 @@ mc_realpath (const char *path, char reso
 *new_path = '\0';
 strcpy (resolved_path, got_path);
 return resolved_path;
+#endif /* USE_SYSTEM_REALPATH */
 }
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re[4]: start time

[Pavel S. Shirshov]

Hello Andrew,

Wednesday, February 2, 2005, 7:35:31 PM, you wrote:

AVS Hello, Pavel!

 Patch was committed into mc-current and mc-pre.

AVS Thx, can you apply next one?

Yes. Committed. Thx

-- 
Best regards,
 Pavelmailto:[EMAIL PROTECTED]

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: start time

[Andrew V. Samoilov]

Hello, Miguel, I am glad to see you here again.
 
   I have applied this patch to the CVS repository with a few changes
   (configure.in checks, plus made sure that the style matched the rest of
   the code).

I think this patch is reasonable.

BTW, I did not add ChangeLog entries for these getgrouplist() patches.

-- 
Regards,
Andrew V. Samoilov


GET INTERNET ACCESS FROM BCS! http://www.bcs.zp.ua
Join BCS today! For your FREE webmail, visit: http://email.zp.ua/
src/ChangeLog:

* utilunix.c (init_groups): Use glib memory allocation functions.

--- utilunix.c~ Mon Jan 31 09:28:11 2005
+++ utilunix.c  Mon Jan 31 15:44:24 2005
@@ -94,33 +94,32 @@ void init_groups (void)
 
 #ifdef HAVE_GETGROUPLIST
 {
-gid_t *groups = NULL;
-int ng = 1;
-//struct group *grp;
-gid_t *newgroups = NULL;
-
-groups = (gid_t *) malloc(ng * sizeof(gid_t));
+   gid_t *groups = g_new (gid_t, 1);
+   int ng = 1;
+   gid_t *newgroups = NULL;
 
-if (getgrouplist(pwd-pw_name, pwd-pw_gid, groups, ng) == -1) {
-newgroups = (gid_t *) malloc(ng * sizeof(gid_t));
-if (newgroups != NULL) {
-free (groups);
-groups = newgroups;
-getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng);
-} else
-   ng = 1;
-}
+   if (getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng) == -1) {
+   newgroups = g_new (gid_t, ng);
+   if (newgroups != NULL) {
+   g_free (groups);
+   groups = newgroups;
+   getgrouplist (pwd-pw_name, pwd-pw_gid, groups, ng);
+   } else
+   ng = 1;
+   }
 
-for (i = 0; i  ng; i++) {
-grp = getgrgid(groups[i]);
-if (grp != NULL  !g_tree_lookup (current_user_gid, 
GUINT_TO_POINTER ((int) grp-gr_gid))) {
-g_tree_insert (current_user_gid,
-  GUINT_TO_POINTER ((int) grp-gr_gid),
-  g_strdup (grp-gr_name));
-}
-}
+   for (i = 0; i  ng; i++) {
+   grp = getgrgid (groups[i]);
+   if (grp != NULL
+!g_tree_lookup (current_user_gid,
+  GUINT_TO_POINTER ((int) grp-gr_gid))) {
+   g_tree_insert (current_user_gid,
+  GUINT_TO_POINTER ((int) grp-gr_gid),
+  g_strdup (grp-gr_name));
+   }
+   }
 
-   free(groups);
+   g_free (groups);
 }
 #else
 setgrent ();
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: start time

[Miguel de Icaza]

Hey,

I have applied this patch to the CVS repository with a few changes
(configure.in checks, plus made sure that the style matched the rest of
the code).
 
 I think this patch is reasonable.
 
 BTW, I did not add ChangeLog entries for these getgrouplist() patches.

This patch looks good, could you commit?

Miguel
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: start time

[Leonard den Ottolander]

Hi Miguel,

On Sun, 2005-01-30 at 06:01, Miguel de Icaza wrote:
 I have applied this patch to the CVS repository with a few changes
 (configure.in checks, plus made sure that the style matched the rest of
 the code).

To which branches? Only to HEAD or also to mc-4.6.1-PREsomething?

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: start time

[Miguel de Icaza]

Hello,

  I have applied this patch to the CVS repository with a few changes
  (configure.in checks, plus made sure that the style matched the rest of
  the code).
 
 To which branches? Only to HEAD or also to mc-4.6.1-PREsomething?

Only to HEAD, I did not want to step on an already tagged tree.

Miguel.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel