[MediaWiki-commits] [Gerrit] Avoid direct access to $wgGroupPermissions - change (mediawiki/core[master])
Tim Starling has submitted this change and it was merged. Change subject: Avoid direct access to $wgGroupPermissions .. Avoid direct access to $wgGroupPermissions Created a new method User::groupHasPermission and check also $wgRevokePermissions for the given right Change-Id: I41edb091fa35c8c68b6f95cc5fd208ea99418cdb --- M includes/OutputPage.php M includes/ProtectionForm.php M includes/SpecialPage.php M includes/Title.php M includes/User.php M includes/actions/RawAction.php M includes/specials/SpecialNewpages.php 7 files changed, 30 insertions(+), 32 deletions(-) Approvals: Tim Starling: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26357 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41edb091fa35c8c68b6f95cc5fd208ea99418cdb Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add version number to deprecated setting - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged. Change subject: Add version number to deprecated setting .. Add version number to deprecated setting Fix one doc Change-Id: I527639c3694d7b72d9f3bff62fb8b0b7eb6ee126 --- M docs/memcached.txt M includes/DefaultSettings.php 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I527639c3694d7b72d9f3bff62fb8b0b7eb6ee126 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: Catrope Gerrit-Reviewer: MaxSem Gerrit-Reviewer: Reedy Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix HtmlTest, XmlTest; Add setMwGlobals method to base TestC... - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged. Change subject: Fix HtmlTest, XmlTest; Add setMwGlobals method to base TestCase. .. Fix HtmlTest, XmlTest; Add setMwGlobals method to base TestCase. The HTML and XML test now set the globals they depend on (instead of relying on the default settings). Tests for the "other" scenarios still exist, globals are overridden inline. They are automatically restored after each test## function by PHPUnit from MediaWikiTestCase::tearDown. Also fixed 2 other problems with the test suite: * HtmlTest::testDropDefaults forgot to pass $message to the assertion from the provider ($case[3]). * The data provider for HtmlTest::testDropDefaults was calling Html::element directly (instead of calling it within the test) which is problematic because data providers are expected to be static. PHPUnit calls them outside the setUp/tearDown flow. (also fixed the function to be public static, as PHPUnit expects). That last one was crucial to make the test still pass correctly. Updated the expected strings to what they are with these fixed non-leakage settings. Took wgHtml5 without xmlform as default. And added tests for variations where it made sense. Change-Id: Iccf6ea81f4bc2639273ab2ad101c58788ee49d45 --- M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/HtmlTest.php M tests/phpunit/includes/XmlTest.php 3 files changed, 305 insertions(+), 196 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27160 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccf6ea81f4bc2639273ab2ad101c58788ee49d45 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle Gerrit-Reviewer: Hashar Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Clean and repair many phpunit tests (+ fix implied configura... - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged. Change subject: Clean and repair many phpunit tests (+ fix implied configuration) .. Clean and repair many phpunit tests (+ fix implied configuration) This commit depends on the introduction of MediaWikiTestCase::setMwGlobals in change Iccf6ea81f4. Various tests already set their globals, but forgot to restore them afterwards, or forgot to call the parent setUp, tearDown... Either way they won't have to anymore with setMwGlobals. Consistent use of function characteristics: * protected function setUp * protected function tearDown * public static function (provide..) (Matching the function signature with PHPUnit/Framework/TestCase.php) Replaces: * public function (setUp|tearDown)\( * protected function $1( * \tfunction (setUp|tearDown)\( * \tprotected function $1( * \tfunction (data|provide)\( * \tpublic static function $1\( Also renamed a few "data#", "provider#" and "provides#" functions to "provide#" for consistency. This also removes confusion where the /media tests had a few private methods called dataFile(), which were sometimes expected to be data providers. Fixes: TimestampTest often failed due to a previous test setting a different language (it tests "1 hour ago" so need to make sure it is set to English). MWNamespaceTest became a lot cleaner now that it executes with a known context. Though the now-redundant code that was removed didn't work anyway because wgContentNamespaces isn't keyed by namespace id, it had them was values... FileBackendTest: * Fixed: "PHP Fatal: Using $this when not in object context" HttpTest * Added comment about: "PHP Fatal: Call to protected MWHttpRequest::__construct()" (too much unrelated code to fix in this commit) ExternalStoreTest * Add an assertTrue as well, without it the test is useless because regardless of whether wgExternalStores is true or false it only uses it if it is an array. Change-Id: I9d2b148e57bada64afeb7d5a99bec0e58f8e1561 --- M includes/ExternalStoreDB.php M tests/phpunit/MediaWikiLangTestCase.php M tests/phpunit/includes/ArticleTest.php M tests/phpunit/includes/BlockTest.php M tests/phpunit/includes/CdbTest.php M tests/phpunit/includes/DiffHistoryBlobTest.php M tests/phpunit/includes/EditPageTest.php M tests/phpunit/includes/ExternalStoreTest.php M tests/phpunit/includes/ExtraParserTest.php M tests/phpunit/includes/FauxResponseTest.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/GlobalFunctions/wfAssembleUrlTest.php M tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php M tests/phpunit/includes/GlobalFunctions/wfRemoveDotSegmentsTest.php M tests/phpunit/includes/GlobalFunctions/wfUrlencodeTest.php M tests/phpunit/includes/HttpTest.php M tests/phpunit/includes/IPTest.php M tests/phpunit/includes/JsonTest.php M tests/phpunit/includes/LanguageConverterTest.php M tests/phpunit/includes/LinksUpdateTest.php M tests/phpunit/includes/LocalFileTest.php M tests/phpunit/includes/MWFunctionTest.php M tests/phpunit/includes/MWNamespaceTest.php M tests/phpunit/includes/MessageTest.php M tests/phpunit/includes/ParserOptionsTest.php M tests/phpunit/includes/PathRouterTest.php M tests/phpunit/includes/PreferencesTest.php M tests/phpunit/includes/RecentChangeTest.php M tests/phpunit/includes/ResourceLoaderTest.php M tests/phpunit/includes/RevisionStorageTest.php M tests/phpunit/includes/RevisionTest.php M tests/phpunit/includes/SampleTest.php M tests/phpunit/includes/SanitizerTest.php M tests/phpunit/includes/SeleniumConfigurationTest.php M tests/phpunit/includes/SiteConfigurationTest.php M tests/phpunit/includes/TimeAdjustTest.php M tests/phpunit/includes/TimestampTest.php M tests/phpunit/includes/TitleMethodsTest.php M tests/phpunit/includes/TitlePermissionTest.php M tests/phpunit/includes/TitleTest.php M tests/phpunit/includes/UserTest.php M tests/phpunit/includes/WebRequestTest.php M tests/phpunit/includes/WikiPageTest.php M tests/phpunit/includes/XmlSelectTest.php M tests/phpunit/includes/XmlTest.php M tests/phpunit/includes/ZipDirectoryReaderTest.php M tests/phpunit/includes/api/ApiBlockTest.php M tests/phpunit/includes/api/ApiEditPageTest.php M tests/phpunit/includes/api/ApiOptionsTest.php M tests/phpunit/includes/api/ApiPurgeTest.php M tests/phpunit/includes/api/ApiQueryTest.php M tests/phpunit/includes/api/ApiTestCase.php M tests/phpunit/includes/api/ApiTestCaseUpload.php M tests/phpunit/includes/api/ApiWatchTest.php M tests/phpunit/includes/cache/GenderCacheTest.php M tests/phpunit/includes/cache/ProcessCacheLRUTest.php M tests/phpunit/includes/db/DatabaseSQLTest.php M tests/phpunit/includes/db/DatabaseSqliteTest.php M tests/phpunit/includes/db/DatabaseTest.php M tests/phpunit/includes/db/TestORMRowTest.php M tests/phpunit/includes/debug/MWDebugTest.php M tests/phpunit/includes/filerepo/FileBackendTest.php M tests/phpunit/includes/filerepo/StoreBatchTest.php M te
[MediaWiki-commits] [Gerrit] Replace remaining wfMsgExt calls. - change (mediawiki...Scribunto[master])
Tim Starling has submitted this change and it was merged.
Change subject: Replace remaining wfMsgExt calls.
..
Replace remaining wfMsgExt calls.
All of these were in getScriptTraceHtml, which used some magic ($msgOptions)
which is no
longer that easy when using the Message class. As only inContentLanguage
('content') was
used, I documented that, and added the relevant code paths.
I tried to keep the code as readable and brief as possible and also removed an
unused
local variable ($linedefined).
Change-Id: I38e1ce0bf90d9aa462e88ca7c795fcc848c4f118
---
M engines/LuaCommon/LuaCommon.php
1 file changed, 20 insertions(+), 9 deletions(-)
Approvals:
Tim Starling: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/27027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38e1ce0bf90d9aa462e88ca7c795fcc848c4f118
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Siebrand
Gerrit-Reviewer: Nikerabbit
Gerrit-Reviewer: Tim Starling
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix 2 x script typos - change (mediawiki...EducationProgram[master])
Siebrand has submitted this change and it was merged. Change subject: Fix 2 x script typos .. Fix 2 x script typos Fix undefined variable in error message Change-Id: I50944b0fe854e705911b0d276b847d01d78223dd --- M maintenance/deleteEducation.php M maintenance/importWEPData.php M maintenance/importWEPFromDB.php 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27264 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50944b0fe854e705911b0d276b847d01d78223dd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EducationProgram Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 39701) beta: automatic MediaWiki update - change (operations/puppet[production])
Tim Starling has submitted this change and it was merged. Change subject: (bug 39701) beta: automatic MediaWiki update .. (bug 39701) beta: automatic MediaWiki update This patch is supposed to be run on one server having access to /home/wikipedia/common. The shell script is an infinite loop which is managed by an upstartjob. The script will run git pull in an existing MediaWiki core working copy and then in the extension working copy, will then invoke an update of all submodules. Change-Id: I84292345f5e4135e03c524a02dd7eb34ee9119cb --- A files/misc/beta/wmf-beta-autoupdate A files/misc/beta/wmf-beta-autoupdate.default A files/upstart/wmf-beta-autoupdate.conf A manifests/misc/beta.pp 4 files changed, 162 insertions(+), 0 deletions(-) Approvals: Tim Starling: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22116 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84292345f5e4135e03c524a02dd7eb34ee9119cb Gerrit-PatchSet: 13 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: CSteipp Gerrit-Reviewer: Demon Gerrit-Reviewer: Faidon Gerrit-Reviewer: Hashar Gerrit-Reviewer: Platonides Gerrit-Reviewer: Reedy Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: gerrit2 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] run mergeMessageFileList.php as 'mwdeploy' user - change (operations/puppet[production])
Tim Starling has submitted this change and it was merged. Change subject: run mergeMessageFileList.php as 'mwdeploy' user .. run mergeMessageFileList.php as 'mwdeploy' user The mw-update-l10n script could potentially be run as the root user, for example by the automatic updater for beta. We do not want to use those credentials and run a PHP script coming from mediawiki/core.git. Change-Id: I0fe0f3cf3c5bdfcf010aa3a266f033728fa3c102 --- M files/misc/scripts/mw-update-l10n 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tim Starling: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27060 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fe0f3cf3c5bdfcf010aa3a266f033728fa3c102 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar Gerrit-Reviewer: Platonides Gerrit-Reviewer: Reedy Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: gerrit2 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 34876) Make jquery.makeCollapsible less slow. - change (mediawiki/core[master])
Tim Starling has submitted this change and it was merged.
Change subject: (bug 34876) Make jquery.makeCollapsible less slow.
..
(bug 34876) Make jquery.makeCollapsible less slow.
Several optimisations:
* Re-using the same $collapsible jQuery object instead of
re-creation of $(this).
* Use .data instead of dom manipulation (className property).
* Use $.nodeName( HTMLElement, tag ) to check something is ,
instead of using creating a jQuery object and calling
"is.('a')", which goes through a lot of selector stuff.
- Fix bug where it says it does instantHide but actually still
triggers the event that causes initial animations.
Thanks to Lupo for most of these ideas, based on this patch:
* https://bugzilla.wikimedia.org/attachment.cgi?id=10200
Verified that these test cases all still work:
https://test.wikipedia.org/wiki/User:Krinkle/CollapsingTestpageMw
(copy wikitext to localhost)
Change-Id: Idb9ca00c03ec7d70903ed7fd79e427efa270ace4
---
M RELEASE-NOTES-1.21
M resources/jquery/jquery.makeCollapsible.js
2 files changed, 125 insertions(+), 85 deletions(-)
Approvals:
Tim Starling: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/21873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb9ca00c03ec7d70903ed7fd79e427efa270ace4
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle
Gerrit-Reviewer: Catrope
Gerrit-Reviewer: Krinkle
Gerrit-Reviewer: Matmarex
Gerrit-Reviewer: Tim Starling
Gerrit-Reviewer: Trevor Parscal
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Split $.smwTooltip into two methods (init and add) - change (mediawiki...SemanticMediaWiki[master])
Mwjames has uploaded a new change for review.
Change subject: Split $.smwTooltip into two methods (init and add)
..
Split $.smwTooltip into two methods (init and add)
## Description
Split $.smwTooltip into two methods (init and add). The add method can be
used on any element and handles the creation of the icon/content element
and also initializes the tooltip with a qtip2 instance.
## Usage
$( ... ).smwTooltip( 'add', {
title: ...,
type: ...,
content:...
} );
I'd like to use a namespace for this such as smw.tooltip/
semanticMediawiki.Tooltip but since jquery and namespaces usage sucks
(in order to allow normal chaining behaviour ) I have to leave this for
and use fn.smw...
## Dependency
on change I88adbae3
Change-Id: Icc9c43e428189a029c589a0869541d3dc4d54251
---
M resources/ext.smw.util.tooltip.js
1 file changed, 87 insertions(+), 21 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki
refs/changes/67/27267/1
--
To view, visit https://gerrit.wikimedia.org/r/27267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9c43e428189a029c589a0869541d3dc4d54251
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Mwjames
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added two hooks: SavePreferences and UserRightsAbort. - change (mediawiki/core[master])
Parent5446 has uploaded a new change for review. Change subject: Added two hooks: SavePreferences and UserRightsAbort. .. Added two hooks: SavePreferences and UserRightsAbort. (bug 24944) Add hook to allow modification of preferences before save. (bug 31625) Add hook to allow changing of user groups in Special:Userrights. Change-Id: I2cc93bc6bb216e119c76e76f67ceea1919f7fced --- M docs/hooks.txt M includes/Preferences.php M includes/specials/SpecialUserrights.php 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/66/27266/1 -- To view, visit https://gerrit.wikimedia.org/r/27266 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2cc93bc6bb216e119c76e76f67ceea1919f7fced Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added contexts to Hooks. - change (mediawiki/core[master])
Parent5446 has uploaded a new change for review. Change subject: Added contexts to Hooks. .. Added contexts to Hooks. Added third parameter to wfRunHooks() and Hooks::run() that allows the passing of an IContextSource argument. If the argument is not passed, RequestContext::getMain() is used instead. Then, for each hook, if the callback object or any data passed to a callback inherits ContextSource, Hooks will set the context on those objects to the one provided. Also, any hooks in the core that are run within some sort of context were changed to pass that context to the hooks using the aformentioned new parameter. Those that do not take place in a context were left alone, which defaults to RequestContext::getMain(). Change-Id: I0e2cefcc1e54cf2cb9e816152f7233396153c6e0 --- M includes/Action.php M includes/Article.php M includes/CategoryPage.php M includes/ChangesList.php M includes/GlobalFunctions.php M includes/Hooks.php M includes/ImagePage.php M includes/OutputPage.php M includes/Preferences.php M includes/Skin.php M includes/SkinLegacy.php M includes/SkinTemplate.php M includes/SpecialPage.php M includes/Wiki.php M includes/actions/EditAction.php M includes/actions/HistoryAction.php M includes/actions/InfoAction.php M includes/actions/RawAction.php M includes/api/ApiBase.php M includes/api/ApiEditPage.php M includes/api/ApiLogin.php M includes/api/ApiLogout.php M includes/api/ApiMain.php M includes/api/ApiQuery.php M includes/api/ApiQueryInfo.php M includes/api/ApiQueryRecentChanges.php M includes/api/ApiQueryRevisions.php M includes/api/ApiQuerySiteinfo.php M includes/api/ApiQueryUsers.php M includes/api/ApiRsd.php M includes/api/ApiTokens.php M includes/api/ApiUndelete.php M includes/context/RequestContext.php M includes/diff/DifferenceEngine.php M includes/logging/LogEventsList.php M includes/logging/LogFormatter.php M includes/specials/SpecialBlock.php M includes/specials/SpecialBlockList.php M includes/specials/SpecialBooksources.php M includes/specials/SpecialChangeEmail.php M includes/specials/SpecialChangePassword.php M includes/specials/SpecialContributions.php M includes/specials/SpecialDeletedContributions.php M includes/specials/SpecialEditWatchlist.php M includes/specials/SpecialEmailuser.php M includes/specials/SpecialImport.php M includes/specials/SpecialListusers.php M includes/specials/SpecialMergeHistory.php M includes/specials/SpecialMovepage.php M includes/specials/SpecialNewpages.php M includes/specials/SpecialPasswordReset.php M includes/specials/SpecialRandompage.php M includes/specials/SpecialRecentchanges.php M includes/specials/SpecialRecentchangeslinked.php M includes/specials/SpecialSearch.php M includes/specials/SpecialStatistics.php M includes/specials/SpecialUndelete.php M includes/specials/SpecialUpload.php M includes/specials/SpecialUserlogin.php M includes/specials/SpecialUserlogout.php M includes/specials/SpecialUserrights.php M includes/specials/SpecialVersion.php M includes/specials/SpecialWantedpages.php M includes/specials/SpecialWatchlist.php 64 files changed, 211 insertions(+), 194 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/65/27265/1 -- To view, visit https://gerrit.wikimedia.org/r/27265 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e2cefcc1e54cf2cb9e816152f7233396153c6e0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable transaction warnings for automatic trx. - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Disable transaction warnings for automatic trx. .. Disable transaction warnings for automatic trx. This tracks which transaction was opened automatically because of the DBO_TRX flag, and then supresses any warnings about committing these transactions implicitely, even if write operations were performed by that transaction. To get warnings about implicitely committed writes from automatic transactions, enable $wgDebugDBTransactions. This change is a follow-up to I1e746322 and the older I3f1dd5fd, and should be considered an alternative to I3eacc5a9. The new warning behavior is: * when beginning a transaction, warn if there is a transaction pending that has also been started explicitely by calling begin(). * when beginning a transaction and $wgDebugDBTransactions is on, log any implicit commit of an automatic transaction if write operations where performed within that transaction. The idea is to provide warnings about nested explicite transactions while staying quiet about implicite commits to automatic transactions. Change-Id: Idbe4a9034b13413e351f432408d358a704f6b77d --- M includes/Defines.php M includes/db/Database.php 2 files changed, 40 insertions(+), 18 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26748 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe4a9034b13413e351f432408d358a704f6b77d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Platonides Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Deprecate $wgSharedDB - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Deprecate $wgSharedDB .. Deprecate $wgSharedDB Deprecate $wgSharedDB in response to it accidentally being used in Wikidata. It was always an ugly hack. Change-Id: I68f3bfe7afc49a49cd310b66dc03cf52507d3e58 --- M includes/DefaultSettings.php 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified Objections: IAlex: There's a problem with this change, please improve -- To view, visit https://gerrit.wikimedia.org/r/27137 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f3bfe7afc49a49cd310b66dc03cf52507d3e58 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Tim Starling Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: IAlex Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Some fixes to the "update" script - change (mediawiki...TrustedXFF[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Some fixes to the "update" script .. Some fixes to the "update" script * Sync out the version you are currently using instead of the default version * Use --wiki Change-Id: If22c31c18cf6eb03a1b5910a1e895aea84045ca9 --- M update 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Aaron Schulz: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26447 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If22c31c18cf6eb03a1b5910a1e895aea84045ca9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TrustedXFF Gerrit-Branch: master Gerrit-Owner: Tim Starling Gerrit-Reviewer: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Localisation updates from http://translatewiki.net. - change (mediawiki...Translate[master])
Reedy has submitted this change and it was merged. Change subject: Localisation updates from http://translatewiki.net. .. Localisation updates from http://translatewiki.net. Change-Id: Ib3e79348c39a8bacaaf8df57c53b394ac6b7c6f9 --- M FirstSteps.i18n.php M PageTranslation.i18n.php M Translate.i18n.php M TranslateGroupDescriptions.i18n.php 4 files changed, 15 insertions(+), 11 deletions(-) Approvals: L10n-bot: Verified; Looks good to me, approved Reedy: jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27238 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3e79348c39a8bacaaf8df57c53b394ac6b7c6f9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: L10n-bot Gerrit-Reviewer: Hashar Gerrit-Reviewer: L10n-bot Gerrit-Reviewer: Reedy Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix 2 x script typos - change (mediawiki...EducationProgram[master])
Reedy has uploaded a new change for review. Change subject: Fix 2 x script typos .. Fix 2 x script typos Fix undefined variable in error message Change-Id: I50944b0fe854e705911b0d276b847d01d78223dd --- M maintenance/deleteEducation.php M maintenance/importWEPData.php M maintenance/importWEPFromDB.php 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram refs/changes/64/27264/1 -- To view, visit https://gerrit.wikimedia.org/r/27264 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I50944b0fe854e705911b0d276b847d01d78223dd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EducationProgram Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82... - change (mediawiki...SpamBlacklist[master])
Tim Starling has uploaded a new change for review. Change subject: Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 .. Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 Change-Id: Ie172f77597059424dfef1ea575d422eed69684d9 --- M cleanup.php 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist refs/changes/63/27263/1 -- To view, visit https://gerrit.wikimedia.org/r/27263 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie172f77597059424dfef1ea575d422eed69684d9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SpamBlacklist Gerrit-Branch: master Gerrit-Owner: Tim Starling ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82... - change (mediawiki...LdapAuthentication[master])
Tim Starling has uploaded a new change for review. Change subject: Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 .. Update User::addToDatabase() call for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 Change-Id: Idb76f70658d877dd0ec4ba2bfaca27645a9bae41 --- M LdapAutoAuthentication.php 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LdapAuthentication refs/changes/62/27262/1 -- To view, visit https://gerrit.wikimedia.org/r/27262 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb76f70658d877dd0ec4ba2bfaca27645a9bae41 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LdapAuthentication Gerrit-Branch: master Gerrit-Owner: Tim Starling ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update User::addToDatabase() for I1f6ef5e6319bfe692fb82a3fa5... - change (mediawiki...CentralAuth[master])
Tim Starling has uploaded a new change for review. Change subject: Update User::addToDatabase() for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 .. Update User::addToDatabase() for I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 Change-Id: I888c7fe75fdf97e979899f02ad413fd8fd43dc16 --- M CentralAuthHooks.php 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth refs/changes/61/27261/1 -- To view, visit https://gerrit.wikimedia.org/r/27261 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I888c7fe75fdf97e979899f02ad413fd8fd43dc16 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralAuth Gerrit-Branch: master Gerrit-Owner: Tim Starling ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 16020) Fix race condition in User::addToDatabase() - change (mediawiki/core[master])
Tim Starling has uploaded a new change for review. Change subject: (bug 16020) Fix race condition in User::addToDatabase() .. (bug 16020) Fix race condition in User::addToDatabase() Fix the DB error which comes from User::addToDatabase() if it is called when the user already exists. This is the most common DB error we log at WMF in normal operation, perhaps because of double clicks on the "create account" button, or perhaps due to CentralAuth autocreation when multiple pages on another wiki are opened in the browser simultaneously, as the bug reporter suggests. See the doc comment for the interface rationale. Patched Special:Userlogin to be aware of the new return value. Most extension callers will continue to work, I will patch a couple that need it in subsequent commits. Change-Id: I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 --- M includes/Status.php M includes/User.php M includes/specials/SpecialUserlogin.php 3 files changed, 71 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/60/27260/1 -- To view, visit https://gerrit.wikimedia.org/r/27260 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f6ef5e6319bfe692fb82a3fa50dc66c9fde8f15 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Tim Starling ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove preferences for edit on double and right click - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Remove preferences for edit on double and right click .. Remove preferences for edit on double and right click To reduce preferences clutter, remove user preferences for "Enable section editing by right clicking on section titles" and "Edit pages on double click". Change-Id: Ia34cb75439fef40c5d702127d52ee8fe1b611dfa --- M RELEASE-NOTES-1.21 M includes/DefaultSettings.php M includes/OutputPage.php M includes/Preferences.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc D resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js D resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js 8 files changed, 2 insertions(+), 69 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/59/27259/1 -- To view, visit https://gerrit.wikimedia.org/r/27259 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia34cb75439fef40c5d702127d52ee8fe1b611dfa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by making 'editsection' non-c... - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by making 'editsection' non-changeable .. Reduce user preference clutter by making 'editsection' non-changeable Pages will have [edit] links for sections, unless __NOEDITSECTION__ is used. Change-Id: I39782b11478953ba2aeeb9324e42019243e3d6d3 --- M RELEASE-NOTES-1.21 M includes/DefaultSettings.php M includes/Preferences.php M includes/parser/ParserOptions.php M includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc 7 files changed, 7 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/58/27258/1 -- To view, visit https://gerrit.wikimedia.org/r/27258 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39782b11478953ba2aeeb9324e42019243e3d6d3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by removing "Size of editing ... - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by removing "Size of editing window" .. Reduce user preference clutter by removing "Size of editing window" Change-Id: I27ac92694b9d34880e235b1823db823f13348f96 --- M RELEASE-NOTES-1.21 M includes/DefaultSettings.php M includes/EditPage.php M includes/OutputPage.php M includes/Preferences.php M includes/specials/SpecialUndelete.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc 8 files changed, 13 insertions(+), 33 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/57/27257/1 -- To view, visit https://gerrit.wikimedia.org/r/27257 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27ac92694b9d34880e235b1823db823f13348f96 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] grammar emits EOF - change (mediawiki...Parsoid[master])
Adamw has uploaded a new change for review. Change subject: grammar emits EOF .. grammar emits EOF Change-Id: Ia3058b6d212ab5168573555956df6945bedd5c49 --- M cpp/src/TreeBuilder.cpp M cpp/src/wikitext_tokenizer.leg 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/56/27256/1 -- To view, visit https://gerrit.wikimedia.org/r/27256 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3058b6d212ab5168573555956df6945bedd5c49 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleaned up Hooks code, comments, and documentation. - change (mediawiki/core[master])
Parent5446 has uploaded a new change for review. Change subject: Cleaned up Hooks code, comments, and documentation. .. Cleaned up Hooks code, comments, and documentation. Essentially rewrote Hooks::run() to get rid of the ridiculous four levels of indentation. Also made some slight adjustments to fix rare edge cases (for example, moved set_error_handler after wfProfileIn in case Profiler triggers an error). Change-Id: Iafdd4ceedac067b49ac597359ac456f4617da9e8 --- M includes/Hooks.php 1 file changed, 72 insertions(+), 140 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/55/27255/1 -- To view, visit https://gerrit.wikimedia.org/r/27255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iafdd4ceedac067b49ac597359ac456f4617da9e8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Parent5446 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Less globals - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Less globals .. Less globals Change-Id: I78939462a2803156879f24ba4414ca278325aa07 --- M api/ApiTranslationReview.php 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27253 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78939462a2803156879f24ba4414ca278325aa07 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] cosmetic improvements to WikiTokenizer and PEG - change (mediawiki...Parsoid[master])
Adamw has uploaded a new change for review. Change subject: cosmetic improvements to WikiTokenizer and PEG .. cosmetic improvements to WikiTokenizer and PEG also: * hide deprecations Change-Id: Ic0014c2912df7aa4549b1ecc7cd7f1aa927768c1 --- M cpp/src/CMakeLists.txt M cpp/src/InputExpansionPipeline.hpp M cpp/src/WikiTokenizer.cpp M cpp/src/WikiTokenizer.hpp D cpp/src/html_parser.cpp D cpp/src/html_parser.h D cpp/src/mediawiki_api.h A cpp/src/wikitext_tokenizer.hpp M cpp/src/wikitext_tokenizer.leg M cpp/test/test.cc 10 files changed, 82 insertions(+), 109 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/54/27254/1 -- To view, visit https://gerrit.wikimedia.org/r/27254 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0014c2912df7aa4549b1ecc7cd7f1aa927768c1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Less globals - change (mediawiki...Translate[master])
Nikerabbit has uploaded a new change for review. Change subject: Less globals .. Less globals Change-Id: I78939462a2803156879f24ba4414ca278325aa07 --- M api/ApiTranslationReview.php 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/53/27253/1 -- To view, visit https://gerrit.wikimedia.org/r/27253 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78939462a2803156879f24ba4414ca278325aa07 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update uls.data API calls - change (mediawiki...Wikibase[master])
John Erling Blad has submitted this change and it was merged. Change subject: Update uls.data API calls .. Update uls.data API calls * autonyms() is deprecated as of today and replaced by getAutonyms(). * There's a new function called getDir(), that returns 'rtl' or 'ltr'. * 'auto' is used if the direction cannot be determined. - patch set 2: added fix for type check - patch set 3: using getDir() in wikibase.Site as well Change-Id: Ic3274326d8c3517b4f53dbd150eb664295a48ddb --- M repo/resources/wikibase.Site.js M repo/resources/wikibase.special/wikibase.special.itemDisambiguation.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.Interface.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js 4 files changed, 12 insertions(+), 6 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27173 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3274326d8c3517b4f53dbd150eb664295a48ddb Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add parameters to LanguageQqx-generated messages. - change (mediawiki/core[master])
Nikerabbit has submitted this change and it was merged. Change subject: Add parameters to LanguageQqx-generated messages. .. Add parameters to LanguageQqx-generated messages. This avoids outputing bunch of unhelpful (parentheses) messages. Change-Id: I55fab4f132f28be3fe7e4bc8f51d403b11d24284 --- M includes/Message.php M languages/classes/LanguageQqx.php 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/9214 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55fab4f132f28be3fe7e4bc8f51d403b11d24284 Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Liangent Gerrit-Reviewer: Kai Nissen (WMDE) Gerrit-Reviewer: Liangent Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Raimond Spekking Gerrit-Reviewer: SPQRobin Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed bug introduced in I6fb93b46, fix failing selenium test - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: Fixed bug introduced in I6fb93b46, fix failing selenium test .. Fixed bug introduced in I6fb93b46, fix failing selenium test This bug happened because the promise.promisor.apiAction always has a value since I6fb93b46. In the case we are filtering for now, promise.promisor.apiAction was set to undefined before I6fb93b46. After changing the apiAction to always have a value promise.promisor.apiAction was no longer undefined so the condition was true even though this was not intended. This extends the condition as it should have been originally. Change-Id: I3d115afee12d80c87bc869d43e645218bd9adc66 --- M repo/resources/wikibase.ui.Toolbar.EditGroup.js 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/52/27252/1 -- To view, visit https://gerrit.wikimedia.org/r/27252 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d115afee12d80c87bc869d43e645218bd9adc66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More logging - change (mediawiki...WikimediaMaintenance[master])
Reedy has submitted this change and it was merged. Change subject: More logging .. More logging Change-Id: I97847d0ee9a3aaf5f6da46a12138cac54b929ebc --- M migrateWlmUploads.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97847d0ee9a3aaf5f6da46a12138cac54b929ebc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaMaintenance Gerrit-Branch: master Gerrit-Owner: MaxSem Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update version to 1.21. - change (mediawiki/core[master])
Reedy has submitted this change and it was merged. Change subject: Update version to 1.21. .. Update version to 1.21. Change-Id: I0305bb936104eadd60a2f43cdbf7cb676a55d3cb --- M includes/PHPVersionError.php M tests/phpunit/maintenance/backupPrefetchTest.php M tests/phpunit/maintenance/backupTextPassTest.php 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0305bb936104eadd60a2f43cdbf7cb676a55d3cb Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: Reedy Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Save action=mobileview in frontend cache for anons - change (mediawiki...MobileFrontend[master])
Reedy has submitted this change and it was merged. Change subject: Save action=mobileview in frontend cache for anons .. Save action=mobileview in frontend cache for anons Change-Id: Ibd0e26df6fc23b637c2f604ad182a6b56c41150f --- M includes/api/ApiMobileView.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd0e26df6fc23b637c2f604ad182a6b56c41150f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem Gerrit-Reviewer: Asher Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: preilly ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] No, we didn't get that far - change (mediawiki...MobileFrontend[master])
Reedy has submitted this change and it was merged. Change subject: No, we didn't get that far .. No, we didn't get that far Change-Id: I67a31e1ab3070a56beceffa0dd053a71e629eb11 --- M MobileFrontend.php 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27251 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67a31e1ab3070a56beceffa0dd053a71e629eb11 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] pngcrush everything - change (mediawiki...MobileFrontend[master])
Reedy has submitted this change and it was merged. Change subject: pngcrush everything .. pngcrush everything Change-Id: I3e5f8f1bbea98148a4912234ef7f5c6f5aa91419 --- M stylesheets/common/images/Mobile_nav_bar_icons.png M stylesheets/common/images/arrow-left-2.png M stylesheets/common/images/icons_main_menu.png M stylesheets/common/images/icons_sub_menu.png M stylesheets/modules/images/watchlist.png 5 files changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e5f8f1bbea98148a4912234ef7f5c6f5aa91419 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: MaxSem Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] No, we didn't get that far - change (mediawiki...MobileFrontend[master])
MaxSem has uploaded a new change for review. Change subject: No, we didn't get that far .. No, we didn't get that far Change-Id: I67a31e1ab3070a56beceffa0dd053a71e629eb11 --- M MobileFrontend.php 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/51/27251/1 -- To view, visit https://gerrit.wikimedia.org/r/27251 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I67a31e1ab3070a56beceffa0dd053a71e629eb11 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40794) Namespace configuration for kk.wikipedia - change (operations/mediawiki-config[master])
Dereckson has uploaded a new change for review. Change subject: (bug 40794) Namespace configuration for kk.wikipedia .. (bug 40794) Namespace configuration for kk.wikipedia New aliases: - Joba, جوبا : Жоба (102, project) - Joba talqılawı, جوبا تالقىلاۋى : Жоба талқылауы (103, project talk) Change-Id: I94f19a0f8a234c176f984568af84028a283af879 --- M wmf-config/InitialiseSettings.php 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/12/27212/1 -- To view, visit https://gerrit.wikimedia.org/r/27212 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I94f19a0f8a234c176f984568af84028a283af879 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Dereckson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Display disabled button for site-links 'add' if site-links a... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: Display disabled button for site-links 'add' if site-links are full (non-JS) .. Display disabled button for site-links 'add' if site-links are full (non-JS) Change-Id: I27249f54fdb41eddb3f651ebe2bcd5d68ff4c0ee --- M repo/includes/EntityView.php M repo/includes/ItemView.php 2 files changed, 26 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/11/27211/1 -- To view, visit https://gerrit.wikimedia.org/r/27211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27249f54fdb41eddb3f651ebe2bcd5d68ff4c0ee Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed InstanceOfSnak and SubclassOfSnak - change (mediawiki...Wikibase[master])
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed InstanceOfSnak and SubclassOfSnak .. Removed InstanceOfSnak and SubclassOfSnak Change-Id: I7b65a22c5830e8676c213b10e95781552e391abe --- M lib/WikibaseLib.php D lib/includes/snak/InstanceOfSnak.php D lib/includes/snak/SubclassOfSnak.php M lib/tests/phpunit/HashArrayTest.php M lib/tests/phpunit/MapValueHasherTest.php M lib/tests/phpunit/claim/ClaimListTest.php M lib/tests/phpunit/claim/ClaimObjectTest.php M lib/tests/phpunit/snak/SnakListTest.php M lib/tests/phpunit/snak/SnakTest.php M repo/includes/api/ApiCreateClaim.php M repo/includes/api/serializers/ApiSerializer.php 11 files changed, 27 insertions(+), 197 deletions(-) Approvals: Denny Vrandecic: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27185 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b65a22c5830e8676c213b10e95781552e391abe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial specification of new API serialization method with s... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Initial specification of new API serialization method with some implementation examples .. Initial specification of new API serialization method with some implementation examples Change-Id: I263e557a57dea6d4d99ea541ce2d5ca983b1e501 --- A repo/includes/api/serializers/ApiSerializer.php A repo/includes/api/serializers/EntitySerializer.php 2 files changed, 169 insertions(+), 0 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, but someone else must approve Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27178 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I263e557a57dea6d4d99ea541ce2d5ca983b1e501 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated util functions names after refactoring - change (mediawiki...UniversalLanguageSelector[master])
Nikerabbit has submitted this change and it was merged. Change subject: Updated util functions names after refactoring .. Updated util functions names after refactoring jquery.uls.js is just updated from GitHub. Change-Id: I506ab810d7136ba5d96dfdd469394a843110f8de --- M lib/jquery.uls/jquery.uls.js M resources/js/ext.uls.displaysettings.js M resources/js/ext.uls.init.js M tests/webfonts.html 4 files changed, 29 insertions(+), 20 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27124 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506ab810d7136ba5d96dfdd469394a843110f8de Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added SnanksSerializer - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added SnanksSerializer .. Added SnanksSerializer Change-Id: If24ad06f1b5eee00fb2b089313a0c47b7527e10e --- M repo/Wikibase.hooks.php M repo/Wikibase.php M repo/includes/api/serializers/SnakSerializer.php A repo/includes/api/serializers/SnaksSerializer.php M repo/includes/api/serializers/StatementSerializer.php M repo/includes/api/serializers/StatementsSerializer.php A repo/tests/phpunit/includes/api/serializers/SnaksSerializerTest.php M repo/tests/phpunit/includes/api/serializers/StatementSerializerTest.php 8 files changed, 163 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/09/27209/1 -- To view, visit https://gerrit.wikimedia.org/r/27209 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If24ad06f1b5eee00fb2b089313a0c47b7527e10e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added Snak::getType - change (mediawiki...Wikibase[master])
John Erling Blad has submitted this change and it was merged. Change subject: Added Snak::getType .. Added Snak::getType Change-Id: Ibfab1e05958b707f45aabaa4d4c00e98ee10500a --- M lib/WikibaseLib.hooks.php M lib/includes/snak/InstanceOfSnak.php M lib/includes/snak/PropertyNoValueSnak.php M lib/includes/snak/PropertySomeValueSnak.php M lib/includes/snak/PropertyValueSnak.php M lib/includes/snak/Snak.php M lib/includes/snak/SubclassOfSnak.php A lib/tests/phpunit/snak/SnakTest.php 8 files changed, 172 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27174 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfab1e05958b707f45aabaa4d4c00e98ee10500a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added adittional tests for the ApiSerializers - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added adittional tests for the ApiSerializers .. Added adittional tests for the ApiSerializers Change-Id: Ie670dce4f40ad8e757f676fbd9e9ca4fa313e200 --- M repo/includes/api/serializers/StatementSerializer.php M repo/tests/phpunit/includes/api/serializers/SnakSerializerTest.php M repo/tests/phpunit/includes/api/serializers/StatementSerializerTest.php M repo/tests/phpunit/includes/api/serializers/StatementsSerializerTest.php 4 files changed, 56 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/08/27208/1 -- To view, visit https://gerrit.wikimedia.org/r/27208 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie670dce4f40ad8e757f676fbd9e9ca4fa313e200 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improved logic of PropertyEditTool.setState/getState() - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: Improved logic of PropertyEditTool.setState/getState() .. Improved logic of PropertyEditTool.setState/getState() Removed some weird old exception. Added a hasToolbar() function. Change-Id: Id0cb40889fa2fde71e0b8aa95b054c5809647e05 --- M repo/resources/wikibase.ui.PropertyEditTool.js M repo/resources/wikibase.ui.Toolbar.js 2 files changed, 39 insertions(+), 31 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/07/27207/1 -- To view, visit https://gerrit.wikimedia.org/r/27207 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0cb40889fa2fde71e0b8aa95b054c5809647e05 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by removing 'justify' - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by removing 'justify' .. Reduce user preference clutter by removing 'justify' Change-Id: I9eb6ac9eda015fae6ff139f828192af63224d279 --- M RELEASE-NOTES-1.21 M includes/DefaultSettings.php M includes/Preferences.php M includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc 6 files changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/06/27206/1 -- To view, visit https://gerrit.wikimedia.org/r/27206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9eb6ac9eda015fae6ff139f828192af63224d279 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed message displayed if max number of site-links is reach... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: Fixed message displayed if max number of site-links is reached (JS version) .. Fixed message displayed if max number of site-links is reached (JS version) The message is now displayed in the table footer rather than as part of the action column toolbar. Change-Id: Ibca44f595c6254e1b07b8b3a413312d955fbff9f --- M repo/resources/wikibase.css M repo/resources/wikibase.ui.PropertyEditTool.js M repo/resources/wikibase.ui.SiteLinksEditTool.js 3 files changed, 37 insertions(+), 32 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/05/27205/1 -- To view, visit https://gerrit.wikimedia.org/r/27205 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibca44f595c6254e1b07b8b3a413312d955fbff9f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update error version to 1.21. - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Update error version to 1.21. .. Update error version to 1.21. Change-Id: I0305bb936104eadd60a2f43cdbf7cb676a55d3cb --- M includes/PHPVersionError.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/04/27204/1 -- To view, visit https://gerrit.wikimedia.org/r/27204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0305bb936104eadd60a2f43cdbf7cb676a55d3cb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Ignore init code in coverage - change (mediawiki...DataValues[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Ignore init code in coverage .. Ignore init code in coverage Change-Id: I3c342b90b446f7ea072d99272bb7f195ad4e6e96 --- M DataTypes/DataTypes.mw.php M DataTypes/DataTypes.php M DataValues.php M DataValues/DataValues.mw.php M DataValues/DataValues.php M ValueFormatters/ValueFormatters.mw.php M ValueFormatters/ValueFormatters.php M ValueParsers/ValueParsers.mw.php M ValueParsers/ValueParsers.php M ValueValidators/ValueValidators.mw.php M ValueValidators/ValueValidators.php 11 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/03/27203/1 -- To view, visit https://gerrit.wikimedia.org/r/27203 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c342b90b446f7ea072d99272bb7f195ad4e6e96 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by removing 'nocache' - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by removing 'nocache' .. Reduce user preference clutter by removing 'nocache' Change-Id: Ia27f16d0cb4d4762ee0bec5316d485e56f96f004 --- M RELEASE-NOTES-1.21 M includes/AjaxResponse.php M includes/DefaultSettings.php M includes/OutputPage.php M includes/Preferences.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc 7 files changed, 2 insertions(+), 17 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/02/27202/1 -- To view, visit https://gerrit.wikimedia.org/r/27202 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia27f16d0cb4d4762ee0bec5316d485e56f96f004 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by removing 'underline' - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by removing 'underline' .. Reduce user preference clutter by removing 'underline' Change-Id: Icca7900b168f688f1406d26d8b75a7dd74d58270 --- M RELEASE-NOTES-1.21 M includes/DefaultSettings.php M includes/Preferences.php M includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc M skins/Simple.php 7 files changed, 5 insertions(+), 38 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/01/27201/1 -- To view, visit https://gerrit.wikimedia.org/r/27201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icca7900b168f688f1406d26d8b75a7dd74d58270 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Release notes tweaks. - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged. Change subject: Release notes tweaks. .. Release notes tweaks. Change-Id: I9e975c27b94657cd8769267ecdd262b2e9bc6b75 --- M RELEASE-NOTES-1.21 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Hoo man: Looks good to me, but someone else must approve Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27198 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e975c27b94657cd8769267ecdd262b2e9bc6b75 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Registered classes and interfaces in autoloader and added pr... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Registered classes and interfaces in autoloader and added preliminary tests .. Registered classes and interfaces in autoloader and added preliminary tests Change-Id: I090b35afe92c931bc1c4498922a8b6d185b6fcc1 --- M repo/Wikibase.hooks.php M repo/Wikibase.php M repo/includes/api/serializers/StatementsSerializer.php A repo/tests/phpunit/includes/api/serializers/ApiSerializationOptionsTest.php A repo/tests/phpunit/includes/api/serializers/ApiSerializerBaseTest.php A repo/tests/phpunit/includes/api/serializers/ApiSerializerTest.php A repo/tests/phpunit/includes/api/serializers/SnakSerializerTest.php A repo/tests/phpunit/includes/api/serializers/StatementSerializerTest.php A repo/tests/phpunit/includes/api/serializers/StatementsSerializerTest.php 9 files changed, 457 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/00/27200/1 -- To view, visit https://gerrit.wikimedia.org/r/27200 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I090b35afe92c931bc1c4498922a8b6d185b6fcc1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 37419) Rewriting of Index pages edit form in PHP - change (mediawiki...ProofreadPage[master])
saper has uploaded a new change for review. Change subject: (bug 37419) Rewriting of Index pages edit form in PHP .. (bug 37419) Rewriting of Index pages edit form in PHP Rewriting of the index form in PHP in order to improve performance (the edit toolbars were loaded and showed and then Prp created the form) and allow easy editing of index pages Creation of json configuration message proofreadpage_index_data_config that replace proofreadpage_index_attributes and proofreadpage_js_attributes. Wiki can keep using the two old messages. The description of the syntax is done in ProofreadIndexPage::getDataConfig() This creation allow to add new features in the form: - list of possible values for a field (show as a select html element) - help messages - type for each data - default values There is no validation in this form in order to support existant data. The names and id of field has change: a prefix "wpprpindex-" is added in order to avoid any id conflict Some generic classes where added: - ProofreadIndexPage that offer methods in order to get index page content. - ProofreadIndexEntry that manage an entry in the index page and is configuration. Use of these two classes inside of existing parts of the ProofreeadPage extension will be done in an other commit. History: gerrit change https://gerrit.wikimedia.org/r/#/c/10741/ Old-Id: Iaade8c7ee83035387be16e24d35e29c45a5717b2 Patch set 1-8: creation of a new form generator in Javascript Patch set 9: Rebase + change name of config message and various small improvements Patch set 10: Writing of PHP form generator. Patch set 11: Fix bug: The PHP form didn't works in preview mode + small improvements Patch set 12: Fix some bugs in cleanInputtedContent (see inline comments of Patch set 11 in EditProofreadIndexPage.php) Patch set 13: Rebase + some UI improvements Change-Id: I942304918b780ef97f516aef8cb9f962a44de627 --- M ProofreadPage.body.php M ProofreadPage.i18n.php M ProofreadPage.php A includes/index/EditProofreadIndexPage.php A includes/index/ProofreadIndexEntry.php A includes/index/ProofreadIndexPage.php A modules/ext.proofreadpage.index/ext.proofreadpage.index.css M modules/ext.proofreadpage.index/ext.proofreadpage.index.js 8 files changed, 605 insertions(+), 145 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage refs/changes/99/27199/1 -- To view, visit https://gerrit.wikimedia.org/r/27199 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I942304918b780ef97f516aef8cb9f962a44de627 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: saper Gerrit-Reviewer: Tpt ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Release notes tweaks. - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Release notes tweaks. .. Release notes tweaks. Change-Id: I9e975c27b94657cd8769267ecdd262b2e9bc6b75 --- M RELEASE-NOTES-1.21 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/98/27198/1 -- To view, visit https://gerrit.wikimedia.org/r/27198 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e975c27b94657cd8769267ecdd262b2e9bc6b75 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reduce user preference clutter by removing 'minordefault' - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Reduce user preference clutter by removing 'minordefault' .. Reduce user preference clutter by removing 'minordefault' Change-Id: I5139d8ec4c48eae29a28da9bdb083a20c770ea77 --- M includes/DefaultSettings.php M includes/EditPage.php M includes/Preferences.php M includes/api/ApiEditPage.php M languages/messages/MessagesEn.php M maintenance/language/messages.inc 6 files changed, 1 insertion(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/97/27197/1 -- To view, visit https://gerrit.wikimedia.org/r/27197 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5139d8ec4c48eae29a28da9bdb083a20c770ea77 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] User preference 'minordefault' was removed from core - change (mediawiki...SemanticForms[master])
Siebrand has uploaded a new change for review. Change subject: User preference 'minordefault' was removed from core .. User preference 'minordefault' was removed from core Change-Id: Ibfe891430dd89f124ea2839b46457c175478812b --- M includes/SF_FormUtils.php 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms refs/changes/96/27196/1 -- To view, visit https://gerrit.wikimedia.org/r/27196 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfe891430dd89f124ea2839b46457c175478812b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding mongodb module. - change (operations/puppet[production])
Ottomata has uploaded a new change for review. Change subject: Adding mongodb module. .. Adding mongodb module. Cloned from https://github.com/puppetlabs/puppetlabs-mongodb at commit SHA 691620d9058e7b41110793abe59442c4d463d568 and then slightly modified. Change-Id: I7ce74bceda325903f9af1f9d04cc7b221a769b5b --- A modules/mongodb/.fixtures.yml A modules/mongodb/.gemfile A modules/mongodb/.travis.yml A modules/mongodb/CHANGELOG A modules/mongodb/LICENSE A modules/mongodb/Modulefile A modules/mongodb/README.md A modules/mongodb/Rakefile A modules/mongodb/manifests/init.pp A modules/mongodb/manifests/params.pp A modules/mongodb/manifests/sources/apt.pp A modules/mongodb/manifests/sources/yum.pp A modules/mongodb/spec/classes/mongodb_spec.rb A modules/mongodb/spec/fixtures/manifests/site.pp A modules/mongodb/spec/spec_helper.rb A modules/mongodb/templates/mongod.conf.erb A modules/mongodb/tests/init.pp A modules/mongodb/tests/sources/apt.pp A modules/mongodb/tests/sources/yum.pp 19 files changed, 575 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/95/27195/1 -- To view, visit https://gerrit.wikimedia.org/r/27195 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ce74bceda325903f9af1f9d04cc7b221a769b5b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40838) Namespace configuration for es.wikibooks - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: (bug 40838) Namespace configuration for es.wikibooks .. (bug 40838) Namespace configuration for es.wikibooks Namespaces removed: - 102 (Wikiversidad) - 103 (Wikiversidad Discusión) Change-Id: I549e681ca97cfbb13ff723f48c89857af9970b76 --- M wmf-config/InitialiseSettings.php 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27123 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I549e681ca97cfbb13ff723f48c89857af9970b76 Gerrit-PatchSet: 2 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Dereckson Gerrit-Reviewer: Dereckson Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40794) Namespace configuration for kk.wikipedia - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: (bug 40794) Namespace configuration for kk.wikipedia .. (bug 40794) Namespace configuration for kk.wikipedia New namespaces: - 102: Жоба (WikiProject) - 103: Жоба талқылауы (WikiProject talk) Side edit: Adding comment to namespace 100 Change-Id: I120a7b5e1ffb918182c2285d36a8a5cc2109bc56 --- M wmf-config/InitialiseSettings.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27034 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I120a7b5e1ffb918182c2285d36a8a5cc2109bc56 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Dereckson Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40795) Subpages namespace configuration for kk.wikipedi... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: (bug 40795) Subpages namespace configuration for kk.wikipedia .. (bug 40795) Subpages namespace configuration for kk.wikipedia The following namespaces will now have subpages enabled: - Қатысушы (NS_USER) - Портал (100) Change-Id: Ib03e9e0dbff11098d0017023cffdd9f4279293f5 --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27166 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib03e9e0dbff11098d0017023cffdd9f4279293f5 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Dereckson Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40776) Namespace configuration & site name for gu.wikti... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: (bug 40776) Namespace configuration & site name for gu.wiktionary .. (bug 40776) Namespace configuration & site name for gu.wiktionary Site rename: - Old name: વિક્ષનરી - New name: વિક્શનરી Namespace rename: - Old NS_PROJECT name: વિક્ષનરી - New NS_PROJECT name: વિક્શનરી New alias: - વિક્ષનર : NS_PROJECT (old name) Change-Id: Ide339da737dd76350d3298ca9c758a0f3cd80485 --- M wmf-config/InitialiseSettings.php 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26747 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide339da737dd76350d3298ca9c758a0f3cd80485 Gerrit-PatchSet: 2 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Dereckson Gerrit-Reviewer: Dereckson Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] provide e-mail context for other forms of feedback other tha... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: provide e-mail context for other forms of feedback other than technical .. provide e-mail context for other forms of feedback other than technical it's been very useful for the technical feedback let's extend it to other places Change-Id: Ib8af1cfabd0245487a9ec09b40b40784b8027994 --- M wmf-config/mobile.php 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/26920 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8af1cfabd0245487a9ec09b40b40784b8027994 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Jdlrobson Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] JavaScript tweaks. - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: JavaScript tweaks. .. JavaScript tweaks. * JSHint/JSLint suggested updates. * Whitespace updates. * Using single quotes instead of double quotes. Change-Id: Ie7af0e4e6d23ed7996e8338ba96c22d0d8fe2f8a --- M resources/ext.translate.hooks.js M resources/ext.translate.messagetable.js M resources/ext.translate.multiselectautocomplete.js M resources/ext.translate.selecttoinput.js M resources/ext.translate.special.aggregategroups.js M resources/ext.translate.special.importtranslations.js M resources/ext.translate.special.languagestats.js M resources/ext.translate.special.pagetranslation.js M resources/ext.translate.special.translate.js M resources/ext.translate.special.translationstats.js 10 files changed, 96 insertions(+), 77 deletions(-) Approvals: Nikerabbit: Looks good to me, approved Siebrand: jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7af0e4e6d23ed7996e8338ba96c22d0d8fe2f8a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] I18n#1741 - Metadata handling in JsonFFS - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: I18n#1741 - Metadata handling in JsonFFS .. I18n#1741 - Metadata handling in JsonFFS Change-Id: Icadc58c5f86f1490ab7c8466bc490da2670c3584 --- M ffs/JsonFFS.php M tests/JsonFFSTest.php A tests/data/jsontest_fi.json 3 files changed, 33 insertions(+), 1 deletion(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27156 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icadc58c5f86f1490ab7c8466bc490da2670c3584 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix exporting of untranslated messages - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Fix exporting of untranslated messages .. Fix exporting of untranslated messages Change-Id: I73295090e4e96fe34d3ca5b2fc5752d40ce925a7 --- M ffs/JsonFFS.php M tests/JsonFFSTest.php 2 files changed, 61 insertions(+), 12 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27155 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73295090e4e96fe34d3ca5b2fc5752d40ce925a7 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Some test cleanup - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Some test cleanup .. Some test cleanup Change-Id: I323363b453eb82d9638ed98506c29573afe76351 --- M tests/ApiGroupReviewTest.php M tests/ApiTokensTest.php M tests/BlackListTest.php M tests/DtdFFSTest.php M tests/HookDocTest.php 5 files changed, 14 insertions(+), 12 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27182 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I323363b453eb82d9638ed98506c29573afe76351 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'Wikidata' into master. - change (mediawiki/core[master])
Daniel Kinzler has uploaded a new change for review. Change subject: Merge branch 'Wikidata' into master. .. Merge branch 'Wikidata' into master. This introduces the ContentHandler facility into MediaWiki, see docs/contenthandler.txt. For convenient review, a squashed version is available at https://gerrit.wikimedia.org/r/27191 The ContentHandler facility is a majore building block of the Wikidata project. It has been discussed repeatedly on wikitech-l. Change-Id: I3804e2d5f6f59e6a39db80744bdf61bfe8c14f98 --- M .gitreview 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/94/27194/1 -- To view, visit https://gerrit.wikimedia.org/r/27194 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3804e2d5f6f59e6a39db80744bdf61bfe8c14f98 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add button for site links table in non-JS version - change (mediawiki...Wikibase[master])
Daniel Werner has submitted this change and it was merged. Change subject: add button for site links table in non-JS version .. add button for site links table in non-JS version Change-Id: Ia9f4608b1159fbd8ae25e2705a9ceea9d2382181 --- M repo/includes/ItemView.php M repo/resources/wikibase.ui.PropertyEditTool.css M repo/resources/wikibase.ui.SiteLinksEditTool.js 3 files changed, 125 insertions(+), 135 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27187 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f4608b1159fbd8ae25e2705a9ceea9d2382181 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rm starting script, handled by puppet - change (wikimedia...wikibugs[master])
Hashar has uploaded a new change for review. Change subject: rm starting script, handled by puppet .. rm starting script, handled by puppet As of https://gerrit.wikimedia.org/r/#/c/26325/ , the wikibugs ircecho bot will be handled by puppet via the misc::ircecho class. So that old starting script can be safely abandonned. Change-Id: I9a3c6ac948be92567f1d31f871a50cc4e5de4402 --- D start-wikibugs-bot 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/wikibugs refs/changes/93/27193/1 -- To view, visit https://gerrit.wikimedia.org/r/27193 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a3c6ac948be92567f1d31f871a50cc4e5de4402 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/wikibugs Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40857) slap some issets all over the place - change (mediawiki/core[master])
Matmarex has uploaded a new change for review. Change subject: (bug 40857) slap some issets all over the place .. (bug 40857) slap some issets all over the place It boggles my mind that I actually have to write such idiotic code, but I guess life's tough. PHP throws notices everywhere I dare to use an index that might be undefined, which makes absolutely no sense at all, but oh well. (Why would anyone even care about notices?) Also fix a semi-legitimate error where a foreach could be passed a non-array value. Change-Id: Ib51c640b9cb10a8acc8fe4033f71463e36770dbe --- M skins/CologneBlue.php 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/92/27192/1 -- To view, visit https://gerrit.wikimedia.org/r/27192 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib51c640b9cb10a8acc8fe4033f71463e36770dbe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ContentHandler changes all squashed in one (DO NOT MERGE) - change (mediawiki/core[master])
Daniel Kinzler has uploaded a new change for review. Change subject: ContentHandler changes all squashed in one (DO NOT MERGE) .. ContentHandler changes all squashed in one (DO NOT MERGE) This shows the changes needed to patch the Wikidata branch @bb51a58e57 into master @a7153315. Change-Id: I3b2dad3aafe69d1c794ac34555905787afe7ff96 --- M RELEASE-NOTES-1.21 A docs/contenthandler.txt A docs/export-0.8.xsd M docs/hooks.txt M includes/Article.php M includes/AutoLoader.php M includes/DefaultSettings.php M includes/Defines.php M includes/EditPage.php M includes/Export.php M includes/FeedUtils.php M includes/ImagePage.php M includes/Import.php M includes/LinkFilter.php M includes/LinksUpdate.php M includes/Message.php M includes/Namespace.php M includes/OutputPage.php M includes/Revision.php M includes/SqlDataUpdate.php M includes/Timestamp.php M includes/Title.php M includes/WikiFilePage.php M includes/WikiPage.php M includes/actions/RawAction.php M includes/actions/RollbackAction.php M includes/api/ApiComparePages.php M includes/api/ApiDelete.php M includes/api/ApiEditPage.php M includes/api/ApiFeedContributions.php A includes/api/ApiFormatNone.php M includes/api/ApiMain.php M includes/api/ApiParse.php M includes/api/ApiPurge.php M includes/api/ApiQueryRevisions.php M includes/cache/LinkCache.php M includes/cache/MessageCache.php A includes/content/AbstractContent.php A includes/content/Content.php A includes/content/ContentHandler.php A includes/content/CssContent.php A includes/content/JavaScriptContent.php A includes/content/MessageContent.php A includes/content/TextContent.php A includes/content/WikitextContent.php M includes/diff/DifferenceEngine.php M includes/filerepo/file/LocalFile.php M includes/installer/Ibm_db2Updater.php M includes/installer/Installer.php M includes/installer/MysqlUpdater.php M includes/installer/OracleUpdater.php M includes/installer/SqliteUpdater.php M includes/job/DoubleRedirectJob.php M includes/job/RefreshLinksJob.php M includes/parser/Parser.php M includes/parser/ParserOutput.php M includes/resourceloader/ResourceLoaderWikiModule.php M includes/search/SearchEngine.php M includes/specials/SpecialBooksources.php M includes/specials/SpecialComparePages.php M includes/specials/SpecialMergeHistory.php M includes/specials/SpecialNewpages.php M includes/specials/SpecialUndelete.php M languages/Language.php M languages/LanguageConverter.php M languages/classes/LanguageFi.php M languages/classes/LanguageGan.php M languages/classes/LanguageIu.php M languages/classes/LanguageKk.php M languages/classes/LanguageKu.php M languages/classes/LanguageShi.php M languages/classes/LanguageSr.php M languages/classes/LanguageUz.php M languages/classes/LanguageZh.php M languages/messages/MessagesDe.php M languages/messages/MessagesEn.php M languages/messages/MessagesQqq.php M maintenance/Maintenance.php A maintenance/archives/patch-archive-ar_content_format.sql A maintenance/archives/patch-archive-ar_content_model.sql A maintenance/archives/patch-page-page_content_model.sql A maintenance/archives/patch-revision-rev_content_format.sql A maintenance/archives/patch-revision-rev_content_model.sql M maintenance/checkBadRedirects.php M maintenance/cleanupSpam.php M maintenance/compareParsers.php M maintenance/dumpIterator.php M maintenance/edit.php M maintenance/getText.php M maintenance/importSiteScripts.php M maintenance/importTextFile.php M maintenance/language/messages.inc M maintenance/populateRevisionLength.php M maintenance/populateRevisionSha1.php M maintenance/preprocessDump.php M maintenance/refreshLinks.php M maintenance/renderDump.php A maintenance/storage/drop_content_model_info.sql M maintenance/storage/testCompression.php M maintenance/tables.sql M tests/parser/parserTest.inc M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/ArticleTablesTest.php M tests/phpunit/includes/ArticleTest.php A tests/phpunit/includes/ContentHandlerTest.php A tests/phpunit/includes/CssContentTest.php A tests/phpunit/includes/JavascriptContentTest.php M tests/phpunit/includes/LinksUpdateTest.php M tests/phpunit/includes/RevisionStorageTest.php A tests/phpunit/includes/RevisionStorageTest_ContentHandlerUseDB.php M tests/phpunit/includes/RevisionTest.php M tests/phpunit/includes/TemplateCategoriesTest.php M tests/phpunit/includes/TimestampTest.php M tests/phpunit/includes/TitleMethodsTest.php M tests/phpunit/includes/TitleTest.php M tests/phpunit/includes/WikiPageTest.php A tests/phpunit/includes/WikiPageTest_ContentHandlerUseDB.php A tests/phpunit/includes/WikitextContentHandlerTest.php A tests/phpunit/includes/WikitextContentTest.php M tests/phpunit/includes/api/ApiEditPageTest.php M tests/phpunit/includes/api/ApiWatchTest.php M tests/phpunit/includes/search/SearchEngineTest.php M tests/phpunit/maintenance/DumpTestCase.php M tests/phpunit/maintenance/backupPrefetchTest.php M tests/phpunit/maintenance/backupTextPassTest.php M tests/
[MediaWiki-commits] [Gerrit] Fix Bug 40539 Add Opendyslexic font - change (mediawiki...UniversalLanguageSelector[master])
Santhosh has submitted this change and it was merged. Change subject: Fix Bug 40539 Add Opendyslexic font .. Fix Bug 40539 Add Opendyslexic font Added it as non-default font for following languages en,af,pt,es,sw,de,fi,sq,fr,hu,ca,da,fo,ga,is,ms,sv,wa,lb,gd,oc,tr,mi,it,et,cy Change-Id: Ia4b18cf0429dc9e07c89b84cdae16a8325806618 --- M data/fontrepo/fonts/LohitBengali/font.ini A data/fontrepo/fonts/Opendyslexic/font.ini A data/fontrepo/fonts/Opendyslexic/opendyslexic-bold.eot A data/fontrepo/fonts/Opendyslexic/opendyslexic-bold.ttf A data/fontrepo/fonts/Opendyslexic/opendyslexic-bold.woff A data/fontrepo/fonts/Opendyslexic/opendyslexic-italic.eot A data/fontrepo/fonts/Opendyslexic/opendyslexic-italic.ttf A data/fontrepo/fonts/Opendyslexic/opendyslexic-italic.woff A data/fontrepo/fonts/Opendyslexic/opendyslexic.eot A data/fontrepo/fonts/Opendyslexic/opendyslexic.ttf A data/fontrepo/fonts/Opendyslexic/opendyslexic.woff M resources/js/ext.uls.webfonts.repository.js 12 files changed, 8 insertions(+), 2 deletions(-) Approvals: Santhosh: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/25481 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b18cf0429dc9e07c89b84cdae16a8325806618 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Aude Gerrit-Reviewer: Logicwiki Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Pginer Gerrit-Reviewer: Reedy Gerrit-Reviewer: Santhosh Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup of Wikidata branch. - change (mediawiki/core[Wikidata])
Daniel Kinzler has submitted this change and it was merged. Change subject: Cleanup of Wikidata branch. .. Cleanup of Wikidata branch. This cleans up several issues raised in comments to I3b2dad3a, mostly style and merge artifacts. Change-Id: I99f5e300a671db1353db151cd187ffd2e4478d03 --- M RELEASE-NOTES-1.21 M includes/Article.php M includes/AutoLoader.php M includes/DefaultSettings.php M includes/Defines.php M includes/DeprecatedGlobal.php M includes/EditPage.php M includes/GlobalFunctions.php M includes/LinksUpdate.php M includes/OutputPage.php M includes/Revision.php M includes/Timestamp.php M includes/Title.php D includes/Uri.php M includes/WikiPage.php M includes/actions/EditAction.php M includes/api/ApiParse.php M includes/api/ApiPurge.php M includes/api/ApiQueryRevisions.php M includes/cache/MessageCache.php M includes/content/AbstractContent.php M includes/content/Content.php M includes/content/TextContent.php M includes/content/WikitextContent.php M includes/diff/DifferenceEngine.php M includes/installer/Installer.php M includes/installer/SqliteUpdater.php M includes/upload/UploadFromUrl.php M languages/messages/MessagesGa.php M languages/messages/MessagesQqq.php M maintenance/importSiteScripts.php M maintenance/language/messages.inc M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/ContentHandlerTest.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/LinksUpdateTest.php M tests/phpunit/includes/TimestampTest.php D tests/phpunit/includes/UriTest.php M tests/phpunit/includes/WikiPageTest.php M tests/phpunit/includes/WikitextContentHandlerTest.php M tests/phpunit/includes/WikitextContentTest.php M tests/phpunit/includes/api/ApiEditPageTest.php M tests/phpunit/includes/filerepo/FileBackendTest.php M tests/phpunit/suite.xml M thumb.php 45 files changed, 306 insertions(+), 784 deletions(-) Approvals: Daniel Kinzler: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/27189 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99f5e300a671db1353db151cd187ffd2e4478d03 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: Wikidata Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Register ValueFormatters extension - change (translatewiki[master])
Raimond Spekking has submitted this change and it was merged. Change subject: Register ValueFormatters extension .. Register ValueFormatters extension Change-Id: Ic214bd748b0e0b102ef06b6ea20d542f04efa748 --- M MediaWiki/mediawiki-defines.txt 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nikerabbit: Looks good to me, but someone else must approve Raimond Spekking: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27063 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic214bd748b0e0b102ef06b6ea20d542f04efa748 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Raimond Spekking Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] First try on Solr (DO NOT MERGE) - change (mediawiki...Wikibase[master])
Denny Vrandecic has uploaded a new change for review. Change subject: First try on Solr (DO NOT MERGE) .. First try on Solr (DO NOT MERGE) Change-Id: I0079779d115d7ac0048951fc80d5ac6d2405d0dc --- M repo/Wikibase.php A repo/includes/specials/SpecialSolrSearch.php A repo/includes/store/solr/README A repo/includes/store/solr/SolrStore.php A repo/includes/store/solr/TermSolrCache.php A repo/includes/store/solr/schema.xml A repo/maintenance/deleteSolr.php 7 files changed, 620 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/90/27190/1 -- To view, visit https://gerrit.wikimedia.org/r/27190 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0079779d115d7ac0048951fc80d5ac6d2405d0dc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Denny Vrandecic ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup of Wikidata branch. - change (mediawiki/core[Wikidata])
Daniel Kinzler has uploaded a new change for review. Change subject: Cleanup of Wikidata branch. .. Cleanup of Wikidata branch. This cleans up several issues raised in comments to I3b2dad3a, mostly style and merge artifacts. Change-Id: I99f5e300a671db1353db151cd187ffd2e4478d03 --- M RELEASE-NOTES-1.21 M includes/Article.php M includes/AutoLoader.php M includes/DefaultSettings.php M includes/Defines.php M includes/DeprecatedGlobal.php M includes/EditPage.php M includes/GlobalFunctions.php M includes/LinksUpdate.php M includes/OutputPage.php M includes/Revision.php M includes/Timestamp.php M includes/Title.php D includes/Uri.php M includes/WikiPage.php M includes/actions/EditAction.php M includes/api/ApiParse.php M includes/api/ApiPurge.php M includes/api/ApiQueryRevisions.php M includes/cache/MessageCache.php M includes/content/AbstractContent.php M includes/content/Content.php M includes/content/TextContent.php M includes/content/WikitextContent.php M includes/diff/DifferenceEngine.php M includes/installer/Installer.php M includes/installer/SqliteUpdater.php M includes/upload/UploadFromUrl.php M languages/messages/MessagesGa.php M languages/messages/MessagesQqq.php M maintenance/importSiteScripts.php M maintenance/language/messages.inc M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/ContentHandlerTest.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/LinksUpdateTest.php M tests/phpunit/includes/TimestampTest.php D tests/phpunit/includes/UriTest.php M tests/phpunit/includes/WikiPageTest.php M tests/phpunit/includes/WikitextContentHandlerTest.php M tests/phpunit/includes/WikitextContentTest.php M tests/phpunit/includes/api/ApiEditPageTest.php M tests/phpunit/includes/filerepo/FileBackendTest.php M tests/phpunit/suite.xml M thumb.php 45 files changed, 306 insertions(+), 784 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/89/27189/1 -- To view, visit https://gerrit.wikimedia.org/r/27189 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99f5e300a671db1353db151cd187ffd2e4478d03 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: Wikidata Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Split ApiSerialization code into seperate files, added optio... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Split ApiSerialization code into seperate files, added options interface and improved handling of ApiResult .. Split ApiSerialization code into seperate files, added options interface and improved handling of ApiResult Change-Id: I45bb7d589bfe611e9c9c2d910ec86fb83a4ab6fc --- A repo/includes/api/serializers/ApiSerializationOptions.php M repo/includes/api/serializers/ApiSerializer.php A repo/includes/api/serializers/ApiSerializerObject.php M repo/includes/api/serializers/EntitySerializer.php A repo/includes/api/serializers/SnakSerializer.php A repo/includes/api/serializers/StatementSerializer.php A repo/includes/api/serializers/StatementsSerializer.php 7 files changed, 407 insertions(+), 129 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/88/27188/1 -- To view, visit https://gerrit.wikimedia.org/r/27188 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45bb7d589bfe611e9c9c2d910ec86fb83a4ab6fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add button for site links table in non-JS version - change (mediawiki...Wikibase[master])
Henning Snater has uploaded a new change for review. Change subject: add button for site links table in non-JS version .. add button for site links table in non-JS version Change-Id: Ia9f4608b1159fbd8ae25e2705a9ceea9d2382181 --- M repo/includes/ItemView.php M repo/resources/wikibase.ui.PropertyEditTool.css M repo/resources/wikibase.ui.SiteLinksEditTool.js 3 files changed, 16 insertions(+), 24 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/87/27187/1 -- To view, visit https://gerrit.wikimedia.org/r/27187 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9f4608b1159fbd8ae25e2705a9ceea9d2382181 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: Ieffa844bbc871345a9daf87f25a1f3496d7c385e --- M client/includes/store/ClientStore.php M client/includes/store/EntityCache.php M client/includes/store/sql/ClientSqlStore.php M client/includes/store/sql/EntityCacheTable.php 4 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/86/27186/1 -- To view, visit https://gerrit.wikimedia.org/r/27186 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieffa844bbc871345a9daf87f25a1f3496d7c385e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Display 'add' button for aliases instead of 'edit' if no ali... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has submitted this change and it was merged. Change subject: Display 'add' button for aliases instead of 'edit' if no aliases exist yet .. Display 'add' button for aliases instead of 'edit' if no aliases exist yet - patch set 2: rebase Also fixes an minor issue with usage of extractEntityInfo() in EntityView. Change-Id: I8616a6b5c1f24c5d3e2131f20f4854f2ba1ab058 --- M repo/includes/EntityView.php M repo/includes/ItemView.php 2 files changed, 10 insertions(+), 9 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26609 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8616a6b5c1f24c5d3e2131f20f4854f2ba1ab058 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed InstanceOfSnak and SubclassOfSnak - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Removed InstanceOfSnak and SubclassOfSnak .. Removed InstanceOfSnak and SubclassOfSnak Change-Id: I7b65a22c5830e8676c213b10e95781552e391abe --- M lib/WikibaseLib.php D lib/includes/snak/InstanceOfSnak.php D lib/includes/snak/SubclassOfSnak.php M lib/tests/phpunit/HashArrayTest.php M lib/tests/phpunit/MapValueHasherTest.php M lib/tests/phpunit/claim/ClaimListTest.php M lib/tests/phpunit/claim/ClaimObjectTest.php M lib/tests/phpunit/snak/SnakListTest.php M lib/tests/phpunit/snak/SnakTest.php M repo/includes/api/ApiCreateClaim.php M repo/includes/api/serializers/ApiSerializer.php 11 files changed, 27 insertions(+), 197 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/85/27185/1 -- To view, visit https://gerrit.wikimedia.org/r/27185 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7b65a22c5830e8676c213b10e95781552e391abe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Installing mercurial on in statistics::packages. - change (operations/puppet[production])
Ottomata has submitted this change and it was merged. Change subject: Installing mercurial on in statistics::packages. .. Installing mercurial on in statistics::packages. Change-Id: Iacf902b36c8c7bc7d631f45b182b7881e588922c --- M manifests/misc/statistics.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ottomata: Verified; Looks good to me, approved gerrit2: Verified -- To view, visit https://gerrit.wikimedia.org/r/27184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacf902b36c8c7bc7d631f45b182b7881e588922c Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata Gerrit-Reviewer: Ottomata Gerrit-Reviewer: gerrit2 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Installing mercurial on in statistics::packages. - change (operations/puppet[production])
Ottomata has uploaded a new change for review. Change subject: Installing mercurial on in statistics::packages. .. Installing mercurial on in statistics::packages. Change-Id: Iacf902b36c8c7bc7d631f45b182b7881e588922c --- M manifests/misc/statistics.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/84/27184/1 -- To view, visit https://gerrit.wikimedia.org/r/27184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacf902b36c8c7bc7d631f45b182b7881e588922c Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] added support for fancy search button on client - change (mediawiki...Wikibase[master])
Tobias Gritschacher has submitted this change and it was merged. Change subject: added support for fancy search button on client .. added support for fancy search button on client Change-Id: I0246d2ad662b3c20576efc21bca54e7825aff8e5 --- M selenium/lib/pages/client_page.rb 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27181 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0246d2ad662b3c20576efc21bca54e7825aff8e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher Gerrit-Reviewer: Aude Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "(Bug #40563) Rebuilding the store on the client when... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" .. Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" This reverts commit 9c6d9012a890e5be5c34fe31fc5028db3813db3c --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 9 insertions(+), 30 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27183 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib43ba8464d1a7fdbac61bfc0fb908a7fc5c70be5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig Gerrit-Reviewer: Jens Ohlig ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Some test cleanup - change (mediawiki...Translate[master])
Nikerabbit has uploaded a new change for review. Change subject: Some test cleanup .. Some test cleanup Change-Id: I323363b453eb82d9638ed98506c29573afe76351 --- M tests/ApiGroupReviewTest.php M tests/ApiTokensTest.php M tests/BlackListTest.php M tests/DtdFFSTest.php M tests/HookDocTest.php 5 files changed, 14 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/82/27182/1 -- To view, visit https://gerrit.wikimedia.org/r/27182 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I323363b453eb82d9638ed98506c29573afe76351 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] added support for fancy search button on client - change (mediawiki...Wikibase[master])
Tobias Gritschacher has uploaded a new change for review. Change subject: added support for fancy search button on client .. added support for fancy search button on client Change-Id: I0246d2ad662b3c20576efc21bca54e7825aff8e5 --- M selenium/lib/pages/client_page.rb 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/81/27181/1 -- To view, visit https://gerrit.wikimedia.org/r/27181 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0246d2ad662b3c20576efc21bca54e7825aff8e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "(Bug #40563) Rebuilding the store on the client when... - change (mediawiki...Wikibase[master])
Aude has submitted this change and it was merged. Change subject: Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" .. Revert "(Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE)" This reverts commit 9c6d9012a890e5be5c34fe31fc5028db3813db3c --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 9 insertions(+), 30 deletions(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27180 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0277f95b74b76ba5a0f88160060ce71825e67463 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude Gerrit-Reviewer: Aude ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Phase out tests/jasmine; Update mediawiki i18n tests - change (mediawiki/core[master])
Nikerabbit has submitted this change and it was merged. Change subject: Phase out tests/jasmine; Update mediawiki i18n tests .. Phase out tests/jasmine; Update mediawiki i18n tests Updated script for generating mediawiki.jqueryMsg sample data to be generic instead of Jasmine specific Removed mediawiki.jqueryMsg.spec.js * The bulk of the tests were already in QUnit (did that a while ago) * The little $.each loop over the sample data is now in QUnit as well. * Made it so that it doesn't need a hardcoded copy of languageClasses but instead pulls it from load.php on-demand and then restores mw.language later on. The mediawiki.jqueryMsg.test module now has several failures which is annoying but should not block the merge for now because they were failing under Jasmine as well, this is a known bug in jqueryMsg, a few cases don't work in js yet. To be investigated (12/66 fail currently). Change-Id: I243d055d6f5129fd9fd760943d05c7cd210d84bf --- D tests/jasmine/.htaccess D tests/jasmine/SpecRunner.html D tests/jasmine/lib/jasmine-1.0.1/MIT.LICENSE D tests/jasmine/lib/jasmine-1.0.1/jasmine-html.js D tests/jasmine/lib/jasmine-1.0.1/jasmine.css D tests/jasmine/lib/jasmine-1.0.1/jasmine.js D tests/jasmine/spec/mediawiki.jqueryMsg.spec.data.js D tests/jasmine/spec/mediawiki.jqueryMsg.spec.js D tests/jasmine/spec_makers/makeJqueryMsgSpec.php M tests/qunit/QUnitTestResources.php A tests/qunit/data/generateJqueryMsgData.php A tests/qunit/data/mediawiki.jqueryMsg.data.js M tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js 13 files changed, 703 insertions(+), 3,816 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/23493 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I243d055d6f5129fd9fd760943d05c7cd210d84bf Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle Gerrit-Reviewer: Catrope Gerrit-Reviewer: Hashar Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Santhosh Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] refactor selenum wait methods - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: refactor selenum wait methods .. refactor selenum wait methods - changed the DOM element to wait for - just one wait_for_entity_to_load method - removed wait_for_aliases and wait_for_sitelinks Change-Id: If0b7ae252955ab0148fe8af4b626f4032ef37394 --- M client/tests/selenium/interwiki/interwiki_spec.rb M repo/tests/selenium/aliases/aliases_bugs_spec.rb M repo/tests/selenium/aliases/aliases_spec.rb M repo/tests/selenium/client/client_repo_spec.rb M repo/tests/selenium/item/blocked_user_spec.rb M repo/tests/selenium/item/delete_item_spec.rb M repo/tests/selenium/item/edit_conflict_spec.rb M repo/tests/selenium/item/editonoff_spec.rb M repo/tests/selenium/item/protected_page_spec.rb M repo/tests/selenium/property/property_view_spec.rb M repo/tests/selenium/sitelinks/sitelinks_spec.rb M repo/tests/selenium/special/item_by_title_spec.rb M repo/tests/selenium/special/recent_changes_spec.rb M repo/tests/selenium/special/restore_spec.rb M repo/tests/selenium/special/rollback_spec.rb M repo/tests/selenium/special/search_spec.rb M repo/tests/selenium/special/undelete_spec.rb M repo/tests/selenium/special/undo_spec.rb M selenium/lib/modules/alias_module.rb M selenium/lib/modules/sitelink_module.rb M selenium/lib/pages/entity_page.rb 21 files changed, 19 insertions(+), 92 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27176 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0b7ae252955ab0148fe8af4b626f4032ef37394 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Some work on ApiCreateClaim - change (mediawiki...Wikibase[master])
John Erling Blad has submitted this change and it was merged. Change subject: Some work on ApiCreateClaim .. Some work on ApiCreateClaim Change-Id: Ia7a692739c2c637cca6b8a38fabf5f7f9b3e5386 --- M repo/includes/api/ApiCreateClaim.php M repo/includes/content/EntityContentFactory.php 2 files changed, 112 insertions(+), 3 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27120 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a692739c2c637cca6b8a38fabf5f7f9b3e5386 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adjust DOM structure of aliases and add edit button for non ... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has submitted this change and it was merged. Change subject: Adjust DOM structure of aliases and add edit button for non JS-version .. Adjust DOM structure of aliases and add edit button for non JS-version For aliases, the required div.wb-gridhelper for styling is now part of the generated DOM already and won't be generated in JavaScript. The 'edit' button will be placed as sibling of the '.wb-aliases div.wb-gridhelper' node. This is equivalent to the 'add' button for aliases in JavaScript mode. In JavaScript mode the 'edit' button is placed in '.wb-aliases .wb-ui-propertyedittool-editablevalue'. It should not be necessary to differentiate between 'add' and 'edit' button in non-JS though. patch set 2: proper clean-up of DOM structure patch set 3: rebase patch set 4: fix regarding QUnit test Change-Id: Ic063b6103104f187781ce376b4ba20ce8ba5bc5c --- M repo/includes/EntityView.php M repo/resources/wikibase.startup.js M repo/resources/wikibase.ui.AliasesEditTool.js M repo/resources/wikibase.ui.PropertyEditTool.EditableAliases.js M repo/resources/wikibase.ui.PropertyEditTool.EditableValue.ListInterface.js M repo/resources/wikibase.ui.PropertyEditTool.js M repo/resources/wikibase.utilities/wikibase.utilities.jQuery.ui.tagadata/wikibase.utilities.jQuery.ui.tagadata.js M repo/tests/qunit/wikibase.ui.AliasesEditTool.tests.js 8 files changed, 42 insertions(+), 26 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26599 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic063b6103104f187781ce376b4ba20ce8ba5bc5c Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add profiling for DB interaction and make methods non-static... - change (mediawiki/core[master])
Siebrand has uploaded a new change for review. Change subject: Add profiling for DB interaction and make methods non-static where possible .. Add profiling for DB interaction and make methods non-static where possible * Add profiling when interacting with database. * CategoryViewer::columnList() and CategoryViewer::shortList() are no longer static. Didn't find any additional callers in core or 170 checked extensions. * Reformat code. Change-Id: Iee18ffeab422bdd2581aab7cab0eab482aec3a80 --- M includes/Category.php M includes/CategoryViewer.php M includes/Categoryfinder.php 3 files changed, 80 insertions(+), 47 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/79/27179/1 -- To view, visit https://gerrit.wikimedia.org/r/27179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee18ffeab422bdd2581aab7cab0eab482aec3a80 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: If1d1841a0247180668e061c32d36112b53451801 --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 30 insertions(+), 9 deletions(-) -- To view, visit https://gerrit.wikimedia.org/r/27177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1d1841a0247180668e061c32d36112b53451801 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial specification of new API serialization method with s... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Initial specification of new API serialization method with some implementation examples .. Initial specification of new API serialization method with some implementation examples Change-Id: I263e557a57dea6d4d99ea541ce2d5ca983b1e501 --- A repo/includes/api/serializers/ApiSerializer.php A repo/includes/api/serializers/EntitySerializer.php 2 files changed, 169 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/78/27178/1 -- To view, visit https://gerrit.wikimedia.org/r/27178 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I263e557a57dea6d4d99ea541ce2d5ca983b1e501 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update default settings to sort by code order - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: update default settings to sort by code order .. update default settings to sort by code order Nearly all Wikipedias sort the links by code order This can be a default setting, which still can be overridden in cases where another sort order is used. Change-Id: Ie7e23f2621a76c282b013c3a2ef5c248f58ed912 --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27152 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7e23f2621a76c282b013c3a2ef5c248f58ed912 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: If1d1841a0247180668e061c32d36112b53451801 --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 30 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/77/27177/1 -- To view, visit https://gerrit.wikimedia.org/r/27177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1d1841a0247180668e061c32d36112b53451801 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
