[MediaWiki-commits] [Gerrit] rm unused $egWBRemoteTitleNormalization var from MediaWikiSi... - change (mediawiki/core[master])

2012-10-26 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: rm unused $egWBRemoteTitleNormalization var from 
MediaWikiSite.php
..


rm unused $egWBRemoteTitleNormalization var from MediaWikiSite.php

Change-Id: I8151b79f97ac7fea547a974ad64d404ff881a2e2
---
M includes/site/MediaWikiSite.php
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Hoo man: Looks good to me, but someone else must approve
  IAlex: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8151b79f97ac7fea547a974ad64d404ff881a2e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Platonides 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] The class is named Revision, no need to shout its name :) Re... - change (mediawiki/core[master])

2012-10-26 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged.

Change subject: The class is named Revision, no need to shout its name :) 
Remove a couple of unused globals.
..


The class is named Revision, no need to shout its name :)
Remove a couple of unused globals.

Change-Id: I750536bc05ed7a5433840b916b17df93d30da5bf
---
M maintenance/refreshLinks.php
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Hoo man: Looks good to me, but someone else must approve
  IAlex: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I750536bc05ed7a5433840b916b17df93d30da5bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed topfails query to not return dupes and order by score. - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has submitted this change and it was merged.

Change subject: Fixed topfails query to not return dupes and order by score.
..


Fixed topfails query to not return dupes and order by score.

Change-Id: I9027ef785148e62020e6c3f2fd0ccddb1dd5b121
---
M js/tests/server/server.js
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  GWicke: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9027ef785148e62020e6c3f2fd0ccddb1dd5b121
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: MarkTraceur 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed topfails query to not return dupes and order by score. - change (mediawiki...Parsoid[master])

2012-10-26 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review.

Change subject: Fixed topfails query to not return dupes and order by score.
..

Fixed topfails query to not return dupes and order by score.

Change-Id: I9027ef785148e62020e6c3f2fd0ccddb1dd5b121
---
M js/tests/server/server.js
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/20/30320/1
--
To view, visit https://gerrit.wikimedia.org/r/30320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9027ef785148e62020e6c3f2fd0ccddb1dd5b121
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] SRF 1.8 pre-release clean-up - change (mediawiki...SemanticResultFormats[master])

2012-10-26 Thread Mwjames (Code Review)
Mwjames has submitted this change and it was merged.

Change subject: SRF 1.8 pre-release clean-up
..


SRF 1.8 pre-release clean-up

+ Use mw-small-spinner and util.spinner.hide for better
maintainability
+ Move some formats into the semanticFormats namespace
+ Fix gallery (overlay/redirect) icon display for IE
+ Gallery top left icon if shown will point to the original image


Change-Id: Iaf3a214c72a964be3a9c51a7c87d8bd7e0a2f045
---
M SRF_Resources.php
M SRF_Utils.php
M formats/calendar/resources/ext.srf.eventcalendar.js
D formats/d3/resources/chart/ext.srf.d3.chart.bubble.js
D formats/d3/resources/chart/ext.srf.d3.chart.treemap.js
R formats/d3/resources/ext.srf.d3.chart.bubble.css
A formats/d3/resources/ext.srf.d3.chart.bubble.js
R formats/d3/resources/ext.srf.d3.chart.treemap.css
A formats/d3/resources/ext.srf.d3.chart.treemap.js
M formats/dygraphs/resources/ext.srf.dygraphs.js
M formats/gallery/resources/ext.srf.gallery.carousel.js
M formats/gallery/resources/ext.srf.gallery.overlay.css
M formats/gallery/resources/ext.srf.gallery.overlay.js
M formats/gallery/resources/ext.srf.gallery.redirect.css
M formats/gallery/resources/ext.srf.gallery.redirect.js
M formats/gallery/resources/ext.srf.gallery.slideshow.js
M formats/jqplot/resources/ext.srf.jqplot.chart.js
M formats/sparkline/resources/ext.srf.sparkline.js
M formats/tagcloud/resources/ext.srf.tagcloud.sphere.js
M formats/tagcloud/resources/ext.srf.tagcloud.wordcloud.js
M formats/timeseries/resources/ext.srf.timeseries.flot.js
M formats/widget/SRF_PageWidget.php
M formats/widget/resources/ext.srf.listwidget.js
M formats/widget/resources/ext.srf.pagewidget.carousel.js
M resources/ext.srf.css
M resources/ext.srf.util.js
D resources/images/spinner.gif
27 files changed, 450 insertions(+), 335 deletions(-)

Approvals:
  Mwjames: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf3a214c72a964be3a9c51a7c87d8bd7e0a2f045
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Mwjames 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Markus Kroetzsch 
Gerrit-Reviewer: Mwjames 
Gerrit-Reviewer: Nischayn22 
Gerrit-Reviewer: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add extensions for dewikivoyage into labs - change (operations/mediawiki-config[master])

2012-10-26 Thread CSteipp (Code Review)
CSteipp has uploaded a new change for review.

Change subject: Add extensions for dewikivoyage into labs
..

Add extensions for dewikivoyage into labs

(Assuming this works as expected for .de, we can do the other 5 next)

Change-Id: I3c4033bc4a4dc584f2d01c11b0929cde12f7445b
---
M wmf-config/CommonSettings-wmflabs.php
M wmf-config/InitialiseSettings.php
2 files changed, 39 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/19/30319/1
--
To view, visit https://gerrit.wikimedia.org/r/30319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c4033bc4a4dc584f2d01c11b0929cde12f7445b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: CSteipp 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 7497) use redirect tag to set page_is_redirect field - change (mediawiki...mwdumper[master])

2012-10-26 Thread Bean49 (Code Review)
Bean49 has uploaded a new change for review.

Change subject: (bug 7497) use redirect tag to set page_is_redirect field
..

(bug 7497) use redirect tag to set page_is_redirect field

Replaces isRedirect() method of Revision with isRedirect property
of Page, and uses the redirect tag to set the page_is_redirect column of
the page table. The old method was redundant and it did not produce right
results for borderline syntax and for localized instances.

Change-Id: I27afb2a3ac9affeea0a357596e19be2852afaa55
---
M src/org/mediawiki/importer/Page.java
M src/org/mediawiki/importer/Revision.java
M src/org/mediawiki/importer/SqlWriter14.java
M src/org/mediawiki/importer/SqlWriter15.java
M src/org/mediawiki/importer/XmlDumpReader.java
5 files changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/mwdumper 
refs/changes/18/30318/1
--
To view, visit https://gerrit.wikimedia.org/r/30318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27afb2a3ac9affeea0a357596e19be2852afaa55
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/mwdumper
Gerrit-Branch: master
Gerrit-Owner: Bean49 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add constant and system fields, sample acux model. - change (mediawiki...EventLogging[master])

2012-10-26 Thread Spage (Code Review)
Spage has uploaded a new change for review.

Change subject: Add constant and system fields, sample acux model.
..

Add constant and system fields, sample acux model.

Focus on the acux_assign JSON model, is that a good syntax?
The JS code implements constant value logging; system fields are TODO --
  if ( typeof eventLog.system[ 'gen_' + field] ) === 'function' ) ...

Change-Id: Idf1f6c14ad2fcb12e701cf89f48215de22f51fc2
---
M modules/ext.EventLogging.dataModels.js
M modules/ext.EventLogging.js
2 files changed, 35 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/17/30317/1
--
To view, visit https://gerrit.wikimedia.org/r/30317
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf1f6c14ad2fcb12e701cf89f48215de22f51fc2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Spage 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 41428) Fix 'enum' usage; + misc. improvements - change (mediawiki...EventLogging[master])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: (Bug 41428) Fix 'enum' usage; + misc. improvements
..


(Bug 41428) Fix 'enum' usage; + misc. improvements

- Enumerate globals in .jshintrc and organize
  configurations.
- Add closure to tests file; use function form of "use
  strict".
- Quote 'enum' property
- Permit dangling '_' for special case (_db and _id).
- References: module -> QUnit.module, test -> QUnit.test.
- Rename modules/dataModels.js to
  modules/ext.EventLogging.dataModels.js
- Remove init {} from ext.EventLogging.dataModels.js
- Fix order in $wgResourceModules, ext.EventLogging.js
  first, ext.EventLogging.dataModels.js second.
- Replace init {} in ext.EventLogging.js with regular
  assignment.
- Replace call to JSON.stringify with $.toJSON.
- Use __DIR__ instead of dirname( __FILE__ ).
- URI_MAX_BYTES -> uriMaxBytes
- Space after 'switch' operator
- Drop unused hook handler.
- If wgEventLoggingBaseUri undefined, emit wfDebug warning
  in PHP and mw.log() in JS.

Change-Id: I810bddad3b8bbabf2daaf1a26444f20a1224775d
---
M .jshintrc
M EventLogging.hooks.php
M EventLogging.php
R modules/ext.EventLogging.dataModels.js
M modules/ext.EventLogging.js
M tests/ext.EventLogging.tests.js
6 files changed, 181 insertions(+), 178 deletions(-)

Approvals:
  Ori.livneh: 
  Spage: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30131
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I810bddad3b8bbabf2daaf1a26444f20a1224775d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Spage 
Gerrit-Reviewer: Tychay 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add integer type + tests; allow bit-fiddling in .jshintrc - change (mediawiki...EventLogging[master])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Add integer type + tests; allow bit-fiddling in .jshintrc
..

Add integer type + tests; allow bit-fiddling in .jshintrc

The JSON Schema draft spec specifies distinct "number" and
"integer" types -- happily, because reflection to SQL hinges
on drawing a distinction between ints and floats.

Change-Id: I620512d8e2a9aae794aa751d81917a28f2a3fa16
---
M .jshintrc
M modules/ext.EventLogging.js
M tests/ext.EventLogging.tests.js
3 files changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/16/30316/1
--
To view, visit https://gerrit.wikimedia.org/r/30316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I620512d8e2a9aae794aa751d81917a28f2a3fa16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Prototype) Automatic reflection of JSON Schema to SQL - change (analytics/glass[master])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: (Prototype) Automatic reflection of JSON Schema to SQL
..

(Prototype) Automatic reflection of JSON Schema to SQL

Change-Id: Id90bb153706616024d122a599868ebd5a768005f
---
A glass/models.json
A glass/reflect.py
2 files changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/glass 
refs/changes/15/30315/1
--
To view, visit https://gerrit.wikimedia.org/r/30315
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id90bb153706616024d122a599868ebd5a768005f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/glass
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41443) Link in password reset is broken - change (mediawiki/core[master])

2012-10-26 Thread Hoo man (Code Review)
Hoo man has uploaded a new change for review.

Change subject: (bug 41443) Link in password reset is broken
..

(bug 41443) Link in password reset is broken

The link in the password reset email was broken, because the
paramters for passwordreset-emailtext-user were over-escaped.
I've fixed this with passing the link unescaped while leaving
the other parameters escaped.

Change-Id: If2665a419f5ee11602d4a69b60f7c4786f816ee2
---
M includes/specials/SpecialPasswordReset.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/14/30314/1
--
To view, visit https://gerrit.wikimedia.org/r/30314
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2665a419f5ee11602d4a69b60f7c4786f816ee2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Round-trip attribute keys with tags or comments - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has uploaded a new change for review.

Change subject: Round-trip attribute keys with tags or comments
..

Round-trip attribute keys with tags or comments

Example text that round-trips now:

{| class="wikitable" border="1" bla [[foo]] bar<\hiddentext>

TODO: Support source-based round-tripping for attribute values too, and add
ksrc/vsrc for other kinds of attributes as well if they parse to non-string
tokens in the tokenizer.

Change-Id: Ica794140231a9e2c4446e4b5c5f913c0195201c9
---
M js/lib/ext.core.AttributeExpander.js
M js/lib/ext.core.Sanitizer.js
M js/lib/pegTokenizer.pegjs.txt
3 files changed, 38 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/13/30313/1
--
To view, visit https://gerrit.wikimedia.org/r/30313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica794140231a9e2c4446e4b5c5f913c0195201c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup tool API - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Trevor Parscal (Code Review)
Trevor Parscal has uploaded a new change for review.

Change subject: Cleanup tool API
..

Cleanup tool API

* Moved to tool specific configuration to static properties (left tool instance 
specific stuff in the constructors)
* Added documentation for tool configurations
* Centralized typePattern matching for inspectors

Change-Id: Ieacf61b320c10fd37ea69a05e543313fa990b403
---
M modules/ve/ui/inspectors/ve.ui.LinkInspector.js
M modules/ve/ui/tools/buttons/ve.ui.BoldButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.BulletButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.IndentButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.ItalicButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.LinkButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.NumberButtonTool.js
M modules/ve/ui/tools/buttons/ve.ui.OutdentButtonTool.js
M modules/ve/ui/tools/ve.ui.AnnotationButtonTool.js
M modules/ve/ui/tools/ve.ui.ButtonTool.js
M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js
M modules/ve/ui/tools/ve.ui.InspectorButtonTool.js
M modules/ve/ui/tools/ve.ui.ListButtonTool.js
M modules/ve/ui/ve.ui.InspectorFactory.js
M modules/ve/ui/ve.ui.Tool.js
M modules/ve/ve.Action.js
16 files changed, 147 insertions(+), 69 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/12/30312/1
--
To view, visit https://gerrit.wikimedia.org/r/30312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieacf61b320c10fd37ea69a05e543313fa990b403
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41443) Don't escape link to site in password reset emai... - change (mediawiki/core[master])

2012-10-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 41443) Don't escape link to site in password reset emails
..

(bug 41443) Don't escape link to site in password reset emails

Change-Id: Ib71108f168c9ec99d25949a53b82521673ed01e1
---
M includes/specials/SpecialPasswordReset.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/11/30311/1
--
To view, visit https://gerrit.wikimedia.org/r/30311
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib71108f168c9ec99d25949a53b82521673ed01e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add Ex:MergeUser and Ex:GeoCrumbs to Wikivoyage - change (operations/mediawiki-config[master])

2012-10-26 Thread CSteipp (Code Review)
CSteipp has uploaded a new change for review.

Change subject: Add Ex:MergeUser and Ex:GeoCrumbs to Wikivoyage
..

Add Ex:MergeUser and Ex:GeoCrumbs to Wikivoyage

Change-Id: Ica436ad9cdd04ec678d76a5f27add5bebe895474
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
2 files changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/10/30310/1
--
To view, visit https://gerrit.wikimedia.org/r/30310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica436ad9cdd04ec678d76a5f27add5bebe895474
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: CSteipp 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Use avconv by default - change (mediawiki...TimedMediaHandler[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Use avconv by default
..


Use avconv by default

ffmpeg command in Ubuntu 12.04 has some issues with seeking that are not
present in avconv. Switching to make thumb extraction faster and get rid
of deprecated warning in error messages.

Change-Id: I798804cfb1375302fa3af02660684673090d177a
---
M README
M TimedMediaHandler.php
2 files changed, 17 insertions(+), 48 deletions(-)

Approvals:
  Aaron Schulz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30133
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I798804cfb1375302fa3af02660684673090d177a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Mdale 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update title setting when changing history - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: update title setting when changing history
..

update title setting when changing history

modules might want to make use of it
this ensures the value is accurate
(updates setting function to accept a second value for saving)

Change-Id: Ica90765eb571275f85b0dba273f9658f54c39a56
---
M javascripts/common/mf-application.js
M javascripts/common/mf-history.js
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/09/30309/1
--
To view, visit https://gerrit.wikimedia.org/r/30309
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica90765eb571275f85b0dba273f9658f54c39a56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] correct firstRun check - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: correct firstRun check
..

correct firstRun check

Change-Id: I814445073db6d7928ba36aac3795dca7921a420c
---
M javascripts/common/mf-history.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/08/30308/1
--
To view, visit https://gerrit.wikimedia.org/r/30308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I814445073db6d7928ba36aac3795dca7921a420c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow json files for static content CORS - change (operations/puppet[production])

2012-10-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: Allow json files for static content CORS
..


Allow json files for static content CORS

Change-Id: I438b67aba61ee4658f0db82d2675784a5e8fa5e4
---
M files/apache/apache2.conf.api_appserver
M files/apache/apache2.conf.appserver
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I438b67aba61ee4658f0db82d2675784a5e8fa5e4
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Attempt to fix SSL cert usage for wikidata.org - change (operations/puppet[production])

2012-10-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: Attempt to fix SSL cert usage for wikidata.org
..


Attempt to fix SSL cert usage for wikidata.org

Change-Id: Ib9797a544ea9dcf8edae7e55ccb3a7d65cf52e86
---
M manifests/protoproxy.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9797a544ea9dcf8edae7e55ccb3a7d65cf52e86
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Attempt to fix SSL cert usage for wikidata.org - change (operations/puppet[production])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Attempt to fix SSL cert usage for wikidata.org
..

Attempt to fix SSL cert usage for wikidata.org

Change-Id: Ib9797a544ea9dcf8edae7e55ccb3a7d65cf52e86
---
M manifests/protoproxy.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/30307/1
--
To view, visit https://gerrit.wikimedia.org/r/30307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9797a544ea9dcf8edae7e55ccb3a7d65cf52e86
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] set application/x-font-woff for woff files - change (operations/puppet[production])

2012-10-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: set application/x-font-woff for woff files
..


set application/x-font-woff for woff files

Change-Id: I7b21d49d932a7d416121b2f2554f40b3f6a2f5e6
---
M files/apache/apache2.conf.api_appserver
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nikerabbit: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b21d49d932a7d416121b2f2554f40b3f6a2f5e6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Dont emit in tokenizer since more td-content might fol... - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has submitted this change and it was merged.

Change subject: Dont emit  in tokenizer since more td-content might follow.
..


Dont emit  in tokenizer since more td-content might follow.

* Templates can lead to td-cell content to be put together
  from different parsing contexts -- see example below.
Input : {{echo|{{!}}foo}}{{echo|bar}}
Output: foobar
  Given this, the tokenizer cannot really close a  tag.
  So, eliminated the  token from the tokenizer and letting
  the tree builder close unclosed tags.

* Added a mw:TSRMarker meta tag where the  used to be in
  case the TSR info from that place might be useful.  Similarly,
  added another such marker where  might show up.  In theory,
  we could add these markers to all productions where there is no
  tsr-bearing tag at the end of the production.  However, unsure
  if these marker-tsr tags make a difference at all.  Something
  worth investigating later and getting rid of them if they are
  not useful.

* We have a purely white-space regression in a html2html test --
  the diff is purely syntactic (trailing white-space in td cells)
  which can be fixed by fixing the html output normalizer.

* The following simplified wikitext from en:KingdomOfDenmark
  now roundtrips correctly:

{{col-begin}}
{{col-break|width=70%}}
foo bar baz
{{col-break|width=30%}}
{{Danish regions}}
{{Col-end}}

Change-Id: I1ef6a462122e4e72271748e2f339a28e85f3008a
---
M js/lib/mediawiki.DOMPostProcessor.js
M js/lib/pegTokenizer.pegjs.txt
2 files changed, 28 insertions(+), 8 deletions(-)

Approvals:
  GWicke: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef6a462122e4e72271748e2f339a28e85f3008a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Avoid duplicate "null" change journal entries. - change (mediawiki/core[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Avoid duplicate "null" change journal entries.
..


Avoid duplicate "null" change journal entries.

Change-Id: Ie5625963d4755b7aa7b3ecf3aaca0eb9e9e22cf5
---
M includes/filebackend/FileOp.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5625963d4755b7aa7b3ecf3aaca0eb9e9e22cf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Demon 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Dont emit in tokenizer since more td-content might fol... - change (mediawiki...Parsoid[master])

2012-10-26 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has uploaded a new change for review.

Change subject: Dont emit  in tokenizer since more td-content might follow.
..

Dont emit  in tokenizer since more td-content might follow.

* Templates can lead to td-cell content to be put together
  from different parsing contexts -- see example below.
Input : {{echo|{{!}}foo}}{{echo|bar}}
Output: foobar
  Given this, the tokenizer cannot really close a  tag.
  So, eliminated the  token from the tokenizer and letting
  the tree builder close unclosed tags.

* Added a mw:TSRMarker meta tag where the  used to be in
  case the TSR info from that place might be useful.  Similarly,
  added another such marker where  might show up.  In theory,
  we could add these markers to all productions where there is no
  tsr-bearing tag at the end of the production.  However, unsure
  if these marker-tsr tags make a difference at all.  Something
  worth investigating later and getting rid of them if they are
  not useful.

* We have a purely white-space regression in a html2html test --
  the diff is purely syntactic (trailing white-space in td cells)
  which can be fixed by fixing the html output normalizer.

* The following simplified wikitext from en:KingdomOfDenmark
  now roundtrips correctly:

{{col-begin}}
{{col-break|width=70%}}
foo bar baz
{{col-break|width=30%}}
{{Danish regions}}
{{Col-end}}

Change-Id: I1ef6a462122e4e72271748e2f339a28e85f3008a
---
M js/lib/mediawiki.DOMPostProcessor.js
M js/lib/pegTokenizer.pegjs.txt
2 files changed, 28 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/06/30306/1
--
To view, visit https://gerrit.wikimedia.org/r/30306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ef6a462122e4e72271748e2f339a28e85f3008a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [FileBackend] Simplified FileOpBatch code to have just one "... - change (mediawiki/core[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

Change subject: [FileBackend] Simplified FileOpBatch code to have just one 
"run" function.
..

[FileBackend] Simplified FileOpBatch code to have just one "run" function.

Change-Id: Iae6c8e96e2558588f76f23c1ceb160a6fc372aa8
---
M includes/filebackend/FileOpBatch.php
1 file changed, 11 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/30305/1
--
To view, visit https://gerrit.wikimedia.org/r/30305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae6c8e96e2558588f76f23c1ceb160a6fc372aa8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow callers to force a refresh in fetchProjectInfo(). - change (mediawiki...OpenStackManager[master])

2012-10-26 Thread Andrew Bogott (Code Review)
Andrew Bogott has uploaded a new change for review.

Change subject: Allow callers to force a refresh in fetchProjectInfo().
..

Allow callers to force a refresh in fetchProjectInfo().

We need this to keep the object up-to-date after adding
or deleting members.  This fixes the project-creation bug
that resulted in the creating user being dropped.

Change-Id: Iac8eb5c0c32bcba093f81a80974e22c799190c5f
---
M OpenStackNovaProject.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager 
refs/changes/04/30304/1
--
To view, visit https://gerrit.wikimedia.org/r/30304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac8eb5c0c32bcba093f81a80974e22c799190c5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] allow cleanup templates to be collapsed in sub sections - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: allow cleanup templates to be collapsed in sub sections
..

allow cleanup templates to be collapsed in sub sections

fix mf-toggle-dynamic to send the expanding section rather than
no argument

Change-Id: Icda2d4ae05c744b3572d59b7741ea6d55e4c5b8b
---
M javascripts/modules/mf-cleanuptemplates.js
M javascripts/modules/mf-toggle-dynamic.js
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/03/30303/1
--
To view, visit https://gerrit.wikimedia.org/r/30303
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icda2d4ae05c744b3572d59b7741ea6d55e4c5b8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update carrier names - change (mediawiki...ZeroRatedMobileAccess[master])

2012-10-26 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: update carrier names
..


update carrier names

Change-Id: Ic0f7eae898be4996cb80192d5cda580580833171
---
M ZeroRatedMobileAccess.i18n.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0f7eae898be4996cb80192d5cda580580833171
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: preilly 
Gerrit-Reviewer: preilly 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] update carrier names - change (mediawiki...ZeroRatedMobileAccess[master])

2012-10-26 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: update carrier names
..

update carrier names

Change-Id: Ic0f7eae898be4996cb80192d5cda580580833171
---
M ZeroRatedMobileAccess.i18n.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 
refs/changes/02/30302/1
--
To view, visit https://gerrit.wikimedia.org/r/30302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f7eae898be4996cb80192d5cda580580833171
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: preilly 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [cosmetic] Hide tagToStringFns from view - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has uploaded a new change for review.

Change subject: [cosmetic] Hide tagToStringFns from view
..

[cosmetic] Hide tagToStringFns from view

Define tagToStringFns on the TagTk and SelfclosingTagTk prototypes using
defineProperty with enumerable flag set to false, so that this key is no
longer serialized when JSON.serialize'ing tokens. Very important for --debug
aesthetics.

Change-Id: I8b0f26b3bdfee6ebafe7ee6d471bd0dc6349fae2
---
M js/lib/mediawiki.parser.defines.js
M js/lib/mediawiki.tokenizer.peg.js
2 files changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/01/30301/1
--
To view, visit https://gerrit.wikimedia.org/r/30301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b0f26b3bdfee6ebafe7ee6d471bd0dc6349fae2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Don't revert global log actions - change (mediawiki...AbuseFilter[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Don't revert global log actions
..


Don't revert global log actions

Prevent attempting to revert a global rule's actions, when the action
happened on another wiki.

This is probably a temporary fix. Eventually, we may want to support
having a central administrator revert actions from global rules on
the local wikis.

Change-Id: Idd29596ddc21c37d81528a8ae6ed14367c373c5f
---
M Views/AbuseFilterViewRevert.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Hoo man: Looks good to me, but someone else must approve
  Aaron Schulz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/23514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd29596ddc21c37d81528a8ae6ed14367c373c5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: CSteipp 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Liangent 
Gerrit-Reviewer: Victor Vasiliev 
Gerrit-Reviewer: Werdna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] set application/x-font-woff for woff files - change (operations/puppet[production])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: set application/x-font-woff for woff files
..

set application/x-font-woff for woff files

Change-Id: I7b21d49d932a7d416121b2f2554f40b3f6a2f5e6
---
M files/apache/apache2.conf.api_appserver
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/00/30300/1
--
To view, visit https://gerrit.wikimedia.org/r/30300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b21d49d932a7d416121b2f2554f40b3f6a2f5e6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] $language->prettyTimestamp is expecting 3 arguments - change (mediawiki...Echo[master])

2012-10-26 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged.

Change subject: $language->prettyTimestamp is expecting 3 arguments
..


$language->prettyTimestamp is expecting 3 arguments

Change-Id: I58daf0fd93891bf3d6c7a76d56ffce2c4af5f3b3
---
M api/ApiEchoNotifications.php
M formatters/NotificationFormatter.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alex Monk: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58daf0fd93891bf3d6c7a76d56ffce2c4af5f3b3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Bsitu 
Gerrit-Reviewer: Kaldari 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] only show edit button when logged in - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: only show edit button when logged in
..

only show edit button when logged in

this will minimise noise and give us an idea how existing editors
would use an edit feature

Change-Id: I598763eeb4005d911bb6d8a4bbf4dee4e9d14d07
---
M javascripts/common/mf-navigation.js
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/98/30298/1
--
To view, visit https://gerrit.wikimedia.org/r/30298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I598763eeb4005d911bb6d8a4bbf4dee4e9d14d07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] when saving via mobile append [Via Mobile] to comment - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: when saving via mobile append [Via Mobile] to comment
..

when saving via mobile append [Via Mobile] to comment

Note I'm not i18n this message as we want to get a feel for how many
people use this feature and what kind of edits they make

Change-Id: I79083f5c0b18a49db265b3ce3f7b5c323e17408f
---
M javascripts/actions/mf-edit.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/99/30299/1
--
To view, visit https://gerrit.wikimedia.org/r/30299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79083f5c0b18a49db265b3ce3f7b5c323e17408f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41438) Some MoodBar deletion message creations/changes - change (mediawiki...MoodBar[master])

2012-10-26 Thread Bsitu (Code Review)
Bsitu has submitted this change and it was merged.

Change subject: (bug 41438) Some MoodBar deletion message creations/changes
..


(bug 41438) Some MoodBar deletion message creations/changes

Change-Id: If996ac505fe53de14cf1fd2e445bdbd5647070dd
---
M MoodBar.i18n.php
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Bsitu: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If996ac505fe53de14cf1fd2e445bdbd5647070dd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Bsitu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allow json files for static content CORS - change (operations/puppet[production])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Allow json files for static content CORS
..

Allow json files for static content CORS

Change-Id: I438b67aba61ee4658f0db82d2675784a5e8fa5e4
---
M files/apache/apache2.conf.api_appserver
M files/apache/apache2.conf.appserver
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/97/30297/1
--
To view, visit https://gerrit.wikimedia.org/r/30297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I438b67aba61ee4658f0db82d2675784a5e8fa5e4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug #41434) Converting format across 2 lists with paragraph... - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: (bug #41434) Converting format across 2 lists with paragraphs 
in between fail
..


(bug #41434) Converting format across 2 lists with paragraphs in between fail

Thanks to Roan for suggesting this fix.

Change-Id: I754dc34fbd3aaf2bdcb78bf89bfc896b612b4ee6
---
M modules/ve/actions/ve.FormatAction.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I754dc34fbd3aaf2bdcb78bf89bfc896b612b4ee6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug #41434) Converting format across 2 lists with paragraph... - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Trevor Parscal (Code Review)
Trevor Parscal has uploaded a new change for review.

Change subject: (bug #41434) Converting format across 2 lists with paragraphs 
in between fail
..

(bug #41434) Converting format across 2 lists with paragraphs in between fail

Thanks to Roan for suggesting this fix.

Change-Id: I754dc34fbd3aaf2bdcb78bf89bfc896b612b4ee6
---
M modules/ve/actions/ve.FormatAction.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/95/30295/1
--
To view, visit https://gerrit.wikimedia.org/r/30295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I754dc34fbd3aaf2bdcb78bf89bfc896b612b4ee6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update extension E3Experiments to master - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: Update extension E3Experiments to master
..


Update extension E3Experiments to master

Change-Id: If14fc78b6d8adb4eedbd21f3c6b49548327ae474
---
M extensions/E3Experiments
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30294
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If14fc78b6d8adb4eedbd21f3c6b49548327ae474
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update extension E3Experiments to master - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

Change subject: Update extension E3Experiments to master
..

Update extension E3Experiments to master

Change-Id: If14fc78b6d8adb4eedbd21f3c6b49548327ae474
---
M extensions/E3Experiments
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/30294/1
--
To view, visit https://gerrit.wikimedia.org/r/30294
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If14fc78b6d8adb4eedbd21f3c6b49548327ae474
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Really properly initialize static member before adding stuff... - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Really properly initialize static member before adding stuff to 
it
..


Really properly initialize static member before adding stuff to it

Kill them console log errors 'til they're dead.

Change-Id: I7329f4c869f46a9ef664af8ab49cb2504abdf972
---
M modules/ve/ve.Action.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7329f4c869f46a9ef664af8ab49cb2504abdf972
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Really properly initialize static member before adding stuff... - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Trevor Parscal (Code Review)
Trevor Parscal has uploaded a new change for review.

Change subject: Really properly initialize static member before adding stuff to 
it
..

Really properly initialize static member before adding stuff to it

Kill them console log errors 'til they're dead.

Change-Id: I7329f4c869f46a9ef664af8ab49cb2504abdf972
---
M modules/ve/ve.Action.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/93/30293/1
--
To view, visit https://gerrit.wikimedia.org/r/30293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7329f4c869f46a9ef664af8ab49cb2504abdf972
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] rm unused $egWBRemoteTitleNormalization var from MediaWikiSi... - change (mediawiki/core[master])

2012-10-26 Thread Aude (Code Review)
Aude has uploaded a new change for review.

Change subject: rm unused $egWBRemoteTitleNormalization var from 
MediaWikiSite.php
..

rm unused $egWBRemoteTitleNormalization var from MediaWikiSite.php

Change-Id: I8151b79f97ac7fea547a974ad64d404ff881a2e2
---
M includes/site/MediaWikiSite.php
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/30292/1
--
To view, visit https://gerrit.wikimedia.org/r/30292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8151b79f97ac7fea547a974ad64d404ff881a2e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Properly initialize static member before adding stuff to it - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Properly initialize static member before adding stuff to it
..


Properly initialize static member before adding stuff to it

This was causing a console error

Change-Id: Ic394cf4d4821bd7c03fd32bb9e202801dccde085
---
M modules/ve/ve.Action.js
1 file changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic394cf4d4821bd7c03fd32bb9e202801dccde085
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Properly initialize static member before adding stuff to it - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Trevor Parscal (Code Review)
Trevor Parscal has uploaded a new change for review.

Change subject: Properly initialize static member before adding stuff to it
..

Properly initialize static member before adding stuff to it

This was causing a console error

Change-Id: Ic394cf4d4821bd7c03fd32bb9e202801dccde085
---
M modules/ve/ve.Action.js
1 file changed, 12 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/91/30291/1
--
To view, visit https://gerrit.wikimedia.org/r/30291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic394cf4d4821bd7c03fd32bb9e202801dccde085
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Avoid duplicate "null" change journal entries. - change (mediawiki/core[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

Change subject: Avoid duplicate "null" change journal entries.
..

Avoid duplicate "null" change journal entries.

Change-Id: Ie5625963d4755b7aa7b3ecf3aaca0eb9e9e22cf5
---
M includes/filebackend/FileOp.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/30290/1
--
To view, visit https://gerrit.wikimedia.org/r/30290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5625963d4755b7aa7b3ecf3aaca0eb9e9e22cf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] make sure cleanup templates are re-initialised on a dynamic ... - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: make sure cleanup templates are re-initialised on a dynamic 
page load
..

make sure cleanup templates are re-initialised on a dynamic page load

Change-Id: I0145a06edc4f7a39cf77d7e70b132e346523bd2c
---
M javascripts/modules/mf-cleanuptemplates.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/89/30289/1
--
To view, visit https://gerrit.wikimedia.org/r/30289
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0145a06edc4f7a39cf77d7e70b132e346523bd2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Whitespace and comment cleanup on ve.ce.SurfaceObserver - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Whitespace and comment cleanup on ve.ce.SurfaceObserver
..


Whitespace and comment cleanup on ve.ce.SurfaceObserver

Change-Id: Ice4058f1041f3d0118c7955122b8ea4d538790e0
---
M modules/ve/ce/ve.ce.SurfaceObserver.js
1 file changed, 15 insertions(+), 4 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice4058f1041f3d0118c7955122b8ea4d538790e0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ve.dm.Node.hasAttributes() - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Add ve.dm.Node.hasAttributes()
..


Add ve.dm.Node.hasAttributes()

Will be used in future commits to reduce duplication.

Change-Id: Ibde934d5a55b980010e84b6242f8d968e88cea54
---
M modules/ve/dm/ve.dm.Node.js
1 file changed, 37 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibde934d5a55b980010e84b6242f8d968e88cea54
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ve.dm.Node.hasMatchingAncestor() - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Add ve.dm.Node.hasMatchingAncestor()
..


Add ve.dm.Node.hasMatchingAncestor()

Will be used in future commits to avoid traversing up the tree and
comparing type and attributes.

Change-Id: I993f4cbe20018406dbb4a3c9d1ce2f8766f8e1ba
---
M modules/ve/dm/ve.dm.Node.js
1 file changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I993f4cbe20018406dbb4a3c9d1ce2f8766f8e1ba
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ve.Action, ve.ActionFactory, subclasses - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Add ve.Action, ve.ActionFactory, subclasses
..


Add ve.Action, ve.ActionFactory, subclasses

Moved implementation of all the tools into a reusable action
system. To execute an action just call

surface.execute( actionName, method, param1, param2, ... );

This helps keep tools simple, and opens the door to key commands
reusing the same code.

Change-Id: Ie786fa3d38d1ea17d39b5dfb8eeeb5f2256267ce
---
M VisualEditor.php
M demos/ve/index.php
A modules/ve/actions/ve.AnnotationAction.js
A modules/ve/actions/ve.FormatAction.js
A modules/ve/actions/ve.HistoryAction.js
A modules/ve/actions/ve.IndentationAction.js
A modules/ve/actions/ve.InspectorAction.js
A modules/ve/actions/ve.ListAction.js
M modules/ve/dm/ve.dm.SurfaceFragment.js
A modules/ve/ve.Action.js
A modules/ve/ve.ActionFactory.js
M modules/ve/ve.Surface.js
M modules/ve/ve.js
13 files changed, 916 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29905
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie786fa3d38d1ea17d39b5dfb8eeeb5f2256267ce
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add ve.dm.Surface.has{Past,Future}State, add docs - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Add ve.dm.Surface.has{Past,Future}State, add docs
..


Add ve.dm.Surface.has{Past,Future}State, add docs

Will be used by the history tools in a future commit, providing
a reasonable interface to this information rather than the tool
reaching into private members.

Change-Id: I0472349968e9b48ec17eb47b6845ec9ccf3811e2
---
M modules/ve/dm/ve.dm.Surface.js
1 file changed, 59 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0472349968e9b48ec17eb47b6845ec9ccf3811e2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] UI context reorganization, inspector rewrite, iframe refacto... - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: UI context reorganization, inspector rewrite, iframe refactor, 
icon generalization
..


UI context reorganization, inspector rewrite, iframe refactor, icon 
generalization

* Only show the inspector if the selected text has an inspectable annotation
* Replace the inline menu with a toolbar containing inspectable annotations
* Change the appearance of the inspector to match new mockups
* Add the trash can icon for removing annotations
* Move iframe handling code into a class that manages all that nonsense

Change-Id: I840f72426f9a9e50054a28de950393f0e9913153
---
M VisualEditor.i18n.php
M VisualEditor.php
M demos/ve/index.php
M modules/ve/ce/ve.ce.Surface.js
M modules/ve/ui/inspectors/ve.ui.LinkInspector.js
M modules/ve/ui/styles/ve.ui.Context.css
M modules/ve/ui/styles/ve.ui.Icons-raster.css
M modules/ve/ui/styles/ve.ui.Icons-vector.css
M modules/ve/ui/styles/ve.ui.Inspector.Icons-raster.css
M modules/ve/ui/styles/ve.ui.Inspector.Icons-vector.css
M modules/ve/ui/styles/ve.ui.Inspector.css
M modules/ve/ui/styles/ve.ui.Menu.css
M modules/ve/ui/ve.ui.Context.js
A modules/ve/ui/ve.ui.Frame.js
M modules/ve/ui/ve.ui.Inspector.js
A modules/ve/ui/ve.ui.InspectorFactory.js
M modules/ve/ui/ve.ui.Menu.js
M modules/ve/ui/ve.ui.js
M modules/ve/ve.Surface.js
19 files changed, 599 insertions(+), 562 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I840f72426f9a9e50054a28de950393f0e9913153
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add commands to ve.Surface - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Add commands to ve.Surface
..


Add commands to ve.Surface

First stab at a simple command interface. This and commandFactory
will be refactored significantly before this code is put into
action.

Change-Id: I0de5d3271198c987baf06fb3011aebdc1671f498
---
M modules/ve/ve.Surface.js
1 file changed, 116 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0de5d3271198c987baf06fb3011aebdc1671f498
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Tools changes - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: Tools changes
..


Tools changes

* Rewrite of all tools, dramatically simplifiying them and decreasing
  duplication
* Tools are now created using a tool factory instead of
  a make-shift facility built into the toolbar
* All UI object have a surface or a toolbar reference instead of a
  surface view

Change-Id: I589ecba36bf715b452d03c8fd5c0547dc3c1dc61
---
M VisualEditor.php
M demos/ve/index.php
A modules/ve/ui/styles/ve.ui.Tool.css
M modules/ve/ui/styles/ve.ui.Toolbar.css
A modules/ve/ui/tools/buttons/ve.ui.BoldButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.BulletButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.ClearButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.IndentButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.ItalicButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.LinkButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.NumberButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.OutdentButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.RedoButtonTool.js
A modules/ve/ui/tools/buttons/ve.ui.UndoButtonTool.js
A modules/ve/ui/tools/dropdowns/ve.ui.FormatDropdownTool.js
M modules/ve/ui/tools/ve.ui.AnnotationButtonTool.js
M modules/ve/ui/tools/ve.ui.ButtonTool.js
D modules/ve/ui/tools/ve.ui.ClearButtonTool.js
M modules/ve/ui/tools/ve.ui.DropdownTool.js
D modules/ve/ui/tools/ve.ui.FormatDropdownTool.js
D modules/ve/ui/tools/ve.ui.HistoryButtonTool.js
M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js
A modules/ve/ui/tools/ve.ui.InspectorButtonTool.js
M modules/ve/ui/tools/ve.ui.ListButtonTool.js
M modules/ve/ui/ve.ui.Tool.js
A modules/ve/ui/ve.ui.ToolFactory.js
M modules/ve/ui/ve.ui.Toolbar.js
M modules/ve/ui/ve.ui.js
M modules/ve/ve.Surface.js
29 files changed, 1,224 insertions(+), 1,210 deletions(-)

Approvals:
  Catrope: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/29907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I589ecba36bf715b452d03c8fd5c0547dc3c1dc61
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Robmoen 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] remove borders from th and td elements (bug 37222) - change (mediawiki...MobileFrontend[master])

2012-10-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review.

Change subject: remove borders from th and td elements (bug 37222)
..

remove borders from th and td elements (bug 37222)

looking at logs not clear they were added for any reason

Change-Id: I14f4d0897a04d961fc6eb77fbc06576296532720
---
M stylesheets/common/mf-common.css
M stylesheets/less/common/mf-common.less
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/88/30288/1
--
To view, visit https://gerrit.wikimedia.org/r/30288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I14f4d0897a04d961fc6eb77fbc06576296532720
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] The class is named Revision, no need to shout its name :) Re... - change (mediawiki/core[master])

2012-10-26 Thread Platonides (Code Review)
Platonides has uploaded a new change for review.

Change subject: The class is named Revision, no need to shout its name :) 
Remove a couple of unused globals.
..

The class is named Revision, no need to shout its name :)
Remove a couple of unused globals.

Change-Id: I750536bc05ed7a5433840b916b17df93d30da5bf
---
M maintenance/refreshLinks.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/30287/1
--
To view, visit https://gerrit.wikimedia.org/r/30287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I750536bc05ed7a5433840b916b17df93d30da5bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Eat tags in attribute names - change (mediawiki...Parsoid[master])

2012-10-26 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has submitted this change and it was merged.

Change subject: Eat tags in attribute names
..


Eat tags in attribute names

This accepts wikitext like this fun snippet from
[[:en:2002 Australian Formula 3 season]]:
{| class="wikitable" border="1" bla generated with..<\hiddentext>

This still fails to round-trip, along with sanitizer-stripped key-only
attributes in general. At least it switches this from a semantic to a
purely syntactic diff.

TODO: Fix invalid key-only attribute round-tripping in general. Minimal
example:


This will also fix round-tripping for this the more complex test case above.

Change-Id: I1864ec9e5586ecf465d3ae0689f638e284f1dd32
---
M js/lib/pegTokenizer.pegjs.txt
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Subramanya Sastry: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1864ec9e5586ecf465d3ae0689f638e284f1dd32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 
Gerrit-Reviewer: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41438) Some MoodBar deletion message creations/changes - change (mediawiki...MoodBar[master])

2012-10-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review.

Change subject: (bug 41438) Some MoodBar deletion message creations/changes
..

(bug 41438) Some MoodBar deletion message creations/changes

Change-Id: If996ac505fe53de14cf1fd2e445bdbd5647070dd
---
M MoodBar.i18n.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoodBar 
refs/changes/86/30286/1
--
To view, visit https://gerrit.wikimedia.org/r/30286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If996ac505fe53de14cf1fd2e445bdbd5647070dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 37843) Trying to edit a blank page fails - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Trevor Parscal (Code Review)
Trevor Parscal has submitted this change and it was merged.

Change subject: (bug 37843) Trying to edit a blank page fails
..


(bug 37843) Trying to edit a blank page fails

Explicitly check for false, because the empty string does not signify a
failure.

Change-Id: I8857d39e1a20080c8419c6165be2b5ad0cdbacd2
---
M ApiVisualEditor.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Trevor Parscal: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8857d39e1a20080c8419c6165be2b5ad0cdbacd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Trevor Parscal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] A little cleanup in gender - change (mediawiki/core[master])

2012-10-26 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review.

Change subject: A little cleanup in gender
..

A little cleanup in gender

Documentation and whitespace.

Change-Id: Ia28ab9eee8d1fb6301532d820f7f8cfd2f8a5146
---
M resources/mediawiki/mediawiki.jqueryMsg.js
1 file changed, 11 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/30285/1
--
To view, visit https://gerrit.wikimedia.org/r/30285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia28ab9eee8d1fb6301532d820f7f8cfd2f8a5146
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amire80 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix round-tripping for sanitizer-stripped key-only attribute... - change (mediawiki...Parsoid[master])

2012-10-26 Thread Subramanya Sastry (Code Review)
Subramanya Sastry has submitted this change and it was merged.

Change subject: Fix round-tripping for sanitizer-stripped key-only attributes
..


Fix round-tripping for sanitizer-stripped key-only attributes

Fixes round-tripping for test cases like .

Two more round-trip mode parserTests are passing.

Change-Id: Id47548cd3dcad2d73c3f1d897fff5c8716f61d77
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Subramanya Sastry: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id47548cd3dcad2d73c3f1d897fff5c8716f61d77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 
Gerrit-Reviewer: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix sidebar HTML escaping in CologneBlue (again) - change (mediawiki/core[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged.

Change subject: fix sidebar HTML escaping in CologneBlue (again)
..


fix sidebar HTML escaping in CologneBlue (again)

Followup to I6df92c62.

Change-Id: If9394a6223da987dc363057e276c7f754acc06a8
---
M skins/CologneBlue.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9394a6223da987dc363057e276c7f754acc06a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Daniel Friesen 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Minor documentation fix. - change (mediawiki/core[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Minor documentation fix.
..


Minor documentation fix.

Change-Id: I4efc89b4b4149caba62663a7b56f0f57eb9c6b52
---
M includes/filebackend/filejournal/FileJournal.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4efc89b4b4149caba62663a7b56f0f57eb9c6b52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix round-tripping for sanitizer-stripped key-only attribute... - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has uploaded a new change for review.

Change subject: Fix round-tripping for sanitizer-stripped key-only attributes
..

Fix round-tripping for sanitizer-stripped key-only attributes

Fixes round-tripping for test cases like .

Two more round-trip mode parserTests are passing.

Change-Id: Id47548cd3dcad2d73c3f1d897fff5c8716f61d77
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/84/30284/1
--
To view, visit https://gerrit.wikimedia.org/r/30284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id47548cd3dcad2d73c3f1d897fff5c8716f61d77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix sidebar HTML escaping in CologneBlue (again) - change (mediawiki/core[master])

2012-10-26 Thread Matmarex (Code Review)
Matmarex has uploaded a new change for review.

Change subject: fix sidebar HTML escaping in CologneBlue (again)
..

fix sidebar HTML escaping in CologneBlue (again)

Followup to I6df92c62.

Change-Id: If9394a6223da987dc363057e276c7f754acc06a8
---
M skins/CologneBlue.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/30283/1
--
To view, visit https://gerrit.wikimedia.org/r/30283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9394a6223da987dc363057e276c7f754acc06a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Minor documentation fix. - change (mediawiki/core[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

Change subject: Minor documentation fix.
..

Minor documentation fix.

Change-Id: I4efc89b4b4149caba62663a7b56f0f57eb9c6b52
---
M includes/filebackend/filejournal/FileJournal.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/30282/1
--
To view, visit https://gerrit.wikimedia.org/r/30282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4efc89b4b4149caba62663a7b56f0f57eb9c6b52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 37843) Trying to edit a blank page fails - change (mediawiki...VisualEditor[master])

2012-10-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review.

Change subject: (bug 37843) Trying to edit a blank page fails
..

(bug 37843) Trying to edit a blank page fails

Explicitly check for false, because the empty string does not signify a
failure.

Change-Id: I8857d39e1a20080c8419c6165be2b5ad0cdbacd2
---
M ApiVisualEditor.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/81/30281/1
--
To view, visit https://gerrit.wikimedia.org/r/30281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8857d39e1a20080c8419c6165be2b5ad0cdbacd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Eat tags in attribute names - change (mediawiki...Parsoid[master])

2012-10-26 Thread GWicke (Code Review)
GWicke has uploaded a new change for review.

Change subject: Eat tags in attribute names
..

Eat tags in attribute names

This accepts wikitext like this fun snippet from
[[:en:2002 Australian Formula 3 season]]:
{| class="wikitable" border="1" bla generated with..<\hiddentext>

This still fails to round-trip, along with sanitizer-stripped key-only
attributes in general. At least it switches this from a semantic to a
purely syntactic diff.

TODO: Fix invalid key-only attribute round-tripping in general. Minimal
example:


This will also fix round-tripping for this the more complex test case above.

Change-Id: I1864ec9e5586ecf465d3ae0689f638e284f1dd32
---
M js/lib/pegTokenizer.pegjs.txt
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/80/30280/1
--
To view, visit https://gerrit.wikimedia.org/r/30280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1864ec9e5586ecf465d3ae0689f638e284f1dd32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41429) add image and $wgCentralAuthLoginIcon setting fo... - change (operations/mediawiki-config[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: (bug 41429) add image and $wgCentralAuthLoginIcon setting for 
wikidata
..


(bug 41429) add image and $wgCentralAuthLoginIcon setting for wikidata

Change-Id: I910596a9e68c225935228ed62cf9d8d50e7489e7
---
A images/sul/wikidata.png
M wmf-config/InitialiseSettings.php
2 files changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I910596a9e68c225935228ed62cf9d8d50e7489e7
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Aude 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix sidebar HTML escaping in CologneBlue - change (mediawiki/core[master])

2012-10-26 Thread Ori.livneh (Code Review)
Ori.livneh has submitted this change and it was merged.

Change subject: fix sidebar HTML escaping in CologneBlue
..


fix sidebar HTML escaping in CologneBlue

In my defense, it wasn't documented anywhere that it isn't safe to output.
I added docs in If56df0a7.

Change-Id: I6df92c628e4efab3012073bf06673f844a0b
---
M skins/CologneBlue.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/29434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6df92c628e4efab3012073bf06673f844a0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex 
Gerrit-Reviewer: Daniel Friesen 
Gerrit-Reviewer: Dereckson 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41409) Fix regression in diffs while editing old revisi... - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: (bug 41409) Fix regression in diffs while editing old revisions
..


(bug 41409) Fix regression in diffs while editing old revisions

Until the ContentHandler merge, when editing an old revision the "Show
changes" button would show the diff between the current version and the
text in the edit field. It appears that the ContentHandler merge somehow
unfixed bug 34849.

The same fix that was applied for that bug in r112819 translated into
ContentHandler terms seems to fix the bug again here.

Change-Id: I1eee25c530ef87ff2ecd61f0fd5c01de94eccb98
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1eee25c530ef87ff2ecd61f0fd5c01de94eccb98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 41370) protect aginst content-less revisions - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: (Bug 41370) protect aginst content-less revisions
..


(Bug 41370) protect aginst content-less revisions

getAutoDeletereason did not gracefully deal with revisions that would
return null as their content (e.g. for deleted revisions).

Change-Id: I4976f2d09b8666ca1bccebea346af37ee77b09f7
---
M includes/content/ContentHandler.php
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4976f2d09b8666ca1bccebea346af37ee77b09f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 41409) Fix regression in diffs while editing old revisi... - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: (bug 41409) Fix regression in diffs while editing old revisions
..

(bug 41409) Fix regression in diffs while editing old revisions

Until the ContentHandler merge, when editing an old revision the "Show
changes" button would show the diff between the current version and the
text in the edit field. It appears that the ContentHandler merge somehow
unfixed bug 34849.

The same fix that was applied for that bug in r112819 translated into
ContentHandler terms seems to fix the bug again here.

Change-Id: I1eee25c530ef87ff2ecd61f0fd5c01de94eccb98
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/30279/1
--
To view, visit https://gerrit.wikimedia.org/r/30279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eee25c530ef87ff2ecd61f0fd5c01de94eccb98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Anomie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (Bug 41370) protect aginst content-less revisions - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: (Bug 41370) protect aginst content-less revisions
..

(Bug 41370) protect aginst content-less revisions

getAutoDeletereason did not gracefully deal with revisions that would
return null as their content (e.g. for deleted revisions).

Change-Id: I4976f2d09b8666ca1bccebea346af37ee77b09f7
---
M includes/content/ContentHandler.php
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/30278/1
--
To view, visit https://gerrit.wikimedia.org/r/30278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4976f2d09b8666ca1bccebea346af37ee77b09f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Daniel Kinzler 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [GeoMath][SlippyMap] Disable deleted extensions - change (translatewiki[master])

2012-10-26 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged.

Change subject: [GeoMath][SlippyMap] Disable deleted extensions
..


[GeoMath][SlippyMap] Disable deleted extensions

with I67f104bc

Change-Id: I7480ca6394e1339c69bc5caf301b060262eba2c0
---
M MediaWiki/mediawiki-defines.txt
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7480ca6394e1339c69bc5caf301b060262eba2c0
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] [GeoMath][SlippyMap] Disable deleted extensions - change (translatewiki[master])

2012-10-26 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review.

Change subject: [GeoMath][SlippyMap] Disable deleted extensions
..

[GeoMath][SlippyMap] Disable deleted extensions

with I67f104bc

Change-Id: I7480ca6394e1339c69bc5caf301b060262eba2c0
---
M MediaWiki/mediawiki-defines.txt
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/77/30277/1
--
To view, visit https://gerrit.wikimedia.org/r/30277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7480ca6394e1339c69bc5caf301b060262eba2c0
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated MwEmbedSupport to master. - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Updated MwEmbedSupport to master.
..


Updated MwEmbedSupport to master.

Change-Id: I59ccd5969b4ad155018eb5526d43594cae9b76dc
---
M extensions/MwEmbedSupport
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59ccd5969b4ad155018eb5526d43594cae9b76dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated MwEmbedSupport to master. - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

Change subject: Updated MwEmbedSupport to master.
..

Updated MwEmbedSupport to master.

Change-Id: I59ccd5969b4ad155018eb5526d43594cae9b76dc
---
M extensions/MwEmbedSupport
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/30276/1
--
To view, visit https://gerrit.wikimedia.org/r/30276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59ccd5969b4ad155018eb5526d43594cae9b76dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Adding lucid installer stanza sq82 - change (operations/puppet[production])

2012-10-26 Thread Pyoungmeister (Code Review)
Pyoungmeister has submitted this change and it was merged.

Change subject: Adding lucid installer stanza sq82
..


Adding lucid installer stanza sq82

Change-Id: I9d0e9a56f86732239ed8e6c7d32d93c1c369c2a1
---
M files/dhcpd/linux-host-entries.ttyS1-115200
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Pyoungmeister: Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d0e9a56f86732239ed8e6c7d32d93c1c369c2a1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 
Gerrit-Reviewer: Pyoungmeister 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] adjustment to new version of Maht (parser) - change (mediawiki...MathSearch[master])

2012-10-26 Thread Physikerwelt (Code Review)
Physikerwelt has uploaded a new change for review.

Change subject: adjustment to new version of Maht (parser)
..

adjustment to new version of Maht (parser)

Change-Id: I30e0471a0da76d592926c0cbbdb91d9c6f3d374e
---
M MathSearch.hooks.php
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch 
refs/changes/75/30275/1
--
To view, visit https://gerrit.wikimedia.org/r/30275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e0471a0da76d592926c0cbbdb91d9c6f3d374e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated TimedMediaHandler to master. - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Updated TimedMediaHandler to master.
..


Updated TimedMediaHandler to master.

Change-Id: Ia23f634c77396d224b5f125b1f3bc4ec3ac9ff77
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23f634c77396d224b5f125b1f3bc4ec3ac9ff77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated TimedMediaHandler to master. - change (mediawiki/core[wmf/1.21wmf2])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

Change subject: Updated TimedMediaHandler to master.
..

Updated TimedMediaHandler to master.

Change-Id: Ia23f634c77396d224b5f125b1f3bc4ec3ac9ff77
---
M extensions/TimedMediaHandler
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/30274/1
--
To view, visit https://gerrit.wikimedia.org/r/30274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia23f634c77396d224b5f125b1f3bc4ec3ac9ff77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf2
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rewritten $wgAdaptiveMessageCache - change (mediawiki/core[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: Rewritten $wgAdaptiveMessageCache
..


Rewritten $wgAdaptiveMessageCache

This was developed for translatewiki.net, which has but
millions of messages in MediaWiki namespace. To avoid
exploding the message cache, not all of them can be
loaded. Instead of logging what messages have been
requested, now it uses the fact that if the
message has not been customised in the
site language, there is most likely
no reason to load it in any other
language either.

Change-Id: I6dd81b3858acfd2b73332e46668d46015e99c748
---
M includes/DefaultSettings.php
M includes/Wiki.php
M includes/cache/MessageCache.php
3 files changed, 14 insertions(+), 134 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  preilly: Verified
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/29793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6dd81b3858acfd2b73332e46668d46015e99c748
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Platonides 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] (bug 39559) Add GENDER support to upwiz-deeds-macro-prompt - change (mediawiki...UploadWizard[master])

2012-10-26 Thread Amire80 (Code Review)
Amire80 has uploaded a new change for review.

Change subject: (bug 39559) Add GENDER support to upwiz-deeds-macro-prompt
..

(bug 39559) Add GENDER support to upwiz-deeds-macro-prompt

Pass the user object as $2.
Add dummy GENDER to the English message.
Add documentation.

Change-Id: I7fcb20f3ba6dcea0862c3dd727d18206eb017650
---
M UploadWizard.i18n.php
M resources/mw.UploadWizard.js
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/73/30273/1
--
To view, visit https://gerrit.wikimedia.org/r/30273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fcb20f3ba6dcea0862c3dd727d18206eb017650
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Amire80 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix thumbnail extraction with ForeignDBViaLBRepo - change (mediawiki...TimedMediaHandler[master])

2012-10-26 Thread Aaron Schulz (Code Review)
Aaron Schulz has submitted this change and it was merged.

Change subject: fix thumbnail extraction with ForeignDBViaLBRepo
..


fix thumbnail extraction with ForeignDBViaLBRepo

- Port ExtractThumbParameters from OggHandler to TimedMediaHandler.
- Return same default value in makeParamString (mid) as OggHandler.
- Temporarily use api to get thumb url for ForeignDBViaLBRepo repos
  (this can be taken out once commons is using TMH too)

Change-Id: Ic58abfb7470e169056ecd25ec449f413ed0e4f85
---
M TimedMediaHandler.php
M TimedMediaHandler_body.php
M TimedMediaTransformOutput.php
3 files changed, 51 insertions(+), 8 deletions(-)

Approvals:
  Aaron Schulz: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic58abfb7470e169056ecd25ec449f413ed0e4f85
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: J 
Gerrit-Reviewer: Mdale 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Wikidata config - change (operations/mediawiki-config[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Wikidata config
..


Wikidata config

Change-Id: Ia8f298b44bf8842f89ad485e7ccf242e59792d45
---
M all.dblist
M s3.dblist
M special.dblist
M wikiversions.dat
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
6 files changed, 61 insertions(+), 3 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8f298b44bf8842f89ad485e7ccf242e59792d45
Gerrit-PatchSet: 8
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Denny Vrandecic 
Gerrit-Reviewer: Hydriz 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add "&contribution_tracking_id=1" to nagios checks to resolv... - change (operations/puppet[production])

2012-10-26 Thread Jgreen (Code Review)
Jgreen has submitted this change and it was merged.

Change subject: add "&contribution_tracking_id=1" to nagios checks to resolve 
duplication issue
..


add "&contribution_tracking_id=1" to nagios checks to resolve duplication issue

Change-Id: Idb9f99e82213c341283b49b5134884f8086ae4d2
---
M manifests/lvs.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jgreen: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb9f99e82213c341283b49b5134884f8086ae4d2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jgreen 
Gerrit-Reviewer: Jgreen 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add "&contribution_tracking_id=1" to nagios checks to resolv... - change (operations/puppet[production])

2012-10-26 Thread Jgreen (Code Review)
Jgreen has uploaded a new change for review.

Change subject: add "&contribution_tracking_id=1" to nagios checks to resolve 
duplication issue
..

add "&contribution_tracking_id=1" to nagios checks to resolve duplication issue

Change-Id: Idb9f99e82213c341283b49b5134884f8086ae4d2
---
M manifests/lvs.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/22/30222/1
--
To view, visit https://gerrit.wikimedia.org/r/30222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9f99e82213c341283b49b5134884f8086ae4d2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jgreen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Guard for web execution - change (mediawiki...UniversalLanguageSelector[master])

2012-10-26 Thread Nikerabbit (Code Review)
Nikerabbit has uploaded a new change for review.

Change subject: Guard for web execution
..

Guard for web execution

Change-Id: I4cac7035a9b80865c3ff5a709f5d7d7c5e5cada4
---
M data/fontrepo/scripts/compile.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/10/30210/1
--
To view, visit https://gerrit.wikimedia.org/r/30210
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cac7035a9b80865c3ff5a709f5d7d7c5e5cada4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Kill off CreditSource too - change (mediawiki/extensions[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Kill off CreditSource too
..


Kill off CreditSource too

Change-Id: Icddd08eab7f553871f2dbfa82e80d4639f39c78b
---
M .gitmodules
D CreditSource
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icddd08eab7f553871f2dbfa82e80d4639f39c78b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Kill off CreditSource too - change (mediawiki/extensions[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Kill off CreditSource too
..

Kill off CreditSource too

Change-Id: Icddd08eab7f553871f2dbfa82e80d4639f39c78b
---
M .gitmodules
D CreditSource
2 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/09/30209/1
--
To view, visit https://gerrit.wikimedia.org/r/30209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icddd08eab7f553871f2dbfa82e80d4639f39c78b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove GeoMath and SlippyMap - change (mediawiki/extensions[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Remove GeoMath and SlippyMap
..


Remove GeoMath and SlippyMap

Change-Id: I67f104bc30c836f437045e5baf02622f0734c8df
---
M .gitmodules
D GeoMath
D SlippyMap
3 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67f104bc30c836f437045e5baf02622f0734c8df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remove GeoMath and SlippyMap - change (mediawiki/extensions[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has uploaded a new change for review.

Change subject: Remove GeoMath and SlippyMap
..

Remove GeoMath and SlippyMap

Change-Id: I67f104bc30c836f437045e5baf02622f0734c8df
---
M .gitmodules
D GeoMath
D SlippyMap
3 files changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/08/30208/1
--
To view, visit https://gerrit.wikimedia.org/r/30208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67f104bc30c836f437045e5baf02622f0734c8df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Adding lucid installer stanza sq82 - change (operations/puppet[production])

2012-10-26 Thread Cmjohnson (Code Review)
Cmjohnson has uploaded a new change for review.

Change subject: Adding lucid installer stanza sq82
..

Adding lucid installer stanza sq82

Change-Id: I9d0e9a56f86732239ed8e6c7d32d93c1c369c2a1
---
M files/dhcpd/linux-host-entries.ttyS1-115200
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/30207/1
--
To view, visit https://gerrit.wikimedia.org/r/30207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d0e9a56f86732239ed8e6c7d32d93c1c369c2a1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Cmjohnson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rename Bread to Geo - change (mediawiki...GeoCrumbs[master])

2012-10-26 Thread CSteipp (Code Review)
CSteipp has submitted this change and it was merged.

Change subject: Rename Bread to Geo
..


Rename Bread to Geo

Change-Id: I26d072c36c1d4ffc39f7c45e912cf48ae55ccffd
---
A .gitreview
R GeoCrumbs.i18n.php
R GeoCrumbs.php
3 files changed, 24 insertions(+), 18 deletions(-)

Approvals:
  CSteipp: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26d072c36c1d4ffc39f7c45e912cf48ae55ccffd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GeoCrumbs
Gerrit-Branch: master
Gerrit-Owner: CSteipp 
Gerrit-Reviewer: CSteipp 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Set branch - change (mediawiki/extensions[master])

2012-10-26 Thread Reedy (Code Review)
Reedy has submitted this change and it was merged.

Change subject: Set branch
..


Set branch

Change-Id: I93d24606e56ae49db7673494aae1c2b34edec9dd
---
M .gitmodules
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/30206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93d24606e56ae49db7673494aae1c2b34edec9dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   3   >