[MediaWiki-commits] [Gerrit] Delete more thumbnails after (new) parser tests. - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Delete more thumbnails after (new) parser tests. .. Delete more thumbnails after (new) parser tests. Same as I0a0e757a only for the new parser tests (under phpunit) Change-Id: If2198676da7e8a621d02227b42da0713f67a1de0 --- M tests/phpunit/includes/parser/NewParserTest.php 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33828 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2198676da7e8a621d02227b42da0713f67a1de0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added conf for wikistats only for editors - change (analytics/wikistats[master])
Stefan.petrea has uploaded a new change for review. Change subject: Added conf for wikistats only for editors .. Added conf for wikistats only for editors * added parameter -p to SquidCountArchive.pl and SquidReportArchive.pl * removed logic for computing job_runs_on_production_server from EzLib.pm , this will be decided by the presence of the -p parameter Change-Id: Iae65c489f0713ba3264d05a2a2db42b2230abc3b --- M squids/.gitignore A squids/conf-editors/SquidCountArchiveConfig-editors.pm A squids/conf-editors/SquidReportArchiveConfig-editors.pm M squids/perl/EzLib.pm M squids/perl/SquidCountArchive.pl M squids/perl/SquidReportArchive.pl 6 files changed, 79 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats refs/changes/58/33858/1 -- To view, visit https://gerrit.wikimedia.org/r/33858 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae65c489f0713ba3264d05a2a2db42b2230abc3b Gerrit-PatchSet: 1 Gerrit-Project: analytics/wikistats Gerrit-Branch: master Gerrit-Owner: Stefan.petrea ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Output special page name before attempting to run function - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Output special page name before attempting to run function .. Output special page name before attempting to run function Related to bug 42210, we don't have a blank line, not knowing what it's actually running QueryPage updates do this already! Change-Id: I18eb0fb4c316744d92a81f5e64e201508b27eb27 --- M maintenance/updateSpecialPages.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33841 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18eb0fb4c316744d92a81f5e64e201508b27eb27 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix edge case in tpl-encap. when entire tpl is fostered out ... - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Fix edge case in tpl-encap. when entire tpl is fostered out of tbl. .. Fix edge case in tpl-encap. when entire tpl is fostered out of tbl. * Fixes RTing of SS_Oxfordshire (and possibly a few other ship-related pages). Change-Id: I5346cd9e043a2599ebb17ea78123fa030b75330a --- M js/lib/mediawiki.DOMPostProcessor.js 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/57/33857/1 -- To view, visit https://gerrit.wikimedia.org/r/33857 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5346cd9e043a2599ebb17ea78123fa030b75330a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rewrote getEditReviewTimes() function to use subqueries. - change (mediawiki...FlaggedRevs[master])
Aaron Schulz has uploaded a new change for review. Change subject: Rewrote getEditReviewTimes() function to use subqueries. .. Rewrote getEditReviewTimes() function to use subqueries. * This also no longer seems to hang on the query for the case when $users is set to "users", though it still seems slower than it should be. Change-Id: I8a9554cbd89188e7e377a5c67902c5bb7770175c --- M backend/FlaggedRevsStats.php 1 file changed, 29 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs refs/changes/56/33856/1 -- To view, visit https://gerrit.wikimedia.org/r/33856 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a9554cbd89188e7e377a5c67902c5bb7770175c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FlaggedRevs Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix typo (cointent => content) - change (mediawiki/core[master])
Ori.livneh has submitted this change and it was merged. Change subject: Fix typo (cointent => content) .. Fix typo (cointent => content) Change-Id: I4d6702d0b2a6c4fe224a8c59808a579b6c6916a0 --- M docs/hooks.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d6702d0b2a6c4fe224a8c59808a579b6c6916a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix typo (cointent => content) - change (mediawiki/core[master])
Ori.livneh has uploaded a new change for review. Change subject: Fix typo (cointent => content) .. Fix typo (cointent => content) Change-Id: I4d6702d0b2a6c4fe224a8c59808a579b6c6916a0 --- M docs/hooks.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/55/33855/1 -- To view, visit https://gerrit.wikimedia.org/r/33855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d6702d0b2a6c4fe224a8c59808a579b6c6916a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update jQuery to 1.8.3 - change (mediawiki/core[master])
Krinkle has submitted this change and it was merged. Change subject: Update jQuery to 1.8.3 .. Update jQuery to 1.8.3 http://blog.jquery.com/2012/11/13/jquery-1-8-3-released/ Change-Id: I0bda71044ff6ea41e946d34e48fa279101f4bf90 --- M RELEASE-NOTES-1.21 M resources/jquery/jquery.js 2 files changed, 120 insertions(+), 87 deletions(-) Approvals: Krinkle: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bda71044ff6ea41e946d34e48fa279101f4bf90 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Catrope Gerrit-Reviewer: Kaldari Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42121) Change markers lost for first paragraph on new p... - change (mediawiki...VisualEditor[master])
Catrope has uploaded a new change for review. Change subject: (bug 42121) Change markers lost for first paragraph on new page .. (bug 42121) Change markers lost for first paragraph on new page When editing a new page, or loading an empty page into the editor, the converter generates a paragraph so the document isn't completely empty. This paragraph is then unwrapped on the way out, potentially destroying change markers and generally producing strange HTML output. Mark this paragraph with generated=empty rather than generated=wrapper, and only unwrap it on the way out if it's still empty. This means we cleanly round-trip empty documents (and empty list items and the like), but if the user enters text, we create a paragraph like we're supposed to. Change-Id: Id0241221a67b769445676b833b5741320d99ea5f --- M modules/ve/dm/ve.dm.Converter.js M modules/ve/test/dm/ve.dm.Converter.test.js M modules/ve/test/dm/ve.dm.example.js 3 files changed, 58 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/54/33854/1 -- To view, visit https://gerrit.wikimedia.org/r/33854 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0241221a67b769445676b833b5741320d99ea5f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Temporary patch-up to prevent crashers in extension content ... - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: Temporary patch-up to prevent crashers in extension content handler. .. Temporary patch-up to prevent crashers in extension content handler. * Not a real fix -- real fix involved extracting extension tags from attributes. * Just a temporary fix to prevent crashers in RT testing. Change-Id: I57855b161096b279272f24c8ce2fd62a72650231 --- M js/lib/ext.ExtensionContentCollector.js 1 file changed, 19 insertions(+), 13 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33849 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57855b161096b279272f24c8ce2fd62a72650231 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix bug in LTR propagation of DSR values. - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: Fix bug in LTR propagation of DSR values. .. Fix bug in LTR propagation of DSR values. * Update dsr[0] only if new value is smaller than existing one. * Fixes regression on both examples from commit message of 3b676e5. * One more wt2wt test green (regression from 3b676e5 -- we missed this somehow) * But doesn't seem to fix all rt test pages (to be investigated). Change-Id: Ib2051d2a264aaa7bf653513bb330e6c9e2f56197 --- M js/lib/mediawiki.DOMPostProcessor.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33848 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2051d2a264aaa7bf653513bb330e6c9e2f56197 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix two typos - change (mediawiki...Translate[master])
Reedy has submitted this change and it was merged. Change subject: Fix two typos .. Fix two typos Change-Id: I8cff3ab1a759eb6c06fbce40c4993edb58cc26c9 --- M README M Translate.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33815 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cff3ab1a759eb6c06fbce40c4993edb58cc26c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nemo bis Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Inherit the parent syntax for new elements in some cases - change (mediawiki...Parsoid[master])
GWicke has uploaded a new change for review. Change subject: Inherit the parent syntax for new elements in some cases .. Inherit the parent syntax for new elements in some cases Examples include new table elements inside a table or new list items inside a list. Defaulting to wikitext in these cases would change the semantics in html2html round-tripping (especially in the list case) and looks ugly. Change-Id: I68aa615ad5142a935475d33694139feb707fd682 --- M js/lib/mediawiki.WikitextSerializer.js 1 file changed, 37 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/53/33853/1 -- To view, visit https://gerrit.wikimedia.org/r/33853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68aa615ad5142a935475d33694139feb707fd682 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42123) Add i18n for aliennated content tool tip. - change (mediawiki...VisualEditor[master])
Catrope has submitted this change and it was merged. Change subject: (bug 42123) Add i18n for aliennated content tool tip. .. (bug 42123) Add i18n for aliennated content tool tip. Change-Id: Ibb98d256fb989cd69407b487df673ee22f8c9758 --- M VisualEditor.i18n.php M VisualEditor.php M modules/ve/ce/ve.ce.Surface.js 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb98d256fb989cd69407b487df673ee22f8c9758 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester Gerrit-Reviewer: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Additional tests to spec behavior of wikitext in extlink-bra... - change (mediawiki/core[master])
GWicke has submitted this change and it was merged. Change subject: Additional tests to spec behavior of wikitext in extlink-brackets. .. Additional tests to spec behavior of wikitext in extlink-brackets. * Mostly to keep Parsoid in line. Change-Id: I1629b156f66cb3f1b511fbe26feb1bee1e1e0e59 --- M tests/parser/parserTests.txt 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33852 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1629b156f66cb3f1b511fbe26feb1bee1e1e0e59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Additional tests to spec behavior of wikitext in extlink-bra... - change (mediawiki/core[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Additional tests to spec behavior of wikitext in extlink-brackets. .. Additional tests to spec behavior of wikitext in extlink-brackets. * Mostly to keep Parsoid in line. Change-Id: I1629b156f66cb3f1b511fbe26feb1bee1e1e0e59 --- M tests/parser/parserTests.txt 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/52/33852/1 -- To view, visit https://gerrit.wikimedia.org/r/33852 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1629b156f66cb3f1b511fbe26feb1bee1e1e0e59 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42123) Add i18n for aliennated content tool tip. - change (mediawiki...VisualEditor[master])
Jforrester has uploaded a new change for review. Change subject: (bug 42123) Add i18n for aliennated content tool tip. .. (bug 42123) Add i18n for aliennated content tool tip. Change-Id: Ibb98d256fb989cd69407b487df673ee22f8c9758 --- M VisualEditor.i18n.php M VisualEditor.php M modules/ve/ce/ve.ce.Surface.js 3 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/51/33851/1 -- To view, visit https://gerrit.wikimedia.org/r/33851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb98d256fb989cd69407b487df673ee22f8c9758 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update jQuery to 1.8.3 - change (mediawiki/core[master])
Reedy has uploaded a new change for review. Change subject: Update jQuery to 1.8.3 .. Update jQuery to 1.8.3 http://blog.jquery.com/2012/11/13/jquery-1-8-3-released/ Change-Id: I0bda71044ff6ea41e946d34e48fa279101f4bf90 --- M RELEASE-NOTES-1.21 M resources/jquery/jquery.js 2 files changed, 120 insertions(+), 87 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/50/33850/1 -- To view, visit https://gerrit.wikimedia.org/r/33850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0bda71044ff6ea41e946d34e48fa279101f4bf90 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Temporary patch-up to prevent crashers in extension content ... - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Temporary patch-up to prevent crashers in extension content handler. .. Temporary patch-up to prevent crashers in extension content handler. * Not a real fix -- real fix involved extracting extension tags from attributes. * Just a temporary fix to prevent crashers in RT testing. Change-Id: I57855b161096b279272f24c8ce2fd62a72650231 --- M js/lib/ext.ExtensionContentCollector.js 1 file changed, 19 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/49/33849/1 -- To view, visit https://gerrit.wikimedia.org/r/33849 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57855b161096b279272f24c8ce2fd62a72650231 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix bug in LTR propagation of DSR values. - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Fix bug in LTR propagation of DSR values. .. Fix bug in LTR propagation of DSR values. * Update dsr[0] only if new value is smaller than existing one. * Fixes regression on both examples from commit message of 3b676e5. * One more wt2wt test green (regression from 3b676e5 -- we missed this somehow) * But doesn't seem to fix all rt test pages (to be investigated). Change-Id: Ib2051d2a264aaa7bf653513bb330e6c9e2f56197 --- M js/lib/mediawiki.DOMPostProcessor.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/48/33848/1 -- To view, visit https://gerrit.wikimedia.org/r/33848 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2051d2a264aaa7bf653513bb330e6c9e2f56197 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed bug in extlink handling when extlink token is not a li... - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: Fixed bug in extlink handling when extlink token is not a link. .. Fixed bug in extlink handling when extlink token is not a link. * [foo's] was getting parsed as foo' s when the extlink token was reconverted to text. * One more wt2wt test fixed. * Eliminates RT errors from en:Giulio%20d%E2%80%99Este Change-Id: I988cfdf1ccf56597ddee88ca7b205d5dbf371dea --- M js/lib/ext.core.LinkHandler.js M js/lib/pegTokenizer.pegjs.txt 2 files changed, 15 insertions(+), 5 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33700 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I988cfdf1ccf56597ddee88ca7b205d5dbf371dea Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke Gerrit-Reviewer: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] RT as well as tag. - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: RT as well as tag. .. RT as well as tag. * Fixes RT diff in en:Standing Sushi Bar. Change-Id: Ia05f9d01503e3003260a10663d1dd845a261beab --- M js/lib/ext.Cite.js 1 file changed, 18 insertions(+), 15 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia05f9d01503e3003260a10663d1dd845a261beab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] schema updates via hook - change (mediawiki...ContributionReporting[master])
Adamw has uploaded a new change for review. Change subject: schema updates via hook .. schema updates via hook Change-Id: I545120b28e3d46ab62ea5dcda4339f0aa87c372b --- M ContributionReporting.php A patches/public-reporting-days.sql A patches/public-reporting-fundraisers.sql D patches/public-reporting-summaries.sql 4 files changed, 45 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionReporting refs/changes/47/33847/1 -- To view, visit https://gerrit.wikimedia.org/r/33847 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I545120b28e3d46ab62ea5dcda4339f0aa87c372b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContributionReporting Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Part of bug 42210 - Add a global to enable/disable update ot... - change (mediawiki...FlaggedRevs[master])
Reedy has uploaded a new change for review. Change subject: Part of bug 42210 - Add a global to enable/disable update ot ValidationStatistics .. Part of bug 42210 - Add a global to enable/disable update ot ValidationStatistics Change-Id: Ie8d0dfb8cf738b7d490bafc705fb2e9aecbcce35 --- M FlaggedRevs.config.php M frontend/FlaggedRevsUI.setup.php 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs refs/changes/46/33846/1 -- To view, visit https://gerrit.wikimedia.org/r/33846 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8d0dfb8cf738b7d490bafc705fb2e9aecbcce35 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FlaggedRevs Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41947) Propagate change markers when unwrapping generat... - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: (bug 41947) Propagate change markers when unwrapping generated nodes .. (bug 41947) Propagate change markers when unwrapping generated nodes Editing the text of a list item results in a change marker on the paragraph within that list item. However, that paragraph usually isn't present in the HTML, so the converter unwraps it when converting back to HTML, and the change markers are lost. Instead, transfer the change markers to the . Change-Id: Id675075d19c08d69bc8e990174841dc393b749fc --- M modules/ve/dm/ve.dm.Converter.js M modules/ve/test/dm/ve.dm.example.js 2 files changed, 41 insertions(+), 4 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33840 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id675075d19c08d69bc8e990174841dc393b749fc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable updating of ValidationStatistics in SpecialPageCache... - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Disable updating of ValidationStatistics in SpecialPageCacheUpdates .. Disable updating of ValidationStatistics in SpecialPageCacheUpdates Change-Id: I61a312149e4f3e509e6487c371f9438a654c4f9b --- M wmf-config/flaggedrevs.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/45/33845/1 -- To view, visit https://gerrit.wikimedia.org/r/33845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61a312149e4f3e509e6487c371f9438a654c4f9b Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] RT as well as tag. - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: RT as well as tag. .. RT as well as tag. * Fixes RT diff in en:Standing Sushi Bar. Change-Id: Ia05f9d01503e3003260a10663d1dd845a261beab --- M js/lib/ext.Cite.js 1 file changed, 18 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/44/33844/1 -- To view, visit https://gerrit.wikimedia.org/r/33844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia05f9d01503e3003260a10663d1dd845a261beab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [FileBackend] More stat caching improvements. - change (mediawiki/core[master])
Aaron Schulz has uploaded a new change for review. Change subject: [FileBackend] More stat caching improvements. .. [FileBackend] More stat caching improvements. * Extended negative caching to handle the "latest" parameter. * Added a new "dstExists" parameter to some write functions to avoid salting the cache when a file is created at an unused path. The ability to do this was already mentioned in the setFileCache() doc comments. Change-Id: Ib64e4c128e16f4d284033fff70b88686fa0593ab --- M includes/filebackend/FileBackendStore.php M includes/filebackend/FileOp.php 2 files changed, 56 insertions(+), 25 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/43/33843/1 -- To view, visit https://gerrit.wikimedia.org/r/33843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib64e4c128e16f4d284033fff70b88686fa0593ab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add ce.AlienNode to tests - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Add ce.AlienNode to tests .. Add ce.AlienNode to tests Change-Id: I591501067732ae36c89da340398ad35e8d4b6e3d --- M modules/ve/test/index.html 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33838 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I591501067732ae36c89da340398ad35e8d4b6e3d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope Gerrit-Reviewer: Catrope Gerrit-Reviewer: Christian Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added undo-before-apply for new link annotations - change (mediawiki...VisualEditor[master])
Trevor Parscal has uploaded a new change for review. Change subject: Added undo-before-apply for new link annotations .. Added undo-before-apply for new link annotations When the link inspector is used to create a new annotation, the text is annotated with the default link target derived from the selected text. Then if the inspector is used to change that value, yet another transaction is processed when the inspector is closed. To avoid having to press undo 2x, this change makes the inspector undo it's first change before applying the changed annotation. This change also introduces insert, remove and select content actions. Change-Id: I3e29189158fb01336d6b053bc2a8bda2a91a0a46 --- M VisualEditor.php M demos/ve/index.php A modules/ve/actions/ve.ContentAction.js M modules/ve/test/index.html M modules/ve/ui/inspectors/ve.ui.LinkInspector.js 5 files changed, 87 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/42/33842/1 -- To view, visit https://gerrit.wikimedia.org/r/33842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e29189158fb01336d6b053bc2a8bda2a91a0a46 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Output special page name before attempting to run function - change (mediawiki/core[master])
Reedy has uploaded a new change for review. Change subject: Output special page name before attempting to run function .. Output special page name before attempting to run function Related to bug 42210, we don't have a blank line, not knowing what it's actually running QueryPage updates do this already! Change-Id: I18eb0fb4c316744d92a81f5e64e201508b27eb27 --- M maintenance/updateSpecialPages.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/41/33841/1 -- To view, visit https://gerrit.wikimedia.org/r/33841 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I18eb0fb4c316744d92a81f5e64e201508b27eb27 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41947) Propagate change markers when unwrapping generat... - change (mediawiki...VisualEditor[master])
Catrope has uploaded a new change for review. Change subject: (bug 41947) Propagate change markers when unwrapping generated nodes .. (bug 41947) Propagate change markers when unwrapping generated nodes Editing the text of a list item results in a change marker on the paragraph within that list item. However, that paragraph usually isn't present in the HTML, so the converter unwraps it when converting back to HTML, and the change markers are lost. Instead, transfer the change markers to the . Change-Id: Id675075d19c08d69bc8e990174841dc393b749fc --- M modules/ve/dm/ve.dm.Converter.js M modules/ve/test/dm/ve.dm.example.js 2 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/40/33840/1 -- To view, visit https://gerrit.wikimedia.org/r/33840 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id675075d19c08d69bc8e990174841dc393b749fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] use default parameter - change (mediawiki...SemanticMaps[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: use default parameter .. use default parameter Change-Id: If9d574da88b842db036e3adf41bac58659a36f98 --- M includes/queryprinters/SM_MapPrinter.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33839 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9d574da88b842db036e3adf41bac58659a36f98 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMaps Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] use default parameter - change (mediawiki...SemanticMaps[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: use default parameter .. use default parameter Change-Id: If9d574da88b842db036e3adf41bac58659a36f98 --- M includes/queryprinters/SM_MapPrinter.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMaps refs/changes/39/33839/1 -- To view, visit https://gerrit.wikimedia.org/r/33839 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9d574da88b842db036e3adf41bac58659a36f98 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMaps Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add ce.AlienNode to tests and demo - change (mediawiki...VisualEditor[master])
Catrope has uploaded a new change for review. Change subject: Add ce.AlienNode to tests and demo .. Add ce.AlienNode to tests and demo Change-Id: I591501067732ae36c89da340398ad35e8d4b6e3d --- M demos/ve/index.php M modules/ve/test/index.html 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/38/33838/1 -- To view, visit https://gerrit.wikimedia.org/r/33838 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I591501067732ae36c89da340398ad35e8d4b6e3d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moved test to correct location and fixed data provider - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Moved test to correct location and fixed data provider .. Moved test to correct location and fixed data provider Change-Id: I32a58ff23dcb9f09cc7655a9efb0b00eb0202ad5 --- M lib/tests/phpunit/entity/EntityObjectTest.php M lib/tests/phpunit/property/PropertyObjectTest.php 2 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/36/33836/1 -- To view, visit https://gerrit.wikimedia.org/r/33836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32a58ff23dcb9f09cc7655a9efb0b00eb0202ad5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make use of parseClaimKey - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Make use of parseClaimKey .. Make use of parseClaimKey Change-Id: I9ed96431d4bd7083653e0b433cd6aba77208f829 --- M repo/includes/api/ApiGetClaims.php 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/37/33837/1 -- To view, visit https://gerrit.wikimedia.org/r/33837 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ed96431d4bd7083653e0b433cd6aba77208f829 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Registered wbgetclaims API module, some small stuff and upda... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Registered wbgetclaims API module, some small stuff and updated rel notes .. Registered wbgetclaims API module, some small stuff and updated rel notes Change-Id: Ic79668caa1b5a914f75578019f56410b60817fb4 --- M lib/RELEASE-NOTES M lib/includes/claim/ClaimListAccess.php M lib/includes/entity/EntityObject.php M repo/RELEASE-NOTES M repo/Wikibase.php M repo/includes/api/ApiGetClaims.php 6 files changed, 68 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/35/33835/1 -- To view, visit https://gerrit.wikimedia.org/r/33835 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic79668caa1b5a914f75578019f56410b60817fb4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing Pre-Annotations - change (mediawiki...VisualEditor[master])
Christian has uploaded a new change for review. Change subject: Fixing Pre-Annotations .. Fixing Pre-Annotations AnnotationAction and SurfaceFragment now use insertAnnotations. Change-Id: I047d656acf7fa1c63f726ca2b0801e1476f84f96 --- M modules/ve/actions/ve.AnnotationAction.js M modules/ve/dm/ve.dm.SurfaceFragment.js 2 files changed, 18 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/34/33834/1 -- To view, visit https://gerrit.wikimedia.org/r/33834 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I047d656acf7fa1c63f726ca2b0801e1476f84f96 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Christian ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf3])
Reedy has submitted this change and it was merged. Change subject: Update TimedMediaHandler to master .. Update TimedMediaHandler to master Change-Id: I4efc31e4335e9fb275490cf241f200f19f5d59cc --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4efc31e4335e9fb275490cf241f200f19f5d59cc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf4])
Reedy has submitted this change and it was merged. Change subject: Update TimedMediaHandler to master .. Update TimedMediaHandler to master Change-Id: I6edeeb6f65f9d51e67cc4dcee298605d27e86027 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6edeeb6f65f9d51e67cc4dcee298605d27e86027 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf4])
Reedy has uploaded a new change for review. Change subject: Update TimedMediaHandler to master .. Update TimedMediaHandler to master Change-Id: I6edeeb6f65f9d51e67cc4dcee298605d27e86027 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/33/33833/1 -- To view, visit https://gerrit.wikimedia.org/r/33833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6edeeb6f65f9d51e67cc4dcee298605d27e86027 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TimedMediaHandler to master - change (mediawiki/core[wmf/1.21wmf3])
Reedy has uploaded a new change for review. Change subject: Update TimedMediaHandler to master .. Update TimedMediaHandler to master Change-Id: I4efc31e4335e9fb275490cf241f200f19f5d59cc --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/32/33832/1 -- To view, visit https://gerrit.wikimedia.org/r/33832 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4efc31e4335e9fb275490cf241f200f19f5d59cc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: use local_variable instead of CONSTANT - change (qa/browsertests[master])
Cmcmahon has submitted this change and it was merged. Change subject: Refactoring: use local_variable instead of CONSTANT .. Refactoring: use local_variable instead of CONSTANT There is no need to use a CONSTANT to hold credentials, local_variable does the job. Change-Id: I3d0b902e7d03db16dad5dcbd175484d87150fe6b --- M features/support/env.rb 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Cmcmahon: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33817 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d0b902e7d03db16dad5dcbd175484d87150fe6b Gerrit-PatchSet: 2 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin Gerrit-Reviewer: Cmcmahon Gerrit-Reviewer: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TMH to master to catch the fix from https://gerrit.wi... - change (mediawiki/core[wmf/1.21wmf4])
MaxSem has submitted this change and it was merged. Change subject: Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 .. Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 Change-Id: I85c6844b950c50dcb873d23ccee64a2d52014362 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c6844b950c50dcb873d23ccee64a2d52014362 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: MaxSem Gerrit-Reviewer: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TMH to master to catch the fix from https://gerrit.wi... - change (mediawiki/core[wmf/1.21wmf3])
MaxSem has submitted this change and it was merged. Change subject: Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 .. Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 Change-Id: Ia556dd5093a2f9cd120665e9b5d67bafe05fad81 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia556dd5093a2f9cd120665e9b5d67bafe05fad81 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: MaxSem Gerrit-Reviewer: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TMH to master to catch the fix from https://gerrit.wi... - change (mediawiki/core[wmf/1.21wmf4])
MaxSem has uploaded a new change for review. Change subject: Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 .. Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 Change-Id: I85c6844b950c50dcb873d23ccee64a2d52014362 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/31/33831/1 -- To view, visit https://gerrit.wikimedia.org/r/33831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85c6844b950c50dcb873d23ccee64a2d52014362 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update TMH to master to catch the fix from https://gerrit.wi... - change (mediawiki/core[wmf/1.21wmf3])
MaxSem has uploaded a new change for review. Change subject: Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 .. Update TMH to master to catch the fix from https://gerrit.wikimedia.org/r/33819 Change-Id: Ia556dd5093a2f9cd120665e9b5d67bafe05fad81 --- M extensions/TimedMediaHandler 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/30/33830/1 -- To view, visit https://gerrit.wikimedia.org/r/33830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia556dd5093a2f9cd120665e9b5d67bafe05fad81 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup: delete unused configuration - change (qa/browsertests[master])
Cmcmahon has submitted this change and it was merged. Change subject: Cleanup: delete unused configuration .. Cleanup: delete unused configuration Looks like this is not used anywhere. Change-Id: I4c6fe56015a2a1ca89f7afd88deec9b4c88e4af8 --- M config/config.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Cmcmahon: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c6fe56015a2a1ca89f7afd88deec9b4c88e4af8 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin Gerrit-Reviewer: Cmcmahon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] zuul: setup.py requires python-setuptools package - change (operations/puppet[production])
Lcarr has submitted this change and it was merged. Change subject: zuul: setup.py requires python-setuptools package .. zuul: setup.py requires python-setuptools package Spotted while installing zuul from scratch in labs, the 'setup.py install' command definitely require python-setuptools. It usually comes with python-pip but we are not install that package since we do not need fetching files from a third party (packages are provided in Debian). Change-Id: I26ae8fd6152159c8cb20b9d67aef64d0d668d00b --- M modules/zuul/manifests/init.pp 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Lcarr: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33475 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26ae8fd6152159c8cb20b9d67aef64d0d668d00b Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar Gerrit-Reviewer: Lcarr Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rake disable colors on non TTY - change (operations/puppet[production])
Lcarr has submitted this change and it was merged. Change subject: rake disable colors on non TTY .. rake disable colors on non TTY Color output is trouble some on non TTY so we just disable it unconditionally. Change-Id: I427bbda3180cdeb076fe17ba8fc1b7d9a4b1aa94 --- M rakefile 1 file changed, 17 insertions(+), 5 deletions(-) Approvals: Lcarr: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/30062 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I427bbda3180cdeb076fe17ba8fc1b7d9a4b1aa94 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar Gerrit-Reviewer: Lcarr Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "Disable validation statistics maintenance report upd... - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Revert "Disable validation statistics maintenance report update" .. Revert "Disable validation statistics maintenance report update" This reverts commit 9fce53506bc02a5160942b525ef7976ae5125c2b --- M wmf-config/InitialiseSettings.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b74e4c7e5487fc22bc65988363bd1e42d2185de Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup: delete unused configuration - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Cleanup: delete unused configuration .. Cleanup: delete unused configuration Looks like this is not used anywhere. Change-Id: I4c6fe56015a2a1ca89f7afd88deec9b4c88e4af8 --- M config/config.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/29/33829/1 -- To view, visit https://gerrit.wikimedia.org/r/33829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c6fe56015a2a1ca89f7afd88deec9b4c88e4af8 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Delete more thumbnails after (new) parser tests. - change (mediawiki/core[master])
Umherirrender has uploaded a new change for review. Change subject: Delete more thumbnails after (new) parser tests. .. Delete more thumbnails after (new) parser tests. Same as I0a0e757a only for the new parser tests (under phpunit) Change-Id: If2198676da7e8a621d02227b42da0713f67a1de0 --- M tests/phpunit/includes/parser/NewParserTest.php 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/28/33828/1 -- To view, visit https://gerrit.wikimedia.org/r/33828 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2198676da7e8a621d02227b42da0713f67a1de0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add number of fixes and number of regressions in the latest ... - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: Add number of fixes and number of regressions in the latest revision to stats page .. Add number of fixes and number of regressions in the latest revision to stats page Add number of fixes, regressions and tests to each commit's row on the /commits page remove stray whitespace moved the new stats to the section specific to this version Change-Id: I04ebf4291df421ccfcaf66fe379f47c9ce4f8dd1 --- M js/tests/server/server.js 1 file changed, 79 insertions(+), 13 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33740 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ebf4291df421ccfcaf66fe379f47c9ce4f8dd1 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Lwelling Gerrit-Reviewer: GWicke Gerrit-Reviewer: Lwelling Gerrit-Reviewer: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ClaimList now uses HashArray rather then HashableObjectStora... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: ClaimList now uses HashArray rather then HashableObjectStorage .. ClaimList now uses HashArray rather then HashableObjectStorage In retrospect we currently actually do not need efficient by-guid lookup since we can just get away with looping over all claims and then selecting the one with the correct guid. Leaving it as it is for now since its quite possible we run into a use case for it soonish. If we dont it can be changed back to use HashableObjectStorage if we want to make it as simple as possible Change-Id: Id7f0aa283e368007a4f88bee943db6f17a881a12 --- M lib/WikibaseLib.hooks.php M lib/WikibaseLib.php M lib/includes/HashArray.php M lib/includes/claim/ClaimList.php M lib/includes/claim/ClaimListAccess.php M lib/includes/claim/Claims.php M lib/includes/entity/EntityObject.php M lib/tests/phpunit/claim/ClaimListTest.php A lib/tests/phpunit/hasharray/HashArrayElement.php R lib/tests/phpunit/hasharray/HashArrayTest.php A lib/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php A lib/tests/phpunit/hasharray/HashArrayWithoutDuplicatesTest.php 12 files changed, 602 insertions(+), 85 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/27/33827/1 -- To view, visit https://gerrit.wikimedia.org/r/33827 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7f0aa283e368007a4f88bee943db6f17a881a12 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Detect API requests by checking defined('MW_API') - change (mediawiki...EventLogging[master])
Ori.livneh has submitted this change and it was merged.
Change subject: Detect API requests by checking defined('MW_API')
..
Detect API requests by checking defined('MW_API')
Change-Id: I6cbc7c9d6ee5aa10705e889bfaf7ff7e38048847
---
M EventLogging.hooks.php
1 file changed, 1 insertion(+), 18 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
Mattflaschen: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.wikimedia.org/r/33822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cbc7c9d6ee5aa10705e889bfaf7ff7e38048847
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh
Gerrit-Reviewer: Mattflaschen
Gerrit-Reviewer: Ori.livneh
Gerrit-Reviewer: Spage
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (WIP) Update Memcached on Meta - change (mediawiki...EventLogging[master])
Ori.livneh has uploaded a new change for review. Change subject: (WIP) Update Memcached on Meta .. (WIP) Update Memcached on Meta Change-Id: I9a53f4b2695d9bb8606c1c7a25f03af91d539708 --- A EventLogging.home.php M EventLogging.module.php M EventLogging.php 3 files changed, 80 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging refs/changes/25/33825/1 -- To view, visit https://gerrit.wikimedia.org/r/33825 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a53f4b2695d9bb8606c1c7a25f03af91d539708 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 42192 - s/mw.getConfig/mw.config.get/g - change (mediawiki...TimedMediaHandler[master])
Mdale has submitted this change and it was merged. Change subject: Bug 42192 - s/mw.getConfig/mw.config.get/g .. Bug 42192 - s/mw.getConfig/mw.config.get/g ...to avoid JS errors in production Change-Id: I3460b606dff4f343b98c0d3f73bc86a34e93ac50 --- M MwEmbedModules/EmbedPlayer/EmbedPlayer.loader.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerImageOverlay.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js M MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js M MwEmbedModules/TimedText/TimedText.loader.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M resources/mw.MediaWikiPlayerSupport.js 15 files changed, 86 insertions(+), 86 deletions(-) Approvals: Mdale: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33819 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3460b606dff4f343b98c0d3f73bc86a34e93ac50 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: MaxSem Gerrit-Reviewer: J Gerrit-Reviewer: Mdale ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable validation statistics maintenance report update - change (operations/mediawiki-config[master])
Reedy has submitted this change and it was merged. Change subject: Disable validation statistics maintenance report update .. Disable validation statistics maintenance report update Change-Id: I87e08946ebedd2b147f1304011c1c27c3013a87d --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33824 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e08946ebedd2b147f1304011c1c27c3013a87d Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disable validation statistics maintenance report update - change (operations/mediawiki-config[master])
Reedy has uploaded a new change for review. Change subject: Disable validation statistics maintenance report update .. Disable validation statistics maintenance report update Change-Id: I87e08946ebedd2b147f1304011c1c27c3013a87d --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/24/33824/1 -- To view, visit https://gerrit.wikimedia.org/r/33824 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87e08946ebedd2b147f1304011c1c27c3013a87d Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42097) $.tablesorter fix when wgDefaultDateFormat is un... - change (mediawiki/core[wmf/1.21wmf3])
Catrope has submitted this change and it was merged. Change subject: (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized .. (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized The 'date' parser assumed all wikis use wgDefaultDateFormat that is either 'mdy' or 'dmy', but this is not the case; for example fi.wikipedia uses 'fi normal'. Therefore the correct value was not set, a string was not changed to an array, and a loop that assumed an array would be present hanged forever. Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 --- M resources/jquery/jquery.tablesorter.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Catrope Gerrit-Reviewer: Catrope Gerrit-Reviewer: Matmarex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42097) $.tablesorter fix when wgDefaultDateFormat is un... - change (mediawiki/core[wmf/1.21wmf4])
Catrope has submitted this change and it was merged. Change subject: (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized .. (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized The 'date' parser assumed all wikis use wgDefaultDateFormat that is either 'mdy' or 'dmy', but this is not the case; for example fi.wikipedia uses 'fi normal'. Therefore the correct value was not set, a string was not changed to an array, and a loop that assumed an array would be present hanged forever. Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 --- M resources/jquery/jquery.tablesorter.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33821 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: Catrope Gerrit-Reviewer: Catrope Gerrit-Reviewer: Matmarex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42097) $.tablesorter fix when wgDefaultDateFormat is un... - change (mediawiki/core[wmf/1.21wmf3])
Catrope has uploaded a new change for review. Change subject: (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized .. (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized The 'date' parser assumed all wikis use wgDefaultDateFormat that is either 'mdy' or 'dmy', but this is not the case; for example fi.wikipedia uses 'fi normal'. Therefore the correct value was not set, a string was not changed to an array, and a loop that assumed an array would be present hanged forever. Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 --- M resources/jquery/jquery.tablesorter.js 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/23/33823/1 -- To view, visit https://gerrit.wikimedia.org/r/33823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Catrope Gerrit-Reviewer: Matmarex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Detect API requests by checking defined('MW_API') - change (mediawiki...EventLogging[master])
Ori.livneh has uploaded a new change for review.
Change subject: Detect API requests by checking defined('MW_API')
..
Detect API requests by checking defined('MW_API')
Change-Id: I6cbc7c9d6ee5aa10705e889bfaf7ff7e38048847
---
M EventLogging.hooks.php
1 file changed, 1 insertion(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/22/33822/1
--
To view, visit https://gerrit.wikimedia.org/r/33822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cbc7c9d6ee5aa10705e889bfaf7ff7e38048847
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42097) $.tablesorter fix when wgDefaultDateFormat is un... - change (mediawiki/core[wmf/1.21wmf4])
Catrope has uploaded a new change for review. Change subject: (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized .. (bug 42097) $.tablesorter fix when wgDefaultDateFormat is unrecognized The 'date' parser assumed all wikis use wgDefaultDateFormat that is either 'mdy' or 'dmy', but this is not the case; for example fi.wikipedia uses 'fi normal'. Therefore the correct value was not set, a string was not changed to an array, and a loop that assumed an array would be present hanged forever. Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 --- M resources/jquery/jquery.tablesorter.js 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/21/33821/1 -- To view, visit https://gerrit.wikimedia.org/r/33821 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba17bc6b44d6a2fff491b7462d7a5457f85d19c5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: Catrope Gerrit-Reviewer: Matmarex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41183) move beta logs out of /home - change (operations/puppet[production])
Lcarr has submitted this change and it was merged. Change subject: (bug 41183) move beta logs out of /home .. (bug 41183) move beta logs out of /home In labs /home is a shared directory. Since the beginning of this project the udp2log have been written to /home/wikipedia/logs and end up filling the shared directory from time to time. A better usage would be to write log to the project directory /data/project. The new role::beta::logging::mediawiki simply calls the previously applied class role::logging::mediawiki but using /data/project/logs. For back compatibility and ease of use, a basic symbolic link is kept around from /home/wikipedia/logs to the new directory. This would need to be manually fixed whenever the new class is applied on the logging server. Change-Id: I22b9852aebbc45f601bdc37e3f2dc5a0acfc6c1b --- M manifests/role/logging.pp 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Lcarr: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33813 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22b9852aebbc45f601bdc37e3f2dc5a0acfc6c1b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: Lcarr Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] New version: 1.2.3 - change (mediawiki...SemanticDrilldown[master])
Yaron Koren has submitted this change and it was merged. Change subject: New version: 1.2.3 .. New version: 1.2.3 Change-Id: I33f5d4393639dfe3520518bda8b00fe2cb2b8c04 --- M INSTALL M SemanticDrilldown.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaron Koren: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33820 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f5d4393639dfe3520518bda8b00fe2cb2b8c04 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticDrilldown Gerrit-Branch: master Gerrit-Owner: Yaron Koren Gerrit-Reviewer: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] New version: 1.2.3 - change (mediawiki...SemanticDrilldown[master])
Yaron Koren has uploaded a new change for review. Change subject: New version: 1.2.3 .. New version: 1.2.3 Change-Id: I33f5d4393639dfe3520518bda8b00fe2cb2b8c04 --- M INSTALL M SemanticDrilldown.php 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown refs/changes/20/33820/1 -- To view, visit https://gerrit.wikimedia.org/r/33820 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33f5d4393639dfe3520518bda8b00fe2cb2b8c04 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticDrilldown Gerrit-Branch: master Gerrit-Owner: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 42192 - s/mw.getConfig/mw.config.get/g - change (mediawiki...TimedMediaHandler[master])
MaxSem has uploaded a new change for review. Change subject: Bug 42192 - s/mw.getConfig/mw.config.get/g .. Bug 42192 - s/mw.getConfig/mw.config.get/g ...to avoid JS errors in production Change-Id: I3460b606dff4f343b98c0d3f73bc86a34e93ac50 --- M MwEmbedModules/EmbedPlayer/EmbedPlayer.loader.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerImageOverlay.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerJava.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js M MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js M MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js M MwEmbedModules/TimedText/TimedText.loader.js M MwEmbedModules/TimedText/resources/mw.TimedText.js M resources/mw.MediaWikiPlayerSupport.js 15 files changed, 86 insertions(+), 86 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/19/33819/1 -- To view, visit https://gerrit.wikimedia.org/r/33819 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3460b606dff4f343b98c0d3f73bc86a34e93ac50 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 37158) display personal menu on top of page tabs on Vec... - change (mediawiki/core[master])
MarkTraceur has submitted this change and it was merged. Change subject: (bug 37158) display personal menu on top of page tabs on Vector .. (bug 37158) display personal menu on top of page tabs on Vector If personal menu is long enough to span two lines, bottom part of the second one would be covered by the tabs. This changes the z-index to avoid this. Change-Id: I1c975095a598e4c0f5c259d82346f1c9112c7188 --- M skins/vector/screen.css 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Isarra: Looks good to me, but someone else must approve Martineznovo: Looks good to me, but someone else must approve MarkTraceur: Verified; Looks good to me, approved Henning Snater: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31288 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c975095a598e4c0f5c259d82346f1c9112c7188 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex Gerrit-Reviewer: Catrope Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Isarra Gerrit-Reviewer: MarkTraceur Gerrit-Reviewer: Martineznovo Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [Database] Fixed case where trx idle callbacks might be lost... - change (mediawiki/core[REL1_20])
Reedy has uploaded a new change for review. Change subject: [Database] Fixed case where trx idle callbacks might be lost. .. [Database] Fixed case where trx idle callbacks might be lost. * (bug 41656) LoadBalancer always commits if there are callbacks pending. This works by checking a new DatabaseBase::writesOrCallbacksPending() function. * Made transaction idle callbacks run in autocommit mode. Generally callers already want autocommit mode or do quick begin()/commit() calls anyway. The docs already make stat that callbacks should close any connections they start, but this makes it harder for people to forget about implicit transactions. Since the callbacks often may happen in commitMasterChanges(), if transactions are left open, they might not get committed by anything afterwards. * Added sanity exceptions and warnings if callbacks get lost for some reason. * Renamed trxIdleCallbacks -> mTrxIdleCallbacks for consistency. Change-Id: I00e1e0fcdd7d1fbac6d0f295160479cb8962 --- M includes/db/Database.php M includes/db/LoadBalancer.php 2 files changed, 35 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/18/33818/1 -- To view, visit https://gerrit.wikimedia.org/r/33818 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00e1e0fcdd7d1fbac6d0f295160479cb8962 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_20 Gerrit-Owner: Reedy Gerrit-Reviewer: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: better variable names - change (qa/browsertests[master])
Cmcmahon has submitted this change and it was merged. Change subject: Refactoring: better variable names .. Refactoring: better variable names Make it explict which username and password you are using. At the moment we use MediaWiki (test2) and Sauce Labs credentials. Change-Id: Ie575f578db21d2d05f7d85f8a39cd03c11a41fe3 --- M config/config.yml M features/step_definitions/login_steps.rb M features/step_definitions/uploadwizard_steps.rb M features/support/env.rb 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Cmcmahon: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33812 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie575f578db21d2d05f7d85f8a39cd03c11a41fe3 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin Gerrit-Reviewer: Cmcmahon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: simpler credentials managament - change (qa/browsertests[master])
Cmcmahon has submitted this change and it was merged. Change subject: Refactoring: simpler credentials managament .. Refactoring: simpler credentials managament Get credentials from config files just once, put it in instance variable and use it when needed. Change-Id: Ie16975839f5b3052a80bc861d09f386eae328ed7 --- M config/config.yml M features/step_definitions/login_steps.rb M features/step_definitions/uploadwizard_steps.rb M features/support/env.rb 4 files changed, 11 insertions(+), 13 deletions(-) Approvals: Cmcmahon: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33808 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16975839f5b3052a80bc861d09f386eae328ed7 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin Gerrit-Reviewer: Cmcmahon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: use local_variable instead of CONSTANT - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Refactoring: use local_variable instead of CONSTANT .. Refactoring: use local_variable instead of CONSTANT There is no need to use a CONSTANT to hold credentials, local_variable does the job. Change-Id: I3d0b902e7d03db16dad5dcbd175484d87150fe6b --- M features/support/env.rb 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/17/33817/1 -- To view, visit https://gerrit.wikimedia.org/r/33817 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d0b902e7d03db16dad5dcbd175484d87150fe6b Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fudge relative expiry when it is exactly equal to the maximu... - change (mediawiki/core[master])
Ori.livneh has uploaded a new change for review. Change subject: Fudge relative expiry when it is exactly equal to the maximum .. Fudge relative expiry when it is exactly equal to the maximum MemcachedBagOStuff::fixExpiry previously assumes that an expiry values greater than 2592000 but less than 10 were caller mistakes, and normalized them to 2592000, the maximum permitted relative expiry. This fact, combined with the common use of 2592000 to mean "cache indefinitely", means we risk a periodic cache stampede every thirty days. Changes: - Do not attempt to correct outright stupidity ($expiry = 999, etc.) - If the requested expiry is exactly equal to 2592000, fudge it by subtracting a random quantity of seconds (up to 12 hours). Change-Id: If2ee54c7202f4cfc833bab74fd29f84611e44c9a --- M includes/objectcache/MemcachedBagOStuff.php 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/16/33816/1 -- To view, visit https://gerrit.wikimedia.org/r/33816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2ee54c7202f4cfc833bab74fd29f84611e44c9a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added DataValue factory in JS - change (mediawiki...DataValues[master])
Daniel Werner has submitted this change and it was merged. Change subject: Added DataValue factory in JS .. Added DataValue factory in JS Change-Id: I59aa604c044022d9215599baade78954d36080a3 --- M DataValues/DataValues.mw.php M DataValues/includes/DataValueFactory.php M DataValues/resources/DataValue.js M DataValues/resources/dataValues.js M DataValues/resources/values/BoolValue.js M DataValues/resources/values/MonolingualTextValue.js M DataValues/resources/values/MultilingualTextValue.js M DataValues/resources/values/StringValue.js M DataValues/resources/values/UnknownValue.js M DataValues/tests/includes/DataValueFactoryTest.php A DataValues/tests/qunit/DataValues.tests.js 11 files changed, 232 insertions(+), 71 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59aa604c044022d9215599baade78954d36080a3 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix two typos - change (mediawiki...Translate[master])
Nemo bis has uploaded a new change for review. Change subject: Fix two typos .. Fix two typos Change-Id: I8cff3ab1a759eb6c06fbce40c4993edb58cc26c9 --- M README M Translate.php 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/15/33815/1 -- To view, visit https://gerrit.wikimedia.org/r/33815 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8cff3ab1a759eb6c06fbce40c4993edb58cc26c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nemo bis ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Costmetic changes - change (mediawiki...SemanticDrilldown[master])
Yaron Koren has submitted this change and it was merged. Change subject: Costmetic changes .. Costmetic changes Change-Id: I38d5aa1d02239fbda4ea0336f3026818427937fc --- M specials/SD_BrowseData.php 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Yaron Koren: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38d5aa1d02239fbda4ea0336f3026818427937fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticDrilldown Gerrit-Branch: master Gerrit-Owner: Yaron Koren Gerrit-Reviewer: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Costmetic changes - change (mediawiki...SemanticDrilldown[master])
Yaron Koren has uploaded a new change for review. Change subject: Costmetic changes .. Costmetic changes Change-Id: I38d5aa1d02239fbda4ea0336f3026818427937fc --- M specials/SD_BrowseData.php 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticDrilldown refs/changes/14/33814/1 -- To view, visit https://gerrit.wikimedia.org/r/33814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38d5aa1d02239fbda4ea0336f3026818427937fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticDrilldown Gerrit-Branch: master Gerrit-Owner: Yaron Koren ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41183) move beta logs out of /home - change (operations/puppet[production])
Hashar has uploaded a new change for review. Change subject: (bug 41183) move beta logs out of /home .. (bug 41183) move beta logs out of /home In labs /home is a shared directory. Since the beginning of this project the udp2log have been written to /home/wikipedia/logs and end up filling the shared directory from time to time. A better usage would be to write log to the project directory /data/project. The new role::beta::logging::mediawiki simply calls the previously applied class role::logging::mediawiki but using /data/project/logs. For back compatibility and ease of use, a basic symbolic link is kept around from /home/wikipedia/logs to the new directory. This would need to be manually fixed whenever the new class is applied on the logging server. Change-Id: I22b9852aebbc45f601bdc37e3f2dc5a0acfc6c1b --- M manifests/role/logging.pp 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/13/33813/1 -- To view, visit https://gerrit.wikimedia.org/r/33813 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I22b9852aebbc45f601bdc37e3f2dc5a0acfc6c1b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added bool value and parser - change (mediawiki...DataValues[master])
Daniel Werner has submitted this change and it was merged. Change subject: Added bool value and parser .. Added bool value and parser Change-Id: I10297cf3b389a3b2de03f4f5f88c3ab6efe0a96f --- M DataValues/DataValues.mw.php M DataValues/Resources.php A DataValues/resources/values/BoolValue.js M DataValues/resources/values/MonolingualTextValue.js M DataValues/resources/values/MultilingualTextValue.js M DataValues/resources/values/StringValue.js M DataValues/resources/values/UnknownValue.js A DataValues/tests/qunit/values/BoolValue.tests.js M ValueParsers/Resources.php M ValueParsers/ValueParsers.mw.php M ValueParsers/resources/Api.js A ValueParsers/resources/parsers/BoolParser.js M ValueParsers/tests/qunit/ValueParser.tests.js A ValueParsers/tests/qunit/parsers/BoolParser.tests.js 14 files changed, 261 insertions(+), 2 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33588 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10297cf3b389a3b2de03f4f5f88c3ab6efe0a96f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: better variable names - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Refactoring: better variable names .. Refactoring: better variable names Make it explict which username and password you are using. At the moment we use MediaWiki (test2) and Sauce Labs credentials. Change-Id: Ie575f578db21d2d05f7d85f8a39cd03c11a41fe3 --- M config/config.yml M features/step_definitions/login_steps.rb M features/step_definitions/uploadwizard_steps.rb M features/support/env.rb 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/12/33812/1 -- To view, visit https://gerrit.wikimedia.org/r/33812 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie575f578db21d2d05f7d85f8a39cd03c11a41fe3 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added null parser in JS - change (mediawiki...DataValues[master])
Daniel Werner has submitted this change and it was merged. Change subject: Added null parser in JS .. Added null parser in JS Change-Id: I1a7496e1b5858538cf6ca534c0043ea69d1b0090 --- M DataValues/DataValues.mw.php M DataValues/Resources.php M DataValues/includes/values/UnknownValue.php A DataValues/resources/values/UnknownValue.js A DataValues/tests/qunit/values/UnknownValue.tests.js M ValueParsers/Resources.php M ValueParsers/ValueParsers.mw.php M ValueParsers/resources/parsers/IntParser.js A ValueParsers/resources/parsers/NullParser.js A ValueParsers/tests/qunit/parsers/NullParser.tests.js 10 files changed, 263 insertions(+), 2 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a7496e1b5858538cf6ca534c0043ea69d1b0090 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] pulling es1 for converstion to innodb - change (operations/mediawiki-config[master])
Pyoungmeister has submitted this change and it was merged. Change subject: pulling es1 for converstion to innodb .. pulling es1 for converstion to innodb Change-Id: I01a7e6096d47a1493f6780b2211dfea1dc3f47f2 --- M wmf-config/db.php 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33811 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a7e6096d47a1493f6780b2211dfea1dc3f47f2 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] pulling es1 for converstion to innodb - change (operations/mediawiki-config[master])
Pyoungmeister has uploaded a new change for review. Change subject: pulling es1 for converstion to innodb .. pulling es1 for converstion to innodb Change-Id: I01a7e6096d47a1493f6780b2211dfea1dc3f47f2 --- M wmf-config/db.php 1 file changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/11/33811/1 -- To view, visit https://gerrit.wikimedia.org/r/33811 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I01a7e6096d47a1493f6780b2211dfea1dc3f47f2 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More prefs functionality for Echo - change (mediawiki...Echo[master])
Kaldari has uploaded a new change for review. Change subject: More prefs functionality for Echo .. More prefs functionality for Echo Change-Id: I9b971bd11171e73cd4d0c4ea10f817f4e19024f2 --- M Echo.i18n.php M Echo.php M Hooks.php M controller/NotificationController.php 4 files changed, 106 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/10/33810/1 -- To view, visit https://gerrit.wikimedia.org/r/33810 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b971bd11171e73cd4d0c4ea10f817f4e19024f2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Unset DirectoryIterator in the FileBackend - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Unset DirectoryIterator in the FileBackend .. Unset DirectoryIterator in the FileBackend This is necessory to close all handlers on the directory and than it is possible to rmdir the directory without a 'permission denied' on a windows machine. Corresponding unit test failure: 1) FileBackendTest::testRecursiveClean Dir mwstore://localtesting/unittest-cont1/e/a no longer exists (FSFileBackend). Failed asserting that true matches expected false. Change-Id: Ide58c6d0ec101bf0ddcd6b7414c51075fc28825b --- M includes/filebackend/FileBackendStore.php M tests/phpunit/includes/filebackend/FileBackendTest.php 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33750 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide58c6d0ec101bf0ddcd6b7414c51075fc28825b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup: delete unused configuration - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Cleanup: delete unused configuration .. Cleanup: delete unused configuration Looks like this is not used anywhere. Change-Id: I6e507e6bb20992640a81e0ee0a732b2ed14248f1 --- M config/config.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/09/33809/1 -- To view, visit https://gerrit.wikimedia.org/r/33809 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e507e6bb20992640a81e0ee0a732b2ed14248f1 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: simpler credentials managament - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Refactoring: simpler credentials managament .. Refactoring: simpler credentials managament Get credentials from config files just once, put it in instance variable and use it when needed. Change-Id: Ie16975839f5b3052a80bc861d09f386eae328ed7 --- M config/config.yml M features/step_definitions/login_steps.rb M features/step_definitions/uploadwizard_steps.rb M features/support/env.rb 4 files changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/08/33808/1 -- To view, visit https://gerrit.wikimedia.org/r/33808 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie16975839f5b3052a80bc861d09f386eae328ed7 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Phantoms not vanishing on mouseout - change (mediawiki...VisualEditor[master])
Trevor Parscal has submitted this change and it was merged. Change subject: Phantoms not vanishing on mouseout .. Phantoms not vanishing on mouseout If the mouse is moved too quickly, the phantoms have a tendency to stick. This change moves the event from phantom.mouseleave to surface.mousemove. Change-Id: I2c7e7bdc838427d4355a6c0c13bafe3198636dbe --- M VisualEditor.php M demos/ve/index.php M modules/ve/ce/nodes/ve.ce.AlienBlockNode.js M modules/ve/ce/nodes/ve.ce.AlienInlineNode.js A modules/ve/ce/nodes/ve.ce.AlienNode.js M modules/ve/ce/ve.ce.Surface.js 6 files changed, 102 insertions(+), 49 deletions(-) Approvals: Christian: Looks good to me, but someone else must approve Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33670 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7e7bdc838427d4355a6c0c13bafe3198636dbe Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Christian Gerrit-Reviewer: Christian Gerrit-Reviewer: Inez Gerrit-Reviewer: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] setting srv214-218 and srv231-247 to use appalicationserver ... - change (operations/puppet[production])
Pyoungmeister has submitted this change and it was merged. Change subject: setting srv214-218 and srv231-247 to use appalicationserver role classes .. setting srv214-218 and srv231-247 to use appalicationserver role classes Change-Id: I8628d9693ced6414524c24f3da093b7c7da4314c --- M manifests/site.pp 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33803 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8628d9693ced6414524c24f3da093b7c7da4314c Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] setting srv214-218 and srv231-247 to use appalicationserver ... - change (operations/puppet[production])
Pyoungmeister has uploaded a new change for review. Change subject: setting srv214-218 and srv231-247 to use appalicationserver role classes .. setting srv214-218 and srv231-247 to use appalicationserver role classes Change-Id: I8628d9693ced6414524c24f3da093b7c7da4314c --- M manifests/site.pp 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/03/33803/1 -- To view, visit https://gerrit.wikimedia.org/r/33803 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8628d9693ced6414524c24f3da093b7c7da4314c Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] The great inspector and context rewrite of 2012 - change (mediawiki...VisualEditor[master])
Trevor Parscal has uploaded a new change for review. Change subject: The great inspector and context rewrite of 2012 .. The great inspector and context rewrite of 2012 ve.AnnotationAction * Added filter to the clearAll method to allow clearing all matching annotations only ve.dm.Document * Some variable renaming for consistency ve.dm.SurfaceFragment * Added truncateRange method * Added annotation scope to expandRange method * Added support for passing an annotation object into annotateContent method * Switched to using name instead of type in annotateContent method to match the ve.dm.Annotation class ve.ui.LinkInspector * Moved most of the functionality elsewhere * General reorganization * Changed setOverlayPosition to accept 2 arguments instead of an object with 2 properties and renamed it to positionOverlayBelow icons.ai, inspector.png, inspector.svg * Added generic inspector icon which will be used when a custom icon is not specified in future inspector subclasses ve.ui.Inspector.Icons * Added inspector icon * Renamed clear icon to remove to match it's actual image ve.ui.Context * Greatly simplified the interface, reducing the number of methods by inlining a few things and combining others * Now always listening to resize events on the window rather than only while document is focused * Not listening to scroll events anymore, they used to affect the top/bottom positioning of the menu which we don't do anymore * Lots of cleanup and reorganization ve.ui.Frame * Simplified the constructor by introducing the createFrame method * General cleanup ve.ui.Inspector * Generalized lots of functionality previously located in the link inspector class which will be useful to all inspectors (such as title, clear button, saving changes, etc.) * Added setDisabled and isDisabled methods to manage CSS changes and avoid needing to check the CSS to determine the state of the inspector (storing state in the view is evil) * Added getMatchingAnnotations method for convenience * Added prepareSelection stub * Lots of cleanup and documentation * Type pattern is now defined in base class ve.ui.InspectorFactory * Depending on type pattern now since it's always there * Added getInspectorsForAnnotations method VisualEditor, VisualEditor.i18n * Added default inspector message Change-Id: I1cc008445bcbc8cba6754ca4b6ac0397575980d5 --- M VisualEditor.i18n.php M VisualEditor.php M modules/ve/actions/ve.AnnotationAction.js M modules/ve/dm/ve.dm.Document.js M modules/ve/dm/ve.dm.SurfaceFragment.js M modules/ve/ui/inspectors/ve.ui.LinkInspector.js M modules/ve/ui/styles/images/icons.ai A modules/ve/ui/styles/images/icons/inspector.png A modules/ve/ui/styles/images/icons/inspector.svg M modules/ve/ui/styles/ve.ui.Inspector.Icons-raster.css M modules/ve/ui/styles/ve.ui.Inspector.Icons-vector.css M modules/ve/ui/styles/ve.ui.Inspector.css M modules/ve/ui/ve.ui.Context.js M modules/ve/ui/ve.ui.Frame.js M modules/ve/ui/ve.ui.Inspector.js M modules/ve/ui/ve.ui.InspectorFactory.js 16 files changed, 2,613 insertions(+), 1,172 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/96/33796/1 -- To view, visit https://gerrit.wikimedia.org/r/33796 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1cc008445bcbc8cba6754ca4b6ac0397575980d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42176) make Entity::newFromPrefixedId() and isPrefixedI... - change (mediawiki...Wikibase[master])
Aude has uploaded a new change for review. Change subject: (bug 42176) make Entity::newFromPrefixedId() and isPrefixedId() case-insensitive .. (bug 42176) make Entity::newFromPrefixedId() and isPrefixedId() case-insensitive Change-Id: I8c707c1f9adb9246bb2dee6d66f28e974d626573 --- M lib/includes/entity/EntityId.php M lib/tests/phpunit/entity/EntityIdTest.php 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/89/33789/1 -- To view, visit https://gerrit.wikimedia.org/r/33789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8c707c1f9adb9246bb2dee6d66f28e974d626573 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kill mobileRedirect.php, not used since forever - change (operations/mediawiki-config[master])
MaxSem has uploaded a new change for review. Change subject: Kill mobileRedirect.php, not used since forever .. Kill mobileRedirect.php, not used since forever Change-Id: I510ba4c18542892e3afc66b5c8f9b166ace3dd54 --- D live-1.5/mobileRedirect.php 1 file changed, 0 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/86/33786/1 -- To view, visit https://gerrit.wikimedia.org/r/33786 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I510ba4c18542892e3afc66b5c8f9b166ace3dd54 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])
Mwjames has submitted this change and it was merged. Change subject: Merge branch 'master' into 1.9.x .. Merge branch 'master' into 1.9.x Change-Id: I3493c82ec81e1612c701c1af337fd87ae053faed --- 0 files changed, 0 insertions(+), 0 deletions(-) Approvals: Mwjames: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33753 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3493c82ec81e1612c701c1af337fd87ae053faed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Mwjames Gerrit-Reviewer: Mwjames ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' into 1.9.x - change (mediawiki...SemanticMediaWiki[1.9.x])
Mwjames has uploaded a new change for review. Change subject: Merge branch 'master' into 1.9.x .. Merge branch 'master' into 1.9.x Change-Id: I3493c82ec81e1612c701c1af337fd87ae053faed --- 0 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/53/33753/1 -- To view, visit https://gerrit.wikimedia.org/r/33753 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3493c82ec81e1612c701c1af337fd87ae053faed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Mwjames ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [FileBackend] Stat caching improvements. - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: [FileBackend] Stat caching improvements. .. [FileBackend] Stat caching improvements. Callers often tend to end up calling getFileStat(), at least indirectly, or in various successive function on the same path. This created RTTs when the file didn't exist since negatives were not cached. This change does the following: * Cache definitive negatives (404s) in the process cache. Nothing is cached on failure (like network problems). * Ignore process cache entries after a brief time period so long running scripts do not have overly stale entries. Change-Id: I356bd9f48281e3c7e7a273778b2aca59c521a0c7 --- M includes/cache/ProcessCacheLRU.php M includes/filebackend/FileBackendStore.php 2 files changed, 28 insertions(+), 11 deletions(-) Approvals: Aaron Schulz: Demon: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33751 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I356bd9f48281e3c7e7a273778b2aca59c521a0c7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Demon Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update 1.9 release notes - change (mediawiki...SemanticMediaWiki[1.9.x])
Mwjames has submitted this change and it was merged. Change subject: Update 1.9 release notes .. Update 1.9 release notes Change-Id: I4d302e6f5a6d0ba7b98d33720d20a60833ae79f0 --- M RELEASE-NOTES-1.9 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mwjames: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33752 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d302e6f5a6d0ba7b98d33720d20a60833ae79f0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Mwjames Gerrit-Reviewer: Mwjames ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
