[MediaWiki-commits] [Gerrit] Increase fcgi buffers a bit - change (translatewiki[master])
Nikerabbit has uploaded a new change for review. Change subject: Increase fcgi buffers a bit .. Increase fcgi buffers a bit Change-Id: I1f9a001b0b70e7d22675033605cca573743dd1d6 --- M puppet/modules/nginx/files/sites/translatewiki.net 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/58/34858/1 -- To view, visit https://gerrit.wikimedia.org/r/34858 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f9a001b0b70e7d22675033605cca573743dd1d6 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] nginx listen on ipv6 too - change (translatewiki[master])
Nikerabbit has uploaded a new change for review. Change subject: nginx listen on ipv6 too .. nginx listen on ipv6 too Change-Id: I2ff8f052079a7eb338f218c7c66a23dc1fa56250 --- M puppet/modules/nginx/files/sites/translatewiki.net 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/59/34859/1 -- To view, visit https://gerrit.wikimedia.org/r/34859 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ff8f052079a7eb338f218c7c66a23dc1fa56250 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Increase fcgi buffers a bit - change (translatewiki[master])
Siebrand has submitted this change and it was merged. Change subject: Increase fcgi buffers a bit .. Increase fcgi buffers a bit Change-Id: I1f9a001b0b70e7d22675033605cca573743dd1d6 --- M puppet/modules/nginx/files/sites/translatewiki.net 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34858 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f9a001b0b70e7d22675033605cca573743dd1d6 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] nginx listen on ipv6 too - change (translatewiki[master])
Siebrand has submitted this change and it was merged. Change subject: nginx listen on ipv6 too .. nginx listen on ipv6 too Change-Id: I2ff8f052079a7eb338f218c7c66a23dc1fa56250 --- M puppet/modules/nginx/files/sites/translatewiki.net 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34859 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ff8f052079a7eb338f218c7c66a23dc1fa56250 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Apply preventCategorization to all translations - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Apply preventCategorization to all translations .. Apply preventCategorization to all translations https://translatewiki.net/wiki/Thread:Support/OSM:Notifier.signup_confirm_html.user_wiki_page Tests are include in the price Change-Id: I750f027e25e281aea3d8142ba9f254968d4e15f1 --- M Translate.php M TranslateHooks.php M tag/PageTranslationHooks.php 3 files changed, 11 insertions(+), 15 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34542 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I750f027e25e281aea3d8142ba9f254968d4e15f1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More fixes to bundlecreater - change (translatewiki[master])
Siebrand has submitted this change and it was merged. Change subject: More fixes to bundlecreater .. More fixes to bundlecreater Change-Id: Ice0f34176fd128b2232739a9fe4f176549e3a859 --- M melange/BundleCreater.php M melange/INSTALL.MediaWikiLanguageExtensionBundle M melange/config.ini 3 files changed, 44 insertions(+), 25 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34497 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0f34176fd128b2232739a9fe4f176549e3a859 Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Avoid buildup of whitespace in pyffs - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Avoid buildup of whitespace in pyffs .. Avoid buildup of whitespace in pyffs Change-Id: I4fd633e5cd4fdfcc4ae36a35346c4e28bd12ec2c --- M ffs/PythonSingleFFS.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34292 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fd633e5cd4fdfcc4ae36a35346c4e28bd12ec2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add message for Waymarked Trails Help group desc - change (mediawiki...Translate[master])
Siebrand has submitted this change and it was merged. Change subject: Add message for Waymarked Trails Help group desc .. Add message for Waymarked Trails Help group desc See Ib8f3763bc7be85b6b00ff93d07735f9480419992 Change-Id: Id1a0386690f514b85005642a2bf8a9407b4c4550 --- M TranslateGroupDescriptions.i18n.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34591 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1a0386690f514b85005642a2bf8a9407b4c4550 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use message for Waymarked Trails Help group desc - change (translatewiki[master])
Siebrand has submitted this change and it was merged. Change subject: Use message for Waymarked Trails Help group desc .. Use message for Waymarked Trails Help group desc https://translatewiki.net/w/i.php?title=Thread:Support/How_to_localize_the_group_description_of_the_help_pages_of_the_Waymarked_Trails_web_sites%3F Change-Id: Ib8f3763bc7be85b6b00ff93d07735f9480419992 --- M OpenStreetMap/WaymarkedTrailsHelp.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34590 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8f3763bc7be85b6b00ff93d07735f9480419992 Gerrit-PatchSet: 2 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Nemo bis federicol...@tiscali.it Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Maintenance for GoogleNewsSitemap extension. - change (mediawiki...GoogleNewsSitemap[master])
Siebrand has submitted this change and it was merged. Change subject: Maintenance for GoogleNewsSitemap extension. .. Maintenance for GoogleNewsSitemap extension. * Replace deprecated methods. * Deglobalize. * Update docs. * Use __DIR__ insread of dirname( __FILE__ ). * Remove unneeded MEDIAWIKI constant check. * Bump version. * Remove superfluous newlines. Change-Id: I5acf86aba3209f335a328bf83436fad57eaa0875 --- M FeedSMItem.php M GoogleNewsSitemap.php M GoogleNewsSitemap_body.php M SitemapFeed.php 4 files changed, 42 insertions(+), 38 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5acf86aba3209f335a328bf83436fad57eaa0875 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/GoogleNewsSitemap Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: Brian Wolff bawolff...@gmail.com Gerrit-Reviewer: IAlex ialex.w...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] /etc/zuul/wikimedia no more belong to root - change (operations/puppet[production])
ArielGlenn has submitted this change and it was merged. Change subject: /etc/zuul/wikimedia no more belong to root .. /etc/zuul/wikimedia no more belong to root The path contains the continuous integration workflow and we need to be able to adapt it quickly, possibly using live hacks. This makes the file belong to the jenkins user instead of root so we dont end up being blocked. Change-Id: Ia4c9524b7a0fbb0df692ba78119df6e1af0eb48f --- M manifests/zuul.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: ArielGlenn: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34848 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4c9524b7a0fbb0df692ba78119df6e1af0eb48f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: ArielGlenn ar...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Consistency tweaks in preparation for translation - change (mediawiki...LightweightRDFa[master])
Kontokostas has submitted this change and it was merged. Change subject: Consistency tweaks in preparation for translation .. Consistency tweaks in preparation for translation * Add file path * Add description message * http-https Change-Id: I7aec50c59c61be8193217caa5d0849b54c06062a --- M LightweightRDFa.i18n.php M LightweightRDFa.php 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Kontokostas: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aec50c59c61be8193217caa5d0849b54c06062a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LightweightRDFa Gerrit-Branch: master Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com Gerrit-Reviewer: Kontokostas jimk...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Avoid hardcoded font fallback stack - change (mediawiki...UniversalLanguageSelector[master])
Nikerabbit has submitted this change and it was merged. Change subject: Avoid hardcoded font fallback stack .. Avoid hardcoded font fallback stack Change-Id: I07571d1390f4f68313b786d3dd1371488b6534a6 --- M resources/js/ext.uls.webfonts.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34857 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07571d1390f4f68313b786d3dd1371488b6534a6 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 42374 - Provide clear indication of lack of IME supp... - change (mediawiki...UniversalLanguageSelector[master])
Santhosh has uploaded a new change for review. Change subject: Fix Bug 42374 - Provide clear indication of lack of IME support for a language .. Fix Bug 42374 - Provide clear indication of lack of IME support for a language Change-Id: Id637eed3544a66aac4185f9e9d967691fe481331 --- M i18n/en.json M i18n/ml.json M i18n/qqq.json M resources/js/ext.uls.inputsettings.js 4 files changed, 15 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/60/34860/1 -- To view, visit https://gerrit.wikimedia.org/r/34860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id637eed3544a66aac4185f9e9d967691fe481331 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix the language selection from language selector for IME - change (mediawiki...UniversalLanguageSelector[master])
Amire80 has submitted this change and it was merged. Change subject: Fix the language selection from language selector for IME .. Fix the language selection from language selector for IME Change-Id: I40e77680e4832a38a9c0ae03bbf5a3850afa518e --- M resources/js/ext.uls.ime.js 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Amire80: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34696 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40e77680e4832a38a9c0ae03bbf5a3850afa518e Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] No need of IME in language search bar of ULS - change (mediawiki...UniversalLanguageSelector[master])
Amire80 has submitted this change and it was merged. Change subject: No need of IME in language search bar of ULS .. No need of IME in language search bar of ULS Change-Id: Iab5c08f3edd5047200819fa3cde95bfb5d78db35 --- M resources/js/ext.uls.init.js 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Amire80: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34700 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5c08f3edd5047200819fa3cde95bfb5d78db35 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] dummy generic module - change (operations/puppet[production])
Hashar has uploaded a new change for review. Change subject: dummy generic module .. dummy generic module We use several classes whose names start with generic::, I guess we might end up moving them to a puppet module. This simply create a dummy generic module that we could extend later on. Change-Id: Ia5a9d04ed341ae8b3c32bdabe46712f341c3110e --- A modules/generic/manifests/init.pp 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/61/34861/1 -- To view, visit https://gerrit.wikimedia.org/r/34861 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5a9d04ed341ae8b3c32bdabe46712f341c3110e Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Generic class to install OpenJDK - change (operations/puppet[production])
Hashar has uploaded a new change for review. Change subject: Generic class to install OpenJDK .. Generic class to install OpenJDK This generic::packages::openjdk class would let us install OpenJDK jre and jdk at a specific version (6, 7 or whater ubuntu uses per default). I only tested it locally using: puppet apply --noop --verbose --modulepath=modules \ -e include generic::packages::openjdk Change-Id: I8123013c41887107490245553e8c132285abbc1d --- A modules/generic/manifests/packages/openjdk.pp 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/62/34862/1 -- To view, visit https://gerrit.wikimedia.org/r/34862 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8123013c41887107490245553e8c132285abbc1d Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] OpenJDK JRE/JDK on CI host - change (operations/puppet[production])
Hashar has uploaded a new change for review. Change subject: OpenJDK JRE/JDK on CI host .. OpenJDK JRE/JDK on CI host This install OpenJDK 6 and 7 on the Jenkins host, we need them when building Java applications. See also bug 42380. Change-Id: Ie211e55cbbbd161463ac25e9e0b03fe8298b7e5b --- M manifests/misc/contint.pp 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/63/34863/1 -- To view, visit https://gerrit.wikimedia.org/r/34863 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie211e55cbbbd161463ac25e9e0b03fe8298b7e5b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix link to repo entity in client recent changes - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Fix link to repo entity in client recent changes .. Fix link to repo entity in client recent changes Change-Id: Ia5a1727a1fa5284bb301605689e68c9eba99ca68 --- M client/includes/ExternalChangesList.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Nikerabbit: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/34533 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5a1727a1fa5284bb301605689e68c9eba99ca68 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code should also be more readable overall now. This fixes Bug 42361. Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef --- M includes/datavalues/SMW_DV_String.php 1 file changed, 88 insertions(+), 31 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/64/34864/1 -- To view, visit https://gerrit.wikimedia.org/r/34864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] updated todos - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: updated todos .. updated todos Change-Id: I6f0bf81ebfb98237be32e50bf73fff13e72cefa9 --- M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiGetClaims.php M repo/includes/api/ApiRemoveClaims.php 3 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/65/34865/1 -- To view, visit https://gerrit.wikimedia.org/r/34865 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6f0bf81ebfb98237be32e50bf73fff13e72cefa9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] updated todos - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: updated todos .. updated todos Change-Id: I6f0bf81ebfb98237be32e50bf73fff13e72cefa9 --- M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiGetClaims.php M repo/includes/api/ApiRemoveClaims.php 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34865 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0bf81ebfb98237be32e50bf73fff13e72cefa9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix exception when searching for stuff beginning with Media... - change (mediawiki/core[master])
Nikerabbit has submitted this change and it was merged. Change subject: Fix exception when searching for stuff beginning with Media: .. Fix exception when searching for stuff beginning with Media: Change-Id: I8b5a419fa369ad91034c3769a4b228290b878e1b --- M includes/search/SearchEngine.php 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34679 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5a419fa369ad91034c3769a4b228290b878e1b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Change the way focus is called on quickedit boxes - change (mediawiki...Translate[master])
Santhosh has uploaded a new change for review. Change subject: Change the way focus is called on quickedit boxes .. Change the way focus is called on quickedit boxes Instead of directly calling jquery focus, call DOM Element focus method to get all focus listeners notified. For example, when IME is integrated to edit box, since there is a focus handler already defined using jquery and since focus event does not bubble, event is not reached to IME binding handler. But when DOM element focus API is used, both handlers get called. Change-Id: I0023aeb6a5b4e41456e2702a80c6cf2f284da3e2 --- M resources/ext.translate.quickedit.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/66/34866/1 -- To view, visit https://gerrit.wikimedia.org/r/34866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0023aeb6a5b4e41456e2702a80c6cf2f284da3e2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added profiling to test runner. - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: Added profiling to test runner. .. Added profiling to test runner. MediaWikiTestCase now calls wfProfileIn/wfProfileOut for each call to a test function. This makes it easy to track down slow tests. Change-Id: I5ff2fea957c082f41da37936fe44948ad006f573 --- M tests/phpunit/MediaWikiPHPUnitCommand.php M tests/phpunit/MediaWikiTestCase.php 2 files changed, 28 insertions(+), 3 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ff2fea957c082f41da37936fe44948ad006f573 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Asher afeld...@wikimedia.org Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41792) Fix Special:Preferences tabs in IE8 compatibilit... - change (mediawiki/core[master])
Nikerabbit has submitted this change and it was merged. Change subject: (bug 41792) Fix Special:Preferences tabs in IE8 compatibility mode .. (bug 41792) Fix Special:Preferences tabs in IE8 compatibility mode It seems that IE8 lies about supporting onhashchange with the standard feature test when in compatibility mode. So, sadly, we must add in an explicit browser check if we want this to work. Change-Id: Ib2c1b150acd0a0b5b16604e8623d6aa78017a9a0 --- M resources/mediawiki.special/mediawiki.special.preferences.js 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Matmarex: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34329 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c1b150acd0a0b5b16604e8623d6aa78017a9a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie bjor...@wikimedia.org Gerrit-Reviewer: Matmarex matma@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wb.Api.createClaim now takes a wb.Claim object - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: wb.Api.createClaim now takes a wb.Claim object .. wb.Api.createClaim now takes a wb.Claim object * createClaim required three parameters for defining the claim and requires a wb.Claim instance now * wb.PropertyValueSnak only takes a DataValue as second parameter now * added wb.Snak.toJSON() * adjusted tests for Snaks * cleaned up some var names and comments * test for createClaim is still missing, waiting for API support for creating entities Change-Id: I2bd5d99574ffefc457841b2460622757b953158b --- M lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js M lib/resources/wikibase.datamodel/wikibase.Snak.js M lib/resources/wikibase.store/wikibase.Api.js M lib/tests/qunit/wikibase.datamodel/Wikibase.snak.tests.js 4 files changed, 76 insertions(+), 55 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34582 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd5d99574ffefc457841b2460622757b953158b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Change the way focus is called on quickedit boxes - change (mediawiki...Translate[master])
Nikerabbit has submitted this change and it was merged. Change subject: Change the way focus is called on quickedit boxes .. Change the way focus is called on quickedit boxes Instead of directly calling jquery focus, call DOM Element focus method to get all focus listeners notified. For example, when IME is integrated to edit box, since there is a focus handler already defined using jquery and since focus event does not bubble, event is not reached to IME binding handler. But when DOM element focus API is used, both handlers get called. Change-Id: I0023aeb6a5b4e41456e2702a80c6cf2f284da3e2 --- M resources/ext.translate.quickedit.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0023aeb6a5b4e41456e2702a80c6cf2f284da3e2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add MediaWikiTestCase::checkHasDiff3 and use it - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: Add MediaWikiTestCase::checkHasDiff3 and use it .. Add MediaWikiTestCase::checkHasDiff3 and use it Some tests can only passed, when diff3 is enabled on the wiki, when not the tests should marked as skipped. To avoid code duplicates inside the test folder for the check, if diff3 is enabled, the new function MediaWikiTestCase::checkHasDiff3 can be used. Change-Id: Ie765da49a4a1358da78a3506e38772d61bcd010c --- M tests/phpunit/MediaWikiTestCase.php M tests/phpunit/includes/EditPageTest.php M tests/phpunit/includes/GlobalFunctions/GlobalTest.php M tests/phpunit/includes/WikiPageTest.php M tests/phpunit/includes/content/WikitextContentHandlerTest.php 5 files changed, 25 insertions(+), 33 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie765da49a4a1358da78a3506e38772d61bcd010c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wb.Snak has a getType() function instead of TYPE constant no... - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: wb.Snak has a getType() function instead of TYPE constant now .. wb.Snak has a getType() function instead of TYPE constant now The constant still exists but as a property of the constructor. This allows to use someSnakInstance.getType() === wb.PropertyValueSnak.TYPE Change-Id: Ie4ee9ff8b5d9a3e393b59c5c68abcd8f426afabd --- M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js M lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js M lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js M lib/resources/wikibase.datamodel/wikibase.Snak.js M lib/tests/qunit/wikibase.datamodel/Wikibase.snak.tests.js 6 files changed, 52 insertions(+), 32 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34608 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ee9ff8b5d9a3e393b59c5c68abcd8f426afabd Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rename key to claim - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: rename key to claim .. rename key to claim Change-Id: Ibcdc2e71c3d222dc467aa1ad349cda29b6fd9267 --- M repo/includes/api/ApiGetClaims.php M repo/includes/api/ApiRemoveClaims.php M repo/tests/phpunit/includes/api/ApiGetClaimsTest.php M repo/tests/phpunit/includes/api/ApiRemoveClaimsTest.php 4 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/67/34867/1 -- To view, visit https://gerrit.wikimedia.org/r/34867 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibcdc2e71c3d222dc467aa1ad349cda29b6fd9267 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial poke at setference API module - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Initial poke at setference API module .. Initial poke at setference API module Needs 2 adittions to the backend before it can work, so no tests yet Change-Id: Ib7ec159798436d3890b9cdcb7b8dc987aefd1625 --- M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiGetClaims.php M repo/includes/api/ApiRemoveClaims.php M repo/includes/api/ApiSetClaimValue.php A repo/includes/api/ApiSetReference.php 5 files changed, 254 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/68/34868/1 -- To view, visit https://gerrit.wikimedia.org/r/34868 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7ec159798436d3890b9cdcb7b8dc987aefd1625 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Loop over all epoll events to check if we need to read vca_p... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has uploaded a new change for review. Change subject: Loop over all epoll events to check if we need to read vca_pipes .. Loop over all epoll events to check if we need to read vca_pipes This avoids an unnecessary syscall at the expense of linear searching over max NEEV=100 events --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/varnish refs/changes/69/34869/1 -- To view, visit https://gerrit.wikimedia.org/r/34869 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id96b9e8ada6326de2cc9009ae57b938a6cd3a31f Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Read the entire vca pipe at once at Linux typical size of 64... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has uploaded a new change for review. Change subject: Read the entire vca pipe at once at Linux typical size of 64 kiB .. Read the entire vca pipe at once at Linux typical size of 64 kiB --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/varnish refs/changes/70/34870/1 -- To view, visit https://gerrit.wikimedia.org/r/34870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f9d242deb3069a448dcd2014f029d5dac9a026a Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Read the entire vca pipe at once at Linux typical size of 64... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has uploaded a new change for review. Change subject: Read the entire vca pipe at once at Linux typical size of 64 kiB .. Read the entire vca pipe at once at Linux typical size of 64 kiB --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/varnish refs/changes/71/34871/1 -- To view, visit https://gerrit.wikimedia.org/r/34871 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9bc21fcaccae6ff0c6276023d4cd3d263137314a Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code should also be more readable overall now. This fixes Bug 42361. Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef --- M includes/datavalues/SMW_DV_String.php 1 file changed, 88 insertions(+), 31 deletions(-) Approvals: Markus Kroetzsch: Verified Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42374) Provide clear indication of lack of IME support ... - change (mediawiki...UniversalLanguageSelector[master])
Nikerabbit has submitted this change and it was merged. Change subject: (bug 42374) Provide clear indication of lack of IME support for a language .. (bug 42374) Provide clear indication of lack of IME support for a language Change-Id: Id637eed3544a66aac4185f9e9d967691fe481331 --- M i18n/en.json M i18n/ml.json M i18n/qqq.json M resources/js/ext.uls.inputsettings.js 4 files changed, 14 insertions(+), 11 deletions(-) Approvals: Nikerabbit: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id637eed3544a66aac4185f9e9d967691fe481331 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Pginer pgi...@wikimedia.org Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Read vca_pipes ss pointers first to avoid blocking worker th... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has submitted this change and it was merged. Change subject: Read vca_pipes ss pointers first to avoid blocking worker threads .. Read vca_pipes ss pointers first to avoid blocking worker threads Split reading of vca_pipes in vca_eev() into a separate function vca_read_ss(), and call it before iterating the epoll results. --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 28 insertions(+), 20 deletions(-) Approvals: Catrope: Looks good to me, but someone else must approve Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I609e3648142a9039d87d5c61df3292643536ccb5 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make the worker thread end of vca_pipes non-blocking as well - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has submitted this change and it was merged. Change subject: Make the worker thread end of vca_pipes non-blocking as well .. Make the worker thread end of vca_pipes non-blocking as well Varnish doesn't recover from many worker threads blocking on that pipe (e.g. because it's full), so this needs to be avoided. (Original patch by Artur Bergman) --- M bin/varnishd/cache_acceptor.c M bin/varnishd/cache_waiter_epoll.c M bin/varnishd/cache_waiter_kqueue.c M include/vsc_fields.h 4 files changed, 27 insertions(+), 2 deletions(-) Approvals: Catrope: Looks good to me, but someone else must approve Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I141af2af2c2c2fd9497062397e8817894a500db9 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Loop over all epoll events to check if we need to read vca_p... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has submitted this change and it was merged. Change subject: Loop over all epoll events to check if we need to read vca_pipes .. Loop over all epoll events to check if we need to read vca_pipes This avoids an unnecessary syscall at the expense of linear searching over max NEEV=100 events Change-Id: Id96b9e8ada6326de2cc9009ae57b938a6cd3a31f --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34869 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id96b9e8ada6326de2cc9009ae57b938a6cd3a31f Gerrit-PatchSet: 2 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Read the entire vca pipe at once at Linux typical size of 64... - change (operations...varnish[patches/optimize-epoll-thread])
Mark Bergsma has submitted this change and it was merged. Change subject: Read the entire vca pipe at once at Linux typical size of 64 kiB .. Read the entire vca pipe at once at Linux typical size of 64 kiB Change-Id: I9bc21fcaccae6ff0c6276023d4cd3d263137314a --- M bin/varnishd/cache_waiter_epoll.c 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34871 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc21fcaccae6ff0c6276023d4cd3d263137314a Gerrit-PatchSet: 3 Gerrit-Project: operations/debs/varnish Gerrit-Branch: patches/optimize-epoll-thread Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mw.Api's getEntities now uses get request - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: mw.Api's getEntities now uses get request .. mw.Api's getEntities now uses get request Using it before already returned an API warning because the edit token was set when it was not expected. Change-Id: I5cb3e69ee9dc293f27a858de961b52bc35b47623 --- M lib/resources/wikibase.store/wikibase.Api.js 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/72/34872/1 -- To view, visit https://gerrit.wikimedia.org/r/34872 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5cb3e69ee9dc293f27a858de961b52bc35b47623 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implemented unserialization for snaks - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Implemented unserialization for snaks .. Implemented unserialization for snaks Change-Id: I635204917ca8374a587d0df827f39f9e29f8a4b6 --- M lib/includes/serializers/Serializer.php M lib/includes/serializers/SnakSerializer.php M lib/includes/snak/SnakObject.php M lib/tests/phpunit/serializers/ByPropertyListSerializerTest.php M lib/tests/phpunit/serializers/ClaimSerializerTest.php M lib/tests/phpunit/serializers/ClaimsSerializerTest.php M lib/tests/phpunit/serializers/EntitySerializerBaseTest.php M lib/tests/phpunit/serializers/ItemSerializerTest.php M lib/tests/phpunit/serializers/PropertySerializerTest.php M lib/tests/phpunit/serializers/SerializationOptionsTest.php M lib/tests/phpunit/serializers/SerializerBaseTest.php M lib/tests/phpunit/serializers/SerializerTest.php M lib/tests/phpunit/serializers/SnakSerializerTest.php M repo/includes/api/ApiSetReference.php 14 files changed, 120 insertions(+), 23 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/73/34873/1 -- To view, visit https://gerrit.wikimedia.org/r/34873 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I635204917ca8374a587d0df827f39f9e29f8a4b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Typo. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Typo. .. Typo. Change-Id: I2876c4b43d78abcf00da16d446b9c57b42c2a305 --- M repo/includes/store/sql/EntityPerPageTable.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/74/34874/1 -- To view, visit https://gerrit.wikimedia.org/r/34874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2876c4b43d78abcf00da16d446b9c57b42c2a305 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated cog icon for the IME menu - change (mediawiki...UniversalLanguageSelector[master])
Pginer has uploaded a new change for review. Change subject: Updated cog icon for the IME menu .. Updated cog icon for the IME menu The cog icon has been updated to better integrate with the IME menu. Changes: color, margin at the sides and removal of triangle. Change-Id: Id03d3bd3c6401a4a9542c12581ad50626e6c959c --- M resources/images/cog-16x16-ltr.png M resources/images/cog-16x16-rtl.png 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/75/34875/1 -- To view, visit https://gerrit.wikimedia.org/r/34875 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id03d3bd3c6401a4a9542c12581ad50626e6c959c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Pginer pgi...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ORM: pass some __METHOD__ to database functions - change (mediawiki/core[master])
Umherirrender has uploaded a new change for review. Change subject: ORM: pass some __METHOD__ to database functions .. ORM: pass some __METHOD__ to database functions Change-Id: Ic76f88fe682118a097964e4011678ef4ad69113b --- M includes/db/ORMRow.php M includes/db/ORMTable.php 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/76/34876/1 -- To view, visit https://gerrit.wikimedia.org/r/34876 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic76f88fe682118a097964e4011678ef4ad69113b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CSS adjustment for the 'No input methods avaialble' message. - change (mediawiki...UniversalLanguageSelector[master])
Pginer has uploaded a new change for review. Change subject: CSS adjustment for the 'No input methods avaialble' message. .. CSS adjustment for the 'No input methods avaialble' message. * Avoids H4 to affect the layout when is empty. * Adjusts text and spacing according to other disabled messages in this context. Change-Id: Ia5ca2342aaec7554765fb492303851a216124a90 --- M resources/css/ext.uls.inputsettings.css 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/77/34877/1 -- To view, visit https://gerrit.wikimedia.org/r/34877 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5ca2342aaec7554765fb492303851a216124a90 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Pginer pgi...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CategoryTree to master - change (mediawiki/core[wmf/1.21wmf3])
MaxSem has submitted this change and it was merged. Change subject: Update CategoryTree to master .. Update CategoryTree to master Change-Id: I166cb6c2e809cba90702986a5df36d489162ebd0 --- M extensions/CategoryTree 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34694 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I166cb6c2e809cba90702986a5df36d489162ebd0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CategoryTree to master - change (mediawiki/core[wmf/1.21wmf4])
MaxSem has uploaded a new change for review. Change subject: Update CategoryTree to master .. Update CategoryTree to master Change-Id: I40e3f825daf2666ef931858246783fa28fcf0447 --- M extensions/CategoryTree 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/78/34878/1 -- To view, visit https://gerrit.wikimedia.org/r/34878 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40e3f825daf2666ef931858246783fa28fcf0447 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: MaxSem maxsem.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CategoryTree to master - change (mediawiki/core[wmf/1.21wmf4])
MaxSem has submitted this change and it was merged. Change subject: Update CategoryTree to master .. Update CategoryTree to master Change-Id: I40e3f825daf2666ef931858246783fa28fcf0447 --- M extensions/CategoryTree 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34878 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40e3f825daf2666ef931858246783fa28fcf0447 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf4 Gerrit-Owner: MaxSem maxsem.w...@gmail.com Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] No-JS view for entity claims - change (mediawiki...Wikibase[master])
Henning Snater has uploaded a new change for review. Change subject: No-JS view for entity claims .. No-JS view for entity claims Displaying simple string based entity claims when JavaScript is disabled. Change-Id: Iaf5c2517950f1876e0a0f7dd425556656751c506 --- M lib/resources/templates.php M lib/resources/wikibase.css M lib/resources/wikibase.ui.PropertyEditTool.css M repo/Wikibase.i18n.php M repo/includes/EntityView.php M repo/includes/ItemView.php M repo/resources/Resources.php M repo/resources/wikibase.ui.entityViewInit.js 8 files changed, 157 insertions(+), 23 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/79/34879/1 -- To view, visit https://gerrit.wikimedia.org/r/34879 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf5c2517950f1876e0a0f7dd425556656751c506 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) Return correct rev ID from API edits. - change (mediawiki...Wikibase[master])
Daniel Kinzler has uploaded a new change for review. Change subject: (no bug) Return correct rev ID from API edits. .. (no bug) Return correct rev ID from API edits. Make sure API calls that modify entities return the new revision's ID. This change provides a reliable way to determine the newly created revision, and adds code to API modules to use this information when generating output. Previously, only modules based on ApiModifyEntity returned lastrevid, and the value was often incorrect due to cached Revision objects. Change-Id: If0f4b6e068dfb31a9fb9ba07af226fac5de9634a --- M repo/includes/EditEntity.php M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiLinkTitles.php M repo/includes/api/ApiModifyEntity.php M repo/tests/phpunit/includes/api/ApiCreateClaimTest.php M repo/tests/phpunit/includes/api/ApiLinkTitlesTest.php M repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php 7 files changed, 72 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/80/34880/1 -- To view, visit https://gerrit.wikimedia.org/r/34880 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0f4b6e068dfb31a9fb9ba07af226fac5de9634a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 42150) Write script that queries the database for entit... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug 42150) Write script that queries the database for entity artifacts .. (Bug 42150) Write script that queries the database for entity artifacts Change-Id: I1b7bdf820c10af3ba1bc5b29e9376ce9ac24d567 --- A repo/maintenance/searchEntityArtefacts.php 1 file changed, 109 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/81/34881/1 -- To view, visit https://gerrit.wikimedia.org/r/34881 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b7bdf820c10af3ba1bc5b29e9376ce9ac24d567 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wbgetentities API module now takes 'datatype' in 'props' par... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: wbgetentities API module now takes 'datatype' in 'props' parameter .. wbgetentities API module now takes 'datatype' in 'props' parameter Change-Id: Idc9ec43d270a03429c87f75f2bc918be8cfd3dc2 --- M repo/includes/api/ApiGetEntities.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/82/34882/1 -- To view, visit https://gerrit.wikimedia.org/r/34882 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc9ec43d270a03429c87f75f2bc918be8cfd3dc2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] varnish (3.0.3plus~rc1-wm6) precise; urgency=low - change (operations...varnish[testing/3.0.3plus-rc1])
Mark Bergsma has uploaded a new change for review. Change subject: varnish (3.0.3plus~rc1-wm6) precise; urgency=low .. varnish (3.0.3plus~rc1-wm6) precise; urgency=low * Fix a deadlock of worker threads on the vca_pipe under load --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/varnish refs/changes/84/34884/1 -- To view, visit https://gerrit.wikimedia.org/r/34884 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib99a81b5d8c6619d3bbfbec71da27cbd46242669 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: testing/3.0.3plus-rc1 Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix a deadlock of worker threads on the vca_pipe under load - change (operations...varnish[testing/3.0.3plus-rc1])
Mark Bergsma has uploaded a new change for review. Change subject: Fix a deadlock of worker threads on the vca_pipe under load .. Fix a deadlock of worker threads on the vca_pipe under load Under high load, the epoll thread doesn't remove sessions from the vca_pipe fast enough, and can block many worker threads which Varnish doesn't recover from. Fixed by reading from the pipe earlier, and by setting the worker thread pipe end non-blocking. --- A debian/patches/0010-varnishd-optimize-epoll-thread.patch M debian/patches/series 2 files changed, 156 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/varnish refs/changes/83/34883/1 -- To view, visit https://gerrit.wikimedia.org/r/34883 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I576fed91632318f60e1c17f4f7410aea30623577 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: testing/3.0.3plus-rc1 Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix a deadlock of worker threads on the vca_pipe under load - change (operations...varnish[testing/3.0.3plus-rc1])
Mark Bergsma has submitted this change and it was merged. Change subject: Fix a deadlock of worker threads on the vca_pipe under load .. Fix a deadlock of worker threads on the vca_pipe under load Under high load, the epoll thread doesn't remove sessions from the vca_pipe fast enough, and can block many worker threads which Varnish doesn't recover from. Fixed by reading from the pipe earlier, and by setting the worker thread pipe end non-blocking. --- A debian/patches/0010-varnishd-optimize-epoll-thread.patch M debian/patches/series 2 files changed, 156 insertions(+), 0 deletions(-) Approvals: Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34883 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I576fed91632318f60e1c17f4f7410aea30623577 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: testing/3.0.3plus-rc1 Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] varnish (3.0.3plus~rc1-wm6) precise; urgency=low - change (operations...varnish[testing/3.0.3plus-rc1])
Mark Bergsma has submitted this change and it was merged. Change subject: varnish (3.0.3plus~rc1-wm6) precise; urgency=low .. varnish (3.0.3plus~rc1-wm6) precise; urgency=low * Fix a deadlock of worker threads on the vca_pipe under load --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Mark Bergsma: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34884 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib99a81b5d8c6619d3bbfbec71da27cbd46242669 Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/varnish Gerrit-Branch: testing/3.0.3plus-rc1 Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added methods to interact with References beased on referenc... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Added methods to interact with References beased on reference hash .. Added methods to interact with References beased on reference hash Change-Id: I28295606c5d6f324c20a00167e49bcfe7bc3aa9b --- M lib/includes/HashableObjectStorage.php M lib/includes/reference/Reference.php M lib/includes/reference/ReferenceList.php M lib/includes/reference/ReferenceObject.php M lib/includes/reference/References.php M lib/tests/phpunit/HashableObjectStorageTest.php M lib/tests/phpunit/reference/ReferenceListTest.php M lib/tests/phpunit/reference/ReferenceObjectTest.php M lib/tests/phpunit/statement/StatementObjectTest.php 9 files changed, 275 insertions(+), 155 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/85/34885/1 -- To view, visit https://gerrit.wikimedia.org/r/34885 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28295606c5d6f324c20a00167e49bcfe7bc3aa9b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wbgetentities API module now takes 'datatype' in 'props' par... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: wbgetentities API module now takes 'datatype' in 'props' parameter .. wbgetentities API module now takes 'datatype' in 'props' parameter Change-Id: Idc9ec43d270a03429c87f75f2bc918be8cfd3dc2 --- M repo/includes/api/ApiGetEntities.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34882 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc9ec43d270a03429c87f75f2bc918be8cfd3dc2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mw.Api's getEntities now uses get request - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: mw.Api's getEntities now uses get request .. mw.Api's getEntities now uses get request Using it before already returned an API warning because the edit token was set when it was not expected. Change-Id: I5cb3e69ee9dc293f27a858de961b52bc35b47623 --- M lib/resources/wikibase.store/wikibase.Api.js 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34872 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cb3e69ee9dc293f27a858de961b52bc35b47623 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mw.Api's getEntities parameters work with arrays now (broken... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: mw.Api's getEntities parameters work with arrays now (broken before) .. mw.Api's getEntities parameters work with arrays now (broken before) When passing arrays to certain parameters of getEntities(), this would have failed because the Array.prototype.join() was called on the arrays but the result was not assigned to anything. Also moved the languages parameter to the front, behind the props parameter since it seems to be more important than the others which are more likely to be omitted. Change-Id: I1e7efc4570668f6ff55a3c1763c2292225097b09 --- M lib/resources/wikibase.store/wikibase.Api.js 1 file changed, 17 insertions(+), 31 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/86/34886/1 -- To view, visit https://gerrit.wikimedia.org/r/34886 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e7efc4570668f6ff55a3c1763c2292225097b09 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated release notes - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Updated release notes .. Updated release notes Change-Id: I1fdeb43693397c5e043e22c0b3e6f13836210251 --- M lib/RELEASE-NOTES M repo/RELEASE-NOTES 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/87/34887/1 -- To view, visit https://gerrit.wikimedia.org/r/34887 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1fdeb43693397c5e043e22c0b3e6f13836210251 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make use of new reference functions in setreference API and ... - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Make use of new reference functions in setreference API and fixed removeReference and hasReference .. Make use of new reference functions in setreference API and fixed removeReference and hasReference Change-Id: Id7838a8e5c92f02f8e2f77c31d360fc2e0c4131b --- M lib/includes/reference/ReferenceList.php M lib/tests/phpunit/reference/ReferenceListTest.php M repo/includes/api/ApiSetReference.php 3 files changed, 38 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/88/34888/1 -- To view, visit https://gerrit.wikimedia.org/r/34888 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7838a8e5c92f02f8e2f77c31d360fc2e0c4131b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CI workflow using GraphViz - change (integration/doc[master])
Hashar has uploaded a new change for review. Change subject: CI workflow using GraphViz .. CI workflow using GraphViz Also included some rakefile helpers. Change-Id: I92df98f39804cf0d72d7d4ddfaaa59781f21c9f9 --- A rakefile.rb A workflow/rakefile A workflow/workflow.dot A workflow/workflow.svg 4 files changed, 260 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/doc refs/changes/90/34890/1 -- To view, visit https://gerrit.wikimedia.org/r/34890 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92df98f39804cf0d72d7d4ddfaaa59781f21c9f9 Gerrit-PatchSet: 1 Gerrit-Project: integration/doc Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] .gitreview file - change (integration/doc[master])
Hashar has uploaded a new change for review. Change subject: .gitreview file .. .gitreview file Change-Id: Ic0b7226bb247f193684e582ea94cd0dd6dc97af4 --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/doc refs/changes/89/34889/1 -- To view, visit https://gerrit.wikimedia.org/r/34889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0b7226bb247f193684e582ea94cd0dd6dc97af4 Gerrit-PatchSet: 1 Gerrit-Project: integration/doc Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] .gitreview file - change (integration/doc[master])
Hashar has submitted this change and it was merged. Change subject: .gitreview file .. .gitreview file Change-Id: Ic0b7226bb247f193684e582ea94cd0dd6dc97af4 --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0b7226bb247f193684e582ea94cd0dd6dc97af4 Gerrit-PatchSet: 1 Gerrit-Project: integration/doc Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Return correct rev ID from setclaimvalue - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Return correct rev ID from setclaimvalue .. Return correct rev ID from setclaimvalue Change-Id: I3bbe8e3071afc7a43b90abc523148c7044746ea3 --- M repo/includes/api/ApiSetClaimValue.php 1 file changed, 37 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/91/34891/1 -- To view, visit https://gerrit.wikimedia.org/r/34891 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bbe8e3071afc7a43b90abc523148c7044746ea3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update grunt-contrib-wikimedia - change (integration/jenkins[master])
Hashar has uploaded a new change for review. Change subject: update grunt-contrib-wikimedia .. update grunt-contrib-wikimedia Bringing in https://gerrit.wikimedia.org/r/#/c/34488/ Grunt: Add phplint task. Change-Id: Ie4763ee3448e6053446429462796d81d0de6378c --- M tools/grunt-contrib-wikimedia 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins refs/changes/92/34892/1 -- To view, visit https://gerrit.wikimedia.org/r/34892 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie4763ee3448e6053446429462796d81d0de6378c Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update grunt-contrib-wikimedia - change (integration/jenkins[master])
Hashar has submitted this change and it was merged. Change subject: update grunt-contrib-wikimedia .. update grunt-contrib-wikimedia Bringing in https://gerrit.wikimedia.org/r/#/c/34488/ Grunt: Add phplint task. Change-Id: Ie4763ee3448e6053446429462796d81d0de6378c --- M tools/grunt-contrib-wikimedia 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34892 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4763ee3448e6053446429462796d81d0de6378c Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added a jQuerz.valueview.hasViewFor() function - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: Added a jQuerz.valueview.hasViewFor() function .. Added a jQuerz.valueview.hasViewFor() function * Also moved jQuery.fn.valueview.chooseView to jQuery.valueview.chooseView since it can better be used from there. * Added test. Change-Id: I7a364cda348d1e0ab5384aed368f778ec9e77052 --- M DataTypes/resources/jquery.valueview.js M DataTypes/tests/qunit/jquery.valueview.tests.js 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/93/34893/1 -- To view, visit https://gerrit.wikimedia.org/r/34893 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a364cda348d1e0ab5384aed368f778ec9e77052 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup: update to new version of page-object API - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Cleanup: update to new version of page-object API .. Cleanup: update to new version of page-object API using #on instead of #on_page Change-Id: Ibf91ac36ce7487a50b1c74c31faa89a0b3c54029 --- M features/step_definitions/aftv5_steps.rb M features/step_definitions/mobilesearch_steps.rb M spec/login_spec.rb M spec/upload_wizard_spec.rb 4 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/94/34894/1 -- To view, visit https://gerrit.wikimedia.org/r/34894 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf91ac36ce7487a50b1c74c31faa89a0b3c54029 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated Ruby gems - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Updated Ruby gems .. Updated Ruby gems Change-Id: I7d8240242543a072f5e05357fbd59a6c9ebf54e8 --- M Gemfile.lock 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/95/34895/1 -- To view, visit https://gerrit.wikimedia.org/r/34895 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d8240242543a072f5e05357fbd59a6c9ebf54e8 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: there is no need for instance variable @page - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Refactoring: there is no need for instance variable @page .. Refactoring: there is no need for instance variable @page Local variable page does the job just fine. Change-Id: I3fb08c0ebd2c61397553c5f51748b599aaaf94af --- M features/step_definitions/aftv5_steps.rb 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/96/34896/1 -- To view, visit https://gerrit.wikimedia.org/r/34896 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3fb08c0ebd2c61397553c5f51748b599aaaf94af Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use new page-object gem API - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Use new page-object gem API .. Use new page-object gem API Using #visit instead of #visit_page Change-Id: I91d48427d4d4d95739083a029115bd40636f7cc9 --- M features/step_definitions/uploadwizard_steps.rb M spec/bogus_page_spec.rb M spec/login_spec.rb M spec/upload_wizard_spec.rb 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/97/34897/1 -- To view, visit https://gerrit.wikimedia.org/r/34897 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91d48427d4d4d95739083a029115bd40636f7cc9 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactoring: using block instead of instance variable - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Refactoring: using block instead of instance variable .. Refactoring: using block instead of instance variable Change-Id: I142b36c817a4a6122337ca62531f6127ac5f414b --- M features/step_definitions/uploadwizard_steps.rb 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/98/34898/1 -- To view, visit https://gerrit.wikimedia.org/r/34898 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I142b36c817a4a6122337ca62531f6127ac5f414b Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ignore jobs generated by JJB and stop tracking them - change (integration/jenkins[master])
Hashar has uploaded a new change for review. Change subject: ignore jobs generated by JJB and stop tracking them .. ignore jobs generated by JJB and stop tracking them The jobs are in integration/jenkins-job-builder.git already Change-Id: Id8262da71cb697ed84ae40c1d43ad54091b5755b --- M jobs/.gitignore D jobs/mediawiki-core-install-sqlite/config.xml D jobs/mediawiki-core-lint/config.xml D jobs/mediawiki-core-master-phpunit-all/config.xml D jobs/mediawiki-core-merge/config.xml D jobs/mediawiki-core-phpunit-api/config.xml D jobs/mediawiki-core-phpunit-databaseless/config.xml D jobs/mediawiki-core-phpunit-misc/config.xml D jobs/mediawiki-core-phpunit-parser/config.xml 9 files changed, 3 insertions(+), 1,200 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins refs/changes/99/34899/1 -- To view, visit https://gerrit.wikimedia.org/r/34899 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8262da71cb697ed84ae40c1d43ad54091b5755b Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] ignore jobs generated by JJB and stop tracking them - change (integration/jenkins[master])
Hashar has submitted this change and it was merged. Change subject: ignore jobs generated by JJB and stop tracking them .. ignore jobs generated by JJB and stop tracking them The jobs are in integration/jenkins-job-builder.git already Change-Id: Id8262da71cb697ed84ae40c1d43ad54091b5755b --- M jobs/.gitignore D jobs/mediawiki-core-install-sqlite/config.xml D jobs/mediawiki-core-lint/config.xml D jobs/mediawiki-core-master-phpunit-all/config.xml D jobs/mediawiki-core-merge/config.xml D jobs/mediawiki-core-phpunit-api/config.xml D jobs/mediawiki-core-phpunit-databaseless/config.xml D jobs/mediawiki-core-phpunit-misc/config.xml D jobs/mediawiki-core-phpunit-parser/config.xml 9 files changed, 3 insertions(+), 1,200 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34899 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8262da71cb697ed84ae40c1d43ad54091b5755b Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins Gerrit-Branch: master Gerrit-Owner: Hashar has...@free.fr Gerrit-Reviewer: Hashar has...@free.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42064) Fix onEditFilterMerged so it only accepts EditPa... - change (mediawiki...AbuseFilter[master])
John Erling Blad has uploaded a new change for review. Change subject: (bug 42064) Fix onEditFilterMerged so it only accepts EditPage .. (bug 42064) Fix onEditFilterMerged so it only accepts EditPage For some types of hooks, notably during calls in EditEntity, the normal code in onEditFilterMerged will fail. Instead the extensions must implement its own equivalent of the same handler to be run in those cases. The problem point is the argument $editor, which will not be an EditPage but something else. Change-Id: Ibd8dcc87c8ab849f7ae3d3557a7d1df8e53f4d0e --- M AbuseFilter.hooks.php M AbuseFilter.php 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter refs/changes/00/34900/1 -- To view, visit https://gerrit.wikimedia.org/r/34900 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd8dcc87c8ab849f7ae3d3557a7d1df8e53f4d0e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Cleanup) removed some empty constructors in tests when usin... - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: (Cleanup) removed some empty constructors in tests when using inherit function .. (Cleanup) removed some empty constructors in tests when using inherit function Also corrected some invalid array definition in unknown value test. Change-Id: Idf00fb8660e56a3ec73821bca5722142bb690433 --- M DataValues/tests/qunit/values/BoolValue.tests.js M DataValues/tests/qunit/values/MonolingualTextValue.tests.js M DataValues/tests/qunit/values/MultilingualTextValue.tests.js M DataValues/tests/qunit/values/StringValue.tests.js M DataValues/tests/qunit/values/UnknownValue.tests.js 5 files changed, 11 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/01/34901/1 -- To view, visit https://gerrit.wikimedia.org/r/34901 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf00fb8660e56a3ec73821bca5722142bb690433 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implemented number data value in JS - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: Implemented number data value in JS .. Implemented number data value in JS comes with some standard tests. Change-Id: I44c6df90f210c73fe7a725f9ffa0ccb02f0eaf68 --- M DataValues/DataValues.mw.php M DataValues/Resources.php A DataValues/resources/values/NumberValue.js M DataValues/resources/values/UnknownValue.js A DataValues/tests/qunit/values/NumberValue.tests.js 5 files changed, 137 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/02/34902/1 -- To view, visit https://gerrit.wikimedia.org/r/34902 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44c6df90f210c73fe7a725f9ffa0ccb02f0eaf68 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added base for number parser in JS, not enabled yet. - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: Added base for number parser in JS, not enabled yet. .. Added base for number parser in JS, not enabled yet. There is no number parser in the API yet. Since this is an API based number parser, it makes sense to not load this yet. There are sufficient comments in the resource loader module and test module definitions. Change-Id: Ie3a44e9220ae9a3f881e1a00c782f4949799837a --- M DataValues/resources/values/StringValue.js M ValueParsers/Resources.php M ValueParsers/ValueParsers.mw.php A ValueParsers/resources/parsers/NumberParser.js A ValueParsers/tests/qunit/parsers/NumberParser.tests.js 5 files changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/03/34903/1 -- To view, visit https://gerrit.wikimedia.org/r/34903 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3a44e9220ae9a3f881e1a00c782f4949799837a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] StringParserTest does no longer overwrite NullParserTest - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: StringParserTest does no longer overwrite NullParserTest .. StringParserTest does no longer overwrite NullParserTest The test prototype defined in StringParser.tests.js, StringParserTest, was named NullParserTest so it overwrote the actual NullParserTest defined in NullParser.tests.js. Also removed some comments in the bool parser tests which are not required anymore. Change-Id: I60f936cf02ef0873cb03e7f178ed0d23e3b189f8 --- M ValueParsers/tests/qunit/parsers/BoolParser.tests.js M ValueParsers/tests/qunit/parsers/StringParser.tests.js 2 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/04/34904/1 -- To view, visit https://gerrit.wikimedia.org/r/34904 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I60f936cf02ef0873cb03e7f178ed0d23e3b189f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implement sets into OAI-MH API - change (mediawiki...ProofreadPage[master])
Tpt has uploaded a new change for review. Change subject: Implement sets into OAI-MH API .. Implement sets into OAI-MH API Add the capacity to add sets based on MediaWiki categories to the OAI repository. These sets are configure in a new configuration page, Mediawiki:Proofreadpage_index_oai_sets This page must contain only a JSON array like: { test: { //spec of the set ie its ID name: Test, //The set name category: tests_list, //The category to use, without the Category: prefix description: A test set. //Description of the set, optional } } This patch also split the big file that contained all OAI-PMH code to some small files and make some cosmetics changes. Change-Id: Ide3df82bf873b0d3d1f42af91a66ad97de3d6d2d --- M ProofreadPage.php A includes/index/oai/ProofreadIndexOaiRecord.php A includes/index/oai/ProofreadIndexOaiSets.php R includes/index/oai/SpecialProofreadIndexOai.php R includes/index/oai/SpecialProofreadIndexOaiSchema.php R includes/index/oai/schemas/qdc.xsd 6 files changed, 435 insertions(+), 220 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage refs/changes/05/34905/1 -- To view, visit https://gerrit.wikimedia.org/r/34905 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide3df82bf873b0d3d1f42af91a66ad97de3d6d2d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] snakview will now display a message if a property with unsup... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: snakview will now display a message if a property with unsupported type chosen .. snakview will now display a message if a property with unsupported type chosen Before the commonsMedia type was chosen for all properties, this was hard coded in the snakview. Now we get the property ID by the entity selector widget and make an API call to get the data types of the property. This could be optimized if the search would actually return the data type as well. Depends on I7a364cda in DataValues extension repo. Change-Id: Ic728186703632be4f0a51dae9a0eff15fb2c8ded --- M lib/resources/Resources.php M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M repo/Wikibase.i18n.php 3 files changed, 28 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/06/34906/1 -- To view, visit https://gerrit.wikimedia.org/r/34906 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic728186703632be4f0a51dae9a0eff15fb2c8ded Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove Wikimedia-l from counts where not relevant - change (analytics/wikistats[master])
Nemo bis has uploaded a new change for review. Change subject: Remove Wikimedia-l from counts where not relevant .. Remove Wikimedia-l from counts where not relevant The oldest archives of Wikimedia-l were imported from foundation-l. Foundation-l posts are hence counted two times before 2012-04-04. Also, as the imported archives are broken, it's more like 3 times. Change-Id: I7bed86402f1c2bb96ba7356678638ce349678d7f --- M mail-lists/ScanMail.pl 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats refs/changes/07/34907/1 -- To view, visit https://gerrit.wikimedia.org/r/34907 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7bed86402f1c2bb96ba7356678638ce349678d7f Gerrit-PatchSet: 1 Gerrit-Project: analytics/wikistats Gerrit-Branch: master Gerrit-Owner: Nemo bis federicol...@tiscali.it ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make writeEvent global; fix hook. - change (mediawiki...EventLogging[master])
Ori.livneh has submitted this change and it was merged. Change subject: Make writeEvent global; fix hook. .. Make writeEvent global; fix hook. - Use PageContentSaveComplete rather than deprecated ArticleSaveComplete hook. I'm targetting MW 1.21. - Make wfLogServerSideEvent a freestanding function. I don't expect external callers to wfLogServerSideEvent, but the codebase for this extension is getting sufficiently complex that I have to start insisting on some conceptual hygiene. Change-Id: I9432093dee62c896c5c647137e59f0d2dc53a064 --- M EventLogging.home.php M EventLogging.hooks.php M EventLogging.php 3 files changed, 43 insertions(+), 41 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34687 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9432093dee62c896c5c647137e59f0d2dc53a064 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: Krinkle ttij...@wikimedia.org Gerrit-Reviewer: Mattflaschen matthew.flasc...@gatech.edu Gerrit-Reviewer: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: Spage sp...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Amended system messages - change (mediawiki...SemanticMaps[master])
Kghbln has uploaded a new change for review. Change subject: Amended system messages .. Amended system messages * removed typos from two system messages as per suggestion by tw.n translators Change-Id: Idb4367c3e645a6d13b1b2635eedda22a303300fe --- M SemanticMaps.i18n.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMaps refs/changes/08/34908/1 -- To view, visit https://gerrit.wikimedia.org/r/34908 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb4367c3e645a6d13b1b2635eedda22a303300fe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMaps Gerrit-Branch: master Gerrit-Owner: Kghbln mediaw...@kghoffmeyer.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix tests for fda2e6c1b54a0139a3123de413f672e895ff3352 - change (mediawiki...VisualEditor[master])
Catrope has uploaded a new change for review. Change subject: Fix tests for fda2e6c1b54a0139a3123de413f672e895ff3352 .. Fix tests for fda2e6c1b54a0139a3123de413f672e895ff3352 Change-Id: I2725f3f775e092bafe7aa9dca71d2a9022f16db8 --- M modules/ve/test/dm/ve.dm.example.js 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/09/34909/1 -- To view, visit https://gerrit.wikimedia.org/r/34909 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2725f3f775e092bafe7aa9dca71d2a9022f16db8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure the serializer initialState remains unchanged - change (mediawiki...Parsoid[master])
Subramanya Sastry has submitted this change and it was merged. Change subject: Make sure the serializer initialState remains unchanged .. Make sure the serializer initialState remains unchanged extendProps is just a shallow assignment of passed-in values, so for anything that is not assigned by value (objects for example) it would just assign a reference. These objects are later modified and will thus modify the initial serializer state for later serializer runs. This patch clones both options and initialState to avoid this issue. It also freezes the initialState to make sure any modification is detected early. My hope is that this will fix the random list issue we see in production. There are no changes in parserTests. Change-Id: Ic71e384b89241cf96bbff2186d2ea19945ed9c12 --- M js/lib/mediawiki.WikitextSerializer.js 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34666 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic71e384b89241cf96bbff2186d2ea19945ed9c12 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke gwi...@wikimedia.org Gerrit-Reviewer: GWicke gwi...@wikimedia.org Gerrit-Reviewer: Subramanya Sastry ssas...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implement sets into OAI-MH API - change (mediawiki...ProofreadPage[master])
Tpt has submitted this change and it was merged. Change subject: Implement sets into OAI-MH API .. Implement sets into OAI-MH API Add the capacity to add sets based on MediaWiki categories to the OAI repository. These sets are configure in a new configuration page, Mediawiki:Proofreadpage_index_oai_sets This page must contain only a JSON array like: { test: { //spec of the set ie its ID name: Test, //The set name category: tests_list, //The category to use, without the Category: prefix description: A test set. //Description of the set, optional } } This patch also split the big file that contained all OAI-PMH code to some small files and make some cosmetics changes. Change-Id: Ide3df82bf873b0d3d1f42af91a66ad97de3d6d2d --- M ProofreadPage.php A includes/index/oai/ProofreadIndexOaiRecord.php A includes/index/oai/ProofreadIndexOaiSets.php R includes/index/oai/SpecialProofreadIndexOai.php R includes/index/oai/SpecialProofreadIndexOaiSchema.php R includes/index/oai/schemas/qdc.xsd 6 files changed, 437 insertions(+), 220 deletions(-) Approvals: Tpt: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34905 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide3df82bf873b0d3d1f42af91a66ad97de3d6d2d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr Gerrit-Reviewer: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] make Return to ... work again in CollectionFinishedTemplat... - change (mediawiki...Collection[master])
schmir has submitted this change and it was merged. Change subject: make Return to ... work again in CollectionFinishedTemplate .. make Return to ... work again in CollectionFinishedTemplate the text contained raw html markup instead of a link Thanks Siebrand and Brian Wolff! Change-Id: I0065e2598787a571f5732d161ec4301546fa49cf --- M Collection.templates.php 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: schmir: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33071 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0065e2598787a571f5732d161ec4301546fa49cf Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Collection Gerrit-Branch: master Gerrit-Owner: schmir r...@brainbot.com Gerrit-Reviewer: Brian Wolff bawolff...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: schmir r...@brainbot.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove the autocomplete for fields of type page - change (mediawiki...ProofreadPage[master])
Tpt has uploaded a new change for review. Change subject: Remove the autocomplete for fields of type page .. Remove the autocomplete for fields of type page Change-Id: I1025b6935c0b9cf935c6b6946163dd93b8949df6 --- M modules/ext.proofreadpage.index/ext.proofreadpage.index.js 1 file changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage refs/changes/10/34910/1 -- To view, visit https://gerrit.wikimedia.org/r/34910 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1025b6935c0b9cf935c6b6946163dd93b8949df6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove the autocomplete for fields of type page - change (mediawiki...ProofreadPage[master])
Tpt has submitted this change and it was merged. Change subject: Remove the autocomplete for fields of type page .. Remove the autocomplete for fields of type page Change-Id: I1025b6935c0b9cf935c6b6946163dd93b8949df6 --- M modules/ext.proofreadpage.index/ext.proofreadpage.index.js 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Tpt: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34910 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1025b6935c0b9cf935c6b6946163dd93b8949df6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr Gerrit-Reviewer: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial poke at setreference API [DO NOT SUBMIT] - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Initial poke at setreference API [DO NOT SUBMIT] .. Initial poke at setreference API [DO NOT SUBMIT] Not done, broken atm Change-Id: I7a0af282df4411889ad5cb0155d64f8ec1446946 --- A lib/includes/serializers/ReferenceSerializer.php M repo/includes/api/ApiSetReference.php A repo/tests/phpunit/includes/api/ApiSetReferenceTest.php 3 files changed, 171 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/12/34912/1 -- To view, visit https://gerrit.wikimedia.org/r/34912 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a0af282df4411889ad5cb0155d64f8ec1446946 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Amended system messages - change (mediawiki...SemanticMaps[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Amended system messages .. Amended system messages * removed typos from two system messages as per suggestion by tw.n translators Change-Id: Idb4367c3e645a6d13b1b2635eedda22a303300fe --- M SemanticMaps.i18n.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34908 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb4367c3e645a6d13b1b2635eedda22a303300fe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMaps Gerrit-Branch: master Gerrit-Owner: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix misleading param name in FormatJson::encode signature - change (mediawiki/core[master])
Ori.livneh has uploaded a new change for review. Change subject: Fix misleading param name in FormatJson::encode signature .. Fix misleading param name in FormatJson::encode signature As the FIXME notes, $isHtml has nothing to do with HTML; it simply controls whether the resultant JSON should be formatted for readability by inserting whitespace as appropriate. Change-Id: I90d46d6624d683f18a39c98500bd71bbd0ca3800 --- M includes/json/FormatJson.php 1 file changed, 5 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/53/34953/1 -- To view, visit https://gerrit.wikimedia.org/r/34953 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90d46d6624d683f18a39c98500bd71bbd0ca3800 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Enable PostEdit for ptwiki svwiki - change (operations/mediawiki-config[master])
Ori.livneh has uploaded a new change for review. Change subject: Enable PostEdit for ptwiki svwiki .. Enable PostEdit for ptwiki svwiki Change-Id: I0217ba28461cd4075a7c799f8c4b51556b724ccf --- M wmf-config/InitialiseSettings.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/54/34954/1 -- To view, visit https://gerrit.wikimedia.org/r/34954 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0217ba28461cd4075a7c799f8c4b51556b724ccf Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Ori.livneh o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Enable PostEdit for ptwiki svwiki - change (operations/mediawiki-config[master])
Ori.livneh has submitted this change and it was merged. Change subject: Enable PostEdit for ptwiki svwiki .. Enable PostEdit for ptwiki svwiki Change-Id: I0217ba28461cd4075a7c799f8c4b51556b724ccf --- M wmf-config/InitialiseSettings.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34954 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0217ba28461cd4075a7c799f8c4b51556b724ccf Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: Ori.livneh o...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits