[MediaWiki-commits] [Gerrit] Clear latestSerID once selser gets non-nl-res from an unmark... - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Clear latestSerID once selser gets non-nl-res from an unmarked node. .. Clear latestSerID once selser gets non-nl-res from an unmarked node. * As soon as selser hits an unmarked node and gets a serialized result that does not start with a newline, clear latestSerID since selser is now in the zone of unchanged content and nl-handling is not required. * 2 more selser tests passing. Change-Id: Ib64dba14a61b3bcddc610088e647918be0675d67 --- M js/lib/mediawiki.SelectiveSerializer.js 1 file changed, 13 insertions(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/90/37390/1 -- To view, visit https://gerrit.wikimedia.org/r/37390 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib64dba14a61b3bcddc610088e647918be0675d67 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Extension/PGFTikZ) Initial import - change (mediawiki/extensions[master])
thibaultmarin has uploaded a new change for review. Change subject: (Extension/PGFTikZ) Initial import .. (Extension/PGFTikZ) Initial import This extension parses PGF/TikZ input (a LaTeX package for drawing graphs). It: . creates a temporary latex file (with boiler plate latex code and the parsed code) . compiles it, then convert is to an image (using system calls) . uploads the image to the and save the source used to generate the in the file's wikipage. . compares input to the saved source if the image already exists. Change-Id: I636b15dd44f06f0eb1ead184bdaffc68ec8e9a99 --- A PGFTikZ/PGFTikZ.hooks.php A PGFTikZ/PGFTikZ.i18n.php A PGFTikZ/PGFTikZ.parser.php A PGFTikZ/PGFTikZ.php 4 files changed, 840 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/89/37389/1 -- To view, visit https://gerrit.wikimedia.org/r/37389 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I636b15dd44f06f0eb1ead184bdaffc68ec8e9a99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: thibaultmarin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Selser: minor code cleanup (control-flow + if-checks) + adde... - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Selser: minor code cleanup (control-flow + if-checks) + added FIXME. .. Selser: minor code cleanup (control-flow + if-checks) + added FIXME. * No change in semantics or test run results. Change-Id: I71b06c821ed7b3cc38dcdfa3e7c157eff17bed4e --- M js/lib/mediawiki.SelectiveSerializer.js 1 file changed, 41 insertions(+), 45 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/88/37388/1 -- To view, visit https://gerrit.wikimedia.org/r/37388 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71b06c821ed7b3cc38dcdfa3e7c157eff17bed4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] remove an over-zealous return deferred - change (mediawiki...E3Experiments[master])
Ori.livneh has submitted this change and it was merged. Change subject: remove an over-zealous return deferred .. remove an over-zealous return deferred Returning mw.eventLog.logEvent() from normal execution definitely doesn't log. I still return mw.eventLog.logEvent() from .stall() callbacks, the code works with or without it. setAndLogTask() doesn't return a deferred. Awaiting enlightenment... Change-Id: Ia9d320c419e2618758806e029cb744c231f46f2b --- M experiments/openTask.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37383 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9d320c419e2618758806e029cb744c231f46f2b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Added a sanity check to catch ack() breakage. - change (mediawiki/core[wmf/1.21wmf5])
Aaron Schulz has submitted this change and it was merged. Change subject: [JobQueue] Added a sanity check to catch ack() breakage. .. [JobQueue] Added a sanity check to catch ack() breakage. * Also make sure the "id" field is set even if broken subclasses do not set it as the base class does. Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 (cherry picked from commit 32b62ebd4b9e0c1bb77f252fc53312c2fbaa8de9) --- M includes/job/JobQueueDB.php 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Aaron Schulz: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37386 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Added a sanity check to catch ack() breakage. - change (mediawiki/core[wmf/1.21wmf5])
Aaron Schulz has uploaded a new change for review. Change subject: [JobQueue] Added a sanity check to catch ack() breakage. .. [JobQueue] Added a sanity check to catch ack() breakage. * Also make sure the "id" field is set even if broken subclasses do not set it as the base class does. Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 (cherry picked from commit 32b62ebd4b9e0c1bb77f252fc53312c2fbaa8de9) --- M includes/job/JobQueueDB.php 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/86/37386/1 -- To view, visit https://gerrit.wikimedia.org/r/37386 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Added a sanity check to catch ack() breakage. - change (mediawiki/core[master])
Kaldari has submitted this change and it was merged. Change subject: [JobQueue] Added a sanity check to catch ack() breakage. .. [JobQueue] Added a sanity check to catch ack() breakage. * Also make sure the "id" field is set even if broken subclasses do not set it as the base class does. Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 --- M includes/job/JobQueueDB.php 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37372 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Kaldari Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] reversing the logic for whether my.cnf should contain facebo... - change (operations/puppet[production])
Asher has submitted this change and it was merged. Change subject: reversing the logic for whether my.cnf should contain facebook-patch only options .. reversing the logic for whether my.cnf should contain facebook-patch only options Change-Id: Id3e0d8dbb15fff72fb4e4dc1ae52c8f7c08c397f --- M manifests/mysql.pp M templates/mysql/prod.my.cnf.erb 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Asher: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37385 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e0d8dbb15fff72fb4e4dc1ae52c8f7c08c397f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher Gerrit-Reviewer: Asher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] reversing the logic for whether my.cnf should contain facebo... - change (operations/puppet[production])
Asher has uploaded a new change for review. Change subject: reversing the logic for whether my.cnf should contain facebook-patch only options .. reversing the logic for whether my.cnf should contain facebook-patch only options Change-Id: Id3e0d8dbb15fff72fb4e4dc1ae52c8f7c08c397f --- M manifests/mysql.pp M templates/mysql/prod.my.cnf.erb 2 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/85/37385/1 -- To view, visit https://gerrit.wikimedia.org/r/37385 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3e0d8dbb15fff72fb4e4dc1ae52c8f7c08c397f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] onBeforePageDisplay does in fact deliver the skin if $wgAgor... - change (mediawiki...Agora[master])
Mattflaschen has uploaded a new change for review. Change subject: onBeforePageDisplay does in fact deliver the skin if $wgAgoraEnabledSiteWide is true, as one would hope. .. onBeforePageDisplay does in fact deliver the skin if $wgAgoraEnabledSiteWide is true, as one would hope. Change-Id: Ic353b962fac9a058d5ebfd9a3d0dd325f67e8d9c --- M README 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Agora refs/changes/84/37384/1 -- To view, visit https://gerrit.wikimedia.org/r/37384 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic353b962fac9a058d5ebfd9a3d0dd325f67e8d9c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Agora Gerrit-Branch: master Gerrit-Owner: Mattflaschen ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix async regression introduced in c9a74d674419924d68b3798a2... - change (mediawiki...Parsoid[master])
Subramanya Sastry has submitted this change and it was merged. Change subject: Fix async regression introduced in c9a74d674419924d68b3798a21d36181788763f3 .. Fix async regression introduced in c9a74d674419924d68b3798a21d36181788763f3 This fixes a bunch of crashers caused by c9a74d674419924d68b3798a21d36181788763f3. No changes in parser tests, but all pages with crashes like http://parsoid.wmflabs.org:8001/result/291a3cac60ff296b42fc1f388401ccd2001b883a/Sir%C3%A8nes are now working fine. Change-Id: I9e5552beb1f0fce537a3b93bc1839f46c5148338 --- M js/lib/ext.core.ParserFunctions.js M js/lib/mediawiki.HTML5TreeBuilder.node.js M js/lib/mediawiki.WikitextSerializer.js 3 files changed, 20 insertions(+), 2 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37354 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e5552beb1f0fce537a3b93bc1839f46c5148338 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke Gerrit-Reviewer: Subramanya Sastry Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] var check fix - change (operations/puppet[production])
Asher has submitted this change and it was merged. Change subject: var check fix .. var check fix Change-Id: I1ea76e67cdd6e0d4b00d6c5df6d4081eb9cff71b --- M manifests/mysql.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asher: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37382 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea76e67cdd6e0d4b00d6c5df6d4081eb9cff71b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher Gerrit-Reviewer: Asher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] remove an over-zealous return deferred - change (mediawiki...E3Experiments[master])
Spage has uploaded a new change for review. Change subject: remove an over-zealous return deferred .. remove an over-zealous return deferred Returning mw.eventLog.logEvent() from normal execution definitely doesn't log. I still return mw.eventLog.logEvent() from .stall() callbacks, the code works with or without it. setAndLogTask() doesn't return a deferred. Awaiting enlightenment... Change-Id: Ia9d320c419e2618758806e029cb744c231f46f2b --- M experiments/openTask.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/83/37383/1 -- To view, visit https://gerrit.wikimedia.org/r/37383 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9d320c419e2618758806e029cb744c231f46f2b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] var check fix - change (operations/puppet[production])
Asher has uploaded a new change for review. Change subject: var check fix .. var check fix Change-Id: I1ea76e67cdd6e0d4b00d6c5df6d4081eb9cff71b --- M manifests/mysql.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/82/37382/1 -- To view, visit https://gerrit.wikimedia.org/r/37382 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ea76e67cdd6e0d4b00d6c5df6d4081eb9cff71b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update UploadWizard to master - change (mediawiki/core[wmf/1.21wmf5])
Kaldari has submitted this change and it was merged. Change subject: Update UploadWizard to master .. Update UploadWizard to master Change-Id: I4c07cd8e616f355bfadfd4ab7d7c4d2b6cfb8301 --- M extensions/UploadWizard 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Kaldari: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37381 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c07cd8e616f355bfadfd4ab7d7c4d2b6cfb8301 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Kaldari Gerrit-Reviewer: Kaldari Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update UploadWizard to master - change (mediawiki/core[wmf/1.21wmf5])
Kaldari has uploaded a new change for review. Change subject: Update UploadWizard to master .. Update UploadWizard to master Change-Id: I4c07cd8e616f355bfadfd4ab7d7c4d2b6cfb8301 --- M extensions/UploadWizard 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/81/37381/1 -- To view, visit https://gerrit.wikimedia.org/r/37381 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c07cd8e616f355bfadfd4ab7d7c4d2b6cfb8301 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing geo bug in UploadWizard - change (mediawiki...UploadWizard[master])
Kaldari has submitted this change and it was merged. Change subject: Fixing geo bug in UploadWizard .. Fixing geo bug in UploadWizard Change-Id: I30ad2825dc925d199833b3ce6af828ca3802368c --- M resources/mw.UploadWizardDetails.js 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Kaldari: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37380 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30ad2825dc925d199833b3ce6af828ca3802368c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing geo bug in UploadWizard - change (mediawiki...UploadWizard[master])
Kaldari has uploaded a new change for review. Change subject: Fixing geo bug in UploadWizard .. Fixing geo bug in UploadWizard Change-Id: I30ad2825dc925d199833b3ce6af828ca3802368c --- M resources/mw.UploadWizardDetails.js 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/80/37380/1 -- To view, visit https://gerrit.wikimedia.org/r/37380 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I30ad2825dc925d199833b3ce6af828ca3802368c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update jquery.uls from upstream - change (mediawiki...UniversalLanguageSelector[master])
Santhosh has submitted this change and it was merged. Change subject: Update jquery.uls from upstream .. Update jquery.uls from upstream Contains CSS grid changes Change-Id: I064304d0727c9a050935793c44588c6eb93c00b4 --- M lib/jquery.uls/css/jquery.uls.css M lib/jquery.uls/i18n/lez.json M lib/jquery.uls/i18n/te.json M lib/jquery.uls/i18n/war.json A lib/jquery.uls/i18n/zh-hant.json M lib/jquery.uls/jquery.uls.js M resources/js/ext.uls.languagesettings.js 7 files changed, 118 insertions(+), 97 deletions(-) Approvals: Santhosh: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/35600 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064304d0727c9a050935793c44588c6eb93c00b4 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Santhosh Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] our jenkins puppet test is broken :( - change (operations/puppet[production])
Asher has submitted this change and it was merged. Change subject: our jenkins puppet test is broken :( .. our jenkins puppet test is broken :( Change-Id: I4044c0dfbccf2d46b3bcce945f6e0244923e0eda --- M manifests/mysql.pp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Asher: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37379 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4044c0dfbccf2d46b3bcce945f6e0244923e0eda Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher Gerrit-Reviewer: Asher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] our jenkins puppet test is broken :( - change (operations/puppet[production])
Asher has uploaded a new change for review. Change subject: our jenkins puppet test is broken :( .. our jenkins puppet test is broken :( Change-Id: I4044c0dfbccf2d46b3bcce945f6e0244923e0eda --- M manifests/mysql.pp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/79/37379/1 -- To view, visit https://gerrit.wikimedia.org/r/37379 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4044c0dfbccf2d46b3bcce945f6e0244923e0eda Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Log the various events in the Onboarding funnel. - change (mediawiki...E3Experiments[master])
Ori.livneh has submitted this change and it was merged. Change subject: Log the various events in the Onboarding funnel. .. Log the various events in the Onboarding funnel. 1. The new welcomecreation.js logs events on the page displayed by the login form after successful account creation; this page's message can point to a Getting Started page. It also logs on any page named "E3 Test Onboarding." 2. openTask.js now also logs events and tracks tasks on the Special:GettingStarted page, similar to tasks on the Community portal page. 3. openTask.js continues to log edits to the pages the user clicked on from either task list. This all works but the details of Onboarding/OpenTask log events will change. Patch #2 returnTo logging change Address Matt Flaschen comments. Clicking returnTo link doesn't add that page to accept-edit-complete openTask processing. Patch #3 logging improvements Name schema revisions; Experiments module needn't depend on schema.Onboarding. Log welcomecreation events against Schema:Onboarding with more fields. return logEvent() from .stall() clicks per Ori, although he later said not to. Change-Id: I8a4048f9965f5907fa8636a56dd992a7601216d2 --- M Experiments.hooks.php M Experiments.php A experiments/onboarding/welcomecreation.js M experiments/openTask.js 4 files changed, 175 insertions(+), 10 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37193 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a4048f9965f5907fa8636a56dd992a7601216d2 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage Gerrit-Reviewer: Ori.livneh Gerrit-Reviewer: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Yet another pmpta -> pmtpa - change (operations/puppet[production])
Ori.livneh has uploaded a new change for review. Change subject: Yet another pmpta -> pmtpa .. Yet another pmpta -> pmtpa Change-Id: Ifb6eb85ae21624fc299e71c862340043ee090c99 --- M manifests/site.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/78/37378/1 -- To view, visit https://gerrit.wikimedia.org/r/37378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb6eb85ae21624fc299e71c862340043ee090c99 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mariadb testing - change (operations/puppet[production])
Asher has submitted this change and it was merged. Change subject: mariadb testing .. mariadb testing Change-Id: Iecc07bd59e75c289c9cb63529f14a083acb4b2d4 --- M manifests/mysql.pp M manifests/site.pp M templates/mysql/prod.my.cnf.erb 3 files changed, 22 insertions(+), 7 deletions(-) Approvals: Asher: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37365 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecc07bd59e75c289c9cb63529f14a083acb4b2d4 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher Gerrit-Reviewer: Asher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding .gitreview - change (wikimedia...triagescripts[master])
Dereckson has uploaded a new change for review. Change subject: Adding .gitreview .. Adding .gitreview Change-Id: I6e198f05f3a7bb092573c0944e8d0157c3d844df --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/triagescripts refs/changes/77/37377/1 -- To view, visit https://gerrit.wikimedia.org/r/37377 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e198f05f3a7bb092573c0944e8d0157c3d844df Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/triagescripts Gerrit-Branch: master Gerrit-Owner: Dereckson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding .gitreview - change (wikimedia...modifications[master])
Dereckson has uploaded a new change for review. Change subject: Adding .gitreview .. Adding .gitreview Change-Id: I9d37ebc31ff5b801f619d7c6fe72fe7274a715d4 --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/modifications refs/changes/76/37376/1 -- To view, visit https://gerrit.wikimedia.org/r/37376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d37ebc31ff5b801f619d7c6fe72fe7274a715d4 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/modifications Gerrit-Branch: master Gerrit-Owner: Dereckson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Try using check_http_on_port instead of check_lvs_http_on_po... - change (operations/puppet[production])
Catrope has uploaded a new change for review. Change subject: Try using check_http_on_port instead of check_lvs_http_on_port for Parsoid monitoring .. Try using check_http_on_port instead of check_lvs_http_on_port for Parsoid monitoring It doesn't allow me to specify a path or a vhost, but whatever, I don't really need that anyway. Maybe the simpler command (and the one that I didn't write myself) will work. Change-Id: I85a5ca92ff1129ae6112bf71be53b34c52aac945 --- M manifests/lvs.pp M manifests/misc/parsoid.pp 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/75/37375/1 -- To view, visit https://gerrit.wikimedia.org/r/37375 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85a5ca92ff1129ae6112bf71be53b34c52aac945 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleaning wikibugs header: - change (wikimedia...wikibugs[master])
Dereckson has uploaded a new change for review. Change subject: Cleaning wikibugs header: .. Cleaning wikibugs header: - More portable shebang line - Typo - Code is now in Gerrit, not anymore in SVN. Change-Id: I134a3b397a2fbc6580f8a29a9300ce746930f359 --- M wikibugs 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/wikibugs refs/changes/74/37374/1 -- To view, visit https://gerrit.wikimedia.org/r/37374 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I134a3b397a2fbc6580f8a29a9300ce746930f359 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/wikibugs Gerrit-Branch: master Gerrit-Owner: Dereckson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Another pmpta typo - change (operations/puppet[production])
Ryan Lane has submitted this change and it was merged. Change subject: Another pmpta typo .. Another pmpta typo Change-Id: I2e494e1a07d8ced8d5a988ba9ec353b613ca7cd2 --- M manifests/lvs.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ryan Lane: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37371 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e494e1a07d8ced8d5a988ba9ec353b613ca7cd2 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Catrope Gerrit-Reviewer: Ryan Lane Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding .gitreview file. - change (wikimedia...wikibugs[master])
Dereckson has uploaded a new change for review. Change subject: Adding .gitreview file. .. Adding .gitreview file. Change-Id: I8435ce7c0b30b534e57cb11a81aece98387a17df --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bugzilla/wikibugs refs/changes/73/37373/1 -- To view, visit https://gerrit.wikimedia.org/r/37373 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8435ce7c0b30b534e57cb11a81aece98387a17df Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/wikibugs Gerrit-Branch: master Gerrit-Owner: Dereckson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Added a sanity check to catch ack() breakage. - change (mediawiki/core[master])
Aaron Schulz has uploaded a new change for review. Change subject: [JobQueue] Added a sanity check to catch ack() breakage. .. [JobQueue] Added a sanity check to catch ack() breakage. Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 --- M includes/job/JobQueueDB.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/72/37372/1 -- To view, visit https://gerrit.wikimedia.org/r/37372 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Another pmpta typo - change (operations/puppet[production])
Catrope has uploaded a new change for review. Change subject: Another pmpta typo .. Another pmpta typo Change-Id: I2e494e1a07d8ced8d5a988ba9ec353b613ca7cd2 --- M manifests/lvs.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/71/37371/1 -- To view, visit https://gerrit.wikimedia.org/r/37371 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2e494e1a07d8ced8d5a988ba9ec353b613ca7cd2 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Catrope ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add ExprError to autoloaded classes - change (mediawiki...ParserFunctions[master])
Reedy has uploaded a new change for review. Change subject: Add ExprError to autoloaded classes .. Add ExprError to autoloaded classes Change-Id: I0f585d5396fb31eab362e5eb4c351bb194574cb7 --- M ParserFunctions.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions refs/changes/70/37370/1 -- To view, visit https://gerrit.wikimedia.org/r/37370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f585d5396fb31eab362e5eb4c351bb194574cb7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add qqq messages for missing i18n strings - change (mediawiki...VisualEditor[master])
jenkins-bot has submitted this change and it was merged. Change subject: Add qqq messages for missing i18n strings .. Add qqq messages for missing i18n strings Also minor tweaks to existing wording for consistency. Change-Id: I7ccdf036a5df8029bb2f47856c917055da081f0a --- M VisualEditor.i18n.php 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Robmoen: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ccdf036a5df8029bb2f47856c917055da081f0a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester Gerrit-Reviewer: Robmoen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add qqq messages for missing i18n strings - change (mediawiki...VisualEditor[master])
Jforrester has uploaded a new change for review. Change subject: Add qqq messages for missing i18n strings .. Add qqq messages for missing i18n strings Also minor tweaks to existing wording for consistency. Change-Id: I7ccdf036a5df8029bb2f47856c917055da081f0a --- M VisualEditor.i18n.php 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/69/37369/1 -- To view, visit https://gerrit.wikimedia.org/r/37369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ccdf036a5df8029bb2f47856c917055da081f0a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42801) Fixed by re-adding calls to disableRendering() (... - change (mediawiki...VisualEditor[master])
jenkins-bot has submitted this change and it was merged. Change subject: (bug 42801) Fixed by re-adding calls to disableRendering() (used to be lock()) and enableRendering() (used to be unlock()) - deleted accidentally in commit: 9c74c97808f0bc25a8305d215411a85f2d5cb1bd .. (bug 42801) Fixed by re-adding calls to disableRendering() (used to be lock()) and enableRendering() (used to be unlock()) - deleted accidentally in commit: 9c74c97808f0bc25a8305d215411a85f2d5cb1bd Change-Id: Ia91a572c94cc3e9a81148b1484fc567941fa7c3e --- M modules/ve/ce/ve.ce.Surface.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Robmoen: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37364 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91a572c94cc3e9a81148b1484fc567941fa7c3e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Inez Gerrit-Reviewer: Robmoen Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 35866 - ParserFunctions: Division by zero in Expr.php - change (mediawiki...ParserFunctions[master])
Reedy has uploaded a new change for review. Change subject: Bug 35866 - ParserFunctions: Division by zero in Expr.php .. Bug 35866 - ParserFunctions: Division by zero in Expr.php Int casting isn't much use when we allow floating point numbers.. Change-Id: I32c9eca6552e4fec248eb4fa6419faa39c10df3b --- M testExpr.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions refs/changes/68/37368/1 -- To view, visit https://gerrit.wikimedia.org/r/37368 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32c9eca6552e4fec248eb4fa6419faa39c10df3b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding back new webmoney things. - change (mediawiki...DonationInterface[master])
Katie Horn has submitted this change and it was merged. Change subject: Adding back new webmoney things. .. Adding back new webmoney things. Change-Id: Id8de8c3d923e56bb9e24cc365ffb2e807f129b8b --- M globalcollect_gateway/forms/html/ew/ew-webmoney.html 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Katie Horn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37359 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8de8c3d923e56bb9e24cc365ffb2e807f129b8b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres Gerrit-Reviewer: Katie Horn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 42809 - Move testExpr.php to more usual PHPUnit test, so... - change (mediawiki...ParserFunctions[master])
Reedy has uploaded a new change for review. Change subject: Bug 42809 - Move testExpr.php to more usual PHPUnit test, so it can be run automatically .. Bug 42809 - Move testExpr.php to more usual PHPUnit test, so it can be run automatically Change-Id: I338af01b50684b5849ca198eac536eacdc916ec6 --- M ParserFunctions.php D exprTests.txt D testExpr.php A tests/ExpressionTest.php 4 files changed, 89 insertions(+), 82 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions refs/changes/67/37367/1 -- To view, visit https://gerrit.wikimedia.org/r/37367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I338af01b50684b5849ca198eac536eacdc916ec6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge branch 'master' of ssh://wmf-git/wikimedia/fundraising... - change (wikimedia...tools[master])
Mwalker has uploaded a new change for review. Change subject: Merge branch 'master' of ssh://wmf-git/wikimedia/fundraising/tools .. Merge branch 'master' of ssh://wmf-git/wikimedia/fundraising/tools Conflicts: AmazonAudit/README AmazonAudit/amazon-audit.cfg AmazonAudit/amazon-audit.py AmazonAudit/amazon.py Change-Id: Ic00b2d9a7d0b2879d73070eaeb4623fa615a05d3 --- M AmazonAudit/README M AmazonAudit/amazon-audit.cfg M AmazonAudit/amazon-audit.py M AmazonAudit/amazon.py 4 files changed, 0 insertions(+), 353 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/66/37366/1 -- To view, visit https://gerrit.wikimedia.org/r/37366 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic00b2d9a7d0b2879d73070eaeb4623fa615a05d3 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Mwalker ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mariadb testing - change (operations/puppet[production])
Asher has uploaded a new change for review. Change subject: mariadb testing .. mariadb testing Change-Id: Iecc07bd59e75c289c9cb63529f14a083acb4b2d4 --- M manifests/mysql.pp M manifests/site.pp M templates/mysql/prod.my.cnf.erb 3 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/65/37365/1 -- To view, visit https://gerrit.wikimedia.org/r/37365 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iecc07bd59e75c289c9cb63529f14a083acb4b2d4 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Asher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42801) Fixed by re-adding calls to disableRendering() (... - change (mediawiki...VisualEditor[master])
Inez has uploaded a new change for review. Change subject: (bug 42801) Fixed by re-adding calls to disableRendering() (used to be lock()) and enableRendering() (used to be unlock()) - deleted accidentally in commit: 9c74c97808f0bc25a8305d215411a85f2d5cb1bd .. (bug 42801) Fixed by re-adding calls to disableRendering() (used to be lock()) and enableRendering() (used to be unlock()) - deleted accidentally in commit: 9c74c97808f0bc25a8305d215411a85f2d5cb1bd Change-Id: Ia91a572c94cc3e9a81148b1484fc567941fa7c3e --- M modules/ve/ce/ve.ce.Surface.js 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/64/37364/1 -- To view, visit https://gerrit.wikimedia.org/r/37364 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia91a572c94cc3e9a81148b1484fc567941fa7c3e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Inez ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Amazon Audit Grace Period - change (wikimedia...tools[master])
Mwalker has submitted this change and it was merged. Change subject: Amazon Audit Grace Period .. Amazon Audit Grace Period IN some cases the queue consumer is not idempotent. One of these cases is where a properly collected message is present in the queue and an audit collected message is then added. These will have different timestamps and thus will be treated as different transactions. We remove this possibility by adding a grace period where the audit script will not check for messages before a certain time. Change-Id: If136e2b3dce49f6635eb968b429d07a8981ce229 --- M AmazonAudit/README M AmazonAudit/amazon-audit.py 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Mwalker: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34348 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If136e2b3dce49f6635eb968b429d07a8981ce229 Gerrit-PatchSet: 4 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Mwalker Gerrit-Reviewer: Adamw Gerrit-Reviewer: Mwalker ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Initial Commit of Amazon Audit Script - change (wikimedia...tools[master])
Mwalker has submitted this change and it was merged. Change subject: Initial Commit of Amazon Audit Script .. Initial Commit of Amazon Audit Script Script to connect to AWS and reconcile those reports with what we see in Civi. Change-Id: I5303d74c632d78a099ddb2aece2b56edd1a03aee --- A .gitreview A AmazonAudit/.gitignore A AmazonAudit/README A AmazonAudit/amazon-audit.cfg A AmazonAudit/amazon-audit.py A AmazonAudit/amazon.py 6 files changed, 462 insertions(+), 0 deletions(-) Approvals: Mwalker: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34337 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5303d74c632d78a099ddb2aece2b56edd1a03aee Gerrit-PatchSet: 4 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Mwalker Gerrit-Reviewer: Adamw Gerrit-Reviewer: Mwalker Gerrit-Reviewer: Pgehres ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Another test analytics suite - change (wikimedia...tools[master])
Mwalker has submitted this change and it was merged. Change subject: Another test analytics suite .. Another test analytics suite TODO: * Use anonymized contributions and tracking; move to Labs * Winner in each suite moves to top of display * Do groupings matrix among 4-up test cases. * Landing page test type * Oauth / pw broker / firewalled bot account * Parameterize: Banner filter regexes determining test validity and "label" Desired confidence level * Code clean-up: test plan vs suite spec vs case; cache "rowid"; warn unused columns * mirror results to mysql db * Track eg mutated variations of banner text mid-test * Archival result databases (2011 and previous) Change-Id: If8744050701fda866171225dac29781360c25e09 --- A live_anal/.gitignore A live_anal/README A live_anal/config.py.example A live_anal/db.py A live_anal/fr/__init__.py A live_anal/fr/centralnotice.py A live_anal/fr/contributions.py A live_anal/fr/mediawiki.py A live_anal/fr/tests/__init__.py A live_anal/fr/tests/campaign_log.py A live_anal/fr/tests/results_gdoc.py A live_anal/fr/tests/spec.py A live_anal/fr/tests/spec_gdoc.py A live_anal/fr/time_util.py A live_anal/fr/top_ten.py A live_anal/gdocs.py A live_anal/jail.py A live_anal/lock.py A live_anal/publish_results A live_anal/stats_abba.py A live_anal/update_spec_sheet 21 files changed, 1,421 insertions(+), 0 deletions(-) Approvals: Mwalker: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37350 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8744050701fda866171225dac29781360c25e09 Gerrit-PatchSet: 3 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Adamw Gerrit-Reviewer: Adamw Gerrit-Reviewer: Mwalker ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add some tests that broke when trying to fix 35866 - change (mediawiki...ParserFunctions[master])
Reedy has submitted this change and it was merged. Change subject: Add some tests that broke when trying to fix 35866 .. Add some tests that broke when trying to fix 35866 https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=526794123#Recent_changes_to_MediaWiki Cause was https://gerrit.wikimedia.org/r/#/c/37341/ Change-Id: Iaad077f8f59c003f4e912b695b360ef2070071a7 --- M exprTests.txt 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37363 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaad077f8f59c003f4e912b695b360ef2070071a7 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add some tests that broke when trying to fix 35866 - change (mediawiki...ParserFunctions[master])
Reedy has uploaded a new change for review. Change subject: Add some tests that broke when trying to fix 35866 .. Add some tests that broke when trying to fix 35866 https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=526794123#Recent_changes_to_MediaWiki Cause was https://gerrit.wikimedia.org/r/#/c/37341/ Change-Id: Iaad077f8f59c003f4e912b695b360ef2070071a7 --- M exprTests.txt 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions refs/changes/63/37363/1 -- To view, visit https://gerrit.wikimedia.org/r/37363 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaad077f8f59c003f4e912b695b360ef2070071a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42806) DO NOT MERGE! - change (mediawiki...VisualEditor[master])
Trevor Parscal has uploaded a new change for review. Change subject: (bug 42806) DO NOT MERGE! .. (bug 42806) DO NOT MERGE! This is a PARTIAL fix for bug 42806. It allows content branch's content to be adopted, but it doesn't handle any other cases beyond that. The problem still remains that we aren't fixing up the data properly. Change-Id: I0d2b593e05ebdee807e2cc6eeb902d542db3895f --- M modules/ve/dm/ve.dm.Document.js 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/62/37362/1 -- To view, visit https://gerrit.wikimedia.org/r/37362 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d2b593e05ebdee807e2cc6eeb902d542db3895f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rough pass at banner screenshot job - change (wikimedia...tools[master])
Adamw has uploaded a new change for review. Change subject: rough pass at banner screenshot job .. rough pass at banner screenshot job Change-Id: Ia7dcdaea11fddf5d2746e7e06e58b5bc9b857147 --- A banner_screenshot/config.py.example A banner_screenshot/mediawiki/__init__.py A banner_screenshot/mediawiki/__init__.pyc A banner_screenshot/mediawiki/centralnotice.py A banner_screenshot/mediawiki/centralnotice.pyc A banner_screenshot/mediawiki/time_util.py A banner_screenshot/mediawiki/time_util.pyc A banner_screenshot/rasterize.js A banner_screenshot/shoot_banners 9 files changed, 158 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/61/37361/1 -- To view, visit https://gerrit.wikimedia.org/r/37361 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7dcdaea11fddf5d2746e7e06e58b5bc9b857147 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Modification to all notification page - change (mediawiki...Echo[master])
Bsitu has uploaded a new change for review. Change subject: Modification to all notification page .. Modification to all notification page patch set 1: * Consolidate notification retrieval in API and Special page * Add load more function to special page with records as old as 7 days ago * Add support for browsers with javascript disabled Change-Id: Ic69e430b5eb196e5223a2bb6b1d447ef257d559b --- M Echo.i18n.php M Echo.php M api/ApiEchoNotifications.php M controller/NotificationController.php M modules/overlay/ext.echo.overlay.js A modules/special/ext.echo.special.css A modules/special/ext.echo.special.js M special/SpecialNotifications.php 8 files changed, 291 insertions(+), 47 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo refs/changes/60/37360/1 -- To view, visit https://gerrit.wikimedia.org/r/37360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic69e430b5eb196e5223a2bb6b1d447ef257d559b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Bsitu ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding back new webmoney things. - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Adding back new webmoney things. .. Adding back new webmoney things. Change-Id: Id8de8c3d923e56bb9e24cc365ffb2e807f129b8b --- M globalcollect_gateway/forms/html/ew/ew-webmoney.html 1 file changed, 15 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/59/37359/1 -- To view, visit https://gerrit.wikimedia.org/r/37359 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8de8c3d923e56bb9e24cc365ffb2e807f129b8b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove code duplication - change (mediawiki/core[master])
Reedy has uploaded a new change for review. Change subject: Remove code duplication .. Remove code duplication Remove trailing whitespace Change-Id: I31b381c45ccc1631bd17c4d62a1cc1985a4770ba --- M tests/phpunit/includes/parser/MediaWikiParserTest.php 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/58/37358/1 -- To view, visit https://gerrit.wikimedia.org/r/37358 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31b381c45ccc1631bd17c4d62a1cc1985a4770ba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update ParserFunctions to master - change (mediawiki/core[wmf/1.21wmf5])
Reedy has submitted this change and it was merged. Change subject: Update ParserFunctions to master .. Update ParserFunctions to master Change-Id: Ic979213e394ce0030ea71f9cb0090979c4f1e63b --- M extensions/ParserFunctions 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37357 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic979213e394ce0030ea71f9cb0090979c4f1e63b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update ParserFunctions to master - change (mediawiki/core[wmf/1.21wmf5])
Reedy has uploaded a new change for review. Change subject: Update ParserFunctions to master .. Update ParserFunctions to master Change-Id: Ic979213e394ce0030ea71f9cb0090979c4f1e63b --- M extensions/ParserFunctions 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/57/37357/1 -- To view, visit https://gerrit.wikimedia.org/r/37357 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic979213e394ce0030ea71f9cb0090979c4f1e63b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] new .gitreview - change (wikimedia...tools[master])
Adamw has uploaded a new change for review. Change subject: new .gitreview .. new .gitreview Change-Id: I452997ba66b082dd3340deaf1f2a26ab0ac4263f --- A .gitreview 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/56/37356/1 -- To view, visit https://gerrit.wikimedia.org/r/37356 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I452997ba66b082dd3340deaf1f2a26ab0ac4263f Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "Bug 35866 - ParserFunctions: Division by zero in Exp... - change (mediawiki...ParserFunctions[master])
Reedy has submitted this change and it was merged. Change subject: Revert "Bug 35866 - ParserFunctions: Division by zero in Expr.php" .. Revert "Bug 35866 - ParserFunctions: Division by zero in Expr.php" Seeemingly quite a lot of false positives... This reverts commit a63cb85ae841b2f75cb628b092b4dc78fa20d391 --- M Expr.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37355 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac8ad3f82e5633a2c3f006a5aadd283c1073 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix async regression introduced in c9a74d674419924d68b3798a2... - change (mediawiki...Parsoid[master])
GWicke has uploaded a new change for review. Change subject: Fix async regression introduced in c9a74d674419924d68b3798a21d36181788763f3 .. Fix async regression introduced in c9a74d674419924d68b3798a21d36181788763f3 This fixes a bunch of crashers caused by c9a74d674419924d68b3798a21d36181788763f3. No changes in parser tests, but all pages with crashes like http://parsoid.wmflabs.org:8001/result/291a3cac60ff296b42fc1f388401ccd2001b883a/Sir%C3%A8nes are now working fine. Change-Id: I9e5552beb1f0fce537a3b93bc1839f46c5148338 --- M js/lib/ext.core.ParserFunctions.js M js/lib/mediawiki.HTML5TreeBuilder.node.js M js/lib/mediawiki.WikitextSerializer.js 3 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/54/37354/1 -- To view, visit https://gerrit.wikimedia.org/r/37354 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e5552beb1f0fce537a3b93bc1839f46c5148338 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Re-enabling wgAllowCopyUploads for Commons for experimental ... - change (operations/mediawiki-config[master])
Kaldari has submitted this change and it was merged. Change subject: Re-enabling wgAllowCopyUploads for Commons for experimental Flickr uploading, see bug 20512. .. Re-enabling wgAllowCopyUploads for Commons for experimental Flickr uploading, see bug 20512. Change-Id: Id2a6cb7620142fd9d6b8ba57d5c926239cb39683 --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kaldari: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37353 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a6cb7620142fd9d6b8ba57d5c926239cb39683 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Kaldari Gerrit-Reviewer: Kaldari Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Re-enabling wgAllowCopyUploads for Commons for experimental ... - change (operations/mediawiki-config[master])
Kaldari has uploaded a new change for review. Change subject: Re-enabling wgAllowCopyUploads for Commons for experimental Flickr uploading, see bug 20512. .. Re-enabling wgAllowCopyUploads for Commons for experimental Flickr uploading, see bug 20512. Change-Id: Id2a6cb7620142fd9d6b8ba57d5c926239cb39683 --- M wmf-config/InitialiseSettings.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/53/37353/1 -- To view, visit https://gerrit.wikimedia.org/r/37353 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2a6cb7620142fd9d6b8ba57d5c926239cb39683 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Kaldari ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix the other side of the link encode/decode bug - change (mediawiki...Parsoid[master])
MarkTraceur has uploaded a new change for review. Change subject: Fix the other side of the link encode/decode bug .. Fix the other side of the link encode/decode bug This should put to rest the problem of รbber serializing incorrectly. Change-Id: I5e1de9244d727641c10b6f0a89acc61afba7ecad --- M js/lib/mediawiki.WikitextSerializer.js 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/52/37352/1 -- To view, visit https://gerrit.wikimedia.org/r/37352 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e1de9244d727641c10b6f0a89acc61afba7ecad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] swapping roles on db61 for testing - change (operations/puppet[production])
Pyoungmeister has submitted this change and it was merged. Change subject: swapping roles on db61 for testing .. swapping roles on db61 for testing Change-Id: Ibc2f61542f9786d58d07544d2e2612f6b4e749fa --- M manifests/site.pp 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37351 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc2f61542f9786d58d07544d2e2612f6b4e749fa Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] swapping roles on db61 for testing - change (operations/puppet[production])
Pyoungmeister has uploaded a new change for review. Change subject: swapping roles on db61 for testing .. swapping roles on db61 for testing Change-Id: Ibc2f61542f9786d58d07544d2e2612f6b4e749fa --- M manifests/site.pp 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/51/37351/1 -- To view, visit https://gerrit.wikimedia.org/r/37351 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc2f61542f9786d58d07544d2e2612f6b4e749fa Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add name for mysql user - change (operations/puppet[production])
Pyoungmeister has submitted this change and it was merged. Change subject: add name for mysql user .. add name for mysql user Change-Id: I85fadc04b816d1021982b263231bb01bb6c233a5 --- M modules/coredb_mysql/manifests/base.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37349 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85fadc04b816d1021982b263231bb01bb6c233a5 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Another test analytics suite - change (wikimedia...tools[master])
Adamw has uploaded a new change for review. Change subject: Another test analytics suite .. Another test analytics suite TODO: * Use anonymized contributions and tracking; move to Labs * Winner in each suite moves to top of display * Win proportion and confidence interval in results * Do groupings matrix among 4-up test cases. * Landing page test type * Oauth / pw broker / firewalled bot account * Parameterize: Banner filter regexes determining test validity and "label" Desired confidence level * Code clean-up: test plan vs suite spec vs case; cache "rowid"; warn unused columns; presentation driver decoupled (ie mirror results to mysql db) * Track eg mutated variations of banner text mid-test * Archival result databases (2011 and previous) Change-Id: If8744050701fda866171225dac29781360c25e09 --- A live_anal/.gitignore A live_anal/README A live_anal/config.py.example A live_anal/db.py A live_anal/fr/__init__.py A live_anal/fr/centralnotice.py A live_anal/fr/contributions.py A live_anal/fr/mediawiki.py A live_anal/fr/tests.py A live_anal/fr/time_util.py A live_anal/fr/top_ten.py A live_anal/gdocs.py A live_anal/jail.py A live_anal/lock.py A live_anal/publish_results A live_anal/stats_abba.py A live_anal/update_spec_sheet 17 files changed, 1,345 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/50/37350/1 -- To view, visit https://gerrit.wikimedia.org/r/37350 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8744050701fda866171225dac29781360c25e09 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wikivoyage.[com|de|net] redirects - break out into seprate r... - change (operations/apache-config[master])
Dzahn has submitted this change and it was merged. Change subject: wikivoyage.[com|de|net] redirects - break out into seprate rules again, can just summarize the first part, second part would not work like this .. wikivoyage.[com|de|net] redirects - break out into seprate rules again, can just summarize the first part, second part would not work like this Change-Id: I11bb5aff81c6bd13debd4a4ef24cdbd86fdf288a --- M redirects.conf 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Dzahn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37348 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11bb5aff81c6bd13debd4a4ef24cdbd86fdf288a Gerrit-PatchSet: 2 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn Gerrit-Reviewer: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add name for mysql user - change (operations/puppet[production])
Pyoungmeister has uploaded a new change for review. Change subject: add name for mysql user .. add name for mysql user Change-Id: I85fadc04b816d1021982b263231bb01bb6c233a5 --- M modules/coredb_mysql/manifests/base.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/49/37349/1 -- To view, visit https://gerrit.wikimedia.org/r/37349 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85fadc04b816d1021982b263231bb01bb6c233a5 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wikivoyage.[com|de|net] redirects - break out into seprate r... - change (operations/apache-config[master])
Dzahn has uploaded a new change for review. Change subject: wikivoyage.[com|de|net] redirects - break out into seprate rules again, can just summarize the first part, second part would not work like this .. wikivoyage.[com|de|net] redirects - break out into seprate rules again, can just summarize the first part, second part would not work like this Change-Id: I11bb5aff81c6bd13debd4a4ef24cdbd86fdf288a --- M redirects.conf 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/48/37348/1 -- To view, visit https://gerrit.wikimedia.org/r/37348 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11bb5aff81c6bd13debd4a4ef24cdbd86fdf288a Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] coredb monitoring: remove uncalled for conditional - change (operations/puppet[production])
Pyoungmeister has submitted this change and it was merged. Change subject: coredb monitoring: remove uncalled for conditional .. coredb monitoring: remove uncalled for conditional Change-Id: I085e4b0cadfc89571098f69286abd395d1d9dd88 --- M manifests/mysql.pp 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37347 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I085e4b0cadfc89571098f69286abd395d1d9dd88 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] coredb monitoring: remove uncalled for conditional - change (operations/puppet[production])
Pyoungmeister has uploaded a new change for review. Change subject: coredb monitoring: remove uncalled for conditional .. coredb monitoring: remove uncalled for conditional Change-Id: I085e4b0cadfc89571098f69286abd395d1d9dd88 --- M manifests/mysql.pp 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/47/37347/1 -- To view, visit https://gerrit.wikimedia.org/r/37347 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I085e4b0cadfc89571098f69286abd395d1d9dd88 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing paste from external sources - change (mediawiki...VisualEditor[master])
jenkins-bot has submitted this change and it was merged.
Change subject: Fixing paste from external sources
..
Fixing paste from external sources
Since model.change now starts the surfaceObserver, a problem manifested where
the surfaceObserver was observing the $('#paste') element (used for capturing
and sanitizing pasted content from external sources). Simply switching the
order of the transaction and the documentNode focus fixed the problem.
Change-Id: I1b542b546d7f3d97e2e954ca4b51ca74232b2877
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.wikimedia.org/r/37334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b542b546d7f3d97e2e954ca4b51ca74232b2877
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian
Gerrit-Reviewer: Robmoen
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [FileBackend] Removed obsolete "allowStale" parameter. - change (mediawiki/core[master])
Brion VIBBER has submitted this change and it was merged. Change subject: [FileBackend] Removed obsolete "allowStale" parameter. .. [FileBackend] Removed obsolete "allowStale" parameter. * This was obsoleted by doQuickOperations(). Change-Id: I9e1d9c1e1c910e4ce6de4317299424305b31469c --- M includes/filebackend/FileBackend.php M includes/filebackend/FileOp.php M includes/filebackend/FileOpBatch.php 3 files changed, 2 insertions(+), 22 deletions(-) Approvals: Brion VIBBER: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/35566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e1d9c1e1c910e4ce6de4317299424305b31469c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Demon Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add redirect for wikivoyage.net and save a few code lines by... - change (operations/apache-config[master])
Dzahn has submitted this change and it was merged. Change subject: add redirect for wikivoyage.net and save a few code lines by using a regex for .com, .de and .net .. add redirect for wikivoyage.net and save a few code lines by using a regex for .com, .de and .net Change-Id: I3268a0c442c31280f3c7c0d039756ee3aac9ee29 --- M redirects.conf 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Dzahn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37345 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3268a0c442c31280f3c7c0d039756ee3aac9ee29 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn Gerrit-Reviewer: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42802) Let the client specify multiple filters for list... - change (mediawiki...AbuseFilter[master])
Alex Monk has uploaded a new change for review. Change subject: (bug 42802) Let the client specify multiple filters for list=abuselog .. (bug 42802) Let the client specify multiple filters for list=abuselog Change-Id: I9d06186aea207896bdb354d0e86ee35632fc2090 --- M api/ApiQueryAbuseLog.php 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter refs/changes/46/37346/1 -- To view, visit https://gerrit.wikimedia.org/r/37346 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d06186aea207896bdb354d0e86ee35632fc2090 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Alex Monk ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add redirect for wikivoyage.net and save a few code lines by... - change (operations/apache-config[master])
Dzahn has uploaded a new change for review. Change subject: add redirect for wikivoyage.net and save a few code lines by using a regex for .com, .de and .net .. add redirect for wikivoyage.net and save a few code lines by using a regex for .com, .de and .net Change-Id: I3268a0c442c31280f3c7c0d039756ee3aac9ee29 --- M redirects.conf 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/45/37345/1 -- To view, visit https://gerrit.wikimedia.org/r/37345 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3268a0c442c31280f3c7c0d039756ee3aac9ee29 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Leave some FIXME comments for Bug 36911 - Division by zero - change (mediawiki/core[master])
Reedy has uploaded a new change for review. Change subject: Leave some FIXME comments for Bug 36911 - Division by zero .. Leave some FIXME comments for Bug 36911 - Division by zero Change-Id: I994c482cad1d195cf29d18f7ccf1d8816b1e7330 --- M includes/ImagePage.php 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/44/37344/1 -- To view, visit https://gerrit.wikimedia.org/r/37344 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I994c482cad1d195cf29d18f7ccf1d8816b1e7330 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] coredb_mysql: attempting laner's hackaround for module/role ... - change (operations/puppet[production])
Pyoungmeister has submitted this change and it was merged. Change subject: coredb_mysql: attempting laner's hackaround for module/role class issue .. coredb_mysql: attempting laner's hackaround for module/role class issue explicitly passing params from role class to module Change-Id: I3787c05efec0ecd5ca55ef7a83dc062663b8b716 --- M manifests/role/coredb.pp 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3787c05efec0ecd5ca55ef7a83dc062663b8b716 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] coredb_mysql: attempting laner's hackaround for module/role ... - change (operations/puppet[production])
Pyoungmeister has uploaded a new change for review. Change subject: coredb_mysql: attempting laner's hackaround for module/role class issue .. coredb_mysql: attempting laner's hackaround for module/role class issue explicitly passing params from role class to module Change-Id: I3787c05efec0ecd5ca55ef7a83dc062663b8b716 --- M manifests/role/coredb.pp 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/43/37343/1 -- To view, visit https://gerrit.wikimedia.org/r/37343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3787c05efec0ecd5ca55ef7a83dc062663b8b716 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Pyoungmeister ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update ParserFunctions to master - change (mediawiki/core[wmf/1.21wmf5])
Reedy has submitted this change and it was merged. Change subject: Update ParserFunctions to master .. Update ParserFunctions to master Change-Id: I6743c499bb75153ddfe5b2b4184528af2c51d2ae --- M extensions/ParserFunctions 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37342 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6743c499bb75153ddfe5b2b4184528af2c51d2ae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update ParserFunctions to master - change (mediawiki/core[wmf/1.21wmf5])
Reedy has uploaded a new change for review. Change subject: Update ParserFunctions to master .. Update ParserFunctions to master Change-Id: I6743c499bb75153ddfe5b2b4184528af2c51d2ae --- M extensions/ParserFunctions 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/42/37342/1 -- To view, visit https://gerrit.wikimedia.org/r/37342 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6743c499bb75153ddfe5b2b4184528af2c51d2ae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 35866 - ParserFunctions: Division by zero in Expr.php - change (mediawiki...ParserFunctions[master])
Reedy has submitted this change and it was merged. Change subject: Bug 35866 - ParserFunctions: Division by zero in Expr.php .. Bug 35866 - ParserFunctions: Division by zero in Expr.php Change-Id: Ie9b101b69096e5021a05af1f7260fbc6611319ac --- M Expr.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ori.livneh: Looks good to me, approved Reedy: Verified -- To view, visit https://gerrit.wikimedia.org/r/37341 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9b101b69096e5021a05af1f7260fbc6611319ac Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Ori.livneh Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 35866 - ParserFunctions: Division by zero in Expr.php - change (mediawiki...ParserFunctions[master])
Reedy has uploaded a new change for review. Change subject: Bug 35866 - ParserFunctions: Division by zero in Expr.php .. Bug 35866 - ParserFunctions: Division by zero in Expr.php Change-Id: Ie9b101b69096e5021a05af1f7260fbc6611319ac --- M Expr.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions refs/changes/41/37341/1 -- To view, visit https://gerrit.wikimedia.org/r/37341 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9b101b69096e5021a05af1f7260fbc6611319ac Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ParserFunctions Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Serialize correctly if selser is activated but oldtext is nu... - change (mediawiki...Parsoid[master])
GWicke has submitted this change and it was merged. Change subject: Serialize correctly if selser is activated but oldtext is null. .. Serialize correctly if selser is activated but oldtext is null. * If oldtext is not provided (or src is null for other reasons), selser should fall back on the regular serializer. Ex: echo "foo" | node parse.js --wt2wt --selser Change-Id: I37e19ce4b8931ea991501bb1d258cef06bf7e093 --- M js/lib/mediawiki.SelectiveSerializer.js 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: GWicke: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37339 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37e19ce4b8931ea991501bb1d258cef06bf7e093 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry Gerrit-Reviewer: GWicke Gerrit-Reviewer: Subramanya Sastry Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed doc - change (mediawiki...Wikibase[master])
Jeroen De Dauw has uploaded a new change for review. Change subject: Fixed doc .. Fixed doc Change-Id: I25384e52e72d58354ee4969e1528d6f09ac4aef3 --- M lib/includes/changes/EntityChange.php 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/40/37340/1 -- To view, visit https://gerrit.wikimedia.org/r/37340 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25384e52e72d58354ee4969e1528d6f09ac4aef3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Dont crash if selser is activated but oldtext is null. - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Dont crash if selser is activated but oldtext is null. .. Dont crash if selser is activated but oldtext is null. * If oldtext is not provided (or src is null for other reasons), selser should fall back on the regular serializer. Ex: echo "foo" | node parse.js --wt2wt --selser Change-Id: I37e19ce4b8931ea991501bb1d258cef06bf7e093 --- M js/lib/mediawiki.SelectiveSerializer.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/39/37339/1 -- To view, visit https://gerrit.wikimedia.org/r/37339 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37e19ce4b8931ea991501bb1d258cef06bf7e093 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix typo - change (mediawiki...Wikibase[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: fix typo .. fix typo Change-Id: I1f80beabf8749c471af80a6abdb353c312d3b7b9 --- M client/includes/store/sql/WikiPageEntityLookup.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37337 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f80beabf8749c471af80a6abdb353c312d3b7b9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Added __METHOD__ to delete() call. - change (mediawiki/core[master])
Aaron Schulz has uploaded a new change for review. Change subject: [JobQueue] Added __METHOD__ to delete() call. .. [JobQueue] Added __METHOD__ to delete() call. Change-Id: If2644e2d0ef12b6ad68b7229f1e60a3d50fc139d --- M includes/job/JobQueueDB.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/38/37338/1 -- To view, visit https://gerrit.wikimedia.org/r/37338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2644e2d0ef12b6ad68b7229f1e60a3d50fc139d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix typo - change (mediawiki...Wikibase[master])
Aude has uploaded a new change for review. Change subject: fix typo .. fix typo Change-Id: I1f80beabf8749c471af80a6abdb353c312d3b7b9 --- M client/includes/store/sql/WikiPageEntityLookup.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/37/37337/1 -- To view, visit https://gerrit.wikimedia.org/r/37337 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f80beabf8749c471af80a6abdb353c312d3b7b9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Register WikitextContentTest in the test autoloader. - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: Register WikitextContentTest in the test autoloader. .. Register WikitextContentTest in the test autoloader. Change-Id: I3c3b0fab9850196b0aad7c0bee06c4ca0b8e2fc6 --- M tests/TestsAutoLoader.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37314 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c3b0fab9850196b0aad7c0bee06c4ca0b8e2fc6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Platonides Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Hashar Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: ใในใ ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Setup SSL properly for doc.wikimedia.org - change (operations/puppet[production])
Ryan Lane has submitted this change and it was merged. Change subject: Setup SSL properly for doc.wikimedia.org .. Setup SSL properly for doc.wikimedia.org Change-Id: Ib7d9f0b18e569df400f51ea6f21b4df124210911 --- M files/apache/sites/doc.wikimedia.org M manifests/site.pp 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Ryan Lane: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37336 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7d9f0b18e569df400f51ea6f21b4df124210911 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Demon Gerrit-Reviewer: Ryan Lane Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add missing wfProfileOut() - change (mediawiki/core[master])
Hashar has submitted this change and it was merged. Change subject: Add missing wfProfileOut() .. Add missing wfProfileOut() Change-Id: Id9c4958aa6659d66bb3486d17186424fbd9b5758 --- M includes/content/WikitextContent.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37315 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9c4958aa6659d66bb3486d17186424fbd9b5758 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Platonides Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Hashar Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding metadata to geoShapes. - change (mediawiki...SemanticMaps[master])
Jeroen De Dauw has submitted this change and it was merged. Change subject: Adding metadata to geoShapes. .. Adding metadata to geoShapes. Changed buildLocationList() to addMetada() which now handles all geoShapes. Identify Images and display them. Shouldn't the DV support this? Change-Id: I5fbab4c647935ae5ee8d8d75ebceaadc83a30e90 --- M includes/queryprinters/SM_MapPrinter.php M includes/queryprinters/SM_QueryHandler.php 2 files changed, 44 insertions(+), 40 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34078 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fbab4c647935ae5ee8d8d75ebceaadc83a30e90 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/SemanticMaps Gerrit-Branch: master Gerrit-Owner: Nischayn22 Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Nischayn22 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Setup SSL properly for doc.wikimedia.org - change (operations/puppet[production])
Demon has uploaded a new change for review. Change subject: Setup SSL properly for doc.wikimedia.org .. Setup SSL properly for doc.wikimedia.org Change-Id: Ib7d9f0b18e569df400f51ea6f21b4df124210911 --- M files/apache/sites/doc.wikimedia.org M manifests/site.pp 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/36/37336/1 -- To view, visit https://gerrit.wikimedia.org/r/37336 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7d9f0b18e569df400f51ea6f21b4df124210911 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Demon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core[wmf/1.21wmf5])
awjrichards has submitted this change and it was merged. Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: Ibce35af95ed00dd7ca8b7ca0d0c3d660a287d735 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: awjrichards: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37335 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce35af95ed00dd7ca8b7ca0d0c3d660a287d735 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: awjrichards Gerrit-Reviewer: awjrichards Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42136) Use user prefs to set initial state of "Watch th... - change (mediawiki...VisualEditor[master])
jenkins-bot has submitted this change and it was merged. Change subject: (bug 42136) Use user prefs to set initial state of "Watch this". .. (bug 42136) Use user prefs to set initial state of "Watch this". * Don't show at all if user isn't logged in * Use "watch pages I create" and "watch pages I create" prefs * If the user is already watching it, use that Also updated relevant onMakeGlobalVariablesScript hook, it was using old globals still, the hook has context as of MediaWiki 1.19. Change-Id: Ic3daf32505a745b3cccd0663a03bbf7f3885be84 --- M VisualEditor.hooks.php M modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 3 files changed, 20 insertions(+), 8 deletions(-) Approvals: Trevor Parscal: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37189 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3daf32505a745b3cccd0663a03bbf7f3885be84 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Krinkle Gerrit-Reviewer: Catrope Gerrit-Reviewer: Krinkle Gerrit-Reviewer: Trevor Parscal Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Not monitoring varnishncsa instances for blog.wikimedia.org. - change (operations/puppet[production])
Ottomata has submitted this change and it was merged. Change subject: Not monitoring varnishncsa instances for blog.wikimedia.org. .. Not monitoring varnishncsa instances for blog.wikimedia.org. monmartel does not have nrpe installed. Change-Id: I2fe6d27410545541c3d88bce01675fa733ddd11f --- M manifests/misc/blogs.pp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37295 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fe6d27410545541c3d88bce01675fa733ddd11f Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata Gerrit-Reviewer: Asher Gerrit-Reviewer: Ottomata Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update MobileFrontend to master - change (mediawiki/core[wmf/1.21wmf5])
awjrichards has uploaded a new change for review. Change subject: Update MobileFrontend to master .. Update MobileFrontend to master Change-Id: Ibce35af95ed00dd7ca8b7ca0d0c3d660a287d735 --- M extensions/MobileFrontend 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/35/37335/1 -- To view, visit https://gerrit.wikimedia.org/r/37335 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibce35af95ed00dd7ca8b7ca0d0c3d660a287d735 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: awjrichards ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing paste from external sources - change (mediawiki...VisualEditor[master])
Christian has uploaded a new change for review.
Change subject: Fixing paste from external sources
..
Fixing paste from external sources
Since model.change now starts the surfaceObserver, a problem manifested where
the surfaceObserver was observing the $('#paste') element (used for capturing
and sanitizing pasted content from external sources). Simply switching the
order of the transaction and the documentNode focus fixed the problem.
Change-Id: I1b542b546d7f3d97e2e954ca4b51ca74232b2877
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/34/37334/1
--
To view, visit https://gerrit.wikimedia.org/r/37334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b542b546d7f3d97e2e954ca4b51ca74232b2877
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Reduced the change of deadlocks in recycleStaleJo... - change (mediawiki/core[wmf/1.21wmf5])
Aaron Schulz has submitted this change and it was merged. Change subject: [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). .. [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). * Do the DELETE by primary key to avoid gap locks. This should cut down on deadlocks, though their frequency is still fairly modest. * Also use GET_LOCK() to assure that two processes are not doing this update at the same time. Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e (cherry picked from commit 47e9cc7fe89fe4f33047e328b1036853cd28e3bd) --- M includes/job/JobQueueDB.php 1 file changed, 37 insertions(+), 13 deletions(-) Approvals: Aaron Schulz: Verified; Looks good to me, approved jenkins-bot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37333 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Reduced the change of deadlocks in recycleStaleJo... - change (mediawiki/core[wmf/1.21wmf5])
Aaron Schulz has uploaded a new change for review. Change subject: [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). .. [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). * Do the DELETE by primary key to avoid gap locks. This should cut down on deadlocks, though their frequency is still fairly modest. * Also use GET_LOCK() to assure that two processes are not doing this update at the same time. Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e (cherry picked from commit 47e9cc7fe89fe4f33047e328b1036853cd28e3bd) --- M includes/job/JobQueueDB.php 1 file changed, 37 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/33/37333/1 -- To view, visit https://gerrit.wikimedia.org/r/37333 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf5 Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [JobQueue] Reduced the change of deadlocks in recycleStaleJo... - change (mediawiki/core[master])
Demon has submitted this change and it was merged. Change subject: [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). .. [JobQueue] Reduced the change of deadlocks in recycleStaleJobs(). * Do the DELETE by primary key to avoid gap locks. This should cut down on deadlocks, though their frequency is still fairly modest. * Also use GET_LOCK() to assure that two processes are not doing this update at the same time. Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e --- M includes/job/JobQueueDB.php 1 file changed, 37 insertions(+), 13 deletions(-) Approvals: Demon: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37291 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Demon Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
