[MediaWiki-commits] [Gerrit] Add a comment about the constructor - change (mediawiki...Translate[master])
Amire80 has uploaded a new change for review. Change subject: Add a comment about the constructor .. Add a comment about the constructor Change-Id: I621b8c2defa6d05fdf3f97b15147ec85c94aa4a7 --- M utils/MessageTable.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/58/39358/1 -- To view, visit https://gerrit.wikimedia.org/r/39358 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I621b8c2defa6d05fdf3f97b15147ec85c94aa4a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] run tests for some whitelisted users - change (integration/zuul-config[master])
Hashar has submitted this change and it was merged. Change subject: run tests for some whitelisted users .. run tests for some whitelisted users The new 'test' pipepline is meant to run unit tests on patch submission when the user is trusted. More users can be added later on and the 'test' pipeline could be setup on the other repositories as well. This is only applied on mediawiki/core for now. Change-Id: I5cd733beaa3213461f853e6357cbc4043b6b6870 --- M layout.yaml 1 file changed, 50 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39310 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cd733beaa3213461f853e6357cbc4043b6b6870 Gerrit-PatchSet: 5 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar Gerrit-Reviewer: Krinkle ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 42064) Add a hook to AbuseFilter - change (mediawiki...AbuseFilter[master])
Hoo man has submitted this change and it was merged. Change subject: (Bug 42064) Add a hook to AbuseFilter .. (Bug 42064) Add a hook to AbuseFilter The hook 'AbuseFilter-interceptVariable' can be used for intercepting any request to recalculate a variable, and if a handler is returning false the later code will be skipped. That makes it possible to avoid using content if the content model is wrong, as it could be for a Wikibase entity. The hook uses the same arguments as the hook 'AbuseFilter-computeVariable', thereby making it simple to move handlers around. The arguments to the hook are @param string $method @param AbuseFilterVariableHolder $vars @param array $parameters @param AFPData|array|int|mixed|null|string &$result Patchset 2: Fix for arg 1 to the hook, it got $this instead of $this->mMethod Change-Id: I4944ea612369d6f96319e24c96d97cf9739358c7 --- M AbuseFilter.hooks.php M AbuseFilterVariableHolder.php 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Hoo man: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4944ea612369d6f96319e24c96d97cf9739358c7 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: John Erling Blad Gerrit-Reviewer: Alex Monk Gerrit-Reviewer: Hoo man Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) Adding documentation for claim view's remove event - change (mediawiki...Wikibase[master])
Daniel Werner has submitted this change and it was merged. Change subject: (minor) Adding documentation for claim view's remove event .. (minor) Adding documentation for claim view's remove event Change-Id: Ib7fe6378a374a419055160e703508c7cd1785038 --- M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39203 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7fe6378a374a419055160e703508c7cd1785038 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Copy title attr to new #back-to-referrer button - change (mediawiki...GettingStarted[master])
Spage has uploaded a new change for review. Change subject: Copy title attr to new #back-to-referrer button .. Copy title attr to new #back-to-referrer button The old '#mw-return-to button put the article title in the title attribute, and event logging needs it. Also add 'use strict' for jshint. Change-Id: I9c2d42223c75462fcb9552bde5e2061f52e68d63 --- M resources/ext.gettingstarted.accountcreation.js 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted refs/changes/60/39360/1 -- To view, visit https://gerrit.wikimedia.org/r/39360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c2d42223c75462fcb9552bde5e2061f52e68d63 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/GettingStarted Gerrit-Branch: master Gerrit-Owner: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) make sure arrays have equal size before doing multis... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) make sure arrays have equal size before doing multisort .. (minor) make sure arrays have equal size before doing multisort - a PHP warning was given when sortArray and entries had different size; this happend when a search result entry had no score (e.g. when searching for whitespace) Change-Id: Ib59c16bd0ed7019714310ae173feca6fde8dc83a --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 8 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/61/39361/1 -- To view, visit https://gerrit.wikimedia.org/r/39361 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib59c16bd0ed7019714310ae173feca6fde8dc83a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding GettingStarted - change (mediawiki/extensions[master])
Hashar has uploaded a new change for review. Change subject: Adding GettingStarted .. Adding GettingStarted Change-Id: I2a9afff3c1d7aa46d446ba08819d0e5e7ee6c7dc --- M .gitmodules 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/62/39362/1 -- To view, visit https://gerrit.wikimedia.org/r/39362 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a9afff3c1d7aa46d446ba08819d0e5e7ee6c7dc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding GettingStarted - change (mediawiki/extensions[master])
Hashar has submitted this change and it was merged. Change subject: Adding GettingStarted .. Adding GettingStarted Change-Id: I2a9afff3c1d7aa46d446ba08819d0e5e7ee6c7dc --- M .gitmodules 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39362 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a9afff3c1d7aa46d446ba08819d0e5e7ee6c7dc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add support for audio derivatives - change (mediawiki...TimedMediaHandler[master])
J has uploaded a new change for review. Change subject: Add support for audio derivatives .. Add support for audio derivatives Add support to transcode audio files to other formats. For now only support transcoding to Ogg Vorbis to support playback of FLAC, Speex and Opus files in browsers that support Vorbis. Change-Id: I6237b3676d79cadfff8a286f52e3e3289d9c817b --- M ApiTranscodeReset.php M MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php M MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaPlayers.js M MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js M TimedMediaHandler.hooks.php M TimedMediaHandler.i18n.php M TimedMediaHandler.php M TimedMediaHandler_body.php M WebVideoTranscode/WebVideoTranscode.php M WebVideoTranscode/WebVideoTranscodeJob.php 12 files changed, 128 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/63/39363/1 -- To view, visit https://gerrit.wikimedia.org/r/39363 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6237b3676d79cadfff8a286f52e3e3289d9c817b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 43074) Setting proper focus after adding/editing claims - change (mediawiki...Wikibase[master])
Daniel Werner has submitted this change and it was merged. Change subject: (bug 43074) Setting proper focus after adding/editing claims .. (bug 43074) Setting proper focus after adding/editing claims - patch set 2: Added message in the QUnit tests that failing focus tests may be because of removing the focus from browser window. Change-Id: Id8464f131e8bab06e3f1ec5c96aa2a9974975562 --- M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js M lib/resources/wikibase.ui.Toolbar.Button.js M lib/resources/wikibase.ui.Toolbar.Label.js M lib/resources/wikibase.ui.Toolbar.js M lib/tests/qunit/wikibase.ui.Toolbar.Button.tests.js M lib/tests/qunit/wikibase.ui.Toolbar.Label.tests.js 7 files changed, 219 insertions(+), 51 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39202 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8464f131e8bab06e3f1ec5c96aa2a9974975562 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Actually add GettingStarted - change (mediawiki/extensions[master])
Hashar has uploaded a new change for review. Change subject: Actually add GettingStarted .. Actually add GettingStarted Change-Id: I7c0e8008baba1017393ebe571be8bd640a3203b5 --- A GettingStarted 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/64/39364/1 -- To view, visit https://gerrit.wikimedia.org/r/39364 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c0e8008baba1017393ebe571be8bd640a3203b5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Actually add GettingStarted - change (mediawiki/extensions[master])
Hashar has submitted this change and it was merged. Change subject: Actually add GettingStarted .. Actually add GettingStarted Change-Id: I7c0e8008baba1017393ebe571be8bd640a3203b5 --- A GettingStarted 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39364 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0e8008baba1017393ebe571be8bd640a3203b5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Begin to fix lang and dir attributes - change (mediawiki...Translate[master])
Amire80 has uploaded a new change for review. Change subject: Begin to fix lang and dir attributes .. Begin to fix lang and dir attributes Apply source and target lang and dir data attributes to the main message list element to make them available to the rest of the table. Change-Id: I5ca85ba529784c26b47c9bdc1aee767bb371b49b --- M resources/js/ext.translate.editor.js M utils/TuxMessageTable.php 2 files changed, 18 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/65/39365/1 -- To view, visit https://gerrit.wikimedia.org/r/39365 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ca85ba529784c26b47c9bdc1aee767bb371b49b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use logrotate to archive log files - change (operations/puppet[production])
Ori.livneh has uploaded a new change for review. Change subject: Use logrotate to archive log files .. Use logrotate to archive log files Change-Id: I6cb1d8865a9b20c9e6072ad654da870320d89861 --- A files/logrotate/eventlogging M manifests/misc/statistics.pp 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/66/39366/1 -- To view, visit https://gerrit.wikimedia.org/r/39366 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6cb1d8865a9b20c9e6072ad654da870320d89861 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) fix edgecase in aliases UI when edited by multiple u... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has uploaded a new change for review. Change subject: (minor) fix edgecase in aliases UI when edited by multiple users .. (minor) fix edgecase in aliases UI when edited by multiple users - this fixes a very special edgecase in the aliases UI: when 2 users were editing aliases of the same entity and user 1 removed all aliases while they are still displayed for user 2, a JS error occurred when user 2 was trying to add a new alias and then tries t remove it again. the bug happened cause the UI was expecting an array of aliases coming back from the API but got no aliases at all instead. Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 --- M lib/resources/wikibase.ui.PropertyEditTool.EditableAliases.js 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/67/39367/1 -- To view, visit https://gerrit.wikimedia.org/r/39367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42998) Placeholder and loading spinner when adding a sn... - change (mediawiki...Wikibase[master])
Henning Snater has uploaded a new change for review. Change subject: (bug 42998) Placeholder and loading spinner when adding a snak .. (bug 42998) Placeholder and loading spinner when adding a snak When adding a snak/claim, a placeholder message is displayed in the property input element initially. After selecting a property, a loading spinner is displayed as long as the value view is loading. Change-Id: Ib298041417a8e9c8e2520f3685bf71e76a9cd458 --- M lib/resources/Resources.php M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M repo/Wikibase.i18n.php 3 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/68/39368/1 -- To view, visit https://gerrit.wikimedia.org/r/39368 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib298041417a8e9c8e2520f3685bf71e76a9cd458 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use logrotate to archive log files - change (operations/puppet[production])
ArielGlenn has submitted this change and it was merged. Change subject: Use logrotate to archive log files .. Use logrotate to archive log files Change-Id: I6cb1d8865a9b20c9e6072ad654da870320d89861 --- A files/logrotate/eventlogging M manifests/misc/statistics.pp 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: ArielGlenn: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39366 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cb1d8865a9b20c9e6072ad654da870320d89861 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh Gerrit-Reviewer: ArielGlenn Gerrit-Reviewer: Faidon Gerrit-Reviewer: Ottomata Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) fix edgecase in aliases UI when edited by multiple u... - change (mediawiki...Wikibase[master])
Daniel Werner has submitted this change and it was merged. Change subject: (minor) fix edgecase in aliases UI when edited by multiple users .. (minor) fix edgecase in aliases UI when edited by multiple users - this fixes a very special edgecase in the aliases UI: when 2 users were editing aliases of the same entity and user 1 removed all aliases while they are still displayed for user 2, a JS error occurred when user 2 was trying to add a new alias and then tries t remove it again. the bug happened cause the UI was expecting an array of aliases coming back from the API but got no aliases at all instead. Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 --- M lib/resources/wikibase.ui.PropertyEditTool.EditableAliases.js 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved Henning Snater: Checked; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6c0884b06efc294369043115ebb2fd18cf58fd6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a dependency on mediawiki.legacy.wikibits. - change (mediawiki...Drafts[master])
VitaliyFilippov has uploaded a new change for review. Change subject: Add a dependency on mediawiki.legacy.wikibits. .. Add a dependency on mediawiki.legacy.wikibits. This will allow ResourceLoader to always determine the correct loading order (today I've hit a bug on number of my wikis when Drafts were put before mediawiki.legacy.wikibits in the loaded JS, and prevented ALL loaded js from executing via an exception). Change-Id: I5f0d17f637926669c51c2c897b75a7d7dfd5ca1d --- M Drafts.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Drafts refs/changes/69/39369/1 -- To view, visit https://gerrit.wikimedia.org/r/39369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f0d17f637926669c51c2c897b75a7d7dfd5ca1d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Drafts Gerrit-Branch: master Gerrit-Owner: VitaliyFilippov ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Most of new event logging. - change (mediawiki...E3Experiments[master])
Spage has uploaded a new change for review. Change subject: Most of new event logging. .. Most of new event logging. Do all logging of Community portal and GettingStarted in openTask.js, refactor it to log to either schema (OpenTask or GettingStarted). Change-Id: I7d1220132116d6f199b716853c900bf57d4c2eac --- M Experiments.hooks.php M Experiments.php D experiments/onboarding/welcomecreation.js M experiments/openTask.js 4 files changed, 89 insertions(+), 142 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/70/39370/1 -- To view, visit https://gerrit.wikimedia.org/r/39370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d1220132116d6f199b716853c900bf57d4c2eac Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) add method to SiteLinkTable to get site links of it... - change (mediawiki...Wikibase[master])
Daniel Kinzler has submitted this change and it was merged. Change subject: (no bug) add method to SiteLinkTable to get site links of item id .. (no bug) add method to SiteLinkTable to get site links of item id Change-Id: I82c4d5dc290f5bece811cf475243ac5838ae77b2 --- M lib/includes/store/SiteLinkLookup.php M lib/includes/store/SiteLinkTable.php 2 files changed, 53 insertions(+), 1 deletion(-) Approvals: Daniel Kinzler: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/39327 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82c4d5dc290f5bece811cf475243ac5838ae77b2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't leak e3 and murmur3 into global scope. - change (mediawiki...E3Experiments[master])
Spage has submitted this change and it was merged. Change subject: Don't leak e3 and murmur3 into global scope. .. Don't leak e3 and murmur3 into global scope. In ?debug=1 mode I noticed global (window) scope had e3 and murmur3 defined. This file is the culprit. I changed it to declare within an immediate anonymous function. Change-Id: I75423161ab54697f33aad5ba58751f01c237 --- M lib/murmur3.js 1 file changed, 58 insertions(+), 56 deletions(-) Approvals: Spage: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38819 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75423161ab54697f33aad5ba58751f01c237 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage Gerrit-Reviewer: Alex Monk Gerrit-Reviewer: Ori.livneh Gerrit-Reviewer: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Retire unused murmur3 hash function - change (mediawiki...E3Experiments[master])
Spage has uploaded a new change for review. Change subject: Retire unused murmur3 hash function .. Retire unused murmur3 hash function This provided a 32-bit JavaScript implementation of MurmurHash 3, a non-cryptographic hash function. Change-Id: I9e43e4b4e80852c66138e0637d2b02eb61cbcac8 --- D lib/murmur3.js 1 file changed, 0 insertions(+), 81 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/71/39371/1 -- To view, visit https://gerrit.wikimedia.org/r/39371 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e43e4b4e80852c66138e0637d2b02eb61cbcac8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bugfix missing backslash, private->public function, &misc - change (mediawiki...TranslateSvg[master])
Jarry1250 has uploaded a new change for review. Change subject: Bugfix missing backslash, private->public function, &misc .. Bugfix missing backslash, private->public function, &misc Change-Id: I251ea3ba6da125bcaddd2335c1712dcb38030e73 --- M SVGFormatReader.php M TranslateSvgUtils.php 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg refs/changes/72/39372/1 -- To view, visit https://gerrit.wikimedia.org/r/39372 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I251ea3ba6da125bcaddd2335c1712dcb38030e73 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TranslateSvg Gerrit-Branch: master Gerrit-Owner: Jarry1250 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bugfix missing backslash, private->public function, &misc - change (mediawiki...TranslateSvg[master])
Jarry1250 has submitted this change and it was merged. Change subject: Bugfix missing backslash, private->public function, &misc .. Bugfix missing backslash, private->public function, &misc Change-Id: I251ea3ba6da125bcaddd2335c1712dcb38030e73 --- M SVGFormatReader.php M TranslateSvgUtils.php 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Jarry1250: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39372 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I251ea3ba6da125bcaddd2335c1712dcb38030e73 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TranslateSvg Gerrit-Branch: master Gerrit-Owner: Jarry1250 Gerrit-Reviewer: Jarry1250 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] basic script to sync extensions from Gerrit - change (mediawiki/extensions[master])
Hashar has uploaded a new change for review. Change subject: basic script to sync extensions from Gerrit .. basic script to sync extensions from Gerrit We manually maintain the submodules in mediawiki/extensions and we might miss some from time to time. This script will get the list of extensions from Gerrit, compare the registered git submodules and output the commands to add any missing extensions. Change-Id: I2faf8bb097931975da519fc3a8fcbf1be28f5e8d --- A sync-from-gerrit.sh 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/73/39373/1 -- To view, visit https://gerrit.wikimedia.org/r/39373 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2faf8bb097931975da519fc3a8fcbf1be28f5e8d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add several missing extensions - change (mediawiki/extensions[master])
Hashar has uploaded a new change for review. Change subject: Add several missing extensions .. Add several missing extensions List: CharRangeSpan CreditSource EImage GeoMath GuidedTour MagicNoCache MobileSections MyVariables NavigationTiming PageCredit PerPageLicense SecureSessions SlippyMap TimelineTable WikibaseClient WikibaseLib WikidataClient WikidataRepo Wikilog Change-Id: If45311832b3e373aa6ca37221b6f688124137675 --- M .gitmodules A CharRangeSpan A CreditSource A EImage A GeoMath A GuidedTour A MagicNoCache A MobileSections A MyVariables A NavigationTiming A PageCredit A PerPageLicense A SecureSessions A SlippyMap A TimelineTable A WikibaseClient A WikibaseLib A WikidataClient A WikidataRepo A Wikilog 20 files changed, 60 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions refs/changes/74/39374/1 -- To view, visit https://gerrit.wikimedia.org/r/39374 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If45311832b3e373aa6ca37221b6f688124137675 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Retire unused murmur3 hash function - change (mediawiki...E3Experiments[master])
Ori.livneh has submitted this change and it was merged. Change subject: Retire unused murmur3 hash function .. Retire unused murmur3 hash function This provided a 32-bit JavaScript implementation of MurmurHash 3, a non-cryptographic hash function. Change-Id: I9e43e4b4e80852c66138e0637d2b02eb61cbcac8 --- D lib/murmur3.js 1 file changed, 0 insertions(+), 81 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39371 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e43e4b4e80852c66138e0637d2b02eb61cbcac8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update comment - change (analytics/glass[master])
Ori.livneh has uploaded a new change for review. Change subject: Update comment .. Update comment Change-Id: I96f6d0917d3fa39eb643bd61aa8814d4cfb4e40d --- M glass/zmq2log.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/analytics/glass refs/changes/75/39375/1 -- To view, visit https://gerrit.wikimedia.org/r/39375 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I96f6d0917d3fa39eb643bd61aa8814d4cfb4e40d Gerrit-PatchSet: 1 Gerrit-Project: analytics/glass Gerrit-Branch: master Gerrit-Owner: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update comment - change (analytics/glass[master])
Ori.livneh has submitted this change and it was merged. Change subject: Update comment .. Update comment Change-Id: I96f6d0917d3fa39eb643bd61aa8814d4cfb4e40d --- M glass/zmq2log.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39375 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f6d0917d3fa39eb643bd61aa8814d4cfb4e40d Gerrit-PatchSet: 1 Gerrit-Project: analytics/glass Gerrit-Branch: master Gerrit-Owner: Ori.livneh Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42998) Placeholder and loading spinner when adding a sn... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 42998) Placeholder and loading spinner when adding a snak .. (bug 42998) Placeholder and loading spinner when adding a snak When adding a snak/claim, a placeholder message is displayed in the property input element initially. After selecting a property, a loading spinner is displayed as long as the value view is loading. Change-Id: Ib298041417a8e9c8e2520f3685bf71e76a9cd458 --- M lib/resources/Resources.php M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M repo/Wikibase.i18n.php 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39368 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib298041417a8e9c8e2520f3685bf71e76a9cd458 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) data type message keys will be added to resource loa... - change (mediawiki...DataValues[master])
Daniel Werner has uploaded a new change for review. Change subject: (minor) data type message keys will be added to resource loader module .. (minor) data type message keys will be added to resource loader module Before, all message keys for the data types were added by the Wikibase Lib extension. They are part of the data types extension though and therefore all message keys of all data types should be added as messages of the data types resource loader module. Also added myself as author in DataTypes.mw.php Change-Id: I2a57a85eea78f7730eaa349976325bfe757d861c --- M DataTypes/DataTypes.mw.php M DataTypes/Resources.php M DataTypes/includes/modules/DataTypesModule.php 3 files changed, 43 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/76/39376/1 -- To view, visit https://gerrit.wikimedia.org/r/39376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a57a85eea78f7730eaa349976325bfe757d861c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] solrupdate.php tweaks - change (mediawiki...GeoData[master])
MaxSem has uploaded a new change for review. Change subject: solrupdate.php tweaks .. solrupdate.php tweaks * Fix killlist cleaning * Added --noindex ption Change-Id: Iae8b981eec2a750725a84e86c6550f85fe2991b4 --- M solrupdate.php 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GeoData refs/changes/77/39377/1 -- To view, visit https://gerrit.wikimedia.org/r/39377 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae8b981eec2a750725a84e86c6550f85fe2991b4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/GeoData Gerrit-Branch: master Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) display message when choosing property of unsupporte... - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: (minor) display message when choosing property of unsupported type in snakview .. (minor) display message when choosing property of unsupported type in snakview - patch set 2: renamed message 'wikibase-snak-unsupporteddatatype' to 'wikibase-snakview-unsupporteddatatype' and added qqq. Added dependencies to data type name messages into resources - patch set 3: updated qqq message - patch set 4: rebase - patch set 5: updated qqq message Change-Id: I8d99d1ba8027e8f13502acb611a1ea7354d8dc15 --- M lib/resources/Resources.php M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M lib/resources/wikibase.css M repo/Wikibase.i18n.php 4 files changed, 26 insertions(+), 11 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39194 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d99d1ba8027e8f13502acb611a1ea7354d8dc15 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) removed data type label messages, they are included ... - change (mediawiki...Wikibase[master])
Daniel Werner has uploaded a new change for review. Change subject: (minor) removed data type label messages, they are included by data types now .. (minor) removed data type label messages, they are included by data types now Requires I2a57a85e which changes DataTypes extension's resource loader module to add the messages of all data types. Change-Id: I1234f479027fdda490db09765ad80080656b9269 --- M lib/resources/Resources.php 1 file changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/78/39378/1 -- To view, visit https://gerrit.wikimedia.org/r/39378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1234f479027fdda490db09765ad80080656b9269 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) data type message keys will be added to resource loa... - change (mediawiki...DataValues[master])
Henning Snater has submitted this change and it was merged. Change subject: (minor) data type message keys will be added to resource loader module .. (minor) data type message keys will be added to resource loader module Before, all message keys for the data types were added by the Wikibase Lib extension. They are part of the data types extension though and therefore all message keys of all data types should be added as messages of the data types resource loader module. Also added myself as author in DataTypes.mw.php Change-Id: I2a57a85eea78f7730eaa349976325bfe757d861c --- M DataTypes/DataTypes.mw.php M DataTypes/Resources.php M DataTypes/includes/modules/DataTypesModule.php 3 files changed, 43 insertions(+), 10 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/39376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a57a85eea78f7730eaa349976325bfe757d861c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) removed data type label messages, they are included ... - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: (minor) removed data type label messages, they are included by data types now .. (minor) removed data type label messages, they are included by data types now Requires I2a57a85e which changes DataTypes extension's resource loader module to add the messages of all data types. Change-Id: I1234f479027fdda490db09765ad80080656b9269 --- M lib/resources/Resources.php 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1234f479027fdda490db09765ad80080656b9269 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) Adding property input placeholder message to resourc... - change (mediawiki...Wikibase[master])
Henning Snater has uploaded a new change for review. Change subject: (minor) Adding property input placeholder message to resource module .. (minor) Adding property input placeholder message to resource module Change-Id: Ic56371ae12fa1c1b5dd8b594a664359696e6ba0a --- M lib/resources/Resources.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/79/39379/1 -- To view, visit https://gerrit.wikimedia.org/r/39379 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic56371ae12fa1c1b5dd8b594a664359696e6ba0a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) Adding property input placeholder message to resourc... - change (mediawiki...Wikibase[master])
Tobias Gritschacher has submitted this change and it was merged. Change subject: (minor) Adding property input placeholder message to resource module .. (minor) Adding property input placeholder message to resource module Change-Id: Ic56371ae12fa1c1b5dd8b594a664359696e6ba0a --- M lib/resources/Resources.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39379 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic56371ae12fa1c1b5dd8b594a664359696e6ba0a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) make sure arrays have equal size before doing multis... - change (mediawiki...Wikibase[master])
Henning Snater has submitted this change and it was merged. Change subject: (minor) make sure arrays have equal size before doing multisort .. (minor) make sure arrays have equal size before doing multisort - a PHP warning was given when sortArray and entries had different size; this happend when a search result entry had no score (e.g. when searching for whitespace) Change-Id: Ib59c16bd0ed7019714310ae173feca6fde8dc83a --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 8 insertions(+), 10 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39361 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib59c16bd0ed7019714310ae173feca6fde8dc83a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115788] trunk/extensions/Wikidata/OmegaWiki
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115788
Revision: 115788
Author: kipcool
Date: 2012-12-19 13:06:45 + (Wed, 19 Dec 2012)
Log Message:
---
- English langid (85) replaced by a parameter
- some code formatting and comments
Modified Paths:
--
trunk/extensions/Wikidata/OmegaWiki/Controller.php
trunk/extensions/Wikidata/OmegaWiki/HTMLtable.php
trunk/extensions/Wikidata/OmegaWiki/OmegaWikiRecordSets.php
trunk/extensions/Wikidata/OmegaWiki/RecordSet.php
trunk/extensions/Wikidata/OmegaWiki/RecordSetQueries.php
trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php
trunk/extensions/Wikidata/OmegaWiki/WikiDataGlobals.php
trunk/extensions/Wikidata/OmegaWiki/forms.php
trunk/extensions/Wikidata/OmegaWiki/resources/suggest.css
Modified: trunk/extensions/Wikidata/OmegaWiki/Controller.php
===
--- trunk/extensions/Wikidata/OmegaWiki/Controller.php 2012-11-28 17:33:03 UTC
(rev 115787)
+++ trunk/extensions/Wikidata/OmegaWiki/Controller.php 2012-12-19 13:06:45 UTC
(rev 115788)
@@ -216,7 +216,12 @@
public function update( $keyPath, $record ) {
$definedMeaningId = $keyPath->peek( 1 )->definedMeaningId;
$syntransId = $keyPath->peek( 0 )->syntransId;
- updateSynonymOrTranslationWithId( $syntransId,
$record->identicalMeaning );
+ $identicalMeaning = $record->identicalMeaning;
+
+ // check that the needed parameters exist
+ if ( ($syntransId != "") && ($identicalMeaning != "") ) {
+ updateSynonymOrTranslationWithId( $syntransId,
$identicalMeaning );
+ }
}
}
Modified: trunk/extensions/Wikidata/OmegaWiki/HTMLtable.php
===
--- trunk/extensions/Wikidata/OmegaWiki/HTMLtable.php 2012-11-28 17:33:03 UTC
(rev 115787)
+++ trunk/extensions/Wikidata/OmegaWiki/HTMLtable.php 2012-12-19 13:06:45 UTC
(rev 115788)
@@ -61,20 +61,16 @@
if ( !$type instanceof Structure ) {
$skipRows = count( $rows );
$columnIndex = $childNode->column + $columnOffset;
- $sort = 'sortTable(this, ' . $skipRows . ', ' .
$columnIndex . ')';
-
$class = ' class="' . $type . ' ' . $attribute->id .
'"';
}
else {
$class = ' class="' . $attribute->id . '"';
- $sort = '';
- $leftsort = '';
}
$rowSpan = $height - $childNode->height;
$rows[$currentDepth] .= '' . $attribute->name . $leftsort . '';
+ '">' . $attribute->name . '';
addChildNodesToRows( $childNode, $rows, $currentDepth +
$rowSpan, $columnOffset, $idPath, $leftmost );
$idPath->popAttribute();
Modified: trunk/extensions/Wikidata/OmegaWiki/OmegaWikiRecordSets.php
===
--- trunk/extensions/Wikidata/OmegaWiki/OmegaWikiRecordSets.php 2012-11-28
17:33:03 UTC (rev 115787)
+++ trunk/extensions/Wikidata/OmegaWiki/OmegaWikiRecordSets.php 2012-12-19
13:06:45 UTC (rev 115788)
@@ -121,22 +121,24 @@
" AND {$dc}_expression.remove_transaction_id IS NULL " .
" AND {$dc}_defined_meaning.defined_meaning_id = ";
-# Build atomic queries
- $definedMeaningIdsCopy = $definedMeaningIds;
-unset( $value );
-foreach ( $definedMeaningIdsCopy as &$value ) { $value = $frontQuery .
$value; }
-unset( $value );
+ // copy the definedMeaningIds array to create one query for each DM id
+ $definedMeaningQueries = $definedMeaningIds;
+ unset( $value );
+ foreach ( $definedMeaningQueries as &$value ) {
+ $value = $frontQuery . $value;
+ }
+ unset( $value );
# Union of the atoms
-$finalQuery = implode( ' UNION ', $definedMeaningIdsCopy );
+ $finalQuery = implode( ' UNION ', $definedMeaningQueries );
$queryResult = $dbr->query( $finalQuery );
while ( $row = $dbr->fetchObject( $queryResult ) ) {
- if ( isset(
$definedMeaningReferenceRecords[$row->defined_meaning_id] ) )
+ if ( isset(
$definedMeaningReferenceRecords[$row->defined_meaning_id] ) ) {
$definedMeaningReferenceRecord =
$definedMeaningReferenceRecords[$row->defined_meaning_id];
- else
+ } else {
$definedMeaningReferenceRecord = null;
-
+ }
if ( $definedMeaningReferenceRecord == null ) {
$definedMeaningReferenceRecord = new ArrayRecord(
$o->definedMeaningReferenceStruct
[MediaWiki-commits] SVN: [115789] trunk/extensions/Wikidata
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115789 Revision: 115789 Author: kipcool Date: 2012-12-19 13:11:27 + (Wed, 19 Dec 2012) Log Message: --- - Disabled broken importtsv and exporttsv - disabled broken API - resourceLoader with position top for css Modified Paths: -- trunk/extensions/Wikidata/App.php trunk/extensions/Wikidata/OmegaWiki/SpecialImportTSV.php trunk/extensions/Wikidata/Wikidata.hooks.php Modified: trunk/extensions/Wikidata/App.php === --- trunk/extensions/Wikidata/App.php 2012-12-19 13:06:45 UTC (rev 115788) +++ trunk/extensions/Wikidata/App.php 2012-12-19 13:11:27 UTC (rev 115789) @@ -2,6 +2,10 @@ if ( !defined( 'MEDIAWIKI' ) ) die( 'Invalid entry point.' ); +$dir = dirname( __FILE__ ) . '/'; + +require_once( $dir . 'OmegaWiki/Wikidata.php' ); + $wgExtensionCredits['other'][] = array( 'path'=> __FILE__, 'name'=> 'Wikidata', @@ -12,7 +16,7 @@ 'Maarten van Hoof', 'André Malafaya Baptista' ), - 'url' => 'http://meta.wikimedia.org/wiki/Wikidata', + 'url' => 'http://www.mediawiki.org/wiki/Extension:Wikidata', 'descriptionmsg' => 'wikidata-desc', ); @@ -26,11 +30,12 @@ 'author' => 'Alan Smithee', ); -$dir = dirname( __FILE__ ) . '/'; +/* the API "wikidata" does not work. + * Should be repaired, if someone has the courage to go through + * the undocumented code... + */ +//$wgAPIModules['wikidata'] = 'ApiWikiData'; -require_once( $dir . 'OmegaWiki/Wikidata.php' ); - -$wgAPIModules['wikidata'] = 'ApiWikiData'; $wgExtensionMessagesFiles['Wikidata'] = $dir . 'Wikidata.i18n.php'; @@ -41,15 +46,22 @@ 'remoteExtPath' => 'Wikidata' ); -$wgResourceModules['ext.Wikidata'] = $resourcePathArray + array( +// separated css with position "top" to avoid +// so-called Flash of unstyled content +$wgResourceModules['ext.Wikidata.css'] = $resourcePathArray + array( + 'styles' => array( 'OmegaWiki/resources/suggest.css', 'OmegaWiki/resources/tables.css' ), + 'position' => 'top' +); + +$wgResourceModules['ext.Wikidata.ajax'] = $resourcePathArray + array( 'scripts' => 'OmegaWiki/resources/omegawiki-ajax.js', - 'styles' => array( 'OmegaWiki/resources/suggest.css', 'OmegaWiki/resources/tables.css' ), 'dependencies' => array( 'jquery.tablesorter' ) ); $wgResourceModules['ext.Wikidata.edit'] = $resourcePathArray + array( 'scripts' => 'OmegaWiki/resources/omegawiki-edit.js' ); + $wgResourceModules['ext.Wikidata.suggest'] = $resourcePathArray + array( 'scripts' => 'OmegaWiki/resources/suggest.js' ); @@ -60,9 +72,10 @@ $wgAutoloadClasses['WikidataArticle' ] = $dir . 'includes/WikidataArticle.php'; $wgAutoloadClasses['WikidataEditPage' ] = $dir . 'includes/WikidataEditPage.php'; $wgAutoloadClasses['WikidataPageHistory' ] = $dir . 'includes/WikidataPageHistory.php'; -$wgAutoloadClasses['ApiWikiData' ] = $dir . 'includes/api/ApiWikiData.php'; -$wgAutoloadClasses['ApiWikiDataFormatBase'] = $dir . 'includes/api/ApiWikiDataFormatBase.php'; -$wgAutoloadClasses['ApiWikiDataFormatXml' ] = $dir . 'includes/api/ApiWikiDataFormatXml.php'; +// api wikidata is disabled since it does not work +// $wgAutoloadClasses['ApiWikiData' ] = $dir . 'includes/api/ApiWikiData.php'; +// $wgAutoloadClasses['ApiWikiDataFormatBase'] = $dir . 'includes/api/ApiWikiDataFormatBase.php'; +// $wgAutoloadClasses['ApiWikiDataFormatXml' ] = $dir . 'includes/api/ApiWikiDataFormatXml.php'; # FIXME: Rename this to reduce chance of collision. $wgAutoloadClasses['OmegaWiki'] = $dir . 'OmegaWiki/OmegaWiki.php'; @@ -82,8 +95,6 @@ $wgAutoloadClasses['SpecialAddCollection'] = $dir . 'OmegaWiki/SpecialAddCollection.php'; $wgAutoloadClasses['SpecialConceptMapping'] = $dir . 'OmegaWiki/SpecialConceptMapping.php'; $wgAutoloadClasses['SpecialCopy'] = $dir . 'OmegaWiki/SpecialCopy.php'; -$wgAutoloadClasses['SpecialExportTSV'] = $dir . 'OmegaWiki/SpecialExportTSV.php'; -$wgAutoloadClasses['SpecialImportTSV'] = $dir . 'OmegaWiki/SpecialImportTSV.php'; $wgAutoloadClasses['SpecialOWStatistics'] = $dir . 'OmegaWiki/SpecialOWStatistics.php'; # FIXME: These should be modified to make Wikidata more reusable. @@ -93,8 +104,6 @@ $wgAvailableRights[] = 'languagenames'; $wgAvailableRights[] = 'addcollection'; $wgAvailableRights[] = 'editClassAttributes'; -$wgAvailableRights[] = 'exporttsv'; -$wgAvailableRights[] = 'importtsv'; $wgGroupPermissions['*']['editClassAttributes'] = false; @@ -106,14 +115,9 @@ $wgGroupPermissions['bureaucrat']['languagenames'] = true; $wgGroupPermissions['bureaucrat']['addcollection'] = true; $wgGroupPermissions['bureaucrat']['editClassAttributes'] = true; -$wgGroupPermissions['bureaucrat']['exporttsv'] = true; -$wgGroupPermissions['bureaucrat']['importts
[MediaWiki-commits] SVN: [115790] trunk/extensions/Wikidata/OmegaWiki/resources/ omegawiki-ajax.js
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115790
Revision: 115790
Author: kipcool
Date: 2012-12-19 13:12:55 + (Wed, 19 Dec 2012)
Log Message:
---
using tableSorterCollation for a better sorting
Modified Paths:
--
trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
Modified: trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
===
--- trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
2012-12-19 13:11:27 UTC (rev 115789)
+++ trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
2012-12-19 13:12:55 UTC (rev 115790)
@@ -1,32 +1,16 @@
-
-
jQuery(document).ready(function( $ ) {
/*
* Some javascript that is run when the page finished loading
*/
+
+ // First, sort the table on languages
+ sortTablesOnLanguages();
- $("table.wiki-data-table").tablesorter();
-
- if(( wgAction == 'view' ) || ( wgAction == 'history' )) {
- // simulate a click on the first column (sort on languages).
- $("table.wiki-data-table").find("th.headerSort:first").click();
- }
- if( wgAction == 'edit' ) {
- // simulate a click on the second column (sort on languages).
-
$("table.wiki-data-table").find("th.headerSort:first").next("th").click();
- }
-
- // now disable sorting for users
- $(".jquery-tablesorter").find("th").off("click");
- $(".jquery-tablesorter").removeClass("jquery-tablesorter");
-
-
// add and manage arrows to navigate the tabs
if ( $(".wd-tablist").length ) {
initializeTabs();
}
-
// sticky explang
var explangUrl = document.URL.match( /explang=\d+/gi ) ;
if ( explangUrl!=null ) {
@@ -43,25 +27,69 @@
* Some more javascript events
*/
+ // toggle the togglable elements
$(".toggle").click(function() {
$(this).children("span").toggle();
$(this).parent().next().fadeToggle('fast');
});
- $(".toggle").find("a").click(function(event) {
+ $("a").click(function(event) {
// avoid the toggling if a link is clicked
event.stopPropagation();
} );
+ // toggle the annotation popups
$(".togglePopup").click(function() {
$(this).children("span").toggle();
- $(this).next(".popupToggleable").toggle();
+ $(this).next(".popupToggleable").toggle(100);
});
+ $(".mw-line-even").hover(
+ function (event) {
+ showTooltip( $(this), event );
+ },
+ function () {
+ hideTooltip( $(this) );
+ }
+ );
+
$(window).resize(function() {
updateTabs();
});
+
+ /*
+* sortTablesOnLanguages sorts the wiki tables according to the
language column
+* using the jquery tablesorter plugin
+*/
+ function sortTablesOnLanguages() {
+ // optimally, different tableSorterCollation should be used
according to the interface language
+ mw.config.set('tableSorterCollation', {
+ 'é':'e', 'è':'e', // French characters
+ 'ä':'ae', 'ö' : 'oe', 'ß': 'ss', 'ü':'ue' // German
characters
+ });
+ // start the tablesorter jquery plugin
+ $("table.wiki-data-table").tablesorter();
+
+ if(( wgAction == 'view' ) || ( wgAction == 'history' )) {
+ // simulate a click on the second column (sort on
languages).
+
$("table.wiki-data-table").find("th.headerSort:first").next("th").click();
+ }
+ if( wgAction == 'edit' ) {
+ // simulate a click on the third column (sort on
languages).
+
$("table.wiki-data-table").find("th:first").next("th").next("th").click();
+ }
+
+ // now disable sorting for users
+ $(".jquery-tablesorter").find("th").off("click");
+ $(".jquery-tablesorter").removeClass("jquery-tablesorter");
+ }
+
+
+ /*
+* initializeTabs adds tabs on the top of a page to navigate between
languages
+* when an expression exists in several languages
+*/
function initializeTabs() {
var $previousArrow = '' + "❮" +
'' ;
var $nextArrow = '' + "❯" +
'' ;
@@ -212,8 +240,49 @@
}
}
} // updateTabs
+
});
+ function showTooltip(elem, event) {
+// elem.hide();
+ // position where it will be displayeds
+ var posX = event
[MediaWiki-commits] SVN: [115791] trunk/extensions/Wikidata/OmegaWiki/resources/ omegawiki-ajax.js
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115791
Revision: 115791
Author: kipcool
Date: 2012-12-19 13:15:22 + (Wed, 19 Dec 2012)
Log Message:
---
removed some experimental functions that should not have been committed...
Modified Paths:
--
trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
Modified: trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
===
--- trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
2012-12-19 13:12:55 UTC (rev 115790)
+++ trunk/extensions/Wikidata/OmegaWiki/resources/omegawiki-ajax.js
2012-12-19 13:15:22 UTC (rev 115791)
@@ -43,15 +43,6 @@
$(this).next(".popupToggleable").toggle(100);
});
- $(".mw-line-even").hover(
- function (event) {
- showTooltip( $(this), event );
- },
- function () {
- hideTooltip( $(this) );
- }
- );
-
$(window).resize(function() {
updateTabs();
});
@@ -243,46 +234,7 @@
});
- function showTooltip(elem, event) {
-// elem.hide();
- // position where it will be displayeds
- var posX = event.pageX ;
- var posY = elem.offset().top - 40 ;
- // check it the element already has a tooltip (hidden)
- if ( elem.children(".tooltip").length ) {
- //yes : reposition and show it
- elem.children(".tooltip")
- .css ("left", posX)
- .show();
-
- } else {
- // else create it
- var tipdiv = jQuery(document.createElement('span')) ;
- var tipmessage = "toto";
-
- tipdiv.addClass("tooltip")
- .css ("position", "fixed")
- .css ("left", posX)
- .css ("top", posY)
- .html( tipmessage )
- .appendTo(elem)
- .show();
-
- var triangle = jQuery(document.createElement('span')) ;
- // position absolute = given relative to its parent
- triangle.addClass("triangle-down")
- .css ("position", "absolute")
- // 5 is half of the triangle size
- .css ("left", tipdiv.width() / 2 - 5 )
- .css ("top", tipdiv.outerHeight() )
- .appendTo(tipdiv);
- } // else
- }
-
- function hideTooltip(elem) {
- elem.children(".tooltip").hide();
- }
//TODO: convert the functions below to jQuery...
window.MD5 = function (string) {
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make the PNG thumbnail update live - change (mediawiki...TranslateSvg[master])
Jarry1250 has uploaded a new change for review. Change subject: Make the PNG thumbnail update live .. Make the PNG thumbnail update live A live-updated thumbnail allows users to perfect the formatting of translated messages. There are essentially two parts to this commit, rolled together to allow testing and to make it clear why certain design decisions were taken. The first is a series of hooks into Translate to amend the API meta=messagegroups. The second is a JavaScript section that uses the the amended API methods to provide the live update service. Change-Id: I9c75d38028adc7cbab48a1d17f97c30a0ae12123 --- M TranslateSvg.php M TranslateSvgHooks.php M resources/ext.translatesvg.core.js 3 files changed, 133 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg refs/changes/80/39380/1 -- To view, visit https://gerrit.wikimedia.org/r/39380 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c75d38028adc7cbab48a1d17f97c30a0ae12123 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TranslateSvg Gerrit-Branch: master Gerrit-Owner: Jarry1250 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115792] trunk/extensions/Wikidata/OmegaWiki
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115792
Revision: 115792
Author: kipcool
Date: 2012-12-19 13:19:27 + (Wed, 19 Dec 2012)
Log Message:
---
Changed the identical meaning checkbox to a combobox
Modified Paths:
--
trunk/extensions/Wikidata/OmegaWiki/Editor.php
trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php
trunk/extensions/Wikidata/OmegaWiki/OmegaWikiEditors.php
trunk/extensions/Wikidata/OmegaWiki/WikiDataAPI.php
trunk/extensions/Wikidata/OmegaWiki/resources/tables.css
trunk/extensions/Wikidata/OmegaWiki/type.php
Modified: trunk/extensions/Wikidata/OmegaWiki/Editor.php
===
--- trunk/extensions/Wikidata/OmegaWiki/Editor.php 2012-12-19 13:15:22 UTC
(rev 115791)
+++ trunk/extensions/Wikidata/OmegaWiki/Editor.php 2012-12-19 13:19:27 UTC
(rev 115792)
@@ -235,18 +235,23 @@
}
}
-/* XXX: Basic Editor class. */
+/**
+ * Basic Editor class.
+ */
abstract class DefaultEditor implements Editor {
protected $editors;
protected $attributeEditorMap;
protected $attribute;
protected $isCollapsible;
+ protected $displayHeader;
public function __construct( Attribute $attribute = null ) {
$this->attribute = $attribute;
$this->editors = array();
$this->attributeEditorMap = new AttributeEditorMap();
$this->isCollapsible = true;
+ // show header by default
+ $this->displayHeader = true;
}
public function addEditor( Editor $editor ) {
@@ -282,6 +287,15 @@
$this->isCollapsible = $value;
}
+ public function setDisplayHeader( $value ) {
+ $this->displayHeader = $value;
+ }
+
+ public function getDisplayHeader() {
+ return $this->displayHeader;
+ }
+
+
public function getExpansionPrefix( $class, $elementId ) {
if ( ! $this->isCollapsible ) {
return '';
@@ -522,13 +536,13 @@
public function getUpdateRecord( IdStack $idPath, Structure $structure,
$editors ) {
$result = new ArrayRecord( $structure );
- foreach ( $editors as $editor )
+ foreach ( $editors as $editor ) {
if ( $attribute = $editor->getUpdateAttribute() ) {
$idPath->pushAttribute( $attribute );
$result->setAttributeValue( $attribute,
$editor->getUpdateValue( $idPath ) );
$idPath->popAttribute();
}
-
+ }
return $result;
}
@@ -1390,15 +1404,15 @@
}
public function add( IdStack $idPath ) {
- if ( $this->isAddField )
+ if ( $this->isAddField ) {
return getTextBox( $this->addId( $idPath->getId() ),
"", $this->onChangeHandler );
- else
+ } else {
return "";
+ }
}
public function getInputValue( $id ) {
- global
- $wgRequest;
+ global $wgRequest;
return trim( $wgRequest->getText( $id ) );
}
@@ -1415,9 +1429,9 @@
$label = htmlspecialchars( $value->linkLabel );
$url = htmlspecialchars( $value->linkURL );
- if ( $label == "" )
+ if ( $label == "" ) {
$label = $url;
-
+ }
return
'' . $label . '' . EOL;
}
@@ -1447,10 +1461,11 @@
}
public function add( IdStack $idPath ) {
- if ( $this->isAddField )
+ if ( $this->isAddField ) {
return getCheckBox( $this->addId( $idPath->getId() ),
$this->defaultValue );
- else
+ } else {
return "";
+ }
}
public function getInputValue( $id ) {
@@ -1460,12 +1475,69 @@
}
}
+/*
+* IdenticalMeaningEditor
+* in view mode, shows either = or ≈
+* in edit mode, shows a combobox to choose.
+* for html we use strings "true" and "false" instead of "0" and "1"
+* to be sure that an undefined value will not be considered as a "0".
+*/
+class IdenticalMeaningEditor extends ScalarEditor {
+ protected $defaultValue;
+ // textValues is an array of "value" => "how the value is displayed"
+ // e.g. array( "true" => "=", "false" => "≈" );
+ protected $textValues;
+
+ public function __construct( Attribute $attribute = null,
PermissionController $permissionController, $isAddField ) {
+ parent::__construct( $attribute, $permissionController,
$isAddField );
+
+ $this->defaultValue = "t
[MediaWiki-commits] [Gerrit] Remove support for StatusNet - change (translatewiki[master])
Siebrand has uploaded a new change for review. Change subject: Remove support for StatusNet .. Remove support for StatusNet The product will be discontinued. Might return in some form or another. Change-Id: I11c77f402128a165d98603539af2f1f24223c8ab --- M REPOCONF M TranslateSettings.php M bin/repocommit M bin/repocreate M bin/repoexport M bin/repoupdate D bin/stats-statusnet M bin/update-externals 8 files changed, 5 insertions(+), 67 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/81/39381/1 -- To view, visit https://gerrit.wikimedia.org/r/39381 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11c77f402128a165d98603539af2f1f24223c8ab Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added link to Code Climate - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Added link to Code Climate .. Added link to Code Climate Change-Id: I3c0e046e6c62c89aa9cee3ca2e2d9a967c6b90fb --- M README.md 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/82/39382/1 -- To view, visit https://gerrit.wikimedia.org/r/39382 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c0e046e6c62c89aa9cee3ca2e2d9a967c6b90fb Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CSS adjustments for translation suggestions - change (mediawiki...Translate[master])
Pginer has uploaded a new change for review. Change subject: CSS adjustments for translation suggestions .. CSS adjustments for translation suggestions CSS modifications on font size, color, spacing and border for suggestions to fit better in the editor. Change-Id: I68f131e6d2f9581afb71784726e2a60a3dba33b8 --- M resources/css/ext.translate.editor.css 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/83/39383/1 -- To view, visit https://gerrit.wikimedia.org/r/39383 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68f131e6d2f9581afb71784726e2a60a3dba33b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Pginer ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 43253 - SQL query error in CategoryTree::renderParents - change (mediawiki...CategoryTree[master])
Reedy has uploaded a new change for review. Change subject: Bug 43253 - SQL query error in CategoryTree::renderParents .. Bug 43253 - SQL query error in CategoryTree::renderParents Change-Id: Icc6bf66ca9cdabce417801ca5452e684ff83e6b8 --- M CategoryTreeFunctions.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CategoryTree refs/changes/84/39384/1 -- To view, visit https://gerrit.wikimedia.org/r/39384 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc6bf66ca9cdabce417801ca5452e684ff83e6b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CategoryTree Gerrit-Branch: master Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] SVN: [115793] trunk/extensions/Wikidata/OmegaWiki/Editor.php
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115793
Revision: 115793
Author: kipcool
Date: 2012-12-19 14:01:09 + (Wed, 19 Dec 2012)
Log Message:
---
resolved bug unkown function getDisplayHeader for some editors
Modified Paths:
--
trunk/extensions/Wikidata/OmegaWiki/Editor.php
Modified: trunk/extensions/Wikidata/OmegaWiki/Editor.php
===
--- trunk/extensions/Wikidata/OmegaWiki/Editor.php 2012-12-19 13:19:27 UTC
(rev 115792)
+++ trunk/extensions/Wikidata/OmegaWiki/Editor.php 2012-12-19 14:01:09 UTC
(rev 115793)
@@ -2067,6 +2067,12 @@
public function getAttributeEditorMap() {
return $this->wrappedEditor->getAttributeEditorMap();
}
+
+ public function getDisplayHeader() {
+ // only used for DefaultEditor so far.
+ // here returns only default true.
+ return true;
+ }
}
class PopUpEditor extends WrappingEditor {
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a comment about the constructor - change (mediawiki...Translate[master])
jenkins-bot has submitted this change and it was merged. Change subject: Add a comment about the constructor .. Add a comment about the constructor Change-Id: I621b8c2defa6d05fdf3f97b15147ec85c94aa4a7 --- M utils/MessageTable.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39358 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I621b8c2defa6d05fdf3f97b15147ec85c94aa4a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] CSS adjustments for translation suggestions - change (mediawiki...Translate[master])
jenkins-bot has submitted this change and it was merged. Change subject: CSS adjustments for translation suggestions .. CSS adjustments for translation suggestions CSS modifications on font size, color, spacing and border for suggestions to fit better in the editor. Change-Id: I68f131e6d2f9581afb71784726e2a60a3dba33b8 --- M resources/css/ext.translate.editor.css 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39383 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f131e6d2f9581afb71784726e2a60a3dba33b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Pginer Gerrit-Reviewer: Amire80 Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: Santhosh Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] first PageTriage feature for review - change (qa/browsertests[master])
Zfilipin has submitted this change and it was merged. Change subject: first PageTriage feature for review .. first PageTriage feature for review Change-Id: I25a917cdb7986fa84bd2bb7add15653592c9a642 --- A features/page_triage.feature 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Zfilipin: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39220 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25a917cdb7986fa84bd2bb7add15653592c9a642 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon Gerrit-Reviewer: Zfilipin Gerrit-Reviewer: mgro...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make github replication config forward compatible - change (operations/puppet[production])
Demon has uploaded a new change for review. Change subject: Make github replication config forward compatible .. Make github replication config forward compatible isGithubRepo is a hack I instituted for us awhile back. Now that this is being upstreamed, we've made it less of a hack. Change-Id: I55072d5244cd6df22d175c7337a8544725d4fdf8 --- M manifests/role/gerrit.pp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/85/39385/1 -- To view, visit https://gerrit.wikimedia.org/r/39385 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I55072d5244cd6df22d175c7337a8544725d4fdf8 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Demon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Jenkins job template now has repository option again. - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Jenkins job template now has repository option again. .. Jenkins job template now has repository option again. This reverts commit 10d4e1cfed310ab0044e386ef3224931d022c0d0 and adds Cloudbess repository to options. Change-Id: If33b061cf3fcb0275ebe1cb36b3ff863b535d838 --- M docs/template.md 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/86/39386/1 -- To view, visit https://gerrit.wikimedia.org/r/39386 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If33b061cf3fcb0275ebe1cb36b3ff863b535d838 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add several missing extensions - change (mediawiki/extensions[master])
Demon has submitted this change and it was merged. Change subject: Add several missing extensions .. Add several missing extensions List: CharRangeSpan CreditSource EImage GeoMath GuidedTour MagicNoCache MobileSections MyVariables NavigationTiming PageCredit PerPageLicense SecureSessions SlippyMap TimelineTable WikibaseClient WikibaseLib WikidataClient WikidataRepo Wikilog Change-Id: If45311832b3e373aa6ca37221b6f688124137675 --- M .gitmodules A CharRangeSpan A CreditSource A EImage A GeoMath A GuidedTour A MagicNoCache A MobileSections A MyVariables A NavigationTiming A PageCredit A PerPageLicense A SecureSessions A SlippyMap A TimelineTable A WikibaseClient A WikibaseLib A WikidataClient A WikidataRepo A Wikilog 20 files changed, 60 insertions(+), 0 deletions(-) Approvals: Demon: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39374 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If45311832b3e373aa6ca37221b6f688124137675 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Demon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rename global $realm to $wmfRealm - change (operations/mediawiki-config[master])
Hashar has submitted this change and it was merged. Change subject: rename global $realm to $wmfRealm .. rename global $realm to $wmfRealm $realm pollute the global namespace, renaming it to $wmfRealm makes it more obvious. Change-Id: Ibee3874f0275e966f0277e6e7446af71d9efce71 --- M wmf-config/CommonSettings.php M wmf-config/InitialiseSettings.php 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39056 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibee3874f0275e966f0277e6e7446af71d9efce71 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Anomie Gerrit-Reviewer: Hashar Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] basic inline documentation - change (integration/zuul-config[master])
Hashar has submitted this change and it was merged. Change subject: basic inline documentation .. basic inline documentation Add in a bit more documentation in the YAML file. The real documentation is available upstream at: http://ci.openstack.org/zuul/zuul.html#configuration Change-Id: Ic00f2524cd0d5a7efc3d9222ae05f3172cc9f75b --- M layout.yaml 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38520 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00f2524cd0d5a7efc3d9222ae05f3172cc9f75b Gerrit-PatchSet: 2 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) check on alias when validating entity selector input - change (mediawiki...Wikibase[master])
Henning Snater has uploaded a new change for review. Change subject: (minor) check on alias when validating entity selector input .. (minor) check on alias when validating entity selector input Change-Id: If0d0b6aa23b573efc6c762e86f36f09b406c3cb6 --- M lib/resources/jquery.ui/jquery.ui.entityselector.js 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/87/39387/1 -- To view, visit https://gerrit.wikimedia.org/r/39387 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0d0b6aa23b573efc6c762e86f36f09b406c3cb6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Whitespace - change (mediawiki...Translate[master])
Amire80 has uploaded a new change for review. Change subject: Whitespace .. Whitespace Change-Id: Ic1f60b1f022fc37841671084ff96890519c60e57 --- M resources/js/ext.translate.editor.js 1 file changed, 43 insertions(+), 43 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/88/39388/1 -- To view, visit https://gerrit.wikimedia.org/r/39388 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1f60b1f022fc37841671084ff96890519c60e57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed description for async parameter in upload module - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Fixed description for async parameter in upload module .. Fixed description for async parameter in upload module The description was already present, but it used incorrect syntax, so it didn't show. Change-Id: I7522265362f019c73523125df182366dfd274be2 --- M includes/api/ApiUpload.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7522265362f019c73523125df182366dfd274be2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Petr Onderka Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Whitespace - change (mediawiki...Translate[master])
Santhosh has submitted this change and it was merged. Change subject: Whitespace .. Whitespace Change-Id: Ic1f60b1f022fc37841671084ff96890519c60e57 --- M resources/js/ext.translate.editor.js 1 file changed, 43 insertions(+), 43 deletions(-) Approvals: Santhosh: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/39388 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f60b1f022fc37841671084ff96890519c60e57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 Gerrit-Reviewer: Santhosh Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update puppet-lint rake target - change (operations/puppet[production])
ArielGlenn has submitted this change and it was merged. Change subject: update puppet-lint rake target .. update puppet-lint rake target Exclude a few more lint for the most popular issues. Change-Id: I451270538cf5585087a628088a0ab148a42ec307 --- M rakefile 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: ArielGlenn: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/34850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451270538cf5585087a628088a0ab148a42ec307 Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: ArielGlenn Gerrit-Reviewer: Hashar Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix PEAR part of install-phpunit.sh. - change (mediawiki/core[master])
jenkins-bot has submitted this change and it was merged. Change subject: Fix PEAR part of install-phpunit.sh. .. Fix PEAR part of install-phpunit.sh. * Discover additional channel, update, and use alldeps. * Remove obsolete pear.symfony-project.com * Per https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Installing_PHPUnit#Using_PEAR Change-Id: I7f348c967c1526736ec7f34d610d315f8aabd504 --- M tests/phpunit/install-phpunit.sh 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/38814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f348c967c1526736ec7f34d610d315f8aabd504 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Mattflaschen Gerrit-Reviewer: Hashar Gerrit-Reviewer: Kaldari Gerrit-Reviewer: Maryana Gerrit-Reviewer: Mattflaschen Gerrit-Reviewer: Spage Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: preilly ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 43184) bogus script path in Special:Version - change (mediawiki/core[master])
jenkins-bot has submitted this change and it was merged. Change subject: (bug 43184) bogus script path in Special:Version .. (bug 43184) bogus script path in Special:Version Corrected display of script path change so that when the script path is empty, we default to showing / as the path. Change-Id: I8bb6ff820fa3f8d7c3cdd608f531c0f3c36389ca --- M includes/specials/SpecialVersion.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Demon: Looks good to me, approved Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39153 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bb6ff820fa3f8d7c3cdd608f531c0f3c36389ca Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Karun Gerrit-Reviewer: Demon Gerrit-Reviewer: Hashar Gerrit-Reviewer: Karun Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Pass user to LogEventsList::getExcludeClause - change (mediawiki/core[master])
IAlex has submitted this change and it was merged. Change subject: Pass user to LogEventsList::getExcludeClause .. Pass user to LogEventsList::getExcludeClause This avoids $wgUser in that method Also removed the double strencode for logtypes, that is already done by Database::addQuotes/Database::makeList Change-Id: I5f7f6da06594d92375f74ca48c04d180505642a9 --- M includes/logging/LogEventsList.php M includes/logging/LogPager.php 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/38713 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f7f6da06594d92375f74ca48c04d180505642a9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: IAlex Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up I5f7f6da0 (cefb9ef): pass the User parameter to mo... - change (mediawiki/core[master])
IAlex has uploaded a new change for review. Change subject: Follow-up I5f7f6da0 (cefb9ef): pass the User parameter to more LogEventsList::getExcludeClause() calls .. Follow-up I5f7f6da0 (cefb9ef): pass the User parameter to more LogEventsList::getExcludeClause() calls Per comment of Umherirrender, this is needed after the merge of Ia9709ed5 (c326de4). Change-Id: I7e9c2c7ee7de4e8f26008134c54b6f341ed91f7f --- M includes/api/ApiQueryLogEvents.php 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/89/39389/1 -- To view, visit https://gerrit.wikimedia.org/r/39389 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e9c2c7ee7de4e8f26008134c54b6f341ed91f7f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bug 43253 - SQL query error in CategoryTree::renderParents - change (mediawiki...CategoryTree[master])
Reedy has submitted this change and it was merged. Change subject: Bug 43253 - SQL query error in CategoryTree::renderParents .. Bug 43253 - SQL query error in CategoryTree::renderParents Change-Id: Icc6bf66ca9cdabce417801ca5452e684ff83e6b8 --- M CategoryTreeFunctions.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39384 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc6bf66ca9cdabce417801ca5452e684ff83e6b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CategoryTree Gerrit-Branch: master Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Jenkins job template now can specify Git repository branch - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Jenkins job template now can specify Git repository branch .. Jenkins job template now can specify Git repository branch This is needed because desktop-* and mobile-* jobs need master branch and debug-job needs debug branch. Change-Id: I5458c4d31bf574ee4dd91e80703a8db21c2b3996 --- M docs/template.md 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/90/39390/1 -- To view, visit https://gerrit.wikimedia.org/r/39390 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5458c4d31bf574ee4dd91e80703a8db21c2b3996 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CategoryTree to master - change (mediawiki/core[wmf/1.21wmf6])
Reedy has uploaded a new change for review. Change subject: Update CategoryTree to master .. Update CategoryTree to master Change-Id: If3d519c92b5e22d13636c1d49bc3c900f1935584 --- M extensions/CategoryTree 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/91/39391/1 -- To view, visit https://gerrit.wikimedia.org/r/39391 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3d519c92b5e22d13636c1d49bc3c900f1935584 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf6 Gerrit-Owner: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CategoryTree to master - change (mediawiki/core[wmf/1.21wmf6])
Reedy has submitted this change and it was merged. Change subject: Update CategoryTree to master .. Update CategoryTree to master Change-Id: If3d519c92b5e22d13636c1d49bc3c900f1935584 --- M extensions/CategoryTree 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39391 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3d519c92b5e22d13636c1d49bc3c900f1935584 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf6 Gerrit-Owner: Reedy Gerrit-Reviewer: Reedy ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix for IE10 failure when opening edit page - change (qa/browsertests[master])
Zfilipin has uploaded a new change for review. Change subject: Fix for IE10 failure when opening edit page .. Fix for IE10 failure when opening edit page Looks like IE10 checks too early, when the page is not opened yet. The fix waits for Save element to be on the page before checking page URL. Change-Id: I110d88bf5249114f7d07dfdf98c35d9fe623d63c --- M features/step_definitions/edit_steps.rb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/92/39392/1 -- To view, visit https://gerrit.wikimedia.org/r/39392 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I110d88bf5249114f7d07dfdf98c35d9fe623d63c Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Addin solr servers to yttrium stanza - change (operations/puppet[production])
Cmjohnson has uploaded a new change for review. Change subject: Addin solr servers to yttrium stanza .. Addin solr servers to yttrium stanza Change-Id: Ic3287c4c9b692dc6c90dccc34704356408eabc25 --- M manifests/site.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/93/39393/1 -- To view, visit https://gerrit.wikimedia.org/r/39393 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3287c4c9b692dc6c90dccc34704356408eabc25 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding solr servers to yttrium stanza - change (operations/puppet[production])
RobH has submitted this change and it was merged. Change subject: Adding solr servers to yttrium stanza .. Adding solr servers to yttrium stanza Change-Id: Ic3287c4c9b692dc6c90dccc34704356408eabc25 --- M manifests/site.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: RobH: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39393 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3287c4c9b692dc6c90dccc34704356408eabc25 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson Gerrit-Reviewer: Cmjohnson Gerrit-Reviewer: RobH Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] bug 43220: Modify mw:extension:listings to look for mediawik... - change (mediawiki...Listings[master])
Carlb has uploaded a new change for review. Change subject: bug 43220: Modify mw:extension:listings to look for mediawiki:listings-template as the name of a template to be used to format individual listings instead of using the built-in defaults. .. bug 43220: Modify mw:extension:listings to look for mediawiki:listings-template as the name of a template to be used to format individual listings instead of using the built-in defaults. Change-Id: I90dced07924d0b87cb7737fdf969203fae8810ca --- M Listings.body.php 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Listings refs/changes/94/39394/1 -- To view, visit https://gerrit.wikimedia.org/r/39394 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90dced07924d0b87cb7737fdf969203fae8810ca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Listings Gerrit-Branch: master Gerrit-Owner: Carlb ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure translation memories are not polluted in tests - change (mediawiki...Translate[master])
Nikerabbit has uploaded a new change for review. Change subject: Make sure translation memories are not polluted in tests .. Make sure translation memories are not polluted in tests Also fixed one typo Change-Id: I89b6caf7f7794920ed37e774cc6a1ba1a51c6961 --- M tests/MessageGroupStatesUpdaterJobTest.php M tests/MessageGroupsTest.php M tests/MessageIndexRebuildJobTest.php M tests/MessageIndexTest.php M tests/PageTranslationTaggingTest.php M tests/SpecialPagesTest.php M tests/TranslateHooksTest.php M tests/TranslationFuzzyUpdaterTest.php M tests/api/ApiGroupReviewTest.php M tests/api/ApiQueryMessageGroupsTest.php M tests/api/ApiTranslationReviewTest.php 11 files changed, 23 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/95/39395/1 -- To view, visit https://gerrit.wikimedia.org/r/39395 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89b6caf7f7794920ed37e774cc6a1ba1a51c6961 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] make rebuildtextindex script aware of content models. - change (mediawiki/core[master])
jenkins-bot has submitted this change and it was merged. Change subject: make rebuildtextindex script aware of content models. .. make rebuildtextindex script aware of content models. Change-Id: Ia976ce975e3c64a54e1d4b27c52bccaa07754041 --- M includes/search/SearchUpdate.php M maintenance/rebuildtextindex.php 2 files changed, 29 insertions(+), 7 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/38688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia976ce975e3c64a54e1d4b27c52bccaa07754041 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Asher Gerrit-Reviewer: Demon Gerrit-Reviewer: Reedy Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Only parse wikitext once per test per test run. - change (mediawiki...Parsoid[master])
MarkTraceur has uploaded a new change for review. Change subject: Only parse wikitext once per test per test run. .. Only parse wikitext once per test per test run. Also, moved the outerHTML trick we use into DOMUtils. Change-Id: I11d5f74d9a1c2f68d8806a8a348cb6db406af1b3 --- M js/lib/mediawiki.DOMUtils.js M js/tests/parserTests.js M js/tests/roundtrip-test.js 3 files changed, 63 insertions(+), 35 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/96/39396/1 -- To view, visit https://gerrit.wikimedia.org/r/39396 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11d5f74d9a1c2f68d8806a8a348cb6db406af1b3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: MarkTraceur ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] dhcpd entry for solr1-3 - change (operations/puppet[production])
Cmjohnson has uploaded a new change for review. Change subject: dhcpd entry for solr1-3 .. dhcpd entry for solr1-3 Change-Id: If4ada66c11edca4768105b063460d857c2fde011 --- M files/dhcpd/linux-host-entries.ttyS1-115200 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/97/39397/1 -- To view, visit https://gerrit.wikimedia.org/r/39397 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4ada66c11edca4768105b063460d857c2fde011 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Sync special page alias file - change (mediawiki...MobileFrontend[master])
Raimond Spekking has uploaded a new change for review. Change subject: Sync special page alias file .. Sync special page alias file In https://gerrit.wikimedia.org/r/#/c/39155/8/MobileFrontend.php,unified * 'DonateImage' was added * 'MobileDiff' and 'MobileMenu' were added somewhere in the past * 'MobileFrontend' was removed somewhere in the past Change-Id: Idc9711054fd18b7321ff62de1c71c90fcd7480c9 --- M MobileFrontend.alias.php 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/98/39398/1 -- To view, visit https://gerrit.wikimedia.org/r/39398 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc9711054fd18b7321ff62de1c71c90fcd7480c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] dhcpd entry for solr1-3 - change (operations/puppet[production])
Cmjohnson has submitted this change and it was merged. Change subject: dhcpd entry for solr1-3 .. dhcpd entry for solr1-3 Change-Id: If4ada66c11edca4768105b063460d857c2fde011 --- M files/dhcpd/linux-host-entries.ttyS1-115200 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Cmjohnson: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/39397 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4ada66c11edca4768105b063460d857c2fde011 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Cmjohnson Gerrit-Reviewer: Cmjohnson Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Several tsr/dsr fixes for the different lists. - change (mediawiki...Parsoid[master])
Subramanya Sastry has uploaded a new change for review. Change subject: Several tsr/dsr fixes for the different lists. .. Several tsr/dsr fixes for the different lists. * TSR computation for lists and list-items was incorrect. The fixes are documented with examples in the list-handler. * Eliminates many DSR computation warnings about s/cs mismatches Given a node N and a [s,e) value for N's subtree, the DSR code proceeds right-to-left (RTL) processing N's children and ends up with a 'cs' value when it hits the first child. If all is well, s should match cs (s == DSR-RTL(N.children, e)) This patch eliminates about 34 warnings. * No change in regular parser tests. But, selser tests improve. The specific numbers vary by the changes file and num-changes parameter. * I thought a list regression in Barack Obama page disappeared but it may also be a non-deterministic thing since I did see it show up again on one of the test runs. Change-Id: I9774f9ecd7a2ec2a051ff3cfa13ad18d99a8b195 --- M js/lib/ext.core.ListHandler.js M js/lib/mediawiki.DOMPostProcessor.js 2 files changed, 56 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/99/39399/1 -- To view, visit https://gerrit.wikimedia.org/r/39399 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9774f9ecd7a2ec2a051ff3cfa13ad18d99a8b195 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing Logic Bomb in the Amazon Audit Script - change (wikimedia...tools[master])
Mwalker has uploaded a new change for review. Change subject: Fixing Logic Bomb in the Amazon Audit Script .. Fixing Logic Bomb in the Amazon Audit Script An errant 'or' would cause ALL successful transactions to be submitted to civi instead of just the ones that actually needed to be. Change-Id: Ib5d58390e2ad0e2783cffdd67b519031d01645dd --- M AmazonAudit/amazon-audit.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools refs/changes/00/39400/1 -- To view, visit https://gerrit.wikimedia.org/r/39400 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5d58390e2ad0e2783cffdd67b519031d01645dd Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Mwalker ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix outdent tooltip calling for a non-existant message - change (mediawiki...VisualEditor[master])
jenkins-bot has submitted this change and it was merged. Change subject: Fix outdent tooltip calling for a non-existant message .. Fix outdent tooltip calling for a non-existant message Change-Id: I8b39f116181310b86d804a567eedf9c68bde594f --- M modules/ve/ui/tools/buttons/ve.ui.OutdentButtonTool.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Robmoen: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/38810 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b39f116181310b86d804a567eedf9c68bde594f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester Gerrit-Reviewer: Robmoen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing Logic Bomb in the Amazon Audit Script - change (wikimedia...tools[master])
Adamw has submitted this change and it was merged. Change subject: Fixing Logic Bomb in the Amazon Audit Script .. Fixing Logic Bomb in the Amazon Audit Script An errant 'or' would cause ALL successful transactions to be submitted to civi instead of just the ones that actually needed to be. Change-Id: Ib5d58390e2ad0e2783cffdd67b519031d01645dd --- M AmazonAudit/amazon-audit.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adamw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39400 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d58390e2ad0e2783cffdd67b519031d01645dd Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/tools Gerrit-Branch: master Gerrit-Owner: Mwalker Gerrit-Reviewer: Adamw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup of error handling in saving messages - change (mediawiki...Translate[master])
Amire80 has uploaded a new change for review. Change subject: Cleanup of error handling in saving messages .. Cleanup of error handling in saving messages Message saving said "FIXME not tested" about error hadling. I tried to test it, and found some issues that I try to address here. It's probably not perfect. Change-Id: Icb5f2123c95e57376c0f77ef0b10e91096e2bc12 --- M Translate.i18n.php M Translate.php M resources/js/ext.translate.editor.js 3 files changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/01/39401/1 -- To view, visit https://gerrit.wikimedia.org/r/39401 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb5f2123c95e57376c0f77ef0b10e91096e2bc12 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Amire80 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix broken qunit test - change (mediawiki...MobileFrontend[master])
Jdlrobson has uploaded a new change for review. Change subject: fix broken qunit test .. fix broken qunit test it is now mandatory when using replaceHash that an item with that hash exists in the DOM update whitespace in mf-history.js whilst at it Change-Id: I793ac56f84ecd30b859519ce1aeca48148229169 --- M javascripts/common/mf-history.js M tests/js/test_application.js 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/02/39402/1 -- To view, visit https://gerrit.wikimedia.org/r/39402 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I793ac56f84ecd30b859519ce1aeca48148229169 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add a PhantomJS runner for QUnit tests - change (mediawiki...MobileFrontend[master])
Jdlrobson has submitted this change and it was merged. Change subject: Add a PhantomJS runner for QUnit tests .. Add a PhantomJS runner for QUnit tests Now `make qunit` runs tests in the terminal instead trying to open a browser window. Also updated the pre-commit hook. Change-Id: I6ebbb7c6c08d72b85dae09600274e59125c81c00 --- M Makefile M scripts/pre-commit A tests/phantomjs-qunit-runner.js A tests/qunit.sh 4 files changed, 143 insertions(+), 1 deletion(-) Approvals: Jdlrobson: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/39346 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ebbb7c6c08d72b85dae09600274e59125c81c00 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: JGonera Gerrit-Reviewer: JGonera Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Switching all 'pedias to 1.21wmf6 - change (operations/mediawiki-config[master])
Demon has uploaded a new change for review. Change subject: Switching all 'pedias to 1.21wmf6 .. Switching all 'pedias to 1.21wmf6 Change-Id: I3bf45b2ba1cebf429e79a2788e1cb2fb57f7bf00 --- M wikiversions.dat 1 file changed, 273 insertions(+), 273 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/03/39403/1 -- To view, visit https://gerrit.wikimedia.org/r/39403 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bf45b2ba1cebf429e79a2788e1cb2fb57f7bf00 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Demon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Depend on postEdit for wgPostEdit, pending bug 43270. - change (mediawiki...E3Experiments[master])
Mattflaschen has uploaded a new change for review. Change subject: Depend on postEdit for wgPostEdit, pending bug 43270. .. Depend on postEdit for wgPostEdit, pending bug 43270. Change-Id: Ie4b7793d3e185d54a41e5c8f0a845ba5c65e2e33 --- M Experiments.php 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/E3Experiments refs/changes/04/39404/1 -- To view, visit https://gerrit.wikimedia.org/r/39404 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie4b7793d3e185d54a41e5c8f0a845ba5c65e2e33 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Mattflaschen ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Depend on postEdit for wgPostEdit, pending bug 43270. - change (mediawiki...E3Experiments[master])
Ori.livneh has submitted this change and it was merged. Change subject: Depend on postEdit for wgPostEdit, pending bug 43270. .. Depend on postEdit for wgPostEdit, pending bug 43270. Change-Id: Ie4b7793d3e185d54a41e5c8f0a845ba5c65e2e33 --- M Experiments.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/39404 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4b7793d3e185d54a41e5c8f0a845ba5c65e2e33 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Mattflaschen Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] fix broken qunit test - change (mediawiki...MobileFrontend[master])
JGonera has submitted this change and it was merged. Change subject: fix broken qunit test .. fix broken qunit test it is now mandatory when using replaceHash that an item with that hash exists in the DOM update whitespace in mf-history.js whilst at it Change-Id: I793ac56f84ecd30b859519ce1aeca48148229169 --- M javascripts/common/mf-history.js M tests/js/test_application.js 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: JGonera: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/39402 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I793ac56f84ecd30b859519ce1aeca48148229169 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson Gerrit-Reviewer: JGonera Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add an option to importImages to search subdirectories recur... - change (mediawiki/core[master])
Hoo man has uploaded a new change for review. Change subject: Add an option to importImages to search subdirectories recursively .. Add an option to importImages to search subdirectories recursively Change-Id: I73a0d42884c1006492cd3de912eb1dc6dab08c5e --- M maintenance/importImages.inc M maintenance/importImages.php 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/05/39405/1 -- To view, visit https://gerrit.wikimedia.org/r/39405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73a0d42884c1006492cd3de912eb1dc6dab08c5e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hoo man ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding .gitreview - change (wikimedia...modifications[master])
Demon has submitted this change and it was merged. Change subject: Adding .gitreview .. Adding .gitreview Change-Id: I9d37ebc31ff5b801f619d7c6fe72fe7274a715d4 --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Demon: Verified Aklapper: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d37ebc31ff5b801f619d7c6fe72fe7274a715d4 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/bugzilla/modifications Gerrit-Branch: master Gerrit-Owner: Dereckson Gerrit-Reviewer: Aklapper Gerrit-Reviewer: Demon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update pom - change (mediawiki...mwdumper[master])
Demon has submitted this change and it was merged. Change subject: Update pom .. Update pom Fix compiler warnings. Change-Id: I074ce1df8f5cb6526573747d338c164d51c2225a --- M pom.xml 1 file changed, 77 insertions(+), 65 deletions(-) Approvals: Demon: Verified Oren: Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/33092 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074ce1df8f5cb6526573747d338c164d51c2225a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/mwdumper Gerrit-Branch: master Gerrit-Owner: Bean49 Gerrit-Reviewer: ArielGlenn Gerrit-Reviewer: Demon Gerrit-Reviewer: Oren Gerrit-Reviewer: jenkins-bot Gerrit-Reviewer: saper ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Changed messages and message keys for standardization. - change (mediawiki...SecureSessions[master])
Parent5446 has submitted this change and it was merged. Change subject: Changed messages and message keys for standardization. .. Changed messages and message keys for standardization. Changed certain messages to comply with MediaWiki standards. Also unified prefix on message keys. Code was adjusted for the message key changes. Finally, an aliases file was added for the special page. Change-Id: Ide93c6f53f964e4480c23eea1cc901ba7ba0 --- M SecureSessions.i18n.php A SpecialSessions.alias.php M SpecialSessions.php 3 files changed, 78 insertions(+), 20 deletions(-) Approvals: Parent5446: Verified; Looks good to me, approved Siebrand: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37115 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide93c6f53f964e4480c23eea1cc901ba7ba0 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SecureSessions Gerrit-Branch: master Gerrit-Owner: Parent5446 Gerrit-Reviewer: Parent5446 Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove of a call to the depreciated function wfMsgForContent - change (mediawiki...ProofreadPage[master])
Tpt has submitted this change and it was merged. Change subject: Remove of a call to the depreciated function wfMsgForContent .. Remove of a call to the depreciated function wfMsgForContent Change-Id: Id40b49690ab7a16946cb09c13e7ae0573e9ba225 --- M includes/ProofreadPageInit.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tpt: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/38748 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id40b49690ab7a16946cb09c13e7ae0573e9ba225 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt Gerrit-Reviewer: Brian Wolff Gerrit-Reviewer: Tpt ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] pass pep8 on deployment module - change (operations/puppet[production])
Hashar has uploaded a new change for review. Change subject: pass pep8 on deployment module .. pass pep8 on deployment module Change-Id: I5ab1f4cb466d54e3601a1ee2c83d64ac7eefd483 --- M modules/deployment/files/git-deploy/shared.py M modules/deployment/files/modules/deploy.py M modules/deployment/files/modules/parsoid.py 3 files changed, 91 insertions(+), 72 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/07/39407/1 -- To view, visit https://gerrit.wikimedia.org/r/39407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ab1f4cb466d54e3601a1ee2c83d64ac7eefd483 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42802) Let the client specify multiple filters for list... - change (mediawiki...AbuseFilter[master])
CSteipp has submitted this change and it was merged. Change subject: (bug 42802) Let the client specify multiple filters for list=abuselog .. (bug 42802) Let the client specify multiple filters for list=abuselog Change-Id: I9d06186aea207896bdb354d0e86ee35632fc2090 --- M api/ApiQueryAbuseLog.php 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: CSteipp: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37346 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d06186aea207896bdb354d0e86ee35632fc2090 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Alex Monk Gerrit-Reviewer: Alex Monk Gerrit-Reviewer: CSteipp Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Matthias Mullie ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
