[MediaWiki-commits] [Gerrit] Hide mw.makeProtectedEnvFuncs from modules - change (mediawiki...Scribunto)
jenkins-bot has submitted this change and it was merged.
Change subject: Hide mw.makeProtectedEnvFuncs from modules
..
Hide mw.makeProtectedEnvFuncs from modules
Allowing a module to call mw.makeProtectedEnvFuncs() lets it bypass the
allowEnvFuncs setting. It can also be used to manipulate the global
tables that other modules' sandboxes will be copied from.
And for paranoia's sake, let's tighten up what setfenv is allowed to
set. This requires changing a unit test, because it is no longer
sane to do something like
env.setfenv, env.getfenv = mw.makeProtectedEnvFuncs( { [env] = true }, {} )
Nothing real does this, it was only in the unit test.
Change-Id: I8e0d83bb0980ee869af3ac4413afd211717ca92f
---
M engines/LuaCommon/lualib/mw.lua
M tests/engines/LuaCommon/CommonTest.php
M tests/engines/LuaCommon/CommonTests.lua
3 files changed, 20 insertions(+), 7 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/49170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0d83bb0980ee869af3ac4413afd211717ca92f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Anomie
Gerrit-Reviewer: Aaron Schulz
Gerrit-Reviewer: Demon
Gerrit-Reviewer: Tim Starling
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix mw.ustring.gmatch and patterns with '^' - change (mediawiki...Scribunto)
jenkins-bot has submitted this change and it was merged. Change subject: Fix mw.ustring.gmatch and patterns with '^' .. Fix mw.ustring.gmatch and patterns with '^' The Lua manual says this: For this function, a '^' at the start of a pattern does not work as an anchor, as this would prevent the iteration. I had interpreted that to mean that a pattern starting with '^' would never match in gmatch. But further testing reveals that the '^' is just treated as a literal character: string.gmatch( "foo ^bar baz", "^%a+" ) will match "^bar". Change-Id: Id91d6ee2db753ce1d6a4f6ae27764691d9e9fdc4 --- M engines/LuaCommon/UstringLibrary.php M engines/LuaCommon/lualib/mw.ustring.lua M engines/LuaCommon/lualib/ustring/ustring.lua M tests/engines/LuaCommon/UstringLibraryTests.lua 4 files changed, 9 insertions(+), 19 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49080 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id91d6ee2db753ce1d6a4f6ae27764691d9e9fdc4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Scribunto Gerrit-Branch: master Gerrit-Owner: Anomie Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Demon Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update README.md to reflect new repository name - change (mediawiki/vagrant)
Ori.livneh has submitted this change and it was merged. Change subject: Update README.md to reflect new repository name .. Update README.md to reflect new repository name Change-Id: I7084e844b288f5a65548e983b53c092554636608 --- M README.md 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49209 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7084e844b288f5a65548e983b53c092554636608 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vagrant Gerrit-Branch: master Gerrit-Owner: Legoktm Gerrit-Reviewer: Ori.livneh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implemented base of query object - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Implemented base of query object .. Implemented base of query object Change-Id: Iae65fccd40407e112085c1833e3d86a8c2ac7e2f --- M Ask.classes.php M Ask.mw.php M includes/language/Query.php A tests/phpunit/language/QueryTest.php 4 files changed, 133 insertions(+), 3 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved Jeroen De Dauw: -- To view, visit https://gerrit.wikimedia.org/r/48609 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae65fccd40407e112085c1833e3d86a8c2ac7e2f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add i18n file - change (mediawiki...Git2Pages)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/49210 Change subject: Add i18n file .. Add i18n file Change-Id: Ic0343939a743b55c72f4c200e54957202be24829 --- A Git2Pages.i18n.php M Git2Pages.php 2 files changed, 32 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Git2Pages refs/changes/10/49210/1 -- To view, visit https://gerrit.wikimedia.org/r/49210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0343939a743b55c72f4c200e54957202be24829 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Git2Pages Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Change test base class registration so Jenkins does not run ... - change (mediawiki...Ask)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49211 Change subject: Change test base class registration so Jenkins does not run into problems .. Change test base class registration so Jenkins does not run into problems Change-Id: Id176c2000f0a22cb8205a6c0b6e40e00a043f698 --- M Ask.mw.php 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/11/49211/1 -- To view, visit https://gerrit.wikimedia.org/r/49211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id176c2000f0a22cb8205a6c0b6e40e00a043f698 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove non-needed class registration check - change (mediawiki...Ask)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49212 Change subject: Remove non-needed class registration check .. Remove non-needed class registration check Change-Id: I601de691634651a690faa22a5dab7659398ad65b --- M Ask.mw.php 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/12/49212/1 -- To view, visit https://gerrit.wikimedia.org/r/49212 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I601de691634651a690faa22a5dab7659398ad65b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Require the DataValues library to be loaded - change (mediawiki...Ask)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49213 Change subject: Require the DataValues library to be loaded .. Require the DataValues library to be loaded Change-Id: Ib4b70c2e71f7e790cbef4a440ec061de962bc8fe --- M Ask.php 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/13/49213/1 -- To view, visit https://gerrit.wikimedia.org/r/49213 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4b70c2e71f7e790cbef4a440ec061de962bc8fe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Regsiter dependencies for Ask - change (integration/jenkins-job-builder-config)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49214 Change subject: Regsiter dependencies for Ask .. Regsiter dependencies for Ask Change-Id: I009b785fad3f2715b8e087a82d22afa32203aa45 --- M mediawiki-extensions.yaml 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config refs/changes/14/49214/1 -- To view, visit https://gerrit.wikimedia.org/r/49214 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I009b785fad3f2715b8e087a82d22afa32203aa45 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added options to query object - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Added options to query object .. Added options to query object Change-Id: Ic045ff797093257f200fbbd1c85566374ea8e341 --- M Ask.classes.php M includes/language/Query.php A includes/language/option/PropertyValueSortExpression.php A includes/language/option/QueryOptions.php A includes/language/option/SortExpression.php A includes/language/option/SortOptions.php M includes/language/selectionrequest/ThisSelectionRequest.php M tests/phpunit/language/QueryTest.php 8 files changed, 276 insertions(+), 15 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved Jeroen De Dauw: -- To view, visit https://gerrit.wikimedia.org/r/48619 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic045ff797093257f200fbbd1c85566374ea8e341 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Regsiter dependencies for Ask - change (integration/jenkins-job-builder-config)
Hashar has submitted this change and it was merged. Change subject: Regsiter dependencies for Ask .. Regsiter dependencies for Ask Change-Id: I009b785fad3f2715b8e087a82d22afa32203aa45 --- M mediawiki-extensions.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49214 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I009b785fad3f2715b8e087a82d22afa32203aa45 Gerrit-PatchSet: 2 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] rename SelectionRequest to Selection and ThisSelection to Su... - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: rename SelectionRequest to Selection and ThisSelection to SubjectSelection .. rename SelectionRequest to Selection and ThisSelection to SubjectSelection Change-Id: Id64e2dc2fd86f33ed17c7f66fb592605eee33a78 --- M Ask.classes.php M Ask.mw.php M includes/language/Query.php M includes/language/description/ValueDescription.php R includes/language/selection/PropertySelection.php R includes/language/selection/Selection.php R includes/language/selection/SubjectSelection.php M tests/phpunit/language/QueryTest.php R tests/phpunit/language/selection/PropertySelectionTest.php R tests/phpunit/language/selection/SelectionTest.php R tests/phpunit/language/selection/SubjectSelectionTest.php 11 files changed, 48 insertions(+), 46 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved Jeroen De Dauw: -- To view, visit https://gerrit.wikimedia.org/r/48621 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id64e2dc2fd86f33ed17c7f66fb592605eee33a78 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jens Ohlig Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Change test base class registration so Jenkins does not run ... - change (mediawiki...Ask)
jenkins-bot has submitted this change and it was merged. Change subject: Change test base class registration so Jenkins does not run into problems .. Change test base class registration so Jenkins does not run into problems Change-Id: Id176c2000f0a22cb8205a6c0b6e40e00a043f698 --- M Ask.mw.php 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id176c2000f0a22cb8205a6c0b6e40e00a043f698 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added docs - change (mediawiki...Ask)
jenkins-bot has submitted this change and it was merged. Change subject: Added docs .. Added docs Change-Id: Ie3dcb908cf8deb75e4450226802a692241beca97 --- M includes/language/Query.php M includes/language/option/PropertyValueSortExpression.php M includes/language/option/QueryOptions.php M includes/language/option/SortExpression.php M includes/language/option/SortOptions.php 5 files changed, 58 insertions(+), 4 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/48822 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3dcb908cf8deb75e4450226802a692241beca97 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added direction field to SortExpression - change (mediawiki...Ask)
jenkins-bot has submitted this change and it was merged. Change subject: Added direction field to SortExpression .. Added direction field to SortExpression Change-Id: Ib46f5d832273b2045e846b324a03b34af31a65d4 --- M includes/language/option/PropertyValueSortExpression.php M includes/language/option/SortExpression.php 2 files changed, 36 insertions(+), 1 deletion(-) Approvals: John Erling Blad: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/48823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib46f5d832273b2045e846b324a03b34af31a65d4 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Kick out isSingleton method. Apparently it is not used in th... - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Kick out isSingleton method. Apparently it is not used in the SMW query engine at all .. Kick out isSingleton method. Apparently it is not used in the SMW query engine at all Change-Id: I5ea06b5d75932a7c1772102c5090bdfb209bf57b --- M includes/language/description/AnyValue.php M includes/language/description/Conjunction.php M includes/language/description/Description.php M includes/language/description/Disjunction.php M includes/language/description/SomeProperty.php M includes/language/description/ValueDescription.php M tests/phpunit/language/description/AnyValueTest.php M tests/phpunit/language/description/ConjunctionTest.php M tests/phpunit/language/description/DescriptionTest.php M tests/phpunit/language/description/DisjunctionTest.php M tests/phpunit/language/description/SomePropertyTest.php M tests/phpunit/language/description/ValueDescriptionTest.php 12 files changed, 0 insertions(+), 215 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved Jeroen De Dauw: -- To view, visit https://gerrit.wikimedia.org/r/48824 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ea06b5d75932a7c1772102c5090bdfb209bf57b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add i18n file - change (mediawiki...Git2Pages)
Siebrand has submitted this change and it was merged. Change subject: Add i18n file .. Add i18n file Change-Id: Ic0343939a743b55c72f4c200e54957202be24829 --- A Git2Pages.i18n.php M Git2Pages.php 2 files changed, 32 insertions(+), 4 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0343939a743b55c72f4c200e54957202be24829 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Git2Pages Gerrit-Branch: master Gerrit-Owner: Raimond Spekking Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Terrrydactyl ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] make logo protorel instead hardcoding HTTP - change (operations/puppet)
Jeremyb has uploaded a new change for review. https://gerrit.wikimedia.org/r/49215 Change subject: make logo protorel instead hardcoding HTTP .. make logo protorel instead hardcoding HTTP It's a Wikimedia specific path so it's probably used somewhere. haven't found it yet. Change-Id: I6d2139b20b2686c7ed839bbf5094a0ca5dcf8e1f --- M files/rt/80-wikimedia 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/15/49215/1 -- To view, visit https://gerrit.wikimedia.org/r/49215 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d2139b20b2686c7ed839bbf5094a0ca5dcf8e1f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Jeremyb ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Require the DataValues library to be loaded - change (mediawiki...Ask)
jenkins-bot has submitted this change and it was merged. Change subject: Require the DataValues library to be loaded .. Require the DataValues library to be loaded Change-Id: Ib4b70c2e71f7e790cbef4a440ec061de962bc8fe --- M Ask.php 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49213 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b70c2e71f7e790cbef4a440ec061de962bc8fe Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Followup Ic0343939: Fix typo - change (mediawiki...Git2Pages)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/49216 Change subject: Followup Ic0343939: Fix typo .. Followup Ic0343939: Fix typo Change-Id: I9684250a055336f93323ae9153530e8f1d98db54 --- M Git2Pages.i18n.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Git2Pages refs/changes/16/49216/1 -- To view, visit https://gerrit.wikimedia.org/r/49216 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9684250a055336f93323ae9153530e8f1d98db54 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Git2Pages Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Followup Ic0343939: Fix typo - change (mediawiki...Git2Pages)
Raimond Spekking has submitted this change and it was merged. Change subject: Followup Ic0343939: Fix typo .. Followup Ic0343939: Fix typo Change-Id: I9684250a055336f93323ae9153530e8f1d98db54 --- M Git2Pages.i18n.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Raimond Spekking: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49216 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9684250a055336f93323ae9153530e8f1d98db54 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Git2Pages Gerrit-Branch: master Gerrit-Owner: Raimond Spekking Gerrit-Reviewer: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove non-needed class registration check - change (mediawiki...Ask)
jenkins-bot has submitted this change and it was merged. Change subject: Remove non-needed class registration check .. Remove non-needed class registration check Change-Id: I601de691634651a690faa22a5dab7659398ad65b --- M Ask.mw.php 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49212 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601de691634651a690faa22a5dab7659398ad65b Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [Git2Pages] Register extension - change (translatewiki)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/49217 Change subject: [Git2Pages] Register extension .. [Git2Pages] Register extension Change-Id: Id3e88ee9ab2d6a7ccfb32f9ab70837b48ccbdf9a --- M groups/MediaWiki/mediawiki-defines.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/17/49217/1 -- To view, visit https://gerrit.wikimedia.org/r/49217 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3e88ee9ab2d6a7ccfb32f9ab70837b48ccbdf9a Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [Git2Pages] Register extension - change (translatewiki)
Raimond Spekking has submitted this change and it was merged. Change subject: [Git2Pages] Register extension .. [Git2Pages] Register extension Change-Id: Id3e88ee9ab2d6a7ccfb32f9ab70837b48ccbdf9a --- M groups/MediaWiki/mediawiki-defines.txt 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Raimond Spekking: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49217 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e88ee9ab2d6a7ccfb32f9ab70837b48ccbdf9a Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Raimond Spekking Gerrit-Reviewer: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] only set async if we want to enable async - change (mediawiki...UploadWizard)
J has uploaded a new change for review. https://gerrit.wikimedia.org/r/49218 Change subject: only set async if we want to enable async .. only set async if we want to enable async setting async to false does not work, only set it if we want async publishing. Change-Id: Ia6bb6a71409a3b39b6dda3cab93375aadbe5ad76 --- M resources/mw.UploadWizardDetails.js 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/18/49218/1 -- To view, visit https://gerrit.wikimedia.org/r/49218 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6bb6a71409a3b39b6dda3cab93375aadbe5ad76 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: J ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rename Autocomment class to Summary - change (mediawiki...Wikibase)
Daniel Kinzler has uploaded a new change for review. https://gerrit.wikimedia.org/r/49219 Change subject: Rename Autocomment class to Summary .. Rename Autocomment class to Summary Change-Id: I315d884e38e44e15dcebc98c0a0f60e185846d14 --- M repo/Wikibase.hooks.php M repo/Wikibase.php R repo/includes/Summary.php M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiEditEntity.php M repo/includes/api/ApiLinkTitles.php M repo/includes/api/ApiModifyEntity.php M repo/includes/api/ApiModifyLangAttribute.php M repo/includes/api/ApiSetAliases.php M repo/includes/api/ApiSetSiteLink.php R repo/includes/api/ApiSummary.php M repo/includes/specials/SpecialCreateEntity.php M repo/includes/specials/SpecialSetEntity.php R repo/tests/phpunit/includes/SummaryTest.php 14 files changed, 61 insertions(+), 61 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/19/49219/1 -- To view, visit https://gerrit.wikimedia.org/r/49219 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I315d884e38e44e15dcebc98c0a0f60e185846d14 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Renamed "Wikidata repository" special page group into "Wikib... - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Renamed "Wikidata repository" special page group into "Wikibase repository" .. Renamed "Wikidata repository" special page group into "Wikibase repository" "Wikidata" is just wrong since the extension itself is called "Wikibase". If this is an issue on wikidata.org, then this should be solved there by changing the message only there. Change-Id: I6a2775e7c6a0f8c4d60e3c6aac142a3a58d9a343 --- M repo/Wikibase.i18n.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved Siebrand: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/48484 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a2775e7c6a0f8c4d60e3c6aac142a3a58d9a343 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Aude Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 44857) Add &bot param to API modules that are missing i... - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: (bug 44857) Add &bot param to API modules that are missing it .. (bug 44857) Add &bot param to API modules that are missing it Change-Id: Ia5cb3fcc8b4af8adfdd1e2e024f7fe7cadb512d6 --- M repo/includes/api/ApiCreateClaim.php M repo/includes/api/ApiRemoveClaims.php M repo/includes/api/ApiSetClaimValue.php M repo/includes/api/ApiSetReference.php M repo/includes/api/RemoveQualifiers.php M repo/includes/api/RemoveReferences.php M repo/includes/api/SetQualifier.php M repo/includes/api/SetStatementRank.php 8 files changed, 81 insertions(+), 17 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49205 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cb3fcc8b4af8adfdd1e2e024f7fe7cadb512d6 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Legoktm Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Legoktm ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] planet config updates . add 2 update 2 de, en, it - change (operations/puppet)
Jalexander has uploaded a new change for review. https://gerrit.wikimedia.org/r/49220 Change subject: planet config updates . add 2 update 2 de,en,it .. planet config updates . add 2 update 2 de,en,it requeste on meta http://meta.wikimedia.org/wiki/Planet_Wikimedia Change-Id: Iebc99859e209529389adc61733a2b318c9452ce1 --- M templates/planet/de_config.erb M templates/planet/en_config.erb M templates/planet/it_config.erb 3 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/20/49220/1 -- To view, visit https://gerrit.wikimedia.org/r/49220 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iebc99859e209529389adc61733a2b318c9452ce1 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Jalexander ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Set 1 hour timeout for entities cached on the client. - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Set 1 hour timeout for entities cached on the client. .. Set 1 hour timeout for entities cached on the client. Change-Id: Ic71ef36042d43c610efcdc4dd400de11adcb6505 --- M lib/includes/store/WikiPageEntityLookup.php 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/48815 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic71ef36042d43c610efcdc4dd400de11adcb6505 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Aude Gerrit-Reviewer: Demon Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Reedy Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "Set 1 hour timeout for entities cached on the client... - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Revert "Set 1 hour timeout for entities cached on the client." .. Revert "Set 1 hour timeout for entities cached on the client." There are several errors after merging this changeset. It could be something specific for my setup, but Toby also gets the errors. The actual errors are as the following There were 5 errors: 1) Wikibase\Test\ChangeHandlerTest::testMergeChanges with data set #2 (array(Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => 1, 'object_id' => 'q1', 'page_id' => 1, 'parent_id' => 0, 'rev_id' => 11, 'revision_id' => 11, 'time' => '20130101010101', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => 2, 'object_id' => 'q1', 'page_id' => 1, 'parent_id' => 11, 'rev_id' => 12, 'revision_id' => 12, 'time' => '20130102020202', 'type' => 'wikibase-item~update', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => 1, 'object_id' => 'q1', 'page_id' => 1, 'parent_id' => 12, 'rev_id' => 13, 'revision_id' => 13, 'time' => '20130103030303', 'type' => 'wikibase-item~update', 'user_id' => 1, 'user_text' => 'User1', )), Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => NULL, 'object_id' => 'q1', 'page_id' => 1, 'parent_id' => 0, 'rev_id' => 13, 'revision_id' => 13, 'time' => '20130103030303', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', )) MWException: Failed to load revision 11 of q1 /home/john/Workspace/Wikibase/client/includes/ChangeHandler.php:152 /home/john/Workspace/Wikibase/client/tests/phpunit/includes/ChangeHandlerTest.php:344 /home/john/Workspace/core/tests/phpunit/MediaWikiTestCase.php:116 /home/john/Workspace/core/tests/phpunit/MediaWikiPHPUnitCommand.php:63 /home/john/Workspace/core/tests/phpunit/MediaWikiPHPUnitCommand.php:47 2) Wikibase\Test\ChangeHandlerTest::testCoalesceRuns with data set #2 (array(Wikibase\ItemChange: array ( 'id' => 1101, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => , 'revision_id' => , 'time' => '20130101010101', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'id' => 1123, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 1112, 'revision_id' => 1112, 'time' => '20130102020202', 'type' => 'wikibase-item~update', 'user_id' => 1, 'user_text' => 'User1', )), array(Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => NULL, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 1112, 'revision_id' => 1112, 'time' => '20130102020202', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', ))) Failed to load revision of q1 [Called from Wikibase\ChangeHandler::coalesceRuns in /home/john/Workspace/Wikibase/client/includes/ChangeHandler.php at line 264] /home/john/Workspace/core/includes/debug/Debug.php:283 /home/john/Workspace/core/includes/debug/Debug.php:144 /home/john/Workspace/core/includes/GlobalFunctions.php:1103 /home/john/Workspace/Wikibase/client/includes/ChangeHandler.php:264 /home/john/Workspace/Wikibase/client/tests/phpunit/includes/ChangeHandlerTest.php:563 /home/john/Workspace/core/tests/phpunit/MediaWikiTestCase.php:116 /home/john/Workspace/core/tests/phpunit/MediaWikiPHPUnitCommand.php:63 /home/john/Workspace/core/tests/phpunit/MediaWikiPHPUnitCommand.php:47 3) Wikibase\Test\ChangeHandlerTest::testCoalesceRuns with data set #4 (array(Wikibase\ItemChange: array ( 'id' => 1101, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => , 'revision_id' => , 'time' => '20130101010101', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'id' => 1123, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 1112, 'revision_id' => 1112, 'time' => '20130102020202', 'type' => 'wikibase-item~update', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'id' => 1135, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 0, 'revision_id' => 0, 'time' => '20130105050505', 'type' => 'wikibase-item~remove', 'user_id' => 1, 'user_text' => 'User1', )), array(Wikibase\ItemChange: array ( 'bot' => 0, 'comment' => 'wikibase-comment-add', 'id' => NULL, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 1112, 'revision_id' => 1112, 'time' => '20130102020202', 'type' => 'wikibase-item~add', 'user_id' => 1, 'user_text' => 'User1', ), Wikibase\ItemChange: array ( 'id' => 1135, 'object_id' => 'q1', 'parent_id' => 0, 'rev_id' => 0, 'revision_id' => 0, 'time' => '20130105050505', 'type' => 'wikibase-item~remove', 'user_id' => 1, 'user_text' => 'User1', ))) Failed to load revision of q1 [Called from Wikibase\ChangeHandler::coalesceR
[MediaWiki-commits] [Gerrit] (minor) added radix parameter to parseInt in inputAutoExpand - change (mediawiki...Wikibase)
Daniel Werner has uploaded a new change for review. https://gerrit.wikimedia.org/r/49222 Change subject: (minor) added radix parameter to parseInt in inputAutoExpand .. (minor) added radix parameter to parseInt in inputAutoExpand Change-Id: I394564bdea37a44ee4af61c14eb895ce3c0b8635 --- M lib/resources/jquery/jquery.inputAutoExpand.js 1 file changed, 25 insertions(+), 24 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/22/49222/1 -- To view, visit https://gerrit.wikimedia.org/r/49222 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I394564bdea37a44ee4af61c14eb895ce3c0b8635 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49223 Change subject: Update formatting .. Update formatting 5 of n. Change-Id: I811ca957b6588085d67606ebc0cd4033a1e53839 --- M tests/phpunit/includes/filerepo/FileRepoTest.php M tests/phpunit/includes/filerepo/StoreBatchTest.php M tests/phpunit/includes/installer/InstallDocFormatterTest.php M tests/phpunit/includes/jobqueue/JobQueueTest.php M tests/phpunit/includes/json/ServicesJsonTest.php M tests/phpunit/includes/libs/CSSJanusTest.php M tests/phpunit/includes/libs/GenericArrayObjectTest.php M tests/phpunit/includes/libs/IEUrlExtensionTest.php M tests/phpunit/includes/libs/JavaScriptMinifierTest.php M tests/phpunit/includes/logging/LogFormatterTest.php M tests/phpunit/includes/logging/LogTests.i18n.php M tests/phpunit/includes/media/BitmapMetadataHandlerTest.php M tests/phpunit/includes/media/BitmapScalingTest.php M tests/phpunit/includes/media/ExifBitmapTest.php M tests/phpunit/includes/media/ExifRotationTest.php M tests/phpunit/includes/media/ExifTest.php M tests/phpunit/includes/media/FormatMetadataTest.php M tests/phpunit/includes/media/GIFMetadataExtractorTest.php M tests/phpunit/includes/media/GIFTest.php M tests/phpunit/includes/media/IPTCTest.php M tests/phpunit/includes/media/JpegMetadataExtractorTest.php M tests/phpunit/includes/media/PNGMetadataExtractorTest.php M tests/phpunit/includes/media/PNGTest.php M tests/phpunit/includes/media/SVGMetadataExtractorTest.php M tests/phpunit/includes/media/XMPTest.php 25 files changed, 214 insertions(+), 167 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/23/49223/1 -- To view, visit https://gerrit.wikimedia.org/r/49223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I811ca957b6588085d67606ebc0cd4033a1e53839 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49224 Change subject: Update formatting .. Update formatting 6 of n. Change-Id: I0ca3f1f72349623631ce1d7f3a4e2ed5edbdbdf4 --- M tests/phpunit/includes/normal/CleanUpTest.php M tests/phpunit/includes/objectcache/BagOStuffTest.php M tests/phpunit/includes/parser/MagicVariableTest.php M tests/phpunit/includes/parser/MediaWikiParserTest.php M tests/phpunit/includes/parser/NewParserTest.php M tests/phpunit/includes/parser/ParserMethodsTest.php M tests/phpunit/includes/parser/ParserPreloadTest.php M tests/phpunit/includes/parser/PreprocessorTest.php M tests/phpunit/includes/parser/TagHooksTest.php M tests/phpunit/includes/search/SearchEngineTest.php M tests/phpunit/includes/site/SiteListTest.php M tests/phpunit/includes/site/SiteTest.php M tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php M tests/phpunit/includes/specials/SpecialRecentchangesTest.php M tests/phpunit/includes/specials/SpecialSearchTest.php 15 files changed, 338 insertions(+), 314 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/24/49224/1 -- To view, visit https://gerrit.wikimedia.org/r/49224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0ca3f1f72349623631ce1d7f3a4e2ed5edbdbdf4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49225 Change subject: Update formatting .. Update formatting 7 of n. Change-Id: I07687a4381f29fd9fc73666e460f25769ed54092 --- M tests/phpunit/languages/LanguageAmTest.php M tests/phpunit/languages/LanguageArTest.php M tests/phpunit/languages/LanguageBeTest.php M tests/phpunit/languages/LanguageBe_taraskTest.php M tests/phpunit/languages/LanguageBhoTest.php M tests/phpunit/languages/LanguageBsTest.php M tests/phpunit/languages/LanguageClassesTestCase.php M tests/phpunit/languages/LanguageCsTest.php M tests/phpunit/languages/LanguageCuTest.php M tests/phpunit/languages/LanguageCyTest.php M tests/phpunit/languages/LanguageDsbTest.php M tests/phpunit/languages/LanguageFrTest.php M tests/phpunit/languages/LanguageGaTest.php M tests/phpunit/languages/LanguageGdTest.php M tests/phpunit/languages/LanguageGvTest.php M tests/phpunit/languages/LanguageHeTest.php M tests/phpunit/languages/LanguageHiTest.php M tests/phpunit/languages/LanguageHrTest.php M tests/phpunit/languages/LanguageHsbTest.php M tests/phpunit/languages/LanguageHuTest.php M tests/phpunit/languages/LanguageHyTest.php M tests/phpunit/languages/LanguageKshTest.php M tests/phpunit/languages/LanguageLnTest.php M tests/phpunit/languages/LanguageLtTest.php M tests/phpunit/languages/LanguageLvTest.php M tests/phpunit/languages/LanguageMgTest.php M tests/phpunit/languages/LanguageMkTest.php M tests/phpunit/languages/LanguageMlTest.php M tests/phpunit/languages/LanguageMoTest.php M tests/phpunit/languages/LanguageMtTest.php M tests/phpunit/languages/LanguageNsoTest.php M tests/phpunit/languages/LanguagePlTest.php M tests/phpunit/languages/LanguageRoTest.php M tests/phpunit/languages/LanguageSeTest.php M tests/phpunit/languages/LanguageSgsTest.php M tests/phpunit/languages/LanguageShTest.php M tests/phpunit/languages/LanguageSkTest.php M tests/phpunit/languages/LanguageSlTest.php M tests/phpunit/languages/LanguageSmaTest.php M tests/phpunit/languages/LanguageSrTest.php M tests/phpunit/languages/LanguageTest.php M tests/phpunit/languages/LanguageTiTest.php M tests/phpunit/languages/LanguageTlTest.php M tests/phpunit/languages/LanguageTrTest.php M tests/phpunit/languages/LanguageUkTest.php M tests/phpunit/languages/LanguageUzTest.php M tests/phpunit/languages/LanguageWaTest.php 47 files changed, 241 insertions(+), 220 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/25/49225/1 -- To view, visit https://gerrit.wikimedia.org/r/49225 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I07687a4381f29fd9fc73666e460f25769ed54092 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49226 Change subject: Update formatting .. Update formatting 8 of n. Change-Id: I1510e7afde5b6b981697d5c0efd7b9507585 --- M tests/phpunit/includes/upload/UploadFromUrlTest.php M tests/phpunit/includes/upload/UploadStashTest.php M tests/phpunit/languages/utils/CLDRPluralRuleEvaluatorTest.php M tests/phpunit/maintenance/DumpTestCase.php M tests/phpunit/maintenance/backupPrefetchTest.php M tests/phpunit/maintenance/backup_LogTest.php M tests/phpunit/phpunit.php M tests/phpunit/resources/ResourcesTest.php M tests/phpunit/suites/ExtensionsTestSuite.php M tests/qunit/data/generateJqueryMsgData.php M tests/qunit/data/qunitOkCall.js M tests/qunit/data/styleTest.css.php M tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js M tests/qunit/suites/resources/jquery/jquery.byteLength.test.js M tests/qunit/suites/resources/jquery/jquery.colorUtil.test.js M tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js M tests/qunit/suites/resources/jquery/jquery.getAttrs.test.js M tests/qunit/suites/resources/jquery/jquery.hidpi.test.js M tests/qunit/suites/resources/jquery/jquery.localize.test.js M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js M tests/selenium/SeleniumConfig.php M tests/selenium/SeleniumTestListener.php M tests/selenium/SeleniumTestSuite.php M tests/selenium/installer/MediaWikiInstallationConfig.php M tests/selenium/installer/MediaWikiInstallationMessage.php M tests/selenium/installer/MediaWikiInstallationVariables.php M tests/selenium/installer/MediaWikiInstallerTestSuite.php M tests/selenium/suites/MediaWikiEditorConfig.php M tests/selenium/suites/MediaWikiExtraTestSuite.php M tests/selenium/suites/MediawikiCoreSmokeTestCase.php M tests/selenium/suites/MediawikiCoreSmokeTestSuite.php M tests/selenium/suites/PageDeleteTestSuite.php M tests/selenium/suites/SimpleSeleniumTestCase.php M tests/selenium/suites/SimpleSeleniumTestSuite.php 35 files changed, 178 insertions(+), 180 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/26/49226/1 -- To view, visit https://gerrit.wikimedia.org/r/49226 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1510e7afde5b6b981697d5c0efd7b9507585 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49227 Change subject: Update formatting .. Update formatting 9 of n. Change-Id: Ide20743a2e84ff68549286120e6cff9d9f396f54 --- M tests/qunit/data/testrunner.js M tests/qunit/suites/resources/jquery/jquery.byteLimit.test.js M tests/qunit/suites/resources/jquery/jquery.client.test.js M tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js M tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js M tests/qunit/suites/resources/jquery/jquery.textSelection.test.js M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js M tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.jscompat.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.user.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js 16 files changed, 1,796 insertions(+), 1,760 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/27/49227/1 -- To view, visit https://gerrit.wikimedia.org/r/49227 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide20743a2e84ff68549286120e6cff9d9f396f54 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49228 Change subject: Update formatting .. Update formatting 10 of n. Change-Id: I9c17088ac063c14544484176daa00272dcd607b8 --- M tests/phpunit/maintenance/backupTextPassTest.php M tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php M tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php M tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php M tests/selenium/installer/MediaWikiInstallationCommonFunction.php M tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php M tests/selenium/installer/MediaWikiUserInterfaceTestCase.php M tests/selenium/suites/AddContentToNewPageTestCase.php M tests/selenium/suites/CreateAccountTestCase.php M tests/selenium/suites/MovePageTestCase.php M tests/selenium/suites/PageSearchTestCase.php M tests/selenium/suites/UserPreferencesTestCase.php M tests/testHelpers.inc 13 files changed, 1,500 insertions(+), 1,585 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/28/49228/1 -- To view, visit https://gerrit.wikimedia.org/r/49228 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c17088ac063c14544484176daa00272dcd607b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/49229 Change subject: Update formatting .. Update formatting 11 of n. Change-Id: Ifdaf198b16bf72e1e0a3d3802c041d239096ae28 --- M tests/phpunit/includes/upload/UploadTest.php M tests/phpunit/maintenance/MaintenanceTest.php M tests/phpunit/maintenance/backup_PageTest.php M tests/phpunit/maintenance/fetchTextTest.php M tests/phpunit/skins/SideBarTest.php M tests/phpunit/suites/UploadFromUrlTestSuite.php M tests/selenium/Selenium.php M tests/selenium/SeleniumServerManager.php M tests/selenium/SeleniumTestCase.php M tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php M tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php M tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php M tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php M tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php M tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php M tests/selenium/installer/MediaWikiRestartInstallationTestCase.php M tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php M tests/selenium/suites/AddNewPageTestCase.php M tests/selenium/suites/DeletePageAdminTestCase.php M tests/selenium/suites/EmailPasswordTestCase.php M tests/selenium/suites/MediaWikiEditorTestSuite.php M tests/selenium/suites/MyContributionsTestCase.php M tests/selenium/suites/MyWatchListTestCase.php M tests/selenium/suites/PreviewPageTestCase.php M tests/selenium/suites/SavePageTestCase.php M tests/selenium/suites/SimpleSeleniumConfig.php 26 files changed, 738 insertions(+), 768 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/29/49229/1 -- To view, visit https://gerrit.wikimedia.org/r/49229 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdaf198b16bf72e1e0a3d3802c041d239096ae28 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update find-entries.php to 2013 - change (mediawiki...code-utils)
Platonides has uploaded a new change for review. https://gerrit.wikimedia.org/r/49230 Change subject: Update find-entries.php to 2013 .. Update find-entries.php to 2013 * Add support for __DIR__ (added in PHP 5.3) * Support RUN_MAINTENANCE_IF_MAIN define, renamed from DO_MAINTENANCE in r80205 (26505b17) Change-Id: I9620ac6371fc2e9016e5d4d97c3c65c2ff4faa75 --- M find-entries.php 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/code-utils refs/changes/30/49230/1 -- To view, visit https://gerrit.wikimedia.org/r/49230 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9620ac6371fc2e9016e5d4d97c3c65c2ff4faa75 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/code-utils Gerrit-Branch: master Gerrit-Owner: Platonides ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apache-sanity-check needs to use new regex to also work on e... - change (operations...wikimedia-task-appserver)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/49231 Change subject: apache-sanity-check needs to use new regex to also work on eqiad Apaches see details in RT-4449 .. apache-sanity-check needs to use new regex to also work on eqiad Apaches see details in RT-4449 Change-Id: I81ee68c97e86512c220406637051dc2c2b0ad9ef --- M apache-sanity-check 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikimedia-task-appserver refs/changes/31/49231/1 -- To view, visit https://gerrit.wikimedia.org/r/49231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I81ee68c97e86512c220406637051dc2c2b0ad9ef Gerrit-PatchSet: 1 Gerrit-Project: operations/debs/wikimedia-task-appserver Gerrit-Branch: master Gerrit-Owner: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Inline documentation for Wikidata's puppet files - change (operations/puppet)
Silke Meyer has uploaded a new change for review. https://gerrit.wikimedia.org/r/49232 Change subject: Inline documentation for Wikidata's puppet files .. Inline documentation for Wikidata's puppet files Change-Id: I7d32eaaa53075d075644d5c17c38dd8d6f85c3a6 --- M manifests/role/labsmediawiki.pp M manifests/wikidata.pp M templates/mediawiki/labs-localsettings M templates/mediawiki/wikidata-client-requires.php 4 files changed, 66 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/32/49232/1 -- To view, visit https://gerrit.wikimedia.org/r/49232 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d32eaaa53075d075644d5c17c38dd8d6f85c3a6 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Silke Meyer ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Lekhani was tested by Subhashish and should be deployed - change (mediawiki...Narayam)
Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/49233 Change subject: Lekhani was tested by Subhashish and should be deployed .. Lekhani was tested by Subhashish and should be deployed Change-Id: If8770a77d9cedc900b275c20e4f796d289b9f49c --- M Narayam.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Narayam refs/changes/33/49233/1 -- To view, visit https://gerrit.wikimedia.org/r/49233 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8770a77d9cedc900b275c20e4f796d289b9f49c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Narayam Gerrit-Branch: master Gerrit-Owner: Amire80 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 5 of n. Change-Id: I811ca957b6588085d67606ebc0cd4033a1e53839 --- M tests/phpunit/includes/filerepo/FileRepoTest.php M tests/phpunit/includes/filerepo/StoreBatchTest.php M tests/phpunit/includes/installer/InstallDocFormatterTest.php M tests/phpunit/includes/jobqueue/JobQueueTest.php M tests/phpunit/includes/json/ServicesJsonTest.php M tests/phpunit/includes/libs/CSSJanusTest.php M tests/phpunit/includes/libs/GenericArrayObjectTest.php M tests/phpunit/includes/libs/IEUrlExtensionTest.php M tests/phpunit/includes/libs/JavaScriptMinifierTest.php M tests/phpunit/includes/logging/LogFormatterTest.php M tests/phpunit/includes/logging/LogTests.i18n.php M tests/phpunit/includes/media/BitmapMetadataHandlerTest.php M tests/phpunit/includes/media/BitmapScalingTest.php M tests/phpunit/includes/media/ExifBitmapTest.php M tests/phpunit/includes/media/ExifRotationTest.php M tests/phpunit/includes/media/ExifTest.php M tests/phpunit/includes/media/FormatMetadataTest.php M tests/phpunit/includes/media/GIFMetadataExtractorTest.php M tests/phpunit/includes/media/GIFTest.php M tests/phpunit/includes/media/IPTCTest.php M tests/phpunit/includes/media/JpegMetadataExtractorTest.php M tests/phpunit/includes/media/PNGMetadataExtractorTest.php M tests/phpunit/includes/media/PNGTest.php M tests/phpunit/includes/media/SVGMetadataExtractorTest.php M tests/phpunit/includes/media/XMPTest.php 25 files changed, 214 insertions(+), 167 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811ca957b6588085d67606ebc0cd4033a1e53839 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Create block log entries on HideUser blocks too - change (mediawiki/core)
Liangent has uploaded a new change for review. https://gerrit.wikimedia.org/r/49234 Change subject: Create block log entries on HideUser blocks too .. Create block log entries on HideUser blocks too When an oversighter HideUser-blocks a user accidentially, it's impossible to restore the visibility of the log entry regarding the block action now as it's in the suppress log page. With this patch a block log entry is created (and hidden) too, which can be unhidden when needed. Change-Id: I0d5e20a91636952811dcc3b953e89780e0742c56 --- M includes/specials/SpecialBlock.php 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/34/49234/1 -- To view, visit https://gerrit.wikimedia.org/r/49234 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d5e20a91636952811dcc3b953e89780e0742c56 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Liangent ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 6 of n. Change-Id: I0ca3f1f72349623631ce1d7f3a4e2ed5edbdbdf4 --- M tests/phpunit/includes/normal/CleanUpTest.php M tests/phpunit/includes/objectcache/BagOStuffTest.php M tests/phpunit/includes/parser/MagicVariableTest.php M tests/phpunit/includes/parser/MediaWikiParserTest.php M tests/phpunit/includes/parser/NewParserTest.php M tests/phpunit/includes/parser/ParserMethodsTest.php M tests/phpunit/includes/parser/ParserPreloadTest.php M tests/phpunit/includes/parser/PreprocessorTest.php M tests/phpunit/includes/parser/TagHooksTest.php M tests/phpunit/includes/search/SearchEngineTest.php M tests/phpunit/includes/site/SiteListTest.php M tests/phpunit/includes/site/SiteTest.php M tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php M tests/phpunit/includes/specials/SpecialRecentchangesTest.php M tests/phpunit/includes/specials/SpecialSearchTest.php 15 files changed, 338 insertions(+), 314 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ca3f1f72349623631ce1d7f3a4e2ed5edbdbdf4 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 44960) Job returns Status instead of bool - change (mediawiki...ArticleFeedbackv5)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/49235 Change subject: (bug 44960) Job returns Status instead of bool .. (bug 44960) Job returns Status instead of bool Change-Id: I176813196fa300d92bc0f2ba753bc2808269eae7 --- M ArticleFeedbackv5MailerJob.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 refs/changes/35/49235/1 -- To view, visit https://gerrit.wikimedia.org/r/49235 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I176813196fa300d92bc0f2ba753bc2808269eae7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Matthias Mullie ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 7 of n. Change-Id: I07687a4381f29fd9fc73666e460f25769ed54092 --- M tests/phpunit/languages/LanguageAmTest.php M tests/phpunit/languages/LanguageArTest.php M tests/phpunit/languages/LanguageBeTest.php M tests/phpunit/languages/LanguageBe_taraskTest.php M tests/phpunit/languages/LanguageBhoTest.php M tests/phpunit/languages/LanguageBsTest.php M tests/phpunit/languages/LanguageClassesTestCase.php M tests/phpunit/languages/LanguageCsTest.php M tests/phpunit/languages/LanguageCuTest.php M tests/phpunit/languages/LanguageCyTest.php M tests/phpunit/languages/LanguageDsbTest.php M tests/phpunit/languages/LanguageFrTest.php M tests/phpunit/languages/LanguageGaTest.php M tests/phpunit/languages/LanguageGdTest.php M tests/phpunit/languages/LanguageGvTest.php M tests/phpunit/languages/LanguageHeTest.php M tests/phpunit/languages/LanguageHiTest.php M tests/phpunit/languages/LanguageHrTest.php M tests/phpunit/languages/LanguageHsbTest.php M tests/phpunit/languages/LanguageHuTest.php M tests/phpunit/languages/LanguageHyTest.php M tests/phpunit/languages/LanguageKshTest.php M tests/phpunit/languages/LanguageLnTest.php M tests/phpunit/languages/LanguageLtTest.php M tests/phpunit/languages/LanguageLvTest.php M tests/phpunit/languages/LanguageMgTest.php M tests/phpunit/languages/LanguageMkTest.php M tests/phpunit/languages/LanguageMlTest.php M tests/phpunit/languages/LanguageMoTest.php M tests/phpunit/languages/LanguageMtTest.php M tests/phpunit/languages/LanguageNsoTest.php M tests/phpunit/languages/LanguagePlTest.php M tests/phpunit/languages/LanguageRoTest.php M tests/phpunit/languages/LanguageSeTest.php M tests/phpunit/languages/LanguageSgsTest.php M tests/phpunit/languages/LanguageShTest.php M tests/phpunit/languages/LanguageSkTest.php M tests/phpunit/languages/LanguageSlTest.php M tests/phpunit/languages/LanguageSmaTest.php M tests/phpunit/languages/LanguageSrTest.php M tests/phpunit/languages/LanguageTest.php M tests/phpunit/languages/LanguageTiTest.php M tests/phpunit/languages/LanguageTlTest.php M tests/phpunit/languages/LanguageTrTest.php M tests/phpunit/languages/LanguageUkTest.php M tests/phpunit/languages/LanguageUzTest.php M tests/phpunit/languages/LanguageWaTest.php 47 files changed, 241 insertions(+), 220 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49225 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07687a4381f29fd9fc73666e460f25769ed54092 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 8 of n. Change-Id: I1510e7afde5b6b981697d5c0efd7b9507585 --- M tests/phpunit/includes/upload/UploadFromUrlTest.php M tests/phpunit/includes/upload/UploadStashTest.php M tests/phpunit/languages/utils/CLDRPluralRuleEvaluatorTest.php M tests/phpunit/maintenance/DumpTestCase.php M tests/phpunit/maintenance/backupPrefetchTest.php M tests/phpunit/maintenance/backup_LogTest.php M tests/phpunit/phpunit.php M tests/phpunit/resources/ResourcesTest.php M tests/phpunit/suites/ExtensionsTestSuite.php M tests/qunit/data/generateJqueryMsgData.php M tests/qunit/data/qunitOkCall.js M tests/qunit/data/styleTest.css.php M tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js M tests/qunit/suites/resources/jquery/jquery.byteLength.test.js M tests/qunit/suites/resources/jquery/jquery.colorUtil.test.js M tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js M tests/qunit/suites/resources/jquery/jquery.getAttrs.test.js M tests/qunit/suites/resources/jquery/jquery.hidpi.test.js M tests/qunit/suites/resources/jquery/jquery.localize.test.js M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.parse.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.language.test.js M tests/selenium/SeleniumConfig.php M tests/selenium/SeleniumTestListener.php M tests/selenium/SeleniumTestSuite.php M tests/selenium/installer/MediaWikiInstallationConfig.php M tests/selenium/installer/MediaWikiInstallationMessage.php M tests/selenium/installer/MediaWikiInstallationVariables.php M tests/selenium/installer/MediaWikiInstallerTestSuite.php M tests/selenium/suites/MediaWikiEditorConfig.php M tests/selenium/suites/MediaWikiExtraTestSuite.php M tests/selenium/suites/MediawikiCoreSmokeTestCase.php M tests/selenium/suites/MediawikiCoreSmokeTestSuite.php M tests/selenium/suites/PageDeleteTestSuite.php M tests/selenium/suites/SimpleSeleniumTestCase.php M tests/selenium/suites/SimpleSeleniumTestSuite.php 35 files changed, 178 insertions(+), 180 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49226 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1510e7afde5b6b981697d5c0efd7b9507585 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: Mattflaschen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 9 of n. Change-Id: Ide20743a2e84ff68549286120e6cff9d9f396f54 --- M tests/qunit/data/testrunner.js M tests/qunit/suites/resources/jquery/jquery.byteLimit.test.js M tests/qunit/suites/resources/jquery/jquery.client.test.js M tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js M tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js M tests/qunit/suites/resources/jquery/jquery.textSelection.test.js M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js M tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.jscompat.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.user.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js 16 files changed, 1,796 insertions(+), 1,760 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49227 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide20743a2e84ff68549286120e6cff9d9f396f54 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: Mattflaschen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Return boolean from status object. - change (mediawiki/core)
Nischayn22 has uploaded a new change for review. https://gerrit.wikimedia.org/r/49236 Change subject: Return boolean from status object. .. Return boolean from status object. Change-Id: I37e4c37423f16bee6342ffce02383db251d900cd --- M includes/job/jobs/EmaillingJob.php 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/36/49236/1 -- To view, visit https://gerrit.wikimedia.org/r/49236 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37e4c37423f16bee6342ffce02383db251d900cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Nischayn22 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 10 of n. Change-Id: I9c17088ac063c14544484176daa00272dcd607b8 --- M tests/phpunit/maintenance/backupTextPassTest.php M tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php M tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php M tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php M tests/selenium/installer/MediaWikiInstallationCommonFunction.php M tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php M tests/selenium/installer/MediaWikiUserInterfaceTestCase.php M tests/selenium/suites/AddContentToNewPageTestCase.php M tests/selenium/suites/CreateAccountTestCase.php M tests/selenium/suites/MovePageTestCase.php M tests/selenium/suites/PageSearchTestCase.php M tests/selenium/suites/UserPreferencesTestCase.php M tests/testHelpers.inc 13 files changed, 1,500 insertions(+), 1,585 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49228 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c17088ac063c14544484176daa00272dcd607b8 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update formatting - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Update formatting .. Update formatting 11 of n. Change-Id: Ifdaf198b16bf72e1e0a3d3802c041d239096ae28 --- M tests/phpunit/includes/upload/UploadTest.php M tests/phpunit/maintenance/MaintenanceTest.php M tests/phpunit/maintenance/backup_PageTest.php M tests/phpunit/maintenance/fetchTextTest.php M tests/phpunit/skins/SideBarTest.php M tests/phpunit/suites/UploadFromUrlTestSuite.php M tests/selenium/Selenium.php M tests/selenium/SeleniumServerManager.php M tests/selenium/SeleniumTestCase.php M tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php M tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php M tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php M tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php M tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php M tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php M tests/selenium/installer/MediaWikiRestartInstallationTestCase.php M tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php M tests/selenium/suites/AddNewPageTestCase.php M tests/selenium/suites/DeletePageAdminTestCase.php M tests/selenium/suites/EmailPasswordTestCase.php M tests/selenium/suites/MediaWikiEditorTestSuite.php M tests/selenium/suites/MyContributionsTestCase.php M tests/selenium/suites/MyWatchListTestCase.php M tests/selenium/suites/PreviewPageTestCase.php M tests/selenium/suites/SavePageTestCase.php M tests/selenium/suites/SimpleSeleniumConfig.php 26 files changed, 738 insertions(+), 768 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49229 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdaf198b16bf72e1e0a3d3802c041d239096ae28 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand Gerrit-Reviewer: IAlex Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] redirect wikimediafoundation.info -> wmfwiki - change (operations/apache-config)
Dzahn has submitted this change and it was merged. Change subject: redirect wikimediafoundation.info -> wmfwiki .. redirect wikimediafoundation.info -> wmfwiki RT: #3542 Change-Id: Id2554bb4101c99cba599305760f3b0bc40075518 --- M redirects.conf 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Dzahn: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49194 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2554bb4101c99cba599305760f3b0bc40075518 Gerrit-PatchSet: 4 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Jeremyb Gerrit-Reviewer: Dzahn Gerrit-Reviewer: Jeremyb Gerrit-Reviewer: Lcarr Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: Thehelpfulone ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [SpellingApi] Register extension - change (translatewiki)
Raimond Spekking has uploaded a new change for review. https://gerrit.wikimedia.org/r/49237 Change subject: [SpellingApi] Register extension .. [SpellingApi] Register extension Change-Id: If8ab965875a77cd1063788869bdab73d579ead0c --- M groups/MediaWiki/mediawiki-defines.txt 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/translatewiki refs/changes/37/49237/1 -- To view, visit https://gerrit.wikimedia.org/r/49237 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8ab965875a77cd1063788869bdab73d579ead0c Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [SpellingApi] Register extension - change (translatewiki)
Raimond Spekking has submitted this change and it was merged. Change subject: [SpellingApi] Register extension .. [SpellingApi] Register extension Change-Id: If8ab965875a77cd1063788869bdab73d579ead0c --- M groups/MediaWiki/mediawiki-defines.txt 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Raimond Spekking: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49237 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ab965875a77cd1063788869bdab73d579ead0c Gerrit-PatchSet: 1 Gerrit-Project: translatewiki Gerrit-Branch: master Gerrit-Owner: Raimond Spekking Gerrit-Reviewer: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41163, 44165, 44166) autocomments for claims. - change (mediawiki...Wikibase)
Daniel Kinzler has uploaded a new change for review. https://gerrit.wikimedia.org/r/49238 Change subject: (bug 41163, 44165, 44166) autocomments for claims. .. (bug 41163, 44165, 44166) autocomments for claims. This adds autocomments when claims get added or removed, or their main snak is changed. Caveat: When removing or changing a claim, the claim ID (GUID) is shown in the summary. That is not very helpful. To changes this, some refactoring is needed - this is already in the pipeline. Change-Id: I0fd1ea5f98d3ee814f11ad57ece6911e1bdc2ff2 --- M repo/Wikibase.i18n.php M repo/Wikibase.php M repo/includes/api/ApiCreateClaim.php A repo/includes/api/ApiModifyClaim.php M repo/includes/api/ApiRemoveClaims.php M repo/includes/api/ApiSetClaimValue.php 6 files changed, 301 insertions(+), 367 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/38/49238/1 -- To view, visit https://gerrit.wikimedia.org/r/49238 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0fd1ea5f98d3ee814f11ad57ece6911e1bdc2ff2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [BagOStuff] De-breakified cas() for SqlBagOStuff. - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: [BagOStuff] De-breakified cas() for SqlBagOStuff. .. [BagOStuff] De-breakified cas() for SqlBagOStuff. * Seemed to be a functional merge conflict with sharding code. Change-Id: I1e49790f6b82b09ea2cd6606ca918f0a620a191f --- M includes/objectcache/SqlBagOStuff.php 1 file changed, 18 insertions(+), 16 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49203 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e49790f6b82b09ea2cd6606ca918f0a620a191f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: IAlex Gerrit-Reviewer: Tim Starling Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] $wgOpenIDConsumerForce as an OpenIDProvider for parameterize... - change (mediawiki...OpenID)
UnwashedMeme has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49239
Change subject: $wgOpenIDConsumerForce as an OpenIDProvider for parameterized
identities
..
$wgOpenIDConsumerForce as an OpenIDProvider for parameterized identities
The goal here is to have a wiki be an OpenID consumer that forces the
use of a single openid provider, but that provider requires
parameterized identity urls.
You can now specify:
`$wgOpenIDConsumerForce = new OpenIDProvider('wp',
'a-wordpress.com', 'Your Wordpress Username',
'http://a-wordpress-site.com/author/{username}/' );`
Previously if $wgOpenIDConsumerForce was specified it would skip the
login form entirely; this behaviour is preserved when
$wgOpenIDConsumerForce is a string.
Now, when $wgOpenIDConsumerForce is an OpenIDProvider object, it will
display a login form rendering that OpenIDProvider. This takes
advantage of the existing logic that creates a text input for
parameterized urls (ones with '{...}' in them). In this case none of
the other large or small providers are displayed--this maintains the
sense of that variable forcing a single provider.
The javascript on the login form is adjusted to handle that the
OpenIDProvider 'openid' is no longer guaranteed to be on the login
form.
Instead of rendering the 'openid' provider differently, treat it like
the others and always add a hidden input 'openid_url' that the JS
fills.
Change-Id: Ie2f0974d630a7ff25004e77cc6cdb13a0f52acac
---
M OpenIDProvider.body.php
M README.OpenID-mediawiki-extension
M SpecialOpenID.body.php
M SpecialOpenIDLogin.body.php
M skin/openid.js
5 files changed, 126 insertions(+), 64 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenID
refs/changes/39/49239/1
--
To view, visit https://gerrit.wikimedia.org/r/49239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2f0974d630a7ff25004e77cc6cdb13a0f52acac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenID
Gerrit-Branch: master
Gerrit-Owner: UnwashedMeme
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Advanced Solr monitoring script - change (operations/puppet)
Dzahn has submitted this change and it was merged. Change subject: Advanced Solr monitoring script .. Advanced Solr monitoring script Change-Id: I769f834fdb3d4ebd010452dfe7bba9ba60069431 --- A files/nagios/check_solr 1 file changed, 197 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/47111 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I769f834fdb3d4ebd010452dfe7bba9ba60069431 Gerrit-PatchSet: 4 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: MaxSem Gerrit-Reviewer: Dzahn Gerrit-Reviewer: MaxSem Gerrit-Reviewer: Pyoungmeister Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] New collation: zh-zhuyin (bopomofo). - change (mediawiki/core)
Liangent has uploaded a new change for review. https://gerrit.wikimedia.org/r/49240 Change subject: New collation: zh-zhuyin (bopomofo). .. New collation: zh-zhuyin (bopomofo). This requires ICU 50 to work. As of the time of writing this commit, it's not in Ubuntu or Debian package repository and I don't bother to install it manually, so I didn't really test this code in real world (just looked at icu code when coding). It would be better not merge this now. This can be a demonstration of adding a new collation. Change-Id: I82c8f8042acf55969bd60bc45193fc0600cc14b8 --- M RELEASE-NOTES-1.21 M includes/Collation.php M languages/messages/MessagesEn.php M maintenance/language/generateCollationDataZh.php M maintenance/language/messages.inc A serialized/first-letters-zh@collation=zhuyin.ser 6 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/40/49240/1 -- To view, visit https://gerrit.wikimedia.org/r/49240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I82c8f8042acf55969bd60bc45193fc0600cc14b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Liangent Gerrit-Reviewer: Siebrand ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] sync mediawiki only in production - change (operations/puppet)
Dzahn has submitted this change and it was merged. Change subject: sync mediawiki only in production .. sync mediawiki only in production beta does not use rsync AT ALL, so only update MediaWiki files in production. In beta fake the sync process to bring up apache which is not started on machine boot (bug 38996). Change-Id: If46a997d63363a869b4569c2f32484eab58f0626 --- M modules/applicationserver/manifests/config/apache.pp 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/47398 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If46a997d63363a869b4569c2f32484eab58f0626 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar Gerrit-Reviewer: Dzahn Gerrit-Reviewer: Faidon Gerrit-Reviewer: Hashar Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix ChangeHandler and ChangeHandlerTest. - change (mediawiki...Wikibase)
Daniel Kinzler has uploaded a new change for review. https://gerrit.wikimedia.org/r/49241 Change subject: Fix ChangeHandler and ChangeHandlerTest. .. Fix ChangeHandler and ChangeHandlerTest. Test handling of missing revisions, removing debugging code (oops!). Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c --- M client/includes/ChangeHandler.php M client/tests/phpunit/includes/ChangeHandlerTest.php 2 files changed, 45 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/41/49241/1 -- To view, visit https://gerrit.wikimedia.org/r/49241 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] triggers for operations-apache-config-lint - change (integration/zuul-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/49242 Change subject: triggers for operations-apache-config-lint .. triggers for operations-apache-config-lint Change-Id: I2dcfd30e18b0fc94e645034f1cc67fc80297832c --- M layout.yaml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config refs/changes/42/49242/1 -- To view, visit https://gerrit.wikimedia.org/r/49242 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2dcfd30e18b0fc94e645034f1cc67fc80297832c Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] triggers for operations-apache-config-lint - change (integration/zuul-config)
Hashar has submitted this change and it was merged. Change subject: triggers for operations-apache-config-lint .. triggers for operations-apache-config-lint Change-Id: I2dcfd30e18b0fc94e645034f1cc67fc80297832c --- M layout.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49242 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dcfd30e18b0fc94e645034f1cc67fc80297832c Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Jenkins job validation (DO NOT SUBMIT) - change (operations/apache-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/49243 Change subject: Jenkins job validation (DO NOT SUBMIT) .. Jenkins job validation (DO NOT SUBMIT) Change-Id: Ib84c284c8eccba81a85b8177c327722d5890feb1 --- A JENKINS 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/43/49243/1 -- To view, visit https://gerrit.wikimedia.org/r/49243 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib84c284c8eccba81a85b8177c327722d5890feb1 Gerrit-PatchSet: 1 Gerrit-Project: operations/apache-config Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rename Selection interface to SelectionRequest - change (mediawiki...Ask)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49244 Change subject: Rename Selection interface to SelectionRequest .. Rename Selection interface to SelectionRequest Change-Id: Ic46d9d5d4fe0ecbd264efdb0763c49c185ebf9b6 --- M Ask.classes.php M Ask.mw.php M includes/language/Query.php M includes/language/selection/PropertySelection.php R includes/language/selection/SelectionRequest.php M includes/language/selection/SubjectSelection.php M tests/phpunit/language/QueryTest.php M tests/phpunit/language/selection/PropertySelectionTest.php R tests/phpunit/language/selection/SelectionRequestTest.php M tests/phpunit/language/selection/SubjectSelectionTest.php 10 files changed, 21 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/44/49244/1 -- To view, visit https://gerrit.wikimedia.org/r/49244 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic46d9d5d4fe0ecbd264efdb0763c49c185ebf9b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix ChangeHandler and ChangeHandlerTest. - change (mediawiki...Wikibase)
Aude has submitted this change and it was merged. Change subject: Fix ChangeHandler and ChangeHandlerTest. .. Fix ChangeHandler and ChangeHandlerTest. Test handling of missing revisions, removing debugging code (oops!). Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c --- M client/includes/ChangeHandler.php M client/tests/phpunit/includes/ChangeHandlerTest.php 2 files changed, 45 insertions(+), 9 deletions(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49241 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Aude Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix message parsing on the client in wbclient.linkItem - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Fix message parsing on the client in wbclient.linkItem .. Fix message parsing on the client in wbclient.linkItem No longer use the shorthand mw.msg for messages which need to be parsed to html. Change-Id: Ide49248e27dcb3744661893bd1b2a1ec9839df23 --- M client/resources/wbclient.linkItem.js 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/48985 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide49248e27dcb3744661893bd1b2a1ec9839df23 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Hoo man Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update 'recheck' regexp - change (integration/zuul-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/49245 Change subject: update 'recheck' regexp .. update 'recheck' regexp The new Gerrit automatically insert the current patchset # before the user comment. We thus have to slightly update the regex rule. Change-Id: I4125f0dde2cc28c1a7b204a3982953b0b2adba8e --- M layout.yaml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config refs/changes/45/49245/1 -- To view, visit https://gerrit.wikimedia.org/r/49245 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4125f0dde2cc28c1a7b204a3982953b0b2adba8e Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix ChangeHandler and ChangeHandlerTest. - change (mediawiki...Wikibase)
Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/49246 Change subject: Fix ChangeHandler and ChangeHandlerTest. .. Fix ChangeHandler and ChangeHandlerTest. Test handling of missing revisions, removing debugging code (oops!). Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c --- M client/includes/ChangeHandler.php M client/tests/phpunit/includes/ChangeHandlerTest.php 2 files changed, 45 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/46/49246/1 -- To view, visit https://gerrit.wikimedia.org/r/49246 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.21-wmf10 Gerrit-Owner: Aude Gerrit-Reviewer: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update 'recheck' regexp - change (integration/zuul-config)
Hashar has submitted this change and it was merged. Change subject: update 'recheck' regexp .. update 'recheck' regexp The new Gerrit automatically insert the current patchset # before the user comment. We thus have to slightly update the regex rule. Change-Id: I4125f0dde2cc28c1a7b204a3982953b0b2adba8e --- M layout.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49245 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4125f0dde2cc28c1a7b204a3982953b0b2adba8e Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Demon Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow SPR-0 - change (mediawiki...Ask)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/49247 Change subject: Follow SPR-0 .. Follow SPR-0 Change-Id: I3a3d657e972d8750699dd142aaf87eb4fbaca279 --- M Ask.classes.php M Ask.mw.php R includes/Ask/Immutable.php R includes/Ask/Language/Description/AnyValue.php R includes/Ask/Language/Description/Conjunction.php R includes/Ask/Language/Description/Description.php R includes/Ask/Language/Description/DescriptionCollection.php R includes/Ask/Language/Description/Disjunction.php R includes/Ask/Language/Description/SomeProperty.php R includes/Ask/Language/Description/ValueDescription.php R includes/Ask/Language/Option/PropertyValueSortExpression.php R includes/Ask/Language/Option/QueryOptions.php R includes/Ask/Language/Option/SortExpression.php R includes/Ask/Language/Option/SortOptions.php R includes/Ask/Language/Query.php R includes/Ask/Language/Selection/PropertySelection.php R includes/Ask/Language/Selection/SelectionRequest.php R includes/Ask/Language/Selection/SubjectSelection.php R tests/phpunit/Language/Description/AnyValueTest.php R tests/phpunit/Language/Description/ConjunctionTest.php R tests/phpunit/Language/Description/DescriptionTest.php R tests/phpunit/Language/Description/DisjunctionTest.php R tests/phpunit/Language/Description/SomePropertyTest.php R tests/phpunit/Language/Description/ValueDescriptionTest.php R tests/phpunit/Language/QueryTest.php R tests/phpunit/Language/Selection/PropertySelectionTest.php R tests/phpunit/Language/Selection/SelectionRequestTest.php R tests/phpunit/Language/Selection/SubjectSelectionTest.php 28 files changed, 43 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask refs/changes/47/49247/1 -- To view, visit https://gerrit.wikimedia.org/r/49247 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a3d657e972d8750699dd142aaf87eb4fbaca279 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rename Selection interface to SelectionRequest - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Rename Selection interface to SelectionRequest .. Rename Selection interface to SelectionRequest Change-Id: Ic46d9d5d4fe0ecbd264efdb0763c49c185ebf9b6 --- M Ask.classes.php M Ask.mw.php M includes/language/Query.php M includes/language/selection/PropertySelection.php R includes/language/selection/SelectionRequest.php M includes/language/selection/SubjectSelection.php M tests/phpunit/language/QueryTest.php M tests/phpunit/language/selection/PropertySelectionTest.php R tests/phpunit/language/selection/SelectionRequestTest.php M tests/phpunit/language/selection/SubjectSelectionTest.php 10 files changed, 21 insertions(+), 21 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49244 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic46d9d5d4fe0ecbd264efdb0763c49c185ebf9b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow SPR-0 - change (mediawiki...Ask)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Follow SPR-0 .. Follow SPR-0 Change-Id: I3a3d657e972d8750699dd142aaf87eb4fbaca279 --- M Ask.classes.php M Ask.mw.php R includes/Ask/Immutable.php R includes/Ask/Language/Description/AnyValue.php R includes/Ask/Language/Description/Conjunction.php R includes/Ask/Language/Description/Description.php R includes/Ask/Language/Description/DescriptionCollection.php R includes/Ask/Language/Description/Disjunction.php R includes/Ask/Language/Description/SomeProperty.php R includes/Ask/Language/Description/ValueDescription.php R includes/Ask/Language/Option/PropertyValueSortExpression.php R includes/Ask/Language/Option/QueryOptions.php R includes/Ask/Language/Option/SortExpression.php R includes/Ask/Language/Option/SortOptions.php R includes/Ask/Language/Query.php R includes/Ask/Language/Selection/PropertySelection.php R includes/Ask/Language/Selection/SelectionRequest.php R includes/Ask/Language/Selection/SubjectSelection.php R tests/phpunit/Language/Description/AnyValueTest.php R tests/phpunit/Language/Description/ConjunctionTest.php R tests/phpunit/Language/Description/DescriptionTest.php R tests/phpunit/Language/Description/DisjunctionTest.php R tests/phpunit/Language/Description/SomePropertyTest.php R tests/phpunit/Language/Description/ValueDescriptionTest.php R tests/phpunit/Language/QueryTest.php R tests/phpunit/Language/Selection/PropertySelectionTest.php R tests/phpunit/Language/Selection/SelectionRequestTest.php R tests/phpunit/Language/Selection/SubjectSelectionTest.php 28 files changed, 43 insertions(+), 28 deletions(-) Approvals: Jeroen De Dauw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49247 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a3d657e972d8750699dd142aaf87eb4fbaca279 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw Gerrit-Reviewer: Jeroen De Dauw ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make wbclient.linkItem more user friendly - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Make wbclient.linkItem more user friendly .. Make wbclient.linkItem more user friendly Changes: 1. The item the page links goes from is now linked when conforming page links 2. A meaningful error is shown at an early stage if the page the user wants to link to is already linked with an item having a link to a local page 3. Some minor improvements and removals of old temporary code This breaks backwards compatiblity on the client but that doesn't matter as all that isn't used in production anywhere yet. Change-Id: I60278018d749d3bba0debb201d2df23fa9e5b9bc --- M client/WikibaseClient.i18n.php M client/resources/Resources.php M client/resources/wbclient.linkItem.css M client/resources/wbclient.linkItem.js M lib/includes/modules/RepoAccessModule.php M lib/resources/wikibase.store/wikibase.RepoApi.js 6 files changed, 64 insertions(+), 33 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/48997 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60278018d749d3bba0debb201d2df23fa9e5b9bc Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Hoo man Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: Hoo man Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Tobias Gritschacher ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Document configuration settings. - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Document configuration settings. .. Document configuration settings. This also removes some unused settings and fixes some defaults. Change-Id: Iae9256f4e0b0e5f7c6c34d2af9643cfff69c4a2b --- M client/config/WikibaseClient.default.php M client/includes/SortUtils.php M client/includes/store/ClientStoreFactory.php A docs/options.wiki M repo/config/Wikibase.default.php 5 files changed, 100 insertions(+), 19 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49030 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae9256f4e0b0e5f7c6c34d2af9643cfff69c4a2b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler Gerrit-Reviewer: Anja Jentzsch Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Kinzler Gerrit-Reviewer: Denny Vrandecic Gerrit-Reviewer: Jeroen De Dauw Gerrit-Reviewer: John Erling Blad Gerrit-Reviewer: Silke Meyer ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix ChangeHandler and ChangeHandlerTest. - change (mediawiki...Wikibase)
Aude has submitted this change and it was merged. Change subject: Fix ChangeHandler and ChangeHandlerTest. .. Fix ChangeHandler and ChangeHandlerTest. Test handling of missing revisions, removing debugging code (oops!). Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c --- M client/includes/ChangeHandler.php M client/tests/phpunit/includes/ChangeHandlerTest.php 2 files changed, 45 insertions(+), 9 deletions(-) Approvals: Aude: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49246 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7cdded7a71c9255da6bf20d3cf6ef7596110f5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.21-wmf10 Gerrit-Owner: Aude Gerrit-Reviewer: Aude Gerrit-Reviewer: Daniel Kinzler ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 44744) copyright warning now using its own message inst... - change (mediawiki...Wikibase)
Daniel Werner has uploaded a new change for review. https://gerrit.wikimedia.org/r/49248 Change subject: (bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning .. (bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning Since the 'EditPageCopyrightWarning' is not suitable (without adjustments) to cover the needs of the wikidata short copyright message, we introduce our own message in wikibase for this. Change-Id: I0a8328fbb50a8209fe9799f692898eccca378840 --- M repo/Wikibase.i18n.php M repo/includes/EntityView.php M repo/resources/wikibase.ui.entityViewInit.js 3 files changed, 19 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/48/49248/1 -- To view, visit https://gerrit.wikimedia.org/r/49248 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a8328fbb50a8209fe9799f692898eccca378840 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update ALL 'recheck' regexp - change (integration/zuul-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/49249 Change subject: update ALL 'recheck' regexp .. update ALL 'recheck' regexp Turns out we have several 'check' pipelines. Change-Id: I0347c1233842cd5a27f7a96f93ac97c301fb1af0 --- M layout.yaml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/zuul-config refs/changes/49/49249/1 -- To view, visit https://gerrit.wikimedia.org/r/49249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0347c1233842cd5a27f7a96f93ac97c301fb1af0 Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update ALL 'recheck' regexp - change (integration/zuul-config)
Hashar has submitted this change and it was merged. Change subject: update ALL 'recheck' regexp .. update ALL 'recheck' regexp Turns out we have several 'check' pipelines. Change-Id: I0347c1233842cd5a27f7a96f93ac97c301fb1af0 --- M layout.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0347c1233842cd5a27f7a96f93ac97c301fb1af0 Gerrit-PatchSet: 1 Gerrit-Project: integration/zuul-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Solr monitoring fixes - change (operations/puppet)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/49250 Change subject: Solr monitoring fixes .. Solr monitoring fixes Change-Id: I26623d180e767f7536b393183ffebbc671a06352 --- M files/nagios/check_solr M manifests/nagios.pp M manifests/role/solr.pp 3 files changed, 19 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/50/49250/1 -- To view, visit https://gerrit.wikimedia.org/r/49250 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I26623d180e767f7536b393183ffebbc671a06352 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: MaxSem ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) Define supports0Height in inputAutoExpand before it ... - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: (minor) Define supports0Height in inputAutoExpand before it is first used. .. (minor) Define supports0Height in inputAutoExpand before it is first used. Also added radix parameter to parseInt in inputAutoExpand Change-Id: I394564bdea37a44ee4af61c14eb895ce3c0b8635 --- M lib/resources/jquery/jquery.inputAutoExpand.js 1 file changed, 25 insertions(+), 24 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49222 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I394564bdea37a44ee4af61c14eb895ce3c0b8635 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Setting up sync from HDFS /wmf/public directory to stat1001 ... - change (operations/puppet)
Ottomata has submitted this change and it was merged. Change subject: Setting up sync from HDFS /wmf/public directory to stat1001 stats.wikimedia.org site. .. Setting up sync from HDFS /wmf/public directory to stat1001 stats.wikimedia.org site. This is intended to be a temporary measure to allow visualization of data generated by kraken. Change-Id: I28854487c6000e336c5d6cf352c23ae798fa973c --- A manifests/misc/analytics.pp M manifests/misc/statistics.pp M manifests/site.pp 3 files changed, 36 insertions(+), 1 deletion(-) Approvals: Ottomata: Faidon: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49074 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28854487c6000e336c5d6cf352c23ae798fa973c Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata Gerrit-Reviewer: Faidon Gerrit-Reviewer: Ottomata Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] linter for our Apache configurations - change (integration/jenkins-job-builder-config)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/49251 Change subject: linter for our Apache configurations .. linter for our Apache configurations Our infamous apache configuration can be subject to various typo and mistakes. This patch use the apache linter to load operations/apache-config.git files based on the document root provided by operations/mediawiki-config.git Using the apache -C option, one can pass extra configuration arguments such as loading some generic configuration files. Whenever apache -t detect a syntax error, the build will fail. Change-Id: I3ddf2fd384b2212773922d7dd980940db055498e --- A operations-apache-config.yaml 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config refs/changes/51/49251/1 -- To view, visit https://gerrit.wikimedia.org/r/49251 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ddf2fd384b2212773922d7dd980940db055498e Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Test for GuidedTour checks for GT lightbox - change (qa/browsertests)
Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/49252 Change subject: Test for GuidedTour checks for GT lightbox .. Test for GuidedTour checks for GT lightbox Change-Id: I6283ad6f4dce5153cfe969ae181141148ad28fa6 --- A features/guided_tour.feature A features/step_definitions/guided_tour_steps.rb A features/support/pages/tour_page.rb 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/52/49252/1 -- To view, visit https://gerrit.wikimedia.org/r/49252 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6283ad6f4dce5153cfe969ae181141148ad28fa6 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Test for GuidedTour checks for GT lightbox - change (qa/browsertests)
Zfilipin has submitted this change and it was merged. Change subject: Test for GuidedTour checks for GT lightbox .. Test for GuidedTour checks for GT lightbox Change-Id: I6283ad6f4dce5153cfe969ae181141148ad28fa6 --- A features/guided_tour.feature A features/step_definitions/guided_tour_steps.rb A features/support/pages/tour_page.rb 3 files changed, 22 insertions(+), 0 deletions(-) Approvals: Zfilipin: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49252 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6283ad6f4dce5153cfe969ae181141148ad28fa6 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon Gerrit-Reviewer: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert "Revert "Set 1 hour timeout for entities cached on th... - change (mediawiki...Wikibase)
John Erling Blad has submitted this change and it was merged. Change subject: Revert "Revert "Set 1 hour timeout for entities cached on the client."" .. Revert "Revert "Set 1 hour timeout for entities cached on the client."" This reverts commit 1e8fc237dfd1c3056db5e596a6d540c81ad6a947 Change-Id: Ibc9c92cad1d6ed56ba5d24d4c1c05a36d5ffc7f5 --- M lib/includes/store/WikiPageEntityLookup.php 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49253 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9c92cad1d6ed56ba5d24d4c1c05a36d5ffc7f5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] building db29 for RT #4518 - change (operations/puppet)
Jgreen has uploaded a new change for review. https://gerrit.wikimedia.org/r/49254 Change subject: building db29 for RT #4518 .. building db29 for RT #4518 Change-Id: I5fd25554a46f097d187e2ebb60c9b001871dc546 --- M manifests/site.pp 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/54/49254/1 -- To view, visit https://gerrit.wikimedia.org/r/49254 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5fd25554a46f097d187e2ebb60c9b001871dc546 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Jgreen ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 44744) copyright warning now using its own message inst... - change (mediawiki...Wikibase)
Henning Snater has submitted this change and it was merged. Change subject: (bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning .. (bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning Since the 'EditPageCopyrightWarning' is not suitable (without adjustments) to cover the needs of the wikidata short copyright message, we introduce our own message in wikibase for this. The following will be added to Wikidata's configuration to have the message displayed according to Wikidata's copyright and terms of use. - $wgRightsUrl = 'http://creativecommons.org/publicdomain/zero/1.0/'; - $wgRightsText = 'CC0 public domain dedication'; Without these configuration variables defined, the message will not look nice. - patch set 2: Corrected spelling errors Change-Id: I0a8328fbb50a8209fe9799f692898eccca378840 --- M repo/Wikibase.i18n.php M repo/includes/EntityView.php M repo/resources/wikibase.ui.entityViewInit.js 3 files changed, 18 insertions(+), 10 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49248 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a8328fbb50a8209fe9799f692898eccca378840 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner Gerrit-Reviewer: Henning Snater Gerrit-Reviewer: John Erling Blad ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing hdfs::sync rsync command - change (operations/puppet)
Ottomata has uploaded a new change for review. https://gerrit.wikimedia.org/r/49255 Change subject: Fixing hdfs::sync rsync command .. Fixing hdfs::sync rsync command Change-Id: I64187ecce14cb9926f5cc366c74273e6f6bd52f3 --- M manifests/misc/analytics.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/55/49255/1 -- To view, visit https://gerrit.wikimedia.org/r/49255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I64187ecce14cb9926f5cc366c74273e6f6bd52f3 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] building db29 for RT #4518 - change (operations/puppet)
Jgreen has submitted this change and it was merged. Change subject: building db29 for RT #4518 .. building db29 for RT #4518 Change-Id: I5fd25554a46f097d187e2ebb60c9b001871dc546 --- M manifests/site.pp 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jgreen: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49254 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fd25554a46f097d187e2ebb60c9b001871dc546 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Jgreen Gerrit-Reviewer: Jgreen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing hdfs::sync rsync command - change (operations/puppet)
Ottomata has submitted this change and it was merged. Change subject: Fixing hdfs::sync rsync command .. Fixing hdfs::sync rsync command Change-Id: I64187ecce14cb9926f5cc366c74273e6f6bd52f3 --- M manifests/misc/analytics.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ottomata: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64187ecce14cb9926f5cc366c74273e6f6bd52f3 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata Gerrit-Reviewer: Ottomata ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allow opening any compressed dump in all the scripts with du... - change (wiktionary/anagrimes)
Darkdadaah has uploaded a new change for review. https://gerrit.wikimedia.org/r/49256 Change subject: Allow opening any compressed dump in all the scripts with dump_input() from basic.pm .. Allow opening any compressed dump in all the scripts with dump_input() from basic.pm Change-Id: I0d262c83764fd03e59e910bcee021123dbb64a65 --- M scripts/dico-allwords.pl M scripts/dico-diffs.pl M scripts/dico-gener.pl M scripts/dico-liste.pl M scripts/dico-phile.pl M scripts/dico-table.pl M wiktio/basic.pm 7 files changed, 41 insertions(+), 51 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wiktionary/anagrimes refs/changes/56/49256/1 -- To view, visit https://gerrit.wikimedia.org/r/49256 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d262c83764fd03e59e910bcee021123dbb64a65 Gerrit-PatchSet: 1 Gerrit-Project: wiktionary/anagrimes Gerrit-Branch: master Gerrit-Owner: Darkdadaah ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Include diffs in Gerrit e-mails - change (operations/puppet)
Jgreen has submitted this change and it was merged. Change subject: Include diffs in Gerrit e-mails .. Include diffs in Gerrit e-mails Bug: 35532 Change-Id: If9f9113cb633e5eab49f7ed4df9fa255c83afca7 --- M templates/gerrit/gerrit.config.erb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Demon: Looks good to me, but someone else must approve Hashar: Looks good to me, but someone else must approve Jgreen: Checked; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/49133 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9f9113cb633e5eab49f7ed4df9fa255c83afca7 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Demon Gerrit-Reviewer: Demon Gerrit-Reviewer: Hashar Gerrit-Reviewer: Jgreen Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] only set async if we want to enable async - change (mediawiki...UploadWizard)
Aaron Schulz has submitted this change and it was merged. Change subject: only set async if we want to enable async .. only set async if we want to enable async setting async to false does not work, only set it if we want async publishing. Change-Id: Ia6bb6a71409a3b39b6dda3cab93375aadbe5ad76 --- M resources/mw.UploadWizardDetails.js 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Aaron Schulz: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49218 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6bb6a71409a3b39b6dda3cab93375aadbe5ad76 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: J Gerrit-Reviewer: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allow opening any compressed dump in all the scripts with du... - change (wiktionary/anagrimes)
Darkdadaah has submitted this change and it was merged. Change subject: Allow opening any compressed dump in all the scripts with dump_input() from basic.pm .. Allow opening any compressed dump in all the scripts with dump_input() from basic.pm Change-Id: I0d262c83764fd03e59e910bcee021123dbb64a65 --- M scripts/dico-allwords.pl M scripts/dico-diffs.pl M scripts/dico-gener.pl M scripts/dico-liste.pl M scripts/dico-phile.pl M scripts/dico-table.pl M wiktio/basic.pm 7 files changed, 41 insertions(+), 51 deletions(-) Approvals: Darkdadaah: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49256 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d262c83764fd03e59e910bcee021123dbb64a65 Gerrit-PatchSet: 1 Gerrit-Project: wiktionary/anagrimes Gerrit-Branch: master Gerrit-Owner: Darkdadaah Gerrit-Reviewer: Darkdadaah ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] linter for our Apache configurations - change (integration/jenkins-job-builder-config)
Hashar has submitted this change and it was merged. Change subject: linter for our Apache configurations .. linter for our Apache configurations Our infamous apache configuration can be subject to various typo and mistakes. This patch use the apache linter to load operations/apache-config.git files based on the document root provided by operations/mediawiki-config.git Using the apache -C option, one can pass extra configuration arguments such as loading some generic configuration files. Whenever apache -t detect a syntax error, the build will fail. Change-Id: I3ddf2fd384b2212773922d7dd980940db055498e --- A operations-apache-config.yaml 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/49251 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ddf2fd384b2212773922d7dd980940db055498e Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding --delete flag to hdfs::sync rsync command - change (operations/puppet)
Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49257
Change subject: Adding --delete flag to hdfs::sync rsync command
..
Adding --delete flag to hdfs::sync rsync command
Change-Id: I3962c45d9d5f45467e9f6ceea0608cdeae1429ed
---
M manifests/misc/analytics.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/57/49257/1
diff --git a/manifests/misc/analytics.pp b/manifests/misc/analytics.pp
index 47a5720..025b343 100644
--- a/manifests/misc/analytics.pp
+++ b/manifests/misc/analytics.pp
@@ -14,7 +14,7 @@
}
$local_tmp_dir = "${tmp_dir}/${name}"
- $command = "/bin/rm -rf ${local_tmp_dir} && /usr/bin/hadoop fs
-get ${hdfs_source} ${local_tmp_dir} && /usr/bin/rsync -rt ${local_tmp_dir}/
${rsync_destination} && /bin/rm -rf ${local_tmp_dir}"
+ $command = "/bin/rm -rf ${local_tmp_dir} && /usr/bin/hadoop fs
-get ${hdfs_source} ${local_tmp_dir} && /usr/bin/rsync -rt --delete
${local_tmp_dir}/ ${rsync_destination} && /bin/rm -rf ${local_tmp_dir}"
# Create an hourly cron job to rsync to $rsync_destination.
cron { "hdfs_sync_${name}":
--
To view, visit https://gerrit.wikimedia.org/r/49257
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3962c45d9d5f45467e9f6ceea0608cdeae1429ed
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding --delete flag to hdfs::sync rsync command - change (operations/puppet)
Ottomata has submitted this change and it was merged.
Change subject: Adding --delete flag to hdfs::sync rsync command
..
Adding --delete flag to hdfs::sync rsync command
Change-Id: I3962c45d9d5f45467e9f6ceea0608cdeae1429ed
---
M manifests/misc/analytics.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ottomata: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/misc/analytics.pp b/manifests/misc/analytics.pp
index 47a5720..025b343 100644
--- a/manifests/misc/analytics.pp
+++ b/manifests/misc/analytics.pp
@@ -14,7 +14,7 @@
}
$local_tmp_dir = "${tmp_dir}/${name}"
- $command = "/bin/rm -rf ${local_tmp_dir} && /usr/bin/hadoop fs
-get ${hdfs_source} ${local_tmp_dir} && /usr/bin/rsync -rt ${local_tmp_dir}/
${rsync_destination} && /bin/rm -rf ${local_tmp_dir}"
+ $command = "/bin/rm -rf ${local_tmp_dir} && /usr/bin/hadoop fs
-get ${hdfs_source} ${local_tmp_dir} && /usr/bin/rsync -rt --delete
${local_tmp_dir}/ ${rsync_destination} && /bin/rm -rf ${local_tmp_dir}"
# Create an hourly cron job to rsync to $rsync_destination.
cron { "hdfs_sync_${name}":
--
To view, visit https://gerrit.wikimedia.org/r/49257
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3962c45d9d5f45467e9f6ceea0608cdeae1429ed
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata
Gerrit-Reviewer: Ottomata
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
