date:20150816

[MediaWiki-commits] [Gerrit] Revert WikidataPageBanner should run Wikibase tests - change (integration/config)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Revert WikidataPageBanner should run Wikibase tests
..


Revert WikidataPageBanner should run Wikibase tests

This reverts commit 340476e4954e9908b62935ff0f299a464849f686.
See Bug T95897 - this blocks any merging of code.

Change-Id: Ifc74b4865a7771cb1ee93f1a9fc31af78aea1d11
---
M zuul/ext_dependencies.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  JanZerebecki: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/zuul/ext_dependencies.py b/zuul/ext_dependencies.py
old mode 100755
new mode 100644
index 838813c..80e0ca7
--- a/zuul/ext_dependencies.py
+++ b/zuul/ext_dependencies.py
@@ -30,7 +30,6 @@
 'SyntaxHighlight_GeSHi': ['VisualEditor'],
 'Thanks': ['Echo', 'Flow', 'MobileFrontend'],
 'VectorBeta': ['EventLogging'],
-'WikidataPageBanner': ['Wikidata'],
 }
 
 # Limit execution to these jobs

-- 
To view, visit https://gerrit.wikimedia.org/r/231779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc74b4865a7771cb1ee93f1a9fc31af78aea1d11
Gerrit-PatchSet: 3
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Dduvall dduv...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: JanZerebecki jan.wikime...@zerebecki.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] exim: remove unreferenced +relay_domains from mailman - change (operations/puppet)

2015-08-16 Thread Faidon Liambotis (Code Review)

Faidon Liambotis has submitted this change and it was merged.

Change subject: exim: remove unreferenced +relay_domains from mailman
..


exim: remove unreferenced +relay_domains from mailman

Change-Id: Idcbda0da83b3cf99edc6fb9ec0bad0ad81847f33
---
M templates/exim/exim4.conf.mailman.erb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Faidon Liambotis: Verified; Looks good to me, approved



diff --git a/templates/exim/exim4.conf.mailman.erb 
b/templates/exim/exim4.conf.mailman.erb
index d88ba0c..63482ba 100644
--- a/templates/exim/exim4.conf.mailman.erb
+++ b/templates/exim/exim4.conf.mailman.erb
@@ -95,9 +95,9 @@
hosts = +relay_from_hosts
control = submission/sender_retain
 
-   # Require recipient domain to be local, or a domain we relay for
+   # Require recipient domain to be local
require message = Relay not permitted
-   domains = +local_domains : +relay_domains
+   domains = +local_domains
set acl_m_relayed = yes
 
# Accept mail for postmaster without further policy checking,

-- 
To view, visit https://gerrit.wikimedia.org/r/231874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcbda0da83b3cf99edc6fb9ec0bad0ad81847f33
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] exim: remove unreferenced +relay_domains from mailman - change (operations/puppet)

2015-08-16 Thread Faidon Liambotis (Code Review)

Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231874

Change subject: exim: remove unreferenced +relay_domains from mailman
..

exim: remove unreferenced +relay_domains from mailman

Change-Id: Idcbda0da83b3cf99edc6fb9ec0bad0ad81847f33
---
M templates/exim/exim4.conf.mailman.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/74/231874/1

diff --git a/templates/exim/exim4.conf.mailman.erb 
b/templates/exim/exim4.conf.mailman.erb
index d88ba0c..5f13f31 100644
--- a/templates/exim/exim4.conf.mailman.erb
+++ b/templates/exim/exim4.conf.mailman.erb
@@ -97,7 +97,7 @@
 
# Require recipient domain to be local, or a domain we relay for
require message = Relay not permitted
-   domains = +local_domains : +relay_domains
+   domains = +local_domains
set acl_m_relayed = yes
 
# Accept mail for postmaster without further policy checking,

-- 
To view, visit https://gerrit.wikimedia.org/r/231874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcbda0da83b3cf99edc6fb9ec0bad0ad81847f33
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [tox] Add blockreview.py to flake8-docstrings-mandatory - change (pywikibot/core)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231868

Change subject: [tox] Add blockreview.py to flake8-docstrings-mandatory
..

[tox] Add blockreview.py to flake8-docstrings-mandatory

- doc strings added.

Change-Id: Ibf44ae25a296aff779b99c5c7daf9e64f2465d65
---
M scripts/blockreview.py
M tox.ini
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/68/231868/1

diff --git a/scripts/blockreview.py b/scripts/blockreview.py
index 08ec0ff..d754c8f 100755
--- a/scripts/blockreview.py
+++ b/scripts/blockreview.py
@@ -93,6 +93,7 @@
 self.parts = None
 
 def run(self):
+Run the bot.
 # TODO: change the generator for template to the included category
 try:
 genPage = pywikibot.Page(self.site,
@@ -228,6 +229,7 @@
 self.save(talkText, userPage, talkComment)
 
 def getInfo(self, user):
+Collect user info for i18n parameter dict.
 if not self.info:
 self.info = next(self.site.logpages(
 1, mode='block', title=user.getUserPage().title(), dump=True))
@@ -242,6 +244,7 @@
 }
 
 def SysopGenerator(self):
+Retrieve sysop talkpages.
 for user in self.site.allusers(group='sysop'):
 # exclude sysop bots
 if 'bot' not in user['groups']:
@@ -263,6 +266,7 @@
 return text
 
 def save(self, text, page, comment, minorEdit=True, botflag=True):
+Save the text.
 if text != page.text:
 # Show the title of the page we're working on.
 # Highlight the title in purple.
diff --git a/tox.ini b/tox.ini
index 5f23596..c2d6796 100644
--- a/tox.ini
+++ b/tox.ini
@@ -67,6 +67,7 @@
 scripts/add_text.py \
 scripts/basic.py \
 scripts/blockpageschecker.py \
+scripts/blockreview.py \
 scripts/capitalize_redirects.py \
 scripts/category.py \
 scripts/category_redirect.py \

-- 
To view, visit https://gerrit.wikimedia.org/r/231868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf44ae25a296aff779b99c5c7daf9e64f2465d65
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] xenon: redirect stdout to /dev/null, avoid cronspam - change (operations/puppet)

2015-08-16 Thread Faidon Liambotis (Code Review)

Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231873

Change subject: xenon: redirect stdout to /dev/null, avoid cronspam
..

xenon: redirect stdout to /dev/null, avoid cronspam

Subject: Cron xenon@fluorine /usr/local/bin/xenon-generate-svgs

Generating /srv/xenon/svgs/daily/2015-08-16.api.svgz...
Generating /srv/xenon/svgs/daily/2015-08-16.api.reversed.svgz...
[...]

Change-Id: I7a0f5f9f67d665b10ab4fd4591715de4008481d1
---
M modules/xenon/manifests/init.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/73/231873/1

diff --git a/modules/xenon/manifests/init.pp b/modules/xenon/manifests/init.pp
index cd56da4..af7225a 100644
--- a/modules/xenon/manifests/init.pp
+++ b/modules/xenon/manifests/init.pp
@@ -125,7 +125,7 @@
 
 cron { 'xenon_generate_svgs':
 ensure  = $ensure,
-command = '/usr/local/bin/xenon-generate-svgs',
+command = '/usr/local/bin/xenon-generate-svgs  /dev/null',
 user= 'xenon',
 minute  = '*/15',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/231873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a0f5f9f67d665b10ab4fd4591715de4008481d1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Vietnamese namespace - change (mediawiki...JsonConfig)

2015-08-16 Thread Mxn (Code Review)

Mxn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231872

Change subject: Vietnamese namespace
..

Vietnamese namespace

Change-Id: I5cfdcd61a1cf44d1f05ea2dd7dac996faf50fb50
---
M JsonConfig.namespaces.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/JsonConfig 
refs/changes/72/231872/1

diff --git a/JsonConfig.namespaces.php b/JsonConfig.namespaces.php
index 86d969e..f85e2c7 100644
--- a/JsonConfig.namespaces.php
+++ b/JsonConfig.namespaces.php
@@ -16,3 +16,8 @@
482 = 'Config',
483 = 'Config_talk',
 );
+
+$namespaceNames['vi'] = array(
+   482 = 'Cấu_hình',
+   483 = 'Thảo_luận_Cấu_hình',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cfdcd61a1cf44d1f05ea2dd7dac996faf50fb50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Mxn m...@1ec5.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] xenon: redirect stdout to /dev/null, avoid cronspam - change (operations/puppet)

2015-08-16 Thread Faidon Liambotis (Code Review)

Faidon Liambotis has submitted this change and it was merged.

Change subject: xenon: redirect stdout to /dev/null, avoid cronspam
..


xenon: redirect stdout to /dev/null, avoid cronspam

Subject: Cron xenon@fluorine /usr/local/bin/xenon-generate-svgs

Generating /srv/xenon/svgs/daily/2015-08-16.api.svgz...
Generating /srv/xenon/svgs/daily/2015-08-16.api.reversed.svgz...
[...]

Change-Id: I7a0f5f9f67d665b10ab4fd4591715de4008481d1
---
M modules/xenon/manifests/init.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Faidon Liambotis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/xenon/manifests/init.pp b/modules/xenon/manifests/init.pp
index cd56da4..af7225a 100644
--- a/modules/xenon/manifests/init.pp
+++ b/modules/xenon/manifests/init.pp
@@ -125,7 +125,7 @@
 
 cron { 'xenon_generate_svgs':
 ensure  = $ensure,
-command = '/usr/local/bin/xenon-generate-svgs',
+command = '/usr/local/bin/xenon-generate-svgs  /dev/null',
 user= 'xenon',
 minute  = '*/15',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/231873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0f5f9f67d665b10ab4fd4591715de4008481d1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Vietnamese namespaces - change (mediawiki...Wikibase)

2015-08-16 Thread Mxn (Code Review)

Mxn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231869

Change subject: Vietnamese namespaces
..

Vietnamese namespaces

Change-Id: I4bbccdb23c5f0c827faf07e4d63816b92c8e437b
---
M repo/Wikibase.i18n.namespaces.php
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/69/231869/1

diff --git a/repo/Wikibase.i18n.namespaces.php 
b/repo/Wikibase.i18n.namespaces.php
index cc0dc9b..555dd32 100644
--- a/repo/Wikibase.i18n.namespaces.php
+++ b/repo/Wikibase.i18n.namespaces.php
@@ -105,3 +105,17 @@
WB_NS_QUERY  = 'Запрос',
WB_NS_QUERY_TALK = 'Обсуждение_запроса',
 );
+
+$namespaceNames['en'] = array(
+   WB_NS_DATA  = 'Dữ_liệu',   // legacy
+   WB_NS_DATA_TALK = 'Thảo_luận_Dữ_liệu', // legacy
+
+   WB_NS_ITEM  = 'Khoản_mục',
+   WB_NS_ITEM_TALK = 'Thảo_luận_Khoản_mục',
+
+   WB_NS_PROPERTY  = 'Thuộc_tính',
+   WB_NS_PROPERTY_TALK = 'Thảo_luận_Thuộc_tính',
+
+   WB_NS_QUERY  = 'Truy_vấn',
+   WB_NS_QUERY_TALK = 'Thảo_luận_Truy_vấn',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bbccdb23c5f0c827faf07e4d63816b92c8e437b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Mxn m...@1ec5.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Vietnamese namespace and special page alias - change (mediawiki...Flow)

2015-08-16 Thread Mxn (Code Review)

Mxn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231870

Change subject: Vietnamese namespace and special page alias
..

Vietnamese namespace and special page alias

Change-Id: I8f03f20ef1e66c5026b81d5a7468afb5d4cb4029
---
M Flow.alias.php
M Flow.namespaces.php
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/70/231870/1

diff --git a/Flow.alias.php b/Flow.alias.php
index 882a55c..007e894 100644
--- a/Flow.alias.php
+++ b/Flow.alias.php
@@ -77,6 +77,12 @@
'Flow' = array( 'Flöde' ),
 );
 
+/** Vietnamese (Tiếng Việt) */
+$specialPageAliases['vi'] = array(
+   'Flow' = array( 'Flow' ),
+   'EnableFlow' = array( 'Kích_hoạt_Flow' ),
+);
+
 /** Simplified Chinese (中文（简体）‎) */
 $specialPageAliases['zh-hans'] = array(
'EnableFlow' = array( '启用Flow' ),
diff --git a/Flow.namespaces.php b/Flow.namespaces.php
index 7412c45..bdbc759 100644
--- a/Flow.namespaces.php
+++ b/Flow.namespaces.php
@@ -119,6 +119,11 @@
NS_TOPIC =  'موضوع',
 );
 
+/** Vietnamese */
+$namespaceNames['vi'] = array(
+   NS_TOPIC =  'Đề_tài',
+);
+
 /** Yiddish */
 $namespaceNames['yi'] = array(
NS_TOPIC =  'טעמע',

-- 
To view, visit https://gerrit.wikimedia.org/r/231870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f03f20ef1e66c5026b81d5a7468afb5d4cb4029
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mxn m...@1ec5.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Safer ctrl-c handling. - change (pywikibot/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Safer ctrl-c handling.
..


Safer ctrl-c handling.

This prevents half-finished changes to be written to Wikidata.
Instead, this finished the current change and then exits.

Change-Id: Iac27f7f7ddc7578368fa149e4be136bb0f9b12ef
---
M scripts/harvest_template.py
1 file changed, 17 insertions(+), 0 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py
index 8c60ba6..ec5fc3b 100755
--- a/scripts/harvest_template.py
+++ b/scripts/harvest_template.py
@@ -35,6 +35,21 @@
 #
 
 import re
+import signal
+
+willstop = False
+
+
+def _signal_handler(signal, frame):
+global willstop
+if not willstop:
+willstop = True
+print(Received ctrl-c. Finishing current item; press ctrl-c again to 
abort.)
+else:
+raise KeyboardInterrupt
+
+signal.signal(signal.SIGINT, _signal_handler)
+
 import pywikibot
 from pywikibot import pagegenerators as pg, textlib, WikidataBot
 
@@ -111,6 +126,8 @@
 
 def treat(self, page, item):
 Process a single page/item.
+if willstop:
+raise KeyboardInterrupt
 self.current_page = page
 item.get()
 if set(self.fields.values()) = set(item.claims.keys()):

-- 
To view, visit https://gerrit.wikimedia.org/r/173650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac27f7f7ddc7578368fa149e4be136bb0f9b12ef
Gerrit-PatchSet: 6
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen valhall...@arctus.nl
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Xqt i...@gno.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Vietnamese namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread Mxn (Code Review)

Mxn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231871

Change subject: Vietnamese namespaces
..

Vietnamese namespaces

Change-Id: I1f76e00b04a740c646456ae6f296198ff2f1d18c
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/71/231871/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0ec7d10..7c51166 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -15,3 +15,10 @@
NS_GADGET_DEFINITION = 'Gadget_definition',
NS_GADGET_DEFINITION_TALK = 'Gadget_definition_talk',
 );
+
+$namespaceNames['vi'] = array(
+   NS_GADGET = 'Tiện_ích',
+   NS_GADGET_TALK = 'Thảo_luận_Tiện_ích',
+   NS_GADGET_DEFINITION = 'Định_nghĩa_tiện_ích',
+   NS_GADGET_DEFINITION_TALK = 'Thảo_luận_Định_nghĩa_tiện_ích',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f76e00b04a740c646456ae6f296198ff2f1d18c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Mxn m...@1ec5.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] updates to upstream 36a50ccbae1e004eb1bb20003d726593cba6d814... - change (phabricator...Sprint)

2015-08-16 Thread Christopher Johnson (WMDE) (Code Review)

Christopher Johnson (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231876

Change subject: updates to upstream 36a50ccbae1e004eb1bb20003d726593cba6d814 
2015-08-15
..

updates to upstream 36a50ccbae1e004eb1bb20003d726593cba6d814
2015-08-15

Change-Id: If0582f457509dc0a0560e4ba089c2a6da13d763d
---
M rsrc/phui-object-box.css
M rsrc/phui-workboard-view.css
M src/conduit/SprintCreateConduitAPIMethod.php
M src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
M src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
M src/conduit/SprintSetIsSprintConduitAPIMethod.php
M src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
M src/controller/SprintHistoryController.php
M src/controller/SprintListController.php
M src/controller/SprintProjectProfileController.php
M src/controller/SprintProjectViewController.php
M src/controller/SprintReportController.php
M src/controller/board/SprintBoardColumnDetailController.php
M src/controller/board/SprintBoardColumnEditController.php
M src/controller/board/SprintBoardColumnHideController.php
M src/controller/board/SprintBoardImportController.php
M src/controller/board/SprintBoardMoveController.php
M src/controller/board/SprintBoardReorderController.php
M src/controller/board/SprintBoardTaskEditController.php
M src/controller/board/SprintBoardViewController.php
M src/tests/SprintQueryTest.php
M src/tests/SprintTestCase.php
M src/view/SprintUIObjectBoxView.php
M src/view/SprintView.php
M src/view/reports/SprintHistoryTableView.php
M src/view/reports/SprintReportBurnUpView.php
M src/view/reports/SprintReportOpenTasksView.php
27 files changed, 192 insertions(+), 193 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint 
refs/changes/76/231876/1

diff --git a/rsrc/phui-object-box.css b/rsrc/phui-object-box.css
index bd773ce..07db25d 100644
--- a/rsrc/phui-object-box.css
+++ b/rsrc/phui-object-box.css
@@ -38,7 +38,7 @@
 margin: 0;
 border-radius: 0;
 border: 0;
-border-bottom: 1px solid {$thinblueborder};
+border-bottom: 1px solid {$thinblueborder};
 }
 
 .device-phone .phui-object-box {
@@ -57,44 +57,44 @@
 /* - Object Box Colors -- 
*/
 
 .phui-box-border.phui-object-box-green {
-border: 1px solid {$green};
+border: 1px solid {$green};
 }
 
 .phui-box-border.phui-object-box-green .phui-header-view {
-color: {$green};
+color: {$green};
 }
 
 .phui-box-border.phui-object-box-green .phui-header-shell {
-border-bottom-color: {$lightgreen};
+border-bottom-color: {$lightgreen};
 }
 
 .phui-box-border.phui-object-box-blue {
-border: 1px solid {$blue};
+border: 1px solid {$blue};
 }
 
 .phui-box-border.phui-object-box-blue .phui-header-view {
-color: {$blue};
+color: {$blue};
 }
 
 .phui-box-border.phui-object-box-blue .phui-header-shell {
-border-bottom-color: {$lightblue};
+border-bottom-color: {$lightblue};
 }
 
 .phui-box-border.phui-object-box-red {
-border: 1px solid {$red};
+border: 1px solid {$red};
 }
 
 .phui-box-border.phui-object-box-red .phui-header-view {
-color: {$red};
+color: {$red};
 }
 
 .phui-box-border.phui-object-box-red .phui-header-shell {
-border-bottom-color: {$lightred};
+border-bottom-color: {$lightred};
 }
 
 .phui-object-box-hidden-content {
-background: {$lightgreybackground};
-border-bottom: 1px solid {$thinblueborder};
+background: {$lightgreybackground};
+border-bottom: 1px solid {$thinblueborder};
 }
 
 .phui-object-box.phui-object-box-collapsed .phui-object-box-hidden-content {
@@ -109,11 +109,11 @@
 
 /* eh oh el */
 .phui-object-box .phui-object-box + .phui-object-box {
-border-top: 1px solid {$thinblueborder};
+border-top: 1px solid {$thinblueborder};
 }
 
 .phui-object-box .phui-object-box .phui-header-shell .phui-header-header {
-font-family: {$fontfamily};
+font-family: {$fontfamily};
 }
 
 .phui-object-box .phui-box-border {
@@ -124,14 +124,14 @@
 
 .phui-object-box .phui-object-box .phui-header-shell .phui-header-view {
 padding: 4px 8px;
-background-color: {$lightgreybackground};
+background-color: {$lightgreybackground};
 }
 
 .phui-object-box .phui-object-box .phui-header-shell .phui-header-header {
 font-size: 13px;
 margin: 0;
-color: {$darkbluetext};
-font-weight: bold;
+color: {$darkbluetext};
+font-weight: bold;
 }
 
 .phui-object-box .phui-object-box .phui-header-shell {
diff --git a/rsrc/phui-workboard-view.css b/rsrc/phui-workboard-view.css
index 4d57612..b48b478 100644
--- a/rsrc/phui-workboard-view.css
+++ b/rsrc/phui-workboard-view.css
@@ -9,14 +9,14 @@
 .device-desktop .phui-workboard-view-shadow {
 overflow-x: auto;
 position: absolute;
-top: 110px;
+top: 96px;
 bottom: 0;
 left: 0;
 right: 0;
 }
 
 .device-desktop .page-has-warning .phui-workboard-view-shadow {
-top: 138px;
+top: 132px;
 }

[MediaWiki-commits] [Gerrit] [IMPR] Replace fullVersionHistory() with revisions() - change (pywikibot/core)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231875

Change subject: [IMPR] Replace fullVersionHistory() with revisions()
..

[IMPR] Replace fullVersionHistory() with revisions()

- create page instance on top of the method
- use revision properties

Change-Id: I56be946e4215a06c608839ba750f2b7e1423fad8
---
M scripts/revertbot.py
1 file changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/75/231875/1

diff --git a/scripts/revertbot.py b/scripts/revertbot.py
index e283477..0da068e 100755
--- a/scripts/revertbot.py
+++ b/scripts/revertbot.py
@@ -91,31 +91,34 @@
 return 'top' in item
 
 def revert(self, item):
-history = pywikibot.Page(self.site, item['title']).fullVersionHistory(
-total=2, rollback=self.rollback)
+page = pywikibot.Page(self.site, item['title'])
+history = list(page.revisions(total=2))
 if len(history)  1:
 rev = history[1]
 else:
 return False
 comment = i18n.twtranslate(
-pywikibot.Site(), 'revertbot-revert',
-{'revid': rev[0], 'author': rev[2], 'timestamp': rev[1]})
+self.site, 'revertbot-revert',
+{'revid': rev.revid,
+ 'author': rev.user,
+ 'timestamp': rev.timestamp})
 if self.comment:
 comment += ': ' + self.comment
-page = pywikibot.Page(self.site, item['title'])
 pywikibot.output(u\n\n \03{lightpurple}%s\03{default} 
  % page.title(asLink=True, forceInterwiki=True,
   textlink=True))
 if not self.rollback:
 old = page.text
-page.text = rev[3]
+page.text = rev.text
 pywikibot.showDiff(old, page.text)
 page.save(comment)
 return comment
 try:
 pywikibot.data.api.Request(
-self.site, parameters={'action': 'rollback', 'title': page,
-   'user': self.user, 'token': rev[4],
+self.site, parameters={'action': 'rollback',
+   'title': page,
+   'user': self.user,
+   'token': rev.rollbacktoken,
'markbot': True}).submit()
 except pywikibot.data.api.APIError as e:
 if e.code == 'badtoken':

-- 
To view, visit https://gerrit.wikimedia.org/r/231875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56be946e4215a06c608839ba750f2b7e1423fad8
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] New Wikidata Build - 2015-08-16T10:00:01+0000 - change (mediawiki...Wikidata)

2015-08-16 Thread WikidataBuilder (Code Review)

WikidataBuilder has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231877

Change subject: New Wikidata Build - 2015-08-16T10:00:01+
..

New Wikidata Build - 2015-08-16T10:00:01+

Change-Id: I99720946084d87ea8878c241bc277ea0933a4929
---
M composer.lock
M extensions/Wikibase/repo/i18n/ady-cyrl.json
M extensions/Wikibase/repo/i18n/ko.json
M extensions/Wikibase/repo/i18n/sv.json
M vendor/composer/installed.json
5 files changed, 31 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/77/231877/1

diff --git a/composer.lock b/composer.lock
index 383a2f8..a212b70 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1379,12 +1379,12 @@
 source: {
 type: git,
 url: 
https://github.com/wikimedia/mediawiki-extensions-Wikibase.git;,
-reference: 752cd9bb22b8dd577b54c89ec102c7c057605bd1
+reference: 1cba17bd26b4070920aec5c52933defe48fa52e5
 },
 dist: {
 type: zip,
-url: 
https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/752cd9bb22b8dd577b54c89ec102c7c057605bd1;,
-reference: 752cd9bb22b8dd577b54c89ec102c7c057605bd1,
+url: 
https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/1cba17bd26b4070920aec5c52933defe48fa52e5;,
+reference: 1cba17bd26b4070920aec5c52933defe48fa52e5,
 shasum: 
 },
 require: {
@@ -1453,7 +1453,7 @@
 wikibaserepo,
 wikidata
 ],
-time: 2015-08-14 20:13:22
+time: 2015-08-15 19:49:52
 },
 {
 name: wikibase/wikimedia-badges,
diff --git a/extensions/Wikibase/repo/i18n/ady-cyrl.json 
b/extensions/Wikibase/repo/i18n/ady-cyrl.json
index d03cdcf..bf6033c 100644
--- a/extensions/Wikibase/repo/i18n/ady-cyrl.json
+++ b/extensions/Wikibase/repo/i18n/ady-cyrl.json
@@ -4,15 +4,16 @@
SamGamgee,
TheRossatron,
SmartNart12,
-   GR44 Luc
+   GR44 Luc,
+   Highlander45temp
]
},
wikibase-edit: еIаз,
wikibase-add: хэгъахъу,
-   wikibase-label-empty: Ц1э пари фэусыгъэп,
+   wikibase-label-empty: ЦIэ пари фэусыгъэп,
wikibase-description-empty: ГурыIоныгъэ пари итхагъэп,
-   wikibase-statements: Еплъык1эхэр,
-   wikibase-sitelinks-special: Нэмык1 сайтхэр,
+   wikibase-statements: ЕплъыкIэхэр,
+   wikibase-sitelinks-special: НэмыкI сайтхэр,
wikibase-aliases-empty: Синонимхэр гъэнэфагъэхэп,
wikibase-statementview-rank-normal: Ранг нормал,
wikibase-statementview-referencesheading-pendingcountersubject: 
{{PLURAL:$1|лъапсэ|лъапсэхэр}}
diff --git a/extensions/Wikibase/repo/i18n/ko.json 
b/extensions/Wikibase/repo/i18n/ko.json
index 59abc5b..d9b2e9d 100644
--- a/extensions/Wikibase/repo/i18n/ko.json
+++ b/extensions/Wikibase/repo/i18n/ko.json
@@ -125,6 +125,7 @@
wikibase-gotolinkedpage-lookup-item: 항목 아이디:,
wikibase-gotolinkedpage-submit: 가기,
wikibase-gotolinkedpage-summary: Special:GoToLinkedPage는 항목으로 연결된 
사이트에 있는 문서를 찾는 데 사용됩니다.br / 왼쪽 칸의 \사이트:\에는 언어나 사이트 코드를 입력하는 곳입니다.br / 오른쪽 
칸의 \항목 ID:\에는 당신이 찾고자 하는 문서에 해당하는 위키데이터 항목의 ID를 입력하셔야 합니다.,
+   wikibase-gotolinkedpage-error-item-not-found: 항목을 찾을 수 없습니다,
special-itemdisambiguation: 항목 동음이의어,
wikibase-itemdisambiguation-lookup-fieldset: 언어와 레이블별로 항목 검색,
wikibase-itemdisambiguation-lookup-language: 언어 코드:,
@@ -192,6 +193,7 @@
wikibase-mergeitems-fromid: 합병되는 문서의 id,
wikibase-mergeitems-toid: 합병할 문서의 id,
wikibase-mergeitems-submit: 항목 합병,
+   wikibase-itemmerge-failed-save: 항목 저장에 실패했습니다.,
special-dispatchstats: 편집 전송 통계,
wikibase-dispatchstats-intro: 이 문서는 변경 사항을 클라이언트에 전송하는 것에 관한 통계를 
제공합니다.,
wikibase-dispatchstats-no-stats: 현재 사용할 수 있는 통계가 없습니다.,
@@ -237,6 +239,7 @@
wikibase-entitydata-unsupported-format: $1 데이터 형식은 이 인터페이스에서 지원되지 
않습니다.,
wikibase-entitydata-title: 개체 데이터,
wikibase-entitydata-text: 이 문서는 개체 값에 연결된 데이터 인터페이스를 제공합니다. 하위 문서 
구문을 사용하여 URL에 있는 개체 ID를 입력하세요.,
+   wikibase-redirectentity-submit: 넘겨주기,
special-mylanguagefallbackchain: 내 언어 폴백 체인,
wikibase-mylanguagefallbackchain-text: 개체의 레이블을 보여주는 데 사용되는 언어 폴백 
체인을 아래에 보여줍니다.,
wikibase-mylanguagefallbackchain-babel: {{GENDER:$1|자신의}} 
[[Special:MyPage|사용자 문서]]에 nowiki{{#babel: }}/nowiki을 넣어 편집할 수 있습니다.,
diff --git a/extensions/Wikibase/repo/i18n/sv.json 
b/extensions/Wikibase/repo/i18n/sv.json
index 5f6ba0f..5e797f2 100644
--- a/extensions/Wikibase/repo/i18n/sv.json
+++ b/extensions/Wikibase/repo/i18n/sv.json
@@ -171,6 +171,7

[MediaWiki-commits] [Gerrit] New Wikidata Build - 2015-08-15T10:00:01+0000 - change (mediawiki...Wikidata)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: New Wikidata Build - 2015-08-15T10:00:01+
..


New Wikidata Build - 2015-08-15T10:00:01+

Change-Id: Ic226f7fa40dea20bbfe5c4b28b84dd88859cd0b7
---
M composer.json
M composer.lock
M extensions/Constraints/composer.json
M 
extensions/Constraints/includes/ConstraintCheck/Checker/ConflictsWithChecker.php
M extensions/Constraints/includes/ConstraintCheck/Checker/InverseChecker.php
M extensions/Constraints/includes/ConstraintCheck/Checker/ItemChecker.php
M extensions/Constraints/includes/ConstraintCheck/Checker/SymmetricChecker.php
M 
extensions/Constraints/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
M extensions/Constraints/includes/ConstraintCheck/Checker/TypeChecker.php
M extensions/Constraints/includes/ConstraintCheck/Checker/ValueTypeChecker.php
M 
extensions/Constraints/includes/ConstraintCheck/DelegatingConstraintChecker.php
M extensions/Constraints/includes/ConstraintCheck/Helper/TypeCheckerHelper.php
M extensions/Constraints/includes/ConstraintReportFactory.php
M extensions/Constraints/specials/SpecialConstraintReport.php
M extensions/Constraints/tests/phpunit/ConstraintReportFactoryTest.php
M extensions/Constraints/tests/phpunit/DelegatingConstraintCheckerTest.php
M extensions/PropertySuggester/PropertySuggester.php
M extensions/PropertySuggester/README.md
M extensions/PropertySuggester/composer.json
M extensions/PropertySuggester/src/PropertySuggester/GetSuggestions.php
M extensions/PropertySuggester/src/PropertySuggester/SuggestionGenerator.php
M 
extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php
M extensions/Quality/composer.json
M extensions/Quality/tests/phpunit/Helper/JsonFileEntityLookup.php
M extensions/Wikibase/client/i18n/ady-cyrl.json
M extensions/Wikibase/client/i18n/ast.json
M extensions/Wikibase/client/i18n/av.json
M extensions/Wikibase/client/i18n/be-tarask.json
M extensions/Wikibase/client/i18n/ce.json
M extensions/Wikibase/client/i18n/cs.json
M extensions/Wikibase/client/i18n/fr.json
M extensions/Wikibase/client/i18n/gl.json
M extensions/Wikibase/client/i18n/km.json
M extensions/Wikibase/client/i18n/ps.json
M extensions/Wikibase/client/i18n/sgs.json
M extensions/Wikibase/client/i18n/sr-el.json
M extensions/Wikibase/client/i18n/tt-cyrl.json
M extensions/Wikibase/client/i18n/war.json
M extensions/Wikibase/client/includes/Changes/ChangeRunCoalescer.php
M extensions/Wikibase/client/includes/DataAccess/PropertyIdResolver.php
M 
extensions/Wikibase/client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
M 
extensions/Wikibase/client/includes/DataAccess/PropertyParserFunction/PropertyClaimsRendererFactory.php
M extensions/Wikibase/client/includes/DataAccess/RestrictedEntityLookup.php
M extensions/Wikibase/client/includes/DataAccess/Scribunto/EntityAccessor.php
M 
extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibrary.php
M 
extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php
M 
extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLuaBindings.php
M 
extensions/Wikibase/client/includes/DataAccess/StatementTransclusionInteractor.php
M extensions/Wikibase/client/includes/Hooks/LanguageLinkBadgeDisplay.php
M extensions/Wikibase/client/includes/LangLinkHandler.php
R extensions/Wikibase/client/includes/PropertyLabelNotResolvedException.php
M extensions/Wikibase/client/includes/Usage/PageEntityUsages.php
M extensions/Wikibase/client/includes/Usage/UsageTrackingTermLookup.php
M extensions/Wikibase/client/includes/WikibaseClient.php
M extensions/Wikibase/client/includes/store/ClientStore.php
M extensions/Wikibase/client/includes/store/sql/BulkSubscriptionUpdater.php
M extensions/Wikibase/client/includes/store/sql/DirectSqlStore.php
M extensions/Wikibase/client/tests/phpunit/MockClientStore.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/PropertyIdResolverTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/LanguageAwareRendererTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/PropertyClaimsRendererFactoryTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/RunnerTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/RestrictedEntityLookupTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/EntityAccessorTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/Scribunto/WikibaseLuaBindingsTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/DataAccess/StatementTransclusionInteractorTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/Hooks/SidebarHookHandlersTest.php
M 
extensions/Wikibase/client/tests/phpunit/includes/Usage/UsageTrackingTermLookupTest.php
M

[MediaWiki-commits] [Gerrit] [tox] Add blockreview.py to flake8-docstrings-mandatory - change (pywikibot/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [tox] Add blockreview.py to flake8-docstrings-mandatory
..


[tox] Add blockreview.py to flake8-docstrings-mandatory

- doc strings added.

Change-Id: Ibf44ae25a296aff779b99c5c7daf9e64f2465d65
---
M scripts/blockreview.py
M tox.ini
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/blockreview.py b/scripts/blockreview.py
index 08ec0ff..d754c8f 100755
--- a/scripts/blockreview.py
+++ b/scripts/blockreview.py
@@ -93,6 +93,7 @@
 self.parts = None
 
 def run(self):
+Run the bot.
 # TODO: change the generator for template to the included category
 try:
 genPage = pywikibot.Page(self.site,
@@ -228,6 +229,7 @@
 self.save(talkText, userPage, talkComment)
 
 def getInfo(self, user):
+Collect user info for i18n parameter dict.
 if not self.info:
 self.info = next(self.site.logpages(
 1, mode='block', title=user.getUserPage().title(), dump=True))
@@ -242,6 +244,7 @@
 }
 
 def SysopGenerator(self):
+Retrieve sysop talkpages.
 for user in self.site.allusers(group='sysop'):
 # exclude sysop bots
 if 'bot' not in user['groups']:
@@ -263,6 +266,7 @@
 return text
 
 def save(self, text, page, comment, minorEdit=True, botflag=True):
+Save the text.
 if text != page.text:
 # Show the title of the page we're working on.
 # Highlight the title in purple.
diff --git a/tox.ini b/tox.ini
index 5f23596..c2d6796 100644
--- a/tox.ini
+++ b/tox.ini
@@ -67,6 +67,7 @@
 scripts/add_text.py \
 scripts/basic.py \
 scripts/blockpageschecker.py \
+scripts/blockreview.py \
 scripts/capitalize_redirects.py \
 scripts/category.py \
 scripts/category_redirect.py \

-- 
To view, visit https://gerrit.wikimedia.org/r/231868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf44ae25a296aff779b99c5c7daf9e64f2465d65
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Merlijn van Deen valhall...@arctus.nl
Gerrit-Reviewer: XZise commodorefabia...@gmx.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] getLanguageNameByCode: Avoid conflicts with predefined Objec... - change (mediawiki...Wikibase)

2015-08-16 Thread Gerrit Patch Uploader (Code Review)

Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231878

Change subject: getLanguageNameByCode: Avoid conflicts with predefined Object 
prototypes
..

getLanguageNameByCode: Avoid conflicts with predefined Object prototypes

With this patch
wb.getLanguageNameByCode( 'constructor' )
evaluates to constructor instead of constructor().

This avoids JavaScript errors when using URL parameter uselang=constructor.

Change-Id: I17bf89674d846b976f03dd57692a68583e753e36
---
M view/resources/wikibase/wikibase.getLanguageNameByCode.js
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/78/231878/1

diff --git a/view/resources/wikibase/wikibase.getLanguageNameByCode.js 
b/view/resources/wikibase/wikibase.getLanguageNameByCode.js
index ce40742..ee3ba65 100644
--- a/view/resources/wikibase/wikibase.getLanguageNameByCode.js
+++ b/view/resources/wikibase/wikibase.getLanguageNameByCode.js
@@ -8,6 +8,8 @@
 ( function ( wb, mw, $ ) {
'use strict';
 
+   var hasOwn = Object.prototype.hasOwnProperty;
+
/**
 * Tries to retrieve Universal Language Selector's set of languages.
 *
@@ -30,8 +32,8 @@
 * @return string
 */
var getNativeLanguageName = function( langCode ) {
-   var language = getLanguages()[ langCode ];
-   return language  language[2] || langCode;
+   var languages = getLanguages();
+   return hasOwn.call( languages, langCode )  
languages[langCode][2] || langCode;
};
 
/**
@@ -43,7 +45,8 @@
 */
wb.getLanguageNameByCode = function( langCode ) {
var ulsLanguages = mw.config.get( 'wgULSLanguages' );
-   return ulsLanguages  ulsLanguages[langCode] || 
getNativeLanguageName( langCode );
+   return ulsLanguages  hasOwn.call( ulsLanguages, langCode )  
ulsLanguages[langCode]
+   || getNativeLanguageName( langCode );
};
 
 } )( wikibase, mediaWiki, jQuery );

-- 
To view, visit https://gerrit.wikimedia.org/r/231878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I17bf89674d846b976f03dd57692a68583e753e36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] New Wikidata Build - 2015-08-16T10:00:01+0000 - change (mediawiki...Wikidata)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: New Wikidata Build - 2015-08-16T10:00:01+
..


New Wikidata Build - 2015-08-16T10:00:01+

Change-Id: I99720946084d87ea8878c241bc277ea0933a4929
---
M composer.lock
M extensions/Wikibase/repo/i18n/ady-cyrl.json
M extensions/Wikibase/repo/i18n/ko.json
M extensions/Wikibase/repo/i18n/sv.json
M vendor/composer/installed.json
5 files changed, 31 insertions(+), 26 deletions(-)

Approvals:
  JanZerebecki: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.lock b/composer.lock
index 383a2f8..a212b70 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1379,12 +1379,12 @@
 source: {
 type: git,
 url: 
https://github.com/wikimedia/mediawiki-extensions-Wikibase.git;,
-reference: 752cd9bb22b8dd577b54c89ec102c7c057605bd1
+reference: 1cba17bd26b4070920aec5c52933defe48fa52e5
 },
 dist: {
 type: zip,
-url: 
https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/752cd9bb22b8dd577b54c89ec102c7c057605bd1;,
-reference: 752cd9bb22b8dd577b54c89ec102c7c057605bd1,
+url: 
https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/1cba17bd26b4070920aec5c52933defe48fa52e5;,
+reference: 1cba17bd26b4070920aec5c52933defe48fa52e5,
 shasum: 
 },
 require: {
@@ -1453,7 +1453,7 @@
 wikibaserepo,
 wikidata
 ],
-time: 2015-08-14 20:13:22
+time: 2015-08-15 19:49:52
 },
 {
 name: wikibase/wikimedia-badges,
diff --git a/extensions/Wikibase/repo/i18n/ady-cyrl.json 
b/extensions/Wikibase/repo/i18n/ady-cyrl.json
index d03cdcf..bf6033c 100644
--- a/extensions/Wikibase/repo/i18n/ady-cyrl.json
+++ b/extensions/Wikibase/repo/i18n/ady-cyrl.json
@@ -4,15 +4,16 @@
SamGamgee,
TheRossatron,
SmartNart12,
-   GR44 Luc
+   GR44 Luc,
+   Highlander45temp
]
},
wikibase-edit: еIаз,
wikibase-add: хэгъахъу,
-   wikibase-label-empty: Ц1э пари фэусыгъэп,
+   wikibase-label-empty: ЦIэ пари фэусыгъэп,
wikibase-description-empty: ГурыIоныгъэ пари итхагъэп,
-   wikibase-statements: Еплъык1эхэр,
-   wikibase-sitelinks-special: Нэмык1 сайтхэр,
+   wikibase-statements: ЕплъыкIэхэр,
+   wikibase-sitelinks-special: НэмыкI сайтхэр,
wikibase-aliases-empty: Синонимхэр гъэнэфагъэхэп,
wikibase-statementview-rank-normal: Ранг нормал,
wikibase-statementview-referencesheading-pendingcountersubject: 
{{PLURAL:$1|лъапсэ|лъапсэхэр}}
diff --git a/extensions/Wikibase/repo/i18n/ko.json 
b/extensions/Wikibase/repo/i18n/ko.json
index 59abc5b..d9b2e9d 100644
--- a/extensions/Wikibase/repo/i18n/ko.json
+++ b/extensions/Wikibase/repo/i18n/ko.json
@@ -125,6 +125,7 @@
wikibase-gotolinkedpage-lookup-item: 항목 아이디:,
wikibase-gotolinkedpage-submit: 가기,
wikibase-gotolinkedpage-summary: Special:GoToLinkedPage는 항목으로 연결된 
사이트에 있는 문서를 찾는 데 사용됩니다.br / 왼쪽 칸의 \사이트:\에는 언어나 사이트 코드를 입력하는 곳입니다.br / 오른쪽 
칸의 \항목 ID:\에는 당신이 찾고자 하는 문서에 해당하는 위키데이터 항목의 ID를 입력하셔야 합니다.,
+   wikibase-gotolinkedpage-error-item-not-found: 항목을 찾을 수 없습니다,
special-itemdisambiguation: 항목 동음이의어,
wikibase-itemdisambiguation-lookup-fieldset: 언어와 레이블별로 항목 검색,
wikibase-itemdisambiguation-lookup-language: 언어 코드:,
@@ -192,6 +193,7 @@
wikibase-mergeitems-fromid: 합병되는 문서의 id,
wikibase-mergeitems-toid: 합병할 문서의 id,
wikibase-mergeitems-submit: 항목 합병,
+   wikibase-itemmerge-failed-save: 항목 저장에 실패했습니다.,
special-dispatchstats: 편집 전송 통계,
wikibase-dispatchstats-intro: 이 문서는 변경 사항을 클라이언트에 전송하는 것에 관한 통계를 
제공합니다.,
wikibase-dispatchstats-no-stats: 현재 사용할 수 있는 통계가 없습니다.,
@@ -237,6 +239,7 @@
wikibase-entitydata-unsupported-format: $1 데이터 형식은 이 인터페이스에서 지원되지 
않습니다.,
wikibase-entitydata-title: 개체 데이터,
wikibase-entitydata-text: 이 문서는 개체 값에 연결된 데이터 인터페이스를 제공합니다. 하위 문서 
구문을 사용하여 URL에 있는 개체 ID를 입력하세요.,
+   wikibase-redirectentity-submit: 넘겨주기,
special-mylanguagefallbackchain: 내 언어 폴백 체인,
wikibase-mylanguagefallbackchain-text: 개체의 레이블을 보여주는 데 사용되는 언어 폴백 
체인을 아래에 보여줍니다.,
wikibase-mylanguagefallbackchain-babel: {{GENDER:$1|자신의}} 
[[Special:MyPage|사용자 문서]]에 nowiki{{#babel: }}/nowiki을 넣어 편집할 수 있습니다.,
diff --git a/extensions/Wikibase/repo/i18n/sv.json 
b/extensions/Wikibase/repo/i18n/sv.json
index 5f6ba0f..5e797f2 100644
--- a/extensions/Wikibase/repo/i18n/sv.json
+++ b/extensions/Wikibase/repo/i18n/sv.json
@@ -171,6 +171,7 @@
wikibase-setaliases-label: Alias:,

[MediaWiki-commits] [Gerrit] WikidataPageBanner add max-wdith - change (mediawiki...WikidataPageBanner)

2015-08-16 Thread Sumit (Code Review)

Sumit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231886

Change subject: WikidataPageBanner add max-wdith
..

WikidataPageBanner add max-wdith

Add a parameter max-width to the banner so as to prevent pixelation of the
banner.

Bug: T108986
Change-Id: I54353ca33a243954392de4467f2f2b23b76601a2
---
M includes/WikidataPageBanner.functions.php
M templates/banner.mustache
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/86/231886/1

diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 374e20c..0c6658d 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -149,6 +149,8 @@
$options['bannerfile'] = $bannerfile-getLocalUrl();
$options['banner'] = $bannerurl;
$options['srcset'] = $srcset;
+   $file = wfFindFile( $bannerfile );
+   $options['maxWidth'] = $file-getWidth();
$banner = $templateParser-processTemplate(
'banner',
$options
diff --git a/templates/banner.mustache b/templates/banner.mustache
index 40560be..aca46f3 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -1,7 +1,7 @@
 div class=ext-wpb-pagebanner noprint
div class=wpb-topbanner
div class=wpb-name{{title}}/div
-   a class=image title={{tooltip}} href={{bannerfile}}img 
src={{banner}} srcset={{srcset}} class=wpb-banner-image {{originx}} 
data-pos-x={{data-pos-x}} data-pos-y={{data-pos-y}}/a
+   a class=image title={{tooltip}} href={{bannerfile}}img 
src={{banner}} srcset={{srcset}} class=wpb-banner-image {{originx}} 
data-pos-x={{data-pos-x}} data-pos-y={{data-pos-y}} 
style=max-width:{{maxWidth}}px/a
{{#hasIcons}}
div class=wpb-iconbox
{{#icons}}

-- 
To view, visit https://gerrit.wikimedia.org/r/231886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54353ca33a243954392de4467f2f2b23b76601a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit asthana.sumi...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Hebrew namespace translation - change (mediawiki...Gadgets)

2015-08-16 Thread Amire80 (Code Review)

Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231895

Change subject: Add Hebrew namespace translation
..

Add Hebrew namespace translation

Change-Id: I1e4afe239ee83f8d1cba38618144136056186aaf
---
M Gadgets.namespaces.php
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/95/231895/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0ec7d10..3b2b924 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -15,3 +15,11 @@
NS_GADGET_DEFINITION = 'Gadget_definition',
NS_GADGET_DEFINITION_TALK = 'Gadget_definition_talk',
 );
+
+$namespaceNames['en'] = array(
+   NS_GADGET = 'גאדג\'ט',
+   NS_GADGET_TALK = 'שיחת_גאדג\'ט',
+   NS_GADGET_DEFINITION = 'הגדרת_גאדג\'ט',
+   NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
+);
+

-- 
To view, visit https://gerrit.wikimedia.org/r/231895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e4afe239ee83f8d1cba38618144136056186aaf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [FEAT] replaceExcept: Support custom parameters - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231899

Change subject: [FEAT] replaceExcept: Support custom parameters
..

[FEAT] replaceExcept: Support custom parameters

This adds the ability to support custom parameters when the replacement is a
callable. This can be used to pass the page to the callable in the replace
script.

Bug: T109220
Change-Id: Iee52388d8a137a21252476cb7926e4705e0324fa
---
M pywikibot/textlib.py
M scripts/replace.py
M tests/textlib_tests.py
3 files changed, 65 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/99/231899/1

diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py
index 77454fc..bf10b7a 100644
--- a/pywikibot/textlib.py
+++ b/pywikibot/textlib.py
@@ -225,7 +225,8 @@
 
 
 def replaceExcept(text, old, new, exceptions, caseInsensitive=False,
-  allowoverlap=False, marker='', site=None):
+  allowoverlap=False, marker='', site=None,
+  replacement_parameters=None):
 
 Return text with 'old' replaced by 'new', ignoring specified types of text.
 
@@ -245,8 +246,17 @@
 @type caseInsensitive: bool
 @param marker: a string that will be added to the last replacement;
 if nothing is changed, it is added at the end
-
+@param replacement_parameters: if C{new} is a callable these parameters
+are forwarded additionally to the match.
+@type replacement_parameters: dict or None
 
+if replacement_parameters:
+if not callable(new):
+raise ValueError('The replacement_parameters cannot be set when '
+ 'the replacement is not callable.')
+else:
+replacement_parameters = {}
+
 # if we got a string, compile it as a regular expression
 if isinstance(old, basestring):
 if caseInsensitive:
@@ -289,7 +299,7 @@
 if callable(new):
 # the parameter new can be a function which takes the match
 # as a parameter.
-replacement = new(match)
+replacement = new(match, **replacement_parameters)
 else:
 # it is not a function, but a string.
 
diff --git a/scripts/replace.py b/scripts/replace.py
index 9bcfeb1..981d580 100755
--- a/scripts/replace.py
+++ b/scripts/replace.py
@@ -179,12 +179,14 @@
 
 The replacement instructions.
 
-def __init__(self, old, new, edit_summary=None, default_summary=True):
+def __init__(self, old, new, edit_summary=None, default_summary=True,
+ page_parameter=False):
 self.old = old
 self.old_regex = None
 self.new = new
 self._edit_summary = edit_summary
 self.default_summary = default_summary
+self.page_parameter = page_parameter
 
 @property
 def edit_summary(self):
@@ -287,7 +289,7 @@
 
 
 def __init__(self, use_regex, exceptions, case_insensitive, edit_summary,
- name):
+ name, page_parameter=False):
 super(ReplacementList, self).__init__()
 self.use_regex = use_regex
 self._exceptions = exceptions
@@ -295,6 +297,7 @@
 self.case_insensitive = case_insensitive
 self.edit_summary = edit_summary
 self.name = name
+self.page_parameter = page_parameter
 
 def _compile_exceptions(self, use_regex, flags):
 if not self.exceptions and self._exceptions is not None:
@@ -343,6 +346,11 @@
 Container objects must have a name attribute.
 
 return self.fix_set
+
+@property
+def page_parameter(self):
+Return the page_parameter of the container.
+return self.container.page_parameter
 
 def _compile(self, use_regex, flags):
 super(ReplacementListEntry, self)._compile(use_regex, flags)
@@ -589,10 +597,15 @@
 replacement.description, page.title(asLink=True)))
 continue
 old_text = new_text
+if replacement.page_parameter:
+parameters = {'page': page}
+else:
+parameters = {}
 new_text = textlib.replaceExcept(
 new_text, replacement.old_regex, replacement.new,
 exceptions + get_exceptions(replacement.exceptions or {}),
-allowoverlap=self.allowoverlap, site=self.site)
+allowoverlap=self.allowoverlap, site=self.site,
+replacement_parameters=parameters)
 if old_text != new_text:
 applied.add(replacement)
 
@@ -963,11 +976,9 @@
 set_summary = i18n.translate(site, fix['msg'], fallback=True)
 else:
 set_summary = None
-replacement_set = ReplacementList(fix.get('regex'),
-  fix.get('exceptions'),
-

[MediaWiki-commits] [Gerrit] Stop branching Extension:Oversight - change (mediawiki...release)

2015-08-16 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231900

Change subject: Stop branching Extension:Oversight
..

Stop branching Extension:Oversight

Bug: T34628
Change-Id: I731cda24bb0c4a089b19a16733c64c045c9b8358
---
M make-wmf-branch/config.json
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/00/231900/1

diff --git a/make-wmf-branch/config.json b/make-wmf-branch/config.json
index 2124edc..3301c05 100644
--- a/make-wmf-branch/config.json
+++ b/make-wmf-branch/config.json
@@ -88,7 +88,6 @@
OAI,
OATHAuth,
OpenStackManager,
-   Oversight,
PagedTiffHandler,
PageImages,
PageTriage,

-- 
To view, visit https://gerrit.wikimedia.org/r/231900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I731cda24bb0c4a089b19a16733c64c045c9b8358
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disable Extension:Oversight - change (operations/mediawiki-config)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Disable Extension:Oversight
..


Disable Extension:Oversight

Bug: T62373
Change-Id: I41a953d545533b890e305981302af4d5a6261ea9
---
M wmf-config/CommonSettings.php
M wmf-config/extension-list
2 files changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 1bd34b9..7f15f8a 100755
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1131,12 +1131,6 @@
}
 }
 
-if ( $wgDBname === 'enwiki' ) {
-   require( $IP/extensions/Oversight/HideRevision.php );
-   $wgGroupPermissions['oversight']['hiderevision'] = false;
-   // $wgGroupPermissions['oversight']['oversight'] = true;
-}
-
 if ( extension_loaded( 'wikidiff2' ) ) {
$wgExternalDiffEngine = 'wikidiff2';
$wgDiff = false;
diff --git a/wmf-config/extension-list b/wmf-config/extension-list
index ea4e622..d7396e2 100644
--- a/wmf-config/extension-list
+++ b/wmf-config/extension-list
@@ -83,7 +83,6 @@
 $IP/extensions/Nuke/SpecialNuke.php
 $IP/extensions/OAI/OAIRepo.php
 $IP/extensions/OAuth/OAuth.php
-$IP/extensions/Oversight/HideRevision.php
 $IP/extensions/PagedTiffHandler/PagedTiffHandler.php
 $IP/extensions/PageImages/PageImages.php
 $IP/extensions/PageTriage/PageTriage.php

-- 
To view, visit https://gerrit.wikimedia.org/r/169612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41a953d545533b890e305981302af4d5a6261ea9
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move CSS specific to Special:Preferences to mediawiki.specia... - change (mediawiki/core)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231883

Change subject: Move CSS specific to Special:Preferences to 
mediawiki.special.preferences
..

Move CSS specific to Special:Preferences to mediawiki.special.preferences

Change-Id: I5da5d31137d446ea4c9b8e58972bc7c9aa7fc620
---
M resources/src/mediawiki.legacy/oldshared.css
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.special/mediawiki.special.preferences.css
3 files changed, 12 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/231883/1

diff --git a/resources/src/mediawiki.legacy/oldshared.css 
b/resources/src/mediawiki.legacy/oldshared.css
index 196ea21..4f90bae 100644
--- a/resources/src/mediawiki.legacy/oldshared.css
+++ b/resources/src/mediawiki.legacy/oldshared.css
@@ -256,14 +256,6 @@
color: #666;
 }
 
-fieldset.prefsection {
-   margin-top: 1em;
-}
-
-fieldset.operaprefsection {
-   margin-left: 15em;
-}
-
 /* emulate center */
 .center {
width: 100%;
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 248ea19..a761ea5 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -253,18 +253,6 @@
vertical-align: middle;
 }
 
-.prefsection td.mw-label {
-   width: 20%;
-}
-
-.prefsection table {
-   width: 100%;
-}
-
-.prefsection table.mw-htmlform-matrix {
-   width: auto;
-}
-
 .mw-icon-question {
/* SVG support using a transparent gradient to guarantee cross-browser
 * compatibility (browsers able to understand gradient syntax support 
also SVG).
diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.css 
b/resources/src/mediawiki.special/mediawiki.special.preferences.css
index 0e71d30..fb151d0 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.css
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.css
@@ -24,3 +24,15 @@
 .successbox {
display: none;
 }
+
+.prefsection td.mw-label {
+   width: 20%;
+}
+
+.prefsection table {
+   width: 100%;
+}
+
+.prefsection table.mw-htmlform-matrix {
+   width: auto;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/231883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da5d31137d446ea4c9b8e58972bc7c9aa7fc620
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] Fix indentation errors E122 and E127 - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231887

Change subject: [IMPROV] Fix indentation errors E122 and E127
..

[IMPROV] Fix indentation errors E122 and E127

Change-Id: I7348bf135cdb9ea4ef24677f8de359ba717200a9
---
M docs/conf.py
M pywikibot/data/wikidataquery.py
M pywikibot/flow.py
M tox.ini
4 files changed, 11 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/87/231887/1

diff --git a/docs/conf.py b/docs/conf.py
index 64c3114..d1263ad 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -175,16 +175,7 @@
 
 # -- Options for LaTeX output 
--
 
-latex_elements = {
-# The paper size ('letterpaper' or 'a4paper').
-#  'papersize': 'letterpaper',
-
-# The font size ('10pt', '11pt' or '12pt').
-#  'pointsize': '10pt',
-
-# Additional stuff for the LaTeX preamble.
-#  'preamble': '',
-}
+latex_elements = {}
 
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title, author, documentclass 
[howto/manual]).
diff --git a/pywikibot/data/wikidataquery.py b/pywikibot/data/wikidataquery.py
index 2d7ee3a..e965884 100644
--- a/pywikibot/data/wikidataquery.py
+++ b/pywikibot/data/wikidataquery.py
@@ -331,13 +331,13 @@
 
 def validate(self):
 return (self.isOrContainsOnlyTypes(self.item, int) and
-self.isOrContainsOnlyTypes(self.forward, int) and
-self.isOrContainsOnlyTypes(self.reverse, int))
+self.isOrContainsOnlyTypes(self.forward, int) and
+self.isOrContainsOnlyTypes(self.reverse, int))
 
 def __str__(self):
 return %s[%s][%s][%s] % (self.queryType, self.formatList(self.item),
-self.formatList(self.forward),
-self.formatList(self.reverse))
+   self.formatList(self.forward),
+   self.formatList(self.reverse))
 
 
 class Around(Query):
@@ -458,7 +458,7 @@
 
 
 def __init__(self, host=https://wdq.wmflabs.org;, cacheDir=None,
-cacheMaxAge=60):
+ cacheMaxAge=60):
 Constructor.
 self.host = host
 self.cacheMaxAge = cacheMaxAge
@@ -467,7 +467,7 @@
 self.cacheDir = cacheDir
 else:
 self.cacheDir = os.path.join(tempfile.gettempdir(),
-wikidataquery_cache)
+ wikidataquery_cache)
 
 def getUrl(self, queryStr):
 return %s/api?%s % (self.host, queryStr)
@@ -518,7 +518,7 @@
 data = pickle.load(f)
 except pickle.UnpicklingError:
 pywikibot.warning(uCouldn't read cached data from %s
-% cacheFile)
+  % cacheFile)
 data = None
 
 return data
diff --git a/pywikibot/flow.py b/pywikibot/flow.py
index 1580edb..1416bc4 100644
--- a/pywikibot/flow.py
+++ b/pywikibot/flow.py
@@ -103,8 +103,8 @@
 return new_params
 
 def topics(self, format='wikitext', limit=100, sort_by='newest',
-offset=None, offset_uuid='', reverse=False,
-include_offset=False, toc_only=False):
+   offset=None, offset_uuid='', reverse=False,
+   include_offset=False, toc_only=False):
 Load this board's topics.
 
 @param format: The content format to request the data in.
diff --git a/tox.ini b/tox.ini
index c2d6796..dd81fef 100644
--- a/tox.ini
+++ b/tox.ini
@@ -31,6 +31,7 @@
 
 [testenv:flake8-docstrings-mandatory]
 commands = flake8 \
+docs/conf.py \
 ez_setup.py \
 generate_user_files.py \
 pwb.py \

-- 
To view, visit https://gerrit.wikimedia.org/r/231887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7348bf135cdb9ea4ef24677f8de359ba717200a9
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise commodorefabia...@gmx.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] tox: add missing files - change (pywikibot/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [IMPROV] tox: add missing files
..


[IMPROV] tox: add missing files

Some files have been added which already work with flake8-docstrings-mandatory.

Change-Id: Id2a15700ea9520307fba960584833ce6182a
---
M tox.ini
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tox.ini b/tox.ini
index c2d6796..7877956 100644
--- a/tox.ini
+++ b/tox.ini
@@ -57,12 +57,18 @@
 pywikibot/page.py \
 pywikibot/pagegenerators.py \
 pywikibot/plural.py \
+pywikibot/proofreadpage.py \
 pywikibot/textlib.py \
 pywikibot/throttle.py \
+pywikibot/titletranslate.py \
 pywikibot/tools/ \
 pywikibot/userinterfaces/__init__.py \
 pywikibot/userinterfaces/terminal_interface.py \
+pywikibot/userinterfaces/terminal_interface_base.py \
+pywikibot/userinterfaces/terminal_interface_unix.py \
+pywikibot/version.py \
 pywikibot/weblib.py \
+pywikibot/xmlreader.py \
 scripts/__init__.py \
 scripts/add_text.py \
 scripts/basic.py \
@@ -76,9 +82,11 @@
 scripts/commonscat.py \
 scripts/coordinate_import.py \
 scripts/cosmetic_changes.py \
+scripts/create_categories.py \
 scripts/data_ingestion.py \
 scripts/delete.py \
 scripts/disambredir.py \
+scripts/djvutext.py \
 scripts/editarticle.py \
 scripts/fixing_redirects.py \
 scripts/flickrripper.py \
@@ -94,6 +102,7 @@
 scripts/newitem.py \
 scripts/noreferences.py \
 scripts/pagefromfile.py \
+scripts/patrol.py \
 scripts/piper.py \
 scripts/protect.py \
 scripts/selflink.py \
@@ -119,6 +128,7 @@
 tests/category_tests.py \
 tests/checkimages_tests.py \
 tests/cosmetic_changes_tests.py \
+tests/data/ \
 tests/data_ingestion_tests.py \
 tests/date_tests.py \
 tests/deletionbot_tests.py \
@@ -129,6 +139,7 @@
 tests/exceptions_tests.py \
 tests/family_tests.py \
 tests/file_tests.py \
+tests/flow_edit_tests.py \
 tests/flow_tests.py \
 tests/http_tests.py \
 tests/i18n/ \
@@ -158,6 +169,7 @@
 tests/upload_tests.py \
 tests/uploadbot_tests.py \
 tests/weblib_tests.py \
+tests/weblinkchecker_tests.py \
 tests/wikidataquery_tests.py \
 tests/wikistats_tests.py
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a15700ea9520307fba960584833ce6182a
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise commodorefabia...@gmx.de
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Xqt i...@gno.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [L10N] Update Arabic (ar) for welcome.py - change (pywikibot/core)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231892

Change subject: [L10N] Update Arabic (ar) for welcome.py
..

[L10N] Update Arabic (ar) for welcome.py

Bug: T109225
Change-Id: Ia013feb068ce5b80838f1f1ed45d6262dd1b859e
---
M scripts/welcome.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/92/231892/1

diff --git a/scripts/welcome.py b/scripts/welcome.py
index bc3ae1f..9b8b515 100755
--- a/scripts/welcome.py
+++ b/scripts/welcome.py
@@ -173,8 +173,8 @@
 # (C) Filnik, 2007-2011
 # (C) Daniel Herding, 2007
 # (C) Alex Shih-Han Lin, 2009-2010
-# (C) xqt, 2009-2011
-# (C) Pywikibot team, 2008-2010
+# (C) xqt, 2009-2015
+# (C) Pywikibot team, 2008-2015
 #
 # Distributed under the terms of the MIT license.
 #
@@ -265,6 +265,7 @@
 'zh-yue': u'{{歡迎}}--%s',
 },
 'wikinews': {
+'ar': '{{subst:ترحيب}} %s',
 'fa': u'{{خوشامد۲|%s}}',
 'it': u'{{subst:benvenuto}}',
 'zh': u'{{subst:welcome}} %s',

-- 
To view, visit https://gerrit.wikimedia.org/r/231892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia013feb068ce5b80838f1f1ed45d6262dd1b859e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Rename mediawiki.legacy.feeds to mediawiki.feedlink - change (mediawiki/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Rename mediawiki.legacy.feeds to mediawiki.feedlink
..


Rename mediawiki.legacy.feeds to mediawiki.feedlink

Follow-up to d51317ccc24940b77f4f7226d9455c801c09b457. There's nothing
legacy about this newly added module.

Also updated comments and marked the copy in shared.css for removal
when cached page renders expire.

Change-Id: Iabaebe9bf1e11a06bb951769693b1be4404e5b00
---
M includes/skins/SkinTemplate.php
M resources/Resources.php
M resources/src/mediawiki.legacy/shared.css
R resources/src/mediawiki/images/feed-icon.png
R resources/src/mediawiki/images/feed-icon.svg
R resources/src/mediawiki/mediawiki.feedlink.css
6 files changed, 13 insertions(+), 12 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index cc294f8..a1844a8 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -58,7 +58,7 @@
'mediawiki.sectionAnchor'
);
if ( $out-isSyndicated() ) {
-   $moduleStyles[] = 'mediawiki.legacy.feeds';
+   $moduleStyles[] = 'mediawiki.feedlink';
}
$out-addModuleStyles( $moduleStyles );
}
diff --git a/resources/Resources.php b/resources/Resources.php
index ec1523e..d575c8d 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -970,7 +970,10 @@
'feedback-useragent'
),
),
-
+   'mediawiki.feedlink' = array(
+   'position' = 'top',
+   'styles' = 'resources/src/mediawiki/mediawiki.feedlink.css',
+   ),
'mediawiki.filewarning' = array(
'scripts' = 'resources/src/mediawiki/mediawiki.filewarning.js',
'styles' = 
'resources/src/mediawiki/mediawiki.filewarning.less',
@@ -978,7 +981,6 @@
'oojs-ui',
),
),
-
'mediawiki.helplink' = array(
'position' = 'top',
'styles' = array(
@@ -1695,10 +1697,6 @@
 
/* MediaWiki Legacy */
 
-   'mediawiki.legacy.feeds' = array(
-   'position' = 'top',
-   'styles' = 'resources/src/mediawiki.legacy/feeds.css',
-   ),
'mediawiki.legacy.commonPrint' = array(
'position' = 'top',
'styles' = array(
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 248ea19..14fd286 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -493,13 +493,14 @@
 }
 
 /* feed links */
+/* To be removed before 1.26 release, moved to mediawiki.feedlink module */
 a.feedlink {
/* SVG support using a transparent gradient to guarantee cross-browser
 * compatibility (browsers able to understand gradient syntax support 
also SVG).
 * 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
-   background-image: url(images/feed-icon.png);
-   background-image: -webkit-linear-gradient(transparent, transparent), 
url(images/feed-icon.svg);
-   background-image: linear-gradient(transparent, transparent), 
url(images/feed-icon.svg);
+   background-image: url(../mediawiki/images/feed-icon.png);
+   background-image: -webkit-linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
+   background-image: linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
background-position: center left;
background-repeat: no-repeat;
background-size: 12px 12px;
diff --git a/resources/src/mediawiki.legacy/images/feed-icon.png 
b/resources/src/mediawiki/images/feed-icon.png
similarity index 100%
rename from resources/src/mediawiki.legacy/images/feed-icon.png
rename to resources/src/mediawiki/images/feed-icon.png
Binary files differ
diff --git a/resources/src/mediawiki.legacy/images/feed-icon.svg 
b/resources/src/mediawiki/images/feed-icon.svg
similarity index 100%
rename from resources/src/mediawiki.legacy/images/feed-icon.svg
rename to resources/src/mediawiki/images/feed-icon.svg
diff --git a/resources/src/mediawiki.legacy/feeds.css 
b/resources/src/mediawiki/mediawiki.feedlink.css
similarity index 69%
rename from resources/src/mediawiki.legacy/feeds.css
rename to resources/src/mediawiki/mediawiki.feedlink.css
index 9737fd4..1dda2ac 100644
--- a/resources/src/mediawiki.legacy/feeds.css
+++ b/resources/src/mediawiki/mediawiki.feedlink.css
@@ -1,5 +1,7 @@
-/* Extracted from mediawiki.legacy.shared, which no longer @embeds the
- * background image. The selector below must be more specific. */
+/* Styles for links to RSS/Atom feeds in sidebar */
+
+/* Until the copy of this code

[MediaWiki-commits] [Gerrit] Migration script: Set last revision ID when ignoring a row - change (mediawiki...Oversight)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Migration script: Set last revision ID when ignoring a row
..


Migration script: Set last revision ID when ignoring a row

Otherwise you enter an infinite loop when you ignore all rows in a batch

Bug: T62373
Change-Id: I08b3920940a1f60cd6d0ca03bd95262af0e02025
---
M migrateToRevDel.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/migrateToRevDel.php b/migrateToRevDel.php
index 0cc38ca..87088d2 100644
--- a/migrateToRevDel.php
+++ b/migrateToRevDel.php
@@ -121,12 +121,14 @@
array( 'LIMIT' = $this-mBatchSize, 'ORDER BY' 
= 'hidden_rev_id' ),
array( 'user' = array( 'INNER JOIN', 'user_id 
= hidden_by_user' ) )
);
+
$insertLoggingData = array();
$insertRevisionData = array();
$insertArchiveData = array();
foreach ( $hiddenRows as $hiddenRow ) {
if ( Revision::newFromId( 
$hiddenRow-hidden_rev_id ) ) {
$this-output( Ignoring revision 
{$hiddenRow-hidden_rev_id} as it is already in the revision table.\n );
+   $lastRevId = $hiddenRow-hidden_rev_id;
continue;
}
$insertData = array();
@@ -171,6 +173,7 @@
__METHOD__
) ) {
$this-output( Ignoring revision 
{$hiddenRow-hidden_rev_id} as it is already in the archive table.\n );
+   $lastRevId = $hiddenRow-hidden_rev_id;
continue;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08b3920940a1f60cd6d0ca03bd95262af0e02025
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Oversight
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [tox] shorten lines beneath 10 chars. - change (pywikibot/core)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231896

Change subject: [tox] shorten lines beneath 10 chars.
..

[tox] shorten lines beneath 10 chars.

Change-Id: Idf2e45db2f83e9ea1a473b25430bc49b8a829e1d
---
M pywikibot/site_detect.py
M scripts/harvest_template.py
M scripts/interwiki.py
3 files changed, 39 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/96/231896/1

diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py
index fed47e9..7718e87 100644
--- a/pywikibot/site_detect.py
+++ b/pywikibot/site_detect.py
@@ -41,7 +41,8 @@
 if sys.version_info[0]  2:
 uo.charset = uo.headers.get_content_charset()
 else:
-uo.charset = 
uo.headers.getfirstmatchingheader('Content-Type')[0].strip().split('charset=')[1]
+uo.charset = uo.headers.getfirstmatchingheader(
+'Content-Type')[0].strip().split('charset=')[1]
 except IndexError:
 uo.charset = 'latin-1'
 return uo
@@ -68,7 +69,8 @@
 except HTTPError as e:
 if e.code != 404:
 raise
-data = e.read().decode('latin-1')  # don't care about mojibake for 
errors
+# don't care about mojibake for errors
+data = e.read().decode('latin-1')
 pass
 
 wp = WikiHTMLPageParser()
diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py
index ec5fc3b..35e1a8c 100755
--- a/scripts/harvest_template.py
+++ b/scripts/harvest_template.py
@@ -85,7 +85,8 @@
 pywikibot.error(u'Template %s does not exist.' % temp.title())
 exit()
 
-pywikibot.output('Finding redirects...')  # Put some output here since 
it can take a while
+# Put some output here since it can take a while
+pywikibot.output('Finding redirects...')
 if temp.isRedirectPage():
 temp = temp.getRedirectTarget()
 titles = [page.title(withNamespace=False)
@@ -143,7 +144,9 @@
 template = pywikibot.Page(page.site, template,
   ns=10).title(withNamespace=False)
 except pywikibot.exceptions.InvalidTitle:
-pywikibot.error(uFailed parsing template; '%s' should be the 
template name. % template)
+pywikibot.error(
+'Failed parsing template; '%s' should be the template 
name.'
+% template)
 continue
 # We found the template we were looking for
 if template in self.templateTitles:
@@ -191,11 +194,15 @@
 if image.isRedirectPage():
 image = 
pywikibot.FilePage(image.getRedirectTarget())
 if not image.exists():
-pywikibot.output('[[%s]] doesn\'t exist so 
I can\'t link to it' % (image.title(),))
+pywikibot.output(
+'[[%s]] doesn\'t exist so I can\'t 
link to it'
+% (image.title(),))
 continue
 claim.setTarget(image)
 else:
-pywikibot.output(%s is not a supported 
datatype. % claim.type)
+pywikibot.output(
+'%s is not a supported datatype.'
+% claim.type)
 continue
 
 pywikibot.output('Adding %s -- %s'
diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index eabe727..4100b41 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -358,7 +358,8 @@
 
 import pywikibot
 
-from pywikibot import config, i18n, pagegenerators, textlib, interwiki_graph, 
titletranslate
+from pywikibot import config, i18n, pagegenerators, textlib, interwiki_graph
+from pywikibot import titletranslate
 from pywikibot.bot import ListOption, StandardOption
 from pywikibot.tools import first_upper
 
@@ -584,7 +585,8 @@
 elif arg.startswith('-neverlink:'):
 self.neverlink += arg[11:].split(,)
 elif arg.startswith('-ignore:'):
-self.ignore += [pywikibot.Page(pywikibot.Site(), p) for p in 
arg[8:].split(,)]
+self.ignore += [pywikibot.Page(pywikibot.Site(), p)
+for p in arg[8:].split(',')]
 elif arg.startswith('-ignorefile:'):
 ignorefile = arg[12:]
 ignorePageGen = pagegenerators.TextfilePageGenerator(ignorefile)
@@ -1055,7 +1057,8 @@
 return False
 if globalvar.autonomous:
 pywikibot.output(
-uNOTE: Ignoring link from page %s in namespace %i to page %s in namespace %i.
+

[MediaWiki-commits] [Gerrit] Fail gracefully when UploadWizard is disabled - change (mediawiki...UploadWizard)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231888

Change subject: Fail gracefully when UploadWizard is disabled
..

Fail gracefully when UploadWizard is disabled

* Do not add id=upload-wizard to the error message displayed when
  UploadWizard is disabled.
* When no element with id=upload-wizard is present, do not try to
  build UI. (Previously it failed with cryptic errors deep in the code.)

Change-Id: I481dd11c233123ef92b3f3419c73c75a2f680e34
---
M includes/specials/SpecialUploadWizard.php
M resources/mw.UploadWizardPage.js
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/88/231888/1

diff --git a/includes/specials/SpecialUploadWizard.php 
b/includes/specials/SpecialUploadWizard.php
index f4e30f4..9c62288 100644
--- a/includes/specials/SpecialUploadWizard.php
+++ b/includes/specials/SpecialUploadWizard.php
@@ -327,8 +327,8 @@
if ( array_key_exists( 'fallbackToAltUploadForm', $config )
 array_key_exists( 'altUploadForm', $config )
 $config['altUploadForm'] != ''
-$config[ 'fallbackToAltUploadForm' ] 
) {
-
+$config[ 'fallbackToAltUploadForm' ]
+   ) {
$linkHtml = '';
$altUploadForm = Title::newFromText( $config[ 
'altUploadForm' ] );
if ( $altUploadForm instanceof Title ) {
@@ -342,7 +342,7 @@
return
Html::rawElement(
'div',
-   array( 'id' = 'upload-wizard', 'class' 
= 'upload-section' ),
+   array(),
Html::rawElement(
'p',
array( 'style' = 'text-align: 
center' ),
diff --git a/resources/mw.UploadWizardPage.js b/resources/mw.UploadWizardPage.js
index f02464f..d9a033f 100644
--- a/resources/mw.UploadWizardPage.js
+++ b/resources/mw.UploadWizardPage.js
@@ -16,6 +16,11 @@
 
// Default configuration value that cannot be removed
config.maxUploads = config.maxUploads || 10;
+   
+   if ( $( '#upload-wizard' ).length === 0 ) {
+   mw.log( 'UploadWizard is disabled, nothing to do.' );
+   return;
+   }
 
uploadWizard = new mw.UploadWizard( config );
uploadWizard.createInterface( '#upload-wizard' );

-- 
To view, visit https://gerrit.wikimedia.org/r/231888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I481dd11c233123ef92b3f3419c73c75a2f680e34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Install texlive-extra-utils on mw appservers - change (operations/puppet)

2015-08-16 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231889

Change subject: Install texlive-extra-utils on mw appservers
..

Install texlive-extra-utils on mw appservers

Bug: T109195
Change-Id: I72c821001d2fa9ab1f872299f60cf91ab2484d2d
---
M modules/mediawiki/manifests/packages.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/89/231889/1

diff --git a/modules/mediawiki/manifests/packages.pp 
b/modules/mediawiki/manifests/packages.pp
index 125aa56..b4e7166 100644
--- a/modules/mediawiki/manifests/packages.pp
+++ b/modules/mediawiki/manifests/packages.pp
@@ -24,6 +24,7 @@
 package { [
 'texlive',
 'texlive-bibtex-extra',
+'texlive-extra-utils',
 'texlive-font-utils',
 'texlive-fonts-extra',
 'texlive-lang-all',

-- 
To view, visit https://gerrit.wikimedia.org/r/231889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72c821001d2fa9ab1f872299f60cf91ab2484d2d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use meta.wikimedia.org/api/rest_v1 instead of parsoid-lb in ... - change (operations/puppet)

2015-08-16 Thread Alex Monk (Code Review)

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231890

Change subject: Use meta.wikimedia.org/api/rest_v1 instead of parsoid-lb in the 
sysadmin table script
..

Use meta.wikimedia.org/api/rest_v1 instead of parsoid-lb in the sysadmin table 
script

Change-Id: I67809d57ec412d6eac30ba094fabe79cd48f3b2f
---
M modules/admin/files/GenSysadminTable.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/90/231890/1

diff --git a/modules/admin/files/GenSysadminTable.py 
b/modules/admin/files/GenSysadminTable.py
index b310933..df4099a 100644
--- a/modules/admin/files/GenSysadminTable.py
+++ b/modules/admin/files/GenSysadminTable.py
@@ -12,8 +12,8 @@
 except:
 import urllib2 as urllib
 
-parsoidUrl = http://parsoid-lb.eqiad.wikimedia.org; + \
- /metawiki/System_administrators
+parsoidUrl = https://meta.wikimedia.org/api/rest_v1; + \
+ /page/html/System_administrators
 bs = BeautifulSoup(urllib.urlopen(parsoidUrl).read())
 oldUserData = {}
 for table in bs.find_all('table')[:-2]:

-- 
To view, visit https://gerrit.wikimedia.org/r/231890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67809d57ec412d6eac30ba094fabe79cd48f3b2f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alex Monk kren...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] Add docstrings - change (pywikibot/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [IMPROV] Add docstrings
..


[IMPROV] Add docstrings

Change-Id: Idd9212a92a9fd3e2592dc1b7dcb4879d053e0987
---
M pywikibot/data/wikidataquery.py
M pywikibot/flow.py
M pywikibot/logentries.py
M pywikibot/userinterfaces/terminal_interface_win32.py
M pywikibot/userinterfaces/transliteration.py
M pywikibot/userinterfaces/win32_unicode.py
M tests/page_tests.py
M tests/python_tests.py
M tests/reflinks_tests.py
M tests/timestamp_tests.py
M tests/wikibase_edit_tests.py
M tests/xmlreader_tests.py
M tox.ini
13 files changed, 120 insertions(+), 2 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/data/wikidataquery.py b/pywikibot/data/wikidataquery.py
index 2d7ee3a..8a40510 100644
--- a/pywikibot/data/wikidataquery.py
+++ b/pywikibot/data/wikidataquery.py
@@ -112,6 +112,7 @@
 return s
 
 def __repr__(self):
+Return a string representation.
 return uQuerySet(%s) % self
 
 
@@ -201,6 +202,7 @@
 return True
 
 def validateOrRaise(self, msg=None):
+Validate the contents and raise TypeError if the validation 
fails.
 if not self.validate():
 raise TypeError(msg)
 
@@ -221,6 +223,7 @@
 return int(item)
 
 def convertWDTypes(self, items):
+Convert the items into integer IDs using L{Query.convertWDType}.
 return [self.convertWDType(x) for x in listify(items)]
 
 def __str__(self):
@@ -234,6 +237,7 @@
 raise NotImplementedError
 
 def __repr__(self):
+Return a string representation.
 return uQuery(%s) % self
 
 
@@ -262,6 +266,7 @@
 self.validateOrRaise()
 
 def formatItems(self):
+Format the items when they are a list.
 res = ''
 if self.items:
 res += : + ,.join([self.formatItem(x) for x in self.items])
@@ -269,9 +274,11 @@
 return res
 
 def validate(self):
+Validate that the items are ints or Querys.
 return self.isOrContainsOnlyTypes(self.items, [int, Query])
 
 def __str__(self):
+Return the query string for the API.
 if isinstance(self.items, list):
 return %s[%s%s] % (self.queryType, self.prop, self.formatItems())
 elif isinstance(self.items, Query):
@@ -296,6 +303,7 @@
 return '%s' % x
 
 def validate(self):
+Validate that the items are strings.
 return self.isOrContainsOnlyTypes(self.items, basestring)
 
 
@@ -330,11 +338,13 @@
 self.validateOrRaise()
 
 def validate(self):
+Validate that the item, forward and reverse are all ints.
 return (self.isOrContainsOnlyTypes(self.item, int) and
 self.isOrContainsOnlyTypes(self.forward, int) and
 self.isOrContainsOnlyTypes(self.reverse, int))
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s][%s][%s] % (self.queryType, self.formatList(self.item),
 self.formatList(self.forward),
 self.formatList(self.reverse))
@@ -354,9 +364,11 @@
 self.rad = rad
 
 def validate(self):
+Validate that the prop is an int.
 return isinstance(self.prop, int)
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s,%s,%s,%s] % (self.queryType, self.prop,
 self.lt, self.lg, self.rad)
 
@@ -383,9 +395,11 @@
 self.end = end
 
 def validate(self):
+Validate that a range is given and the prop is an int.
 return (self.begin or self.end) and isinstance(self.prop, int)
 
 def __str__(self):
+Return the query string for the API.
 begin = self.begin.toTimestr() if self.begin else ''
 
 # if you don't have an end, you don't put in the comma
@@ -410,9 +424,11 @@
 self.validateOrRaise()
 
 def validate(self):
+Validate that the link is a string.
 return self.isOrContainsOnlyTypes(self.link, basestring)
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s] % (self.queryType, self.formatList(self.link))
 
 
@@ -470,6 +486,7 @@
 wikidataquery_cache)
 
 def getUrl(self, queryStr):
+Get the URL given the query string.
 return %s/api?%s % (self.host, queryStr)
 
 def getQueryString(self, q, labels=[], props=[]):
diff --git a/pywikibot/flow.py b/pywikibot/flow.py
index 1580edb..5677db9 100644
--- a/pywikibot/flow.py
+++ b/pywikibot/flow.py
@@ -70,6 +70,7 @@
 return self._uuid
 
 def get(self, force=False, get_redirect=False, sysop=False):
+Get the page's content.
 if get_redirect or force or sysop:
 raise NotImplementedError
 
diff

[MediaWiki-commits] [Gerrit] CSSMin: remove dot segments in relative local URLs - change (mediawiki/core)

2015-08-16 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231897

Change subject: CSSMin: remove dot segments in relative local URLs
..

CSSMin: remove dot segments in relative local URLs

Call wfRemoveDotSegments() (if available) on relative local URLs, so that
relative dot segments are collapsed.

Change-Id: Icc1c23a2a7d96c869412965bd8c3730d3c3b3a53
---
M includes/libs/CSSMin.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/231897/1

diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php
index f415c9b..118463a 100644
--- a/includes/libs/CSSMin.php
+++ b/includes/libs/CSSMin.php
@@ -399,7 +399,7 @@
 
if ( $local === false ) {
// Assume that all paths are relative to $remote, and 
make them absolute
-   return $remote . '/' . $url;
+   $url = $remote . '/' . $url;
} else {
// We drop the query part here and instead make the 
path relative to $remote
$url = {$remote}/{$file};
@@ -418,8 +418,11 @@
}
// If any of these conditions failed (file missing, we 
don't want to embed it
// or it's not embeddable), return the URL (possibly 
with ?timestamp part)
-   return $url;
}
+   if ( function_exists( 'wfRemoveDotSegments' ) ) {
+   $url = wfRemoveDotSegments( $url );
+   }
+   return $url;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/231897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc1c23a2a7d96c869412965bd8c3730d3c3b3a53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Migration script: Set last revision ID when ignoring a row - change (mediawiki...Oversight)

2015-08-16 Thread Alex Monk (Code Review)

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231898

Change subject: Migration script: Set last revision ID when ignoring a row
..

Migration script: Set last revision ID when ignoring a row

Otherwise you enter an infinite loop when you ignore all rows in a batch

Bug: T62373
Change-Id: I08b3920940a1f60cd6d0ca03bd95262af0e02025
---
M migrateToRevDel.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Oversight 
refs/changes/98/231898/1

diff --git a/migrateToRevDel.php b/migrateToRevDel.php
index 0cc38ca..87088d2 100644
--- a/migrateToRevDel.php
+++ b/migrateToRevDel.php
@@ -121,12 +121,14 @@
array( 'LIMIT' = $this-mBatchSize, 'ORDER BY' 
= 'hidden_rev_id' ),
array( 'user' = array( 'INNER JOIN', 'user_id 
= hidden_by_user' ) )
);
+
$insertLoggingData = array();
$insertRevisionData = array();
$insertArchiveData = array();
foreach ( $hiddenRows as $hiddenRow ) {
if ( Revision::newFromId( 
$hiddenRow-hidden_rev_id ) ) {
$this-output( Ignoring revision 
{$hiddenRow-hidden_rev_id} as it is already in the revision table.\n );
+   $lastRevId = $hiddenRow-hidden_rev_id;
continue;
}
$insertData = array();
@@ -171,6 +173,7 @@
__METHOD__
) ) {
$this-output( Ignoring revision 
{$hiddenRow-hidden_rev_id} as it is already in the archive table.\n );
+   $lastRevId = $hiddenRow-hidden_rev_id;
continue;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08b3920940a1f60cd6d0ca03bd95262af0e02025
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Oversight
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Unit testing for Newsletter extension - change (mediawiki...Newsletter)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Unit testing for Newsletter extension
..


Unit testing for Newsletter extension

Version 1 of unit test to check the case of user trying
to subscribe and unsubscribe to existing newsletters.

Bug: T108202
Change-Id: I048e0feaf0879403bb7c4c28b076f323a17092e9
---
M Newsletter.hooks.php
M Newsletter.php
A tests/ApiNewsletterTest.php
3 files changed, 95 insertions(+), 0 deletions(-)

Approvals:
  01tonythomas: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Newsletter.hooks.php b/Newsletter.hooks.php
index 0ccfac6..b25e66f 100755
--- a/Newsletter.hooks.php
+++ b/Newsletter.hooks.php
@@ -73,4 +73,10 @@
 
return true;
}
+
+   public static function onUnitTestsList( $files ) {
+   $files = array_merge( $files, glob( __DIR__ . 
'/tests/*Test.php' ) );
+
+   return true;
+   }
 }
diff --git a/Newsletter.php b/Newsletter.php
index a5bb680..56c4237 100755
--- a/Newsletter.php
+++ b/Newsletter.php
@@ -76,3 +76,4 @@
 $wgHooks['LoadExtensionSchemaUpdates'][] = 
'NewsletterHooks::onLoadExtensionSchemaUpdates';
 $wgHooks['BeforeCreateEchoEvent'][] = 
'NewsletterHooks::onBeforeCreateEchoEvent';
 $wgHooks['EchoGetDefaultNotifiedUsers'][] = 
'NewsletterHooks::onEchoGetDefaultNotifiedUsers';
+$wgHooks['UnitTestsList'][] = 'NewsletterHooks::onUnitTestsList';
diff --git a/tests/ApiNewsletterTest.php b/tests/ApiNewsletterTest.php
new file mode 100644
index 000..8475145
--- /dev/null
+++ b/tests/ApiNewsletterTest.php
@@ -0,0 +1,88 @@
+?php
+/**
+ * Unit test to test Api module - ApiNewsletter
+ *
+ * @group API
+ * @group medium
+ * @group Database
+ * @covers ApiNewsletter
+ * @author Tina Johnson
+ */
+
+class ApiNewsletterTest extends ApiTestCase {
+   protected  function setUp() {
+   parent::setUp();
+   $dbw = wfGetDB( DB_MASTER );
+
+   $user = User::newFromName( Owner );
+   $user-addToDatabase();
+
+   $rowData = array(
+   'nl_name' = 'MyNewsletter',
+   'nl_desc' = 'This is a newsletter',
+   'nl_main_page_id' = 1,
+   'nl_frequency' = 'monthly',
+   'nl_owner_id' = $user-getId()
+   );
+   $dbw-insert( 'nl_newsletters', $rowData, __METHOD__ );
+   $this-tablesUsed = array( 'nl_newsletters' );
+}
+
+   protected function getNewsletterId() {
+   $dbr = wfGetDB( DB_SLAVE );
+   $res = $dbr-select(
+   'nl_newsletters',
+   array( 'nl_id' ),
+   array(
+   'nl_name' = 'MyNewsletter'
+   ),
+   __METHOD__
+   );
+   $newsletterId = null;
+   foreach ( $res as $row ) {
+   $newsletterId = $row-nl_id;
+   }
+
+   return $newsletterId;
+   }
+
+   function testApiNewsletterForSubscribingNewsletter() {
+   $this-doApiRequest( array(
+   'action' = 'newsletterapi',
+   'newsletterId' = $this-getNewsletterId(),
+   'todo' = 'subscribe'
+   ) );
+
+   $dbr = wfGetDB( DB_SLAVE );
+   $result = $dbr-selectRowCount(
+   'nl_subscriptions',
+   array( 'subscriber_id' ),
+   array(
+   'newsletter_id' = $this-getNewsletterId()
+   ),
+   __METHOD__
+   );
+
+   $this-assertEquals( $result, 1 );
+   }
+
+   function testApiNewsletterForUnsubscribingNewsletter() {
+   $this-doApiRequest( array(
+   'action' = 'newsletterapi',
+   'newsletterId' = $this-getNewsletterId(),
+   'todo' = 'unsubscribe'
+   ) );
+
+   $dbr = wfGetDB( DB_SLAVE );
+   $result = $dbr-selectRowCount(
+   'nl_subscriptions',
+   array( 'subscriber_id' ),
+   array(
+   'newsletter_id' = $this-getNewsletterId()
+   ),
+   __METHOD__
+   );
+
+   $this-assertEquals( $result, 0 );
+   }
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/231599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I048e0feaf0879403bb7c4c28b076f323a17092e9
Gerrit-PatchSet: 11
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Tinaj1234 tinajohnson.1...@gmail.com
Gerrit-Reviewer: 01tonythomas

[MediaWiki-commits] [Gerrit] Rename mediawiki.legacy.feeds to mediawiki.feedlink - change (mediawiki/core)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231879

Change subject: Rename mediawiki.legacy.feeds to mediawiki.feedlink
..

Rename mediawiki.legacy.feeds to mediawiki.feedlink

Follow-up to d51317ccc24940b77f4f7226d9455c801c09b457. There's nothing
legacy about this newly added module.

Also updated comments and marked the copy in shared.css for removal
when cached page renders expire.

Change-Id: Iabaebe9bf1e11a06bb951769693b1be4404e5b00
---
M includes/skins/SkinTemplate.php
M resources/Resources.php
M resources/src/mediawiki.legacy/shared.css
R resources/src/mediawiki/images/feed-icon.png
R resources/src/mediawiki/images/feed-icon.svg
R resources/src/mediawiki/mediawiki.feedlink.css
6 files changed, 13 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/231879/1

diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index cc294f8..a1844a8 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -58,7 +58,7 @@
'mediawiki.sectionAnchor'
);
if ( $out-isSyndicated() ) {
-   $moduleStyles[] = 'mediawiki.legacy.feeds';
+   $moduleStyles[] = 'mediawiki.feedlink';
}
$out-addModuleStyles( $moduleStyles );
}
diff --git a/resources/Resources.php b/resources/Resources.php
index ec1523e..d575c8d 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -970,7 +970,10 @@
'feedback-useragent'
),
),
-
+   'mediawiki.feedlink' = array(
+   'position' = 'top',
+   'styles' = 'resources/src/mediawiki/mediawiki.feedlink.css',
+   ),
'mediawiki.filewarning' = array(
'scripts' = 'resources/src/mediawiki/mediawiki.filewarning.js',
'styles' = 
'resources/src/mediawiki/mediawiki.filewarning.less',
@@ -978,7 +981,6 @@
'oojs-ui',
),
),
-
'mediawiki.helplink' = array(
'position' = 'top',
'styles' = array(
@@ -1695,10 +1697,6 @@
 
/* MediaWiki Legacy */
 
-   'mediawiki.legacy.feeds' = array(
-   'position' = 'top',
-   'styles' = 'resources/src/mediawiki.legacy/feeds.css',
-   ),
'mediawiki.legacy.commonPrint' = array(
'position' = 'top',
'styles' = array(
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 248ea19..14fd286 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -493,13 +493,14 @@
 }
 
 /* feed links */
+/* To be removed before 1.26 release, moved to mediawiki.feedlink module */
 a.feedlink {
/* SVG support using a transparent gradient to guarantee cross-browser
 * compatibility (browsers able to understand gradient syntax support 
also SVG).
 * 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
-   background-image: url(images/feed-icon.png);
-   background-image: -webkit-linear-gradient(transparent, transparent), 
url(images/feed-icon.svg);
-   background-image: linear-gradient(transparent, transparent), 
url(images/feed-icon.svg);
+   background-image: url(../mediawiki/images/feed-icon.png);
+   background-image: -webkit-linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
+   background-image: linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
background-position: center left;
background-repeat: no-repeat;
background-size: 12px 12px;
diff --git a/resources/src/mediawiki.legacy/images/feed-icon.png 
b/resources/src/mediawiki/images/feed-icon.png
similarity index 100%
rename from resources/src/mediawiki.legacy/images/feed-icon.png
rename to resources/src/mediawiki/images/feed-icon.png
Binary files differ
diff --git a/resources/src/mediawiki.legacy/images/feed-icon.svg 
b/resources/src/mediawiki/images/feed-icon.svg
similarity index 100%
rename from resources/src/mediawiki.legacy/images/feed-icon.svg
rename to resources/src/mediawiki/images/feed-icon.svg
diff --git a/resources/src/mediawiki.legacy/feeds.css 
b/resources/src/mediawiki/mediawiki.feedlink.css
similarity index 69%
rename from resources/src/mediawiki.legacy/feeds.css
rename to resources/src/mediawiki/mediawiki.feedlink.css
index 9737fd4..1dda2ac 100644
--- a/resources/src/mediawiki.legacy/feeds.css
+++ b/resources/src/mediawiki/mediawiki.feedlink.css
@@ -1,5 +1,7 @@
-/* Extracted from mediawiki.legacy.shared, which no longer @embeds the
- * background image. The selector below must be more specific. */
+/* Styles for links to RSS/Atom feeds

[MediaWiki-commits] [Gerrit] Move HTMLForm-specific styles out of mediawiki.legacy.shared - change (mediawiki/core)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231885

Change subject: Move HTMLForm-specific styles out of mediawiki.legacy.shared
..

Move HTMLForm-specific styles out of mediawiki.legacy.shared

Bug: T89981
Change-Id: Idcd20b4a776fe6741462b09885e05d1e08f67334
---
M includes/htmlform/HTMLForm.php
M resources/Resources.php
M resources/src/mediawiki.legacy/shared.css
R resources/src/mediawiki/images/question.png
R resources/src/mediawiki/images/question.svg
A resources/src/mediawiki/mediawiki.htmlform.css
6 files changed, 56 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/231885/1

diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php
index da58f20..ad650d4 100644
--- a/includes/htmlform/HTMLForm.php
+++ b/includes/htmlform/HTMLForm.php
@@ -868,6 +868,7 @@
# For good measure (it is the default)
$this-getOutput()-preventClickjacking();
$this-getOutput()-addModules( 'mediawiki.htmlform' );
+   $this-getOutput()-addModuleStyles( 
'mediawiki.htmlform.styles' );
 
$html = ''
. $this-getErrors( $submitResult )
diff --git a/resources/Resources.php b/resources/Resources.php
index ec1523e..4965dd2 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1009,6 +1009,10 @@
'colon-separator',
),
),
+   'mediawiki.htmlform.styles' = array(
+   'styles' = 'resources/src/mediawiki/mediawiki.htmlform.css',
+   'position' = 'top',
+   ),
'mediawiki.htmlform.ooui.styles' = array(
'styles' = 
'resources/src/mediawiki/mediawiki.htmlform.ooui.css',
'position' = 'top',
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index a761ea5..5aafdf1 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -253,54 +253,8 @@
vertical-align: middle;
 }
 
-.mw-icon-question {
-   /* SVG support using a transparent gradient to guarantee cross-browser
-* compatibility (browsers able to understand gradient syntax support 
also SVG).
-* 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
-   background-image: url(images/question.png);
-   background-image: -webkit-linear-gradient(transparent, transparent), 
url(images/question.svg);
-   background-image: linear-gradient(transparent, transparent), 
url(images/question.svg);
-   background-repeat: no-repeat;
-   background-size: 13px 13px;
-   display: inline-block;
-   height: 13px;
-   width: 13px;
-   margin-left: 4px;
-}
-
-.mw-icon-question:lang(ar),
-.mw-icon-question:lang(fa),
-.mw-icon-question:lang(ur) {
-   -webkit-transform: scaleX(-1);
-   -ms-transform: scaleX(-1);
-   transform: scaleX(-1);
-}
-
 td.mw-submit {
white-space: nowrap;
-}
-
-table.mw-htmlform-nolabel td.mw-label {
-   width: 1px;
-}
-
-tr.mw-htmlform-vertical-label td.mw-label {
-   text-align: left !important;
-}
-
-.mw-htmlform-invalid-input td.mw-input input {
-   border-color: red;
-}
-
-.mw-htmlform-flatlist div.mw-htmlform-flatlist-item {
-   display: inline;
-   margin-right: 1em;
-   white-space: nowrap;
-}
-
-.mw-htmlform-matrix td {
-   padding-left: 0.5em;
-   padding-right: 0.5em;
 }
 
 input#wpSummary {
diff --git a/resources/src/mediawiki.legacy/images/question.png 
b/resources/src/mediawiki/images/question.png
similarity index 100%
rename from resources/src/mediawiki.legacy/images/question.png
rename to resources/src/mediawiki/images/question.png
Binary files differ
diff --git a/resources/src/mediawiki.legacy/images/question.svg 
b/resources/src/mediawiki/images/question.svg
similarity index 100%
rename from resources/src/mediawiki.legacy/images/question.svg
rename to resources/src/mediawiki/images/question.svg
diff --git a/resources/src/mediawiki/mediawiki.htmlform.css 
b/resources/src/mediawiki/mediawiki.htmlform.css
new file mode 100644
index 000..e41248c
--- /dev/null
+++ b/resources/src/mediawiki/mediawiki.htmlform.css
@@ -0,0 +1,51 @@
+/* HTMLForm styles */
+
+table.mw-htmlform-nolabel td.mw-label {
+   width: 1px;
+}
+
+.mw-htmlform-invalid-input td.mw-input input {
+   border-color: red;
+}
+
+.mw-htmlform-flatlist div.mw-htmlform-flatlist-item {
+   display: inline;
+   margin-right: 1em;
+   white-space: nowrap;
+}
+
+/* HTMLCheckMatrix */
+
+.mw-htmlform-matrix td {
+   padding-left: 0.5em;
+   padding-right: 0.5em;
+}
+
+tr.mw-htmlform-vertical-label td.mw-label {
+   text-align: left !important;
+}
+
+.mw-icon-question {
+   /* SVG support using a transparent gradient to guarantee cross-browser

[MediaWiki-commits] [Gerrit] Remove unused misnamed .prefsectiontip CSS class from Usercr... - change (mediawiki/core)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231884

Change subject: Remove unused misnamed .prefsectiontip CSS class from 
Usercreate template
..

Remove unused misnamed .prefsectiontip CSS class from Usercreate template

Presumably copied from Special:Preferences ages ago, then disappeared
at the original place together with the styles.

Change-Id: I89cc5ebaa4e96bad186fda4c97fc6e6fe5d230c7
---
M includes/templates/Usercreate.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/231884/1

diff --git a/includes/templates/Usercreate.php 
b/includes/templates/Usercreate.php
index c17d575..96f81bb 100644
--- a/includes/templates/Usercreate.php
+++ b/includes/templates/Usercreate.php
@@ -186,7 +186,7 @@
input type='text' class='mw-ui-input 
loginText' name=wpRealName id=wpRealName
tabindex=7
value=?php $this-text( 
'realname' ); ? size='20' /
-   div class=prefsectiontip
+   div
?php $this-msgWiki( 
$this-data['loggedin'] ? 'createacct-another-realname-tip' : 
'prefs-help-realname' ); ?
/div
/div
@@ -247,7 +247,7 @@
/
?php } ?
?php if ( 
$inputItem['helptext'] !== false ) { ?
-   div 
class=prefsectiontip
+   div
?php 
$this-msgWiki( $inputItem['helptext'] ); ?
/div
?php } ?

-- 
To view, visit https://gerrit.wikimedia.org/r/231884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89cc5ebaa4e96bad186fda4c97fc6e6fe5d230c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] tox: add missing files - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231891

Change subject: [IMPROV] tox: add missing files
..

[IMPROV] tox: add missing files

Some files have been added which already work with flake8-docstrings-mandatory.

Change-Id: Id2a15700ea9520307fba960584833ce6182a
---
M tox.ini
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/91/231891/1

diff --git a/tox.ini b/tox.ini
index c2d6796..e0d8251 100644
--- a/tox.ini
+++ b/tox.ini
@@ -57,12 +57,20 @@
 pywikibot/page.py \
 pywikibot/pagegenerators.py \
 pywikibot/plural.py \
+pywikibot/proofreadpage.py \
 pywikibot/textlib.py \
 pywikibot/throttle.py \
+pywikibot/titletranslate.py \
 pywikibot/tools/ \
 pywikibot/userinterfaces/__init__.py \
 pywikibot/userinterfaces/terminal_interface.py \
+pywikibot/userinterfaces/terminal_interface_base.py \
+pywikibot/userinterfaces/terminal_interface_unix.py \
+pywikibot/userinterfaces/transliteration.py \
+pywikibot/userinterfaces/win32_unicode.py \
+pywikibot/version.py \
 pywikibot/weblib.py \
+pywikibot/xmlreader.py \
 scripts/__init__.py \
 scripts/add_text.py \
 scripts/basic.py \
@@ -76,9 +84,11 @@
 scripts/commonscat.py \
 scripts/coordinate_import.py \
 scripts/cosmetic_changes.py \
+scripts/create_categories.py \
 scripts/data_ingestion.py \
 scripts/delete.py \
 scripts/disambredir.py \
+scripts/djvutext.py \
 scripts/editarticle.py \
 scripts/fixing_redirects.py \
 scripts/flickrripper.py \
@@ -94,6 +104,7 @@
 scripts/newitem.py \
 scripts/noreferences.py \
 scripts/pagefromfile.py \
+scripts/patrol.py \
 scripts/piper.py \
 scripts/protect.py \
 scripts/selflink.py \
@@ -119,6 +130,7 @@
 tests/category_tests.py \
 tests/checkimages_tests.py \
 tests/cosmetic_changes_tests.py \
+tests/data/ \
 tests/data_ingestion_tests.py \
 tests/date_tests.py \
 tests/deletionbot_tests.py \
@@ -129,6 +141,7 @@
 tests/exceptions_tests.py \
 tests/family_tests.py \
 tests/file_tests.py \
+tests/flow_edit_tests.py \
 tests/flow_tests.py \
 tests/http_tests.py \
 tests/i18n/ \
@@ -158,6 +171,7 @@
 tests/upload_tests.py \
 tests/uploadbot_tests.py \
 tests/weblib_tests.py \
+tests/weblinkchecker_tests.py \
 tests/wikidataquery_tests.py \
 tests/wikistats_tests.py
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a15700ea9520307fba960584833ce6182a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise commodorefabia...@gmx.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] No longer branch Extension:Oversight - change (mediawiki...release)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: No longer branch Extension:Oversight
..


No longer branch Extension:Oversight

Removed from production

Bug: T34628
Change-Id: Id18f81033c7fc85791f8075e40981ca84a2cd051
---
M make-wmf-branch/config.json
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/make-wmf-branch/config.json b/make-wmf-branch/config.json
index 2124edc..3301c05 100644
--- a/make-wmf-branch/config.json
+++ b/make-wmf-branch/config.json
@@ -88,7 +88,6 @@
OAI,
OATHAuth,
OpenStackManager,
-   Oversight,
PagedTiffHandler,
PageImages,
PageTriage,

-- 
To view, visit https://gerrit.wikimedia.org/r/224298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id18f81033c7fc85791f8075e40981ca84a2cd051
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove WMF deployment hack for .feedlink from mediawiki.lega... - change (mediawiki/core)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231880

Change subject: Remove WMF deployment hack for .feedlink from 
mediawiki.legacy.shared
..

Remove WMF deployment hack for .feedlink from mediawiki.legacy.shared

To be merged 30 days after 579ec5dee1cdb08fc6c94121ff5570a501f98e0c is
deployed, and we know for sure that the new mediawiki.feedlink module
is included on all pages that need it.

Change-Id: I1e47b626fa937066823f056aec6fbc0205fdb9b6
---
M docs/uidesign/design.html
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki/mediawiki.feedlink.css
3 files changed, 2 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/80/231880/1

diff --git a/docs/uidesign/design.html b/docs/uidesign/design.html
index 51c1b55..6ab57d7 100644
--- a/docs/uidesign/design.html
+++ b/docs/uidesign/design.html
@@ -2,6 +2,7 @@
 html lang=en dir=ltr
 head
link rel=stylesheet 
href=../../resources/src/mediawiki.legacy/shared.css
+   link rel=stylesheet 
href=../../resources/src/mediawiki/mediawiki.feedlink.css
 /head
 body style=font-size: small;
 
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 14fd286..78f4dca 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -492,21 +492,6 @@
color: #BA;
 }
 
-/* feed links */
-/* To be removed before 1.26 release, moved to mediawiki.feedlink module */
-a.feedlink {
-   /* SVG support using a transparent gradient to guarantee cross-browser
-* compatibility (browsers able to understand gradient syntax support 
also SVG).
-* 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
-   background-image: url(../mediawiki/images/feed-icon.png);
-   background-image: -webkit-linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
-   background-image: linear-gradient(transparent, transparent), 
url(../mediawiki/images/feed-icon.svg);
-   background-position: center left;
-   background-repeat: no-repeat;
-   background-size: 12px 12px;
-   padding-left: 16px;
-}
-
 /* Plainlinks - this can be used to switch
  * off special external link styling */
 .plainlinks a.external {
diff --git a/resources/src/mediawiki/mediawiki.feedlink.css 
b/resources/src/mediawiki/mediawiki.feedlink.css
index 1dda2ac..8221f52 100644
--- a/resources/src/mediawiki/mediawiki.feedlink.css
+++ b/resources/src/mediawiki/mediawiki.feedlink.css
@@ -1,8 +1,6 @@
 /* Styles for links to RSS/Atom feeds in sidebar */
 
-/* Until the copy of this code in mediawiki.legacy.shared is removed, which no 
longer @embeds the
- * background image, the selector below must be kept more specific. */
-#feedlinks a.feedlink {
+a.feedlink {
/* SVG support using a transparent gradient to guarantee cross-browser
 * compatibility (browsers able to understand gradient syntax support 
also SVG).
 * 
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */

-- 
To view, visit https://gerrit.wikimedia.org/r/231880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e47b626fa937066823f056aec6fbc0205fdb9b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] cname debian.wikimedia.org to carbon (apt) - change (operations/dns)

2015-08-16 Thread John F. Lewis (Code Review)

John F. Lewis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231882

Change subject: cname debian.wikimedia.org to carbon (apt)
..

cname debian.wikimedia.org to carbon (apt)

Puppet: I59936679ab3a1007c48bbfffb26cfe16e38f894f

Change-Id: I934515a64d4f19d42fe83f50be7ad8b6173028be
---
M templates/wikimedia.org
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dns 
refs/changes/82/231882/1

diff --git a/templates/wikimedia.org b/templates/wikimedia.org
index fbd8b86..4958c1b 100644
--- a/templates/wikimedia.org
+++ b/templates/wikimedia.org
@@ -610,6 +610,7 @@
 cs   600 IN DYNA geoip!text-addrs
 cz   600 IN DYNA geoip!text-addrs
 datasets 1H  IN CNAMEmisc-web-lb.eqiad
+debian   1H  IN CNAMEcarbon
 download 1H  IN CNAMEdumps
 etherpad 5M  IN CNAMEmisc-web-lb.eqiad
 fundraising  1H  IN CNAMEfundraising-eqiad

-- 
To view, visit https://gerrit.wikimedia.org/r/231882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I934515a64d4f19d42fe83f50be7ad8b6173028be
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: John F. Lewis johnflewi...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mirrors: add debian.wikimedia.org as a servername - change (operations/puppet)

2015-08-16 Thread John F. Lewis (Code Review)

John F. Lewis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231881

Change subject: mirrors: add debian.wikimedia.org as a servername
..

mirrors: add debian.wikimedia.org as a servername

DNS: I934515a64d4f19d42fe83f50be7ad8b6173028be

Change-Id: I59936679ab3a1007c48bbfffb26cfe16e38f894f
---
M modules/mirrors/files/nginx.conf
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/81/231881/1

diff --git a/modules/mirrors/files/nginx.conf b/modules/mirrors/files/nginx.conf
index f7f6989..bbcdd49 100644
--- a/modules/mirrors/files/nginx.conf
+++ b/modules/mirrors/files/nginx.conf
@@ -1,7 +1,7 @@
 server {
listen 80;
listen [::]:80;
-   server_name mirrors.wikimedia.org ubuntu.wikimedia.org;
+   server_name mirrors.wikimedia.org ubuntu.wikimedia.org debian.wikimedia.org;
root /srv/mirrors;
 
location / {

-- 
To view, visit https://gerrit.wikimedia.org/r/231881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59936679ab3a1007c48bbfffb26cfe16e38f894f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: John F. Lewis johnflewi...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] Add docstrings - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231893

Change subject: [IMPROV] Add docstrings
..

[IMPROV] Add docstrings

Change-Id: Idd9212a92a9fd3e2592dc1b7dcb4879d053e0987
---
M pywikibot/data/wikidataquery.py
M pywikibot/flow.py
M pywikibot/logentries.py
M pywikibot/userinterfaces/terminal_interface_win32.py
M pywikibot/userinterfaces/transliteration.py
M pywikibot/userinterfaces/win32_unicode.py
M tests/page_tests.py
M tests/python_tests.py
M tests/reflinks_tests.py
M tests/timestamp_tests.py
M tests/wikibase_edit_tests.py
M tests/xmlreader_tests.py
M tox.ini
13 files changed, 120 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/93/231893/1

diff --git a/pywikibot/data/wikidataquery.py b/pywikibot/data/wikidataquery.py
index 2d7ee3a..8a40510 100644
--- a/pywikibot/data/wikidataquery.py
+++ b/pywikibot/data/wikidataquery.py
@@ -112,6 +112,7 @@
 return s
 
 def __repr__(self):
+Return a string representation.
 return uQuerySet(%s) % self
 
 
@@ -201,6 +202,7 @@
 return True
 
 def validateOrRaise(self, msg=None):
+Validate the contents and raise TypeError if the validation 
fails.
 if not self.validate():
 raise TypeError(msg)
 
@@ -221,6 +223,7 @@
 return int(item)
 
 def convertWDTypes(self, items):
+Convert the items into integer IDs using L{Query.convertWDType}.
 return [self.convertWDType(x) for x in listify(items)]
 
 def __str__(self):
@@ -234,6 +237,7 @@
 raise NotImplementedError
 
 def __repr__(self):
+Return a string representation.
 return uQuery(%s) % self
 
 
@@ -262,6 +266,7 @@
 self.validateOrRaise()
 
 def formatItems(self):
+Format the items when they are a list.
 res = ''
 if self.items:
 res += : + ,.join([self.formatItem(x) for x in self.items])
@@ -269,9 +274,11 @@
 return res
 
 def validate(self):
+Validate that the items are ints or Querys.
 return self.isOrContainsOnlyTypes(self.items, [int, Query])
 
 def __str__(self):
+Return the query string for the API.
 if isinstance(self.items, list):
 return %s[%s%s] % (self.queryType, self.prop, self.formatItems())
 elif isinstance(self.items, Query):
@@ -296,6 +303,7 @@
 return '%s' % x
 
 def validate(self):
+Validate that the items are strings.
 return self.isOrContainsOnlyTypes(self.items, basestring)
 
 
@@ -330,11 +338,13 @@
 self.validateOrRaise()
 
 def validate(self):
+Validate that the item, forward and reverse are all ints.
 return (self.isOrContainsOnlyTypes(self.item, int) and
 self.isOrContainsOnlyTypes(self.forward, int) and
 self.isOrContainsOnlyTypes(self.reverse, int))
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s][%s][%s] % (self.queryType, self.formatList(self.item),
 self.formatList(self.forward),
 self.formatList(self.reverse))
@@ -354,9 +364,11 @@
 self.rad = rad
 
 def validate(self):
+Validate that the prop is an int.
 return isinstance(self.prop, int)
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s,%s,%s,%s] % (self.queryType, self.prop,
 self.lt, self.lg, self.rad)
 
@@ -383,9 +395,11 @@
 self.end = end
 
 def validate(self):
+Validate that a range is given and the prop is an int.
 return (self.begin or self.end) and isinstance(self.prop, int)
 
 def __str__(self):
+Return the query string for the API.
 begin = self.begin.toTimestr() if self.begin else ''
 
 # if you don't have an end, you don't put in the comma
@@ -410,9 +424,11 @@
 self.validateOrRaise()
 
 def validate(self):
+Validate that the link is a string.
 return self.isOrContainsOnlyTypes(self.link, basestring)
 
 def __str__(self):
+Return the query string for the API.
 return %s[%s] % (self.queryType, self.formatList(self.link))
 
 
@@ -470,6 +486,7 @@
 wikidataquery_cache)
 
 def getUrl(self, queryStr):
+Get the URL given the query string.
 return %s/api?%s % (self.host, queryStr)
 
 def getQueryString(self, q, labels=[], props=[]):
diff --git a/pywikibot/flow.py b/pywikibot/flow.py
index 1580edb..5677db9 100644
--- a/pywikibot/flow.py
+++ b/pywikibot/flow.py
@@ -70,6 +70,7 @@
 return self._uuid
 
 def get(self, force=False, get_redirect=False, sysop=False):
+Get the page's content.
 if get_redirect or force or sysop:

[MediaWiki-commits] [Gerrit] [L10N] Update Arabic (ar) for welcome.py - change (pywikibot/compat)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231894

Change subject: [L10N] Update Arabic (ar) for welcome.py
..

[L10N] Update Arabic (ar) for welcome.py

backport bot script from core

Bug: T109225
Change-Id: If5cd8d3febaa9601c5d85aeea28bf0218db995e7
---
M welcome.py
1 file changed, 62 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/compat 
refs/changes/94/231894/1

diff --git a/welcome.py b/welcome.py
index db880c8..4e95d11 100644
--- a/welcome.py
+++ b/welcome.py
@@ -1,21 +1,20 @@
 # -*- coding: utf-8  -*-
 
-Script to welcome new users. This script works out of the box for Wikis that
+Script to welcome new users.
+
+This script works out of the box for Wikis that
 have been defined in the script. It is currently used on the Dutch, Norwegian,
 Albanian, Italian Wikipedia, Wikimedia Commons and English Wikiquote.
-
-Note: You can download the latest version available
-from here: http://botwiki.sno.cc/wiki/Python:Welcome.py
 
 Ensure you have community support before running this bot!
 
 URLs to current implementations:
-* Wikimedia Commons: http://commons.wikimedia.org/wiki/Commons:Welcome_log
-* Dutch Wikipedia: http://nl.wikipedia.org/wiki/Wikipedia:Logboek_welkom
-* Italian Wikipedia: http://it.wikipedia.org/wiki/Wikipedia:Benvenuto_log
-* English Wikiquote: http://en.wikiquote.org/wiki/Wikiquote:Welcome_log
-* Persian Wikipedia: http://fa.wikipedia.org/wiki/ویکی‌پدیا:سیاهه_خوشامد
-* Korean Wikipedia: http://ko.wikipedia.org/wiki/위키백과:Welcome_log
+* Wikimedia Commons: https://commons.wikimedia.org/wiki/Commons:Welcome_log
+* Dutch Wikipedia: https://nl.wikipedia.org/wiki/Wikipedia:Logboek_welkom
+* Italian Wikipedia: https://it.wikipedia.org/wiki/Wikipedia:Benvenuto_log
+* English Wikiquote: https://en.wikiquote.org/wiki/Wikiquote:Welcome_log
+* Persian Wikipedia: https://fa.wikipedia.org/wiki/ویکی‌پدیا:سیاهه_خوشامد
+* Korean Wikipedia: https://ko.wikipedia.org/wiki/위키백과:Welcome_log
 
 Everything that needs customisation to support additional projects is
 indicated by comments.
@@ -109,9 +108,9 @@
 * dio is a badword
 * Claudio is a normal name
 * The username is Claudio90 fuck!
-* The Bot find dio and set warning
-* The Bot find Claudio and set ok
-* The Bot find fuck at the end and set warning
+* The Bot finds dio and sets warning
+* The Bot finds Claudio and sets ok
+* The Bot finds fuck at the end and sets warning
 * Result: The username is reported.
 4)  When a user is reported you have to check him and do:
 * If he's ok, put the {{welcome}}
@@ -173,8 +172,8 @@
 # (C) Filnik, 2007-2011
 # (C) Daniel Herding, 2007
 # (C) Alex Shih-Han Lin, 2009-2010
-# (C) xqt, 2009-2011
-# (C) Pywikipedia bot team, 2008-2010
+# (C) xqt, 2009-2015
+# (C) Pywikibot team, 2008-2015
 #
 # Distributed under the terms of the MIT license.
 #
@@ -196,7 +195,7 @@
 
 locale.setlocale(locale.LC_ALL, '')
 
-# Script users the class pywikibot.translate() to find the right
+# Script uses the method pywikibot.translate() to find the right
 # page/user/summary/etc so the need to specify language and project have
 # been eliminated.
 # FIXME: Not all language/project combinations have been defined yet.
@@ -213,7 +212,7 @@
 
 # The page where the bot will save the log (e.g. Wikipedia:Welcome log).
 #
-# ATTENTION: Not listed projects are disabled to log welcomed users, and no 
necessary to set details.
+# ATTENTION: Projects not listed won't write a log to the wiki.
 logbook = {
 'ar': u'Project:سجل الترحيب',
 'fr': u'Wikipedia:Prise de décision/Accueil automatique des nouveaux par 
un robot/log',
@@ -263,6 +262,7 @@
 'zh-yue': u'{{歡迎}}--%s',
 },
 'wikinews': {
+'ar': u'{{subst:ترحيب}} %s',
 'fa': u'{{خوشامد۲|%s}}',
 'it': u'{{subst:benvenuto}}',
 'zh': u'{{subst:welcome}} %s',
@@ -285,7 +285,9 @@
 }
 # The page where the bot will report users with a possibly bad username.
 report_page = {
-'commons': {'_default': u'Project:Administrators\' noticeboard/User 
problems/Usernames to be checked', },
+'commons': {
+'_default': u'Project:Administrators\' noticeboard/User 
problems/Usernames to be checked',
+},
 'wikipedia': {
 'am': u'User:Beria/Report',
 'ar': 'Project:إخطار الإداريين/أسماء مستخدمين للفحص',
@@ -392,9 +394,15 @@
 #
 #
 logpage_header = {
-'_default': u'{|border=2 cellpadding=4 cellspacing=0 style=margin: 
0.5em 0.5em 0.5em 1em; padding: 0.5em; background: #bfcda5; border: 1px #b6fd2c 
solid; border-collapse: collapse; font-size: 95%;',
+'_default': u'{|border=2 cellpadding=4 cellspacing=0 style=margin: '
+u'0.5em 0.5em 0.5em 1em; padding: 0.5em; background: #bfcda5; '
+u'border: 1px #b6fd2c solid; border-collapse: collapse; '
+u'font-size: 95%;',

[MediaWiki-commits] [Gerrit] [IMPR] Replace fullVersionHistory() with revisions() - change (pywikibot/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: [IMPR] Replace fullVersionHistory() with revisions()
..


[IMPR] Replace fullVersionHistory() with revisions()

- create page instance on top of the method
- use revision properties

Change-Id: I56be946e4215a06c608839ba750f2b7e1423fad8
---
M scripts/revertbot.py
1 file changed, 11 insertions(+), 8 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/revertbot.py b/scripts/revertbot.py
index e283477..0da068e 100755
--- a/scripts/revertbot.py
+++ b/scripts/revertbot.py
@@ -91,31 +91,34 @@
 return 'top' in item
 
 def revert(self, item):
-history = pywikibot.Page(self.site, item['title']).fullVersionHistory(
-total=2, rollback=self.rollback)
+page = pywikibot.Page(self.site, item['title'])
+history = list(page.revisions(total=2))
 if len(history)  1:
 rev = history[1]
 else:
 return False
 comment = i18n.twtranslate(
-pywikibot.Site(), 'revertbot-revert',
-{'revid': rev[0], 'author': rev[2], 'timestamp': rev[1]})
+self.site, 'revertbot-revert',
+{'revid': rev.revid,
+ 'author': rev.user,
+ 'timestamp': rev.timestamp})
 if self.comment:
 comment += ': ' + self.comment
-page = pywikibot.Page(self.site, item['title'])
 pywikibot.output(u\n\n \03{lightpurple}%s\03{default} 
  % page.title(asLink=True, forceInterwiki=True,
   textlink=True))
 if not self.rollback:
 old = page.text
-page.text = rev[3]
+page.text = rev.text
 pywikibot.showDiff(old, page.text)
 page.save(comment)
 return comment
 try:
 pywikibot.data.api.Request(
-self.site, parameters={'action': 'rollback', 'title': page,
-   'user': self.user, 'token': rev[4],
+self.site, parameters={'action': 'rollback',
+   'title': page,
+   'user': self.user,
+   'token': rev.rollbacktoken,
'markbot': True}).submit()
 except pywikibot.data.api.APIError as e:
 if e.code == 'badtoken':

-- 
To view, visit https://gerrit.wikimedia.org/r/231875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56be946e4215a06c608839ba750f2b7e1423fad8
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Merlijn van Deen valhall...@arctus.nl
Gerrit-Reviewer: XZise commodorefabia...@gmx.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...GoogleAnalyticsMetrics)

2015-08-16 Thread tosfos (Code Review)

tosfos has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231979

Change subject: Initial commit
..

Initial commit

Change-Id: I442412a40b41b29cf19f00d564aa942df7602540
---
A GoogleAnalyticsMetrics.hooks.php
A GoogleAnalyticsMetrics.i18n.magic.php
A GoogleAnalyticsMetrics.php
A i18n/en.json
A i18n/qqq.json
5 files changed, 177 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GoogleAnalyticsMetrics 
refs/changes/79/231979/1

diff --git a/GoogleAnalyticsMetrics.hooks.php b/GoogleAnalyticsMetrics.hooks.php
new file mode 100644
index 000..982a34f
--- /dev/null
+++ b/GoogleAnalyticsMetrics.hooks.php
@@ -0,0 +1,121 @@
+?php
+
+class GoogleAnalyticsMetricsHooks {
+
+   /**
+* Sets up the parser function
+*
+* @param Parser $parser
+*/
+   public static function onParserFirstCallInit( Parser $parser ) {
+   $parser-setFunctionHook( 'googleanalyticsmetrics',
+   'GoogleAnalyticsMetricsHooks::googleAnalyticsMetrics' );
+   }
+
+   /**
+* Handles the googleanalyticsmetrics parser function
+*
+* @global string|array $wgGoogleAnalyticsMetricsAllowed
+* @param Parser $parser Unused
+* @param string $metric
+* @param string $startDate
+* @param string $endDate
+* @return string
+*/
+   public static function googleAnalyticsMetrics( Parser $parser, 
$metric, $startDate = null,
+   $endDate = null ) {
+   global $wgGoogleAnalyticsMetricsAllowed;
+
+   // Setting the defaults above would not allow an empty start 
parameter
+   if ( !$startDate ) {
+   $startDate = '2005-01-01';
+   }
+   if ( !$endDate ) {
+   $endDate = 'today';
+   }
+   if ( $wgGoogleAnalyticsMetricsAllowed !== '*'  !in_array( 
$metric,
+   $wgGoogleAnalyticsMetricsAllowed ) ) {
+   return self::getWrappedError( 'The requested metric is 
forbidden.' );
+   }
+
+   return self::getMetric( $metric, $startDate, $endDate );
+   }
+
+   /**
+* Gets the Analytics metric with the dates provided
+*
+* @global string $wgGoogleAnalyticsMetricsViewID
+* @param string $metric The name of the Analyitcs metric, without the 
ga: prefix
+* @param string $startDate Must be a valid date recognized by the 
Google API
+* @param string $endDate Must be a valid date recognized by the Google 
API
+* @return string
+*/
+   public static function getMetric( $metric, $startDate, $endDate ) {
+   global $wgGoogleAnalyticsMetricsViewID;
+   $service = self::getService();
+   try {
+   $response = $service-data_ga-get(
+   'ga:' . $wgGoogleAnalyticsMetricsViewID, 
$startDate, $endDate, 'ga:' . $metric
+   );
+   } catch ( Exception $e ) {
+   MWExceptionHandler::logException( $e );
+   return self::getWrappedError( 'Error!' );
+   }
+
+   $rows = $response-getRows();
+   return $rows[0][0];
+   }
+
+   /**
+* Returns the Analytics service, ready for use
+*
+* @global string $wgGoogleAnalyticsMetricsEmail
+* @global string $wgGoogleAnalyticsMetricsPath
+* @global WebRequest $wgRequest
+* @return \Google_Service_Analytics
+*/
+   private static function getService() {
+   //This entire function is copied from 
GoogleAnalyticsTopPages::getData()
+   global $wgGoogleAnalyticsMetricsEmail, 
$wgGoogleAnalyticsMetricsPath, $wgRequest;
+
+   // create a new Google_Client object
+   $client = new Google_Client();
+   // set app name
+   $client-setApplicationName( 'GoogleAnalyticsMetrics' );
+
+   $request = $wgRequest;
+   // check, if the client is already authenticated
+   if ( $request-getSessionData( 'service_token' ) !== null ) {
+   $client-setAccessToken( $request-getSessionData( 
'service_token' ) );
+   }
+
+   // load the certificate key file
+   $key = file_get_contents( $wgGoogleAnalyticsMetricsPath );
+   // create the service account credentials
+   $cred = new Google_Auth_AssertionCredentials(
+   $wgGoogleAnalyticsMetricsEmail, array( 
'https://www.googleapis.com/auth/analytics.readonly' ),
+   $key
+   );
+   // set the credentials
+   $client-setAssertionCredentials( $cred );
+

[MediaWiki-commits] [Gerrit] WikidataPageBanner add banner to imagelinks - change (mediawiki...WikidataPageBanner)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: WikidataPageBanner add banner to imagelinks
..


WikidataPageBanner add banner to imagelinks

Check which banner is valid and eligible to be added and added it to imagelinks
in addCustomBanner parser hook.

Bug: T108614
Change-Id: I23751b51f7c937e8c368351d1cb071ceae50b7ee
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/WikidataPageBanner.hooks.php 
b/includes/WikidataPageBanner.hooks.php
index ca892a4..5f330f9 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -161,6 +161,22 @@
$paramsForBannerTemplate['name'] = $bannername;
// Set 'wpb-banner-options' property for generating 
banner later
$parser-getOutput()-setProperty( 
'wpb-banner-options', $paramsForBannerTemplate );
+
+   // add the valid banner to image links
+   // @FIXME:Since bannernames which are to be added are 
generated here, getBannerHtml can
+   // be cleaned to only accept a valid title object 
pointing to a banner file
+   // Default banner is not added to imagelinks as that is 
the property of this extension
+   // and is uniform across all pages
+   $wikidataBanner = 
$wpbFunctionsClass::getWikidataBanner( $title );
+   $bannerTitle = null;
+   if ( $wpbFunctionsClass::getImageUrl( 
$paramsForBannerTemplate['name'] ) !== null ) {
+   $bannerTitle = Title::makeTitleSafe( NS_FILE, 
$paramsForBannerTemplate['name'] );
+   } elseif ( $wpbFunctionsClass::getImageUrl( 
$wikidataBanner ) !== null ) {
+   $bannerTitle = Title::makeTitleSafe( NS_FILE, 
$wikidataBanner );
+   }
+   if ( $bannerTitle !== null ) {
+   $parser-fetchFileAndTitle( $bannerTitle );
+   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/230643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23751b51f7c937e8c368351d1cb071ceae50b7ee
Gerrit-PatchSet: 10
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit asthana.sumi...@gmail.com
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Sumit asthana.sumi...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Use a better name for a foreach variable - change (mediawiki...QuickSearchLookup)

2015-08-16 Thread Florianschmidtwelzow (Code Review)

Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231977

Change subject: Hygiene: Use a better name for a foreach variable
..

Hygiene: Use a better name for a foreach variable

Follow up: I7aca81842e627af

Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9
---
M includes/QuickSearchLookup.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSearchLookup 
refs/changes/77/231977/1

diff --git a/includes/QuickSearchLookup.php b/includes/QuickSearchLookup.php
index b1e78b6..060e161 100644
--- a/includes/QuickSearchLookup.php
+++ b/includes/QuickSearchLookup.php
@@ -287,9 +287,9 @@
$api = new ApiMain( $params );
$api-execute();
$data = $api-getResult()-getResultData();
-   foreach ( $data['query']['pages'] as $id = $d ) {
-   if ( isset( $d['pageid'] ) ) {
-   $this-metadata = $d;
+   foreach ( $data['query']['pages'] as $id = $page ) {
+   if ( isset( $page['pageid'] ) ) {
+   $this-metadata = $page;
}
}
}
@@ -376,4 +376,4 @@
}
return $res;
}
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/231977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSearchLookup
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow florian.schmidt.stargatewis...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add translatable description and name to skin - change (mediawiki...Blueprint)

2015-08-16 Thread VolkerE (Code Review)

VolkerE has submitted this change and it was merged.

Change subject: Add translatable description and name to skin
..


Add translatable description and name to skin

This also adds a description to the skin.

Bug: T109131
Change-Id: I9086e3c2675125d6702a3f9fdde9798da8d405ec
---
M i18n/en.json
M i18n/qqq.json
M skin.json
3 files changed, 8 insertions(+), 6 deletions(-)

Approvals:
  VolkerE: Verified; Looks good to me, approved



diff --git a/i18n/en.json b/i18n/en.json
index 11cdd63..cb16d77 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
 {
@metadata: {
-   authors: [
-   werdna
-   ]
+   authors: []
},
+   skinname-blueprint: Blueprint,
+   blueprint-skin-desc: Blueprint combines page actions, site 
navigation, and the current page's Table of Contents into a navigation bar that 
is only shown on-demand,
blueprint-left-nav: * [[Main Page]]\n
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7f44569..ca387bc 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -1,8 +1,8 @@
 {
@metadata: {
-   authors: [
-   werdna
-   ]
+   authors: []
},
+   skinname-blueprint: {{optional}},
+   blueprint-skin-desc: 
{{desc|what=skin|name=Blueprint|url=https://www.mediawiki.org/wiki/Skin:Blueprint}};,
blueprint-left-nav: List of links to show in the left navigation for 
the skin
 }
diff --git a/skin.json b/skin.json
index b82e9b9..a0e9d42 100644
--- a/skin.json
+++ b/skin.json
@@ -1,10 +1,12 @@
 {
name: Blueprint,
+   namemsg: skinname-blueprint,
author: [
Andrew Garrett,
Prateek Saxena
],
url: https://gerrit.wikimedia.org/r/p/mediawiki/skins/Blueprint;,
+   descriptionmsg: blueprint-skin-desc,
type: skin,
license-name: MIT,
callback: BlueprintHooks::registerExtension,

-- 
To view, visit https://gerrit.wikimedia.org/r/229699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9086e3c2675125d6702a3f9fdde9798da8d405ec
Gerrit-PatchSet: 10
Gerrit-Project: mediawiki/skins/Blueprint
Gerrit-Branch: master
Gerrit-Owner: Paladox thomasmulhall...@yahoo.com
Gerrit-Reviewer: Paladox thomasmulhall...@yahoo.com
Gerrit-Reviewer: Prtksxna psax...@wikimedia.org
Gerrit-Reviewer: Spage sp...@wikimedia.org
Gerrit-Reviewer: VolkerE ve...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed RE for maps referrer - change (operations/puppet)

2015-08-16 Thread Yurik (Code Review)

Yurik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231978

Change subject: Fixed RE for maps referrer
..

Fixed RE for maps referrer

Change-Id: Ia232be3077a51fcf437131fcd635841370fcbaeb
---
M templates/varnish/maps-frontend.inc.vcl.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/78/231978/1

diff --git a/templates/varnish/maps-frontend.inc.vcl.erb 
b/templates/varnish/maps-frontend.inc.vcl.erb
index fc390cb..4b709ea 100644
--- a/templates/varnish/maps-frontend.inc.vcl.erb
+++ b/templates/varnish/maps-frontend.inc.vcl.erb
@@ -6,7 +6,7 @@
call vcl_recv_purge;
if (req.http.referer
 req.http.referer !~ (?i)^https://maps\.wikimedia\.org/;
-req.http.referer !~ 
(?i)^https?://[-a-zA-Z0-9.]\.beta\.wmflabs\.org/
+req.http.referer !~ 
(?i)^https?://[-a-zA-Z0-9.]+\.beta\.wmflabs\.org/
) {
error 403 Access Denied;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/231978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia232be3077a51fcf437131fcd635841370fcbaeb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yurik yu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't embed legacy images in render-blocking CSS - change (mediawiki/core)

2015-08-16 Thread Ori.livneh (Code Review)

Ori.livneh has submitted this change and it was merged.

Change subject: Don't embed legacy images in render-blocking CSS
..


Don't embed legacy images in render-blocking CSS

This commit cherry-picks the following changes from master:

* I6c7e592a50: mediawiki.legacy.common: don't embed legacy images
* Ife5d84fb95: Add mediawiki.legacy.feeds
* I8e092e9d2c: mediawiki.legacy.config: use own help-field styling
* I2a2556a0a4: mediawiki.special.upload: use spinner from jquery.spinner
* Iabaebe9bf1: Rename mediawiki.legacy.feeds to mediawiki.feedlink

Change-Id: I85495fff5b0664b7b7c93c1fe8b8373e81ccd750
---
M includes/installer/WebInstaller.php
M includes/skins/SkinTemplate.php
M mw-config/config.css
M resources/Resources.php
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.special/templates/thumbnail.html
R resources/src/mediawiki/images/feed-icon.png
R resources/src/mediawiki/images/feed-icon.svg
A resources/src/mediawiki/mediawiki.feedlink.css
9 files changed, 66 insertions(+), 19 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/includes/installer/WebInstaller.php 
b/includes/installer/WebInstaller.php
index 4930826..74904f1 100644
--- a/includes/installer/WebInstaller.php
+++ b/includes/installer/WebInstaller.php
@@ -696,11 +696,11 @@
$text = wfMessage( $msg, $args )-useDatabase( false )-plain();
$html = $this-parse( $text, true );
 
-   return div class=\mw-help-field-container\\n .
-   span class=\mw-help-field-hint\ title=\ .
+   return div class=\config-help-field-container\\n .
+   span class=\config-help-field-hint\ title=\ .
wfMessage( 'config-help-tooltip' )-escaped() . \ .
wfMessage( 'config-help' )-escaped() . /span\n .
-   span class=\mw-help-field-data\ . $html . 
/span\n .
+   span class=\config-help-field-data\ . $html . 
/span\n .
/div\n;
}
 
diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index ae78b2c..a1844a8 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -51,12 +51,16 @@
 * @param OutputPage $out
 */
function setupSkinUserCss( OutputPage $out ) {
-   $out-addModuleStyles( array(
+   $moduleStyles = array(
'mediawiki.legacy.shared',
'mediawiki.legacy.commonPrint',
'mediawiki.ui.button',
'mediawiki.sectionAnchor'
-   ) );
+   );
+   if ( $out-isSyndicated() ) {
+   $moduleStyles[] = 'mediawiki.feedlink';
+   }
+   $out-addModuleStyles( $moduleStyles );
}
 
/**
diff --git a/mw-config/config.css b/mw-config/config.css
index 17b2039..0e0b304 100644
--- a/mw-config/config.css
+++ b/mw-config/config.css
@@ -172,3 +172,32 @@
overflow: hidden;
min-width: 20em;
 }
+
+/* tooltip styles */
+.config-help-field-hint {
+   display: none;
+   margin-left: 2px;
+   margin-bottom: -8px;
+   padding: 0 0 0 15px;
+   /* @embed */
+   background-image: url(images/help-question.gif);
+   background-position: left center;
+   background-repeat: no-repeat;
+   cursor: pointer;
+   font-size: .8em;
+   text-decoration: underline;
+   color: #0645ad;
+}
+
+.config-help-field-hint:hover {
+   /* @embed */
+   background-image: url(images/help-question-hover.gif);
+}
+
+.config-help-field-data {
+   display: block;
+   background-color: #d6f3ff;
+   padding: 5px 8px 4px 8px;
+   border: 1px solid #5dc9f4;
+   margin-left: 20px;
+}
diff --git a/resources/Resources.php b/resources/Resources.php
index 1116b79..716ee9b 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -970,7 +970,10 @@
'feedback-useragent'
),
),
-
+   'mediawiki.feedlink' = array(
+   'position' = 'top',
+   'styles' = 'resources/src/mediawiki/mediawiki.feedlink.css',
+   ),
'mediawiki.filewarning' = array(
'scripts' = 'resources/src/mediawiki/mediawiki.filewarning.js',
'styles' = 
'resources/src/mediawiki/mediawiki.filewarning.less',
@@ -978,7 +981,6 @@
'oojs-ui',
),
),
-
'mediawiki.helplink' = array(
'position' = 'top',
'styles' = array(
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index b69e59d..14fd286 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -2,6 +2,11 @@
  * CSS in

[MediaWiki-commits] [Gerrit] Include /api/ rewrite on wikimediafoundation.org - change (operations/puppet)

2015-08-16 Thread Alex Monk (Code Review)

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231976

Change subject: Include /api/ rewrite on wikimediafoundation.org
..

Include /api/ rewrite on wikimediafoundation.org

Found by Max on Ibfdad3dc, didn't seem to be missing from any of the other
obvious suspects.

Change-Id: I597e0e96e06247395c603c119694fdf5438fc5e1
---
M modules/mediawiki/files/apache/sites/foundation.conf
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/76/231976/1

diff --git a/modules/mediawiki/files/apache/sites/foundation.conf 
b/modules/mediawiki/files/apache/sites/foundation.conf
index 2b5c96d..cdafadf 100644
--- a/modules/mediawiki/files/apache/sites/foundation.conf
+++ b/modules/mediawiki/files/apache/sites/foundation.conf
@@ -21,6 +21,7 @@
 # Primary wiki redirector:
 Alias /wiki /srv/mediawiki/docroot/foundation/w/index.php
 Include sites-enabled/public-wiki-rewrites.incl
+Include sites-enabled/api-rewrites.incl
 Include sites-enabled/wikimedia-legacy.incl
 
 RewriteRule ^/math/(.*) %{ENV:RW_PROTO}://upload.wikimedia.org/math/$1 
[R=301]

-- 
To view, visit https://gerrit.wikimedia.org/r/231976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I597e0e96e06247395c603c119694fdf5438fc5e1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alex Monk kren...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use a clear description for message key - change (mediawiki...GoogleLogin)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Use a clear description for message key
..


Use a clear description for message key

The current description is a bit spongy and leaves place for mis-
understandings. The key is used as a button level for a Next button
to go to the next step in a multi-step workflow.

Change-Id: If55ce5045acad0ed12ff6fc57b007bb5a5bf117a
---
M i18n/qqq.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/qqq.json b/i18n/qqq.json
index f8143b8..a575320 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -54,7 +54,7 @@
googlelogin-form-merge-title: Title of button to merge the wiki and 
Google account.,
googlelogin-form-logout: Title of button to choose another Google 
account to merge/create (to/a new) wiki account. (logout the currently Google 
account in wiki),
googlelogin-form-backlink: Used as link text on subpages of 
Special:GoogleLogin to go back to Main special page [[Special:GoogleLogin]].,
-   googlelogin-form-next: Next button\n{{Identical|Next}},
+   googlelogin-form-next: Button label used to indicate to got to the 
next step in a multi-step workflow.\n{{Identical|Next}},
googlelogin-form-merge: Title of button to merge the wikiaccount and 
Google account, if the user is logged into a wikiaccount (and not connected to 
a Google account) and navigates to Special:GoogleLogin.,
googlelogin-form-unlink: Title of button to unlink the connection 
between the wiki user account and Google account.,
googlelogin-email: Title of value email address in account 
information table on [[Special:GoogleLogin]].\n{{Identical|E-mail address}},

-- 
To view, visit https://gerrit.wikimedia.org/r/230478
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If55ce5045acad0ed12ff6fc57b007bb5a5bf117a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow florian.schmidt.stargatewis...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Florianschmidtwelzow florian.schmidt.stargatewis...@gmail.com
Gerrit-Reviewer: Nemo bis federicol...@tiscali.it
Gerrit-Reviewer: Siebrand siebr...@kitano.nl
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Marked the option labels with indexes - change (mediawiki...LanguageTool)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Marked the option labels with indexes
..


Marked the option labels with indexes

Change-Id: I76e841c517c4a4e83fa0e26338b4ddb12669b6b3
---
M modules/ext.LanguageToolDialog.js
1 file changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index e594e8c..026f4ee 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -89,23 +89,23 @@
menu: {
items: [
new OO.ui.MenuOptionWidget( {
-   data: 'Option 1',
+   data: '1',
label: 'Option 123'
} ),
new OO.ui.MenuOptionWidget( {
-   data: 'Option 2',
+   data: '2',
label: 'Option Two'
} ),
new OO.ui.MenuOptionWidget( {
-   data: 'Option 3',
+   data: '3',
label: 'Option Three'
} ),
new OO.ui.MenuOptionWidget( {
-   data: 'Option 4',
+   data: '4',
label: 'Option Four'
} ),
new OO.ui.MenuOptionWidget( {
-   data: 'Option 5',
+   data: '5',
label: 'Option Five'
} )
]
@@ -603,7 +603,7 @@
 // End of wrapper code by James Padolsey
 
 mw.LanguageToolDialog.prototype.displayInformation = function () {
-   var replacements, error;
+   var i, replacements, error, replaceArr, len, index;
 
if ( this.errors  this.errors.length  this.focusedIndex ) {
error = this.errors[ this.focusedIndex ].description;
@@ -614,7 +614,12 @@
this.findText.setValue( error );
}
if ( replacements ) {
-   this.replaceText.setValue( replacements );
+   replaceArr = replacements.split( '#' );
+   len = replaceArr.length;
+   for ( i = 0; i = len; i++ ) {
+   index = i.toString();
+   this.replaceText.getMenu().getItemFromData( index 
).setData( replaceArr[ i ] );
+   }
}
return;
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/231863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76e841c517c4a4e83fa0e26338b4ddb12669b6b3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks kumariankita...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix Persian translations - change (mediawiki...Flow)

2015-08-16 Thread Mjbmr (Code Review)

Mjbmr has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231919

Change subject: Fix Persian translations
..

Fix Persian translations

Change-Id: I88d059dae86eba42b1bf8c69b09a0f992373c0bd
---
M Flow.namespaces.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/19/231919/1

diff --git a/Flow.namespaces.php b/Flow.namespaces.php
index 7412c45..1703187 100644
--- a/Flow.namespaces.php
+++ b/Flow.namespaces.php
@@ -36,7 +36,7 @@
 
 /** Persian */
 $namespaceNames['fa'] = array(
-   NS_TOPIC =  'موضوع',
+   NS_TOPIC =  'مبحث',
 );
 
 /** Finnish */

-- 
To view, visit https://gerrit.wikimedia.org/r/231919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88d059dae86eba42b1bf8c69b09a0f992373c0bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mjbmr mjb...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 39ee8f0..f317630 - change (mediawiki/extensions)

2015-08-16 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231962

Change subject: Syncronize VisualEditor: 39ee8f0..f317630
..

Syncronize VisualEditor: 39ee8f0..f317630

Change-Id: I66b4e3807efbda7d27cde37cacb0fed99f3f4eb7
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions 
refs/changes/62/231962/1

diff --git a/VisualEditor b/VisualEditor
index 39ee8f0..f317630 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 39ee8f0c2fe6f94933563c8a2c92cffd5a308f2c
+Subproject commit f317630ccf838cc05cde18fbec565f080baff31b

-- 
To view, visit https://gerrit.wikimedia.org/r/231962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66b4e3807efbda7d27cde37cacb0fed99f3f4eb7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync jenkins-...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Syncronize VisualEditor: 39ee8f0..f317630 - change (mediawiki/extensions)

2015-08-16 Thread Jenkins-mwext-sync (Code Review)

Jenkins-mwext-sync has submitted this change and it was merged.

Change subject: Syncronize VisualEditor: 39ee8f0..f317630
..


Syncronize VisualEditor: 39ee8f0..f317630

Change-Id: I66b4e3807efbda7d27cde37cacb0fed99f3f4eb7
---
M VisualEditor
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins-mwext-sync: Verified; Looks good to me, approved



diff --git a/VisualEditor b/VisualEditor
index 39ee8f0..f317630 16
--- a/VisualEditor
+++ b/VisualEditor
-Subproject commit 39ee8f0c2fe6f94933563c8a2c92cffd5a308f2c
+Subproject commit f317630ccf838cc05cde18fbec565f080baff31b

-- 
To view, visit https://gerrit.wikimedia.org/r/231962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66b4e3807efbda7d27cde37cacb0fed99f3f4eb7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions
Gerrit-Branch: master
Gerrit-Owner: Jenkins-mwext-sync jenkins-...@wikimedia.org
Gerrit-Reviewer: Jenkins-mwext-sync jenkins-...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] registration: Fix having multiple callbacks for a single hook - change (mediawiki/core)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: registration: Fix having multiple callbacks for a single hook
..


registration: Fix having multiple callbacks for a single hook

Bug: T98975
Bug: T109243
Change-Id: I40ff36090d18344fabdb018519209671b7883fa1
(cherry picked from commit 2fcd5d7909401e1fec9856999ba439eed4d01561)
---
M RELEASE-NOTES-1.25
M includes/registration/ExtensionProcessor.php
M tests/phpunit/includes/registration/ExtensionProcessorTest.php
3 files changed, 32 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/RELEASE-NOTES-1.25 b/RELEASE-NOTES-1.25
index 6d32a44..e53dfbe 100644
--- a/RELEASE-NOTES-1.25
+++ b/RELEASE-NOTES-1.25
@@ -1,6 +1,14 @@
 Security reminder: If you have PHP's register_globals option set, you must
 turn it off. MediaWiki will not work with it enabled.
 
+== MediaWiki 1.25.3 ==
+
+THIS IS NOT YET A RELEASE!
+
+=== Changes since 1.25.2 ===
+
+* (T98975) Fix having multiple callbacks for a single hook.
+
 == MediaWiki 1.25.2 ==
 
 This is a security and maintenance release of the MediaWiki 1.25 branch.
diff --git a/includes/registration/ExtensionProcessor.php 
b/includes/registration/ExtensionProcessor.php
index bb8fb32..a11f1aa 100644
--- a/includes/registration/ExtensionProcessor.php
+++ b/includes/registration/ExtensionProcessor.php
@@ -166,8 +166,10 @@
 
protected function extractHooks( array $info ) {
if ( isset( $info['Hooks'] ) ) {
-   foreach ( $info['Hooks'] as $name = $callable ) {
-   $this-globals['wgHooks'][$name][] = $callable;
+   foreach ( $info['Hooks'] as $name = $value ) {
+   foreach ( (array)$value as $callback ) {
+   $this-globals['wgHooks'][$name][] = 
$callback;
+   }
}
}
}
diff --git a/tests/phpunit/includes/registration/ExtensionProcessorTest.php 
b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
index 8715711..9474496 100644
--- a/tests/phpunit/includes/registration/ExtensionProcessorTest.php
+++ b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
@@ -38,6 +38,10 @@
}
 
public static function provideRegisterHooks() {
+   // Format:
+   // Current $wgHooks
+   // Content in extension.json
+   // Expected value of $wgHooks
return array(
// No hooks
array(
@@ -66,6 +70,22 @@
'FooBaz' = array( 'FooBazCallback' ),
),
),
+   // Callbacks for FooBaz wrapped in an array
+   array(
+   array(),
+   array( 'Hooks' = array( 'FooBaz' = array( 
'Callback1' ) ) ) + self::$default,
+   array(
+   'FooBaz' = array( 'Callback1' ),
+   ),
+   ),
+   // Multiple callbacks for FooBaz hook
+   array(
+   array(),
+   array( 'Hooks' = array( 'FooBaz' = array( 
'Callback1', 'Callback2' ) ) ) + self::$default,
+   array(
+   'FooBaz' = array( 'Callback1', 
'Callback2' ),
+   ),
+   ),
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40ff36090d18344fabdb018519209671b7883fa1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_25
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] CSSMin: version URLs based on content, not mtime - change (mediawiki/core)

2015-08-16 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231981

Change subject: CSSMin: version URLs based on content, not mtime
..

CSSMin: version URLs based on content, not mtime

The content of these files is more stable than their mtimes, which change
every time we roll out a new branch. Because MD5 avalanches well[0], using
the first five hexadecimal digits is sufficient to ensure that the chance
of two successive versions colliding is improbably small (roughly one in a
million).

[0]: https://en.wikipedia.org/wiki/Avalanche_effect

Change-Id: I1bdf94c58786d2545311b238476b48217a5a60af
---
M includes/libs/CSSMin.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/81/231981/1

diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php
index f415c9b..b386a92 100644
--- a/includes/libs/CSSMin.php
+++ b/includes/libs/CSSMin.php
@@ -406,9 +406,9 @@
// Path to the actual file on the filesystem
$localFile = {$local}/{$file};
if ( file_exists( $localFile ) ) {
-   // Add version parameter as a time-stamp in ISO 
8601 format,
-   // using Z for the timezone, meaning GMT
-   $url .= '?' . gmdate( 'Y-m-d\TH:i:s\Z', round( 
filemtime( $localFile ), -2 ) );
+   // Add version parameter as the first five hex 
digits
+   // of the MD5 hash of the file's contents.
+   $url .= '?' . substr( md5_file( $localFile ), 
0, 5 );
if ( $embed ) {
$data = self::encodeImageAsDataURI( 
$localFile );
if ( $data !== false ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/231981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bdf94c58786d2545311b238476b48217a5a60af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Apply serveral tweaks - change (mediawiki...NumberFormat)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Apply serveral tweaks
..


Apply serveral tweaks

* Fix links to extension creators
* Add path constant
* Repace dir variable by dir constant
* Make extension's name translatable
* Add license-name
* Add COPYING file

Change-Id: If76d0e119a67783068f2c69b2d3b282b87813d33
---
A COPYING
M NumberFormat.php
M i18n/en.json
M i18n/qqq.json
4 files changed, 144 insertions(+), 14 deletions(-)

Approvals:
  Pastakhov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/COPYING b/COPYING
new file mode 100644
index 000..11bec1e
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,125 @@
+GNU LESSER GENERAL PUBLIC LICENSE
+Version 3, 29 June 2007
+
+Copyright (C) 2007 Free Software Foundation, Inc. http://fsf.org/
+
+Everyone is permitted to copy and distribute verbatim copies of this license 
document, but changing
+it is not allowed.
+
+This version of the GNU Lesser General Public License incorporates the terms 
and conditions of
+version 3 of the GNU General Public License, supplemented by the additional 
permissions listed below.
+
+0. Additional Definitions.
+
+As used herein, this License refers to version 3 of the GNU Lesser General 
Public License, and the
+GNU GPL refers to version 3 of the GNU General Public License.
+
+The Library refers to a covered work governed by this License, other than an 
Application or a
+Combined Work as defined below.
+
+An Application is any work that makes use of an interface provided by the 
Library, but which is
+not otherwise based on the Library. Defining a subclass of a class defined by 
the Library is deemed
+a mode of using an interface provided by the Library.
+
+A Combined Work is a work produced by combining or linking an Application 
with the Library. The
+particular version of the Library with which the Combined Work was made is 
also called the Linked
+Version.
+
+The Minimal Corresponding Source for a Combined Work means the Corresponding 
Source for the
+Combined Work, excluding any source code for portions of the Combined Work 
that, considered in
+isolation, are based on the Application, and not on the Linked Version.
+
+The Corresponding Application Code for a Combined Work means the object code 
and/or source code
+for the Application, including any data and utility programs needed for 
reproducing the Combined
+Work from the Application, but excluding the System Libraries of the Combined 
Work.
+
+1. Exception to Section 3 of the GNU GPL.
+You may convey a covered work under sections 3 and 4 of this License without 
being bound by section
+3 of the GNU GPL.
+
+2. Conveying Modified Versions.
+If you modify a copy of the Library, and, in your modifications, a facility 
refers to a function or
+data to be supplied by an Application that uses the facility (other than as an 
argument passed when
+the facility is invoked), then you may convey a copy of the modified version:
+
+a) under this License, provided that you make a good faith effort to ensure 
that, in the event an
+Application does not supply the function or data, the facility still operates, 
and performs whatever
+part of its purpose remains meaningful, or
+
+b) under the GNU GPL, with none of the additional permissions of this License 
applicable to that
+copy.
+
+3. Object Code Incorporating Material from Library Header Files.
+The object code form of an Application may incorporate material from a header 
file that is part of
+the Library. You may convey such object code under terms of your choice, 
provided that, if the
+incorporated material is not limited to numerical parameters, data structure 
layouts and accessors,
+or small macros, inline functions and templates (ten or fewer lines in 
length), you do both of the
+following:
+
+a) Give prominent notice with each copy of the object code that the Library is 
used in it and that
+the Library and its use are covered by this License.
+
+b) Accompany the object code with a copy of the GNU GPL and this license 
document.
+
+4. Combined Works.
+You may convey a Combined Work under terms of your choice that, taken 
together, effectively do not
+restrict modification of the portions of the Library contained in the Combined 
Work and reverse
+engineering for debugging such modifications, if you also do each of the 
following:
+
+a) Give prominent notice with each copy of the Combined Work that the Library 
is used in it and that
+the Library and its use are covered by this License.
+
+b) Accompany the Combined Work with a copy of the GNU GPL and this license 
document.
+
+c) For a Combined Work that displays copyright notices during execution, 
include the copyright
+notice for the Library among these notices, as well as a reference directing 
the user to the copies
+of the GNU GPL and this license document.
+
+d) Do one of the following:
+
+0) Convey the Minimal Corresponding Source under the terms of this

[MediaWiki-commits] [Gerrit] Add /multimeter/ to robots.txt exclusion - change (phabricator/phabricator)

2015-08-16 Thread 20after4 (Code Review)

20after4 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231983

Change subject: Add /multimeter/ to robots.txt exclusion
..

Add /multimeter/ to robots.txt exclusion

We don't need search engines indexing /multimeter, it's unwanted load
and not at all useful. (It's also filling up the logs, currently)

Bug: T109247
Change-Id: I8d991f52b59219501982366738dfaab4ff6e7b43
---
M src/applications/system/controller/PhabricatorRobotsController.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/phabricator 
refs/changes/83/231983/1

diff --git a/src/applications/system/controller/PhabricatorRobotsController.php 
b/src/applications/system/controller/PhabricatorRobotsController.php
index bfc548f..b7767d7 100644
--- a/src/applications/system/controller/PhabricatorRobotsController.php
+++ b/src/applications/system/controller/PhabricatorRobotsController.php
@@ -20,6 +20,7 @@
 
 $out[] = 'User-Agent: *';
 $out[] = 'Disallow: /diffusion/';
+$out[] = 'Disallow: /multimeter/';
 
 // Add a small crawl delay (number of seconds between requests) for spiders
 // which respect it. The intent here is to prevent spiders from affecting

-- 
To view, visit https://gerrit.wikimedia.org/r/231983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d991f52b59219501982366738dfaab4ff6e7b43
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/phabricator
Gerrit-Branch: production
Gerrit-Owner: 20after4 mmod...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add /multimeter/ to robots.txt exclusion - change (phabricator/phabricator)

2015-08-16 Thread 20after4 (Code Review)

20after4 has submitted this change and it was merged.

Change subject: Add /multimeter/ to robots.txt exclusion
..


Add /multimeter/ to robots.txt exclusion

We don't need search engines indexing /multimeter, it's unwanted load
and not at all useful. (It's also filling up the logs, currently)

Bug: T109247
Change-Id: I8d991f52b59219501982366738dfaab4ff6e7b43
---
M src/applications/system/controller/PhabricatorRobotsController.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  20after4: Looks good to me, approved
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/src/applications/system/controller/PhabricatorRobotsController.php 
b/src/applications/system/controller/PhabricatorRobotsController.php
index bfc548f..b7767d7 100644
--- a/src/applications/system/controller/PhabricatorRobotsController.php
+++ b/src/applications/system/controller/PhabricatorRobotsController.php
@@ -20,6 +20,7 @@
 
 $out[] = 'User-Agent: *';
 $out[] = 'Disallow: /diffusion/';
+$out[] = 'Disallow: /multimeter/';
 
 // Add a small crawl delay (number of seconds between requests) for spiders
 // which respect it. The intent here is to prevent spiders from affecting

-- 
To view, visit https://gerrit.wikimedia.org/r/231983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d991f52b59219501982366738dfaab4ff6e7b43
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/phabricator
Gerrit-Branch: production
Gerrit-Owner: 20after4 mmod...@wikimedia.org
Gerrit-Reviewer: 20after4 mmod...@wikimedia.org
Gerrit-Reviewer: Dzahn dz...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] registration: Fix having multiple callbacks for a single hook - change (mediawiki/core)

2015-08-16 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231980

Change subject: registration: Fix having multiple callbacks for a single hook
..

registration: Fix having multiple callbacks for a single hook

Bug: T98975
Change-Id: I40ff36090d18344fabdb018519209671b7883fa1
(cherry picked from commit 2fcd5d7909401e1fec9856999ba439eed4d01561)
---
M includes/registration/ExtensionProcessor.php
M tests/phpunit/includes/registration/ExtensionProcessorTest.php
2 files changed, 24 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/80/231980/1

diff --git a/includes/registration/ExtensionProcessor.php 
b/includes/registration/ExtensionProcessor.php
index bb8fb32..a11f1aa 100644
--- a/includes/registration/ExtensionProcessor.php
+++ b/includes/registration/ExtensionProcessor.php
@@ -166,8 +166,10 @@
 
protected function extractHooks( array $info ) {
if ( isset( $info['Hooks'] ) ) {
-   foreach ( $info['Hooks'] as $name = $callable ) {
-   $this-globals['wgHooks'][$name][] = $callable;
+   foreach ( $info['Hooks'] as $name = $value ) {
+   foreach ( (array)$value as $callback ) {
+   $this-globals['wgHooks'][$name][] = 
$callback;
+   }
}
}
}
diff --git a/tests/phpunit/includes/registration/ExtensionProcessorTest.php 
b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
index 8715711..9474496 100644
--- a/tests/phpunit/includes/registration/ExtensionProcessorTest.php
+++ b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
@@ -38,6 +38,10 @@
}
 
public static function provideRegisterHooks() {
+   // Format:
+   // Current $wgHooks
+   // Content in extension.json
+   // Expected value of $wgHooks
return array(
// No hooks
array(
@@ -66,6 +70,22 @@
'FooBaz' = array( 'FooBazCallback' ),
),
),
+   // Callbacks for FooBaz wrapped in an array
+   array(
+   array(),
+   array( 'Hooks' = array( 'FooBaz' = array( 
'Callback1' ) ) ) + self::$default,
+   array(
+   'FooBaz' = array( 'Callback1' ),
+   ),
+   ),
+   // Multiple callbacks for FooBaz hook
+   array(
+   array(),
+   array( 'Hooks' = array( 'FooBaz' = array( 
'Callback1', 'Callback2' ) ) ) + self::$default,
+   array(
+   'FooBaz' = array( 'Callback1', 
'Callback2' ),
+   ),
+   ),
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I40ff36090d18344fabdb018519209671b7883fa1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_25
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Whitelist kumariankita002 at gmail.com - change (integration/config)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Whitelist kumariankita002 at gmail.com
..


Whitelist kumariankita002 at gmail.com

Ankita is the main developer of the LanguageTool extension.

Bug: T109057
Change-Id: I96272dd522134e9282c6e7bd54369eb8f0be48df
---
M zuul/layout.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 8e7df8a..db668a3 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -104,6 +104,7 @@
 | kartik\.mistry@gmail\.com
 | krenair@gmail\.com
 | krinklemail@gmail\.com
+| kumariankita002@gmail\.com
 | l10n-bot@translatewiki\.net
 | ladsgroup@gmail\.com
 | legoktm\.wikipedia@gmail\.com
@@ -328,6 +329,7 @@
- ^jeff\.janes@gmail\.com$
- ^johnflewis93@gmail\.com$
- ^krenair@gmail\.com$
+   - ^kumariankita002@gmail\.com$
- ^ladsgroup@gmail\.com$ # Pywikibot maintainer
- ^lewis@lewiscawte\.me$
- ^liangent@gmail\.com$

-- 
To view, visit https://gerrit.wikimedia.org/r/231902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96272dd522134e9282c6e7bd54369eb8f0be48df
Gerrit-PatchSet: 3
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enable article-recommender-1 campaign in ca, en, es, fa, fr, ... - change (operations/mediawiki-config)

2015-08-16 Thread KartikMistry (Code Review)

KartikMistry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231984

Change subject: Enable article-recommender-1 campaign in ca, en, es, fa, fr, 
it, sw
..

Enable article-recommender-1 campaign in ca, en, es, fa, fr, it, sw

Bug: T109245
Change-Id: I29e07f6a1a978fc87f35d01d2b2b74f2fa87ffcc
---
M wmf-config/InitialiseSettings.php
1 file changed, 27 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/84/231984/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index a9ce0df..ffd3f7b 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14733,6 +14733,12 @@
'cxstats' = true,
'staff-recommender' = true
),
+   'cawiki' = array(
+   'newarticle' = true,
+   'cxstats' = true,
+   'staff-recommender' = true,
+   'article-recommender-1' = true
+   ),
'dewiki' = array(
'cxstats' = true,
'newarticle' = false,
@@ -14741,24 +14747,41 @@
'enwiki' = array(
'cxstats' = true,
'newarticle' = false,
-   'staff-recommender' = true
+   'staff-recommender' = true,
+   'article-recommender-1' = true
),
'eswiki' = array(
'newarticle' = true,
'cxstats' = true,
'staff-recommender' = true,
-   'eswiki-recommender' = true
+   'eswiki-recommender' = true,
+   'article-recommender-1' = true
+   ),
+   'fawiki' = array(
+   'newarticle' = true,
+   'cxstats' = true,
+   'staff-recommender' = true,
+   'article-recommender-1' = true
),
'frwiki' = array(
'newarticle' = true,
'cxstats' = true,
'staff-recommender' = true,
-   'frwiki-recommender' = true
+   'frwiki-recommender' = true,
+   'article-recommender-1' = true
),
'itwiki' = array(
'cxstats' = true,
'newarticle' = false,
-   'staff-recommender' = true
+   'staff-recommender' = true,
+   'article-recommender-1' = true
+   ),
+   'swwiki' = array(
+   'newarticle' = true,
+   'cxstats' = true,
+   'newarticle' = false,
+   'staff-recommender' = true,
+   'article-recommender-1' = true
),
 ),
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29e07f6a1a978fc87f35d01d2b2b74f2fa87ffcc
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: KartikMistry kartik.mis...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update ogv.js libraries to 0.9.9 - change (mediawiki...TimedMediaHandler)

2015-08-16 Thread Brion VIBBER (Code Review)

Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231985

Change subject: Update ogv.js libraries to 0.9.9
..

Update ogv.js libraries to 0.9.9

* console.log() spam cleanup and some misc fixes.

Release notes:
https://github.com/brion/ogv.js/releases/tag/0.9.9

Change-Id: I99acd0681ded2ab34e3df04b6c2a8bc00a0e558d
---
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-decoder-audio-opus.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-decoder-audio-vorbis.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-demuxer-ogg.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-support.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-version.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-worker-audio.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv-worker-video.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/ogv.js
M MwEmbedModules/EmbedPlayer/binPlayers/ogv.js/readme.md
9 files changed, 195 insertions(+), 99 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/85/231985/1


-- 
To view, visit https://gerrit.wikimedia.org/r/231985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99acd0681ded2ab34e3df04b6c2a8bc00a0e558d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER br...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix Persian namespace name translation - change (mediawiki...Flow)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Fix Persian namespace name translation
..


Fix Persian namespace name translation

Follow-up to Ib8cc18d9e478ab98799a3bc79358387ebc38b338

Bug: T109234
Change-Id: I88d059dae86eba42b1bf8c69b09a0f992373c0bd
---
M Flow.namespaces.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Flow.namespaces.php b/Flow.namespaces.php
index 7412c45..1703187 100644
--- a/Flow.namespaces.php
+++ b/Flow.namespaces.php
@@ -36,7 +36,7 @@
 
 /** Persian */
 $namespaceNames['fa'] = array(
-   NS_TOPIC =  'موضوع',
+   NS_TOPIC =  'مبحث',
 );
 
 /** Finnish */

-- 
To view, visit https://gerrit.wikimedia.org/r/231919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88d059dae86eba42b1bf8c69b09a0f992373c0bd
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mjbmr mjb...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Siebrand siebr...@kitano.nl
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Hebrew namespace translation - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add Hebrew namespace translation
..


Add Hebrew namespace translation

Change-Id: I1e4afe239ee83f8d1cba38618144136056186aaf
---
M Gadgets.namespaces.php
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Eranroz: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0ec7d10..35b76e6 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -15,3 +15,11 @@
NS_GADGET_DEFINITION = 'Gadget_definition',
NS_GADGET_DEFINITION_TALK = 'Gadget_definition_talk',
 );
+
+$namespaceNames['he'] = array(
+   NS_GADGET = 'גאדג\'ט',
+   NS_GADGET_TALK = 'שיחת_גאדג\'ט',
+   NS_GADGET_DEFINITION = 'הגדרת_גאדג\'ט',
+   NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
+);
+

-- 
To view, visit https://gerrit.wikimedia.org/r/231895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e4afe239ee83f8d1cba38618144136056186aaf
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Eranroz eranro...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Persian translations - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add Persian translations
..


Add Persian translations

Follow-up to Ia88c774cc0decc252a4a4277d14822048db95801

Bug: T109234
Change-Id: Ib05342d19f99c301f9f1a21c016ef1d86cb2175e
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 35b76e6..0aa17be 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -16,6 +16,13 @@
NS_GADGET_DEFINITION_TALK = 'Gadget_definition_talk',
 );
 
+$namespaceNames['fa'] = array(
+   NS_GADGET = 'ابزار',
+   NS_GADGET_TALK = 'بحث_ابزار',
+   NS_GADGET_DEFINITION = 'توضیحات_ابزار',
+   NS_GADGET_DEFINITION_TALK = 'بحث_توضیحات_ابزار',
+);
+
 $namespaceNames['he'] = array(
NS_GADGET = 'גאדג\'ט',
NS_GADGET_TALK = 'שיחת_גאדג\'ט',

-- 
To view, visit https://gerrit.wikimedia.org/r/231963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib05342d19f99c301f9f1a21c016ef1d86cb2175e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Mjbmr mjb...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Siebrand siebr...@kitano.nl
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Urdu translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add Urdu translation for namespaces
..


Add Urdu translation for namespaces

Translations provided by MuhammadShuaib at T109206. I do no speak the
language, but they have been vetted by Urdu Wikipedia community and
automated translation back to English looks sane.

Bug: T109206
Change-Id: I6f0555b8f02895f547a708ff6845d975fb5e29e3
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 7781a96..0f386cb 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -37,6 +37,13 @@
NS_GADGET_DEFINITION_TALK = 'Dyskusja_definicji_gadżetu',
 );
 
+$namespaceNames['ur'] = array(
+   NS_GADGET = 'آلہ',
+   NS_GADGET_TALK = 'تبادلۂ_خیال_آلہ',
+   NS_GADGET_DEFINITION = 'تعریف_آلہ',
+   NS_GADGET_DEFINITION_TALK = 'تبادلۂ_خیال_تعریف_آلہ',
+);
+
 $namespaceNames['vi'] = array(
NS_GADGET = 'Tiện_ích',
NS_GADGET_TALK = 'Thảo_luận_Tiện_ích',

-- 
To view, visit https://gerrit.wikimedia.org/r/231965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f0555b8f02895f547a708ff6845d975fb5e29e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Whitelist kumariankita...@gmail.com - change (integration/config)

2015-08-16 Thread Amire80 (Code Review)

Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231902

Change subject: Whitelist kumariankita...@gmail.com
..

Whitelist kumariankita...@gmail.com

Ankita is the main developer of the LanguageTool extension.

Bug: T109057
Change-Id: I96272dd522134e9282c6e7bd54369eb8f0be48df
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/02/231902/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 8e7df8a..98bedcf 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -328,6 +328,7 @@
- ^jeff\.janes@gmail\.com$
- ^johnflewis93@gmail\.com$
- ^krenair@gmail\.com$
+   - ^kumariankita002@gmail\.com$
- ^ladsgroup@gmail\.com$ # Pywikibot maintainer
- ^lewis@lewiscawte\.me$
- ^liangent@gmail\.com$

-- 
To view, visit https://gerrit.wikimedia.org/r/231902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96272dd522134e9282c6e7bd54369eb8f0be48df
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Persian translations - change (mediawiki...Gadgets)

2015-08-16 Thread Mjbmr (Code Review)

Mjbmr has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231963

Change subject: Add Persian translations
..

Add Persian translations

Change-Id: Ib05342d19f99c301f9f1a21c016ef1d86cb2175e
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/63/231963/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0ec7d10..b818ccc 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -15,3 +15,10 @@
NS_GADGET_DEFINITION = 'Gadget_definition',
NS_GADGET_DEFINITION_TALK = 'Gadget_definition_talk',
 );
+
+$namespaceNames['fa'] = array(
+   NS_GADGET = 'ابزار',
+   NS_GADGET_TALK = 'بحث_ابزار',
+   NS_GADGET_DEFINITION = 'توضیحات_ابزار',
+   NS_GADGET_DEFINITION_TALK = 'بحث_توضیحات_ابزار',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib05342d19f99c301f9f1a21c016ef1d86cb2175e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Mjbmr mjb...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Polish translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231964

Change subject: Add Polish translation for namespaces
..

Add Polish translation for namespaces

Change-Id: I05aa2f7f34867864ac435add85c6ad8f2783464b
---
M Gadgets.namespaces.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/64/231964/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 35b76e6..d570655 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -23,3 +23,9 @@
NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
 );
 
+$namespaceNames['pl'] = array(
+   NS_GADGET = 'Gadżet',
+   NS_GADGET_TALK = 'Dyskusja_gadżetu',
+   NS_GADGET_DEFINITION = 'Definicja_gadżetu',
+   NS_GADGET_DEFINITION_TALK = 'Dyskusja_definicji_gadżetu',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05aa2f7f34867864ac435add85c6ad8f2783464b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Suggestions correctly displayed in drop-down - change (mediawiki...LanguageTool)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Suggestions correctly displayed in drop-down
..


Suggestions correctly displayed in drop-down

Change-Id: I6d5ef13c2b6bd9f68723b1e478e0ea89c759b836
---
M modules/ext.LanguageToolDialog.js
1 file changed, 19 insertions(+), 29 deletions(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 026f4ee..7c0f0e5 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -83,32 +83,13 @@
ve.ui.triggerRegistry.getMessages( 'findNext' ).join( 
', ' )
} );
 
+   this.items = [];
+
this.replaceText = new OO.ui.ComboBoxWidget( {
label: 'ComboBoxWidget',
-   input: { value: 'Option 123' },
+   input: { value: 'Suggestions' },
menu: {
-   items: [
-   new OO.ui.MenuOptionWidget( {
-   data: '1',
-   label: 'Option 123'
-   } ),
-   new OO.ui.MenuOptionWidget( {
-   data: '2',
-   label: 'Option Two'
-   } ),
-   new OO.ui.MenuOptionWidget( {
-   data: '3',
-   label: 'Option Three'
-   } ),
-   new OO.ui.MenuOptionWidget( {
-   data: '4',
-   label: 'Option Four'
-   } ),
-   new OO.ui.MenuOptionWidget( {
-   data: '5',
-   label: 'Option Five'
-   } )
-   ]
+   items: this.items
}
} );
 
@@ -336,7 +317,6 @@
}
this.renderedFragments = range;
this.highlightFocused();
-   this.displayInformation();
 };
 
 /**
@@ -385,6 +365,7 @@
$( 'body, html' ).animate( { scrollTop: offset - ( 
windowScrollHeight / 2  ) }, 'fast' );
}
}
+   this.displayInformation();
 };
 
 /**
@@ -393,7 +374,6 @@
 mw.LanguageToolDialog.prototype.findNext = function () {
this.focusedIndex = ( this.focusedIndex + 1 ) % this.errors.length;
this.highlightFocused( true );
-   this.displayInformation();
 };
 
 /**
@@ -402,7 +382,6 @@
 mw.LanguageToolDialog.prototype.findPrevious = function () {
this.focusedIndex = ( this.focusedIndex + this.errors.length - 1 ) % 
this.errors.length;
this.highlightFocused( true );
-   this.displayInformation();
 };
 
 /**
@@ -603,7 +582,7 @@
 // End of wrapper code by James Padolsey
 
 mw.LanguageToolDialog.prototype.displayInformation = function () {
-   var i, replacements, error, replaceArr, len, index;
+   var i, index, replacements, error, replaceArr, len;
 
if ( this.errors  this.errors.length  this.focusedIndex ) {
error = this.errors[ this.focusedIndex ].description;
@@ -613,13 +592,24 @@
if ( error ) {
this.findText.setValue( error );
}
-   if ( replacements ) {
+   if ( replacements.length ) {
replaceArr = replacements.split( '#' );
len = replaceArr.length;
+   this.replaceText.getMenu().removeItems( this.items );
+   this.items = [];
for ( i = 0; i = len; i++ ) {
index = i.toString();
-   this.replaceText.getMenu().getItemFromData( index 
).setData( replaceArr[ i ] );
+   this.items.push(
+   new OO.ui.MenuOptionWidget( {
+   data: replaceArr[i],
+   label: replaceArr[i]
+   } )
+   );
}
+   this.replaceText.getMenu().addItems( this.items );
+   } else {
+   this.replaceText.getMenu().removeItems( this.items );
+   this.items = [];
}
return;
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/231864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d5ef13c2b6bd9f68723b1e478e0ea89c759b836
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks kumariankita...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: jenkins-bot

[MediaWiki-commits] [Gerrit] Add Polish translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add Polish translation for namespaces
..


Add Polish translation for namespaces

Change-Id: I05aa2f7f34867864ac435add85c6ad8f2783464b
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 920272a..7781a96 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -30,6 +30,13 @@
NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
 );
 
+$namespaceNames['pl'] = array(
+   NS_GADGET = 'Gadżet',
+   NS_GADGET_TALK = 'Dyskusja_gadżetu',
+   NS_GADGET_DEFINITION = 'Definicja_gadżetu',
+   NS_GADGET_DEFINITION_TALK = 'Dyskusja_definicji_gadżetu',
+);
+
 $namespaceNames['vi'] = array(
NS_GADGET = 'Tiện_ích',
NS_GADGET_TALK = 'Thảo_luận_Tiện_ích',

-- 
To view, visit https://gerrit.wikimedia.org/r/231964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05aa2f7f34867864ac435add85c6ad8f2783464b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Mjbmr mjb...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] Add docstrings to various test modules - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231968

Change subject: [IMPROV] Add docstrings to various test modules
..

[IMPROV] Add docstrings to various test modules

Change-Id: I4bfa6f9c63b08279477d8b4af77d1b99806a6ef9
---
M tests/api_tests.py
M tests/dry_api_tests.py
M tests/dry_site_tests.py
M tests/i18n_tests.py
M tests/isbn_tests.py
M tests/textlib_tests.py
M tox.ini
7 files changed, 107 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/68/231968/1

diff --git a/tests/api_tests.py b/tests/api_tests.py
index 822f70a..0e221e4 100644
--- a/tests/api_tests.py
+++ b/tests/api_tests.py
@@ -153,6 +153,7 @@
 Test ParamInfo.
 
 def test_init(self):
+Test common initialization.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertEqual(len(pi), 0)
@@ -188,6 +189,7 @@
 self.assertIn('query', pi._paraminfo)
 
 def test_init_pageset(self):
+Test initializing with only the pageset.
 site = self.get_site()
 self.assertNotIn('query', api.ParamInfo.init_modules)
 pi = api.ParamInfo(site, set(['pageset']))
@@ -218,6 +220,7 @@
 self.assertGreater(len(generators_param['type']), 1)
 
 def test_generators(self):
+Test requesting the generator parameter.
 site = self.get_site()
 pi = api.ParamInfo(site, set(['pageset', 'query']))
 self.assertEqual(len(pi), 0)
@@ -236,6 +239,7 @@
 self.assertEqual(pageset_generators_param, query_generators_param)
 
 def test_with_module_info(self):
+Test requesting the module info.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertEqual(len(pi), 0)
@@ -264,6 +268,7 @@
 self.assertIn('protection', param['type'])
 
 def test_with_module_revisions(self):
+Test requesting the module revisions.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertEqual(len(pi), 0)
@@ -292,6 +297,7 @@
 self.assertIn('user', param['type'])
 
 def test_multiple_modules(self):
+Test requesting multiple modules in one fetch.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertEqual(len(pi), 0)
@@ -309,6 +315,7 @@
  2 + len(pi.preloaded_modules))
 
 def test_with_invalid_module(self):
+Test requesting different kind of invalid modules.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertEqual(len(pi), 0)
@@ -345,6 +352,7 @@
 self.assertRaises(KeyError, pi.submodules, 'edit')
 
 def test_query_modules_with_limits(self):
+Test query_modules_with_limits property.
 site = self.get_site()
 pi = api.ParamInfo(site)
 self.assertIn('revisions', pi.query_modules_with_limits)
@@ -396,6 +404,7 @@
 self.assertEqual(value, '')
 
 def test_old_mode(self):
+Test the old mode explicitly.
 site = self.get_site()
 pi = api.ParamInfo(site, modules_only_mode=False)
 pi.fetch(['info'])
@@ -411,6 +420,7 @@
 self.assertIn('revisions', pi.prefixes)
 
 def test_new_mode(self):
+Test the new modules-only mode explicitly.
 site = self.get_site()
 if MediaWikiVersion(site.version())  MediaWikiVersion('1.25wmf4'):
 raise unittest.SkipTest(
@@ -574,19 +584,23 @@
 self.assertPagelistTitles(self.gen, self.titles)
 
 def test_initial_limit(self):
+Test the default limit.
 self.assertEqual(self.gen.limit, None)  # limit is initally None
 
 def test_set_limit_as_number(self):
+Test setting the limit using an int.
 for i in range(-2, 4):
 self.gen.set_maximum_items(i)
 self.assertEqual(self.gen.limit, i)
 
 def test_set_limit_as_string(self):
+Test setting the limit using an int cast into a string.
 for i in range(-2, 4):
 self.gen.set_maximum_items(str(i))
 self.assertEqual(self.gen.limit, i)
 
 def test_set_limit_not_number(self):
+Test setting the limit to not a number.
 with self.assertRaisesRegex(
 ValueError,
 invalid literal for int\(\) with base 10: 'test'):
@@ -792,6 +806,7 @@
 cached = False
 
 def test_normal_use(self):
+Test the caching of CachedRequest with an ordinary request.
 mysite = self.get_site()
 mainpage = self.get_mainpage()
 # Run the cached query three times to ensure the
@@ -817,6 +832,7 @@
 self.assertEqual(req2._cachetime, req3._cachetime)
 
 def test_internals(self):
+Test the caching of CachedRequest by faking a unique request.
 mysite = self.get_site()
 # Run tests on a missing page unique to this test run so it can

[MediaWiki-commits] [Gerrit] Add simple haveged module - change (operations/puppet)

2015-08-16 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231973

Change subject: Add simple haveged module
..

Add simple haveged module

The haveged project is an attempt to provide an easy-to-use, unpredictable
random number generator based upon an adaptation of the HAVEGE algorithm.
Haveged was created to remedy low-entropy conditions in the Linux random device
that can occur under some workloads, especially on headless servers.

Bug: T82576
Change-Id: Icb18c15dbc1031eed718a238b3b50dc3bdb6101b
---
A modules/haveged/manifests/init.pp
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/73/231973/1

diff --git a/modules/haveged/manifests/init.pp 
b/modules/haveged/manifests/init.pp
new file mode 100644
index 000..721bc25
--- /dev/null
+++ b/modules/haveged/manifests/init.pp
@@ -0,0 +1,19 @@
+# == Class: haveged
+#
+# The haveged project is an attempt to provide an easy-to-use, unpredictable
+# random number generator based upon an adaptation of the HAVEGE algorithm.
+# Haveged was created to remedy low-entropy conditions in the Linux random
+# device that can occur under some workloads, especially on headless servers.
+#
+class haveged {
+require_package('haveged')
+
+service { 'haveged':
+ensure   = running,
+enable   = true,
+provider = $::initsystem ? {
+systemd = 'systemd',
+default = 'debian',
+},
+}
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/231973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb18c15dbc1031eed718a238b3b50dc3bdb6101b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh o...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] os_version: Add Ubuntu Vivid Wily, Debian Stretch Buster - change (operations/puppet)

2015-08-16 Thread Ori.livneh (Code Review)

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231972

Change subject: os_version: Add Ubuntu Vivid  Wily, Debian Stretch  Buster
..

os_version: Add Ubuntu Vivid  Wily, Debian Stretch  Buster

Change-Id: Id67989183161598fb5613aca64108ba5a1450dd6
---
M modules/wmflib/lib/puppet/parser/functions/os_version.rb
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/72/231972/1

diff --git a/modules/wmflib/lib/puppet/parser/functions/os_version.rb 
b/modules/wmflib/lib/puppet/parser/functions/os_version.rb
index e48c79c..4fce749 100644
--- a/modules/wmflib/lib/puppet/parser/functions/os_version.rb
+++ b/modules/wmflib/lib/puppet/parser/functions/os_version.rb
@@ -37,11 +37,15 @@
   'Raring'   = '13.04',
   'Saucy'= '13.10',
   'Trusty'   = '14.04',
-  'Utopic'   = '14.10'
+  'Utopic'   = '14.10',
+  'Vivid'= '15.04',
+  'Wily' = '15.10',
 },
 'Debian' = {
   'Jessie'  = '8',
   'Wheezy'  = '7',
+  'Stretch' = '9',
+  'Buster'  = '10',
 }
   }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id67989183161598fb5613aca64108ba5a1450dd6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh o...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Italian translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread Ricordisamoa (Code Review)

Ricordisamoa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231975

Change subject: Add Italian translation for namespaces
..

Add Italian translation for namespaces

Accessorio derives from the localized name
of the Gadgets special page.

Change-Id: Ifc5eac7808b1549fbff3822da951d6e937f53053
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/75/231975/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0f386cb..4f74a4a 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -30,6 +30,13 @@
NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
 );
 
+$namespaceNames['it'] = array(
+   NS_GADGET = 'Accessorio',
+   NS_GADGET_TALK = 'Discussioni_accessorio',
+   NS_GADGET_DEFINITION = 'Definizione_accessorio',
+   NS_GADGET_DEFINITION_TALK = 'Discussioni_definizione_accessorio',
+);
+
 $namespaceNames['pl'] = array(
NS_GADGET = 'Gadżet',
NS_GADGET_TALK = 'Dyskusja_gadżetu',

-- 
To view, visit https://gerrit.wikimedia.org/r/231975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc5eac7808b1549fbff3822da951d6e937f53053
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa ricordisa...@openmailbox.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Don't allow shortening URLs with a username or password - change (mediawiki...UrlShortener)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Don't allow shortening URLs with a username or password
..


Don't allow shortening URLs with a username or password

...and fix the error message for invalid ports.

Bug: T108604
Change-Id: I02d139cbf60efa45db52061734c4db63375356c1
---
M UrlShortener.utils.php
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.urlShortener.special.js
5 files changed, 15 insertions(+), 3 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/UrlShortener.utils.php b/UrlShortener.utils.php
index 8543900..72ad2df 100755
--- a/UrlShortener.utils.php
+++ b/UrlShortener.utils.php
@@ -187,6 +187,11 @@
return wfMessage( 
'urlshortener-error-badports' );
}
}
+
+   if ( isset( $urlParts['user'] ) || isset( 
$urlParts['pass'] ) ) {
+   return wfMessage( 
'urlshortener-error-nouserpass' );
+   }
+
$domain = $urlParts['host'];
 
if ( preg_match( '/' . self::getWhitelistRegex() . '/', 
$domain ) === 1 ) {
diff --git a/extension.json b/extension.json
index 3ec6709..fa28fd1 100644
--- a/extension.json
+++ b/extension.json
@@ -56,6 +56,7 @@
urlshortener-error-malformed-url,
urlshortener-error-disallowed-url,
urlshortener-error-badports,
+   urlshortener-error-nouserpass,
urlshortener-url-input-submit,
urlshortener-url-input-submitting,
urlshortener-shortened-url-label
diff --git a/i18n/en.json b/i18n/en.json
index 688f06b..84c7cda 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,5 +18,6 @@
urlshortener-approved-domains: Links to the following 
{{PLURAL:$1|domain|domains}} may be shortened: $2.,
urlshortener-ratelimit: Please wait some time before shortening more 
URLs.,
urlshortener-toolbox: Get shortened URL,
-   urlshortener-error-badports: URLs that contain ports are not allowed 
to be shortened
+   urlshortener-error-badports: URLs that contain ports are not allowed 
to be shortened,
+   urlshortener-error-nouserpass: URLs that contain a username or 
password are not allowed to be shortened
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 60524da..39edd3e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -19,5 +19,6 @@
urlshortener-approved-domains: Help message displayed on 
Special:UrlShortener showing which domains can be shortened. $1 is the number 
of domains, $2 is a comma separated list of domains.,
urlshortener-ratelimit: Error message shown when a user shortens too 
many urls in a short period of time,
urlshortener-toolbox: Text of link in toolbox to get shortened URL,
-   urlshortener-error-badports: Error message shown when the URL cannot 
be shortened because it contains a port (e.g. http://example.org:90/path)
+   urlshortener-error-badports: Error message shown when the URL cannot 
be shortened because it contains a port (e.g. http://example.org:90/path),
+   urlshortener-error-nouserpass: Error message shown when the URL 
cannot be shortened because it contains a username or password (e.g. 
http://user:passw...@example.org/)
 }
diff --git a/modules/ext.urlShortener.special.js 
b/modules/ext.urlShortener.special.js
index dac06aa..dbf7bb8 100644
--- a/modules/ext.urlShortener.special.js
+++ b/modules/ext.urlShortener.special.js
@@ -59,7 +59,11 @@
!self.allowArbitraryPorts 
!( parsed.port === '80' || parsed.port === 
'443' )
) {
-   return showError( 'urlshortener-error-badports' 
);
+   return showError( mw.msg( 
'urlshortener-error-badports' ) );
+   }
+
+   if ( parsed.user || parsed.password ) {
+   return showError( mw.msg( 
'urlshortener-error-nouserpass' ) );
}
 
self.input.setLabel( null );

-- 
To view, visit https://gerrit.wikimedia.org/r/231744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02d139cbf60efa45db52061734c4db63375356c1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UrlShortener
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Prtksxna psax...@wikimedia.org
Gerrit-Reviewer: Siebrand siebr...@kitano.nl
Gerrit-Reviewer: jenkins-bot 

___

[MediaWiki-commits] [Gerrit] Inserted ComboBoxWidget successfully - change (mediawiki...LanguageTool)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Inserted ComboBoxWidget successfully
..


Inserted ComboBoxWidget successfully

Change-Id: I2d5e95448fd1eef12113aa5c280054a1d9d75d6f
---
M modules/ext.LanguageTool.css
M modules/ext.LanguageToolDialog.js
2 files changed, 57 insertions(+), 12 deletions(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.LanguageTool.css b/modules/ext.LanguageTool.css
index 4338aef..9d9a3b1 100644
--- a/modules/ext.LanguageTool.css
+++ b/modules/ext.LanguageTool.css
@@ -26,11 +26,24 @@
padding-right: 0;
 }
 
-.ve-ui-findAndReplaceDialog-cell-input {
+.ve-ui-findAndReplaceDialog-cell-input-find {
width: 100%;
 }
 
-.ve-ui-findAndReplaceDialog-cell-input .oo-ui-textInputWidget {
+.ve-ui-findAndReplaceDialog-cell-input-find .oo-ui-textInputWidget {
+   max-width: none;
+}
+
+.ve-ui-findAndReplaceDialog-cell-input-replace {
+   width: 100%;
+}
+
+.ve-ui-findAndReplaceDialog-overlay {
+   width : 100%;
+   overflow: auto;
+}
+
+.ve-ui-findAndReplaceDialog-cell-input-replace .oo-ui-comboBoxWidget {
max-width: none;
 }
 
diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 1acc060..e594e8c 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -82,10 +82,36 @@
iconTitle: ve.msg( 'visualeditor-find-and-replace-next-button' 
) + ' ' +
ve.ui.triggerRegistry.getMessages( 'findNext' ).join( 
', ' )
} );
-   this.replaceText = new OO.ui.TextInputWidget( {
-   placeholder: ve.msg( 
'visualeditor-find-and-replace-replace-text' ),
-   readOnly: true
+
+   this.replaceText = new OO.ui.ComboBoxWidget( {
+   label: 'ComboBoxWidget',
+   input: { value: 'Option 123' },
+   menu: {
+   items: [
+   new OO.ui.MenuOptionWidget( {
+   data: 'Option 1',
+   label: 'Option 123'
+   } ),
+   new OO.ui.MenuOptionWidget( {
+   data: 'Option 2',
+   label: 'Option Two'
+   } ),
+   new OO.ui.MenuOptionWidget( {
+   data: 'Option 3',
+   label: 'Option Three'
+   } ),
+   new OO.ui.MenuOptionWidget( {
+   data: 'Option 4',
+   label: 'Option Four'
+   } ),
+   new OO.ui.MenuOptionWidget( {
+   data: 'Option 5',
+   label: 'Option Five'
+   } )
+   ]
+   }
} );
+
this.replaceButton = new OO.ui.ButtonWidget( {
label: ve.msg( 'visualeditor-find-and-replace-replace-button' )
} );
@@ -128,19 +154,18 @@
 
// Initialization
this.findText.$input.prop( 'tabIndex', 1 );
-   this.replaceText.$input.prop( 'tabIndex', 2 );
this.$content.addClass( 've-ui-findAndReplaceDialog-content' );
this.$body
.append(
$findRow.append(
-   $( 'div' ).addClass( 
've-ui-findAndReplaceDialog-cell ve-ui-findAndReplaceDialog-cell-input' 
).append(
+   $( 'div' ).addClass( 
've-ui-findAndReplaceDialog-cell ve-ui-findAndReplaceDialog-cell-input-find' 
).append(
this.findText.$element
),
navigateGroup.$element,
optionsGroup.$element
),
$replaceRow.append(
-   $( 'div' ).addClass( 
've-ui-findAndReplaceDialog-cell ve-ui-findAndReplaceDialog-cell-input' 
).append(
+   $( 'div' ).css( { height: '90px' } 
).addClass( 've-ui-findAndReplaceDialog-cell 
ve-ui-findAndReplaceDialog-cell-input-replace' ).append(
this.replaceText.$element
),
replaceGroup.$element,
@@ -580,10 +605,17 @@
 mw.LanguageToolDialog.prototype.displayInformation = function () {
var replacements, error;
 
-   error = this.errors[ this.focusedIndex ].description;
-   replacements = this.errors[ this.focusedIndex ].replacements;
-   this.findText.setValue( error );
-   this.replaceText.setValue(

[MediaWiki-commits] [Gerrit] Vietnamese namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Vietnamese namespaces
..


Vietnamese namespaces

Change-Id: I1f76e00b04a740c646456ae6f296198ff2f1d18c
---
M Gadgets.namespaces.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0aa17be..920272a 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -30,3 +30,9 @@
NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
 );
 
+$namespaceNames['vi'] = array(
+   NS_GADGET = 'Tiện_ích',
+   NS_GADGET_TALK = 'Thảo_luận_Tiện_ích',
+   NS_GADGET_DEFINITION = 'Định_nghĩa_tiện_ích',
+   NS_GADGET_DEFINITION_TALK = 'Thảo_luận_Định_nghĩa_tiện_ích',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/231871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f76e00b04a740c646456ae6f296198ff2f1d18c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Mxn m...@1ec5.org
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Mjbmr mjb...@gmail.com
Gerrit-Reviewer: Mxn m...@1ec5.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Italian translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged.

Change subject: Add Italian translation for namespaces
..


Add Italian translation for namespaces

Accessorio derives from the localized name
of the Gadgets special page.

Change-Id: Ifc5eac7808b1549fbff3822da951d6e937f53053
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 0f386cb..4f74a4a 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -30,6 +30,13 @@
NS_GADGET_DEFINITION_TALK = 'שיחת_הגדרת_גאדג\'ט',
 );
 
+$namespaceNames['it'] = array(
+   NS_GADGET = 'Accessorio',
+   NS_GADGET_TALK = 'Discussioni_accessorio',
+   NS_GADGET_DEFINITION = 'Definizione_accessorio',
+   NS_GADGET_DEFINITION_TALK = 'Discussioni_definizione_accessorio',
+);
+
 $namespaceNames['pl'] = array(
NS_GADGET = 'Gadżet',
NS_GADGET_TALK = 'Dyskusja_gadżetu',

-- 
To view, visit https://gerrit.wikimedia.org/r/231975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc5eac7808b1549fbff3822da951d6e937f53053
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa ricordisa...@openmailbox.org
Gerrit-Reviewer: Alessio alessio...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Incola diegmo...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Nemo bis federicol...@tiscali.it
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPR] remove obsolete gen.set_query_increment(50) setting - change (pywikibot/core)

2015-08-16 Thread Xqt (Code Review)

Xqt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231901

Change subject: [IMPR] remove obsolete gen.set_query_increment(50) setting
..

[IMPR] remove obsolete gen.set_query_increment(50) setting

APIGenerator.query_increment is set to 50 in contructor.
It is obsolete to set this value again.

Change-Id: Idfdd57683a6f922637daa80764390130f5110a39
---
M pywikibot/site.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/01/231901/1

diff --git a/pywikibot/site.py b/pywikibot/site.py
index 4e87cb6..ecda3e6 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -6532,7 +6532,6 @@
 
 gen = api.APIGenerator('wbsearchentities', data_name='search',
search=search, language=language, **kwargs)
-gen.set_query_increment(50)
 if limit is not None:
 gen.set_maximum_items(limit)
 return gen

-- 
To view, visit https://gerrit.wikimedia.org/r/231901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfdd57683a6f922637daa80764390130f5110a39
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt i...@gno.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [FIX] api_tests: Call super's setUp and tearDown - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231966

Change subject: [FIX] api_tests: Call super's setUp and tearDown
..

[FIX] api_tests: Call super's setUp and tearDown

Change-Id: I324e65c2139d59b2c0e079ffe98df9b6131e1a48
---
M tests/api_tests.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/66/231966/1

diff --git a/tests/api_tests.py b/tests/api_tests.py
index 822f70a..071be74 100644
--- a/tests/api_tests.py
+++ b/tests/api_tests.py
@@ -879,11 +879,13 @@
 # pywikibot is not connected to a tty. T100964
 
 def setUp(self):
+super(TestLazyLoginNotExistUsername, self).setUp()
 self.orig_login_manager = pywikibot.data.api.LoginManager
 pywikibot.data.api.LoginManager = FakeLoginManager
 
 def tearDown(self):
 pywikibot.data.api.LoginManager = self.orig_login_manager
+super(TestLazyLoginNotExistUsername, self).tearDown()
 
 def test_access_denied_notexist_username(self):
 Test the query with a username which does not exist.

-- 
To view, visit https://gerrit.wikimedia.org/r/231966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I324e65c2139d59b2c0e079ffe98df9b6131e1a48
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise commodorefabia...@gmx.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Urdu translation for namespaces - change (mediawiki...Gadgets)

2015-08-16 Thread Code Review

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231965

Change subject: Add Urdu translation for namespaces
..

Add Urdu translation for namespaces

Translations provided by MuhammadShuaib at T109206. I do no speak the
language, but they have been vetted by Urdu Wikipedia community and
automated translation back to English looks sane.

Bug: T109206
Change-Id: I6f0555b8f02895f547a708ff6845d975fb5e29e3
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/65/231965/1

diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 7781a96..0f386cb 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -37,6 +37,13 @@
NS_GADGET_DEFINITION_TALK = 'Dyskusja_definicji_gadżetu',
 );
 
+$namespaceNames['ur'] = array(
+   NS_GADGET = 'آلہ',
+   NS_GADGET_TALK = 'تبادلۂ_خیال_آلہ',
+   NS_GADGET_DEFINITION = 'تعریف_آلہ',
+   NS_GADGET_DEFINITION_TALK = 'تبادلۂ_خیال_تعریف_آلہ',
+);
+
 $namespaceNames['vi'] = array(
NS_GADGET = 'Tiện_ích',
NS_GADGET_TALK = 'Thảo_luận_Tiện_ích',

-- 
To view, visit https://gerrit.wikimedia.org/r/231965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f0555b8f02895f547a708ff6845d975fb5e29e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] i18n_tests: Remove superfluous assertion - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231967

Change subject: [IMPROV] i18n_tests: Remove superfluous assertion
..

[IMPROV] i18n_tests: Remove superfluous assertion

If a method raises an exception, its output can't be compared via `assertEqual`
and usually this would lead to the test to error. But if this is then wrapped
in an `assertRaises`, it will expect that exception and thus prevent the error.
But that requires an exception so that the only way `assertEqual` actually does
compare two values will lead to `assertRaises` to fail because no exception was
raised.

This also removes any string formatting which would be done after the method
call which is tested and which is thus never done anyway.

Change-Id: I10690b8bd5d263001ae5b12a331b3b465150ca30
---
M tests/i18n_tests.py
1 file changed, 7 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/67/231967/1

diff --git a/tests/i18n_tests.py b/tests/i18n_tests.py
index aeb214e..c2caabd 100644
--- a/tests/i18n_tests.py
+++ b/tests/i18n_tests.py
@@ -279,38 +279,24 @@
 Test wrong parameter length.
 err_msg = 'Length of parameter does not match PLURAL occurrences'
 with self.assertRaisesRegex(ValueError, err_msg):
-self.assertEqual(
-i18n.twntranslate('de', 'test-multiple-plurals', (1, 2))
-% {'action': u'Ändere', 'line': u'drei'},
-u'Bot: Ändere drei Zeilen von mehreren Seiten.')
+i18n.twntranslate('de', 'test-multiple-plurals', (1, 2))
 
 with self.assertRaisesRegex(ValueError, err_msg):
-self.assertEqual(
-i18n.twntranslate('de', 'test-multiple-plurals', [321])
-% {'action': u'Ändere', 'line': u'dreihunderteinundzwanzig'},
-u'Bot: Ändere dreihunderteinundzwanzig Zeilen von mehreren 
Seiten.')
+i18n.twntranslate('de', 'test-multiple-plurals', [321])
 
 def testMultipleNonNumbers(self):
 Test error handling for multiple non-numbers.
 with self.assertRaisesRegex(ValueError, invalid literal for int\(\) 
with base 10: 'drei'):
-self.assertEqual(
-i18n.twntranslate('de', 'test-multiple-plurals', [drei, 1, 
1])
-% {'action': u'Ändere', 'line': u'drei'},
-u'Bot: Ändere drei Zeilen von einer Seite.')
+i18n.twntranslate('de', 'test-multiple-plurals', [drei, 1, 1])
 with self.assertRaisesRegex(ValueError, invalid literal for int\(\) 
with base 10: 'elf'):
-self.assertEqual(
-i18n.twntranslate('de', 'test-multiple-plurals',
-  {'action': u'Ändere', 'line': elf, 'page': 
2}),
-u'Bot: Ändere elf Zeilen von mehreren Seiten.')
+i18n.twntranslate('de', 'test-multiple-plurals',
+  {'action': u'Ändere', 'line': elf, 'page': 2})
 
 def testAllParametersExist(self):
 with self.assertRaisesRegex(KeyError, repr(u'line')):
 # all parameters must be inside twntranslate
-self.assertEqual(
-i18n.twntranslate('de', 'test-multiple-plurals',
-  {'line': 1, 'page': 1})
-% {'action': u'Ändere'},
-u'Bot: Ändere 1 Zeile von einer Seite.')
+i18n.twntranslate('de', 'test-multiple-plurals',
+  {'line': 1, 'page': 1})
 
 def test_fallback_lang(self):
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I10690b8bd5d263001ae5b12a331b3b465150ca30
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise commodorefabia...@gmx.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [IMPROV] tests: Use Request's parameters parameter - change (pywikibot/core)

2015-08-16 Thread XZise (Code Review)

XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231971

Change subject: [IMPROV] tests: Use Request's parameters parameter
..

[IMPROV] tests: Use Request's parameters parameter

With b44e59ae the constructor of `Request` should expect the MW API parameter
only via `parameters`. This is implementing it for a few tests.

Change-Id: Ib9e55bdef4aca301ea44d132334bcd2a24047fd3
---
M tests/api_tests.py
M tests/dry_api_tests.py
2 files changed, 41 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/71/231971/1

diff --git a/tests/api_tests.py b/tests/api_tests.py
index 822f70a..3945884 100644
--- a/tests/api_tests.py
+++ b/tests/api_tests.py
@@ -110,7 +110,8 @@
 
 def testObjectCreation(self):
 Test api.Request() constructor with implicit site creation.
-req = api.Request(action=test, foo=, bar=test)
+req = api.Request(parameters={'action': 'test', 'foo': '',
+  'bar': 'test'})
 self.assertTrue(req)
 self.assertEqual(req.site, self.get_site())
 
@@ -122,7 +123,8 @@
 def testObjectCreation(self):
 Test api.Request() constructor.
 mysite = self.get_site()
-req = api.Request(site=mysite, action=test, foo=, bar=test)
+req = api.Request(site=mysite, parameters={'action': 'test', 'foo': '',
+   'bar': 'test'})
 self.assertTrue(req)
 self.assertEqual(req.site, mysite)
 self.assertIn(foo, req._params)
@@ -802,13 +804,13 @@
   'titles': mainpage.title(),
   }
 req1 = api.CachedRequest(datetime.timedelta(minutes=10),
- site=mysite, **params)
+ site=mysite, parameters=params)
 data1 = req1.submit()
 req2 = api.CachedRequest(datetime.timedelta(minutes=10),
- site=mysite, **params)
+ site=mysite, parameters=params)
 data2 = req2.submit()
 req3 = api.CachedRequest(datetime.timedelta(minutes=10),
- site=mysite, **params)
+ site=mysite, parameters=params)
 data3 = req3.submit()
 self.assertEqual(data1, data2)
 self.assertEqual(data2, data3)
@@ -826,7 +828,7 @@
   'titles': 'TestCachedRequest_test_internals ' + str(now),
   }
 req = api.CachedRequest(datetime.timedelta(minutes=10),
-site=mysite, **params)
+site=mysite, parameters=params)
 rv = req._load_cache()
 self.assertFalse(rv)
 self.assertIsNone(req._data)
@@ -888,7 +890,7 @@
 def test_access_denied_notexist_username(self):
 Test the query with a username which does not exist.
 self.site._username = ['Not registered username', None]
-req = api.Request(site=self.site, action='query')
+req = api.Request(site=self.site, parameters={'action': 'query'})
 self.assertRaises(pywikibot.NoUsername, req.submit)
 # FIXME: T100965
 self.assertRaises(api.APIError, req.submit)
@@ -909,7 +911,7 @@
 if 'steward' in pywikibot.config.usernames:
 del pywikibot.config.usernames['steward']
 
-req = api.Request(site=self.site, action='query')
+req = api.Request(site=self.site, parameters={'action': 'query'})
 self.assertRaises(pywikibot.NoUsername, req.submit)
 # FIXME: T100965
 self.assertRaises(api.APIError, req.submit)
diff --git a/tests/dry_api_tests.py b/tests/dry_api_tests.py
index 5266256..53b3cef 100644
--- a/tests/dry_api_tests.py
+++ b/tests/dry_api_tests.py
@@ -48,17 +48,23 @@
 
 def setUp(self):
 super(DryCachedRequestTests, self).setUp()
-self.parms = {'site': self.basesite,
-  'action': 'query',
+self.parms = {'action': 'query',
   'meta': 'userinfo'}
-self.req = CachedRequest(expiry=1, **self.parms)
-self.expreq = CachedRequest(expiry=0, **self.parms)
-self.diffreq = CachedRequest(expiry=1, site=self.basesite, 
action='query', meta='siteinfo')
-self.diffsite = CachedRequest(expiry=1, site=self.altsite, 
action='query', meta='userinfo')
+self.req = CachedRequest(expiry=1, site=self.basesite,
+ parameters=self.parms)
+self.expreq = CachedRequest(expiry=0, site=self.basesite,
+parameters=self.parms)
+self.diffreq = CachedRequest(
+expiry=1, site=self.basesite,
+parameters={'action': 'query', 'meta': 'siteinfo'})
+self.diffsite = CachedRequest(
+expiry=1, site=self.altsite,
+

[MediaWiki-commits] [Gerrit] Fix array access error in LoginForm - change (mediawiki/core)

2015-08-16 Thread Code Review

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231974

Change subject: Fix array access error in LoginForm
..

Fix array access error in LoginForm

The status code from a login attempt should be an integer but
sometimes is not; due to differences in type juggling in $a[$x]
and switch($x) it will pass the error handling in the switch and
cause an error in the array access.

Bug: T109193
Change-Id: I56cb3e9ba87c08fdff4c389aae22a5c913cb3484
---
M includes/api/ApiLogin.php
M includes/specials/SpecialUserlogin.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/231974/1

diff --git a/includes/api/ApiLogin.php b/includes/api/ApiLogin.php
index 8c65310..0e0d0f3 100644
--- a/includes/api/ApiLogin.php
+++ b/includes/api/ApiLogin.php
@@ -179,7 +179,7 @@
LoggerFactory::getInstance( 'authmanager' )-info( 'Login 
attempt', array(
'event' = 'login',
'successful' = $authRes === LoginForm::SUCCESS,
-   'status' = LoginForm::$statusCodes[$authRes],
+   'status' = LoginForm::$statusCodes[(int)$authRes],
) );
}
 
diff --git a/includes/specials/SpecialUserlogin.php 
b/includes/specials/SpecialUserlogin.php
index 0b500f4..c1b75e4 100644
--- a/includes/specials/SpecialUserlogin.php
+++ b/includes/specials/SpecialUserlogin.php
@@ -1067,7 +1067,7 @@
LoggerFactory::getInstance( 'authmanager' )-info( 'Login 
attempt', array(
'event' = 'login',
'successful' = $status === self::SUCCESS,
-   'status' = LoginForm::$statusCodes[$status],
+   'status' = LoginForm::$statusCodes[(int)$status],
) );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56cb3e9ba87c08fdff4c389aae22a5c913cb3484
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza gti...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Clear up usage of --wiki parameter to mwscript - change (operations/mediawiki-config)

2015-08-16 Thread Alex Monk (Code Review)

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231982

Change subject: Clear up usage of --wiki parameter to mwscript
..

Clear up usage of --wiki parameter to mwscript

* Fix error which was saying --wiki should be the first parameter (it should
  go after the script name and therefore be the second).
* If you don't supply '--wiki', add that into $argv when interpreting
  mwscript scriptname.php dbname, to avoid breaking code which just does
  getArg( 0 )

Bug: T90343
Change-Id: I9e70521f76e00d3e3e488f2696fd95dbc83aad63
---
M multiversion/MWMultiVersion.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/82/231982/1

diff --git a/multiversion/MWMultiVersion.php b/multiversion/MWMultiVersion.php
index c9c43f1..646dd80 100644
--- a/multiversion/MWMultiVersion.php
+++ b/multiversion/MWMultiVersion.php
@@ -220,10 +220,11 @@
$dbname = substr( $argv[1], 7 ); // script.php 
--wiki=dbname
} elseif ( isset( $argv[1] )  substr( $argv[1], 0, 2 ) !== 
'--' ) {
$dbname = $argv[1]; // script.php dbname
+   $argv[1] = '--wiki=' . $dbname;
}
 
if ( $dbname === '' ) {
-   self::error( --wiki must be the first parameter.\n );
+   self::error( --wiki must be the second parameter.\n );
}
 
$this-db = $dbname;

-- 
To view, visit https://gerrit.wikimedia.org/r/231982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e70521f76e00d3e3e488f2696fd95dbc83aad63
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Makes replace from drop-down works - change (mediawiki...LanguageTool)

2015-08-16 Thread Ankita-ks (Code Review)

Ankita-ks has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231986

Change subject: Makes replace from drop-down works
..

Makes replace from drop-down works

Change-Id: I4b4e09d3234989279996234f49c805841b0b4241
---
M modules/ext.LanguageToolDialog.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LanguageTool 
refs/changes/86/231986/1

diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 7c0f0e5..d407816 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -419,9 +419,9 @@
  * @param {number} index Index to replace
  */
 mw.LanguageToolDialog.prototype.replace = function ( index ) {
-   var replaceArr, replace = this.replaceText.getValue();
-   replaceArr = replace.split( '#' );
-   replace = replaceArr[ 0 ];
+   var replace;
+
+   replace = this.replaceText.getInput().getValue();
this.fragments[ index ].insertContent( replace, true );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b4e09d3234989279996234f49c805841b0b4241
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks kumariankita...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

94 matches

Mail list logo