[MediaWiki-commits] [Gerrit] Remove references to Entity from MockRepository - change (mediawiki...Wikibase)
Bene has uploaded a new change for review. https://gerrit.wikimedia.org/r/268866 Change subject: Remove references to Entity from MockRepository .. Remove references to Entity from MockRepository Change-Id: Ia7d1e4187bb5ab804976d943989dbf2830b345f2 --- M lib/tests/phpunit/MockRepository.php 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/66/268866/1 diff --git a/lib/tests/phpunit/MockRepository.php b/lib/tests/phpunit/MockRepository.php index 4e35177..3cecaa5 100644 --- a/lib/tests/phpunit/MockRepository.php +++ b/lib/tests/phpunit/MockRepository.php @@ -4,7 +4,6 @@ use Status; use User; -use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\EntityDocument; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\EntityRedirect; @@ -321,7 +320,7 @@ * * @param EntityId $entityId * -* @return Entity +* @return EntityDocument */ public function removeEntity( EntityId $entityId ) { try { @@ -368,7 +367,7 @@ * * @param EntityId[] $entityIds * -* @return Entity|null[] +* @return EntityDocument|null[] */ public function getEntities( array $entityIds ) { $entities = array(); -- To view, visit https://gerrit.wikimedia.org/r/268866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7d1e4187bb5ab804976d943989dbf2830b345f2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Bene___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add PopluateDatabase.php - change (mediawiki...ORES)
Ladsgroup has uploaded a new change for review. https://gerrit.wikimedia.org/r/268874 Change subject: Add PopluateDatabase.php .. Add PopluateDatabase.php Bug: T123795 Change-Id: Ia10250e261ed2a16afa970cdf3e9c5e3105bb98d --- A maintenance/PopluateDatabase.php 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES refs/changes/74/268874/1 diff --git a/maintenance/PopluateDatabase.php b/maintenance/PopluateDatabase.php new file mode 100644 index 000..5913d72 --- /dev/null +++ b/maintenance/PopluateDatabase.php @@ -0,0 +1,47 @@ +addDescription( 'Poplute the database' ); + $this->addOption( 'number', 'Number of revisions to be scored', false, true, 'n' ); + + } + + public function execute() { + $dbr = wfGetDb( DB_SLAVE ); + $limit = $this->getOption('number', 1000); + $join_conds = array( 'ores_classification' => + array( 'LEFT JOIN', array('oresc_rev = rc_this_oldid') ) + ); + $res = $dbr->select( array( 'recentchanges', 'ores_classification' ), + array( 'rc_this_oldid', 'rc_title' ), array( 'oresc_id IS NULL', 'rc_type' => 0 ), + __METHOD__, array( 'GROUP BY' => 'rc_this_oldid', 'ORDER BY' => 'rc_id', + 'DESC', 'LIMIT' => $limit ), $join_conds ); + foreach ( $res as $row ) { + $title = Title::makeTitle(0, $row->rc_title); + $job = new FetchScoreJob( $title, array( + 'revid' => $row->rc_this_oldid, + ) ); + JobQueueGroup::singleton()->push( $job ); + } + // @todo this script needs some output + } +} + +$maintClass = 'ORES\PopulateDatabase'; +require_once RUN_MAINTENANCE_IF_MAIN; -- To view, visit https://gerrit.wikimedia.org/r/268874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia10250e261ed2a16afa970cdf3e9c5e3105bb98d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ORES Gerrit-Branch: master Gerrit-Owner: Ladsgroup___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] hive query to extract sample query set - change (wikimedia...relevancylab)
DCausse has uploaded a new change for review. https://gerrit.wikimedia.org/r/268704 Change subject: hive query to extract sample query set .. hive query to extract sample query set This query strategy is to catch near_match queries followed by a full_text. It should track queries sent by desktop (mobile web?) users when hit enter in the top right search box. We can't really use full_text directly, it's polluted by tons of partial queries (Mobile app). In order to filter bots the query will take only one query by ip for one day. It seems to work but I'm not 100% sure. Bug: T125825 Change-Id: Ice89a203186e2e3c35e0108588c18fcacb1cfbc4 --- A misc/fulltextQueriesSample.hsql 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/relevancylab refs/changes/04/268704/1 diff --git a/misc/fulltextQueriesSample.hsql b/misc/fulltextQueriesSample.hsql new file mode 100644 index 000..53f4730 --- /dev/null +++ b/misc/fulltextQueriesSample.hsql @@ -0,0 +1,65 @@ +-- Random fulltext queries sample +-- +-- Queries useful to extract a sample query set of fulltext queries +-- We use query set that includes a near_match, which are likely run +-- when the user hit enter on the top right search box on the desktop +-- site. If the near_match query set includes a full_text query then +-- it's probable that the user is redirected to a search results page. +-- We can't really use full_text directly since the WikipediaApp sends +-- partial queries with partial words (search type ahead) which are +-- completely useless for measuring fulltext queries performances. +-- To avoid including too many automata queries we accept only one query +-- per ip-day. + +-- Random sample of 1000 queries that return more than 500 results +-- on enwiki over one week + +SET year=2016; +SET month=1; +SET day_min=25; +SET day_max=31; +SET min_res=500; +SET wiki='enwiki'; +SET index='enwiki_content'; +SET multi_word_regex='\\S\\s+\\S'; +SET single_word_regex='^\\s+$'; +SET query_regex=${hiveconf:multi_word_regex}; + +SELECT DISTINCT(q) FROM ( + SELECT + -- keep only one query at random per ip/day + FIRST_VALUE(areq.query) over ( + PARTITION by csr.ip, csr.day + ORDER BY rand() + ) as q + FROM + CirrusSearchRequestSet csr + -- Explode the requests array so we can extract the + -- last full_text query + LATERAL VIEW EXPLODE(requests) req as areq + WHERE + year = ${hiveconf:year} AND month = ${hiveconf:month} + AND day >= ${hiveconf:day_min} and day <= ${hiveconf:day_max} + + -- When the user hit enter it generates a near_match query first. + AND csr.requests[0].queryType = 'near_match' + + -- Filter the full_text query with more than 500 results + AND areq.queryType = 'full_text' + AND areq.hitstotal > ${hiveconf:min_res} + + -- Make sure we extract only enwiki_content + AND size(areq.indices) == 1 + AND areq.indices[0] = ${hiveconf:index} + AND wikiid=${hiveconf:wiki} + + AND areq.query RLIKE ${hiveconf:query_regex} + + -- TODO: make sure we don't get a did you mean + -- rewritten query. +) queries +-- Various stuff stolen from https://www.joefkelley.com/?p=736 +DISTRIBUTE BY RAND() +SORT BY rand() +LIMIT 1000; + -- To view, visit https://gerrit.wikimedia.org/r/268704 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice89a203186e2e3c35e0108588c18fcacb1cfbc4 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/relevancylab Gerrit-Branch: master Gerrit-Owner: DCausse___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] New Wikidata Build - 2016-02-06T10:00:01+0000 - change (mediawiki...Wikidata)
WikidataBuilder has uploaded a new change for review. https://gerrit.wikimedia.org/r/268861 Change subject: New Wikidata Build - 2016-02-06T10:00:01+ .. New Wikidata Build - 2016-02-06T10:00:01+ Change-Id: I87921fb6cefc0ed822a5a93d2887491f74d4e7ef --- M composer.lock M extensions/ArticlePlaceholder/Specials/SpecialAboutTopic.php M extensions/ArticlePlaceholder/i18n/en.json M extensions/Wikibase/client/i18n/jam.json M extensions/Wikibase/client/i18n/ka.json M extensions/Wikibase/client/i18n/ps.json M extensions/Wikibase/client/includes/DataAccess/PropertyParserFunction/Runner.php M extensions/Wikibase/client/includes/Hooks/DeletePageNoticeCreator.php M extensions/Wikibase/client/includes/Hooks/InfoActionHookHandler.php M extensions/Wikibase/client/includes/Hooks/MovePageNotice.php M extensions/Wikibase/client/includes/Hooks/OtherProjectsSidebarGenerator.php M extensions/Wikibase/client/includes/LangLinkHandler.php M extensions/Wikibase/client/includes/ParserOutput/ClientParserOutputDataUpdater.php M extensions/Wikibase/client/includes/SiteLinkCommentCreator.php M extensions/Wikibase/client/includes/UpdateRepo/UpdateRepo.php M extensions/Wikibase/client/includes/specials/SpecialPagesWithBadges.php M extensions/Wikibase/client/includes/specials/SpecialUnconnectedPages.php M extensions/Wikibase/client/includes/store/AddUsagesForPageJob.php M extensions/Wikibase/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php M extensions/Wikibase/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php M extensions/Wikibase/client/tests/phpunit/includes/SiteLinkCommentCreatorTest.php M extensions/Wikibase/client/tests/phpunit/includes/Usage/UsageTrackingIntegrationTest.php M extensions/Wikibase/client/tests/phpunit/includes/recentchanges/RecentChangeFactoryTest.php M extensions/Wikibase/docs/ontology.owl M extensions/Wikibase/lib/i18n/hu.json M extensions/Wikibase/lib/i18n/ps.json M extensions/Wikibase/lib/includes/MediaWikiContentLanguages.php M extensions/Wikibase/lib/includes/StaticContentLanguages.php M extensions/Wikibase/lib/includes/UnionContentLanguages.php M extensions/Wikibase/phpcs.xml M extensions/Wikibase/repo/i18n/cs.json M extensions/Wikibase/repo/i18n/de.json M extensions/Wikibase/repo/i18n/gl.json M extensions/Wikibase/repo/i18n/hu.json M extensions/Wikibase/repo/i18n/ja.json M extensions/Wikibase/repo/i18n/ka.json M extensions/Wikibase/repo/i18n/ps.json M extensions/Wikibase/repo/includes/api/EditEntity.php M extensions/Wikibase/repo/includes/api/GetClaims.php M extensions/Wikibase/repo/includes/api/ResultBuilder.php M extensions/Wikibase/repo/tests/phpunit/includes/api/ResultBuilderTest.php M extensions/Wikibase/repo/tests/phpunit/includes/api/SetClaimValueTest.php M extensions/Wikibase/view/resources.php M extensions/Wikibase/view/resources.test.php M extensions/Wikibase/view/resources/jquery/wikibase/snakview/snakview.js M extensions/Wikibase/view/resources/resources.php M extensions/Wikibase/view/resources/wikibase/entityChangers/resources.php M extensions/Wikibase/view/resources/wikibase/entityIdFormatter/resources.php M extensions/Wikibase/view/resources/wikibase/view/resources.php M extensions/Wikibase/view/src/EmptyEditSectionGenerator.php M extensions/Wikibase/view/src/EntityIdFormatterFactory.php M extensions/Wikibase/view/src/HtmlSnakFormatterFactory.php M extensions/Wikibase/view/src/SpecialPageLinker.php M extensions/Wikibase/view/src/Template/TemplateFactory.php M extensions/Wikibase/view/tests/qunit/jquery/resources.php M extensions/Wikibase/view/tests/qunit/resources.php M extensions/Wikibase/view/tests/qunit/wikibase/entityChangers/resources.php M extensions/Wikibase/view/tests/qunit/wikibase/entityIdFormatter/resources.php M extensions/Wikibase/view/tests/qunit/wikibase/utilities/resources.php M extensions/Wikibase/view/tests/qunit/wikibase/view/resources.php M vendor/composer/installed.json 61 files changed, 190 insertions(+), 107 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata refs/changes/61/268861/1 diff --git a/composer.lock b/composer.lock index e9687ca..20ef94b 100644 --- a/composer.lock +++ b/composer.lock @@ -777,12 +777,12 @@ "source": { "type": "git", "url": "https://github.com/wikimedia/mediawiki-extensions-ArticlePlaceholder.git;, -"reference": "a704bce577caff9b6a62a20f8ae2be0ea6b48b8e" +"reference": "922c260fd2fb74bbfedbcef2001b0745cb32859f" }, "dist": { "type": "zip", -"url": "https://api.github.com/repos/wikimedia/mediawiki-extensions-ArticlePlaceholder/zipball/a704bce577caff9b6a62a20f8ae2be0ea6b48b8e;, -"reference": "a704bce577caff9b6a62a20f8ae2be0ea6b48b8e", +"url":
[MediaWiki-commits] [Gerrit] Remove references to Entity in change tests - change (mediawiki...Wikibase)
Bene has uploaded a new change for review. https://gerrit.wikimedia.org/r/268867 Change subject: Remove references to Entity in change tests .. Remove references to Entity in change tests Change-Id: I0902ede77b82eaae195b95cb943a9037ba5734d3 --- M lib/tests/phpunit/changes/EntityChangeTest.php M lib/tests/phpunit/changes/ItemChangeTest.php M lib/tests/phpunit/changes/TestChanges.php 3 files changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/67/268867/1 diff --git a/lib/tests/phpunit/changes/EntityChangeTest.php b/lib/tests/phpunit/changes/EntityChangeTest.php index 142adc7..ef535ff 100644 --- a/lib/tests/phpunit/changes/EntityChangeTest.php +++ b/lib/tests/phpunit/changes/EntityChangeTest.php @@ -7,7 +7,7 @@ use RecentChange; use Revision; use stdClass; -use Wikibase\DataModel\Entity\Entity; +use Wikibase\DataModel\Entity\EntityDocument; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; @@ -63,13 +63,13 @@ $entities = array_filter( TestChanges::getEntities(), - function( Entity $entity ) use ( $entityClass ) { + function( EntityDocument $entity ) use ( $entityClass ) { return is_a( $entity, $entityClass ); } ); $cases = array_map( - function( Entity $entity ) { + function( EntityDocument $entity ) { return array( $entity ); }, $entities diff --git a/lib/tests/phpunit/changes/ItemChangeTest.php b/lib/tests/phpunit/changes/ItemChangeTest.php index c386c17..5d6d36c 100644 --- a/lib/tests/phpunit/changes/ItemChangeTest.php +++ b/lib/tests/phpunit/changes/ItemChangeTest.php @@ -5,7 +5,7 @@ use Diff\DiffOp\Diff\Diff; use Diff\DiffOp\DiffOpChange; use Exception; -use Wikibase\DataModel\Entity\Entity; +use Wikibase\DataModel\Entity\EntityDocument; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Services\Diff\ItemDiff; use Wikibase\EntityChange; @@ -38,14 +38,14 @@ public function entityProvider() { $entities = array_filter( TestChanges::getEntities(), - function( Entity $entity ) { + function( EntityDocument $entity ) { return ( $entity instanceof Item ); } ); $cases = array_map( - function( Entity $entity ) { - return array( $entity ); + function( Item $item ) { + return array( $item ); }, $entities ); diff --git a/lib/tests/phpunit/changes/TestChanges.php b/lib/tests/phpunit/changes/TestChanges.php index c47d34a..92ce5f7 100644 --- a/lib/tests/phpunit/changes/TestChanges.php +++ b/lib/tests/phpunit/changes/TestChanges.php @@ -3,6 +3,7 @@ namespace Wikibase\Test; use Wikibase\ChangeRow; +use Wikibase\DataModel\Entity\EntityDocument; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\Property; @@ -277,6 +278,9 @@ return $diffs; } + /** +* @return EntityDocument[] +*/ public static function getEntities() { $entityList = array(); -- To view, visit https://gerrit.wikimedia.org/r/268867 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0902ede77b82eaae195b95cb943a9037ba5734d3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Bene___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move VE module to extension.json - change (mediawiki...Graph)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/268875 Change subject: Move VE module to extension.json .. Move VE module to extension.json Change-Id: Iab603e466493711a4ce2b92283d2bd61d982dba1 --- M extension.json M includes/Graph.hooks.php 2 files changed, 60 insertions(+), 86 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Graph refs/changes/75/268875/1 diff --git a/extension.json b/extension.json index 6271466..0958ee0 100644 --- a/extension.json +++ b/extension.json @@ -101,6 +101,63 @@ ], "messages": [ "ok" ], "targets": [ "desktop" ] + }, + "ext.graph.visualEditor": { + "scripts": [ + "modules/ve-graph/ve.ce.MWGraphNode.js", + "modules/ve-graph/ve.dm.MWGraphModel.js", + "modules/ve-graph/ve.dm.MWGraphNode.js", + "modules/ve-graph/ve.ui.MWGraphDialog.js", + "modules/ve-graph/ve.ui.MWGraphDialogTool.js", + "modules/ve-graph/widgets/ve.ui.RowWidget.js", + "modules/ve-graph/widgets/ve.ui.TableWidget.js" + ], + "styles": [ + "modules/ve-graph/ve.ce.MWGraphNode.css", + "modules/ve-graph/ve.ui.MWGraphIcons.css", + "modules/ve-graph/widgets/ve.ui.RowWidget.css", + "modules/ve-graph/widgets/ve.ui.TableWidget.css" + ], + "dependencies": [ + "ext.graph.data", + "ext.visualEditor.mwcore", + "ext.visualEditor.mwimage.core" + ], + "messages": [ + "graph-ve-dialog-button-tooltip", + "graph-ve-dialog-edit-field-graph-type", + "graph-ve-dialog-edit-field-raw-json", + "graph-ve-dialog-edit-height", + "graph-ve-dialog-edit-json-invalid", + "graph-ve-dialog-edit-padding-auto", + "graph-ve-dialog-edit-padding-fieldset", + "graph-ve-dialog-edit-padding-table-bottom", + "graph-ve-dialog-edit-padding-table-left", + "graph-ve-dialog-edit-padding-table-right", + "graph-ve-dialog-edit-padding-table-top", + "graph-ve-dialog-edit-padding-table-unit", + "graph-ve-dialog-edit-page-data", + "graph-ve-dialog-edit-page-general", + "graph-ve-dialog-edit-page-raw", + "graph-ve-dialog-edit-size-fieldset", + "graph-ve-dialog-edit-size-table-unit", + "graph-ve-dialog-edit-table-row-delete", + "graph-ve-dialog-edit-title", + "graph-ve-dialog-edit-type-area", + "graph-ve-dialog-edit-type-bar", + "graph-ve-dialog-edit-type-line", + "graph-ve-dialog-edit-type-unknown", + "graph-ve-dialog-edit-width", + "graph-ve-dialog-edit-unknown-graph-type-warning", + "graph-ve-empty-graph", + "graph-ve-no-spec", + "graph-ve-vega-error", + "graph-ve-vega-error-no-render" + ], + "targets": [ + "mobile", + "desktop" + ] } }, "ResourceFileModulePaths": { @@ -116,9 +173,6 @@ ], "ParserAfterParse": [ "Graph\\Singleton::onParserAfterParse" - ], - "ResourceLoaderRegisterModules": [ - "Graph\\Hooks::onResourceLoaderRegisterModules" ], "ResourceLoaderTestModules": [ "Graph\\Hooks::onResourceLoaderTestModules" diff --git a/includes/Graph.hooks.php b/includes/Graph.hooks.php index 65f968a..2fbea28 100644 --- a/includes/Graph.hooks.php +++ b/includes/Graph.hooks.php @@ -12,93 +12,12 @@ class Hooks { /** -* Conditionally register the ext.graph.VisualEditor module if VisualEditor -
[MediaWiki-commits] [Gerrit] Add support for traits in ClassCollector - change (mediawiki/core)
Victorbarbu has uploaded a new change for review. https://gerrit.wikimedia.org/r/268876 Change subject: Add support for traits in ClassCollector .. Add support for traits in ClassCollector Bug: T126116 Change-Id: Ifb81c6844565736111717736fe7649492e31f0f7 --- M includes/utils/AutoloadGenerator.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/76/268876/1 diff --git a/includes/utils/AutoloadGenerator.php b/includes/utils/AutoloadGenerator.php index 7d63156..69426d7 100644 --- a/includes/utils/AutoloadGenerator.php +++ b/includes/utils/AutoloadGenerator.php @@ -310,6 +310,7 @@ case T_NAMESPACE: case T_CLASS: case T_INTERFACE: + case T_TRAIT: $this->startToken = $token; } } @@ -331,6 +332,7 @@ case T_CLASS: case T_INTERFACE: + case T_TRAIT: $this->tokens[] = $token; if ( is_array( $token ) && $token[0] === T_STRING ) { $this->classes[] = $this->namespace . $this->implodeTokens(); -- To view, visit https://gerrit.wikimedia.org/r/268876 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb81c6844565736111717736fe7649492e31f0f7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Victorbarbu___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits