[MediaWiki-commits] [Gerrit] Fix makeDumpList for WikimediaMaintenance removal - change (mediawiki...WikimediaMaintenance)

2016-03-29 Thread Tim Starling (Code Review) 
Tim Starling has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280385

Change subject: Fix makeDumpList for WikimediaMaintenance removal
..

Fix makeDumpList for WikimediaMaintenance removal

Class was removed in 7d2d286a9b3739f2ca831e89db9e0d22b3264a9f

Change-Id: If18443b6a07f17a82e2d03b3424650415c1ef73d
(cherry picked from commit 38dcaa3d0fbfa1c2022a6e74607ac55d883de5af)
---
M makeDumpList.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMaintenance 
refs/changes/85/280385/1

diff --git a/makeDumpList.php b/makeDumpList.php
index 955d614..89e67f5 100644
--- a/makeDumpList.php
+++ b/makeDumpList.php
@@ -2,7 +2,7 @@
 
 require_once( __DIR__ . '/WikimediaMaintenance.php' );
 
-class MakeDumpList extends WikimediaMaintenance {
+class MakeDumpList extends Maintenance {
public function __construct() {
parent::__construct();
$this->mDescription = 'From a list of page titles, generate a 
list of titles needed to render those pages, including templates and the pages 
themselves.';

-- 
To view, visit https://gerrit.wikimedia.org/r/280385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If18443b6a07f17a82e2d03b3424650415c1ef73d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMaintenance
Gerrit-Branch: wmf/1.27.0-wmf.18
Gerrit-Owner: Tim Starling 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [1.27.0-wmf.19] Fix makeDumpList for WikimediaMaintenance re... - change (mediawiki...WikimediaMaintenance)

2016-03-29 Thread Tim Starling (Code Review) 
Tim Starling has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280383

Change subject: [1.27.0-wmf.19] Fix makeDumpList for WikimediaMaintenance 
removal
..

[1.27.0-wmf.19] Fix makeDumpList for WikimediaMaintenance removal

Class was removed in 7d2d286a9b3739f2ca831e89db9e0d22b3264a9f

Change-Id: If18443b6a07f17a82e2d03b3424650415c1ef73d
(cherry picked from commit 38dcaa3d0fbfa1c2022a6e74607ac55d883de5af)
---
M makeDumpList.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMaintenance 
refs/changes/83/280383/1

diff --git a/makeDumpList.php b/makeDumpList.php
index 955d614..89e67f5 100644
--- a/makeDumpList.php
+++ b/makeDumpList.php
@@ -2,7 +2,7 @@
 
 require_once( __DIR__ . '/WikimediaMaintenance.php' );
 
-class MakeDumpList extends WikimediaMaintenance {
+class MakeDumpList extends Maintenance {
public function __construct() {
parent::__construct();
$this->mDescription = 'From a list of page titles, generate a 
list of titles needed to render those pages, including templates and the pages 
themselves.';

-- 
To view, visit https://gerrit.wikimedia.org/r/280383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If18443b6a07f17a82e2d03b3424650415c1ef73d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMaintenance
Gerrit-Branch: wmf/1.27.0-wmf.19
Gerrit-Owner: Tim Starling 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Change threshold for survey invitation from 2 unread notifs ... - change (mediawiki...Echo)

2016-03-29 Thread Mattflaschen (Code Review) 
Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280370

Change subject: Change threshold for survey invitation from 2 unread notifs to 1
..

Change threshold for survey invitation from 2 unread notifs to 1

Bug: T128937
Change-Id: I28d5d46a5ecd1c184269b7f8d3ba984bfedad77b
(cherry picked from commit 8f01e880b6a37210a7859c6adf6928cd962d2553)
---
M modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/70/280370/1

diff --git a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js 
b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
index 2795e6e..d8810f8 100644
--- a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
@@ -110,7 +110,7 @@
if (
mw.config.get( 'wgEchoShowFooterNotice' ) &&
!mw.user.options.get( 'echo-dismiss-feedback-alert' ) &&
-   initialNotifCount >= 2 &&
+   initialNotifCount >= 1 &&
mw.config.get( 'wgUserEditCount', 0 ) >= 100
) {
notice = new mw.echo.ui.FooterNoticeWidget( {

-- 
To view, visit https://gerrit.wikimedia.org/r/280370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28d5d46a5ecd1c184269b7f8d3ba984bfedad77b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.27.0-wmf.19
Gerrit-Owner: Mattflaschen 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Change threshold for survey invitation from 2 unread notifs ... - change (mediawiki...Echo)

2016-03-29 Thread Mattflaschen (Code Review) 
Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280369

Change subject: Change threshold for survey invitation from 2 unread notifs to 1
..

Change threshold for survey invitation from 2 unread notifs to 1

Bug: T128937
Change-Id: I28d5d46a5ecd1c184269b7f8d3ba984bfedad77b
(cherry picked from commit 8f01e880b6a37210a7859c6adf6928cd962d2553)
---
M modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/69/280369/1

diff --git a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js 
b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
index 7aa328d..3fbe99d 100644
--- a/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
@@ -109,7 +109,7 @@
if (
mw.config.get( 'wgEchoShowFooterNotice' ) &&
!mw.user.options.get( 'echo-dismiss-feedback-alert' ) &&
-   initialNotifCount >= 2 &&
+   initialNotifCount >= 1 &&
mw.config.get( 'wgUserEditCount', 0 ) >= 100
) {
notice = new mw.echo.ui.FooterNoticeWidget( {

-- 
To view, visit https://gerrit.wikimedia.org/r/280369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28d5d46a5ecd1c184269b7f8d3ba984bfedad77b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.27.0-wmf.18
Gerrit-Owner: Mattflaschen 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] uw.controller.Step: Refactor simultaneous transitions - change (mediawiki...UploadWizard)

2016-03-29 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280339

Change subject: uw.controller.Step: Refactor simultaneous transitions
..

uw.controller.Step: Refactor simultaneous transitions

Problems:
* We assumed that Upload and Details steps are sufficiently alike
  to use the same code for transitioning from them, but they aren't.
* The transitionAll() function, while otherwise adequate for Details,
  would blow up if uploads were removed while the queue was running.
* The transitionAll() function doesn't allow adding uploads while the
  queue is already running, which we tried to do in the Upload step.
  This resulted in the queue starting for every upload, effectively
  ignoring the maximum simultaneous upload limit.

Solutions:
* Introduce uw.ConcurrentQueue, which takes care of executing async
  functions, waiting for them to finish, then executing further ones,
  while also allowing actions to be added to or removed from the queue
  at any time and emitting events when things happen.
* uw.controller.Upload: Don't use transitionAll(), implement separate
  logic using uw.ConcurrentQueue. Update mw.UploadWizard to match.
* uw.controller.Details: Rewrite transitionAll() using uw.ConcurrentQueue.
* Remove the broken common implementation in uw.controller.Step.

Bug: T92809
Change-Id: I32fbd941f5a5dca50c030c3a93889a18537555ef
(cherry picked from commit a8a5966bf6aa76cb137b4b7cda4f3aa2635be991)
---
M UploadWizardHooks.php
M resources/controller/uw.controller.Details.js
M resources/controller/uw.controller.Step.js
M resources/controller/uw.controller.Upload.js
M resources/mw.UploadWizard.js
A resources/uw.ConcurrentQueue.js
M tests/qunit/controller/uw.controller.Details.test.js
M tests/qunit/controller/uw.controller.Step.test.js
M tests/qunit/controller/uw.controller.Upload.test.js
A tests/qunit/uw.ConcurrentQueue.test.js
10 files changed, 755 insertions(+), 132 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/39/280339/1

diff --git a/UploadWizardHooks.php b/UploadWizardHooks.php
index 35f7863..bae1a85 100644
--- a/UploadWizardHooks.php
+++ b/UploadWizardHooks.php
@@ -500,6 +500,7 @@
 
'uw.controller.Step' => array(
'scripts' => array(
+   'resources/uw.ConcurrentQueue.js',
'resources/controller/uw.controller.Step.js',
),
 
@@ -911,6 +912,7 @@

'tests/qunit/transports/mw.FormDataTransport.test.js',

'tests/qunit/transports/mw.IframeTransport.test.js',
'tests/qunit/uw.EventFlowLogger.test.js',
+   'tests/qunit/uw.ConcurrentQueue.test.js',
'tests/qunit/mw.UploadWizard.test.js',
'tests/qunit/mw.UploadWizardUpload.test.js',

'tests/qunit/mw.UploadWizardLicenseInput.test.js',
diff --git a/resources/controller/uw.controller.Details.js 
b/resources/controller/uw.controller.Details.js
index 3a9aed6..2d174fd 100644
--- a/resources/controller/uw.controller.Details.js
+++ b/resources/controller/uw.controller.Details.js
@@ -36,6 +36,11 @@
 
this.stepName = 'details';
this.finishState = 'complete';
+
+   this.queue = new uw.ConcurrentQueue( {
+   count: this.config.maxSimultaneousConnections,
+   action: this.transitionOne.bind( this )
+   } );
};
 
OO.inheritClass( uw.controller.Details, uw.controller.Step );
@@ -192,11 +197,41 @@
);
};
 
+   /**
+* Perform this step's changes on one upload.
+*
+* @return {jQuery.Promise}
+*/
uw.controller.Details.prototype.transitionOne = function ( upload ) {
return upload.details.submit();
};
 
/**
+* Perform this step's changes on all uploads.
+*
+* @return {jQuery.Promise}
+*/
+   uw.controller.Details.prototype.transitionAll = function () {
+   var
+   deferred = $.Deferred(),
+   details = this;
+
+   $.each( this.uploads, function ( i, upload ) {
+   if ( upload === undefined ) {
+   return;
+   }
+   if ( details.canTransition( upload ) ) {
+   details.queue.addItem( upload );
+   }
+   } );
+
+   this.queue.on( 'complete', deferred.resolve );
+   this.queue.startExecuting();
+
+   return deferred.promise();
+   };
+
+   /**
 * Submit details to the API.
 *

[MediaWiki-commits] [Gerrit] Optimise for automatic page images banners on mobile views - change (mediawiki...WikidataPageBanner)

2016-03-29 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280328

Change subject: Optimise for automatic page images banners on mobile views
..

Optimise for automatic page images banners on mobile views

Update algorithm for positioning images
* Hide the image until its positioned to avoid jerking movements
* Take into consideration whether a position was provided or not
* For portrait photos (height is greater than container) reposition
to -10% on basis that most portraits put the face in this position
* Add a bottom transparent border for white lead banners
* Add a panorama class to distinguish between portrait photos and panoramas
in the styling
** Reposition panoramas at -25% when no center position given

Bug: T131072
Change-Id: Idff7c17a6d1ab6e1324053247903052bc4087f5b
(cherry picked from commit c44b9bd61f710c45e5f804fad0f0c42c50e85c3b)
---
M includes/WikidataPageBanner.functions.php
M 
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.minerva.less
M templates/banner.mustache
M tests/phpunit/BannerOptionsTest.php
M 
tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
7 files changed, 82 insertions(+), 20 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/28/280328/1

diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 8072990..deb30e6 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -76,13 +76,16 @@
public static function addFocus( &$paramsForBannerTemplate, 
$argumentsFromParserFunction ) {
// default centering would be 0, and -1 would represent extreme 
left and extreme top
// Allowed values for each coordinate is between 0 and 1
+   // If no value has been specified these are set to null
$paramsForBannerTemplate['data-pos-x'] = 0;
$paramsForBannerTemplate['data-pos-y'] = 0;
+   $paramsForBannerTemplate['hasPosition'] = false;
 
if ( isset( $argumentsFromParserFunction['origin'] ) ) {
// split the origin into x and y coordinates
$coords = explode( ',', 
$argumentsFromParserFunction['origin'] );
if ( count( $coords ) === 2 ) {
+   $paramsForBannerTemplate['hasPosition'] = true;
$positionx = $coords[0];
$positiony = $coords[1];
// TODO:Add a js module to use the data-pos 
values being set below to fine tune the
@@ -167,7 +170,10 @@
$options['banner'] = $bannerurl;
$options['srcset'] = $srcset;
$file = wfFindFile( $bannerfile );
-   $options['maxWidth'] = $file->getWidth();
+   $fileWidth = $file->getWidth();
+   $options['maxWidth'] = $fileWidth;
+   // Provide information to the logic-less template about 
whether it is a panorama or not.
+   $options['isPanorama'] = $fileWidth > ( 
$file->getHeight() * 2 );
$options['isHeadingOverrideEnabled'] = $config->get( 
'WPBEnableHeadingOverride' );
$banner = $templateParser->processTemplate(
'banner',
diff --git 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index e541a9e..c688f80 100644
--- 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++ 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -13,8 +13,10 @@
$wpbBannerImage = $container.find( '.wpb-banner-image' 
),
totalOffsetX = 0,
totalOffsetY = 0,
+   containerWidth = $container.width(),
centerX = $wpbBannerImage.data( 'pos-x' ),
centerY = $wpbBannerImage.data( 'pos-y' );
+
// reset translations applied by css
$wpbBannerImage.css( {
transform: 'translate(0)',
@@ -25,7 +27,7 @@
'margin-top': 0
} );
// Adjust vertical focus
-   if ( $wpbBannerImage.height() > $container.height() ) {
+   if ( $wpbBannerImage.height() > $container.height() && centerY 
!== undefined ) {

[MediaWiki-commits] [Gerrit] Optimise for automatic page images banners on mobile views - change (mediawiki...WikidataPageBanner)

2016-03-29 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280327

Change subject: Optimise for automatic page images banners on mobile views
..

Optimise for automatic page images banners on mobile views

Update algorithm for positioning images
* Hide the image until its positioned to avoid jerking movements
* Take into consideration whether a position was provided or not
* For portrait photos (height is greater than container) reposition
to -10% on basis that most portraits put the face in this position
* Add a bottom transparent border for white lead banners
* Add a panorama class to distinguish between portrait photos and panoramas
in the styling
** Reposition panoramas at -25% when no center position given

Bug: T131072
Change-Id: Idff7c17a6d1ab6e1324053247903052bc4087f5b
(cherry picked from commit c44b9bd61f710c45e5f804fad0f0c42c50e85c3b)
---
M includes/WikidataPageBanner.functions.php
M 
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.minerva.less
M templates/banner.mustache
M tests/phpunit/BannerOptionsTest.php
M 
tests/qunit/ext.WikidataPageBanner.positionBanner/test_ext.WikidataPageBanner.positionBanner.js
7 files changed, 82 insertions(+), 20 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/27/280327/1

diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 8072990..deb30e6 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -76,13 +76,16 @@
public static function addFocus( &$paramsForBannerTemplate, 
$argumentsFromParserFunction ) {
// default centering would be 0, and -1 would represent extreme 
left and extreme top
// Allowed values for each coordinate is between 0 and 1
+   // If no value has been specified these are set to null
$paramsForBannerTemplate['data-pos-x'] = 0;
$paramsForBannerTemplate['data-pos-y'] = 0;
+   $paramsForBannerTemplate['hasPosition'] = false;
 
if ( isset( $argumentsFromParserFunction['origin'] ) ) {
// split the origin into x and y coordinates
$coords = explode( ',', 
$argumentsFromParserFunction['origin'] );
if ( count( $coords ) === 2 ) {
+   $paramsForBannerTemplate['hasPosition'] = true;
$positionx = $coords[0];
$positiony = $coords[1];
// TODO:Add a js module to use the data-pos 
values being set below to fine tune the
@@ -167,7 +170,10 @@
$options['banner'] = $bannerurl;
$options['srcset'] = $srcset;
$file = wfFindFile( $bannerfile );
-   $options['maxWidth'] = $file->getWidth();
+   $fileWidth = $file->getWidth();
+   $options['maxWidth'] = $fileWidth;
+   // Provide information to the logic-less template about 
whether it is a panorama or not.
+   $options['isPanorama'] = $fileWidth > ( 
$file->getHeight() * 2 );
$options['isHeadingOverrideEnabled'] = $config->get( 
'WPBEnableHeadingOverride' );
$banner = $templateParser->processTemplate(
'banner',
diff --git 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index e541a9e..c688f80 100644
--- 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++ 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -13,8 +13,10 @@
$wpbBannerImage = $container.find( '.wpb-banner-image' 
),
totalOffsetX = 0,
totalOffsetY = 0,
+   containerWidth = $container.width(),
centerX = $wpbBannerImage.data( 'pos-x' ),
centerY = $wpbBannerImage.data( 'pos-y' );
+
// reset translations applied by css
$wpbBannerImage.css( {
transform: 'translate(0)',
@@ -25,7 +27,7 @@
'margin-top': 0
} );
// Adjust vertical focus
-   if ( $wpbBannerImage.height() > $container.height() ) {
+   if ( $wpbBannerImage.height() > $container.height() && centerY 
!== undefined ) {

[MediaWiki-commits] [Gerrit] ExtendedSearch: Use categories from file page ... - change (mediawiki...BlueSpiceExtensions)

2016-03-29 Thread Mglaser (Code Review) 
Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280203

Change subject: ExtendedSearch: Use categories from file page ...
..

ExtendedSearch: Use categories from file page ...

... also on the file itself.

This allows filtering file hits using the 'category' facet.

Needs cherry-pick to REL1_23!

Change-Id: I4633dd7a4255b3c9732f5f00c66fa6ac7936515c
(cherry picked from commit 48ec67b65c178ad7431f5c4a7a950ae115df6048)
---
M ExtendedSearch/ExtendedSearch.class.php
M ExtendedSearch/includes/BuildIndex/AbstractBuildIndexAll.class.php
M ExtendedSearch/includes/BuildIndex/BuildIndexMwRepository.class.php
M ExtendedSearch/includes/BuildIndex/BuildIndexMwSingleFile.class.php
4 files changed, 45 insertions(+), 17 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/03/280203/1

diff --git a/ExtendedSearch/ExtendedSearch.class.php 
b/ExtendedSearch/ExtendedSearch.class.php
index c0a269f..f35c838 100644
--- a/ExtendedSearch/ExtendedSearch.class.php
+++ b/ExtendedSearch/ExtendedSearch.class.php
@@ -375,6 +375,23 @@
public function onArticleSaveComplete( &$oArticle, &$oUser ) {
try {
BuildIndexMainControl::getInstance()->updateIndexWiki( 
$oArticle );
+   $oTitle = $oArticle->getTitle();
+
+   //There may be an update to the categories of a file 
page, which
+   //in turn means that we need to update the index entry 
of the file
+   //with the new categories
+   if ( $oTitle->getNamespace() === NS_FILE ) {
+   $oFile = LocalFile::newFromTitle( $oTitle, 
RepoGroup::singleton()->getLocalRepo() );
+
+   //Unfortunately 
BuildIndexMwSingleFile::indexCrawledDocuments
+   //checks if the file is already on the index. 
If so it does not
+   //apply the update. To have our categories be 
written to the
+   //index we need to remove the file from the 
index first...
+   
BuildIndexMainControl::getInstance()->deleteIndexFile( $oFile->getPath(), 
'repo' );
+
+   //... and then add it again
+   
BuildIndexMainControl::getInstance()->updateIndexFile( $oFile );
+   }
} catch ( BsException $e ) {
wfDebugLog( 'ExtendedSearch', 'onArticleSaveComplete: 
'.$e->getMessage() );
}
diff --git a/ExtendedSearch/includes/BuildIndex/AbstractBuildIndexAll.class.php 
b/ExtendedSearch/includes/BuildIndex/AbstractBuildIndexAll.class.php
index 773a18d..64161df 100644
--- a/ExtendedSearch/includes/BuildIndex/AbstractBuildIndexAll.class.php
+++ b/ExtendedSearch/includes/BuildIndex/AbstractBuildIndexAll.class.php
@@ -19,7 +19,7 @@
 
/**
 * Instance of BuildIndexMainControl
-* @var BsBuildIndexMainControl
+* @var BuildIndexMainControl
 */
protected $oMainControl = null;
/**
@@ -49,8 +49,8 @@
protected $totalNoDocumentsCrawled = 0;
 
/**
-* Constructor for BsAbstractBuildIndexAll class
-* @param BsBuildIndexMainControl $oMainControl Instance of build index 
controller
+* Constructor for AbstractBuildIndexAll class
+* @param BuildIndexMainControl $oMainControl Instance of build index 
controller
 */
public function __construct( $oMainControl ) {
wfProfileIn( 'BS::'.__METHOD__ );
diff --git 
a/ExtendedSearch/includes/BuildIndex/BuildIndexMwRepository.class.php 
b/ExtendedSearch/includes/BuildIndex/BuildIndexMwRepository.class.php
index df2436e..e7c9790 100644
--- a/ExtendedSearch/includes/BuildIndex/BuildIndexMwRepository.class.php
+++ b/ExtendedSearch/includes/BuildIndex/BuildIndexMwRepository.class.php
@@ -75,10 +75,11 @@
 * @param string $fileText The body of the wiki-page or the document
 * @param string $realPath Path to document if external (not in wiki). 
Might be empty or null
 * @param unknown $ts Timestamp
+* @param array $aCategories
 * @return Apache_Solr_Document
 */
-   public function makeRepoDocument( $type, $img_name, &$text, $realPath, 
$ts, $sVirtualPath ) {
-   return $this->oMainControl->makeDocument( 'repo', $type, 
$img_name, $text, -1, 999, $realPath, $sVirtualPath, $ts );
+   public function makeRepoDocument( $type, $img_name, &$text, $realPath, 
$ts, $sVirtualPath, $aCategories ) {
+   return $this->oMainControl->makeDocument( 'repo', $type, 
$img_name, $text, -1, 999, $realPath, $sVirtualPath, $ts, $aCategories );
}
 
/**
@@ -116,8 +117,8 @@
if ( $this->checkExistence(

[MediaWiki-commits] [Gerrit] Test lazy load images with cookie on mobile - change (performance/WebPageTest)

2016-03-29 Thread Phedenskog (Code Review) 
Phedenskog has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280161

Change subject: Test lazy load images with cookie on mobile
..

Test lazy load images with cookie on mobile

Set the new cookie for lazy loading so we can measure the difference
on the Obama page. Lets skip the netspeed b tests, since we serve
the images at that size to all users.

The cookie implementation is in T127883.

Bug: T130706
Change-Id: I668be22ae9d9a55650578f5910f3972289adcbca
---
M scripts/batch/mobile.txt
A scripts/wptscripts/lazyloadimages-a-mobile-obama.txt
D scripts/wptscripts/netspeed-b-mobile-obama.txt
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/performance/WebPageTest 
refs/changes/61/280161/1

diff --git a/scripts/batch/mobile.txt b/scripts/batch/mobile.txt
index 7f3348c..299f2e4 100644
--- a/scripts/batch/mobile.txt
+++ b/scripts/batch/mobile.txt
@@ -37,4 +37,4 @@
 
 --webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>:Chrome --label chrome-emulated-m 
--runs <%WPT_MOBILE_RUNS> --reporter statsv --endpoint <%STATSV_ENDPOINT> 
--namespace webpagetest.test2wiki-mobile.anonymous.Washington_DC 
--emulateMobile true --connectivity 3GFast --first true 
https://test2.m.wikipedia.org/wiki/Washington,_D.C.
 
---webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>:Chrome --label 
netspeed-b-chrome-emulated-m-2g --runs <%WPT_MOBILE_RUNS> --endpoint 
<%STATSV_ENDPOINT> --namespace 
webpagetest.enwiki-mobile-2gslow-netspeedb.anonymous.Barack_Obama 
--emulateMobile true --bandwidthDown 35000 --bandwidthUp 32000 --latency 1300 
--connectivity custom --reporter statsv --first true 
./scripts/wptscripts/netspeed-b-mobile-obama.txt
+--webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>:Chrome --label 
lazyloadimages-a-chrome-emulated-m-2g --runs <%WPT_MOBILE_RUNS> --endpoint 
<%STATSV_ENDPOINT> --namespace 
webpagetest.enwiki-mobile-2gslow-lazyloadimages.anonymous.Barack_Obama 
--emulateMobile true --bandwidthDown 35000 --bandwidthUp 32000 --latency 1300 
--connectivity custom --reporter statsv --first true 
./scripts/wptscripts/lazyloadimages-a-mobile-obama.txt
diff --git a/scripts/wptscripts/lazyloadimages-a-mobile-obama.txt 
b/scripts/wptscripts/lazyloadimages-a-mobile-obama.txt
new file mode 100644
index 000..54e3374
--- /dev/null
+++ b/scripts/wptscripts/lazyloadimages-a-mobile-obama.txt
@@ -0,0 +1,2 @@
+setCookie  https://en.m.wikipedia.org/ LazyLoadImages=A
+navigate https://en.m.wikipedia.org/wiki/Barack_Obama
diff --git a/scripts/wptscripts/netspeed-b-mobile-obama.txt 
b/scripts/wptscripts/netspeed-b-mobile-obama.txt
deleted file mode 100644
index 0e66524..000
--- a/scripts/wptscripts/netspeed-b-mobile-obama.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-setCookie  https://en.m.wikipedia.org/ NetSpeed=B
-navigate https://en.m.wikipedia.org/wiki/Barack_Obama

-- 
To view, visit https://gerrit.wikimedia.org/r/280161
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I668be22ae9d9a55650578f5910f3972289adcbca
Gerrit-PatchSet: 1
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add user name autocompletion support to Special:EditProfile ... - change (mediawiki...SocialProfile)

2016-03-29 Thread Jack Phoenix (Code Review) 
Jack Phoenix has submitted this change and it was merged.

Change subject: Add user name autocompletion support to Special:EditProfile & 
Special:RemoveAvatar
..


Add user name autocompletion support to Special:EditProfile & 
Special:RemoveAvatar

Change-Id: I9e6f408592da89e1bca76d76284b3fe02981d574
---
M UserProfile/SpecialEditProfile.php
M UserProfile/SpecialRemoveAvatar.php
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jack Phoenix: Verified; Looks good to me, approved



diff --git a/UserProfile/SpecialEditProfile.php 
b/UserProfile/SpecialEditProfile.php
index 0a8a1c0..f366841 100644
--- a/UserProfile/SpecialEditProfile.php
+++ b/UserProfile/SpecialEditProfile.php
@@ -77,6 +77,7 @@
 
// Still not set? Just give up and show the "search for a user" 
form...
if ( !$userFromRequest ) {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->createUserInputForm() );
return;
}
@@ -84,6 +85,7 @@
$target = User::newFromName( $userFromRequest );
 
if ( !$target || $target->getID() == 0 ) {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->msg( 'nosuchusershort', 
htmlspecialchars( $userFromRequest ) )->escaped() );
$out->addHTML( $this->createUserInputForm() );
return;
@@ -138,6 +140,7 @@
)
) . Xml::label( $this->msg( 'username' )->parse(), 
'mw-socialprofile-user' ) .
Xml::input( 'wpUser', 60, '', array(
+   'class' => 'mw-autocomplete-user',
'tabindex' => '1',
'id' => 'mw-socialprofile-user',
'maxlength' => '200'
diff --git a/UserProfile/SpecialRemoveAvatar.php 
b/UserProfile/SpecialRemoveAvatar.php
index a6c39dd..474f289 100644
--- a/UserProfile/SpecialRemoveAvatar.php
+++ b/UserProfile/SpecialRemoveAvatar.php
@@ -104,6 +104,7 @@
if ( $par ) {
$out->addHTML( $this->showUserAvatar( $par ) );
} else {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->showUserForm() );
}
}
@@ -117,7 +118,7 @@
$output = '' .
Html::hidden( 'title', $this->getPageTitle() ) .
'' . $this->msg( 'username' )->text() . '
-   
+   

';
return $output;

-- 
To view, visit https://gerrit.wikimedia.org/r/280159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e6f408592da89e1bca76d76284b3fe02981d574
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Lewis Cawte 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove commenting - change (wikimedia...civicrm)

2016-03-29 Thread Eileen (Code Review) 
Eileen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280160

Change subject: Remove commenting
..

Remove commenting

This wmf customisation is no longer required

Bug: T127133 T128133

Change-Id: I62d5e3ae9bd30fbd1fde7c492d26bd462d7448cc
---
M CRM/Logging/Schema.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm 
refs/changes/60/280160/1

diff --git a/CRM/Logging/Schema.php b/CRM/Logging/Schema.php
index 5456892..87b9589 100644
--- a/CRM/Logging/Schema.php
+++ b/CRM/Logging/Schema.php
@@ -219,7 +219,7 @@
 else {
   $tableNames = $this->tables;
 }
-/*
+
 foreach ($tableNames as $table) {
   $validName = CRM_Core_DAO::shortenSQLName($table, 48, TRUE);
 
@@ -233,7 +233,7 @@
   $dao->executeTriggerQuery("DROP TRIGGER IF EXISTS 
{$validName}_after_update");
   $dao->executeTriggerQuery("DROP TRIGGER IF EXISTS 
{$validName}_after_delete");
 }
-*/
+
 // now lets also be safe and drop all triggers that start with
 // civicrm_ if we are dropping all triggers
 // we need to do this to capture all the leftover triggers since

-- 
To view, visit https://gerrit.wikimedia.org/r/280160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62d5e3ae9bd30fbd1fde7c492d26bd462d7448cc
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add user name autocompletion support to Special:EditProfile ... - change (mediawiki...SocialProfile)

2016-03-29 Thread Jack Phoenix (Code Review) 
Jack Phoenix has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280159

Change subject: Add user name autocompletion support to Special:EditProfile & 
Special:RemoveAvatar
..

Add user name autocompletion support to Special:EditProfile & 
Special:RemoveAvatar

Change-Id: I9e6f408592da89e1bca76d76284b3fe02981d574
---
M UserProfile/SpecialEditProfile.php
M UserProfile/SpecialRemoveAvatar.php
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile 
refs/changes/59/280159/1

diff --git a/UserProfile/SpecialEditProfile.php 
b/UserProfile/SpecialEditProfile.php
index 0a8a1c0..f366841 100644
--- a/UserProfile/SpecialEditProfile.php
+++ b/UserProfile/SpecialEditProfile.php
@@ -77,6 +77,7 @@
 
// Still not set? Just give up and show the "search for a user" 
form...
if ( !$userFromRequest ) {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->createUserInputForm() );
return;
}
@@ -84,6 +85,7 @@
$target = User::newFromName( $userFromRequest );
 
if ( !$target || $target->getID() == 0 ) {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->msg( 'nosuchusershort', 
htmlspecialchars( $userFromRequest ) )->escaped() );
$out->addHTML( $this->createUserInputForm() );
return;
@@ -138,6 +140,7 @@
)
) . Xml::label( $this->msg( 'username' )->parse(), 
'mw-socialprofile-user' ) .
Xml::input( 'wpUser', 60, '', array(
+   'class' => 'mw-autocomplete-user',
'tabindex' => '1',
'id' => 'mw-socialprofile-user',
'maxlength' => '200'
diff --git a/UserProfile/SpecialRemoveAvatar.php 
b/UserProfile/SpecialRemoveAvatar.php
index a6c39dd..474f289 100644
--- a/UserProfile/SpecialRemoveAvatar.php
+++ b/UserProfile/SpecialRemoveAvatar.php
@@ -104,6 +104,7 @@
if ( $par ) {
$out->addHTML( $this->showUserAvatar( $par ) );
} else {
+   $out->addModules( 'mediawiki.userSuggest' );
$out->addHTML( $this->showUserForm() );
}
}
@@ -117,7 +118,7 @@
$output = '' .
Html::hidden( 'title', $this->getPageTitle() ) .
'' . $this->msg( 'username' )->text() . '
-   
+   

';
return $output;

-- 
To view, visit https://gerrit.wikimedia.org/r/280159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e6f408592da89e1bca76d76284b3fe02981d574
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [WIP] Kafka backend - change (wikimedia...php-queue)

2016-03-29 Thread Awight (Code Review) 
Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280158

Change subject: [WIP] Kafka backend
..

[WIP] Kafka backend

Change-Id: I869a9669ec1ce0550300bc0a4350423e09ce154b
---
M README.md
A src/PHPQueue/Backend/Kafka.php
2 files changed, 71 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/php-queue 
refs/changes/58/280158/1

diff --git a/README.md b/README.md
index 72a73c8..dee6fea 100644
--- a/README.md
+++ b/README.md
@@ -40,9 +40,11 @@
You can also include our core library files into your application and 
do some powerful heavy lifting.

Several backend drivers are bundled:
+* Kafka
 * Memcache
 * Redis
 * MongoDB
+* STOMP
 * CSV
 These can be used as the primary job queue server, or for abstract FIFO or 
key-value data access.
 
diff --git a/src/PHPQueue/Backend/Kafka.php b/src/PHPQueue/Backend/Kafka.php
new file mode 100644
index 000..e9c41ce
--- /dev/null
+++ b/src/PHPQueue/Backend/Kafka.php
@@ -0,0 +1,69 @@
+servers = $options['servers'];
+}
+}
+
+public function connect()
+{
+if (empty($this->servers)) {
+throw new BackendException("No servers specified");
+}
+   // FIXME: inheritance fail.  This backend lazy-connects, see 
the next
+   // two functions.
+   }
+
+   protected function getProducerConnection() {
+   if (!$this->producerConnection) {
+   $this->producerConnection = new \Kafka(
+   $this->servers,
+   array(
+   Kafka::CONFIRM_DELIVERY,
+   // XXX
+   )
+   );
+   }
+   return $this->producerConnection;
+   }
+
+   protected function getConsumerConnection() {
+   if (!$this->consumerConnection) {
+   $this->consumerConnection = new \Kafka(
+   $this->servers,
+   array(
+   // XXX
+   )
+   );
+   }
+   return $this->consumerConnection;
+   }
+
+   // TODO: push, pop
+   public function push($data)
+   {
+   $this->getProducerConnection()->
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/280158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I869a9669ec1ce0550300bc0a4350423e09ce154b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/php-queue
Gerrit-Branch: master
Gerrit-Owner: Awight 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix @param and @return types on all PPFrame::getArgument met... - change (mediawiki/core)

2016-03-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix @param and @return types on all PPFrame::getArgument methods
..


Fix @param and @return types on all PPFrame::getArgument methods

This is about template parameters. They can be indexed by position (int) or
name (string). The returned value is always a string, or false (bool) on
failure.

Change-Id: I565210ad485505281246ef2bb3086a675b905976
---
M includes/parser/Preprocessor.php
M includes/parser/Preprocessor_DOM.php
M includes/parser/Preprocessor_Hash.php
3 files changed, 30 insertions(+), 10 deletions(-)

Approvals:
  Tim Starling: Looks good to me, approved
  Umherirrender: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/parser/Preprocessor.php b/includes/parser/Preprocessor.php
index 368d79e..cc98abd 100644
--- a/includes/parser/Preprocessor.php
+++ b/includes/parser/Preprocessor.php
@@ -260,8 +260,8 @@
 
/**
 * Get an argument to this frame by name
-* @param string $name
-* @return bool
+* @param int|string $name
+* @return string|bool
 */
public function getArgument( $name );
 
diff --git a/includes/parser/Preprocessor_DOM.php 
b/includes/parser/Preprocessor_DOM.php
index 79a66e0..4c94b2a 100644
--- a/includes/parser/Preprocessor_DOM.php
+++ b/includes/parser/Preprocessor_DOM.php
@@ -1462,6 +1462,10 @@
return true;
}
 
+   /**
+* @param int|string $name
+* @return bool Always false in this implementation.
+*/
public function getArgument( $name ) {
return false;
}
@@ -1646,6 +1650,10 @@
return $arguments;
}
 
+   /**
+* @param int $index
+* @return string|bool
+*/
public function getNumberedArgument( $index ) {
if ( !isset( $this->numberedArgs[$index] ) ) {
return false;
@@ -1660,6 +1668,10 @@
return $this->numberedExpansionCache[$index];
}
 
+   /**
+* @param string $name
+* @return string|bool
+*/
public function getNamedArgument( $name ) {
if ( !isset( $this->namedArgs[$name] ) ) {
return false;
@@ -1672,6 +1684,10 @@
return $this->namedExpansionCache[$name];
}
 
+   /**
+* @param int|string $name
+* @return string|bool
+*/
public function getArgument( $name ) {
$text = $this->getNumberedArgument( $name );
if ( $text === false ) {
@@ -1738,6 +1754,10 @@
return !count( $this->args );
}
 
+   /**
+* @param int|string $index
+* @return string|bool
+*/
public function getArgument( $index ) {
if ( !isset( $this->args[$index] ) ) {
return false;
diff --git a/includes/parser/Preprocessor_Hash.php 
b/includes/parser/Preprocessor_Hash.php
index 24baae4..f030cca 100644
--- a/includes/parser/Preprocessor_Hash.php
+++ b/includes/parser/Preprocessor_Hash.php
@@ -1355,8 +1355,8 @@
}
 
/**
-* @param string $name
-* @return bool
+* @param int|string $name
+* @return bool Always false in this implementation.
 */
public function getArgument( $name ) {
return false;
@@ -1549,7 +1549,7 @@
 
/**
 * @param int $index
-* @return array|bool
+* @return string|bool
 */
public function getNumberedArgument( $index ) {
if ( !isset( $this->numberedArgs[$index] ) ) {
@@ -1567,7 +1567,7 @@
 
/**
 * @param string $name
-* @return bool
+* @return string|bool
 */
public function getNamedArgument( $name ) {
if ( !isset( $this->namedArgs[$name] ) ) {
@@ -1582,8 +1582,8 @@
}
 
/**
-* @param string $name
-* @return array|bool
+* @param int|string $name
+* @return string|bool
 */
public function getArgument( $name ) {
$text = $this->getNumberedArgument( $name );
@@ -1652,8 +1652,8 @@
}
 
/**
-* @param int $index
-* @return bool
+* @param int|string $index
+* @return string|bool
 */
public function getArgument( $index ) {
if ( !isset( $this->args[$index] ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/275387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I565210ad485505281246ef2bb3086a675b905976
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Addshore

[MediaWiki-commits] [Gerrit] Translation list: Replace the elipses text with icon - change (mediawiki...ContentTranslation)

2016-03-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Translation list: Replace the elipses text with icon
..


Translation list: Replace the elipses text with icon

Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89
---
M modules/dashboard/ext.cx.translationlist.js
A modules/dashboard/images/elipses.png
A modules/dashboard/images/elipses.svg
M modules/dashboard/styles/ext.cx.translationlist.less
4 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Nikerabbit: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/dashboard/ext.cx.translationlist.js 
b/modules/dashboard/ext.cx.translationlist.js
index 4010ec6..5466aa7 100644
--- a/modules/dashboard/ext.cx.translationlist.js
+++ b/modules/dashboard/ext.cx.translationlist.js
@@ -321,8 +321,7 @@
.text( mw.msg( 'cx-translation-status-' + 
translation.status ) );
 
$actionsTrigger = $( '' )
-   .addClass( 'cx-tlitem__actions__trigger' )
-   .text( '…' );
+   .addClass( 'cx-tlitem__actions__trigger' );
// If the translation is draft, allow deleting it
if ( translation.status === 'draft' ) {
$deleteTranslation = $( '' )
diff --git a/modules/dashboard/images/elipses.png 
b/modules/dashboard/images/elipses.png
new file mode 100644
index 000..21594ea
--- /dev/null
+++ b/modules/dashboard/images/elipses.png
Binary files differ
diff --git a/modules/dashboard/images/elipses.svg 
b/modules/dashboard/images/elipses.svg
new file mode 100644
index 000..98cc53d
--- /dev/null
+++ b/modules/dashboard/images/elipses.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
diff --git a/modules/dashboard/styles/ext.cx.translationlist.less 
b/modules/dashboard/styles/ext.cx.translationlist.less
index 50c2b21..8437d01 100644
--- a/modules/dashboard/styles/ext.cx.translationlist.less
+++ b/modules/dashboard/styles/ext.cx.translationlist.less
@@ -17,11 +17,15 @@
z-index: 100;
 
.cx-tlitem__actions__trigger {
-   font-size: larger;
-   font-weight: 800;
-   color: #565656;
cursor: pointer;
-   padding: 0 5px;
+   padding: 12px;
+   .background-image-svg('../images/elipses.svg', 
'../images/elipses.png');
+   background-repeat: no-repeat;
+   background-position: center left;
+   background-size: 24px;
+   &:hover {
+   background-color: #eee;
+   }
}
 
ul {

-- 
To view, visit https://gerrit.wikimedia.org/r/278842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update comments for dir=auto - change (mediawiki...Translate)

2016-03-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Update comments for dir=auto
..


Update comments for dir=auto

Bug number was incorrect, fixed that too.

Change-Id: I17cb7862466e17b7f65a028fad87111c612e5e2a
---
M resources/js/ext.translate.quickedit.js
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.translate.quickedit.js 
b/resources/js/ext.translate.quickedit.js
index 3d9e8cb..ae3ae90 100644
--- a/resources/js/ext.translate.quickedit.js
+++ b/resources/js/ext.translate.quickedit.js
@@ -208,7 +208,9 @@
} );
$td
.html( convertWhiteSpaceToHTML( text ) )
-   .attr( 'dir', 'auto' ) // (bug T31233) 
hacky, but better than nothing
+   // T41233: hacky, but better than 
nothing.
+   // T130390: must be attr for IE/Edge.
+   .attr( 'dir', 'auto' )
.removeClass( 'untranslated' )
.addClass( 'justtranslated' );
};
@@ -352,7 +354,9 @@
// Update the cell value with the new 
translation
$this
.html( convertWhiteSpaceToHTML( text ) )
-   .attr( 'dir', 'auto' ) // (bug T31233) 
hacky, but better than nothing
+   // T41233: hacky, but better than 
nothing.
+   // T130390: must be attr for IE/Edge.
+   .attr( 'dir', 'auto' )
.removeClass( 'untranslated' )
.addClass( 'justtranslated' );
};

-- 
To view, visit https://gerrit.wikimedia.org/r/279326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17cb7862466e17b7f65a028fad87111c612e5e2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits