[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Fix previous patch, better skinsplash

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371603 )

Change subject: Fix previous patch, better skinsplash
..


Fix previous patch, better skinsplash

...feck arse.

Change-Id: I80d4bd860978d24bb3e69ff04e01f48f890f4827
---
M Splash.skin.php
M skin.json
2 files changed, 15 insertions(+), 5 deletions(-)

Approvals:
  jenkins-bot: Verified
  Isarra: Looks good to me, approved



diff --git a/Splash.skin.php b/Splash.skin.php
index 38b4c0d..88985e9 100644
--- a/Splash.skin.php
+++ b/Splash.skin.php
@@ -9,11 +9,12 @@
$template = 'SplashTemplate', $useHeadElement = true;
 
/**
-* @param $out OutputPage
+* @param OutputPage $out
 */
-   function setupSkinUserCss( OutputPage $out ) {
-   global $wgFontCSSLocation;
-   parent::setupSkinUserCss( $out );
+   public function initPage( OutputPage $out ) {
+   parent::initPage( $out );
+
+   $out->addMeta( 'viewport', 'width=device-width, 
initial-scale=1, maximum-scale=1' );
 
# Add css/js
$out->addModuleStyles( array (
@@ -22,4 +23,13 @@
) );
$out->addModuleScripts( 'skins.splash' );
}
+
+   /**
+* Add CSS via ResourceLoader
+* @param $out OutputPage
+*/
+   function setupSkinUserCss( OutputPage $out ) {
+   global $wgFontCSSLocation;
+   parent::setupSkinUserCss( $out );
+   }
 }
diff --git a/skin.json b/skin.json
index f527a19..c16e7d6 100644
--- a/skin.json
+++ b/skin.json
@@ -18,7 +18,7 @@
},
"AutoloadClasses": {
"SkinSplash": "Splash.skin.php",
-   "SplashTemplate": "Splash.skin.php"
+   "SplashTemplate": "SplashTemplate.php"
},
"ResourceFileModulePaths": {
"localBasePath": "",

-- 
To view, visit https://gerrit.wikimedia.org/r/371603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80d4bd860978d24bb3e69ff04e01f48f890f4827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Splash
Gerrit-Branch: master
Gerrit-Owner: Isarra 
Gerrit-Reviewer: Isarra 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Fix previous patch, better skinsplash

[Isarra (Code Review)]

Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371603 )

Change subject: Fix previous patch, better skinsplash
..

Fix previous patch, better skinsplash

...feck arse.

Change-Id: I80d4bd860978d24bb3e69ff04e01f48f890f4827
---
M Splash.skin.php
M skin.json
2 files changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Splash 
refs/changes/03/371603/1

diff --git a/Splash.skin.php b/Splash.skin.php
index 38b4c0d..88985e9 100644
--- a/Splash.skin.php
+++ b/Splash.skin.php
@@ -9,11 +9,12 @@
$template = 'SplashTemplate', $useHeadElement = true;
 
/**
-* @param $out OutputPage
+* @param OutputPage $out
 */
-   function setupSkinUserCss( OutputPage $out ) {
-   global $wgFontCSSLocation;
-   parent::setupSkinUserCss( $out );
+   public function initPage( OutputPage $out ) {
+   parent::initPage( $out );
+
+   $out->addMeta( 'viewport', 'width=device-width, 
initial-scale=1, maximum-scale=1' );
 
# Add css/js
$out->addModuleStyles( array (
@@ -22,4 +23,13 @@
) );
$out->addModuleScripts( 'skins.splash' );
}
+
+   /**
+* Add CSS via ResourceLoader
+* @param $out OutputPage
+*/
+   function setupSkinUserCss( OutputPage $out ) {
+   global $wgFontCSSLocation;
+   parent::setupSkinUserCss( $out );
+   }
 }
diff --git a/skin.json b/skin.json
index f527a19..c16e7d6 100644
--- a/skin.json
+++ b/skin.json
@@ -18,7 +18,7 @@
},
"AutoloadClasses": {
"SkinSplash": "Splash.skin.php",
-   "SplashTemplate": "Splash.skin.php"
+   "SplashTemplate": "SplashTemplate.php"
},
"ResourceFileModulePaths": {
"localBasePath": "",

-- 
To view, visit https://gerrit.wikimedia.org/r/371603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80d4bd860978d24bb3e69ff04e01f48f890f4827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Splash
Gerrit-Branch: master
Gerrit-Owner: Isarra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Separate out SplashTemplate class into its own file

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371601 )

Change subject: Separate out SplashTemplate class into its own file
..


Separate out SplashTemplate class into its own file

Change-Id: If82739a982fc1c0c047f1b6c52c92067ab83f5f5
---
M Splash.skin.php
A SplashTemplate.php
2 files changed, 402 insertions(+), 416 deletions(-)

Approvals:
  jenkins-bot: Verified
  Isarra: Looks good to me, approved



diff --git a/Splash.skin.php b/Splash.skin.php
index a50ce66..38b4c0d 100644
--- a/Splash.skin.php
+++ b/Splash.skin.php
@@ -1,22 +1,7 @@
 addModuleScripts( 'skins.splash' );
}
 }
-
-/**
- * Main skin class
- * @ingroup Skins
- */
-class SplashTemplate extends BaseTemplate {
-
-   /**
-* Template filter callback for Splash skin.
-* Takes an associative array of data set from a SkinTemplate-based
-* class, and a wrapper for MediaWiki's localization database, and
-* outputs a formatted page.
-*
-* @access private
-*/
-   function execute() {
-   $user = $this->getSkin()->getUser();
-
-   # Suppress warnings to prevent notices about missing indexes in 
$this->data
-   wfSuppressWarnings();
-
-   $this->html( 'headelement' );
-   ?>
-   
-   
-   
-   
-   
-   
-   html( 
'userlangattributes' ); ?>>
-   
-   escaped() ) {
-   $this->renderNavigation( 
'global-links-menu', 'main-links' );
-   }
-   ?>
-   
-   
-   
-   isLoggedIn() ) {
-   ?>
-   
-   getName(); ?>
-   
-   
-   
-   
-   
-   html( 
'userlangattributes' ) ?>>
-   getPersonalTools() as $key => $item ) {
-   echo 
$this->makeListItem( $key, $item );
-   }
-   ?>
-   
-   
-   
-   
-   renderPortals( 
$this->data['sidebar'] ); ?>
-   
-   searchBox(); ?>
-
-   
-   
-   parse(); ?>
-   
-   
-   
-   
-   
-   
-   data['sitenotice'] ) {
-   ?>
-   
-   html( 'sitenotice' )
-   ?>
-   
-   data['newtalk'] ) {
-   if ( $this->data['newtalk'] ) {
-   ?>
-   html( 'newtalk' ) ?>
-   
-   
-   cactions(); ?>
-   html( 'title' ) ?>
-   
-   data['subtitle'] || $this->data['undelete'] 
) {
-   ?>
-   html( 
'userlangattributes' ) ?>>
-   html( 'subtitle' ) ?>
-   
-   data['undelete'] ) {
-   ?>
-   html( 'undelete' ) ?>
-   
-   
-   msg( 'tagline' ) 
?>
-
-   
-   html( 'bodytext' ) ?>
-   
-
-   
-   data['catlinks'] ) { 
$this->html( 'catlinks' ); } ?>
-   data['dataAfterContent'] ) { 
$this->html( 'dataAfterContent' ); } ?>
-   
-   
-   parse(); ?>
-   
-   
-   
-   
-   getFooterIcons( "icononly" );
-   $validFooterLinks = $this->getFooterLink

[MediaWiki-commits] [Gerrit] labs...heritage[wikidata]: Handle sparql http timeout issue

[Lokal Profil (Code Review)]

Lokal Profil has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371602 )

Change subject: Handle sparql http timeout issue
..

Handle sparql http timeout issue

This is done by catching it, waiting, then trying again. On the second try
the sparql endpoint has already generated the result so the reply is fast.

Bug: T172690
Change-Id: I7c9d8a213a595ac9adac335020cd1179c199fdda
---
M erfgoedbot/update_database.py
1 file changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/heritage 
refs/changes/02/371602/1

diff --git a/erfgoedbot/update_database.py b/erfgoedbot/update_database.py
index 7d86e93..c459085 100755
--- a/erfgoedbot/update_database.py
+++ b/erfgoedbot/update_database.py
@@ -15,6 +15,9 @@
 import warnings
 import datetime
 import urlparse
+import time
+
+from requests.exceptions import Timeout
 
 import pywikibot
 import pywikibot.data.sparql
@@ -482,7 +485,13 @@
 )
 # print sparql_query
 sq = pywikibot.data.sparql.SparqlQuery()
-query_result = sq.select(sparql_query, full_data=True)
+try:
+query_result = sq.select(sparql_query, full_data=True)
+except Timeout:
+pywikibot.output('Sparql endpoint being slow, giving it a moment...')
+time.sleep(10)
+query_result = sq.select(sparql_query, full_data=True)
+
 for resultitem in query_result:
 process_monument_wikidata(resultitem, countryconfig, conn, cursor)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c9d8a213a595ac9adac335020cd1179c199fdda
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/heritage
Gerrit-Branch: wikidata
Gerrit-Owner: Lokal Profil 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Separate out SplashTemplate class into its own file

[Isarra (Code Review)]

Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371601 )

Change subject: Separate out SplashTemplate class into its own file
..

Separate out SplashTemplate class into its own file

Change-Id: If82739a982fc1c0c047f1b6c52c92067ab83f5f5
---
M Splash.skin.php
A SplashTemplate.php
2 files changed, 402 insertions(+), 416 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Splash 
refs/changes/01/371601/1

diff --git a/Splash.skin.php b/Splash.skin.php
index a50ce66..38b4c0d 100644
--- a/Splash.skin.php
+++ b/Splash.skin.php
@@ -1,22 +1,7 @@
 addModuleScripts( 'skins.splash' );
}
 }
-
-/**
- * Main skin class
- * @ingroup Skins
- */
-class SplashTemplate extends BaseTemplate {
-
-   /**
-* Template filter callback for Splash skin.
-* Takes an associative array of data set from a SkinTemplate-based
-* class, and a wrapper for MediaWiki's localization database, and
-* outputs a formatted page.
-*
-* @access private
-*/
-   function execute() {
-   $user = $this->getSkin()->getUser();
-
-   # Suppress warnings to prevent notices about missing indexes in 
$this->data
-   wfSuppressWarnings();
-
-   $this->html( 'headelement' );
-   ?>
-   
-   
-   
-   
-   
-   
-   html( 
'userlangattributes' ); ?>>
-   
-   escaped() ) {
-   $this->renderNavigation( 
'global-links-menu', 'main-links' );
-   }
-   ?>
-   
-   
-   
-   isLoggedIn() ) {
-   ?>
-   
-   getName(); ?>
-   
-   
-   
-   
-   
-   html( 
'userlangattributes' ) ?>>
-   getPersonalTools() as $key => $item ) {
-   echo 
$this->makeListItem( $key, $item );
-   }
-   ?>
-   
-   
-   
-   
-   renderPortals( 
$this->data['sidebar'] ); ?>
-   
-   searchBox(); ?>
-
-   
-   
-   parse(); ?>
-   
-   
-   
-   
-   
-   
-   data['sitenotice'] ) {
-   ?>
-   
-   html( 'sitenotice' )
-   ?>
-   
-   data['newtalk'] ) {
-   if ( $this->data['newtalk'] ) {
-   ?>
-   html( 'newtalk' ) ?>
-   
-   
-   cactions(); ?>
-   html( 'title' ) ?>
-   
-   data['subtitle'] || $this->data['undelete'] 
) {
-   ?>
-   html( 
'userlangattributes' ) ?>>
-   html( 'subtitle' ) ?>
-   
-   data['undelete'] ) {
-   ?>
-   html( 'undelete' ) ?>
-   
-   
-   msg( 'tagline' ) 
?>
-
-   
-   html( 'bodytext' ) ?>
-   
-
-   
-   data['catlinks'] ) { 
$this->html( 'catlinks' ); } ?>
-   data['dataAfterContent'] ) { 
$this->html( 'dataAfterContent' ); } ?>
-   
-   
-   parse(); ?>
-   
-   
-   
-   
-   getFooterIcons( "icononly" );
-   $validFooterLinks = $this->getFoo

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WikimediaUI theme: Remove unnecessary selector in CheckboxIn...

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371600 )

Change subject: WikimediaUI theme: Remove unnecessary selector in 
CheckboxInputWidget
..

WikimediaUI theme: Remove unnecessary selector in CheckboxInputWidget

Removing unnecessary `&disabled:hover + span` selector in
CheckboxInputWidget, which was introduced in I96daa17d5451.

Change-Id: Iee293016bc75e4fab63cfa25ebcffd0d7007f7c1
---
M src/themes/wikimediaui/widgets.less
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/00/371600/1

diff --git a/src/themes/wikimediaui/widgets.less 
b/src/themes/wikimediaui/widgets.less
index 64160af..1e7daa3 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -380,10 +380,6 @@
background-color: 
@background-color-filled--disabled;
border-color: @border-color-base--disabled;
}
-   &:hover + span {
-   background-color: 
@background-color-filled--disabled;
-   border-color: @border-color-base--disabled;
-   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee293016bc75e4fab63cfa25ebcffd0d7007f7c1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Add configuration for `##goat`

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371599 )

Change subject: Add configuration for `##goat`
..


Add configuration for `##goat`

Change-Id: I4657a7186711d0b55d3677f039c6b07e9f41e976
---
M channels.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/channels.yaml b/channels.yaml
index 6f8914b..078f35a 100644
--- a/channels.yaml
+++ b/channels.yaml
@@ -287,6 +287,8 @@
 - VPS-project-icinga2
 "#wikimedia-ops":
 - wikimedia-irc-freenode
+"##goat":
+- Goatification
 
 firehose-channel: '#mediawiki-feed'
 default-channel: '#wikimedia-dev'

-- 
To view, visit https://gerrit.wikimedia.org/r/371599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4657a7186711d0b55d3677f039c6b07e9f41e976
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/wikibugs2
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Add configuration for `##goat`

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371599 )

Change subject: Add configuration for `##goat`
..

Add configuration for `##goat`

Change-Id: I4657a7186711d0b55d3677f039c6b07e9f41e976
---
M channels.yaml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/wikibugs2 
refs/changes/99/371599/1

diff --git a/channels.yaml b/channels.yaml
index 6f8914b..078f35a 100644
--- a/channels.yaml
+++ b/channels.yaml
@@ -287,6 +287,8 @@
 - VPS-project-icinga2
 "#wikimedia-ops":
 - wikimedia-irc-freenode
+"##goat":
+- Goatification
 
 firehose-channel: '#mediawiki-feed'
 default-channel: '#wikimedia-dev'

-- 
To view, visit https://gerrit.wikimedia.org/r/371599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4657a7186711d0b55d3677f039c6b07e9f41e976
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/wikibugs2
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...HitCounters[master]: Remove superfuluos check

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371598 )

Change subject: Remove superfuluos check
..

Remove superfuluos check

PHP already checks it for us.

Change-Id: I31e2c46f719af0861f8fe67d2689c0ee34039045
---
M includes/HitCounters.body.php
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HitCounters 
refs/changes/98/371598/1

diff --git a/includes/HitCounters.body.php b/includes/HitCounters.body.php
index f607f87..2f5bd62 100644
--- a/includes/HitCounters.body.php
+++ b/includes/HitCounters.body.php
@@ -25,9 +25,6 @@
 * @return int The view count for the page
 */
public static function getCount( Title $title ) {
-   if ( $title === null ) {
-   throw new MWException( "Asked for count without a 
title!" );
-   }
if ( $title->isSpecialPage() ) {
return null;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31e2c46f719af0861f8fe67d2689c0ee34039045
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/HitCounters
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: $wgDisableCounters is deprecated and is always true

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371597 )

Change subject: $wgDisableCounters is deprecated and is always true
..

$wgDisableCounters is deprecated and is always true

Change-Id: Ife8eb30803b6456b875223d5835368bc3b231aeb
---
M includes/AbuseFilter.class.php
1 file changed, 5 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/97/371597/1

diff --git a/includes/AbuseFilter.class.php b/includes/AbuseFilter.class.php
index a9b5f0e..fdc9b19 100644
--- a/includes/AbuseFilter.class.php
+++ b/includes/AbuseFilter.class.php
@@ -267,10 +267,7 @@
}
 
$realValues = self::$builderValues;
-   global $wgDisableCounters;
-   if ( !$wgDisableCounters ) {
-   $realValues['vars']['article_views'] = 'article-views';
-   }
+
Hooks::run( 'AbuseFilter-builder', [ &$realValues ] );
 
return $realValues;
@@ -341,13 +338,10 @@
$vars->setVar( $prefix . '_TEXT', $title->getText() );
$vars->setVar( $prefix . '_PREFIXEDTEXT', 
$title->getPrefixedText() );
 
-   global $wgDisableCounters;
-   if ( !$wgDisableCounters && !$title->isSpecialPage() ) {
-   // Support: HitCounters extension
-   // XXX: This should be part of the extension (T159069)
-   if ( method_exists( 'HitCounters\HitCounters', 
'getCount' ) ) {
-   $vars->setVar( $prefix . '_VIEWS', 
HitCounters\HitCounters::getCount( $title ) );
-   }
+   // Support: HitCounters extension
+   // XXX: This should be part of the extension (T159069)
+   if ( !$title->isSpecialPage() && method_exists( 
'HitCounters\HitCounters', 'getCount' ) ) {
+   $vars->setVar( $prefix . '_VIEWS', 
HitCounters\HitCounters::getCount( $title ) );
}
 
// Use restrictions.

-- 
To view, visit https://gerrit.wikimedia.org/r/371597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife8eb30803b6456b875223d5835368bc3b231aeb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Remove retrieval of deprecated pageviews statistics

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371596 )

Change subject: Remove retrieval of deprecated pageviews statistics
..

Remove retrieval of deprecated pageviews statistics

Both $wgDisableCounters and SiteStats::views() do nothing
these days. Always return zero.

Change-Id: Ia2375fb3db31d1faade5f271e4725de64b10b55b
---
M engines/LuaCommon/SiteLibrary.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/96/371596/1

diff --git a/engines/LuaCommon/SiteLibrary.php 
b/engines/LuaCommon/SiteLibrary.php
index 68e8bae..4e6e7c5 100644
--- a/engines/LuaCommon/SiteLibrary.php
+++ b/engines/LuaCommon/SiteLibrary.php
@@ -8,7 +8,7 @@
private $pagesInCategoryCache = [];
 
function register() {
-   global $wgContLang, $wgNamespaceAliases, $wgDisableCounters;
+   global $wgContLang, $wgNamespaceAliases;
 
$lib = [
'getNsIndex' => [ $this, 'getNsIndex' ],
@@ -82,7 +82,8 @@
'articles' => (int)SiteStats::articles(),
'files' => (int)SiteStats::images(),
'edits' => (int)SiteStats::edits(),
-   'views' => $wgDisableCounters ? null : 
(int)SiteStats::views(),
+   // @deprecated since 1.30, always zero. To be removed 
completely later.
+   'views' => 0,
'users' => (int)SiteStats::users(),
'activeUsers' => (int)SiteStats::activeUsers(),
'admins' => (int)SiteStats::numberingroup( 'sysop' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/371596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2375fb3db31d1faade5f271e4725de64b10b55b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove MagicWord::replaceMultiple()

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371595 )

Change subject: Remove MagicWord::replaceMultiple()
..

Remove MagicWord::replaceMultiple()

wfDeprecated since 1.25, not used anywhere.

Change-Id: I09fd362a3d795328ffc12572025702ef9b951378
---
M RELEASE-NOTES-1.30
M includes/MagicWord.php
2 files changed, 1 insertion(+), 27 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/371595/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 452cb35..3045c4d 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -158,6 +158,7 @@
   nothing and is deprecated.
 * mw.util.escapeId() was deprecated, use escapeIdForAttribute() or
   escapeIdForLink().
+* MagicWord::replaceMultiple() was removed.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/MagicWord.php b/includes/MagicWord.php
index e70b8ce..6e7799a 100644
--- a/includes/MagicWord.php
+++ b/includes/MagicWord.php
@@ -647,33 +647,6 @@
}
 
/**
-* $magicarr is an associative array of (magic word ID => replacement)
-* This method uses the php feature to do several replacements at the 
same time,
-* thereby gaining some efficiency. The result is placed in the out 
variable
-* $result. The return value is true if something was replaced.
-* @deprecated since 1.25, unused
-*
-* @param array $magicarr
-* @param string $subject
-* @param string &$result
-*
-* @return bool
-*/
-   public function replaceMultiple( $magicarr, $subject, &$result ) {
-   wfDeprecated( __METHOD__, '1.25' );
-   $search = [];
-   $replace = [];
-   foreach ( $magicarr as $id => $replacement ) {
-   $mw = self::get( $id );
-   $search[] = $mw->getRegex();
-   $replace[] = $replacement;
-   }
-
-   $result = preg_replace( $search, $replace, $subject );
-   return $result !== $subject;
-   }
-
-   /**
 * Adds all the synonyms of this MagicWord to an array, to allow quick
 * lookup in a list of magic words
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/371595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09fd362a3d795328ffc12572025702ef9b951378
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: Remove deprecated wfProfileIn()/wfProfileOut()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371591 )

Change subject: Remove deprecated wfProfileIn()/wfProfileOut()
..


Remove deprecated wfProfileIn()/wfProfileOut()

Change-Id: Ibf6ddfa305565adcd751d7cc141d36cabf551b1d
---
M PdfHandler.image.php
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PdfHandler.image.php b/PdfHandler.image.php
index 57abcf8..8346b31 100644
--- a/PdfHandler.image.php
+++ b/PdfHandler.image.php
@@ -113,7 +113,6 @@
global $wgPdfInfo, $wgPdftoText;
 
if ( $wgPdfInfo ) {
-   wfProfileIn( 'pdfinfo' );
$cmd = wfEscapeShellArg( $wgPdfInfo ) .
" -enc UTF-8 " . # Report metadata as UTF-8 
text...
" -l 999 " . # Report page sizes for all 
pages
@@ -122,19 +121,16 @@
$retval = '';
$dump = wfShellExec( $cmd, $retval );
$data = $this->convertDumpToArray( $dump );
-   wfProfileOut( 'pdfinfo' );
} else {
$data = null;
}
 
// Read text layer
if ( isset( $wgPdftoText ) ) {
-   wfProfileIn( 'pdftotext' );
$cmd = wfEscapeShellArg( $wgPdftoText ) . ' '. 
wfEscapeShellArg( $this->mFilename ) . ' - ';
wfDebug( __METHOD__.": $cmd\n" );
$retval = '';
$txt = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'pdftotext' );
if ( $retval == 0 ) {
$txt = str_replace( "\r\n", "\n", $txt );
$pages = explode( "\f", $txt );

-- 
To view, visit https://gerrit.wikimedia.org/r/371591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf6ddfa305565adcd751d7cc141d36cabf551b1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PdfHandler
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PhpTags[master]: Remove deprecated wfProfileIn()/wfProfileOut()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371592 )

Change subject: Remove deprecated wfProfileIn()/wfProfileOut()
..


Remove deprecated wfProfileIn()/wfProfileOut()

Change-Id: I373fc491a7ecaac22bc87403264d0b319261ede1
---
M includes/Renderer.php
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Renderer.php b/includes/Renderer.php
index 371ac19..8ff8e20 100644
--- a/includes/Renderer.php
+++ b/includes/Renderer.php
@@ -48,7 +48,6 @@
 * @param array $args
 */
public static function runParserFunction( $parser, $frame, $args ) {
-   wfProfileIn( __METHOD__ );
Timer::start( $parser );
 
$command = array_shift($args);
@@ -81,12 +80,10 @@
 
Timer::stop( $parser );
 
-   wfProfileOut( __METHOD__ );
return Validator::cleanUp( $return );
}
 
public static function runTagHook( $input, array $args, \Parser 
$parser, \PPFrame $frame ) {
-   wfProfileIn( __METHOD__ );
Timer::start( $parser );
 
$frameTitle = $frame->getTitle();
@@ -109,7 +106,6 @@
 
Timer::stop( $parser );
$return = self::insertGeneral( $parser, 
$parser->recursiveTagParse( implode($result), $frame ) );
-   wfProfileOut( __METHOD__ );
return $return;
}
 
@@ -268,7 +264,6 @@
 
public static function onParserAfterTidy( $parser, &$text ) {
global $wgPhpTagsBytecodeExptime;
-   wfProfileIn( __METHOD__ );
 
if ( self::$globalVariablesScript ) {
$vars = array();
@@ -286,7 +281,6 @@
}
self::reset();
 
-   wfProfileOut( __METHOD__ );
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I373fc491a7ecaac22bc87403264d0b319261ede1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PhpTags
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PagedTiffHandler[master]: Remove deprecated function usage

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371590 )

Change subject: Remove deprecated function usage
..


Remove deprecated function usage

* Delete wfProfileIn()/wfProfleOut()
* Replace wfSuppressWarnings()/wfRestoreWarnings() with alternatives

Change-Id: Iab716ec99643c63f0ce045d1883e8bb33fb30593
---
M PagedTiffHandler.image.php
M PagedTiffHandler_body.php
2 files changed, 2 insertions(+), 16 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PagedTiffHandler.image.php b/PagedTiffHandler.image.php
index 937aa25..c645dc3 100644
--- a/PagedTiffHandler.image.php
+++ b/PagedTiffHandler.image.php
@@ -91,8 +91,6 @@
global $wgShowEXIF;
 
if ( $this->metadata === null ) {
-   wfProfileIn( 'PagedTiffImage::retrieveMetaData' );
-
// fetch base info: number of pages, size and alpha for 
each page.
// run hooks first, then optionally tiffinfo or, per 
default,
// ImageMagic's identify command
@@ -108,11 +106,9 @@
$cmd = wfEscapeShellArg( $wgTiffTiffinfoCommand 
) .
' ' . wfEscapeShellArg( 
$this->mFilename ) . ' 2>&1';
 
-   wfProfileIn( 'tiffinfo' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'tiffinfo' );
 
if ( $retval ) {
$data['errors'][] = "tiffinfo command 
failed: $cmd";
@@ -127,11 +123,9 @@

'"[BEGIN]page=%p\nalpha=%A\nalpha2=%r\nheight=%h\nwidth=%w\ndepth=%z[END]" ' .
wfEscapeShellArg( $this->mFilename ) . 
' 2>&1';
 
-   wfProfileIn( 'identify' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'identify' );
 
if ( $retval ) {
$data['errors'][] = "identify command 
failed: $cmd";
@@ -164,11 +158,9 @@
$cmd = wfEscapeShellArg( $wgExiv2Command ) .
' -u -psix -Pnt ' . wfEscapeShellArg( 
$this->mFilename ) . ' 2>&1';
 
-   wfProfileIn( 'exiv2' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'exiv2' );
 
if ( $retval ) {
$data['errors'][] = "exiv command 
failed: $cmd";
@@ -202,8 +194,6 @@
unset( $this->metadata['exif']['ImageResources'] );
 
$this->metadata['TIFF_METADATA_VERSION'] = 
PagedTiffHandler::TIFF_METADATA_VERSION;
-
-   wfProfileOut( 'PagedTiffImage::retrieveMetaData' );
}
 
return $this->metadata;
diff --git a/PagedTiffHandler_body.php b/PagedTiffHandler_body.php
index 8c4f620..7dc6ef2 100644
--- a/PagedTiffHandler_body.php
+++ b/PagedTiffHandler_body.php
@@ -406,9 +406,7 @@
 
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = null;
-   wfProfileIn( 'PagedTiffHandler' );
$err = wfShellExecWithStderr( $cmd, $retval );
-   wfProfileOut( 'PagedTiffHandler' );
 
if ( $retval !== 0 ) {
wfDebugLog( 'thumbnail', "thumbnail failed on " . 
wfHostname() .
@@ -716,11 +714,9 @@
return false;
}
 
-   wfProfileIn( __METHOD__ );
-   wfSuppressWarnings();
+   MediaWiki\suppressWarnings();
$image->tiffMetaArray = unserialize( $metadata );
-   wfRestoreWarnings();
-   wfProfileOut( __METHOD__ );
+   MediaWiki\restoreWarnings();
 
return $image->tiffMetaArray;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab716ec99643c63f0ce045d1883e8bb33fb30593
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagedTiffHandler
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
Medi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Hard-deprecate SprofileSection

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371594 )

Change subject: Hard-deprecate SprofileSection
..

Hard-deprecate SprofileSection

No usages anywhere, to be removed in 1.31

Change-Id: I3ed4c2aa07d97e18c026e9ee6dae66d3b023896f
---
M includes/profiler/ProfileSection.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/94/371594/1

diff --git a/includes/profiler/ProfileSection.php 
b/includes/profiler/ProfileSection.php
index 32daeed..56c152c 100644
--- a/includes/profiler/ProfileSection.php
+++ b/includes/profiler/ProfileSection.php
@@ -40,5 +40,6 @@
 * @param string $name Name of the function to profile
 */
public function __construct( $name ) {
+   wfDeprecated( 'class ProfileSection', '1.30' );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ed4c2aa07d97e18c026e9ee6dae66d3b023896f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Use transparent for invisible borders of page navigation rat...

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371593 )

Change subject: Use transparent for invisible borders of page navigation rather 
than white
..

Use transparent for invisible borders of page navigation rather than white

This makes the effect better when you override page background color,
like we do on mediawiki.org e.g. on manual pages like
.

Change-Id: Ie863d11b19a56ab6cf75ff4b8dfcd2d74b69ce1d
---
M resources/screen-common.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/93/371593/1

diff --git a/resources/screen-common.less b/resources/screen-common.less
index 4dc60a7..09bb7ce 100644
--- a/resources/screen-common.less
+++ b/resources/screen-common.less
@@ -212,7 +212,7 @@
}
li {
margin: 0.25em 0 1em;
-   border-bottom: solid 3px @background;
+   border-bottom: solid 3px transparent;
 
&:hover {
border-bottom-color: @grey;

-- 
To view, visit https://gerrit.wikimedia.org/r/371593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie863d11b19a56ab6cf75ff4b8dfcd2d74b69ce1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PhpTags[master]: Remove deprecated wfProfileIn()/wfProfileOut()

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371592 )

Change subject: Remove deprecated wfProfileIn()/wfProfileOut()
..

Remove deprecated wfProfileIn()/wfProfileOut()

Change-Id: I373fc491a7ecaac22bc87403264d0b319261ede1
---
M includes/Renderer.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PhpTags 
refs/changes/92/371592/1

diff --git a/includes/Renderer.php b/includes/Renderer.php
index 371ac19..8ff8e20 100644
--- a/includes/Renderer.php
+++ b/includes/Renderer.php
@@ -48,7 +48,6 @@
 * @param array $args
 */
public static function runParserFunction( $parser, $frame, $args ) {
-   wfProfileIn( __METHOD__ );
Timer::start( $parser );
 
$command = array_shift($args);
@@ -81,12 +80,10 @@
 
Timer::stop( $parser );
 
-   wfProfileOut( __METHOD__ );
return Validator::cleanUp( $return );
}
 
public static function runTagHook( $input, array $args, \Parser 
$parser, \PPFrame $frame ) {
-   wfProfileIn( __METHOD__ );
Timer::start( $parser );
 
$frameTitle = $frame->getTitle();
@@ -109,7 +106,6 @@
 
Timer::stop( $parser );
$return = self::insertGeneral( $parser, 
$parser->recursiveTagParse( implode($result), $frame ) );
-   wfProfileOut( __METHOD__ );
return $return;
}
 
@@ -268,7 +264,6 @@
 
public static function onParserAfterTidy( $parser, &$text ) {
global $wgPhpTagsBytecodeExptime;
-   wfProfileIn( __METHOD__ );
 
if ( self::$globalVariablesScript ) {
$vars = array();
@@ -286,7 +281,6 @@
}
self::reset();
 
-   wfProfileOut( __METHOD__ );
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I373fc491a7ecaac22bc87403264d0b319261ede1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PhpTags
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: Remove deprecated wfProfileIn()/wfProfileOut()

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371591 )

Change subject: Remove deprecated wfProfileIn()/wfProfileOut()
..

Remove deprecated wfProfileIn()/wfProfileOut()

Change-Id: Ibf6ddfa305565adcd751d7cc141d36cabf551b1d
---
M PdfHandler.image.php
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PdfHandler 
refs/changes/91/371591/1

diff --git a/PdfHandler.image.php b/PdfHandler.image.php
index 57abcf8..8346b31 100644
--- a/PdfHandler.image.php
+++ b/PdfHandler.image.php
@@ -113,7 +113,6 @@
global $wgPdfInfo, $wgPdftoText;
 
if ( $wgPdfInfo ) {
-   wfProfileIn( 'pdfinfo' );
$cmd = wfEscapeShellArg( $wgPdfInfo ) .
" -enc UTF-8 " . # Report metadata as UTF-8 
text...
" -l 999 " . # Report page sizes for all 
pages
@@ -122,19 +121,16 @@
$retval = '';
$dump = wfShellExec( $cmd, $retval );
$data = $this->convertDumpToArray( $dump );
-   wfProfileOut( 'pdfinfo' );
} else {
$data = null;
}
 
// Read text layer
if ( isset( $wgPdftoText ) ) {
-   wfProfileIn( 'pdftotext' );
$cmd = wfEscapeShellArg( $wgPdftoText ) . ' '. 
wfEscapeShellArg( $this->mFilename ) . ' - ';
wfDebug( __METHOD__.": $cmd\n" );
$retval = '';
$txt = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'pdftotext' );
if ( $retval == 0 ) {
$txt = str_replace( "\r\n", "\n", $txt );
$pages = explode( "\f", $txt );

-- 
To view, visit https://gerrit.wikimedia.org/r/371591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf6ddfa305565adcd751d7cc141d36cabf551b1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PdfHandler
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PagedTiffHandler[master]: Remove deprecated function usage

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371590 )

Change subject: Remove deprecated function usage
..

Remove deprecated function usage

* Delete wfProfileIn()/wfProfleOut()
* Replace wfSuppressWarnings()/wfRestoreWarnings() with alternatives

Change-Id: Iab716ec99643c63f0ce045d1883e8bb33fb30593
---
M PagedTiffHandler.image.php
M PagedTiffHandler_body.php
2 files changed, 2 insertions(+), 16 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PagedTiffHandler 
refs/changes/90/371590/1

diff --git a/PagedTiffHandler.image.php b/PagedTiffHandler.image.php
index 937aa25..c645dc3 100644
--- a/PagedTiffHandler.image.php
+++ b/PagedTiffHandler.image.php
@@ -91,8 +91,6 @@
global $wgShowEXIF;
 
if ( $this->metadata === null ) {
-   wfProfileIn( 'PagedTiffImage::retrieveMetaData' );
-
// fetch base info: number of pages, size and alpha for 
each page.
// run hooks first, then optionally tiffinfo or, per 
default,
// ImageMagic's identify command
@@ -108,11 +106,9 @@
$cmd = wfEscapeShellArg( $wgTiffTiffinfoCommand 
) .
' ' . wfEscapeShellArg( 
$this->mFilename ) . ' 2>&1';
 
-   wfProfileIn( 'tiffinfo' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'tiffinfo' );
 
if ( $retval ) {
$data['errors'][] = "tiffinfo command 
failed: $cmd";
@@ -127,11 +123,9 @@

'"[BEGIN]page=%p\nalpha=%A\nalpha2=%r\nheight=%h\nwidth=%w\ndepth=%z[END]" ' .
wfEscapeShellArg( $this->mFilename ) . 
' 2>&1';
 
-   wfProfileIn( 'identify' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'identify' );
 
if ( $retval ) {
$data['errors'][] = "identify command 
failed: $cmd";
@@ -164,11 +158,9 @@
$cmd = wfEscapeShellArg( $wgExiv2Command ) .
' -u -psix -Pnt ' . wfEscapeShellArg( 
$this->mFilename ) . ' 2>&1';
 
-   wfProfileIn( 'exiv2' );
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = '';
$dump = wfShellExec( $cmd, $retval );
-   wfProfileOut( 'exiv2' );
 
if ( $retval ) {
$data['errors'][] = "exiv command 
failed: $cmd";
@@ -202,8 +194,6 @@
unset( $this->metadata['exif']['ImageResources'] );
 
$this->metadata['TIFF_METADATA_VERSION'] = 
PagedTiffHandler::TIFF_METADATA_VERSION;
-
-   wfProfileOut( 'PagedTiffImage::retrieveMetaData' );
}
 
return $this->metadata;
diff --git a/PagedTiffHandler_body.php b/PagedTiffHandler_body.php
index 8c4f620..7dc6ef2 100644
--- a/PagedTiffHandler_body.php
+++ b/PagedTiffHandler_body.php
@@ -406,9 +406,7 @@
 
wfDebug( __METHOD__ . ": $cmd\n" );
$retval = null;
-   wfProfileIn( 'PagedTiffHandler' );
$err = wfShellExecWithStderr( $cmd, $retval );
-   wfProfileOut( 'PagedTiffHandler' );
 
if ( $retval !== 0 ) {
wfDebugLog( 'thumbnail', "thumbnail failed on " . 
wfHostname() .
@@ -716,11 +714,9 @@
return false;
}
 
-   wfProfileIn( __METHOD__ );
-   wfSuppressWarnings();
+   MediaWiki\suppressWarnings();
$image->tiffMetaArray = unserialize( $metadata );
-   wfRestoreWarnings();
-   wfProfileOut( __METHOD__ );
+   MediaWiki\restoreWarnings();
 
return $image->tiffMetaArray;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab716ec99643c63f0ce045d1883e8bb33fb30593
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagedTiffHandler
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove quite a lot of unused code from PropertyValueSnakForm...

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371589 )

Change subject: Remove quite a lot of unused code from 
PropertyValueSnakFormatter
..

Remove quite a lot of unused code from PropertyValueSnakFormatter

Change-Id: I5f31c7fbba031f37edd23b6e55ee7f7236870f26
---
M lib/includes/Formatters/OutputFormatSnakFormatterFactory.php
M lib/includes/Formatters/PropertyValueSnakFormatter.php
M lib/includes/Formatters/WikibaseSnakFormatterBuilders.php
M lib/tests/phpunit/Formatters/PropertyValueSnakFormatterTest.php
4 files changed, 15 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/89/371589/1

diff --git a/lib/includes/Formatters/OutputFormatSnakFormatterFactory.php 
b/lib/includes/Formatters/OutputFormatSnakFormatterFactory.php
index afb0304..0e0c3e9 100644
--- a/lib/includes/Formatters/OutputFormatSnakFormatterFactory.php
+++ b/lib/includes/Formatters/OutputFormatSnakFormatterFactory.php
@@ -100,7 +100,6 @@
$valueFormatter = 
$this->valueFormatterFactory->getValueFormatter( $format, $options );
$valueSnakFormatter = new PropertyValueSnakFormatter(
$format,
-   $options,
$valueFormatter,
$this->propertyDataTypeLookup,
$this->dataTypeFactory
diff --git a/lib/includes/Formatters/PropertyValueSnakFormatter.php 
b/lib/includes/Formatters/PropertyValueSnakFormatter.php
index 473762a..231ef61 100644
--- a/lib/includes/Formatters/PropertyValueSnakFormatter.php
+++ b/lib/includes/Formatters/PropertyValueSnakFormatter.php
@@ -6,10 +6,8 @@
 use DataValues\DataValue;
 use DataValues\UnDeserializableValue;
 use InvalidArgumentException;
-use Message;
 use OutOfBoundsException;
 use ValueFormatters\Exceptions\MismatchingDataValueTypeException;
-use ValueFormatters\FormatterOptions;
 use ValueFormatters\FormattingException;
 use ValueFormatters\ValueFormatter;
 use Wikibase\DataModel\Services\Lookup\PropertyDataTypeLookup;
@@ -33,11 +31,6 @@
private $format;
 
/**
-* @var FormatterOptions
-*/
-   private $options;
-
-   /**
 * @var ValueFormatter
 */
private $valueFormatter;
@@ -55,7 +48,6 @@
/**
 * @param string $format The name of this formatter's output format.
 *Use the FORMAT_XXX constants defined in SnakFormatter.
-* @param FormatterOptions|null $options
 * @param ValueFormatter $valueFormatter
 * @param PropertyDataTypeLookup $typeLookup
 * @param DataTypeFactory $dataTypeFactory
@@ -64,7 +56,6 @@
 */
public function __construct(
$format,
-   FormatterOptions $options = null,
ValueFormatter $valueFormatter,
PropertyDataTypeLookup $typeLookup,
DataTypeFactory $dataTypeFactory
@@ -74,7 +65,6 @@
}
 
$this->format = $format;
-   $this->options = $options ?: new FormatterOptions();
$this->valueFormatter = $valueFormatter;
$this->typeLookup = $typeLookup;
$this->dataTypeFactory = $dataTypeFactory;
@@ -100,7 +90,6 @@
throw new InvalidArgumentException( "Not a 
PropertyValueSnak: " . get_class( $snak ) );
}
 
-   $propertyType = null;
$value = $snak->getDataValue();
 
try {
@@ -112,46 +101,17 @@
throw new FormattingException( $ex->getMessage(), 0, 
$ex );
}
 
-   $this->checkValueType( $value, $expectedDataValueType );
-
-   return $this->formatValue( $value, $propertyType );
-   }
-
-   /**
-* @param DataValue $value
-*
-* @return boolean
-*/
-   private function isUnDeserializableValue( DataValue $value ) {
-   return $value->getType() === UnDeserializableValue::getType();
-   }
-
-   /**
-* @param DataValue $value
-* @param string $expectedDataValueType
-*
-* @throws PropertyDataTypeLookupException
-* @throws MismatchingDataValueTypeException
-* @return Message|null
-*/
-   private function checkValueType( DataValue $value, 
$expectedDataValueType ) {
-   $warning = null;
-
-   if ( $this->isUnDeserializableValue( $value ) ) {
+   if ( $expectedDataValueType !== $value->getType() ) {
throw new MismatchingDataValueTypeException(
$expectedDataValueType,
$value->getType(),
-   'Encountered undeserializable value'
-   );
-   } elseif ( $expected

[MediaWiki-commits] [Gerrit] mediawiki...Cite[master]: VisualDiff: Show less information about ref nodes

[Tchanders (Code Review)]

Tchanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371588 )

Change subject: VisualDiff: Show less information about ref nodes
..

VisualDiff: Show less information about ref nodes

If a ref node's index changes (e.g. because an earlier
reference was inserted/removed), only describe the index
change.

(Currently the edit diffs in the save dialog don't show
any change if only the index has changed. Perhaps ideally
that is what would happen here eventually.)

Bug: T170235
Change-Id: I2513bb82099a92529516e4e217e61a2d0a2dd43b
---
M modules/ve-cite/ve.dm.MWReferenceNode.js
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/88/371588/1

diff --git a/modules/ve-cite/ve.dm.MWReferenceNode.js 
b/modules/ve-cite/ve.dm.MWReferenceNode.js
index de55223..1fae5b8 100644
--- a/modules/ve-cite/ve.dm.MWReferenceNode.js
+++ b/modules/ve-cite/ve.dm.MWReferenceNode.js
@@ -323,7 +323,11 @@
return clone;
 };
 
+/**
+ * @inheritdoc
+ */
 ve.dm.MWReferenceNode.static.describeChange = function ( key, change ) {
+   // Only display messages for refGroup and listIndex changes
if ( key === 'refGroup' ) {
if ( change.from ) {
if ( change.to ) {
@@ -334,11 +338,9 @@
}
return ve.msg( 'cite-ve-changedesc-reflist-group-to', change.to 
);
}
-   if ( key === 'listGroup' || key === 'originalMw' ) {
-   return null;
+   if ( key === 'listIndex' ) {
+   return 
ve.dm.MWReferenceNode.parent.static.describeChange.apply( this, arguments );
}
-
-   return ve.dm.MWReferenceNode.parent.static.describeChange.apply( this, 
arguments );
 };
 
 /* Methods */

-- 
To view, visit https://gerrit.wikimedia.org/r/371588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2513bb82099a92529516e4e217e61a2d0a2dd43b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Tchanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Improve documentation of methods

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330117 )

Change subject: Improve documentation of methods
..


Improve documentation of methods

Change-Id: I231d6a3e095324ae1509fdf028bcc352148a0dbe
---
M includes/AbuseFilter.class.php
M includes/AbuseFilter.hooks.php
2 files changed, 92 insertions(+), 82 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AbuseFilter.class.php b/includes/AbuseFilter.class.php
index c8b9cd5..a9b5f0e 100644
--- a/includes/AbuseFilter.class.php
+++ b/includes/AbuseFilter.class.php
@@ -16,6 +16,8 @@
private static $filterCache = [];
 
public static $condCount = 0;
+
+   /** @var array Map of (action ID => string[]) */
public static $tagsToSet = []; // FIXME: avoid global state here
 
public static $history_mappings = [
@@ -148,8 +150,8 @@
public static $editboxName = null;
 
/**
-* @param $context IContextSource
-* @param $pageType
+* @param IContextSource $context
+* @param string $pageType
 */
public static function addNavigationLinks( IContextSource $context, 
$pageType ) {
$linkDefs = [
@@ -205,7 +207,7 @@
 
/**
 * @static
-* @param  $user User
+* @param User $user
 * @return AbuseFilterVariableHolder
 */
public static function generateUserVars( $user ) {
@@ -275,7 +277,7 @@
}
 
/**
-* @param $filter
+* @param string $filter
 * @return bool
 */
public static function filterHidden( $filter ) {
@@ -304,7 +306,7 @@
}
 
/**
-* @param $val int
+* @param int $val
 * @throws MWException
 */
public static function triggerLimiter( $val = 1 ) {
@@ -323,8 +325,8 @@
}
 
/**
-* @param $title Title
-* @param $prefix
+* @param Title|null $title
+* @param string $prefix
 * @return AbuseFilterVariableHolder
 */
public static function generateTitleVars( $title, $prefix ) {
@@ -408,9 +410,9 @@
}
 
/**
-* @param $conds
-* @param $vars
-* @param $ignoreError bool
+* @param string $conds
+* @param AbuseFilterVariableHolder $vars
+* @param bool $ignoreError
 * @return bool
 * @throws Exception
 */
@@ -446,7 +448,7 @@
/**
 * Returns an associative array of filters which were tripped
 *
-* @param $vars AbuseFilterVariableHolder
+* @param AbuseFilterVariableHolder $vars
 * @param string $group The filter's group (as defined in 
$wgAbuseFilterValidGroups)
 *
 * @return bool[] Map of (integer filter ID => bool)
@@ -520,10 +522,10 @@
 
/**
 * @static
-* @param $row
-* @param $vars
-* @param $profile bool
-* @param $prefix string
+* @param stdClass $row
+* @param AbuseFilterVariableHolder $vars
+* @param bool $profile
+* @param string $prefix
 * @return bool
 */
public static function checkFilter( $row, $vars, $profile = false, 
$prefix = '' ) {
@@ -569,7 +571,7 @@
}
 
/**
-* @param $filter
+* @param int $filter
 */
public static function resetFilterProfile( $filter ) {
$stash = ObjectCache::getMainStashInstance();
@@ -583,9 +585,9 @@
}
 
/**
-* @param $filter
-* @param $time
-* @param $conds
+* @param int $filter
+* @param float $time
+* @param int $conds
 */
public static function recordProfilingResult( $filter, $time, $conds ) {
// Defer updates to avoid massive (~1 second) edit time 
increases
@@ -612,7 +614,7 @@
}
 
/**
-* @param $filter
+* @param string $filter
 * @return array
 */
public static function getFilterProfile( $filter ) {
@@ -641,7 +643,7 @@
/**
 * Utility function to decode global-$index to $index. Returns false if 
not global
 *
-* @param $filter string
+* @param string $filter
 *
 * @return string|bool
 */
@@ -654,8 +656,8 @@
}
 
/**
-* @param $filters array
-* @return array
+* @param string[] $filters
+* @return array[]
 */
public static function getConsequencesForFilters( $filters ) {
$globalFilters = [];
@@ -690,10 +692,10 @@
}
 
/**
-* @param $dbr DatabaseBase
-* @param $filters array
-* @param $prefix string
-* @return array
+* @param DatabaseBase $dbr
+* @param string[] $filters
+ 

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Don't throw if someone accesses mw.wikibase.entity.notAPrope...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371070 )

Change subject: Don't throw if someone accesses 
mw.wikibase.entity.notAPropertyId
..


Don't throw if someone accesses mw.wikibase.entity.notAPropertyId

Also make getBestStatements complain if the passed property id
is not valid.

Change-Id: I28971864dc664593eac1155485cf82e351f4ed63
---
M client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua
M 
client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
2 files changed, 48 insertions(+), 13 deletions(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua 
b/client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua
index 112cba9..989a572 100644
--- a/client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua
+++ b/client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua
@@ -26,6 +26,13 @@
RANK_DEPRECATED = 0
 }
 
+-- Is this a valid property id (Pnnn)?
+--
+-- @param {string} propertyId
+local isValidPropertyId = function( propertyId )
+   return type( propertyId ) == 'string' and propertyId:match( 
'^P[1-9]%d*$' )
+end
+
 -- Function to mask an entity's claims table in order to log access
 -- to individual claims of an entity.
 -- Code for logging based on: http://www.lua.org/pil/13.4.4.html
@@ -39,20 +46,24 @@
entity.claims = {}
 
local pseudoClaimsMetatable = {}
-   pseudoClaimsMetatable.__index = function( emptyTable, propertyID )
-   php.addStatementUsage(entity.id, propertyID)
-   return actualEntityClaims[propertyID]
+   pseudoClaimsMetatable.__index = function( emptyTable, propertyId )
+   if isValidPropertyId( propertyId ) then
+   -- Only attempt to track the usage if we have a valid 
property id.
+   php.addStatementUsage( entity.id, propertyId )
+   end
+
+   return actualEntityClaims[propertyId]
end
 
-   pseudoClaimsMetatable.__newindex = function( emptyTable, propertyID, 
data )
+   pseudoClaimsMetatable.__newindex = function( emptyTable, propertyId, 
data )
error( 'Entity cannot be modified' )
end
 
-   local logNext = function( emptyTable, propertyID )
-   if propertyID ~= nil then
-   php.addStatementUsage(entity.id, propertyID)
+   local logNext = function( emptyTable, propertyId )
+   if isValidPropertyId( propertyId ) then
+   php.addStatementUsage( entity.id, propertyId )
end
-   return next( actualEntityClaims, propertyID )
+   return next( actualEntityClaims, propertyId )
end
 
pseudoClaimsMetatable.__pairs = function( emptyTable )
@@ -187,6 +198,12 @@
 --
 -- @param {string} propertyId
 methodtable.getBestStatements = function( entity, propertyId )
+   checkType( 'getBestStatements', 1, propertyId, 'string' )
+
+   if not isValidPropertyId( propertyId ) then
+   error( 'Invalid property id passed to 
mw.wikibase.entity.getBestStatements: "' .. propertyId .. '"' )
+   end
+
if entity.claims == nil or not entity.claims[propertyId] then
return {}
end
@@ -240,7 +257,7 @@
)
 
local label
-   if propertyLabelOrId:match( '^P%d+$' ) then
+   if isValidPropertyId( propertyLabelOrId ) then
label = mw.wikibase.label( propertyLabelOrId )
end
 
diff --git 
a/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
 
b/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
index 2c173bf..3d20045 100644
--- 
a/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
+++ 
b/client/tests/phpunit/includes/DataAccess/Scribunto/LuaWikibaseEntityLibraryTests.lua
@@ -211,7 +211,13 @@
 
 local function testClaimsNewIndex()
local entity = mw.wikibase.getEntityObject( 'Q32487' )
-   entity['claims']['P321'] = ""
+   entity.claims['P321'] = ""
+end
+
+local function testClaimsAccessIndex( propertyId )
+   local entity = mw.wikibase.getEntityObject( 'Q32487' )
+
+   return entity.claims[propertyId]
 end
 
 
@@ -221,14 +227,18 @@
{ name = 'mw.wikibase.entity exists', func = testExists, 
type='ToString',
  expect = { 'table' }
},
-   { name = 'mw.wikibase.testClaimsPairSize', func = testClaimsPairSize,
+   { name = 'mw.wikibase.entity.claims pair size', func = 
testClaimsPairSize,
  expect = { 1 }
},
-   { name = 'mw.wikibase.testClaimsPairContent', func = 
testClaimsPairContent,
+   { name = 'mw.wikibase.entity.claims pair content', func = 
testClaimsPairContent,
  expect = { 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: extension.json: Depend on MediaWiki 1.30+, not 1.29+

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371476 )

Change subject: extension.json: Depend on MediaWiki 1.30+, not 1.29+
..


extension.json: Depend on MediaWiki 1.30+, not 1.29+

We're using newer versions of OOjs UI than 1.29 provide.

Change-Id: I7691b231c7f139fccf5c35a06a21bb2826910d52
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tchanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 41984bb..18b9a49 100644
--- a/extension.json
+++ b/extension.json
@@ -21,7 +21,7 @@
"license-name": "MIT",
"type": "other",
"requires": {
-   "MediaWiki": ">= 1.29.0"
+   "MediaWiki": ">= 1.30.0"
},
"callback": "VisualEditorHooks::onRegistration",
"config": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7691b231c7f139fccf5c35a06a21bb2826910d52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Tchanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Misc tweaks to comments

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370461 )

Change subject: Misc tweaks to comments
..


Misc tweaks to comments

Change-Id: I4fd03f0e61118b6e9835f53c2dd9438c34b26801
---
M lib/lineardoc/TextBlock.js
M lib/mw/ApiRequest.js
M lib/mw/BatchedAPIRequest.js
M lib/translationunits/MWLink.js
4 files changed, 13 insertions(+), 14 deletions(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/lineardoc/TextBlock.js b/lib/lineardoc/TextBlock.js
index 3f9ece6..5b42171 100644
--- a/lib/lineardoc/TextBlock.js
+++ b/lib/lineardoc/TextBlock.js
@@ -390,7 +390,7 @@
// the execution till the async call is resolved. For us, while looping 
over these text
// chunks and tags, this will create a problem. Adaptations often 
perform asynchrounous API
// calls to a MediaWiki instance. If we do API calls for each and every 
item like a link
-   // title, it is inefficient. The API accepts a batched list of titles. 
We do have a  batched
+   // title, it is inefficient. The API accepts a batched list of titles. 
We do have a batched
// API mechanism in cxserver, but that works by debouncing the incoming 
requests with a
// timeout. Pausing execution here will cause that debounce handler to 
be called.
// So we avoid that pausing by just using an array of promises.
diff --git a/lib/mw/ApiRequest.js b/lib/mw/ApiRequest.js
index 4bda2b5..fd96486 100644
--- a/lib/mw/ApiRequest.js
+++ b/lib/mw/ApiRequest.js
@@ -24,10 +24,10 @@
/**
 * Calls the MW API with the supplied query as its body
 *
-* @param {string} domain the domain to issue the request to
-* @param {Object} query an object with all the query parameters for 
the MW API
+* @param {string} domain The domain to issue the request to
+* @param {Object} query An object with all the query parameters for 
the MW API
 * @param {string} method The HTTP method to use - get or post
-* @return {Promise} a promise resolving as the response object from 
the MW API
+* @return {Promise} A promise resolving as the response object from 
the MW API
 */
mwRequest( domain, query, method ) {
var request;
@@ -68,20 +68,20 @@
/**
 * Calls the MW API with the supplied query as its body
 *
-* @param {string} domain the domain to issue the request to
-* @param {Object} query an object with all the query parameters for 
the MW API
-* @return {Promise} a promise resolving as the response object from 
the MW API
+* @param {string} domain The domain to issue the request to
+* @param {Object} query An object with all the query parameters for 
the MW API
+* @return {Promise} A promise resolving as the response object from 
the MW API
 */
mwPost( domain, query ) {
return this.mwRequest( domain, query, 'post' );
}
 
/**
-* Calls the MW API with the supplied query as its body
+* Calls the MW API with the supplied query as URL params
 *
-* @param {string} domain the domain to issue the request to
-* @param {Object} query an object with all the query parameters for 
the MW API
-* @return {Promise} a promise resolving as the response object from 
the MW API
+* @param {string} domain The domain to issue the request to
+* @param {Object} query An object with all the query parameters for 
the MW API
+* @return {Promise} A promise resolving as the response object from 
the MW API
 */
mwGet( domain, query ) {
return this.mwRequest( domain, query, 'get' );
diff --git a/lib/mw/BatchedAPIRequest.js b/lib/mw/BatchedAPIRequest.js
index e66a5fe..ebf4253 100644
--- a/lib/mw/BatchedAPIRequest.js
+++ b/lib/mw/BatchedAPIRequest.js
@@ -7,7 +7,7 @@
  * Used to queue up lists of items centrally to get information about in 
batches of requests.
  *
  * @class
- * @extends OO.EventEmitter
+ * @extends MWApiRequest
  * @constructor
  * @param {Object} config Configuration
  */
@@ -48,7 +48,6 @@
 * Perform any scheduled API requests.
 *
 * @private
-* @fires add
 */
processQueue() {
var subqueue, queue, processResult,
diff --git a/lib/translationunits/MWLink.js b/lib/translationunits/MWLink.js
index fcbd61c..8b7ac90 100644
--- a/lib/translationunits/MWLink.js
+++ b/lib/translationunits/MWLink.js
@@ -20,7 +20,7 @@
.titlePairRequest( this.node.attributes.href, 
this.sourceLanguage, this.targetLanguage );
 
if ( linkPairInfo.targetTitle ) {
-   // NOTE: This titles we are setting here are not relative 
titles.
+   // NOTE: This paths we are setting here are not relative paths.

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Change the language-data node module source

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371113 )

Change subject: Change the language-data node module source
..


Change the language-data node module source

Now the language-data is hosted under wikimedia account at github

Change-Id: I34fc3bf461dbe872c42d9defebd16bb55e49aead
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/package.json b/package.json
index 9e891d5..7e9db95 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
 "html-entities": "1.2.0",
 "js-yaml": "^3.6.1",
 "jsonwebtoken": "~5.6.0",
-"language-data": "git+https://github.com/santhoshtr/language-data#master";,
+"language-data": "git+https://github.com/wikimedia/language-data#master";,
 "mediawiki-title": "^0.6.3",
 "preq": "^0.5.2",
 "sax": "1.2.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/371113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34fc3bf461dbe872c42d9defebd16bb55e49aead
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: KartikMistry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Implements a difference engine for Index: pages

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371136 )

Change subject: Implements a difference engine for Index: pages
..


Implements a difference engine for Index: pages

Change-Id: I8a29d94022ff86c9823414e7bae1ab8ce0f63b13
---
M extension.json
M includes/index/IndexContentHandler.php
A includes/index/IndexDifferenceEngine.php
M includes/page/PageDifferenceEngine.php
4 files changed, 109 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/extension.json b/extension.json
index 266871c..042b62b 100644
--- a/extension.json
+++ b/extension.json
@@ -53,6 +53,7 @@
"ProofreadPage\\Index\\IndexContent": 
"includes/index/IndexContent.php",
"ProofreadPage\\Index\\IndexRedirectContent": 
"includes/index/IndexRedirectContent.php",
"ProofreadPage\\Index\\IndexContentHandler": 
"includes/index/IndexContentHandler.php",
+   "ProofreadPage\\Index\\IndexDifferenceEngine": 
"includes/index/IndexDifferenceEngine.php",
"ProofreadPage\\Index\\IndexEditAction": 
"includes/index/IndexEditAction.php",
"ProofreadPage\\Index\\IndexSubmitAction": 
"includes/index/IndexSubmitAction.php",
"ProofreadPage\\Index\\EditIndexPage": 
"includes/index/EditIndexPage.php",
diff --git a/includes/index/IndexContentHandler.php 
b/includes/index/IndexContentHandler.php
index 5d18c7f..2b1f606 100644
--- a/includes/index/IndexContentHandler.php
+++ b/includes/index/IndexContentHandler.php
@@ -129,6 +129,13 @@
}
 
/**
+* @see ContentHandler::getDiffEngineClass
+*/
+   protected function getDiffEngineClass() {
+   return '\ProofreadPage\Index\IndexDifferenceEngine';
+   }
+
+   /**
 * @see ContentHandler::makeEmptyContent
 */
public function makeEmptyContent() {
diff --git a/includes/index/IndexDifferenceEngine.php 
b/includes/index/IndexDifferenceEngine.php
new file mode 100644
index 000..ae4488d
--- /dev/null
+++ b/includes/index/IndexDifferenceEngine.php
@@ -0,0 +1,98 @@
+diffFormatterUtils = new DiffFormatterUtils();
+   $extContext = ( $extContext === null ) ? 
Context::getDefaultContext() : $extContext;
+   $this->customIndexFieldsParser = 
$extContext->getCustomIndexFieldsParser();
+   }
+
+   /**
+* @see DifferenceEngine::generateContentDiffBody
+*/
+   public function generateContentDiffBody( Content $old, Content $new ) {
+   if ( $old instanceof IndexRedirectContent ) {
+   if ( $new instanceof IndexRedirectContent ) {
+   return $this->createRedirectionDiff( 
$old->getRedirectTarget(), $new->getRedirectTarget() );
+   } elseif ( $new instanceof IndexContent ) {
+   return $this->createRedirectionDiff( 
$old->getRedirectTarget(), null ) .
+   $this->createIndexContentDiff( null, 
$new );
+   }
+   } elseif ( $old instanceof IndexContent ) {
+   if ( $new instanceof IndexRedirectContent ) {
+   return $this->createRedirectionDiff( null, 
$new->getRedirectTarget() ) .
+   $this->createIndexContentDiff( $old, 
null );
+   } elseif ( $new instanceof IndexContent ) {
+   return $this->createIndexContentDiff( $old, 
$new );
+   }
+   }
+   throw new InvalidArgumentException(
+   'IndexDifferenceEngine is only able to output diffs 
between IndexContents'
+   );
+   }
+
+   private function createRedirectionDiff( Title $old = null, Title $new = 
null ) {
+   $old = ( $old === null ) ? '' : $old->getFullText();
+   $new = ( $new === null ) ? '' : $new->getFullText();
+   return $this->createTextDiffOutput( $old, $new,
+   $this->msg( 'isredirect' )->escaped()
+   );
+   }
+
+   private function createIndexContentDiff( IndexContent $old = null, 
IndexContent $new = null ) {
+   $oldCustomFields = ( $old === null )
+   ? []
+   : 
$this->customIndexFieldsParser->parseCustomIndexFields( $old );
+   $newCustomFields = ( $new === null )
+   ? []
+   : 
$this->customIndexFieldsParser->parseCustomIndexFields( $new );
+   $diff = '';
+   foreach ( $oldCustomFields as $oldField ) {
+   $diff .= $this->createTextDiffOutput(
+   $oldField->getStringValue(),
+   
$newCustomFields[

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Replace remaining greys with WikimediaUI palette ones

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371329 )

Change subject: Replace remaining greys with WikimediaUI palette ones
..


Replace remaining greys with WikimediaUI palette ones

Replacing remaining `#ccc` with WikimediaUI palette's `#c8ccd1`.
Also replacing static `border-radius` values with variables.

Bug: T149768
Change-Id: I42d4e4152d2a98d34e486c9ad77bb507391be451
---
M modules/editor/editors/visualeditor/mw.flow.ve.Target.less
M modules/styles/board/topic/titlebar.less
M modules/styles/flow/widgets/editor/mw.flow.ui.editor-monobook.less
M modules/styles/flow/widgets/editor/mw.flow.ui.editor-vector.less
M modules/styles/mediawiki.ui/forms.less
M modules/styles/mediawiki.ui/tooltips.less
6 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.Target.less 
b/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
index 234b30c..2f75f53 100644
--- a/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.Target.less
@@ -6,7 +6,7 @@
 // has been removed
 .flow-component {
.ve-init-target {
-   border: 1px solid #ccc;
+   border: 1px solid #c8ccd1;
}
 
.ve-ce-documentNode,
diff --git a/modules/styles/board/topic/titlebar.less 
b/modules/styles/board/topic/titlebar.less
index cf0761e..ed76ea7 100644
--- a/modules/styles/board/topic/titlebar.less
+++ b/modules/styles/board/topic/titlebar.less
@@ -7,7 +7,7 @@
position: relative;
padding: 0.5em 0;
background-color: @colorGray14;
-   border-radius: 3px;
+   border-radius: @borderRadius;
outline: 0;
 
// use child selector to block ie6
diff --git a/modules/styles/flow/widgets/editor/mw.flow.ui.editor-monobook.less 
b/modules/styles/flow/widgets/editor/mw.flow.ui.editor-monobook.less
index 3160a87..0208958 100644
--- a/modules/styles/flow/widgets/editor/mw.flow.ui.editor-monobook.less
+++ b/modules/styles/flow/widgets/editor/mw.flow.ui.editor-monobook.less
@@ -70,8 +70,8 @@
 .flow-ui-editorSwitcherWidget {
// Undo border & box-shadow on textarea and re-apply it on the
// div that contains textarea + legal text + switch button
-   border: 1px solid #ccc;
-   border-radius: 0.25em;
+   border: 1px solid #c8ccd1;
+   border-radius: @borderRadius;
 }
 
 .flow-editor.flow-ui-focused,
diff --git a/modules/styles/flow/widgets/editor/mw.flow.ui.editor-vector.less 
b/modules/styles/flow/widgets/editor/mw.flow.ui.editor-vector.less
index 174514a..996c3bf 100644
--- a/modules/styles/flow/widgets/editor/mw.flow.ui.editor-vector.less
+++ b/modules/styles/flow/widgets/editor/mw.flow.ui.editor-vector.less
@@ -79,7 +79,7 @@
-moz-transition: border 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 ), 
box-shadow 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 );
-o-transition: border 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 ), 
box-shadow 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 );
transition: border 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 ), 
box-shadow 0.2s cubic-bezier( 0.39, 0.575, 0.565, 1 );
-   border-radius: 2px;
+   border-radius: @borderRadius;
 }
 
 .flow-editor.flow-ui-focused,
diff --git a/modules/styles/mediawiki.ui/forms.less 
b/modules/styles/mediawiki.ui/forms.less
index 90581ae..ee478e3 100644
--- a/modules/styles/mediawiki.ui/forms.less
+++ b/modules/styles/mediawiki.ui/forms.less
@@ -101,7 +101,7 @@
 
.mw-ui-validation-icon {
border-color: @colorGray7;
-   border-radius: 0 2px 2px 0;
+   border-radius: 0 @borderRadius @borderRadius 0;
border-style: solid;
border-width: 1px 1px 1px 0;
}
diff --git a/modules/styles/mediawiki.ui/tooltips.less 
b/modules/styles/mediawiki.ui/tooltips.less
index 6632d15..01f3dfa 100644
--- a/modules/styles/mediawiki.ui/tooltips.less
+++ b/modules/styles/mediawiki.ui/tooltips.less
@@ -23,7 +23,7 @@
background: #fff;
color: @colorText;
word-wrap: break-word;
-   border-radius: 3px;
+   border-radius: @borderRadius;
.box-shadow( ~'0 2px 0 0 @{colorGray12}, 0 0 1px 0 @{colorGray12}' );
opacity: 0.9;
z-index: 99;

-- 
To view, visit https://gerrit.wikimedia.org/r/371329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42d4e4152d2a98d34e486c9ad77bb507391be451
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Mattflaschen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing l

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Add deleteWiki.php

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371587 )

Change subject: Add deleteWiki.php
..

Add deleteWiki.php

Maintains database integrity to remove references to a wiki being
deleted from various global databases.

Change-Id: I2dce175d5f9a357b5b9de2bfc519e5f759dfdce7
---
A deleteWiki.php
1 file changed, 99 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMaintenance 
refs/changes/87/371587/1

diff --git a/deleteWiki.php b/deleteWiki.php
new file mode 100644
index 000..d1c11aa
--- /dev/null
+++ b/deleteWiki.php
@@ -0,0 +1,99 @@
+http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ * @ingroup Maintenance
+ * @ingroup Wikimedia
+ */
+
+use MediaWiki\MediaWikiServices;
+
+require_once __DIR__ . '/WikimediaMaintenance.php';
+
+class DeleteWiki extends Maintenance {
+   public function __construct() {
+   parent::__construct();
+   $this->addDescription( 'Cleans up databases from references to 
a deleted wiki, but does '
+   . 'not delete anything from the wiki itself.'
+   );
+
+   $this->addArg( 'wiki', 'Wiki being deleted', true );
+   $this->setBatchSize( 500 );
+   }
+
+   /**
+* Nuke all the datas!
+*/
+   public function execute() {
+   $wiki = $this->getArg( 0 );
+
+   $this->output( "ATTENTION: All references to $wiki are going to 
be irreversibly DELETED! "
+   . "Press Ctrl+C to abort.\n"
+   );
+   if ( !$this->isQuiet() ) {
+   wfCountDown( 10 );
+   }
+
+   $this->output( "Cleaning up global image links...\n" );
+   $this->cleanupWikiDb( 'commonswiki', "DELETE FROM 
globalimagelinks WHERE gil_wiki='$wiki'" );
+
+   $this->output( "Cleaning up CentralAuth localnames...\n" );
+   $this->cleanupWikiDb( 'centralauth', "DELETE FROM localnames 
WHERE ln_wiki='$wiki'" );
+
+   $this->output( "Cleaning up CentralAuth localuser...\n" );
+   $this->cleanupWikiDb( 'centralauth', "DELETE FROM localuser 
WHERE lu_wiki='$wiki'" );
+
+   $this->output( "Cleaning up CentralAuth renameuser_status...\n" 
);
+   $this->cleanupWikiDb( 'centralauth', "DELETE FROM 
renameuser_status WHERE ru_wiki='$wiki'" );
+
+   // @TODO: wikiset
+
+   $this->output( "Cleaning up CentralAuth renameuser_queue...\n" 
);
+   $this->cleanupWikiDb( 'centralauth', "DELETE FROM 
renameuser_queue WHERE rq_wiki='$wiki'" );
+
+   $this->output( "Cleaning up CentralAuth users_to_rename...\n" );
+   $this->cleanupWikiDb( 'centralauth', "DELETE FROM 
users_to_rename WHERE utr_wiki='$wiki'" );
+   }
+
+   /**
+* Perform cleanup of a wiki
+*
+* @param string $wiki Wiki to operate on (NOT the wiki being deleted!)
+* @param string $query Query to run in batches
+*/
+   private function cleanupWikiDb( $wiki, $query ) {
+   $lbFactory = 
MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
+   $lb = $lbFactory->getMainLB( $wiki );
+   $dbw = $lb->getConnection( DB_MASTER );
+
+   $query .= " LIMIT {$this->mBatchSize}";
+   $count = 0;
+   do {
+   $dbw->query( $query, __METHOD__ );
+   $lbFactory->waitForReplication( [ 'wiki' => $wiki ] );
+   $count += $dbw->affectedRows();
+   $this->output( "  $count\n" );
+   } while ( $dbw->affectedRows() >= $this->mBatchSize );
+
+   $lb->reuseConnection( $dbw );
+   }
+}
+
+$maintClass = 'DeleteWiki';
+require_once RUN_MAINTENANCE_IF_MAIN;

-- 
To view, visit https://gerrit.wikimedia.org/r/371587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dce175d5f9a357b5b9de2bfc519e5f759dfdce7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMaintenance
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [WIP] harvest multiple values from one parameter

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371586 )

Change subject: [WIP] harvest multiple values from one parameter
..

[WIP] harvest multiple values from one parameter

Does not work with -islink

FIXME: refactor lame claim/claims codepaths, work with claim types
besides wikibase-item

Bug: T87689
Change-Id: Ied808405a21213e165d51b3fe3d79dfd883e58c0
---
M scripts/harvest_template.py
1 file changed, 54 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/86/371586/1

diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py
index 5d99364..5959270 100755
--- a/scripts/harvest_template.py
+++ b/scripts/harvest_template.py
@@ -71,6 +71,15 @@
 page won't be skipped if the item already has that property but there is
 not the new value.
 
+python pwb.py harvest_template -lang:en -family:wikipedia -namespace:0 \
+-template:"Infobox musical artist" current_members P527 -exists:p 
-multi
+
+will import band members from the "current_members" parameter of "Infobox
+musical artist" on English Wikipedia as Wikidata property "P527" (has 
part).
+This will only extract multiple band members if each is linked, and will 
not
+add duplicate claims for the same member.
+
+TODO: 'multi' implies at least exists:p - set that automatically?
 """
 #
 # (C) Multichill, Amir, 2013
@@ -109,8 +118,9 @@
 """Class holding options for a param-property pair."""
 
 availableOptions = {
-'islink': False,
 'exists': '',
+'islink': False,
+'multi': False,
 }
 
 
@@ -130,11 +140,14 @@
 @type fields: dict
 @keyword islink: Whether non-linked values should be treated as links
 @type islink: bool
+@keyword multi: Whether multiple values should be extracted from a 
single parameter
+@type islink: bool
 """
 self.availableOptions.update({
 'always': True,
 'exists': '',
 'islink': False,
+'multi': False,
 })
 super(HarvestRobot, self).__init__(**kwargs)
 self.generator = generator
@@ -220,7 +233,8 @@
 raise KeyboardInterrupt
 self.current_page = page
 item.get()
-if set(val[0] for val in self.fields.values()) <= set(
+any_multi = any('exists' in val[1].options for val in 
self.fields.values())
+if not any_multi and set(val[0] for val in self.fields.values()) <= 
set(
 item.claims.keys()):
 pywikibot.output('%s item %s has claims for all properties. '
  'Skipping.' % (page, item.title()))
@@ -253,25 +267,43 @@
 # This field contains something useful for us
 prop, options = self.fields[field]
 claim = pywikibot.Claim(self.repo, prop)
+claims = []  # FIXME: this is a horrid way to do multiples
 if claim.type == 'wikibase-item':
-# Try to extract a valid page
-match = pywikibot.link_regex.search(value)
-if match:
-link_text = match.group(1)
-else:
-if self._get_option_with_fallback(options, 'islink'):
-link_text = value
-else:
+if self._get_option_with_fallback(options, 'multi'):
+matches = pywikibot.link_regex.findall(value)
+if matches:
+for match in matches:
+link_text = match[0]
+linked_item = self._template_link_target(item, 
link_text)
+if not linked_item:
+continue
+claim.setTarget(linked_item)
+claims.append(claim)
+claim = pywikibot.Claim(self.repo, prop)
+if len(claims) == 0:
 pywikibot.output(
-'%s field %s value %s is not a wikilink. '
+'%s field %s value %s contains no wikilinks to 
data items. '
 'Skipping.' % (claim.getID(), field, value))
 continue
+else:
+# Try to extract a valid page
+match = pywikibot.link_regex.search(value)
+if match:
+link_text = match.group(1)
+else:
+if self._get_option_with_fallback(options, 
'islink'):
+link_text = value
+else:
+ 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove passed FunctionComment.SpacingAfter from phpcs.xml

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371585 )

Change subject: Remove passed FunctionComment.SpacingAfter from phpcs.xml
..

Remove passed FunctionComment.SpacingAfter from phpcs.xml

After fix of the other MediaWiki.Commenting.FunctionComment sniffs the
SpacingAfter now passed, because it allows to align the variables

Change-Id: If5b0bd16028761abc2c47ace9e97d37ad14bb36f
---
M phpcs.xml
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/85/371585/1

diff --git a/phpcs.xml b/phpcs.xml
index 2831a2b..ad3b334 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
 


-   



-   
-   
-   




-- 
To view, visit https://gerrit.wikimedia.org/r/371585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b0bd16028761abc2c47ace9e97d37ad14bb36f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing @param and @return documentation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371558 )

Change subject: Add missing @param and @return documentation
..


Add missing @param and @return documentation

Change-Id: I1d1098eec3933df6561cceef646576013ddc08c8
---
M includes/AuthPlugin.php
M includes/FauxRequest.php
M includes/Linker.php
M includes/OutputPage.php
M includes/Preferences.php
M includes/Title.php
M includes/changes/RecentChange.php
M includes/changetags/ChangeTags.php
M includes/export/WikiExporter.php
M includes/libs/filebackend/SwiftFileBackend.php
M includes/media/MediaHandler.php
M includes/media/WebP.php
M includes/search/SearchEngine.php
M includes/search/SearchHighlighter.php
M includes/session/Token.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/SpecialMediaStatistics.php
M includes/upload/UploadBase.php
M phpcs.xml
19 files changed, 45 insertions(+), 8 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AuthPlugin.php b/includes/AuthPlugin.php
index 24ae856..b73ecbd 100644
--- a/includes/AuthPlugin.php
+++ b/includes/AuthPlugin.php
@@ -359,6 +359,7 @@
 
/**
 * @deprecated since 1.28, use 
SessionManager::invalidateSessionForUser() instead.
+* @return bool
 */
public function resetAuthToken() {
# Override this!
diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 9147240..2f7f75b 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -152,6 +152,7 @@
 
/**
 * @since 1.25
+* @param string $url
 */
public function setRequestURL( $url ) {
$this->requestUrl = $url;
@@ -160,6 +161,7 @@
/**
 * @since 1.25 MWException( "getRequestURL not implemented" )
 * no longer thrown.
+* @return string
 */
public function getRequestURL() {
if ( $this->requestUrl === null ) {
diff --git a/includes/Linker.php b/includes/Linker.php
index 34cc49a..d55f0e0 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -154,6 +154,11 @@
 * @since 1.16.3
 * @deprecated since 1.28, use MediaWiki\Linker\LinkRenderer instead
 * @see Linker::link
+* @param Title $target
+* @param string $html
+* @param array $customAttribs
+* @param array $query
+* @param string|array $options
 * @return string
 */
public static function linkKnown(
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index fd002d1..2a3a7cd 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -571,6 +571,7 @@
 * @param bool $filter Whether to filter out insufficiently trustworthy 
modules
 * @param string|null $position If not null, only return modules with 
this position
 * @param string $param
+* @param string $type
 * @return array Array of module names
 */
public function getModules( $filter = false, $position = null, $param = 
'mModules',
diff --git a/includes/Preferences.php b/includes/Preferences.php
index 48eaaf2..039d99c 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1122,6 +1122,9 @@
 
/**
 * Dummy, kept for backwards-compatibility.
+* @param User $user
+* @param IContextSource $context
+* @param array &$defaultPreferences
 */
static function miscPreferences( $user, IContextSource $context, 
&$defaultPreferences ) {
}
diff --git a/includes/Title.php b/includes/Title.php
index 1fd1073..05f85fa 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1896,6 +1896,8 @@
 * protocol-relative, the URL will be expanded to http://
 *
 * @see self::getLocalURL for the arguments.
+* @param string $query
+* @param string|bool $query2
 * @return string The URL
 */
public function getInternalURL( $query = '', $query2 = false ) {
diff --git a/includes/changes/RecentChange.php 
b/includes/changes/RecentChange.php
index 64c..f123363 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -426,6 +426,7 @@
 * @since 1.22
 * @deprecated since 1.29 Use RCFeed::factory() instead
 * @param string $uri URI to get the engine object for
+* @param array $params
 * @return RCFeedEngine The engine object
 * @throws MWException
 */
diff --git a/includes/changetags/ChangeTags.php 
b/includes/changetags/ChangeTags.php
index 608e7bb..fa98124 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -1328,6 +1328,7 @@
 *
 * @see listSoftwareDefinedTags
 * @deprecated since 1.28
+* @return array
 */
public st

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing type to @param documentation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371557 )

Change subject: Add missing type to @param documentation
..


Add missing type to @param documentation

Change-Id: I6b2c9c7af9a281fe457099cc3a336a60a25e74aa
---
M includes/OutputPage.php
M includes/PHPVersionCheck.php
M includes/api/ApiCSPReport.php
M includes/collation/NumericUppercaseCollation.php
M includes/content/JsonContent.php
M includes/content/TextContent.php
M includes/installer/SqliteInstaller.php
M includes/libs/IEUrlExtension.php
M includes/libs/mime/IEContentAnalyzer.php
M includes/libs/mime/XmlTypeCheck.php
M includes/libs/rdbms/TransactionProfiler.php
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/encasing/Blob.php
M includes/media/MediaHandler.php
M includes/media/WebP.php
M includes/page/ImagePage.php
M includes/search/NullIndexField.php
M includes/search/SearchIndexField.php
M includes/search/SearchIndexFieldDefinition.php
M includes/site/SiteImporter.php
M includes/specialpage/AuthManagerSpecialPage.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/pagers/ProtectedPagesPager.php
M languages/Language.php
M languages/classes/LanguageEn.php
M tests/parser/ParserTestRunner.php
M tests/phpunit/includes/WatchedItemQueryServiceUnitTest.php
M tests/phpunit/includes/WatchedItemStoreUnitTest.php
M tests/phpunit/includes/content/WikitextStructureTest.php
M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
M tests/phpunit/includes/search/SearchIndexFieldTest.php
31 files changed, 86 insertions(+), 85 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 8f62a85..fd002d1 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1963,7 +1963,7 @@
}
 
/**
-* @param $maxage
+* @param int $maxage
 * @deprecated since 1.27 Use setCdnMaxage() instead
 */
public function setSquidMaxage( $maxage ) {
diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index c8872d2..cd5bf54 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -231,9 +231,9 @@
/**
 * Returns an error page, which is suitable for output to the end user 
via a web browser.
 *
-* @param $title
-* @param $longHtml
-* @param $shortText
+* @param string $title
+* @param string $longHtml
+* @param string $shortText
 * @return string
 */
function getIndexErrorOutput( $title, $longHtml, $shortText ) {
diff --git a/includes/api/ApiCSPReport.php b/includes/api/ApiCSPReport.php
index 3a78c13..a4a46bb 100644
--- a/includes/api/ApiCSPReport.php
+++ b/includes/api/ApiCSPReport.php
@@ -63,9 +63,9 @@
 
/**
 * Log CSP report, with a different severity depending on $flags
-* @param $flags Array Flags for this report
-* @param $logLine String text of log entry
-* @param $context Array logging context
+* @param array $flags Flags for this report
+* @param string $logLine text of log entry
+* @param array $context logging context
 */
private function logReport( $flags, $logLine, $context ) {
if ( in_array( 'false-positive', $flags ) ) {
@@ -80,8 +80,8 @@
/**
 * Get extra notes about the report.
 *
-* @param $report Array The CSP report
-* @return Array
+* @param array $report The CSP report
+* @return array
 */
private function getFlags( $report ) {
$reportOnly = $this->getParameter( 'reportonly' );
@@ -155,9 +155,9 @@
/**
 * Get text of log line.
 *
-* @param $flags Array of additional markers for this report
-* @param $report Array the csp report
-* @return String Text to put in log
+* @param array $flags of additional markers for this report
+* @param array $report the csp report
+* @return string Text to put in log
 */
private function generateLogLine( $flags, $report ) {
$flagText = '';
@@ -177,8 +177,8 @@
/**
 * Stop processing the request, and output/log an error
 *
-* @param $code String error code
-* @param $method String method that made error
+* @param string $code error code
+* @param string $method method that made error
 * @throws ApiUsageException Always
 */
private function error( $code, $method ) {
diff --git a/includes/collation/NumericUppercaseCollation.php 
b/includes/collation/NumericUppercaseCollation.php
index 8dd7a38..da78a05 100644
--- a/includes/collation/NumericUppercaseCollation.php
+++ b/includes/collation/NumericUppercaseCollation.php
@@

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do not circumvent ExceptionRenderer for MWExceptions

[Code Review]

Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371584 )

Change subject: Do not circumvent ExceptionRenderer for MWExceptions
..

Do not circumvent ExceptionRenderer for MWExceptions

* allow ExceptionRenderer to override how MWExceptions are displayed
* remove duplicate code from MWException
* use API/commandline-specific code (it was overridden in some
  subclasses)

Task: T111731
Change-Id: If3747eab5fb3499708956fd8282a88ca973b4bc4
---
M includes/exception/BadRequestError.php
M includes/exception/HttpError.php
M includes/exception/MWException.php
M includes/exception/MWExceptionHandler.php
M includes/exception/Renderer.php
M includes/exception/StandardRenderer.php
M includes/exception/ThrottledError.php
M includes/filerepo/file/LocalFile.php
M tests/phpunit/includes/exception/MWExceptionTest.php
9 files changed, 49 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/371584/1

diff --git a/includes/exception/BadRequestError.php 
b/includes/exception/BadRequestError.php
index 5fcf0e6..a125242 100644
--- a/includes/exception/BadRequestError.php
+++ b/includes/exception/BadRequestError.php
@@ -26,9 +26,7 @@
  */
 class BadRequestError extends ErrorPageError {
 
-   public function report() {
-   global $wgOut;
-   $wgOut->setStatusCode( 400 );
-   parent::report();
+   public function getStatusCode() {
+   return 400;
}
 }
diff --git a/includes/exception/HttpError.php b/includes/exception/HttpError.php
index f464d8a..3f2f02d 100644
--- a/includes/exception/HttpError.php
+++ b/includes/exception/HttpError.php
@@ -72,9 +72,6 @@
public function report() {
$this->doLog();
 
-   HttpStatus::header( $this->httpCode );
-   header( 'Content-type: text/html; charset=utf-8' );
-
print $this->getHTML();
}
 
diff --git a/includes/exception/MWException.php 
b/includes/exception/MWException.php
index 8c1f8dc..ab11775 100644
--- a/includes/exception/MWException.php
+++ b/includes/exception/MWException.php
@@ -146,7 +146,17 @@
}
 
/**
+* Return the HTTP status code appropriate for this exception.
+*
+* @return int
+*/
+   public function getStatusCode() {
+   return 500;
+   }
+
+   /**
 * Output the exception report using HTML.
+* @deprecated since 1.30, create an ExceptionRenderer instead
 */
public function reportHTML() {
global $wgOut, $wgSitename;
@@ -176,38 +186,10 @@
/**
 * Output a report about the exception and takes care of formatting.
 * It will be either HTML or plain text based on isCommandLine().
+* @deprecated since 1.30, create an ExceptionRenderer instead
 */
public function report() {
-   global $wgMimeType;
-
-   if ( defined( 'MW_API' ) ) {
-   // Unhandled API exception, we can't be sure that 
format printer is alive
-   self::header( 'MediaWiki-API-Error: 
internal_api_error_' . static::class );
-   wfHttpError( 500, 'Internal Server Error', 
$this->getText() );
-   } elseif ( self::isCommandLine() ) {
-   $message = $this->getText();
-   // T17602: STDERR may not be available
-   if ( defined( 'STDERR' ) ) {
-   fwrite( STDERR, $message );
-   } else {
-   echo $message;
-   }
-   } else {
-   self::statusHeader( 500 );
-   self::header( "Content-Type: $wgMimeType; 
charset=utf-8" );
-
-   $this->reportHTML();
-   }
-   }
-
-   /**
-* Check whether we are in command line mode or not to report the 
exception
-* in the correct format.
-*
-* @return bool
-*/
-   public static function isCommandLine() {
-   return !empty( $GLOBALS['wgCommandLineMode'] );
+   $this->reportHTML();
}
 
/**
@@ -218,11 +200,6 @@
private static function header( $header ) {
if ( !headers_sent() ) {
header( $header );
-   }
-   }
-   private static function statusHeader( $code ) {
-   if ( !headers_sent() ) {
-   HttpStatus::header( $code );
}
}
 }
diff --git a/includes/exception/MWExceptionHandler.php 
b/includes/exception/MWExceptionHandler.php
index 2bbea0c..5a06208 100644
--- a/includes/exception/MWExceptionHandler.php
+++ b/includes/exception/MWExceptionHandler.php
@@ -68,14 +68,7 @@
$renderer = 
MediaWikiServ

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Add hierarchy field creation in Special:CreateClass

[Fz-29 (Code Review)]

Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371583 )

Change subject: Add hierarchy field creation in Special:CreateClass
..

Add hierarchy field creation in Special:CreateClass

Change-Id: I8eea2ff62b6382b29323d5b39e0dbdbb2a5fde95
---
M libs/PF_CreateClass.js
M specials/PF_CreateClass.php
2 files changed, 33 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms 
refs/changes/83/371583/1

diff --git a/libs/PF_CreateClass.js b/libs/PF_CreateClass.js
index 44e5fe7..be1428b 100644
--- a/libs/PF_CreateClass.js
+++ b/libs/PF_CreateClass.js
@@ -27,9 +27,24 @@
if (jQuery('#use_cargo').prop('checked')) {
jQuery('#cargo_table_input').show('medium');
$('td:nth-child(4),th:nth-child(3)').show('medium');
+   $('.hierarchy_structure_input').show('medium');
} else {
jQuery('#cargo_table_input').hide('medium');
$('td:nth-child(4),th:nth-child(3)').hide('medium');
+   $('.hierarchy_structure_input').hide('medium');
+   $("textarea[name*='hierarchy_structure_']").hide('medium');
+   $("input[name*='allowed_values_']").show('medium');
+   $('.isHierarchy').prop('checked', false);
+   }
+}
+
+function toggleHierarchyInput(containerElement) {
+   if (containerElement.find( "input[name*='is_hierarchy_']" 
).prop('checked')) {
+   containerElement.find( "input[name*='allowed_values_']" 
).hide('medium');
+   containerElement.find( "textarea[name*='hierarchy_structure_']" 
).show('medium');
+   } else {
+   containerElement.find( "textarea[name*='hierarchy_structure_']" 
).hide('medium');
+   containerElement.find( "input[name*='allowed_values_']" 
).show('medium');
}
 }
 
@@ -43,4 +58,7 @@
jQuery( ".createClassAddRow" ).click( function () {
createClassAddRow();
} );
+   jQuery( ".isHierarchy" ).click( function () {
+   toggleHierarchyInput(jQuery( this ).closest( "td" ));
+   } );
 } );
diff --git a/specials/PF_CreateClass.php b/specials/PF_CreateClass.php
index 65130a9..e3e6f6c 100644
--- a/specials/PF_CreateClass.php
+++ b/specials/PF_CreateClass.php
@@ -59,6 +59,7 @@
$property_type = $req->getVal( "property_type_$i" );
$allowed_values = $req->getVal( "allowed_values_$i" );
$is_list = $req->getCheck( "is_list_$i" );
+   $is_hierarchy = $req->getCheck( "is_hierarchy_$i" );
// Create an PFTemplateField object based on these
// values, and add it to the $fields array.
$field = PFTemplateField::create( $field_name, 
$field_name, $property_name, $is_list );
@@ -67,7 +68,11 @@
// Hopefully it's safe to use a Cargo
// utility method here.
$possibleValues = CargoUtils::smartSplit( ',', 
$allowed_values );
-   $field->setPossibleValues( $possibleValues );
+   if ( $is_hierarchy ) {
+   $field->setHierarchyStructure( 
$req->getVal( 'hierarchy_structure_' . $i ) );
+   } else {
+   $field->setPossibleValues( 
$possibleValues );
+   }
if ( $use_cargo ) {
$field->setFieldType( $property_type );
$field->setPossibleValues( 
$possibleValues );
@@ -362,10 +367,17 @@
}
$text .= "\t\t\t\t" . Html::rawElement( 
'select', array( 'name' => "property_type_$n" ), $typeDropdownBody ) . "\n";
}
+   $isHierarchyLabel = wfMessage( 
'pf_createtemplate_fieldishierarchy' )->escaped();
+   $hierarchyStructurePlaceholder = wfMessage( 
'pf_createtemplate_hierarchystructureplaceholder' )->escaped();
$text .= <<
-   
-
+   
+   
+   
+   
+   
+   $isHierarchyLabel
+   
 END;
}
$text .= <

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Replace Linker::link() with LinkRenderer in special pages

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/359688 )

Change subject: Replace Linker::link() with LinkRenderer in special pages
..


Replace Linker::link() with LinkRenderer in special pages

Bug: T149346
Change-Id: Ib4bf6bd1e585a671a77658d1b9a51a1f59a5a350
---
M frontend/specialpages/actions/RevisionReview_body.php
M frontend/specialpages/reports/ConfiguredPages_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/ReviewedPages_body.php
M frontend/specialpages/reports/ReviewedVersions_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M frontend/specialpages/reports/ValidationStatistics_body.php
9 files changed, 52 insertions(+), 37 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/frontend/specialpages/actions/RevisionReview_body.php 
b/frontend/specialpages/actions/RevisionReview_body.php
index 974a95b..6fc5917 100644
--- a/frontend/specialpages/actions/RevisionReview_body.php
+++ b/frontend/specialpages/actions/RevisionReview_body.php
@@ -182,11 +182,12 @@
}
 
protected function getSpecialLinks() {
+   $linkRenderer = $this->getLinkRenderer();
$s = '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'UnreviewedPages' ) )
+   $linkRenderer->makeKnownLink( SpecialPage::getTitleFor( 
'UnreviewedPages' ) )
)->escaped() . '';
$s .= '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'PendingChanges' ) )
+   $linkRenderer->makeKnownLink( SpecialPage::getTitleFor( 
'PendingChanges' ) )
)->escaped() . '';
return $s;
}
diff --git a/frontend/specialpages/reports/ConfiguredPages_body.php 
b/frontend/specialpages/reports/ConfiguredPages_body.php
index b62561a..89f9849 100644
--- a/frontend/specialpages/reports/ConfiguredPages_body.php
+++ b/frontend/specialpages/reports/ConfiguredPages_body.php
@@ -71,11 +71,12 @@
public function formatRow( $row ) {
$title = Title::newFromRow( $row );
# Link to page
-   $link = Linker::link( $title );
+   $linkRenderer = $this->getLinkRenderer();
+   $link = $linkRenderer->makeLink( $title );
# Link to page configuration
-   $config = Linker::linkKnown(
+   $config = $linkRenderer->makeKnownLink(
SpecialPage::getTitleFor( 'Stabilization' ),
-   $this->msg( 'configuredpages-config' )->escaped(),
+   $this->msg( 'configuredpages-config' )->text(),
[],
'page=' . $title->getPrefixedUrl()
);
diff --git a/frontend/specialpages/reports/PendingChanges_body.php 
b/frontend/specialpages/reports/PendingChanges_body.php
index efff67d..f621f89 100644
--- a/frontend/specialpages/reports/PendingChanges_body.php
+++ b/frontend/specialpages/reports/PendingChanges_body.php
@@ -225,14 +225,17 @@
$title = Title::newFromRow( $row );
$stxt = ChangesList::showCharacterDifference( $row->rev_len, 
$row->page_len );
# Page links...
-   $link = Linker::link( $title );
-   $hist = Linker::linkKnown( $title,
-   $this->msg( 'hist' )->escaped(),
+   $linkRenderer = $this->getLinkRenderer();
+   $link = $linkRenderer->makeLink( $title );
+   $hist = $linkRenderer->makeKnownLink(
+   $title,
+   $this->msg( 'hist' )->text(),
[],
[ 'action' => 'history' ]
);
-   $review = Linker::linkKnown( $title,
-   $this->msg( 'pendingchanges-diff' )->escaped(),
+   $review = $linkRenderer->makeKnownLink(
+   $title,
+   $this->msg( 'pendingchanges-diff' )->text(),
[],
[ 'diff' => 'cur', 'oldid' => $row->stable ] + 
FlaggedRevs::diffOnlyCGI()
);
diff --git a/frontend/specialpages/reports/ProblemChanges_body.php 
b/frontend/specialpages/reports/ProblemChanges_body.php
index d832c63..e21f270 100644
--- a/frontend/specialpages/reports/ProblemChanges_body.php
+++ b/frontend/specialpages/reports/ProblemChanges_body.php
@@ -193,9 +193,11 @@
$css = $quality = $tags = $underReview = '';
 
$title = Title::newFromRow( $row );
-   $link = Linker::link( $title );
- 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: profile: fix udev reload dependency for swift::storage::labs

[Filippo Giunchedi (Code Review)]

Filippo Giunchedi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371582 )

Change subject: profile: fix udev reload dependency for swift::storage::labs
..

profile: fix udev reload dependency for swift::storage::labs

Change-Id: Ic1308a9b8c184b0b061ff54561b8d826f678bd83
---
M modules/profile/manifests/swift/storage/labs.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/82/371582/1

diff --git a/modules/profile/manifests/swift/storage/labs.pp 
b/modules/profile/manifests/swift/storage/labs.pp
index 4fcee4f..c67d7d5 100644
--- a/modules/profile/manifests/swift/storage/labs.pp
+++ b/modules/profile/manifests/swift/storage/labs.pp
@@ -16,7 +16,7 @@
 group   => 'root',
 mode=> '0444',
 content => 'ENV{DM_LV_NAME}=="lv-a1", ENV{DM_VG_NAME}=="vd", 
SYMLINK+="swift/lv-a1"',
-notify  => Exec['swift_udev_reload'],
+notify  => Exec['swift_labs_udev_reload'],
 require => Lvm::Logical_volume['lv-a1'],
   }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1308a9b8c184b0b061ff54561b8d826f678bd83
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Disable VE integration while we're fixing it

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371580 )

Change subject: Disable VE integration while we're fixing it
..

Disable VE integration while we're fixing it

Bug: T172958
Change-Id: I2af80270306886346f6ab062c9718df3ad0d7f96
---
M extension.json
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/80/371580/1

diff --git a/extension.json b/extension.json
index 70033f3..8e1ee23 100644
--- a/extension.json
+++ b/extension.json
@@ -153,7 +153,8 @@
"CodeMirrorHooks::onGetBetaFeaturePreferences"
]
},
-   "VisualEditorPluginModules": [
+   "@comment": "Temporarily disabled while we're fixing T172958 and 
T161054",
+   "VisualEditorPluginModules_disabled": [
"ext.CodeMirror.visualEditor.init",
"ext.CodeMirror.visualEditor"
],

-- 
To view, visit https://gerrit.wikimedia.org/r/371580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2af80270306886346f6ab062c9718df3ad0d7f96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.11]: Add Timeless submodule

[Legoktm (Code Review)]

Legoktm has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371581 )

Change subject: Add Timeless submodule
..


Add Timeless submodule

Change-Id: Ia6da2a424030bccc2d42b0ac08765bea6c17f3ef
---
M .gitmodules
A skins/Timeless
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Verified; Looks good to me, approved



diff --git a/.gitmodules b/.gitmodules
index e797f6c..47b48c7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -678,3 +678,6 @@
path = vendor
url = https://gerrit.wikimedia.org/r/mediawiki/vendor
branch = wmf/1.30.0-wmf.11
+[submodule "skins/Timeless"]
+   path = skins/Timeless
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Timeless.git
diff --git a/skins/Timeless b/skins/Timeless
new file mode 16
index 000..f11212f
--- /dev/null
+++ b/skins/Timeless
@@ -0,0 +1 @@
+Subproject commit f11212f7bd75663517a3466bf0174c9a2347ada2

-- 
To view, visit https://gerrit.wikimedia.org/r/371581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6da2a424030bccc2d42b0ac08765bea6c17f3ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.11
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.11]: Add Timeless submodule

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371581 )

Change subject: Add Timeless submodule
..

Add Timeless submodule

Change-Id: Ia6da2a424030bccc2d42b0ac08765bea6c17f3ef
---
M .gitmodules
A skins/Timeless
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/81/371581/1

diff --git a/.gitmodules b/.gitmodules
index e797f6c..47b48c7 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -678,3 +678,6 @@
path = vendor
url = https://gerrit.wikimedia.org/r/mediawiki/vendor
branch = wmf/1.30.0-wmf.11
+[submodule "skins/Timeless"]
+   path = skins/Timeless
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Timeless.git
diff --git a/skins/Timeless b/skins/Timeless
new file mode 16
index 000..f11212f
--- /dev/null
+++ b/skins/Timeless
@@ -0,0 +1 @@
+Subproject commit f11212f7bd75663517a3466bf0174c9a2347ada2

-- 
To view, visit https://gerrit.wikimedia.org/r/371581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6da2a424030bccc2d42b0ac08765bea6c17f3ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.11
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: update mediawiki-codesniffer to 0.11.0 and fix issues

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371474 )

Change subject: update mediawiki-codesniffer to 0.11.0 and fix issues
..


update mediawiki-codesniffer to 0.11.0 and fix issues

- mostly auto fixes
- some too long lines fixed
- ignore amp space in one case  passing by reference

Change-Id: I6472f83bc3cbf4bd629d83050cc3319b19ec465c
---
M composer.json
M includes/Block.php
M includes/DefaultSettings.php
M includes/EditPage.php
M includes/MovePage.php
M includes/RevisionList.php
M includes/Sanitizer.php
M includes/api/ApiCSPReport.php
M includes/api/ApiQueryImageInfo.php
M includes/api/ApiQueryWatchlist.php
M includes/api/SearchApi.php
M includes/changes/ChangesListFilterGroup.php
M includes/changes/OldChangesList.php
M includes/filebackend/filejournal/DBFileJournal.php
M includes/installer/Installer.php
M includes/libs/composer/ComposerInstalled.php
M includes/libs/composer/ComposerLock.php
M includes/parser/Parser.php
M includes/parser/ParserOptions.php
M includes/parser/Preprocessor_DOM.php
M includes/parser/Preprocessor_Hash.php
M includes/profiler/SectionProfiler.php
M includes/search/SearchEngine.php
M includes/search/SearchSqlite.php
M includes/site/Site.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/SpecialExport.php
M includes/specials/SpecialMediaStatistics.php
M includes/specials/SpecialRevisiondelete.php
M includes/specials/SpecialWatchlist.php
M includes/specials/helpers/LoginHelper.php
M includes/specials/pagers/UsersPager.php
M includes/tidy/Balancer.php
M includes/widget/search/InterwikiSearchResultSetWidget.php
M includes/widget/search/InterwikiSearchResultWidget.php
M languages/Language.php
M languages/classes/LanguageKk.php
M languages/classes/LanguageSr.php
M languages/messages/MessagesKm.php
M maintenance/hhvm/makeRepo.php
M maintenance/refreshLinks.php
M tests/phpunit/MediaWikiTestCase.php
M tests/phpunit/includes/changes/ChangesListFilterTest.php
M tests/phpunit/includes/config/EtcdConfigTest.php
M tests/phpunit/includes/interwiki/ClassicInterwikiLookupTest.php
M tests/phpunit/mocks/media/MockOggHandler.php
M tests/qunit/data/load.mock.php
47 files changed, 86 insertions(+), 81 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/composer.json b/composer.json
index bc48360..32933e6 100644
--- a/composer.json
+++ b/composer.json
@@ -53,7 +53,7 @@
"jakub-onderka/php-parallel-lint": "0.9.2",
"jetbrains/phpstorm-stubs": 
"dev-master#1b9906084d6635456fcf3f3a01f0d7d5b99a578a",
"justinrainbow/json-schema": "~5.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"monolog/monolog": "~1.22.1",
"nikic/php-parser": "2.1.0",
"nmred/kafka-php": "0.1.5",
diff --git a/includes/Block.php b/includes/Block.php
index 8fc2686..843ea54 100644
--- a/includes/Block.php
+++ b/includes/Block.php
@@ -1501,7 +1501,7 @@
return $id;
}
$hmac = MWCryptHash::hmac( $id, $secretKey, false );
-   $cookieValue =  $id . '!' . $hmac;
+   $cookieValue = $id . '!' . $hmac;
return $cookieValue;
}
 
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index a28aa5b..ba755fa 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -5797,7 +5797,7 @@
// Long term limit. We need to balance the risk
// of somebody using this as a DoS attack to lock someone
// out of their account, and someone doing a brute force attack.
-   [ 'count' => 150, 'seconds' => 60*60*48 ],
+   [ 'count' => 150, 'seconds' => 60 * 60 * 48 ],
 ];
 
 /**
diff --git a/includes/EditPage.php b/includes/EditPage.php
index cc27e88..49341c5 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -4333,7 +4333,7 @@
$newPage = !$this->mTitle->exists();
 
if ( $labelAsPublish ) {
-   $buttonLabelKey =  $newPage ? 'publishpage' : 
'publishchanges';
+   $buttonLabelKey = $newPage ? 'publishpage' : 
'publishchanges';
} else {
$buttonLabelKey = $newPage ? 'savearticle' : 
'savechanges';
}
diff --git a/includes/MovePage.php b/includes/MovePage.php
index 8d0c33dc..39dc642 100644
--- a/includes/MovePage.php
+++ b/includes/MovePage.php
@@ -511,7 +511,7 @@
$logEntry->setComment( $reason );
$logEntry->setParameters( [
'4::target' => $nt->getPrefixedText(),
-   '5::noredir' => $redirectContent ? '0': '1',
+   '5::noredir' => $redirectContent ? '0' : '1',
] );
 
$formatter = LogFo

[MediaWiki-commits] [Gerrit] operations/puppet[production]: hieradata: create pagecompilation account

[Filippo Giunchedi (Code Review)]

Filippo Giunchedi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371579 )

Change subject: hieradata: create pagecompilation account
..

hieradata: create pagecompilation account

Bug: T172123
Change-Id: I7d95f14c52102ceb0d5882b64810db375477b5dc
---
M hieradata/codfw/swift/params.yaml
M hieradata/eqiad/swift/params.yaml
2 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/371579/1

diff --git a/hieradata/codfw/swift/params.yaml 
b/hieradata/codfw/swift/params.yaml
index ebfe8b7..e9df3e4 100644
--- a/hieradata/codfw/swift/params.yaml
+++ b/hieradata/codfw/swift/params.yaml
@@ -32,6 +32,11 @@
 account_name: 'AUTH_docker'
 auth: 'http://swift.svc.codfw.wmnet'
 user: 'docker:registry'
+pagecompilation:
+access:   '.admin'
+account_name: 'AUTH_pagecompilation'
+auth: 'http://swift.svc.codfw.wmnet'
+user: 'pagecompilation:zim'
 # keys are to be defined in private repo, e.g.:
 #swift::params::account_keys:
 #super_admin: 
diff --git a/hieradata/eqiad/swift/params.yaml 
b/hieradata/eqiad/swift/params.yaml
index 1848e69..f49a538 100644
--- a/hieradata/eqiad/swift/params.yaml
+++ b/hieradata/eqiad/swift/params.yaml
@@ -32,6 +32,11 @@
 account_name: 'AUTH_docker'
 auth: 'http://swift.svc.eqiad.wmnet'
 user: 'docker:registry'
+pagecompilation:
+access:   '.admin'
+account_name: 'AUTH_pagecompilation'
+auth: 'http://swift.svc.eqiad.wmnet'
+user: 'pagecompilation:zim'
 # keys are to be defined in private repo, e.g.:
 #swift::params::account_keys:
 #super_admin: 

-- 
To view, visit https://gerrit.wikimedia.org/r/371579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d95f14c52102ceb0d5882b64810db375477b5dc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix: No comma escaping for hierarchy structure input

[Fz-29 (Code Review)]

Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371574 )

Change subject: Fix: No comma escaping for hierarchy structure input
..

Fix: No comma escaping for hierarchy structure input

Change-Id: Ifbaaade0706ad5a6a008502ade782fcc6db58b50
---
M CargoFieldDescription.php
1 file changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/74/371574/1

diff --git a/CargoFieldDescription.php b/CargoFieldDescription.php
index 6c78859..23b0646 100644
--- a/CargoFieldDescription.php
+++ b/CargoFieldDescription.php
@@ -69,13 +69,13 @@
// already used to separate
// "extra parameters", so just
// hardcode it to a semicolon.
+   $allowedValuesArray = array();
if( 
$fieldDescription->mIsHierarchy == true ) {
// $paramValue contains 
"*" hierarchy structure

$fieldDescription->mHierarchyStructure = trim( $paramValue );
// now make the allowed 
values param similar to the syntax
// used by other fields
$hierarchyNodesArray = 
explode( "\n", $paramValue );
-   $allowedValuesArray = 
array();
foreach ( 
$hierarchyNodesArray as $node ) {
// Remove 
prefix of multiple "*"

$allowedValuesArray[] = preg_replace( '/^[*]*/', '', $node );
@@ -83,14 +83,15 @@
} else {
$delimiter = ',';
$allowedValuesStr = 
str_replace( "\\$delimiter", "\a", $paramValue );
-   $allowedValuesArray = 
explode( $delimiter, $allowedValuesStr );
+   $allowedValuesTempArray 
= explode( $delimiter, $allowedValuesStr );
+   foreach ( 
$allowedValuesTempArray as $i => $value ) {
+   if ( $value == 
'' ) continue;
+   // Replace beep 
back with delimiter, trim.
+   $value = 
str_replace( "\a", $delimiter, trim( $value ) );
+   
$allowedValuesArray[] = $value;
+   }
}
-   foreach ( $allowedValuesArray 
as $i => $value ) {
-   if ( $value == '' ) 
continue;
-   // Replace beep back 
with delimiter, trim.
-   $value = str_replace( 
"\a", $delimiter, trim( $value ) );
-   
$fieldDescription->mAllowedValues[] = $value;
-   }
+   
$fieldDescription->mAllowedValues = $allowedValuesArray;
} elseif ( $paramKey == 'size' ) {
$fieldDescription->mSize = 
$paramValue;
} else {

-- 
To view, visit https://gerrit.wikimedia.org/r/371574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbaaade0706ad5a6a008502ade782fcc6db58b50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...pybal[master]: Add metric pybal_service_depool_threshold

[Ema (Code Review)]

Ema has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371185 )

Change subject: Add metric pybal_service_depool_threshold
..


Add metric pybal_service_depool_threshold

Reports the depool_threshold from pybal.conf, useful for plotting
against pooled & total servers.

Bug: T171710
Change-Id: Ia3d712002d11cc8e9096ee49814bd53b4a9547df
---
M pybal/coordinator.py
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Ema: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pybal/coordinator.py b/pybal/coordinator.py
index 22ce835..a526b5b 100755
--- a/pybal/coordinator.py
+++ b/pybal/coordinator.py
@@ -316,6 +316,10 @@
 'could_not_depool_total',
 'Pybal could not depool a server because too many down',
 **metric_keywords),
+'depool_threshold': Gauge(
+'depool_threshold',
+"Threshold of up servers vs total servers below which pybal can't 
depool any more",
+**metric_keywords),
 }
 
 def __init__(self, lvsservice, configUrl):
@@ -333,6 +337,10 @@
 self.configObserver = config.ConfigurationObserver.fromUrl(self, 
configUrl)
 self.configObserver.startObserving()
 
+self.metrics['depool_threshold'].labels(
+**self.metric_labels
+).set(self.lvsservice.getDepoolThreshold())
+
 def __str__(self):
 return "[%s]" % self.lvsservice.name
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3d712002d11cc8e9096ee49814bd53b4a9547df
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Mark Bergsma 
Gerrit-Reviewer: Ema 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add Timeless skin to test and mediawiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371519 )

Change subject: Add Timeless skin to test and mediawiki
..


Add Timeless skin to test and mediawiki

Bug: T154371
Change-Id: Id4d5a831185420391aa0f8092271dd5c866296ef
---
M wmf-config/CommonSettings.php
M wmf-config/InitialiseSettings.php
M wmf-config/extension-list
M wmf-config/extension-list-labs
4 files changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 77593a9..bc395ae 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -650,6 +650,10 @@
 
 wfLoadSkins( [ 'Vector', 'MonoBook', 'Modern', 'CologneBlue' ] );
 
+if ( $wmgUseTimeless ) {
+   wfLoadSkin( 'Timeless' ); // T154371
+}
+
 // Grants and rights
 // Note these have to be visible on all wikis, not just the ones the
 // extension is enabled on, for proper display in OAuth pages and such.
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 0fab1d3..2fd0ca6 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19399,6 +19399,13 @@
'default' => true,
 ],
 
+'wmgUseTimeless' => [
+   'default' => false,
+   'testwiki' => true,
+   'test2wiki' => true,
+   'mediawikiwiki' => true,
+],
+
 ];
 
 ### WMF Labs override #
diff --git a/wmf-config/extension-list b/wmf-config/extension-list
index 5c4d8d9..db80964 100644
--- a/wmf-config/extension-list
+++ b/wmf-config/extension-list
@@ -161,4 +161,5 @@
 $IP/skins/Modern/skin.json
 $IP/skins/MonoBook/skin.json
 $IP/skins/Nostalgia/skin.json
+$IP/skins/Timeless/skin.json
 $IP/skins/Vector/skin.json
diff --git a/wmf-config/extension-list-labs b/wmf-config/extension-list-labs
index 719b842..c8c747b 100644
--- a/wmf-config/extension-list-labs
+++ b/wmf-config/extension-list-labs
@@ -3,4 +3,3 @@
 $IP/extensions/CodeMirror/extension.json
 $IP/extensions/PerformanceInspector/extension.json
 $IP/extensions/Sentry/extension.json
-$IP/skins/Timeless/skin.json

-- 
To view, visit https://gerrit.wikimedia.org/r/371519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4d5a831185420391aa0f8092271dd5c866296ef
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.13]: Add Timeless skin submodule

[Legoktm (Code Review)]

Legoktm has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371552 )

Change subject: Add Timeless skin submodule
..


Add Timeless skin submodule

Change-Id: I225040c7aece3b682bd0e79065f6d52f80d8a678
---
M .gitmodules
A skins/Timeless
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Verified; Looks good to me, approved



diff --git a/.gitmodules b/.gitmodules
index 8bcad49..ca97979 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -678,3 +678,6 @@
path = vendor
url = https://gerrit.wikimedia.org/r/mediawiki/vendor
branch = wmf/1.30.0-wmf.13
+[submodule "skins/Timeless"]
+   path = skins/Timeless
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Timeless.git
diff --git a/skins/Timeless b/skins/Timeless
new file mode 16
index 000..f11212f
--- /dev/null
+++ b/skins/Timeless
@@ -0,0 +1 @@
+Subproject commit f11212f7bd75663517a3466bf0174c9a2347ada2

-- 
To view, visit https://gerrit.wikimedia.org/r/371552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I225040c7aece3b682bd0e79065f6d52f80d8a678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.13
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Merge old internal list into new document

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371515 )

Change subject: VisualDiff: Merge old internal list into new document
..


VisualDiff: Merge old internal list into new document

The new document needs to know about removed references.

Bug: T173100
Change-Id: I8a11d2d558236939fcb2e7c9fc018e3b93c8240e
---
M src/dm/ve.dm.Document.js
M src/dm/ve.dm.VisualDiff.js
M src/ui/elements/ve.ui.DiffElement.js
3 files changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 7c38cf4..6087c9b 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -656,16 +656,17 @@
  * will be clones of the ones in this document.
  *
  * @param {ve.Range} [range] Range of data to clone, clones the whole document 
if ommitted.
+ * @param {boolean} [detachedCopy] The copy is not intended to be merged into 
the original
  * @return {ve.dm.Document} New document
  */
-ve.dm.Document.prototype.cloneFromRange = function ( range ) {
+ve.dm.Document.prototype.cloneFromRange = function ( range, detachedCopy ) {
var listRange = this.getInternalList().getListNode().getOuterRange(),
data = ve.copy( this.getFullData( range, true ) );
if ( range && ( range.start > listRange.start || range.end < 
listRange.end ) ) {
// The range does not include the entire internal list, so add 
it
data = data.concat( this.getFullData( listRange ) );
}
-   return this.cloneWithData( data, true );
+   return this.cloneWithData( data, true, detachedCopy );
 };
 
 /**
@@ -675,9 +676,10 @@
  * @param {Array|ve.dm.ElementLinearData|ve.dm.FlatLinearData} data Raw linear 
model data,
  *  ElementLinearData or FlatLinearData
  * @param {boolean} [copyInternalList] Copy the internal list
+ * @param {boolean} [detachedCopy] The copy is not intended to be merged into 
the original
  * @return {ve.dm.Document} New document
  */
-ve.dm.Document.prototype.cloneWithData = function ( data, copyInternalList ) {
+ve.dm.Document.prototype.cloneWithData = function ( data, copyInternalList, 
detachedCopy ) {
var newDoc;
 
if ( Array.isArray( data ) ) {
@@ -697,7 +699,7 @@
// lang+dir
this.getLang(), this.getDir()
);
-   if ( copyInternalList ) {
+   if ( copyInternalList && !detachedCopy ) {
// Record the length of the internal list at the time the slice 
was created so we can
// reconcile additions properly
newDoc.origDoc = this;
diff --git a/src/dm/ve.dm.VisualDiff.js b/src/dm/ve.dm.VisualDiff.js
index a2c006e..5248160 100644
--- a/src/dm/ve.dm.VisualDiff.js
+++ b/src/dm/ve.dm.VisualDiff.js
@@ -18,8 +18,8 @@
  * @param {Number} [timeout=1000] Timeout after which to stop performing 
linear diffs (in ms)
  */
 ve.dm.VisualDiff = function VeDmVisualDiff( oldDoc, newDoc, timeout ) {
-   this.oldDoc = oldDoc.cloneFromRange();
-   this.newDoc = newDoc.cloneFromRange();
+   this.oldDoc = oldDoc.cloneFromRange( undefined, true );
+   this.newDoc = newDoc.cloneFromRange( undefined, true );
this.oldDocNode = this.oldDoc.getDocumentNode();
this.newDocNode = this.newDoc.getDocumentNode();
this.oldDocChildren = this.getDocChildren( this.oldDocNode );
diff --git a/src/ui/elements/ve.ui.DiffElement.js 
b/src/ui/elements/ve.ui.DiffElement.js
index e52a4c1..3a877e7 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -16,7 +16,7 @@
  * @param {Object} [config]
  */
 ve.ui.DiffElement = function VeUiDiffElement( visualDiff, config ) {
-   var diff = visualDiff.diff;
+   var tx, diff = visualDiff.diff;
 
// Parent constructor
ve.ui.DiffElement.super.call( this, config );
@@ -29,6 +29,11 @@
this.oldDocChildren = visualDiff.oldDocChildren;
this.newDocChildren = visualDiff.newDocChildren;
 
+   // Merge the old internal list into the new document, so that it knows
+   // about removed references
+   tx = ve.dm.TransactionBuilder.static.newFromDocumentInsertion( 
this.newDoc, 0, this.oldDoc, new ve.Range( 0 ) );
+   this.newDoc.commit( tx );
+
// Internal list
this.newDocInternalListNode = visualDiff.newDocInternalListNode;
this.oldDocInternalListNode = visualDiff.oldDocInternalListNode;

-- 
To view, visit https://gerrit.wikimedia.org/r/371515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a11d2d558236939fcb2e7c9fc018e3b93c8240e
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing @param and @return documentation

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371558 )

Change subject: Add missing @param and @return documentation
..

Add missing @param and @return documentation

Change-Id: I1d1098eec3933df6561cceef646576013ddc08c8
---
M includes/AuthPlugin.php
M includes/FauxRequest.php
M includes/Linker.php
M includes/OutputPage.php
M includes/Preferences.php
M includes/Title.php
M includes/changes/RecentChange.php
M includes/changetags/ChangeTags.php
M includes/export/WikiExporter.php
M includes/libs/filebackend/SwiftFileBackend.php
M includes/media/MediaHandler.php
M includes/media/WebP.php
M includes/search/SearchEngine.php
M includes/search/SearchHighlighter.php
M includes/session/Token.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/SpecialMediaStatistics.php
M includes/upload/UploadBase.php
M phpcs.xml
19 files changed, 45 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/371558/1

diff --git a/includes/AuthPlugin.php b/includes/AuthPlugin.php
index 24ae856..b73ecbd 100644
--- a/includes/AuthPlugin.php
+++ b/includes/AuthPlugin.php
@@ -359,6 +359,7 @@
 
/**
 * @deprecated since 1.28, use 
SessionManager::invalidateSessionForUser() instead.
+* @return bool
 */
public function resetAuthToken() {
# Override this!
diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 9147240..2f7f75b 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -152,6 +152,7 @@
 
/**
 * @since 1.25
+* @param string $url
 */
public function setRequestURL( $url ) {
$this->requestUrl = $url;
@@ -160,6 +161,7 @@
/**
 * @since 1.25 MWException( "getRequestURL not implemented" )
 * no longer thrown.
+* @return string
 */
public function getRequestURL() {
if ( $this->requestUrl === null ) {
diff --git a/includes/Linker.php b/includes/Linker.php
index 34cc49a..d55f0e0 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -154,6 +154,11 @@
 * @since 1.16.3
 * @deprecated since 1.28, use MediaWiki\Linker\LinkRenderer instead
 * @see Linker::link
+* @param Title $target
+* @param string $html
+* @param array $customAttribs
+* @param array $query
+* @param string|array $options
 * @return string
 */
public static function linkKnown(
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index fd002d1..2a3a7cd 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -571,6 +571,7 @@
 * @param bool $filter Whether to filter out insufficiently trustworthy 
modules
 * @param string|null $position If not null, only return modules with 
this position
 * @param string $param
+* @param string $type
 * @return array Array of module names
 */
public function getModules( $filter = false, $position = null, $param = 
'mModules',
diff --git a/includes/Preferences.php b/includes/Preferences.php
index 48eaaf2..039d99c 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1122,6 +1122,9 @@
 
/**
 * Dummy, kept for backwards-compatibility.
+* @param User $user
+* @param IContextSource $context
+* @param array &$defaultPreferences
 */
static function miscPreferences( $user, IContextSource $context, 
&$defaultPreferences ) {
}
diff --git a/includes/Title.php b/includes/Title.php
index 1fd1073..05f85fa 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -1896,6 +1896,8 @@
 * protocol-relative, the URL will be expanded to http://
 *
 * @see self::getLocalURL for the arguments.
+* @param string $query
+* @param string|bool $query2
 * @return string The URL
 */
public function getInternalURL( $query = '', $query2 = false ) {
diff --git a/includes/changes/RecentChange.php 
b/includes/changes/RecentChange.php
index 64c..f123363 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -426,6 +426,7 @@
 * @since 1.22
 * @deprecated since 1.29 Use RCFeed::factory() instead
 * @param string $uri URI to get the engine object for
+* @param array $params
 * @return RCFeedEngine The engine object
 * @throws MWException
 */
diff --git a/includes/changetags/ChangeTags.php 
b/includes/changetags/ChangeTags.php
index 608e7bb..fa98124 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -1328,6 +1328,7 @@
 *
 * @see listSoftwareDefinedTags
 * @deprecated since 1.28
+* @return array
 */
public st

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing type to @param documentation

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371557 )

Change subject: Add missing type to @param documentation
..

Add missing type to @param documentation

Change-Id: I6b2c9c7af9a281fe457099cc3a336a60a25e74aa
---
M includes/OutputPage.php
M includes/PHPVersionCheck.php
M includes/api/ApiCSPReport.php
M includes/collation/NumericUppercaseCollation.php
M includes/content/JsonContent.php
M includes/content/TextContent.php
M includes/installer/SqliteInstaller.php
M includes/libs/IEUrlExtension.php
M includes/libs/mime/IEContentAnalyzer.php
M includes/libs/mime/XmlTypeCheck.php
M includes/libs/rdbms/TransactionProfiler.php
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/encasing/Blob.php
M includes/media/MediaHandler.php
M includes/media/WebP.php
M includes/page/ImagePage.php
M includes/search/NullIndexField.php
M includes/search/SearchIndexField.php
M includes/search/SearchIndexFieldDefinition.php
M includes/site/SiteImporter.php
M includes/specialpage/AuthManagerSpecialPage.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/pagers/ProtectedPagesPager.php
M languages/Language.php
M languages/classes/LanguageEn.php
M tests/parser/ParserTestRunner.php
M tests/phpunit/includes/WatchedItemQueryServiceUnitTest.php
M tests/phpunit/includes/WatchedItemStoreUnitTest.php
M tests/phpunit/includes/content/WikitextStructureTest.php
M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
M tests/phpunit/includes/search/SearchIndexFieldTest.php
31 files changed, 86 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/57/371557/1

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 8f62a85..fd002d1 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1963,7 +1963,7 @@
}
 
/**
-* @param $maxage
+* @param int $maxage
 * @deprecated since 1.27 Use setCdnMaxage() instead
 */
public function setSquidMaxage( $maxage ) {
diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index c8872d2..cd5bf54 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -231,9 +231,9 @@
/**
 * Returns an error page, which is suitable for output to the end user 
via a web browser.
 *
-* @param $title
-* @param $longHtml
-* @param $shortText
+* @param string $title
+* @param string $longHtml
+* @param string $shortText
 * @return string
 */
function getIndexErrorOutput( $title, $longHtml, $shortText ) {
diff --git a/includes/api/ApiCSPReport.php b/includes/api/ApiCSPReport.php
index 3a78c13..a4a46bb 100644
--- a/includes/api/ApiCSPReport.php
+++ b/includes/api/ApiCSPReport.php
@@ -63,9 +63,9 @@
 
/**
 * Log CSP report, with a different severity depending on $flags
-* @param $flags Array Flags for this report
-* @param $logLine String text of log entry
-* @param $context Array logging context
+* @param array $flags Flags for this report
+* @param string $logLine text of log entry
+* @param array $context logging context
 */
private function logReport( $flags, $logLine, $context ) {
if ( in_array( 'false-positive', $flags ) ) {
@@ -80,8 +80,8 @@
/**
 * Get extra notes about the report.
 *
-* @param $report Array The CSP report
-* @return Array
+* @param array $report The CSP report
+* @return array
 */
private function getFlags( $report ) {
$reportOnly = $this->getParameter( 'reportonly' );
@@ -155,9 +155,9 @@
/**
 * Get text of log line.
 *
-* @param $flags Array of additional markers for this report
-* @param $report Array the csp report
-* @return String Text to put in log
+* @param array $flags of additional markers for this report
+* @param array $report the csp report
+* @return string Text to put in log
 */
private function generateLogLine( $flags, $report ) {
$flagText = '';
@@ -177,8 +177,8 @@
/**
 * Stop processing the request, and output/log an error
 *
-* @param $code String error code
-* @param $method String method that made error
+* @param string $code error code
+* @param string $method method that made error
 * @throws ApiUsageException Always
 */
private function error( $code, $method ) {
diff --git a/includes/collation/NumericUppercaseCollation.php 
b/includes/collation/NumericUppercaseCollation.php
index 8dd7a38..da78a05 100644
--- a/includes/collation/NumericUppercaseCollation.php
+++ b/includes/collation/NumericUppercaseCollation.php
@@

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2017-08-11T19:48:03+0000

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371547 )

Change subject: New Wikidata Build - 2017-08-11T19:48:03+
..


New Wikidata Build - 2017-08-11T19:48:03+

Change-Id: I225415a6574592bf3f32d7994b94767970db7312
---
M composer.lock
M extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
M vendor/composer/installed.json
3 files changed, 9 insertions(+), 8 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.lock b/composer.lock
index 4fed1ac..b366fea 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1547,12 +1547,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0"
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/b5f8f115e7de452020c9876f404f7a5c895c55c0";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ad9c8a8671f0a5436dfc2405e56705b947a4a925";,
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925",
 "shasum": ""
 },
 "require": {
@@ -1629,7 +1629,7 @@
 "wikibaserepo",
 "wikidata"
 ],
-"time": "2017-08-10 21:18:44"
+"time": "2017-08-10 23:08:05"
 },
 {
 "name": "wikibase/wikimedia-badges",
diff --git 
a/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php 
b/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
index 03cdba7..344c11f 100644
--- 
a/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
+++ 
b/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
@@ -46,6 +46,7 @@
$this->tablesUsed[] = 'page';
$this->tablesUsed[] = 'redirect';
$this->tablesUsed[] = 'revision';
+   $this->tablesUsed[] = 'ip_changes';
 
$termRows = [];
$infoRows = [];
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index 41155a5..f46b41b 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1387,12 +1387,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0"
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/b5f8f115e7de452020c9876f404f7a5c895c55c0";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ad9c8a8671f0a5436dfc2405e56705b947a4a925";,
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925",
 "shasum": ""
 },
 "require": {
@@ -1426,7 +1426,7 @@
 "jakub-onderka/php-parallel-lint": ">=0.3 <0.10",
 "wikibase/wikibase-codesniffer": "^0.1.0"
 },
-"time": "2017-08-10 21:18:44",
+"time": "2017-08-10 23:08:05",
 "type": "mediawiki-extension",
 "installation-source": "dist",
 "autoload": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I225415a6574592bf3f32d7994b94767970db7312
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Add skin screenshots for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371548 )

Change subject: Add skin screenshots for the installer
..


Add skin screenshots for the installer

Screenshots for all four supported width modes.

Bug: T68295
Change-Id: I29e99ed6cd123d1a7a072f91fcb808fdb7b320b8
---
A screenshots/1024x768.png
A screenshots/1280x800.png
A screenshots/1440x900.png
A screenshots/Mobile.png
4 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Isarra: Looks good to me, approved



diff --git a/screenshots/1024x768.png b/screenshots/1024x768.png
new file mode 100644
index 000..bc47e03
--- /dev/null
+++ b/screenshots/1024x768.png
Binary files differ
diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..d9a1379
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ
diff --git a/screenshots/1440x900.png b/screenshots/1440x900.png
new file mode 100644
index 000..b8402bd
--- /dev/null
+++ b/screenshots/1440x900.png
Binary files differ
diff --git a/screenshots/Mobile.png b/screenshots/Mobile.png
new file mode 100644
index 000..6706436
--- /dev/null
+++ b/screenshots/Mobile.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29e99ed6cd123d1a7a072f91fcb808fdb7b320b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Isarra 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlickrAPI[master]: Switch to extension registration system

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368129 )

Change subject: Switch to extension registration system
..


Switch to extension registration system

This moves to the new-style extension registration and removes the
old style. Also removes the Git submodule and adds that library
as a (manual) Composer dependency.

Coding standards are also updated.

Bug: T171819
Change-Id: I46d1a2dd04903b7a3207b9c4a709b80214626fc5
---
D .gitmodules
M FlickrAPI.hooks.php
D FlickrAPI.php
M FlickrAPICache.php
M FlickrAPIUtils.php
A composer.json
A extension.json
D modules/phpflickr
A phpcs.xml
9 files changed, 141 insertions(+), 99 deletions(-)

Approvals:
  Umherirrender: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  tosfos: Looks good to me, approved



diff --git a/.gitmodules b/.gitmodules
deleted file mode 100644
index 4414c1f..000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
-[submodule "modules/phpflickr"]
-   path = modules/phpflickr
-   url = https://github.com/dan-coulter/phpflickr.git
diff --git a/FlickrAPI.hooks.php b/FlickrAPI.hooks.php
index 1a8645e..c2f7332 100644
--- a/FlickrAPI.hooks.php
+++ b/FlickrAPI.hooks.php
@@ -9,11 +9,22 @@
 class FlickrAPIHooks {
 
/**
+* Hooked to ParserFirstCallInit.
+* @link https://www.mediawiki.org/wiki/Manual:Hooks/ParserFirstCallInit
+* @param Parser &$parser The parser.
+* @return bool
+*/
+   public static function onParserFirstCallInit( Parser &$parser ) {
+   $parser->setHook( 'flickr', self::class.'::flickrAPITag' );
+   return true;
+   }
+
+   /**
 * Get output for the  tag
 *
-* @param string $optionsString
-* @param array $args
-* @param Parser $parser
+* @param string $optionsString Tag content.
+* @param array $args Tag attributes.
+* @param Parser $parser The parser.
 * @return string
 */
public static function flickrAPITag( $optionsString, array $args, 
Parser $parser ) {
@@ -34,12 +45,12 @@
private static function extractOptions( $optionsString ) {
$parts = StringUtils::explode( '|', $optionsString );
 
-   $options = array( 'id' => $parts->current() );
+   $options = [ 'id' => $parts->current() ];
$parts->next();
 
$validSizes = self::getValidSizes();
-   $validTypes = array( 'thumb', 'frame', 'frameless' );
-   $validAligns = array( 'right', 'left', 'center', 'none' );
+   $validTypes = [ 'thumb', 'frame', 'frameless' ];
+   $validAligns = [ 'right', 'left', 'center', 'none' ];
# Okay now deal with parameters
/** @todo Copied from Flickr extension. Refactor. */
while ( $parts->valid() ) {
@@ -69,13 +80,13 @@
 * @return array
 */
private static function getValidSizes() {
-   return array(
+   return [
's' => 'Square',
't' => 'Thumbnail',
'm' => 'Small',
'-' => 'Medium',
'b' => 'Large',
-   );
+   ];
}
 
/**
@@ -109,7 +120,7 @@
 * @return string HTML
 */
private static function handleError( MWException $e ) {
-   return Html::element( 'strong', array( 'class' => array( 
'error', 'flickrapi-error' ) ),
+   return Html::element( 'strong', [ 'class' => [ 'error', 
'flickrapi-error' ] ],
$e->getMessage() );
}
 
@@ -151,7 +162,7 @@
$phpFlickr->enableCache( 'fs', $wgFileCacheDirectory );
} else {
$phpFlickr->enableCache( 'custom',
-   array( 'FlickrAPICache::getCache', 
'FlickrAPICache::setCache' ) );
+   [ 'FlickrAPICache::getCache', 
'FlickrAPICache::setCache' ] );
}
 
$info = $phpFlickr->photos_getInfo( $options['id'] );
@@ -164,13 +175,13 @@
 
$linkUrl = $info['photo']['urls']['url']['0']['_content'];
 
-   $frameParams = array(
+   $frameParams = [
'align' => $options['location'],
'alt' => $options['caption'],
'caption' => $options['caption'],
'title' => $options['caption'],
'link-url' => $linkUrl
-   );
+   ];
 
if ( $options['type'] == 'thumb' ) {
$frameParams['thumbnail'] = true;
@@ -179,7 +190,7 @@
}
 
$validSizes = self::getValidSizes();
-   $handlerParam

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Add Timeless

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371549 )

Change subject: make-wmf-branch: Add Timeless
..


make-wmf-branch: Add Timeless

Change-Id: I5a1365ed4469f93018bd42660f5a9ef82a9053dd
---
M make-wmf-branch/config.json
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/make-wmf-branch/config.json b/make-wmf-branch/config.json
index 2fa8ee7..50ecb4d 100644
--- a/make-wmf-branch/config.json
+++ b/make-wmf-branch/config.json
@@ -168,6 +168,7 @@
"MonoBook",
"Modern",
"Nostalgia",
+   "Timeless",
"Vector"
],
"submodules": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371549
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1365ed4469f93018bd42660f5a9ef82a9053dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.13]: Add Timeless skin submodule

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371552 )

Change subject: Add Timeless skin submodule
..

Add Timeless skin submodule

Change-Id: I225040c7aece3b682bd0e79065f6d52f80d8a678
---
M .gitmodules
A skins/Timeless
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/52/371552/1

diff --git a/.gitmodules b/.gitmodules
index 8bcad49..ca97979 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -678,3 +678,6 @@
path = vendor
url = https://gerrit.wikimedia.org/r/mediawiki/vendor
branch = wmf/1.30.0-wmf.13
+[submodule "skins/Timeless"]
+   path = skins/Timeless
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Timeless.git
diff --git a/skins/Timeless b/skins/Timeless
new file mode 16
index 000..f11212f
--- /dev/null
+++ b/skins/Timeless
@@ -0,0 +1 @@
+Subproject commit f11212f7bd75663517a3466bf0174c9a2347ada2

-- 
To view, visit https://gerrit.wikimedia.org/r/371552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I225040c7aece3b682bd0e79065f6d52f80d8a678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.30.0-wmf.13
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove '+' from i18n as it is now a proper icon

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371551 )

Change subject: Remove '+' from i18n as it is now a proper icon
..

Remove '+' from i18n as it is now a proper icon

Change-Id: I379a7b36043479be867da748623b8ce51272eca3
---
M i18n/af.json
M i18n/ar.json
M i18n/as.json
M i18n/ast.json
M i18n/ba.json
M i18n/be-tarask.json
M i18n/be.json
M i18n/bg.json
M i18n/bn.json
M i18n/br.json
M i18n/bs.json
M i18n/ca.json
M i18n/ce.json
M i18n/ckb.json
M i18n/cs.json
M i18n/cy.json
M i18n/da.json
M i18n/de.json
M i18n/diq.json
M i18n/el.json
M i18n/en.json
M i18n/eo.json
M i18n/es.json
M i18n/et.json
M i18n/eu.json
M i18n/fa.json
M i18n/fi.json
M i18n/fr.json
M i18n/fy.json
M i18n/gl.json
M i18n/gu.json
M i18n/he.json
M i18n/hi.json
M i18n/hr.json
M i18n/hsb.json
M i18n/hu.json
M i18n/hy.json
M i18n/ia.json
M i18n/id.json
M i18n/is.json
M i18n/it.json
M i18n/ja.json
M i18n/jv.json
M i18n/ka.json
M i18n/kk-cyrl.json
M i18n/km.json
M i18n/kn.json
M i18n/ko.json
M i18n/krc.json
M i18n/ksh.json
M i18n/ku-latn.json
M i18n/ky.json
M i18n/lb.json
M i18n/lt.json
M i18n/lv.json
M i18n/mg.json
M i18n/min.json
M i18n/mk.json
M i18n/ml.json
M i18n/ms.json
M i18n/nap.json
M i18n/nb.json
M i18n/nds-nl.json
M i18n/ne.json
M i18n/nl.json
M i18n/nn.json
M i18n/oc.json
M i18n/olo.json
M i18n/or.json
M i18n/pam.json
M i18n/pl.json
M i18n/ps.json
M i18n/pt-br.json
M i18n/pt.json
M i18n/qqq.json
M i18n/ro.json
M i18n/roa-tara.json
M i18n/ru.json
M i18n/sah.json
M i18n/sd.json
M i18n/sk.json
M i18n/sl.json
M i18n/sr-ec.json
M i18n/sr-el.json
M i18n/sv.json
M i18n/ta.json
M i18n/th.json
M i18n/tl.json
M i18n/tr.json
M i18n/uk.json
M i18n/ur.json
M i18n/uz.json
M i18n/vi.json
M i18n/yi.json
M i18n/yue.json
M i18n/zh-hans.json
M i18n/zh-hant.json
97 files changed, 97 insertions(+), 97 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/51/371551/1

diff --git a/i18n/af.json b/i18n/af.json
index d378c2e..37294d4 100644
--- a/i18n/af.json
+++ b/i18n/af.json
@@ -38,7 +38,7 @@
"cx-publish-gt-moved-description": "Klik hierdie skakel om jou nuwe 
vertaalde bladsy te lees en verbeter",
"cx-publish-gt-published-title": "Veels geluk, die bladsy is 
gepubliseer",
"cx-publish-gt-published-description": "Jy kan \"$1\" klik om die 
bladsy verder te verbeter. Maak seker dat dit natuurlik voorkom.",
-   "cx-translation-add-translation": "+ Voeg vertaling by",
+   "cx-translation-add-translation": "Voeg vertaling by",
"cx-translation-target-page-exists": "'n Bladsy met die titel [$1 $2] 
bestaan reeds in die teikenwiki. Oorweeg dit om 'n ander titel te kies.",
"tag-contenttranslation": 
"[[{{MediaWiki:cx-descriptionpagelink}}|Inhoudvertaling]]",
"tag-contenttranslation-description": "Die inhoud is deur die 
Inhoudsvertaling werktuig vanuit 'n ander taal vertaal.",
diff --git a/i18n/ar.json b/i18n/ar.json
index e768561..8481345 100644
--- a/i18n/ar.json
+++ b/i18n/ar.json
@@ -46,7 +46,7 @@
"cx-publish-gt-moved-description": "انقر هذه الوصلة لقراءة الصفحة 
المترجمة وتنقيحها",
"cx-publish-gt-published-title": "هنيئا، الصفحة نشرت",
"cx-publish-gt-published-description": "يمكنك نقر \"$1\" لإتمام تنقيح 
الصفحة. تأكد من سهولة قراءتها.",
-   "cx-translation-add-translation": "+ أضف ترجمة",
+   "cx-translation-add-translation": "أضف ترجمة",
"cx-translation-target-page-exists": "الويكي الهدف فيه صفحة بعنوان [$1 
$2]. اختر عنوانا مختلفا للصفحة.",
"tag-contenttranslation": "[[{{MediaWiki:cx-descriptionpagelink}}|ترجمة 
المحتوى]]",
"tag-contenttranslation-description": "جرت ترجمة المحتوى من لغة أخرى 
باستخدام أداة ترجمة المحتوى.",
diff --git a/i18n/as.json b/i18n/as.json
index d8d3077..fe5f378 100644
--- a/i18n/as.json
+++ b/i18n/as.json
@@ -24,7 +24,7 @@
"cx-publish-gt-moved-title": "অনুদিত পৃষ্ঠাটো স্থানান্তৰ কৰা হৈছে",
"cx-publish-gt-moved-description": "আপোনাৰ অনুদিত পৃষ্ঠা পঢ়িবলৈ আৰু 
সংশোধন কৰিবলৈ এই লিংকত ক্লিক কৰক",
"cx-publish-gt-published-title": "অভিনন্দন, পৃষ্ঠাটো প্ৰকাশিত হৈছে",
-   "cx-translation-add-translation": "+ অনুবাদ যোগ কৰক",
+   "cx-translation-add-translation": "অনুবাদ যোগ কৰক",
"cx-translation-target-page-exists": "লক্ষ্য ৱিকিত [$1 $2] নামৰ এটা 
পৃষ্ঠা আছেই। পৃষ্ঠাটোৰ অন্য এটা শিৰোনাম দিয়াৰ কথা বিবেচনা কৰক।",
"cx-tools-link-title": "সংযোগ",
"cx-translation-filter-all-translations": "সমূহ অনুবাদ",
diff --git a/i18n/ast.json b/i18n/ast.json
index a5f99fb..9e68233 100644
--- a/i18n/ast.json
+++ b/i18n/ast.json
@@ -35,7 +35,7 @@
"cx-publish-gt-moved-description": "Fai clic nesti enllaz pa lleer y 
ameyorar la nueva páxina recién traducida",
"cx-publish-gt-published-title": "Felicidaes, publicóse la páxina",
"cx-publish-gt-published-description": "Pues facer clic en \"$1\" pa 
siguir ameyorando

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Placeholder styling and fixes

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371550 )

Change subject: Placeholder styling and fixes
..

Placeholder styling and fixes

Change-Id: I8f3063c75111562f2e77c9a716b13b15c6694402
---
M extension.json
M modules/ui/mw.cx.ui.TranslationView.js
M modules/ui/styles/mw.cx.ui.TargetColumn.less
A modules/ve-cx/ce/styles/ve.ce.CXPlaceholderNode.css
M modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
M modules/ve-cx/ui/ve.ui.CXTranslation.js
6 files changed, 69 insertions(+), 15 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/50/371550/1

diff --git a/extension.json b/extension.json
index 93a081f..9e56bda 100644
--- a/extension.json
+++ b/extension.json
@@ -1351,6 +1351,7 @@
"ve-cx/ui/ve.ui.CXTranslation.js"
],
"styles": [
+   "ve-cx/ce/styles/ve.ce.CXPlaceholderNode.css",
"ve-cx/ui/styles/ve.ui.CXSurface.css"
],
"messages": [
diff --git a/modules/ui/mw.cx.ui.TranslationView.js 
b/modules/ui/mw.cx.ui.TranslationView.js
index 7da43f8..424ddd9 100644
--- a/modules/ui/mw.cx.ui.TranslationView.js
+++ b/modules/ui/mw.cx.ui.TranslationView.js
@@ -51,6 +51,7 @@
this.alignSectionPairs.bind( this ),
500
);
+   $( this.getElementWindow() ).on( 'resize', 
this.throttleAlignSectionPairs );
this.targetColumn.connect( this, {
titleChange: 'onTranslationTitleChange'
} );
@@ -73,12 +74,15 @@
if ( !sourceNode || !targetNode ) {
return;
}
+   sourceNode.style.marginTop = '';
+   targetNode.style.marginTop = '';
+   targetNode.style.height = '';
offsetTop = Math.max(
sourceOffsetTop + sourceNode.offsetTop,
targetOffsetTop + targetNode.offsetTop
);
-   sourceNode.style.paddingTop = ( offsetTop - sourceOffsetTop - 
sourceNode.offsetTop ) + 'px';
-   targetNode.style.paddingTop = ( offsetTop - targetOffsetTop - 
targetNode.offsetTop ) + 'px';
+   sourceNode.style.marginTop = ( offsetTop - sourceOffsetTop - 
sourceNode.offsetTop ) + 'px';
+   targetNode.style.marginTop = ( offsetTop - targetOffsetTop - 
targetNode.offsetTop ) + 'px';
if ( isSubclass( $.data( targetNode, 'view' ), ve.ce.CXPlaceholderNode 
) ) {
if ( sourceNode.offsetHeight > targetNode.offsetHeight ) {
targetNode.style.height = sourceNode.offsetHeight + 
'px';
@@ -88,6 +92,13 @@
 
 /* Methods */
 
+mw.cx.ui.TranslationView.prototype.unbindHandlers = function () {
+   // Parent method
+   mw.cx.ui.TranslationView.super.prototype.unbindHandlers.call( this );
+
+   $( this.getElementWindow() ).off( 'resize', 
this.throttleAlignSectionPairs );
+};
+
 mw.cx.ui.TranslationView.prototype.onSurfaceMouseOver = function ( ev ) {
var fromSegmentId = $( ev.relatedTarget ).closest( '.cx-segment' 
).data( 'segmentid' ),
toSegmentId = $( ev.toElement ).closest( '.cx-segment' ).data( 
'segmentid' );
diff --git a/modules/ui/styles/mw.cx.ui.TargetColumn.less 
b/modules/ui/styles/mw.cx.ui.TargetColumn.less
index c3ba4d2..a94b3c0 100644
--- a/modules/ui/styles/mw.cx.ui.TargetColumn.less
+++ b/modules/ui/styles/mw.cx.ui.TargetColumn.less
@@ -2,10 +2,6 @@
 @import '../../widgets/common/ext.cx.highlight.less';
 
 .cx-column--translation {
-   [contenteditable] {
-   outline: 0;
-   }
-
.cx-column-target-title {
padding: 0;
padding-top: 0.5em;
diff --git a/modules/ve-cx/ce/styles/ve.ce.CXPlaceholderNode.css 
b/modules/ve-cx/ce/styles/ve.ce.CXPlaceholderNode.css
new file mode 100644
index 000..7b401ec
--- /dev/null
+++ b/modules/ve-cx/ce/styles/ve.ce.CXPlaceholderNode.css
@@ -0,0 +1,27 @@
+/* Copied from ve-ce-branchNode-blockSlug */
+.ve-ce-cxPlaceholderNode {
+   opacity: 0;
+   cursor: pointer;
+   -webkit-transition: opacity 200ms ease-out;
+   -moz-transition: opacity 200ms ease-out;
+   transition: opacity 200ms ease-out;
+
+   outline: 1px dashed #ccc;
+   /* rgba( #f1f7fb, 0.5 ) */
+   background-color: rgba( 241, 247, 251, 0.75 );
+}
+
+.ve-ce-cxPlaceholderNode:hover,
+.ve-ce-cxPlaceholderNode.ve-ce-focusableNode-focused {
+   opacity: 1;
+}
+
+.ve-ce-cxPlaceholderNode > .oo-ui-buttonWidget {
+   margin-left: 0.25em;
+   opacity: 0.5;
+   display: block;
+}
+
+.ve-ce-cxPlaceholderNode > .oo-ui-buttonWidget > .oo-ui-buttonElement-button {
+   display: block;
+}
diff --git a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js 
b/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
index 62be3ed..dc3c70b 100644
--- a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
+++ b/modules/ve

[MediaWiki-commits] [Gerrit] mediawiki...Nostalgia[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371539 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I3fe51a40827862429cbafe7dad7442ea5de6d007
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..26e829e
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371539
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fe51a40827862429cbafe7dad7442ea5de6d007
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nostalgia
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Nimbus[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371538 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I894b5a7bce5aed19e6f258f3fcb7dccd662e4265
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..bc7318a
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371538
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I894b5a7bce5aed19e6f258f3fcb7dccd662e4265
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nimbus
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MonoBook[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371537 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I1eb2fd5294d1aff92d3870749448047b49843857
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..96186b7
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1eb2fd5294d1aff92d3870749448047b49843857
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MonoBook
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371540 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I8fddc46db47952740f6f874264918f0ffdbef2fd
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c6f3afd
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fddc46db47952740f6f874264918f0ffdbef2fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Splash
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Tempo[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371541 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I95d3375283e07e0b0bdec4e45e53146898c51acb
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c2f2754
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95d3375283e07e0b0bdec4e45e53146898c51acb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Tempo
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Truglass[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371542 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Ib9430754185c8e52c413cc1baca3547c50f81e2a
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..60467e1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9430754185c8e52c413cc1baca3547c50f81e2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...webplatform[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371544 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Iaeccfcb69bb3bf8a9a1f0753fd2035f68ded1ff6
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c7048d2
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaeccfcb69bb3bf8a9a1f0753fd2035f68ded1ff6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/webplatform
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WPtouch[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371545 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Iccaf598199e0b58578a7d05adc7b9edfbd0b4d3f
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c974305
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccaf598199e0b58578a7d05adc7b9edfbd0b4d3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/WPtouch
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Add Timeless

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371549 )

Change subject: make-wmf-branch: Add Timeless
..

make-wmf-branch: Add Timeless

Change-Id: I5a1365ed4469f93018bd42660f5a9ef82a9053dd
---
M make-wmf-branch/config.json
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/49/371549/1

diff --git a/make-wmf-branch/config.json b/make-wmf-branch/config.json
index 2fa8ee7..50ecb4d 100644
--- a/make-wmf-branch/config.json
+++ b/make-wmf-branch/config.json
@@ -168,6 +168,7 @@
"MonoBook",
"Modern",
"Nostalgia",
+   "Timeless",
"Vector"
],
"submodules": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371549
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a1365ed4469f93018bd42660f5a9ef82a9053dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Modern[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371536 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I6ad5cf54e985c6970e21392df045e44fc3b03415
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..86b8a73
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ad5cf54e985c6970e21392df045e44fc3b03415
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371546 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I67554e951f9cc69ee2b105273aba3fe102feadfb
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..8533a12
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371546
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67554e951f9cc69ee2b105273aba3fe102feadfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/GreyStuff
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371534 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Id84169148017e3f634e46503090339e0a481a650
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..7334bfd
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id84169148017e3f634e46503090339e0a481a650
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Dusk[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371530 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I09b756f9202e7ca8cc64f4fda770332e40d0
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..3b7ef5f
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09b756f9202e7ca8cc64f4fda770332e40d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Dusk
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DeskMessMirrored[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371529 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Iba153cb5208d9bd9aa525dcd1ff9c9a1f9e4b942
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..92668c4
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371529
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba153cb5208d9bd9aa525dcd1ff9c9a1f9e4b942
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/DeskMessMirrored
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CologneBlue[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371527 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Iaac2d43800a37db0c1f423fe0194bd47039128be
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..791e6a1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaac2d43800a37db0c1f423fe0194bd47039128be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/CologneBlue
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Daddio[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371528 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I12b0b45ae53e2bb05838d06c19ce13f77fe43b6f
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..64401b1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12b0b45ae53e2bb05838d06c19ce13f77fe43b6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Daddio
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Bouquet[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371526 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I65583645da7d946e43502dc6f7c8db23f401bd80
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..9e5af68
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65583645da7d946e43502dc6f7c8db23f401bd80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Bouquet
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Add skin screenshots for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371548 )

Change subject: Add skin screenshots for the installer
..

Add skin screenshots for the installer

Screenshots for all four supported width modes.

Bug: T68295
Change-Id: I29e99ed6cd123d1a7a072f91fcb808fdb7b320b8
---
A screenshots/1024x768.png
A screenshots/1280x800.png
A screenshots/1440x900.png
A screenshots/Mobile.png
4 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/48/371548/1

diff --git a/screenshots/1024x768.png b/screenshots/1024x768.png
new file mode 100644
index 000..bc47e03
--- /dev/null
+++ b/screenshots/1024x768.png
Binary files differ
diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..d9a1379
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ
diff --git a/screenshots/1440x900.png b/screenshots/1440x900.png
new file mode 100644
index 000..b8402bd
--- /dev/null
+++ b/screenshots/1440x900.png
Binary files differ
diff --git a/screenshots/Mobile.png b/screenshots/Mobile.png
new file mode 100644
index 000..6706436
--- /dev/null
+++ b/screenshots/Mobile.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29e99ed6cd123d1a7a072f91fcb808fdb7b320b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Mask[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371533 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I9cfcf0b192a3f24b79981bfa14e40c02b4e4a988
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..3c225e1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cfcf0b192a3f24b79981bfa14e40c02b4e4a988
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Mask
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Example[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371532 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I617a4e8460347e09179a1bc6116903d44752fbec
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..2981b05
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I617a4e8460347e09179a1bc6116903d44752fbec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Example
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2017-08-11T19:48:03+0000

[WikidataBuilder (Code Review)]

WikidataBuilder has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371547 )

Change subject: New Wikidata Build - 2017-08-11T19:48:03+
..

New Wikidata Build - 2017-08-11T19:48:03+

Change-Id: I225415a6574592bf3f32d7994b94767970db7312
---
M composer.lock
M extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
M vendor/composer/installed.json
3 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/47/371547/1

diff --git a/composer.lock b/composer.lock
index 4fed1ac..b366fea 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1547,12 +1547,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0"
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/b5f8f115e7de452020c9876f404f7a5c895c55c0";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ad9c8a8671f0a5436dfc2405e56705b947a4a925";,
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925",
 "shasum": ""
 },
 "require": {
@@ -1629,7 +1629,7 @@
 "wikibaserepo",
 "wikidata"
 ],
-"time": "2017-08-10 21:18:44"
+"time": "2017-08-10 23:08:05"
 },
 {
 "name": "wikibase/wikimedia-badges",
diff --git 
a/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php 
b/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
index 03cdba7..344c11f 100644
--- 
a/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
+++ 
b/extensions/Wikibase/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
@@ -46,6 +46,7 @@
$this->tablesUsed[] = 'page';
$this->tablesUsed[] = 'redirect';
$this->tablesUsed[] = 'revision';
+   $this->tablesUsed[] = 'ip_changes';
 
$termRows = [];
$infoRows = [];
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index 41155a5..f46b41b 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -1387,12 +1387,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0"
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/b5f8f115e7de452020c9876f404f7a5c895c55c0";,
-"reference": "b5f8f115e7de452020c9876f404f7a5c895c55c0",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/ad9c8a8671f0a5436dfc2405e56705b947a4a925";,
+"reference": "ad9c8a8671f0a5436dfc2405e56705b947a4a925",
 "shasum": ""
 },
 "require": {
@@ -1426,7 +1426,7 @@
 "jakub-onderka/php-parallel-lint": ">=0.3 <0.10",
 "wikibase/wikibase-codesniffer": "^0.1.0"
 },
-"time": "2017-08-10 21:18:44",
+"time": "2017-08-10 23:08:05",
 "type": "mediawiki-extension",
 "installation-source": "dist",
 "autoload": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I225415a6574592bf3f32d7994b94767970db7312
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: WikidataBuilder 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371543 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I9d3bb2805ed143b5609edb15c336979f4aeabe99
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..4dde41d
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3bb2805ed143b5609edb15c336979f4aeabe99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...erudite[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371531 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: Idb6a4aed60911538c7cbd810fb404ee27728de35
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..140e2e3
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb6a4aed60911538c7cbd810fb404ee27728de35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371535 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: If24a4b3e4ab46ab42c40737888d4a531d00b54a0
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..4387746
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If24a4b3e4ab46ab42c40737888d4a531d00b54a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371546 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I67554e951f9cc69ee2b105273aba3fe102feadfb
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/GreyStuff 
refs/changes/46/371546/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..8533a12
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371546
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67554e951f9cc69ee2b105273aba3fe102feadfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/GreyStuff
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WPtouch[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371545 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Iccaf598199e0b58578a7d05adc7b9edfbd0b4d3f
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/WPtouch 
refs/changes/45/371545/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c974305
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccaf598199e0b58578a7d05adc7b9edfbd0b4d3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/WPtouch
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...webplatform[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371544 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Iaeccfcb69bb3bf8a9a1f0753fd2035f68ded1ff6
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/webplatform 
refs/changes/44/371544/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c7048d2
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaeccfcb69bb3bf8a9a1f0753fd2035f68ded1ff6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/webplatform
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371543 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I9d3bb2805ed143b5609edb15c336979f4aeabe99
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/43/371543/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..4dde41d
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d3bb2805ed143b5609edb15c336979f4aeabe99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Truglass[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371542 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Ib9430754185c8e52c413cc1baca3547c50f81e2a
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Truglass 
refs/changes/42/371542/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..60467e1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9430754185c8e52c413cc1baca3547c50f81e2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Truglass
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Tempo[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371541 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I95d3375283e07e0b0bdec4e45e53146898c51acb
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Tempo 
refs/changes/41/371541/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c2f2754
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95d3375283e07e0b0bdec4e45e53146898c51acb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Tempo
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Nostalgia[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371539 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I3fe51a40827862429cbafe7dad7442ea5de6d007
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Nostalgia 
refs/changes/39/371539/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..26e829e
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371539
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fe51a40827862429cbafe7dad7442ea5de6d007
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nostalgia
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Splash[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371540 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I8fddc46db47952740f6f874264918f0ffdbef2fd
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Splash 
refs/changes/40/371540/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c6f3afd
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fddc46db47952740f6f874264918f0ffdbef2fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Splash
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Nimbus[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371538 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I894b5a7bce5aed19e6f258f3fcb7dccd662e4265
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Nimbus 
refs/changes/38/371538/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..bc7318a
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371538
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I894b5a7bce5aed19e6f258f3fcb7dccd662e4265
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nimbus
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MonoBook[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371537 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I1eb2fd5294d1aff92d3870749448047b49843857
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MonoBook 
refs/changes/37/371537/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..96186b7
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eb2fd5294d1aff92d3870749448047b49843857
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MonoBook
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371535 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: If24a4b3e4ab46ab42c40737888d4a531d00b54a0
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/35/371535/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..4387746
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If24a4b3e4ab46ab42c40737888d4a531d00b54a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Modern[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371536 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I6ad5cf54e985c6970e21392df045e44fc3b03415
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Modern 
refs/changes/36/371536/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..86b8a73
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ad5cf54e985c6970e21392df045e44fc3b03415
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Modern
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371534 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Id84169148017e3f634e46503090339e0a481a650
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Metrolook 
refs/changes/34/371534/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..7334bfd
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id84169148017e3f634e46503090339e0a481a650
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Mask[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371533 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I9cfcf0b192a3f24b79981bfa14e40c02b4e4a988
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Mask 
refs/changes/33/371533/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..3c225e1
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cfcf0b192a3f24b79981bfa14e40c02b4e4a988
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Mask
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Example[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371532 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I617a4e8460347e09179a1bc6116903d44752fbec
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Example 
refs/changes/32/371532/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..2981b05
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I617a4e8460347e09179a1bc6116903d44752fbec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Example
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSky[master]: Add skin screenshot for the installer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371522 )

Change subject: Add skin screenshot for the installer
..


Add skin screenshot for the installer

Bug: T68295
Change-Id: I5e8785f1165ba99c47d9aeea63c84d612a588707
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..c2a3362
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e8785f1165ba99c47d9aeea63c84d612a588707
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSky
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...erudite[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371531 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Idb6a4aed60911538c7cbd810fb404ee27728de35
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/31/371531/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..140e2e3
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb6a4aed60911538c7cbd810fb404ee27728de35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Dusk[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371530 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: I09b756f9202e7ca8cc64f4fda770332e40d0
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Dusk 
refs/changes/30/371530/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..3b7ef5f
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09b756f9202e7ca8cc64f4fda770332e40d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Dusk
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DeskMessMirrored[master]: Add skin screenshot for the installer

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371529 )

Change subject: Add skin screenshot for the installer
..

Add skin screenshot for the installer

Bug: T68295
Change-Id: Iba153cb5208d9bd9aa525dcd1ff9c9a1f9e4b942
---
A screenshots/1280x800.png
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/DeskMessMirrored 
refs/changes/29/371529/1

diff --git a/screenshots/1280x800.png b/screenshots/1280x800.png
new file mode 100644
index 000..92668c4
--- /dev/null
+++ b/screenshots/1280x800.png
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/371529
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba153cb5208d9bd9aa525dcd1ff9c9a1f9e4b942
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/DeskMessMirrored
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits