[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Keep workflow config conditions simple for now

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372908 )

Change subject: Keep workflow config conditions simple for now
..


Keep workflow config conditions simple for now

Let's not add any unneeded features until we actually need them.
This removes the check for redirectRight, which doesn't currently
have a use case. Also tweaked the wording of the comments to make
it slightly more clear.

Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
---
M includes/Workflow.php
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified
  Samwilson: Looks good to me, but someone else must approve



diff --git a/includes/Workflow.php b/includes/Workflow.php
index 2680efe..d1bfcef 100644
--- a/includes/Workflow.php
+++ b/includes/Workflow.php
@@ -65,12 +65,7 @@
continue;
}
 
-   // Filter out users who don't have these rights
-   if ( isset( $cond['redirectRight'] ) && 
!$user->isAllowed( $cond['redirectRight'] ) ) {
-   continue;
-   }
-
-   // Filter out people who have these rights
+   // Don't intercept users that have these rights
if ( isset( $cond['excludeRight'] ) && 
$user->isAllowed( $cond['excludeRight'] ) ) {
continue;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/372908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Samwilson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: PHPVersionCheck: Use HTTPS download URL for downloading PHP

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372925 )

Change subject: PHPVersionCheck: Use HTTPS download URL for downloading PHP
..

PHPVersionCheck: Use HTTPS download URL for downloading PHP

Change-Id: Iaf8e012b91888233703577e2de4ec522f39428e7
---
M includes/PHPVersionCheck.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/25/372925/1

diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index cd5bf54..e9e271c 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -98,7 +98,7 @@
'vendor' => 'the PHP Group',
'upstreamSupported' => '5.5.0',
'minSupported' => '5.5.9',
-   'upgradeURL' => 'http://www.php.net/downloads.php',
+   'upgradeURL' => 'https://secure.php.net/downloads.php',
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf8e012b91888233703577e2de4ec522f39428e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: fix leaking threads in integration tests

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371956 )

Change subject: fix leaking threads in integration tests
..


fix leaking threads in integration tests

The RdfRepository in AbstractRdfRepositoryIntegrationTestBase wasn't closed
properly on each test, which make randomized testing leaked thread detector
unhappy. This should help make tests more reliable.

Change-Id: Ie3496814a320f77641142b01e1c99da416b2e2ba
---
M 
tools/src/test/java/org/wikidata/query/rdf/tool/AbstractRdfRepositoryIntegrationTestBase.java
1 file changed, 28 insertions(+), 18 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified
  Gehel: Looks good to me, but someone else must approve



diff --git 
a/tools/src/test/java/org/wikidata/query/rdf/tool/AbstractRdfRepositoryIntegrationTestBase.java
 
b/tools/src/test/java/org/wikidata/query/rdf/tool/AbstractRdfRepositoryIntegrationTestBase.java
index fa39003..5f439a3 100644
--- 
a/tools/src/test/java/org/wikidata/query/rdf/tool/AbstractRdfRepositoryIntegrationTestBase.java
+++ 
b/tools/src/test/java/org/wikidata/query/rdf/tool/AbstractRdfRepositoryIntegrationTestBase.java
@@ -33,7 +33,7 @@
 /**
  * Repository to test with.
  */
-private final RdfRepositoryForTesting rdfRepository;
+private RdfRepositoryForTesting rdfRepository;
 
 /**
  * Build the test against prod wikidata.
@@ -44,7 +44,34 @@
 
 public AbstractRdfRepositoryIntegrationTestBase(WikibaseUris uris) {
 this.uris = uris;
+}
+
+/**
+ * Initializes the {@link RdfRepository} before each test.
+ *
+ * Since randomized testing ThreadLeakControl checks for leaked thread, not
+ * closing properly the RdfRepository after each test causes random false
+ * negative in the test results. Initializing the RdfRepository for each
+ * test might be slightly less performant, but at least it ensures
+ * reproducible tests.
+ */
+@Before
+public void initRdfRepository() {
 rdfRepository = new RdfRepositoryForTesting("wdq");
+rdfRepository.clear();
+}
+
+/**
+ * Closes the {@link RdfRepository} after each test.
+ *
+ * @throws Exception on error
+ */
+@After
+public void clearAndShutdownRdfRepository() throws Exception {
+if (rdfRepository != null) {
+rdfRepository.clear();
+rdfRepository.close();
+}
 }
 
 /**
@@ -59,23 +86,6 @@
  */
 public RdfRepositoryForTesting rdfRepository() {
 return rdfRepository;
-}
-
-/**
- * Clear the repository so one test doesn't interfere with another.
- */
-@Before
-public void clear() {
-rdfRepository.clear();
-}
-
-/**
- * Close the repository at the end.
- * @throws Exception on error
- */
-@After
-public void closeRepo() throws Exception {
-rdfRepository.close();
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/371956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3496814a320f77641142b01e1c99da416b2e2ba
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Gehel 
Gerrit-Reviewer: Gehel 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: cleanup empty spaces

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372897 )

Change subject: cleanup empty spaces
..


cleanup empty spaces

Change-Id: Id7278b01730455353a8b7c3bf94a416abfcdb415
---
M examples/dialog.html
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/examples/dialog.html b/examples/dialog.html
index 22f76a4..577a34a 100644
--- a/examples/dialog.html
+++ b/examples/dialog.html
@@ -24,9 +24,9 @@



-   
+
Dialog
-   
+



@@ -49,12 +49,12 @@



-   
+

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityExternalValidation[master]: Use namespaced TimestampException

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372924 )

Change subject: Use namespaced TimestampException
..

Use namespaced TimestampException

The non-namespaced one is deprecated since 1.29.

Change-Id: I7a428f350452a89607e0072c94bc8990b0e09daf
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
 refs/changes/24/372924/1

diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php 
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 86ec7ef..cef1a71 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -7,12 +7,12 @@
 use DateInterval;
 use InvalidArgumentException;
 use MWTimestamp;
-use TimestampException;
 use ValueParsers\ParserOptions;
 use ValueParsers\ValueParser;
 use Wikibase\Repo\Parsers\TimeParserFactory;
 use WikibaseQuality\ExternalValidation\CrossCheck\Result\ComparisonResult;
 use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation;
+use Wikimedia\Timestamp\TimestampException;
 
 /**
  * @package WikibaseQuality\ExternalValidation\CrossCheck\Comparer

-- 
To view, visit https://gerrit.wikimedia.org/r/372924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a428f350452a89607e0072c94bc8990b0e09daf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove MemcachedClient compat class names

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372923 )

Change subject: Remove MemcachedClient compat class names
..

Remove MemcachedClient compat class names

Deprecated since 1.27, and unused in Wikimedia Git.

Change-Id: I1d73efac2fddb771124bcd31b3d40769e751410c
---
M RELEASE-NOTES-1.30
M autoload.php
D includes/compat/MemcachedClientCompat.php
3 files changed, 2 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/23/372923/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 61bce21..de4f760 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -177,6 +177,8 @@
   should be used instead.
 * RunningStat class (deprecated in 1.27) was removed. The namespaced
   RunningStat\RunningStat should be used instead.
+* MWMemcached and MemCachedClientforWiki classes (deprecated in 1.27) were 
removed.
+  The MemcachedClient class should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/autoload.php b/autoload.php
index 250d262..ac45cc0 100644
--- a/autoload.php
+++ b/autoload.php
@@ -799,7 +799,6 @@
'MWGrants' => __DIR__ . '/includes/MWGrants.php',
'MWHttpRequest' => __DIR__ . '/includes/http/MWHttpRequest.php',
'MWLBFactory' => __DIR__ . '/includes/db/MWLBFactory.php',
-   'MWMemcached' => __DIR__ . '/includes/compat/MemcachedClientCompat.php',
'MWMessagePack' => __DIR__ . '/includes/libs/MWMessagePack.php',
'MWNamespace' => __DIR__ . '/includes/MWNamespace.php',
'MWOldPassword' => __DIR__ . '/includes/password/MWOldPassword.php',
@@ -964,7 +963,6 @@
'MediaWiki\\Widget\\TitleInputWidget' => __DIR__ . 
'/includes/widget/TitleInputWidget.php',
'MediaWiki\\Widget\\UserInputWidget' => __DIR__ . 
'/includes/widget/UserInputWidget.php',
'MediaWiki\\Widget\\UsersMultiselectWidget' => __DIR__ . 
'/includes/widget/UsersMultiselectWidget.php',
-   'MemCachedClientforWiki' => __DIR__ . 
'/includes/compat/MemcachedClientCompat.php',
'MemcLockManager' => __DIR__ . 
'/includes/libs/lockmanager/MemcLockManager.php',
'MemcachedBagOStuff' => __DIR__ . 
'/includes/libs/objectcache/MemcachedBagOStuff.php',
'MemcachedClient' => __DIR__ . 
'/includes/libs/objectcache/MemcachedClient.php',
diff --git a/includes/compat/MemcachedClientCompat.php 
b/includes/compat/MemcachedClientCompat.php
deleted file mode 100644
index 2304733..000
--- a/includes/compat/MemcachedClientCompat.php
+++ /dev/null
@@ -1,34 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @since 1.27
- * @file
- */
-
-/**
- * @deprecated since 1.27
- */
-class MWMemcached extends MemcachedClient {
-}
-
-/**
- * @deprecated since 1.27
- */
-class MemCachedClientforWiki extends MWMemcached {
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/372923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d73efac2fddb771124bcd31b3d40769e751410c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceExtensions[master]: Remove reference to obsolete MWMemcached class

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372922 )

Change subject: Remove reference to obsolete MWMemcached class
..

Remove reference to obsolete MWMemcached class

$wgMemc is actually a BagOStuff instance. And its unused, so just remove
that line entirely.

Change-Id: I4dcccfb823a493f4fbafc88f931eabd646f95a93
---
M Emoticons/Emoticons.class.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/22/372922/1

diff --git a/Emoticons/Emoticons.class.php b/Emoticons/Emoticons.class.php
index 701b14c..53d41c8 100644
--- a/Emoticons/Emoticons.class.php
+++ b/Emoticons/Emoticons.class.php
@@ -158,11 +158,9 @@
 * @param int $iSection Number of edited section
 * @param int &$iFlags
 * @param Status $oStatus The Status object
-* @global MWMemcached $wgMemc The MediaWiki Memcached object
 * @return mixed Boolean true if syntax is okay or the saved article is 
not the MappingSourceArticle, String 'error-msg' if an error occurs.
 */
public function onPageContentSave( $owikiPage, $oUser, $oContent, 
$sSummary, $bIsMinor, $bIsWatch, $iSection, &$iFlags, $oStatus ) {
-   global $wgMemc;
$oMappingSourceTitle = Title::newFromText( 
'bs-emoticons-mapping', NS_MEDIAWIKI );
if( !$oMappingSourceTitle->equals( $owikiPage->getTitle() ) ) 
return true;
 
@@ -209,4 +207,4 @@
 
return true;
}
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/372922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dcccfb823a493f4fbafc88f931eabd646f95a93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove RunningStat compat class

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372921 )

Change subject: Remove RunningStat compat class
..

Remove RunningStat compat class

Deprecated since 1.27, unused in Wikimedia Git.

Change-Id: I0086c1cd945865b10a1e7fcc34c08642db2474af
---
M RELEASE-NOTES-1.30
M autoload.php
D includes/compat/RunningStatCompat.php
3 files changed, 2 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/21/372921/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index ce190fd..61bce21 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -175,6 +175,8 @@
   The namespaced classes in the Cdb namespace should be used instead.
 * IPSet class (deprecated in 1.26) was removed. The namespaced IPSet\IPSet
   should be used instead.
+* RunningStat class (deprecated in 1.27) was removed. The namespaced
+  RunningStat\RunningStat should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/autoload.php b/autoload.php
index 092dbd2..250d262 100644
--- a/autoload.php
+++ b/autoload.php
@@ -1278,7 +1278,6 @@
'RollbackEdits' => __DIR__ . '/maintenance/rollbackEdits.php',
'RowUpdateGenerator' => __DIR__ . 
'/includes/utils/RowUpdateGenerator.php',
'RunJobs' => __DIR__ . '/maintenance/runJobs.php',
-   'RunningStat' => __DIR__ . '/includes/compat/RunningStatCompat.php',
'SVGMetadataExtractor' => __DIR__ . 
'/includes/media/SVGMetadataExtractor.php',
'SVGReader' => __DIR__ . '/includes/media/SVGMetadataExtractor.php',
'SamplingStatsdClient' => __DIR__ . 
'/includes/libs/stats/SamplingStatsdClient.php',
diff --git a/includes/compat/RunningStatCompat.php 
b/includes/compat/RunningStatCompat.php
deleted file mode 100644
index ac82f44..000
--- a/includes/compat/RunningStatCompat.php
+++ /dev/null
@@ -1,28 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-/**
- * Backward-compatibility alias for RunningStat, which was moved out
- * into an external library and namespaced.
- *
- * @deprecated since 1.27 use RunningStat\RunningStat directly
- */
-class RunningStat extends RunningStat\RunningStat {
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/372921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0086c1cd945865b10a1e7fcc34c08642db2474af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove IPSet compat classes

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372920 )

Change subject: Remove IPSet compat classes
..

Remove IPSet compat classes

Deprecated in 1.26, unused in Wikimedia Git.

Change-Id: I7719a204160ddd0ba71a1a5d8f7088f7d552acbd
---
M RELEASE-NOTES-1.30
M autoload.php
D includes/compat/IPSetCompat.php
3 files changed, 2 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/20/372920/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 2d50abb..ce190fd 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -173,6 +173,8 @@
   any more.
 * CdbReader, CdbWriter, CdbException classes (deprecated in 1.25) were removed.
   The namespaced classes in the Cdb namespace should be used instead.
+* IPSet class (deprecated in 1.26) was removed. The namespaced IPSet\IPSet
+  should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/autoload.php b/autoload.php
index 759a501..092dbd2 100644
--- a/autoload.php
+++ b/autoload.php
@@ -614,7 +614,6 @@
'ILocalizedException' => __DIR__ . 
'/includes/exception/LocalizedException.php',
'IMaintainableDatabase' => __DIR__ . 
'/includes/libs/rdbms/database/IMaintainableDatabase.php',
'IP' => __DIR__ . '/includes/libs/IP.php',
-   'IPSet' => __DIR__ . '/includes/compat/IPSetCompat.php',
'IPTC' => __DIR__ . '/includes/media/IPTC.php',
'IRCColourfulRCFeedFormatter' => __DIR__ . 
'/includes/rcfeed/IRCColourfulRCFeedFormatter.php',
'IcuCollation' => __DIR__ . '/includes/collation/IcuCollation.php',
diff --git a/includes/compat/IPSetCompat.php b/includes/compat/IPSetCompat.php
deleted file mode 100644
index 79c6000..000
--- a/includes/compat/IPSetCompat.php
+++ /dev/null
@@ -1,28 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-/**
- * Backward-compatibility alias for IPSet, which was moved out
- * into an external library and namespaced.
- *
- * @deprecated since 1.26 use IPSet\IPSet directly
- */
-class IPSet extends IPSet\IPSet {
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/372920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7719a204160ddd0ba71a1a5d8f7088f7d552acbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: IP: Remove unused static member $proxyIpSet

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372919 )

Change subject: IP: Remove unused static member $proxyIpSet
..

IP: Remove unused static member $proxyIpSet

Change-Id: Ia48ec2eb1281d955bc28f5c78a1501f3d46826c0
---
M includes/libs/IP.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/19/372919/1

diff --git a/includes/libs/IP.php b/includes/libs/IP.php
index b22f06d..bde8c69 100644
--- a/includes/libs/IP.php
+++ b/includes/libs/IP.php
@@ -67,8 +67,6 @@
  * and IP blocks.
  */
 class IP {
-   /** @var IPSet */
-   private static $proxyIpSet = null;
 
/**
 * Determine if a string is as valid IP address or network (CIDR 
prefix).

-- 
To view, visit https://gerrit.wikimedia.org/r/372919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia48ec2eb1281d955bc28f5c78a1501f3d46826c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove Cdb compat class names

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372918 )

Change subject: Remove Cdb compat class names
..

Remove Cdb compat class names

Deprecated since 1.25, and unused in Wikimedia Git.

Change-Id: I05bdefe2e2bf5ffcadb9846651af7367e8e7a814
---
M RELEASE-NOTES-1.30
M autoload.php
D includes/compat/CdbCompat.php
3 files changed, 2 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/372918/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index dd39561d..2d50abb 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -171,6 +171,8 @@
 * Removed 'jquery.mwExtension' module. (deprecated since 1.26)
 * mediawiki.ui: Deprecate greys, which are not part of WikimediaUI color 
palette
   any more.
+* CdbReader, CdbWriter, CdbException classes (deprecated in 1.25) were removed.
+  The namespaced classes in the Cdb namespace should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/autoload.php b/autoload.php
index d9e85bd..759a501 100644
--- a/autoload.php
+++ b/autoload.php
@@ -226,9 +226,6 @@
'CategoryPage' => __DIR__ . '/includes/page/CategoryPage.php',
'CategoryPager' => __DIR__ . 
'/includes/specials/pagers/CategoryPager.php',
'CategoryViewer' => __DIR__ . '/includes/CategoryViewer.php',
-   'CdbException' => __DIR__ . '/includes/compat/CdbCompat.php',
-   'CdbReader' => __DIR__ . '/includes/compat/CdbCompat.php',
-   'CdbWriter' => __DIR__ . '/includes/compat/CdbCompat.php',
'CdnCacheUpdate' => __DIR__ . '/includes/deferred/CdnCacheUpdate.php',
'CdnPurgeJob' => __DIR__ . '/includes/jobqueue/jobs/CdnPurgeJob.php',
'CentralIdLookup' => __DIR__ . '/includes/user/CentralIdLookup.php',
diff --git a/includes/compat/CdbCompat.php b/includes/compat/CdbCompat.php
deleted file mode 100644
index 0074cc9..000
--- a/includes/compat/CdbCompat.php
+++ /dev/null
@@ -1,45 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-/***
- * This file contains a set of backwards-compatability class names
- * after the cdb functions were moved out into a separate library
- * and put under a proper namespace
- *
- * @since 1.25
- */
-
-/**
- * @deprecated since 1.25
- */
-abstract class CdbReader extends \Cdb\Reader {
-}
-
-/**
- * @deprecated since 1.25
- */
-abstract class CdbWriter extends \Cdb\Writer {
-}
-
-/**
- * @deprecated since 1.25
- */
-class CdbException extends \Cdb\Exception {
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/372918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05bdefe2e2bf5ffcadb9846651af7367e8e7a814
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: LocalisationCache: Remove unused "use" statements

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372917 )

Change subject: LocalisationCache: Remove unused "use" statements
..

LocalisationCache: Remove unused "use" statements

Change-Id: Ie1cdd52d87deffa251b7af0554370ba9a4edce73
---
M includes/cache/localisation/LocalisationCache.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/372917/1

diff --git a/includes/cache/localisation/LocalisationCache.php 
b/includes/cache/localisation/LocalisationCache.php
index e0da22e..a0ce95e 100644
--- a/includes/cache/localisation/LocalisationCache.php
+++ b/includes/cache/localisation/LocalisationCache.php
@@ -20,8 +20,6 @@
  * @file
  */
 
-use Cdb\Reader as CdbReader;
-use Cdb\Writer as CdbWriter;
 use CLDRPluralRuleParser\Evaluator;
 use CLDRPluralRuleParser\Error as CLDRPluralRuleError;
 use MediaWiki\MediaWikiServices;

-- 
To view, visit https://gerrit.wikimedia.org/r/372917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1cdd52d87deffa251b7af0554370ba9a4edce73
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Require only one class/interface/trait per file

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372916 )

Change subject: Require only one class/interface/trait per file
..

Require only one class/interface/trait per file

This is in preparation of PSR-4 compliance.

In a few places our test suite uses multiple classes in the same file,
so just list those errors in the .expect file since it's not worth
fixing them.

Bug: T173798
Change-Id: I385b8758cc15171ed925df417304669bb6b0f9e6
---
M MediaWiki/Tests/files/Commenting/commenting_function.php.expect
M MediaWiki/Tests/files/Usage/extend_class_usage.php.expect
M MediaWiki/Tests/files/WhiteSpace/space_before_class_brace.php.expect
M MediaWiki/ruleset.xml
4 files changed, 60 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/16/372916/1

diff --git a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect 
b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
index 46f702c..43aa70d 100644
--- a/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
+++ b/MediaWiki/Tests/files/Commenting/commenting_function.php.expect
@@ -1,32 +1,37 @@
-  5 | ERROR | [ ] Missing function doc comment
-|   | 
(MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic)
-  9 | ERROR | [ ] Missing function doc comment
-|   | 
(MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic)
- 16 | ERROR | [ ] Missing @return tag in function comment
-|   | (MediaWiki.Commenting.FunctionComment.MissingReturn)
- 22 | ERROR | [x] Expected 1 spaces after parameter name; 2 found
-|   | (MediaWiki.Commenting.FunctionComment.SpacingAfterParamName)
- 23 | ERROR | [x] Expected 1 spaces after parameter name; 3 found
-|   | (MediaWiki.Commenting.FunctionComment.SpacingAfterParamName)
- 31 | ERROR | [x] Short type of "bool" should be used for @param tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortBoolParam)
- 32 | ERROR | [x] Short type of "int" should be used for @param tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortIntParam)
- 33 | ERROR | [x] Short type of "bool" should be used for @return tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortBoolReturn)
- 40 | ERROR | [x] Short type of "int" should be used for @return tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortIntReturn)
- 49 | ERROR | [ ] Missing @return tag in function comment
-|   | (MediaWiki.Commenting.FunctionComment.MissingReturn)
- 59 | ERROR | [ ] Missing parameter comment
-|   | (MediaWiki.Commenting.FunctionComment.MissingParamComment)
- 59 | ERROR | [x] Short type of "bool" should be used for @param tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortBoolParam)
- 60 | ERROR | [ ] Missing parameter comment
-|   | (MediaWiki.Commenting.FunctionComment.MissingParamComment)
- 60 | ERROR | [x] Short type of "int" should be used for @param tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortIntParam)
- 61 | ERROR | [x] Short type of "bool" should be used for @return tag
-|   | (MediaWiki.Commenting.FunctionComment.NotShortBoolReturn)
-
+   5 | ERROR | [ ] Missing function doc comment
+ |   | 
(MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic)
+   9 | ERROR | [ ] Missing function doc comment
+ |   | 
(MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic)
+  16 | ERROR | [ ] Missing @return tag in function comment
+ |   | (MediaWiki.Commenting.FunctionComment.MissingReturn)
+  22 | ERROR | [x] Expected 1 spaces after parameter name; 2 found
+ |   | (MediaWiki.Commenting.FunctionComment.SpacingAfterParamName)
+  23 | ERROR | [x] Expected 1 spaces after parameter name; 3 found
+ |   | (MediaWiki.Commenting.FunctionComment.SpacingAfterParamName)
+  31 | ERROR | [x] Short type of "bool" should be used for @param tag
+ |   | (MediaWiki.Commenting.FunctionComment.NotShortBoolParam)
+  32 | ERROR | [x] Short type of "int" should be used for @param tag
+ |   | (MediaWiki.Commenting.FunctionComment.NotShortIntParam)
+  33 | ERROR | [x] Short type of "bool" should be used for @return
+ |   | tag
+ |   | (MediaWiki.Commenting.FunctionComment.NotShortBoolReturn)
+  40 | ERROR | [x] Short type of "int" should be used for @return tag
+ |   | (MediaWiki.Commenting.FunctionComment.NotShortIntReturn)
+  49 | ERROR | [ ] Missing @return tag in function comment
+ |   | (MediaWiki.Commenting.FunctionComment.MissingReturn)
+  59 | ERROR | [ ] Missing parameter comment
+ |   | (MediaWiki.Commenting.FunctionComment.MissingParamComment)
+  59 | ERROR | [x] Short type of "bool" should be used for @param tag
+ |   

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Make it easier to figure out which test failed

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372915 )

Change subject: Make it easier to figure out which test failed
..

Make it easier to figure out which test failed

Setting a string key results in output like:
 MediaWikiStandardTest::testFile with data set
 "space_before_class_brace.php"

See 


Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
---
M MediaWiki/Tests/MediaWikiStandardTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/15/372915/1

diff --git a/MediaWiki/Tests/MediaWikiStandardTest.php 
b/MediaWiki/Tests/MediaWikiStandardTest.php
index 2ceb11e..4d0398f 100644
--- a/MediaWiki/Tests/MediaWikiStandardTest.php
+++ b/MediaWiki/Tests/MediaWikiStandardTest.php
@@ -65,7 +65,7 @@
if ( substr( $file, -4 ) !== '.php' ) {
continue;
}
-   $tests[] = [
+   $tests[$dir->getFilename()] = [
$file,
$standard,
"$file.expect"

-- 
To view, visit https://gerrit.wikimedia.org/r/372915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Update Red50 'destructive' color

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372172 )

Change subject: Update Red50 'destructive' color
..


Update Red50 'destructive' color

'Destructive' color was updated in WikimediaUI color palette to
ensure WCAG 2.0 level AA conformance with both, white and black.
Due to WikimediaUI Base not in central place we still have to care about
this manually.

Change-Id: I7402ef64b1aa28c2cffeb9bca2804b1dfbecec42
---
M modules/echo.variables.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/modules/echo.variables.less b/modules/echo.variables.less
index 9556fc0..1f22a16 100644
--- a/modules/echo.variables.less
+++ b/modules/echo.variables.less
@@ -10,7 +10,7 @@
 @background-color-primary: #eaf3ff;
 @color-primary: #36c;
 // 'Destructive' Color
-@color-destructive: #c33;
+@color-destructive: #d33;
 
 // Border Colors
 @border-color-heading: #c8ccd1;

-- 
To view, visit https://gerrit.wikimedia.org/r/372172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7402ef64b1aa28c2cffeb9bca2804b1dfbecec42
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix error in CargoDeleteTable.php due to fieldHelperTables

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372885 )

Change subject: Fix error in CargoDeleteTable.php due to fieldHelperTables
..


Fix error in CargoDeleteTable.php due to fieldHelperTables

Change-Id: I487e39ac4b615024a4dedf8f8e47c64e8855d6ee
---
M specials/CargoDeleteTable.php
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/CargoDeleteTable.php b/specials/CargoDeleteTable.php
index 1aff877..22965e3 100644
--- a/specials/CargoDeleteTable.php
+++ b/specials/CargoDeleteTable.php
@@ -31,15 +31,17 @@
 * Also, records need to be removed from the cargo_tables and
 * cargo_pages tables.
 */
-   public static function deleteTable( $mainTable, $fieldTables, 
$fieldHelperTables = array() ) {
+   public static function deleteTable( $mainTable, $fieldTables, 
$fieldHelperTables ) {
$cdb = CargoUtils::getDB();
try {
$cdb->dropTable( $mainTable );
foreach ( $fieldTables as $fieldTable ) {
$cdb->dropTable( $fieldTable );
}
-   foreach ( $fieldHelperTables as $fieldHelperTable ) {
-   $cdb->dropTable( $fieldHelperTable );
+   if ( is_array( $fieldHelperTables ) ) {
+   foreach ( $fieldHelperTables as 
$fieldHelperTable ) {
+   $cdb->dropTable( $fieldHelperTable );
+   }
}
} catch ( Exception $e ) {
throw new MWException( "Caught exception ($e) while 
trying to drop Cargo table. "

-- 
To view, visit https://gerrit.wikimedia.org/r/372885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I487e39ac4b615024a4dedf8f8e47c64e8855d6ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update README to link to Phabricator and not Bugzilla

[MusikAnimal (Code Review)]

MusikAnimal has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372914 )

Change subject: Update README to link to Phabricator and not Bugzilla
..

Update README to link to Phabricator and not Bugzilla

Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e164
---
M README
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/14/372914/1

diff --git a/README b/README
index ad9b9d9..769effc 100644
--- a/README
+++ b/README
@@ -23,7 +23,7 @@
 * Seeking help from a person?
 ** https://www.mediawiki.org/wiki/Special:MyLanguage/Communication
 * Looking to file a bug report or a feature request?
-** https://bugs.mediawiki.org/
+** https://phabricator.wikimedia.org/
 * Interested in helping out?
 ** https://www.mediawiki.org/wiki/Special:MyLanguage/How_to_contribute
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e164
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MusikAnimal 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: make CSS filenames consistent with other files

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372913 )

Change subject: Chore: make CSS filenames consistent with other files
..

Chore: make CSS filenames consistent with other files

Rename App's index.css to match the convention used by TypeScript files.

Change-Id: Iac11a33494825c84fdb0407a8bbed0a6175150c8
---
R src/common/components/app/index.css
M src/common/components/app/index.tsx
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/13/372913/1

diff --git a/src/common/components/app/app.css 
b/src/common/components/app/index.css
similarity index 100%
rename from src/common/components/app/app.css
rename to src/common/components/app/index.css
diff --git a/src/common/components/app/index.tsx 
b/src/common/components/app/index.tsx
index 4a3b03e..968f576 100644
--- a/src/common/components/app/index.tsx
+++ b/src/common/components/app/index.tsx
@@ -1,4 +1,4 @@
-import "./app.css";
+import "./index.css";
 import { FunctionalComponent, h } from "preact";
 
 const app: FunctionalComponent = (_props: any): JSX.Element =>

-- 
To view, visit https://gerrit.wikimedia.org/r/372913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac11a33494825c84fdb0407a8bbed0a6175150c8
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Delete maintenance/deleteRevision.php

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372858 )

Change subject: Delete maintenance/deleteRevision.php
..


Delete maintenance/deleteRevision.php

It hasn't been updated properly since 2006 so many fields aren't being
copied to the archive table. Tim suggests it'd be best to just delete it
and, if someone needs the ability to delete or revdel revisions from the
command line, properly abstract out the deletion code instead of
duplicating it.

Change-Id: I400b8ac30b31802e7dd9f6e4d0ec10918eba0183
---
M autoload.php
D maintenance/deleteRevision.php
2 files changed, 0 insertions(+), 111 deletions(-)

Approvals:
  Tim Starling: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/autoload.php b/autoload.php
index d9e85bd..aeecac7 100644
--- a/autoload.php
+++ b/autoload.php
@@ -367,7 +367,6 @@
'DeleteLogFormatter' => __DIR__ . 
'/includes/logging/DeleteLogFormatter.php',
'DeleteOldRevisions' => __DIR__ . '/maintenance/deleteOldRevisions.php',
'DeleteOrphanedRevisions' => __DIR__ . 
'/maintenance/deleteOrphanedRevisions.php',
-   'DeleteRevision' => __DIR__ . '/maintenance/deleteRevision.php',
'DeleteSelfExternals' => __DIR__ . 
'/maintenance/deleteSelfExternals.php',
'DeletedContribsPager' => __DIR__ . 
'/includes/specials/pagers/DeletedContribsPager.php',
'DeletedContributionsPage' => __DIR__ . 
'/includes/specials/SpecialDeletedContributions.php',
diff --git a/maintenance/deleteRevision.php b/maintenance/deleteRevision.php
deleted file mode 100644
index 3abbdab..000
--- a/maintenance/deleteRevision.php
+++ /dev/null
@@ -1,110 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- * @ingroup Maintenance
- */
-
-require_once __DIR__ . '/Maintenance.php';
-
-/**
- * Maintenance script that deletes one or more revisions by moving them
- * to the archive table.
- *
- * @ingroup Maintenance
- */
-class DeleteRevision extends Maintenance {
-
-   public function __construct() {
-   parent::__construct();
-   $this->addDescription( 'Delete one or more revisions by moving 
them to the archive table' );
-   }
-
-   public function execute() {
-   if ( count( $this->mArgs ) == 0 ) {
-   $this->error( "No revisions specified", true );
-   }
-
-   $this->output( "Deleting revision(s) " . implode( ',', 
$this->mArgs ) .
-   " from " . wfWikiID() . "...\n" );
-   $dbw = $this->getDB( DB_MASTER );
-
-   $affected = 0;
-   foreach ( $this->mArgs as $revID ) {
-   $dbw->insertSelect( 'archive', [ 'page', 'revision' ],
-   [
-   'ar_namespace' => 'page_namespace',
-   'ar_title' => 'page_title',
-   'ar_page_id' => 'page_id',
-   'ar_comment' => 'rev_comment',
-   'ar_user' => 'rev_user',
-   'ar_user_text' => 'rev_user_text',
-   'ar_timestamp' => 'rev_timestamp',
-   'ar_minor_edit' => 'rev_minor_edit',
-   'ar_rev_id' => 'rev_id',
-   'ar_text_id' => 'rev_text_id',
-   'ar_deleted' => 'rev_deleted',
-   'ar_len' => 'rev_len',
-   ],
-   [
-   'rev_id' => $revID,
-   'page_id = rev_page'
-   ],
-   __METHOD__
-   );
-   if ( !$dbw->affectedRows() ) {
-   $this->output( "Revision $revID not found\n" );
-   } else {
-   $affected += $dbw->affectedRows();
-   $pageID = $dbw->selectField(
-   'revision',
-   'rev_page',
-   [ 'rev_id' => $revID ],
-   __METHOD__
-   );
-   $pageLatest = $dbw->selectField(
-   'page',
-   'page_latest',
-   [ 'page_id' => $pageID ],
-   __METHOD__
-   );
-   $dbw->delete( 'revision', [ 'rev_id' => $revID 
] );
-   if ( $pageLatest == $revID ) {
-   

[MediaWiki-commits] [Gerrit] mediawiki...BoilerPlate[master]: Namespace this extension

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372912 )

Change subject: Namespace this extension
..

Namespace this extension

Change-Id: I1ba4e335fff4982dcefbb5f57df260319f54f050
---
M BoilerPlate.hooks.php
M extension.json
M specials/SpecialHelloWorld.php
3 files changed, 12 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BoilerPlate 
refs/changes/12/372912/1

diff --git a/BoilerPlate.hooks.php b/BoilerPlate.hooks.php
index d166e90..375dbf9 100644
--- a/BoilerPlate.hooks.php
+++ b/BoilerPlate.hooks.php
@@ -1,4 +1,7 @@
 https://gerrit.wikimedia.org/r/372912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ba4e335fff4982dcefbb5f57df260319f54f050
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BoilerPlate[master]: Cleanup incorrect usage of config_prefix, use ResourceFileMo...

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372910 )

Change subject: Cleanup incorrect usage of config_prefix, use 
ResourceFileModulePaths
..

Cleanup incorrect usage of config_prefix, use ResourceFileModulePaths

config_prefix is meant for a migration of variables using the legacy $eg
prefix, not for each extension to define their own.

Also use the ResourceFileModulePaths feature to specify all resources
are in the modules/ directory so it doesn't need to be repeated for each
file.

Change-Id: Iab7b0ea68aae547ffe541e411910f2ff120de625
---
M BoilerPlate.hooks.php
M extension.json
2 files changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BoilerPlate 
refs/changes/10/372910/1

diff --git a/BoilerPlate.hooks.php b/BoilerPlate.hooks.php
index f850b31..d166e90 100644
--- a/BoilerPlate.hooks.php
+++ b/BoilerPlate.hooks.php
@@ -9,10 +9,14 @@
 class BoilerPlateHooks {
 
/**
-* @return GlobalVarConfig
+* Hook: NameOfHook
+*
+* @param string $arg1 First argument
+* @param bool $arg2 Second argument
+* @param bool $arg3 Third argument
 */
-   public static function makeConfig() {
-   return new GlobalVarConfig( 'boilerplate' );
+   public static function onNameOfHook( $arg1, $arg2, $arg3 ) {
+   // Stub
}
 
 }
diff --git a/extension.json b/extension.json
index 852177e..928541b 100644
--- a/extension.json
+++ b/extension.json
@@ -12,12 +12,11 @@
"BoilerPlateHooks": "BoilerPlate.hooks.php",
"SpecialHelloWorld": "specials/SpecialHelloWorld.php"
},
-   "config_prefix": "boilerplate",
"ConfigRegistry": {
-   "boilerplate": "BoilerPlateHooks::makeConfig"
+   "boilerplate": "GlobalVarConfig::newInstance"
},
"config": {
-   "EnableFoo": {
+   "BoilerPlateEnableFoo": {
"value": true,
"description": "Whether or not the foo feature is 
enabled."
}
@@ -38,19 +37,19 @@
"ResourceModules": {
"ext.boilerPlate.foo": {
"scripts": [
-   "modules/ext.boilerPlate.js",
-   "modules/ext.boilerPlate.foo.js"
+   "ext.boilerPlate.js",
+   "ext.boilerPlate.foo.js"
],
"styles": [
-   "modules/ext.boilerPlate.foo.css"
+   "ext.boilerPlate.foo.css"
],
"messages": [],
"dependencies": []
}
},
"ResourceFileModulePaths": {
-   "localBasePath": "",
-   "remoteExtPath": "BoilerPlate"
+   "localBasePath": "modules",
+   "remoteExtPath": "BoilerPlate/modules"
},
"SpecialPages": {
"HelloWorld": "SpecialHelloWorld"

-- 
To view, visit https://gerrit.wikimedia.org/r/372910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab7b0ea68aae547ffe541e411910f2ff120de625
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BoilerPlate[master]: Remove legacy BoilerPlate.php shim

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372911 )

Change subject: Remove legacy BoilerPlate.php shim
..

Remove legacy BoilerPlate.php shim

Change-Id: I2e25c9a867b07e8bd02e8f29d9cfd39b76c2bc62
---
D BoilerPlate.php
1 file changed, 0 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BoilerPlate 
refs/changes/11/372911/1

diff --git a/BoilerPlate.php b/BoilerPlate.php
deleted file mode 100644
index 4f9a370..000
--- a/BoilerPlate.php
+++ /dev/null
@@ -1,15 +0,0 @@
-https://www.mediawiki.org/wiki/Extension_registration for more details.'
-   );
-   return true;
-} else {
-   die( 'This version of the BoilerPlate extension requires MediaWiki 
1.25+' );
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/372911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e25c9a867b07e8bd02e8f29d9cfd39b76c2bc62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Specify page being created as a URL parameter

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372903 )

Change subject: Specify page being created as a URL parameter
..


Specify page being created as a URL parameter

We decided that doing so would make pageview analysis easier.

Bug: T173766
Change-Id: Ib632f87f98586e937f504630bf9856ad5d352583
---
M includes/Hooks.php
M includes/SpecialCreatePage.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Kaldari: Looks good to me, approved



diff --git a/includes/Hooks.php b/includes/Hooks.php
index 011ab5f..859a973 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -27,9 +27,9 @@
 
if ( $workflow->shouldInterceptEditPage( $editPage ) ) {
$title = $editPage->getTitle();
-   $redirTo = SpecialPage::getTitleFor( 'CreatePage', 
$title->getPrefixedText() );
+   $redirTo = SpecialPage::getTitleFor( 'CreatePage' );
$output = $editPage->getContext()->getOutput();
-   $output->redirect( $redirTo->getFullURL() );
+   $output->redirect( $redirTo->getFullURL( [ 'page' => 
$title->getPrefixedText() ] ) );
 
return false;
}
diff --git a/includes/SpecialCreatePage.php b/includes/SpecialCreatePage.php
index 5d28acb..bc48154 100644
--- a/includes/SpecialCreatePage.php
+++ b/includes/SpecialCreatePage.php
@@ -36,7 +36,7 @@
->makeConfig( 'ArticleCreationWorkflow' );
$workflow = new Workflow( $config );
 
-   $destTitle = Title::newFromText( $subPage );
+   $destTitle = Title::newFromText( $this->getRequest()->getText( 
'page' ) );
$destTitleText = $destTitle ? $destTitle->getPrefixedText() : 
'';
$landingPageMessage = $workflow->getLandingPageMessage();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib632f87f98586e937f504630bf9856ad5d352583
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Samwilson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix 'year page' identification bug.

[Mhurd (Code Review)]

Mhurd has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372909 )

Change subject: Fix 'year page' identification bug.
..

Fix 'year page' identification bug.

Fixes issue causing some events to appear without any associated pages.

bug T169277

Change-Id: Ia8e824c43995ce478679ade0ee94359f48ecce3b
---
M routes/on-this-day.js
M test/features/onthisday/on-this-day.js
2 files changed, 47 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/09/372909/1

diff --git a/routes/on-this-day.js b/routes/on-this-day.js
index 6ef9f10..99e06e3 100644
--- a/routes/on-this-day.js
+++ b/routes/on-this-day.js
@@ -122,6 +122,17 @@
 }
 
 /**
+ * Determines whether anchor is for specific year page.
+ * @param  {!AnchorElement}  anchor
+ * @param  {!Integer}  year
+ * @param  {!String}  era
+ * @return {!boolean}
+ */
+function isAnchorForYear(anchor, year, era) {
+return new RegExp(`^${Math.abs(year)}\\s*${era}$`, 'i').test(anchor.title);
+}
+
+/**
  * Converts document list element to WMFEvent model.
  * A regular expression determines valid "year list elements" and separating 
their components.
  *  For example:'399 BC - Death of Socrates'
@@ -146,21 +157,20 @@
 }
 
 let year = parseInt(match[1], 10);
-
-// Negate BC years so they sort correctly
 const isBC = (match[2] !== undefined);
+let era = '';
 if (isBC) {
+// Negate BC years so they sort correctly
 year = -year;
+era = match[2];
 }
 
 const textAfterYear = match[3].trim();
 
-function isAnchorNotForYear(anchor) {
-return Math.abs(parseInt(anchor.title, 10)) !== Math.abs(year);
-}
-
 const pages = Array.from(listElement.querySelectorAll('a'))
-.filter(isAnchorNotForYear)
+.filter((anchor) => {
+return !isAnchorForYear(anchor, year, era);
+})
 .map(wmfPageFromAnchorElement);
 
 return new WMFEvent(textAfterYear, pages, year);
@@ -539,7 +549,8 @@
 eventsForYearListElements,
 reverseChronologicalWMFEventComparator,
 hydrateAllTitles,
-listElementsByHeadingID
+listElementsByHeadingID,
+isAnchorForYear
 }
 };
 };
diff --git a/test/features/onthisday/on-this-day.js 
b/test/features/onthisday/on-this-day.js
index 5c7232d..faf4f7a 100644
--- a/test/features/onthisday/on-this-day.js
+++ b/test/features/onthisday/on-this-day.js
@@ -450,4 +450,32 @@
 const listElements = 
onThisDay.testing.listElementsByHeadingID(document, ['Births']);
 assert.ok(listElements.length === 208);
 });
+
+describe('isAnchorForYear', () => {
+const a = domino.createDocument().createElement('A');
+it('correctly identifies anchor linking to year article', () => {
+a.title = '2008';
+assert.ok(onThisDay.testing.isAnchorForYear(a, 2008, ''));
+});
+it('correctly rejects anchor linking article starting with a year', () 
=> {
+a.title = '2008 Something something';
+assert.ok(!onThisDay.testing.isAnchorForYear(a, 2008, ''));
+});
+it('correctly rejects anchor linking article starting with a number', 
() => {
+a.title = '123456 Something something';
+assert.ok(!onThisDay.testing.isAnchorForYear(a, 2008, ''));
+});
+it('correctly rejects anchor linking article not starting with a 
year', () => {
+a.title = 'Something something';
+assert.ok(!onThisDay.testing.isAnchorForYear(a, 2008, ''));
+});
+it('correctly identifies anchor linking to year article with an era 
string', () => {
+a.title = '2008 BC';
+assert.ok(onThisDay.testing.isAnchorForYear(a, 2008, 'BC'));
+});
+it('correctly identifies anchor linking to year article with era 
string w/o space', () => {
+a.title = '55BC';
+assert.ok(onThisDay.testing.isAnchorForYear(a, 55, 'BC'));
+});
+});
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/372909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8e824c43995ce478679ade0ee94359f48ecce3b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mhurd 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Keep workflow config conditions simple for now

[Kaldari (Code Review)]

Kaldari has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372908 )

Change subject: Keep workflow config conditions simple for now
..

Keep workflow config conditions simple for now

Let's not add any unneeded features until we actually need them.
This removes the check for redirectRight, which doesn't currently
have a use case. Also tweaked the wording of the comments to make
it slightly more clear.

Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
---
M includes/Workflow.php
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/08/372908/1

diff --git a/includes/Workflow.php b/includes/Workflow.php
index 2680efe..72ef235 100644
--- a/includes/Workflow.php
+++ b/includes/Workflow.php
@@ -60,17 +60,13 @@
}
 
foreach ( $conditions as $cond ) {
+
// Filter on namespace
if ( !in_array( $title->getNamespace(), 
$cond['namespaces'] ) ) {
continue;
}
 
-   // Filter out users who don't have these rights
-   if ( isset( $cond['redirectRight'] ) && 
!$user->isAllowed( $cond['redirectRight'] ) ) {
-   continue;
-   }
-
-   // Filter out people who have these rights
+   // Don't intercept users that have these rights
if ( isset( $cond['excludeRight'] ) && 
$user->isAllowed( $cond['excludeRight'] ) ) {
continue;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/372908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1ead74c4c5d06adf557296c8ce3ce9ce99ccbe7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Kaldari 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Replace outdated “erroneous” color values with WikimediaUI ones

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372907 )

Change subject: Replace outdated “erroneous” color values with WikimediaUI ones
..

Replace outdated “erroneous” color values with WikimediaUI ones

“Erroneous” color was updated to `#d33` in WikimediaUI color palette to
ensure WCAG 2.0 level AA conformance with both, white and black.
Replacing all occurences of `#f00` and `#c00` to reflect color palette
change with the following caveats and exceptions:
- MW config styles are not amended as it is out of scope and all
  boundaries and applications of WikimediaUI are yet to be defined,
- oldshared.css is excluded as WikimediaUI isn't touching old skins and
- errorbox with it's current background is getting a lowered textual contrast
  but we still provide enough contrast for text size and bolded font and
  this needs to be seen as intermediate standardization step.

Change-Id: Iba3362abaa1702599f0d68860f579aea2114801c
---
M resources/src/jquery/jquery.badge.css
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.less/mediawiki.ui/variables.less
M resources/src/mediawiki.special/mediawiki.special.apisandbox.css
M resources/src/mediawiki/htmlform/styles.css
M resources/src/mediawiki/mediawiki.apihelp.css
6 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/372907/1

diff --git a/resources/src/jquery/jquery.badge.css 
b/resources/src/jquery/jquery.badge.css
index 8e0e512..2dbd4a5 100644
--- a/resources/src/jquery/jquery.badge.css
+++ b/resources/src/jquery/jquery.badge.css
@@ -32,5 +32,5 @@
 }
 
 .mw-badge-important {
-   background-color: #c00;
+   background-color: #d33;
 }
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 1efcdd0..fbc9816 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -153,7 +153,7 @@
 
 .unpatrolled {
font-weight: bold;
-   color: #f00;
+   color: #d33;
 }
 
 div.patrollink {
@@ -389,7 +389,7 @@
 }
 
 .error {
-   color: #c00;
+   color: #d33;
 }
 
 .warning {
@@ -423,7 +423,7 @@
 }
 
 .errorbox {
-   color: #c00;
+   color: #d33;
border-color: #fac5c5;
background-color: #fae3e3;
 }
@@ -460,7 +460,7 @@
 
 /* Note on preview page */
 .previewnote {
-   color: #c00;
+   color: #d33;
margin-bottom: 1em;
 }
 
diff --git a/resources/src/mediawiki.less/mediawiki.ui/variables.less 
b/resources/src/mediawiki.less/mediawiki.ui/variables.less
index 0ad791b..0c897dc 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/variables.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/variables.less
@@ -41,7 +41,7 @@
 @colorButtonTextHighlight: @colorGray4;
 @colorButtonTextActive: @colorGray1;
 @colorDisabledText: @colorGray12;
-@colorErrorText: #c00;
+@colorErrorText: #d33;
 @colorWarningText: #705000;
 
 // UI colors
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.css 
b/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
index 99d0222..750a567 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.css
@@ -101,7 +101,7 @@
 
 .apihelp-deprecated {
font-weight: bold;
-   color: #f00;
+   color: #d33;
 }
 
 .apihelp-deprecated-value .oo-ui-labelElement-label {
diff --git a/resources/src/mediawiki/htmlform/styles.css 
b/resources/src/mediawiki/htmlform/styles.css
index a36b379..0f331ee 100644
--- a/resources/src/mediawiki/htmlform/styles.css
+++ b/resources/src/mediawiki/htmlform/styles.css
@@ -9,7 +9,7 @@
 }
 
 .mw-htmlform-invalid-input td.mw-input input {
-   border-color: #f00;
+   border-color: #d33;
 }
 
 .mw-htmlform-flatlist div.mw-htmlform-flatlist-item {
diff --git a/resources/src/mediawiki/mediawiki.apihelp.css 
b/resources/src/mediawiki/mediawiki.apihelp.css
index bd4741d..7ef32ea 100644
--- a/resources/src/mediawiki/mediawiki.apihelp.css
+++ b/resources/src/mediawiki/mediawiki.apihelp.css
@@ -37,7 +37,7 @@
 .apihelp-flag-deprecated,
 .apihelp-flag-internal strong {
font-weight: bold;
-   color: #f00;
+   color: #d33;
 }
 
 .apihelp-deprecated-value {

-- 
To view, visit https://gerrit.wikimedia.org/r/372907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba3362abaa1702599f0d68860f579aea2114801c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372906 )

Change subject: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
..


build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
---
M package.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
5 files changed, 8 insertions(+), 10 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git a/package.json b/package.json
index 8507238..96a425f 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
 "deepmerge": "1.3.2",
 "eslint": "3.12.2",
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index c066a1f..81c8306 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++ 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -42,7 +42,7 @@
/**
 * Get an object representing the state of this item
 *
-* @returns {Object} Object representing the current data state
+* @return {Object} Object representing the current data state
 *  of the object
 */
mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () {
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..209e7c8 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -458,11 +458,9 @@
this.filtersModel.toggleInvertedNamespaces();
 
if (
-   this.filtersModel.getFiltersByView( 'namespaces' )
-   .filter( function ( filterItem ) {
-   return filterItem.isSelected();
-   } )
-   .length
+   this.filtersModel.getFiltersByView( 'namespaces' 
).filter(
+   function ( filterItem ) { return 
filterItem.isSelected(); }
+   ).length
) {
// Only re-fetch results if there are namespace items 
that are actually selected
this.updateChangesList();
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 70a2227..bb837e0 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -125,7 +125,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index cac1059..3655c16 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -212,7 +212,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
@@ -307,7 +307,7 @@
/**
 * Get item ID
 *
-* @returns {string} Query identifier
+* @return {string} Query identifier
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () {
return this.model.getID();

-- 
To view, visit https://gerrit.wikimedia.org/r/372906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372906 )

Change subject: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
..

build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
---
M package.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
5 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/372906/1

diff --git a/package.json b/package.json
index 8507238..96a425f 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
 "deepmerge": "1.3.2",
 "eslint": "3.12.2",
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index c066a1f..81c8306 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++ 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -42,7 +42,7 @@
/**
 * Get an object representing the state of this item
 *
-* @returns {Object} Object representing the current data state
+* @return {Object} Object representing the current data state
 *  of the object
 */
mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () {
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..209e7c8 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -458,11 +458,9 @@
this.filtersModel.toggleInvertedNamespaces();
 
if (
-   this.filtersModel.getFiltersByView( 'namespaces' )
-   .filter( function ( filterItem ) {
-   return filterItem.isSelected();
-   } )
-   .length
+   this.filtersModel.getFiltersByView( 'namespaces' 
).filter(
+   function ( filterItem ) { return 
filterItem.isSelected(); }
+   ).length
) {
// Only re-fetch results if there are namespace items 
that are actually selected
this.updateChangesList();
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 70a2227..bb837e0 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -125,7 +125,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index cac1059..3655c16 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -212,7 +212,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
@@ -307,7 +307,7 @@
/**
 * Get item ID
 *
-* @returns {string} Query identifier
+* @return {string} Query identifier
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () {
return this.model.getID();

-- 
To view, visit https://gerrit.wikimedia.org/r/372906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Create update SPARQL for category changes

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372905 )

Change subject: Create update SPARQL for category changes
..

Create update SPARQL for category changes

Bug: T173774
Change-Id: I9867ad566c0619b55a48a011bd3c55321b1bfcff
---
M autoload.php
M maintenance/CategoriesRdf.php
A maintenance/categoryChangesAsRdf.php
3 files changed, 427 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/372905/1

diff --git a/autoload.php b/autoload.php
index 80e0cd3..d2191f2 100644
--- a/autoload.php
+++ b/autoload.php
@@ -221,6 +221,7 @@
'CapsCleanup' => __DIR__ . '/maintenance/cleanupCaps.php',
'CategoriesRdf' => __DIR__ . '/maintenance/CategoriesRdf.php',
'Category' => __DIR__ . '/includes/Category.php',
+   'CategoryChangesAsRdf' => __DIR__ . 
'/maintenance/categoryChangesAsRdf.php',
'CategoryFinder' => __DIR__ . '/includes/CategoryFinder.php',
'CategoryMembershipChange' => __DIR__ . 
'/includes/changes/CategoryMembershipChange.php',
'CategoryMembershipChangeJob' => __DIR__ . 
'/includes/jobqueue/jobs/CategoryMembershipChangeJob.php',
diff --git a/maintenance/CategoriesRdf.php b/maintenance/CategoriesRdf.php
index 8e93f20..bac011b 100644
--- a/maintenance/CategoriesRdf.php
+++ b/maintenance/CategoriesRdf.php
@@ -74,6 +74,15 @@
}
 
/**
+* Make URL from title label
+* @param $titleLabel
+* @return string
+*/
+   public function labelToUrl( $titleLabel ) {
+   return $this->titleToUrl( Title::makeTitle( NS_CATEGORY, 
$titleLabel ) );
+   }
+
+   /**
 * Convert Title to link to target page.
 * @param Title $title
 * @return string
diff --git a/maintenance/categoryChangesAsRdf.php 
b/maintenance/categoryChangesAsRdf.php
new file mode 100644
index 000..c5fb13a
--- /dev/null
+++ b/maintenance/categoryChangesAsRdf.php
@@ -0,0 +1,417 @@
+http://www.gnu.org/copyleft/gpl.html
+ *
+ */
+use Wikimedia\Purtle\RdfWriter;
+use Wikimedia\Purtle\TurtleRdfWriter;
+use Wikimedia\Rdbms\IDatabase;
+
+require_once __DIR__ . '/Maintenance.php';
+
+/**
+ * Maintenance script to provide RDF representation of the recent changes in 
category tree.
+ *
+ * @ingroup Maintenance
+ * @since 1.30
+ */
+class CategoryChangesAsRdf extends Maintenance {
+   /**
+* Insert query
+*/
+   const SPARQL_INSERT = <setBatchSize( 200 );
+   $this->addOption( 'output', "Output file (default is stdout). 
Will be overwritten.",
+   false, true );
+   $this->addOption( 's', 'Starting timestamp (inclusive)', true, 
true );
+   $this->addOption( 'e', 'Ending timestamp (exclusive)', true, 
true );
+   }
+
+   public function execute() {
+   $outFile = $this->getOption( 'output', 'php://stdout' );
+
+   if ( $outFile === '-' ) {
+   $outFile = 'php://stdout';
+   }
+
+   $output = fopen( $outFile, 'w' );
+   // SPARQL Update is close to TTL
+   $this->rdfWriter = new TurtleRdfWriter();
+   $this->categoriesRdf = new CategoriesRdf( $this->rdfWriter );
+
+   $this->categoriesRdf->setupPrefixes();
+   $this->rdfWriter->start();
+
+   $prefixes = $this->rdfWriter->drain();
+   // we have to strip @ from prefix, since SPARQL UPDATE doesn't 
use them
+   $prefixes = preg_replace( '/^@/m', '', $prefixes );
+   fwrite( $output, $prefixes );
+
+   $dbr = $this->getDB( DB_REPLICA, [ 'vslow' ] );
+
+   $processed = []; // So we don't try to process same thins twice
+
+   // Handle deletes
+   // This only does "true" deletes - i.e. those that the page 
stays deleted
+   foreach ( $this->getDeletedCatsIterator( $dbr ) as $batch ) {
+   $deleteUrls = [];
+   foreach ( $batch as $row ) {
+   // This can produce duplicates, we don't care
+   $deleteUrls[] = '<' . 
$this->categoriesRdf->labelToUrl( $row->rc_title ) . '>';
+   $processed[$row->rc_cur_id] = true;
+   }
+   fwrite( $output, $this->getCategoriesUpdate( $dbr, 
$deleteUrls, [] ) );
+   }
+
+   // Handle moves
+   // Moves go before additions because if category is moved, we 
should not process creation
+   // as it would produce wrong data - because create row has old 
title
+   foreach ( $this->getMovedCatsIterator( $dbr ) as $batch ) {
+   $pages = [];
+   

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Provide the WikimediaUI LESS config vars for all ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372904 )

Change subject: resources: Provide the WikimediaUI LESS config vars for all 
OOjs UI users
..

resources: Provide the WikimediaUI LESS config vars for all OOjs UI users

Bug: T123359
Change-Id: I11677b9bacdbba9e17574891ca30428051b13606
---
M maintenance/resources/update-oojs-ui.sh
M resources/Resources.php
A resources/lib/oojs-ui/wikimedia-ui-base.less
3 files changed, 158 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/372904/1

diff --git a/maintenance/resources/update-oojs-ui.sh 
b/maintenance/resources/update-oojs-ui.sh
index bfa359f..799af4c 100755
--- a/maintenance/resources/update-oojs-ui.sh
+++ b/maintenance/resources/update-oojs-ui.sh
@@ -59,6 +59,7 @@
 cp ./node_modules/oojs-ui/src/themes/wikimediaui/*.json 
"$REPO_DIR/$TARGET_DIR/themes/wikimediaui"
 cp -R ./node_modules/oojs-ui/dist/themes/apex/images 
"$REPO_DIR/$TARGET_DIR/themes/apex"
 cp ./node_modules/oojs-ui/src/themes/apex/*.json 
"$REPO_DIR/$TARGET_DIR/themes/apex"
+cp ./node_modules/oojs-ui/dist/wikimedia-ui-base.less "$REPO_DIR/$TARGET_DIR"
 
 # Clean up temporary area
 rm -rf "$NPM_DIR"
diff --git a/resources/Resources.php b/resources/Resources.php
index 89eab94..d5b9702 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2695,7 +2695,10 @@
// This contains only the styles required by core widgets.
'oojs-ui-core.styles' => [
'class' => 'ResourceLoaderOOUIFileModule',
-   'styles' => 'resources/src/oojs-ui-local.css', // HACK, see 
inside the file
+   'styles' => [
+   'resources/lib/wikimedia-ui-base.less' // Providing 
Wikimedia UI LESS variables to all
+   'resources/src/oojs-ui-local.css', // HACK, see inside 
the file
+   ],
'themeStyles' => 'core',
'targets' => [ 'desktop', 'mobile' ],
],
diff --git a/resources/lib/oojs-ui/wikimedia-ui-base.less 
b/resources/lib/oojs-ui/wikimedia-ui-base.less
new file mode 100644
index 000..d450dbc
--- /dev/null
+++ b/resources/lib/oojs-ui/wikimedia-ui-base.less
@@ -0,0 +1,153 @@
+/**
+ * WikimediaUI Base v0.9.2
+ * Wikimedia Foundation user interface base variables
+ */
+
+/* Colors */
+// WikimediaUI (WMUI) color palette
+@wmui-color-base0:#000;// = HSB 0°, 0%, 0%
+@wmui-color-base10:   #222;// = HSB 0°, 0%, 13%
+@wmui-color-base20:   #54595d; // = HSB 207°, 10%, 36%; WCAG 2.0 level AAA 
7.09:1 contrast ratio on `#fff`
+@wmui-color-base30:   #72777d; // = HSB 210°, 9%, 49%; WCAG 2.0 level AA at 
4.52:1 contrast ratio on `#fff`
+@wmui-color-base50:   #a2a9b1; // = HSB 212°, 8%, 69%
+@wmui-color-base70:   #c8ccd1; // = HSB 213°, 4%, 82%
+@wmui-color-base80:   #eaecf0; // = HSB 220°, 3%, 94%
+@wmui-color-base90:   #f8f9fa; // = HSB 210°, 1%, 98%
+@wmui-color-base100:  #fff;// = HSB 0°, 0%, 100%
+
+@wmui-color-accent30: #2a4b8d; // = HSB 220°, 70%, 55%
+@wmui-color-accent50: #36c;// = HSB 220°, 75%, 80%
+@wmui-color-accent90: #eaf3ff; // = HSB 214°, 8%, 100%
+
+@wmui-color-red30:#b32424; // = HSB 360°, 80%, 70%
+@wmui-color-red50:#d33;// = HSB 360°, 77%, 87%
+@wmui-color-red90:#fee7e6; // = HSB 3°, 9%, 100%
+
+@wmui-color-yellow30: #ac6600; // = HSB 36°, 100%, 67%
+@wmui-color-yellow50: #fc3;// = HSB 45°, 80%, 100%
+@wmui-color-yellow90: #fef6e7; // = HSB 39°, 9%, 100%
+
+@wmui-color-green30:  #14866d; // = HSB 167°, 85%, 53%
+@wmui-color-green50:  #00af89; // = HSB 167°, 100%, 69%
+@wmui-color-green90:  #d5fdf4; // = HSB 166°, 16%, 99%
+
+// Background Colors
+@background-color-base:   @wmui-color-base100;
+@background-color-code:   @wmui-color-base90;
+// 'Framed' UI elements (Framed Buttons, Dropdowns, ToggleSwitches...)
+@background-color-framed: @wmui-color-base90;
+@background-color-framed--hover: @wmui-color-base100;
+@background-color-framed--active: @wmui-color-base70;
+// Tabs Navigation Background Color
+@background-color-tabs:   @wmui-color-base80;
+// Highlight Colors, RGBA Colors include hex fallback on `#fff` for IE 6/7/8
+@background-color-highlight:  rgba( 255, 182, 13, 0.4 );
+@background-color-highlight--fallback: #ffe29e;
+
+// Foreground Colors
+@color-base:  @wmui-color-base10;
+@color-base--hover:   #444;
+@color-base--active:  @wmui-color-base0;
+@color-base--inverted:@wmui-color-base100;
+@color-base--emphasized:  @wmui-color-base0;
+@color-base--subtle:  @wmui-color-base30;
+@color-base--disabled:@wmui-color-base30;
+@color-filled--disabled:  @color-base--inverted;
+@color-placeholder:   @wmui-color-base30;
+// Primary 'Progressive' Color, Background Color and states
+@background-color-primary:@wmui-color-accent90;
+@background-color-primary--hover: rgba( 

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Specify page being created as a URL parameter

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372903 )

Change subject: Specify page being created as a URL parameter
..

Specify page being created as a URL parameter

We decided that doing so would make pageview analysis easier.

Bug: T173766
Change-Id: Ib632f87f98586e937f504630bf9856ad5d352583
---
M includes/Hooks.php
M includes/SpecialCreatePage.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/03/372903/1

diff --git a/includes/Hooks.php b/includes/Hooks.php
index 011ab5f..859a973 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -27,9 +27,9 @@
 
if ( $workflow->shouldInterceptEditPage( $editPage ) ) {
$title = $editPage->getTitle();
-   $redirTo = SpecialPage::getTitleFor( 'CreatePage', 
$title->getPrefixedText() );
+   $redirTo = SpecialPage::getTitleFor( 'CreatePage' );
$output = $editPage->getContext()->getOutput();
-   $output->redirect( $redirTo->getFullURL() );
+   $output->redirect( $redirTo->getFullURL( [ 'page' => 
$title->getPrefixedText() ] ) );
 
return false;
}
diff --git a/includes/SpecialCreatePage.php b/includes/SpecialCreatePage.php
index 5d28acb..bc48154 100644
--- a/includes/SpecialCreatePage.php
+++ b/includes/SpecialCreatePage.php
@@ -36,7 +36,7 @@
->makeConfig( 'ArticleCreationWorkflow' );
$workflow = new Workflow( $config );
 
-   $destTitle = Title::newFromText( $subPage );
+   $destTitle = Title::newFromText( $this->getRequest()->getText( 
'page' ) );
$destTitleText = $destTitle ? $destTitle->getPrefixedText() : 
'';
$landingPageMessage = $workflow->getLandingPageMessage();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib632f87f98586e937f504630bf9856ad5d352583
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372892 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Iac0b120ccda77065a480e9461e7fcbd19d55f1db
---
M tests/phpunit/DiscussionParserTest.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/DiscussionParserTest.php 
b/tests/phpunit/DiscussionParserTest.php
index 07122a5..35da3fa 100644
--- a/tests/phpunit/DiscussionParserTest.php
+++ b/tests/phpunit/DiscussionParserTest.php
@@ -1,6 +1,7 @@
 https://gerrit.wikimedia.org/r/372892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac0b120ccda77065a480e9461e7fcbd19d55f1db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Use non-deprecated namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371632 )

Change subject: Use non-deprecated namespaced ScopedCallback
..


Use non-deprecated namespaced ScopedCallback

Change-Id: Id336c142b57955b7d221735313bd7e828347172c
---
M includes/Mechanism.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Mechanism.php b/includes/Mechanism.php
index c4c0810..2770eec 100644
--- a/includes/Mechanism.php
+++ b/includes/Mechanism.php
@@ -2,6 +2,8 @@
 
 namespace MediaWiki\ParserMigration;
 
+use Wikimedia\ScopedCallback;
+
 class Mechanism {
public $tidiers;
 
@@ -19,7 +21,7 @@
$options->setTidy( false );
$scopedCallback = $options->setupFakeRevision( $title, 
$content, $user );
$parserOutput = $content->getParserOutput( $title, null, 
$options );
-   \ScopedCallback::consume( $scopedCallback );
+   ScopedCallback::consume( $scopedCallback );
 
$outputs = [];
foreach ( $configIndexes as $i ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/371632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id336c142b57955b7d221735313bd7e828347172c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserMigration
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[wmf/1.30.0-wmf.14]: Fix typo in the notification message

[Niharika29 (Code Review)]

Niharika29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372902 )

Change subject: Fix typo in the notification message
..

Fix typo in the notification message

Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
(cherry picked from commit 7a85836fb7afd6017d38d83420a13e65525af8e4)
---
M i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify 
refs/changes/02/372902/1

diff --git a/i18n/en.json b/i18n/en.json
index f72b7f1..e236635 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -16,6 +16,6 @@
"notification-loginnotify-login-success-email-subject": "Login to 
{{SITENAME}} as $1 from a computer you have not recently used",
"notification-header-login-success": "Someone (probably 
{{GENDER:$1|you}}) recently logged in to your account from a new device. If 
this was you, then you can disregard this message. If it wasn't you, then it's 
recommended that you change your password, and check your account activity.",
"notification-new-bundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to 
your account from a new device since the last time you logged in. If it wasn't 
you, please make sure your account has a strong password.",
-   "notification-known-header-login-fail": "There have been 
{{PLURAL:$1|has been '''a failed attempt'''|have been '''$1 failed 
attempts'''}} to log in to your account since the last time you logged in. If 
it wasn't you, please make sure your account has a strong password.",
+   "notification-known-header-login-fail": "There {{PLURAL:$1|has been 
'''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to your 
account since the last time you logged in. If it wasn't you, please make sure 
your account has a strong password.",
"notification-new-unbundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''multiple failed attempts'''}} to log 
in to your account from a new device. Please make sure your account has a 
strong password."
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: wmf/1.30.0-wmf.14
Gerrit-Owner: Niharika29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372893 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
---
M engines/LuaCommon/LuaCommon.php
M tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 33f8b37..954c60d 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -1,5 +1,7 @@
 https://gerrit.wikimedia.org/r/372893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372888 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ib9a1496df79a139ee6202440ff2aac4f9e647e79
---
M includes/Handlers/Xml/XmlHandler.php
M includes/Jobs/UploadMediafileJob.php
M includes/Jobs/UploadMetadataJob.php
3 files changed, 5 insertions(+), 4 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Handlers/Xml/XmlHandler.php 
b/includes/Handlers/Xml/XmlHandler.php
index af35ce2..628226a 100644
--- a/includes/Handlers/Xml/XmlHandler.php
+++ b/includes/Handlers/Xml/XmlHandler.php
@@ -13,6 +13,7 @@
 use GWToolset\Helpers\GWTFileBackend;
 use Html;
 use MWException;
+use Wikimedia\ScopedCallback;
 use XMLReader;
 
 abstract class XmlHandler {
@@ -130,7 +131,7 @@
}
 
// Make sure close() is called if exceptions occur
-   $xmlCloser = new \ScopedCallback( function () use ( $XMLReader 
) {
+   $xmlCloser = new ScopedCallback( function () use ( $XMLReader ) 
{
$XMLReader->close();
} );
 
@@ -170,7 +171,7 @@
);
}
 
-   \ScopedCallback::cancel( $xmlCloser ); // done already
+   ScopedCallback::cancel( $xmlCloser ); // done already
 
return $result;
}
diff --git a/includes/Jobs/UploadMediafileJob.php 
b/includes/Jobs/UploadMediafileJob.php
index ceb3424..7ffeeb3 100755
--- a/includes/Jobs/UploadMediafileJob.php
+++ b/includes/Jobs/UploadMediafileJob.php
@@ -19,10 +19,10 @@
 use GWToolset\Models\Metadata;
 use GWToolset\Utils;
 use Job;
-use ScopedCallback;
 use Title;
 use User;
 use RequestContext;
+use Wikimedia\ScopedCallback;
 
 class UploadMediafileJob extends Job {
 
diff --git a/includes/Jobs/UploadMetadataJob.php 
b/includes/Jobs/UploadMetadataJob.php
index 5577bcc..2ade543 100644
--- a/includes/Jobs/UploadMetadataJob.php
+++ b/includes/Jobs/UploadMetadataJob.php
@@ -21,7 +21,7 @@
 use Title;
 use User;
 use RequestContext;
-use ScopedCallback;
+use Wikimedia\ScopedCallback;
 
 /**
  * runs the MetadataMappingHandler with the originally $_POST’ed form fields 
when

-- 
To view, visit https://gerrit.wikimedia.org/r/372888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9a1496df79a139ee6202440ff2aac4f9e647e79
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372894 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: I263a28990fb73ab8c3084d1cbde51d4ce062068d
---
M TemplateSandboxLogic.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TemplateSandboxLogic.php b/TemplateSandboxLogic.php
index 0bdad0c..2c74050 100644
--- a/TemplateSandboxLogic.php
+++ b/TemplateSandboxLogic.php
@@ -1,4 +1,7 @@
 https://gerrit.wikimedia.org/r/372894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I263a28990fb73ab8c3084d1cbde51d4ce062068d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateSandbox
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CommonsMetadata[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372890 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ia8f646de33f14d280a351d4ed7317dc2ea12434f
---
M DataCollector.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/DataCollector.php b/DataCollector.php
index 94416ac..d695c01 100644
--- a/DataCollector.php
+++ b/DataCollector.php
@@ -8,7 +8,7 @@
 use LocalFile;
 use ForeignAPIFile;
 use WikiFilePage;
-use ScopedCallback;
+use Wikimedia\ScopedCallback;
 
 /**
  * Class to handle metadata collection and formatting, and manage more 
specific data extraction

-- 
To view, visit https://gerrit.wikimedia.org/r/372890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8f646de33f14d280a351d4ed7317dc2ea12434f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommonsMetadata
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Don't hard-code Preferences page name

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372805 )

Change subject: Don't hard-code Preferences page name
..


Don't hard-code Preferences page name

This fixes the restore-prefs link by switching to use whatever
the current title of the PreferencesForm is.

Bug: T173682
Change-Id: I67a13269a63f719a011a2d59a07493d9eb6b653b
---
M includes/Preferences.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Preferences.php b/includes/Preferences.php
index c74d6e1..04a3637 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1682,7 +1682,7 @@
$html = parent::getButtons();
 
if ( $this->getModifiedUser()->isAllowed( 'editmyoptions' ) ) {
-   $t = SpecialPage::getTitleFor( 'Preferences', 'reset' );
+   $t = $this->getTitle()->getSubpage( 'reset' );
 
$linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
$html .= "\n" . $linkRenderer->makeLink( $t, 
$this->msg( 'restoreprefs' )->text(),

-- 
To view, visit https://gerrit.wikimedia.org/r/372805
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67a13269a63f719a011a2d59a07493d9eb6b653b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Samwilson 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Niharika29 
Gerrit-Reviewer: Samwilson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update link to contributing guidelines

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372901 )

Change subject: Update link to contributing guidelines
..


Update link to contributing guidelines

Change-Id: I7fd9ad2cbcda0ee1f2ac6ee3f0a6c16a2cb44a7b
---
M CONTRIBUTING.md
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e57316d..ddb70a2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -3,7 +3,7 @@
 Thank you for helping us develop VisualEditor!
 
 We inherit the contribution guidelines from VisualEditor core. Be sure to read 
the
-[Contribution 
guidelines](https://git.wikimedia.org/blob/VisualEditor%2FVisualEditor.git/master/CONTRIBUTING.md)
+[Contribution 
guidelines](https://phabricator.wikimedia.org/diffusion/GVED/browse/master/CONTRIBUTING.md)
 in the VisualEditor repository.
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fd9ad2cbcda0ee1f2ac6ee3f0a6c16a2cb44a7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Arlolra 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update link to contributing guidelines

[Arlolra (Code Review)]

Arlolra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372901 )

Change subject: Update link to contributing guidelines
..

Update link to contributing guidelines

Change-Id: I7fd9ad2cbcda0ee1f2ac6ee3f0a6c16a2cb44a7b
---
M CONTRIBUTING.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/01/372901/1

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e57316d..ddb70a2 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -3,7 +3,7 @@
 Thank you for helping us develop VisualEditor!
 
 We inherit the contribution guidelines from VisualEditor core. Be sure to read 
the
-[Contribution 
guidelines](https://git.wikimedia.org/blob/VisualEditor%2FVisualEditor.git/master/CONTRIBUTING.md)
+[Contribution 
guidelines](https://phabricator.wikimedia.org/diffusion/GVED/browse/master/CONTRIBUTING.md)
 in the VisualEditor repository.
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fd9ad2cbcda0ee1f2ac6ee3f0a6c16a2cb44a7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Arlolra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Make sure referenced file exists

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372882 )

Change subject: Make sure referenced file exists
..


Make sure referenced file exists

Change-Id: I9fd767646f1b02cf9ca0865a0d7ed9823929f839
---
A skinStyles/mobile.startup/images/error.svg
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/skinStyles/mobile.startup/images/error.svg 
b/skinStyles/mobile.startup/images/error.svg
new file mode 100644
index 000..1317ec6
--- /dev/null
+++ b/skinStyles/mobile.startup/images/error.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/372882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd767646f1b02cf9ca0865a0d7ed9823929f839
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: Adding dns entries for labvirt1019-20 T172538

[Cmjohnson (Code Review)]

Cmjohnson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372390 )

Change subject: Adding dns entries for labvirt1019-20 T172538
..


Adding dns entries for labvirt1019-20 T172538

Change-Id: I0503a45108872cca43edcd5f10b518fb60bf89a6
---
M templates/10.in-addr.arpa
M templates/wmnet
2 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Cmjohnson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/10.in-addr.arpa b/templates/10.in-addr.arpa
index 1734a04..9b50f1f 100644
--- a/templates/10.in-addr.arpa
+++ b/templates/10.in-addr.arpa
@@ -679,6 +679,8 @@
 35  1H IN PTR   labnet1003.eqiad.wmnet.
 36  1H IN PTR   labnet1004.eqiad.wmnet.
 37  1H IN PTR   labnodepool1002.eqiad.wmnet.
+38  1H IN PTR   labvirt1019.eqiad.wmnet.
+39  1H IN PTR   labvirt1020.eqiad.wmnet.
 
 ; 10.64.21.0/24 - analytics1-b-eqiad
 $ORIGIN 21.64.{{ zonename }}.
@@ -2308,6 +2310,16 @@
 74  1H  IN PTR  wmf7070.mgmt.eqiad.wmnet.
 75  1H  IN PTR  ganeti1008.mgmt.eqiad.wmnet.
 75  1H  IN PTR  wmf7071.mgmt.eqiad.wmnet.
+76  1H  IN PTR  labvirt1019.mgmt.eqiad.wmnet.
+76  1H  IN PTR  wmf7132.mgmt.eqiad.wmnet.
+77  1H  IN PTR  labvirt1020.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
+77  1H  IN PTR  wmf7133.mgmt.eqiad.wmnet.
 
 180 1H  IN PTR  wmf4540.mgmt.eqiad.wmnet.
 180 1H  IN PTR  analytics1001.mgmt.eqiad.wmnet.
diff --git a/templates/wmnet b/templates/wmnet
index 79ee1b8..c6df538 100644
--- a/templates/wmnet
+++ b/templates/wmnet
@@ -890,6 +890,8 @@
 labvirt1016 1H  IN A10.64.20.32
 labvirt1017 1H  IN A10.64.20.33
 labvirt1018 1H  IN A10.64.20.34
+labvirt1019 1H  IN A10.64.20.38
+labvirt1020 1H  IN A10.64.20.39
 wdqs10011H  IN A10.64.48.112
 wdqs10021H  IN A10.64.32.183
 wdqs10031H  IN A10.64.0.14
@@ -1148,6 +1150,10 @@
 wmf7087 1H  IN A10.65.5.68
 labvirt1018 1H  IN A10.65.5.69
 wmf7088 1H  IN A10.65.5.69
+labvirt1019 1H  IN A10.65.5.76
+wmf7132 1H  IN A10.65.5.76
+labvirt1020 1H  IN A10.65.5.77
+wmf7133 1H  IN A10.65.5.77
 labweb1001  1H  IN A10.65.4.121
 wmf7096 1H  IN A10.65.4.121
 labweb1002  1H  IN A10.65.4.122

-- 
To view, visit https://gerrit.wikimedia.org/r/372390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0503a45108872cca43edcd5f10b518fb60bf89a6
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Cmjohnson 
Gerrit-Reviewer: Cmjohnson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: Setting namecheap/comodo CAA records

[RobH (Code Review)]

RobH has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372900 )

Change subject: Setting namecheap/comodo CAA records
..

Setting namecheap/comodo CAA records

policy.wikimedia.org will allow namecheap/comodo to issue certificates
for policy.wikimedia.org only via CAA record

Bug: T173787
Change-Id: I3d961abe468ed734aade22726672fc22618ffe96
---
M templates/wikimedia.org
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dns 
refs/changes/00/372900/1

diff --git a/templates/wikimedia.org b/templates/wikimedia.org
index 429e101..9679cef 100644
--- a/templates/wikimedia.org
+++ b/templates/wikimedia.org
@@ -62,6 +62,11 @@
 wikimedia.org.  5M  IN TYPE257 \# 19 0005697373756564696769636572742E636F6D
 wikimedia.org.  5M  IN TYPE257 \# 22 
000569737375656C657473656E63727970742E6F7267
 wikimedia.org.  5M  IN TYPE257 \# 37 
0005696F6465666D61696C746F3A646E732D61646D696E4077696B696D656469612E6F7267
+; issue comodo.com, iodef mailto:dns-ad...@wikimedia.org
+; cf. https://sslmate.com/labs/caa/
+policy.wikimedia.org.  5M  IN TYPE257  \# 19 
00056973737565636F6D6F646F63612E636F6D
+policy.wikimedia.org.  5M  IN TYPE257  \# 12 0009697373756577696C643B
+policy.wikimedia.org.  5M  IN TYPE257  \# 37 
0005696F6465666D61696C746F3A646E732D61646D696E4077696B696D656469612E6F7267
 
 dumps   1H  IN CNAME dataset1001
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d961abe468ed734aade22726672fc22618ffe96
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: RobH 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Further simplify bottom gradient on lead images.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372899 )

Change subject: Further simplify bottom gradient on lead images.
..

Further simplify bottom gradient on lead images.

Change-Id: Id35860cc3fd12366d19bece361961a081e538e4d
---
M app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java
M app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java
M app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
M app/src/main/java/org/wikipedia/util/GradientUtil.java
M app/src/main/res/layout/view_page_header_image.xml
5 files changed, 14 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/99/372899/1

diff --git a/app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java 
b/app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java
index be902f0..ab222b6 100644
--- a/app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java
+++ b/app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java
@@ -8,7 +8,6 @@
 
 import org.wikipedia.R;
 import org.wikipedia.util.DimenUtil;
-import org.wikipedia.util.GradientUtil;
 
 public class PageToolbarHideHandler extends ViewHideHandler {
 private static final int FULL_OPACITY = 255;
@@ -16,7 +15,6 @@
 private boolean fadeEnabled;
 private boolean forceNoFade;
 @NonNull private final Drawable toolbarBackground;
-private Drawable toolbarGradient;
 @NonNull private final Drawable statusBar;
 
 public PageToolbarHideHandler(@NonNull View hideableView) {
@@ -24,7 +22,6 @@
 
 LayerDrawable toolbarBackgroundLayers = (LayerDrawable) 
hideableView.getBackground();
 toolbarBackground = 
toolbarBackgroundLayers.findDrawableByLayerId(R.id.toolbar_background_solid).mutate();
-initToolbarGradient(toolbarBackgroundLayers);
 
 statusBar = 
hideableView.findViewById(R.id.empty_status_bar).getBackground().mutate();
 }
@@ -53,13 +50,7 @@
 protected void onScrolled(int oldScrollY, int scrollY) {
 int opacity = calculateScrollOpacity(scrollY);
 toolbarBackground.setAlpha(opacity);
-toolbarGradient.setAlpha(FULL_OPACITY - opacity);
 statusBar.setAlpha(opacity);
-}
-
-private void initToolbarGradient(LayerDrawable toolbarBackgroundLayers) {
-toolbarGradient = 
GradientUtil.getPowerGradient(R.color.lead_gradient_start, Gravity.TOP);
-
toolbarBackgroundLayers.setDrawableByLayerId(R.id.toolbar_background_gradient, 
toolbarGradient);
 }
 
 /** @return Alpha value between 0 and 0xff. */
diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java 
b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java
index 2fefdfd..63b727a 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java
@@ -3,7 +3,6 @@
 import android.annotation.TargetApi;
 import android.content.Context;
 import android.graphics.PointF;
-import android.graphics.drawable.Drawable;
 import android.net.Uri;
 import android.os.Build;
 import android.support.annotation.Nullable;
@@ -24,7 +23,8 @@
 
 public class PageHeaderImageView extends FrameLayout {
 @BindView(R.id.view_page_header_image_image) FaceAndColorDetectImageView 
image;
-@BindView(R.id.view_page_header_image_gradient) View gradientView;
+@BindView(R.id.view_page_header_image_gradient_top) View topGradientView;
+@BindView(R.id.view_page_header_image_gradient_bottom) View 
bottomGradientView;
 
 public PageHeaderImageView(Context context) {
 super(context);
@@ -87,7 +87,7 @@
 inflate(getContext(), R.layout.view_page_header_image, this);
 ButterKnife.bind(this);
 
-Drawable gradient = getPowerGradient(R.color.new_lead_gradient_start, 
Gravity.BOTTOM);
-ViewUtil.setBackgroundDrawable(gradientView, gradient);
+ViewUtil.setBackgroundDrawable(topGradientView, 
getPowerGradient(R.color.new_lead_gradient_start, Gravity.TOP));
+ViewUtil.setBackgroundDrawable(bottomGradientView, 
getPowerGradient(R.color.new_lead_gradient_start, Gravity.BOTTOM));
 }
 }
diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java 
b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
index 17bc581..8347673 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
@@ -61,7 +61,7 @@
 
 public class PageHeaderView extends FrameLayout implements 
ObservableWebView.OnScrollChangeListener {
 @BindView(R.id.view_page_header_image) PageHeaderImageView image;
-@BindView(R.id.view_page_header_image_gradient) View gradient;
+@BindView(R.id.view_page_header_image_gradient_bottom) View bottomGradient;
   

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Remove some PHP 5.3 compat code

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372898 )

Change subject: Remove some PHP 5.3 compat code
..

Remove some PHP 5.3 compat code

Change-Id: I433ab9754606e2cbbaef534a1a5b70bad9b9387c
---
M engines/LuaCommon/LuaCommon.php
M engines/LuaCommon/TextLibrary.php
M engines/LuaCommon/UstringLibrary.php
M engines/LuaStandalone/LuaStandaloneEngine.php
M i18n/en.json
M i18n/qqq.json
6 files changed, 12 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/98/372898/1

diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 954c60d..335476f 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -245,13 +245,9 @@
];
$this->expandCache = [];
 
-   // @todo Once support for PHP 5.3 (MW < 1.27) is dropped, lose 
$ref and just use
-   // $this->currentFrames directly in the callback.
-   $ref = &$this->currentFrames;
-   $ref2 = &$this->expandCache;
-   return new ScopedCallback( function () use ( &$ref, &$ref2, 
$oldFrames, $oldExpandCache ) {
-   $ref = $oldFrames;
-   $ref2 = $oldExpandCache;
+   return new ScopedCallback( function () use ( $oldFrames, 
$oldExpandCache ) {
+   $this->currentFrames = $oldFrames;
+   $this->expandCache = $oldExpandCache;
} );
}
 
diff --git a/engines/LuaCommon/TextLibrary.php 
b/engines/LuaCommon/TextLibrary.php
index df55fc5..5453ed9 100644
--- a/engines/LuaCommon/TextLibrary.php
+++ b/engines/LuaCommon/TextLibrary.php
@@ -62,11 +62,7 @@
}
 
function getEntityTable() {
-   $flags = ENT_QUOTES;
-   // PHP 5.3 compat
-   if ( defined( "ENT_HTML5" ) ) {
-   $flags |= constant( "ENT_HTML5" );
-   }
+   $flags = ENT_QUOTES | ENT_HTML5;
$table = array_flip( get_html_translation_table( HTML_ENTITIES, 
$flags, "UTF-8" ) );
return [ $table ];
}
diff --git a/engines/LuaCommon/UstringLibrary.php 
b/engines/LuaCommon/UstringLibrary.php
index d651672..9c7b62c 100644
--- a/engines/LuaCommon/UstringLibrary.php
+++ b/engines/LuaCommon/UstringLibrary.php
@@ -16,13 +16,6 @@
private $stringLengthLimit = null;
 
/**
-* PHP 5.3's mb_check_encoding does not reject characters above 
U+10.
-* When using that version, we'll need to check that manually.
-* @var boolean
-*/
-   private $manualCheckForU11AndUp = false;
-
-   /**
 * PHP until 5.6.9 are buggy when the regex in preg_replace an
 * preg_match_all matches the empty string.
 * @var boolean
@@ -41,7 +34,6 @@
$this->stringLengthLimit = $wgMaxArticleSize * 1024;
}
 
-   $this->manualCheckForU11AndUp = mb_check_encoding( 
"\xf4\x90\x80\x80", "UTF-8" );
$this->phpBug53823 = preg_replace( '//us', 'x', "\xc3\xa1" ) 
=== "x\xc3x\xa1x";
$this->patternRegexCache = new MapCacheLRU( 100 );
 
@@ -89,22 +81,12 @@
] );
}
 
-   // Once we no longer support PHP < 5.4, calls to this method may be 
replaced with
-   // mb_check_encoding( $s, 'UTF-8' )
-   private function checkEncoding( $s ) {
-   $ok = mb_check_encoding( $s, 'UTF-8' );
-   if ( $ok && $this->manualCheckForU11AndUp ) {
-   $ok = !preg_match( '/\xf4[\x90-\xbf]|[\xf5-\xff]/', $s 
);
-   }
-   return $ok;
-   }
-
private function checkString( $name, $s, $checkEncoding = true ) {
if ( $this->getLuaType( $s ) == 'number' ) {
$s = (string)$s;
} else {
$this->checkType( $name, 1, $s, 'string' );
-   if ( $checkEncoding && !$this->checkEncoding( $s ) ) {
+   if ( $checkEncoding && !mb_check_encoding( $s, 'UTF-8' 
) ) {
throw new Scribunto_LuaError( "bad argument #1 
to '$name' (string is not UTF-8)" );
}
if ( strlen( $s ) > $this->stringLengthLimit ) {
@@ -117,7 +99,7 @@
 
public function ustringIsUtf8( $s ) {
$this->checkString( 'isutf8', $s, false );
-   return [ $this->checkEncoding( $s ) ];
+   return [ mb_check_encoding( $s, 'UTF-8' ) ];
}
 
public function ustringByteoffset( $s, $l = 1, $i = 1 ) {
@@ -175,7 +157,7 @@
 
public function ustringToNFC( $s ) {
$this->checkString( 'toNFC', $s, false );
-   if ( !$this->checkEncoding( $s ) ) {
+ 

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Don't use tab indenting between array items

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372871 )

Change subject: Don't use tab indenting between array items
..


Don't use tab indenting between array items

Change-Id: Ifbc293c5075c6518edbefd5d7c4b6ce2cd71ace3
---
M resources/mode/mediawiki/mediawiki.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Niharika29: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mode/mediawiki/mediawiki.js 
b/resources/mode/mediawiki/mediawiki.js
index bc044df..ddc68da 100644
--- a/resources/mode/mediawiki/mediawiki.js
+++ b/resources/mode/mediawiki/mediawiki.js
@@ -33,7 +33,7 @@
rp: true, rt: true, rtc: true, p: true, span: 
true, abbr: true, dfn: true,
kbd: true, samp: true, data: true, time: true, 
mark: true, br: true,
wbr: true, hr: true, li: true, dt: true, dd: 
true, td: true, th: true,
-   tr: true,   noinclude: true, includeonly: 
true, onlyinclude: true },
+   tr: true, noinclude: true, includeonly: true, 
onlyinclude: true },
isBold, isItalic, firstsingleletterword, 
firstmultiletterword, firstspace, mBold, mItalic, mTokens = [],
mStyle;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbc293c5075c6518edbefd5d7c4b6ce2cd71ace3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Niharika29 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: cleanup empty spaces

[Yurik (Code Review)]

Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372897 )

Change subject: cleanup empty spaces
..

cleanup empty spaces

Change-Id: Id7278b01730455353a8b7c3bf94a416abfcdb415
---
M examples/dialog.html
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/97/372897/1

diff --git a/examples/dialog.html b/examples/dialog.html
index 22f76a4..577a34a 100644
--- a/examples/dialog.html
+++ b/examples/dialog.html
@@ -24,9 +24,9 @@



-   
+
Dialog
-   
+



@@ -49,12 +49,12 @@



-   
+

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Add tidy-whitespace-bug category to the stats tool

[Subramanya Sastry (Code Review)]

Subramanya Sastry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372895 )

Change subject: Add tidy-whitespace-bug category to the stats tool
..

Add tidy-whitespace-bug category to the stats tool

Change-Id: I1035e4e96aa467c9b09fe731d922ff99b7b1ac4a
---
M tools/compare.linter.results.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/95/372895/1

diff --git a/tools/compare.linter.results.js b/tools/compare.linter.results.js
index 7f70354..2a93e8a 100755
--- a/tools/compare.linter.results.js
+++ b/tools/compare.linter.results.js
@@ -79,6 +79,7 @@
"deletable-table-tag",
"pwrap-bug-workaround",
"self-closed-tag",
+   "tidy-whitespace-bug",
 ];
 
 var argv = opts.argv;

-- 
To view, visit https://gerrit.wikimedia.org/r/372895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1035e4e96aa467c9b09fe731d922ff99b7b1ac4a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Linter: Tweak tidy-whitespace-bug output

[Subramanya Sastry (Code Review)]

Subramanya Sastry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372896 )

Change subject: Linter: Tweak tidy-whitespace-bug output
..

Linter: Tweak tidy-whitespace-bug output

* Before this patch, we were reporting all instances of affected
  whitespace. However, with short strings, there is no real issue
  with rendering unless the viewport is small. So, in this patch,
  I am implementing a heuristic that triggers this linter issue
  only if the affected string is of a particular length.

* Updated mocha tests.

Change-Id: I15d401e9a9b649723ae3bfc3598d02e8a619a9ec
---
M lib/config/ParsoidConfig.js
M lib/wt2html/pp/handlers/linter.js
M tests/mocha/linter.js
3 files changed, 94 insertions(+), 57 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/96/372896/1

diff --git a/lib/config/ParsoidConfig.js b/lib/config/ParsoidConfig.js
index 7ad..4958257 100644
--- a/lib/config/ParsoidConfig.js
+++ b/lib/config/ParsoidConfig.js
@@ -249,6 +249,18 @@
  */
 ParsoidConfig.prototype.linterAPISampling = 1;
 
+ParsoidConfig.prototype.linter = {
+   /**
+* @property {number} tidyWhiteSpaceBugMaxLength
+*
+* Max length of content covered by 'white-space:nowrap' CSS
+* that we consider "safe" when Tidy is replaced. Beyond that,
+* wikitext will have to be fixed up to manually insert whitespace
+* at the right places.
+*/
+   tidyWhitespaceBugMaxLength: 100,
+};
+
 /**
  * @property {Function} loggerBackend
  * The logger output function.
diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index d4e2e7d..b6fc76c 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -433,66 +433,79 @@
}
 }
 
-function logTidyWhitespaceBug(env, node, dp, tplInfo) {
-   if (DU.isBlockNode(node)) {
-   // Nothing to worry
-   return;
-   }
-
-   if (!hasNoWrapCSS(node)) {
-   // no CSS property that affects whitespcae
-   return;
-   }
-
-   // Find next non-comment sibling of 'node'
-   var next = node.nextSibling;
-   while (next && DU.isComment(next)) {
-   next = next.nextSibling;
-   }
-
-   if (!next || DU.isBlockNode(next) || (DU.isText(next) && 
/^\s/.test(next.data))) {
-   // All good! No text/inline-node sibling
-   return;
-   }
-
+function lastNonCommentNode(node) {
// Find last non-comment child of 'node'
var last = node.lastChild;
while (last && DU.isComment(last)) {
last = last.previousSibling;
}
+}
 
-   if (!last || !DU.isText(last) || !/\s$/.test(last.data)) {
-   // All good! No whitespace for Tidy to hoist out
-   return;
+function logTidyWhitespaceBug(env, node, dp, tplInfo) {
+   // FIXME: Potential for O(n^2) behavior in really bad cases
+
+   var nowrapNodes = [];
+   var startNode = node;
+   while (node && !DU.isBlockNode(node)) {
+   if (DU.isText(node) || !hasNoWrapCSS(node)) {
+   // No CSS property that affects whitespace.
+   if (nowrapNodes.length > 0 && 
!/^\s/.test(node.textContent)) {
+   nowrapNodes.push(node);
+   }
+   break;
+   }
+
+   // Find last non-comment child of 'node'
+   var last = node.lastChild;
+   while (last && DU.isComment(last)) {
+   last = last.previousSibling;
+   }
+
+   if (!last || !DU.isText(last) || !/\s$/.test(last.data)) {
+   // All good! No whitespace for Tidy to hoist out
+   break;
+   }
+
+   // In this scenario, when Tidy hoists the whitespace to
+   // after the node, that whitespace is not subject to the
+   // nowrap CSS => browsers can break content there.
+   //
+   // But, non-Tidy libraries won't hoist the whitespace.
+   // So, browsers don't have a place to break content.
+   //
+   // Track the nodes that are subject to this problem.
+   nowrapNodes.push(node);
+
+   node = node.nextSibling;
+
+   // Skip comments
+   while (node && DU.isComment(node)) {
+   node = node.nextSibling;
+   }
}
 
-   // So, we have:
-   // * two inline siblings without whitespace between then,
-   // * the left sibling has nowrap CSS
-   // * the left sibling has trailing whitespace
-   //
-   // In this scenario, when Tidy hoists the whitespace to
-   // after the left sibling, that whitespace is not subject
-   // to 

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372894 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: I263a28990fb73ab8c3084d1cbde51d4ce062068d
---
M TemplateSandboxLogic.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateSandbox 
refs/changes/94/372894/1

diff --git a/TemplateSandboxLogic.php b/TemplateSandboxLogic.php
index 0bdad0c..2c74050 100644
--- a/TemplateSandboxLogic.php
+++ b/TemplateSandboxLogic.php
@@ -1,4 +1,7 @@
 https://gerrit.wikimedia.org/r/372894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I263a28990fb73ab8c3084d1cbde51d4ce062068d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateSandbox
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372893 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
---
M engines/LuaCommon/LuaCommon.php
M tests/phpunit/engines/LuaCommon/UstringLibraryTest.php
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/93/372893/1

diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 33f8b37..954c60d 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -1,5 +1,7 @@
 https://gerrit.wikimedia.org/r/372893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb3fed78882913a26aad4bdb1a84cb5a3e8ca6bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Use namespaced IDatabase in documentation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372096 )

Change subject: Use namespaced IDatabase in documentation
..


Use namespaced IDatabase in documentation

Change-Id: Ieeb78b2db41caa81308e8b8b29cb833fe6023339
---
M AntiSpoof/CentralAuthSpoofUser.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/AntiSpoof/CentralAuthSpoofUser.php 
b/AntiSpoof/CentralAuthSpoofUser.php
index 96a0e04..51d0f96 100644
--- a/AntiSpoof/CentralAuthSpoofUser.php
+++ b/AntiSpoof/CentralAuthSpoofUser.php
@@ -1,5 +1,7 @@
 https://gerrit.wikimedia.org/r/372096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb78b2db41caa81308e8b8b29cb833fe6023339
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LdapAuthentication[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372889 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: I289f5d6a98f29d1d5df122fd261defe501347c5a
---
M LdapPrimaryAuthenticationProvider.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/LdapPrimaryAuthenticationProvider.php 
b/LdapPrimaryAuthenticationProvider.php
index a3bcf6b..b86f7b0 100644
--- a/LdapPrimaryAuthenticationProvider.php
+++ b/LdapPrimaryAuthenticationProvider.php
@@ -27,6 +27,7 @@
 use MediaWiki\Auth\PasswordAuthenticationRequest;
 use MediaWiki\Auth\PasswordDomainAuthenticationRequest;
 use MediaWiki\Auth\AuthenticationResponse;
+use Wikimedia\ScopedCallback;
 
 /**
  * Primary authentication provider wrapper for LdapAuthentication

-- 
To view, visit https://gerrit.wikimedia.org/r/372889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I289f5d6a98f29d1d5df122fd261defe501347c5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372892 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Iac0b120ccda77065a480e9461e7fcbd19d55f1db
---
M tests/phpunit/DiscussionParserTest.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/92/372892/1

diff --git a/tests/phpunit/DiscussionParserTest.php 
b/tests/phpunit/DiscussionParserTest.php
index 07122a5..35da3fa 100644
--- a/tests/phpunit/DiscussionParserTest.php
+++ b/tests/phpunit/DiscussionParserTest.php
@@ -1,6 +1,7 @@
 https://gerrit.wikimedia.org/r/372892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac0b120ccda77065a480e9461e7fcbd19d55f1db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Ignore sticky filters when emptying all filters

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372891 )

Change subject: RCFilters: Ignore sticky filters when emptying all filters
..

RCFilters: Ignore sticky filters when emptying all filters

Also, as a bonus, actually connect the 'update' event to the already
existing method that was supposed to respond to an update event on
the 'enhanced' filter.

Bug: T172580
Change-Id: I4db5689d1d2ef627bbb5ec34f8af772157d1ff09
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/372891/1

diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index cf226da..a8ee06b 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -793,7 +793,9 @@
 */
mw.rcfilters.dm.FiltersViewModel.prototype.emptyAllFilters = function 
() {
this.getItems().forEach( function ( filterItem ) {
-   this.toggleFilterSelected( filterItem.getName(), false 
);
+   if ( !filterItem.getGroupModel().isSticky() ) {
+   this.toggleFilterSelected( 
filterItem.getName(), false );
+   }
}.bind( this ) );
};
 
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js
index a8c6c28..7248bd7 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js
@@ -32,6 +32,7 @@
// Events
this.valuePicker.connect( this, { choose: [ 'emit', 'limit' ] } 
);
this.groupByPageCheckbox.connect( this, { change: [ 'emit', 
'groupByPage' ] } );
+   this.groupByPageItemModel.connect( this, { update: 
'onGroupByPageModelUpdate' } );
 
// Initialize
this.$element

-- 
To view, visit https://gerrit.wikimedia.org/r/372891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db5689d1d2ef627bbb5ec34f8af772157d1ff09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CommonsMetadata[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372890 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ia8f646de33f14d280a351d4ed7317dc2ea12434f
---
M DataCollector.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommonsMetadata 
refs/changes/90/372890/1

diff --git a/DataCollector.php b/DataCollector.php
index 94416ac..d695c01 100644
--- a/DataCollector.php
+++ b/DataCollector.php
@@ -8,7 +8,7 @@
 use LocalFile;
 use ForeignAPIFile;
 use WikiFilePage;
-use ScopedCallback;
+use Wikimedia\ScopedCallback;
 
 /**
  * Class to handle metadata collection and formatting, and manage more 
specific data extraction

-- 
To view, visit https://gerrit.wikimedia.org/r/372890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8f646de33f14d280a351d4ed7317dc2ea12434f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommonsMetadata
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LdapAuthentication[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372889 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: I289f5d6a98f29d1d5df122fd261defe501347c5a
---
M LdapPrimaryAuthenticationProvider.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LdapAuthentication 
refs/changes/89/372889/1

diff --git a/LdapPrimaryAuthenticationProvider.php 
b/LdapPrimaryAuthenticationProvider.php
index a3bcf6b..b86f7b0 100644
--- a/LdapPrimaryAuthenticationProvider.php
+++ b/LdapPrimaryAuthenticationProvider.php
@@ -27,6 +27,7 @@
 use MediaWiki\Auth\PasswordAuthenticationRequest;
 use MediaWiki\Auth\PasswordDomainAuthenticationRequest;
 use MediaWiki\Auth\AuthenticationResponse;
+use Wikimedia\ScopedCallback;
 
 /**
  * Primary authentication provider wrapper for LdapAuthentication

-- 
To view, visit https://gerrit.wikimedia.org/r/372889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I289f5d6a98f29d1d5df122fd261defe501347c5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Define more precisely the set of existing wikis

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372884 )

Change subject: Define more precisely the set of existing wikis
..


Define more precisely the set of existing wikis

Given there are two mechanism to check if a wiki exists (“variables” files and
“versions” file) and given the two mechanisms answer “possibly existing” if a
wiki is not registered in their mechanism, it was possible to define ghost
wikis, registered nowhere but with some default coarse-defined parameters (MW
parameters like a default database for a suffix, catching there all ghost
wikis).

This commit fixes this odd behaviour: wikis must be defined in at least one of
the two mechanisms (the first mechanism has precedence). More precisely either
the 'wikiID' is defined with at least one identifying variable checked against
a file of existing values, either the ”versions“ file must contain the wikiID.

BTW, remove the need to define the “variables” mechanism (it is possible to
entirely rely on the “versions” mechanism); it will be a bit more easier to
setup a basic installation as described in the “Quick start” guide.

Beyond this improvement in the definition, this is required to create
automatic lists of wikis; without it, the ghost wikis issue remains.

Also, strenghten some PHPCS exceptions and add some gitignored files
temporarily used in tests.

Change-Id: I569c780365022632d5db32e5406fbed86756290c
---
M .gitignore
M src/MediaWikiFarm.php
M src/MediaWikiFarmConfiguration.php
M tests/phpunit/ConstructionTest.php
M tests/phpunit/MediaWikiFarmScriptTest.php
M tests/phpunit/MonoversionInstallationTest.php
M tests/phpunit/MultiversionInstallationTest.php
M tests/phpunit/data/config/farms.php
A tests/phpunit/data/config/versions-default.php
9 files changed, 115 insertions(+), 28 deletions(-)

Approvals:
  Seb35: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
index c39412b..07aae69 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,9 +12,13 @@
 /vendor
 
 # Tests
-/tests/phpunit/data/config/deployments.php
-/tests/phpunit/data/config/testdeploymentsfarmversions.php
+/phpunitHTTP404.php
 /tests/perfs/results
+/tests/phpunit/data/config/badsyntax.json
+/tests/phpunit/data/config/deployments.php
+/tests/phpunit/data/config/empty.json
+/tests/phpunit/data/config/testdeploymentsfarmversions.php
+/tests/phpunit/data/mediawiki/vstub3
 
 # Compiled code documentation
 /docs/code
diff --git a/src/MediaWikiFarm.php b/src/MediaWikiFarm.php
index 147e1b7..56c47be 100644
--- a/src/MediaWikiFarm.php
+++ b/src/MediaWikiFarm.php
@@ -359,7 +359,8 @@
}
 
# Replace variables in the host name and possibly retrieve the 
version
-   if( !$this->checkHostVariables() ) {
+   $explicitExistence = $this->checkHostVariables();
+   if( $explicitExistence === false ) {
return false;
}
 
@@ -368,7 +369,7 @@
$this->setVariable( 'wikiID', true );
 
# Set the version of the wiki
-   if( !$this->setVersion() ) {
+   if( !$this->setVersion( (bool) $explicitExistence ) ) {
return false;
}
 
@@ -745,7 +746,7 @@
}
 
# Shortcut loading
-   // @codingStandardsIgnoreLine
+   // @codingStandardsIgnoreLine 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
if( $this->cacheDir && ( $result = $this->readFile( $host . ( 
$path ? $path : '' ) . '.php', $this->cacheDir . '/wikis', false ) ) ) {
$fresh = true;
$myfreshness = filemtime( $this->cacheDir . '/wikis/' . 
$host . ( $path ? $path : '' ) . '.php' );
@@ -817,7 +818,7 @@
 
# Read the farms configuration
if( !$farms ) {
-   // @codingStandardsIgnoreStart
+   // @codingStandardsIgnoreStart 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
if( $farms = $this->readFile( 'farms.yml', 
$this->configDir ) ) {
$this->farmConfig['coreconfig'][] = 'farms.yml';
} elseif( $farms = $this->readFile( 'farms.php', 
$this->configDir ) ) {
@@ -827,7 +828,7 @@
} else {
return array( 'host' => $host, 'farm' => false, 
'config' => false, 'variables' => false, 'farms' => false, 'redirects' => 
$redirects );
}
-   // @codingStandardsIgnoreEnd
+   // @codingStandardsIgnoreEnd 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
}
 
# For each proposed farm, check if the host 

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Use namespaced ScopedCallback

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372887 )

Change subject: Use namespaced ScopedCallback
..


Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ib4d60553ca17139bec16ccbd0ec5a571d8167f4b
---
M includes/CreateLocalAccountJob.php
M includes/LocalRenameJob/LocalPageMoveJob.php
M includes/LocalRenameJob/LocalRenameJob.php
M includes/specials/SpecialCentralAutoLogin.php
M includes/specials/SpecialCentralLogin.php
5 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CreateLocalAccountJob.php 
b/includes/CreateLocalAccountJob.php
index e3e72e9..f4eecad 100644
--- a/includes/CreateLocalAccountJob.php
+++ b/includes/CreateLocalAccountJob.php
@@ -1,5 +1,7 @@
 https://gerrit.wikimedia.org/r/372887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4d60553ca17139bec16ccbd0ec5a571d8167f4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GWToolset[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372888 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ib9a1496df79a139ee6202440ff2aac4f9e647e79
---
M includes/Handlers/Xml/XmlHandler.php
M includes/Jobs/UploadMediafileJob.php
M includes/Jobs/UploadMetadataJob.php
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset 
refs/changes/88/372888/1

diff --git a/includes/Handlers/Xml/XmlHandler.php 
b/includes/Handlers/Xml/XmlHandler.php
index af35ce2..9dff519 100644
--- a/includes/Handlers/Xml/XmlHandler.php
+++ b/includes/Handlers/Xml/XmlHandler.php
@@ -13,6 +13,7 @@
 use GWToolset\Helpers\GWTFileBackend;
 use Html;
 use MWException;
+use Wikimedia\ScopedCallback;
 use XMLReader;
 
 abstract class XmlHandler {
@@ -170,7 +171,7 @@
);
}
 
-   \ScopedCallback::cancel( $xmlCloser ); // done already
+   ScopedCallback::cancel( $xmlCloser ); // done already
 
return $result;
}
diff --git a/includes/Jobs/UploadMediafileJob.php 
b/includes/Jobs/UploadMediafileJob.php
index ceb3424..7ffeeb3 100755
--- a/includes/Jobs/UploadMediafileJob.php
+++ b/includes/Jobs/UploadMediafileJob.php
@@ -19,10 +19,10 @@
 use GWToolset\Models\Metadata;
 use GWToolset\Utils;
 use Job;
-use ScopedCallback;
 use Title;
 use User;
 use RequestContext;
+use Wikimedia\ScopedCallback;
 
 class UploadMediafileJob extends Job {
 
diff --git a/includes/Jobs/UploadMetadataJob.php 
b/includes/Jobs/UploadMetadataJob.php
index 5577bcc..2ade543 100644
--- a/includes/Jobs/UploadMetadataJob.php
+++ b/includes/Jobs/UploadMetadataJob.php
@@ -21,7 +21,7 @@
 use Title;
 use User;
 use RequestContext;
-use ScopedCallback;
+use Wikimedia\ScopedCallback;
 
 /**
  * runs the MetadataMappingHandler with the originally $_POST’ed form fields 
when

-- 
To view, visit https://gerrit.wikimedia.org/r/372888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9a1496df79a139ee6202440ff2aac4f9e647e79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BrickipediaExtra[master]: Initial commit import from ShoutWiki trunk

[Jack Phoenix (Code Review)]

Jack Phoenix has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372799 )

Change subject: Initial commit import from ShoutWiki trunk
..


Initial commit import from ShoutWiki trunk

This extension is specific to Brickipedia, an online encyclopedia
about LEGO. This provides custom messages for the Brickipedia Wiki.

Change-Id: Ic15f26a0171594ea416ca59f65c22bd6386c2a3a
---
A BrickipediaExtraHooks.php
A extension.json
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/fi.json
A i18n/fr.json
A i18n/nl.json
A i18n/pl.json
A i18n/qqq.json
10 files changed, 142 insertions(+), 0 deletions(-)

Approvals:
  Jack Phoenix: Verified; Looks good to me, approved



diff --git a/BrickipediaExtraHooks.php b/BrickipediaExtraHooks.php
new file mode 100644
index 000..80ec50f
--- /dev/null
+++ b/BrickipediaExtraHooks.php
@@ -0,0 +1,26 @@
+set( 'termsofuse', $sk->footerLink( 'termsofuse', 
'termsofusepage' ) );
+   $tpl->data['footerlinks']['places'][] = 'termsofuse';
+   */
+
+   // "Parents" link in footer
+   $tpl->set( 'parents', $sk->footerLink( 'parents', 'parentspage' 
) );
+   $tpl->data['footerlinks']['places'][] = 'parents';
+
+   return true;
+   }
+
+}
\ No newline at end of file
diff --git a/extension.json b/extension.json
new file mode 100644
index 000..76c7736
--- /dev/null
+++ b/extension.json
@@ -0,0 +1,30 @@
+{
+   "name": "Brickipedia Extra",
+   "version": "1.1",
+   "author": [
+   "Adam Carter/UltrasonicNXT",
+   "George Barnick",
+   "Lewis Cawte",
+   "Jack Phoenix",
+   "Samantha Nguyen",
+   "..."
+   ],
+   "license-name": "GPL-2.0+",
+   "url": "https://www.mediawiki.org/wiki/Extension:BrickipediaExtra;,
+   "descriptionmsg": "brickipedia-extra-desc",
+   "type": "other",
+   "AutoloadClasses": {
+   "BrickipediaExtraHooks": "BrickipediaExtraHooks.php"
+   },
+   "Hooks": {
+   "SkinTemplateOutputPageBeforeExec": [
+   
"BrickipediaExtraHooks::onSkinTemplateOutputPageBeforeExec"
+   ]
+   },
+   "MessagesDirs": {
+   "BrickipediaExtra": [
+   "i18n"
+   ]
+   },
+   "manifest_version": 1
+}
diff --git a/i18n/de.json b/i18n/de.json
new file mode 100644
index 000..b9ccd33
--- /dev/null
+++ b/i18n/de.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "George Barnick"
+   ]
+   },
+   "termsofuse": "Nutzungsbedingungen"
+}
diff --git a/i18n/en.json b/i18n/en.json
new file mode 100644
index 000..80334d4
--- /dev/null
+++ b/i18n/en.json
@@ -0,0 +1,18 @@
+{
+   "@metadata": {
+   "authors": [
+   "George Barnick",
+   "Jack Phoenix "
+   ]
+   },
+   "brickipedia-extra-desc": "Brickipedia-specific i18n messages and other 
functionality",
+   "group-chatmod": "Chat Moderators",
+   "group-chatmod-member": "chat moderator",
+   "group-functionary": "Functionaries",
+   "group-functionary-member": "functionary",
+   "grouppage-functionary": "{{ns:Project}}:Functionaries",
+   "parents": "Parents",
+   "parentspage": "{{ns:Project}}:Parents",
+   "termsofuse": "Terms of Use",
+   "termsofusepage": "{{ns:Project}}:Terms of Use"
+}
diff --git a/i18n/es.json b/i18n/es.json
new file mode 100644
index 000..bc2954d
--- /dev/null
+++ b/i18n/es.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "George Barnick"
+   ]
+   },
+   "termsofuse": "Términos de uso"
+}
diff --git a/i18n/fi.json b/i18n/fi.json
new file mode 100644
index 000..0a9e6b2
--- /dev/null
+++ b/i18n/fi.json
@@ -0,0 +1,11 @@
+{
+   "@metadata": {
+   "authors": [
+   "Jack Phoenix "
+   ]
+   },
+   "group-chatmod": "Chatin valvojat",
+   "group-chatmod-member": "chatin valvoja",
+   "parents": "Vanhemmille",
+   "termsofuse": "Käyttöehdot"
+}
diff --git a/i18n/fr.json b/i18n/fr.json
new file mode 100644
index 000..c08d245
--- /dev/null
+++ b/i18n/fr.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "George Barnick"
+   ]
+   },
+   "termsofuse": "Conditions d'utilisation"
+}
diff --git a/i18n/nl.json b/i18n/nl.json
new file mode 100644
index 000..e0bd9d3
--- /dev/null
+++ b/i18n/nl.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "George Barnick"
+   ]
+   },
+   "termsofuse": "Gebruiksvoorwaarden"
+}
diff --git 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bump src/ to 28a9a22b for deploy

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372883 )

Change subject: Bump src/ to 28a9a22b for deploy
..


Bump src/ to 28a9a22b for deploy

Change-Id: Ib448688d1af3df63f53953706f55c90d84dd02a7
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Subramanya Sastry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src b/src
index 1832a78..28a9a22 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 1832a78ef09cecbee9007f8d89043d7c3ff7dec7
+Subproject commit 28a9a22b8d213601dbbeb47b01ce8a6c76d75bf7

-- 
To view, visit https://gerrit.wikimedia.org/r/372883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib448688d1af3df63f53953706f55c90d84dd02a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Arlolra 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Use namespaced ScopedCallback

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372887 )

Change subject: Use namespaced ScopedCallback
..

Use namespaced ScopedCallback

The non-namespaced version is deprecated since 1.28

Change-Id: Ib4d60553ca17139bec16ccbd0ec5a571d8167f4b
---
M includes/CreateLocalAccountJob.php
M includes/LocalRenameJob/LocalPageMoveJob.php
M includes/LocalRenameJob/LocalRenameJob.php
M includes/specials/SpecialCentralAutoLogin.php
M includes/specials/SpecialCentralLogin.php
5 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/87/372887/1

diff --git a/includes/CreateLocalAccountJob.php 
b/includes/CreateLocalAccountJob.php
index e3e72e9..f4eecad 100644
--- a/includes/CreateLocalAccountJob.php
+++ b/includes/CreateLocalAccountJob.php
@@ -1,5 +1,7 @@
 https://gerrit.wikimedia.org/r/372887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4d60553ca17139bec16ccbd0ec5a571d8167f4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Refactor/standardize status bar appearance in CollapsingTool...

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372886 )

Change subject: Refactor/standardize status bar appearance in 
CollapsingToolbarLayouts.
..

Refactor/standardize status bar appearance in CollapsingToolbarLayouts.

This updates the appearance of the system status bar in activities that
use a full-screen CollapsingToolbarLayout, to make it fully transparent
(instead of partially translucent). Also:

- Refactor the layout of the News fragment to use a CollapsingToolbarLayout,
  instead of a custom-ish toolbar plus image combo.
- Simplify our gradient generator, and make it use a power of 2 instead of
  3, which results in a slightly deeper gradient that doesn't drop off so
  quickly.

Bug: T163594
Change-Id: I87087dcca52b46acaab0a90654a32c0679832e51
---
M app/src/main/java/org/wikipedia/activity/BaseActivity.java
M app/src/main/java/org/wikipedia/feed/news/NewsActivity.java
M app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
M app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
M app/src/main/java/org/wikipedia/offline/CompilationDetailActivity.java
M app/src/main/java/org/wikipedia/offline/CompilationDetailFragment.java
M app/src/main/java/org/wikipedia/page/PageActivity.java
M app/src/main/java/org/wikipedia/page/PageToolbarHideHandler.java
M app/src/main/java/org/wikipedia/page/leadimages/PageHeaderImageView.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListActivity.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListHeaderView.java
M app/src/main/java/org/wikipedia/util/GradientUtil.java
M app/src/main/res/layout/fragment_compilation_detail.xml
M app/src/main/res/layout/fragment_news.xml
M app/src/main/res/layout/fragment_reading_list.xml
15 files changed, 126 insertions(+), 81 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/86/372886/1

diff --git a/app/src/main/java/org/wikipedia/activity/BaseActivity.java 
b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
index a208649..0eab824 100644
--- a/app/src/main/java/org/wikipedia/activity/BaseActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
@@ -9,6 +9,7 @@
 import android.net.ConnectivityManager;
 import android.os.Build;
 import android.os.Bundle;
+import android.support.annotation.ColorInt;
 import android.support.annotation.ColorRes;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
@@ -102,6 +103,16 @@
 }
 }
 
+protected void setStatusBarOverlayColor(@ColorInt int color) {
+if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+View v = 
getWindow().getDecorView().findViewById(android.R.id.statusBarBackground);
+if (v != null) {
+v.setBackgroundColor(color);
+v.setVisibility(View.INVISIBLE);
+}
+}
+}
+
 @Override public boolean isDestroyed() {
 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
 return super.isDestroyed();
diff --git a/app/src/main/java/org/wikipedia/feed/news/NewsActivity.java 
b/app/src/main/java/org/wikipedia/feed/news/NewsActivity.java
index 6bc7b9c..69ab964 100644
--- a/app/src/main/java/org/wikipedia/feed/news/NewsActivity.java
+++ b/app/src/main/java/org/wikipedia/feed/news/NewsActivity.java
@@ -2,6 +2,7 @@
 
 import android.content.Context;
 import android.content.Intent;
+import android.graphics.Color;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
@@ -21,10 +22,9 @@
 public void onCreate(@Nullable Bundle savedInstanceState) {
 super.onCreate(savedInstanceState);
 setSharedElementTransitions();
-
-if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
-
getWindow().setFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS,
-WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS);
+if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+
getWindow().clearFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS);
+getWindow().setStatusBarColor(Color.TRANSPARENT);
 }
 }
 
diff --git a/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java 
b/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
index 4b4e6ca..9649e08 100644
--- a/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/news/NewsFragment.java
@@ -4,8 +4,8 @@
 import android.os.Bundle;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+import android.support.design.widget.AppBarLayout;
 import android.support.v4.app.Fragment;
-import android.support.v4.content.ContextCompat;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.LinearLayoutManager;
 import 

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix error in CargoDeleteTable.php due to fieldHelperTables

[Fz-29 (Code Review)]

Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372885 )

Change subject: Fix error in CargoDeleteTable.php due to fieldHelperTables
..

Fix error in CargoDeleteTable.php due to fieldHelperTables

Change-Id: I487e39ac4b615024a4dedf8f8e47c64e8855d6ee
---
M specials/CargoDeleteTable.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/85/372885/1

diff --git a/specials/CargoDeleteTable.php b/specials/CargoDeleteTable.php
index 1aff877..22965e3 100644
--- a/specials/CargoDeleteTable.php
+++ b/specials/CargoDeleteTable.php
@@ -31,15 +31,17 @@
 * Also, records need to be removed from the cargo_tables and
 * cargo_pages tables.
 */
-   public static function deleteTable( $mainTable, $fieldTables, 
$fieldHelperTables = array() ) {
+   public static function deleteTable( $mainTable, $fieldTables, 
$fieldHelperTables ) {
$cdb = CargoUtils::getDB();
try {
$cdb->dropTable( $mainTable );
foreach ( $fieldTables as $fieldTable ) {
$cdb->dropTable( $fieldTable );
}
-   foreach ( $fieldHelperTables as $fieldHelperTable ) {
-   $cdb->dropTable( $fieldHelperTable );
+   if ( is_array( $fieldHelperTables ) ) {
+   foreach ( $fieldHelperTables as 
$fieldHelperTable ) {
+   $cdb->dropTable( $fieldHelperTable );
+   }
}
} catch ( Exception $e ) {
throw new MWException( "Caught exception ($e) while 
trying to drop Cargo table. "

-- 
To view, visit https://gerrit.wikimedia.org/r/372885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I487e39ac4b615024a4dedf8f8e47c64e8855d6ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Define more precisely the set of existing wikis

[Seb35 (Code Review)]

Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372884 )

Change subject: Define more precisely the set of existing wikis
..

Define more precisely the set of existing wikis

Given there are two mechanism to check if a wiki exists (“variables” files and
“versions” file) and given the two mechanisms answer “possibly existing” if a
wiki is not registered in their mechanism, it was possible to define ghost
wikis, registered nowhere but with some default coarse-defined parameters (MW
parameters like a default database for a suffix, catching there all ghost
wikis).

This commit fixes this odd behaviour: wikis must be defined in at least one of
the two mechanisms (the first mechanism has precedence). More precisely either
the 'wikiID' is defined with at least one identifying variable checked against
a file of existing values, either the ”versions“ file must contain the wikiID.

BTW, remove the need to define the “variables” mechanism (it is possible to
entirely rely on the “versions” mechanism); it will be a bit more easier to
setup a basic installation as described in the “Quick start” guide.

Beyond this improvement in the definition, this is required to create
automatic lists of wikis; without it, the ghost wikis issue remains.

Also, strenghten some PHPCS exceptions and add some gitignored files
temporarily used in tests.

Change-Id: I569c780365022632d5db32e5406fbed86756290c
---
M .gitignore
M src/MediaWikiFarm.php
M src/MediaWikiFarmConfiguration.php
M tests/phpunit/ConstructionTest.php
M tests/phpunit/MediaWikiFarmScriptTest.php
M tests/phpunit/MonoversionInstallationTest.php
M tests/phpunit/MultiversionInstallationTest.php
M tests/phpunit/data/config/farms.php
A tests/phpunit/data/config/versions-default.php
9 files changed, 115 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiFarm 
refs/changes/84/372884/1

diff --git a/.gitignore b/.gitignore
index c39412b..07aae69 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,9 +12,13 @@
 /vendor
 
 # Tests
-/tests/phpunit/data/config/deployments.php
-/tests/phpunit/data/config/testdeploymentsfarmversions.php
+/phpunitHTTP404.php
 /tests/perfs/results
+/tests/phpunit/data/config/badsyntax.json
+/tests/phpunit/data/config/deployments.php
+/tests/phpunit/data/config/empty.json
+/tests/phpunit/data/config/testdeploymentsfarmversions.php
+/tests/phpunit/data/mediawiki/vstub3
 
 # Compiled code documentation
 /docs/code
diff --git a/src/MediaWikiFarm.php b/src/MediaWikiFarm.php
index 147e1b7..56c47be 100644
--- a/src/MediaWikiFarm.php
+++ b/src/MediaWikiFarm.php
@@ -359,7 +359,8 @@
}
 
# Replace variables in the host name and possibly retrieve the 
version
-   if( !$this->checkHostVariables() ) {
+   $explicitExistence = $this->checkHostVariables();
+   if( $explicitExistence === false ) {
return false;
}
 
@@ -368,7 +369,7 @@
$this->setVariable( 'wikiID', true );
 
# Set the version of the wiki
-   if( !$this->setVersion() ) {
+   if( !$this->setVersion( (bool) $explicitExistence ) ) {
return false;
}
 
@@ -745,7 +746,7 @@
}
 
# Shortcut loading
-   // @codingStandardsIgnoreLine
+   // @codingStandardsIgnoreLine 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
if( $this->cacheDir && ( $result = $this->readFile( $host . ( 
$path ? $path : '' ) . '.php', $this->cacheDir . '/wikis', false ) ) ) {
$fresh = true;
$myfreshness = filemtime( $this->cacheDir . '/wikis/' . 
$host . ( $path ? $path : '' ) . '.php' );
@@ -817,7 +818,7 @@
 
# Read the farms configuration
if( !$farms ) {
-   // @codingStandardsIgnoreStart
+   // @codingStandardsIgnoreStart 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
if( $farms = $this->readFile( 'farms.yml', 
$this->configDir ) ) {
$this->farmConfig['coreconfig'][] = 'farms.yml';
} elseif( $farms = $this->readFile( 'farms.php', 
$this->configDir ) ) {
@@ -827,7 +828,7 @@
} else {
return array( 'host' => $host, 'farm' => false, 
'config' => false, 'variables' => false, 'farms' => false, 'redirects' => 
$redirects );
}
-   // @codingStandardsIgnoreEnd
+   // @codingStandardsIgnoreEnd 
MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
}
 
# For each proposed farm, 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bump src/ to 28a9a22b for deploy

[Arlolra (Code Review)]

Arlolra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372883 )

Change subject: Bump src/ to 28a9a22b for deploy
..

Bump src/ to 28a9a22b for deploy

Change-Id: Ib448688d1af3df63f53953706f55c90d84dd02a7
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid/deploy 
refs/changes/83/372883/1

diff --git a/src b/src
index 1832a78..28a9a22 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 1832a78ef09cecbee9007f8d89043d7c3ff7dec7
+Subproject commit 28a9a22b8d213601dbbeb47b01ce8a6c76d75bf7

-- 
To view, visit https://gerrit.wikimedia.org/r/372883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib448688d1af3df63f53953706f55c90d84dd02a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Arlolra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Update sitematrix

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372878 )

Change subject: Update sitematrix
..


Update sitematrix

Change-Id: If0ede2a8f35299f79e360e7210cced1375956828
---
M lib/config/sitematrix.json
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Arlolra: Looks good to me, approved



diff --git a/lib/config/sitematrix.json b/lib/config/sitematrix.json
index 8c12c53..bb5996c 100644
--- a/lib/config/sitematrix.json
+++ b/lib/config/sitematrix.json
@@ -515,8 +515,7 @@
"url": "https://ba.wikibooks.org;,
"dbname": "bawikibooks",
"code": "wikibooks",
-   "sitename": "Wikibooks",
-   "closed": ""
+   "sitename": "Викидәреслек"
}
],
"localname": "Bashkir"
@@ -4471,7 +4470,7 @@
"url": "https://nl.wikinews.org;,
"dbname": "nlwikinews",
"code": "wikinews",
-   "sitename": "Wikinews"
+   "sitename": "Wikinieuws"
},
{
"url": "https://nl.wikiquote.org;,
@@ -4521,7 +4520,7 @@
},
"191": {
"code": "no",
-   "name": "norsk bokmål",
+   "name": "norsk",
"site": [
{
"url": "https://no.wikipedia.org;,

-- 
To view, visit https://gerrit.wikimedia.org/r/372878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0ede2a8f35299f79e360e7210cced1375956828
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Urbanecm 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nova fullstack: increase timeouts yet again

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372881 )

Change subject: nova fullstack: increase timeouts yet again
..


nova fullstack: increase timeouts yet again

I'm still seeing VMs that are working just fine but were forgotten
by the testing daemon.

Bug: T16
Change-Id: Id4f5c040f1a09addeb8f1fb8b5fbaa25695d4dff
---
M modules/openstack/manifests/nova/fullstack.pp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/nova/fullstack.pp 
b/modules/openstack/manifests/nova/fullstack.pp
index b108633..bba6873 100644
--- a/modules/openstack/manifests/nova/fullstack.pp
+++ b/modules/openstack/manifests/nova/fullstack.pp
@@ -8,9 +8,9 @@
 $password,
 $interval = 300,
 $max_pool = 7,
-$creation_timeout = 600,
-$ssh_timeout = 600,
-$puppet_timeout = 600,
+$creation_timeout = 900,
+$ssh_timeout = 900,
+$puppet_timeout = 900,
 ) {
 
 group { 'osstackcanary':

-- 
To view, visit https://gerrit.wikimedia.org/r/372881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4f5c040f1a09addeb8f1fb8b5fbaa25695d4dff
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrap_vz: chase more setup races

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372880 )

Change subject: bootstrap_vz: chase more setup races
..


bootstrap_vz: chase more setup races

I think the cases I'm looking at now have the VM booting
before nova-network has finished setting up the network
stack entirely.  So, during our retry loop, reset if0
and postpone other network activities until we have some
sort of response from that.

Bug: T16
Change-Id: I8092a8adf66688cc7f84935b02276acb9ed3197e
---
M modules/labs_bootstrapvz/files/firstboot.sh
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labs_bootstrapvz/files/firstboot.sh 
b/modules/labs_bootstrapvz/files/firstboot.sh
index b3c85f7..0b714a1 100644
--- a/modules/labs_bootstrapvz/files/firstboot.sh
+++ b/modules/labs_bootstrapvz/files/firstboot.sh
@@ -59,14 +59,11 @@
 fi
 # At this point, all (the rest of) our disk are belong to LVM.
 
-project=`curl http://169.254.169.254/openstack/latest/meta_data.json/ | sed -r 
's/^.*project_id\": \"//'  | sed -r 's/\".*$//g'`
-ip=`curl http://169.254.169.254/1.0/meta-data/local-ipv4 2> /dev/null`
-hostname=`hostname`
-
 # If we're getting ahead of the dnsmasq config, loop until our hostname is
 #  actually ready for us.  Five minutes, total.
 for run in {1..30}
 do
+hostname=`hostname`
 if [ "$hostname" != 'localhost' ]
 then
 break
@@ -75,10 +72,14 @@
 echo `date`
 echo "Waiting for hostname to return the actual hostname."
 sleep 10
+ifdown eth0
+ifup eth0
 /sbin/dhclient -1 eth0
-hostname=`hostname`
 done
 
+project=`curl http://169.254.169.254/openstack/latest/meta_data.json/ | sed -r 
's/^.*project_id\": \"//'  | sed -r 's/\".*$//g'`
+ip=`curl http://169.254.169.254/1.0/meta-data/local-ipv4 2> /dev/null`
+
 # domain is the last two domain sections, e.g. eqiad.wmflabs
 domain=`hostname -d | sed -r 's/.*\.([^.]+\.[^.]+)$/\1/'`
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8092a8adf66688cc7f84935b02276acb9ed3197e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Fix typo in the notification message

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372879 )

Change subject: Fix typo in the notification message
..


Fix typo in the notification message

Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
---
M i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index f72b7f1..e236635 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -16,6 +16,6 @@
"notification-loginnotify-login-success-email-subject": "Login to 
{{SITENAME}} as $1 from a computer you have not recently used",
"notification-header-login-success": "Someone (probably 
{{GENDER:$1|you}}) recently logged in to your account from a new device. If 
this was you, then you can disregard this message. If it wasn't you, then it's 
recommended that you change your password, and check your account activity.",
"notification-new-bundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to 
your account from a new device since the last time you logged in. If it wasn't 
you, please make sure your account has a strong password.",
-   "notification-known-header-login-fail": "There have been 
{{PLURAL:$1|has been '''a failed attempt'''|have been '''$1 failed 
attempts'''}} to log in to your account since the last time you logged in. If 
it wasn't you, please make sure your account has a strong password.",
+   "notification-known-header-login-fail": "There {{PLURAL:$1|has been 
'''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to your 
account since the last time you logged in. If it wasn't you, please make sure 
your account has a strong password.",
"notification-new-unbundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''multiple failed attempts'''}} to log 
in to your account from a new device. Please make sure your account has a 
strong password."
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Make sure referenced file exists

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372882 )

Change subject: Make sure referenced file exists
..

Make sure referenced file exists

Change-Id: I9fd767646f1b02cf9ca0865a0d7ed9823929f839
---
A skinStyles/mobile.startup/error.svg
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/82/372882/1

diff --git a/skinStyles/mobile.startup/error.svg 
b/skinStyles/mobile.startup/error.svg
new file mode 100644
index 000..1317ec6
--- /dev/null
+++ b/skinStyles/mobile.startup/error.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/372882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd767646f1b02cf9ca0865a0d7ed9823929f839
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nova fullstack: increase timeouts yet again

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372881 )

Change subject: nova fullstack: increase timeouts yet again
..

nova fullstack: increase timeouts yet again

I'm still seeing VMs that are working just fine but were forgotten
by the testing daemon.

Bug: T16
Change-Id: Id4f5c040f1a09addeb8f1fb8b5fbaa25695d4dff
---
M modules/openstack/manifests/nova/fullstack.pp
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/81/372881/1

diff --git a/modules/openstack/manifests/nova/fullstack.pp 
b/modules/openstack/manifests/nova/fullstack.pp
index b108633..bba6873 100644
--- a/modules/openstack/manifests/nova/fullstack.pp
+++ b/modules/openstack/manifests/nova/fullstack.pp
@@ -8,9 +8,9 @@
 $password,
 $interval = 300,
 $max_pool = 7,
-$creation_timeout = 600,
-$ssh_timeout = 600,
-$puppet_timeout = 600,
+$creation_timeout = 900,
+$ssh_timeout = 900,
+$puppet_timeout = 900,
 ) {
 
 group { 'osstackcanary':

-- 
To view, visit https://gerrit.wikimedia.org/r/372881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4f5c040f1a09addeb8f1fb8b5fbaa25695d4dff
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrap_vz: chase more setup races

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372880 )

Change subject: bootstrap_vz: chase more setup races
..

bootstrap_vz: chase more setup races

I think the cases I'm looking at now have the VM booting
before nova-network has finished setting up the network
stack entirely.  So, during our retry loop, reset if0
and postpone other network activities until we have some
sort of response from that.

Bug: T16
Change-Id: I8092a8adf66688cc7f84935b02276acb9ed3197e
---
M modules/labs_bootstrapvz/files/firstboot.sh
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/80/372880/1

diff --git a/modules/labs_bootstrapvz/files/firstboot.sh 
b/modules/labs_bootstrapvz/files/firstboot.sh
index b3c85f7..cea5d7f 100644
--- a/modules/labs_bootstrapvz/files/firstboot.sh
+++ b/modules/labs_bootstrapvz/files/firstboot.sh
@@ -59,10 +59,7 @@
 fi
 # At this point, all (the rest of) our disk are belong to LVM.
 
-project=`curl http://169.254.169.254/openstack/latest/meta_data.json/ | sed -r 
's/^.*project_id\": \"//'  | sed -r 's/\".*$//g'`
-ip=`curl http://169.254.169.254/1.0/meta-data/local-ipv4 2> /dev/null`
 hostname=`hostname`
-
 # If we're getting ahead of the dnsmasq config, loop until our hostname is
 #  actually ready for us.  Five minutes, total.
 for run in {1..30}
@@ -75,10 +72,15 @@
 echo `date`
 echo "Waiting for hostname to return the actual hostname."
 sleep 10
+ifdown eth0
+ifup eth0
 /sbin/dhclient -1 eth0
 hostname=`hostname`
 done
 
+project=`curl http://169.254.169.254/openstack/latest/meta_data.json/ | sed -r 
's/^.*project_id\": \"//'  | sed -r 's/\".*$//g'`
+ip=`curl http://169.254.169.254/1.0/meta-data/local-ipv4 2> /dev/null`
+
 # domain is the last two domain sections, e.g. eqiad.wmflabs
 domain=`hostname -d | sed -r 's/.*\.([^.]+\.[^.]+)$/\1/'`
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8092a8adf66688cc7f84935b02276acb9ed3197e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Change Special:Nearby refresh Icon to pointer on-hover

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372869 )

Change subject: Change Special:Nearby refresh Icon to pointer on-hover
..


Change Special:Nearby refresh Icon to pointer on-hover

Following the discussion ticket T126387, it would be better
for the refresh icon to be a button rather than a link since
it's not navigable and using a link may cause default events
to fire on-click. Refresh Icon now is a button were the cursor
changes to a pointer on-hover

Bug: T126387
Change-Id: I3efd07572c39006d4810bc5f8fec31347b97fbed
---
M resources/mobile.special.nearby.scripts/nearby.js
M resources/mobile.special.nearby.styles/specialNearby.less
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/resources/mobile.special.nearby.scripts/nearby.js 
b/resources/mobile.special.nearby.scripts/nearby.js
index 892c3eb..a2346fd 100644
--- a/resources/mobile.special.nearby.scripts/nearby.js
+++ b/resources/mobile.special.nearby.scripts/nearby.js
@@ -26,8 +26,7 @@
name: 'refresh',
id: 'secondary-button',
additionalClassNames: 'main-header-button',
-   tagName: 'a',
-   href: '#',
+   tagName: 'button',
title: mw.msg( 'mobile-frontend-nearby-refresh' ),
label: mw.msg( 'mobile-frontend-nearby-refresh' )
} );
diff --git a/resources/mobile.special.nearby.styles/specialNearby.less 
b/resources/mobile.special.nearby.styles/specialNearby.less
index 19f3984..abb1531 100644
--- a/resources/mobile.special.nearby.styles/specialNearby.less
+++ b/resources/mobile.special.nearby.styles/specialNearby.less
@@ -18,3 +18,8 @@
display: none;
}
 }
+
+// change cursor to pointer when on-hover on refresh icon
+#secondary-button {
+   cursor: pointer;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/372869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3efd07572c39006d4810bc5f8fec31347b97fbed
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: D3r1ck01 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Fix typo in the notification message

[Niharika29 (Code Review)]

Niharika29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372879 )

Change subject: Fix typo in the notification message
..

Fix typo in the notification message

Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
---
M i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify 
refs/changes/79/372879/1

diff --git a/i18n/en.json b/i18n/en.json
index f72b7f1..e236635 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -16,6 +16,6 @@
"notification-loginnotify-login-success-email-subject": "Login to 
{{SITENAME}} as $1 from a computer you have not recently used",
"notification-header-login-success": "Someone (probably 
{{GENDER:$1|you}}) recently logged in to your account from a new device. If 
this was you, then you can disregard this message. If it wasn't you, then it's 
recommended that you change your password, and check your account activity.",
"notification-new-bundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to 
your account from a new device since the last time you logged in. If it wasn't 
you, please make sure your account has a strong password.",
-   "notification-known-header-login-fail": "There have been 
{{PLURAL:$1|has been '''a failed attempt'''|have been '''$1 failed 
attempts'''}} to log in to your account since the last time you logged in. If 
it wasn't you, please make sure your account has a strong password.",
+   "notification-known-header-login-fail": "There {{PLURAL:$1|has been 
'''a failed attempt'''|have been '''$1 failed attempts'''}} to log in to your 
account since the last time you logged in. If it wasn't you, please make sure 
your account has a strong password.",
"notification-new-unbundled-header-login-fail": "There {{PLURAL:$1|has 
been '''a failed attempt'''|have been '''multiple failed attempts'''}} to log 
in to your account from a new device. Please make sure your account has a 
strong password."
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I329847d1c08fdd4dadc69ac60b9cbde2db773b3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Niharika29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Update sitematrix

[Urbanecm (Code Review)]

Urbanecm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372878 )

Change subject: Update sitematrix
..

Update sitematrix

Change-Id: If0ede2a8f35299f79e360e7210cced1375956828
---
M lib/config/sitematrix.json
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/78/372878/1

diff --git a/lib/config/sitematrix.json b/lib/config/sitematrix.json
index 8c12c53..bb5996c 100644
--- a/lib/config/sitematrix.json
+++ b/lib/config/sitematrix.json
@@ -515,8 +515,7 @@
"url": "https://ba.wikibooks.org;,
"dbname": "bawikibooks",
"code": "wikibooks",
-   "sitename": "Wikibooks",
-   "closed": ""
+   "sitename": "Викидәреслек"
}
],
"localname": "Bashkir"
@@ -4471,7 +4470,7 @@
"url": "https://nl.wikinews.org;,
"dbname": "nlwikinews",
"code": "wikinews",
-   "sitename": "Wikinews"
+   "sitename": "Wikinieuws"
},
{
"url": "https://nl.wikiquote.org;,
@@ -4521,7 +4520,7 @@
},
"191": {
"code": "no",
-   "name": "norsk bokmål",
+   "name": "norsk",
"site": [
{
"url": "https://no.wikipedia.org;,

-- 
To view, visit https://gerrit.wikimedia.org/r/372878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0ede2a8f35299f79e360e7210cced1375956828
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Urbanecm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Add padding support for other skins

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371725 )

Change subject: Add padding support for other skins
..


Add padding support for other skins

Change-Id: Ia7494545f2dda36bc2798c23ff8a2855212b77aa
---
M resources/modules/ve-cm/ve.ui.CodeMirror.init.less
1 file changed, 18 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Kaldari: Looks good to me, approved



diff --git a/resources/modules/ve-cm/ve.ui.CodeMirror.init.less 
b/resources/modules/ve-cm/ve.ui.CodeMirror.init.less
index 721326d..0d2cdce 100644
--- a/resources/modules/ve-cm/ve.ui.CodeMirror.init.less
+++ b/resources/modules/ve-cm/ve.ui.CodeMirror.init.less
@@ -13,9 +13,24 @@
box-sizing: border-box;
pointer-events: none;
 
-   padding: 0 1.14286em; /* 1/0.875 */
-   @media screen and ( min-width: 982px ) {
-   padding: 0 1.71429em; /* surface-margin-left (1.5em) / 
(mw-body-content font-size) 0.875em */
+   // Core VE default padding
+   padding: 0.5em 1.5em;
+
+   // Skin specific paddings
+   .skin-vector & {
+   padding: 0 1.14286em; /* 1/0.875 */
+   @media screen and ( min-width: 982px ) {
+   padding: 0 1.71429em; /* surface-margin-left 
(1.5em) / (mw-body-content font-size) 0.875em */
+   }
+   }
+
+   .skin-monobook & {
+   padding: 0;
+   }
+
+   .skin-timeless & {
+   padding-left: 2em;
+   padding-right: 2em;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7494545f2dda36bc2798c23ff8a2855212b77aa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Isarra 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix 'unread' dot top padding regression

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372865 )

Change subject: Fix 'unread' dot top padding regression
..


Fix 'unread' dot top padding regression

All frameless buttons seemed to have recieved a generous padding-top
in the latest OOUI release. This fix overrides that.

Bug: T173059
Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
---
M modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less 
b/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
index 5c99044..ecee641 100644
--- a/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
+++ b/modules/styles/mw.echo.ui.ToggleReadCircleButtonWidget.less
@@ -22,6 +22,11 @@
}
}
 
+   // Override OOUI specific rule for frameless buttons that adds a ~2.5em 
padding-top
+   
&.oo-ui-widget.oo-ui-widget-enabled.oo-ui-buttonElement.oo-ui-buttonElement-frameless
 > .oo-ui-buttonElement-button {
+   padding-top: 0;
+   }
+
&:hover .mw-echo-ui-toggleReadCircleButtonWidget-circle {
// Mark as read
background-color: #447ff5;

-- 
To view, visit https://gerrit.wikimedia.org/r/372865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1f1bbc48410555163afabc84a199e7a69bb95dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Sbisson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WLFilters: set default values

[Sbisson (Code Review)]

Sbisson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372877 )

Change subject: WLFilters: set default values
..

WLFilters: set default values

* Respect different default values for 'limit' and 'day'
  in RC and WL.

* Make 'latestrevision' active by default on WL

Bug: T171134
Change-Id: I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49
---
M includes/specialpage/ChangesListSpecialPage.php
M includes/specials/SpecialRecentchanges.php
M includes/specials/SpecialWatchlist.php
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
4 files changed, 28 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/77/372877/1

diff --git a/includes/specialpage/ChangesListSpecialPage.php 
b/includes/specialpage/ChangesListSpecialPage.php
index 52db51a..c9f7695 100644
--- a/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@ -598,7 +598,9 @@
[
'maxDays' => 
(int)$this->getConfig()->get( 'RCMaxAge' ) / ( 24 * 3600 ), // Translate to days
'limitArray' => 
$this->getConfig()->get( 'RCLinkLimits' ),
+   'limitDefault' => 
$this->getDefaultLimit(),
'daysArray' => $this->getConfig()->get( 
'RCLinkDays' ),
+   'daysDefault' => 
$this->getDefaultDays(),
]
);
}
@@ -1535,4 +1537,8 @@
protected function isStructuredFilterUiEnabled() {
return $this->getUser()->getOption( 'rcenhancedfilters' );
}
+
+   abstract function getDefaultLimit();
+
+   abstract function getDefaultDays();
 }
diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index 4659b9d..d6eac32 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -991,4 +991,12 @@
protected function getCacheTTL() {
return 60 * 5;
}
+
+   function getDefaultLimit() {
+   return $this->getUser()->getIntOption( 'rclimit' );
+   }
+
+   function getDefaultDays() {
+   return $this->getUser()->getIntOption( 'rcdays' );
+   }
 }
diff --git a/includes/specials/SpecialWatchlist.php 
b/includes/specials/SpecialWatchlist.php
index b20b331..224649a 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -142,6 +142,10 @@
protected function registerFilters() {
parent::registerFilters();
 
+   $this->getFilterGroup( 'lastRevision' )
+   ->getFilter( 'hidepreviousrevisions' )
+   ->setDefault( true );
+
$this->registerFilterGroup( new 
ChangesListStringOptionsFilterGroup( [
'name' => 'watchlistactivity',
'title' => 'rcfilters-filtergroup-watchlistactivity',
@@ -858,4 +862,12 @@
$count = $store->countWatchedItems( $this->getUser() );
return floor( $count / 2 );
}
+
+   function getDefaultLimit() {
+   return $this->getUser()->getIntOption( 'wllimit' );
+   }
+
+   function getDefaultDays() {
+   return $this->getUser()->getIntOption( 'watchlistdays' );
+   }
 }
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..7dd1a28 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -97,11 +97,6 @@
};
}
 
-   // Convert the default from the old preference
-   // since the limit preference actually affects more
-   // than just the RecentChanges page
-   limitDefault = Number( mw.user.options.get( 'rclimit', '50' ) );
-
// Add parameter range operations
views.range = {
groups: [
@@ -117,7 +112,7 @@
max: 1000
},
sortFunc: function ( a, b ) { return 
Number( a.name ) - Number( b.name ); },
-   'default': String( limitDefault ),
+   'default': displayConfig.limitDefault,
// Temporarily making this not sticky 
until we resolve the problem
// with the misleading preference. Note 
that if this is to be permanent
// we 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Add title attribute to [x] button

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372588 )

Change subject: RCFilters: Add title attribute to [x] button
..


RCFilters: Add title attribute to [x] button

For accessibility, add title attribute to the remove button in
the active filters area.

Bug: T173608
Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
---
M languages/i18n/en.json
M languages/i18n/qqq.json
M resources/Resources.php
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
4 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 6126bbd..6078b64 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1350,6 +1350,7 @@
"recentchanges-legend-unpatrolled": 
"{{int:recentchanges-label-unpatrolled}}",
"recentchanges-legend-plusminus": "(±123)",
"recentchanges-submit": "Show",
+   "rcfilters-tag-remove": "Remove '$1'",
"rcfilters-legend-heading": "List of abbreviations:",
"rcfilters-other-review-tools": "Other review tools",
"rcfilters-group-results-by-page": "Group results by page",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index bc0fe2c..1bcb075 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1540,6 +1540,7 @@
"recentchanges-legend-unpatrolled": "Used as legend on 
[[Special:RecentChanges]] and [[Special:Watchlist]].\n\nRefers to 
{{msg-mw|Recentchanges-label-unpatrolled}}.",
"recentchanges-legend-plusminus": "{{optional}}\nA plus/minus sign with 
a number for the legend.",
"recentchanges-submit": "Label for submit button in 
[[Special:RecentChanges]]\n{{Identical|Show}}",
+   "rcfilters-tag-remove": "A tooltip for the button that removes a filter 
from the active filters area in [[Special:RecentChanges]] and 
[[Special:Watchlist]] when RCFilters are enabled. \n\nParameters: $1 - Tag 
label",
"rcfilters-legend-heading": "Used as a heading for legend box on 
[[Special:RecentChanges]] and [[Special:Watchlist]] when RCFilters are 
enabled.",
"rcfilters-other-review-tools": "Used as a heading for the community 
collection of other links on [[Special:RecentChanges]] when RCFilters are 
enabled.",
"rcfilters-group-results-by-page": "A label for the checkbox describing 
whether the results in [[Special:RecentChanges]] are grouped by page when 
RCFilters are enabled.",
diff --git a/resources/Resources.php b/resources/Resources.php
index c0c5d9e..6be211e 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1832,6 +1832,7 @@
],
],
'messages' => [
+   'rcfilters-tag-remove',
'rcfilters-activefilters',
'rcfilters-advancedfilters',
'rcfilters-group-results-by-page',
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
index bf75149..81889b2 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.TagItemWidget.js
@@ -48,6 +48,9 @@
this.$highlight = $( '' )
.addClass( 'mw-rcfilters-ui-tagItemWidget-highlight' );
 
+   // Add title attribute with the item label to 'x' button
+   this.closeButton.setTitle( mw.msg( 'rcfilters-tag-remove', 
this.model.getLabel() ) );
+
// Events
this.model.connect( this, { update: 'onModelUpdate' } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcf735e3b610345a8206f83fe5f8115900455cc2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: Sbisson 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: TTO 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Fix highlight circle misalignment

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372590 )

Change subject: RCFilters: Fix highlight circle misalignment
..


RCFilters: Fix highlight circle misalignment

Bug: T172820
Change-Id: I44b91529e8edb6a3fcc65ae9159211dbd2d7f4f1
---
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.HighlightColorPickerWidget.less
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.HighlightColorPickerWidget.less
 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.HighlightColorPickerWidget.less
index 4a7c3f8..667f528 100644
--- 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.HighlightColorPickerWidget.less
+++ 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.HighlightColorPickerWidget.less
@@ -9,6 +9,15 @@
 
&-buttonSelect {
&-color {
+   // Override OOUI definition from padded popup; the 
definition
+   // forces the first-child to be margin-top:0; which 
overrides
+   // our definitions below where margin is 0.5em.
+   // We set up the margin-top as 0.5em for all circles so 
we get
+   // a consistent result
+   
&.oo-ui-widget-enabled.oo-ui-optionWidget.oo-ui-buttonElement.oo-ui-buttonElement-frameless.oo-ui-buttonOptionWidget
 {
+   margin-top: 0.5em;
+   }
+
// Make the rule much more specific to override OOUI
.oo-ui-iconElement-icon.oo-ui-icon-check {
// Override OOUI icon dimensions

-- 
To view, visit https://gerrit.wikimedia.org/r/372590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44b91529e8edb6a3fcc65ae9159211dbd2d7f4f1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Sbisson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmcs: generate /etc/dbusers.yaml with ordered_yaml()

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372876 )

Change subject: wmcs: generate /etc/dbusers.yaml with ordered_yaml()
..

wmcs: generate /etc/dbusers.yaml with ordered_yaml()

This file is named and parsed as yaml, but currently output using
the wmflib ordered_json() function. JSON is a proper subset of YAML so
this works just fine for machine parsing, but reading the collapsed JSON
data is harder for humans than reading YAML's block style encoding.

Change-Id: I248db35bc02c87293ddb4833bc9185530ddc220e
---
M modules/role/manifests/labs/db/maintain_dbusers.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/76/372876/1

diff --git a/modules/role/manifests/labs/db/maintain_dbusers.pp 
b/modules/role/manifests/labs/db/maintain_dbusers.pp
index 63e1084..40d3140 100644
--- a/modules/role/manifests/labs/db/maintain_dbusers.pp
+++ b/modules/role/manifests/labs/db/maintain_dbusers.pp
@@ -75,7 +75,7 @@
 }
 
 file { '/etc/dbusers.yaml':
-content => ordered_json($creds),
+content => ordered_yaml($creds),
 owner   => 'root',
 group   => 'root',
 mode=> '0400',

-- 
To view, visit https://gerrit.wikimedia.org/r/372876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I248db35bc02c87293ddb4833bc9185530ddc220e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: admins: Make daniel a deployer

[Herron (Code Review)]

Herron has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371661 )

Change subject: admins: Make daniel a deployer
..


admins: Make daniel a deployer

Bug: T173230
Change-Id: I8e651e133ad8a6aaec0282f583482ed3b2cffc86
---
M modules/admin/data/data.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alex Monk: Looks good to me, but someone else must approve
  Herron: Looks good to me, approved
  Greg Grossmeier: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index d486564..fab540e 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -54,7 +54,7 @@
 gid: 705
 description: replaces 'mortals' for software deployment
 members: [dr0ptp4kt, anomie, aude, awight, awjrichards, bd808,
-  brion, cscott, demon, ebernhardson, esanders, gilles,
+  brion, cscott, daniel, demon, ebernhardson, esanders, gilles,
   gjg, gwicke, halfak, hashar, hoo, kaldari, kartik, khorn, 
krinkle,
   maxsem, mattflaschen, marktraceur, milimetric, mlitn, andyrussg,
   nikerabbit, reedy, ssastry,
@@ -73,7 +73,7 @@
 gid: 706
 description: access to terbium, mwlog hosts (private data) and bastion 
hosts
  restricted folks use sudo to access apache / www-data 
resources
-members: [daniel, dartar, ellery, bearloga,
+members: [dartar, ellery, bearloga,
   ezachte, jamesur, jdlrobson, tparscal, smalyshev,
   leila, santhosh, amire80, foks, chelsyx]
 privileges: ['ALL = (www-data,apache) NOPASSWD: ALL']

-- 
To view, visit https://gerrit.wikimedia.org/r/371661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e651e133ad8a6aaec0282f583482ed3b2cffc86
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Faidon Liambotis 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Greg Grossmeier 
Gerrit-Reviewer: Herron 
Gerrit-Reviewer: Mark Bergsma 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add test case for summary endpoint

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372875 )

Change subject: Add test case for summary endpoint
..

Add test case for summary endpoint

Change-Id: Id550eba05ff9d2746834b7802bf5f987aa216e09
---
M test/lib/transformations/summarize.js
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/75/372875/1

diff --git a/test/lib/transformations/summarize.js 
b/test/lib/transformations/summarize.js
index 2b19517..f6438fb 100644
--- a/test/lib/transformations/summarize.js
+++ b/test/lib/transformations/summarize.js
@@ -76,6 +76,11 @@
 [
 'Der Deutsche Orden, auch Deutschherrenorden 
oder Deutschritterorden genannt, ist eine römisch-katholische 
Ordensgemeinschaft. Mit dem Johanniter- und dem 
Malteserorden steht er in der (Rechts-)Nachfolge der Ritterorden 
aus der Zeit der Kreuzzüge. Die Mitglieder des Ordens sind seit der 
Reform der Ordensregel 1929 regulierte Chorherren. Der Orden hat 
gegenwärtig 1100 Mitglieder, darunter 100 Priester und 200 
Ordensschwestern, die sich vorwiegend karitativen Aufgaben widmen. Der 
Hauptsitz befindet sich heute in Wien.',
 'Der Deutsche Orden, auch Deutschherrenorden 
oder Deutschritterorden genannt, ist eine römisch-katholische 
Ordensgemeinschaft. Mit dem Johanniter- und dem 
Malteserorden steht er in der (Rechts-)Nachfolge der 
Ritterorden aus der Zeit der Kreuzzüge. Die 
Mitglieder des Ordens sind seit der Reform der Ordensregel 1929 
regulierte Chorherren. Der Orden hat gegenwärtig 1100 Mitglieder, 
darunter 100 Priester und 200 Ordensschwestern, die sich 
vorwiegend karitativen Aufgaben widmen. Der Hauptsitz befindet sich heute in 
Wien.'
+],
+// Full stops do not limit the summaey length (T173640)
+[
+  'Arm. 
gen. Ing. Petr Pavel, 
M.A., (*1.listopadu 1961 Planá) je český voják, generál 
Armády 
České republiky aod června 2015 předseda vojenského výboru NATO. Jako první zástupce zemí bývalé Varšavské smlouvy 
tak nastoupil do nejvyšší vojenské funkce Severoatlantické aliance.[1][2]',
+  'Arm. gen. Ing. Petr Pavel, 
M.A., je český voják, 
generál Armády České republiky aod 
června 2015 předseda vojenského výboru NATO. Jako první zástupce 
zemí bývalé Varšavské smlouvy tak nastoupil do nejvyšší vojenské 
funkce Severoatlantické aliance.'
 ]
 ];
 testCases.forEach((test) => {

-- 
To view, visit https://gerrit.wikimedia.org/r/372875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id550eba05ff9d2746834b7802bf5f987aa216e09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set $wmgUseWikimediaShopLink to true for ptwiki

[Urbanecm (Code Review)]

Urbanecm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372874 )

Change subject: Set $wmgUseWikimediaShopLink to true for ptwiki
..

Set $wmgUseWikimediaShopLink to true for ptwiki

Bug: T173768
Change-Id: I79870a5314fa7562c8165dd68e9921f588221d16
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/74/372874/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 1d2e5f2..0e53550 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -17191,6 +17191,7 @@
'testwiki' => true,
'test2wiki' => true,
'enwiki' => true,
+   'ptwiki' => true, // T173768
 ],
 
 'wmgEnableGeoData' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/372874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79870a5314fa7562c8165dd68e9921f588221d16
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Urbanecm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove child-selector-emu.html

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372570 )

Change subject: Remove child-selector-emu.html
..


Remove child-selector-emu.html

Not necessary to keep this doc around any longer, as IE 6 is not
of concern any more.

Change-Id: I381a2bc750accee324b627e87dd4e11ba8f96364
---
D docs/uidesign/child-selector-emu.html
1 file changed, 0 insertions(+), 100 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/docs/uidesign/child-selector-emu.html 
b/docs/uidesign/child-selector-emu.html
deleted file mode 100644
index 9db4c54..000
--- a/docs/uidesign/child-selector-emu.html
+++ /dev/null
@@ -1,100 +0,0 @@
-
-
-
-   CSS Child selector emulation for IE 6
-   
-   /** Common rules **/
-   body  { background-color: #CCC; }
-   table { border:1px black solid; }
-   caption {
-   background-color: #98fb98;
-   border:1px solid #40FF40;
-   }
-
-   /** "old" rules" **/
-   table.global th,
-   table.global td
-   {
-   border: 1px red solid;
-   background-color:white;
-   padding:1em;
-   }
-   table.global th
-   {
-   background-color: #ffc0cb;
-   }
-
-   /** second table. Try to emulate child selector */
-   table.childemu th,
-   table.childemu td {
-   border: 1px red solid;
-   background-color:white;
-   padding:1em;
-   }
-   table.childemu th
-   {
-   background-color: #ffc0cb;
-   }
-
-   /** Reset style applied in childemu classes */
-   /** TODO: find the real default value!! */
-   table.childemu tr * th,
-   table.childemu tr * td {
-   border: none;
-   background-color: transparent;
-   padding: 0;
-   }
-
-
-   /** child selector emulation */
-   
-
-
-
-The following table show how nested tables inherit colors from the wikitable 
class (here it was renamed "global").
-
-
-Global table
-
-   TH: should have pink bg
-
-
-   TD: white bg
-
-
-   
-   
-   Nested table
-   
-   Nested TH: transparent
-   Nested TD: transparent
-   
-   
-   
-
-
-
-
-With child selector we could limit the wikitable styling to the direct childs 
of the table. Unfortunately, Internet Explorer 6.0 does not support child 
selector. See https://bugzilla.wikimedia.org/show_bug.cgi?id=33752;>our bug #33752.
-
-
-Global table
-
-   TH: should have pink bg
-
-
-   TD: white bg
-
-
-   
-   
-   Nested table
-   
-   Nested TH: transparent
-   Nested TD: transparent
-   
-   
-   
-
-
-NOTE:The nested caption keep the green background. The 
nested table keep the black border. This is because those declarations are 
global so we did not reset them.

-- 
To view, visit https://gerrit.wikimedia.org/r/372570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I381a2bc750accee324b627e87dd4e11ba8f96364
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Make cdh::hadoop class depend on apt-get update

[Ottomata (Code Review)]

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372873 )

Change subject: Make cdh::hadoop class depend on apt-get update
..


Make cdh::hadoop class depend on apt-get update

Bug: T171626
Change-Id: I66744c821e93428b5d5ab0a18ce08852c2907ef5
---
M modules/profile/manifests/hadoop/client.pp
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/profile/manifests/hadoop/client.pp 
b/modules/profile/manifests/hadoop/client.pp
index bd0304b..557460a 100644
--- a/modules/profile/manifests/hadoop/client.pp
+++ b/modules/profile/manifests/hadoop/client.pp
@@ -12,13 +12,13 @@
 # to install CDH packages from our apt repo mirror.
 require ::profile::cdh::apt
 
+# Need Java before Hadoop is installed.
+require ::profile::java::analytics
+
 # Force apt-get update to run before we try to install packages.
 # CDH Packages are in the thirdparty/cloudera apt component,
 # and are made available by profile::cdh::apt.
-Class['::profile::cdh::apt'] -> Exec['apt-get update'] -> 
Class['::profile::hadoop::client']
-
-# Need Java before Hadoop is installed.
-require ::profile::java::analytics
+Class['::profile::cdh::apt'] -> Exec['apt-get update'] -> 
Class['::cdh::hadoop']
 
 $hadoop_var_directory = '/var/lib/hadoop'
 $hadoop_name_directory= "${hadoop_var_directory}/name"

-- 
To view, visit https://gerrit.wikimedia.org/r/372873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66744c821e93428b5d5ab0a18ce08852c2907ef5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Make cdh::hadoop class depend on apt-get update

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372873 )

Change subject: Make cdh::hadoop class depend on apt-get update
..

Make cdh::hadoop class depend on apt-get update

Bug: T171626
Change-Id: I66744c821e93428b5d5ab0a18ce08852c2907ef5
---
M modules/profile/manifests/hadoop/client.pp
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/73/372873/1

diff --git a/modules/profile/manifests/hadoop/client.pp 
b/modules/profile/manifests/hadoop/client.pp
index bd0304b..557460a 100644
--- a/modules/profile/manifests/hadoop/client.pp
+++ b/modules/profile/manifests/hadoop/client.pp
@@ -12,13 +12,13 @@
 # to install CDH packages from our apt repo mirror.
 require ::profile::cdh::apt
 
+# Need Java before Hadoop is installed.
+require ::profile::java::analytics
+
 # Force apt-get update to run before we try to install packages.
 # CDH Packages are in the thirdparty/cloudera apt component,
 # and are made available by profile::cdh::apt.
-Class['::profile::cdh::apt'] -> Exec['apt-get update'] -> 
Class['::profile::hadoop::client']
-
-# Need Java before Hadoop is installed.
-require ::profile::java::analytics
+Class['::profile::cdh::apt'] -> Exec['apt-get update'] -> 
Class['::cdh::hadoop']
 
 $hadoop_var_directory = '/var/lib/hadoop'
 $hadoop_name_directory= "${hadoop_var_directory}/name"

-- 
To view, visit https://gerrit.wikimedia.org/r/372873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66744c821e93428b5d5ab0a18ce08852c2907ef5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WikimediaUI theme: Make checkbox/radio code leaner

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372039 )

Change subject: WikimediaUI theme: Make checkbox/radio code leaner
..


WikimediaUI theme: Make checkbox/radio code leaner

Making Checkbox- and RadioInputWidget's code leaner by
reordering pseudo-classes and therefore removing
unnecessary specificity overrides.

Change-Id: Ia60a7953a4c1dad64616f974f24cc901aa2921e9
---
M src/themes/wikimediaui/widgets.less
1 file changed, 31 insertions(+), 36 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/wikimediaui/widgets.less 
b/src/themes/wikimediaui/widgets.less
index 64160af..e33e5b0 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -400,21 +400,20 @@
);
}
 
-   &:hover + span,
-   &:focus:hover + span {
-   border-color: @color-progressive;
-   }
-
-   &:active + span,
-   &:active:focus + span {
-   background-color: @color-progressive--active;
-   border-color: @border-color-input-binary--active;
-   box-shadow: @box-shadow-input-binary--active;
-   }
-
+   // `:focus` has to come first, otherwise a specificity race 
with `:hover:focus` etc is necessary
&:focus + span {
border-color: @color-progressive;
box-shadow: @box-shadow-widget--focus;
+   }
+
+   &:hover + span {
+   border-color: @color-progressive;
+   }
+
+   &:active + span {
+   background-color: @color-progressive--active;
+   border-color: @border-color-input-binary--active;
+   box-shadow: @box-shadow-input-binary--active;
}
 
&:checked {
@@ -423,24 +422,21 @@
border-color: 
@border-color-input-binary--checked;
}
 
-   &:hover + span,
-   &:focus:hover + span {
-   background-color: @color-progressive--hover;
-   border-color: @color-progressive--hover;
-   }
-
-   &:active + span,
-   &:active:hover + span,
-   &:active:focus + span {
-   background-color: 
@background-color-input-binary--active;
-   border-color: 
@border-color-input-binary--active;
-   box-shadow: @box-shadow-input-binary--active;
-   }
-
&:focus + span {
background-color: 
@background-color-input-binary--checked;
border-color: 
@border-color-input-binary--checked;
box-shadow: @box-shadow-progressive--focus;
+   }
+
+   &:hover + span {
+   background-color: @color-progressive--hover;
+   border-color: @color-progressive--hover;
+   }
+
+   &:active + span {
+   background-color: 
@background-color-input-binary--active;
+   border-color: 
@border-color-input-binary--active;
+   box-shadow: @box-shadow-input-binary--active;
}
}
}
@@ -1252,24 +1248,23 @@
border-color: 
@border-color-input-binary--checked;
}
 
-   &:hover + span,
-   &:hover:focus + span {
+   // `:focus` has to come first, otherwise a specificity 
race with `:hover:focus` etc is necessary
+   &:focus + span {
+   &:before {
+   border-color: @background-color-base;
+   }
+   }
+
+   &:hover + span {
border-color: @color-progressive--hover;
}
 
-   &:active + span,
-   &:active:focus + span {
+   &:active + span {
border-color: 
@border-color-input-binary--active;
box-shadow: @box-shadow-input-binary--active;
 
&:before {
border-color: 
@border-color-input-binary--active;
-   }
-   }
-
-  

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Replace grey with WikimediaUI palette color one

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372585 )

Change subject: Replace grey with WikimediaUI palette color one
..


Replace grey with WikimediaUI palette color one

Replacing `#4d4d4d` with `#444`, which is `color-base` var modifier.
We're going for a very similar
color for now, instead of `#54595d` as with current background
we want to still ensure WCAG 2.0 level AAA conformance as it's
right now in order to not be disruptive.

Bug: T153043
Change-Id: I4c8caac9d829d8a3a351fc78181279ed35ed15a9
---
M variables.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/variables.less b/variables.less
index 8b40cb8..4555136 100755
--- a/variables.less
+++ b/variables.less
@@ -31,7 +31,7 @@
 @menu-main-font-size: inherit;
 
 @menu-main-heading-font-size: 0.75em;
-@menu-main-heading-color: #4d4d4d;
+@menu-main-heading-color: #444;
 
 @menu-main-body-font-size: 0.75em;
 @menu-main-body-link-color: #0645ad;

-- 
To view, visit https://gerrit.wikimedia.org/r/372585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c8caac9d829d8a3a351fc78181279ed35ed15a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Add 'title' attribute to the 'remove' button in TagItemWidget

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372589 )

Change subject: Add 'title' attribute to the 'remove' button in TagItemWidget
..


Add 'title' attribute to the 'remove' button in TagItemWidget

Bug: T173608
Change-Id: I83e2c305f689f163b8c201b7ca5d912a942ed985
---
M i18n/en.json
M i18n/qqq.json
M src/core.js
M src/widgets/CapsuleItemWidget.js
M src/widgets/TagItemWidget.js
5 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/i18n/en.json b/i18n/en.json
index be00832..fd31150 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -22,6 +22,7 @@
"ooui-toolbar-more": "More",
"ooui-toolgroup-expand": "More",
"ooui-toolgroup-collapse": "Fewer",
+   "ooui-item-remove": "Remove",
"ooui-dialog-message-accept": "OK",
"ooui-dialog-message-reject": "Cancel",
"ooui-dialog-process-error": "Something went wrong",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 1a096ef..270cfe9 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -26,6 +26,7 @@
"ooui-toolbar-more": "Label for the toolbar group that contains a list 
of all other available tools.\n{{Identical|More}}",
"ooui-toolgroup-expand": "Label for the fake tool that expands the full 
list of tools in a toolbar group.\n\nSee also:\n* 
{{msg-mw|Ooui-toolgroup-collapse}}\n{{Identical|More}}",
"ooui-toolgroup-collapse": "Label for the fake tool that collapses the 
full list of tools in a toolbar group.\n\nSee also:\n* 
{{msg-mw|Ooui-toolgroup-expand}}\n{{Identical|Fewer}}",
+   "ooui-item-remove": "Text for the action of removing an item",
"ooui-dialog-message-accept": "Default label for the accept button of a 
message dialog\n{{Identical|OK}}",
"ooui-dialog-message-reject": "Default label for the reject button of a 
message dialog\n{{Identical|Cancel}}",
"ooui-dialog-process-error": "Title for process dialog error 
description",
diff --git a/src/core.js b/src/core.js
index 5e0b2a4..1073da9 100644
--- a/src/core.js
+++ b/src/core.js
@@ -348,6 +348,8 @@
'ooui-toolgroup-expand': 'More',
// Label for the fake tool that collapses the full list of 
tools in a toolbar group
'ooui-toolgroup-collapse': 'Fewer',
+   // Default label for the tooltip for the button that removes a 
tag item
+   'ooui-item-remove': 'Remove',
// Default label for the accept button of a confirmation dialog
'ooui-dialog-message-accept': 'OK',
// Default label for the reject button of a confirmation dialog
diff --git a/src/widgets/CapsuleItemWidget.js b/src/widgets/CapsuleItemWidget.js
index e304767..9e87e78 100644
--- a/src/widgets/CapsuleItemWidget.js
+++ b/src/widgets/CapsuleItemWidget.js
@@ -29,7 +29,8 @@
this.closeButton = new OO.ui.ButtonWidget( {
framed: false,
icon: 'close',
-   tabIndex: -1
+   tabIndex: -1,
+   title: OO.ui.msg( 'ooui-item-remove' )
} ).on( 'click', this.onCloseClick.bind( this ) );
 
this.on( 'disable', function ( disabled ) {
diff --git a/src/widgets/TagItemWidget.js b/src/widgets/TagItemWidget.js
index 5666446..d6ee7b9 100644
--- a/src/widgets/TagItemWidget.js
+++ b/src/widgets/TagItemWidget.js
@@ -32,7 +32,8 @@
this.closeButton = new OO.ui.ButtonWidget( {
framed: false,
icon: 'close',
-   tabIndex: -1
+   tabIndex: -1,
+   title: OO.ui.msg( 'ooui-item-remove' )
} );
this.closeButton.setDisabled( this.isDisabled() );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83e2c305f689f163b8c201b7ca5d912a942ed985
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Check for druid-hdfs-storage-cdh dir existance before lookin...

[Ottomata (Code Review)]

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372872 )

Change subject: Check for druid-hdfs-storage-cdh dir existance before looking 
for jar link
..


Check for druid-hdfs-storage-cdh dir existance before looking for jar link

Bug: T171626
Change-Id: Ic3f4cd06ae5fe0481dcbde81d2d5d703a18987ad
---
M modules/druid/manifests/cdh/hadoop/dependencies.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/druid/manifests/cdh/hadoop/dependencies.pp 
b/modules/druid/manifests/cdh/hadoop/dependencies.pp
index ddc1c4e..6f51a80 100644
--- a/modules/druid/manifests/cdh/hadoop/dependencies.pp
+++ b/modules/druid/manifests/cdh/hadoop/dependencies.pp
@@ -39,7 +39,7 @@
 # symlink target does not exist.  This symlinks to a versioned jar in 
druid-hdfs-storage/.
 # During a druid upgrade, the version name of this jar will change, 
causing the symlink
 # to break, which in turn will this puppet exec.
-unless  => "/usr/bin/test -e $(/usr/bin/realpath 
${dest_dir}/druid-hdfs-storage.jar)",
+unless  => "/usr/bin/test -e ${dest_dir} && /usr/bin/test -e 
$(/usr/bin/realpath ${dest_dir}/druid-hdfs-storage.jar)",
 require => File['/usr/local/bin/druid-hdfs-storage-cdh-link'],
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3f4cd06ae5fe0481dcbde81d2d5d703a18987ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Check for druid-hdfs-storage-cdh dir existance before lookin...

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372872 )

Change subject: Check for druid-hdfs-storage-cdh dir existance before looking 
for jar link
..

Check for druid-hdfs-storage-cdh dir existance before looking for jar link

Bug: T171626
Change-Id: Ic3f4cd06ae5fe0481dcbde81d2d5d703a18987ad
---
M modules/druid/manifests/cdh/hadoop/dependencies.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/72/372872/1

diff --git a/modules/druid/manifests/cdh/hadoop/dependencies.pp 
b/modules/druid/manifests/cdh/hadoop/dependencies.pp
index ddc1c4e..6f51a80 100644
--- a/modules/druid/manifests/cdh/hadoop/dependencies.pp
+++ b/modules/druid/manifests/cdh/hadoop/dependencies.pp
@@ -39,7 +39,7 @@
 # symlink target does not exist.  This symlinks to a versioned jar in 
druid-hdfs-storage/.
 # During a druid upgrade, the version name of this jar will change, 
causing the symlink
 # to break, which in turn will this puppet exec.
-unless  => "/usr/bin/test -e $(/usr/bin/realpath 
${dest_dir}/druid-hdfs-storage.jar)",
+unless  => "/usr/bin/test -e ${dest_dir} && /usr/bin/test -e 
$(/usr/bin/realpath ${dest_dir}/druid-hdfs-storage.jar)",
 require => File['/usr/local/bin/druid-hdfs-storage-cdh-link'],
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/372872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3f4cd06ae5fe0481dcbde81d2d5d703a18987ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Don't use tab indenting between array items

[Reedy (Code Review)]

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372871 )

Change subject: Don't use tab indenting between array items
..

Don't use tab indenting between array items

Change-Id: Ifbc293c5075c6518edbefd5d7c4b6ce2cd71ace3
---
M resources/mode/mediawiki/mediawiki.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/71/372871/1

diff --git a/resources/mode/mediawiki/mediawiki.js 
b/resources/mode/mediawiki/mediawiki.js
index bc044df..ddc68da 100644
--- a/resources/mode/mediawiki/mediawiki.js
+++ b/resources/mode/mediawiki/mediawiki.js
@@ -33,7 +33,7 @@
rp: true, rt: true, rtc: true, p: true, span: 
true, abbr: true, dfn: true,
kbd: true, samp: true, data: true, time: true, 
mark: true, br: true,
wbr: true, hr: true, li: true, dt: true, dd: 
true, td: true, th: true,
-   tr: true,   noinclude: true, includeonly: 
true, onlyinclude: true },
+   tr: true, noinclude: true, includeonly: true, 
onlyinclude: true },
isBold, isItalic, firstsingleletterword, 
firstmultiletterword, firstspace, mBold, mItalic, mTokens = [],
mStyle;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbc293c5075c6518edbefd5d7c4b6ce2cd71ace3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...wikidiff2[master]: WIP: fuzz test

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372870 )

Change subject: WIP: fuzz test
..

WIP: fuzz test

Change-Id: I6ba3fc24f1dfa1fc70dc5a927394d1bd63494464
---
A FuzzTest/fuzz.php
A FuzzTest/random.php
2 files changed, 194 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/php/wikidiff2 
refs/changes/70/372870/1

diff --git a/FuzzTest/fuzz.php b/FuzzTest/fuzz.php
new file mode 100644
index 000..f697a9d
--- /dev/null
+++ b/FuzzTest/fuzz.php
@@ -0,0 +1,48 @@
+ '0123456789.-',
+   // Latin
+   1 => 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRTSTUVWXYZ-',
+   // Russian
+   2 => 
'АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯабвгдеёжзийклмнопрстуфхцчшщъыьэюя-',
+   // Thai
+   3 => 
'กขฃคฅฆงจฉชซฌญฎฏฐฑฒณดตถทธนบปผฝพฟภมยรฤลฦวศษสหฬอฮฯะัาำิีึืฺุู',
+   ];
+
+   private static $separators;
+
+   public static function randomData() {
+   self::init();
+
+   switch ( mt_rand( 0, 3 ) ) {
+   // Diff binary garbage with binary garbage
+   case 0:
+   $left = self::randomBinaryString( mt_rand( 0, 
self::MAX_CONTENT_LENGTH ) );
+   $right = self::randomBinaryString( mt_rand( 0, 
self::MAX_CONTENT_LENGTH ) );
+   break;
+   // Diff binary garbage with text
+   case 1:
+   $left = self::randomBinaryString( mt_rand( 0, 
self::MAX_CONTENT_LENGTH ) );
+   $right = self::randomText();
+   break;
+   case 2:
+   $left = self::randomText();
+   $right = self::randomBinaryString( mt_rand( 0, 
self::MAX_CONTENT_LENGTH ) );
+   break;
+   // Diff text against text
+   case 3:
+   $left = self::randomText();
+   $right = self::randomText();
+   break;
+   default:
+   throw new Exception( 'This should not happen' );
+   }
+
+   return [ $left, $right ];
+   }
+
+   private static function init() {
+   static $initd = false;
+   if ( $initd ) {
+   return;
+   }
+
+   self::$separators = self::split( '.,?!:;。．！？｡\'' );
+
+   foreach ( self::$tables as $index => $table ) {
+   self::$tables[$index] = self::split( $table );
+   }
+
+   $initd = true;
+   }
+
+   private static function split( $str ) {
+   $result = preg_split( '//u', $str );
+   array_shift( $result );
+   array_pop( $result );
+
+   return $result;
+   }
+
+   private static function randomText( $length = 0 ) {
+   if ( !$length ) {
+   $length = mt_rand( 0, self::MAX_CONTENT_LENGTH );
+   }
+
+   $str = '';
+   do {
+   $str .= self::randomLine();
+   $str .= str_repeat( "\n", mt_rand( 1, 4 ) );
+   } while ( mb_strlen( $str ) < $length );
+
+   return $str;
+   }
+
+   private static function randomShuffledTexts() {
+   $sourceLines = mt_rand( 0, 100 );
+
+   $source = [];
+
+   for ( $i = 0; $i < $sourceLines; $i++ ) {
+
+   }
+   }
+
+   private static function randomLine( $length = 0 ) {
+   if ( !$length ) {
+   $length = mt_rand( 1, self::MAX_LINE_LENGTH );
+   }
+   $line = '';
+   do {
+   $line .= self::randomWord();
+   $line .= self::randomSeparator( mt_rand( 0, 3 ) );
+   $line .= str_repeat( ' ', mt_rand( 1, 10 ) );
+   } while ( strlen( $line ) < $length );
+
+   return trim( $line );
+   }
+
+   private static function randomWord( $length = 0 ) {
+   if ( !$length ) {
+   $length = mt_rand( 1, self::MAX_WORD_LENGTH );
+   }
+
+   $charset = self::$tables[mt_rand( 0, count( self::$tables ) - 1 
)];
+   $str = '';
+   $chars = count( $charset );
+   for ( $i = 0; $i < $length; $i++ ) {
+   $str .= $charset[mt_rand( 0, $chars - 1 )];
+   }
+   return $str;
+   }
+
+   private static function randomSeparator( $count = 1 ) {
+   $separatorCount = count( self::$separators );
+
+ 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move use_cdh setting into profile hiera param

[Ottomata (Code Review)]

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372867 )

Change subject: Move use_cdh setting into  profile hiera param
..


Move use_cdh setting into  profile hiera param

Bug: T171626
Change-Id: I895dfcf19afc4795d17c0abc155afd70ec27a1da
---
M hieradata/eqiad/druid.yaml
M hieradata/role/common/analytics_cluster/druid/worker.yaml
M modules/profile/manifests/druid/common.pp
M modules/role/manifests/analytics_cluster/druid/worker.pp
4 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/eqiad/druid.yaml b/hieradata/eqiad/druid.yaml
index f5f1408..86a137b 100644
--- a/hieradata/eqiad/druid.yaml
+++ b/hieradata/eqiad/druid.yaml
@@ -1,4 +1,3 @@
-druid::use_cdh: true
 druid::properties:
   druid.metadata.storage.type: mysql
   druid.metadata.storage.connector.host: analytics1003.eqiad.wmnet
diff --git a/hieradata/role/common/analytics_cluster/druid/worker.yaml 
b/hieradata/role/common/analytics_cluster/druid/worker.yaml
index 9ca785b..89f5823 100644
--- a/hieradata/role/common/analytics_cluster/druid/worker.yaml
+++ b/hieradata/role/common/analytics_cluster/druid/worker.yaml
@@ -6,6 +6,9 @@
 
 profile::druid::common::zookeeper_cluster_name: druid-eqiad
 
+# Make druid build an extension composed of CDH jars.
+profile::druid::common::use_cdh: true
+
 # Druid nodes get their own Zookeeper cluster to isolate them
 # from the production ones.
 profile::zookeeper::cluster_name: druid-eqiad
diff --git a/modules/profile/manifests/druid/common.pp 
b/modules/profile/manifests/druid/common.pp
index 50bd4ed..1cd0750 100644
--- a/modules/profile/manifests/druid/common.pp
+++ b/modules/profile/manifests/druid/common.pp
@@ -13,9 +13,11 @@
 $zookeeper_cluster_name = 
hiera('profile::druid::common::zookeeper_cluster_name'),
 $zookeeper_clusters = hiera('zookeeper_clusters'),
 $druid_properties   = hiera_hash('druid::properties'),
+$use_cdh= hiera('profile::druid::common::use_cdh')
 ) {
 # Need Java before Druid is installed.
 require ::profile::java::analytics
+require ::profile::hadoop::client
 
 $zookeeper_hosts = 
keys($zookeeper_clusters[$zookeeper_cluster_name]['hosts'])
 
@@ -32,6 +34,7 @@
 
 # Druid Common Class
 class { '::druid':
+use_cdh=> $use_cdh,
 # Merge our auto configured zookeeper properties
 # with the properties from hiera.
 properties => merge(
diff --git a/modules/role/manifests/analytics_cluster/druid/worker.pp 
b/modules/role/manifests/analytics_cluster/druid/worker.pp
index b542d6b..92e17d6 100644
--- a/modules/role/manifests/analytics_cluster/druid/worker.pp
+++ b/modules/role/manifests/analytics_cluster/druid/worker.pp
@@ -15,7 +15,6 @@
 
 # Require common druid package and configuration.
 require ::profile::druid::common
-require ::profile::hadoop::client
 
 # Zookeeper is co-located on some druid hosts, but not all.
 if $::fqdn in $::profile::druid::common::zookeeper_hosts {

-- 
To view, visit https://gerrit.wikimedia.org/r/372867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I895dfcf19afc4795d17c0abc155afd70ec27a1da
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Change Special:Nearby refresh Icon to pointer on-hover

[D3r1ck01 (Code Review)]

D3r1ck01 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372869 )

Change subject: Change Special:Nearby refresh Icon to pointer on-hover
..

Change Special:Nearby refresh Icon to pointer on-hover

Following the discussion ticket T126387, it would be better
for the refresh icon to be a button rather than a link since
it's not navigable and using a link may cause default events
to fire on-click. Refresh Icon now is a button were the cursor
changes to a pointer on-hover

Bug: T126387
Change-Id: I3efd07572c39006d4810bc5f8fec31347b97fbed
---
M resources/mobile.special.nearby.scripts/nearby.js
M resources/mobile.special.nearby.styles/specialNearby.less
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/69/372869/1

diff --git a/resources/mobile.special.nearby.scripts/nearby.js 
b/resources/mobile.special.nearby.scripts/nearby.js
index 892c3eb..a2346fd 100644
--- a/resources/mobile.special.nearby.scripts/nearby.js
+++ b/resources/mobile.special.nearby.scripts/nearby.js
@@ -26,8 +26,7 @@
name: 'refresh',
id: 'secondary-button',
additionalClassNames: 'main-header-button',
-   tagName: 'a',
-   href: '#',
+   tagName: 'button',
title: mw.msg( 'mobile-frontend-nearby-refresh' ),
label: mw.msg( 'mobile-frontend-nearby-refresh' )
} );
diff --git a/resources/mobile.special.nearby.styles/specialNearby.less 
b/resources/mobile.special.nearby.styles/specialNearby.less
index 19f3984..0b7afcc 100644
--- a/resources/mobile.special.nearby.styles/specialNearby.less
+++ b/resources/mobile.special.nearby.styles/specialNearby.less
@@ -18,3 +18,8 @@
display: none;
}
 }
+
+// change refresh icon to pointer on hover
+#secondary-button {
+   cursor: pointer;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/372869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3efd07572c39006d4810bc5f8fec31347b97fbed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: D3r1ck01 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Remove leading spaces

[Reedy (Code Review)]

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372868 )

Change subject: Remove leading spaces
..

Remove leading spaces

Change-Id: I1acf3d018ac2cf55e9cbe1a410445bc74c418a4c
---
M ResourceLoaderCodeMirrorModule.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/68/372868/1

diff --git a/ResourceLoaderCodeMirrorModule.php 
b/ResourceLoaderCodeMirrorModule.php
index 457d5cd..708abc7 100644
--- a/ResourceLoaderCodeMirrorModule.php
+++ b/ResourceLoaderCodeMirrorModule.php
@@ -31,8 +31,8 @@
return ResourceLoader::makeConfigSetScript(
[ 'extCodeMirrorConfig' => 
$this->getFrontendConfiguraton() ]
)
-  . "\n"
-  . parent::getScript( $context );
+   . "\n"
+   . parent::getScript( $context );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/372868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1acf3d018ac2cf55e9cbe1a410445bc74c418a4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits