[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] MultiSelectWidget: Rename getters

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398006 )

Change subject: [DEPRECATING CHANGE] MultiSelectWidget: Rename getters
..

[DEPRECATING CHANGE] MultiSelectWidget: Rename getters

getSelectedItems to findSelectedItems
getSelectedItemsData to findSelectedItemsData

Bug: T76630
Change-Id: Ic1be36b62f6c48c9f40feace009fe4ca3e7a8e3f
---
M src/widgets/MultiselectWidget.js
1 file changed, 27 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/06/398006/1

diff --git a/src/widgets/MultiselectWidget.js b/src/widgets/MultiselectWidget.js
index 98c1645..588a6db 100644
--- a/src/widgets/MultiselectWidget.js
+++ b/src/widgets/MultiselectWidget.js
@@ -61,28 +61,50 @@
 /* Methods */
 
 /**
- * Get options that are selected.
+ * Find options that are selected.
  *
  * @return {OO.ui.MultioptionWidget[]} Selected options
  */
-OO.ui.MultiselectWidget.prototype.getSelectedItems = function () {
+OO.ui.MultiselectWidget.prototype.findSelectedItems = function () {
return this.items.filter( function ( item ) {
return item.isSelected();
} );
 };
 
 /**
- * Get the data of options that are selected.
+ * Get options that are selected.
+ *
+ * @deprecated 0.25.1 Use {@link findSelectedItems} instead.
+ * @return {OO.ui.MultioptionWidget[]} Selected options
+ */
+OO.ui.MultiselectWidget.prototype.getSelectedItems = function () {
+   OO.ui.warnDeprecation( 'MultiselectWidget#getSelectedItems: Deprecated 
function. Use findSelectedItems instead. See T76630.' );
+   return this.findSelectedItems();
+};
+
+/**
+ * Find the data of options that are selected.
  *
  * @return {Object[]|string[]} Values of selected options
  */
-OO.ui.MultiselectWidget.prototype.getSelectedItemsData = function () {
-   return this.getSelectedItems().map( function ( item ) {
+OO.ui.MultiselectWidget.prototype.findSelectedItemsData = function () {
+   return this.findSelectedItems().map( function ( item ) {
return item.data;
} );
 };
 
 /**
+ * Get the data of options that are selected.
+ *
+ * @deprecated 0.25.1 Use {@link findSelectedItemsData} instead.
+ * @return {Object[]|string[]} Values of selected options
+ */
+OO.ui.MultiselectWidget.prototype.getSelectedItemsData = function () {
+   OO.ui.warnDeprecation( 'MultiselectWidget#getSelectedItemsData: 
Deprecated function. Use findSelectedItemsData instead. See T76630.' );
+   return this.findSelectedItemsData();
+};
+
+/**
  * Select options by reference. Options not mentioned in the `items` array 
will be deselected.
  *
  * @param {OO.ui.MultioptionWidget[]} items Items to select

-- 
To view, visit https://gerrit.wikimedia.org/r/398006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1be36b62f6c48c9f40feace009fe4ca3e7a8e3f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to...

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398005 )

Change subject: [DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to 
findSelectedItem
..

[DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to findSelectedItem

Bug: T76630
Change-Id: I0f1d9c1f31efcc10d3647103548770d2101050d9
---
M src/widgets/SelectWidget.js
1 file changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/05/398005/1

diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 40b35d8..e61bf6d 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -523,11 +523,11 @@
 };
 
 /**
- * Get selected item.
+ * Find selected item.
  *
  * @return {OO.ui.OptionWidget|null} Selected item, `null` if no item is 
selected
  */
-OO.ui.SelectWidget.prototype.getSelectedItem = function () {
+OO.ui.SelectWidget.prototype.findSelectedItem = function () {
var i, len;
 
for ( i = 0, len = this.items.length; i < len; i++ ) {
@@ -539,6 +539,17 @@
 };
 
 /**
+ * Get selected item.
+ *
+ * @deprecated 0.25.1 Use {@link #findSelectedItem} instead.
+ * @return {OO.ui.OptionWidget|null} Selected item, `null` if no item is 
selected
+ */
+OO.ui.SelectWidget.prototype.getSelectedItem = function () {
+   OO.ui.warnDeprecation( 'SelectWidget#getSelectedItem: Deprecated 
function. Use findSelectedItem instead. See T76630.' );
+   return this.findSelectedItem();
+};
+
+/**
  * Find highlighted item.
  *
  * @return {OO.ui.OptionWidget|null} Highlighted item, `null` if no item is 
highlighted

-- 
To view, visit https://gerrit.wikimedia.org/r/398005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f1d9c1f31efcc10d3647103548770d2101050d9
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] GroupElement: Rename getItemFromData to...

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398004 )

Change subject: [DEPRECATING CHANGE] GroupElement: Rename getItemFromData to 
findItemFromData
..

[DEPRECATING CHANGE] GroupElement: Rename getItemFromData to findItemFromData

Bug: T76630
Change-Id: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
---
M src/mixins/GroupElement.js
1 file changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/04/398004/1

diff --git a/src/mixins/GroupElement.js b/src/mixins/GroupElement.js
index e84475c..25e1339 100644
--- a/src/mixins/GroupElement.js
+++ b/src/mixins/GroupElement.js
@@ -62,7 +62,7 @@
 };
 
 /**
- * Get an item by its data.
+ * Find an item by its data.
  *
  * Only the first item with matching data will be returned. To return all 
matching items,
  * use the #getItemsFromData method.
@@ -70,7 +70,7 @@
  * @param {Object} data Item data to search for
  * @return {OO.ui.Element|null} Item with equivalent data, `null` if none 
exists
  */
-OO.ui.mixin.GroupElement.prototype.getItemFromData = function ( data ) {
+OO.ui.mixin.GroupElement.prototype.findItemFromData = function ( data ) {
var i, len, item,
hash = OO.getHash( data );
 
@@ -85,6 +85,18 @@
 };
 
 /**
+ * Get an item by its data.
+ *
+ * @deprecated 0.25.1 Use {@link #findItemFromData} instead.
+ * @param {Object} data Item data to search for
+ * @return {OO.ui.Element|null} Item with equivalent data, `null` if none 
exists
+ */
+OO.ui.mixin.GroupElement.prototype.getItemFromData = function ( data ) {
+   OO.ui.warnDeprecation( 'GroupElement#getItemFromData. Deprecated 
function. Use findItemFromData instead. See T76630' );
+   return this.findItemFromData( data );
+};
+
+/**
  * Get items by their data.
  *
  * All items with matching data will be returned. To return only the first 
match, use the #getItemFromData method instead.

-- 
To view, visit https://gerrit.wikimedia.org/r/398004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...prometheus-rabbitmq-exporter[master]: Add Prometheus exporter for RabbitMQ

[Muehlenhoff (Code Review)]

Muehlenhoff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398003 )

Change subject: Add Prometheus exporter for RabbitMQ
..

Add Prometheus exporter for RabbitMQ

Based on the logic of the existing Diamond collector.

Bug: T181802
Change-Id: Ife08343ae1e963cddbdcfa947fec1d967a8a2c3b
---
A prometheus-rabbitmq-exporter
1 file changed, 229 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/operations/debs/prometheus-rabbitmq-exporter 
refs/changes/03/398003/1

diff --git a/prometheus-rabbitmq-exporter b/prometheus-rabbitmq-exporter
new file mode 100755
index 000..99a37ac
--- /dev/null
+++ b/prometheus-rabbitmq-exporter
@@ -0,0 +1,229 @@
+#!/usr/bin/python
+# Copyright 2017 Moritz Muehlenhoff
+#Filippo Giunchedi
+#Wikimedia Foundation
+# Copyright 2012 Diamond developers (Brightcove Inc, Ivan Pouzyrevsky,
+#Rob Smith, Wijnand Modderman-Lenstra, Dennis Kaarsemaker)
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+
+import argparse
+import logging
+import sys
+import time
+import urllib2
+import json
+import re
+import yaml
+from urlparse import urljoin
+from urllib import quote
+from base64 import b64encode
+
+from prometheus_client import start_http_server, Summary
+from prometheus_client.core import (CounterMetricFamily, GaugeMetricFamily,
+REGISTRY)
+
+log = logging.getLogger(__name__)
+
+
+class RabbitMQClient(object):
+
+def __init__(self, host, user, password, timeout=5):
+self.base_url = 'http://%s/api/' % (host)
+self.timeout = timeout
+self._authorization = 'Basic ' + b64encode('%s:%s' % (user, password))
+
+def do_call(self, path):
+url = urljoin(self.base_url, path)
+req = urllib2.Request(url)
+req.add_header('Authorization', self._authorization)
+return json.load(urllib2.urlopen(req, timeout=self.timeout))
+
+def get_queues(self, vhost=None):
+path = 'queues'
+if vhost:
+vhost = quote(vhost, '')
+path += '/%s' % vhost
+
+queues = self.do_call(path)
+return queues or []
+
+def get_overview(self):
+return self.do_call('overview')
+
+def get_node(self, node):
+return self.do_call('nodes/%s' % node)
+
+
+class PowerRabbitMQCollector(object):
+scrape_duration = Summary(
+'rabbitmq_scrape_duration_seconds', 'RabbitMQ exporter scrape 
duration')
+
+stats_url = 'http://localhost:9001/stats'
+metrics = {}
+
+def __init__(self, config):
+cfg_file = yaml.load(config)
+self.host = cfg_file['server']
+self.user = cfg_file['username']
+self.password = cfg_file['password']
+
+def publish_metric(self, name, prev_keys, key, data):
+value = data[key]
+keys = prev_keys + [key]
+if isinstance(value, dict):
+for new_key in value:
+self.publish_metric(name, keys, new_key, value)
+elif isinstance(value, (float, int, long)):
+joined_keys = '.'.join(keys)
+if name:
+publish_key = '{0}.{1}'.format(name, joined_keys)
+else:
+publish_key = joined_keys
+if isinstance(value, bool):
+value = int(value)
+
+try:
+value = float(value)
+except ValueError:
+value = float('nan')
+metric = GaugeMetricFamily(publish_key, '')
+metric.add_metric([], value)
+self.metrics[publish_key] = metric
+
+@scrape_duration.time()
+def collect(self):
+matchers = []
+
+health_metrics = [
+'fd_used',
+'fd_total',
+'mem_used',
+'mem_limit',
+'sockets_used',
+'sockets_total',
+

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: db-eqiad.php: Depool db1103:3314

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398002 )

Change subject: db-eqiad.php: Depool db1103:3314
..


db-eqiad.php: Depool db1103:3314

Needs alter table

Bug: T174569
Change-Id: Ib113198016037ce40493df0c0fc60aa6b76a1a1a
---
M wmf-config/db-eqiad.php
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 1cb4c4b..88f6892 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -140,7 +140,7 @@
'db1084' => 400, # B1 3.6TB 512GB, api
'db1091' => 500, # D2 3.6TB 512GB
'db1097:3314' => 1,   # D1 3.6TB 512GB, # rc, log: s4 and s5
-   'db1103:3314' => 1,  # A3 3.6TB 512GB # rc, log: s2 and s4
+   # 'db1103:3314' => 1,  # A3 3.6TB 512GB # rc, log: s2 and s4 # 
T174569
],
's5' => [
'db1070' => 0,   # D1 2.8TB 160GB, master
@@ -370,27 +370,27 @@
'watchlist' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'recentchanges' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'recentchangeslinked' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'contributions' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'logpager' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
],
's5' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/398002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib113198016037ce40493df0c0fc60aa6b76a1a1a
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: db-eqiad.php: Depool db1103:3314

[Marostegui (Code Review)]

Marostegui has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398002 )

Change subject: db-eqiad.php: Depool db1103:3314
..

db-eqiad.php: Depool db1103:3314

Needs alter table

Bug: T174569
Change-Id: Ib113198016037ce40493df0c0fc60aa6b76a1a1a
---
M wmf-config/db-eqiad.php
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/02/398002/1

diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 1cb4c4b..88f6892 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -140,7 +140,7 @@
'db1084' => 400, # B1 3.6TB 512GB, api
'db1091' => 500, # D2 3.6TB 512GB
'db1097:3314' => 1,   # D1 3.6TB 512GB, # rc, log: s4 and s5
-   'db1103:3314' => 1,  # A3 3.6TB 512GB # rc, log: s2 and s4
+   # 'db1103:3314' => 1,  # A3 3.6TB 512GB # rc, log: s2 and s4 # 
T174569
],
's5' => [
'db1070' => 0,   # D1 2.8TB 160GB, master
@@ -370,27 +370,27 @@
'watchlist' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'recentchanges' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'recentchangeslinked' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'contributions' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
'logpager' => [
# 'db1056' => 1,
'db1097:3314' => 1,
-   'db1103:3314' => 1,
+   # 'db1103:3314' => 1,
],
],
's5' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/398002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib113198016037ce40493df0c0fc60aa6b76a1a1a
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add config file with access credentials for Prometheus Rabbi...

[Muehlenhoff (Code Review)]

Muehlenhoff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398001 )

Change subject: Add config file with access credentials for Prometheus RabbitMQ 
exporter
..

Add config file with access credentials for Prometheus RabbitMQ exporter

Bug: T181802
Change-Id: Ic4cfc2c1d700e2406b779c9351e22741c8bfa417
---
A modules/profile/templates/prometheus/rabbitmq-exporter.conf.erb
M modules/rabbitmq/manifests/monitor.pp
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/01/398001/1

diff --git a/modules/profile/templates/prometheus/rabbitmq-exporter.conf.erb 
b/modules/profile/templates/prometheus/rabbitmq-exporter.conf.erb
new file mode 100644
index 000..b03ff52
--- /dev/null
+++ b/modules/profile/templates/prometheus/rabbitmq-exporter.conf.erb
@@ -0,0 +1,4 @@
+---
+server: <%= $rabbit_host %>
+username: <%= $rabbit_monitor_username %>
+password: <%= $rabbit_monitor_password %>
diff --git a/modules/rabbitmq/manifests/monitor.pp 
b/modules/rabbitmq/manifests/monitor.pp
index 55084741..2d8a64b 100644
--- a/modules/rabbitmq/manifests/monitor.pp
+++ b/modules/rabbitmq/manifests/monitor.pp
@@ -12,4 +12,12 @@
 },
 source   => 'puppet:///modules/rabbitmq/rabbitmq.py',
 }
+
+file { '/etc/prometheus/rabbitmq-exporter.yaml':
+ensure  => present,
+mode=> '0440',
+owner   => 'prometheus',
+group   => 'prometheus',
+content => template('profile/prometheus/rabbitmq-exporter.conf.erb'),
+}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/398001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4cfc2c1d700e2406b779c9351e22741c8bfa417
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "db-eqiad.php: Depool db1097:3314"

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397869 )

Change subject: Revert "db-eqiad.php: Depool db1097:3314"
..


Revert "db-eqiad.php: Depool db1097:3314"

This reverts commit 16b4fd99061e4b2058a786be909f7a967663095a.

Change-Id: Id47e892d061a3d3bf4fc9df9436418f90bd063e9
---
M wmf-config/db-eqiad.php
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index e2a0c8c..1cb4c4b 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -139,7 +139,7 @@
'db1081' => 300, # A2 3.6TB 512GB, api
'db1084' => 400, # B1 3.6TB 512GB, api
'db1091' => 500, # D2 3.6TB 512GB
-   # 'db1097:3314' => 1,   # D1 3.6TB 512GB, # rc, log: s4 and s5 
# T174569
+   'db1097:3314' => 1,   # D1 3.6TB 512GB, # rc, log: s4 and s5
'db1103:3314' => 1,  # A3 3.6TB 512GB # rc, log: s2 and s4
],
's5' => [
@@ -369,27 +369,27 @@
],
'watchlist' => [
# 'db1056' => 1,
-   # 'db1097:3314' => 1,
+   'db1097:3314' => 1,
'db1103:3314' => 1,
],
'recentchanges' => [
# 'db1056' => 1,
-   # 'db1097:3314' => 1,
+   'db1097:3314' => 1,
'db1103:3314' => 1,
],
'recentchangeslinked' => [
# 'db1056' => 1,
-   # 'db1097:3314' => 1,
+   'db1097:3314' => 1,
'db1103:3314' => 1,
],
'contributions' => [
# 'db1056' => 1,
-   # 'db1097:3314' => 1,
+   'db1097:3314' => 1,
'db1103:3314' => 1,
],
'logpager' => [
# 'db1056' => 1,
-   # 'db1097:3314' => 1,
+   'db1097:3314' => 1,
'db1103:3314' => 1,
],
],

-- 
To view, visit https://gerrit.wikimedia.org/r/397869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id47e892d061a3d3bf4fc9df9436418f90bd063e9
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Record new account expiry date for pnorman

[Muehlenhoff (Code Review)]

Muehlenhoff has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398000 )

Change subject: Record new account expiry date for pnorman
..


Record new account expiry date for pnorman

Change-Id: I7818f96172e4149e48105ac5c604dff6234f3ed7
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Muehlenhoff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 2a5ed29..26c5e8c 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -2517,7 +2517,7 @@
   - ssh-rsa 
B3NzaC1yc2EDAQABAAACAQCy7wnX7ck41mKRzXvt5n/2UVEDkK1T9L5iyDFAWgDAbjgWqjBgnfHVq88lX1d/WOUNjNzF1WnRWn1vk6gKk3eoNlIbEcIvfLGYB+e6yGsE9KZWyvcpWcIBhhe9YH4d7nY34ScUIH42bZkXh2iGu5VpQVm8G5Wf9iqSwKFHSAy+Bl3jclaHSPfUmGxTbjC2e20Xns8BvybEW4dBjb79/eHNR1K/9f5JHeLM9ZE3wKVYC07kSnsYCGVWWr2zqyjpmBl2hQe/0C0pvx2AoTzEYK58BZZUkui3aIihSDiDMxDujNypUtePyoCq14t8dLSkIfOh0kRKAVmC/6oVwzSFbvZ7yjyU5ApsUK1DqCmFw/yz9M/nRuAs3qkXwFC1XUyjNBiVBEbWKDGxBx08TjZPKSvbtQD3DaU7RvXJUh3hsDcrgfky6ZlfV9y1bRp7heHVAShVWrsTwoQt/PF6uZ2ud71Ri51bV9qlHdT/BmF+UJ86LSPzTHSKt57GEXguVVPCGgfjFm+WugW4SOC+Bx/IEQC7+hfgXZjr6CQt+zCOExBS6IpknDBIzuvdbrNKG1auBn6nJKCAURRR3q71tCGlihjV39u5ZEmGqacsIYDA1SSTGqUGq5MuaVoVuS0rBPwFjO1enhqDT6wl9qBVuHUDlis9XQ2wOyLT3yqG0sGYxpNF0w==
 pnorman@pippin
 uid: 16082
 email: penor...@mac.com
-expiry_date: 2017-11-30
+expiry_date: 2017-02-28
 expiry_contact: ab...@wikimedia.org
   ayounsi:
 ensure: present

-- 
To view, visit https://gerrit.wikimedia.org/r/398000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7818f96172e4149e48105ac5c604dff6234f3ed7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Record new account expiry date for pnorman

[Muehlenhoff (Code Review)]

Muehlenhoff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398000 )

Change subject: Record new account expiry date for pnorman
..

Record new account expiry date for pnorman

Change-Id: I7818f96172e4149e48105ac5c604dff6234f3ed7
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/00/398000/1

diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 2a5ed29..26c5e8c 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -2517,7 +2517,7 @@
   - ssh-rsa 
B3NzaC1yc2EDAQABAAACAQCy7wnX7ck41mKRzXvt5n/2UVEDkK1T9L5iyDFAWgDAbjgWqjBgnfHVq88lX1d/WOUNjNzF1WnRWn1vk6gKk3eoNlIbEcIvfLGYB+e6yGsE9KZWyvcpWcIBhhe9YH4d7nY34ScUIH42bZkXh2iGu5VpQVm8G5Wf9iqSwKFHSAy+Bl3jclaHSPfUmGxTbjC2e20Xns8BvybEW4dBjb79/eHNR1K/9f5JHeLM9ZE3wKVYC07kSnsYCGVWWr2zqyjpmBl2hQe/0C0pvx2AoTzEYK58BZZUkui3aIihSDiDMxDujNypUtePyoCq14t8dLSkIfOh0kRKAVmC/6oVwzSFbvZ7yjyU5ApsUK1DqCmFw/yz9M/nRuAs3qkXwFC1XUyjNBiVBEbWKDGxBx08TjZPKSvbtQD3DaU7RvXJUh3hsDcrgfky6ZlfV9y1bRp7heHVAShVWrsTwoQt/PF6uZ2ud71Ri51bV9qlHdT/BmF+UJ86LSPzTHSKt57GEXguVVPCGgfjFm+WugW4SOC+Bx/IEQC7+hfgXZjr6CQt+zCOExBS6IpknDBIzuvdbrNKG1auBn6nJKCAURRR3q71tCGlihjV39u5ZEmGqacsIYDA1SSTGqUGq5MuaVoVuS0rBPwFjO1enhqDT6wl9qBVuHUDlis9XQ2wOyLT3yqG0sGYxpNF0w==
 pnorman@pippin
 uid: 16082
 email: penor...@mac.com
-expiry_date: 2017-11-30
+expiry_date: 2017-02-28
 expiry_contact: ab...@wikimedia.org
   ayounsi:
 ensure: present

-- 
To view, visit https://gerrit.wikimedia.org/r/398000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7818f96172e4149e48105ac5c604dff6234f3ed7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Rename deprecated language code 'mo' to 'ro-cyrl'

[Fomafix (Code Review)]

Fomafix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397999 )

Change subject: Rename deprecated language code 'mo' to 'ro-cyrl'
..

Rename deprecated language code 'mo' to 'ro-cyrl'

According to https://www.iana.org/assignments/language-subtag-registry
the language code 'mo' is deprecated since 2008-11-22 and should
replaced by 'ro':

Type: language
Subtag: mo
Description: Moldavian
Description: Moldovan
Added: 2005-10-16
Deprecated: 2008-11-22
Preferred-Value: ro
Suppress-Script: Latn

The existing messages are in Cyrillic script. The language code must
use the subtag 'Cyrl' because for 'ro' and for 'mo' the Suppress-Script
is 'Latn'.

Bug: T18889
Change-Id: I1a161c41622f914b3d948de6d90125a41909bab2
---
M RELEASE-NOTES-1.31
M languages/LanguageCode.php
M languages/data/Names.php
R languages/i18n/ro-cyrl.json
R languages/messages/MessagesRo_cyrl.php
5 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/99/397999/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 4a2876d..5ebef78 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -69,6 +69,7 @@
 changes to languages because of Phabricator reports.
 
 * (T180052) Mirandese (mwl) now supports gendered NS_USER/NS_USER_TALK 
namespaces.
+* Renamed language code for Moldavian from 'mo' to 'ro-cyrl'.
 
 === Other changes in 1.31 ===
 * MessageBlobStore::insertMessageBlob() (deprecated in 1.27) was removed.
diff --git a/languages/LanguageCode.php b/languages/LanguageCode.php
index f50c55f..22addd0 100644
--- a/languages/LanguageCode.php
+++ b/languages/LanguageCode.php
@@ -42,6 +42,7 @@
'bat-smg' => 'sgs',
'be-x-old' => 'be-tarask',
'fiu-vro' => 'vro',
+   'mo' => 'ro-cyrl',
'roa-rup' => 'rup',
'zh-classical' => 'lzh',
'zh-min-nan' => 'nan',
diff --git a/languages/data/Names.php b/languages/data/Names.php
index 281be2b..831f9c9 100644
--- a/languages/data/Names.php
+++ b/languages/data/Names.php
@@ -290,7 +290,6 @@
'mk' => 'македонски', # Macedonian
'ml' => 'മലയാളം', # Malayalam
'mn' => 'монгол', # Halh Mongolian (Cyrillic) (ISO 639-3: khk)
-   'mo' => 'молдовеняскэ', # Moldovan, deprecated
'mr' => 'मराठी', # Marathi
'mrj' => 'кырык мары', # Hill Mari
'ms' => 'Bahasa Melayu', # Malay
@@ -351,6 +350,7 @@
'rmy' => 'Romani', # Vlax Romany
'rn' => 'Kirundi', # Rundi/Kirundi/Urundi
'ro' => 'română', # Romanian
+   'ro-cyrl' => 'молдовеняскэ', # Moldovan in Cyrillic script
'roa-rup' => 'armãneashti', # Aromanian (deprecated code, 'rup' 
exists in ISO 693-3)
'roa-tara' => 'tarandíne', # Tarantino
'ru' => 'русский', # Russian
diff --git a/languages/i18n/mo.json b/languages/i18n/ro-cyrl.json
similarity index 100%
rename from languages/i18n/mo.json
rename to languages/i18n/ro-cyrl.json
diff --git a/languages/messages/MessagesMo.php 
b/languages/messages/MessagesRo_cyrl.php
similarity index 87%
rename from languages/messages/MessagesMo.php
rename to languages/messages/MessagesRo_cyrl.php
index 744fe73..3c5b427 100644
--- a/languages/messages/MessagesMo.php
+++ b/languages/messages/MessagesRo_cyrl.php
@@ -1,5 +1,5 @@
 https://translatewiki.net
  *

-- 
To view, visit https://gerrit.wikimedia.org/r/397999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a161c41622f914b3d948de6d90125a41909bab2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: icons: Add lightbulb icon

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397998 )

Change subject: icons: Add lightbulb icon
..

icons: Add lightbulb icon

Bug: T175006
Change-Id: I90fe58e79559b7e47a62af6b216098b49802b274
---
M demos/pages/icons.js
M src/themes/apex/icons-alerts.json
A src/themes/apex/images/icons/lightbulb.svg
M src/themes/wikimediaui/icons-alerts.json
A src/themes/wikimediaui/images/icons/lightbulb.svg
5 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/98/397998/1

diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index 0f85058..8d9d8a4 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -38,6 +38,7 @@
'alert',
'bell',
'comment',
+   'lightbulb',
'message',
'notice',
'speechBubble',
diff --git a/src/themes/apex/icons-alerts.json 
b/src/themes/apex/icons-alerts.json
index 9bef0a1..ca2a8c3 100644
--- a/src/themes/apex/icons-alerts.json
+++ b/src/themes/apex/icons-alerts.json
@@ -11,6 +11,7 @@
"deprecated": "This will be removed in v0.26.0."
},
"comment": { "file": "images/icons/comment.svg" },
+   "lightbulb": { "file": "images/icons/lightbulb.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",
"rtl": "images/icons/message-rtl.svg"
diff --git a/src/themes/apex/images/icons/lightbulb.svg 
b/src/themes/apex/images/icons/lightbulb.svg
new file mode 100644
index 000..a4aa8f3
--- /dev/null
+++ b/src/themes/apex/images/icons/lightbulb.svg
@@ -0,0 +1,5 @@
+
+http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
+   
+   
+
diff --git a/src/themes/wikimediaui/icons-alerts.json 
b/src/themes/wikimediaui/icons-alerts.json
index 996609b..a51caf9 100644
--- a/src/themes/wikimediaui/icons-alerts.json
+++ b/src/themes/wikimediaui/icons-alerts.json
@@ -28,6 +28,7 @@
"deprecated": "This will be removed in v0.26.0."
},
"comment": { "file": "images/icons/comment.svg" },
+   "lightbulb": { "file": "images/icons/lightbulb.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",
"rtl": "images/icons/message-rtl.svg"
diff --git a/src/themes/wikimediaui/images/icons/lightbulb.svg 
b/src/themes/wikimediaui/images/icons/lightbulb.svg
new file mode 100644
index 000..a4aa8f3
--- /dev/null
+++ b/src/themes/wikimediaui/images/icons/lightbulb.svg
@@ -0,0 +1,5 @@
+
+http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
+   
+   
+

-- 
To view, visit https://gerrit.wikimedia.org/r/397998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90fe58e79559b7e47a62af6b216098b49802b274
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nova fullstack: update image for testing

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397997 )

Change subject: nova fullstack: update image for testing
..

nova fullstack: update image for testing

Change-Id: I298f6f66832414fceb0a0300f81583345e83f2c4
---
M modules/openstack/files/nova/fullstack/nova_fullstack_test.py
M modules/openstack/templates/initscripts/nova-fullstack.upstart.erb
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/97/397997/1

diff --git a/modules/openstack/files/nova/fullstack/nova_fullstack_test.py 
b/modules/openstack/files/nova/fullstack/nova_fullstack_test.py
index 6cc90d4..3c52b23 100644
--- a/modules/openstack/files/nova/fullstack/nova_fullstack_test.py
+++ b/modules/openstack/files/nova/fullstack/nova_fullstack_test.py
@@ -363,7 +363,7 @@
 
 argparser.add_argument(
 '--image',
-default='debian-8.9-jessie',
+default='debian-8.10-jessie',
 help='Image to use',
 )
 
diff --git a/modules/openstack/templates/initscripts/nova-fullstack.upstart.erb 
b/modules/openstack/templates/initscripts/nova-fullstack.upstart.erb
index a5ba920..8fe909a 100644
--- a/modules/openstack/templates/initscripts/nova-fullstack.upstart.erb
+++ b/modules/openstack/templates/initscripts/nova-fullstack.upstart.erb
@@ -26,7 +26,7 @@
--max-pool <%= @max_pool %>  \
--project admin-monitoring \
--prepend fullstackd \
-   --image debian-8.9-jessie \
+   --image debian-8.10-jessie \
--flavor m1.small \
--keyfile <%= @keyfile %> \
--statsd statsd.eqiad.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/397997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I298f6f66832414fceb0a0300f81583345e83f2c4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [wip] RCFilters: Synchronize input with menu filters

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397996 )

Change subject: [wip] RCFilters: Synchronize input with menu filters
..

[wip] RCFilters: Synchronize input with menu filters

Synchronize the input value with the visible elements in the menu
by making sure that:
1. The switching of view through a trigger in the input happens
   **before anything else** in change events.
2. Make the view model's findMatches (so, the Menu's updateItemVisibility)
   as the ultimate source of truth as to what should be visible. The items
   are now **always** all included in the menu, but they change their
   visibility according to the logic in the findMatches. If there is a search
   term, the function will account for that and the selected view, so we can
   be sure that search results also change between changing views.

Bug: T182720
Change-Id: If575f348705d863b9d68d19761ded55a4d453550
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
2 files changed, 57 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/96/397996/1

diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 8d22c23..46b5597 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -999,12 +999,13 @@
groupTitle,
result = {},
flatResult = [],
-   view = this.getViewByTrigger( query.substr( 0, 1 ) ),
+   view = this.getCurrentView(),
+   queryView = this.getViewByTrigger( query.substr( 0, 1 ) 
),
items = this.getFiltersByView( view );
 
// Normalize so we can search strings regardless of case and 
view
query = query.trim().toLowerCase();
-   if ( view !== 'default' ) {
+   if ( queryView !== 'default' ) {
query = query.substr( 1 );
}
// Trim again to also intercept cases where the spaces were 
after the trigger
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index 22c176f..b43e1d6 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -49,6 +49,19 @@
);
this.setClippableElement( this.$body );
this.setClippableContainer( this.$element );
+   // HACK: We need to make sure things happen as the input is 
changed
+   // and **before** item visibility is called. Right now, the 
only way to
+   // do that is to override OO.ui.MenuSelectWidget's 
onInputEditHandler to
+   // an intermediary method that does what we need it to do and 
*then*
+   // calls this.updateItemVisibility().
+   // TODO: This should be upstreamed so that we just need to 
extend
+   // the method responding to the inputEditHandler rather than
+   // overriding this in the constructor
+   this.onInputEditHandler = OO.ui.debounce( 
this.inputEditHandler.bind( this ), 100 );
+   // The original widget also doesn't account for the input 
changing by external
+   // forces. So we bind that to other types of changes without 
needing keyup/down
+   // event
+   this.$input.on( 'change', this.onInputEditHandler );
 
header = new mw.rcfilters.ui.FilterMenuHeaderWidget(
this.controller,
@@ -122,6 +135,19 @@
/* Methods */
 
/**
+* Respond to an edit on the input
+*/
+   mw.rcfilters.ui.MenuSelectWidget.prototype.inputEditHandler = function 
() {
+   var inputVal = this.$input.val().trim();
+
+   // Change view
+   this.controller.switchView(
+   this.model.getViewByTrigger( inputVal.substr( 0, 1 ) )
+   );
+   this.updateItemVisibility();
+   };
+
+   /**
 * Respond to model update event
 */
mw.rcfilters.ui.MenuSelectWidget.prototype.onModelUpdate = function () {
@@ -143,6 +169,7 @@
mw.rcfilters.ui.MenuSelectWidget.prototype.lazyMenuCreation = function 
() {
var widget = this,
viewGroupCount = {},
+   items = [],
groups = this.model.getFilterGroups();
 
  

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrapvz: allow default (v4) puppet packages on stretch b...

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397966 )

Change subject: bootstrapvz: allow default (v4) puppet packages on stretch base 
images.
..


bootstrapvz: allow default (v4) puppet packages on stretch base images.

Bug: T178717
Change-Id: I5a7cd72e630e6bbd2d29cedbb3b31ecafe387603
---
M modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml 
b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
index 4188877..f01f88c 100644
--- a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
+++ b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
@@ -91,8 +91,8 @@
 - os-prober
 - parted
 - prometheus-node-exporter
-- puppet=3.8.5-2
-- puppet-common=3.8.5-2
+- puppet
+- puppet-common
 - pv
 - python-apt
 - python-ldap

-- 
To view, visit https://gerrit.wikimedia.org/r/397966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a7cd72e630e6bbd2d29cedbb3b31ecafe387603
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet agent: don't call etckeeper hooks pre- and post-run

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397967 )

Change subject: puppet agent: don't call etckeeper hooks pre- and post-run
..


puppet agent: don't call etckeeper hooks pre- and post-run

Best I can tell this was never used; it also appears to be
less supported in modern Puppet versions.

Bug: T182721
Change-Id: I4e1e5ea46f00aa3abfbfa16cf38e107c7551c212
---
M modules/base/templates/puppet.conf.d/10-main.conf.erb
M modules/puppet/templates/self.conf.erb
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  Alexandros Kosiaris: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/base/templates/puppet.conf.d/10-main.conf.erb 
b/modules/base/templates/puppet.conf.d/10-main.conf.erb
index 3aea596..ca8d341 100644
--- a/modules/base/templates/puppet.conf.d/10-main.conf.erb
+++ b/modules/base/templates/puppet.conf.d/10-main.conf.erb
@@ -24,8 +24,6 @@
 configtimeout = 960
 usecacheonfailure = false
 splay = true
-prerun_command = /etc/puppet/etckeeper-commit-pre
-postrun_command = /etc/puppet/etckeeper-commit-post
 pluginsync = true
 report = true
 stringify_facts = false
diff --git a/modules/puppet/templates/self.conf.erb 
b/modules/puppet/templates/self.conf.erb
index f3ce85c..7302aaa 100644
--- a/modules/puppet/templates/self.conf.erb
+++ b/modules/puppet/templates/self.conf.erb
@@ -11,8 +11,6 @@
 server = <%= server %>
 configtimeout = 480
 splay = true
-prerun_command = /etc/puppet/etckeeper-commit-pre
-postrun_command = /etc/puppet/etckeeper-commit-post
 pluginsync = true
 report = true
 <%

-- 
To view, visit https://gerrit.wikimedia.org/r/397967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e1e5ea46f00aa3abfbfa16cf38e107c7551c212
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Faidon Liambotis 
Gerrit-Reviewer: Gehel 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Herron 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/wikistats2[master]: Fix infinite loop

[Milimetric (Code Review)]

Milimetric has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397995 )

Change subject: Fix infinite loop
..

Fix infinite loop

For the future, the flow of events and data in WikiSelector is too
circular.  The init calls get triggered when they're not necessary,
after state changes.

Also, the way the hidden div is added with an id is not great, that
should at least have a class and in general should be added relative to
the component in case multiple versions of the same component are used
on the page.

Bug: T182700
Change-Id: I1dd5f4bce62caaf14215b4fa158d030f53e8f084
---
M src/components/WikiSelector.vue
1 file changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats2 
refs/changes/95/397995/1

diff --git a/src/components/WikiSelector.vue b/src/components/WikiSelector.vue
index c317788..bf8c50d 100644
--- a/src/components/WikiSelector.vue
+++ b/src/components/WikiSelector.vue
@@ -31,6 +31,8 @@
 
 
 

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Media: Mark items in MW galleries with gallery IDs

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397994 )

Change subject: Media: Mark items in MW galleries with gallery IDs
..

Media: Mark items in MW galleries with gallery IDs

Bug: T177430
Change-Id: I4c448aeda6f7d6dd42f85aff7a5c4be2654f2940
---
M lib/media.js
M test/diff/results/page_media-enwiki-Hummingbird.json
2 files changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/94/397994/1

diff --git a/lib/media.js b/lib/media.js
index ca11c4c..da71dd1 100644
--- a/lib/media.js
+++ b/lib/media.js
@@ -66,6 +66,8 @@
 };
 const section = elem.closest('section') || undefined;
 const sectionId = section && 
parseInt(section.getAttribute('data-mw-section-id'), 10);
+const gallery = elem.closest('.gallery') || undefined;
+const galleryId = gallery && gallery.getAttribute('id');
 let title = resource && 
resource.getAttribute('resource').replace(/^.\//, '');
 let startTime;
 let endTime;
@@ -109,6 +111,7 @@
 end_time: endTime,
 thumb_time: thumbTime,
 audio_type: audioType,
+gallery_id: galleryId,
 sources
 };
 });
diff --git a/test/diff/results/page_media-enwiki-Hummingbird.json 
b/test/diff/results/page_media-enwiki-Hummingbird.json
index e3a50d5..784b995 100644
--- a/test/diff/results/page_media-enwiki-Hummingbird.json
+++ b/test/diff/results/page_media-enwiki-Hummingbird.json
@@ -87,6 +87,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAQU",
   "titles": {
 "canonical": "File:Hummingbird_Incubating3.jpg",
 "normalized": "File:Hummingbird Incubating3.jpg",
@@ -113,6 +114,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAQU",
   "titles": {
 "canonical": 
"File:Hummingbird_nest_with_two_chicks_in_Santa_Monica,_CA._Photo_taken_June_26,_2006.jpg",
 "normalized": "File:Hummingbird nest with two chicks in Santa Monica, 
CA. Photo taken June 26, 2006.jpg",
@@ -138,6 +140,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAQU",
   "titles": {
 "canonical": "File:Calliope-nest_edit.jpg",
 "normalized": "File:Calliope-nest edit.jpg",
@@ -496,6 +499,7 @@
 },
 {
   "type": "video",
+  "gallery_id": "mwAi0",
   "sources": [
 {
   "source": 
"https://upload.wikimedia.org/wikipedia/commons/f/fe/Humming_birds_feeding_at_1500fps.webm;,
@@ -571,6 +575,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Hummingbird_feeding.jpg",
 "normalized": "File:Hummingbird feeding.jpg",
@@ -597,6 +602,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Hummingbird_headshot.jpg",
 "normalized": "File:Hummingbird headshot.jpg",
@@ -623,6 +629,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Eugenes-fulgens-001.jpg",
 "normalized": "File:Eugenes-fulgens-001.jpg",
@@ -649,6 +656,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Hummingbird.jpg",
 "normalized": "File:Hummingbird.jpg",
@@ -674,6 +682,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": 
"File:Juvenile_Annas_Hummingbird_at_San_Francisco_Botanical_Garden_-_Stierch_-_E.jpg",
 "normalized": "File:Juvenile Annas Hummingbird at San Francisco 
Botanical Garden - Stierch - E.jpg",
@@ -700,6 +709,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Hummingbird_Calypte_anna_in_ggp_15n.jpg",
 "normalized": "File:Hummingbird Calypte anna in ggp 15n.jpg",
@@ -726,6 +736,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": "File:Nano_Hummingbird.jpg",
 "normalized": "File:Nano Hummingbird.jpg",
@@ -751,6 +762,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": 
"File:Hummingbird_Chicks_in_Nest_in_Cactus_in_Mesa,_Arizona.jpg",
 "normalized": "File:Hummingbird Chicks in Nest in Cactus in Mesa, 
Arizona.jpg",
@@ -777,6 +789,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": 
"File:Hummingbird_Adult_in_Nest_in_Cactus_in_Mesa,_Arizona.jpg",
 "normalized": "File:Hummingbird Adult in Nest in Cactus in Mesa, 
Arizona.jpg",
@@ -803,6 +816,7 @@
 },
 {
   "type": "image",
+  "gallery_id": "mwAi0",
   "titles": {
 "canonical": 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases jenkins: Ensure php-curl is present (version doesn'...

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397993 )

Change subject: Releases jenkins: Ensure php-curl is present (version doesn't 
matter)
..

Releases jenkins: Ensure php-curl is present (version doesn't matter)

Change-Id: I891fa85abbe76311cc36f3a79b2948f851aa046b
---
M modules/releases/manifests/init.pp
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/93/397993/1

diff --git a/modules/releases/manifests/init.pp 
b/modules/releases/manifests/init.pp
index 6c6c3b6..b3b7080 100644
--- a/modules/releases/manifests/init.pp
+++ b/modules/releases/manifests/init.pp
@@ -83,4 +83,8 @@
 package { 'phpunit':
 ensure => present,
 }
+
+package { 'php-curl':
+ensure => present,
+}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/397993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I891fa85abbe76311cc36f3a79b2948f851aa046b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Apply `opacity` button transition and ensure Chr...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395907 )

Change subject: Apex theme: Apply `opacity` button transition and ensure Chrome 
support
..


Apex theme: Apply `opacity` button transition and ensure Chrome support

With `.oo-ui-force-gpu-composite-layer()` support we are able to
provide `opacity` transition now.
Follow-up to Ied6debd7fae5a545736492776a1fd4a9e85f1f62.

Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
---
M src/themes/apex/elements.less
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/themes/apex/elements.less b/src/themes/apex/elements.less
index 02850c0..7124f1e 100644
--- a/src/themes/apex/elements.less
+++ b/src/themes/apex/elements.less
@@ -39,9 +39,15 @@
 
&-frameless {
> .oo-ui-buttonElement-button {
-   // Don't animate `.oo-ui-iconElement-icon` `opacity` 
for now,
-   // causes wiggling in Chrome, see T65020
-   // `.oo-ui-transition( opacity @medium-ease );`
+   > .oo-ui-iconElement-icon {
+   .oo-ui-transition( opacity @medium-ease );
+   // Support Webkit/Blink: `opacity` < 1 causes 
wiggling, see T65020
+   .oo-ui-force-gpu-composite-layer();
+   }
+
+   > .oo-ui-labelElement-label {
+   color: @color-base;
+   }
 
&:hover,
&:focus {
@@ -52,10 +58,6 @@
> .oo-ui-labelElement-label {
color: #000;
}
-   }
-
-   > .oo-ui-labelElement-label {
-   color: @color-base;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Align readonly TextInputWidget across themes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/396556 )

Change subject: Apex theme: Align readonly TextInputWidget across themes
..


Apex theme: Align readonly TextInputWidget across themes

Bringing readonly TextInputWidget closer to WikimediaUI theme,
removing similarities with placeholder appearance.

Bug: T182426
Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
---
M src/themes/apex/widgets.less
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index d598ec2..a549604 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -1336,16 +1336,17 @@
}
 
&.oo-ui-widget-enabled {
-   input:focus,
-   textarea:focus {
-   outline: 0;
-   border-color: @border-color-base--focus;
-   box-shadow: @box-shadow-widget--focus;
-   }
+   input,
+   textarea {
+   &:focus {
+   outline: 0;
+   border-color: @border-color-base--focus;
+   box-shadow: @box-shadow-widget--focus;
+   }
 
-   input[ readonly ],
-   textarea[ readonly ] {
-   color: @color-base--read-only;
+   &[ readonly ] {
+   background-color: #f3f3f3;
+   }
}
 
&.oo-ui-flaggedElement-invalid {

-- 
To view, visit https://gerrit.wikimedia.org/r/396556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...ZppixBot[master]: Update how to get the Bot in your channel

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397992 )

Change subject: Update how to get the Bot in your channel
..


Update how to get the Bot in your channel

Change-Id: Ie27d696c177bb10163b6cff6b6739a75a947a473
---
M public_html/index.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Zppix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/public_html/index.php b/public_html/index.php
index 1b315b6..4f16821 100644
--- a/public_html/index.php
+++ b/public_html/index.php
@@ -2,7 +2,7 @@
 For a list of commands, click here. 

 List of contributors, click here 
 
-If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
+If you would like ZppixBot in your channel, join #ZppixBot and bug Zppix or 
Reception123. 
 
  The second release of ZppixBot is now here! 
  For more information please check out https://github.com/Pix1234/ZppixBot-Source/releases/tag/v2;>the release 
tag !!!

-- 
To view, visit https://gerrit.wikimedia.org/r/397992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie27d696c177bb10163b6cff6b6739a75a947a473
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/ZppixBot
Gerrit-Branch: master
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: Zppix 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...ZppixBot[master]: Update how to get the Bot in your channel

[MacFan4000 (Code Review)]

MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397992 )

Change subject: Update how to get the Bot in your channel
..

Update how to get the Bot in your channel

Change-Id: Ie27d696c177bb10163b6cff6b6739a75a947a473
---
M public_html/index.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/ZppixBot 
refs/changes/92/397992/2

diff --git a/public_html/index.php b/public_html/index.php
index 1b315b6..4f16821 100644
--- a/public_html/index.php
+++ b/public_html/index.php
@@ -2,7 +2,7 @@
 For a list of commands, click here. 

 List of contributors, click here 
 
-If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
+If you would like ZppixBot in your channel, join #ZppixBot and bug Zppix or 
Reception123. 
 
  The second release of ZppixBot is now here! 
  For more information please check out https://github.com/Pix1234/ZppixBot-Source/releases/tag/v2;>the release 
tag !!!

-- 
To view, visit https://gerrit.wikimedia.org/r/397992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie27d696c177bb10163b6cff6b6739a75a947a473
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/ZppixBot
Gerrit-Branch: master
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Dev: Stop caching test HTTP responses by default

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/396425 )

Change subject: Dev: Stop caching test HTTP responses by default
..


Dev: Stop caching test HTTP responses by default

Let's leave it up to the developer to set this in an environment variable
if desired.

Change-Id: If3113027ff730ea6d1aa3398c869f197d5759e6e
---
M README.md
M test/utils/server.js
2 files changed, 9 insertions(+), 16 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/README.md b/README.md
index 9d4611c..d2613ec 100644
--- a/README.md
+++ b/README.md
@@ -118,18 +118,19 @@
 This project takes advantage of HTTP request recording provided by the
 [sepia](https://www.npmjs.com/package/sepia) library to make running the tests 
much faster.
 
-If no `VCR_MODE` variable is found in the environment or provided at the 
command line,
-the tests will run with `VCR_MODE=cache`. After running for the first time, 
HTTP interactions
-should be cached in the `fixtures/` folder. The next time you run the tests, 
they should use
-the cached fixtures and run faster.
-
-To skip the cached fixtures, provide an unexpected VCR_MODE value from the 
command line, e.g.:
+To take advantage of HTTP response caching, either set an environment variable
+`VCR_MODE=cache`, or specify at the command line when running the tests:
 
 ```
-VCR_MODE=off npm test
+VCR_MODE=cache npm test
 ```
 
-To get fresh fixtures just remove the `fixtures` folder and re-run the tests.
+After running for the first time with `VCR_MODE=cache`, HTTP interactions 
should be cached
+in the `fixtures/` folder. The next time you run the tests, they should use 
the cached
+fixtures and run faster.
+
+To skip the cached fixtures, run the tests with an unexpected VCR_MODE value 
(e.g.,
+`VCR_MODE=off`) or just remove the `fixtures` folder and re-run.
 
 See [sepia](https://www.npmjs.com/package/sepia) for more documentation.
 
diff --git a/test/utils/server.js b/test/utils/server.js
index ba33769..d898f3b 100644
--- a/test/utils/server.js
+++ b/test/utils/server.js
@@ -1,14 +1,6 @@
 'use strict';
 
 
-// Default to recording+replaying http fixtures,
-// only if we are not running in Docker
-if (process.env.IN_DOCKER) {
-process.env.VCR_MODE = undefined;
-} else {
-process.env.VCR_MODE = process.env.VCR_MODE || 'cache';
-}
-
 const BBPromise = require('bluebird');
 const ServiceRunner = require('service-runner');
 const logStream = require('./logStream');

-- 
To view, visit https://gerrit.wikimedia.org/r/396425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3113027ff730ea6d1aa3398c869f197d5759e6e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb::parsercache: remove ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397990 )

Change subject: mariadb::parsercache: remove ganglia
..

mariadb::parsercache: remove ganglia

Bug: T177225
Change-Id: I54861dd045cbf0da97a8d412b78aeac969d647fb
---
M hieradata/role/common/mariadb/parsercache.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/90/397990/1

diff --git a/hieradata/role/common/mariadb/parsercache.yaml 
b/hieradata/role/common/mariadb/parsercache.yaml
index 4bfa7b0..1648372 100644
--- a/hieradata/role/common/mariadb/parsercache.yaml
+++ b/hieradata/role/common/mariadb/parsercache.yaml
@@ -1 +1,2 @@
 monitor_screens: false
+standard::has_ganglia: false

-- 
To view, visit https://gerrit.wikimedia.org/r/397990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54861dd045cbf0da97a8d412b78aeac969d647fb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: demos: Promote icons page IndicatorWidget to GPU layer

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395881 )

Change subject: demos: Promote icons page IndicatorWidget to GPU layer
..


demos: Promote icons page IndicatorWidget to GPU layer

Support Chrome by promoting layer to GPU when `opacity` is set.

Bug: T182257
Change-Id: I43e306843514347ac0856f30eb9f6b0767e78387
---
M demos/styles/demo.css
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/demos/styles/demo.css b/demos/styles/demo.css
index cc8d70e..d7af77d 100644
--- a/demos/styles/demo.css
+++ b/demos/styles/demo.css
@@ -284,6 +284,9 @@
 .demo-icons .oo-ui-fieldLayout .oo-ui-iconElement:not( 
.oo-ui-image-progressive ):not( .oo-ui-image-destructive ),
 .demo-icons .oo-ui-fieldLayout .oo-ui-indicatorElement {
opacity: 0.87; /* brings icons/indicators closer to text color */
+   /* Support Chrome by promoting layer to GPU, see T182257 */
+   -webkit-transform: translateZ( 0 );
+   transform: translateZ( 0 );
 }
 /* stylelint-enable indentation */
 .demo-icons .oo-ui-fieldLayout:hover .oo-ui-labelElement-label {

-- 
To view, visit https://gerrit.wikimedia.org/r/395881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43e306843514347ac0856f30eb9f6b0767e78387
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WikimediaUI theme: Remove obsolete icon flags

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397979 )

Change subject: WikimediaUI theme: Remove obsolete icon flags
..


WikimediaUI theme: Remove obsolete icon flags

Removing 'progressive' variant when it's already set globally.

Bug: T173350
Change-Id: Id92b1945abd775357d33d854c7746c3bfaaeb936
---
M src/themes/wikimediaui/icons-content.json
M src/themes/wikimediaui/icons-editing-core.json
M src/themes/wikimediaui/icons-interactions.json
M src/themes/wikimediaui/icons-moderation.json
4 files changed, 18 insertions(+), 24 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/wikimediaui/icons-content.json 
b/src/themes/wikimediaui/icons-content.json
index 3358bff..d37070a 100644
--- a/src/themes/wikimediaui/icons-content.json
+++ b/src/themes/wikimediaui/icons-content.json
@@ -69,7 +69,7 @@
"ltr": "images/icons/newspaper-ltr.svg",
"rtl": "images/icons/newspaper-rtl.svg"
} },
-   "tag": { "file": "images/icons/tag.svg", "variants": [ 
"destructive", "warning", "progressive" ] },
+   "tag": { "file": "images/icons/tag.svg", "variants": [ 
"destructive", "warning" ] },
"upload": { "file": {
"ltr": "images/icons/upload-ltr.svg",
"rtl": "images/icons/upload-rtl.svg"
diff --git a/src/themes/wikimediaui/icons-editing-core.json 
b/src/themes/wikimediaui/icons-editing-core.json
index 9a9293c..dfa370c 100644
--- a/src/themes/wikimediaui/icons-editing-core.json
+++ b/src/themes/wikimediaui/icons-editing-core.json
@@ -22,7 +22,7 @@
"edit": { "file": {
"ltr": "images/icons/edit-ltr.svg",
"rtl": "images/icons/edit-rtl.svg"
-   }, "variants": [ "progressive" ] },
+   } },
"editLock": { "file": {
"ltr": "images/icons/editLock-ltr.svg",
"rtl": "images/icons/editLock-rtl.svg"
diff --git a/src/themes/wikimediaui/icons-interactions.json 
b/src/themes/wikimediaui/icons-interactions.json
index f53fd20..49a5888 100644
--- a/src/themes/wikimediaui/icons-interactions.json
+++ b/src/themes/wikimediaui/icons-interactions.json
@@ -19,25 +19,22 @@
}
},
"images": {
-   "add": { "file": "images/icons/add.svg", "variants": [ 
"progressive" ] },
+   "add": { "file": "images/icons/add.svg" },
"advanced": { "file": "images/icons/advanced.svg" },
"browser": { "file": {
"ltr": "images/icons/browser-ltr.svg",
"rtl": "images/icons/browser-rtl.svg"
} },
"cancel": { "file": "images/icons/cancel.svg", "variants": [ 
"destructive" ] },
-   "check": { "file": "images/icons/check.svg", "variants": [ 
"progressive", "destructive" ] },
+   "check": { "file": "images/icons/check.svg", "variants": [ 
"destructive" ] },
"clear": { "file": "images/icons/clear.svg" },
"clock": { "file": "images/icons/clock.svg" },
"close": { "file": "images/icons/close.svg" },
"ellipsis": { "file": "images/icons/ellipsis.svg" },
-   "feedback": {
-   "file": {
-   "ltr": "images/icons/feedback-ltr.svg",
-   "rtl": "images/icons/feedback-rtl.svg"
-   },
-   "variants": [ "progressive" ]
-   },
+   "feedback": { "file": {
+   "ltr": "images/icons/feedback-ltr.svg",
+   "rtl": "images/icons/feedback-rtl.svg"
+   } },
"funnel": { "file": {
"ltr": "images/icons/funnel-ltr.svg",
"rtl": "images/icons/funnel-rtl.svg"
diff --git a/src/themes/wikimediaui/icons-moderation.json 
b/src/themes/wikimediaui/icons-moderation.json
index 87d1640..89746eb 100644
--- a/src/themes/wikimediaui/icons-moderation.json
+++ b/src/themes/wikimediaui/icons-moderation.json
@@ -24,8 +24,8 @@
"ltr": "images/icons/unBlock-ltr.svg",
"rtl": "images/icons/unBlock-rtl.svg"
} },
-   "clip": { "file": "images/icons/clip.svg", "variants": [ 
"progressive" ] },
-   "unClip": { "file": "images/icons/unClip.svg", "variants": [ 
"progressive" ] },
+   "clip": { "file": "images/icons/clip.svg" },
+   "unClip": { "file": "images/icons/unClip.svg" },
"flag": { "file": {
"ltr": "images/icons/flag-ltr.svg",
"rtl": "images/icons/flag-rtl.svg"
@@ -42,24 +42,21 @@
 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Bump Parsoid HTML version to 1.6.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397982 )

Change subject: Bump Parsoid HTML version to 1.6.0
..


Bump Parsoid HTML version to 1.6.0

It's a brave new world.

https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments=2644817#Tuesday,_Dec._12,_2017_around_11:45_am_PT:_Y_Deployed_741fc5d

Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
---
M ApiVisualEditor.php
M modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Subramanya Sastry: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Arlolra: Looks good to me, but someone else must approve
  Jforrester: Looks good to me, approved



diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index 12cd482..3878598 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -89,7 +89,7 @@
$request['body'] = $params;
}
// Should be synchronised with 
modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
-   $reqheaders['Accept'] = 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.2.0"';
+   $reqheaders['Accept'] = 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.6.0"';
$reqheaders['User-Agent'] = 'VisualEditor-MediaWiki/' . 
$wgVersion;
$reqheaders['Api-User-Agent'] = 'VisualEditor-MediaWiki/' . 
$wgVersion;
$request['headers'] = $reqheaders;
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
index 0b5892a..4c61213 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
@@ -178,7 +178,7 @@
 
// Should be synchronised with 
ApiVisualEditor.php
headers = {
-   Accept: 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.2.0"',
+   Accept: 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.6.0"',
'Api-User-Agent': 
'VisualEditor-MediaWiki/' + mw.config.get( 'wgVersion' )
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Turn off a couple search ranking models that arnt ready

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397988 )

Change subject: Turn off a couple search ranking models that arnt ready
..


Turn off a couple search ranking models that arnt ready

It seems a few of the wikis ranking models havn't been uploaded to the
search clusters yet. Turn those off, enabling only those with
live ranking models.

Change-Id: I28a269c940290518467f99e6003c6eb13774b633
---
M tests/cirrusTest.php
M wmf-config/InitialiseSettings.php
2 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/cirrusTest.php b/tests/cirrusTest.php
index 8a57bda..2c8edb3 100644
--- a/tests/cirrusTest.php
+++ b/tests/cirrusTest.php
@@ -241,7 +241,7 @@
'zhwiki' => [ 'zhwiki', 'wiki',
[
'wmgCirrusSearchSimilarityProfile' => 
'wmf_defaults',
-   'wmgCirrusSearchRescoreProfile' => 
'mlr-1024rs',
+   'wmgCirrusSearchRescoreProfile' => 
'classic',

'wmgCirrusSearchFullTextQueryBuilderProfile' => 'perfield_builder',
'wmgCirrusSearchMaxPhraseTokens' => 10,
],
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index c355b31..c61f97b 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18297,7 +18297,7 @@
'default' => 'wsum_inclinks',
'commonswiki' => 'classic_noboostlinks',
'enwiki' => 'mlr-1024rs',
-   'arwiki' => 'mlr-1024rs',
+   // 'arwiki' => 'mlr-1024rs',
'dewiki' => 'mlr-1024rs',
'fawiki' => 'mlr-1024rs',
'fiwiki' => 'mlr-1024rs',
@@ -18306,14 +18306,14 @@
'itwiki' => 'mlr-1024rs',
'jawiki' => 'mlr-1024rs',
'kowiki' => 'mlr-1024rs',
-   'nlwiki' => 'mlr-1024rs',
+   // 'nlwiki' => 'mlr-1024rs',
'nowiki' => 'mlr-1024rs',
-   'plwiki' => 'mlr-1024rs',
+   // 'plwiki' => 'mlr-1024rs',
'ptwiki' => 'mlr-1024rs',
'ruwiki' => 'mlr-1024rs',
'svwiki' => 'mlr-1024rs',
'viwiki' => 'mlr-1024rs',
-   'zhwiki' => 'mlr-1024rs',
+   // 'zhwiki' => 'mlr-1024rs',
// Uses the lang tag, list of spaceless languages
// (see 
https://www.mediawiki.org/wiki/User:TJones_(WMF)/Notes/Spaceless_Writing_Systems_and_Wiki-Projects)
"bo" => "classic",

-- 
To view, visit https://gerrit.wikimedia.org/r/397988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28a269c940290518467f99e6003c6eb13774b633
Gerrit-PatchSet: 4
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/wikistats2[master]: [WIP] Splitting webpack bundle

[Nuria (Code Review)]

Nuria has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397989 )

Change subject: [WIP] Splitting webpack bundle
..

[WIP] Splitting webpack bundle

Splitting detail page off is a significant improvement but other strategies
probably also work.

The interactions between webpack and babel and less friendly than
you might think so every usage of a webpack feature seems to carry usage
of some special casing in babel

Bug: T182601

Change-Id: Idb4126eda353c3f98392533d792d7f8a9163a5a2
---
M .babelrc
M package.json
M src/App.vue
M src/components/dashboard/MetricWidget.vue
M webpack/base.config.js
M webpack/dev.config.js
M webpack/prod.config.js
7 files changed, 21 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats2 
refs/changes/89/397989/1

diff --git a/.babelrc b/.babelrc
index 25fa091..0b9175b 100644
--- a/.babelrc
+++ b/.babelrc
@@ -5,7 +5,8 @@
 "browsers": ["last 2 versions", "ie >= 10"]
 },
 "useBuiltIns": true,
-"debug": true
+"debug": true,
 }]
-]
+],
+"plugins": ["dynamic-import-webpack"]
 }
diff --git a/package.json b/package.json
index 9138996..e42c38e 100644
--- a/package.json
+++ b/package.json
@@ -28,6 +28,7 @@
 "devDependencies": {
 "babel-core": "^6.25.0",
 "babel-loader": "^7.0.0",
+"babel-plugin-dynamic-import-webpack": "^1.0.2",
 "babel-plugin-transform-object-rest-spread": "^6.23.0",
 "babel-preset-env": "^1.5.2",
 "babel-preset-es2015": "^6.24.1",
diff --git a/src/App.vue b/src/App.vue
index 91e4167..d3514db 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -19,14 +19,23 @@
 
 
 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to bfc3588

[Mholloway (Code Review)]

Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397987 )

Change subject: Update mobileapps to bfc3588
..


Update mobileapps to bfc3588

List of changes:
f117270 Fix news tests and reenable monitoring
bfc3588 Hygiene: Prune old news test fixtures
xxx Update node module dependencies

Change-Id: Icf7b8c561d1bbadd763c615c86a35f1421d2c485
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Verified; Looks good to me, approved



diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 5a12100..bafd7e0 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "59d4bdcb9a0e95b5d9c6a3bd9e9f4b562ac8a509",
+  "_shasum": "d3b44e3ead73d28f27742b4f4f679aaa13043278",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 577f349..63e4d3b 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "868ce5edc8de7e54d918caf79a5b3b30237e66b1",
+  "_shasum": "c9fc70b93cfdcce4bc17f48ef0a66cd1273f6613",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index 94f267b..bfc3588 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 94f267b3a733ac4a49614f2995d743df530fd88a
+Subproject commit bfc3588f79b368c8ecb812fc2c763f058c69d1ff

-- 
To view, visit https://gerrit.wikimedia.org/r/397987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf7b8c561d1bbadd763c615c86a35f1421d2c485
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mail::mx: remove ganglia

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397986 )

Change subject: mail::mx: remove ganglia
..


mail::mx: remove ganglia

Bug: T177225
Change-Id: I49fa16d1e86776554fab74937a35f744d7153804
---
M hieradata/role/common/mail/mx.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/mail/mx.yaml 
b/hieradata/role/common/mail/mx.yaml
index 0144088..13d9dc6 100644
--- a/hieradata/role/common/mail/mx.yaml
+++ b/hieradata/role/common/mail/mx.yaml
@@ -1,4 +1,5 @@
 standard::has_default_mail_relay: false
+standard::has_ganglia: false
 admin::groups:
   - oit
 mtail::logs:

-- 
To view, visit https://gerrit.wikimedia.org/r/397986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49fa16d1e86776554fab74937a35f744d7153804
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Turn off a couple search ranking models that arnt ready

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397988 )

Change subject: Turn off a couple search ranking models that arnt ready
..

Turn off a couple search ranking models that arnt ready

It seems a few of the wikis ranking models havn't been uploaded to the
search clusters yet. Turn those off, enabling only those with
live ranking models.

Change-Id: I28a269c940290518467f99e6003c6eb13774b633
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/88/397988/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index ccf3f56..652fbb9 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18253,7 +18253,7 @@
'default' => 'wsum_inclinks',
'commonswiki' => 'classic_noboostlinks',
'enwiki' => 'mlr-1024rs',
-   'arwiki' => 'mlr-1024rs',
+   //'arwiki' => 'mlr-1024rs',
'dewiki' => 'mlr-1024rs',
'fawiki' => 'mlr-1024rs',
'fiwiki' => 'mlr-1024rs',
@@ -18262,14 +18262,14 @@
'itwiki' => 'mlr-1024rs',
'jawiki' => 'mlr-1024rs',
'kowiki' => 'mlr-1024rs',
-   'nlwiki' => 'mlr-1024rs',
+   //'nlwiki' => 'mlr-1024rs',
'nowiki' => 'mlr-1024rs',
-   'plwiki' => 'mlr-1024rs',
+   //'plwiki' => 'mlr-1024rs',
'ptwiki' => 'mlr-1024rs',
'ruwiki' => 'mlr-1024rs',
'svwiki' => 'mlr-1024rs',
'viwiki' => 'mlr-1024rs',
-   'zhwiki' => 'mlr-1024rs',
+   //'zhwiki' => 'mlr-1024rs',
// Uses the lang tag, list of spaceless languages
// (see 
https://www.mediawiki.org/wiki/User:TJones_(WMF)/Notes/Spaceless_Writing_Systems_and_Wiki-Projects)
"bo" => "classic",

-- 
To view, visit https://gerrit.wikimedia.org/r/397988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28a269c940290518467f99e6003c6eb13774b633
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to bfc3588

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397987 )

Change subject: Update mobileapps to bfc3588
..

Update mobileapps to bfc3588

List of changes:
f117270 Fix news tests and reenable monitoring
bfc3588 Hygiene: Prune old news test fixtures
xxx Update node module dependencies

Change-Id: Icf7b8c561d1bbadd763c615c86a35f1421d2c485
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps/deploy 
refs/changes/87/397987/1

diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 5a12100..bafd7e0 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "59d4bdcb9a0e95b5d9c6a3bd9e9f4b562ac8a509",
+  "_shasum": "d3b44e3ead73d28f27742b4f4f679aaa13043278",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 577f349..63e4d3b 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "868ce5edc8de7e54d918caf79a5b3b30237e66b1",
+  "_shasum": "c9fc70b93cfdcce4bc17f48ef0a66cd1273f6613",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index 94f267b..bfc3588 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 94f267b3a733ac4a49614f2995d743df530fd88a
+Subproject commit bfc3588f79b368c8ecb812fc2c763f058c69d1ff

-- 
To view, visit https://gerrit.wikimedia.org/r/397987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf7b8c561d1bbadd763c615c86a35f1421d2c485
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mail::mx: remove ganglia

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397986 )

Change subject: mail::mx: remove ganglia
..

mail::mx: remove ganglia

Bug: T177225
Change-Id: I49fa16d1e86776554fab74937a35f744d7153804
---
M hieradata/role/common/mail/mx.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/86/397986/1

diff --git a/hieradata/role/common/mail/mx.yaml 
b/hieradata/role/common/mail/mx.yaml
index 0144088..13d9dc6 100644
--- a/hieradata/role/common/mail/mx.yaml
+++ b/hieradata/role/common/mail/mx.yaml
@@ -1,4 +1,5 @@
 standard::has_default_mail_relay: false
+standard::has_ganglia: false
 admin::groups:
   - oit
 mtail::logs:

-- 
To view, visit https://gerrit.wikimedia.org/r/397986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49fa16d1e86776554fab74937a35f744d7153804
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Sync parserTests with core

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397983 )

Change subject: Sync parserTests with core
..


Sync parserTests with core

No actual changes made upstream, but record the commit hash of the
sync pushed to core.

Change-Id: I8e2504e830b89126c03b742cc3a3fc9ca52246ed
---
M tests/parserTests.json
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  C. Scott Ananian: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/parserTests.json b/tests/parserTests.json
index 4dd04d2..7f29bdf 100644
--- a/tests/parserTests.json
+++ b/tests/parserTests.json
@@ -2,8 +2,8 @@
"parserTests.txt": {
"repo": "/wikimedia/mediawiki/",
"path": "tests/parser/parserTests.txt",
-   "expectedSHA1": "201be6a42bb29089c25ff573709a40bea917fd72",
-   "latestCommit": "708e8e9dee4523997a2dfe73e312db18725e782b"
+   "expectedSHA1": "075d7e0f2574f31eb97cd6b4b5a485618f1cb25b",
+   "latestCommit": "438c66d913837ab3c78edce96e96a01106057a24"
},
"citeParserTests.txt": {
"repo": "/wikimedia/mediawiki-extensions-Cite/",

-- 
To view, visit https://gerrit.wikimedia.org/r/397983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e2504e830b89126c03b742cc3a3fc9ca52246ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: C. Scott Ananian 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.11]: Turn on second mlr test for hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397984 )

Change subject: Turn on second mlr test for hewiki
..


Turn on second mlr test for hewiki

Re-uses the same sampling rates as last time around on hewiki. Depends
on I681e1e724 being deployed first to setup the appropriate backend
triggers.

Bug: T182616
Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index 7517df7..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,7 +114,9 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = [],
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
+   [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -135,9 +137,6 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
test: 2000,
subTest: null
@@ -189,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.12]: Turn on second mlr test for hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397985 )

Change subject: Turn on second mlr test for hewiki
..


Turn on second mlr test for hewiki

Re-uses the same sampling rates as last time around on hewiki. Depends
on I681e1e724 being deployed first to setup the appropriate backend
triggers.

Bug: T182616
Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
(cherry picked from commit 4d6d5e905de945647fc24795d172c787bbb33128)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index 7517df7..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,7 +114,9 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = [],
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
+   [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -135,9 +137,6 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
test: 2000,
subTest: null
@@ -189,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Prune old news test fixtures

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397981 )

Change subject: Hygiene: Prune old news test fixtures
..


Hygiene: Prune old news test fixtures

Change-Id: I97888ea9d37dff9dcc1756b21abc19be7c6c7e82
---
D test/fixtures/news-site-da-2016-11-30.htm
D test/fixtures/news-site-da-2017-10-04.htm
D test/fixtures/news-site-de-2016-11-30.htm
D test/fixtures/news-site-de-2017-10-04.htm
D test/fixtures/news-site-el-2016-11-30.htm
D test/fixtures/news-site-el-2017-10-04.htm
D test/fixtures/news-site-en-2016-11-30.htm
D test/fixtures/news-site-en-2017-10-04.htm
D test/fixtures/news-site-es-2016-11-30.htm
D test/fixtures/news-site-es-2017-10-04.htm
D test/fixtures/news-site-fi-2016-11-30.htm
D test/fixtures/news-site-fi-2017-10-04.htm
D test/fixtures/news-site-fr-2016-11-30.htm
D test/fixtures/news-site-fr-2017-10-04.htm
D test/fixtures/news-site-he-2016-11-30.htm
D test/fixtures/news-site-he-2017-10-04.htm
D test/fixtures/news-site-ko-2016-11-30.htm
D test/fixtures/news-site-ko-2017-10-04.htm
D test/fixtures/news-site-no-2016-11-30.htm
D test/fixtures/news-site-no-2017-10-04.htm
D test/fixtures/news-site-pl-2016-11-30.htm
D test/fixtures/news-site-pl-2017-10-04.htm
D test/fixtures/news-site-pt-2016-11-30.htm
D test/fixtures/news-site-pt-2017-10-04.htm
D test/fixtures/news-site-ru-2016-11-30.htm
D test/fixtures/news-site-ru-2017-10-04.htm
D test/fixtures/news-site-sco-2016-11-30.htm
D test/fixtures/news-site-sco-2017-10-04.htm
D test/fixtures/news-site-sv-2016-11-30.htm
D test/fixtures/news-site-sv-2017-10-04.htm
D test/fixtures/news-site-vi-2016-11-30.htm
D test/fixtures/news-site-vi-2017-10-04.htm
32 files changed, 0 insertions(+), 2,406 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/397981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97888ea9d37dff9dcc1756b21abc19be7c6c7e82
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix news tests and reenable monitoring

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397980 )

Change subject: Fix news tests and reenable monitoring
..


Fix news tests and reenable monitoring

Change-Id: I1cf4832e01ab56c3a86ed50b20a5fb4818e7251b
---
M etc/feed/news-sites.js
M spec.yaml
M test/features/news/news-sites.js
M test/features/news/news.js
A test/fixtures/news-site-da-2017-12-12.htm
A test/fixtures/news-site-de-2017-12-12.htm
A test/fixtures/news-site-el-2017-12-12.htm
A test/fixtures/news-site-en-2017-12-12.htm
A test/fixtures/news-site-es-2017-12-12.htm
A test/fixtures/news-site-fi-2017-12-12.htm
A test/fixtures/news-site-fr-2017-12-12.htm
A test/fixtures/news-site-he-2017-12-12.htm
A test/fixtures/news-site-ko-2017-12-12.htm
A test/fixtures/news-site-no-2017-12-12.htm
A test/fixtures/news-site-pl-2017-12-12.htm
A test/fixtures/news-site-pt-2017-12-12.htm
A test/fixtures/news-site-ru-2017-12-12.htm
A test/fixtures/news-site-sco-2017-12-12.htm
A test/fixtures/news-site-sv-2017-12-12.htm
A test/fixtures/news-site-vi-2017-12-12.htm
20 files changed, 1,227 insertions(+), 32 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/397980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1cf4832e01ab56c3a86ed50b20a5fb4818e7251b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.12]: Turn on second mlr test for hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397985 )

Change subject: Turn on second mlr test for hewiki
..

Turn on second mlr test for hewiki

Re-uses the same sampling rates as last time around on hewiki. Depends
on I681e1e724 being deployed first to setup the appropriate backend
triggers.

Bug: T182616
Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
(cherry picked from commit 4d6d5e905de945647fc24795d172c787bbb33128)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/85/397985/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index 7517df7..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,7 +114,9 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = [],
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
+   [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -135,9 +137,6 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
test: 2000,
subTest: null
@@ -189,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.11]: Turn on second mlr test for hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397984 )

Change subject: Turn on second mlr test for hewiki
..

Turn on second mlr test for hewiki

Re-uses the same sampling rates as last time around on hewiki. Depends
on I681e1e724 being deployed first to setup the appropriate backend
triggers.

Bug: T182616
Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/84/397984/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index 7517df7..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,7 +114,9 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = [],
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
+   [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -135,9 +137,6 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
test: 2000,
subTest: null
@@ -189,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Turn on MLR for most wikis with >1% of search traffic

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397970 )

Change subject: Turn on MLR for most wikis with >1% of search traffic
..


Turn on MLR for most wikis with >1% of search traffic

Based on the results of our AB test showing improved search relevance
for machine learned ranking, turn them on. Also updates to models
trained in the last week.

Change-Id: I657d80bd1fbda61d5fd84fcdd0e29383a1d857cd
---
M tests/cirrusTest.php
M wmf-config/InitialiseSettings.php
2 files changed, 36 insertions(+), 19 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/cirrusTest.php b/tests/cirrusTest.php
index 5bccd87..8a57bda 100644
--- a/tests/cirrusTest.php
+++ b/tests/cirrusTest.php
@@ -241,7 +241,7 @@
'zhwiki' => [ 'zhwiki', 'wiki',
[
'wmgCirrusSearchSimilarityProfile' => 
'wmf_defaults',
-   'wmgCirrusSearchRescoreProfile' => 
'wsum_inclinks',
+   'wmgCirrusSearchRescoreProfile' => 
'mlr-1024rs',

'wmgCirrusSearchFullTextQueryBuilderProfile' => 'perfield_builder',
'wmgCirrusSearchMaxPhraseTokens' => 10,
],
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index a44abdc..c355b31 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18297,6 +18297,23 @@
'default' => 'wsum_inclinks',
'commonswiki' => 'classic_noboostlinks',
'enwiki' => 'mlr-1024rs',
+   'arwiki' => 'mlr-1024rs',
+   'dewiki' => 'mlr-1024rs',
+   'fawiki' => 'mlr-1024rs',
+   'fiwiki' => 'mlr-1024rs',
+   'frwiki' => 'mlr-1024rs',
+   'idwiki' => 'mlr-1024rs',
+   'itwiki' => 'mlr-1024rs',
+   'jawiki' => 'mlr-1024rs',
+   'kowiki' => 'mlr-1024rs',
+   'nlwiki' => 'mlr-1024rs',
+   'nowiki' => 'mlr-1024rs',
+   'plwiki' => 'mlr-1024rs',
+   'ptwiki' => 'mlr-1024rs',
+   'ruwiki' => 'mlr-1024rs',
+   'svwiki' => 'mlr-1024rs',
+   'viwiki' => 'mlr-1024rs',
+   'zhwiki' => 'mlr-1024rs',
// Uses the lang tag, list of spaceless languages
// (see 
https://www.mediawiki.org/wiki/User:TJones_(WMF)/Notes/Spaceless_Writing_Systems_and_Wiki-Projects)
"bo" => "classic",
@@ -19848,25 +19865,25 @@
 
 'wmgCirrusSearchMLRModel' => [
'default' => false,
-   'enwiki' => '20171101_enwiki_v1',
-   'arwiki' => '20170905_arwiki_v1',
-   'fawiki' => '20170905_fawiki_v1',
-   'jawiki' => '20170905_jawiki_v1',
-   'svwiki' => '20170905_svwiki_v1',
-   'frwiki' => '20170905_frwiki_v1',
-   'itwiki' => '20170905_itwiki_v1',
-   'ptwiki' => '20170905_ptwiki_v1',
-   'ruwiki' => '20170905_ruwiki_v1',
-   'dewiki' => '20170905_dewiki_v1',
-   'fiwiki' => '20170908_fiwiki_v1',
+   'enwiki' => '20171130_enwiki_v1',
+   'arwiki' => '20171130_arwiki_v1',
+   'fawiki' => '20171130_fawiki_v1',
+   'jawiki' => '20171130_jawiki_v1',
+   'svwiki' => '20171130_svwiki_v1',
+   'frwiki' => '20171130_frwiki_v1',
+   'itwiki' => '20171130_itwiki_v1',
+   'ptwiki' => '20171130_ptwiki_v1',
+   'ruwiki' => '20171130_ruwiki_v1',
+   'dewiki' => '20171130_dewiki_v1',
+   'fiwiki' => '20171130_fiwiki_v1',
'hewiki' => '20171130_hewiki_v1',
-   'idwiki' => '20170908_idwiki_v1',
-   'kowiki' => '20170908_kowiki_v1',
-   'nlwiki' => '20170908_nlwiki_v1',
-   'nowiki' => '20170908_nowiki_v1',
-   'plwiki' => '20170908_plwiki_v1',
-   'viwiki' => '20170908_viwiki_v1',
-   'zhwiki' => '20170908_zhwiki_v1',
+   'idwiki' => '20171130_idwiki_v1',
+   'kowiki' => '20171130_kowiki_v1',
+   'nlwiki' => '20171130_nlwiki_v1',
+   'nowiki' => '20171130_nowiki_v1',
+   'plwiki' => '20171130_plwiki_v1',
+   'viwiki' => '20171130_viwiki_v1',
+   'zhwiki' => '20171130_zhwiki_v1',
 ],
 
 'wmgWMESearchRelevancePages' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/397970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I657d80bd1fbda61d5fd84fcdd0e29383a1d857cd
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Turn on second mlr test for hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397973 )

Change subject: Turn on second mlr test for hewiki
..


Turn on second mlr test for hewiki

Re-uses the same sampling rates as last time around on hewiki. Depends
on I681e1e724 being deployed first to setup the appropriate backend
triggers.

Bug: T182616
Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index 7517df7..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,7 +114,9 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = [],
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
+   [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -135,9 +137,6 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
test: 2000,
subTest: null
@@ -189,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Sync parserTests with core

[C. Scott Ananian (Code Review)]

C. Scott Ananian has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397983 )

Change subject: Sync parserTests with core
..

Sync parserTests with core

No actual changes made upstream, but record the commit hash of the
sync pushed to core.

Change-Id: I8e2504e830b89126c03b742cc3a3fc9ca52246ed
---
M tests/parserTests.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/83/397983/1

diff --git a/tests/parserTests.json b/tests/parserTests.json
index 4dd04d2..7f29bdf 100644
--- a/tests/parserTests.json
+++ b/tests/parserTests.json
@@ -2,8 +2,8 @@
"parserTests.txt": {
"repo": "/wikimedia/mediawiki/",
"path": "tests/parser/parserTests.txt",
-   "expectedSHA1": "201be6a42bb29089c25ff573709a40bea917fd72",
-   "latestCommit": "708e8e9dee4523997a2dfe73e312db18725e782b"
+   "expectedSHA1": "075d7e0f2574f31eb97cd6b4b5a485618f1cb25b",
+   "latestCommit": "438c66d913837ab3c78edce96e96a01106057a24"
},
"citeParserTests.txt": {
"repo": "/wikimedia/mediawiki-extensions-Cite/",

-- 
To view, visit https://gerrit.wikimedia.org/r/397983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e2504e830b89126c03b742cc3a3fc9ca52246ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Setup MLR AB test for hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397582 )

Change subject: Setup MLR AB test for hewiki
..


Setup MLR AB test for hewiki

Last time around we trained the hewiki model on an analysis chain that
was different than the one used when running the test so the results
were invalid. Re-run the test with a new model trained against the new
analysis chain.

Bug: T182616
Change-Id: I681e1e724201337d73867e518fe806cbf5f89636
---
M wmf-config/CirrusSearch-common.php
M wmf-config/InitialiseSettings.php
2 files changed, 13 insertions(+), 60 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified
  DCausse: Looks good to me, but someone else must approve



diff --git a/wmf-config/CirrusSearch-common.php 
b/wmf-config/CirrusSearch-common.php
index e441816..0bbb75c 100644
--- a/wmf-config/CirrusSearch-common.php
+++ b/wmf-config/CirrusSearch-common.php
@@ -298,40 +298,7 @@
],
],
];
-
-   $wgCirrusSearchRescoreProfiles['dbn20'] = 
$wgCirrusSearchRescoreProfiles['mlr-1024rs'];
-   $wgCirrusSearchRescoreProfiles['dbn20']['rescore'][2]['model'] = 
'dbn20_enwiki_v1';
-
-   $wgCirrusSearchRescoreProfiles['dbn35'] = 
$wgCirrusSearchRescoreProfiles['mlr-1024rs'];
-   $wgCirrusSearchRescoreProfiles['dbn35']['rescore'][2]['model'] = 
'dbn35_enwiki_v1';
-
 }
-
-# needed for recall A/B test (T177502)
-$wgCirrusSearchFullTextQueryBuilderProfiles['rec_3t_80_66'] = 
$wgCirrusSearchFullTextQueryBuilderProfiles['perfield_builder'];
-$wgCirrusSearchFullTextQueryBuilderProfiles['rec_3t_80_66']['settings']['filter']
 = [
-   'type' => 'default',
-   'settings' => [
-   'all' => [
-   'minimum_should_match' => '3<80%'
-   ],
-   'all.plain' => [
-   'minimum_should_match' => '3<66%'
-   ],
-   ]
-];
-$wgCirrusSearchFullTextQueryBuilderProfiles['rec_4t_80_66'] = 
$wgCirrusSearchFullTextQueryBuilderProfiles['perfield_builder'];
-$wgCirrusSearchFullTextQueryBuilderProfiles['rec_4t_80_66']['settings']['filter']
 = [
-   'type' => 'default',
-   'settings' => [
-   'all' => [
-   'minimum_should_match' => '4<80%'
-   ],
-   'all.plain' => [
-   'minimum_should_match' => '4<66%'
-   ],
-   ]
-];
 
 $wgCirrusSearchUserTesting = $wmgCirrusSearchUserTesting;
 
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 934235c..a44abdc 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18674,44 +18674,30 @@
 
 'wmgCirrusSearchUserTesting' => [
'default' => [],
-   // DBN sizing AB test
-   'enwiki' => [
-   'dbn_sizing' => [
+   'hewiki' => [
+   'ltr' => [
+   'globals' => [],
'buckets' => [
'control' => [
'trigger' => 'control',
],
-   'dbn20' => [
-   'trigger' => 'dbn20',
+   'ltr-1024' => [
+   'trigger' => 'ltr-1024',
'globals' => [
-   'wgCirrusSearchRescoreProfile' 
=> 'dbn20',
+   'wgCirrusSearchRescoreProfile' 
=> 'mlr-1024rs',
]
],
-   'dbn20-i' => [
-   'trigger' => 'dbn20-i',
+   'ltr-1024-i' => [
+   'trigger' => 'ltr-1024-i',
'globals' => [

'wgCirrusSearchInterleaveConfig' => [
-   
'CirrusSearchRescoreProfile' => 'dbn20',
+   
'CirrusSearchRescoreProfile' => 'mlr-1024rs'
],
-   ]
-   ],
-   'dbn35' => [
-   'trigger' => 'dbn35',
-   'globals' => [
-   'wgCirrusSearchRescoreProfile' 
=> 'dbn35',
-   ]
-   ],
-   'dbn35-i' => [
-   'trigger' => 'dbn35-i',
-   'globals' => [
- 

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix z-index for RCFilters' overlay

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397978 )

Change subject: Fix z-index for RCFilters' overlay
..


Fix z-index for RCFilters' overlay

Currently the personal bar displays on top of it. This wasn't
visible until some popups started opening upwards rather than
downwards. We should fix this better some time...

Bug: T182711
Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
---
M skinStyles/ooui.less
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/skinStyles/ooui.less b/skinStyles/ooui.less
index 60fcec2..e9f5961 100644
--- a/skinStyles/ooui.less
+++ b/skinStyles/ooui.less
@@ -1,4 +1,5 @@
 .oo-ui-windowManager-modal,
+.skin-vector .mw-rcfilters-ui-overlay,
 .skin-vector .ve-ui-overlay-global {
z-index: 101;
position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/397978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Bump Parsoid HTML version to 1.6.0

[C. Scott Ananian (Code Review)]

C. Scott Ananian has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397982 )

Change subject: Bump Parsoid HTML version to 1.6.0
..

Bump Parsoid HTML version to 1.6.0

It's a brave new world.

https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments=2644817#Tuesday,_Dec._12,_2017_around_11:45_am_PT:_Y_Deployed_741fc5d

Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
---
M ApiVisualEditor.php
M modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/82/397982/1

diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index 12cd482..3878598 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -89,7 +89,7 @@
$request['body'] = $params;
}
// Should be synchronised with 
modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
-   $reqheaders['Accept'] = 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.2.0"';
+   $reqheaders['Accept'] = 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.6.0"';
$reqheaders['User-Agent'] = 'VisualEditor-MediaWiki/' . 
$wgVersion;
$reqheaders['Api-User-Agent'] = 'VisualEditor-MediaWiki/' . 
$wgVersion;
$request['headers'] = $reqheaders;
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
index 0b5892a..4c61213 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTargetLoader.js
@@ -178,7 +178,7 @@
 
// Should be synchronised with 
ApiVisualEditor.php
headers = {
-   Accept: 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.2.0"',
+   Accept: 'text/html; charset=utf-8; 
profile="mediawiki.org/specs/html/1.6.0"',
'Api-User-Agent': 
'VisualEditor-MediaWiki/' + mw.config.get( 'wgVersion' )
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib22dc5370cd01bf5becdd639cc12d6a5ccc653a3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: More descriptive failure

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397975 )

Change subject: More descriptive failure
..


More descriptive failure

- Remove pre-semver support
- De-anchor the version detection from ^wmf so if we're given a
  remote like origin/wmf it'll work

Change-Id: I76fa903eb4f41722248367352c4b47a64de3ce7e
---
M make-deploy-notes/uploadChangelog.php
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/make-deploy-notes/uploadChangelog.php 
b/make-deploy-notes/uploadChangelog.php
index c8fc86f..99bc851 100644
--- a/make-deploy-notes/uploadChangelog.php
+++ b/make-deploy-notes/uploadChangelog.php
@@ -29,7 +29,7 @@
 $previousVersion = getPreviousVersion( $version );
 
 if ( $previousVersion === null ) {
-   print "usage: $argv[0] wmf/1.31.0-wmf.11 [username password]\n";
+   print "Unable to determine prior branch, given $version as current\n";
exit( 1 );
 }
 
@@ -88,14 +88,8 @@
  * @return string
  */
 function getPreviousMinorVersion( $major ) {
-   // check, which filter should be used for the filter
-   // Note, that 27 is used here, because the previous version would be 26,
-   // which uses the old non semantic versioning notation.
-   if ( $major <= 27 ) {
-   $filter = "wmf/1.{$major}wmf";
-   } else {
-   $filter = "wmf/1.{$major}.0-wmf";
-   }
+   $filter = "wmf/1.{$major}.0-wmf";
+
// get the list in a raw output format which would be visible in the
// console for this command, sorted by version numbers
$rawList = shell_exec( "git branch -a --list */{$filter}* | sort -V" );
@@ -125,7 +119,7 @@
 function getMajorMinor( $input ) {
$matches = array();
// match any version like wmf/1.26wmf22 or the new semver 
wmf/1.27.0-wmf1
-   if ( preg_match( "/^wmf\/1\.(\d{2})(?:\.[0-9]\-)?wmf\.?(\d{1,2})/", 
$input, $matches ) ) {
+   if ( preg_match( "/wmf\/1\.(\d{2})\.0\-wmf\.(\d{1,2})/", $input, 
$matches ) ) {
// var_dump( $matches );
$major = intval( $matches[1] );
$minor = intval( $matches[2] );

-- 
To view, visit https://gerrit.wikimedia.org/r/397975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76fa903eb4f41722248367352c4b47a64de3ce7e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Prune old news test fixtures

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397981 )

Change subject: Hygiene: Prune old news test fixtures
..

Hygiene: Prune old news test fixtures

Change-Id: I97888ea9d37dff9dcc1756b21abc19be7c6c7e82
---
D test/fixtures/news-site-da-2016-11-30.htm
D test/fixtures/news-site-da-2017-10-04.htm
D test/fixtures/news-site-de-2016-11-30.htm
D test/fixtures/news-site-de-2017-10-04.htm
D test/fixtures/news-site-el-2016-11-30.htm
D test/fixtures/news-site-el-2017-10-04.htm
D test/fixtures/news-site-en-2016-11-30.htm
D test/fixtures/news-site-en-2017-10-04.htm
D test/fixtures/news-site-es-2016-11-30.htm
D test/fixtures/news-site-es-2017-10-04.htm
D test/fixtures/news-site-fi-2016-11-30.htm
D test/fixtures/news-site-fi-2017-10-04.htm
D test/fixtures/news-site-fr-2016-11-30.htm
D test/fixtures/news-site-fr-2017-10-04.htm
D test/fixtures/news-site-he-2016-11-30.htm
D test/fixtures/news-site-he-2017-10-04.htm
D test/fixtures/news-site-ko-2016-11-30.htm
D test/fixtures/news-site-ko-2017-10-04.htm
D test/fixtures/news-site-no-2016-11-30.htm
D test/fixtures/news-site-no-2017-10-04.htm
D test/fixtures/news-site-pl-2016-11-30.htm
D test/fixtures/news-site-pl-2017-10-04.htm
D test/fixtures/news-site-pt-2016-11-30.htm
D test/fixtures/news-site-pt-2017-10-04.htm
D test/fixtures/news-site-ru-2016-11-30.htm
D test/fixtures/news-site-ru-2017-10-04.htm
D test/fixtures/news-site-sco-2016-11-30.htm
D test/fixtures/news-site-sco-2017-10-04.htm
D test/fixtures/news-site-sv-2016-11-30.htm
D test/fixtures/news-site-sv-2017-10-04.htm
D test/fixtures/news-site-vi-2016-11-30.htm
D test/fixtures/news-site-vi-2017-10-04.htm
32 files changed, 0 insertions(+), 2,406 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/81/397981/1


-- 
To view, visit https://gerrit.wikimedia.org/r/397981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97888ea9d37dff9dcc1756b21abc19be7c6c7e82
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix news tests and reenable monitoring

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397980 )

Change subject: Fix news tests and reenable monitoring
..

Fix news tests and reenable monitoring

Change-Id: I1cf4832e01ab56c3a86ed50b20a5fb4818e7251b
---
M etc/feed/news-sites.js
M spec.yaml
M test/features/news/news-sites.js
M test/features/news/news.js
A test/fixtures/news-site-da-2017-12-12.htm
A test/fixtures/news-site-de-2017-12-12.htm
A test/fixtures/news-site-el-2017-12-12.htm
A test/fixtures/news-site-en-2017-12-12.htm
A test/fixtures/news-site-es-2017-12-12.htm
A test/fixtures/news-site-fi-2017-12-12.htm
A test/fixtures/news-site-fr-2017-12-12.htm
A test/fixtures/news-site-he-2017-12-12.htm
A test/fixtures/news-site-ko-2017-12-12.htm
A test/fixtures/news-site-no-2017-12-12.htm
A test/fixtures/news-site-pl-2017-12-12.htm
A test/fixtures/news-site-pt-2017-12-12.htm
A test/fixtures/news-site-ru-2017-12-12.htm
A test/fixtures/news-site-sco-2017-12-12.htm
A test/fixtures/news-site-sv-2017-12-12.htm
A test/fixtures/news-site-vi-2017-12-12.htm
20 files changed, 1,227 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/80/397980/1


-- 
To view, visit https://gerrit.wikimedia.org/r/397980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cf4832e01ab56c3a86ed50b20a5fb4818e7251b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376173 )

Change subject: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem
..


[BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

Follows-up on Ic12be404eba490e5ce748f0d754a807e12f6ba76

Bug: T76630
Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 969cc57..40b35d8 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -813,18 +813,6 @@
 };
 
 /**
- * Get the next selectable item or `null` if there are no selectable items.
- * Disabled options and menu-section markers and breaks are not selectable.
- *
- * @deprecated 0.23.1 Use {@link OO.ui.SelectWidget#findFirstSelectableItem} 
instead.
- * @return {OO.ui.OptionWidget|null} Item, `null` if there aren't any 
selectable items
- */
-OO.ui.SelectWidget.prototype.getFirstSelectableItem = function () {
-   OO.ui.warnDeprecation( 'SelectWidget#getFirstSelectableItem: Deprecated 
function. Use findFirstSelectableItem instead. See T76630.' );
-   return this.findFirstSelectableItem();
-};
-
-/**
  * Add an array of options to the select. Optionally, an index number can be 
used to
  * specify an insertion point.
  *

-- 
To view, visit https://gerrit.wikimedia.org/r/376173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: WikimediaUI theme: Remove obsolete icon flags

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397979 )

Change subject: WikimediaUI theme: Remove obsolete icon flags
..

WikimediaUI theme: Remove obsolete icon flags

Removing 'progressive' variant when it's already set globally.

Bug: T173350
Change-Id: Id92b1945abd775357d33d854c7746c3bfaaeb936
---
M src/themes/wikimediaui/icons-content.json
M src/themes/wikimediaui/icons-editing-core.json
M src/themes/wikimediaui/icons-interactions.json
M src/themes/wikimediaui/icons-moderation.json
4 files changed, 15 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/79/397979/1

diff --git a/src/themes/wikimediaui/icons-content.json 
b/src/themes/wikimediaui/icons-content.json
index 3358bff..d37070a 100644
--- a/src/themes/wikimediaui/icons-content.json
+++ b/src/themes/wikimediaui/icons-content.json
@@ -69,7 +69,7 @@
"ltr": "images/icons/newspaper-ltr.svg",
"rtl": "images/icons/newspaper-rtl.svg"
} },
-   "tag": { "file": "images/icons/tag.svg", "variants": [ 
"destructive", "warning", "progressive" ] },
+   "tag": { "file": "images/icons/tag.svg", "variants": [ 
"destructive", "warning" ] },
"upload": { "file": {
"ltr": "images/icons/upload-ltr.svg",
"rtl": "images/icons/upload-rtl.svg"
diff --git a/src/themes/wikimediaui/icons-editing-core.json 
b/src/themes/wikimediaui/icons-editing-core.json
index 9a9293c..dfa370c 100644
--- a/src/themes/wikimediaui/icons-editing-core.json
+++ b/src/themes/wikimediaui/icons-editing-core.json
@@ -22,7 +22,7 @@
"edit": { "file": {
"ltr": "images/icons/edit-ltr.svg",
"rtl": "images/icons/edit-rtl.svg"
-   }, "variants": [ "progressive" ] },
+   } },
"editLock": { "file": {
"ltr": "images/icons/editLock-ltr.svg",
"rtl": "images/icons/editLock-rtl.svg"
diff --git a/src/themes/wikimediaui/icons-interactions.json 
b/src/themes/wikimediaui/icons-interactions.json
index f53fd20..7f49bea 100644
--- a/src/themes/wikimediaui/icons-interactions.json
+++ b/src/themes/wikimediaui/icons-interactions.json
@@ -19,14 +19,14 @@
}
},
"images": {
-   "add": { "file": "images/icons/add.svg", "variants": [ 
"progressive" ] },
+   "add": { "file": "images/icons/add.svg" },
"advanced": { "file": "images/icons/advanced.svg" },
"browser": { "file": {
"ltr": "images/icons/browser-ltr.svg",
"rtl": "images/icons/browser-rtl.svg"
} },
"cancel": { "file": "images/icons/cancel.svg", "variants": [ 
"destructive" ] },
-   "check": { "file": "images/icons/check.svg", "variants": [ 
"progressive", "destructive" ] },
+   "check": { "file": "images/icons/check.svg", "variants": [ 
"destructive" ] },
"clear": { "file": "images/icons/clear.svg" },
"clock": { "file": "images/icons/clock.svg" },
"close": { "file": "images/icons/close.svg" },
@@ -35,8 +35,7 @@
"file": {
"ltr": "images/icons/feedback-ltr.svg",
"rtl": "images/icons/feedback-rtl.svg"
-   },
-   "variants": [ "progressive" ]
+   }
},
"funnel": { "file": {
"ltr": "images/icons/funnel-ltr.svg",
diff --git a/src/themes/wikimediaui/icons-moderation.json 
b/src/themes/wikimediaui/icons-moderation.json
index 87d1640..89746eb 100644
--- a/src/themes/wikimediaui/icons-moderation.json
+++ b/src/themes/wikimediaui/icons-moderation.json
@@ -24,8 +24,8 @@
"ltr": "images/icons/unBlock-ltr.svg",
"rtl": "images/icons/unBlock-rtl.svg"
} },
-   "clip": { "file": "images/icons/clip.svg", "variants": [ 
"progressive" ] },
-   "unClip": { "file": "images/icons/unClip.svg", "variants": [ 
"progressive" ] },
+   "clip": { "file": "images/icons/clip.svg" },
+   "unClip": { "file": "images/icons/unClip.svg" },
"flag": { "file": {
"ltr": "images/icons/flag-ltr.svg",
"rtl": "images/icons/flag-rtl.svg"
@@ -42,24 +42,21 @@
"ltr": "images/icons/unLock-ltr.svg",
"rtl": "images/icons/unLock-rtl.svg"
}, "variants": [ "destructive" ] },
-   "star": { "file": "images/icons/star.svg", "variants": [ 
"progressive" ] },
+   "star": { "file": 

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix z-index for RCFilters' overlay

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397978 )

Change subject: Fix z-index for RCFilters' overlay
..

Fix z-index for RCFilters' overlay

Currently the personal bar displays on top of it. This wasn't
visible until some popups started opening upwards rather than
downwards. We should fix this better some time...

Bug: T182711
Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
---
M skinStyles/ooui.less
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/78/397978/1

diff --git a/skinStyles/ooui.less b/skinStyles/ooui.less
index 60fcec2..e9f5961 100644
--- a/skinStyles/ooui.less
+++ b/skinStyles/ooui.less
@@ -1,4 +1,5 @@
 .oo-ui-windowManager-modal,
+.skin-vector .mw-rcfilters-ui-overlay,
 .skin-vector .ve-ui-overlay-global {
z-index: 101;
position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/397978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fe6b8b2c9c1e4d12a9a4d2d1edd1ead269780cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointle...

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397976 )

Change subject: mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless 
option
..

mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option

this.$overlay is undefined at this point; passing this does nothing.
An overlay is already being correctly passed when this widget is
constructed in mw.rcfilters.ui.FilterTagMultiselectWidget.

Change-Id: I958051e01d7d6a3065ad88f60bb8db4f5dc932d4
---
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/397976/1

diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index bb837e0..f546d97 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -26,7 +26,6 @@
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this, 
$.extend( {
framed: false,
icon: 'unClip',
-   $overlay: this.$overlay,
title: mw.msg( 'rcfilters-savedqueries-add-new-title' ),
popup: {
classes: [ 
'mw-rcfilters-ui-saveFiltersPopupButtonWidget-popup' ],

-- 
To view, visit https://gerrit.wikimedia.org/r/397976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I958051e01d7d6a3065ad88f60bb8db4f5dc932d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] Drop the `constructive` flag entirely

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/380795 )

Change subject: [BREAKING CHANGE] Drop the `constructive` flag entirely
..


[BREAKING CHANGE] Drop the `constructive` flag entirely

Bug: T156874
Change-Id: I69f9164f5e06e990e3ffec3e2099147c5ba7b8c0
---
M demos/pages/icons.js
M php/mixins/FlaggedElement.php
M php/themes/WikimediaUITheme.php
M src/mixins/FlaggedElement.js
M src/themes/apex/elements.less
M src/themes/apex/windows.less
M src/themes/wikimediaui/WikimediaUITheme.js
M src/themes/wikimediaui/elements.less
M src/themes/wikimediaui/icons-alerts.json
M src/themes/wikimediaui/icons-content.json
M src/themes/wikimediaui/icons-editing-advanced.json
M src/themes/wikimediaui/icons-editing-core.json
M src/themes/wikimediaui/icons-editing-list.json
M src/themes/wikimediaui/icons-editing-styling.json
M src/themes/wikimediaui/icons-interactions.json
M src/themes/wikimediaui/icons-layout.json
M src/themes/wikimediaui/icons-location.json
M src/themes/wikimediaui/icons-media.json
M src/themes/wikimediaui/icons-moderation.json
M src/themes/wikimediaui/icons-movement.json
M src/themes/wikimediaui/icons-user.json
M src/themes/wikimediaui/windows.less
22 files changed, 12 insertions(+), 70 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index 824b65b..0f85058 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -249,7 +249,6 @@
flags: [],
data: {
progressive: false,
-   constructive: false,
destructive: false
}
} ),
@@ -258,7 +257,6 @@
flags: [ 'progressive' ],
data: {
progressive: true,
-   constructive: false,
destructive: false
}
} ),
@@ -267,7 +265,6 @@
flags: [ 'destructive' ],
data: {
progressive: false,
-   constructive: false,
destructive: true
}
} )
@@ -282,7 +279,6 @@
} )
.selectItemByData( {
progressive: false,
-   constructive: false,
destructive: false
} );
 
diff --git a/php/mixins/FlaggedElement.php b/php/mixins/FlaggedElement.php
index 7121660..97e45b0 100644
--- a/php/mixins/FlaggedElement.php
+++ b/php/mixins/FlaggedElement.php
@@ -26,8 +26,7 @@
/**
 * @param array $config Configuration options
 * @param string|string[] $config['flags'] Flags describing importance 
and functionality, e.g.
-*   'primary', 'safe', 'progressive', or 'destructive'. The former 
'constructive' value was
-*deprecated since v0.23.2 and will be removed. It is equivalent to 
'progressive' for now.
+*   'primary', 'safe', 'progressive', or 'destructive'.
 */
public function initializeFlaggedElement( array $config = [] ) {
// Properties
diff --git a/php/themes/WikimediaUITheme.php b/php/themes/WikimediaUITheme.php
index 8c3f911..f93726f 100644
--- a/php/themes/WikimediaUITheme.php
+++ b/php/themes/WikimediaUITheme.php
@@ -11,7 +11,6 @@
'warning' => false,
'invert' => false,
'progressive' => false,
-   'constructive' => false,
'destructive' => false
];
 
@@ -30,7 +29,6 @@
} elseif ( !$element->isDisabled() ) {
// Any other kind of button, use the right 
colored icon if available
$variants['progressive'] = $element->hasFlag( 
'progressive' );
-   $variants['constructive'] = $element->hasFlag( 
'constructive' );
$variants['destructive'] = $element->hasFlag( 
'destructive' );
$variants['warning'] = $element->hasFlag( 
'warning' );
}
diff --git a/src/mixins/FlaggedElement.js b/src/mixins/FlaggedElement.js
index 1479bc1..c2028c9 100644
--- a/src/mixins/FlaggedElement.js
+++ b/src/mixins/FlaggedElement.js
@@ -9,7 +9,6 @@
  *
  * - **progressive**:  Progressive styling is applied to convey that the 
widget will move the user forward in a process.
  * - **destructive**: Destructive styling 

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Fix typo from previous commit, and clean up branching logic

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397975 )

Change subject: Fix typo from previous commit, and clean up branching logic
..

Fix typo from previous commit, and clean up branching logic

- Remove pre-semver support
- De-anchor the version detection from ^wmf so if we're given a
  remote like origin/wmf it'll work

Change-Id: I76fa903eb4f41722248367352c4b47a64de3ce7e
---
M make-deploy-notes/uploadChangelog.php
1 file changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/75/397975/1

diff --git a/make-deploy-notes/uploadChangelog.php 
b/make-deploy-notes/uploadChangelog.php
index ce45e7b..ca3283c 100644
--- a/make-deploy-notes/uploadChangelog.php
+++ b/make-deploy-notes/uploadChangelog.php
@@ -29,7 +29,7 @@
 $previousVersion = getPreviousVersion( $version );
 
 if ( $previousVersion === null ) {
-print "Unable to determine prior branch, given $version as current\n"
+print "Unable to determine prior branch, given $version as current\n";
 exit( 1 );
 }
 
@@ -88,14 +88,8 @@
  * @return string
  */
 function getPreviousMinorVersion( $major ) {
-   // check, which filter should be used for the filter
-   // Note, that 27 is used here, because the previous version would be 26,
-   // which uses the old non semantic versioning notation.
-   if ( $major <= 27 ) {
-   $filter = "wmf/1.{$major}wmf";
-   } else {
-   $filter = "wmf/1.{$major}.0-wmf";
-   }
+   $filter = "wmf/1.{$major}.0-wmf";
+
// get the list in a raw output format which would be visible in the
// console for this command, sorted by version numbers
$rawList = shell_exec( "git branch -a --list */{$filter}* | sort -V" );
@@ -125,7 +119,7 @@
 function getMajorMinor( $input ) {
$matches = array();
// match any version like wmf/1.26wmf22 or the new semver 
wmf/1.27.0-wmf1
-   if ( preg_match( "/^wmf\/1\.(\d{2})(?:\.[0-9]\-)?wmf\.?(\d{1,2})/", 
$input, $matches ) ) {
+   if ( preg_match( "/wmf\/1\.(\d{2})\.[0-9]\-wmf\.(\d{1,2})/", $input, 
$matches ) ) {
// var_dump( $matches );
$major = intval( $matches[1] );
$minor = intval( $matches[2] );

-- 
To view, visit https://gerrit.wikimedia.org/r/397975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76fa903eb4f41722248367352c4b47a64de3ce7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.rcfilters.ui.MenuSelectWidget: Always open this menu down...

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397974 )

Change subject: mw.rcfilters.ui.MenuSelectWidget: Always open this menu 
downwards
..

mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards

Bug: T182711
Change-Id: I6da6cbe53026a4407160c056f6cb4bcb47553049
---
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/397974/1

diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index 22c176f..1740c93 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -135,6 +135,8 @@
mw.rcfilters.ui.MenuSelectWidget.prototype.toggle = function ( show ) {
this.lazyMenuCreation();
mw.rcfilters.ui.MenuSelectWidget.parent.prototype.toggle.call( 
this, show );
+   // Always open this menu downwards. FilterTagMultiselectWidget 
scrolls it into view.
+   this.setVerticalPosition( 'below' );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/397974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6da6cbe53026a4407160c056f6cb4bcb47553049
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Turn on second mlr test for hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397973 )

Change subject: Turn on second mlr test for hewiki
..

Turn on second mlr test for hewiki

Resets enwiki to its default sampling of 1:2000. Re-uses the same
sampling rates as last time around on hewiki. Depends on
I681e1e724 being deployed first to setup the appropriate backend
triggers.

Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 8 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/73/397973/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index a48355d..de78f11 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,8 +114,8 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'enwiki' ?
-   [ 'control', 'dbn20', 'dbn20-i', 
'dbn35', 'dbn35-i' ] :
+   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
+   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
[],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
@@ -137,12 +137,9 @@
test: 350,
subTest: null
},
-   // .0005 works out to 
~2.7k sessions per week.
-   // .15 increases that 
to 810k per week. Giving
-   // 160k sessions per 
bucket per week.
enwiki: {
-   test: 0.15,
-   subTest: 0.996
+   test: 2000,
+   subTest: null
},
enwiktionary: {
test: 40,
@@ -191,6 +188,10 @@
zhwiki: {
test: 100,
subTest: null
+   },
+   hewiki: {
+   test: 0.8112,
+   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/397973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc0ddd86da966a8f49b27a4ddf9aa93074a6b39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: More descriptive failure

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397972 )

Change subject: More descriptive failure
..

More descriptive failure

Change-Id: I4ac7e56c2235f0ae48681a318a7548fac0bb1624
---
M make-deploy-notes/uploadChangelog.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/72/397972/1

diff --git a/make-deploy-notes/uploadChangelog.php 
b/make-deploy-notes/uploadChangelog.php
index c8fc86f..ce45e7b 100644
--- a/make-deploy-notes/uploadChangelog.php
+++ b/make-deploy-notes/uploadChangelog.php
@@ -21,16 +21,16 @@
  */
 
 if ( count( $argv ) !== 2 && count( $argv ) !== 4 ) {
-   print "usage: $argv[0] wmf/1.31.0-wmf.11 [username password]\n";
-   exit( 1 );
+print "usage: $argv[0] wmf/1.31.0-wmf.11 [username password]\n";
+exit( 1 );
 }
 
 $version = $argv[1];
 $previousVersion = getPreviousVersion( $version );
 
 if ( $previousVersion === null ) {
-   print "usage: $argv[0] wmf/1.31.0-wmf.11 [username password]\n";
-   exit( 1 );
+print "Unable to determine prior branch, given $version as current\n"
+exit( 1 );
 }
 
 $escVer = escapeshellarg( $version );

-- 
To view, visit https://gerrit.wikimedia.org/r/397972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ac7e56c2235f0ae48681a318a7548fac0bb1624
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Clarify `.oo-ui-force-gpu-composite-layer()` mixin comment

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395904 )

Change subject: Clarify `.oo-ui-force-gpu-composite-layer()` mixin comment
..


Clarify `.oo-ui-force-gpu-composite-layer()` mixin comment

Clarifying and being more explicit about
`.oo-ui-force-gpu-composite-layer()` mixins usage and adding
usage as workaround for Chrome `opacity` bug.

Bug: T182257
Change-Id: Id826d1b09fce2ba0e0b0b04f08ca921714a3d252
---
M src/styles/common.less
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/styles/common.less b/src/styles/common.less
index c3b6d69..ac96d2e 100644
--- a/src/styles/common.less
+++ b/src/styles/common.less
@@ -32,10 +32,10 @@
.oo-ui-background-image-svg-internal( @svg, @fallback );
 }
 
-// Only Webkit/Blink: Force element on own GPU composite layer
+// Support Webkit/Blink: Force element on own GPU composite layer
 // Can be used in order to help establish smooth, jank-free scrolling
-// in connection with CSS animations. Use sparely & wisely!
-// See T154460
+// in connection with CSS animations or tame `opacity` bug. Use sparely & 
wisely!
+// See T154460 & T182257
 .oo-ui-force-gpu-composite-layer() {
-webkit-transform: translateZ( 0 );
transform: translateZ( 0 );

-- 
To view, visit https://gerrit.wikimedia.org/r/395904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id826d1b09fce2ba0e0b0b04f08ca921714a3d252
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: JJB: Remove browsertests-irc

[Greg Grossmeier (Code Review)]

Greg Grossmeier has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397971 )

Change subject: JJB: Remove browsertests-irc
..

JJB: Remove browsertests-irc

It was set to spam #wikimedia-releng on state change.

1) No one watches those notifications.
2) It is only used with the ruby selenium jobs.

Thus, remove it.

Bug: T181582
Change-Id: I8df4df3b65f5a1325541d527e714f90ee8160756
---
M jjb/job-templates-selenium.yaml
M jjb/language-screenshots.yaml
M jjb/macro.yaml
3 files changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/71/397971/1

diff --git a/jjb/job-templates-selenium.yaml b/jjb/job-templates-selenium.yaml
index 39c1526..b7e47e4 100644
--- a/jjb/job-templates-selenium.yaml
+++ b/jjb/job-templates-selenium.yaml
@@ -117,8 +117,6 @@
   failure: true
   unstable: true
 
-  - browsertests-irc
-
   - performance:
   failed-threshold: -1
   unstable-threshold: -1
diff --git a/jjb/language-screenshots.yaml b/jjb/language-screenshots.yaml
index d9feb08..f6fa945 100644
--- a/jjb/language-screenshots.yaml
+++ b/jjb/language-screenshots.yaml
@@ -85,8 +85,6 @@
   recipients: qa-ale...@lists.wikimedia.org # TODO: job owners wanted
   body: '${SCRIPT, template="wikimedia.template"}'
 
-  - browsertests-irc
-
   - archive:
   artifacts: 'screenshots/*.png'
 
diff --git a/jjb/macro.yaml b/jjb/macro.yaml
index ffb4db0..9d87f4e 100644
--- a/jjb/macro.yaml
+++ b/jjb/macro.yaml
@@ -522,22 +522,6 @@
 artifacts: 'log/*'
 allow-empty: true
 
-- publisher:
-name: browsertests-irc
-publishers:
-  - ircbot:
-  strategy: statechange-only
-  notify-start: false
-  notify-committers: false
-  notify-culprits: false
-  notify-upstream: false
-  notify-fixers: false
-  message-type: summary
-  matrix-notifier: only-configurations
-  channels:
-  - name: '#wikimedia-releng'
-notify-only: true
-
 # Validate a composer.json
 - builder:
 name: composer-validate

-- 
To view, visit https://gerrit.wikimedia.org/r/397971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8df4df3b65f5a1325541d527e714f90ee8160756
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Greg Grossmeier 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 94f267b

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397969 )

Change subject: Update mobileapps to 94f267b
..


Update mobileapps to 94f267b

List of changes:
75d1d7b Fix onthisday with section tags
751845a Bump onthisday version.
94f267b Bump definitions version and sync spec versions
xxx Update node module dependencies

Change-Id: Ia446a2189fe8fa090a27488dad346802b998e142
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 6fd2f7b..5a12100 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "0a1f3ec3192e7e4c49b985e3ebd1e6905d9f2d2d",
+  "_shasum": "59d4bdcb9a0e95b5d9c6a3bd9e9f4b562ac8a509",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 958f485..577f349 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "475d668797333230228ec38595ff831f6520650b",
+  "_shasum": "868ce5edc8de7e54d918caf79a5b3b30237e66b1",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index d0ee651..94f267b 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit d0ee65120d6a4b52a232c056508b82001431f432
+Subproject commit 94f267b3a733ac4a49614f2995d743df530fd88a

-- 
To view, visit https://gerrit.wikimedia.org/r/397969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia446a2189fe8fa090a27488dad346802b998e142
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Turn on MLR for most wikis with >1% of search traffic

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397970 )

Change subject: Turn on MLR for most wikis with >1% of search traffic
..

Turn on MLR for most wikis with >1% of search traffic

Based on the results of our AB test showing improved search relevance
for machine learned ranking, turn them on. Also updates to models
trained in the last week.

Change-Id: I657d80bd1fbda61d5fd84fcdd0e29383a1d857cd
---
M tests/cirrusTest.php
M wmf-config/InitialiseSettings.php
2 files changed, 36 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/70/397970/1

diff --git a/tests/cirrusTest.php b/tests/cirrusTest.php
index 5bccd87..8a57bda 100644
--- a/tests/cirrusTest.php
+++ b/tests/cirrusTest.php
@@ -241,7 +241,7 @@
'zhwiki' => [ 'zhwiki', 'wiki',
[
'wmgCirrusSearchSimilarityProfile' => 
'wmf_defaults',
-   'wmgCirrusSearchRescoreProfile' => 
'wsum_inclinks',
+   'wmgCirrusSearchRescoreProfile' => 
'mlr-1024rs',

'wmgCirrusSearchFullTextQueryBuilderProfile' => 'perfield_builder',
'wmgCirrusSearchMaxPhraseTokens' => 10,
],
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9ab29bf..ccf3f56 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18253,6 +18253,23 @@
'default' => 'wsum_inclinks',
'commonswiki' => 'classic_noboostlinks',
'enwiki' => 'mlr-1024rs',
+   'arwiki' => 'mlr-1024rs',
+   'dewiki' => 'mlr-1024rs',
+   'fawiki' => 'mlr-1024rs',
+   'fiwiki' => 'mlr-1024rs',
+   'frwiki' => 'mlr-1024rs',
+   'idwiki' => 'mlr-1024rs',
+   'itwiki' => 'mlr-1024rs',
+   'jawiki' => 'mlr-1024rs',
+   'kowiki' => 'mlr-1024rs',
+   'nlwiki' => 'mlr-1024rs',
+   'nowiki' => 'mlr-1024rs',
+   'plwiki' => 'mlr-1024rs',
+   'ptwiki' => 'mlr-1024rs',
+   'ruwiki' => 'mlr-1024rs',
+   'svwiki' => 'mlr-1024rs',
+   'viwiki' => 'mlr-1024rs',
+   'zhwiki' => 'mlr-1024rs',
// Uses the lang tag, list of spaceless languages
// (see 
https://www.mediawiki.org/wiki/User:TJones_(WMF)/Notes/Spaceless_Writing_Systems_and_Wiki-Projects)
"bo" => "classic",
@@ -19595,25 +19612,25 @@
 
 'wmgCirrusSearchMLRModel' => [
'default' => false,
-   'enwiki' => '20171101_enwiki_v1',
-   'arwiki' => '20170905_arwiki_v1',
-   'fawiki' => '20170905_fawiki_v1',
-   'jawiki' => '20170905_jawiki_v1',
-   'svwiki' => '20170905_svwiki_v1',
-   'frwiki' => '20170905_frwiki_v1',
-   'itwiki' => '20170905_itwiki_v1',
-   'ptwiki' => '20170905_ptwiki_v1',
-   'ruwiki' => '20170905_ruwiki_v1',
-   'dewiki' => '20170905_dewiki_v1',
-   'fiwiki' => '20170908_fiwiki_v1',
+   'enwiki' => '20171130_enwiki_v1',
+   'arwiki' => '20171130_arwiki_v1',
+   'fawiki' => '20171130_fawiki_v1',
+   'jawiki' => '20171130_jawiki_v1',
+   'svwiki' => '20171130_svwiki_v1',
+   'frwiki' => '20171130_frwiki_v1',
+   'itwiki' => '20171130_itwiki_v1',
+   'ptwiki' => '20171130_ptwiki_v1',
+   'ruwiki' => '20171130_ruwiki_v1',
+   'dewiki' => '20171130_dewiki_v1',
+   'fiwiki' => '20171130_fiwiki_v1',
'hewiki' => '20171130_hewiki_v1',
-   'idwiki' => '20170908_idwiki_v1',
-   'kowiki' => '20170908_kowiki_v1',
-   'nlwiki' => '20170908_nlwiki_v1',
-   'nowiki' => '20170908_nowiki_v1',
-   'plwiki' => '20170908_plwiki_v1',
-   'viwiki' => '20170908_viwiki_v1',
-   'zhwiki' => '20170908_zhwiki_v1',
+   'idwiki' => '20171130_idwiki_v1',
+   'kowiki' => '20171130_kowiki_v1',
+   'nlwiki' => '20171130_nlwiki_v1',
+   'nowiki' => '20171130_nowiki_v1',
+   'plwiki' => '20171130_plwiki_v1',
+   'viwiki' => '20171130_viwiki_v1',
+   'zhwiki' => '20171130_zhwiki_v1',
 ],
 
 'wmgWMESearchRelevancePages' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/397970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I657d80bd1fbda61d5fd84fcdd0e29383a1d857cd
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 94f267b

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397969 )

Change subject: Update mobileapps to 94f267b
..

Update mobileapps to 94f267b

List of changes:
75d1d7b Fix onthisday with section tags
751845a Bump onthisday version.
94f267b Bump definitions version and sync spec versions
xxx Update node module dependencies

Change-Id: Ia446a2189fe8fa090a27488dad346802b998e142
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps/deploy 
refs/changes/69/397969/1

diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 6fd2f7b..5a12100 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "0a1f3ec3192e7e4c49b985e3ebd1e6905d9f2d2d",
+  "_shasum": "59d4bdcb9a0e95b5d9c6a3bd9e9f4b562ac8a509",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 958f485..577f349 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "475d668797333230228ec38595ff831f6520650b",
+  "_shasum": "868ce5edc8de7e54d918caf79a5b3b30237e66b1",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index d0ee651..94f267b 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit d0ee65120d6a4b52a232c056508b82001431f432
+Subproject commit 94f267b3a733ac4a49614f2995d743df530fd88a

-- 
To view, visit https://gerrit.wikimedia.org/r/397969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia446a2189fe8fa090a27488dad346802b998e142
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...relevanceForge[master]: Add sanity checks for more languages

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397968 )

Change subject: Add sanity checks for more languages
..

Add sanity checks for more languages

I'm not completely sure these are very good. I didn't really try and
figure out what any of the pages were, just chose random pages from the
bottom 2/3 of the top 100 most popular pages (by page views) of the last
month. Then chose sometimes a redirect and sometimes the primary title
as the query string.

We can probably iterate on these if we get any complaints about search
results that users expect at the top but are not.

Change-Id: I39b47b47f03d02907f5d291050465c14ae596287
---
M sanityCheck.py
A sanityCheck/arwiki.json
A sanityCheck/dewiki.json
A sanityCheck/fawiki.json
A sanityCheck/fiwiki.json
A sanityCheck/frwiki.json
A sanityCheck/hewiki.json
A sanityCheck/idwiki.json
A sanityCheck/itwiki.json
A sanityCheck/jawiki.json
A sanityCheck/kowiki.json
A sanityCheck/nlwiki.json
A sanityCheck/nowiki.json
A sanityCheck/plwiki.json
A sanityCheck/ptwiki.json
A sanityCheck/ruwiki.json
A sanityCheck/svwiki.json
A sanityCheck/viwiki.json
A sanityCheck/zhwiki.json
19 files changed, 256 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/relevanceForge 
refs/changes/68/397968/1

diff --git a/sanityCheck.py b/sanityCheck.py
old mode 100644
new mode 100755
index 19aae72..341f476
--- a/sanityCheck.py
+++ b/sanityCheck.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python
 from __future__ import print_function
 import argparse
 import json
@@ -37,6 +38,9 @@
 print('')
 else:
 print("PASSED\n")
+
+print("OVERALL: %s" % ("PASSED" if ok else "FAILED"))
+
 return ok
 
 
diff --git a/sanityCheck/arwiki.json b/sanityCheck/arwiki.json
new file mode 100644
index 000..1f27498
--- /dev/null
+++ b/sanityCheck/arwiki.json
@@ -0,0 +1,11 @@
+{
+"api": "https://ar.wikipedia.org/w/api.php;,
+"queries": {
+"ابن_الهيثم": [
+"ابن الهيثم"
+],
+"مؤسسة محمد الخامس": [
+"مؤسسة محمد الخامس للتضامن"
+]
+}
+}
diff --git a/sanityCheck/dewiki.json b/sanityCheck/dewiki.json
new file mode 100644
index 000..4480dc3
--- /dev/null
+++ b/sanityCheck/dewiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://de.wikipedia.org/w/api.php;,
+"queries": {
+"Bundestagswahl 2017": [
+"Bundestagswahl 2017"
+],
+"FIFA WM 2018": [
+"Fußball-Weltmeisterschaft 2018"
+],
+"Rechtswesen Österreichs": [
+"Österreich"
+]
+}
+}
diff --git a/sanityCheck/fawiki.json b/sanityCheck/fawiki.json
new file mode 100644
index 000..7397c81
--- /dev/null
+++ b/sanityCheck/fawiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://fa.wikipedia.org/w/api.php;,
+"queries": {
+"سید محمدحسین شهریار": [
+"سید محمدحسین شهریار"
+],
+"شادمهر عقيلي": [
+"شادمهر عقیلی"
+],
+"ساكر": [
+"آمیزش جنسی دهانی"
+]
+}
+}
diff --git a/sanityCheck/fiwiki.json b/sanityCheck/fiwiki.json
new file mode 100644
index 000..2be778b
--- /dev/null
+++ b/sanityCheck/fiwiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://fi.wikipedia.org/w/api.php;,
+"queries": {
+"Happamuus": [
+"Happamuus"
+],
+"Veljessota": [
+"Suomen sisällissota"
+],
+"Mannerheim": [
+"Carl Gustaf Emil Mannerheim"
+]
+}
+}
diff --git a/sanityCheck/frwiki.json b/sanityCheck/frwiki.json
new file mode 100644
index 000..4528194
--- /dev/null
+++ b/sanityCheck/frwiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://fr.wikipedia.org/w/api.php;,
+"queries": {
+"U Arena": [
+"U Arena"
+],
+"DALS": [
+"Danse avec les stars"
+],
+"Tableau périodique des éléments": [
+"Tableau périodique des éléments"
+]
+}
+}
diff --git a/sanityCheck/hewiki.json b/sanityCheck/hewiki.json
new file mode 100644
index 000..c3a014d
--- /dev/null
+++ b/sanityCheck/hewiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://he.wikipedia.org/w/api.php;,
+"queries": {
+"שלמה ארצי": [
+"שלמה ארצי"
+],
+"רחל בלובשטיין סלע": [
+"רחל המשוררת"
+],
+"Jerusalem": [
+"ירושלים"
+]
+}
+}
diff --git a/sanityCheck/idwiki.json b/sanityCheck/idwiki.json
new file mode 100644
index 000..5e9380e
--- /dev/null
+++ b/sanityCheck/idwiki.json
@@ -0,0 +1,14 @@
+{
+"api": "https://id.wikipedia.org/w/api.php;,
+"queries": {
+"Pemerintahan daerah di Indonesia": [
+"Pemerintahan daerah di Indonesia"
+],
+"Undang-undang dasar": [
+"Konstitusi"
+],
+"Srivijaya": [
+"Sriwijaya"
+ 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet agent: don't call etckeeper hooks pre- and post-run

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397967 )

Change subject: puppet agent: don't call etckeeper hooks pre- and post-run
..

puppet agent: don't call etckeeper hooks pre- and post-run

Best I can tell this was never used; it also appears to be
less supported in modern Puppet versions.

Bug: T182721
Change-Id: I4e1e5ea46f00aa3abfbfa16cf38e107c7551c212
---
M modules/base/templates/puppet.conf.d/10-main.conf.erb
M modules/puppet/templates/self.conf.erb
2 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/397967/1

diff --git a/modules/base/templates/puppet.conf.d/10-main.conf.erb 
b/modules/base/templates/puppet.conf.d/10-main.conf.erb
index 3aea596..ca8d341 100644
--- a/modules/base/templates/puppet.conf.d/10-main.conf.erb
+++ b/modules/base/templates/puppet.conf.d/10-main.conf.erb
@@ -24,8 +24,6 @@
 configtimeout = 960
 usecacheonfailure = false
 splay = true
-prerun_command = /etc/puppet/etckeeper-commit-pre
-postrun_command = /etc/puppet/etckeeper-commit-post
 pluginsync = true
 report = true
 stringify_facts = false
diff --git a/modules/puppet/templates/self.conf.erb 
b/modules/puppet/templates/self.conf.erb
index f3ce85c..7302aaa 100644
--- a/modules/puppet/templates/self.conf.erb
+++ b/modules/puppet/templates/self.conf.erb
@@ -11,8 +11,6 @@
 server = <%= server %>
 configtimeout = 480
 splay = true
-prerun_command = /etc/puppet/etckeeper-commit-pre
-postrun_command = /etc/puppet/etckeeper-commit-post
 pluginsync = true
 report = true
 <%

-- 
To view, visit https://gerrit.wikimedia.org/r/397967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e1e5ea46f00aa3abfbfa16cf38e107c7551c212
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrapvz: allow default (v4) puppet packages on stretch b...

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397966 )

Change subject: bootstrapvz: allow default (v4) puppet packages on stretch base 
images.
..

bootstrapvz: allow default (v4) puppet packages on stretch base images.

Bug: T178717
Change-Id: I5a7cd72e630e6bbd2d29cedbb3b31ecafe387603
---
M modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/66/397966/1

diff --git a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml 
b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
index 4188877..f01f88c 100644
--- a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
+++ b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
@@ -91,8 +91,8 @@
 - os-prober
 - parted
 - prometheus-node-exporter
-- puppet=3.8.5-2
-- puppet-common=3.8.5-2
+- puppet
+- puppet-common
 - pv
 - python-apt
 - python-ldap

-- 
To view, visit https://gerrit.wikimedia.org/r/397966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a7cd72e630e6bbd2d29cedbb3b31ecafe387603
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump definitions version and sync spec versions

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397964 )

Change subject: Bump definitions version and sync spec versions
..


Bump definitions version and sync spec versions

Change-Id: I78466c8ec9ba8fde5d0eef6f11decc3d52268d25
---
M lib/mobile-util.js
M spec.yaml
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index 3d9e28a..c088707 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -14,7 +14,7 @@
 media: { name: 'Media', version: '1.0.0' },
 readHtml: { name: 'ReadHtml', version: '0.1.0' },
 summary: { name: 'Summary', version: '1.3.0' },
-definition: { name: 'definition', version: '0.7.3' },
+definition: { name: 'definition', version: '0.7.4' },
 random: { name: 'random', version: '0.6.0' },
 announcements: { name: 'announcements', version: '0.1.0' },
 compilations: { name: 'compilations', version: '0.1.0' },
diff --git a/spec.yaml b/spec.yaml
index 0d42039..b3838f0 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -139,7 +139,7 @@
  - Holidays: a list of fixed holidays celebrated on the provided day 
and month
  - Events: a list of significant events which happened on the provided 
day and month and which are not covered by the other types yet
   produces:
-- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/onthisday/0.3.1;
+- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/onthisday/0.3.2;
   parameters:
 - name: type
   in: path
@@ -607,7 +607,7 @@
 - Wiktionary definition of {title}
   description: Gets definitions parsed from Wiktionary for {title}
   produces:
-- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/definition/0.7.3;
+- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/definition/0.7.4;
   x-amples:
 - title: retrieve en-wiktionary definitions for 'cat'
   request:

-- 
To view, visit https://gerrit.wikimedia.org/r/397964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78466c8ec9ba8fde5d0eef6f11decc3d52268d25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Update mobileapps to d0ee651"

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397965 )

Change subject: Revert "Update mobileapps to d0ee651"
..

Revert "Update mobileapps to d0ee651"

This reverts commit 28bfda34d0c8ff543cec392a6c8a2186c12e502e.

Change-Id: Ibe21bdac31879a77cdcb5a42d1b49ab7efb44870
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps/deploy 
refs/changes/65/397965/1

diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 6fd2f7b..008df1d 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "0a1f3ec3192e7e4c49b985e3ebd1e6905d9f2d2d",
+  "_shasum": "1a0b533550ebd56cd7fde69badbae6c7ac5e12a7",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 958f485..3ee47b8 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "475d668797333230228ec38595ff831f6520650b",
+  "_shasum": "908d5defcbcdd2a871a6060692f55c88104ffb5c",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index d0ee651..172abc7 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit d0ee65120d6a4b52a232c056508b82001431f432
+Subproject commit 172abc7424d0a7042e027506f5f4979553a40a3b

-- 
To view, visit https://gerrit.wikimedia.org/r/397965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe21bdac31879a77cdcb5a42d1b49ab7efb44870
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...JSBreadCrumbs[master]: Parsed messages to fix PLURAL fix.

[Cicalese (Code Review)]

Cicalese has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397963 )

Change subject: Parsed messages to fix PLURAL fix.
..

Parsed messages to fix PLURAL fix.

Change-Id: I131a1932003590929230aefb8136e5e16102b013
---
M includes/JSBreadCrumbsHooks.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/JSBreadCrumbs 
refs/changes/63/397963/1

diff --git a/includes/JSBreadCrumbsHooks.php b/includes/JSBreadCrumbsHooks.php
index c57cab9..9e75142 100644
--- a/includes/JSBreadCrumbsHooks.php
+++ b/includes/JSBreadCrumbsHooks.php
@@ -41,13 +41,13 @@
if ( $horizontal ) {
$vars['CSSSelector'] = 
$GLOBALS['wgJSBreadCrumbsCSSSelectorHorizontal'];
$vars['LeadingDescription'] = wfMessage( 
'jsbreadcrumbs-intro-horizontal',
-   $vars['SiteMaxCrumbs'] )->plain();
+   $vars['SiteMaxCrumbs'] )->parse();
$vars['MaxLength'] =
$user->getOption( 
'jsbreadcrumbs-maxlength-horizontal' );
} else {
$vars['CSSSelector'] = 
$GLOBALS['wgJSBreadCrumbsCSSSelectorVertical'];
$vars['LeadingDescription'] = wfMessage( 
'jsbreadcrumbs-intro-vertical',
-   $vars['SiteMaxCrumbs'] )->plain();
+   $vars['SiteMaxCrumbs'] )->parse();
$vars['MaxLength'] =
$user->getOption( 
'jsbreadcrumbs-maxlength-vertical' );
}
@@ -68,7 +68,7 @@
if ( $message->isBlank() ) {
$vars['Action'] = $action;
} else {
-   $vars['Action'] = $message->plain();
+   $vars['Action'] = $message->parse();
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I131a1932003590929230aefb8136e5e16102b013
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JSBreadCrumbs
Gerrit-Branch: master
Gerrit-Owner: Cicalese 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump definitions version and sync spec versions

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397964 )

Change subject: Bump definitions version and sync spec versions
..

Bump definitions version and sync spec versions

Change-Id: I78466c8ec9ba8fde5d0eef6f11decc3d52268d25
---
M lib/mobile-util.js
M spec.yaml
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/64/397964/1

diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index 3d9e28a..c088707 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -14,7 +14,7 @@
 media: { name: 'Media', version: '1.0.0' },
 readHtml: { name: 'ReadHtml', version: '0.1.0' },
 summary: { name: 'Summary', version: '1.3.0' },
-definition: { name: 'definition', version: '0.7.3' },
+definition: { name: 'definition', version: '0.7.4' },
 random: { name: 'random', version: '0.6.0' },
 announcements: { name: 'announcements', version: '0.1.0' },
 compilations: { name: 'compilations', version: '0.1.0' },
diff --git a/spec.yaml b/spec.yaml
index 0d42039..b3838f0 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -139,7 +139,7 @@
  - Holidays: a list of fixed holidays celebrated on the provided day 
and month
  - Events: a list of significant events which happened on the provided 
day and month and which are not covered by the other types yet
   produces:
-- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/onthisday/0.3.1;
+- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/onthisday/0.3.2;
   parameters:
 - name: type
   in: path
@@ -607,7 +607,7 @@
 - Wiktionary definition of {title}
   description: Gets definitions parsed from Wiktionary for {title}
   produces:
-- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/definition/0.7.3;
+- application/json; charset=utf-8; 
profile="https://www.mediawiki.org/wiki/Specs/definition/0.7.4;
   x-amples:
 - title: retrieve en-wiktionary definitions for 'cat'
   request:

-- 
To view, visit https://gerrit.wikimedia.org/r/397964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78466c8ec9ba8fde5d0eef6f11decc3d52268d25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Adds iswiki and eswikiquote reverted models.

[Halfak (Code Review)]

Halfak has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397962 )

Change subject: Adds iswiki and eswikiquote reverted models.
..

Adds iswiki and eswikiquote reverted models.

Change-Id: I7cc630e5e776ddfc7f3eb31ca7bdc7328310d3d1
---
M config/00-main.yaml
M submodules/ores
2 files changed, 25 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/ores/deploy 
refs/changes/62/397962/1

diff --git a/config/00-main.yaml b/config/00-main.yaml
index 2f23569..20ed2aa 100644
--- a/config/00-main.yaml
+++ b/config/00-main.yaml
@@ -46,6 +46,7 @@
   - elwiki
   - eswikibooks
   - eswiki
+  - eswikiquote
   - etwiki
   - fawiki
   - fiwiki
@@ -55,6 +56,7 @@
   - hrwiki
   - huwiki
   - idwiki
+  - iswiki
   - itwiki
   - kowiki
   - nlwiki
@@ -168,6 +170,13 @@
 "on": ["edit"]
   goodfaith:
 "on": ["edit"]
+  eswikiquote:
+extractor: eswikiquote_api
+scorer_models:
+  reverted: eswikiquote_revert
+precache:
+  reverted:
+"on": ["edit"]
   etwiki:
 extractor: etwiki_api
 scorer_models:
@@ -244,6 +253,13 @@
 extractor: idwiki_api
 scorer_models:
   reverted: idwiki_revert
+precache:
+  reverted:
+"on": ["edit"]
+  iswiki:
+extractor: iswiki_api
+scorer_models:
+  reverted: iswiki_revert
 precache:
   reverted:
 "on": ["edit"]
@@ -428,6 +444,8 @@
 host: https://es.wikipedia.org
   eswikibooks_api:
 host: https://es.wikibooks.org
+  eswikiquote_api:
+host: https://es.wikiquote.org
   etwiki_api:
 host: https://et.wikipedia.org
   fawiki_api:
@@ -446,6 +464,8 @@
 host: https://hu.wikipedia.org
   idwiki_api:
 host: https://id.wikipedia.org
+  iswiki_api:
+host: https://is.wikipedia.org
   itwiki_api:
 host: https://it.wikipedia.org
   kowiki_api:
@@ -515,6 +535,8 @@
 model_file: 
submodules/editquality/models/eswikibooks.damaging.gradient_boosting.model
   eswikibooks_goodfaith:
 model_file: 
submodules/editquality/models/eswikibooks.goodfaith.gradient_boosting.model
+  eswikiquote_revert:
+model_file: 
submodules/editquality/models/eswikiquote.reverted.gradient_boosting.model
   etwiki_damaging:
 model_file: 
submodules/editquality/models/etwiki.damaging.gradient_boosting.model
   etwiki_goodfaith:
@@ -545,6 +567,8 @@
 model_file: submodules/editquality/models/huwiki.reverted.rf.model
   idwiki_revert:
 model_file: 
submodules/editquality/models/idwiki.reverted.gradient_boosting.model
+  iswiki_revert:
+model_file: 
submodules/editquality/models/iswiki.reverted.gradient_boosting.model
   itwiki_revert:
 model_file: 
submodules/editquality/models/itwiki.reverted.gradient_boosting.model
   jawiki_revert:
diff --git a/submodules/ores b/submodules/ores
index b7413d6..a3a50bb 16
--- a/submodules/ores
+++ b/submodules/ores
@@ -1 +1 @@
-Subproject commit b7413d6abf80688d44b42da4a7d3a4d1a80ca150
+Subproject commit a3a50bb0b5aea50178e428430438ae3323d7376f

-- 
To view, visit https://gerrit.wikimedia.org/r/397962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cc630e5e776ddfc7f3eb31ca7bdc7328310d3d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/ores/deploy
Gerrit-Branch: master
Gerrit-Owner: Halfak 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump onthisday version.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397961 )

Change subject: Bump onthisday version.
..


Bump onthisday version.

Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
---
M lib/mobile-util.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index 443dc01..3d9e28a 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -18,7 +18,7 @@
 random: { name: 'random', version: '0.6.0' },
 announcements: { name: 'announcements', version: '0.1.0' },
 compilations: { name: 'compilations', version: '0.1.0' },
-onthisday: { name: 'onthisday', version: '0.3.1' },
+onthisday: { name: 'onthisday', version: '0.3.2' },
 unpublished: { name: 'unpublished', version: '0.0.0' }
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix onthisday with section tags

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397928 )

Change subject: Fix onthisday with section tags
..


Fix onthisday with section tags

Onthisday was looking for direct children of body to look for the
elements, which is bad with the section tags deployed.

Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
---
M lib/feed/on-this-day.languages.js
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/lib/feed/on-this-day.languages.js 
b/lib/feed/on-this-day.languages.js
index 3df2f41..2edf72f 100644
--- a/lib/feed/on-this-day.languages.js
+++ b/lib/feed/on-this-day.languages.js
@@ -23,7 +23,7 @@
 // 
https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia:Selected_anniversaries%2FMay_22
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipedia:Selected_anniversaries/${monthName}_${dayNumber}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -55,7 +55,7 @@
 // 
https://de.wikipedia.org/api/rest_v1/page/html/Wikipedia:Hauptseite%2FJahrestage%2FMai%2F22
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipedia:Hauptseite/Jahrestage/${monthName}/${dayNumber}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(v\.\s*Chr\.)?\s*(?::|[${dashChars}])\s*(.*\S.*)`,
 'i'),
@@ -93,7 +93,7 @@
 }
 return `Wikipédia:Éphéméride/${dayNumber}_${monthName}`;
 },
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -120,7 +120,7 @@
 selectedPage : {
 // https://sv.wikipedia.org/api/rest_v1/page/html/Mall:22_maj
 nameFormatter : (monthName, monthNumber, dayNumber) => 
`Mall:${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(f\.\s*Kr\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -147,7 +147,7 @@
 // 
https://pt.wikipedia.org/api/rest_v1/page/html/Wikipédia:Efemérides%2F22_de_maio
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipédia:Efemérides/${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -182,7 +182,7 @@
 // 
https://ru.wikipedia.org/api/rest_v1/page/html/Шаблон:События_дня:05-30
 nameFormatter : (monthName, monthNo, dayNo) =>
 `Шаблон:События_дня:${monthNo < 10 ? `0${monthNo}` : 
monthNo}-${dayNo}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -210,7 +210,7 @@
 // 
https://es.wikipedia.org/api/rest_v1/page/html/Plantilla:Efemérides_-_22_de_mayo
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Plantilla:Efemérides - ${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*\.*[:${dashChars}]\s*(.*\S.*)`, 
'i'),
@@ -238,7 +238,7 @@
 // 
https://ar.wikipedia.org/api/rest_v1/page/html/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7%3A%D9%81%D9%8A_%D9%87%D8%B0%D8%A7_%D8%A7%D9%84%D9%8A%D9%88%D9%85%2F22_%D9%85%D8%A7%D9%8A%D9%88
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `ويكيبيديا:في_هذا_اليوم/${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'body > ul li,section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(ق.م)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),

-- 
To view, visit https://gerrit.wikimedia.org/r/397928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump onthisday version.

[BearND (Code Review)]

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397961 )

Change subject: Bump onthisday version.
..

Bump onthisday version.

Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
---
M lib/mobile-util.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/61/397961/1

diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index 443dc01..3d9e28a 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -18,7 +18,7 @@
 random: { name: 'random', version: '0.6.0' },
 announcements: { name: 'announcements', version: '0.1.0' },
 compilations: { name: 'compilations', version: '0.1.0' },
-onthisday: { name: 'onthisday', version: '0.3.1' },
+onthisday: { name: 'onthisday', version: '0.3.2' },
 unpublished: { name: 'unpublished', version: '0.0.0' }
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Cookie must be set on server side

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/396082 )

Change subject: Cookie must be set on server side
..


Cookie must be set on server side

Setting the cookie on the client doesn't work.
It needs to be stored on the server.
This is because a call to MobileContext::setMobileMode must be
made to opt-in to beta, and cookies are not automatically forwarded from
the request to this method as needed. MobileOptions when submitted will
directly call this function.

We could of course update this behaviour must it would mean processing
cookies for every page view (not good!).

Submitting the form without an async save also avoids
the problem of having to refresh the page so after talking to Nirzar we
agreed to keep this simple and make it submit the form.

Changes:
* returnto parameter no longer honoured from Special:MobileOptions
* Remove MobileOptions::getURL which is dead code
* Successbox will only show in no-JavaScript mode. A toast is shown
in its place with JS.

Bug: T169369
Change-Id: I4028a0d37f51d8f6c6e64d49b52a76781b38676c
---
M extension.json
M includes/specials/SpecialMobileOptions.php
M resources/mobile.special.mobileoptions.scripts/mobileoptions.js
M resources/mobile.special.mobileoptions.styles/mobileoptions.less
4 files changed, 21 insertions(+), 44 deletions(-)

Approvals:
  Pmiazga: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index b4be0f0..de15843 100644
--- a/extension.json
+++ b/extension.json
@@ -944,7 +944,6 @@
"targets": [ "mobile", "desktop" ],
"position": "top",
"dependencies": [
-   "jquery.cookie",
"mobile.startup"
],
"scripts": [
diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 62dc4fe..4401371 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -79,8 +79,9 @@
 
if ( $this->getRequest()->getCheck( 'success' ) ) {
$out->wrapWikiMsg(
-   "\n$1\n",
-   'savedprefs'
+   MobileUI::contentElement(
+   Html::successBox( $this->msg( 
'savedprefs' ) )
+   )
);
}
 
@@ -132,8 +133,6 @@
$fields[] = new OOUI\HiddenInputWidget( [ 'name' => 
'token',
'value' => $user->getEditToken() ] );
}
-   $fields[] = new OOUI\HiddenInputWidget( [ 'name' => 'returnto',
-   'value' => $this->returnToTitle->getFullText() ] );
 
// @codingStandardsIgnoreEnd
$form->appendContent(
@@ -196,8 +195,7 @@
}
 
/**
-* Saves the settings submitted by the settings form. Redirects the 
user to the destination
-* of returnto or, if not set, back to this special page
+* Saves the settings submitted by the settings form
 */
private function submitSettingsForm() {
$schema = 'MobileOptionsTracking';
@@ -238,34 +236,8 @@
}
}
$context->setMobileMode( $group );
-   $returnToTitle = Title::newFromText( $request->getText( 
'returnto' ) );
-   if ( $returnToTitle ) {
-   $url = $returnToTitle->getFullURL();
-   } else {
-   $url = $this->getPageTitle()->getFullURL( 'success' );
-   }
+   $url = $this->getPageTitle()->getFullURL( 'success' );
$context->getOutput()->redirect( 
MobileContext::singleton()->getMobileUrl( $url ) );
-   }
-
-   /**
-* Get the URL of this special page
-* @param string|null $option Subpage string, or false to not use a 
subpage
-* @param Title $returnTo Destination to returnto after successfully 
action on the page returned
-* @param bool $fullUrl Whether to get the local url, or the full url
-*
-* @return string
-*/
-   public static function getURL( $option, Title $returnTo = null, 
$fullUrl = false ) {
-   $t = SpecialPage::getTitleFor( 'MobileOptions', $option );
-   $params = [];
-   if ( $returnTo ) {
-   $params['returnto'] = $returnTo->getPrefixedText();
-   }
-   if ( $fullUrl ) {
-   return MobileContext::singleton()->getMobileUrl( 
$t->getFullURL( $params ) );
-   } else {
-   return $t->getLocalURL( $params );
-   }
}
 

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix onthisday with section tags

[BearND (Code Review)]

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397928 )

Change subject: Fix onthisday with section tags
..

Fix onthisday with section tags

Onthisday was looking for direct children of body to look for the
elements, which is bad with the section tags deployed.

Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
---
M lib/feed/on-this-day.languages.js
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/28/397928/1

diff --git a/lib/feed/on-this-day.languages.js 
b/lib/feed/on-this-day.languages.js
index 3df2f41..6da6dc2 100644
--- a/lib/feed/on-this-day.languages.js
+++ b/lib/feed/on-this-day.languages.js
@@ -23,7 +23,7 @@
 // 
https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia:Selected_anniversaries%2FMay_22
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipedia:Selected_anniversaries/${monthName}_${dayNumber}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -55,7 +55,7 @@
 // 
https://de.wikipedia.org/api/rest_v1/page/html/Wikipedia:Hauptseite%2FJahrestage%2FMai%2F22
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipedia:Hauptseite/Jahrestage/${monthName}/${dayNumber}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(v\.\s*Chr\.)?\s*(?::|[${dashChars}])\s*(.*\S.*)`,
 'i'),
@@ -93,7 +93,7 @@
 }
 return `Wikipédia:Éphéméride/${dayNumber}_${monthName}`;
 },
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -120,7 +120,7 @@
 selectedPage : {
 // https://sv.wikipedia.org/api/rest_v1/page/html/Mall:22_maj
 nameFormatter : (monthName, monthNumber, dayNumber) => 
`Mall:${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(f\.\s*Kr\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -147,7 +147,7 @@
 // 
https://pt.wikipedia.org/api/rest_v1/page/html/Wikipédia:Efemérides%2F22_de_maio
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Wikipédia:Efemérides/${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -182,7 +182,7 @@
 // 
https://ru.wikipedia.org/api/rest_v1/page/html/Шаблон:События_дня:05-30
 nameFormatter : (monthName, monthNo, dayNo) =>
 `Шаблон:События_дня:${monthNo < 10 ? `0${monthNo}` : 
monthNo}-${dayNo}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   // eslint-disable-next-line max-len
@@ -210,7 +210,7 @@
 // 
https://es.wikipedia.org/api/rest_v1/page/html/Plantilla:Efemérides_-_22_de_mayo
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `Plantilla:Efemérides - ${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*\.*[:${dashChars}]\s*(.*\S.*)`, 
'i'),
@@ -238,7 +238,7 @@
 // 
https://ar.wikipedia.org/api/rest_v1/page/html/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7%3A%D9%81%D9%8A_%D9%87%D8%B0%D8%A7_%D8%A7%D9%84%D9%8A%D9%88%D9%85%2F22_%D9%85%D8%A7%D9%8A%D9%88
 nameFormatter : (monthName, monthNumber, dayNumber) =>
 `ويكيبيديا:في_هذا_اليوم/${dayNumber}_${monthName}`,
-listElementSelector: 'body > ul li'
+listElementSelector: 'section > ul li'
 },
 yearListElementRegEx :
   new 
RegExp(String.raw`^\s*(\d+)\s*(ق.م)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),

-- 
To view, visit https://gerrit.wikimedia.org/r/397928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases: Also include release tools for releasing

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397895 )

Change subject: Releases: Also include release tools for releasing
..


Releases: Also include release tools for releasing

Change-Id: I413180ece3bd2994b63f9b02aa61d56a85086b53
---
M modules/releases/manifests/init.pp
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/releases/manifests/init.pp 
b/modules/releases/manifests/init.pp
index 9faa57f..6c6c3b6 100644
--- a/modules/releases/manifests/init.pp
+++ b/modules/releases/manifests/init.pp
@@ -41,6 +41,11 @@
 require   => File['/srv/mediawiki'],
 bare  => true,
 }
+git::clone { 'mediawiki/tools/release':
+ensure=> 'latest',
+directory => '/srv/mediawiki/release-tools',
+require   => File['/srv/mediawiki'],
+}
 
 file { '/srv/org/wikimedia/releases/mediawiki':
 ensure  => 'directory',

-- 
To view, visit https://gerrit.wikimedia.org/r/397895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I413180ece3bd2994b63f9b02aa61d56a85086b53
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Better error handling for unexpected responses

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397927 )

Change subject: Better error handling for unexpected responses
..

Better error handling for unexpected responses

Bug: T182639
Change-Id: Iea04fe41b4be8e15927e93f16cbb4bb44328374f
---
M resources/dist/index.js
M resources/dist/index.js.json
M src/gateway/rest.js
M tests/node-qunit/gateway/rest.test.js
4 files changed, 28 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/27/397927/1


-- 
To view, visit https://gerrit.wikimedia.org/r/397927
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea04fe41b4be8e15927e93f16cbb4bb44328374f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OOjs UI: Backport Ibb4a81f4eabda8bffa44ae1629031ac9192c94e5

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397926 )

Change subject: OOjs UI: Backport Ibb4a81f4eabda8bffa44ae1629031ac9192c94e5
..

OOjs UI: Backport Ibb4a81f4eabda8bffa44ae1629031ac9192c94e5

Bug: T182395
Change-Id: I34de0388ad8e30d43d39d308a1b197906abf3a69
---
M resources/lib/oojs-ui/oojs-ui-core.js
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/26/397926/1

diff --git a/resources/lib/oojs-ui/oojs-ui-core.js 
b/resources/lib/oojs-ui/oojs-ui-core.js
index e0d165f..28134bc 100644
--- a/resources/lib/oojs-ui/oojs-ui-core.js
+++ b/resources/lib/oojs-ui/oojs-ui-core.js
@@ -4832,7 +4832,12 @@
  * @return {string} 'left' or 'right'
  */
 OO.ui.mixin.ClippableElement.prototype.getHorizontalAnchorEdge = function () {
-   if ( this.computePosition && this.computePosition().right !== '' ) {
+   var position;
+   try {
+   position = this.computePosition && this.computePosition();
+   } catch ( err ) {
+   }
+   if ( position && position.right !== '' ) {
return 'right';
}
return 'left';
@@ -4854,7 +4859,12 @@
  * @return {string} 'top' or 'bottom'
  */
 OO.ui.mixin.ClippableElement.prototype.getVerticalAnchorEdge = function () {
-   if ( this.computePosition && this.computePosition().bottom !== '' ) {
+   var position;
+   try {
+   position = this.computePosition && this.computePosition();
+   } catch ( err ) {
+   }
+   if ( position && position.bottom !== '' ) {
return 'bottom';
}
return 'top';

-- 
To view, visit https://gerrit.wikimedia.org/r/397926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34de0388ad8e30d43d39d308a1b197906abf3a69
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Releases jenkins: Only clone MediaWiki core, and make it a b...

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397891 )

Change subject: Releases jenkins: Only clone MediaWiki core, and make it a bare 
clone
..


Releases jenkins: Only clone MediaWiki core, and make it a bare clone

The other resources are small enough that fetching over the wire isn't
a big deal. It's only core we care about

Since it's a reference repo, we want to be bare

Change-Id: Id48c7e624cdb096b0957ced46375ad862179
---
M modules/releases/manifests/init.pp
1 file changed, 1 insertion(+), 14 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/releases/manifests/init.pp 
b/modules/releases/manifests/init.pp
index b4a8b19..9faa57f 100644
--- a/modules/releases/manifests/init.pp
+++ b/modules/releases/manifests/init.pp
@@ -39,20 +39,7 @@
 git::clone { 'mediawiki/core':
 directory => '/srv/mediawiki/core',
 require   => File['/srv/mediawiki'],
-}
-git::clone { 'mediawiki/extensions':
-directory  => '/srv/mediawiki/extensions',
-recurse_submodules => true,
-require=> File['/srv/mediawiki'],
-}
-git::clone { 'mediawiki/skins':
-directory  => '/srv/mediawiki/skins',
-recurse_submodules => true,
-require=> File['/srv/mediawiki'],
-}
-git::clone { 'mediawiki/vendor':
-directory => '/srv/mediawiki/vendor',
-require   => File['/srv/mediawiki'],
+bare  => true,
 }
 
 file { '/srv/org/wikimedia/releases/mediawiki':

-- 
To view, visit https://gerrit.wikimedia.org/r/397891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id48c7e624cdb096b0957ced46375ad862179
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to d0ee651

[Mholloway (Code Review)]

Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397924 )

Change subject: Update mobileapps to d0ee651
..


Update mobileapps to d0ee651

List of changes:
d0ee651 Fix definition endpoint 500s
xxx Update node module dependencies

Change-Id: I81c5e60323909df7c3d27cf3a9a0a0ddb327f89f
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Mholloway: Verified; Looks good to me, approved



diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 008df1d..6fd2f7b 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "1a0b533550ebd56cd7fde69badbae6c7ac5e12a7",
+  "_shasum": "0a1f3ec3192e7e4c49b985e3ebd1e6905d9f2d2d",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 3ee47b8..958f485 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "908d5defcbcdd2a871a6060692f55c88104ffb5c",
+  "_shasum": "475d668797333230228ec38595ff831f6520650b",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index 172abc7..d0ee651 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 172abc7424d0a7042e027506f5f4979553a40a3b
+Subproject commit d0ee65120d6a4b52a232c056508b82001431f432

-- 
To view, visit https://gerrit.wikimedia.org/r/397924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81c5e60323909df7c3d27cf3a9a0a0ddb327f89f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrapvz: s/jessie/stretch in apt sources

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397920 )

Change subject: bootstrapvz: s/jessie/stretch in apt sources
..


bootstrapvz: s/jessie/stretch in apt sources

Change-Id: I3cbf733d4f14d93ddf909b499fc457bc290675ad
---
M modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml 
b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
index 614f0e5..4188877 100644
--- a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
+++ b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
@@ -26,8 +26,8 @@
   - deb  http://apt.wikimedia.org/wikimedia stretch-wikimedia main
   - deb-src http://apt.wikimedia.org/wikimedia stretch-wikimedia main
 backports:
-  - deb http://mirrors.wikimedia.org/debian/ jessie-backports main contrib 
non-free
-  - deb-src http://mirrors.wikimedia.org/debian/ jessie-backports main 
contrib non-free
+  - deb http://mirrors.wikimedia.org/debian/ stretch-backports main 
contrib non-free
+  - deb-src http://mirrors.wikimedia.org/debian/ stretch-backports main 
contrib non-free
   trusted-keys:
 - /etc/apt/trusted.gpg
   install_standard: true

-- 
To view, visit https://gerrit.wikimedia.org/r/397920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cbf733d4f14d93ddf909b499fc457bc290675ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to d0ee651

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397924 )

Change subject: Update mobileapps to d0ee651
..

Update mobileapps to d0ee651

List of changes:
d0ee651 Fix definition endpoint 500s
xxx Update node module dependencies

Change-Id: I81c5e60323909df7c3d27cf3a9a0a0ddb327f89f
---
M node_modules/kad/package.json
M node_modules/swagger-ui/package.json
M src
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps/deploy 
refs/changes/24/397924/1

diff --git a/node_modules/kad/package.json b/node_modules/kad/package.json
index 008df1d..6fd2f7b 100644
--- a/node_modules/kad/package.json
+++ b/node_modules/kad/package.json
@@ -49,7 +49,7 @@
 "/limitation"
   ],
   "_resolved": 
"git+https://github.com/gwicke/kad.git#936c91652d757ea6f9dd30e44698afb0daaa1d17;,
-  "_shasum": "1a0b533550ebd56cd7fde69badbae6c7ac5e12a7",
+  "_shasum": "0a1f3ec3192e7e4c49b985e3ebd1e6905d9f2d2d",
   "_shrinkwrap": null,
   "_spec": "kad@git+https://github.com/gwicke/kad.git#master;,
   "_where": "/opt/service/node_modules/limitation",
diff --git a/node_modules/swagger-ui/package.json 
b/node_modules/swagger-ui/package.json
index 3ee47b8..958f485 100644
--- a/node_modules/swagger-ui/package.json
+++ b/node_modules/swagger-ui/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/swagger-ui.git#b9b40dc8e00caeb24c19fe636b93250a7e335541;,
-  "_shasum": "908d5defcbcdd2a871a6060692f55c88104ffb5c",
+  "_shasum": "475d668797333230228ec38595ff831f6520650b",
   "_shrinkwrap": null,
   "_spec": "swagger-ui@git+https://github.com/wikimedia/swagger-ui.git#master;,
   "_where": "/opt/service",
diff --git a/src b/src
index 172abc7..d0ee651 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 172abc7424d0a7042e027506f5f4979553a40a3b
+Subproject commit d0ee65120d6a4b52a232c056508b82001431f432

-- 
To view, visit https://gerrit.wikimedia.org/r/397924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81c5e60323909df7c3d27cf3a9a0a0ddb327f89f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix alignment of the first edit pencil on articles

[Cooltey (Code Review)]

Cooltey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397923 )

Change subject: Fix alignment of the first edit pencil on articles
..

Fix alignment of the first edit pencil on articles

  - Update layout, xml and code to programmtically change the parameter's rules

Bug: T160753
Change-Id: I51c3785b440fce8f336ba5b55a51569ab869638b
---
M app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
M app/src/main/res/layout/view_page_header.xml
M app/src/main/res/values/dimens.xml
3 files changed, 72 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/23/397923/1

diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java 
b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
index a024c16..35f4168 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
@@ -24,9 +24,9 @@
 import android.view.Gravity;
 import android.view.MenuItem;
 import android.view.View;
-import android.widget.FrameLayout;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
+import android.widget.RelativeLayout;
 
 import org.wikipedia.R;
 import org.wikipedia.media.AvPlayer;
@@ -164,16 +164,29 @@
 public void setLocale(@NonNull String locale) {
 titleText.setLocale(locale);
 subtitleText.setLocale(locale);
+
 LinearLayout.LayoutParams dividerParams = (LinearLayout.LayoutParams) 
divider.getLayoutParams();
 dividerParams.gravity = isLangRTL(locale) ? Gravity.RIGHT : 
Gravity.LEFT;
 divider.setLayoutParams(dividerParams);
-FrameLayout.LayoutParams pencilParams = (FrameLayout.LayoutParams) 
editPencil.getLayoutParams();
-pencilParams.gravity = Gravity.BOTTOM | (isLangRTL(locale) ? 
Gravity.LEFT : Gravity.RIGHT);
+
+RelativeLayout.LayoutParams pencilParams = 
(RelativeLayout.LayoutParams) editPencil.getLayoutParams();
+pencilParams.removeRule(isLangRTL(locale) ? 
RelativeLayout.ALIGN_PARENT_END : RelativeLayout.ALIGN_PARENT_START);
+pencilParams.addRule(isLangRTL(locale) ? 
RelativeLayout.ALIGN_PARENT_START : RelativeLayout.ALIGN_PARENT_END);
+pencilParams.addRule(RelativeLayout.ALIGN_START, isLangRTL(locale) ? 
R.dimen.edit_pencil_horizontal_margin : 
R.dimen.edit_pencil_space_between_subtitle);
+pencilParams.addRule(RelativeLayout.ALIGN_END, isLangRTL(locale) ? 
R.dimen.edit_pencil_space_between_subtitle : 
R.dimen.edit_pencil_horizontal_margin);
+editPencil.setLayoutParams(pencilParams);
+
+RelativeLayout.LayoutParams subtitleParams = 
(RelativeLayout.LayoutParams) subtitleText.getLayoutParams();
+subtitleParams.removeRule(isLangRTL(locale) ? RelativeLayout.START_OF 
: RelativeLayout.END_OF);
+subtitleParams.addRule(isLangRTL(locale) ? RelativeLayout.END_OF : 
RelativeLayout.START_OF, editPencil.getId());
+subtitleText.setLayoutParams(subtitleParams);
+
 int subtitlePadding = editPencil.getWidth();
 subtitleText.setPadding(isLangRTL(locale) ? subtitlePadding : 0,
 subtitleText.getPaddingTop(),
 isLangRTL(locale) ? 0 : subtitlePadding,
 subtitleText.getPaddingBottom());
+
 if (TextUtils.isEmpty(subtitle)) {
 subtitleText.setCompoundDrawablesWithIntrinsicBounds(
 isLangRTL(locale) ? 0 : R.drawable.ic_short_text,
diff --git a/app/src/main/res/layout/view_page_header.xml 
b/app/src/main/res/layout/view_page_header.xml
index c712e40..c23c508 100644
--- a/app/src/main/res/layout/view_page_header.xml
+++ b/app/src/main/res/layout/view_page_header.xml
@@ -1,74 +1,72 @@
-http://schemas.android.com/apk/res/android;
 xmlns:app="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
 android:layout_width="match_parent"
-android:layout_height="wrap_content">
+android:layout_height="wrap_content"
+android:orientation="vertical">
 
-
+android:layout_height="wrap_content" />
 
-
+
+
+
 
 
-
-
 
-
-
+
+
 
-
-
-
\ No newline at end of file
+
+
\ No newline at end of file
diff --git a/app/src/main/res/values/dimens.xml 
b/app/src/main/res/values/dimens.xml
index e9641fb..2935093 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -5,8 +5,9 @@
 
 4dp
 
+16dp
 24dp
-24dp
+8dp
 
 8dp
 -8dp

-- 
To view, visit https://gerrit.wikimedia.org/r/397923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51c3785b440fce8f336ba5b55a51569ab869638b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey 

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix definition endpoint 500s

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397921 )

Change subject: Fix definition endpoint 500s
..


Fix definition endpoint 500s

querySelectorAll returns a NodeList and not an Array.  NodeLists don't
have a forEach method. We have to use Array.prototype.call.

Bug: T182715
Change-Id: I84e39215b8135ff88441448bb57cba5c5efaa5ac
---
M lib/parseDefinitionsUsingSectionTags.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/parseDefinitionsUsingSectionTags.js 
b/lib/parseDefinitionsUsingSectionTags.js
index 87bf7f0..1cafda8 100644
--- a/lib/parseDefinitionsUsingSectionTags.js
+++ b/lib/parseDefinitionsUsingSectionTags.js
@@ -85,7 +85,7 @@
 currentDefinition.definition = html.substring(0, 
html.indexOf(' {
+[].forEach.call(examples, (example) => {
 currentDefinition.examples.push(example.innerHTML.trim());
 });
 } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/397921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84e39215b8135ff88441448bb57cba5c5efaa5ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [search] better tuning with language fallbacks for prefix se...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397887 )

Change subject: [search] better tuning with language fallbacks for prefix search
..


[search] better tuning with language fallbacks for prefix search

Tuned to make sure that important items that match the fallback
languages are close to the top.

Bug: T182136
Change-Id: Ic85f9518e81701d59514936d2ba07b675f6de3ee
---
M repo/config/EntityPrefixSearchProfiles.php
M repo/tests/phpunit/data/entitySearch/search_de-ch-en.expected
M repo/tests/phpunit/data/entitySearch/search_de-ch.expected
M repo/tests/phpunit/data/entitySearch/search_de-ch_strict.expected
M repo/tests/phpunit/data/entitySearch/search_en.expected
M repo/tests/phpunit/data/entitySearch/search_en_strict.expected
M repo/tests/phpunit/data/entitySearch/search_id.expected
M repo/tests/phpunit/data/entitySearch/search_par.expected
M repo/tests/phpunit/data/entitySearch/search_prop.expected
M repo/tests/phpunit/data/entitySearch/search_url.expected
M repo/tests/phpunit/data/entitySearch/search_zh-de-ch.expected
M repo/tests/phpunit/data/entitySearch/search_zh.expected
12 files changed, 84 insertions(+), 84 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/config/EntityPrefixSearchProfiles.php 
b/repo/config/EntityPrefixSearchProfiles.php
index 34deca9..be757c3 100644
--- a/repo/config/EntityPrefixSearchProfiles.php
+++ b/repo/config/EntityPrefixSearchProfiles.php
@@ -12,16 +12,16 @@
  * fallback-discount - multiplier for each following fallback
  */
 return [
-   // FIXME: right now these weights are completely arbitrary. We need
-   // to do some work to validate them.
+   // FIXME: manually tuned, next step is to put in place a golden corpus 
of
+   // graded queries and provide metrics to evaluate the quality 
objectively.
'default' => [
'any' => 0.001,
'lang-exact' => 2,
-   'lang-folded' => 1.8,
+   'lang-folded' => 1.6,
'lang-prefix' => 1.1,
-   'fallback-exact' => 1,
-   'fallback-folded' => 0.9,
-   'fallback-prefix' => 0.8,
-   'fallback-discount' => 0.1,
+   'fallback-exact' => 1.9,
+   'fallback-folded' => 1.3,
+   'fallback-prefix' => 0.4,
+   'fallback-discount' => 0.9,
]
 ];
diff --git a/repo/tests/phpunit/data/entitySearch/search_de-ch-en.expected 
b/repo/tests/phpunit/data/entitySearch/search_de-ch-en.expected
index 2c222be..780f300 100644
--- a/repo/tests/phpunit/data/entitySearch/search_de-ch-en.expected
+++ b/repo/tests/phpunit/data/entitySearch/search_de-ch-en.expected
@@ -38,7 +38,7 @@
 
"labels.de-ch.near_match_folded": "Wien"
 }
 },
-"boost": 1.8
+"boost": 1.6
 }
 },
 {
@@ -68,7 +68,7 @@
 
"labels.de.near_match": "Wien"
 }
 },
-"boost": 0.1
+"boost": 1.71
 }
 },
 {
@@ -78,7 +78,7 @@
 
"labels.de.near_match_folded": "Wien"
 }
 },
-"boost": 0.09
+"boost": 1.17
 }
 },
 {
@@ -88,7 +88,7 @@
 
"labels.de.prefix": "Wien"
 }
 },
-"boost": 0.08
+"boost": 0.36
 }
 },
 {
@@ -98,7 +98,7 @@
 
"labels.en.near_match": "Wien"

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[wmf/1.31.0-wmf.12]: Update for Block::setBlocker() requiring a valid user or int...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397916 )

Change subject: Update for Block::setBlocker() requiring a valid user or 
interwiki username
..


Update for Block::setBlocker() requiring a valid user or interwiki username

In prepraration for the upcoming actor table, Block requires the blockers
to either be a local user or an interwiki username.

We can use CentralIdLookup to check whether the blocker on the foreign wiki
is the same as the local wiki, otherwise fallback to an interwiki username
that uses the wiki as a prefix.

Bug: T182344
Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
(cherry picked from commit 4494e49e2c234bc700c38a26dfa49dfa61998cdf)
---
M includes/GlobalBlock.php
1 file changed, 28 insertions(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/GlobalBlock.php b/includes/GlobalBlock.php
index 46f1ded..93cafc9 100644
--- a/includes/GlobalBlock.php
+++ b/includes/GlobalBlock.php
@@ -14,7 +14,7 @@
parent::__construct();
 
$this->error = $error;
-   $this->setBlocker( $block->gb_by );
+   $this->setGlobalBlocker( $block );
}
 
/**
@@ -23,4 +23,31 @@
public function getPermissionsError( IContextSource $context ) {
return $this->error;
}
+
+   /**
+* Block requires that the blocker exist or be an interwiki username, 
so do
+* some validation to figure out what we need to use (T182344)
+*
+* @param stdClass $block DB row from globalblocks table
+*/
+   public function setGlobalBlocker( stdClass $block ) {
+   // If the block was inserted from this wiki, then we know the 
blocker exists
+   if ( $block->gb_by_wiki === wfWikiID() ) {
+   $this->setBlocker( $block->gb_by );
+   return;
+   }
+   $user = User::newFromName( $block->gb_by );
+   // If the blocker is the same user on the foreign wiki and the 
current wiki
+   // then we can use the username
+   $lookup = CentralIdLookup::factory();
+   if ( $user->getId() && $lookup->isAttached( $user )
+   && $lookup->isAttached( $user, $block->gb_by_wiki )
+   ) {
+   $this->setBlocker( $user );
+   return;
+   }
+
+   // They don't exist locally, so we need to use an interwiki 
username
+   $this->setBlocker( "{$block->gb_by_wiki}>{$block->gb_by}" );
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/397916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalBlocking
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix definition endpoint 500s

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397921 )

Change subject: Fix definition endpoint 500s
..

Fix definition endpoint 500s

querySelectorAll returns a NodeList and not an Array.  NodeLists don't
have a forEach method. We have to use Array.prototype.call.

Bug: T182715
Change-Id: I84e39215b8135ff88441448bb57cba5c5efaa5ac
---
M lib/parseDefinitionsUsingSectionTags.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/21/397921/1

diff --git a/lib/parseDefinitionsUsingSectionTags.js 
b/lib/parseDefinitionsUsingSectionTags.js
index 87bf7f0..1cafda8 100644
--- a/lib/parseDefinitionsUsingSectionTags.js
+++ b/lib/parseDefinitionsUsingSectionTags.js
@@ -85,7 +85,7 @@
 currentDefinition.definition = html.substring(0, 
html.indexOf(' {
+[].forEach.call(examples, (example) => {
 currentDefinition.examples.push(example.innerHTML.trim());
 });
 } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/397921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84e39215b8135ff88441448bb57cba5c5efaa5ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[wmf/1.31.0-wmf.11]: Update for Block::setBlocker() requiring a valid user or int...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397917 )

Change subject: Update for Block::setBlocker() requiring a valid user or 
interwiki username
..


Update for Block::setBlocker() requiring a valid user or interwiki username

In prepraration for the upcoming actor table, Block requires the blockers
to either be a local user or an interwiki username.

We can use CentralIdLookup to check whether the blocker on the foreign wiki
is the same as the local wiki, otherwise fallback to an interwiki username
that uses the wiki as a prefix.

Bug: T182344
Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
(cherry picked from commit 4494e49e2c234bc700c38a26dfa49dfa61998cdf)
---
M includes/GlobalBlock.php
1 file changed, 28 insertions(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/GlobalBlock.php b/includes/GlobalBlock.php
index 46f1ded..93cafc9 100644
--- a/includes/GlobalBlock.php
+++ b/includes/GlobalBlock.php
@@ -14,7 +14,7 @@
parent::__construct();
 
$this->error = $error;
-   $this->setBlocker( $block->gb_by );
+   $this->setGlobalBlocker( $block );
}
 
/**
@@ -23,4 +23,31 @@
public function getPermissionsError( IContextSource $context ) {
return $this->error;
}
+
+   /**
+* Block requires that the blocker exist or be an interwiki username, 
so do
+* some validation to figure out what we need to use (T182344)
+*
+* @param stdClass $block DB row from globalblocks table
+*/
+   public function setGlobalBlocker( stdClass $block ) {
+   // If the block was inserted from this wiki, then we know the 
blocker exists
+   if ( $block->gb_by_wiki === wfWikiID() ) {
+   $this->setBlocker( $block->gb_by );
+   return;
+   }
+   $user = User::newFromName( $block->gb_by );
+   // If the blocker is the same user on the foreign wiki and the 
current wiki
+   // then we can use the username
+   $lookup = CentralIdLookup::factory();
+   if ( $user->getId() && $lookup->isAttached( $user )
+   && $lookup->isAttached( $user, $block->gb_by_wiki )
+   ) {
+   $this->setBlocker( $user );
+   return;
+   }
+
+   // They don't exist locally, so we need to use an interwiki 
username
+   $this->setBlocker( "{$block->gb_by_wiki}>{$block->gb_by}" );
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/397917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalBlocking
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] SelectWidget: Remove getRelativeSelectable...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376185 )

Change subject: [BREAKING CHANGE] SelectWidget: Remove getRelativeSelectableItem
..


[BREAKING CHANGE] SelectWidget: Remove getRelativeSelectableItem

Follows-up on I7b556fcae7ac4c4a6508d931d7a5d9ee1e7c59e5

Bug: T76630
Change-Id: I68bd2899cb2a8d6f2ff0dcc167028595a5996c60
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 18 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 32742c4..c115712 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -807,24 +807,6 @@
 };
 
 /**
- * Get an option by its position relative to the specified item (or to the 
start of the option array,
- * if item is `null`). The direction in which to search through the option 
array is specified with a
- * number: -1 for reverse (the default) or 1 for forward. The method will 
return an option, or
- * `null` if there are no options in the array.
- *
- * @deprecated 0.23.1 Use {@link #findRelativeSelectableItem} instead
- * @param {OO.ui.OptionWidget|null} item Item to describe the start position, 
or `null` to start at the beginning of the array.
- * @param {number} direction Direction to move in: -1 to move backward, 1 to 
move forward
- * @param {Function} [filter] Only consider items for which this function 
returns
- *  true. Function takes an OO.ui.OptionWidget and returns a boolean.
- * @return {OO.ui.OptionWidget|null} Item at position, `null` if there are no 
items in the select
- */
-OO.ui.SelectWidget.prototype.getRelativeSelectableItem = function ( item, 
direction, filter ) {
-   OO.ui.warnDeprecation( 'SelectWidget#getRelativeSelectableItem: 
Deprecated function. Use findRelativeSelectableItem instead. See T76630.' );
-   return this.findRelativeSelectableItem( item, direction, filter );
-};
-
-/**
  * Find the next selectable item or `null` if there are no selectable items.
  * Disabled options and menu-section markers and breaks are not selectable.
  *

-- 
To view, visit https://gerrit.wikimedia.org/r/376185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68bd2899cb2a8d6f2ff0dcc167028595a5996c60
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: bootstrapvz: s/jessie/stretch in apt sources

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397920 )

Change subject: bootstrapvz: s/jessie/stretch in apt sources
..

bootstrapvz: s/jessie/stretch in apt sources

Change-Id: I3cbf733d4f14d93ddf909b499fc457bc290675ad
---
M modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/20/397920/1

diff --git a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml 
b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
index 614f0e5..4188877 100644
--- a/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
+++ b/modules/labs_bootstrapvz/files/labs-stretch.manifest.yaml
@@ -26,8 +26,8 @@
   - deb  http://apt.wikimedia.org/wikimedia stretch-wikimedia main
   - deb-src http://apt.wikimedia.org/wikimedia stretch-wikimedia main
 backports:
-  - deb http://mirrors.wikimedia.org/debian/ jessie-backports main contrib 
non-free
-  - deb-src http://mirrors.wikimedia.org/debian/ jessie-backports main 
contrib non-free
+  - deb http://mirrors.wikimedia.org/debian/ stretch-backports main 
contrib non-free
+  - deb-src http://mirrors.wikimedia.org/debian/ stretch-backports main 
contrib non-free
   trusted-keys:
 - /etc/apt/trusted.gpg
   install_standard: true

-- 
To view, visit https://gerrit.wikimedia.org/r/397920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cbf733d4f14d93ddf909b499fc457bc290675ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove client side formatters in Popups code base

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397919 )

Change subject: Remove client side formatters in Popups code base
..

Remove client side formatters in Popups code base

These are now taken care of by the Mobile-Content-Service's
summary  endpoint and no longer needed here!

Change-Id: I2729dc9f172af0afee1c6f0cd563c556b4ae0aeb
---
M resources/dist/index.js
M resources/dist/index.js.json
M src/formatter.js
M src/gateway/restFormatters.js
M tests/node-qunit/formatter.test.js
M tests/node-qunit/gateway/mediawiki.test.js
6 files changed, 3 insertions(+), 94 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/19/397919/1


-- 
To view, visit https://gerrit.wikimedia.org/r/397919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2729dc9f172af0afee1c6f0cd563c556b4ae0aeb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] Remove BookletLayout#getClosestPage

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/375936 )

Change subject: [BREAKING CHANGE] Remove BookletLayout#getClosestPage
..


[BREAKING CHANGE] Remove BookletLayout#getClosestPage

Follows-up on I068dad8c79c4bda6ea37ab6a1eb6ba72ab6f7dc0

Bug: T76630
Change-Id: Ie8895480340811e85db440c213faddbe97202fd8
---
M src/layouts/BookletLayout.js
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/layouts/BookletLayout.js b/src/layouts/BookletLayout.js
index a89b522..4fb4d5b 100644
--- a/src/layouts/BookletLayout.js
+++ b/src/layouts/BookletLayout.js
@@ -342,18 +342,6 @@
 };
 
 /**
- * Get the page closest to the specified page.
- *
- * @deprecated 0.23.0 Use {@link OO.ui.BookletLayout#findClosestPage} instead.
- * @param {OO.ui.PageLayout} page Page to use as a reference point
- * @return {OO.ui.PageLayout|null} Page closest to the specified page
- */
-OO.ui.BookletLayout.prototype.getClosestPage = function ( page ) {
-   OO.ui.warnDeprecation( 'BookletLayout#getClosestPage: Deprecated 
function. Use findClosestPage instead. See T76630.' );
-   return this.findClosestPage( page );
-};
-
-/**
  * Get the outline widget.
  *
  * If the booklet is not outlined, the method will return `null`.

-- 
To view, visit https://gerrit.wikimedia.org/r/375936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8895480340811e85db440c213faddbe97202fd8
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] SelectWidget: Remove getHighlightedItem

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376503 )

Change subject: [BREAKING CHANGE] SelectWidget: Remove getHighlightedItem
..


[BREAKING CHANGE] SelectWidget: Remove getHighlightedItem

Follows-up on I7213476574a62e54e05d4ffa8539b2f881acb214

Bug: T76630
Change-Id: I6c8abad099e299bd40a13e6ce9eba5c6432b939b
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index d3c382b..f1770a4 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -548,17 +548,6 @@
 };
 
 /**
- * Get highlighted item.
- *
- * @deprecated 0.23.1 Use {@link #findHighlightedItem} instead.
- * @return {OO.ui.OptionWidget|null} Highlighted item, `null` if no item is 
highlighted
- */
-OO.ui.SelectWidget.prototype.getHighlightedItem = function () {
-   OO.ui.warnDeprecation( 'SelectWidget#getHighlightedItem: Deprecated 
function. Use findHighlightedItem instead. See T76630.' );
-   return this.findHighlightedItem();
-};
-
-/**
  * Toggle pressed state.
  *
  * Press is a state that occurs when a user mouses down on an item, but

-- 
To view, visit https://gerrit.wikimedia.org/r/376503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c8abad099e299bd40a13e6ce9eba5c6432b939b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Config: Use MCS for summaries in all environments"

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397915 )

Change subject: Revert "Config: Use MCS for summaries in all environments"
..


Revert "Config: Use MCS for summaries in all environments"

This reverts commit 533c24ccd69f741ea3aa2aefec478620172f80b9.

Change-Id: I205b771b37a813559fcdc390c351da4966cfc1b1
---
M scap/environments/beta/vars.yaml
M scap/vars.yaml
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  Ppchelko: Looks good to me, but someone else must approve



diff --git a/scap/environments/beta/vars.yaml b/scap/environments/beta/vars.yaml
index 03d1f93..469ce1b 100644
--- a/scap/environments/beta/vars.yaml
+++ b/scap/environments/beta/vars.yaml
@@ -7,6 +7,7 @@
 cassandra_default_consistency: localOne
 new_storage_enabled_parsoid:
   - '/.*/'
+summary_impl: mcs
 domains:
   BetaCluster:
 aa.wikipedia.beta.wmflabs.org: default_project
diff --git a/scap/vars.yaml b/scap/vars.yaml
index 777cdf0..167257e 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -69,7 +69,7 @@
 domains: /^wikimedia\.org$/
   - name: wikipedia
 domains: /\.wikipedia\.org$/
-summary_impl: mcs
+summary_impl: mwapi
 domains:
   Wikipedia:
 ab.wikipedia.org: default_project

-- 
To view, visit https://gerrit.wikimedia.org/r/397915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I205b771b37a813559fcdc390c351da4966cfc1b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[wmf/1.31.0-wmf.11]: Update for Block::setBlocker() requiring a valid user or int...

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397917 )

Change subject: Update for Block::setBlocker() requiring a valid user or 
interwiki username
..

Update for Block::setBlocker() requiring a valid user or interwiki username

In prepraration for the upcoming actor table, Block requires the blockers
to either be a local user or an interwiki username.

We can use CentralIdLookup to check whether the blocker on the foreign wiki
is the same as the local wiki, otherwise fallback to an interwiki username
that uses the wiki as a prefix.

Bug: T182344
Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
(cherry picked from commit 4494e49e2c234bc700c38a26dfa49dfa61998cdf)
---
M includes/GlobalBlock.php
1 file changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalBlocking 
refs/changes/17/397917/1

diff --git a/includes/GlobalBlock.php b/includes/GlobalBlock.php
index 46f1ded..93cafc9 100644
--- a/includes/GlobalBlock.php
+++ b/includes/GlobalBlock.php
@@ -14,7 +14,7 @@
parent::__construct();
 
$this->error = $error;
-   $this->setBlocker( $block->gb_by );
+   $this->setGlobalBlocker( $block );
}
 
/**
@@ -23,4 +23,31 @@
public function getPermissionsError( IContextSource $context ) {
return $this->error;
}
+
+   /**
+* Block requires that the blocker exist or be an interwiki username, 
so do
+* some validation to figure out what we need to use (T182344)
+*
+* @param stdClass $block DB row from globalblocks table
+*/
+   public function setGlobalBlocker( stdClass $block ) {
+   // If the block was inserted from this wiki, then we know the 
blocker exists
+   if ( $block->gb_by_wiki === wfWikiID() ) {
+   $this->setBlocker( $block->gb_by );
+   return;
+   }
+   $user = User::newFromName( $block->gb_by );
+   // If the blocker is the same user on the foreign wiki and the 
current wiki
+   // then we can use the username
+   $lookup = CentralIdLookup::factory();
+   if ( $user->getId() && $lookup->isAttached( $user )
+   && $lookup->isAttached( $user, $block->gb_by_wiki )
+   ) {
+   $this->setBlocker( $user );
+   return;
+   }
+
+   // They don't exist locally, so we need to use an interwiki 
username
+   $this->setBlocker( "{$block->gb_by_wiki}>{$block->gb_by}" );
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/397917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalBlocking
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalBlocking[wmf/1.31.0-wmf.12]: Update for Block::setBlocker() requiring a valid user or int...

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397916 )

Change subject: Update for Block::setBlocker() requiring a valid user or 
interwiki username
..

Update for Block::setBlocker() requiring a valid user or interwiki username

In prepraration for the upcoming actor table, Block requires the blockers
to either be a local user or an interwiki username.

We can use CentralIdLookup to check whether the blocker on the foreign wiki
is the same as the local wiki, otherwise fallback to an interwiki username
that uses the wiki as a prefix.

Bug: T182344
Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
(cherry picked from commit 4494e49e2c234bc700c38a26dfa49dfa61998cdf)
---
M includes/GlobalBlock.php
1 file changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalBlocking 
refs/changes/16/397916/1

diff --git a/includes/GlobalBlock.php b/includes/GlobalBlock.php
index 46f1ded..93cafc9 100644
--- a/includes/GlobalBlock.php
+++ b/includes/GlobalBlock.php
@@ -14,7 +14,7 @@
parent::__construct();
 
$this->error = $error;
-   $this->setBlocker( $block->gb_by );
+   $this->setGlobalBlocker( $block );
}
 
/**
@@ -23,4 +23,31 @@
public function getPermissionsError( IContextSource $context ) {
return $this->error;
}
+
+   /**
+* Block requires that the blocker exist or be an interwiki username, 
so do
+* some validation to figure out what we need to use (T182344)
+*
+* @param stdClass $block DB row from globalblocks table
+*/
+   public function setGlobalBlocker( stdClass $block ) {
+   // If the block was inserted from this wiki, then we know the 
blocker exists
+   if ( $block->gb_by_wiki === wfWikiID() ) {
+   $this->setBlocker( $block->gb_by );
+   return;
+   }
+   $user = User::newFromName( $block->gb_by );
+   // If the blocker is the same user on the foreign wiki and the 
current wiki
+   // then we can use the username
+   $lookup = CentralIdLookup::factory();
+   if ( $user->getId() && $lookup->isAttached( $user )
+   && $lookup->isAttached( $user, $block->gb_by_wiki )
+   ) {
+   $this->setBlocker( $user );
+   return;
+   }
+
+   // They don't exist locally, so we need to use an interwiki 
username
+   $this->setBlocker( "{$block->gb_by_wiki}>{$block->gb_by}" );
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/397916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3c85fced974a4edabc172bd3ef6a7a255ffa462
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalBlocking
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Config: Use MCS for summaries in all environments"

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397915 )

Change subject: Revert "Config: Use MCS for summaries in all environments"
..

Revert "Config: Use MCS for summaries in all environments"

This reverts commit 533c24ccd69f741ea3aa2aefec478620172f80b9.

Change-Id: I205b771b37a813559fcdc390c351da4966cfc1b1
---
M scap/environments/beta/vars.yaml
M scap/vars.yaml
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/15/397915/1

diff --git a/scap/environments/beta/vars.yaml b/scap/environments/beta/vars.yaml
index 03d1f93..469ce1b 100644
--- a/scap/environments/beta/vars.yaml
+++ b/scap/environments/beta/vars.yaml
@@ -7,6 +7,7 @@
 cassandra_default_consistency: localOne
 new_storage_enabled_parsoid:
   - '/.*/'
+summary_impl: mcs
 domains:
   BetaCluster:
 aa.wikipedia.beta.wmflabs.org: default_project
diff --git a/scap/vars.yaml b/scap/vars.yaml
index 777cdf0..167257e 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -69,7 +69,7 @@
 domains: /^wikimedia\.org$/
   - name: wikipedia
 domains: /\.wikipedia\.org$/
-summary_impl: mcs
+summary_impl: mwapi
 domains:
   Wikipedia:
 ab.wikipedia.org: default_project

-- 
To view, visit https://gerrit.wikimedia.org/r/397915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I205b771b37a813559fcdc390c351da4966cfc1b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits