[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix heading selecting over-select

2017-12-17 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398792 )

Change subject: Fix heading selecting over-select
..

Fix heading selecting over-select

In Chrome, multiple clicking selecting a heading cause a bug that the
first character in the next paragrpah is also selected.

Change-Id: Ib52662c39720dcd36ea0b60c9884530895dd9e6a
---
M resources/src/mediawiki.legacy/shared.css
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/398792/1

diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 9f48204..19b51eb 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -760,11 +760,6 @@
vertical-align: baseline;
/* Reset line-height; headings tend to have it set to larger values */
line-height: 1em;
-   /* As .mw-editsection is a  (inline element), it is treated as 
part */
-   /* of the heading content when selecting text by multiple clicks and 
thus */
-   /* selected together with heading content, despite the user-select: 
none; */
-   /* rule set above. This enforces non-selection without changing the 
look. */
-   display: inline-block;
 }
 
 /* Correct directionality when page dir is different from site/user dir */

-- 
To view, visit https://gerrit.wikimedia.org/r/398792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52662c39720dcd36ea0b60c9884530895dd9e6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix misaligned "More" button

2017-07-19 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366503 )

Change subject: Fix misaligned "More" button
..

Fix misaligned "More" button

"padding-top: 1.375em" is changed to 17px.

Change-Id: Ic4ef86589c6c3d442035f3d768cb9036e1ecc237
---
M components/tabs.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/03/366503/1

diff --git a/components/tabs.less b/components/tabs.less
index a22d260..bf1578d 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -147,7 +147,7 @@
display: block;
font-size: 0.8em;
padding-left: 0.7em;
-   padding-top: 1.375em;
+   padding-top: 17px;
padding-right: 20px;
font-weight: normal;
color: @menu-main-heading-color;

-- 
To view, visit https://gerrit.wikimedia.org/r/366503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4ef86589c6c3d442035f3d768cb9036e1ecc237
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Remove CORS, CSP, proxy codes

2017-07-18 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365924 )

Change subject: Remove CORS, CSP, proxy codes
..

Remove CORS, CSP, proxy codes

These unneeded codes obsfucates the codebase.
They are inherited from service-template-node.

Change-Id: I0a0da60f1c3f55426310190352edb05a7a8c0d31
---
M app.js
M test/features/app/app.js
2 files changed, 0 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/24/365924/1

diff --git a/app.js b/app.js
index f102454..f92ba80 100644
--- a/app.js
+++ b/app.js
@@ -41,25 +41,6 @@
 if(!app.conf.port) { app.conf.port = 10042; }
 if(!app.conf.interface) { app.conf.interface = '0.0.0.0'; }
 if(app.conf.compression_level === undefined) { app.conf.compression_level 
= 3; }
-if(app.conf.cors === undefined) { app.conf.cors = '*'; }
-if(app.conf.csp === undefined) {
-app.conf.csp =
-"default-src 'self'; object-src 'none'; media-src *; img-src *; 
style-src *; frame-ancestors 'self'";
-}
-
-// set outgoing proxy
-if(app.conf.proxy) {
-process.env.HTTP_PROXY = app.conf.proxy;
-// if there is a list of domains which should
-// not be proxied, set it
-if(app.conf.no_proxy_list) {
-if(Array.isArray(app.conf.no_proxy_list)) {
-process.env.NO_PROXY = app.conf.no_proxy_list.join(',');
-} else {
-process.env.NO_PROXY = app.conf.no_proxy_list;
-}
-}
-}
 
 // set up header whitelisting for logging
 if(!app.conf.log_header_whitelist) {
@@ -102,21 +83,7 @@
 app.conf.spec.paths = {};
 }
 
-// set the CORS and CSP headers
 app.all('*', function(req, res, next) {
-if(app.conf.cors !== false) {
-res.header('access-control-allow-origin', app.conf.cors);
-res.header('access-control-allow-headers', 'accept, 
x-requested-with, content-type');
-res.header('access-control-expose-headers', 'etag');
-}
-if(app.conf.csp !== false) {
-res.header('x-xss-protection', '1; mode=block');
-res.header('x-content-type-options', 'nosniff');
-res.header('x-frame-options', 'SAMEORIGIN');
-res.header('content-security-policy', app.conf.csp);
-res.header('x-content-security-policy', app.conf.csp);
-res.header('x-webkit-csp', app.conf.csp);
-}
 sUtil.initAndLogRequest(req, app);
 next();
 });
diff --git a/test/features/app/app.js b/test/features/app/app.js
index ca6174e..49c7252 100644
--- a/test/features/app/app.js
+++ b/test/features/app/app.js
@@ -21,36 +21,4 @@
 });
 });
 
-it('should set CORS headers', function() {
-if(server.config.service.conf.cors === false) {
-return true;
-}
-return preq.get({
-uri: server.config.uri + 'robots.txt'
-}).then(function(res) {
-assert.deepEqual(res.status, 200);
-assert.deepEqual(res.headers['access-control-allow-origin'], '*');
-assert.deepEqual(!!res.headers['access-control-allow-headers'], 
true);
-assert.deepEqual(!!res.headers['access-control-expose-headers'], 
true);
-});
-});
-
-it('should set CSP headers', function() {
-if(server.config.service.conf.csp === false) {
-return true;
-}
-return preq.get({
-uri: server.config.uri + 'robots.txt'
-}).then(function(res) {
-assert.deepEqual(res.status, 200);
-assert.deepEqual(res.headers['x-xss-protection'], '1; mode=block');
-assert.deepEqual(res.headers['x-content-type-options'], 'nosniff');
-assert.deepEqual(res.headers['x-frame-options'], 'SAMEORIGIN');
-assert.deepEqual(res.headers['content-security-policy'], 
'default-src');
-assert.deepEqual(res.headers['x-content-security-policy'], 
'default-src');
-assert.deepEqual(res.headers['x-webkit-csp'], 'default-src');
-});
-});
-
 });
-

-- 
To view, visit https://gerrit.wikimedia.org/r/365924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a0da60f1c3f55426310190352edb05a7a8c0d31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: jshint use es6

2017-07-16 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365540 )

Change subject: jshint use es6
..

jshint use es6

Change-Id: I367575217e45fc03ab230504393d0d4c8ac33797
---
M .jshintrc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/40/365540/1

diff --git a/.jshintrc b/.jshintrc
index 7b9fd7e..9d3785f 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -7,5 +7,6 @@
 "noarg": true,
 "nonew": true,
 "undef": true,
-"node": true
+"node": true,
+"esversion": 6
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/365540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I367575217e45fc03ab230504393d0d4c8ac33797
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Simplify loadRoutes()

2017-07-16 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365539 )

Change subject: Simplify loadRoutes()
..

Simplify loadRoutes()

The previous revision finds existing files in directory ./routes to load routes,
this is replaced by hard coded routes, that is, the convention way, for 
simplicity.
Also the convoluted pattern to mouting router onto app is simplified.

Change-Id: I23c958f96dc065a8d3fb024c16fbb3ae281b7c3e
---
M app.js
M routes/info.js
M routes/mathoid.js
M routes/root.js
4 files changed, 26 insertions(+), 128 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/39/365539/1

diff --git a/app.js b/app.js
index 1bfcc89..f102454 100644
--- a/app.js
+++ b/app.js
@@ -159,47 +159,11 @@
  */
 function loadRoutes (app) {
 
-// get the list of files in routes/
-return fs.readdirAsync(__dirname + '/routes').map(function(fname) {
-return BBPromise.try(function() {
-// ... and then load each route
-// but only if it's a js file
-if(!/\.js$/.test(fname)) {
-return undefined;
-}
-// import the route file
-var route = require(__dirname + '/routes/' + fname);
-return route(app);
-}).then(function(route) {
-if(route === undefined) {
-return undefined;
-}
-// check that the route exports the object we need
-if(route.constructor !== Object || !route.path || !route.router || 
!(route.api_version || route.skip_domain)) {
-throw new TypeError('routes/' + fname + ' does not export the 
correct object!');
-}
-// normalise the path to be used as the mount point
-if(route.path[0] !== '/') {
-route.path = '/' + route.path;
-}
-if(route.path[route.path.length - 1] !== '/') {
-route.path = route.path + '/';
-}
-if(!route.skip_domain) {
-route.path = '/:domain/v' + route.api_version + route.path;
-}
-// wrap the route handlers with Promise.try() blocks
-sUtil.wrapRouteHandlers(route, app);
-// all good, use that route
-app.use(route.path, route.router);
-});
-}).then(function () {
-// catch errors
-sUtil.setErrorHandler(app);
-// route loading is now complete, return the app object
-return BBPromise.resolve(app);
-});
-
+app.use('/', require('./routes/root'));
+app.use('/', require('./routes/mathoid'));
+app.use('/_info', require('./routes/info'));
+sUtil.setErrorHandler(app);
+return BBPromise.resolve(app);
 }
 
 
diff --git a/routes/info.js b/routes/info.js
index 5dd2590..905e904 100644
--- a/routes/info.js
+++ b/routes/info.js
@@ -1,18 +1,7 @@
 'use strict';
 
-
-var sUtil = require('../lib/util');
-
-
-/**
- * The main router object
- */
-var router = sUtil.router();
-
-/**
- * The main application object reported when this module is require()d
- */
-var app;
+var express = require('express');
+var router = express.Router();
 
 
 /**
@@ -23,10 +12,10 @@
 
 // simple sync return
 res.json({
-name: app.info.name,
-version: app.info.version,
-description: app.info.description,
-home: app.info.homepage
+name: req.app.info.name,
+version: req.app.info.version,
+description: req.app.info.description,
+home: req.app.info.homepage
 });
 
 });
@@ -39,7 +28,7 @@
 router.get('/name', function(req, res) {
 
 // simple return
-res.json({ name: app.info.name });
+res.json({ name: req.app.info.name });
 
 });
 
@@ -51,7 +40,7 @@
 router.get('/version', function(req, res) {
 
 // simple return
-res.json({ version: app.info.version });
+res.json({ version: req.app.info.version });
 
 });
 
@@ -63,28 +52,17 @@
  */
 router.all('/home', function(req, res) {
 
-var home = app.info.homepage;
+var home = req.app.info.homepage;
 if(home && /^http/.test(home)) {
 // we have a home page URI defined, so send it
 res.redirect(301, home);
 return;
 } else {
 // no URI defined for the home page, error out
-res.status(404).end('No home page URL defined for ' + app.info.name);
+res.status(404).end('No home page URL defined for ' + 
req.app.info.name);
 }
 
 });
 
 
-module.exports = function(appObj) {
-
-app = appObj;
-
-return {
-path: '/_info',
-skip_domain: true,
-router: router
-};
-
-};
-
+module.exports = router;
diff --git a/routes/mathoid.js b/routes/mathoid.js
index 433c9ce..35ca193 100644
--- a/routes/mathoid.js
+++ b/routes/mathoid.js
@@ -13,17 +13,8 @@
 ]
 });
 
-
-/**
- * The main router object
- */
-var router = sUtil.router();
-
-/**
- *

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Add node version requirement >= 4

2017-07-16 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365513 )

Change subject: Add node version requirement >= 4
..

Add node version requirement >= 4

Added at package.json.

Change-Id: I3eadf9c193de7127db0437a387a6050eed25265a
---
M package.json
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/13/365513/1

diff --git a/package.json b/package.json
index b834376..fb10bbf 100644
--- a/package.json
+++ b/package.json
@@ -63,6 +63,9 @@
 "rewire": "^2.5.1",
 "xmldom": "^0.1.21"
   },
+  "engines": {
+"node": ">=4"
+  },
   "deploy": {
 "node": "6.9.1",
 "target": "debian",

-- 
To view, visit https://gerrit.wikimedia.org/r/365513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eadf9c193de7127db0437a387a6050eed25265a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Remove empty

2017-07-10 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364329 )

Change subject: Remove empty 
..

Remove empty 

Change-Id: I4918d23329a9f70f4c11358d5e1ea7f5c251da46
---
M VectorTemplate.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/29/364329/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 234e015..9b0c80c 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -398,7 +398,7 @@
}
?>

-   
+   

 

@@ -468,7 +468,7 @@
?>" aria-labelledby="p-cactions-label">
msg( 
'vector-more-actions' )
-   ?>
+   ?>
 

>

-- 
To view, visit https://gerrit.wikimedia.org/r/364329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4918d23329a9f70f4c11358d5e1ea7f5c251da46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Drop position:absolute of logo.

2017-07-08 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364028 )

Change subject: Drop position:absolute of logo.
..

Drop position:absolute of logo.

The #mw-panel (sidebar) is at top: 160px
The logo is at top: -160px
This looks hacky so I set it to 0

Bug: T170053
Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
---
M components/navigation.less
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/28/364028/1

diff --git a/components/navigation.less b/components/navigation.less
index a74eda3..ab0ff18 100644
--- a/components/navigation.less
+++ b/components/navigation.less
@@ -60,11 +60,9 @@
 
 /* Logo */
 #p-logo {
-   position: absolute;
-   top: -160px;
-   left: 0;
width: 10em;
height: 160px;
+   padding-bottom: 1em;
 
a {
display: block;
@@ -80,8 +78,7 @@
 div#mw-panel {
font-size: @menu-main-font-size;
position: absolute;
-   top: 160px;
-   padding-top: 1em;
+   top: 0;
width: 10em;
left: 0;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb99ff36e3a9c530c944df2ea0a6c75759045c1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Make Vector look more minimalistic

2017-06-11 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358229 )

Change subject: Make Vector look more minimalistic
..

Make Vector look more minimalistic

Removes button images, break sidebar, head-nav and content with clear border.
Demo can be found on T167582

Change-Id: Ia06e39521044e508ef6caf1ccc30a0ce4debb82a
---
M VectorTemplate.php
M components/common.less
M components/footer.less
M components/navigation.less
M components/personalMenu.less
M components/search.less
M components/tabs.less
M screen-hd.less
M variables.less
9 files changed, 51 insertions(+), 120 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/29/358229/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index bf45341..9e43059 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -94,8 +94,31 @@
// Output HTML Page
$this->html( 'headelement' );
?>
-   
-   
+
+   
+   
+   msg( 'navigation-heading' ) 
?>
+   
+   >
+   renderPortals( 
$this->data['sidebar'] ); ?>
+   
+   
+   
+
+   
+   
+   renderNavigation( 'PERSONAL' ); ?>
+   
+   renderNavigation( [ 
'NAMESPACES', 'VARIANTS' ] ); ?>
+   
+   
+   renderNavigation( [ 
'VIEWS', 'ACTIONS', 'SEARCH' ] ); ?>
+   
+   


 
@@ -172,29 +195,8 @@
?>

html( 'debughtml' ); ?>
-   
-   
-   
-   msg( 'navigation-heading' ) ?>
-
-   
-   renderNavigation( 'PERSONAL' ); ?>
-   
-   renderNavigation( [ 
'NAMESPACES', 'VARIANTS' ] ); ?>
-   
-   
-   renderNavigation( [ 
'VIEWS', 'ACTIONS', 'SEARCH' ] ); ?>


-   
-   >
-   renderPortals( 
$this->data['sidebar'] ); ?>
-   
-   
html( 
'userlangattributes' ) ?>>
getFooterLinks() as $category => 
$links ) {
@@ -234,6 +236,7 @@
?>


+   
printTrail(); ?>
 

diff --git a/components/common.less b/components/common.less
index 0c00963..1be6d4f 100644
--- a/components/common.less
+++ b/components/common.less
@@ -23,9 +23,17 @@
font-family: @content-font-family;
 }
 body {
-   background-color: @menu-background-color;
+   background-color: #ff;
 }
 
+#body-left{
+   position: absolute;
+}
+#body-right{
+   margin-left: 176px;
+   border-left: 1px solid #cacaca;
+   min-height: 100%;
+}
 /* Content */
 .mw-body,
 .parsoid-body {
@@ -36,12 +44,8 @@
 }
 
 .mw-body {
-   margin-left: 10em;
-   /* Border on top, left, and bottom side */
-   border: 1px solid @content-border-color;
-   border-right-width: 0;
-   /* Merge the border with tabs' one (in their background image) */
-   margin-top: -1px;
+   border-top: 1px solid #cacaca;
+   padding: 1.25em 1.5em 1.5em 1.5em;
 
// h1's can exist outside of mw-body-content so some heading styles
// need to be defined in mw-body as well
@@ -70,6 +74,7 @@
.firstHeading {
/* Change the default from mediawiki.skinning CSS to let 
indicators float into heading area */
overflow: visible;
+   border-bottom: 0px;
}
 
.mw-indicators {
diff --git a/components/footer.less b/components/footer.less
index 3d61b66..7bbc167 100644
--- a/components/footer.less
+++ b/components/footer.less
@@ -1,8 +1,6 @@
 /* Footer */
 div#footer {
-   margin-left: 10em;
-   margin-top: 0;
-   padding: 0.75em;
+   padding: 0.75em 0.75em 0.75em 18px;
direction: ltr;
 
ul {
diff --git a/components/navigation.less b/components/navigation.less
index d1ab549..24cd175 100644
--- a/components/navigation.less
+++ b/components/navigation.less
@@ -10,27 +10,11 @@
 }
 
 /* Head */
-#mw-page-base {
-   height: 5em;
-   background-position: bottom left;
-   background-repeat:

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix indents left intentionally by the last commit

2017-06-11 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358230 )

Change subject: Fix indents left intentionally by the last commit
..

Fix indents left intentionally by the last commit

See commit 09becb9
Or T167582

Change-Id: I01d409b02ef1dba36b95548553de2ddc7e21705f
---
M VectorTemplate.php
1 file changed, 98 insertions(+), 98 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/30/358230/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 9e43059..7468c36 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -119,123 +119,123 @@
renderNavigation( [ 
'VIEWS', 'ACTIONS', 'SEARCH' ] ); ?>


-   
-   
+   
+   
 
-   data['sitenotice'] ) {
-   ?>
-   html( 'sitenotice' ) ?>
-   
-   getIndicators();
-   }
-   // Loose comparison with '!=' is intentional, to catch 
null and false too, but not '0'
-   if ( $this->data['title'] != '' ) {
-   ?>
-   html( 'title' )
-   ?>
-   
-   html( 'prebodyhtml' ) ?>
-   
data['isarticle'] ) {
+   if ( $this->data['sitenotice'] ) {
?>
-   msg( 
'tagline' ) ?>
-   
-   html( 
'userlangattributes' ) ?>>html( 'subtitle' )
-   ?>
-   data['undelete'] ) {
-   ?>
-   html( 'undelete' ) ?>
+   html( 'sitenotice' ) ?>

data['newtalk'] ) {
-   ?>
-   html( 'newtalk' ) ?>
-   getIndicators();
}
+   // Loose comparison with '!=' is intentional, 
to catch null and false too, but not '0'
+   if ( $this->data['title'] != '' ) {
?>
-   
-   msg( 'jumpto' ) ?>
-   msg( 'jumptonavigation' )
-   ?>msg( 
'comma-separator' ) ?>
-   msg( 
'jumptosearch' ) ?>
-   
+   html( 'title' )
+   ?>
html( 'bodycontent' );
-
-   if ( $this->data['printfooter'] ) {
+   } ?>
+   html( 'prebodyhtml' ) ?>
+   
+   data['isarticle'] ) {
+   ?>
+   msg( 'tagline' ) ?>
+   
-   
-   html( 
'printfooter' ); ?>
+   html( 
'userlangattributes' ) ?>>html( 'subtitle' )
+   ?>
+   data['undelete'] ) {
+   ?>
+   html( 'undelete' ) ?>
+   
+   data['newtalk'] ) {
+   ?>
+   html( 'newtalk' ) ?>
+   
+   
+   msg( 'jumpto' ) ?>
+   msg( 
'jumptonavigation' )
+   ?>msg( 
'comma-separator' ) ?>
+   msg( 'jumptosearch' ) ?>

-   html( 'bodycontent' );
 
-   if ( $this->data['catlinks'] ) {
-   $this->html( 'catlinks' );
-   }
+   if ( $this->data['printfooter'] ) {
+   ?>
+   
+

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Update readme node version, de-mention phantomjs

2017-06-06 Thread Golopotw (Code Review) 
Golopotw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/357408 )

Change subject: Update readme node version, de-mention phantomjs
..

Update readme node version, de-mention phantomjs

Change-Id: I22464cf194ffc940cb9245a21229151ab002349f
---
M README.md
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/08/357408/1

diff --git a/README.md b/README.md
index 09fb4ec..1fbc5cf 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,13 @@
 
 [![NPM](https://nodei.co/npm/mathoid.png)](https://nodei.co/npm/mathoid/)
 
-Mathoid-server is a service that uses MathJax and PhantomJS to create SVGs and 
MathML on server side.
+Mathoid-server is a service that uses MathJax to create SVGs and MathML on 
server side.
 Mathoid-server is a based on svgtex - https://github.com/agrbin/svgtex.
 
 
 
 ## Installation
-Install node 4.2.3, iojs-v2.5.0 or a compatible node version and npm version 
2.14.7 or similar.
+Install node 6.9.0 or a compatible node version.
 In addition the prerequisites from 
[librsvg](https://www.npmjs.com/package/librsvg#installation) are needed.
 For Debian based systems installing the `librsvg2-dev` should be sufficient.
 ```bash
@@ -19,7 +19,7 @@
 Thereafter, install mathoid by running
 ```bash
 npm install mathoid
-nodejs /node_modules/mathoid/server.js
+node /node_modules/mathoid/server.js
 ```
 To install mathoid as a unix service there is a 
[script](scripts/gen-init-scripts.rb).
 

-- 
To view, visit https://gerrit.wikimedia.org/r/357408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22464cf194ffc940cb9245a21229151ab002349f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Golopotw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits