[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Preferences: Don't show the watchlist token; just link to Re...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392539 )

Change subject: Preferences: Don't show the watchlist token; just link to 
ResetTokens
..

Preferences: Don't show the watchlist token; just link to ResetTokens

Also make both the PasswordReset and ResetTokens forms appropriately
flag their action buttons as destructive.

Bug: T180710
Change-Id: I26649900f9360e5175fa93b87dc7840a7c1d4f93
---
M includes/Preferences.php
M includes/specials/SpecialPasswordReset.php
M includes/specials/SpecialResetTokens.php
M languages/i18n/en.json
M languages/i18n/qqq.json
5 files changed, 16 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/392539/1

diff --git a/includes/Preferences.php b/includes/Preferences.php
index e383f03..924e3ad 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1134,18 +1134,20 @@
$defaultPreferences['watchlisttoken'] = [
'type' => 'api',
];
+
+   $tokenButton = new OOUI\ButtonWidget( [
+   'href' => SpecialPage::getTitleFor( 
'ResetTokens' )->getLinkURL( [
+   'returnto' => SpecialPage::getTitleFor( 
'Preferences' )->getPrefixedText()
+   ] ),
+   'label' => $context->msg( 
'prefs-watchlist-managetokens' )->text(),
+   ] );
$defaultPreferences['watchlisttoken-info'] = [
'type' => 'info',
'section' => 'watchlist/tokenwatchlist',
'label-message' => 'prefs-watchlist-token',
-   'default' => $user->getTokenFromOption( 
'watchlisttoken' ),
-   'help-message' => 'prefs-help-watchlist-token2',
-   ];
-   $defaultPreferences['watchlisttoken-info2'] = [
-   'type' => 'info',
-   'section' => 'watchlist/tokenwatchlist',
+   'help-message' => 'prefs-help-tokenmanagement',
'raw' => true,
-   'default' => $context->msg( 
'prefs-help-watchlist-token2' )->parse(),
+   'default' => (string)$tokenButton,
];
}
}
diff --git a/includes/specials/SpecialPasswordReset.php 
b/includes/specials/SpecialPasswordReset.php
index a4f16bd..bf8dea6 100644
--- a/includes/specials/SpecialPasswordReset.php
+++ b/includes/specials/SpecialPasswordReset.php
@@ -110,6 +110,8 @@
public function alterForm( HTMLForm $form ) {
$resetRoutes = $this->getConfig()->get( 'PasswordResetRoutes' );
 
+   $form->setSubmitDestructive();
+
$form->addHiddenFields( $this->getRequest()->getValues( 
'returnto', 'returntoquery' ) );
 
$i = 0;
diff --git a/includes/specials/SpecialResetTokens.php 
b/includes/specials/SpecialResetTokens.php
index 964a261..d5b0903 100644
--- a/includes/specials/SpecialResetTokens.php
+++ b/includes/specials/SpecialResetTokens.php
@@ -121,6 +121,7 @@
 * @param HTMLForm $form
 */
protected function alterForm( HTMLForm $form ) {
+   $form->setSubmitDestructive();
if ( $this->getTokensList() ) {
$form->setSubmitTextMsg( 'resettokens-resetbutton' );
} else {
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 021a115..261f74b 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1025,6 +1025,7 @@
"prefs-watchlist-edits": "Maximum number of changes to show in 
watchlist:",
"prefs-watchlist-edits-max": "Maximum number: 1000",
"prefs-watchlist-token": "Watchlist token:",
+   "prefs-watchlist-managetokens": "Manage tokens",
"prefs-misc": "Misc",
"prefs-resetpass": "Change password",
"prefs-changeemail": "Change or remove email address",
@@ -1042,7 +1043,7 @@
"recentchangesdays-max": "Maximum $1 {{PLURAL:$1|day|days}}",
"recentchangescount": "Number of edits to show by default:",
"prefs-help-recentchangescount": "This includes recent changes, page 
histories, and logs.",
-   "prefs-help-watchlist-token2": "This is the secret key to the web feed 
of your watchlist.\nAnyone who knows it will be able to read your watchlist, so 
do not share it.\nIf you need to, [[Special:ResetTokens|you can reset it]].",
+   "prefs-help-tokenmanagement": "You can see and reset the secret key for 
your account that can access the Web feed of your watchlist. Anyone who knows 
the key will be able to read your watchlist, so do not share 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (cca896ac3)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391978 )

Change subject: Update VE core submodule to master (cca896ac3)
..

Update VE core submodule to master (cca896ac3)

New changes:
c7ef30a30 Get a ve.ce.BranchNode position's corresponding DOM position
5f9b3f5d1 Localisation updates from https://translatewiki.net.

Change-Id: I3456a20420153b1c31fa39b0541f6b93b7d582ec
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/78/391978/1

diff --git a/lib/ve b/lib/ve
index 7d7966d..cca896a 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 7d7966df9c7135dcb78a24dfc2a81f0dd76da7b5
+Subproject commit cca896ac37fe2b8c9c049542fb1ec9062d158062

-- 
To view, visit https://gerrit.wikimedia.org/r/391978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3456a20420153b1c31fa39b0541f6b93b7d582ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BatchUserRights[master]: build: Add composer phpcs linting and fix up

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391717 )

Change subject: build: Add composer phpcs linting and fix up
..

build: Add composer phpcs linting and fix up

Change-Id: I22f6b5e09701f2892ec8a5c6add44978fe5366aa
---
A .phpcs.xml
M BatchUserRights.php
M BatchUserRights_body.php
M composer.json
4 files changed, 45 insertions(+), 22 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BatchUserRights 
refs/changes/17/391717/1

diff --git a/.phpcs.xml b/.phpcs.xml
new file mode 100644
index 000..ab1462a
--- /dev/null
+++ b/.phpcs.xml
@@ -0,0 +1,20 @@
+
+
+  
+
+
+
+
+
+
+
+  
+  
+
+  
+
+  
+  .
+  
+  
+
diff --git a/BatchUserRights.php b/BatchUserRights.php
index 2779a92..77203e6 100644
--- a/BatchUserRights.php
+++ b/BatchUserRights.php
@@ -14,14 +14,14 @@
 }
 
 // Extension credits that will show up on Special:Version
-$wgExtensionCredits['specialpage'][] = array(
+$wgExtensionCredits['specialpage'][] = [
'path' => __FILE__,
'name' => 'BatchUserRights',
'version' => '1.2.0',
'author' => '[http://www.seancolombo.com Sean Colombo]',
'descriptionmsg' => 'batchuserrights-desc',
'url' => 'https://www.mediawiki.org/wiki/Extension:BatchUserRights',
-);
+];
 
 set_time_limit( 0 );
 // New user right, required to access Special:BatchUserRights
@@ -29,7 +29,7 @@
 $wgGroupPermissions['bureaucrat']['batchuserrights'] = true;
 
 // User groups which can be added through Special:BatchUserRights
-$wgBatchUserRightsGrantableGroups = array();
+$wgBatchUserRightsGrantableGroups = [];
 
 // Set up the new special page
 $wgMessagesDirs['BatchUserRights'] = __DIR__ . '/i18n';
diff --git a/BatchUserRights_body.php b/BatchUserRights_body.php
index ae403e2..08b5efd 100644
--- a/BatchUserRights_body.php
+++ b/BatchUserRights_body.php
@@ -62,7 +62,7 @@
$reason = $request->getVal( 'user-reason' );
$tok = $request->getVal( 'wpEditToken' );
if ( $user->matchEditToken( $tok ) ) {
-   $addgroup = array();
+   $addgroup = [];
foreach ( 
$wgBatchUserRightsGrantableGroups as $group ) {
// This batch form is only for 
adding user groups, we don't remove any.
if ( $request->getCheck( 
"wpGroup-$group" ) ) {
@@ -88,7 +88,7 @@
// Loop through each target user and 
apply the update.
foreach ( $usernames as $username ) {
$username = trim( $username );
-   if( $username !== '' ) {
+   if ( $username !== '' ) {
$out->addHTML( 
$this->msg(

'batchuserrights-single-progress-update',
count( 
$addgroup ),
@@ -132,7 +132,7 @@
 
// Validate input set...
$changeable = $this->changeableGroups();
-   $addable = array_merge( $changeable['add'], $this->isself ? 
$changeable['add-self'] : array() );
+   $addable = array_merge( $changeable['add'], $this->isself ? 
$changeable['add-self'] : [] );
 
$addgroup = array_unique(
array_intersect( (array)$addgroup, $addable )
@@ -155,9 +155,9 @@
wfDebug( 'oldGroups: ' . print_r( $oldGroups, true ) );
wfDebug( 'newGroups: ' . print_r( $newGroups, true ) );
if ( $user instanceof User ) {
-   $removegroup = array();
+   $removegroup = [];
// hmmm
-   Hooks::run( 'UserRights', array( &$user, $addgroup, 
$removegroup ) );
+   Hooks::run( 'UserRights', [ &$user, $addgroup, 
$removegroup ] );
}
 
if ( $newGroups != $oldGroups ) {
@@ -173,10 +173,10 @@
$logEntry->setPerformer( $this->getUser() );
$logEntry->setTarget( $user->getUserPage() );
$logEntry->setComment( $reason );
-   $logEntry->setParameters( array(
+   $logEntry->setParameters( [
'4::oldgroups' => $oldGroups,
'5::newgroups' => $newGroups,
-   ) );
+   ] );
$logid = $logEntry->insert();
$logEntry->publish( $logid );
}
@@ -250,13 +250,13 @@
 */
protected function 

[MediaWiki-commits] [Gerrit] unicodejs[master]: build: Copy non-code distribution files to dist

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391716 )

Change subject: build: Copy non-code distribution files to dist
..

build: Copy non-code distribution files to dist

Change-Id: Ic73f36550ba902ec16423a862a22c0c5dafa9166
---
M Gruntfile.js
M package.json
2 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/16/391716/1

diff --git a/Gruntfile.js b/Gruntfile.js
index f327712..c9aef53 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -7,6 +7,7 @@
 
grunt.loadNpmTasks( 'grunt-contrib-clean' );
grunt.loadNpmTasks( 'grunt-contrib-concat' );
+   grunt.loadNpmTasks( 'grunt-contrib-copy' );
grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-karma' );
grunt.loadTasks( 'build/tasks' );
@@ -15,6 +16,17 @@
pkg: grunt.file.readJSON( 'package.json' ),
clean: {
dist: [ 'dist', 'coverage' ]
+   },
+   copy: {
+   dist: {
+   src: [
+   'AUTHORS.txt',
+   'LICENSE.txt',
+   'History.md',
+   'README.md'
+   ],
+   dest: 'dist/'
+   }
},
concat: {
all: {
@@ -66,7 +78,7 @@
}
} );
 
-   grunt.registerTask( 'build', [ 'clean', 'concat' ] );
+   grunt.registerTask( 'build', [ 'clean', 'concat', 'copy' ] );
grunt.registerTask( 'lint', [ 'eslint' ] );
grunt.registerTask( 'unit', [ 'karma:main' ] );
grunt.registerTask( 'test', [ 'git-build', 'build', 'lint', 'unit' ] );
diff --git a/package.json b/package.json
index 07a88b6..df89597 100644
--- a/package.json
+++ b/package.json
@@ -22,6 +22,7 @@
 "grunt": "1.0.1",
 "grunt-contrib-clean": "1.1.0",
 "grunt-contrib-concat": "1.0.1",
+"grunt-contrib-copy": "1.0.0",
 "grunt-eslint": "20.1.0",
 "grunt-karma": "2.0.0",
 "karma": "1.7.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/391716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic73f36550ba902ec16423a862a22c0c5dafa9166
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up 51d90bd1: Also update README.md

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391713 )

Change subject: Follow-up 51d90bd1: Also update README.md
..

Follow-up 51d90bd1: Also update README.md

Change-Id: Iec6079140cc3696286e9f8c497869102b80f17f7
---
M lib/unicodejs/README.md
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/13/391713/1

diff --git a/lib/unicodejs/README.md b/lib/unicodejs/README.md
index 2a99668..4c99fa6 100644
--- a/lib/unicodejs/README.md
+++ b/lib/unicodejs/README.md
@@ -13,7 +13,7 @@
 npm install unicodejs
 
 
-Or clone the repo, `git clone https://git.wikimedia.org/git/unicodejs.git`.
+Or clone the repo, `git clone https://gerrit.wikimedia.org/r/p/unicodejs.git`.
 
 Versioning
 --
@@ -29,7 +29,7 @@
 Bug tracker
 ---
 
-Found a bug? Please report it in the [issue 
tracker](https://bugzilla.wikimedia.org/enter_bug.cgi?product=Utilities=UnicodeJS)!
+Found a bug? Please report it in the [issue 
tracker](https://phabricator.wikimedia.org/maniphest/task/edit/form/1/?project=Utilities-UnicodeJS)!
 
 Release
 --

-- 
To view, visit https://gerrit.wikimedia.org/r/391713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6079140cc3696286e9f8c497869102b80f17f7
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: [WIP] Convert to static extension loading

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391645 )

Change subject: [WIP] Convert to static extension loading
..

[WIP] Convert to static extension loading

What a mess. Not tested. Almost certainly doesn't work, and some bits
definitely won't.

Bug: T87985
Change-Id: I410a4d499c44a18fb686626775f17187547e74f1
---
D Resources.php
M Translate.php
M TranslateHooks.php
A extension.json
4 files changed, 1,306 insertions(+), 1,248 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/45/391645/1

diff --git a/Resources.php b/Resources.php
deleted file mode 100644
index 66c90e2..000
--- a/Resources.php
+++ /dev/null
@@ -1,581 +0,0 @@
- __DIR__,
-   'remoteExtPath' => 'Translate',
-   'targets' => [ 'desktop', 'mobile' ],
-];
-
-$wgResourceModules['ext.translate'] = [
-   'styles' => 'resources/css/ext.translate.css',
-   'position' => 'top',
-] + $resourcePaths;
-
-$wgResourceModules['ext.translate.base'] = [
-   'scripts' => 'resources/js/ext.translate.base.js',
-   'dependencies' => [
-   'ext.translate.hooks',
-   'mediawiki.api',
-   'mediawiki.util',
-   ],
-   'messages' => [
-   'translate-js-support-unsaved-warning',
-   ],
-] + $resourcePaths;
-
-$wgResourceModules['ext.translate.dropdownmenu'] = [
-   'styles' => 'resources/css/ext.translate.dropdownmenu.css',
-   'scripts' => 'resources/js/ext.translate.dropdownmenu.js',
-] + $resourcePaths;
-
-$wgResourceModules['ext.translate.editor'] = [
-   'scripts' => [
-   'resources/js/ext.translate.editor.helpers.js',
-   'resources/js/ext.translate.editor.js',
-   'resources/js/ext.translate.editor.shortcuts.js',
-   'resources/js/ext.translate.pagemode.js',
-   'resources/js/ext.translate.proofread.js',
-   ],
-   'styles' => [
-   'resources/css/ext.translate.editor.css',
-   'resources/css/ext.translate.pagemode.css',
-   'resources/css/ext.translate.proofread.css',
-   ],
-   'dependencies' => [
-   'ext.translate.base',
-   'ext.translate.dropdownmenu',
-   'ext.translate.hooks',
-   'ext.translate.storage',
-   'jquery.accessKeyLabel',
-   'jquery.autosize',
-   'jquery.makeCollapsible',
-   'jquery.textSelection',
-   'jquery.textchange',
-   'mediawiki.Uri',
-   'mediawiki.api',
-   'mediawiki.api.parse',
-   'mediawiki.jqueryMsg',
-   'mediawiki.language',
-   'mediawiki.user',
-   'mediawiki.util',
-   ],
-   'messages' => [
-   'translate-edit-askpermission',
-   'translate-edit-nopermission',
-   'tux-editor-add-desc',
-   'tux-editor-ask-help',
-   'tux-editor-cancel-button-label',
-   'tux-editor-close-tooltip',
-   'tux-editor-collapse-tooltip',
-   'tux-editor-confirm-button-label',
-   'tux-editor-discard-changes-button-label',
-   'tux-editor-doc-editor-cancel',
-   'tux-editor-doc-editor-placeholder',
-   'tux-editor-doc-editor-save',
-   'tux-editor-edit-desc',
-   'tux-editor-expand-tooltip',
-   'tux-editor-in-other-languages',
-   'tux-editor-loading',
-   'tux-editor-message-desc-less',
-   'tux-editor-message-desc-more',
-   'tux-editor-message-tools-show-editor',
-   'tux-editor-message-tools-delete',
-   'tux-editor-message-tools-history',
-   'tux-editor-message-tools-translations',
-   'tux-editor-n-uses',
-   'tux-editor-need-more-help',
-   'tux-editor-outdated-warning',
-   'tux-editor-outdated-warning-diff-link',
-   'tux-editor-paste-original-button-label',
-   'tux-editor-placeholder',
-   'tux-editor-editsummary-placeholder',
-   'tux-editor-proofread-button-label',
-   'tux-editor-save-button-label',
-   'tux-editor-save-failed',
-   'tux-editor-shortcut-info',
-   'tux-editor-skip-button-label',
-   'tux-editor-suggestions-title',
-   'tux-editor-tm-match',
-   'tux-proofread-action-tooltip',
-   'tux-proofread-edit-label',
-   'tux-proofread-translated-by-self',
-   'tux-session-expired',
-   'tux-status-saving',
-   'tux-status-translated',
-   'tux-status-unsaved',
-   'tux-save-unknown-error',
-   'tux-warnings-hide',
- 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update UnicodeJS to v0.2.0

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391612 )

Change subject: Update UnicodeJS to v0.2.0
..

Update UnicodeJS to v0.2.0

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GUJS/browse/master/History.md;v0.2.0

Change-Id: Ica02f42216d8deb968684f43ccc5a493f4c7a368
---
M lib/unicodejs/unicodejs.js
1 file changed, 61 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/12/391612/1

diff --git a/lib/unicodejs/unicodejs.js b/lib/unicodejs/unicodejs.js
index ef6a8d5..280839a 100644
--- a/lib/unicodejs/unicodejs.js
+++ b/lib/unicodejs/unicodejs.js
@@ -1,12 +1,12 @@
 /*!
- * UnicodeJS v0.1.6
+ * UnicodeJS v0.2.0
  * https://www.mediawiki.org/wiki/UnicodeJS
  *
- * Copyright 2013-2016 UnicodeJS Team and other contributors.
+ * Copyright 2013-2017 UnicodeJS Team and other contributors.
  * Released under the MIT license
  * http://unicodejs.mit-license.org/
  *
- * Date: 2016-12-09T23:38:04Z
+ * Date: 2017-11-15T18:29:34Z
  */
 /*!
  * UnicodeJS namespace
@@ -154,29 +154,28 @@
 
for ( i = 0; i < ranges.length; i++ ) {
range = ranges[ i ];
+
// Handle single code unit
-   if ( typeof range === 'number' && range <= 0x ) {
-   if ( range >= 0xD800 && range <= 0xDFFF ) {
-   throw new Error( 'Surrogate: ' + 
range.toString( 16 ) );
+   if ( typeof range === 'number' ) {
+   if ( range <= 0x ) {
+   if ( range >= 0xD800 && range <= 0xDFFF 
) {
+   throw new Error( 'Surrogate: ' 
+ range.toString( 16 ) );
+   }
+   characterClass.push( uEsc( range ) );
+   continue;
+   } else {
+   // Handle single surrogate pair
+   if ( range > 0x10 ) {
+   throw new Error( 'Character 
code too high: ' + range.toString( 16 ) );
+   }
+   /* eslint-disable no-bitwise */
+   hi = 0xD800 + ( ( range - 0x1 ) >> 
10 );
+   lo = 0xDC00 + ( ( range - 0x1 ) & 
0x3FF );
+   /* eslint-enable no-bitwise */
+
+   disjunction.push( uEsc( hi ) + uEsc( lo 
) );
+   continue;
}
-   if ( range > 0x10 ) {
-   throw new Error( 'Character code too 
high: ' +
-   range.toString( 16 ) );
-   }
-   characterClass.push( uEsc( range ) );
-   continue;
-   }
-
-   // Handle single surrogate pair
-   if ( typeof range === 'number' && range > 0x ) {
-   /* eslint-disable no-bitwise */
-
-   hi = 0xD800 + ( ( range - 0x1 ) >> 10 );
-   lo = 0xDC00 + ( ( range - 0x1 ) & 0x3FF );
-   /* eslint-enable no-bitwise */
-
-   disjunction.push( uEsc( hi ) + uEsc( lo ) );
-   continue;
}
 
// Handle interval
@@ -196,11 +195,11 @@
if ( max <= 0x ) {
// interval is entirely BMP
characterClass.push( codeUnitRange( min, max ) 
);
-   } else if ( min <= 0x && max > 0x ) {
+   } else if ( min <= 0x ) {
// interval is BMP and non-BMP
characterClass.push( codeUnitRange( min, 0x 
) );
boxes = getCodeUnitBoxes( 0x1, max );
-   } else if ( min > 0x ) {
+   } else {
// interval is entirely non-BMP
boxes = getCodeUnitBoxes( min, max );
}
@@ -299,44 +298,31 @@
  * @param {string} text Text
  */
 unicodeJS.TextString = function UnicodeJSTextString( text ) {
-   this.clusters = unicodeJS.graphemebreak.splitClusters( text );
+   this.codepoints = unicodeJS.splitCharacters( text );
 };
 
 /* Methods */
 
 /**
- * Read grapheme cluster 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (d9059cd50)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391137 )

Change subject: Update VE core submodule to master (d9059cd50)
..

Update VE core submodule to master (d9059cd50)

New changes:
b879aeea1 git.wikimedia.org removals
f76f117ed Revert "git.wikimedia.org removals"
8d55f4ac9 Localisation updates from https://translatewiki.net.
c82f7171f Localisation updates from https://translatewiki.net.
d9059cd50 Fix visual diff timeout

Bug: T139089
Bug: T177378
Change-Id: If90a6fee33759be9355d966f9ccd648d2a12003d
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/37/391137/1

diff --git a/lib/ve b/lib/ve
index bf37a87..d9059cd 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit bf37a87d2a16a1514a3829e3e5ff3a3d57244528
+Subproject commit d9059cd5092380649f98a08d6d732ea3dbac4e9f

-- 
To view, visit https://gerrit.wikimedia.org/r/391137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If90a6fee33759be9355d966f9ccd648d2a12003d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Switch submit button from 'save' to 'publish' on dewiki

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391046 )

Change subject: Switch submit button from 'save' to 'publish' on dewiki
..

Switch submit button from 'save' to 'publish' on dewiki

For Monday 20 November 2017.

Change-Id: Ia17c3386285ece2d2a880a976b2fefb4d2408ea0
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/46/391046/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index afff02c..dfbf107 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15315,7 +15315,6 @@
 'wgEditSubmitButtonLabelPublish' => [
'default' => true,  // T131132 from 2017-03-15
'private' => false, // Private wikis are not public
-   'dewiki' => false,  // Temporarily not set
'enwiki' => false,  // Temporarily not set
'wikinews' => false,// Done in local {{int:Copyrightwarning}}s 
instead.
 ],

-- 
To view, visit https://gerrit.wikimedia.org/r/391046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia17c3386285ece2d2a880a976b2fefb4d2408ea0
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RELEASE-NOTES-1.30: Add upgraded, added libraries based on g...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390042 )

Change subject: RELEASE-NOTES-1.30: Add upgraded, added libraries based on git 
history
..

RELEASE-NOTES-1.30: Add upgraded, added libraries based on git history

Change-Id: I4d433f8f75cfe04638adbd60d94346f629cc2f18
---
M RELEASE-NOTES-1.30
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/390042/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index f79ae83..d92c38c 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -80,12 +80,18 @@
 === External library changes in 1.30 ===
 
  Upgraded external libraries 
-* mediawiki/mediawiki-codesniffer updated to 0.8.1.
-* wikimedia/composer-merge-plugin updated to 1.4.1.
+* Updated justinrainbow/json-schema from v3.0 to v5.2.
+* Updated mediawiki/mediawiki-codesniffer from v0.7.2 to v0.12.0.
+* Updated wikimedia/composer-merge-plugin from v1.4.0 to v1.4.1.
+* Updated wikimedia/relpath from v1.0.3 to v2.0.0.
+* Updated OOjs from v2.0.0 to v2.1.0.
+* Updated OOUI from v0.21.1 to v0.23.0.
+* Updated QUnit from v1.23.1 to v2.4.0.
 
  New external libraries 
 * The class \TestingAccessWrapper has been moved to the external library
   wikimedia/testing-access-wrapper and renamed \Wikimedia\TestingAccessWrapper.
+* Purtle, a fast, lightweight RDF generator.
 
  Removed and replaced external libraries 
 * …

-- 
To view, visit https://gerrit.wikimedia.org/r/390042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d433f8f75cfe04638adbd60d94346f629cc2f18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Revert "git.wikimedia.org removals"

[Jforrester (Code Review)]

Hello Chad, jenkins-bot, Siebrand,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/390018

to review the following change.


Change subject: Revert "git.wikimedia.org removals"
..

Revert "git.wikimedia.org removals"

This reverts commit b879aeea1a324847b1b53f5fc04a91055e8692f6.

These are libraries.

Change-Id: Ibe8daf68f3629f8142437d0909dd187449c76c29
---
M lib/jquery.i18n/src/jquery.i18n.emitter.bidi.js
M lib/unicodejs/README.md
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/18/390018/1

diff --git a/lib/jquery.i18n/src/jquery.i18n.emitter.bidi.js 
b/lib/jquery.i18n/src/jquery.i18n.emitter.bidi.js
index 4f03c8f..3a5b625 100644
--- a/lib/jquery.i18n/src/jquery.i18n.emitter.bidi.js
+++ b/lib/jquery.i18n/src/jquery.i18n.emitter.bidi.js
@@ -24,7 +24,7 @@
 * Does not match if there is no strong directionality codepoint.
 *
 * Generated by UnicodeJS (see tools/strongDir) from the UCD; see
-* https://phabricator.wikimedia.org/source/unicodejs/.
+* https://git.wikimedia.org/summary/unicodejs.git .
 */
strongDirRegExp = new RegExp(
'(?:' +
diff --git a/lib/unicodejs/README.md b/lib/unicodejs/README.md
index 8d4a04f..2a99668 100644
--- a/lib/unicodejs/README.md
+++ b/lib/unicodejs/README.md
@@ -13,7 +13,7 @@
 npm install unicodejs
 
 
-Or clone the repo, `git clone https://gerrit.wikimedia.org/r/unicodejs`.
+Or clone the repo, `git clone https://git.wikimedia.org/git/unicodejs.git`.
 
 Versioning
 --

-- 
To view, visit https://gerrit.wikimedia.org/r/390018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe8daf68f3629f8142437d0909dd187449c76c29
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (bf37a87d2)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389901 )

Change subject: Update VE core submodule to master (bf37a87d2)
..

Update VE core submodule to master (bf37a87d2)

New changes:
8c9e847f6 Actually use the CE node while waiting for the DM render
bf37a87d2 Update OOjs UI to v0.24.2

Bug: T179870
Change-Id: I41cefdc9d4cfe741193542b3fa48bdae9e65d525
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/01/389901/1

diff --git a/lib/ve b/lib/ve
index a6b982d..bf37a87 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit a6b982d8a1f7299036aba4820f91ad1f752d38cb
+Subproject commit bf37a87d2a16a1514a3829e3e5ff3a3d57244528

-- 
To view, visit https://gerrit.wikimedia.org/r/389901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41cefdc9d4cfe741193542b3fa48bdae9e65d525
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.24.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389883 )

Change subject: Update OOjs UI to v0.24.2
..

Update OOjs UI to v0.24.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.2

Change-Id: I0e9d3f690349f9f01fb6424f9cb8468ebb21455a
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/README.md
M oojs/oojs-ui/demos/classes/SimpleWidget.css
M oojs/oojs-ui/demos/pages/icons.js
M oojs/oojs-ui/i18n/ka.json
M oojs/oojs-ui/package.json
9 files changed, 150 insertions(+), 137 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/83/389883/1

diff --git a/composer.json b/composer.json
index c199fc7..1a0aaf4 100644
--- a/composer.json
+++ b/composer.json
@@ -82,7 +82,7 @@
"mustangostang/spyc": "0.6.2",
"nikic/php-parser": "3.0.6",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.24.1",
+   "oojs/oojs-ui": "0.24.2",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index 03b9953..87637a3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "6e88396c7cd175ffe4c7797f58573675",
+"content-hash": "47546374fd63a4783d14b8430f4a56ef",
 "packages": [
 {
 "name": "composer/semver",
@@ -1193,16 +1193,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.24.1",
+"version": "v0.24.2",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b"
+"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/460b3700d80073dad91de8391eb7975c9a1ba34b;,
-"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/b6d9d5e50940a7c56d329a605c64d51f147aab80;,
+"reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80",
 "shasum": ""
 },
 "require": {
@@ -1268,7 +1268,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-10-31T22:31:08+00:00"
+"time": "2017-11-07T21:27:09+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 119c36e..838bea6 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2885,87 +2885,6 @@
 "homepage": "https://www.mediawiki.org/wiki/Equivset;
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.24.1",
-"version_normalized": "0.24.1.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/460b3700d80073dad91de8391eb7975c9a1ba34b;,
-"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b",
-"shasum": ""
-},
-"require": {
-"mediawiki/at-ease": "1.1.0",
-"php": ">=5.5.9"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "14.1.0",
-"phpunit/phpunit": "4.8.21"
-},
-"time": "2017-10-31T22:31:08+00:00",
-"type": "library",
-"installation-source": "dist",
-"autoload": {
-"classmap": [
-"php/"
-]
-},
-"notification-url": "https://packagist.org/downloads/;,
-"license": [
-"MIT"
-],
-"authors": [
-{
-"name": "Timo Tijhof",
-"email": "krinklem...@gmail.com"
-},
-{
-"name": "Bartosz Dziewoński",
-"email": "matma@gmail.com"
-},
-{
-"name": "Ed Sanders",
-"email": "esand...@wikimedia.org"
-},
-{
-"name": "James D. Forrester",
-  

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.24.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389884 )

Change subject: Update OOjs UI to v0.24.2
..

Update OOjs UI to v0.24.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.2

Depends-On: I0e9d3f690349f9f01fb6424f9cb8468ebb21455a
Change-Id: I0e9d3f690349f9f01fb6424f9cb8468ebb21455b
---
M composer.json
M resources/lib/oojs-ui/i18n/ka.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/themes/apex/icons-editing-advanced.json
M resources/lib/oojs-ui/themes/wikimediaui/icons-editing-advanced.json
20 files changed, 47 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/389884/1


-- 
To view, visit https://gerrit.wikimedia.org/r/389884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e9d3f690349f9f01fb6424f9cb8468ebb21455b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.24.2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389885 )

Change subject: Update OOjs UI to v0.24.2
..

Update OOjs UI to v0.24.2

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.2

Change-Id: I0809d5f89f886c93b6483c5d66d11f8cc35fd92d
---
M lib/oojs-ui/README.md
M lib/oojs-ui/i18n/ka.json
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.css
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui.css
M lib/oojs-ui/oojs-ui-wikimediaui.js
M lib/oojs-ui/oojs-ui-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
90 files changed, 302 insertions(+), 236 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/85/389885/1


-- 
To view, visit https://gerrit.wikimedia.org/r/389885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (a6b982d8a)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389541 )

Change subject: Update VE core submodule to master (a6b982d8a)
..

Update VE core submodule to master (a6b982d8a)

New changes:
fd01de26b Fix typo/spelling (use en-US)
c7ed230f1 Convert empty doc to empty string in convertToSource
00e344e09 Localisation updates from https://translatewiki.net.
837c20ac8 Unify SVG markup

Change-Id: I9a5f471632ac7f908d877fa312b7e5280b1e6ba4
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/41/389541/1

diff --git a/lib/ve b/lib/ve
index 6741337..a6b982d 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 6741337ffaa180c3099be45d8abccfb3b28e94f8
+Subproject commit a6b982d8a1f7299036aba4820f91ad1f752d38cb

-- 
To view, visit https://gerrit.wikimedia.org/r/389541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a5f471632ac7f908d877fa312b7e5280b1e6ba4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Unify SVG markup

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389536 )

Change subject: Unify SVG markup
..

Unify SVG markup

Align SVG markup across Foundation products by:
- unifying XML declaration,
- removing unnecessary `standalone="no"` attribute as it's default,
- removing all SVG editor metadata,
- removing all `g` group elements except where necessary for transforms,
- putting attributes on `path`,
- removing unnecessary ids, and
- unifying whitespace.

Change-Id: I370e098c0570e017c884bdf75f5d7052f97e1abe
---
M demos/ve/VisualEditor-logo.svg
M demos/ve/VisualEditor-pad-logo.svg
M src/ui/styles/images/icons/table-move-column-ltr.svg
M src/ui/styles/images/icons/table-move-column-rtl.svg
M src/ui/styles/images/icons/table-move-row-after.svg
M src/ui/styles/images/icons/table-move-row-before.svg
M src/ui/styles/images/resize-ne-sw.svg
M src/ui/styles/images/resize-nw-se.svg
8 files changed, 31 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/36/389536/1

diff --git a/demos/ve/VisualEditor-logo.svg b/demos/ve/VisualEditor-logo.svg
index c76de67..6bf31b8 100644
--- a/demos/ve/VisualEditor-logo.svg
+++ b/demos/ve/VisualEditor-logo.svg
@@ -1,4 +1,4 @@
-
+
 
 http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd;>
 http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink; x="0px" y="0px"
diff --git a/demos/ve/VisualEditor-pad-logo.svg 
b/demos/ve/VisualEditor-pad-logo.svg
index d3e780b..0216ade 100644
--- a/demos/ve/VisualEditor-pad-logo.svg
+++ b/demos/ve/VisualEditor-pad-logo.svg
@@ -1,8 +1,8 @@
-
+
 http://www.w3.org/2000/svg; viewBox="72.5 191.5 400 225" 
height="225" width="400" id="Layer_1">
-
-
-
-
-
+   
+   
+   
+   
+   
 
diff --git a/src/ui/styles/images/icons/table-move-column-ltr.svg 
b/src/ui/styles/images/icons/table-move-column-ltr.svg
index 28b9305..444eb29 100644
--- a/src/ui/styles/images/icons/table-move-column-ltr.svg
+++ b/src/ui/styles/images/icons/table-move-column-ltr.svg
@@ -1,6 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
-
+   
+   
+   
 
diff --git a/src/ui/styles/images/icons/table-move-column-rtl.svg 
b/src/ui/styles/images/icons/table-move-column-rtl.svg
index 533a88e..4e567d3 100644
--- a/src/ui/styles/images/icons/table-move-column-rtl.svg
+++ b/src/ui/styles/images/icons/table-move-column-rtl.svg
@@ -1,6 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
-
+   
+   
+   
 
diff --git a/src/ui/styles/images/icons/table-move-row-after.svg 
b/src/ui/styles/images/icons/table-move-row-after.svg
index f98cd12..34be31d 100644
--- a/src/ui/styles/images/icons/table-move-row-after.svg
+++ b/src/ui/styles/images/icons/table-move-row-after.svg
@@ -1,6 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24">
-
-
-
+   
+   
+   
 
diff --git a/src/ui/styles/images/icons/table-move-row-before.svg 
b/src/ui/styles/images/icons/table-move-row-before.svg
index 3d559af..05b8206 100644
--- a/src/ui/styles/images/icons/table-move-row-before.svg
+++ b/src/ui/styles/images/icons/table-move-row-before.svg
@@ -1,6 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="24" height="24" viewBox="0 0 24 
24" id="svg3043">
-
-
-
+   
+   
+   
 
diff --git a/src/ui/styles/images/resize-ne-sw.svg 
b/src/ui/styles/images/resize-ne-sw.svg
index 85533c5..1abbd0f 100644
--- a/src/ui/styles/images/resize-ne-sw.svg
+++ b/src/ui/styles/images/resize-ne-sw.svg
@@ -1,8 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="11" height="11" viewBox="0 0 11 
11">
-
-
-
-
-
+   
+   
+   
 
diff --git a/src/ui/styles/images/resize-nw-se.svg 
b/src/ui/styles/images/resize-nw-se.svg
index d7c5859..839c63c 100644
--- a/src/ui/styles/images/resize-nw-se.svg
+++ b/src/ui/styles/images/resize-nw-se.svg
@@ -1,8 +1,6 @@
-
+
 http://www.w3.org/2000/svg; width="11" height="11" viewBox="0 0 11 
11">
-
-
-
-
-
+   
+   
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/389536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I370e098c0570e017c884bdf75f5d7052f97e1abe
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: MessageIndexRebuildJob::insert: Rename to avoid conflict wit...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388262 )

Change subject: MessageIndexRebuildJob::insert: Rename to avoid conflict with 
parent method
..

MessageIndexRebuildJob::insert: Rename to avoid conflict with parent method

Job::insert is long-deprecated, and though this doesn't call it, causes
confusion.

Change-Id: Ia803b7381fbffcfbfe732b276d6aee42767dbe0b
---
M api/ApiAggregateGroups.php
M tag/SpecialPageTranslationDeletePage.php
M tests/phpunit/MessageIndexRebuildJobTest.php
M utils/MessageIndexRebuildJob.php
4 files changed, 13 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/62/388262/1

diff --git a/api/ApiAggregateGroups.php b/api/ApiAggregateGroups.php
index ebfef5a..33a4e9b 100644
--- a/api/ApiAggregateGroups.php
+++ b/api/ApiAggregateGroups.php
@@ -228,7 +228,7 @@
$this->getResult()->addValue( null, $this->getModuleName(), 
$output );
// Cache needs to be cleared after any changes to groups
MessageGroups::singleton()->recache();
-   MessageIndexRebuildJob::newJob()->insert();
+   MessageIndexRebuildJob::newJob()->insertIntoJoeQueue();
}
 
protected function generateAggregateGroupId( $aggregateGroupName, 
$prefix = 'agg-' ) {
diff --git a/tag/SpecialPageTranslationDeletePage.php 
b/tag/SpecialPageTranslationDeletePage.php
index 55414df..c8c0b09 100644
--- a/tag/SpecialPageTranslationDeletePage.php
+++ b/tag/SpecialPageTranslationDeletePage.php
@@ -397,7 +397,7 @@
 
$this->clearMetadata();
MessageGroups::singleton()->recache();
-   MessageIndexRebuildJob::newJob()->insert();
+   MessageIndexRebuildJob::newJob()->insertIntoJoeQueue();
 
$this->getOutput()->addWikiMsg( 'pt-deletepage-started' );
}
diff --git a/tests/phpunit/MessageIndexRebuildJobTest.php 
b/tests/phpunit/MessageIndexRebuildJobTest.php
index 2a2bd79..4825dd3 100644
--- a/tests/phpunit/MessageIndexRebuildJobTest.php
+++ b/tests/phpunit/MessageIndexRebuildJobTest.php
@@ -37,7 +37,7 @@
public function testInsertImmediate() {
global $wgTranslateDelayedMessageIndexRebuild;
$wgTranslateDelayedMessageIndexRebuild = false;
-   MessageIndexRebuildJob::newJob()->insert();
+   MessageIndexRebuildJob::newJob()->insertIntoJoeQueue();
$this->assertFalse(
JobQueueGroup::singleton()->get( 
'MessageIndexRebuildJob' )->pop(),
'There is no job in the JobQueue'
@@ -47,7 +47,7 @@
public function testInsertDelayed() {
global $wgTranslateDelayedMessageIndexRebuild;
$wgTranslateDelayedMessageIndexRebuild = true;
-   MessageIndexRebuildJob::newJob()->insert();
+   MessageIndexRebuildJob::newJob()->insertIntoJoeQueue();
$job = JobQueueGroup::singleton()->get( 
'MessageIndexRebuildJob' )->pop();
$this->assertInstanceOf(
'MessageIndexRebuildJob',
diff --git a/utils/MessageIndexRebuildJob.php b/utils/MessageIndexRebuildJob.php
index 614ece0..ec97b28 100644
--- a/utils/MessageIndexRebuildJob.php
+++ b/utils/MessageIndexRebuildJob.php
@@ -44,7 +44,7 @@
 * in installations with errant job queue processing.
 * @override
 */
-   public function insert() {
+   public function insertIntoJoeQueue() {
global $wgTranslateDelayedMessageIndexRebuild;
if ( $wgTranslateDelayedMessageIndexRebuild ) {
JobQueueGroup::singleton()->push( $this );
@@ -52,4 +52,12 @@
$this->run();
}
}
+
+   /**
+* @deprecated since 1.31 alias for insertIntoJobQueue()
+*/
+   public function insert() {
+   $this->insertIntoJobQueue();
+   }
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/388262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia803b7381fbffcfbfe732b276d6aee42767dbe0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TranslateSvg[master]: Use JobQueueGroup::singleton()->push() rather than deprecate...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388259 )

Change subject: Use JobQueueGroup::singleton()->push() rather than deprecated 
Job::insert()
..

Use JobQueueGroup::singleton()->push() rather than deprecated Job::insert()

This bumps MediaWiki compatibility up to 1.21.0 if not already there.

Change-Id: I242e5e380c509c620547544b4d8fd4a9578e2dea
---
M SVGMessageGroup.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslateSvg 
refs/changes/59/388259/1

diff --git a/SVGMessageGroup.php b/SVGMessageGroup.php
index 6f276db..820eb4d 100644
--- a/SVGMessageGroup.php
+++ b/SVGMessageGroup.php
@@ -284,7 +284,7 @@
 
MessageGroups::clearCache();
if( $useJobQueue ) {
-   MessageIndexRebuildJob::newJob()->insert();
+   JobQueueGroup::singleton()->push( 
MessageIndexRebuildJob::newJob() );
} else {
MessageIndex::singleton()->rebuild();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/388259
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I242e5e380c509c620547544b4d8fd4a9578e2dea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslateSvg
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Job::insert: Hard deprecate (soft-deprecated in 1.21!)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388223 )

Change subject: Job::insert: Hard deprecate (soft-deprecated in 1.21!)
..

Job::insert: Hard deprecate (soft-deprecated in 1.21!)

Change-Id: I5b653a3dacd6dc73a80b6bbcc282fdd5dad6e49a
---
M includes/jobqueue/Job.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/23/388223/1

diff --git a/includes/jobqueue/Job.php b/includes/jobqueue/Job.php
index 703e485..8508861 100644
--- a/includes/jobqueue/Job.php
+++ b/includes/jobqueue/Job.php
@@ -337,6 +337,7 @@
 * @deprecated since 1.21
 */
public function insert() {
+   wfDeprecated( __METHOD__, '1.21' );
JobQueueGroup::singleton()->push( $this );
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/388223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b653a3dacd6dc73a80b6bbcc282fdd5dad6e49a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: OutputPage: Hard-deprecate setSquidMaxage, renamed since 1.27

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388147 )

Change subject: OutputPage: Hard-deprecate setSquidMaxage, renamed since 1.27
..

OutputPage: Hard-deprecate setSquidMaxage, renamed since 1.27

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Only six uses in Wikimedia-hosted git repositories, marked as
dependencies. Also one use snuck back into MediaWiki itself,
fixed in this patch.

Depends-On: Ie8c13a6b1dc1b7861f6c27bbba996099375f066b
Depends-On: Ic2ea90343efda6533c06ca1325bc85d9aa776078
Depends-On: Ibba2f486f0ecb684ded7efb09f9942f5e0f5fd7a
Depends-On: Id27a48e10fd127e00f68e1020e8f40e30ba9a251
Depends-On: Ifd6db7910a71bb700484d6b588327424f11c00e0
Depends-On: I6523059941eb5f86274e364a8d5cc74b849655a4
Change-Id: I2cdfcd60fc7934830e3e6ec132958aa2aa1fe486
---
M includes/MediaWiki.php
M includes/OutputPage.php
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/47/388147/1

diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index 43de4ba..9e3bc10 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -367,7 +367,7 @@
}
throw new HttpError( 500, $message );
}
-   $output->setSquidMaxage( 1200 );
+   $output->setCdnMaxage( 1200 );
$output->redirect( $targetUrl, '301' );
return true;
}
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 500be8d..4635f99 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1976,6 +1976,7 @@
 * @deprecated since 1.27 Use setCdnMaxage() instead
 */
public function setSquidMaxage( $maxage ) {
+   wfDeprecated( __METHOD__, '1.27' );
$this->setCdnMaxage( $maxage );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/388147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cdfcd60fc7934830e3e6ec132958aa2aa1fe486
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Nostalgia[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388143 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Change-Id: I6523059941eb5f86274e364a8d5cc74b849655a4
---
M Nostalgia_body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Nostalgia 
refs/changes/43/388143/1

diff --git a/Nostalgia_body.php b/Nostalgia_body.php
index 7911f0c..77481cc 100644
--- a/Nostalgia_body.php
+++ b/Nostalgia_body.php
@@ -439,7 +439,7 @@
);
$s[] = '' . wfMessage( 
'youhavenewmessages', $tl, $dl )->text() . '';
# disable caching
-   $wgOut->setSquidMaxage( 0 );
+   $wgOut->setCdnMaxage( 0 );
$wgOut->enableClientCache( false );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/388143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6523059941eb5f86274e364a8d5cc74b849655a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nostalgia
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388141 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Change-Id: Ifd6db7910a71bb700484d6b588327424f11c00e0
---
M classes/Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/41/388141/1

diff --git a/classes/Hooks.php b/classes/Hooks.php
index 6c9c3f1..98cf96d 100644
--- a/classes/Hooks.php
+++ b/classes/Hooks.php
@@ -97,7 +97,7 @@
) {
$s = wfMessage( 'lqt_youhavenewmessages', 
$newmsg_t->getPrefixedText() )->parse();
$tpl->set( "newtalk", $s );
-   $wgOut->setSquidMaxage( 0 );
+   $wgOut->setCdnMaxage( 0 );
} else {
$tpl->set( "newtalk", '' );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/388141
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd6db7910a71bb700484d6b588327424f11c00e0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FundraiserLandingPage[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388140 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Change-Id: Id27a48e10fd127e00f68e1020e8f40e30ba9a251
---
M FundraiserLandingPage.body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FundraiserLandingPage 
refs/changes/40/388140/1

diff --git a/FundraiserLandingPage.body.php b/FundraiserLandingPage.body.php
index 034326f..4be7325 100644
--- a/FundraiserLandingPage.body.php
+++ b/FundraiserLandingPage.body.php
@@ -27,7 +27,7 @@
$request = $this->getRequest();
 
// Set squid age
-   $out->setSquidMaxage( $wgFundraiserLandingPageMaxAge );
+   $out->setCdnMaxage( $wgFundraiserLandingPageMaxAge );
$this->setHeaders();
 
// set the page title to something useful

-- 
To view, visit https://gerrit.wikimedia.org/r/388140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id27a48e10fd127e00f68e1020e8f40e30ba9a251
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FundraiserLandingPage
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GoogleNewsSitemap[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388138 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Change-Id: Ic2ea90343efda6533c06ca1325bc85d9aa776078
---
M GoogleNewsSitemap_body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GoogleNewsSitemap 
refs/changes/38/388138/1

diff --git a/GoogleNewsSitemap_body.php b/GoogleNewsSitemap_body.php
index f5bbf85..de8fe83 100644
--- a/GoogleNewsSitemap_body.php
+++ b/GoogleNewsSitemap_body.php
@@ -79,7 +79,7 @@
Title::newMainPage()->getFullURL()
);
 
-   $this->getOutput()->setSquidMaxage( $wgGNSMsmaxage );
+   $this->getOutput()->setCdnMaxage( $wgGNSMsmaxage );
 
$cacheInvalidationInfo = $this->getCacheInvalidationInfo( 
$params,
$categories, $notCategories );

-- 
To view, visit https://gerrit.wikimedia.org/r/388138
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2ea90343efda6533c06ca1325bc85d9aa776078
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleNewsSitemap
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388137 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Change-Id: Ibba2f486f0ecb684ded7efb09f9942f5e0f5fd7a
---
M includes/specials/SpecialCentralAutoLogin.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/37/388137/1

diff --git a/includes/specials/SpecialCentralAutoLogin.php 
b/includes/specials/SpecialCentralAutoLogin.php
index debcd2f..6b93784 100644
--- a/includes/specials/SpecialCentralAutoLogin.php
+++ b/includes/specials/SpecialCentralAutoLogin.php
@@ -225,7 +225,7 @@
case 'start': // Main entry point
// Note this is safe to cache, because the cache 
already varies on
// the session cookies.
-   $this->getOutput()->setSquidMaxage( 1200 );
+   $this->getOutput()->setCdnMaxage( 1200 );
 
if ( !$this->checkIsLocalWiki() ) {
return;
@@ -244,7 +244,7 @@
case 'checkLoggedIn': // Check if we're logged in centrally
// Note this is safe to cache, because the cache 
already varies on
// the session cookies.
-   $this->getOutput()->setSquidMaxage( 1200 );
+   $this->getOutput()->setCdnMaxage( 1200 );
 
if ( !$this->checkIsCentralWiki( $wikiid ) ) {
return;

-- 
To view, visit https://gerrit.wikimedia.org/r/388137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibba2f486f0ecb684ded7efb09f9942f5e0f5fd7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Replace OutputPage::setSquidMaxage with ::setCdnMaxage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388136 )

Change subject: Replace OutputPage::setSquidMaxage with ::setCdnMaxage
..

Replace OutputPage::setSquidMaxage with ::setCdnMaxage

Renamed and deprecated in MediaWiki in f606fd8d  since 1.27.

Change-Id: Ie8c13a6b1dc1b7861f6c27bbba996099375f066b
---
M includes/CampaignPageFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/36/388136/1

diff --git a/includes/CampaignPageFormatter.php 
b/includes/CampaignPageFormatter.php
index feb4a43..14f5128 100644
--- a/includes/CampaignPageFormatter.php
+++ b/includes/CampaignPageFormatter.php
@@ -47,7 +47,7 @@
$gallery->setHeights( 180 );
$gallery->setShowBytes( false );
 
-   $this->context->getOutput()->setSquidMaxage(
+   $this->context->getOutput()->setCdnMaxage(
UploadWizardConfig::getSetting( 'campaignSquidMaxAge' )
);
$this->context->getOutput()->setHTMLTitle( $this->context->msg( 
'pagetitle', $campaignTitle ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/388136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8c13a6b1dc1b7861f6c27bbba996099375f066b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Rename CDN config variables to be generic, deprecating...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387877 )

Change subject: [WIP] Rename CDN config variables to be generic, deprecating 
the old names
..

[WIP] Rename CDN config variables to be generic, deprecating the old names

Untested. Messy. Not totally sure this is a good idea.

Should https://www.mediawiki.org/wiki/Manual:Squid_caching be renamed too?

Bug: T104148
Change-Id: I7a725dae551c867a4fa7c213838d52c7fb862756
---
M includes/AjaxResponse.php
M includes/Block.php
M includes/DefaultSettings.php
M includes/MediaWiki.php
M includes/OutputPage.php
M includes/ServiceWiring.php
M includes/Setup.php
M includes/actions/RawAction.php
M includes/api/ApiMain.php
M includes/clientpool/SquidPurgeClient.php
M includes/deferred/CdnCacheUpdate.php
M includes/skins/Skin.php
M maintenance/benchmarks/benchmarkPurge.php
M tests/phpunit/includes/WebRequestTest.php
M thumb.php
15 files changed, 157 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/77/387877/1

diff --git a/includes/AjaxResponse.php b/includes/AjaxResponse.php
index 3e42c08..2c18cab 100644
--- a/includes/AjaxResponse.php
+++ b/includes/AjaxResponse.php
@@ -180,12 +180,19 @@
# and tell the client to always check with the CDN. 
Otherwise,
# tell the client to use a cached copy, without a way 
to purge it.
 
-   if ( $this->mConfig->get( 'UseSquid' ) ) {
+   $config = $this->mConfig;
+
+   // Backwards-compatibility reading of old $wgUseSquid 
setting as of MediaWiki 1.31
+   $configUseCdn = $config->has( 'UseSquid' ) ?
+   $config->get( 'UseSquid' ) :
+   $config->get( 'UseCdn' );
+
+   if ( $configUseCdn ) {
# Expect explicit purge of the proxy cache, but 
require end user agents
# to revalidate against the proxy on each visit.
# Surrogate-Control controls our CDN, 
Cache-Control downstream caches
 
-   if ( $this->mConfig->get( 'UseESI' ) ) {
+   if ( $config->get( 'UseESI' ) ) {
header( 'Surrogate-Control: max-age=' . 
$this->mCacheDuration . ', content="ESI/1.0"' );
header( 'Cache-Control: s-maxage=0, 
must-revalidate, max-age=0' );
} else {
diff --git a/includes/Block.php b/includes/Block.php
index d1e78bb..16ce1a6 100644
--- a/includes/Block.php
+++ b/includes/Block.php
@@ -1203,7 +1203,7 @@
if ( !IP::isValid( $ipaddr ) ) {
continue;
}
-   # Don't check trusted IPs (includes local squids which 
will be in every request)
+   # Don't check trusted IPs (includes local CDNs which 
will be in every request)
if ( $proxyLookup->isTrustedProxy( $ipaddr ) ) {
continue;
}
@@ -1264,7 +1264,7 @@
 * @param array $ipChain List of IPs (strings). This is used to 
determine how "close"
 * a block is to the server, and if a block matches exactly, or is 
in a range.
 * The order is furthest from the server to nearest e.g., (Browser, 
proxy1, proxy2,
-* local-squid, ...)
+* local-cdn, ...)
 * @throws MWException
 * @return Block|null The "best" block from the list
 */
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index d9f032c..608edb1 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -2650,7 +2650,8 @@
  * @name   HTTP proxy (CDN) settings
  *
  * Many of these settings apply to any HTTP proxy used in front of MediaWiki,
- * although they are referred to as Squid settings for historical reasons.
+ * although they are sometimes still referred to as Squid settings for
+ * historical reasons.
  *
  * Achieving a high hit ratio with an HTTP proxy requires special
  * configuration. See https://www.mediawiki.org/wiki/Manual:Squid_caching for
@@ -2662,8 +2663,10 @@
 /**
  * Enable/disable CDN.
  * See https://www.mediawiki.org/wiki/Manual:Squid_caching
+ *
+ * @since 1.31 Renamed from $wgUseSquid.
  */
-$wgUseSquid = false;
+$wgUseCdn = false;
 
 /**
  * If you run Squid3 with ESI support, enable this (default:false):
@@ -2673,6 +2676,7 @@
 /**
  * Send the Key HTTP header for better caching.
  * See https://datatracker.ietf.org/doc/draft-fielding-http-key/ for details.
+ *
  * @since 1.27
  */
 $wgUseKeyHeader = false;
@@ -2703,12 +2707,15 @@
  * out s-maxage in the CDN config.
  *
  * 18000 seconds = 5 hours, more cache 

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Get rid of squid.php in favor of new reverse-proxy.php

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387832 )

Change subject: Get rid of squid.php in favor of new reverse-proxy.php
..

Get rid of squid.php in favor of new reverse-proxy.php

Bug: T104148
Change-Id: I3ceac441803cb8d5b18f5172d1590fe32a899a4a
---
D docroot/noc/conf/squid.php.txt
M docroot/noc/createTxtFileSymlinks.sh
M wmf-config/CommonSettings.php
D wmf-config/squid.php
4 files changed, 3 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/32/387832/1

diff --git a/docroot/noc/conf/squid.php.txt b/docroot/noc/conf/squid.php.txt
deleted file mode 12
index 7ffa63b..000
--- a/docroot/noc/conf/squid.php.txt
+++ /dev/null
@@ -1 +0,0 @@
-../../../wmf-config/squid.php
\ No newline at end of file
diff --git a/docroot/noc/createTxtFileSymlinks.sh 
b/docroot/noc/createTxtFileSymlinks.sh
index ef51134..c1f47ed 100755
--- a/docroot/noc/createTxtFileSymlinks.sh
+++ b/docroot/noc/createTxtFileSymlinks.sh
@@ -41,7 +41,6 @@
wgConf.php
reverse-proxy.php
reverse-proxy-staging.php
-   squid.php
session.php
session-labs.php
timeline.php
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 960e48d..27e2e2c 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -20,7 +20,7 @@
 
 use MediaWiki\Logger\LoggerFactory;
 
-# Godforsaken hack to work around problems with the Squid caching changes...
+# Godforsaken hack to work around problems with the reverse proxy caching 
changes...
 #
 # To minimize damage on fatal PHP errors, output a default no-cache header
 # It will be overridden in cases where we actually specify caching behavior.
@@ -574,14 +574,14 @@
$wgSVGConverters['rsvg-wikitech'] = '$path/rsvg-convert -w $width -h 
$height -o $output $input';
 }
 # ##
-# Squid Configuration
+# Reverse proxy Configuration
 # ##
 
 $wgStatsdServer = $wmfLocalServices['statsd'];
 if ( $wmfRealm === 'production' ) {
if ( $wmgUseClusterSquid ) {
$wgUseSquid = true;
-   require "$wmfConfigDir/squid.php";
+   require "$wmfConfigDir/reverse-proxy.php";
}
 } elseif ( $wmfRealm === 'labs' ) {
$wgStatsdMetricPrefix = 'BetaMediaWiki';
diff --git a/wmf-config/squid.php b/wmf-config/squid.php
deleted file mode 100644
index af7033a..000
--- a/wmf-config/squid.php
+++ /dev/null
@@ -1,74 +0,0 @@
- [
-   'host' => '239.128.0.112',
-   'port' => 4827
-   ]
-];
-$wgHTCPMulticastTTL = 8;
-
-# Accept XFF from these proxies
-$wgSquidServersNoPurge = [
-   # Note: the general idea here is to cover infrastructure space
-   # where e.g. Varnish and SSL servers could be located, but exclude
-   # other misc subnets (e.g. labs, analytics).
-
-   ## eqiad
-   '208.80.154.0/26',  # public1-a-eqiad
-   '2620:0:861:1::/64',# public1-a-eqiad
-   '208.80.154.128/26',# public1-b-eqiad
-   '2620:0:861:2::/64',# public1-b-eqiad
-   '208.80.154.64/26', # public1-c-eqiad
-   '2620:0:861:3::/64',# public1-c-eqiad
-   '208.80.155.96/27', # public1-d-eqiad
-   '2620:0:861:4::/64',# public1-d-eqiad
-   '10.64.0.0/22', # private1-a-eqiad
-   '2620:0:861:101::/64',  # private1-a-eqiad
-   '10.64.16.0/22',# private1-b-eqiad
-   '2620:0:861:102::/64',  # private1-b-eqiad
-   '10.64.32.0/22',# private1-c-eqiad
-   '2620:0:861:103::/64',  # private1-c-eqiad
-   '10.64.48.0/22',# private1-d-eqiad
-   '2620:0:861:107::/64',  # private1-d-eqiad
-
-   ## codfw
-   '208.80.153.0/27', # public1-a-codfw
-   '2620:0:860:1::/64', # public1-a-codfw
-   '208.80.153.32/27', # public1-b-codfw
-   '2620:0:860:2::/64', # public1-b-codfw
-   '208.80.153.64/27', # public1-c-codfw
-   '2620:0:860:3::/64', # public1-c-codfw
-   '208.80.153.96/27', # public1-d-codfw
-   '2620:0:860:4::/64', # public1-d-codfw
-   '10.192.0.0/22', # private1-a-codfw
-   '2620:0:860:101::/64', # private1-a-codfw
-   '10.192.16.0/22', # private1-b-codfw
-   '2620:0:860:102::/64', # private1-b-codfw
-   '10.192.32.0/22', # private1-c-codfw
-   '2620:0:860:103::/64', # private1-c-codfw
-   '10.192.48.0/22', # private1-d-codfw
-   '2620:0:860:104::/64', # private1-d-codfw
-
-   ## esams
-   '91.198.174.0/25',  # public1-esams
-   '2620:0:862:1::/64',# public1-esams
-   '10.20.0.0/24', # private1-esams
-   '2620:0:862:102::/64',  # private1-esams
-
-   ## ulsfo
-   '10.128.0.0/24',# private1-ulsfo
-   '2620:0:863:101::/64',  # 

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.24.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387746 )

Change subject: Update OOjs UI to v0.24.1
..

Update OOjs UI to v0.24.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.1

Change-Id: I9ebdc86488c4eda7c524fb6004ea6a124a63d7ab
---
M composer.json
M composer.lock
M composer/installed.json
A oojs/oojs-ui/.phpcs.xml
M oojs/oojs-ui/History.md
M oojs/oojs-ui/README.md
M oojs/oojs-ui/demos/classes/FloatableTest.css
M oojs/oojs-ui/demos/classes/PositionSelectWidget.css
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/i18n/ais.json
M oojs/oojs-ui/i18n/id.json
M oojs/oojs-ui/i18n/skr-arab.json
M oojs/oojs-ui/i18n/ur.json
M oojs/oojs-ui/i18n/zh-hant.json
M oojs/oojs-ui/package.json
15 files changed, 205 insertions(+), 152 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/46/387746/1

diff --git a/composer.json b/composer.json
index d5f8c91..8fcad1d 100644
--- a/composer.json
+++ b/composer.json
@@ -74,7 +74,7 @@
"mustangostang/spyc": "0.6.2",
"nikic/php-parser": "3.0.6",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.24.0",
+   "oojs/oojs-ui": "0.24.1",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index adeccd7..e7d6033 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "dc944fad09b4f0eea8581b87645d7747",
+"content-hash": "547ea39a262b2ce34f2187d8a1a0e107",
 "packages": [
 {
 "name": "composer/semver",
@@ -711,16 +711,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.24.0",
+"version": "v0.24.1",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "702a48a61bc597a4053c19dd4e8767461c71fb12"
+"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/702a48a61bc597a4053c19dd4e8767461c71fb12;,
-"reference": "702a48a61bc597a4053c19dd4e8767461c71fb12",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/460b3700d80073dad91de8391eb7975c9a1ba34b;,
+"reference": "460b3700d80073dad91de8391eb7975c9a1ba34b",
 "shasum": ""
 },
 "require": {
@@ -729,7 +729,7 @@
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.12.0",
+"mediawiki/mediawiki-codesniffer": "14.1.0",
 "phpunit/phpunit": "4.8.21"
 },
 "type": "library",
@@ -786,7 +786,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-10-17T22:42:34+00:00"
+"time": "2017-10-31T22:31:08+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 7e3a274..3e31b83 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2833,18 +2833,70 @@
 ]
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.24.0",
-"version_normalized": "0.24.0.0",
+"name": "wikimedia/equivset",
+"version": "1.0.0",
+"version_normalized": "1.0.0.0",
 "source": {
 "type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "702a48a61bc597a4053c19dd4e8767461c71fb12"
+"url": "https://github.com/wikimedia/Equivset.git;,
+"reference": "70d97de8339da54889a6d7e7ef9d438775cd286b"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/702a48a61bc597a4053c19dd4e8767461c71fb12;,
-"reference": "702a48a61bc597a4053c19dd4e8767461c71fb12",
+"url": 
"https://api.github.com/repos/wikimedia/Equivset/zipball/70d97de8339da54889a6d7e7ef9d438775cd286b;,
+"reference": "70d97de8339da54889a6d7e7ef9d438775cd286b",
+"shasum": ""
+},
+"require": {
+"php": ">=5.5.9",
+"wikimedia/utfnormal": "^1.1.0"
+},
+"require-dev": {
+

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.24.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387745 )

Change subject: Update OOjs UI to v0.24.1
..

Update OOjs UI to v0.24.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.1

Change-Id: I9ebdc86488c4eda7c524fb6004ea6a124a63d7da
---
M lib/oojs-ui/README.md
M lib/oojs-ui/i18n/ais.json
M lib/oojs-ui/i18n/id.json
M lib/oojs-ui/i18n/skr-arab.json
M lib/oojs-ui/i18n/ur.json
M lib/oojs-ui/i18n/zh-hant.json
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.css
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui.css
M lib/oojs-ui/oojs-ui-wikimediaui.js
M lib/oojs-ui/oojs-ui-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
M lib/oojs-ui/themes/apex/images/icons/add.svg
M lib/oojs-ui/themes/apex/images/icons/advanced.svg
M lib/oojs-ui/themes/apex/images/icons/alert.svg
M 

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: build: Organise Gruntfile.js more consistently

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387732 )

Change subject: build: Organise Gruntfile.js more consistently
..

build: Organise Gruntfile.js more consistently

This also adds linting for skinStyles, with a few fixes to make these pass.

Change-Id: Id26b0bad21850d985eaaceda24fa50ad6f886458
---
M Gruntfile.js
M skinStyles/mediawiki.hlist/minerva.less
M skinStyles/mediawiki.special.preferences.styles/styles.less
M skinStyles/mobile.startup/Overlay.less
4 files changed, 28 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/32/387732/1

diff --git a/Gruntfile.js b/Gruntfile.js
index c4352eb..a0f8cd2 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -13,10 +13,10 @@
eslint: {
all: [
'**/*.js',
-   '!libs/**',
-   '!vendor/**',
'!docs/**',
-   '!node_modules/**'
+   '!libs/**',
+   '!node_modules/**',
+   '!vendor/**'
]
},
stylelint: {
@@ -24,17 +24,30 @@
syntax: 'less'
},
all: [
-   'minerva.less/**/*.less',
-   'resources/**/*.less'
+   '**/*.less',
+   '!docs/**',
+   '!libs/**',
+   '!node_modules/**',
+   '!vendor/**'
]
},
+   jsonlint: {
+   all: [
+   '**/*.json',
+   '!docs/**',
+   '!libs/**',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
+   },
+   banana: conf.MessagesDirs,
watch: {
lint: {
-   files: [ 'resources/**/*.js', 
'tests/qunit/**/*.js' ],
+   files: [ 
'{resources,tests/qunit}/**/*.{js,less}' ],
tasks: [ 'lint' ]
},
scripts: {
-   files: [ 'resources/**/*.js', 
'tests/qunit/**/*.js' ],
+   files: [ '{resources,tests/qunit}/**/*.js' ],
tasks: [ 'test' ]
},
configFiles: {
@@ -43,19 +56,10 @@
reload: true
}
}
-   },
-   banana: conf.MessagesDirs,
-   jsonlint: {
-   all: [
-   '*.json',
-   '**/*.json',
-   '!node_modules/**',
-   '!vendor/**'
-   ]
}
} );
 
-   grunt.registerTask( 'lint', [ 'eslint', 'jsonlint', 'banana', 
'stylelint' ] );
+   grunt.registerTask( 'lint', [ 'eslint', 'stylelint', 'jsonlint', 
'banana' ] );
grunt.registerTask( 'test', [ 'lint' ] );
 
grunt.registerTask( 'default', [ 'test' ] );
diff --git a/skinStyles/mediawiki.hlist/minerva.less 
b/skinStyles/mediawiki.hlist/minerva.less
index abe6279..a436568 100644
--- a/skinStyles/mediawiki.hlist/minerva.less
+++ b/skinStyles/mediawiki.hlist/minerva.less
@@ -1,4 +1,4 @@
- @import 'minerva.variables.less';
+@import 'minerva.variables.less';
 
 /**
  * This tweaks the default mediawiki.hlist module to provide performance 
optimisations
@@ -7,7 +7,7 @@
 
 // FIXME: to support hlists on enwiki projects - this should be deprecated
 .hlist > ul,
-.hlist > dl,.hlist > ul,
+.hlist > dl,
 // Horizontal Lists
 //
 // Use hlist class when dealing with lists where items should be horizontal.
diff --git a/skinStyles/mediawiki.special.preferences.styles/styles.less 
b/skinStyles/mediawiki.special.preferences.styles/styles.less
index 2e6814d..7e5599b 100644
--- a/skinStyles/mediawiki.special.preferences.styles/styles.less
+++ b/skinStyles/mediawiki.special.preferences.styles/styles.less
@@ -46,4 +46,4 @@
border: solid 1px @colorFieldBorder;
padding: 8px;
}
-}
\ No newline at end of file
+}
diff --git a/skinStyles/mobile.startup/Overlay.less 
b/skinStyles/mobile.startup/Overlay.less
index c0b123c..3d44a02 100644
--- a/skinStyles/mobile.startup/Overlay.less
+++ b/skinStyles/mobile.startup/Overlay.less
@@ -4,6 +4,10 @@
 .overlay {

[MediaWiki-commits] [Gerrit] integration/config[master]: [MediaViewer] Run jsduck in gate

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387650 )

Change subject: [MediaViewer] Run jsduck in gate
..

[MediaViewer] Run jsduck in gate

Rather than just having the publish task fail.

Repos which are fine:
* MediaWiki
* EventLogging
* Flow
* GuidedTour
* TemplateData

Repos which seem to have the same issue:
* CollaborationKit
* Kartographer
* MobileFrontend
* Wikibase
* MinervaNeue

Change-Id: If9ab1ed4c37d08506202d67ff38ffbc4021ca41f
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/50/387650/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 6b5f829..a490d8a 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3793,6 +3793,7 @@
   - name: extension-unittests-generic
   - name: mwgate-npm
   - name: extension-selenium
+  - name: extension-jsduck
 postmerge:
   - mwext-jsduck-publish
 experimental:

-- 
To view, visit https://gerrit.wikimedia.org/r/387650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ab1ed4c37d08506202d67ff38ffbc4021ca41f
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Follow-up 3e5ad4c8: Fix jsduck for introduction of mw.storage

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387647 )

Change subject: Follow-up 3e5ad4c8: Fix jsduck for introduction of mw.storage
..

Follow-up 3e5ad4c8: Fix jsduck for introduction of mw.storage

Change-Id: I1aebfa88fb6fc567c035cb47f2a71d88e23f2827
---
M jsduck.categories.json
M jsduck.external.js
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/47/387647/1

diff --git a/jsduck.categories.json b/jsduck.categories.json
index bbc3dc7..b994017 100644
--- a/jsduck.categories.json
+++ b/jsduck.categories.json
@@ -87,6 +87,7 @@
"mw.Api",
"mw.Title",
"mw.Map",
+   "mw.storage",
"mw.eventLog"
]
},
diff --git a/jsduck.external.js b/jsduck.external.js
index 8f4e9ae..45c713d 100644
--- a/jsduck.external.js
+++ b/jsduck.external.js
@@ -26,6 +26,11 @@
  */
 
 /**
+ * @class mw.storage
+ * 
+ */
+
+/**
  * @class HTMLElement
  * An HTML element.
  */

-- 
To view, visit https://gerrit.wikimedia.org/r/387647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aebfa88fb6fc567c035cb47f2a71d88e23f2827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Bump stylelint devDependencies

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387597 )

Change subject: build: Bump stylelint devDependencies
..

build: Bump stylelint devDependencies

 stylelint   7.8.0  →  8.2.0
 stylelint-config-wikimedia  0.4.1  →  0.4.2

Change-Id: I322f90c5eeb7d1a235e469f074fd287161533c6e
---
M demos/classes/PositionSelectWidget.css
M package.json
M src/styles/widgets/SelectFileWidget.less
M src/styles/widgets/TextInputWidget.less
M src/themes/apex/widgets.less
M src/themes/wikimediaui/elements.less
M src/themes/wikimediaui/tools.less
M src/themes/wikimediaui/widgets.less
8 files changed, 26 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/97/387597/1

diff --git a/demos/classes/PositionSelectWidget.css 
b/demos/classes/PositionSelectWidget.css
index 7317097..f175df4 100644
--- a/demos/classes/PositionSelectWidget.css
+++ b/demos/classes/PositionSelectWidget.css
@@ -1,31 +1,31 @@
 .demo-positionSelectWidget table {
border-collapse: collapse;
 }
-.demo-positionSelectWidget tr:nth-child(2) td:nth-child(2) {
+.demo-positionSelectWidget tr:nth-child( 2 ) td:nth-child( 2 ) {
border-top: 1px #000 solid;
border-left: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(2) td:nth-child(3) {
+.demo-positionSelectWidget tr:nth-child( 2 ) td:nth-child( 3 ) {
border-top: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(2) td:nth-child(4) {
+.demo-positionSelectWidget tr:nth-child( 2 ) td:nth-child( 4 ) {
border-top: 1px #000 solid;
border-right: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(3) td:nth-child(2) {
+.demo-positionSelectWidget tr:nth-child( 3 ) td:nth-child( 2 ) {
border-left: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(3) td:nth-child(4) {
+.demo-positionSelectWidget tr:nth-child( 3 ) td:nth-child( 4 ) {
border-right: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(4) td:nth-child(2) {
+.demo-positionSelectWidget tr:nth-child( 4 ) td:nth-child( 2 ) {
border-bottom: 1px #000 solid;
border-left: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(4) td:nth-child(3) {
+.demo-positionSelectWidget tr:nth-child( 4 ) td:nth-child( 3 ) {
border-bottom: 1px #000 solid;
 }
-.demo-positionSelectWidget tr:nth-child(4) td:nth-child(4) {
+.demo-positionSelectWidget tr:nth-child( 4 ) td:nth-child( 4 ) {
border-bottom: 1px #000 solid;
border-right: 1px #000 solid;
 }
diff --git a/package.json b/package.json
index 66afc31..8033e37 100644
--- a/package.json
+++ b/package.json
@@ -60,7 +60,7 @@
 "prismjs": "1.8.3",
 "q": "1.5.1",
 "qunitjs": "2.4.1",
-"stylelint": "7.8.0",
-"stylelint-config-wikimedia": "0.4.1"
+"stylelint": "8.2.0",
+"stylelint-config-wikimedia": "0.4.2"
   }
 }
diff --git a/src/styles/widgets/SelectFileWidget.less 
b/src/styles/widgets/SelectFileWidget.less
index 39bf52f..7c4b1f4 100644
--- a/src/styles/widgets/SelectFileWidget.less
+++ b/src/styles/widgets/SelectFileWidget.less
@@ -11,7 +11,7 @@
position: relative;
overflow: hidden;
 
-   > [type='file'] {
+   > [ type='file' ] {
position: absolute;
top: 0;
bottom: 0;
@@ -28,7 +28,7 @@
}
 
&.oo-ui-widget-disabled {
-   > .oo-ui-buttonElement-button > [type='file'] {
+   > .oo-ui-buttonElement-button > [ type='file' ] {
display: none;
}
}
diff --git a/src/styles/widgets/TextInputWidget.less 
b/src/styles/widgets/TextInputWidget.less
index 68760ba..30f194e 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -20,7 +20,7 @@
 
// Normalize styling of `` by removing
// proprietary vendor UI extensions
-   [type='number'] {
+   [ type='number' ] {
-moz-appearance: textfield;
 
&::-webkit-outer-spin-button,
@@ -32,7 +32,7 @@
 
// Normalize styling of `` and
// remove proprietary vendor UI extensions
-   [type='search'] {
+   [ type='search' ] {
-webkit-appearance: none; // Support: Safari/iOS `none` needed, 
Chrome would accept `textfield` as well
 
// Support: IE 10-11, Edge 12+
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 61b8519..63b8c07 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -1336,8 +1336,8 @@
box-shadow: @box-shadow-widget--focus;
}
 
-   input[readonly],
-   textarea[readonly] {
+ 

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: FlaggablePageView::changeSaveButton: Use OOUI methods to ove...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387348 )

Change subject: FlaggablePageView::changeSaveButton: Use OOUI methods to 
over-write
..

FlaggablePageView::changeSaveButton: Use OOUI methods to over-write

This also drops the dependency on the 'dom' PHP extension, in return
for increasing the MediaWiki dependency to 1.29+ (default config) or
1.30+ if you account for people using the old config removed then.

Bug: T179326
Change-Id: Ieb2cd46b9709c80263c27d845001fe14cca4
---
M frontend/FlaggablePageView.php
1 file changed, 6 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/48/387348/1

diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 32b6cc3..7faebad 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1901,25 +1901,17 @@
if ( !$this->editWillRequireReview( $editPage ) ) {
return true; // edit will go live or be reviewed on save
}
-   if ( extension_loaded( 'domxml' ) ) {
-   wfDebug(
-   "Warning: you have the obsolete domxml 
extension for PHP. Please remove it!\n"
-   );
-   return true; # PECL extension conflicts with the core 
DOM extension (see bug 13770)
-   } elseif ( isset( $buttons['save'] ) && extension_loaded( 'dom' 
) ) {
-   $dom = new DOMDocument();
-   $dom->loadXML( $buttons['save'] ); // load button XML 
from hook
-   foreach ( $dom->getElementsByTagName( 'input' ) as 
$input ) { // one 
+   if ( isset( $buttons['save'] ) ) {
+   // This relies on MediaWiki 1.29+ as these are OOUI 
ButtonInputWidgets:
+   if ( is_a( $buttons['save'], 'ButtonInputWidget' ) ) {
$buttonLabel = $this->msg( 
'revreview-submitedit' )->text();
-   $input->setAttribute( 'value', $buttonLabel );
+   $buttons['save']->setLabel( $buttonLabel );
+
// This attempts to re-implement 
Linker::titleAttrib();
// TODO, consider a re-use pattern
$buttonTitle = $this->msg( 
'revreview-submitedit-title' )->text() . ' ' .
$this->msg( 'brackets', $this->msg( 
'accesskey-save' )->text() )->text();
-   $input->setAttribute( 'title', $buttonTitle ); 
// keep accesskey
-
-   # Change submit button text & title
-   $buttons['save'] = $dom->saveXML( 
$dom->documentElement );
+   $buttons['save']->setTitle( $buttonTitle );
}
}
return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/387348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb2cd46b9709c80263c27d845001fe14cca4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (8d1c0d026)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386762 )

Change subject: Update VE core submodule to master (8d1c0d026)
..

Update VE core submodule to master (8d1c0d026)

New changes:
8581e9d86 LinearEnterKeyDownHandler: Enter behavior in nested lists
a91e77764 build: Put karma coverage reports in the top-level directory
81a88b4f1 build: Replace JSON code coverage report with clover.xml one

Bug: T108595
Change-Id: Ic5d83417d64126d9a27d46504fc8fcd338cd7f21
---
M Gruntfile.js
M lib/ve
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/62/386762/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 24774b2..3c66db3 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -116,6 +116,7 @@
},
src: [
'**/*.{js,json,less,css,txt}',
+   '!package-lock.json',
'!build/typos.json',
'!lib/**',
'!{docs,node_modules,vendor}/**',
diff --git a/lib/ve b/lib/ve
index 9b32da8..8d1c0d0 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 9b32da86d99a3e4e7a56640aa8669d2c47072d50
+Subproject commit 8d1c0d0260a313292016665b947b9bc5f365fb6d

-- 
To view, visit https://gerrit.wikimedia.org/r/386762
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5d83417d64126d9a27d46504fc8fcd338cd7f21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: build: Bump stylelint devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386760 )

Change subject: build: Bump stylelint devDependencies to latest
..

build: Bump stylelint devDependencies to latest

 grunt-stylelint 0.8.0  →  0.9.0
 stylelint   7.8.0  →  8.2.0
 stylelint-config-wikimedia  0.4.1  →  0.4.2

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695b
---
M .stylelintrc.json
M package.json
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/60/386760/1

diff --git a/.stylelintrc.json b/.stylelintrc.json
index 501742f..cdb8adf 100644
--- a/.stylelintrc.json
+++ b/.stylelintrc.json
@@ -6,7 +6,7 @@
"background-size"
],
"selector-list-comma-newline-after": null,
-   "selector-no-id": null,
+   "selector-max-id": null,
"value-keyword-case": null
}
 }
diff --git a/package.json b/package.json
index 9e6b276..66f3eb2 100644
--- a/package.json
+++ b/package.json
@@ -16,8 +16,8 @@
"grunt-eslint": "20.1.0",
"grunt-jsonlint": "1.1.0",
"grunt-notify": "0.4.5",
-   "grunt-stylelint": "0.8.0",
-   "stylelint": "7.8.0",
-   "stylelint-config-wikimedia": "0.4.1"
+   "grunt-stylelint": "0.9.0",
+   "stylelint": "8.2.0",
+   "stylelint-config-wikimedia": "0.4.2"
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/386760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: build: Bump run-time dependencies to latest, pin

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386761 )

Change subject: build: Bump run-time dependencies to latest, pin
..

build: Bump run-time dependencies to latest, pin

 jsdoc3.4.2  →  3.5.5
 svgo   >=0.4.4  →  0.7.2

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695c
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/61/386761/1

diff --git a/package.json b/package.json
index 66f3eb2..2f1b8af 100644
--- a/package.json
+++ b/package.json
@@ -5,8 +5,8 @@
"doc": "jsduck"
},
"dependencies": {
-   "jsdoc": "3.4.2",
-   "svgo": ">=0.4.4"
+   "jsdoc": "3.5.5",
+   "svgo": "0.7.2"
},
"devDependencies": {
"eslint-config-wikimedia": "0.5.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/386761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: build: Bump various devDependencies to latest, pin consistently

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386759 )

Change subject: build: Bump various devDependencies to latest, pin consistently
..

build: Bump various devDependencies to latest, pin consistently

 grunt  ^1.0.1  →  1.0.1
 grunt-banana-checker   ^0.5.0  →  0.6.0
 grunt-contrib-watch^1.0.0  →  1.0.0
 grunt-eslint   20.0.0  → 20.1.0
 grunt-jsonlint ^1.1.0  →  1.1.0
 grunt-notify   ^0.4.5  →  0.4.5

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695a
---
M package.json
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/59/386759/1

diff --git a/package.json b/package.json
index 0ebdab7..9e6b276 100644
--- a/package.json
+++ b/package.json
@@ -10,12 +10,12 @@
},
"devDependencies": {
"eslint-config-wikimedia": "0.5.0",
-   "grunt": "^1.0.1",
-   "grunt-banana-checker": "^0.5.0",
-   "grunt-contrib-watch": "^1.0.0",
-   "grunt-eslint": "20.0.0",
-   "grunt-jsonlint": "^1.1.0",
-   "grunt-notify": "^0.4.5",
+   "grunt": "1.0.1",
+   "grunt-banana-checker": "0.6.0",
+   "grunt-contrib-watch": "1.0.0",
+   "grunt-eslint": "20.1.0",
+   "grunt-jsonlint": "1.1.0",
+   "grunt-notify": "0.4.5",
"grunt-stylelint": "0.8.0",
"stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"

-- 
To view, visit https://gerrit.wikimedia.org/r/386759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move Beta Features screenshots into modules

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386739 )

Change subject: Move Beta Features screenshots into modules
..

Move Beta Features screenshots into modules

Change-Id: I6b46f334d226a3e061a3534fd2982397b66e2c6f
---
M VisualEditor.hooks.php
R modules/ve-wmf/betafeatures-icon-VisualEditor-ltr.svg
R modules/ve-wmf/betafeatures-icon-VisualEditor-rtl.svg
R modules/ve-wmf/betafeatures-icon-WikitextEditor-ltr.svg
R modules/ve-wmf/betafeatures-icon-WikitextEditor-rtl.svg
5 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/39/386739/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 3fcc30f..9a86a01 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -686,7 +686,7 @@
 
public static function onGetBetaPreferences( User $user, array 
&$preferences ) {
$coreConfig = RequestContext::getMain()->getConfig();
-   $iconpath = $coreConfig->get( 'ExtensionAssetsPath' ) . 
"/VisualEditor";
+   $iconpath = $coreConfig->get( 'ExtensionAssetsPath' ) . 
"/VisualEditor/modules/ve-wmf";
 
$veConfig = ConfigFactory::getDefaultInstance()->makeConfig( 
'visualeditor' );
$preferences['visualeditor-enable'] = [
diff --git a/betafeatures-icon-VisualEditor-ltr.svg 
b/modules/ve-wmf/betafeatures-icon-VisualEditor-ltr.svg
similarity index 100%
rename from betafeatures-icon-VisualEditor-ltr.svg
rename to modules/ve-wmf/betafeatures-icon-VisualEditor-ltr.svg
diff --git a/betafeatures-icon-VisualEditor-rtl.svg 
b/modules/ve-wmf/betafeatures-icon-VisualEditor-rtl.svg
similarity index 100%
rename from betafeatures-icon-VisualEditor-rtl.svg
rename to modules/ve-wmf/betafeatures-icon-VisualEditor-rtl.svg
diff --git a/betafeatures-icon-WikitextEditor-ltr.svg 
b/modules/ve-wmf/betafeatures-icon-WikitextEditor-ltr.svg
similarity index 100%
rename from betafeatures-icon-WikitextEditor-ltr.svg
rename to modules/ve-wmf/betafeatures-icon-WikitextEditor-ltr.svg
diff --git a/betafeatures-icon-WikitextEditor-rtl.svg 
b/modules/ve-wmf/betafeatures-icon-WikitextEditor-rtl.svg
similarity index 100%
rename from betafeatures-icon-WikitextEditor-rtl.svg
rename to modules/ve-wmf/betafeatures-icon-WikitextEditor-rtl.svg

-- 
To view, visit https://gerrit.wikimedia.org/r/386739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b46f334d226a3e061a3534fd2982397b66e2c6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Upgrade stylelint and related devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386726 )

Change subject: build: Upgrade stylelint and related devDependencies to latest
..

build: Upgrade stylelint and related devDependencies to latest

Change-Id: I4c47f1d290802705d061167fe369c130405512e0
---
M .stylelintrc.json
M package.json
M resources/src/mediawiki.action/mediawiki.action.history.css
M resources/src/mediawiki.legacy/commonPrint.css
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.less/mediawiki.ui/mixins.less
M resources/src/mediawiki.rcfilters/styles/mw.rcfilters.mixins.less
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ChangesListWrapperWidget.highlightCircles.seenunseen.less
M resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.TagItemWidget.less
M resources/src/mediawiki.skinning/content.externallinks.css
M resources/src/mediawiki.skinning/content.parsoid.less
M resources/src/mediawiki.skinning/elements.css
M resources/src/mediawiki.special/mediawiki.special.comparepages.styles.less
M resources/src/mediawiki.ui/components/checkbox.less
M resources/src/mediawiki.ui/components/forms.less
M resources/src/mediawiki.ui/components/inputs.less
M resources/src/mediawiki.ui/components/radio.less
17 files changed, 79 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/26/386726/1

diff --git a/.stylelintrc.json b/.stylelintrc.json
index 27e289d..a6b858c 100644
--- a/.stylelintrc.json
+++ b/.stylelintrc.json
@@ -2,7 +2,6 @@
"extends": "stylelint-config-wikimedia",
"rules": {
"no-descending-specificity": null,
-
-   "selector-no-id": null
+   "selector-max-id": null
}
 }
diff --git a/package.json b/package.json
index 58f48e4..faca87d 100644
--- a/package.json
+++ b/package.json
@@ -17,7 +17,7 @@
 "grunt-eslint": "20.1.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
-"grunt-stylelint": "0.8.0",
+"grunt-stylelint": "0.9.0",
 "grunt-webdriver": "2.0.3",
 "karma": "1.7.1",
 "karma-chrome-launcher": "2.2.0",
@@ -26,8 +26,8 @@
 "karma-qunit": "1.2.1",
 "nodemw": "0.11.0",
 "qunitjs": "2.4.1",
-"stylelint": "7.8.0",
-"stylelint-config-wikimedia": "0.4.1",
+"stylelint": "8.2.0",
+"stylelint-config-wikimedia": "0.4.2",
 "wdio-junit-reporter": "0.2.0",
 "wdio-mocha-framework": "0.5.8",
 "wdio-sauce-service": "^0.3.1",
diff --git a/resources/src/mediawiki.action/mediawiki.action.history.css 
b/resources/src/mediawiki.action/mediawiki.action.history.css
index f3ea163..3c95be9 100644
--- a/resources/src/mediawiki.action/mediawiki.action.history.css
+++ b/resources/src/mediawiki.action/mediawiki.action.history.css
@@ -1,6 +1,6 @@
 /* Styles for the JavaScript enhancements of the history page */
 
 #pagehistory li.before input[name='oldid'],
-#pagehistory li.after input[name='diff'] {
+   #pagehistory li.after input[name='diff'] {
visibility: hidden;
 }
diff --git a/resources/src/mediawiki.legacy/commonPrint.css 
b/resources/src/mediawiki.legacy/commonPrint.css
index 8ff0634..4dd794b 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -78,7 +78,7 @@
 
 /* Expand protocol-relative URLs for printing */
 .mw-body-content a.external.text[href^='//']:after,
-.mw-body-content a.external.autonumber[href^='//']:after {
+   .mw-body-content a.external.autonumber[href^='//']:after {
content: ' (https:' attr( href ) ')';
 }
 
diff --git a/resources/src/mediawiki.legacy/shared.css 
b/resources/src/mediawiki.legacy/shared.css
index 74233d6..ecdfb61 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -56,36 +56,36 @@
 
 /* Input types that should follow user direction, like buttons */
 /* TODO: What about buttons in wikipage content ? */
-input[type='submit'],
-input[type='button'],
-input[type='reset'],
-input[type='file'] {
+input[ type='submit' ],
+input[ type='button' ],
+input[ type='reset' ],
+input[ type='file' ] {
direction: ltr;
 }
 
 /* Override default values */
-textarea[dir='ltr'],
-input[dir='ltr'] {
+textarea[ dir='ltr' ],
+input[ dir='ltr' ] {
/* @noflip */
direction: ltr;
 }
 
-textarea[dir='rtl'],
-input[dir='rtl'] {
+textarea[ dir='rtl' ],
+input[ dir='rtl' ] {
/* @noflip */
direction: rtl;
 }
 
 /* Default style for semantic tags */
-abbr[title],
-.explain[title] {
+abbr[ title ],
+.explain[ title ] {
border-bottom: 1px dotted;
cursor: help;
 }
 
 @supports ( text-decoration: underline dotted ) {
-   abbr[title],
-   .explain[title] {
+   abbr[ title ],
+   .explain[ title ] {
border-bottom: 0;
text-decoration: underline dotted;
}
diff --git 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Mark MediaWiki.UI as deprecated.

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386727 )

Change subject: resources: Mark MediaWiki.UI as deprecated.
..

resources: Mark MediaWiki.UI as deprecated.

Change-Id: Idd5f898c1b596040be8d14dee0a9893b59d6a532
---
M resources/Resources.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/27/386727/1

diff --git a/resources/Resources.php b/resources/Resources.php
index b9986fe..1a2d707 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -360,7 +360,7 @@
/* jQuery UI */
 
'jquery.ui.core' => [
-   'deprecated' => 'Please use "mediawiki.ui.button" or "oojs-ui" 
instead.',
+   'deprecated' => 'Please use OOUI instead.',
'scripts' => 'resources/lib/jquery.ui/jquery.ui.core.js',
'dependencies' => [
'jquery.ui.core.styles',
@@ -2311,6 +2311,7 @@
/* MediaWiki UI */
 
'mediawiki.ui' => [
+   'deprecated' => 'Please use OOUI instead.',
'skinStyles' => [
'default' => [
'resources/src/mediawiki.ui/default.less',

-- 
To view, visit https://gerrit.wikimedia.org/r/386727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd5f898c1b596040be8d14dee0a9893b59d6a532
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Test against Safari 7, Safari 6 is no longer around

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386664 )

Change subject: build: Test against Safari 7, Safari 6 is no longer around
..

build: Test against Safari 7, Safari 6 is no longer around

Change-Id: I11e97c8bf8ee544ccc279aee9c235c79391540d1
---
M Gruntfile.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/64/386664/1

diff --git a/Gruntfile.js b/Gruntfile.js
index ae64640..33d10b7 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -131,7 +131,7 @@
// Latest versions of complicated 
browsers
'slSafari', 'slIE',
// Earliest-supported versions of 
complicated browsers
-   'slSafari6', 'slIE10'
+   'slSafari7', 'slIE10'
]
},
// Primary unit test run (includes code coverage)

-- 
To view, visit https://gerrit.wikimedia.org/r/386664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e97c8bf8ee544ccc279aee9c235c79391540d1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] unicodejs[master]: build: Drop unused karma 'text-summary' coverage report

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386650 )

Change subject: build: Drop unused karma 'text-summary' coverage report
..

build: Drop unused karma 'text-summary' coverage report

Change-Id: I9a9a374748d16beefd9f2133672608be9e2c8ff3
---
M Gruntfile.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/50/386650/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 62c7ab5..cbd156f 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -46,8 +46,7 @@
subdir: '.',
reporters: [
{ type: 'json-summary', file: 
'coverage-summary.json' },
-   { type: 'html' },
-   { type: 'text-summary' }
+   { type: 'html' }
],
check: { global: {
functions: 100,

-- 
To view, visit https://gerrit.wikimedia.org/r/386650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a9a374748d16beefd9f2133672608be9e2c8ff3
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] unicodejs[master]: build: Put karma coverage reports in the top-level directory

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386649 )

Change subject: build: Put karma coverage reports in the top-level directory
..

build: Put karma coverage reports in the top-level directory

Change-Id: I6413096ad0581764307e9f0892ef4665a7ae4338
---
M Gruntfile.js
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/49/386649/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 3702b7f..62c7ab5 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -42,16 +42,19 @@
'src/*.js': [ 'coverage' ]
},
coverageReporter: {
+   dir: 'coverage/',
+   subdir: '.',
+   reporters: [
+   { type: 'json-summary', file: 
'coverage-summary.json' },
+   { type: 'html' },
+   { type: 'text-summary' }
+   ],
check: { global: {
functions: 100,
statements: 95,
branches: 90,
lines: 95
-   } },
-   reporters: [
-   { type: 'text-summary' },
-   { type: 'html', dir: 
'coverage/' }
-   ]
+   } }
}
},
main: {

-- 
To view, visit https://gerrit.wikimedia.org/r/386649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6413096ad0581764307e9f0892ef4665a7ae4338
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Drop karma 'text-summary' coverage report, unused

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386647 )

Change subject: build: Drop karma 'text-summary' coverage report, unused
..

build: Drop karma 'text-summary' coverage report, unused

Change-Id: I2fd5c0c05c2b37955e109c3047e14d472215c0aa
---
M Gruntfile.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/47/386647/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 4ecfb8a..5b09fba 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -325,8 +325,7 @@
subdir: '.',
reporters: [
{ type: 'json-summary', file: 
'coverage-summary.json' },
-   { type: 'html' },
-   { type: 'text-summary' }
+   { type: 'html' }
],
// 
https://github.com/karma-runner/karma-coverage/blob/v1.1.1/docs/configuration.md#check
check: {

-- 
To view, visit https://gerrit.wikimedia.org/r/386647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fd5c0c05c2b37955e109c3047e14d472215c0aa
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Put karma coverage reports in the top-level directory

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386645 )

Change subject: build: Put karma coverage reports in the top-level directory
..

build: Put karma coverage reports in the top-level directory

Change-Id: I3f01b1e055472173c274288ff26f00115bba99e2
---
M Gruntfile.js
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/45/386645/1

diff --git a/Gruntfile.js b/Gruntfile.js
index ca45bd8..4ecfb8a 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -321,10 +321,12 @@
},
reporters: [ 'mocha', 'coverage' ],
coverageReporter: {
+   dir: 'coverage/',
+   subdir: '.',
reporters: [
-   { type: 'json-summary', dir: 
'coverage/' },
-   { type: 'html', dir: 
'coverage/' },
-   { type: 'text-summary', dir: 
'coverage/' }
+   { type: 'json-summary', file: 
'coverage-summary.json' },
+   { type: 'html' },
+   { type: 'text-summary' }
],
// 
https://github.com/karma-runner/karma-coverage/blob/v1.1.1/docs/configuration.md#check
check: {

-- 
To view, visit https://gerrit.wikimedia.org/r/386645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f01b1e055472173c274288ff26f00115bba99e2
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: Follow-up 1b12648: Add a use tag for the newly-used class

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386478 )

Change subject: Follow-up 1b12648: Add a use tag for the newly-used class
..

Follow-up 1b12648: Add a use tag for the newly-used class

Change-Id: I594e16672d67536c617ad3d90c1df9fe30cc3b67
---
M includes/index/EditIndexPage.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/78/386478/1

diff --git a/includes/index/EditIndexPage.php b/includes/index/EditIndexPage.php
index 94c6ad8..862f150 100644
--- a/includes/index/EditIndexPage.php
+++ b/includes/index/EditIndexPage.php
@@ -9,6 +9,7 @@
 use OOUI\FieldLayout;
 use OOUI\FieldsetLayout;
 use OOUI\TextInputWidget;
+use OOUI\MultilineTextInputWidget;
 use ProofreadPage\Context;
 use Status;
 use WikitextContent;

-- 
To view, visit https://gerrit.wikimedia.org/r/386478
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I594e16672d67536c617ad3d90c1df9fe30cc3b67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386475 )

Change subject: build: Bump eslint devDependencies to latest
..

build: Bump eslint devDependencies to latest

 eslint 3.12.2  →   4.9.0
 grunt-eslint   20.0.0  →  20.1.0

Change-Id: I7eb9964fb5d163c5bbcef850f62383cbceb59287
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/75/386475/1

diff --git a/package.json b/package.json
index c30e150..b5b20de 100644
--- a/package.json
+++ b/package.json
@@ -8,13 +8,13 @@
   },
   "devDependencies": {
 "deepmerge": "1.3.2",
-"eslint": "3.12.2",
+"eslint": "4.9.0",
 "eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
 "grunt-contrib-watch": "1.0.0",
-"grunt-eslint": "20.0.0",
+"grunt-eslint": "20.1.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.8.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/386475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7eb9964fb5d163c5bbcef850f62383cbceb59287
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump karma devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386476 )

Change subject: build: Bump karma devDependencies to latest
..

build: Bump karma devDependencies to latest

 karma   1.5.0  →   1.7.1
 karma-chrome-launcher   2.0.0  →   2.2.0
 karma-mocha-reporter2.2.3  →   2.2.5
 nodemw 0.10.1  →  0.11.0
 qunitjs 2.4.0  →   2.4.1

Change-Id: I1e06189a12fbbc1d62781a4636f192c5b7078c1a
---
M package.json
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/386476/1

diff --git a/package.json b/package.json
index b5b20de..58f48e4 100644
--- a/package.json
+++ b/package.json
@@ -19,13 +19,13 @@
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.8.0",
 "grunt-webdriver": "2.0.3",
-"karma": "1.5.0",
-"karma-chrome-launcher": "2.0.0",
+"karma": "1.7.1",
+"karma-chrome-launcher": "2.2.0",
 "karma-firefox-launcher": "1.0.1",
-"karma-mocha-reporter": "2.2.3",
+"karma-mocha-reporter": "2.2.5",
 "karma-qunit": "1.2.1",
-"nodemw": "0.10.1",
-"qunitjs": "2.4.0",
+"nodemw": "0.11.0",
+"qunitjs": "2.4.1",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1",
 "wdio-junit-reporter": "0.2.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/386476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e06189a12fbbc1d62781a4636f192c5b7078c1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Remove deprecated 'mediawiki.widgets.CategorySele...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386472 )

Change subject: resources: Remove deprecated 
'mediawiki.widgets.CategorySelector' module alias
..

resources: Remove deprecated 'mediawiki.widgets.CategorySelector' module alias

Change-Id: I28557186a6cfe45b2a378f06ca59848be3f8e781
---
M resources/Resources.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/386472/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 1b4762b..1f9c7b1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2504,12 +2504,6 @@
],
'targets' => [ 'desktop', 'mobile' ],
],
-   'mediawiki.widgets.CategorySelector' => [
-   'deprecated' => 'Use "mw.widgets.CategoryMultiselectWidget" 
instead. See T161285.',
-   'dependencies' => [
-   'mediawiki.widgets.CategoryMultiselectWidget',
-   ],
-   ],
'mediawiki.widgets.CategoryMultiselectWidget' => [
'scripts' => [

'resources/src/mediawiki.widgets/mw.widgets.CategoryCapsuleItemWidget.js',

-- 
To view, visit https://gerrit.wikimedia.org/r/386472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28557186a6cfe45b2a378f06ca59848be3f8e781
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Remove deprecated 'jquery.placeholder' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386470 )

Change subject: resources: Remove deprecated 'jquery.placeholder' module
..

resources: Remove deprecated 'jquery.placeholder' module

Change-Id: I1f14561e54df477067460411ff155e3f2eeb167a
---
M resources/Resources.php
D resources/src/jquery/jquery.placeholder.js
M resources/src/mediawiki.less/mediawiki.mixins.less
3 files changed, 0 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/386470/1

diff --git a/resources/Resources.php b/resources/Resources.php
index aa25053..1475619 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -286,12 +286,6 @@
'scripts' => 'resources/src/jquery/jquery.mw-jump.js',
'targets' => [ 'desktop', 'mobile' ],
],
-   'jquery.placeholder' => [
-   'deprecated' => 'Use of "jquery.placeholder" is deprecated 
since MediaWiki 1.29.0',
-
-   'scripts' => 'resources/src/jquery/jquery.placeholder.js',
-   'targets' => [ 'desktop', 'mobile' ],
-   ],
'jquery.qunit' => [
'scripts' => 'resources/lib/qunitjs/qunit.js',
'styles' => 'resources/lib/qunitjs/qunit.css',
diff --git a/resources/src/jquery/jquery.placeholder.js 
b/resources/src/jquery/jquery.placeholder.js
deleted file mode 100644
index afb8837..000
--- a/resources/src/jquery/jquery.placeholder.js
+++ /dev/null
@@ -1,18 +0,0 @@
-/*!
- * No-op for compatibility with code from before we used
- * native placeholder in all supported browsers.
- */
-
-( function ( $ ) {
-   var placeholder;
-
-   placeholder = $.fn.placeholder = function ( text ) {
-   if ( arguments.length ) {
-   this.prop( 'placeholder', text );
-   }
-   return this;
-   };
-
-   placeholder.input = placeholder.textarea = true;
-
-}( jQuery ) );
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less 
b/resources/src/mediawiki.less/mediawiki.mixins.less
index fb3b00e..ea0b959 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -171,10 +171,6 @@
&::placeholder {
@rules();
}
-   // For inputs that use jquery.placeholder.js e.g. IE9
-   &.placeholder {
-   @rules();
-   }
 }
 /* stylelint-enable selector-no-vendor-prefix, at-rule-no-unknown */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/386470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f14561e54df477067460411ff155e3f2eeb167a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Remove deprecated 'jquery.autoEllipsis' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386469 )

Change subject: resources: Remove deprecated 'jquery.autoEllipsis' module
..

resources: Remove deprecated 'jquery.autoEllipsis' module

Change-Id: Ib181b814953bac0153dead95a25040ed2d4ca7ca
---
M jsduck.json
M resources/Resources.php
D resources/src/jquery/jquery.autoEllipsis.js
M tests/qunit/QUnitTestResources.php
D tests/qunit/suites/resources/jquery/jquery.autoEllipsis.test.js
5 files changed, 0 insertions(+), 233 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/386469/1

diff --git a/jsduck.json b/jsduck.json
index 0f8daf8..0021f37 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -21,7 +21,6 @@
"resources/src/mediawiki.toolbar",
"resources/src/mediawiki.widgets",
"resources/src/jquery/jquery.accessKeyLabel.js",
-   "resources/src/jquery/jquery.autoEllipsis.js",
"resources/src/jquery/jquery.byteLength.js",
"resources/src/jquery/jquery.byteLimit.js",
"resources/src/jquery/jquery.checkboxShiftClick.js",
diff --git a/resources/Resources.php b/resources/Resources.php
index 71b167a..aa25053 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -158,12 +158,6 @@
'jquery.async' => [
'scripts' => 'resources/lib/jquery/jquery.async.js',
],
-   'jquery.autoEllipsis' => [
-   'deprecated' => 'Use CSS text-overflow instead.',
-   'scripts' => 'resources/src/jquery/jquery.autoEllipsis.js',
-   'dependencies' => 'jquery.highlightText',
-   'targets' => [ 'desktop', 'mobile' ],
-   ],
'jquery.byteLength' => [
'scripts' => 'resources/src/jquery/jquery.byteLength.js',
'targets' => [ 'desktop', 'mobile' ],
diff --git a/resources/src/jquery/jquery.autoEllipsis.js 
b/resources/src/jquery/jquery.autoEllipsis.js
deleted file mode 100644
index 8716b69..000
--- a/resources/src/jquery/jquery.autoEllipsis.js
+++ /dev/null
@@ -1,171 +0,0 @@
-/**
- * @class jQuery.plugin.autoEllipsis
- */
-( function ( $ ) {
-
-   var
-   // Cache ellipsed substrings for every string-width-position 
combination
-   cache = {},
-
-   // Use a separate cache when match highlighting is enabled
-   matchTextCache = {};
-
-   // Due to 
-   // jscs:disable jsDoc
-   /**
-* Automatically truncate the plain text contents of an element and add 
an ellipsis
-*
-* @param {Object} options
-* @param {'left'|'center'|'right'} [options.position='center'] Where 
to remove text.
-* @param {boolean} [options.tooltip=false] Whether to show a tooltip 
with the remainder
-* of the text.
-* @param {boolean} [options.restoreText=false] Whether to save the 
text for restoring
-* later.
-* @param {boolean} [options.hasSpan=false] Whether the element is 
already a container,
-* or if the library should create a new container for it.
-* @param {string|null} [options.matchText=null] Text to highlight, 
e.g. search terms.
-* @return {jQuery}
-* @chainable
-*/
-   $.fn.autoEllipsis = function ( options ) {
-   options = $.extend( {
-   position: 'center',
-   tooltip: false,
-   restoreText: false,
-   hasSpan: false,
-   matchText: null
-   }, options );
-
-   return this.each( function () {
-   var $trimmableText,
-   text, trimmableText, w, pw,
-   l, r, i, side, m,
-   // container element - used for measuring 
against
-   $container = $( this );
-
-   if ( options.restoreText ) {
-   if ( !$container.data( 
'autoEllipsis.originalText' ) ) {
-   $container.data( 
'autoEllipsis.originalText', $container.text() );
-   } else {
-   $container.text( $container.data( 
'autoEllipsis.originalText' ) );
-   }
-   }
-
-   // trimmable text element - only the text within this 
element will be trimmed
-   if ( options.hasSpan ) {
-   $trimmableText = $container.children( 
options.selector );
-   } else {
-   $trimmableText = $( '' )
-   .css( 'whiteSpace', 'nowrap' )
- 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Remove deprecated 'jquery.appear' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386471 )

Change subject: resources: Remove deprecated 'jquery.appear' module
..

resources: Remove deprecated 'jquery.appear' module

Change-Id: Ifce63eb64c94203acb049d3f588e75f18123f12e
---
M resources/Resources.php
D resources/lib/jquery/jquery.appear.js
2 files changed, 0 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/71/386471/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 1475619..1b4762b 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -151,10 +151,6 @@
'messages' => [ 'brackets', 'word-separator' ],
'targets' => [ 'mobile', 'desktop' ],
],
-   'jquery.appear' => [
-   'deprecated' => 'Please use "mediawiki.viewport" instead.',
-   'scripts' => 'resources/lib/jquery/jquery.appear.js',
-   ],
'jquery.async' => [
'scripts' => 'resources/lib/jquery/jquery.async.js',
],
diff --git a/resources/lib/jquery/jquery.appear.js 
b/resources/lib/jquery/jquery.appear.js
deleted file mode 100644
index 4f77886..000
--- a/resources/lib/jquery/jquery.appear.js
+++ /dev/null
@@ -1,138 +0,0 @@
-/*
- * jQuery.appear
- * http://code.google.com/p/jquery-appear/
- *
- * Copyright (c) 2009 Michael Hixson
- * Licensed under the MIT license 
(http://www.opensource.org/licenses/mit-license.php)
-*/
-(function($) {
-
-   $.fn.appear = function(fn, options) {
-
-   var settings = $.extend({
- 
-   //arbitrary data to pass to fn
-   data: undefined,
- 
-   //call fn only on the first appear?
-   one: true
-
-   }, options);
-
-   return this.each(function() {
-
-   var t = $(this);
-
-   //whether the element is currently visible
-   t.appeared = false;
-
-   if (!fn) {
- 
-   //trigger the custom event
-   t.trigger('appear', settings.data);
-   return;
-   }
-
-   var w = $(window);
-
-   //fires the appear event when appropriate
-   var check = function() {
- 
-   //is the element hidden?
-   if (!t.is(':visible')) {
-
-   //it became hidden
-   t.appeared = false;
-   return;
-   }
- 
-   //is the element inside the visible window?
-   var a = w.scrollLeft();
-   var b = w.scrollTop();
-   var o = t.offset();
-   var x = o.left;
-   var y = o.top;
-
-   if (y + t.height() >= b && 
-   y <= b + w.height() &&
-   x + t.width() >= a && 
-   x <= a + w.width()) {
- 
-   //trigger the custom event
-   if (!t.appeared) t.trigger('appear', 
settings.data);
-
-   } else {
- 
-   //it scrolled out of view
-   t.appeared = false;
-   }
-   };
- 
-   //create a modified fn with some additional logic
-   var modifiedFn = function() {
-
-   //mark the element as visible
-   t.appeared = true;
- 
-   //is this supposed to happen only once?
-   if (settings.one) {
- 
-   //remove the check
-   w.unbind('scroll', check);
-   var i = $.inArray(check, 
$.fn.appear.checks);
-   if (i >= 0) 
$.fn.appear.checks.splice(i, 1);
-   }
- 
-   //trigger the original fn
-   fn.apply(this, arguments);
-   

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386433 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 eslint   ^3.19.0  →4.9.0
 eslint-config-wikimedia   ^0.4.0  →0.5.0
 grunt-banana-checker   0.4.0  →0.6.0
 grunt-eslint ^19.0.0  →   20.1.0
 grunt-jsonlint 1.0.7  →1.1.0
 grunt-stylelint0.6.0  →0.8.0

Change-Id: I19667318887d97f1dac68f4e47a01d28b5e97a2f
---
M package.json
M 
resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
2 files changed, 11 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/33/386433/1

diff --git a/package.json b/package.json
index 23d901d..f9bb60f 100644
--- a/package.json
+++ b/package.json
@@ -8,13 +8,13 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint": "^3.19.0",
-"eslint-config-wikimedia": "^0.4.0",
+"eslint": "4.9.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
-"grunt-banana-checker": "0.4.0",
-"grunt-eslint": "^19.0.0",
-"grunt-jsonlint": "1.0.7",
-"grunt-stylelint": "0.6.0",
+"grunt-banana-checker": "0.6.0",
+"grunt-eslint": "20.1.0",
+"grunt-jsonlint": "1.1.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
diff --git 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
index c688f80..2e834e8 100644
--- 
a/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
+++ 
b/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js
@@ -81,11 +81,11 @@
} );
}
$( window ).on( 'resize', $.debounce(
-   100,
-   function () {
-   positionBanner( $wpbBannerImageContainer );
-   }
-   ) );
+   100,
+   function () {
+   positionBanner( $wpbBannerImageContainer );
+   }
+   ) );
// set focus after image has loaded
$img.load( function () {
positionBanner( $wpbBannerImageContainer );

-- 
To view, visit https://gerrit.wikimedia.org/r/386433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19667318887d97f1dac68f4e47a01d28b5e97a2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386432 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 eslint   ^3.19.0  →4.9.0
 eslint-config-wikimedia   ^0.4.0  →0.5.0
 grunt-banana-checker   0.4.0  →0.6.0
 grunt-eslint ^19.0.0  →   20.1.0
 grunt-jsonlint 1.0.7  →1.1.0
 grunt-stylelint0.6.0  →0.8.0

Change-Id: I750b1df23b671a28f27b28eba4044b4182ff998d
---
M package.json
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/32/386432/1

diff --git a/package.json b/package.json
index decd1fb..d2d057f 100644
--- a/package.json
+++ b/package.json
@@ -4,13 +4,13 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint": "^3.19.0",
-"eslint-config-wikimedia": "^0.4.0",
+"eslint": "4.9.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
-"grunt-banana-checker": "0.4.0",
-"grunt-eslint": "^19.0.0",
-"grunt-jsonlint": "1.0.7",
-"grunt-stylelint": "0.6.0",
+"grunt-banana-checker": "0.6.0",
+"grunt-eslint": "20.1.0",
+"grunt-jsonlint": "1.1.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/386432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I750b1df23b671a28f27b28eba4044b4182ff998d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeEditor[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386431 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 eslint-config-wikimedia   0.4.0  →   0.5.0
 grunt-banana-checker  0.5.0  →   0.6.0
 grunt-eslint 19.0.0  →  20.1.0
 grunt-stylelint   0.6.0  →   0.8.0

Change-Id: Ia01949112243c5a496896c0a3a5eda261e0f66bd
---
M modules/jquery.codeEditor.js
M package.json
2 files changed, 18 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor 
refs/changes/31/386431/1

diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 91cfe16..ba4058e 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -330,20 +330,20 @@
api.abort();
 
api.saveOption( 'usecodeeditor', prefValue ? 1 
: 0 )
-   .fail( function ( code, result ) {
-   var message;
+   .fail( function ( code, result ) {
+   var message;
 
-   if ( code === 'http' && 
result.textStatus === 'abort' ) {
-   // Request was aborted. Ignore 
error
-   return;
-   }
+   if ( code === 'http' && 
result.textStatus === 'abort' ) {
+   // Request was aborted. 
Ignore error
+   return;
+   }
 
-   message = 'Failed to set code editor 
preference: ' + code;
-   if ( result.error && result.error.info 
) {
-   message += '\n' + 
result.error.info;
-   }
-   mw.log.warn( message );
-   } );
+   message = 'Failed to set code 
editor preference: ' + code;
+   if ( result.error && 
result.error.info ) {
+   message += '\n' + 
result.error.info;
+   }
+   mw.log.warn( message );
+   } );
},
/**
 * Sets up the iframe in place of the textarea to allow 
more advanced operations
@@ -381,9 +381,9 @@
box.textSelection( 'register', 
textSelectionFn );
 
// Disable some annoying commands
-   
context.codeEditor.commands.removeCommand( 'replace' );  // ctrl+R
+   
context.codeEditor.commands.removeCommand( 'replace' ); // ctrl+R

context.codeEditor.commands.removeCommand( 'transposeletters' ); // ctrl+T
-   
context.codeEditor.commands.removeCommand( 'gotoline' ); // ctrl+L
+   
context.codeEditor.commands.removeCommand( 'gotoline' ); // ctrl+L
 
context.codeEditor.setReadOnly( 
box.prop( 'readonly' ) );
context.codeEditor.setShowInvisibles( 
context.showInvisibleChars );
diff --git a/package.json b/package.json
index 0e4e1ab..1f0d3cd 100644
--- a/package.json
+++ b/package.json
@@ -7,12 +7,12 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
-"grunt-banana-checker": "0.5.0",
-"grunt-eslint": "19.0.0",
+"grunt-banana-checker": "0.6.0",
+"grunt-eslint": "20.1.0",
 "grunt-jsonlint": "1.1.0",
-"grunt-stylelint": "0.6.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/386431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia01949112243c5a496896c0a3a5eda261e0f66bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386430 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 eslint-config-wikimedia   0.4.0  →   0.5.0
 grunt-banana-checker  0.5.0  →   0.6.0
 grunt-eslint 19.0.0  →  20.1.0
 grunt-jsonlint1.0.8  →   1.1.0
 grunt-stylelint   0.6.0  →   0.9.0
 stylelint 7.8.0  →   8.2.0

Change-Id: Ic80c765108feed6b6671ab2dc9bd90e7f743aa60
---
M package.json
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures 
refs/changes/30/386430/1

diff --git a/package.json b/package.json
index e86c99e..9bb6427 100644
--- a/package.json
+++ b/package.json
@@ -7,13 +7,13 @@
 "test": "grunt test"
   },
   "devDependencies": {
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
-"grunt-banana-checker": "0.5.0",
+"grunt-banana-checker": "0.6.0",
 "grunt-contrib-watch": "1.0.0",
-"grunt-eslint": "19.0.0",
-"grunt-jsonlint": "1.0.8",
-"grunt-stylelint": "0.6.0",
+"grunt-eslint": "20.1.0",
+"grunt-jsonlint": "1.1.0",
+"grunt-stylelint": "0.8.0",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/386430
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic80c765108feed6b6671ab2dc9bd90e7f743aa60
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...3D[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386429 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 eslint-config-wikimedia   0.3.0  →   0.5.0
 grunt-banana-checker  0.5.0  →   0.6.0
 grunt-eslint 19.0.0  →  20.1.0
 grunt-stylelint   0.7.0  →   0.8.0

Change-Id: I3b2f56c868f29b1ab445802b5be521f65638ff38
---
M package.json
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/3D 
refs/changes/29/386429/1

diff --git a/package.json b/package.json
index 24436b1..fa1cc37 100644
--- a/package.json
+++ b/package.json
@@ -7,12 +7,12 @@
"test": "grunt test"
},
"devDependencies": {
-   "eslint-config-wikimedia": "0.3.0",
+   "eslint-config-wikimedia": "0.5.0",
"grunt": "1.0.1",
-   "grunt-banana-checker": "0.5.0",
-   "grunt-eslint": "19.0.0",
+   "grunt-banana-checker": "0.6.0",
+   "grunt-eslint": "20.1.0",
"grunt-jsonlint": "1.1.0",
-   "grunt-stylelint": "0.7.0",
+   "grunt-stylelint": "0.8.0",
"stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"
}

-- 
To view, visit https://gerrit.wikimedia.org/r/386429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b2f56c868f29b1ab445802b5be521f65638ff38
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialPage: Hard deprecate getTitle, deprecated since 1.23

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386420 )

Change subject: SpecialPage: Hard deprecate getTitle, deprecated since 1.23
..

SpecialPage: Hard deprecate getTitle, deprecated since 1.23

Change-Id: I839e9aaa0be7491087cc144ea13153abb2e77aa6
---
M includes/specialpage/SpecialPage.php
M includes/specials/forms/PreferencesForm.php
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/20/386420/1

diff --git a/includes/specialpage/SpecialPage.php 
b/includes/specialpage/SpecialPage.php
index 4c3ca54..12206dc 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -615,6 +615,7 @@
 * @deprecated since 1.23, use SpecialPage::getPageTitle
 */
function getTitle( $subpage = false ) {
+   wfDeprecated( __METHOD__, '1.23' );
return $this->getPageTitle( $subpage );
}
 
diff --git a/includes/specials/forms/PreferencesForm.php 
b/includes/specials/forms/PreferencesForm.php
index d4e5ef4..f6a81ff 100644
--- a/includes/specials/forms/PreferencesForm.php
+++ b/includes/specials/forms/PreferencesForm.php
@@ -80,7 +80,7 @@
$html = parent::getButtons();
 
if ( $this->getModifiedUser()->isAllowed( 'editmyoptions' ) ) {
-   $t = $this->getTitle()->getSubpage( 'reset' );
+   $t = $this->getPageTitle()->getSubpage( 'reset' );
 
$linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
$html .= "\n" . $linkRenderer->makeLink( $t, 
$this->msg( 'restoreprefs' )->text(),

-- 
To view, visit https://gerrit.wikimedia.org/r/386420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I839e9aaa0be7491087cc144ea13153abb2e77aa6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Article: Drop partial purge code and constants, deprecated i...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386412 )

Change subject: Article: Drop partial purge code and constants, deprecated in 
1.29
..

Article: Drop partial purge code and constants, deprecated in 1.29

Change-Id: I4f20d823e6c9206121212b8a73ecc28f91e68b45
---
M RELEASE-NOTES-1.31
M includes/page/Article.php
M includes/page/WikiPage.php
3 files changed, 2 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/12/386412/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index fc50897..042af6e 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -55,6 +55,8 @@
 * The OutputPage class constructor now requires a context parameter,
   (instantiating without context was deprecated in 1.18)
 * mw.page (deprecated in 1.30) was removed.
+* Article::getLastPurgeTimestamp(), WikiPage::getLastPurgeTimestamp(), and the
+  related WikiPage::PURGE_* constants, deprecated in 1.29, were removed.
 
 == Compatibility ==
 MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/page/Article.php b/includes/page/Article.php
index b91bd9a..da8fe88 100644
--- a/includes/page/Article.php
+++ b/includes/page/Article.php
@@ -2118,16 +2118,6 @@
 
/**
 * Call to WikiPage function for backwards compatibility.
-* @see WikiPage::getLastPurgeTimestamp
-* @deprecated since 1.29
-*/
-   public function getLastPurgeTimestamp() {
-   wfDeprecated( __METHOD__, '1.29' );
-   return $this->mPage->getLastPurgeTimestamp();
-   }
-
-   /**
-* Call to WikiPage function for backwards compatibility.
 * @see WikiPage::doViewUpdates
 */
public function doViewUpdates( User $user, $oldid = 0 ) {
diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index aa26105..146c054 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -88,12 +88,6 @@
 */
protected $mLinksUpdated = '1970010100';
 
-   /** @deprecated since 1.29. Added in 1.28 for partial purging, no 
longer used. */
-   const PURGE_CDN_CACHE = 1;
-   const PURGE_CLUSTER_PCACHE = 2;
-   const PURGE_GLOBAL_PCACHE = 4;
-   const PURGE_ALL = 7;
-
/**
 * Constructor and clear the article
 * @param Title $title Reference to a Title object.
@@ -1132,18 +1126,6 @@
}
 
return true;
-   }
-
-   /**
-* Get the last time a user explicitly purged the page via action=purge
-*
-* @return string|bool TS_MW timestamp or false
-* @since 1.28
-* @deprecated since 1.29. It will always return false.
-*/
-   public function getLastPurgeTimestamp() {
-   wfDeprecated( __METHOD__, '1.29' );
-   return false;
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/386412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f20d823e6c9206121212b8a73ecc28f91e68b45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.5]: MWInternalLinkContextItem: increase specificity to override ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386308 )

Change subject: MWInternalLinkContextItem: increase specificity to override 
OOUI changes
..

MWInternalLinkContextItem: increase specificity to override OOUI changes

OOUI 8e31b2f273 increased changed various icon CSS rules, and increased their
specificity. Increase ours to match. This restores the correct size/ratio of
the images in the link context item.

Bug: T178933
Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
(cherry picked from commit ab1e5d58d41699c47b5e3ce2ba6d42930347d7e8)
---
M modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/08/386308/1

diff --git 
a/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css 
b/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
index 60c38a1..4f4f569 100644
--- a/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
+++ b/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
@@ -10,7 +10,7 @@
white-space: normal;
 }
 
-.ve-ui-mwInternalLinkContextItem-withImage .oo-ui-iconElement-icon {
+.ve-ui-mwInternalLinkContextItem-withImage > 
.oo-ui-iconElement.oo-ui-iconElement-icon {
float: left;
width: 3.75em;
height: 3.75em;
@@ -25,7 +25,7 @@
background-size: cover;
 }
 
-.ve-ui-mwInternalLinkContextItem-withImage 
.ve-ui-mwInternalLinkContextItem-hasImage {
+.ve-ui-mwInternalLinkContextItem-withImage > 
.ve-ui-mwInternalLinkContextItem-hasImage.oo-ui-iconElement-icon {
border: 0;
background-size: cover;
opacity: 1;

-- 
To view, visit https://gerrit.wikimedia.org/r/386308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.5
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: DLynch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.4]: MWInternalLinkContextItem: increase specificity to override ...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386309 )

Change subject: MWInternalLinkContextItem: increase specificity to override 
OOUI changes
..

MWInternalLinkContextItem: increase specificity to override OOUI changes

OOUI 8e31b2f273 increased changed various icon CSS rules, and increased their
specificity. Increase ours to match. This restores the correct size/ratio of
the images in the link context item.

Bug: T178933
Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
(cherry picked from commit ab1e5d58d41699c47b5e3ce2ba6d42930347d7e8)
---
M modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/09/386309/1

diff --git 
a/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css 
b/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
index 60c38a1..4f4f569 100644
--- a/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
+++ b/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css
@@ -10,7 +10,7 @@
white-space: normal;
 }
 
-.ve-ui-mwInternalLinkContextItem-withImage .oo-ui-iconElement-icon {
+.ve-ui-mwInternalLinkContextItem-withImage > 
.oo-ui-iconElement.oo-ui-iconElement-icon {
float: left;
width: 3.75em;
height: 3.75em;
@@ -25,7 +25,7 @@
background-size: cover;
 }
 
-.ve-ui-mwInternalLinkContextItem-withImage 
.ve-ui-mwInternalLinkContextItem-hasImage {
+.ve-ui-mwInternalLinkContextItem-withImage > 
.ve-ui-mwInternalLinkContextItem-hasImage.oo-ui-iconElement-icon {
border: 0;
background-size: cover;
opacity: 1;

-- 
To view, visit https://gerrit.wikimedia.org/r/386309
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f1a6dde363cf99f7665dc83f4b0fa6b1dd3c29e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.4
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: DLynch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386253 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 grunt-contrib-uglify   3.0.1  →   3.1.0
 grunt-eslint  20.0.0  →  20.1.0
 grunt-exec 1.0.1  →   3.0.0
 grunt-stylelint0.8.0  →   0.9.0
 karma  1.7.0  →   1.7.1
 prismjs1.6.0  →   1.8.3
 q  1.5.0  →   1.5.1
 qunitjs2.4.0  →   2.4.1

Change-Id: I5b011d987b6b7d7c577b63a8cb26430f67d51b22
---
M package.json
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/53/386253/1

diff --git a/package.json b/package.json
index 8732bb8..e5b33a9 100644
--- a/package.json
+++ b/package.json
@@ -36,30 +36,30 @@
 "grunt-contrib-copy": "1.0.0",
 "grunt-contrib-cssmin": "2.2.1",
 "grunt-contrib-less": "1.4.1",
-"grunt-contrib-uglify": "3.0.1",
+"grunt-contrib-uglify": "3.1.0",
 "grunt-contrib-watch": "1.0.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "20.0.0",
-"grunt-exec": "1.0.1",
+"grunt-eslint": "20.1.0",
+"grunt-exec": "3.0.0",
 "grunt-file-exists": "0.1.4",
 "grunt-image": "1.5.2",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-promise-q": 
"git://github.com/jdforrester/grunt-promise-q.git#v0.1.1-wmf.1",
 "grunt-string-replace": "1.3.1",
-"grunt-stylelint": "0.8.0",
+"grunt-stylelint": "0.9.0",
 "grunt-svg2png": 
"git://github.com/jdforrester/grunt-svg2png.git#v0.2.7-wmf.1",
 "grunt-tyops": "0.1.0",
 "javascript-stringify": "1.6.0",
-"karma": "1.7.0",
+"karma": "1.7.1",
 "karma-chrome-launcher": "2.2.0",
 "karma-coverage": "1.1.1",
 "karma-firefox-launcher": "1.0.1",
 "karma-qunit": "1.2.1",
 "karma-remap-istanbul": "0.6.0",
-"prismjs": "1.6.0",
-"q": "1.5.0",
-"qunitjs": "2.4.0",
+"prismjs": "1.8.3",
+"q": "1.5.1",
+"qunitjs": "2.4.1",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/386253
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b011d987b6b7d7c577b63a8cb26430f67d51b22
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: tests: Replace QUnit.expect with assert.expect

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386209 )

Change subject: tests: Replace QUnit.expect with assert.expect
..

tests: Replace QUnit.expect with assert.expect

Change-Id: Ie786f3cd3faf0182c3964fac7de5000847b6ea07
---
M tests/qunit/ext.quicksurveys.lib/test_lib.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/09/386209/1

diff --git a/tests/qunit/ext.quicksurveys.lib/test_lib.js 
b/tests/qunit/ext.quicksurveys.lib/test_lib.js
index bef8312..db2a954 100644
--- a/tests/qunit/ext.quicksurveys.lib/test_lib.js
+++ b/tests/qunit/ext.quicksurveys.lib/test_lib.js
@@ -126,7 +126,7 @@
assert.ok( qSurveys.surveyMatchesPlatform( { platforms: 
test[0] }, 'stable' ) === test[2] );
assert.ok( qSurveys.surveyMatchesPlatform( { platforms: 
test[0] }, 'beta' ) === test[3] );
} );
-   QUnit.expect( testCases.length * 3 );
+   assert.expect( testCases.length * 3 );
} );
 
QUnit.test( 'showSurvey: Placement (plain)', 3, function ( assert ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/386209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie786f3cd3faf0182c3964fac7de5000847b6ea07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: tests: Replace QUnit.expect with assert.expect

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386208 )

Change subject: tests: Replace QUnit.expect with assert.expect
..

tests: Replace QUnit.expect with assert.expect

Change-Id: I8945409ff8380a839b9c6ed9e7400643eb04832c
---
M resources/mobile.gallery/test_PhotoListApiGateway.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/08/386208/1

diff --git a/resources/mobile.gallery/test_PhotoListApiGateway.js 
b/resources/mobile.gallery/test_PhotoListApiGateway.js
index 09e7ec9..4054b18 100644
--- a/resources/mobile.gallery/test_PhotoListApiGateway.js
+++ b/resources/mobile.gallery/test_PhotoListApiGateway.js
@@ -16,7 +16,7 @@
[ 'File:No file extension but has a . in the title', 
'No file extension but has a . in the title' ],
[ 'Fichier:French Photo.jpg', 'French Photo' ]
];
-   QUnit.expect( tests.length );
+   assert.expect( tests.length );
$( tests ).each( function ( i ) {
var val = m.prototype._getDescription( this[ 0 ] );
assert.strictEqual( val, this[ 1 ], 'test ' + i );

-- 
To view, visit https://gerrit.wikimedia.org/r/386208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8945409ff8380a839b9c6ed9e7400643eb04832c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] unicodejs[master]: build: Bump devDependencies to latest and make pass

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386109 )

Change subject: build: Bump devDependencies to latest and make pass
..

build: Bump devDependencies to latest and make pass

 eslint-config-wikimedia   0.3.0  →   0.5.0
 grunt-contrib-clean   1.0.0  →   1.1.0
 grunt-eslint 19.0.0  →  20.1.0
 grunt-karma   1.0.0  →   2.0.0
 karma 1.1.0  →   1.7.1
 karma-chrome-launcher 1.0.1  →   2.2.0
 karma-coverage1.0.0  →   1.1.1
 karma-firefox-launcher1.0.0  →   1.0.1
 karma-qunit   1.1.0  →   1.2.1
 qunitjs  1.23.0  →   2.4.1

Change-Id: I5ce9c93e0241326a3bbb378c79dc32bfdc7da371
---
M package.json
M tests/unicodejs.characterclass.test.js
M tests/unicodejs.graphemebreak.test.js
M tests/unicodejs.test.js
M tests/unicodejs.wordbreak.test.js
5 files changed, 30 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/09/386109/1

diff --git a/package.json b/package.json
index 1777041..5cdbdbe 100644
--- a/package.json
+++ b/package.json
@@ -18,17 +18,17 @@
   },
   "dependencies": {},
   "devDependencies": {
-"eslint-config-wikimedia" : "0.3.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
-"grunt-contrib-clean": "1.0.0",
+"grunt-contrib-clean": "1.1.0",
 "grunt-contrib-concat": "1.0.1",
-"grunt-eslint": "19.0.0",
-"grunt-karma": "1.0.0",
-"karma": "1.1.0",
-"karma-chrome-launcher": "1.0.1",
-"karma-coverage": "1.0.0",
-"karma-firefox-launcher": "1.0.0",
-"karma-qunit": "1.1.0",
-"qunitjs": "1.23.0"
+"grunt-eslint": "20.1.0",
+"grunt-karma": "2.0.0",
+"karma": "1.7.1",
+"karma-chrome-launcher": "2.2.0",
+"karma-coverage": "1.1.1",
+"karma-firefox-launcher": "1.0.1",
+"karma-qunit": "1.2.1",
+"qunitjs": "2.4.1"
   }
 }
diff --git a/tests/unicodejs.characterclass.test.js 
b/tests/unicodejs.characterclass.test.js
index 476977f..6e3739a 100644
--- a/tests/unicodejs.characterclass.test.js
+++ b/tests/unicodejs.characterclass.test.js
@@ -49,7 +49,7 @@
'', 'ퟠ'
];
 
-   QUnit.expect( 2 );
+   assert.expect( 2 );
assert.deepEqual( wordChars.join( '' ).match( wordGlobalRegex ), 
wordChars );
assert.strictEqual( nonWordChars.join( '' ).match( wordGlobalRegex ), 
null );
 } );
diff --git a/tests/unicodejs.graphemebreak.test.js 
b/tests/unicodejs.graphemebreak.test.js
index 0b65b6c..a51d3bb 100644
--- a/tests/unicodejs.graphemebreak.test.js
+++ b/tests/unicodejs.graphemebreak.test.js
@@ -7,7 +7,7 @@
 
 QUnit.module( 'unicodeJS.graphemebreak' );
 
-QUnit.test( 'splitClusters', 1, function ( assert ) {
+QUnit.test( 'splitClusters', function ( assert ) {
var expected = [
'a',
' ',
diff --git a/tests/unicodejs.test.js b/tests/unicodejs.test.js
index 33032b4..20e3494 100644
--- a/tests/unicodejs.test.js
+++ b/tests/unicodejs.test.js
@@ -14,8 +14,14 @@
[ [ 0x0040 ], '\\u0040', 'single BMP character' ],
[ [ 0x ], '\\u', 'highest BMP character' ],
[
-   [ 0x005F, [ 0x203F, 0x2040 ], 0x2054, [ 0xFE33, 0xFE34 
],
-   [ 0xFE4D, 0xFE4F ], 0xFF3F ],
+   [
+   0x005F,
+   [ 0x203F, 0x2040 ],
+   0x2054,
+   [ 0xFE33, 0xFE34 ],
+   [ 0xFE4D, 0xFE4F ],
+   0xFF3F
+   ],

'[\\u005f\\u203f-\\u2040\\u2054\\ufe33-\\ufe34\\ufe4d-\\ufe4f\\uff3f]',
'multiple BMP ranges (= ExtendNumLet from wordbreak 
rules)'
],
@@ -105,7 +111,7 @@
[ [ [ 0x, 0x ] ], 'surrogate overlap 4' ]
];
 
-   QUnit.expect( equalityTests.length + throwTests.length );
+   assert.expect( equalityTests.length + throwTests.length );
for ( i = 0; i < equalityTests.length; i++ ) {
test = equalityTests[ i ];
assert.equal(
diff --git a/tests/unicodejs.wordbreak.test.js 
b/tests/unicodejs.wordbreak.test.js
index 6d5d0d8..e54e09d 100644
--- a/tests/unicodejs.wordbreak.test.js
+++ b/tests/unicodejs.wordbreak.test.js
@@ -26,7 +26,7 @@
}
};
 
-   QUnit.expect( length + 1 );
+   assert.expect( length + 1 );
 
for ( i = 0; i <= length; i++ ) {
result = ( breakOffsets.indexOf( i ) !== -1 );
@@ -60,9 +60,12 @@
// U+10308 OLD ITALIC LETTER THE \ud800\udf08
// U+1030A OLD ITALIC LETTER KA \ud800\udf0a
// U+0302 COMBINING CIRCUMFLEX \u0302
-   '\ud800\udf08' + '\ud800\udf08\u0302' + 

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: tests: Replace QUnit.expect with assert.expect

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386093 )

Change subject: tests: Replace QUnit.expect with assert.expect
..

tests: Replace QUnit.expect with assert.expect

Change-Id: Iade0f4eee42fb1a7dd806701aa78066466e80f0f
---
M tests/qunit/flow/dm/test_mw.flow.dm.Board.js
M tests/qunit/flow/dm/test_mw.flow.dm.Content.js
M tests/qunit/flow/dm/test_mw.flow.dm.Post.js
M tests/qunit/flow/dm/test_mw.flow.dm.System.js
M tests/qunit/flow/dm/test_mw.flow.dm.Topic.js
5 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/93/386093/1

diff --git a/tests/qunit/flow/dm/test_mw.flow.dm.Board.js 
b/tests/qunit/flow/dm/test_mw.flow.dm.Board.js
index cb1aa61..8993d39 100644
--- a/tests/qunit/flow/dm/test_mw.flow.dm.Board.js
+++ b/tests/qunit/flow/dm/test_mw.flow.dm.Board.js
@@ -173,5 +173,5 @@
}
}
 
-   QUnit.expect( expectCount );
+   assert.expect( expectCount );
 } );
diff --git a/tests/qunit/flow/dm/test_mw.flow.dm.Content.js 
b/tests/qunit/flow/dm/test_mw.flow.dm.Content.js
index 9c0bf34..5fa36b1 100644
--- a/tests/qunit/flow/dm/test_mw.flow.dm.Content.js
+++ b/tests/qunit/flow/dm/test_mw.flow.dm.Content.js
@@ -16,7 +16,7 @@
assert.equal( content.get(), 'content in default format (wikitext, for 
instance)' );
assert.equal( content.get( 'unknown format' ), null );
 
-   QUnit.expect( 4 );
+   assert.expect( 4 );
 } );
 
 QUnit.test( 'Behaves when empty', function ( assert ) {
@@ -25,5 +25,5 @@
assert.equal( content.get(), null );
assert.equal( content.get( 'whatever format' ), null );
 
-   QUnit.expect( 2 );
+   assert.expect( 2 );
 } );
diff --git a/tests/qunit/flow/dm/test_mw.flow.dm.Post.js 
b/tests/qunit/flow/dm/test_mw.flow.dm.Post.js
index e46f911..723a80b 100644
--- a/tests/qunit/flow/dm/test_mw.flow.dm.Post.js
+++ b/tests/qunit/flow/dm/test_mw.flow.dm.Post.js
@@ -508,5 +508,5 @@
assert.equal( replies[ 0 ].getWorkflowId(), topic.getId(), 'Replies: 
WorkflowId is topic Id' );
assert.equal( subreplies[ 0 ].getWorkflowId(), topic.getId(), 'Sub 
replies: WorkflowId is topic Id' );
 
-   QUnit.expect( 12 );
+   assert.expect( 12 );
 } );
diff --git a/tests/qunit/flow/dm/test_mw.flow.dm.System.js 
b/tests/qunit/flow/dm/test_mw.flow.dm.System.js
index 7387871..85e13c0 100644
--- a/tests/qunit/flow/dm/test_mw.flow.dm.System.js
+++ b/tests/qunit/flow/dm/test_mw.flow.dm.System.js
@@ -344,5 +344,5 @@
expectCounter++;
}
 
-   QUnit.expect( expectCounter );
+   assert.expect( expectCounter );
 } );
diff --git a/tests/qunit/flow/dm/test_mw.flow.dm.Topic.js 
b/tests/qunit/flow/dm/test_mw.flow.dm.Topic.js
index 6066a3b..95acc64 100644
--- a/tests/qunit/flow/dm/test_mw.flow.dm.Topic.js
+++ b/tests/qunit/flow/dm/test_mw.flow.dm.Topic.js
@@ -252,5 +252,5 @@
}
}
 
-   QUnit.expect( expectCount );
+   assert.expect( expectCount );
 } );

-- 
To view, visit https://gerrit.wikimedia.org/r/386093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iade0f4eee42fb1a7dd806701aa78066466e80f0f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: tests: Make compartible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386068 )

Change subject: tests: Make compartible with QUnit 2
..

tests: Make compartible with QUnit 2

Change-Id: Ibd5db944e20c887dc44a984c2e7ae70e94b44b46
---
M tests/qunit/test_zerobanner.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner 
refs/changes/68/386068/1

diff --git a/tests/qunit/test_zerobanner.js b/tests/qunit/test_zerobanner.js
index 859fe7c..e47e9e0 100644
--- a/tests/qunit/test_zerobanner.js
+++ b/tests/qunit/test_zerobanner.js
@@ -1,7 +1,7 @@
 ( function ( M, $ ) {
QUnit.module( 'Zero' );
 
-   QUnit.test( '#init', 1, function ( assert ) {
+   QUnit.test( '#init', function ( assert ) {
assert.ok( mw.loader.getState( 'zerobanner' ) === 'ready',
'check Zero banner module installed without problems' );
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/386068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd5db944e20c887dc44a984c2e7ae70e94b44b46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: tests: Use a better name so it's not confused with ZeroPortal

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386069 )

Change subject: tests: Use a better name so it's not confused with ZeroPortal
..

tests: Use a better name so it's not confused with ZeroPortal

Change-Id: I6cad7b3d06b2363b0a90d0a38037af936b5d7e20
---
M tests/qunit/test_zerobanner.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner 
refs/changes/69/386069/1

diff --git a/tests/qunit/test_zerobanner.js b/tests/qunit/test_zerobanner.js
index e47e9e0..24965ac 100644
--- a/tests/qunit/test_zerobanner.js
+++ b/tests/qunit/test_zerobanner.js
@@ -1,5 +1,5 @@
 ( function ( M, $ ) {
-   QUnit.module( 'Zero' );
+   QUnit.module( 'ZeroBanner' );
 
QUnit.test( '#init', function ( assert ) {
assert.ok( mw.loader.getState( 'zerobanner' ) === 'ready',

-- 
To view, visit https://gerrit.wikimedia.org/r/386069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cad7b3d06b2363b0a90d0a38037af936b5d7e20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: tests: Make compartible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386067 )

Change subject: tests: Make compartible with QUnit 2
..

tests: Make compartible with QUnit 2

Change-Id: I726d7f75e37a759e1b1f6372710cb06f754fc94b
---
M tests/qunit/test_ext.thanks.mobilediff.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks 
refs/changes/67/386067/1

diff --git a/tests/qunit/test_ext.thanks.mobilediff.js 
b/tests/qunit/test_ext.thanks.mobilediff.js
index bb3f2d8..db51415 100644
--- a/tests/qunit/test_ext.thanks.mobilediff.js
+++ b/tests/qunit/test_ext.thanks.mobilediff.js
@@ -1,7 +1,7 @@
 ( function ( $, mw ) {
QUnit.module( 'Thanks mobilediff' );
 
-   QUnit.test( 'render button for logged in users', 1, function ( assert ) 
{
+   QUnit.test( 'render button for logged in users', function ( assert ) {
var $container = $( '' ),
$user = $( '' ).data( 'user-name', 'jon' )
.data( 'revision-id', 1 )

-- 
To view, visit https://gerrit.wikimedia.org/r/386067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I726d7f75e37a759e1b1f6372710cb06f754fc94b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: tests: Make compartible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386066 )

Change subject: tests: Make compartible with QUnit 2
..

tests: Make compartible with QUnit 2

Change-Id: Id067022f009ac8d73291eee55d7c14ef4198e7e8
---
M tests/qunit/engine/misc/test_flow-handlebars.js
M tests/qunit/engine/misc/test_mw-ui.enhance.js
2 files changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/66/386066/1

diff --git a/tests/qunit/engine/misc/test_flow-handlebars.js 
b/tests/qunit/engine/misc/test_flow-handlebars.js
index 84c893e..94ae428 100644
--- a/tests/qunit/engine/misc/test_flow-handlebars.js
+++ b/tests/qunit/engine/misc/test_flow-handlebars.js
@@ -29,28 +29,28 @@
}
} );
 
-   QUnit.test( 'Handlebars.prototype.processTemplate', 1, function ( 
assert ) {
+   QUnit.test( 'Handlebars.prototype.processTemplate', function ( assert ) 
{
assert.strictEqual( this.handlebarsProto.processTemplate( 
'foo', { val: 'Hello' } ),
'Magic.', 'Getting a template works.' );
} );
 
-   QUnit.test( 'Handlebars.prototype.processTemplateGetFragment', 1, 
function ( assert ) {
+   QUnit.test( 'Handlebars.prototype.processTemplateGetFragment', function 
( assert ) {
assert.strictEqual( 
this.handlebarsProto.processTemplateGetFragment( 'foo', { val: 'Hello' } 
).childNodes.length,
1, 'Return a fragment with the div child node' );
} );
 
-   QUnit.test( 'Handlebars.prototype.getTemplate', 2, function ( assert ) {
+   QUnit.test( 'Handlebars.prototype.getTemplate', function ( assert ) {
assert.strictEqual( this.handlebarsProto.getTemplate( 'foo' 
)(), 'Stubbed.', 'Getting a template works.' );
assert.strictEqual( this.handlebarsProto.getTemplate( 'foo' 
)(), 'Stubbed.', 'Getting a template from cache works.' );
} );
 
// Helpers
-   QUnit.test( 'Handlebars.prototype.callHelper', 1, function ( assert ) {
+   QUnit.test( 'Handlebars.prototype.callHelper', function ( assert ) {
assert.strictEqual( this.handlebarsProto.callHelper( 
'_qunit_helper_test', 1, 2 ),
3, 'Check the helper was called.' );
} );
 
-   QUnit.test( 'Handlebars.prototype.eachPost', 3, function ( assert ) {
+   QUnit.test( 'Handlebars.prototype.eachPost', function ( assert ) {
var ctx = {
posts: {
1: [ 300 ],
@@ -67,7 +67,7 @@
assert.deepEqual( this.handlebarsProto.eachPost( ctx, 2, {} ), 
{ content: null }, 'Missing revision id.' );
} );
 
-   QUnit.test( 'Handlebars.prototype.ifCond', 8, function ( assert ) {
+   QUnit.test( 'Handlebars.prototype.ifCond', function ( assert ) {
assert.strictEqual( this.handlebarsProto.ifCond( 'foo', '===', 
'bar', this.opts ), 'nope', 'not equal' );
assert.strictEqual( this.handlebarsProto.ifCond( 'foo', '===', 
'foo', this.opts ), 'ok', 'equal' );
assert.strictEqual( this.handlebarsProto.ifCond( true, 'or', 
false, this.opts ), 'ok', 'true || false' );
@@ -78,17 +78,17 @@
assert.strictEqual( this.handlebarsProto.ifCond( 'foo', '!==', 
'bar', this.opts ), 'ok' );
} );
 
-   QUnit.test( 'Handlebars.prototype.ifAnonymous', 2, function () {
+   QUnit.test( 'Handlebars.prototype.ifAnonymous', function () {
strictEqual( this.handlebarsProto.ifAnonymous( this.opts ), 
'ok', 'User should be anonymous first time.' );
strictEqual( this.handlebarsProto.ifAnonymous( this.opts ), 
'nope', 'User should be logged in on second call.' );
} );
 
-   QUnit.test( 'Handlebars.prototype.concat', 2, function () {
+   QUnit.test( 'Handlebars.prototype.concat', function () {
strictEqual( this.handlebarsProto.concat( 'a', 'b', 'c', 
this.opts ), 'abc', 'Check concat working fine.' );
strictEqual( this.handlebarsProto.concat( this.opts ), '', 
'Without arguments.' );
} );
 
-   QUnit.test( 'Handlebars.prototype.progressiveEnhancement', 5, function 
() {
+   QUnit.test( 'Handlebars.prototype.progressiveEnhancement', function () {
var opts = $.extend( { hash: { type: 'insert', target: 'abc', 
id: 'def' } }, this.opts ),
$div = $( document.createElement( 'div' ) );
 
diff --git a/tests/qunit/engine/misc/test_mw-ui.enhance.js 
b/tests/qunit/engine/misc/test_mw-ui.enhance.js
index 8170df6..8397722 100644
--- a/tests/qunit/engine/misc/test_mw-ui.enhance.js
+++ b/tests/qunit/engine/misc/test_mw-ui.enhance.js
@@ -1,7 +1,7 @@
 ( function ( $ ) {
QUnit.module( 'ext.flow: mediawiki.ui.enhance' );
 
-   QUnit.test( 'Forms with required 

[MediaWiki-commits] [Gerrit] mediawiki...GuidedTour[master]: tests: Make compartible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386063 )

Change subject: tests: Make compartible with QUnit 2
..

tests: Make compartible with QUnit 2

Change-Id: I0a758d448de36f736c81e8c7ecf12f7a060871eb
---
M tests/qunit/ext.guidedTour.lib.tests.js
1 file changed, 26 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GuidedTour 
refs/changes/63/386063/1

diff --git a/tests/qunit/ext.guidedTour.lib.tests.js 
b/tests/qunit/ext.guidedTour.lib.tests.js
index 33c5e77..81f339a 100644
--- a/tests/qunit/ext.guidedTour.lib.tests.js
+++ b/tests/qunit/ext.guidedTour.lib.tests.js
@@ -64,7 +64,7 @@
}
} ) );
 
-   QUnit.test( 'makeTourId', 4, function ( assert ) {
+   QUnit.test( 'makeTourId', function ( assert ) {
assert.strictEqual(
gt.makeTourId( {
name: 'test',
@@ -93,7 +93,7 @@
);
} );
 
-   QUnit.test( 'parseTourId', 1, function ( assert ) {
+   QUnit.test( 'parseTourId', function ( assert ) {
var tourId = 'gt-test-2', expectedTourInfo;
expectedTourInfo = {
name: 'test',
@@ -106,7 +106,7 @@
);
} );
 
-   QUnit.test( 'isPage', 2, function ( assert ) {
+   QUnit.test( 'isPage', function ( assert ) {
var PAGE_NAME_TO_SKIP = 'TestPage',
OTHER_PAGE_NAME = 'WrongPage';
 
@@ -125,7 +125,7 @@
);
} );
 
-   QUnit.test( 'hasQuery', 7, function ( assert ) {
+   QUnit.test( 'hasQuery', function ( assert ) {
var paramMap,
PAGE_NAME_TO_SKIP = 'RightPage',
OTHER_PAGE_NAME = 'OtherPage';
@@ -183,7 +183,7 @@
);
} );
 
-   QUnit.test( 'getStepFromQuery', 2, function ( assert ) {
+   QUnit.test( 'getStepFromQuery', function ( assert ) {
var step;
this.sandbox.stub( mw.util, 'getParamValue', function () {
return step;
@@ -204,7 +204,7 @@
);
} );
 
-   QUnit.test( 'setTourCookie', 5, function ( assert ) {
+   QUnit.test( 'setTourCookie', function ( assert ) {
var firstTourName = 'foo',
secondTourName = 'bar',
numberStep = 5,
@@ -244,7 +244,7 @@
mw.cookie.set( cookieName, oldCookieValue, cookieParams );
} );
 
-   QUnit.test( 'shouldShow', 19, function ( assert ) {
+   QUnit.test( 'shouldShow', function ( assert ) {
var visualEditorArgs, wikitextArgs, mockOpenVE;
 
visualEditorArgs = {
@@ -543,7 +543,7 @@
);
} );
 
-   QUnit.test( 'defineTour', 13, function ( assert ) {
+   QUnit.test( 'defineTour', function ( assert ) {
var SPEC_MUST_BE_OBJECT = /Check your syntax. There must be 
exactly one argument, 'tourSpec', which must be an object\./,
NAME_MUST_BE_STRING = /'tourSpec.name' must be a 
string, the tour name\./,
STEPS_MUST_BE_ARRAY = /'tourSpec.steps' must be an 
array, a list of one or more steps/,
@@ -646,7 +646,7 @@
this.restoreWarnings();
} );
 
-   QUnit.test( 'StepBuilder.constructor', 5, function ( assert ) {
+   QUnit.test( 'StepBuilder.constructor', function ( assert ) {
var STEP_NAME_MUST_BE_STRING = /'stepSpec.name\' must be a 
string, the step name/;
 
assert.strictEqual(
@@ -685,7 +685,7 @@
);
} );
 
-   QUnit.test( 'StepBuilder.listenForMwHooks', 6, function ( assert ) {
+   QUnit.test( 'StepBuilder.listenForMwHooks', function ( assert ) {
var listenForMwHookSpy = this.spy( firstStepBuilder.step, 
'listenForMwHook' );
 
firstStepBuilder.listenForMwHooks();
@@ -723,7 +723,7 @@
);
} );
 
-   QUnit.test( 'StepBuilder.next', 14, function ( assert ) {
+   QUnit.test( 'StepBuilder.next', function ( assert ) {
var editStepBuilder, linkStepBuilder, previewStepBuilder, 
saveStepBuilder,
pointsInvalidNameStepBuilder, 
pointsOtherTourStepBuilder,
returnsInvalidNameCallbackStepBuilder,
@@ -863,7 +863,7 @@
);
} );
 
-   QUnit.test( 'StepBuilder.transition', 14, function ( assert ) {
+   QUnit.test( 'StepBuilder.transition', function ( assert ) {
var linkStepBuilder, editStepBuilder, previewStepBuilder,
returnsInvalidNameCallbackStepBuilder,
returnsOtherTourCallbackStepBuilder,
@@ -997,7 +997,7 @@
);
} );
 
-   QUnit.test( 'Step.constructor', 5, 

[MediaWiki-commits] [Gerrit] mediawiki...EventLogging[master]: tests: Make compartible with QUnit 2

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386061 )

Change subject: tests: Make compartible with QUnit 2
..

tests: Make compartible with QUnit 2

Change-Id: I7fb5b4172dea8610a37ca85aa135411e06070581
---
M tests/ext.eventLogging.tests.js
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/61/386061/1

diff --git a/tests/ext.eventLogging.tests.js b/tests/ext.eventLogging.tests.js
index 849e51f..a95589d 100644
--- a/tests/ext.eventLogging.tests.js
+++ b/tests/ext.eventLogging.tests.js
@@ -83,11 +83,13 @@
}
} ) );
 
-   QUnit.test( 'Configuration', 1, function ( assert ) {
+   QUnit.test( 'Configuration', function ( assert ) {
assert.ok( mw.config.exists( 'wgEventLoggingBaseUri' ), 'Global 
config var "wgEventLoggingBaseUri" exists' );
} );
 
-   QUnit.test( 'validate', validationCases.length + 1, function ( assert ) 
{
+   QUnit.test( 'validate', function ( assert ) {
+   assert.expect( validationCases.length + 1 );
+
var meta = mw.eventLog.getSchema( 'earthquake' ),
errors = mw.eventLog.validate( {
epicenter: 'Valdivia',
@@ -102,7 +104,7 @@
} );
} );
 
-   QUnit.test( 'inSample', 2, function ( assert ) {
+   QUnit.test( 'inSample', function ( assert ) {
assert.strictEqual( mw.eventLog.inSample( 0 ), false );
assert.strictEqual( mw.eventLog.inSample( 1 ), true );
 
@@ -110,7 +112,7 @@
// want consistency in this case
} );
 
-   QUnit.test( 'randomTokenMatch', 2, function ( assert ) {
+   QUnit.test( 'randomTokenMatch', function ( assert ) {
var i, results = { 'true': 0, 'false': 0 };
for ( i = 0; i < 100; i++ ) {
results[ mw.eventLog.randomTokenMatch( 10 ) ]++;
@@ -140,7 +142,7 @@
expected: 'Url exceeds maximum length'
}
}, function ( name, params ) {
-   QUnit.test( name, 1, function ( assert ) {
+   QUnit.test( name, function ( assert ) {
var url = new Array( params.size + 1 ).join( 'x' ),
result = mw.eventLog.checkUrlSize( 
'earthquake', url );
assert.deepEqual( result, params.expected, name );
@@ -165,7 +167,7 @@
.always( assert.async() );
} );
 
-   QUnit.test( 'setDefaults', 1, function ( assert ) {
+   QUnit.test( 'setDefaults', function ( assert ) {
var prepared;
 
mw.eventLog.setDefaults( 'earthquake', {
@@ -213,9 +215,7 @@
invalid: [ -1, {}, undefined ]
}
}, function ( type, cases ) {
-   var asserts = cases.valid.length + cases.invalid.length;
-
-   QUnit.test( type, asserts, function ( assert ) {
+   QUnit.test( type, function ( assert ) {
$.each( cases.valid, function ( index, value ) {
assert.strictEqual( mw.eventLog.isInstanceOf( 
value, type ), true,
JSON.stringify( value ) + ' is a ' + 
type );

-- 
To view, visit https://gerrit.wikimedia.org/r/386061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fb5b4172dea8610a37ca85aa135411e06070581
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump unit test-related devDependencies

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386050 )

Change subject: build: Bump unit test-related devDependencies
..

build: Bump unit test-related devDependencies

 karma   1.1.2  →  1.7.1
 karma-chrome-launcher   1.0.1  →  2.2.0
 karma-firefox-launcher  1.0.0  →  1.0.1
 karma-mocha-reporter2.2.3  →  2.2.5

Change-Id: I7498d7a246cdce99d506abc8d70d435c6218e666
---
M package.json
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/50/386050/1

diff --git a/package.json b/package.json
index b48b65b..1870110 100644
--- a/package.json
+++ b/package.json
@@ -35,11 +35,11 @@
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.9.0",
 "grunt-tyops": "0.1.0",
-"karma": "1.1.2",
-"karma-chrome-launcher": "1.0.1",
-"karma-firefox-launcher": "1.0.0",
+"karma": "1.7.1",
+"karma-chrome-launcher": "2.2.0",
+"karma-firefox-launcher": "1.0.1",
 "karma-coverage": "1.1.1",
-"karma-mocha-reporter": "2.2.3",
+"karma-mocha-reporter": "2.2.5",
 "karma-qunit": "1.2.1",
 "qunitjs": "2.4.1",
 "stylelint": "7.8.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/386050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7498d7a246cdce99d506abc8d70d435c6218e666
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Bump various devDependencies to latest

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386049 )

Change subject: build: Bump various devDependencies to latest
..

build: Bump various devDependencies to latest

 grunt-eslint20.0.0  →  20.1.0
 grunt-stylelint  0.8.0  →   0.9.0
 qunitjs  2.4.0  →   2.4.1

Change-Id: I81906c25f90a651f09d19ea9e8ce25c7029196d0
---
M package.json
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/49/386049/1

diff --git a/package.json b/package.json
index 710379c..b48b65b 100644
--- a/package.json
+++ b/package.json
@@ -30,10 +30,10 @@
 "grunt-contrib-watch": "1.0.0",
 "grunt-css-url-embed": "1.10.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "20.0.0",
+"grunt-eslint": "20.1.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
-"grunt-stylelint": "0.8.0",
+"grunt-stylelint": "0.9.0",
 "grunt-tyops": "0.1.0",
 "karma": "1.1.2",
 "karma-chrome-launcher": "1.0.1",
@@ -41,7 +41,7 @@
 "karma-coverage": "1.1.1",
 "karma-mocha-reporter": "2.2.3",
 "karma-qunit": "1.2.1",
-"qunitjs": "2.4.0",
+"qunitjs": "2.4.1",
 "stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/386049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81906c25f90a651f09d19ea9e8ce25c7029196d0
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (a13b7efa5)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386047 )

Change subject: Update VE core submodule to master (a13b7efa5)
..

Update VE core submodule to master (a13b7efa5)

New changes:
9c1134b1b Localisation updates from https://translatewiki.net.
ccf83d4ed Localisation updates from https://translatewiki.net.
a13b7efa5 Fix infinite recursion in standalone diff dialog

Change-Id: Icb79a79d3bcde9337938d989d7cd93b3a74dd913
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/47/386047/1

diff --git a/lib/ve b/lib/ve
index 28e34c1..a13b7ef 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 28e34c1d70fb1086c5a99e844dced1227f2dbdb6
+Subproject commit a13b7efa52832bf748433b89a3cc0f8228d1c6af

-- 
To view, visit https://gerrit.wikimedia.org/r/386047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb79a79d3bcde9337938d989d7cd93b3a74dd913
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Removed the deprecated 'jquery.badge' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386029 )

Change subject: resources: Removed the deprecated 'jquery.badge' module
..

resources: Removed the deprecated 'jquery.badge' module

Bug: T178450
Change-Id: I4540e5959ea15323b1f54be51fbeea6ca3f35169
Depends-On: I78543abe412d04d61a05e76702cb7681d5fad61d
---
M RELEASE-NOTES-1.31
M resources/Resources.php
D resources/src/jquery/jquery.badge.css
D resources/src/jquery/jquery.badge.js
4 files changed, 1 insertion(+), 129 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/29/386029/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 3c22e78..e06f671 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -26,6 +26,7 @@
 * …
 
  Removed and replaced external libraries 
+* (T17845) The deprecated 'jquery.badge' module was removed.
 * …
 
 === Bug fixes in 1.31 ===
diff --git a/resources/Resources.php b/resources/Resources.php
index b4a3f2f..71b167a 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -164,12 +164,6 @@
'dependencies' => 'jquery.highlightText',
'targets' => [ 'desktop', 'mobile' ],
],
-   'jquery.badge' => [
-   'deprecated' => 'Please use Notifications instead.',
-   'scripts' => 'resources/src/jquery/jquery.badge.js',
-   'styles' => 'resources/src/jquery/jquery.badge.css',
-   'dependencies' => 'mediawiki.language',
-   ],
'jquery.byteLength' => [
'scripts' => 'resources/src/jquery/jquery.byteLength.js',
'targets' => [ 'desktop', 'mobile' ],
diff --git a/resources/src/jquery/jquery.badge.css 
b/resources/src/jquery/jquery.badge.css
deleted file mode 100644
index 1157c27..000
--- a/resources/src/jquery/jquery.badge.css
+++ /dev/null
@@ -1,35 +0,0 @@
-.mw-badge {
-   background-color: #72777d;
-   min-width: 7px;
-   border-radius: 2px;
-   padding: 1px 4px;
-   text-align: center;
-   font-size: 12px;
-   line-height: 12px;
-   cursor: pointer;
-}
-
-.mw-badge-content {
-   font-weight: bold;
-   color: #fff;
-   vertical-align: baseline;
-}
-
-.mw-badge-inline {
-   margin-left: 3px;
-   display: inline-block;
-   /* Hack for IE6 and IE7 (T49926) */
-   zoom: 1;
-   *display: inline; /* stylelint-disable-line 
declaration-block-no-duplicate-properties */
-
-}
-.mw-badge-overlay {
-   position: absolute;
-   bottom: -1px;
-   right: -3px;
-   z-index: 50;
-}
-
-.mw-badge-important {
-   background-color: #d33;
-}
diff --git a/resources/src/jquery/jquery.badge.js 
b/resources/src/jquery/jquery.badge.js
deleted file mode 100644
index 40b3baf..000
--- a/resources/src/jquery/jquery.badge.js
+++ /dev/null
@@ -1,88 +0,0 @@
-/*!
- * jQuery Badge plugin
- *
- * @license MIT
- *
- * @author Ryan Kaldari , 2012
- * @author Andrew Garrett , 2012
- * @author Marius Hoch , 2012
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to 
deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * This program is distributed WITHOUT ANY WARRANTY.
- */
-
-/**
- * @class jQuery.plugin.badge
- */
-( function ( $, mw ) {
-   /**
-* Put a badge on an item on the page. The badge container will be 
appended to the selected element(s).
-*
-* $element.badge( text );
-* $element.badge( 5 );
-* $element.badge( '100+' );
-* $element.badge( text, inline );
-* $element.badge( 'New', true );
-*
-* @param {number|string} text The value to display in the badge. If 
the value is falsey (0,
-*  null, false, '', etc.), any existing badge will be removed.
-* @param {boolean} [inline=true] True if the badge should be displayed 
inline, false
-*  if the badge should overlay the parent element.
-* @param {boolean} [displayZero=false] True if the number zero should 
be displayed,
-*  false if the number zero should result in the badge being hidden
-* @return {jQuery}
-* @chainable
-*/
-   $.fn.badge = function ( text, inline, displayZero ) {
-   var $badge = this.find( '.mw-badge' ),
-   badgeStyleClass = 'mw-badge-' + ( inline ? 'inline' : 

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: resources: Deprecate the 'jquery.badge' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386024 )

Change subject: resources: Deprecate the 'jquery.badge' module
..

resources: Deprecate the 'jquery.badge' module

Only used in the PageTriage extension, which can provide it itself:

https://github.com/search?utf8=%E2%9C%93=%22jquery.badge%22+%40wikimedia+-repo%3Awikimedia%2Fjquery.badge+-repo%3Awikimedia%2Fmediawiki-debian=Code

Bug: T178450
Change-Id: Ibe4ff6a1f39fc554dcf4fc20cc214521d854f1ec
(cherry picked from commit dfafef8e706af54706d2de621b845085604f154d)
---
M RELEASE-NOTES-1.30
M resources/Resources.php
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/24/386024/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index bec7b86..bcdd436 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -240,6 +240,9 @@
 * (T138166) SpecialEmailUser::getTarget() now requires a second argument, the 
sending
   user object. Using the method without the second argument is deprecated.
 * (T67297) Browsers that don't support Unicode will have their edits rejected.
+* (T178450) The module 'jquery.badge' is deprecated and will be removed in a 
future
+  release. For notifying the user of an event, the Notifications ("Echo") 
system
+  should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/resources/Resources.php b/resources/Resources.php
index 818112f..780eb17 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -169,6 +169,7 @@
'targets' => [ 'desktop', 'mobile' ],
],
'jquery.badge' => [
+   'deprecated' => 'Please use Notifications instead.',
'scripts' => 'resources/src/jquery/jquery.badge.js',
'styles' => 'resources/src/jquery/jquery.badge.css',
'dependencies' => 'mediawiki.language',

-- 
To view, visit https://gerrit.wikimedia.org/r/386024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe4ff6a1f39fc554dcf4fc20cc214521d854f1ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resources: Deprecate the 'jquery.badge' module

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385490 )

Change subject: resources: Deprecate the 'jquery.badge' module
..

resources: Deprecate the 'jquery.badge' module

Only used in the PageTriage extension, which can provide it itself:

https://github.com/search?utf8=%E2%9C%93=%22jquery.badge%22+%40wikimedia+-repo%3Awikimedia%2Fjquery.badge+-repo%3Awikimedia%2Fmediawiki-debian=Code

Bug: T178450
Change-Id: Ibe4ff6a1f39fc554dcf4fc20cc214521d854f1ec
---
M RELEASE-NOTES-1.30
M resources/Resources.php
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/385490/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index bec7b86..bcdd436 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -240,6 +240,9 @@
 * (T138166) SpecialEmailUser::getTarget() now requires a second argument, the 
sending
   user object. Using the method without the second argument is deprecated.
 * (T67297) Browsers that don't support Unicode will have their edits rejected.
+* (T178450) The module 'jquery.badge' is deprecated and will be removed in a 
future
+  release. For notifying the user of an event, the Notifications ("Echo") 
system
+  should be used instead.
 
 == Compatibility ==
 MediaWiki 1.30 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/resources/Resources.php b/resources/Resources.php
index 7afd89d..b4a3f2f 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -165,6 +165,7 @@
'targets' => [ 'desktop', 'mobile' ],
],
'jquery.badge' => [
+   'deprecated' => 'Please use Notifications instead.',
'scripts' => 'resources/src/jquery/jquery.badge.js',
'styles' => 'resources/src/jquery/jquery.badge.css',
'dependencies' => 'mediawiki.language',

-- 
To view, visit https://gerrit.wikimedia.org/r/385490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe4ff6a1f39fc554dcf4fc20cc214521d854f1ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Account for 'eye' icon having moved icon packs

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385212 )

Change subject: Account for 'eye' icon having moved icon packs
..

Account for 'eye' icon having moved icon packs

ext.visualEditor.articleTarget (for ve.ui.MWSaveDialog) previously
missed the editing-advanced pack, so the [[ ]] icon only showed up
by happy accident of the VE toolbar loading it and generally being
there.

ext.visualEditor.diffPage.init (for ve.init.mw.DiffPage.init) just
needed being switched over.

Change-Id: Id12ef14434fd30a442bbbf6e9ccd8e50c3376cd5
---
M extension.json
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/12/385212/1

diff --git a/extension.json b/extension.json
index e92d226..28f1764 100644
--- a/extension.json
+++ b/extension.json
@@ -548,6 +548,8 @@
"ext.visualEditor.core",
"ext.visualEditor.mwcore",
"ext.visualEditor.mwextensions",
+   "oojs-ui.styles.icons-accessibility",
+   "oojs-ui.styles.icons-editing-advanced",
"oojs-ui.styles.icons-layout"
],
"messages": [
@@ -1911,7 +1913,7 @@
"dependencies": [
"ext.visualEditor.diffLoader",
"oojs-ui",
-   "oojs-ui.styles.icons-alerts",
+   "oojs-ui.styles.icons-accessibility",
"oojs-ui.styles.icons-editing-advanced",
"mediawiki.Uri"
],

-- 
To view, visit https://gerrit.wikimedia.org/r/385212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id12ef14434fd30a442bbbf6e9ccd8e50c3376cd5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AntiSpoof[REL1_30]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385076 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Ifc455833721fc1ad9592f2356d33783f828294fa
(cherry picked from commit 87c90e1eb400f65997f93ccbdf2bb778cafd81f8)
---
M AntiSpoof.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AntiSpoof 
refs/changes/76/385076/1

diff --git a/AntiSpoof.php b/AntiSpoof.php
index 151756e..2dd75fe 100644
--- a/AntiSpoof.php
+++ b/AntiSpoof.php
@@ -3,11 +3,11 @@
wfLoadExtension( 'AntiSpoof' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['AntiSpoof'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for AntiSpoof extension. ' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the AntiSpoof extension requires MediaWiki 1.25+' 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/385076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc455833721fc1ad9592f2356d33783f828294fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AntiSpoof
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[REL1_30]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385069 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Ic6cba1dab5c0f7f09ba5479f15fb81bb2d869cb1
(cherry picked from commit 0d4df2b666c59bf93b29ab32e96bf3694dc290c3)
---
M ConfirmEdit.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit 
refs/changes/69/385069/1

diff --git a/ConfirmEdit.php b/ConfirmEdit.php
index 8116e5a..22cb25f 100644
--- a/ConfirmEdit.php
+++ b/ConfirmEdit.php
@@ -35,11 +35,11 @@
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['ConfirmEdit'] = __DIR__ . '/i18n';
$wgExtensionMessagesFiles['ConfirmEditAlias'] = __DIR__ . 
'/ConfirmEdit.alias.php';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for ConfirmEdit extension. ' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the ConfirmEdit extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/385069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6cba1dab5c0f7f09ba5479f15fb81bb2d869cb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Campaigns[REL1_30]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385064 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: I2d46590f22b9f944a1be94804beeea00d381d7aa
(cherry picked from commit 2f4aebce06b8be5600cd45e65290d67272e54ef0)
---
M Campaigns.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Campaigns 
refs/changes/64/385064/1

diff --git a/Campaigns.php b/Campaigns.php
index 209039e..1b73bb0 100644
--- a/Campaigns.php
+++ b/Campaigns.php
@@ -3,10 +3,10 @@
wfLoadExtension( 'Campaigns' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['Campaigns'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for Campaigns extension. 
Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the Campaigns extension requires MediaWiki 1.25+' 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/385064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d46590f22b9f944a1be94804beeea00d381d7aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Campaigns
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[REL1_30]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385061 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Id4c6b5897b47406082d7398111bdb03bd0b9dba1
(cherry picked from commit 16af56b057988512ec316d8e9ab19514c400c6df)
---
M SpamBlacklist.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist 
refs/changes/61/385061/1

diff --git a/SpamBlacklist.php b/SpamBlacklist.php
index 0b703b5..bade5f5 100644
--- a/SpamBlacklist.php
+++ b/SpamBlacklist.php
@@ -3,11 +3,11 @@
wfLoadExtension( 'SpamBlacklist' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['SpamBlackList'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for SpamBlacklist extension. ' 
.
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the SpamBlacklist extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/385061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4c6b5897b47406082d7398111bdb03bd0b9dba1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TitleBlacklist[REL1_30]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385062 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: I75ddd651c6b25f25f7c67d5c18af986d2d7b1abb
(cherry picked from commit 31c3e8609a27885636277a7b1ceb5907033602c7)
---
M TitleBlacklist.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TitleBlacklist 
refs/changes/62/385062/1

diff --git a/TitleBlacklist.php b/TitleBlacklist.php
index 6eaef24..105f2d2 100644
--- a/TitleBlacklist.php
+++ b/TitleBlacklist.php
@@ -12,11 +12,11 @@
wfLoadExtension( 'TitleBlacklist' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['TitleBlacklist'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for TitleBlacklist extension. 
' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the TitleBlacklist extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/385062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75ddd651c6b25f25f7c67d5c18af986d2d7b1abb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleBlacklist
Gerrit-Branch: REL1_30
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (28e34c1d7)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384912 )

Change subject: Update VE core submodule to master (28e34c1d7)
..

Update VE core submodule to master (28e34c1d7)

New changes:
f549faef9 Revert "ve.ui.LinearContextItem: Workaround for T178336"
952faad32 Update OOjs UI to v0.24.0

Change-Id: I76d27222edb29ee9685c7b8807068ac7c99536d9
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/12/384912/1

diff --git a/lib/ve b/lib/ve
index ea51798..28e34c1 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit ea5179857cb55525ca98f0b28cd1681a3705f2f5
+Subproject commit 28e34c1d70fb1086c5a99e844dced1227f2dbdb6

-- 
To view, visit https://gerrit.wikimedia.org/r/384912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76d27222edb29ee9685c7b8807068ac7c99536d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[wmf/1.31.0-wmf.4]: ve.ui.CiteFromIdInspector: Fix CSS for context menus after c...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384817 )

Change subject: ve.ui.CiteFromIdInspector: Fix CSS for context menus after 
changes in OOjs UI
..

ve.ui.CiteFromIdInspector: Fix CSS for context menus after changes in OOjs UI

Bug: T178324
Change-Id: I4133d988dc80da8c2cd8067afff46c24e6d0867f
(cherry picked from commit df3c1d2661923d76c329b9d351cf26a544078092)
---
M modules/ve.ui.CiteFromIdInspector.css
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid 
refs/changes/17/384817/1

diff --git a/modules/ve.ui.CiteFromIdInspector.css 
b/modules/ve.ui.CiteFromIdInspector.css
index f186347..5c5f95b 100644
--- a/modules/ve.ui.CiteFromIdInspector.css
+++ b/modules/ve.ui.CiteFromIdInspector.css
@@ -31,7 +31,8 @@
font-weight: bold;
 }
 
-.ve-ui-citeFromIdReferenceWidget .oo-ui-iconElement-icon {
+.ve-ui-citeFromIdReferenceWidget.oo-ui-iconElement > .oo-ui-iconElement-icon {
+   position: static;
display: inline-block;
margin-right: 0.5em;
height: 1.875em;

-- 
To view, visit https://gerrit.wikimedia.org/r/384817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4133d988dc80da8c2cd8067afff46c24e6d0867f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: wmf/1.31.0-wmf.4
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.31.0-wmf.4]: ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384748 )

Change subject: ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons
..

ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

OOjs UI's styles now include 'top: 0' for icons, which messes us up here.

Bug: T178415
Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
(cherry picked from commit 99cdc08f53b00452d134579dec5a609b6ac5978e)
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/48/384748/1

diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css 
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
index e2b8e36..ead4d1e 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
@@ -10,6 +10,7 @@
margin: 0.05em;
height: 1.9em;
position: absolute;
+   top: auto;
opacity: 0.5;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/384748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.4
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (b20086541)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384594 )

Change subject: Update VE core submodule to master (b20086541)
..

Update VE core submodule to master (b20086541)

New changes:
f5ffe3713 Localisation updates from https://translatewiki.net.
7a829c165 Fix CSS for context menus after changes in OOjs UI

Bug: T178324
Change-Id: Ifb4c592b506974d020de64d71388d0f20560b299
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/94/384594/1

diff --git a/lib/ve b/lib/ve
index df62df4..b200865 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit df62df432594de92db53d246ae4463e98d3e580b
+Subproject commit b2008654113ff7ac7028190494facfdc25ce0456

-- 
To view, visit https://gerrit.wikimedia.org/r/384594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb4c592b506974d020de64d71388d0f20560b299
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AntiSpoof[master]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384176 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Ifc455833721fc1ad9592f2356d33783f828294fa
---
M AntiSpoof.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AntiSpoof 
refs/changes/76/384176/1

diff --git a/AntiSpoof.php b/AntiSpoof.php
index 151756e..2dd75fe 100644
--- a/AntiSpoof.php
+++ b/AntiSpoof.php
@@ -3,11 +3,11 @@
wfLoadExtension( 'AntiSpoof' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['AntiSpoof'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for AntiSpoof extension. ' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the AntiSpoof extension requires MediaWiki 1.25+' 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/384176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc455833721fc1ad9592f2356d33783f828294fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AntiSpoof
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Campaigns[master]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384175 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: I2d46590f22b9f944a1be94804beeea00d381d7aa
---
M Campaigns.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Campaigns 
refs/changes/75/384175/1

diff --git a/Campaigns.php b/Campaigns.php
index 209039e..1b73bb0 100644
--- a/Campaigns.php
+++ b/Campaigns.php
@@ -3,10 +3,10 @@
wfLoadExtension( 'Campaigns' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['Campaigns'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for Campaigns extension. 
Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the Campaigns extension requires MediaWiki 1.25+' 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/384175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d46590f22b9f944a1be94804beeea00d381d7aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Campaigns
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TitleBlacklist[master]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384174 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: I75ddd651c6b25f25f7c67d5c18af986d2d7b1abb
---
M TitleBlacklist.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TitleBlacklist 
refs/changes/74/384174/1

diff --git a/TitleBlacklist.php b/TitleBlacklist.php
index 6eaef24..105f2d2 100644
--- a/TitleBlacklist.php
+++ b/TitleBlacklist.php
@@ -12,11 +12,11 @@
wfLoadExtension( 'TitleBlacklist' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['TitleBlacklist'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for TitleBlacklist extension. 
' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the TitleBlacklist extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/384174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75ddd651c6b25f25f7c67d5c18af986d2d7b1abb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleBlacklist
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[master]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384172 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Ic6cba1dab5c0f7f09ba5479f15fb81bb2d869cb1
---
M ConfirmEdit.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit 
refs/changes/72/384172/1

diff --git a/ConfirmEdit.php b/ConfirmEdit.php
index 8116e5a..22cb25f 100644
--- a/ConfirmEdit.php
+++ b/ConfirmEdit.php
@@ -35,11 +35,11 @@
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['ConfirmEdit'] = __DIR__ . '/i18n';
$wgExtensionMessagesFiles['ConfirmEditAlias'] = __DIR__ . 
'/ConfirmEdit.alias.php';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for ConfirmEdit extension. ' .
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the ConfirmEdit extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/384172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6cba1dab5c0f7f09ba5479f15fb81bb2d869cb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Uncomment wfWarn in deprecated PHP entry point

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384170 )

Change subject: Uncomment wfWarn in deprecated PHP entry point
..

Uncomment wfWarn in deprecated PHP entry point

Change-Id: Id4c6b5897b47406082d7398111bdb03bd0b9dba1
---
M SpamBlacklist.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist 
refs/changes/70/384170/1

diff --git a/SpamBlacklist.php b/SpamBlacklist.php
index 0b703b5..bade5f5 100644
--- a/SpamBlacklist.php
+++ b/SpamBlacklist.php
@@ -3,11 +3,11 @@
wfLoadExtension( 'SpamBlacklist' );
// Keep i18n globals so mergeMessageFileList.php doesn't break
$wgMessagesDirs['SpamBlackList'] = __DIR__ . '/i18n';
-   /* wfWarn(
+   wfWarn(
'Deprecated PHP entry point used for SpamBlacklist extension. ' 
.
'Please use wfLoadExtension instead, ' .
'see https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
+   );
return;
 } else {
die( 'This version of the SpamBlacklist extension requires MediaWiki 
1.25+' );

-- 
To view, visit https://gerrit.wikimedia.org/r/384170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4c6b5897b47406082d7398111bdb03bd0b9dba1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (df62df432)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383943 )

Change subject: Update VE core submodule to master (df62df432)
..

Update VE core submodule to master (df62df432)

New changes:
539f1fd80 Update OOjs UI to v0.23.4
4dda3b936 Notification for DM node attached/detached
df62df432 Update OOjs UI to v0.23.5

Bug: T162761
Change-Id: Id1a159ecac246dd067b83bbe86f4b163bde83e8c
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/43/383943/1

diff --git a/lib/ve b/lib/ve
index 33e74b9..df62df4 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 33e74b92f44438e8a714494e1d46cbb05ce8da0d
+Subproject commit df62df432594de92db53d246ae4463e98d3e580b

-- 
To view, visit https://gerrit.wikimedia.org/r/383943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1a159ecac246dd067b83bbe86f4b163bde83e8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOjs UI to v0.23.5

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383939 )

Change subject: Update OOjs UI to v0.23.5
..

Update OOjs UI to v0.23.5

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.5

Also, replace uses of `OOUI\TextInputWidget( [ 'multiline' => true ] )`
with `OOUI\MultilineTextInputWidget()` to avoid deprecation warnings
(which cause unit tests to fail).

Depends-on: I990b14982ffb72fe981040d02c7023d13f721aaa
Change-Id: If8312c60e1547a6177f5491011badb6576f54b21
---
M composer.json
M includes/htmlform/fields/HTMLTextAreaField.php
M includes/widget/UsersMultiselectWidget.php
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-toolbars.js.map
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/themes/apex/icons-interactions.json
A resources/lib/oojs-ui/themes/apex/images/icons/reload-ltr.png
A resources/lib/oojs-ui/themes/apex/images/icons/reload-ltr.svg
A resources/lib/oojs-ui/themes/apex/images/icons/reload-rtl.png
A resources/lib/oojs-ui/themes/apex/images/icons/reload-rtl.svg
M resources/lib/oojs-ui/themes/wikimediaui/icons-interactions.json
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/alert-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/arched-arrow-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/arched-arrow-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/articleCheck-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/articleCheck-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/articleRedirect-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/articleRedirect-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/articleSearch-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/attachment-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/attachment-rtl-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/bell-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bellOn-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bellOn-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bigger-ltr-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-a-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-arab-ain-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-arab-dad-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-armn-to-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-cyrl-be-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-cyrl-zhe-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/bold-g-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/book-ltr-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/book-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/browser-ltr-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/cancel-destructive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/cancel-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/case-sensitive-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/clear-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/clip-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/clock-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/download-rtl-progressive.png
M resources/lib/oojs-ui/themes/wikimediaui/images/icons/edit-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/editLock-ltr-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/editLock-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/editUndo-rtl-progressive.png
M 
resources/lib/oojs-ui/themes/wikimediaui/images/icons/external-link-ltr-progressive.png
M 

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.23.5

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383938 )

Change subject: Update OOjs UI to v0.23.5
..

Update OOjs UI to v0.23.5

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.5

Change-Id: I990b14982ffb72fe981040d02c7023d13f721aaa
---
M composer.json
M composer.lock
M composer/autoload_classmap.php
M composer/autoload_static.php
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/bin/testsuitegenerator.rb
M oojs/oojs-ui/demos/classes/IndexedDialog.js
M oojs/oojs-ui/demos/index.html
M oojs/oojs-ui/demos/pages/icons.js
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/demos/pages/widgets.php
M oojs/oojs-ui/demos/styles/demo.css
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/Element.php
M oojs/oojs-ui/php/Theme.php
A oojs/oojs-ui/php/widgets/MultilineTextInputWidget.php
A oojs/oojs-ui/php/widgets/SearchInputWidget.php
M oojs/oojs-ui/php/widgets/TextInputWidget.php
19 files changed, 193 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/38/383938/1

diff --git a/composer.json b/composer.json
index bbd968a..f845dc5 100644
--- a/composer.json
+++ b/composer.json
@@ -70,7 +70,7 @@
"monolog/monolog": "1.22.1",
"mustangostang/spyc": "0.6.2",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.23.3",
+   "oojs/oojs-ui": "0.23.5",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index c2d2989..6262e59 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "0c594f60d3795a4d41a93290ac37015c",
+"content-hash": "f93386e95c40850a5d8063d4b42fd186",
 "packages": [
 {
 "name": "composer/semver",
@@ -540,16 +540,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.23.3",
+"version": "v0.23.5",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "072606c2676ba903b8b2439a03d4dae3e5fa2e01"
+"reference": "2f77f21e3867c48aa9d4dc78e332a05b89ff4ed6"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/072606c2676ba903b8b2439a03d4dae3e5fa2e01;,
-"reference": "072606c2676ba903b8b2439a03d4dae3e5fa2e01",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/2f77f21e3867c48aa9d4dc78e332a05b89ff4ed6;,
+"reference": "2f77f21e3867c48aa9d4dc78e332a05b89ff4ed6",
 "shasum": ""
 },
 "require": {
@@ -615,7 +615,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-10-04T01:07:16+00:00"
+"time": "2017-10-12T21:07:17+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/autoload_classmap.php b/composer/autoload_classmap.php
index d98c4e3..16a67c7 100644
--- a/composer/autoload_classmap.php
+++ b/composer/autoload_classmap.php
@@ -751,10 +751,12 @@
 'OOUI\\LabelWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/LabelWidget.php',
 'OOUI\\Layout' => $vendorDir . '/oojs/oojs-ui/php/Layout.php',
 'OOUI\\MediaWikiTheme' => $vendorDir . 
'/oojs/oojs-ui/php/themes/MediaWikiTheme.php',
+'OOUI\\MultilineTextInputWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/MultilineTextInputWidget.php',
 'OOUI\\PanelLayout' => $vendorDir . 
'/oojs/oojs-ui/php/layouts/PanelLayout.php',
 'OOUI\\ProgressBarWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/ProgressBarWidget.php',
 'OOUI\\RadioInputWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/RadioInputWidget.php',
 'OOUI\\RadioSelectInputWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/RadioSelectInputWidget.php',
+'OOUI\\SearchInputWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/SearchInputWidget.php',
 'OOUI\\TabIndexedElement' => $vendorDir . 
'/oojs/oojs-ui/php/mixins/TabIndexedElement.php',
 'OOUI\\Tag' => $vendorDir . '/oojs/oojs-ui/php/Tag.php',
 'OOUI\\TextInputWidget' => $vendorDir . 
'/oojs/oojs-ui/php/widgets/TextInputWidget.php',
diff --git a/composer/autoload_static.php b/composer/autoload_static.php
index 0d3e8f2..7e2c63e 100644
--- a/composer/autoload_static.php
+++ b/composer/autoload_static.php
@@ -952,10 +952,12 @@
 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.23.5

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383937 )

Change subject: Update OOjs UI to v0.23.5
..

Update OOjs UI to v0.23.5

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.5

Change-Id: I033f698ef84532469d6f5d61ec385f1102a04c1c
---
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.css
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui.css
M lib/oojs-ui/oojs-ui-wikimediaui.js
M lib/oojs-ui/oojs-ui-wikimediaui.rtl.css
M