[MediaWiki-commits] [Gerrit] Fix XSS vulnerability - change (mediawiki...MsCalendar)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/290232

Change subject: Fix XSS vulnerability
..

Fix XSS vulnerability

Change-Id: I32b022e8aa7412ff9f36dd7fc874830ef16635ed
---
M js/MsCalendar.js
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCalendar 
refs/changes/32/290232/1

diff --git a/js/MsCalendar.js b/js/MsCalendar.js
index 5bb2fd7..f64d344 100644
--- a/js/MsCalendar.js
+++ b/js/MsCalendar.js
@@ -160,19 +160,22 @@
if ( this_dialog.find( 'input[name="remove_event"]' 
).is( ':checked' ) ) {
rs_var = 'MsCalendar::remove';
}
-   var inhalt = this_dialog.find( 
'input[name="form_inhalt"]' ),
-   datum = this_dialog.find( 
'input[name="form_datum"]' ),
-   event_id = this_dialog.find( 
'input[name="form_id"]' ),
-   duration = this_dialog.find( 
'input[name="form_duration"]' ),
+   var inhalt = this_dialog.find( 
'input[name="form_inhalt"]' ).val(),
+   datum = this_dialog.find( 
'input[name="form_datum"]' ).val(),
+   event_id = this_dialog.find( 
'input[name="form_id"]' ).val(),
+   duration = this_dialog.find( 
'input[name="form_duration"]' ).val(),
yearly = this_dialog.find( 
'input[name="form_yearly"]' ).is( ':checked' ) ? 1 : 0,
bValid = true;
+
+   // Sanitize
+   inhalt = $( '' ).html( inhalt ).text();
 
if ( bValid ) {
//console.log( datum.val() );
$.get( mw.util.wikiScript(), {
action: 'ajax',
rs: rs_var,
-   rsargs: [ calendarId, datum.val(), 
inhalt.val(), event_id.val(), duration.val(), yearly ]
+   rsargs: [ calendarId, datum, inhalt, 
event_id, duration, yearly ]
}, function ( data ) {
loadMonth();
}, 'json' );

-- 
To view, visit https://gerrit.wikimedia.org/r/290232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32b022e8aa7412ff9f36dd7fc874830ef16635ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCalendar
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove $wgEnableMetaDescriptionFunctions - change (mediawiki...Description2)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/287416

Change subject: Remove $wgEnableMetaDescriptionFunctions
..

Remove $wgEnableMetaDescriptionFunctions

What's the point of installing this extension
if you're not enabling the meta description functions?
I'm removing this dumb variable.

Change-Id: Id9f6df571b757e9798a84ec12a7e9350f0bc1879
---
M Description2.php
1 file changed, 1 insertion(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Description2 
refs/changes/16/287416/1

diff --git a/Description2.php b/Description2.php
index 68d9b4b..93e43ae 100644
--- a/Description2.php
+++ b/Description2.php
@@ -61,11 +61,6 @@
 
 $wgHooks['ParserFirstCallInit'][] = array( 'efDescription2RegisterParser' );
 function efDescription2RegisterParser( &$parser ) {
-   global $wgEnableMetaDescriptionFunctions;
-   if ( !$wgEnableMetaDescriptionFunctions ) {
-   // Functions and tags are disabled
-   return true;
-   }
$parser->setFunctionHook( 'description2', 'efDescription2Function', 
Parser::SFH_OBJECT_ARGS );
$parser->setFunctionTagHook( 'metadesc', 'efDescription2Tag', 
Parser::SFH_OBJECT_ARGS );
return true;
@@ -95,9 +90,4 @@
if ( isset($out->mDescription) && $out->mDescription )
$out->addMeta("description", $out->mDescription);
return true;
-}
-
-
-## Configuration
-$wgEnableMetaDescriptionFunctions = false;
-
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/287416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9f6df571b757e9798a84ec12a7e9350f0bc1879
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Description2
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Further normalise keys to find titles with special characters - change (mediawiki...TitleKey)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/286580

Change subject: Further normalise keys to find titles with special characters
..

Further normalise keys to find titles with special characters

Using iconv, all special characters are translitered to ASCII.
Then, all non-alphanumerical, non-whitespace characters are removed.
This allows for many new kinds of relevant matches in languages
such as Spanish where diacritics are common.

For example, searching "avion" now matches "Avión".

Bug: T22097
Change-Id: I80e8cf68b213a1593197cbfe6b9ab7de0184de0b
---
M TitleKey_body.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TitleKey 
refs/changes/80/286580/1

diff --git a/TitleKey_body.php b/TitleKey_body.php
index 63cf769..319b7f4 100644
--- a/TitleKey_body.php
+++ b/TitleKey_body.php
@@ -37,10 +37,13 @@
static function setBatchKeys( $titles ) {
$rows = array();
foreach( $titles as $id => $title ) {
+   $key = $title->getText();
+   $key = iconv( 'UTF-8', 'ASCII//TRANSLIT', $key );
+   $key = preg_replace( '#[^-\w\s]+#', '', $key ); // 
Remove unwanted chars
$rows[] = array(
'tk_page' => $id,
'tk_namespace' => $title->getNamespace(),
-   'tk_key' => self::normalize( $title->getText() 
),
+   'tk_key' => self::normalize( $key ),
);
}
$db = wfGetDB( DB_MASTER );
@@ -53,6 +56,8 @@
// Normalization...
static function normalize( $text ) {
global $wgContLang;
+   $text = iconv( 'UTF-8', 'ASCII//TRANSLIT', $text );
+   $text = preg_replace( '#[^-\w\s]+#', '', $text ); // Remove 
unwanted chars
return $wgContLang->caseFold( $text );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/286580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80e8cf68b213a1593197cbfe6b9ab7de0184de0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleKey
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Debugged and improved the keyMatch method - change (mediawiki...ConfirmEdit)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284749

Change subject: Debugged and improved the keyMatch method
..

Debugged and improved the keyMatch method

The keyMatch method did NOT normalise correctly the answers inside an array.
Now it does.
I've also added trimming for extra normalisation.
And hopefully made the method a bit clearer to read.

Change-Id: I62a39a51876e49121c5950345afafdb46a220f66
---
M QuestyCaptcha/QuestyCaptcha.class.php
1 file changed, 12 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit 
refs/changes/49/284749/1

diff --git a/QuestyCaptcha/QuestyCaptcha.class.php 
b/QuestyCaptcha/QuestyCaptcha.class.php
index dbe96e7..8281f8b 100644
--- a/QuestyCaptcha/QuestyCaptcha.class.php
+++ b/QuestyCaptcha/QuestyCaptcha.class.php
@@ -10,12 +10,21 @@
 
 class QuestyCaptcha extends SimpleCaptcha {
 
-   /** Validate a captcha response */
+   /**
+* Validate a captcha response
+* Override SimpleCaptcha::keyMatch
+*/
function keyMatch( $answer, $info ) {
+   $answer = strtolower( trim( $answer ) ); // Normalise the user 
answer
+
+   // Check if there is more than one correct answer
if ( is_array( $info['answer'] ) ) {
-   return in_array( strtolower( $answer ), array_map( 
'strtolower', $info['answer'] ) );
+   $correctAnswers = array_flip( $info['answer'] );
+   $correctAnswers = array_change_key_case( 
$correctAnswers, CASE_LOWER ); // Normalise
+   return array_key_exists( $answer, $correctAnswers ); // 
Check if the given answer is a key in our correctAnswers array
} else {
-   return strtolower( $answer ) == strtolower( 
$info['answer'] );
+   $correctAnswer = strtolower( $info['answer'] ); // 
Normalise
+   return $answer == $correctAnswer; // Weak comparison to 
prevent unnecessary fails
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/284749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62a39a51876e49121c5950345afafdb46a220f66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update extension to registration - change (mediawiki...MsCalendar)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Update extension to registration
..


Update extension to registration

Change-Id: I54c79e57e62a96e06a6d6e8e29e43d2b8df59ca7
---
M MsCalendar.body.php
M MsCalendar.php
M README.md
A extension.json
4 files changed, 82 insertions(+), 7 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/MsCalendar.body.php b/MsCalendar.body.php
index 7618aff..b069fbc 100644
--- a/MsCalendar.body.php
+++ b/MsCalendar.body.php
@@ -11,7 +11,7 @@
}
 
static function setHook( Parser $parser ) {
-   $parser->setHook( 'mscalendar', 'MsCalendar::render' );
+   $parser->setHook( 'MsCalendar', 'MsCalendar::render' );
return true;
}
 
diff --git a/MsCalendar.php b/MsCalendar.php
index 843fd01..ca28c62 100644
--- a/MsCalendar.php
+++ b/MsCalendar.php
@@ -3,9 +3,9 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCalendar',
'url' => 'https://www.mediawiki.org/wiki/Extension:MsCalendar',
-   'version' => '2.1',
+   'version' => '2.2',
'descriptionmsg' => 'msc-desc',
-   'license-name' => 'GPLv2+',
+   'license-name' => 'GPLv3',
'author' => array(
'[mailto:w...@ratin.de Martin Schwindl]',
'[mailto:w...@keyler-consult.de Martin Keyler]',
diff --git a/README.md b/README.md
index 3eba2f6..384145c 100644
--- a/README.md
+++ b/README.md
@@ -1,12 +1,12 @@
 MsCalendar
 ==
-The MsCalendar extension adds the  tag to insert calendars into 
wiki pages.
+The MsCalendar extension enables users to insert calendars into wiki pages.
 
 Installation
 
 To install MsCalendar, add the following to your LocalSettings.php:
 
-require_once "$IP/extensions/MsCalendar/MsCalendar.php";
+wfLoadExtension( 'MsCalendar' );
 
 Then run the update script to create the necessary tables (see 
https://www.mediawiki.org/wiki/Manual:Update.php).
 
@@ -14,7 +14,7 @@
 -
 To insert a calendar into a wiki page, simply edit a page and add the 
following wikitext:
 
-Name of the calendar
+Name of the calendar
 
 You can insert as many calendars as you want, but each must have a unique name.
 
@@ -22,7 +22,7 @@
 -
 The events of each day are sorted alphabetically. You can also sort them by id 
by doing:
 
-Name of the calendar
+Name of the calendar
 
 Credits
 ---
diff --git a/extension.json b/extension.json
new file mode 100644
index 000..98ab044
--- /dev/null
+++ b/extension.json
@@ -0,0 +1,75 @@
+{
+   "name": "MsCalendar",
+   "version": "2.2",
+   "author": [
+   "[mailto:w...@ratin.de Martin Schwindl]",
+   "[mailto:w...@keyler-consult.de Martin Keyler]",
+   "[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis 
Felipe Schenone]",
+   "[https://www.mediawiki.org/wiki/User:Fraifrai Frédéric 
Souchon]"
+   ],
+   "url": "https://www.mediawiki.org/wiki/Extension:MsCalendar";,
+   "descriptionmsg": "msc-desc",
+   "license-name": "GPLv3",
+   "type": "parserhook",
+   "MessagesDirs": {
+   "MsCalendar": [
+   "i18n"
+   ]
+   },
+   "AutoloadClasses": {
+   "MsCalendar": "MsCalendar.body.php"
+   },
+   "ResourceModules": {
+   "ext.MsCalendar": {
+   "scripts": [
+   "js/jquery.calendario.js",
+   "js/MsCalendar.js"
+   ],
+   "styles": "MsCalendar.css",
+   "messages": [
+   "msc-desc",
+   "msc-notfirstday",
+   "msc-change",
+   "msc-remove",
+   "msc-create",
+   "msc-cancel",
+   "msc-eventname",
+   "msc-eventdate",
+   "msc-eventduration",
+   "msc-eventyearly",
+   "msc-eventedit",
+   "msc-eventcreate",
+   "msc-today",
+   "msc-todaylabel",
+   "msc-months",
+   "msc-days"
+   ],
+   "dependencies": [
+   "jquery.ui.dialog",
+   "jquery.ui.datepicker"
+   ]
+   }
+   },
+   "ResourceFileModulePaths": {
+   "localBasePath": "",
+   "remoteExtPath": "MsCalendar"
+   },
+   "Hooks": {
+   "ParserFirstCallInit": [
+ 

[MediaWiki-commits] [Gerrit] Update extension to registration - change (mediawiki...MsCalendar)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284736

Change subject: Update extension to registration
..

Update extension to registration

Change-Id: I54c79e57e62a96e06a6d6e8e29e43d2b8df59ca7
---
M MsCalendar.body.php
M MsCalendar.php
M README.md
A extension.json
4 files changed, 82 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCalendar 
refs/changes/36/284736/1

diff --git a/MsCalendar.body.php b/MsCalendar.body.php
index 7618aff..b069fbc 100644
--- a/MsCalendar.body.php
+++ b/MsCalendar.body.php
@@ -11,7 +11,7 @@
}
 
static function setHook( Parser $parser ) {
-   $parser->setHook( 'mscalendar', 'MsCalendar::render' );
+   $parser->setHook( 'MsCalendar', 'MsCalendar::render' );
return true;
}
 
diff --git a/MsCalendar.php b/MsCalendar.php
index 843fd01..ca28c62 100644
--- a/MsCalendar.php
+++ b/MsCalendar.php
@@ -3,9 +3,9 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCalendar',
'url' => 'https://www.mediawiki.org/wiki/Extension:MsCalendar',
-   'version' => '2.1',
+   'version' => '2.2',
'descriptionmsg' => 'msc-desc',
-   'license-name' => 'GPLv2+',
+   'license-name' => 'GPLv3',
'author' => array(
'[mailto:w...@ratin.de Martin Schwindl]',
'[mailto:w...@keyler-consult.de Martin Keyler]',
diff --git a/README.md b/README.md
index 3eba2f6..384145c 100644
--- a/README.md
+++ b/README.md
@@ -1,12 +1,12 @@
 MsCalendar
 ==
-The MsCalendar extension adds the  tag to insert calendars into 
wiki pages.
+The MsCalendar extension enables users to insert calendars into wiki pages.
 
 Installation
 
 To install MsCalendar, add the following to your LocalSettings.php:
 
-require_once "$IP/extensions/MsCalendar/MsCalendar.php";
+wfLoadExtension( 'MsCalendar' );
 
 Then run the update script to create the necessary tables (see 
https://www.mediawiki.org/wiki/Manual:Update.php).
 
@@ -14,7 +14,7 @@
 -
 To insert a calendar into a wiki page, simply edit a page and add the 
following wikitext:
 
-Name of the calendar
+Name of the calendar
 
 You can insert as many calendars as you want, but each must have a unique name.
 
@@ -22,7 +22,7 @@
 -
 The events of each day are sorted alphabetically. You can also sort them by id 
by doing:
 
-Name of the calendar
+Name of the calendar
 
 Credits
 ---
diff --git a/extension.json b/extension.json
new file mode 100644
index 000..98ab044
--- /dev/null
+++ b/extension.json
@@ -0,0 +1,75 @@
+{
+   "name": "MsCalendar",
+   "version": "2.2",
+   "author": [
+   "[mailto:w...@ratin.de Martin Schwindl]",
+   "[mailto:w...@keyler-consult.de Martin Keyler]",
+   "[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis 
Felipe Schenone]",
+   "[https://www.mediawiki.org/wiki/User:Fraifrai Frédéric 
Souchon]"
+   ],
+   "url": "https://www.mediawiki.org/wiki/Extension:MsCalendar";,
+   "descriptionmsg": "msc-desc",
+   "license-name": "GPLv3",
+   "type": "parserhook",
+   "MessagesDirs": {
+   "MsCalendar": [
+   "i18n"
+   ]
+   },
+   "AutoloadClasses": {
+   "MsCalendar": "MsCalendar.body.php"
+   },
+   "ResourceModules": {
+   "ext.MsCalendar": {
+   "scripts": [
+   "js/jquery.calendario.js",
+   "js/MsCalendar.js"
+   ],
+   "styles": "MsCalendar.css",
+   "messages": [
+   "msc-desc",
+   "msc-notfirstday",
+   "msc-change",
+   "msc-remove",
+   "msc-create",
+   "msc-cancel",
+   "msc-eventname",
+   "msc-eventdate",
+   "msc-eventduration",
+   "msc-eventyearly",
+   "msc-eventedit",
+   "msc-eventcreate",
+   "msc-today",
+   "msc-todaylabel",
+   "msc-months",
+   "msc-days"
+   ],
+   "dependencies": [
+   "jquery.ui.dialog",
+   "jquery.ui.datepicker"
+   ]
+   }
+   },
+   "ResourceFileModulePaths": {
+   "localBasePath": "",
+   "remoteExtPath": "MsCalendar"
+   },
+   "Hooks": {
+   "Par

[MediaWiki-commits] [Gerrit] Provide missing license lable to show on "Special:Version" - change (mediawiki...LastUserLogin)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Provide missing license lable to show on "Special:Version"
..


Provide missing license lable to show on "Special:Version"

* License per COPYING file
* Some tiny formatting tweaks

Bug: T123943
Change-Id: I297b6c0b220a3f33a842e1f284ff9ffb05370b87
---
M LastUserLogin.php
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/LastUserLogin.php b/LastUserLogin.php
index 8f5567d..896ef82 100644
--- a/LastUserLogin.php
+++ b/LastUserLogin.php
@@ -14,7 +14,7 @@
  * with this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
- * 
+ *
  * @file
  */
 
@@ -22,9 +22,15 @@
'path' => __FILE__,
'name' => 'LastUserLogin',
'version' => '1.3',
-   'author' => array( 'Justin G. Cramer', 'Danila Ulyanov', 'Thomas 
Klein', 'Luis Felipe Schenone' ),
+   'author' => array(
+   'Justin G. Cramer',
+   'Danila Ulyanov',
+   'Thomas Klein',
+   'Luis Felipe Schenone'
+   ),
'url' => 'https://www.mediawiki.org/wiki/Extension:LastUserLogin',
'descriptionmsg' => 'lastuserlogin-desc',
+   'license-name' => 'GPL-3.0+'
 );
 
 $wgAutoloadClasses['LastUserLogin'] = __DIR__ . '/LastUserLogin.body.php';
@@ -39,4 +45,4 @@
 $wgSpecialPages['LastUserLogin'] = 'LastUserLogin';
 
 // Register the method that updates the database when a user logs in
-$wgExtensionFunctions[] = 'LastUserLogin::updateUserTouched';
\ No newline at end of file
+$wgExtensionFunctions[] = 'LastUserLogin::updateUserTouched';

-- 
To view, visit https://gerrit.wikimedia.org/r/283393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I297b6c0b220a3f33a842e1f284ff9ffb05370b87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LastUserLogin
Gerrit-Branch: master
Gerrit-Owner: Kghbln 
Gerrit-Reviewer: Felipeschenone 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add support for specifying page, chapter, volume, etc. - change (mediawiki...Cite)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280923

Change subject: Add support for specifying page, chapter, volume, etc.
..

Add support for specifying page, chapter, volume, etc.

Adding an arbitrary parameter to a  tag will now extend the little number
that links to the reference by adding a comma, followed by the name of the
parameter, a space, and the value.

For example  will generate a reference and the
little link to it will look like so: [1, page 3]

Multiple extra parameters and abbreviations are also possible:
 will produce [1, p. 3, vol. 2]

Bug: T100645
Change-Id: I8288d3d514aa7d50154aeda941c7787827746642
---
M .gitignore
M Cite_body.php
2 files changed, 83 insertions(+), 81 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/23/280923/1

diff --git a/.gitignore b/.gitignore
index 4284dfa..253ad31 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+.DS_Store
 .svn
 *~
 *.kate-swp
diff --git a/Cite_body.php b/Cite_body.php
index 3cdabba..a8f5e0f 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -235,13 +235,28 @@
 * @return string
 */
function guardedRef( $str, array $argv, Parser $parser, $default_group 
= self::DEFAULT_GROUP ) {
+   global $wgAllowCiteGroups;
+
$this->mParser = $parser;
 
-   # The key here is the "name" attribute.
-   list( $key, $group, $follow ) = $this->refArg( $argv );
+   // Do some validation
+   if ( array_key_exists( 'name', $argv ) and array_key_exists( 
'follow', $argv ) ) {
+   return;
+   }
+   if ( !array_key_exists( 'name', $argv ) and array_key_exists( 
'group', $argv ) ) {
+   return;
+   }
+   if ( array_key_exists( 'group', $argv ) and !$wgAllowCiteGroups 
) {
+   return;
+   }
+
+   $key = array_key_exists( 'name', $argv ) ? $argv['name'] : null;
+   $group = array_key_exists( 'group', $argv ) ? $argv['group'] : 
null;
+   $follow = array_key_exists( 'follow', $argv ) ? $argv['follow'] 
: null;
 
# Split these into groups.
if ( $group === null ) {
+
if ( $this->mInReferences ) {
$group = $this->mReferencesGroup;
} else {
@@ -368,72 +383,10 @@
}
 
/**
-* Parse the arguments to the  tag
-*
-*  "name" : Key of the reference.
-*  "group" : Group to which it belongs. Needs to be passed to 
 too.
-*  "follow" : If the current reference is the continuation of another, 
key of that reference.
-*
-*
-* @param string[] $argv The argument vector
-* @return mixed false on invalid input, a string on valid
-*   input and null on no input
-*/
-   function refArg( array $argv ) {
-   global $wgAllowCiteGroups;
-   $cnt = count( $argv );
-   $group = null;
-   $key = null;
-   $follow = null;
-
-   if ( $cnt > 2 ) {
-   // There should only be one key or follow parameter, 
and one group parameter
-   // FIXME : this looks inconsistent, it should probably 
return a tuple
-   return false;
-   } elseif ( $cnt >= 1 ) {
-   if ( isset( $argv['name'] ) && isset( $argv['follow'] ) 
) {
-   return array( false, false, false );
-   }
-   if ( isset( $argv['name'] ) ) {
-   // Key given.
-   $key = Sanitizer::escapeId( $argv['name'], 
'noninitial' );
-   unset( $argv['name'] );
-   --$cnt;
-   }
-   if ( isset( $argv['follow'] ) ) {
-   // Follow given.
-   $follow = Sanitizer::escapeId( $argv['follow'], 
'noninitial' );
-   unset( $argv['follow'] );
-   --$cnt;
-   }
-   if ( isset( $argv['group'] ) ) {
-   if ( !$wgAllowCiteGroups ) {
-   // remove when groups are fully tested.
-   return array( false );
-   }
-   // Group given.
-   $group = $argv['group'];
-   unset( $argv['group'] );
-   --$cnt;
-   }
-
-   if ( $cnt === 0 ) {
-  

[MediaWiki-commits] [Gerrit] Bugfix and enhancements - change (wikipedia...Formicarium)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/248279

Change subject: Bugfix and enhancements
..

Bugfix and enhancements

Change-Id: I61291318496654e4231b4090428a37fe59c4c005
---
M Formicarium.css
M Formicarium.js
M README.md
3 files changed, 242 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikipedia/wikiwidgets/Formicarium 
refs/changes/79/248279/1

diff --git a/Formicarium.css b/Formicarium.css
index 33b9af0..42464ce 100644
--- a/Formicarium.css
+++ b/Formicarium.css
@@ -7,14 +7,15 @@
margin: 5px 0;
 }
 
-.FormicariumMenu .button {
+.FormicariumButton {
cursor: pointer;
display: inline;
margin-right: 7px;
padding: 5px;
+   user-select: none;
 }
 
-.FormicariumMenu .button.active {
+.FormicariumButton.active {
background: #a7dcff;
 }
 
diff --git a/Formicarium.js b/Formicarium.js
index c476133..e277d7a 100644
--- a/Formicarium.js
+++ b/Formicarium.js
@@ -67,89 +67,92 @@
mw.messages.set( Formicarium.messages[ mw.config.get( 
'wgUserLanguage' ) ] );
 
// Build the GUI and bind the events
-   Formicarium.gui.buildAndBind()
+   Formicarium.gui.init();
 
// Set the default action 
-   $( '.FormicariumAntButton' ).click();
+   Formicarium.gui.clickAntButton();
 
// Add a single ant in the center
-   Formicarium.board.addAnt( 0, 0, 'red' );
+   Formicarium.board.addAnt();
Formicarium.board.fill();
},
 
+   /**
+* Graphical User Interface
+*/
gui: {
-   buildAndBind: function () {
-   var wikiwidget = $( 
'.WikiWidget[data-wikiwidget="Formicarium"]' );
-   var canvas = $( '' ).attr( 'class', 
'FormicariumCanvas' );
-   var menu = $( '' ).attr( 'class', 
'FormicariumMenu' );
+   init: function () {
+   var container = $( 
'.WikiWidget[data-wikiwidget="Formicarium"]' ),
+   canvas = $( '' ).attr( 'class', 
'FormicariumCanvas' ),
+   menu = $( '' ).attr( 'class', 
'FormicariumMenu' );
 
var antButton = $( '' ).attr({
-   'class': 'button FormicariumAntButton',
+   'class': 'FormicariumButton 
FormicariumAntButton',
'src': 
'//upload.wikimedia.org/wikipedia/commons/a/a9/WikiWidgetAntButton.png',
'title': mw.message( 'ant-button-tooltip' ),
'alt': mw.message( 'ant-button' ),
});
var cellButton = $( '' ).attr({
-   'class': 'button FormicariumCellButton',
+   'class': 'FormicariumButton 
FormicariumCellButton',
'src': 
'//upload.wikimedia.org/wikipedia/commons/f/ff/WikiWidgetCellButton.png',
'title': mw.message( 'cell-button-tooltip' ),
'alt': mw.message( 'cell-button' )
});
var moveButton = $( '' ).attr({
-   'class': 'button FormicariumMoveButton',
+   'class': 'FormicariumButton 
FormicariumMoveButton',
'src': 
'//upload.wikimedia.org/wikipedia/commons/1/15/WikiWidgetMoveButton.png',
'title': mw.message( 'move-button-tooltip' ),
'alt': mw.message( 'move-button' )
});
var zoomInButton = $( '' ).attr({
-   'class': 'button FormicariumZoomInButton',
+   'class': 'FormicariumButton 
FormicariumZoomInButton',
'src': 
'//upload.wikimedia.org/wikipedia/commons/2/2e/WikiWidgetZoomInButton.png',
'title': mw.message( 'zoom-in-button-tooltip' ),
'alt': mw.message( 'zoom-in-button' )
});
var zoomOutButton = $( '' ).attr({
-   'class': 'button FormicariumZoomOutButton',
+   'class': 'FormicariumButton 
FormicariumZoomOutButton',
'src': 
'//upload.wikimedia.org/wikipedia/commons/6/63/WikiWidgetZoomOutButton.png',
'title': mw.message( 'zoom-out-button-tooltip' 
),
'alt': mw.message( 'zoom-out-button' )
});
var gridButton = $( '' ).attr({
-   'class': 'button Fo

[MediaWiki-commits] [Gerrit] Fixing and tags - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixing  and  tags
..


Fixing  and  tags

Change-Id: I3d009d4efb7b770c98ea035ea5903fc5bcdbe23d
---
M MobileDetect.body.php
A MobileDetect.mobileonly.css
A MobileDetect.nomobile.css
M MobileDetect.php
4 files changed, 32 insertions(+), 8 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MobileDetect.body.php b/MobileDetect.body.php
index 77dbc44..70b1016 100644
--- a/MobileDetect.body.php
+++ b/MobileDetect.body.php
@@ -2,6 +2,11 @@
 
 class MobileDetect {
 
+   public static function addModule( &$output ) {
+   $output->addModules( 'ext.MobileDetect' );
+   return true;
+   }
+
public static function setParserHook( &$parser ) {
$parser->setHook( 'nomobile', 'MobileDetect::nomobile' );
$parser->setHook( 'mobileonly', 'MobileDetect::mobileonly' );
@@ -9,17 +14,11 @@
}
 
public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
-   if ( self::isMobile() ) {
-   return '';
-   }
-   return $parser->recursiveTagParse( $input );
+   return '' . $parser->recursiveTagParse( 
$input ) . '';
}
 
public static function mobileonly( $input, array $args, Parser $parser, 
PPFrame $frame ) {
-   if ( self::isMobile() ) {
-   return $parser->recursiveTagParse( $input );
-   }
-   return '';
+   return '' . $parser->recursiveTagParse( 
$input ) . '';
}
 
public static function isMobile() {
diff --git a/MobileDetect.mobileonly.css b/MobileDetect.mobileonly.css
new file mode 100644
index 000..21b0acf
--- /dev/null
+++ b/MobileDetect.mobileonly.css
@@ -0,0 +1,7 @@
+#bo-content {
+   background: red;
+}
+
+.nomobile {
+   display: none;
+}
\ No newline at end of file
diff --git a/MobileDetect.nomobile.css b/MobileDetect.nomobile.css
new file mode 100644
index 000..6de7a00
--- /dev/null
+++ b/MobileDetect.nomobile.css
@@ -0,0 +1,7 @@
+#bo-content {
+   background: green;
+}
+
+.mobileonly {
+   display: none;
+}
\ No newline at end of file
diff --git a/MobileDetect.php b/MobileDetect.php
index 76491f8..69a8377 100644
--- a/MobileDetect.php
+++ b/MobileDetect.php
@@ -14,8 +14,19 @@
 
 $wgAutoloadClasses['MobileDetect'] = __DIR__ . '/MobileDetect.body.php';
 
+$wgHooks['BeforePageDisplay'][] = 'MobileDetect::addModule';
 $wgHooks['ParserFirstCallInit'][] = 'MobileDetect::setParserHook';
 
+$wgResourceModules['ext.MobileDetect'] = array(
+   'localBasePath' => __DIR__,
+   'remoteExtPath' => 'MobileDetect',
+);
+if ( MobileDetect::isMobile() ) {
+   $wgResourceModules['ext.MobileDetect']['styles'] = 
'MobileDetect.mobileonly.css';
+} else {
+   $wgResourceModules['ext.MobileDetect']['styles'] = 
'MobileDetect.nomobile.css';
+}
+
 // Backwards compatibility
 function mobiledetect() {
return MobileDetect::isMobile();

-- 
To view, visit https://gerrit.wikimedia.org/r/238714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d009d4efb7b770c98ea035ea5903fc5bcdbe23d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileDetect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixing and tags - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/238714

Change subject: Fixing  and  tags
..

Fixing  and  tags

Change-Id: I3d009d4efb7b770c98ea035ea5903fc5bcdbe23d
---
M MobileDetect.body.php
A MobileDetect.mobileonly.css
A MobileDetect.nomobile.css
M MobileDetect.php
4 files changed, 32 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileDetect 
refs/changes/14/238714/1

diff --git a/MobileDetect.body.php b/MobileDetect.body.php
index 77dbc44..70b1016 100644
--- a/MobileDetect.body.php
+++ b/MobileDetect.body.php
@@ -2,6 +2,11 @@
 
 class MobileDetect {
 
+   public static function addModule( &$output ) {
+   $output->addModules( 'ext.MobileDetect' );
+   return true;
+   }
+
public static function setParserHook( &$parser ) {
$parser->setHook( 'nomobile', 'MobileDetect::nomobile' );
$parser->setHook( 'mobileonly', 'MobileDetect::mobileonly' );
@@ -9,17 +14,11 @@
}
 
public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
-   if ( self::isMobile() ) {
-   return '';
-   }
-   return $parser->recursiveTagParse( $input );
+   return '' . $parser->recursiveTagParse( 
$input ) . '';
}
 
public static function mobileonly( $input, array $args, Parser $parser, 
PPFrame $frame ) {
-   if ( self::isMobile() ) {
-   return $parser->recursiveTagParse( $input );
-   }
-   return '';
+   return '' . $parser->recursiveTagParse( 
$input ) . '';
}
 
public static function isMobile() {
diff --git a/MobileDetect.mobileonly.css b/MobileDetect.mobileonly.css
new file mode 100644
index 000..21b0acf
--- /dev/null
+++ b/MobileDetect.mobileonly.css
@@ -0,0 +1,7 @@
+#bo-content {
+   background: red;
+}
+
+.nomobile {
+   display: none;
+}
\ No newline at end of file
diff --git a/MobileDetect.nomobile.css b/MobileDetect.nomobile.css
new file mode 100644
index 000..6de7a00
--- /dev/null
+++ b/MobileDetect.nomobile.css
@@ -0,0 +1,7 @@
+#bo-content {
+   background: green;
+}
+
+.mobileonly {
+   display: none;
+}
\ No newline at end of file
diff --git a/MobileDetect.php b/MobileDetect.php
index 76491f8..69a8377 100644
--- a/MobileDetect.php
+++ b/MobileDetect.php
@@ -14,8 +14,19 @@
 
 $wgAutoloadClasses['MobileDetect'] = __DIR__ . '/MobileDetect.body.php';
 
+$wgHooks['BeforePageDisplay'][] = 'MobileDetect::addModule';
 $wgHooks['ParserFirstCallInit'][] = 'MobileDetect::setParserHook';
 
+$wgResourceModules['ext.MobileDetect'] = array(
+   'localBasePath' => __DIR__,
+   'remoteExtPath' => 'MobileDetect',
+);
+if ( MobileDetect::isMobile() ) {
+   $wgResourceModules['ext.MobileDetect']['styles'] = 
'MobileDetect.mobileonly.css';
+} else {
+   $wgResourceModules['ext.MobileDetect']['styles'] = 
'MobileDetect.nomobile.css';
+}
+
 // Backwards compatibility
 function mobiledetect() {
return MobileDetect::isMobile();

-- 
To view, visit https://gerrit.wikimedia.org/r/238714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d009d4efb7b770c98ea035ea5903fc5bcdbe23d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileDetect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update MsUpload tests - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Update MsUpload tests
..


Update MsUpload tests

Requires https://gerrit.wikimedia.org/r/#/c/225231/

Change-Id: I350561b14a778506aba28cf89f0ab041ea15eb7c
---
A .jscsrc
A .jshintignore
A .jshintrc
A Gruntfile.js
A composer.json
A package.json
6 files changed, 86 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.jscsrc b/.jscsrc
new file mode 100644
index 000..9d22e3f
--- /dev/null
+++ b/.jscsrc
@@ -0,0 +1,3 @@
+{
+   "preset": "wikimedia"
+}
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 000..3c3629e
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 000..66e3d48
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,24 @@
+{
+   // Enforcing
+   "bitwise": true,
+   "eqeqeq": true,
+   "freeze": true,
+   "latedef": true,
+   "noarg": true,
+   "nonew": true,
+   "undef": true,
+   "unused": true,
+   "strict": false,
+
+   // Relaxing
+   "es5": false,
+
+   // Environment
+   "browser": true,
+   "jquery": true,
+
+   "globals": {
+   "mediaWiki": false,
+   "OO": false
+   }
+}
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 000..7b0f3f2
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,34 @@
+/*jshint node:true */
+module.exports = function ( grunt ) {
+   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+   grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
+   grunt.loadNpmTasks( 'grunt-jscs' );
+
+   grunt.initConfig( {
+   jshint: {
+   options: {
+   jshintrc: true
+   },
+   all: [
+   '*.js'
+   ]
+   },
+   jscs: {
+   src: '<%= jshint.all %>'
+   },
+   banana: {
+   all: 'i18n/'
+   },
+   jsonlint: {
+   all: [
+   '*.json',
+   'i18n/*.json',
+   '!node_modules/**'
+   ]
+   }
+   } );
+
+   grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ] 
);
+   grunt.registerTask( 'default', 'test' );
+};
diff --git a/composer.json b/composer.json
new file mode 100644
index 000..7e86f90
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,11 @@
+{
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.*"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor"
+   ]
+   }
+
+}
diff --git a/package.json b/package.json
new file mode 100644
index 000..93beca9
--- /dev/null
+++ b/package.json
@@ -0,0 +1,13 @@
+{
+  "scripts": {
+"test": "grunt test"
+  },
+  "devDependencies": {
+"grunt": "0.4.5",
+"grunt-cli": "0.1.13",
+"grunt-contrib-jshint": "0.11.2",
+"grunt-banana-checker": "0.2.2",
+"grunt-jscs": "1.8.0",
+"grunt-jsonlint": "1.0.4"
+  }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/225235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I350561b14a778506aba28cf89f0ab041ea15eb7c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove i18n shim - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Remove i18n shim
..


Remove i18n shim

Change-Id: I9fec66b50895a945faa70fab81d6485cc5abcb9b
---
D MsUpload.i18n.php
M MsUpload.php
2 files changed, 0 insertions(+), 36 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsUpload.i18n.php b/MsUpload.i18n.php
deleted file mode 100644
index dc970ba..000
--- a/MsUpload.i18n.php
+++ /dev/null
@@ -1,35 +0,0 @@
-https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
- *
- * Beginning with MediaWiki 1.23, translation strings are stored in json files,
- * and the EXTENSION.i18n.php file only exists to provide compatibility with
- * older releases of MediaWiki. For more information about this migration, see:
- * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
- *
- * This shim maintains compatibility back to MediaWiki 1.17.
- */
-$messages = array();
-if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
-   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
-   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
-   foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
-   if ( is_readable( $fileName ) ) {
-   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
-   foreach ( array_keys( $data ) as $key ) {
-   if ( $key === '' || $key[0] === '@' ) {
-   unset( $data[$key] );
-   }
-   }
-   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
-   }
-
-   $cachedData['deps'][] = new FileDependency( $fileName );
-   }
-   return true;
-   }
-
-   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
-}
diff --git a/MsUpload.php b/MsUpload.php
index b35b559..033eefc 100644
--- a/MsUpload.php
+++ b/MsUpload.php
@@ -38,7 +38,6 @@
'remoteExtPath' => 'MsUpload',
 );
 
-$wgExtensionMessagesFiles['MsUpload'] = __DIR__ . '/MsUpload.i18n.php';
 $wgMessagesDirs['MsUpload'] = __DIR__ . '/i18n';
 
 $wgAutoloadClasses['MsUpload'] = __DIR__ . '/MsUpload.body.php';

-- 
To view, visit https://gerrit.wikimedia.org/r/225233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fec66b50895a945faa70fab81d6485cc5abcb9b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add images/cache (default directory for file cache) to .giti... - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/205015

Change subject: Add images/cache (default directory for file cache) to 
.gitignore
..

Add images/cache (default directory for file cache) to .gitignore

See http://www.mediawiki.org/wiki/Manual:$wgFileCacheDirectory

Change-Id: I5228414291bf098886cdf31ef760acd203d8604b
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/15/205015/1

diff --git a/.gitignore b/.gitignore
index b1649df..26f0953 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,7 @@
 /images/lockdir
 /images/temp
 /images/thumb
+/images/cache
 ## Extension:EasyTimeline
 /images/timeline
 /images/tmp

-- 
To view, visit https://gerrit.wikimedia.org/r/205015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5228414291bf098886cdf31ef760acd203d8604b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor fixes and improvements - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Minor fixes and improvements
..


Minor fixes and improvements

Change-Id: I5d843550ef795bde08637ee98ce1c4d585ecb4d0
---
A COPYING
M YotpoReviews.body.php
M YotpoReviews.php
M i18n/en.json
4 files changed, 301 insertions(+), 18 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/COPYING b/COPYING
new file mode 100644
index 000..4eb3f1e
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,278 @@
+   GNU GENERAL PUBLIC LICENSE
+  Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+   Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Lesser General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep intact all the
+notices that refer to this License and to the absen

[MediaWiki-commits] [Gerrit] Minor fixes and improvements - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/199602

Change subject: Minor fixes and improvements
..

Minor fixes and improvements

Change-Id: I5d843550ef795bde08637ee98ce1c4d585ecb4d0
---
A COPYING
M YotpoReviews.body.php
M YotpoReviews.php
M i18n/en.json
4 files changed, 301 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/YotpoReviews 
refs/changes/02/199602/1

diff --git a/COPYING b/COPYING
new file mode 100644
index 000..4eb3f1e
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,278 @@
+   GNU GENERAL PUBLIC LICENSE
+  Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+   Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Lesser General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep int

[MediaWiki-commits] [Gerrit] Fixed the README and added .gitignore - change (mediawiki...LastUserLogin)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixed the README and added .gitignore
..


Fixed the README and added .gitignore

Change-Id: I313f95828bc2f187a149bdb55e7a9367ed1856d3
---
A .gitignore
M README
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/README b/README
index cd81425..e501244 100644
--- a/README
+++ b/README
@@ -10,6 +10,6 @@
 
 Usage
 -
-Once installed, simply visit Special:LastUserLogin to see the times at which 
each user last logged in. Only users with the 'userlogin' right can view the 
special pages and by default only admins (sysops) are given the right. To give 
the right to other user groups (for example the 'bureaucrat' group) simply add 
the following to your LocalSettings.php:
+Once installed, visit Special:LastUserLogin to see the times at which each 
user last logged in. Only users with the 'lastlogin' right can view the special 
pages and by default only admins (sysops) are given the right. To give the 
right to other user groups (for example the 'bureaucrat' group) simply add the 
following to your LocalSettings.php:
 
$wgGroupPermissions['bureaucrat']['lastlogin'] = true;
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/198745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I313f95828bc2f187a149bdb55e7a9367ed1856d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LastUserLogin
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed the README and added .gitignore - change (mediawiki...LastUserLogin)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/198745

Change subject: Fixed the README and added .gitignore
..

Fixed the README and added .gitignore

Change-Id: I313f95828bc2f187a149bdb55e7a9367ed1856d3
---
A .gitignore
M README
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LastUserLogin 
refs/changes/45/198745/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/README b/README
index cd81425..e501244 100644
--- a/README
+++ b/README
@@ -10,6 +10,6 @@
 
 Usage
 -
-Once installed, simply visit Special:LastUserLogin to see the times at which 
each user last logged in. Only users with the 'userlogin' right can view the 
special pages and by default only admins (sysops) are given the right. To give 
the right to other user groups (for example the 'bureaucrat' group) simply add 
the following to your LocalSettings.php:
+Once installed, visit Special:LastUserLogin to see the times at which each 
user last logged in. Only users with the 'lastlogin' right can view the special 
pages and by default only admins (sysops) are given the right. To give the 
right to other user groups (for example the 'bureaucrat' group) simply add the 
following to your LocalSettings.php:
 
$wgGroupPermissions['bureaucrat']['lastlogin'] = true;
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/198745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I313f95828bc2f187a149bdb55e7a9367ed1856d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LastUserLogin
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...LastUserLogin)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Initial commit
..


Initial commit

Change-Id: I135ca16398f02d4f1c573e3d9627653f6a83c2f9
---
A COPYING
A LastUserLogin.alias.php
A LastUserLogin.body.php
A LastUserLogin.i18n.php
A LastUserLogin.php
A README
A i18n/af.json
A i18n/aln.json
A i18n/ar.json
A i18n/arc.json
A i18n/az.json
A i18n/be-tarask.json
A i18n/bg.json
A i18n/bn.json
A i18n/br.json
A i18n/bs.json
A i18n/ca.json
A i18n/ce.json
A i18n/cs.json
A i18n/csb.json
A i18n/de.json
A i18n/diq.json
A i18n/dsb.json
A i18n/el.json
A i18n/en.json
A i18n/eo.json
A i18n/es.json
A i18n/et.json
A i18n/eu.json
A i18n/fa.json
A i18n/fi.json
A i18n/fr.json
A i18n/frp.json
A i18n/ga.json
A i18n/gl.json
A i18n/gsw.json
A i18n/he.json
A i18n/hi.json
A i18n/hsb.json
A i18n/hu.json
A i18n/ia.json
A i18n/id.json
A i18n/it.json
A i18n/ja.json
A i18n/ka.json
A i18n/km.json
A i18n/ksh.json
A i18n/ku-latn.json
A i18n/la.json
A i18n/lb.json
A i18n/lg.json
A i18n/lt.json
A i18n/mk.json
A i18n/mr.json
A i18n/ms.json
A i18n/nb.json
A i18n/nl.json
A i18n/nn.json
A i18n/pa.json
A i18n/pdc.json
A i18n/pl.json
A i18n/pms.json
A i18n/ps.json
A i18n/pt-br.json
A i18n/pt.json
A i18n/qqq.json
A i18n/ro.json
A i18n/ru.json
A i18n/si.json
A i18n/sr-ec.json
A i18n/sr-el.json
A i18n/sv.json
A i18n/ta.json
A i18n/te.json
A i18n/tl.json
A i18n/tr.json
A i18n/uk.json
A i18n/ur.json
A i18n/vi.json
A i18n/yi.json
A i18n/zh-hans.json
A i18n/zh-hant.json
82 files changed, 2,069 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+  Finally, eve

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...LastUserLogin)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/198737

Change subject: Initial commit
..

Initial commit

Change-Id: I135ca16398f02d4f1c573e3d9627653f6a83c2f9
---
A COPYING
A LastUserLogin.alias.php
A LastUserLogin.body.php
A LastUserLogin.i18n.php
A LastUserLogin.php
A README
A i18n/af.json
A i18n/aln.json
A i18n/ar.json
A i18n/arc.json
A i18n/az.json
A i18n/be-tarask.json
A i18n/bg.json
A i18n/bn.json
A i18n/br.json
A i18n/bs.json
A i18n/ca.json
A i18n/ce.json
A i18n/cs.json
A i18n/csb.json
A i18n/de.json
A i18n/diq.json
A i18n/dsb.json
A i18n/el.json
A i18n/en.json
A i18n/eo.json
A i18n/es.json
A i18n/et.json
A i18n/eu.json
A i18n/fa.json
A i18n/fi.json
A i18n/fr.json
A i18n/frp.json
A i18n/ga.json
A i18n/gl.json
A i18n/gsw.json
A i18n/he.json
A i18n/hi.json
A i18n/hsb.json
A i18n/hu.json
A i18n/ia.json
A i18n/id.json
A i18n/it.json
A i18n/ja.json
A i18n/ka.json
A i18n/km.json
A i18n/ksh.json
A i18n/ku-latn.json
A i18n/la.json
A i18n/lb.json
A i18n/lg.json
A i18n/lt.json
A i18n/mk.json
A i18n/mr.json
A i18n/ms.json
A i18n/nb.json
A i18n/nl.json
A i18n/nn.json
A i18n/pa.json
A i18n/pdc.json
A i18n/pl.json
A i18n/pms.json
A i18n/ps.json
A i18n/pt-br.json
A i18n/pt.json
A i18n/qqq.json
A i18n/ro.json
A i18n/ru.json
A i18n/si.json
A i18n/sr-ec.json
A i18n/sr-el.json
A i18n/sv.json
A i18n/ta.json
A i18n/te.json
A i18n/tl.json
A i18n/tr.json
A i18n/uk.json
A i18n/ur.json
A i18n/vi.json
A i18n/yi.json
A i18n/zh-hans.json
A i18n/zh-hant.json
82 files changed, 2,069 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LastUserLogin 
refs/changes/37/198737/1

diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the 

[MediaWiki-commits] [Gerrit] Updated in-wiki version to latest standards - change (mediawiki...MsCalendar)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updated in-wiki version to latest standards
..


Updated in-wiki version to latest standards

Change-Id: I2cf806382b2186282b0badd031864ec176f10a7f
---
A .gitignore
A COPYING
A MsCalendar.body.php
A MsCalendar.css
A MsCalendar.i18n.php
A MsCalendar.php
A MsCalendar.sql
A README.md
A i18n/de.json
A i18n/en.json
A i18n/fr.json
A images/calendar-icon-today.png
A images/calendar-select.png
A images/exclamation-red.png
A js/MsCalendar.js
A js/jquery.calendario.js
16 files changed, 2,096 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+  Finally, every program is threatened constantly by software patents.
+States should not allow patents to restrict development and use of
+software on general-purpose computers, but in those that do, we wish to
+avoid the special danger that patents applied to a free program could
+make it effectively proprietary.  To prevent this, the GPL assures that
+patents cannot be used to render the program non-free.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   TERMS AND CONDITIONS
+
+  0. Definitions.
+
+  "This License" refers to version 3 of the GNU General Public License.
+
+  "Copyright" also means copyright-like laws that apply to other kinds of
+works, such as semiconductor masks.
+
+  "The Program" 

[MediaWiki-commits] [Gerrit] Updated in-wiki version to latest standards - change (mediawiki...MsCalendar)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/196595

Change subject: Updated in-wiki version to latest standards
..

Updated in-wiki version to latest standards

Change-Id: I2cf806382b2186282b0badd031864ec176f10a7f
---
A .gitignore
A COPYING
A MsCalendar.body.php
A MsCalendar.css
A MsCalendar.i18n.php
A MsCalendar.php
A MsCalendar.sql
A README.md
A i18n/de.json
A i18n/en.json
A i18n/fr.json
A images/calendar-icon-today.png
A images/calendar-select.png
A images/exclamation-red.png
A js/MsCalendar.js
A js/jquery.calendario.js
16 files changed, 2,096 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCalendar 
refs/changes/95/196595/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+  Finally, every program is threatened constantly by software patents.
+States should not allow patents to restrict development and use of
+software on general-purpose computers, but in those that do, we wish to
+avoid the special danger that patents applied to a free program could
+make it effectively proprietary.  To prevent this, the GPL assures that
+patents cannot be used to render the program non-free.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   TERMS AND CONDITIONS
+
+  0. Definitions.
+
+  "This License" refers to version 3 of the GNU General Public License.
+
+  "Copyright" also means copyright-like laws that apply to other kin

[MediaWiki-commits] [Gerrit] Debugged and improved the keyMatch method - change (mediawiki...ConfirmEdit)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193529

Change subject: Debugged and improved the keyMatch method
..

Debugged and improved the keyMatch method

The keyMatch method did NOT normalise correctly the answers inside an array.
Now it does.
I've also added trimming for extra normalisation.
And hopefully made the method a bit clearer to read.

Change-Id: I1874c357a525d5f2e27b27dc640d7fcd9da66524
---
M QuestyCaptcha.class.php
1 file changed, 16 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit 
refs/changes/29/193529/1

diff --git a/QuestyCaptcha.class.php b/QuestyCaptcha.class.php
index 0ab4424..7e816e7 100644
--- a/QuestyCaptcha.class.php
+++ b/QuestyCaptcha.class.php
@@ -10,13 +10,26 @@
 
 class QuestyCaptcha extends SimpleCaptcha {
 
-   /** Validate a captcha response */
+   /**
+* Validate a captcha response
+* Override SimpleCaptcha::keyMatch
+*/
function keyMatch( $answer, $info ) {
if ( is_array( $info['answer'] ) ) {
-   return in_array( strtolower( $answer ), $info['answer'] 
);
+   $correctAnswers = $info['answer'];
} else {
-   return strtolower( $answer ) == strtolower( 
$info['answer'] );
+   $correctAnswers = array( $info['answer'] );
}
+   foreach ( $correctAnswers as $correctAnswer ) {
+   $answer = trim( $answer );
+   $answer = strtolower( $answer );
+   $correctAnswer = trim( $correctAnswer );
+   $correctAnswer = strtolower( $correctAnswer );
+   if ( $answer == $correctAnswer ) {
+   return true;
+   }
+   }
+   return false;
}
 
function addCaptchaAPI( &$resultArr ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/193529
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1874c357a525d5f2e27b27dc640d7fcd9da66524
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Adding COPYING file with the GPLv3 licence - change (mediawiki...Hovergallery)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Adding COPYING file with the GPLv3 licence
..


Adding COPYING file with the GPLv3 licence

Change-Id: Ie89dcd67383f0d05707fde6609d088f6fd306a00
---
A COPYING
1 file changed, 674 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+  Finally, every program is threatened constantly by software patents.
+States should not allow patents to restrict development and use of
+software on general-purpose computers, but in those that do, we wish to
+avoid the special danger that patents applied to a free program could
+make it effectively proprietary.  To prevent this, the GPL assures that
+patents cannot be used to render the program non-free.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   TERMS AND CONDITIONS
+
+  0. Definitions.
+
+  "This License" refers to version 3 of the GNU General Public License.
+
+  "Copyright" also means copyright-like laws that apply to other kinds of
+works, such as semiconductor masks.
+
+  "The Program" refers to any copyrightable work licensed under this
+License.  Each licensee is addressed as "you".  "Licensees" and
+"recipients" may be individuals or organizations.
+
+  To "modify" a work means to copy from or adapt all or part of the work
+in a fashion requiring copyright permission, other than the making of an
+exact copy.  The resulting work is called a "modified version" of the
+earlier work or a work "based on" the earlier work.
+
+  A "covered work" means e

[MediaWiki-commits] [Gerrit] Adding COPYING file with the GPLv3 licence - change (mediawiki...Hovergallery)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/190204

Change subject: Adding COPYING file with the GPLv3 licence
..

Adding COPYING file with the GPLv3 licence

Change-Id: Ie89dcd67383f0d05707fde6609d088f6fd306a00
---
A COPYING
1 file changed, 674 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Hovergallery 
refs/changes/04/190204/1

diff --git a/COPYING b/COPYING
new file mode 100644
index 000..20d40b6
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,674 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. 
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+  The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works.  By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users.  We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors.  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+  To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights.  Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received.  You must make sure that they, too, receive
+or can get the source code.  And you must show them these terms so they
+know their rights.
+
+  Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+  For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software.  For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+  Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so.  This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software.  The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable.  Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products.  If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+  Finally, every program is threatened constantly by software patents.
+States should not allow patents to restrict development and use of
+software on general-purpose computers, but in those that do, we wish to
+avoid the special danger that patents applied to a free program could
+make it effectively proprietary.  To prevent this, the GPL assures that
+patents cannot be used to render the program non-free.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+   TERMS AND CONDITIONS
+
+  0. Definitions.
+
+  "This License" refers to version 3 of the GNU General Public License.
+
+  "Copyright" also means copyright-like laws that apply to other kinds of
+works, such as semiconductor masks.
+
+  "The Program" refers to any copyrightable work licensed under this
+License.  Each licensee is addressed as "you".  "Licensees" and
+"recipients" may be individuals or organizations.
+
+  To "modify" a work means to copy from or adapt all or part of the work
+in a fashion requiring copyright permission, other than the making of an
+exact copy.  The resulting work is called a "modified version" of the
+earlier work or a

[MediaWiki-commits] [Gerrit] Add COPYING and 'license-name' matching SPDX conventions - change (mediawiki...SectionDisqus)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Add COPYING and 'license-name' matching SPDX conventions
..


Add COPYING and 'license-name' matching SPDX conventions

References:
http://spdx.org/licenses/
https://www.mediawiki.org/wiki/Manual:$wgExtensionCredits#license-name

Change-Id: Ib9f7858f0a714d703b019fb8d8028feb066cec52
---
A COPYING
M SectionDisqus.php
2 files changed, 341 insertions(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/COPYING b/COPYING
new file mode 100644
index 000..d159169
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,339 @@
+GNU GENERAL PUBLIC LICENSE
+   Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Lesser General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an 

[MediaWiki-commits] [Gerrit] Hovering over thumbnails now shows them in big - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Hovering over thumbnails now shows them in big
..


Hovering over thumbnails now shows them in big

Change-Id: Ib199462ea9966cadb43e59fc1db5313cef60eec8
---
M MsUpload.css
M MsUpload.js
2 files changed, 20 insertions(+), 3 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsUpload.css b/MsUpload.css
index d445c13..bd25293 100755
--- a/MsUpload.css
+++ b/MsUpload.css
@@ -128,10 +128,21 @@
padding: 2px;
height: 22px;
margin: 1px;
+   cursor: pointer;
 }
 
 #upload-list .file .picture_load canvas {
margin: 1px;
+}
+
+#upload-list .file .picture_load canvas:nth-child(2) {
+   display: none;
+   position: relative;
+   z-index: 10;
+}
+
+#upload-list .file .picture_load:hover canvas:nth-child(2) {
+   display: block;
 }
 
 #upload-list .file .file-title {
@@ -257,14 +268,14 @@
 }
 
 #upload-list .file .input-change {
-   margin: 0px 10px;
+   margin: 0 10px 0 40px;
display: inline;
 }
 
 #upload-list .file .file-size {
color: #666;
 }
- 
+
 #upload-list .file .file-error {
color: #8a1f11;
 }
diff --git a/MsUpload.js b/MsUpload.js
index 40b4e8a..6b3bebf 100755
--- a/MsUpload.js
+++ b/MsUpload.js
@@ -137,7 +137,13 @@
// embed the current thumbnail
this.embed( file.li.type.get( 0 
), {
width: 30,
-   height: 17,
+   height: 40,
+   crop: false
+   });
+   // big thumbnail
+   this.embed( file.li.type.get( 0 
), {
+   width: 300,
+   height: 300,
crop: false
});
};

-- 
To view, visit https://gerrit.wikimedia.org/r/185990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib199462ea9966cadb43e59fc1db5313cef60eec8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hovering over thumbnails now shows them in big - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/185990

Change subject: Hovering over thumbnails now shows them in big
..

Hovering over thumbnails now shows them in big

Change-Id: Ib199462ea9966cadb43e59fc1db5313cef60eec8
---
M MsUpload.css
M MsUpload.js
2 files changed, 20 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsUpload 
refs/changes/90/185990/1

diff --git a/MsUpload.css b/MsUpload.css
index d445c13..bd25293 100755
--- a/MsUpload.css
+++ b/MsUpload.css
@@ -128,10 +128,21 @@
padding: 2px;
height: 22px;
margin: 1px;
+   cursor: pointer;
 }
 
 #upload-list .file .picture_load canvas {
margin: 1px;
+}
+
+#upload-list .file .picture_load canvas:nth-child(2) {
+   display: none;
+   position: relative;
+   z-index: 10;
+}
+
+#upload-list .file .picture_load:hover canvas:nth-child(2) {
+   display: block;
 }
 
 #upload-list .file .file-title {
@@ -257,14 +268,14 @@
 }
 
 #upload-list .file .input-change {
-   margin: 0px 10px;
+   margin: 0 10px 0 40px;
display: inline;
 }
 
 #upload-list .file .file-size {
color: #666;
 }
- 
+
 #upload-list .file .file-error {
color: #8a1f11;
 }
diff --git a/MsUpload.js b/MsUpload.js
index 40b4e8a..6b3bebf 100755
--- a/MsUpload.js
+++ b/MsUpload.js
@@ -137,7 +137,13 @@
// embed the current thumbnail
this.embed( file.li.type.get( 0 
), {
width: 30,
-   height: 17,
+   height: 40,
+   crop: false
+   });
+   // big thumbnail
+   this.embed( file.li.type.get( 0 
), {
+   width: 300,
+   height: 300,
crop: false
});
};

-- 
To view, visit https://gerrit.wikimedia.org/r/185990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib199462ea9966cadb43e59fc1db5313cef60eec8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor bug fix - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Minor bug fix
..


Minor bug fix

Change-Id: I755f726bfe97469140dcbfa98afab6680d5c9f7f
---
M MsCatSelect.js
M MsCatSelect.php
2 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsCatSelect.js b/MsCatSelect.js
index 277e68b..e4cd039 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -67,14 +67,13 @@
 
 function mscsCreateDropDown( maincat, ebene ) {
var dd = jQuery( '' ).attr( 'id', 'mscs_dd_' + ebene ).change( 
function () {
-
var container = jQuery( '#mscs_subcat_' + ebene ).empty();
 
-   if ( jQuery( this ).val() !== 0 ) { //not ---
+   if ( jQuery( this ).val() !== '0' ) { //not ---
selectedCat = jQuery( 'option:selected', this ).text();
-   mscsGetSubcats( selectedCat, ebene,container );
+   mscsGetSubcats( selectedCat, ebene, container );
} else if ( ebene === 0 ) { //--- and nothing
-   selectedCat = ''; //zuruecksetzen
+   selectedCat = ''; //Fall back to the previous category, 
if any
} else {
selectedCat = jQuery( '#MsCatSelect 
option:selected:eq(' + ( ebene - 1 ) + ')' ).text();
}
diff --git a/MsCatSelect.php b/MsCatSelect.php
index 491ee80..9b3bfac 100755
--- a/MsCatSelect.php
+++ b/MsCatSelect.php
@@ -3,7 +3,7 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCatSelect',
'url' => 'http://www.mediawiki.org/wiki/Extension:MsCatSelect',
-   'version' => '6.0',
+   'version' => '6.1',
'descriptionmsg' => 'mscs-desc',
'license-name' => 'GPLv2+',
'author' => array( '[mailto:w...@ratin.de Martin Schwindl]', 
'[mailto:w...@keyler-consult.de Martin Keyler]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/182754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I755f726bfe97469140dcbfa98afab6680d5c9f7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor bug fix - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/182754

Change subject: Minor bug fix
..

Minor bug fix

Change-Id: I755f726bfe97469140dcbfa98afab6680d5c9f7f
---
M MsCatSelect.js
M MsCatSelect.php
2 files changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/54/182754/1

diff --git a/MsCatSelect.js b/MsCatSelect.js
index 277e68b..e4cd039 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -67,14 +67,13 @@
 
 function mscsCreateDropDown( maincat, ebene ) {
var dd = jQuery( '' ).attr( 'id', 'mscs_dd_' + ebene ).change( 
function () {
-
var container = jQuery( '#mscs_subcat_' + ebene ).empty();
 
-   if ( jQuery( this ).val() !== 0 ) { //not ---
+   if ( jQuery( this ).val() !== '0' ) { //not ---
selectedCat = jQuery( 'option:selected', this ).text();
-   mscsGetSubcats( selectedCat, ebene,container );
+   mscsGetSubcats( selectedCat, ebene, container );
} else if ( ebene === 0 ) { //--- and nothing
-   selectedCat = ''; //zuruecksetzen
+   selectedCat = ''; //Fall back to the previous category, 
if any
} else {
selectedCat = jQuery( '#MsCatSelect 
option:selected:eq(' + ( ebene - 1 ) + ')' ).text();
}
diff --git a/MsCatSelect.php b/MsCatSelect.php
index 491ee80..9b3bfac 100755
--- a/MsCatSelect.php
+++ b/MsCatSelect.php
@@ -3,7 +3,7 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCatSelect',
'url' => 'http://www.mediawiki.org/wiki/Extension:MsCatSelect',
-   'version' => '6.0',
+   'version' => '6.1',
'descriptionmsg' => 'mscs-desc',
'license-name' => 'GPLv2+',
'author' => array( '[mailto:w...@ratin.de Martin Schwindl]', 
'[mailto:w...@keyler-consult.de Martin Keyler]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/182754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I755f726bfe97469140dcbfa98afab6680d5c9f7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix embed URL - change (mediawiki...PageDisqus)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fix embed URL
..


Fix embed URL

Add missing / to URLs for Disqus JS files. Not sure why it used to work
in the first place...

Change-Id: I6712b4344a436e88e3347030cc815cb49fd4f618
---
M PageDisqus.body.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/PageDisqus.body.php b/PageDisqus.body.php
index 4873706..f16d8f6 100755
--- a/PageDisqus.body.php
+++ b/PageDisqus.body.php
@@ -35,8 +35,8 @@



-   http://disqus.com/forums' . $wgPageDisqusShortname . '/embed.js">
-   http://disqus.com/forums' . 
$wgPageDisqusShortname . '/?url=ref">' . $noscript . '';
+   http://disqus.com/forums/' . $wgPageDisqusShortname . '/embed.js">
+   http://disqus.com/forums/' . 
$wgPageDisqusShortname . '/?url=ref">' . $noscript . '';
return true;
}
 
@@ -75,4 +75,4 @@
";
return true;
}
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/182199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6712b4344a436e88e3347030cc815cb49fd4f618
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageDisqus
Gerrit-Branch: master
Gerrit-Owner: Wctaiwan 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Adding the name of the special page - change (mediawiki...UserPageViewTracker)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Adding the name of the special page
..


Adding the name of the special page

Change-Id: Iff1c6aa8e2409329c2673d494132c4c8e723d51d
---
M i18n/en.json
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/i18n/en.json b/i18n/en.json
index 974bfb7..3aa9adf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -4,5 +4,6 @@
 "Luis Felipe Schenone"
 ]
 },
-"userpageviewtracker-desc": "[[Special:UserPageViewTracker|Tracks the page 
views per page per user]] and displays it"
+"userpageviewtracker-desc": "[[Special:UserPageViewTracker|Tracks the page 
views per page per user]] and displays it",
+   "userpageviewtracker": "User page view tracker"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/181614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff1c6aa8e2409329c2673d494132c4c8e723d51d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UserPageViewTracker
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Adding the name of the special page - change (mediawiki...UserPageViewTracker)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181614

Change subject: Adding the name of the special page
..

Adding the name of the special page

Change-Id: Iff1c6aa8e2409329c2673d494132c4c8e723d51d
---
M i18n/en.json
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UserPageViewTracker 
refs/changes/14/181614/1

diff --git a/i18n/en.json b/i18n/en.json
index 974bfb7..3aa9adf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -4,5 +4,6 @@
 "Luis Felipe Schenone"
 ]
 },
-"userpageviewtracker-desc": "[[Special:UserPageViewTracker|Tracks the page 
views per page per user]] and displays it"
+"userpageviewtracker-desc": "[[Special:UserPageViewTracker|Tracks the page 
views per page per user]] and displays it",
+   "userpageviewtracker": "User page view tracker"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/181614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff1c6aa8e2409329c2673d494132c4c8e723d51d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UserPageViewTracker
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hover images never go off the screen now - change (mediawiki...Hovergallery)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Hover images never go off the screen now
..


Hover images never go off the screen now

Change-Id: Ie4babddeb9c3498eec55d716aa2c47efd9ceed60
---
M HoverGallery.body.php
M HoverGallery.css
M HoverGallery.js
M HoverGallery.php
4 files changed, 39 insertions(+), 40 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/HoverGallery.body.php b/HoverGallery.body.php
index 3fc4ce7..c6db884 100644
--- a/HoverGallery.body.php
+++ b/HoverGallery.body.php
@@ -8,11 +8,11 @@
}
 
public static function setParserHook( &$parser ) {
-   $parser->setHook( 'hovergallery', 'HoverGallery::renderGallery' 
);
+   $parser->setHook( 'hovergallery', 'HoverGallery::render' );
return true;
}
 
-   public static function renderGallery( $input, array $ARGS, Parser 
$parser, PPFrame $frame ) {
+   public static function render( $input, array $ARGS, Parser $parser, 
PPFrame $frame ) {
 
$maxhoverwidth = '';
$maxhoverheight = '';
@@ -29,8 +29,8 @@
 
$normalGallery = $parser->recursiveTagParse( '' . 
$input . '' );
 
-   $hiddenGallery = '';
-   $FILENAMES = explode( "\n", $input );
+   $hiddenGallery = '';
+   $FILENAMES = explode( PHP_EOL, trim( $input ) );
$FILENAMES = array_filter( $FILENAMES );
foreach ( $FILENAMES as $filename ) {
if ( $maxhoverwidth or $maxhoverheight ) {
diff --git a/HoverGallery.css b/HoverGallery.css
index 5008bcd..34d2aa0 100644
--- a/HoverGallery.css
+++ b/HoverGallery.css
@@ -1,6 +1,7 @@
-div.hover-gallery img {
+div.hovergallery img {
border-radius: 5px;
display: none;
+   pointer-events: none;
position: fixed;
z-index: 99;
 }
\ No newline at end of file
diff --git a/HoverGallery.js b/HoverGallery.js
index 76f9a34..7c5c855 100644
--- a/HoverGallery.js
+++ b/HoverGallery.js
@@ -1,45 +1,43 @@
-(function ($) {
-   $(document).ready(function(){
+$( function () {
 
-   var thumbs, mouseX, mouseY, clientWidth, clientHeight, 
fullImage, fullImageX, fullImageY, fullImageWidth, fullImageHeight;
+   var thumbs, mouseX, mouseY, clientWidth, clientHeight, fullImage, 
fullImageWidth, fullImageHeight, fullImageX, fullImageY, fullImageWidth, 
fullImageHeight;
 
-   // Get all the thumbnails
-   // The normal gallery is right before the hidden gallery, so 
just move to it and select all the images it contains
-   thumbs = $('div.hover-gallery').prev().find('img');
+   // Get all the thumbnails
+   // The normal gallery is right before the hidden gallery, so just move 
to it and select all the images it contains
+   thumbs = $( 'div.hovergallery' ).prev().find( 'img' );
 
-   thumbs.mousemove(function(event){
+   thumbs.mouseenter( function ( event ) {
 
-   // Determine which of the thumbs is it
-   var thumbIndex = $.inArray( this, thumbs );
+   // Determine which of the thumbs is it
+   var thumbIndex = $.inArray( this, thumbs );
 
-   // Get the corresponding full-size image
-   fullImage = $('div.hover-gallery').children().eq( 
thumbIndex ).children();
+   // Get the corresponding full-size image, and its width and 
height
+   fullImage = $( 'div.hovergallery' ).children().eq( thumbIndex 
).children();
 
-   // Calculate the position of the mouse
-   mouseX = event.clientX;
-   mouseY = event.clientY;
+   // Calculate the position of the mouse
+   mouseX = event.clientX;
+   mouseY = event.clientY;
 
-   // Now the position of the top left corner of the full 
image
-   fullImageX = mouseX + 10;
-   fullImageY = mouseY + 10;
+   // Now the position of the top left corner of the full image
+   fullImageX = mouseX + 10;
+   fullImageY = mouseY + 10;
 
-   // If the mouse is very near the border, move the full 
image to the other side
-   clientWidth = document.body.clientWidth;
-   clientHeight = document.body.clientHeight;
-   fullImageWidth = fullImage.width();
-   fullImageHeight = fullImage.height();
-   if ( mouseX + fullImageWidth > clientWidth ) {
-   fullImageX = mouseX - fullImageWidth - 10;
-   }
-   if ( mouseY + fullImageHeight > clientHeight ) {
-   ful

[MediaWiki-commits] [Gerrit] Hover images never go off the screen now - change (mediawiki...Hovergallery)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181260

Change subject: Hover images never go off the screen now
..

Hover images never go off the screen now

Change-Id: Ie4babddeb9c3498eec55d716aa2c47efd9ceed60
---
M HoverGallery.body.php
M HoverGallery.css
M HoverGallery.js
M HoverGallery.php
4 files changed, 39 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Hovergallery 
refs/changes/60/181260/1

diff --git a/HoverGallery.body.php b/HoverGallery.body.php
index 3fc4ce7..c6db884 100644
--- a/HoverGallery.body.php
+++ b/HoverGallery.body.php
@@ -8,11 +8,11 @@
}
 
public static function setParserHook( &$parser ) {
-   $parser->setHook( 'hovergallery', 'HoverGallery::renderGallery' 
);
+   $parser->setHook( 'hovergallery', 'HoverGallery::render' );
return true;
}
 
-   public static function renderGallery( $input, array $ARGS, Parser 
$parser, PPFrame $frame ) {
+   public static function render( $input, array $ARGS, Parser $parser, 
PPFrame $frame ) {
 
$maxhoverwidth = '';
$maxhoverheight = '';
@@ -29,8 +29,8 @@
 
$normalGallery = $parser->recursiveTagParse( '' . 
$input . '' );
 
-   $hiddenGallery = '';
-   $FILENAMES = explode( "\n", $input );
+   $hiddenGallery = '';
+   $FILENAMES = explode( PHP_EOL, trim( $input ) );
$FILENAMES = array_filter( $FILENAMES );
foreach ( $FILENAMES as $filename ) {
if ( $maxhoverwidth or $maxhoverheight ) {
diff --git a/HoverGallery.css b/HoverGallery.css
index 5008bcd..34d2aa0 100644
--- a/HoverGallery.css
+++ b/HoverGallery.css
@@ -1,6 +1,7 @@
-div.hover-gallery img {
+div.hovergallery img {
border-radius: 5px;
display: none;
+   pointer-events: none;
position: fixed;
z-index: 99;
 }
\ No newline at end of file
diff --git a/HoverGallery.js b/HoverGallery.js
index 76f9a34..b6b2af3 100644
--- a/HoverGallery.js
+++ b/HoverGallery.js
@@ -1,45 +1,43 @@
-(function ($) {
-   $(document).ready(function(){
+$( function () {
 
-   var thumbs, mouseX, mouseY, clientWidth, clientHeight, 
fullImage, fullImageX, fullImageY, fullImageWidth, fullImageHeight;
+   var thumbs, mouseX, mouseY, clientWidth, clientHeight, fullImage, 
fullImageWidth, fullImageHeight, fullImageX, fullImageY, fullImageWidth, 
fullImageHeight;
 
-   // Get all the thumbnails
-   // The normal gallery is right before the hidden gallery, so 
just move to it and select all the images it contains
-   thumbs = $('div.hover-gallery').prev().find('img');
+   // Get all the thumbnails
+   // The normal gallery is right before the hidden gallery, so just move 
to it and select all the images it contains
+   thumbs = $( 'div.hovergallery' ).prev().find( 'img' );
 
-   thumbs.mousemove(function(event){
+   thumbs.mouseenter( function ( event ) {
 
-   // Determine which of the thumbs is it
-   var thumbIndex = $.inArray( this, thumbs );
+   // Determine which of the thumbs is it
+   var thumbIndex = $.inArray( this, thumbs );
 
-   // Get the corresponding full-size image
-   fullImage = $('div.hover-gallery').children().eq( 
thumbIndex ).children();
+   // Get the corresponding full-size image, and its width and 
height
+   fullImage = $( 'div.hovergallery' ).children().eq( thumbIndex 
).children();
 
-   // Calculate the position of the mouse
-   mouseX = event.clientX;
-   mouseY = event.clientY;
+   // Calculate the position of the mouse
+   mouseX = event.clientX;
+   mouseY = event.clientY;
 
-   // Now the position of the top left corner of the full 
image
-   fullImageX = mouseX + 10;
-   fullImageY = mouseY + 10;
+   // Now the position of the top left corner of the full image
+   fullImageX = mouseX + 10;
+   fullImageY = mouseY + 10;
 
-   // If the mouse is very near the border, move the full 
image to the other side
-   clientWidth = document.body.clientWidth;
-   clientHeight = document.body.clientHeight;
-   fullImageWidth = fullImage.width();
-   fullImageHeight = fullImage.height();
-   if ( mouseX + fullImageWidth > clientWidth ) {
-   fullImageX = mouseX - fullImageWidth - 10;
-   }
-   if ( mouseY + fullIm

[MediaWiki-commits] [Gerrit] Hover images never leave the screen now - change (mediawiki...Hovergallery)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181259

Change subject: Hover images never leave the screen now
..

Hover images never leave the screen now

Change-Id: I01caf7a665a9a1ef92d1fda9de6e2ab8f94f6fbb
---
M HoverGallery.body.php
M HoverGallery.css
M HoverGallery.js
M HoverGallery.php
4 files changed, 51 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Hovergallery 
refs/changes/59/181259/1

diff --git a/HoverGallery.body.php b/HoverGallery.body.php
index 3508b7f..c6db884 100644
--- a/HoverGallery.body.php
+++ b/HoverGallery.body.php
@@ -8,32 +8,36 @@
}
 
public static function setParserHook( &$parser ) {
-   $parser->setHook( 'hovergallery', 'HoverGallery::renderGallery' 
);
+   $parser->setHook( 'hovergallery', 'HoverGallery::render' );
return true;
}
 
-   public static function renderGallery( $input, array $ARGS, Parser 
$parser, PPFrame $frame ) {
+   public static function render( $input, array $ARGS, Parser $parser, 
PPFrame $frame ) {
 
-   $maxhoverwidth = '100%';
-   $maxhoverheight = '100%';
-   if ( array_key_exists( 'hoversize', $ARGS ) ) {
-   $maxhoverwidth = $ARGS['hoversize'] . 'px';
-   $maxhoverheight = $ARGS['hoversize'] . 'px';
+   $maxhoverwidth = '';
+   $maxhoverheight = '';
+   if ( array_key_exists( 'maxhoversize', $ARGS ) ) {
+   $maxhoverwidth = $ARGS['maxhoversize'];
+   $maxhoverheight = $ARGS['maxhoversize'];
}
if ( array_key_exists( 'maxhoverwidth', $ARGS ) ) {
-   $maxhoverwidth = $ARGS['maxhoverwidth'] . 'px';
+   $maxhoverwidth = $ARGS['maxhoverwidth'];
}
if ( array_key_exists( 'maxhoverheight', $ARGS ) ) {
-   $maxhoverheight = $ARGS['maxhoverheight'] . 'px';
+   $maxhoverheight = $ARGS['maxhoverheight'];
}   
 
$normalGallery = $parser->recursiveTagParse( '' . 
$input . '' );
 
-   $hiddenGallery = '';
-   $FILENAMES = explode( "\n", $input );
+   $hiddenGallery = '';
+   $FILENAMES = explode( PHP_EOL, trim( $input ) );
$FILENAMES = array_filter( $FILENAMES );
foreach ( $FILENAMES as $filename ) {
-   $hiddenGallery .= $parser->recursiveTagParse( '[[' . 
$filename . ']]' );
+   if ( $maxhoverwidth or $maxhoverheight ) {
+   $hiddenGallery .= $parser->recursiveTagParse( 
'[[' . $filename . '|' . $maxhoverwidth . 'x' . $maxhoverheight . 'px]]' );
+   } else {
+   $hiddenGallery .= $parser->recursiveTagParse( 
'[[' . $filename . ']]' );
+   }
}
$hiddenGallery .= '';
 
diff --git a/HoverGallery.css b/HoverGallery.css
index 5008bcd..34d2aa0 100644
--- a/HoverGallery.css
+++ b/HoverGallery.css
@@ -1,6 +1,7 @@
-div.hover-gallery img {
+div.hovergallery img {
border-radius: 5px;
display: none;
+   pointer-events: none;
position: fixed;
z-index: 99;
 }
\ No newline at end of file
diff --git a/HoverGallery.js b/HoverGallery.js
index 76f9a34..b6b2af3 100644
--- a/HoverGallery.js
+++ b/HoverGallery.js
@@ -1,45 +1,43 @@
-(function ($) {
-   $(document).ready(function(){
+$( function () {
 
-   var thumbs, mouseX, mouseY, clientWidth, clientHeight, 
fullImage, fullImageX, fullImageY, fullImageWidth, fullImageHeight;
+   var thumbs, mouseX, mouseY, clientWidth, clientHeight, fullImage, 
fullImageWidth, fullImageHeight, fullImageX, fullImageY, fullImageWidth, 
fullImageHeight;
 
-   // Get all the thumbnails
-   // The normal gallery is right before the hidden gallery, so 
just move to it and select all the images it contains
-   thumbs = $('div.hover-gallery').prev().find('img');
+   // Get all the thumbnails
+   // The normal gallery is right before the hidden gallery, so just move 
to it and select all the images it contains
+   thumbs = $( 'div.hovergallery' ).prev().find( 'img' );
 
-   thumbs.mousemove(function(event){
+   thumbs.mouseenter( function ( event ) {
 
-   // Determine which of the thumbs is it
-   var thumbIndex = $.inArray( this, thumbs );
+   // Determine which of the thumbs is it
+   var thumbIndex = $.inArray( this, thumbs );
 
-   // Get the corresponding full-size image
-   fullImage = $('div.hover-gallery').children().

[MediaWiki-commits] [Gerrit] Minor bugfix - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Minor bugfix
..


Minor bugfix

Change-Id: I195eb01c1a6d27d8fca78d61ee0c58cc354ccb38
---
M MsCatSelect.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsCatSelect.js b/MsCatSelect.js
index 5530b67..277e68b 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -95,7 +95,7 @@
 }
 
 function mscsAddCat( newCat, newSortkey ) {
-   if ( newCat !== '' && jQuery( '#mscs-added .mscs_entry[category="' + 
newCat + '"]' ).length === 0 ) {
+   if ( newCat !== '---' && jQuery( '#mscs-added .mscs_entry[category="' + 
newCat + '"]' ).length === 0 ) {
 
if ( newSortkey === '' ) {
newSortkey = wgTitle; // Standard sortkey is the page 
title

-- 
To view, visit https://gerrit.wikimedia.org/r/181057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I195eb01c1a6d27d8fca78d61ee0c58cc354ccb38
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor bugfix - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181057

Change subject: Minor bugfix
..

Minor bugfix

Change-Id: I195eb01c1a6d27d8fca78d61ee0c58cc354ccb38
---
M MsCatSelect.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/57/181057/1

diff --git a/MsCatSelect.js b/MsCatSelect.js
index 5530b67..277e68b 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -95,7 +95,7 @@
 }
 
 function mscsAddCat( newCat, newSortkey ) {
-   if ( newCat !== '' && jQuery( '#mscs-added .mscs_entry[category="' + 
newCat + '"]' ).length === 0 ) {
+   if ( newCat !== '---' && jQuery( '#mscs-added .mscs_entry[category="' + 
newCat + '"]' ).length === 0 ) {
 
if ( newSortkey === '' ) {
newSortkey = wgTitle; // Standard sortkey is the page 
title

-- 
To view, visit https://gerrit.wikimedia.org/r/181057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I195eb01c1a6d27d8fca78d61ee0c58cc354ccb38
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enhancing functionality - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Enhancing  functionality
..


Enhancing  functionality

Change-Id: Ib0a3ea874b08d8afea610a08a51fb5d7e0a25a60
---
M MsCatSelect.body.php
M MsCatSelect.js
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsCatSelect.body.php b/MsCatSelect.body.php
index 841a8ac..30a1070 100755
--- a/MsCatSelect.body.php
+++ b/MsCatSelect.body.php
@@ -13,7 +13,7 @@
'MainCategories' => $wgMSCS_MainCategories,
'UseNiceDropdown' => $wgMSCS_UseNiceDropdown,
'WarnNoCategories' => $wgMSCS_WarnNoCategories,
-   'WarnNoCategoriesException' => 
$wgMSCS_WarnNoCategoriesException,
+   'WarnNoCategoriesException' => str_replace( ' ', '_', 
$wgMSCS_WarnNoCategoriesException ),
);
$mscsVars = json_encode( $mscsVars, true );
$wgOut->addScript( "var mscsVars = $mscsVars;" 
);
diff --git a/MsCatSelect.js b/MsCatSelect.js
index 51031be..5530b67 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -246,7 +246,11 @@
 }
 
 function mscsCheckCategories() {
-   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 && jQuery.inArray( 
mw.config.get( 'wgNamespaceNumber' ), mscsVars.WarnNoCategoriesException ) === 
-1 ) {
+   if ( mscsVars.WarnNoCategories === true &&
+jQuery( '#mscs-added input[type="checkbox"]:checked' ).length 
=== 0 &&
+jQuery.inArray( mw.config.get( 'wgNamespaceNumber' ), 
mscsVars.WarnNoCategoriesException ) === -1 &&
+jQuery.inArray( mw.config.get( 'wgRelevantPageName' ), 
mscsVars.WarnNoCategoriesException ) === -1
+   ) {
return confirm( mediaWiki.msg( 'mscs-warnnocat' ) );
}
return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/177852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0a3ea874b08d8afea610a08a51fb5d7e0a25a60
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Enhancing functionality - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177852

Change subject: Enhancing  functionality
..

Enhancing  functionality

Change-Id: Ib0a3ea874b08d8afea610a08a51fb5d7e0a25a60
---
M MsCatSelect.body.php
M MsCatSelect.js
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/52/177852/1

diff --git a/MsCatSelect.body.php b/MsCatSelect.body.php
index 841a8ac..30a1070 100755
--- a/MsCatSelect.body.php
+++ b/MsCatSelect.body.php
@@ -13,7 +13,7 @@
'MainCategories' => $wgMSCS_MainCategories,
'UseNiceDropdown' => $wgMSCS_UseNiceDropdown,
'WarnNoCategories' => $wgMSCS_WarnNoCategories,
-   'WarnNoCategoriesException' => 
$wgMSCS_WarnNoCategoriesException,
+   'WarnNoCategoriesException' => str_replace( ' ', '_', 
$wgMSCS_WarnNoCategoriesException ),
);
$mscsVars = json_encode( $mscsVars, true );
$wgOut->addScript( "var mscsVars = $mscsVars;" 
);
diff --git a/MsCatSelect.js b/MsCatSelect.js
index 51031be..5530b67 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -246,7 +246,11 @@
 }
 
 function mscsCheckCategories() {
-   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 && jQuery.inArray( 
mw.config.get( 'wgNamespaceNumber' ), mscsVars.WarnNoCategoriesException ) === 
-1 ) {
+   if ( mscsVars.WarnNoCategories === true &&
+jQuery( '#mscs-added input[type="checkbox"]:checked' ).length 
=== 0 &&
+jQuery.inArray( mw.config.get( 'wgNamespaceNumber' ), 
mscsVars.WarnNoCategoriesException ) === -1 &&
+jQuery.inArray( mw.config.get( 'wgRelevantPageName' ), 
mscsVars.WarnNoCategoriesException ) === -1
+   ) {
return confirm( mediaWiki.msg( 'mscs-warnnocat' ) );
}
return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/177852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0a3ea874b08d8afea610a08a51fb5d7e0a25a60
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixing qqq link to documentation - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixing qqq link to documentation
..


Fixing qqq link to documentation

Change-Id: I93133a8582ac47d9a4767c19195183bf32a1f2c3
---
M i18n/qqq.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/i18n/qqq.json b/i18n/qqq.json
index d005359..8d6d15e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -4,7 +4,7 @@
"Luis Felipe Schenone"
]
},
-   "msl-desc": 
"{{desc|name=MsWikiEditor|url=https://www.mediawiki.org/wiki/Extension:MsWikiEditor}}";,
+   "msl-desc": 
"{{desc|name=MsLinks|url=https://www.mediawiki.org/wiki/Extension:MsLinks}}";,
"msl-tooltip": "Tooltip to the button for inserting links",
"msl-example-filename": "Name of the example file"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/177210
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93133a8582ac47d9a4767c19195183bf32a1f2c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsLinks
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixing qqq link to documentation - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177210

Change subject: Fixing qqq link to documentation
..

Fixing qqq link to documentation

Change-Id: I93133a8582ac47d9a4767c19195183bf32a1f2c3
---
M i18n/qqq.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsLinks 
refs/changes/10/177210/1

diff --git a/i18n/qqq.json b/i18n/qqq.json
index d005359..8d6d15e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -4,7 +4,7 @@
"Luis Felipe Schenone"
]
},
-   "msl-desc": 
"{{desc|name=MsWikiEditor|url=https://www.mediawiki.org/wiki/Extension:MsWikiEditor}}";,
+   "msl-desc": 
"{{desc|name=MsLinks|url=https://www.mediawiki.org/wiki/Extension:MsLinks}}";,
"msl-tooltip": "Tooltip to the button for inserting links",
"msl-example-filename": "Name of the example file"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/177210
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I93133a8582ac47d9a4767c19195183bf32a1f2c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsLinks
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor improvements - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Minor improvements
..


Minor improvements

Change-Id: Ieca40af54fba7e4af39033876b53171931b19225
---
M MsUpload.body.php
M MsUpload.js
M MsUpload.php
M README.md
M i18n/de.json
M i18n/en.json
M i18n/es.json
M i18n/qqq.json
8 files changed, 261 insertions(+), 258 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsUpload.body.php b/MsUpload.body.php
index bbd7720..5c0c09a 100644
--- a/MsUpload.body.php
+++ b/MsUpload.body.php
@@ -22,7 +22,7 @@
);
 
$msuVars = json_encode( $msuVars );
-   $wgOut->addScript( "var 
msuVars = $msuVars;\n" );
+   $wgOut->addScript( "var msuVars 
= $msuVars;\n" );
 
return true;
}
diff --git a/MsUpload.js b/MsUpload.js
index 9e2d7f2..58bebce 100755
--- a/MsUpload.js
+++ b/MsUpload.js
@@ -6,8 +6,8 @@
file.li.warning.text( errorText );
file.li.addClass( 'yellow' );
file.li.type.addClass( 'error' );
-   file.li.click( function() { // Remove li at click
-   file.li.fadeOut( 'slow', function() {
+   file.li.click( function () { // Remove li at click
+   file.li.fadeOut( 'slow', function () {
$( this ).remove();
uploader.trigger( 'CheckFiles' );
});
@@ -17,11 +17,20 @@
 var galleryArray = [];
 function addGallery() {
var galleryText = 'File:' + galleryArray.join( '\nFile:' );
-   mw.toolbar.insertTags( '\n' + galleryText + '\n\n', 
'', '', '' ); // Insert gallery
+   mw.toolbar.insertTags( '\n' + galleryText + '\n\n', 
'', '', '' );
 }
 
+var filesArray = [];
 function addFiles() {
-   mw.toolbar.insertTags( '[[File:' + galleryArray.join( ']]\n[[File:' ) + 
']]\n', '', '', '' ); // Insert gallery
+   mw.toolbar.insertTags( '[[File:' + filesArray.join( ']]\n[[File:' ) + 
']]\n', '', '', '' );
+}
+
+function addLinks() {
+   if ( msuVars.useMsLinks === true ) {
+   mw.toolbar.insertTags( '*{{#l:' + filesArray.join( '}}\n*{{#l:' 
) + '}}\n', '', '', '' );
+   } else {
+   mw.toolbar.insertTags( '*[[:File:' + filesArray.join( 
']]\n*[[:File:' ) + ']]\n', '', '', '' );
+   }
 }
 
 function warningText( fileItem, warning ) {
@@ -31,7 +40,7 @@
// Error handling
warning = warning.replace( /( <( [^>]+ )> )/ig, '' );
var warningSplit = warning.split( '. ' ); // split error
-   $( '' ).attr( 'class', 'small-warn' ).html( 
warningSplit[0] ).click( function() {
+   $( '' ).attr( 'class', 'small-warn' ).html( 
warningSplit[0] ).click( function () {
$( this ).html( warningSplit[0] + '. ' + 
warningSplit[1] );
}).appendTo( fileItem.warning );
}
@@ -48,18 +57,18 @@
titles: 'File:' + filename,
prop: 'imageinfo',
iiprop: 'uploadwarning'
-   }, success: function( data ) {
+   }, success: function ( data ) {
if ( data && data.query && data.query.pages ) {
var pages = data.query.pages;
// warningText( fileItem, pages[Object.keys( 
pages )[0]].imageinfo[0].html ); // .keys possible in ie8
-   $.each( pages, function( index, val ) {
+   $.each( pages, function ( index, val ) {
warningText( fileItem, 
val.imageinfo[0].html );
return false; // Break out
});
} else {
warningText( fileItem, 'Error: Unknown result 
from API.' );
}
-   }, error: function() {
+   }, error: function () {
warningText( fileItem, 'Error: Request failed.' );
}});
} else {
@@ -83,17 +92,17 @@
'class': 'check-index',
'type': 'checkbox',
'checked': file.cat
-   }).change( function() {
+   }).change( function () {
file.cat = this.checked; // Save
}).appendTo( file.li );

$( '' ).attr( 'class', 'check-span' ).text( 
wgPageName.replace( /_/g, ' ' ) ).appendTo( file.li );
}
-   file.li.title.mouseover( function() {
+   file.li.title.mouseover( function () {
$( this ).addClass( 'title_over' );
-   }).mouseleave( function() {
+   }).mouseleave( function () {
$( this ).removeClass( 'title_over' );
-   }).click( function() {
+   }).click( function () {
  

[MediaWiki-commits] [Gerrit] Minor improvements - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176835

Change subject: Minor improvements
..

Minor improvements

Change-Id: Ieca40af54fba7e4af39033876b53171931b19225
---
M MsUpload.body.php
M MsUpload.js
M MsUpload.php
M README.md
M i18n/de.json
M i18n/en.json
M i18n/es.json
M i18n/qqq.json
8 files changed, 261 insertions(+), 258 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsUpload 
refs/changes/35/176835/1

diff --git a/MsUpload.body.php b/MsUpload.body.php
index bbd7720..5c0c09a 100644
--- a/MsUpload.body.php
+++ b/MsUpload.body.php
@@ -22,7 +22,7 @@
);
 
$msuVars = json_encode( $msuVars );
-   $wgOut->addScript( "var 
msuVars = $msuVars;\n" );
+   $wgOut->addScript( "var msuVars 
= $msuVars;\n" );
 
return true;
}
diff --git a/MsUpload.js b/MsUpload.js
index 9e2d7f2..58bebce 100755
--- a/MsUpload.js
+++ b/MsUpload.js
@@ -6,8 +6,8 @@
file.li.warning.text( errorText );
file.li.addClass( 'yellow' );
file.li.type.addClass( 'error' );
-   file.li.click( function() { // Remove li at click
-   file.li.fadeOut( 'slow', function() {
+   file.li.click( function () { // Remove li at click
+   file.li.fadeOut( 'slow', function () {
$( this ).remove();
uploader.trigger( 'CheckFiles' );
});
@@ -17,11 +17,20 @@
 var galleryArray = [];
 function addGallery() {
var galleryText = 'File:' + galleryArray.join( '\nFile:' );
-   mw.toolbar.insertTags( '\n' + galleryText + '\n\n', 
'', '', '' ); // Insert gallery
+   mw.toolbar.insertTags( '\n' + galleryText + '\n\n', 
'', '', '' );
 }
 
+var filesArray = [];
 function addFiles() {
-   mw.toolbar.insertTags( '[[File:' + galleryArray.join( ']]\n[[File:' ) + 
']]\n', '', '', '' ); // Insert gallery
+   mw.toolbar.insertTags( '[[File:' + filesArray.join( ']]\n[[File:' ) + 
']]\n', '', '', '' );
+}
+
+function addLinks() {
+   if ( msuVars.useMsLinks === true ) {
+   mw.toolbar.insertTags( '*{{#l:' + filesArray.join( '}}\n*{{#l:' 
) + '}}\n', '', '', '' );
+   } else {
+   mw.toolbar.insertTags( '*[[:File:' + filesArray.join( 
']]\n*[[:File:' ) + ']]\n', '', '', '' );
+   }
 }
 
 function warningText( fileItem, warning ) {
@@ -31,7 +40,7 @@
// Error handling
warning = warning.replace( /( <( [^>]+ )> )/ig, '' );
var warningSplit = warning.split( '. ' ); // split error
-   $( '' ).attr( 'class', 'small-warn' ).html( 
warningSplit[0] ).click( function() {
+   $( '' ).attr( 'class', 'small-warn' ).html( 
warningSplit[0] ).click( function () {
$( this ).html( warningSplit[0] + '. ' + 
warningSplit[1] );
}).appendTo( fileItem.warning );
}
@@ -48,18 +57,18 @@
titles: 'File:' + filename,
prop: 'imageinfo',
iiprop: 'uploadwarning'
-   }, success: function( data ) {
+   }, success: function ( data ) {
if ( data && data.query && data.query.pages ) {
var pages = data.query.pages;
// warningText( fileItem, pages[Object.keys( 
pages )[0]].imageinfo[0].html ); // .keys possible in ie8
-   $.each( pages, function( index, val ) {
+   $.each( pages, function ( index, val ) {
warningText( fileItem, 
val.imageinfo[0].html );
return false; // Break out
});
} else {
warningText( fileItem, 'Error: Unknown result 
from API.' );
}
-   }, error: function() {
+   }, error: function () {
warningText( fileItem, 'Error: Request failed.' );
}});
} else {
@@ -83,17 +92,17 @@
'class': 'check-index',
'type': 'checkbox',
'checked': file.cat
-   }).change( function() {
+   }).change( function () {
file.cat = this.checked; // Save
}).appendTo( file.li );

$( '' ).attr( 'class', 'check-span' ).text( 
wgPageName.replace( /_/g, ' ' ) ).appendTo( file.li );
}
-   file.li.title.mouseover( function() {
+   file.li.title.mouseover( function () {
$( this ).addClass( 'title_over' );
-   }).mouseleave( function() {
+   }).mouseleave( function () {
$( this ).removeClass( 'title_over' );
-   }).cl

[MediaWiki-commits] [Gerrit] Removing unnecessary globals - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Removing unnecessary globals
..


Removing unnecessary globals

Change-Id: I7b21b8db08f1bdc62da293ee472994602dcff348
---
M YotpoReviews.body.php
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/YotpoReviews.body.php b/YotpoReviews.body.php
index 83fac50..c77262d 100644
--- a/YotpoReviews.body.php
+++ b/YotpoReviews.body.php
@@ -14,7 +14,6 @@
}
 
public static function renderReviews( $input, array $args, Parser 
$parser, PPFrame $frame ) {
-   global $wgTitle, $wgLogo, $wgServer, $wgYotpoAppKey;
 
$width = '100%'; //Default
if ( array_key_exists( 'width', $args ) ) {
@@ -45,9 +44,10 @@
$float = $args['float'];
}
 
-   $data_product_id = $wgTitle->getDBKey();
-   $data_name = $wgTitle->getText();
-   $data_url = $wgTitle->getFullURL();
+   $title = $parser->getTitle();
+   $data_product_id = $title->getDBKey();
+   $data_name = $title->getText();
+   $data_url = $title->getFullURL();
$data_image_url = '';
$data_description = '';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b21b8db08f1bdc62da293ee472994602dcff348
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/YotpoReviews
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Removing unnecessary globals - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176651

Change subject: Removing unnecessary globals
..

Removing unnecessary globals

Change-Id: I7b21b8db08f1bdc62da293ee472994602dcff348
---
M YotpoReviews.body.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/YotpoReviews 
refs/changes/51/176651/1

diff --git a/YotpoReviews.body.php b/YotpoReviews.body.php
index 83fac50..c77262d 100644
--- a/YotpoReviews.body.php
+++ b/YotpoReviews.body.php
@@ -14,7 +14,6 @@
}
 
public static function renderReviews( $input, array $args, Parser 
$parser, PPFrame $frame ) {
-   global $wgTitle, $wgLogo, $wgServer, $wgYotpoAppKey;
 
$width = '100%'; //Default
if ( array_key_exists( 'width', $args ) ) {
@@ -45,9 +44,10 @@
$float = $args['float'];
}
 
-   $data_product_id = $wgTitle->getDBKey();
-   $data_name = $wgTitle->getText();
-   $data_url = $wgTitle->getFullURL();
+   $title = $parser->getTitle();
+   $data_product_id = $title->getDBKey();
+   $data_name = $title->getText();
+   $data_url = $title->getFullURL();
$data_image_url = '';
$data_description = '';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b21b8db08f1bdc62da293ee472994602dcff348
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/YotpoReviews
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Converting line endings and changing extension type - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Converting line endings and changing extension type
..


Converting line endings and changing extension type

Change-Id: Ic2118de8a789b1f2e6a0d683e31bd8b2e8fc8bf3
---
M MsWikiEditor.js
M MsWikiEditor.php
2 files changed, 109 insertions(+), 109 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  Raimond Spekking: Looks good to me, but someone else must approve



diff --git a/MsWikiEditor.js b/MsWikiEditor.js
index e99b7bf..d31c33a 100755
--- a/MsWikiEditor.js
+++ b/MsWikiEditor.js
@@ -1,83 +1,83 @@
-// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
-if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
-   mw.loader.using( 'user.options', function () {
-   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
-   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
-   $( document ).ready( mswe_modifyToolbar );
-   });
-   }
-   });
-}
-
-var mswe_setGroup = false;
-
-function mswe_modifyToolbar() {
-   mswe_addGroup();
-   mswe_addAllButtons( mswe_buttons );
-   jQuery.each( mswe_remove, function ( i, val ) {
-   if ( val === 'reference' ) {
-   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
-   'section': 'main',
-   'group': 'insert',
-   'tool': 'reference'
-   });
-   } else {
-   mswe_removeSection( val );
-   }
-   });
-}
-
-function mswe_addAllButtons( mswe_buttons ) {
-   jQuery.each( mswe_add, function ( i, val ) {
-   mswe_addThisButton( val );
-   });
-}
-
-function mswe_addThisButton( titleButton ) {
-   var anam = mswe_buttons[ titleButton ][0];
-   var aprex = mswe_buttons[ titleButton ][1];
-   var aperix = mswe_buttons[ titleButton ][2];
-   var apostx = mswe_buttons[ titleButton ][3];
-   var aimg = mswe_buttons[ titleButton ][4];
-
-   // To add a button to an existing toolbar group:
-   $( '#wpTextbox1' ).wikiEditor( 'addToToolbar', {
-   'section': 'main',
-   'group': 'additional',
-   'tools': {
-   'anam': {
-   'label': anam, // Or use labelMsg for a 
localized label, see above
-   'type': 'button',
-   'icon': aimg,
-   'action': {
-   'type': 'encapsulate',
-   'options': {
-   'pre': aprex, 
-   'peri': aperix,
-   'post': apostx,
-   }
-   }
-   }
-   }
-   });
-}
-
-function mswe_removeSection( nam ) {
-   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
-   'section': nam
-   });
-}
-
-function mswe_addGroup() {
-   if ( mswe_setGroup === false ) {
-   // To add a group to an existing toolbar section:
-   mswe_setGroup = true;
-   $( '#wpTextbox1' ).wikiEditor( 'addToToolbar', {
-   'section': 'main',
-   'groups': {
-   'additional': {}
-   }
-   });
-   }
-   $( '.wikiEditor-ui-toolbar .group-additional' ).css( 'border-left', 
'1px solid #DD' );
+// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
+   $( document ).ready( mswe_modifyToolbar );
+   });
+   }
+   });
+}
+
+var mswe_setGroup = false;
+
+function mswe_modifyToolbar() {
+   mswe_addGroup();
+   mswe_addAllButtons( mswe_buttons );
+   jQuery.each( mswe_remove, function ( i, val ) {
+   if ( val === 'reference' ) {
+   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
+   'section': 'main',
+   'group': 'insert',
+   'tool': 'reference'
+   });
+   } else {
+   mswe_removeSection( val );
+   }

[MediaWiki-commits] [Gerrit] Converting line endings and changing extension type - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/175753

Change subject: Converting line endings and changing extension type
..

Converting line endings and changing extension type

Change-Id: Ic2118de8a789b1f2e6a0d683e31bd8b2e8fc8bf3
---
M MsWikiEditor.js
M MsWikiEditor.php
2 files changed, 109 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsWikiEditor 
refs/changes/53/175753/1

diff --git a/MsWikiEditor.js b/MsWikiEditor.js
index e99b7bf..d31c33a 100755
--- a/MsWikiEditor.js
+++ b/MsWikiEditor.js
@@ -1,83 +1,83 @@
-// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
-if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
-   mw.loader.using( 'user.options', function () {
-   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
-   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
-   $( document ).ready( mswe_modifyToolbar );
-   });
-   }
-   });
-}
-
-var mswe_setGroup = false;
-
-function mswe_modifyToolbar() {
-   mswe_addGroup();
-   mswe_addAllButtons( mswe_buttons );
-   jQuery.each( mswe_remove, function ( i, val ) {
-   if ( val === 'reference' ) {
-   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
-   'section': 'main',
-   'group': 'insert',
-   'tool': 'reference'
-   });
-   } else {
-   mswe_removeSection( val );
-   }
-   });
-}
-
-function mswe_addAllButtons( mswe_buttons ) {
-   jQuery.each( mswe_add, function ( i, val ) {
-   mswe_addThisButton( val );
-   });
-}
-
-function mswe_addThisButton( titleButton ) {
-   var anam = mswe_buttons[ titleButton ][0];
-   var aprex = mswe_buttons[ titleButton ][1];
-   var aperix = mswe_buttons[ titleButton ][2];
-   var apostx = mswe_buttons[ titleButton ][3];
-   var aimg = mswe_buttons[ titleButton ][4];
-
-   // To add a button to an existing toolbar group:
-   $( '#wpTextbox1' ).wikiEditor( 'addToToolbar', {
-   'section': 'main',
-   'group': 'additional',
-   'tools': {
-   'anam': {
-   'label': anam, // Or use labelMsg for a 
localized label, see above
-   'type': 'button',
-   'icon': aimg,
-   'action': {
-   'type': 'encapsulate',
-   'options': {
-   'pre': aprex, 
-   'peri': aperix,
-   'post': apostx,
-   }
-   }
-   }
-   }
-   });
-}
-
-function mswe_removeSection( nam ) {
-   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
-   'section': nam
-   });
-}
-
-function mswe_addGroup() {
-   if ( mswe_setGroup === false ) {
-   // To add a group to an existing toolbar section:
-   mswe_setGroup = true;
-   $( '#wpTextbox1' ).wikiEditor( 'addToToolbar', {
-   'section': 'main',
-   'groups': {
-   'additional': {}
-   }
-   });
-   }
-   $( '.wikiEditor-ui-toolbar .group-additional' ).css( 'border-left', 
'1px solid #DD' );
+// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
+   $( document ).ready( mswe_modifyToolbar );
+   });
+   }
+   });
+}
+
+var mswe_setGroup = false;
+
+function mswe_modifyToolbar() {
+   mswe_addGroup();
+   mswe_addAllButtons( mswe_buttons );
+   jQuery.each( mswe_remove, function ( i, val ) {
+   if ( val === 'reference' ) {
+   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
+   'section': 'main',
+   'group': 'insert',
+   'tool': 'reference'
+   });
+   } else {
+   mswe_removeSection( val );
+   }
+   

[MediaWiki-commits] [Gerrit] Updating all - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updating all
..


Updating all

Change-Id: I2043fcf0ae022591b4d72759c5bedfe57debc1ea
(cherry picked from commit bc0077d9a458cf70be97f72fce85038a4adf)
---
M .gitignore
A MsLinks.body.php
A MsLinks.i18n.php
A MsLinks.js
A MsLinks.php
D README.TXT
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
M images/broken_icon.png
D images/code__red_icon.png
M images/code_icon.png
D images/delete_icon.png
M images/doc_icon.png
A images/document-access.png
A images/document-excel-table.png
A images/dwg_icon.gif
A images/exe_icon.gif
D images/exe_icon.png
A images/film_icon.png
M images/image_ai_icon.png
M images/image_icon.png
M images/image_ps_icon.png
M images/movie_flash_icon.png
M images/movie_icon.png
R images/mslink_icon.png
A images/mslink_icon_oldschool.gif
M images/music_icon.png
M images/no_icon.png
M images/pdf_icon.png
D images/php_icon.png
M images/pps_icon.png
M images/txt_icon.png
M images/xls_icon.png
M images/zip_icon.png
D mslinks.js
D mslinks.php
D mslinks_body.php
40 files changed, 344 insertions(+), 293 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/.gitignore b/.gitignore
index 98b092a..2c8761d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+.DS_Store
 .svn
 *~
 *.kate-swp
diff --git a/MsLinks.body.php b/MsLinks.body.php
new file mode 100755
index 000..603b6f9
--- /dev/null
+++ b/MsLinks.body.php
@@ -0,0 +1,73 @@
+addModules( 'ext.MsLinks' );
+   $path = $wgScriptPath . '/extensions/MsLinks';
+   $wgOut->addScript( "var 
msl_icon_path = \"$path\";" );
+   return true;
+   }
+
+   static function setHook( &$parser ) {
+   $parser->setFunctionHook( 'mslink', 'MsLinks::render' );
+   return true;
+   }
+
+   static function getMagicWord( &$magicWords, $langCode ) {
+   $magicWords['mslink'] = array( 0, 'l' );
+   return true;
+   }
+
+   static function render( $parser, $type = 'no', $url = '', $description 
= '', $align = '' ) {
+   global $wgOut, $wgScriptPath, $wgMSL_FileTypes;
+
+   if ( $type !== 'dlink' and $type !== 'vlink' ) {
+   $align = $description;
+   $description = $url;
+   $url = $type;
+   }
+
+   try {
+   $title = Title::newFromText( $url, NS_IMAGE );
+   $file = function_exists( 'wfFindFile' ) ? wfFindFile( 
$title ) : new Image( $title );
+   $base = ( is_object( $file ) && $file->exists() ) ? 
':Image' : 'Media';
+   } catch( Exception $exception ) {
+   $base = 'Media';
+   } 
+
+   $extension = strtolower( substr( strrchr( $url, '.' ), 1 ) );
+   if ( !$description ) {
+   if ( $extension ) {
+   $description = substr( $url, 0, ( strlen( $url 
) - ( strlen( $extension ) + 1 ) ) );
+   } else {
+   $description = $url;
+   }
+   }
+
+   //Defaults
+   $wikitext = "[[$base:$url|$description]]";
+   $image = "";
+
+   foreach ( $wgMSL_FileTypes as $key => $value ) { 
+   if ( $key === $extension ) {
+   $image = ""; 
+   }
+   }
+   $image = $parser->insertStripItem( $image, $parser->mStripState 
);
+
+   if ( $type !== 'vlink' and $type !== 'dlink' ) {
+   $base = 'Media';
+   }
+
+   $image = "[[$base:$url|$image]]";
+
+   if ( $align === 'right' ) { 
+   $wikitext = $wikitext . ' ' . $image;
+   } else {
+   $wikitext = $image . ' ' . $wikitext;
+   }
+   return $wikitext;
+   }
+}
\ No newline at end of file
diff --git a/MsLinks.i18n.php b/MsLinks.i18n.php
new file mode 100644
index 000..bb63e53
--- /dev/null
+++ b/MsLinks.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache,

[MediaWiki-commits] [Gerrit] Fix path and file name. - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fix path and file name.
..


Fix path and file name.

* Fixes path to i18n.

* Fixes file name for MsLinks.js it was mslinks.js but renamed to MsLinks.js

Change-Id: Ia28d5f58dd7e4fc4ae57ae14bc1ef286c2dc4b12
---
M MsLinks.i18n.php
R MsLinks.js
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsLinks.i18n.php b/MsLinks.i18n.php
index 4ec7bdb..bb63e53 100644
--- a/MsLinks.i18n.php
+++ b/MsLinks.i18n.php
@@ -15,7 +15,7 @@
function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
$codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . 
"/extensions/MsLinks/i18n/$csCode.json";
+   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
if ( is_readable( $fileName ) ) {
$data = FormatJson::decode( file_get_contents( 
$fileName ), true );
foreach ( array_keys( $data ) as $key ) {
diff --git a/mslinks.js b/MsLinks.js
similarity index 100%
rename from mslinks.js
rename to MsLinks.js
old mode 100755
new mode 100644

-- 
To view, visit https://gerrit.wikimedia.org/r/175005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28d5f58dd7e4fc4ae57ae14bc1ef286c2dc4b12
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MsLinks
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bumping version - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Bumping version
..


Bumping version

* Bumps version to 4.0 reason because before the update it was 3.1 and then it 
went to 3.0 in new update where as it should have been bumped to a higher 
number.

Change-Id: I5ffe98ab2ab0f857310bfdf6588f824da87c527d
---
M MsLinks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsLinks.php b/MsLinks.php
index 79ec9bf..9df0e30 100755
--- a/MsLinks.php
+++ b/MsLinks.php
@@ -3,7 +3,7 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsLinks',
'url' => 'https://www.mediawiki.org/wiki/Extension:MsLinks',
-   'version' => '3.0',
+   'version' => '4.0',
'descriptionmsg' => 'msl-desc',
'license-name' => 'GPLv2+',
'author' => array( '[mailto:w...@ratin.de Martin Schwindl]', 
'[mailto:w...@keyler-consult.de Martin Keyler]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/174990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ffe98ab2ab0f857310bfdf6588f824da87c527d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MsLinks
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Finishing update - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Finishing update
..


Finishing update

Change-Id: I65ce5c392a345de33d3e292f9b499e16f4fcd253
---
M MsCatSelect.body.php
M MsCatSelect.js
M MsCatSelect.php
D README.TXT
A README.md
M i18n/en.json
6 files changed, 51 insertions(+), 39 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MsCatSelect.body.php b/MsCatSelect.body.php
index 64f9574..841a8ac 100755
--- a/MsCatSelect.body.php
+++ b/MsCatSelect.body.php
@@ -3,20 +3,20 @@
 class MsCatSelect {
 
static function start() {
-   global $wgOut, $wgJsMimeType, $wgMSCS_MainCategories, 
$wgMSCS_UseNiceDropdown, $wgMSCS_WarnNoCategories;
+   global $wgOut, $wgMSCS_MainCategories, $wgMSCS_UseNiceDropdown, 
$wgMSCS_WarnNoCategories, $wgMSCS_WarnNoCategoriesException;
 
// Load module
$wgOut->addModules( 'ext.MsCatSelect' );
 
-   // Make the configuration available to JavaScript
+   // Make the configuration variables available to JavaScript
$mscsVars = array(
'MainCategories' => $wgMSCS_MainCategories,
'UseNiceDropdown' => $wgMSCS_UseNiceDropdown,
'WarnNoCategories' => $wgMSCS_WarnNoCategories,
+   'WarnNoCategoriesException' => 
$wgMSCS_WarnNoCategoriesException,
);
$mscsVars = json_encode( $mscsVars, true );
-   $wgOut->addScript( "var 
mscsVars = $mscsVars;\n" );
-
+   $wgOut->addScript( "var mscsVars = $mscsVars;" 
);
return true;
}
 
diff --git a/MsCatSelect.js b/MsCatSelect.js
index b909f39..51031be 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -246,7 +246,7 @@
 }
 
 function mscsCheckCategories() {
-   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 ) {
+   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 && jQuery.inArray( 
mw.config.get( 'wgNamespaceNumber' ), mscsVars.WarnNoCategoriesException ) === 
-1 ) {
return confirm( mediaWiki.msg( 'mscs-warnnocat' ) );
}
return true;
diff --git a/MsCatSelect.php b/MsCatSelect.php
index 0825191..491ee80 100755
--- a/MsCatSelect.php
+++ b/MsCatSelect.php
@@ -3,10 +3,10 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCatSelect',
'url' => 'http://www.mediawiki.org/wiki/Extension:MsCatSelect',
-   'version' => 6,
-   'license-name' => 'GPLv2+',
-   'author' => array( '[mailto:mscatsel...@ratin.de Martin Schwindl]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),
+   'version' => '6.0',
'descriptionmsg' => 'mscs-desc',
+   'license-name' => 'GPLv2+',
+   'author' => array( '[mailto:w...@ratin.de Martin Schwindl]', 
'[mailto:w...@keyler-consult.de Martin Keyler]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),
 );
 
 $wgResourceModules['ext.MsCatSelect'] = array(
@@ -37,7 +37,8 @@
 $wgHooks['EditPage::showEditForm:initial'][] = 'MsCatSelect::showHook';
 $wgHooks['EditPage::attemptSave'][] = 'MsCatSelect::saveHook';
 
-//Configuration defaults
+// Default configuration
 $wgMSCS_MainCategories = null;
 $wgMSCS_UseNiceDropdown = true;
-$wgMSCS_WarnNoCategories = true;
\ No newline at end of file
+$wgMSCS_WarnNoCategories = true;
+$wgMSCS_WarnNoCategoriesException = array();
\ No newline at end of file
diff --git a/README.TXT b/README.TXT
deleted file mode 100755
index 6bf36ef..000
--- a/README.TXT
+++ /dev/null
@@ -1,28 +0,0 @@
-
-#
-# Author: Martin Schwindl, mscatsel...@ratin.de
-#
-# Updated, debugged and normalised by Luis Felipe Schenone 
(scheno...@gmail.com) in 2014
-#
-# Some icons by Yusuke Kamiyamane. All rights reserved. Licensed under a 
Creative Commons Attribution 3.0 License.
-# http://p.yusukekamiyamane.com
-# 
-# Chosen, a Select Box Enhancer for jQuery and Protoype
-# by Patrick Filler for Harvest
-# Available for use under the MIT License
-# Copyright (c) 2011-2013 by Harvest
-# Permission is hereby granted, free of charge, to any person obtaining a copy 
of this software and associated documentation files (the "Software"), to deal 
in the Software without restriction, including without limitation the rights to 
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies 
of the Software, and to permit persons to whom the Software is furnished to do 
so, subject to the following conditions:
-# The above copyright notice and this permission notice shall be included in 
all copies or substantial portions of the Software.
-# THE SOFTWARE IS PROVIDED 

[MediaWiki-commits] [Gerrit] Finishing update - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174948

Change subject: Finishing update
..

Finishing update

Change-Id: I65ce5c392a345de33d3e292f9b499e16f4fcd253
---
M MsCatSelect.body.php
M MsCatSelect.js
M MsCatSelect.php
D README.TXT
A README.md
M i18n/en.json
6 files changed, 51 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/48/174948/1

diff --git a/MsCatSelect.body.php b/MsCatSelect.body.php
index 64f9574..841a8ac 100755
--- a/MsCatSelect.body.php
+++ b/MsCatSelect.body.php
@@ -3,20 +3,20 @@
 class MsCatSelect {
 
static function start() {
-   global $wgOut, $wgJsMimeType, $wgMSCS_MainCategories, 
$wgMSCS_UseNiceDropdown, $wgMSCS_WarnNoCategories;
+   global $wgOut, $wgMSCS_MainCategories, $wgMSCS_UseNiceDropdown, 
$wgMSCS_WarnNoCategories, $wgMSCS_WarnNoCategoriesException;
 
// Load module
$wgOut->addModules( 'ext.MsCatSelect' );
 
-   // Make the configuration available to JavaScript
+   // Make the configuration variables available to JavaScript
$mscsVars = array(
'MainCategories' => $wgMSCS_MainCategories,
'UseNiceDropdown' => $wgMSCS_UseNiceDropdown,
'WarnNoCategories' => $wgMSCS_WarnNoCategories,
+   'WarnNoCategoriesException' => 
$wgMSCS_WarnNoCategoriesException,
);
$mscsVars = json_encode( $mscsVars, true );
-   $wgOut->addScript( "var 
mscsVars = $mscsVars;\n" );
-
+   $wgOut->addScript( "var mscsVars = $mscsVars;" 
);
return true;
}
 
diff --git a/MsCatSelect.js b/MsCatSelect.js
index b909f39..51031be 100755
--- a/MsCatSelect.js
+++ b/MsCatSelect.js
@@ -246,7 +246,7 @@
 }
 
 function mscsCheckCategories() {
-   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 ) {
+   if ( mscsVars.WarnNoCategories === true && jQuery( '#mscs-added 
input[type="checkbox"]:checked' ).length === 0 && jQuery.inArray( 
mw.config.get( 'wgNamespaceNumber' ), mscsVars.WarnNoCategoriesException ) === 
-1 ) {
return confirm( mediaWiki.msg( 'mscs-warnnocat' ) );
}
return true;
diff --git a/MsCatSelect.php b/MsCatSelect.php
index 0825191..491ee80 100755
--- a/MsCatSelect.php
+++ b/MsCatSelect.php
@@ -3,10 +3,10 @@
 $wgExtensionCredits['parserhook'][] = array(
'name' => 'MsCatSelect',
'url' => 'http://www.mediawiki.org/wiki/Extension:MsCatSelect',
-   'version' => 6,
-   'license-name' => 'GPLv2+',
-   'author' => array( '[mailto:mscatsel...@ratin.de Martin Schwindl]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),
+   'version' => '6.0',
'descriptionmsg' => 'mscs-desc',
+   'license-name' => 'GPLv2+',
+   'author' => array( '[mailto:w...@ratin.de Martin Schwindl]', 
'[mailto:w...@keyler-consult.de Martin Keyler]', 
'[https://www.mediawiki.org/wiki/User:Luis_Felipe_Schenone Luis Felipe 
Schenone]' ),
 );
 
 $wgResourceModules['ext.MsCatSelect'] = array(
@@ -37,7 +37,8 @@
 $wgHooks['EditPage::showEditForm:initial'][] = 'MsCatSelect::showHook';
 $wgHooks['EditPage::attemptSave'][] = 'MsCatSelect::saveHook';
 
-//Configuration defaults
+// Default configuration
 $wgMSCS_MainCategories = null;
 $wgMSCS_UseNiceDropdown = true;
-$wgMSCS_WarnNoCategories = true;
\ No newline at end of file
+$wgMSCS_WarnNoCategories = true;
+$wgMSCS_WarnNoCategoriesException = array();
\ No newline at end of file
diff --git a/README.TXT b/README.TXT
deleted file mode 100755
index 6bf36ef..000
--- a/README.TXT
+++ /dev/null
@@ -1,28 +0,0 @@
-
-#
-# Author: Martin Schwindl, mscatsel...@ratin.de
-#
-# Updated, debugged and normalised by Luis Felipe Schenone 
(scheno...@gmail.com) in 2014
-#
-# Some icons by Yusuke Kamiyamane. All rights reserved. Licensed under a 
Creative Commons Attribution 3.0 License.
-# http://p.yusukekamiyamane.com
-# 
-# Chosen, a Select Box Enhancer for jQuery and Protoype
-# by Patrick Filler for Harvest
-# Available for use under the MIT License
-# Copyright (c) 2011-2013 by Harvest
-# Permission is hereby granted, free of charge, to any person obtaining a copy 
of this software and associated documentation files (the "Software"), to deal 
in the Software without restriction, including without limitation the rights to 
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies 
of the Software, and to permit persons to whom the Software is furnished to do 
so, subject to the following conditions:
-# The above copyright notice and this permission notice shall be included in 
all copies or sub

[MediaWiki-commits] [Gerrit] Updating all - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updating all
..


Updating all

Change-Id: I2043fcf0ae022591b4d72759c5bedfe57debc1ea
---
M .gitignore
A MsLinks.body.php
A MsLinks.i18n.php
A MsLinks.php
D README.TXT
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
M images/broken_icon.png
D images/code__red_icon.png
M images/code_icon.png
D images/delete_icon.png
M images/doc_icon.png
A images/document-access.png
A images/document-excel-table.png
A images/dwg_icon.gif
A images/exe_icon.gif
D images/exe_icon.png
A images/film_icon.png
M images/image_ai_icon.png
M images/image_icon.png
M images/image_ps_icon.png
M images/movie_flash_icon.png
M images/movie_icon.png
R images/mslink_icon.png
A images/mslink_icon_oldschool.gif
M images/music_icon.png
M images/no_icon.png
M images/pdf_icon.png
D images/php_icon.png
M images/pps_icon.png
M images/txt_icon.png
M images/xls_icon.png
M images/zip_icon.png
M mslinks.js
D mslinks.php
D mslinks_body.php
39 files changed, 341 insertions(+), 290 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index 98b092a..2c8761d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+.DS_Store
 .svn
 *~
 *.kate-swp
diff --git a/MsLinks.body.php b/MsLinks.body.php
new file mode 100755
index 000..603b6f9
--- /dev/null
+++ b/MsLinks.body.php
@@ -0,0 +1,73 @@
+addModules( 'ext.MsLinks' );
+   $path = $wgScriptPath . '/extensions/MsLinks';
+   $wgOut->addScript( "var 
msl_icon_path = \"$path\";" );
+   return true;
+   }
+
+   static function setHook( &$parser ) {
+   $parser->setFunctionHook( 'mslink', 'MsLinks::render' );
+   return true;
+   }
+
+   static function getMagicWord( &$magicWords, $langCode ) {
+   $magicWords['mslink'] = array( 0, 'l' );
+   return true;
+   }
+
+   static function render( $parser, $type = 'no', $url = '', $description 
= '', $align = '' ) {
+   global $wgOut, $wgScriptPath, $wgMSL_FileTypes;
+
+   if ( $type !== 'dlink' and $type !== 'vlink' ) {
+   $align = $description;
+   $description = $url;
+   $url = $type;
+   }
+
+   try {
+   $title = Title::newFromText( $url, NS_IMAGE );
+   $file = function_exists( 'wfFindFile' ) ? wfFindFile( 
$title ) : new Image( $title );
+   $base = ( is_object( $file ) && $file->exists() ) ? 
':Image' : 'Media';
+   } catch( Exception $exception ) {
+   $base = 'Media';
+   } 
+
+   $extension = strtolower( substr( strrchr( $url, '.' ), 1 ) );
+   if ( !$description ) {
+   if ( $extension ) {
+   $description = substr( $url, 0, ( strlen( $url 
) - ( strlen( $extension ) + 1 ) ) );
+   } else {
+   $description = $url;
+   }
+   }
+
+   //Defaults
+   $wikitext = "[[$base:$url|$description]]";
+   $image = "";
+
+   foreach ( $wgMSL_FileTypes as $key => $value ) { 
+   if ( $key === $extension ) {
+   $image = ""; 
+   }
+   }
+   $image = $parser->insertStripItem( $image, $parser->mStripState 
);
+
+   if ( $type !== 'vlink' and $type !== 'dlink' ) {
+   $base = 'Media';
+   }
+
+   $image = "[[$base:$url|$image]]";
+
+   if ( $align === 'right' ) { 
+   $wikitext = $wikitext . ' ' . $image;
+   } else {
+   $wikitext = $image . ' ' . $wikitext;
+   }
+   return $wikitext;
+   }
+}
\ No newline at end of file
diff --git a/MsLinks.i18n.php b/MsLinks.i18n.php
new file mode 100644
index 000..4ec7bdb
--- /dev/null
+++ b/MsLinks.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallb

[MediaWiki-commits] [Gerrit] Updating all - change (mediawiki...MsLinks)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174943

Change subject: Updating all
..

Updating all

Change-Id: I2043fcf0ae022591b4d72759c5bedfe57debc1ea
---
M .gitignore
A MsLinks.body.php
A MsLinks.i18n.php
A MsLinks.php
D README.TXT
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
M images/broken_icon.png
D images/code__red_icon.png
M images/code_icon.png
D images/delete_icon.png
M images/doc_icon.png
A images/document-access.png
A images/document-excel-table.png
A images/dwg_icon.gif
A images/exe_icon.gif
D images/exe_icon.png
A images/film_icon.png
M images/image_ai_icon.png
M images/image_icon.png
M images/image_ps_icon.png
M images/movie_flash_icon.png
M images/movie_icon.png
R images/mslink_icon.png
A images/mslink_icon_oldschool.gif
M images/music_icon.png
M images/no_icon.png
M images/pdf_icon.png
D images/php_icon.png
M images/pps_icon.png
M images/txt_icon.png
M images/xls_icon.png
M images/zip_icon.png
M mslinks.js
D mslinks.php
D mslinks_body.php
39 files changed, 341 insertions(+), 290 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsLinks 
refs/changes/43/174943/1

diff --git a/.gitignore b/.gitignore
index 98b092a..2c8761d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+.DS_Store
 .svn
 *~
 *.kate-swp
diff --git a/MsLinks.body.php b/MsLinks.body.php
new file mode 100755
index 000..603b6f9
--- /dev/null
+++ b/MsLinks.body.php
@@ -0,0 +1,73 @@
+addModules( 'ext.MsLinks' );
+   $path = $wgScriptPath . '/extensions/MsLinks';
+   $wgOut->addScript( "var 
msl_icon_path = \"$path\";" );
+   return true;
+   }
+
+   static function setHook( &$parser ) {
+   $parser->setFunctionHook( 'mslink', 'MsLinks::render' );
+   return true;
+   }
+
+   static function getMagicWord( &$magicWords, $langCode ) {
+   $magicWords['mslink'] = array( 0, 'l' );
+   return true;
+   }
+
+   static function render( $parser, $type = 'no', $url = '', $description 
= '', $align = '' ) {
+   global $wgOut, $wgScriptPath, $wgMSL_FileTypes;
+
+   if ( $type !== 'dlink' and $type !== 'vlink' ) {
+   $align = $description;
+   $description = $url;
+   $url = $type;
+   }
+
+   try {
+   $title = Title::newFromText( $url, NS_IMAGE );
+   $file = function_exists( 'wfFindFile' ) ? wfFindFile( 
$title ) : new Image( $title );
+   $base = ( is_object( $file ) && $file->exists() ) ? 
':Image' : 'Media';
+   } catch( Exception $exception ) {
+   $base = 'Media';
+   } 
+
+   $extension = strtolower( substr( strrchr( $url, '.' ), 1 ) );
+   if ( !$description ) {
+   if ( $extension ) {
+   $description = substr( $url, 0, ( strlen( $url 
) - ( strlen( $extension ) + 1 ) ) );
+   } else {
+   $description = $url;
+   }
+   }
+
+   //Defaults
+   $wikitext = "[[$base:$url|$description]]";
+   $image = "";
+
+   foreach ( $wgMSL_FileTypes as $key => $value ) { 
+   if ( $key === $extension ) {
+   $image = ""; 
+   }
+   }
+   $image = $parser->insertStripItem( $image, $parser->mStripState 
);
+
+   if ( $type !== 'vlink' and $type !== 'dlink' ) {
+   $base = 'Media';
+   }
+
+   $image = "[[$base:$url|$image]]";
+
+   if ( $align === 'right' ) { 
+   $wikitext = $wikitext . ' ' . $image;
+   } else {
+   $wikitext = $image . ' ' . $wikitext;
+   }
+   return $wikitext;
+   }
+}
\ No newline at end of file
diff --git a/MsLinks.i18n.php b/MsLinks.i18n.php
new file mode 100644
index 000..4ec7bdb
--- /dev/null
+++ b/MsLinks.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $code

[MediaWiki-commits] [Gerrit] Fixing docs - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixing docs
..


Fixing docs

Change-Id: I3661adc6425ca932e8233de6862050dfe50b78f6
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/README.md b/README.md
index aeaaf10..532f56c 100755
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@
 
 To remove a button, include its name in the $wgMSWE_remove array, below the 
require_once line. For example:
 
-$wgMSWE_remove = array( 'help', 'characters', 'reference', 'advanced' );
+$wgMSWE_remove = array( 'advanced', 'characters', 'help' );
 
 By default, all arrays are empty.
 

-- 
To view, visit https://gerrit.wikimedia.org/r/174939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3661adc6425ca932e8233de6862050dfe50b78f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsWikiEditor
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixing docs - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174939

Change subject: Fixing docs
..

Fixing docs

Change-Id: I3661adc6425ca932e8233de6862050dfe50b78f6
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsWikiEditor 
refs/changes/39/174939/1

diff --git a/README.md b/README.md
index aeaaf10..532f56c 100755
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@
 
 To remove a button, include its name in the $wgMSWE_remove array, below the 
require_once line. For example:
 
-$wgMSWE_remove = array( 'help', 'characters', 'reference', 'advanced' );
+$wgMSWE_remove = array( 'advanced', 'characters', 'help' );
 
 By default, all arrays are empty.
 

-- 
To view, visit https://gerrit.wikimedia.org/r/174939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3661adc6425ca932e8233de6862050dfe50b78f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsWikiEditor
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Initial commit
..


Initial commit

Change-Id: I66ac225f8884930ddff0d124eb114a571aae2d1f
---
A .gitignore
A MsWikiEditor.body.php
A MsWikiEditor.i18n.php
A MsWikiEditor.js
A MsWikiEditor.php
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
A images/Achtung-Link.gif
A images/Btn_toolbar_gallery.png
A images/Button_strike.png
A images/Button_vote_biblio.png
A images/E-Mail.png
A images/Information-Link.gif
A images/Kalender.gif
A images/Link_button_oldschool.gif
A images/Wiki-Editor-Buttons_Achtung_22.png
A images/Wiki-Editor-Buttons_E-Mail_22.png
A images/Wiki-Editor-Buttons_Gallery_22.png
A images/Wiki-Editor-Buttons_Info_22.png
A images/Wiki-Editor-Buttons_Kalender_22.png
A images/Wiki-Editor-Buttons_Li.png
A images/Wiki-Editor-Buttons_Strike_22.png
A images/Wiki-Editor-Buttons_Upload_22.png
A images/password.png
A images/username.png
28 files changed, 236 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MsWikiEditor.body.php b/MsWikiEditor.body.php
new file mode 100644
index 000..ca26f20
--- /dev/null
+++ b/MsWikiEditor.body.php
@@ -0,0 +1,20 @@
+addScript( "
+   var mswe_add = JSON.parse('$mswe_add');
+   var mswe_remove = JSON.parse('$mswe_remove');
+   var mswe_buttons = JSON.parse('$mswe_buttons'); 
+   "
+   );
+   $wgOut->addModules( 'ext.MsWikiEditor' );
+   return true;
+   }
+}
\ No newline at end of file
diff --git a/MsWikiEditor.i18n.php b/MsWikiEditor.i18n.php
new file mode 100644
index 000..455283b
--- /dev/null
+++ b/MsWikiEditor.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . 
"/extensions/MsWikiEditor/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
+   }
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
+   }
+
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
+   }
+
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
+}
\ No newline at end of file
diff --git a/MsWikiEditor.js b/MsWikiEditor.js
new file mode 100755
index 000..e99b7bf
--- /dev/null
+++ b/MsWikiEditor.js
@@ -0,0 +1,83 @@
+// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
+   $( document ).ready( mswe_modifyToolbar );
+   });
+   }
+   });
+}
+
+var mswe_setGroup = false;
+
+function mswe_modifyToolbar() {
+   mswe_addGroup();
+   mswe_addAllButtons( mswe_buttons );
+   jQuery.each( mswe_remove, function ( i, val ) {
+   if ( val === 'reference' ) {
+   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
+   'section': 'main',
+   'group': 'insert',
+   'tool': 'reference'
+   });
+   } else {
+ 

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...MsWikiEditor)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174937

Change subject: Initial commit
..

Initial commit

Change-Id: I66ac225f8884930ddff0d124eb114a571aae2d1f
---
A .gitignore
A MsWikiEditor.body.php
A MsWikiEditor.i18n.php
A MsWikiEditor.js
A MsWikiEditor.php
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
A images/Achtung-Link.gif
A images/Btn_toolbar_gallery.png
A images/Button_strike.png
A images/Button_vote_biblio.png
A images/E-Mail.png
A images/Information-Link.gif
A images/Kalender.gif
A images/Link_button_oldschool.gif
A images/Wiki-Editor-Buttons_Achtung_22.png
A images/Wiki-Editor-Buttons_E-Mail_22.png
A images/Wiki-Editor-Buttons_Gallery_22.png
A images/Wiki-Editor-Buttons_Info_22.png
A images/Wiki-Editor-Buttons_Kalender_22.png
A images/Wiki-Editor-Buttons_Li.png
A images/Wiki-Editor-Buttons_Strike_22.png
A images/Wiki-Editor-Buttons_Upload_22.png
A images/password.png
A images/username.png
28 files changed, 236 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsWikiEditor 
refs/changes/37/174937/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MsWikiEditor.body.php b/MsWikiEditor.body.php
new file mode 100644
index 000..ca26f20
--- /dev/null
+++ b/MsWikiEditor.body.php
@@ -0,0 +1,20 @@
+addScript( "
+   var mswe_add = JSON.parse('$mswe_add');
+   var mswe_remove = JSON.parse('$mswe_remove');
+   var mswe_buttons = JSON.parse('$mswe_buttons'); 
+   "
+   );
+   $wgOut->addModules( 'ext.MsWikiEditor' );
+   return true;
+   }
+}
\ No newline at end of file
diff --git a/MsWikiEditor.i18n.php b/MsWikiEditor.i18n.php
new file mode 100644
index 000..455283b
--- /dev/null
+++ b/MsWikiEditor.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . 
"/extensions/MsWikiEditor/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
+   }
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
+   }
+
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
+   }
+
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
+}
\ No newline at end of file
diff --git a/MsWikiEditor.js b/MsWikiEditor.js
new file mode 100755
index 000..e99b7bf
--- /dev/null
+++ b/MsWikiEditor.js
@@ -0,0 +1,83 @@
+// Check if we are in edit mode and the required modules are available and 
then customize the toolbar
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', function () {
+   $( document ).ready( mswe_modifyToolbar );
+   });
+   }
+   });
+}
+
+var mswe_setGroup = false;
+
+function mswe_modifyToolbar() {
+   mswe_addGroup();
+   mswe_addAllButtons( mswe_buttons );
+   jQuery.each( mswe_remove, function ( i, val ) {
+   if ( val === 'reference' ) {
+   $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
+   'section': 'main',
+   'group': 'insert',
+   'tool': 'reference'
+  

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...MsInsert)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Initial commit
..


Initial commit

Change-Id: I0755fe91fafc613a3e643ecc17264df8feac0ec8
---
A .gitignore
A MsInsert.body.php
A MsInsert.i18n.php
A MsInsert.js
A MsInsert.php
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
10 files changed, 276 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MsInsert.body.php b/MsInsert.body.php
new file mode 100644
index 000..9e7524d
--- /dev/null
+++ b/MsInsert.body.php
@@ -0,0 +1,24 @@
+addModules( 'ext.MsInsert' );
+
+   $templates = array();
+   foreach ( $wgTemplates as $key => $template ) {
+   $title = Title::newFromText( htmlentities( $template ) 
);
+   $title2 = Title::newFromText( $template );
+   if ( $title and $title->exists() ) {
+   $templates[] = htmlentities( $template );
+   } elseif ( $title2 and $title2->exists() ) {
+   $templates[] = $template;
+   }
+   }
+   $templates = json_encode( $templates );
+   $wgOut->addScript( "var msi_templates = 
JSON.parse('$templates');" );
+   return true;
+   }
+}
\ No newline at end of file
diff --git a/MsInsert.i18n.php b/MsInsert.i18n.php
new file mode 100644
index 000..b64e7a0
--- /dev/null
+++ b/MsInsert.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . 
"/extensions/MsInsert/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
+   }
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
+   }
+
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
+   }
+
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
+}
\ No newline at end of file
diff --git a/MsInsert.js b/MsInsert.js
new file mode 100755
index 000..e19f412
--- /dev/null
+++ b/MsInsert.js
@@ -0,0 +1,121 @@
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) && 
mw.user.options.get( 'showtoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', 
msi_modifyToolbar1 );
+   } else {
+   msi_modifyToolbar2();
+   }
+   });
+}
+
+function msi_modifyToolbar1() {
+   var dropdownMenu = $( '' ).attr( 'id', 'msi-select' ).css( 
'margin', '4px' ).change( function () {
+   var selection = this.options[ this.selectedIndex ].value;
+   msi_templateSelect( selection );
+   });
+   dropdownMenu.append( '' + mw.msg( 
'msi-insert-template' ) + '' );
+   for ( var i = 0; i < msi_templates.length; i++ ) {
+   dropdownMenu.append( '' + 
msi_templates[ i ] + '' );
+   }
+   $( '#editform' ).find( '.group-insert' ).append( dropdownMenu );
+}
+
+function msi_modifyToolbar2() {
+   var dropdownMenu = $( '' ).attr( 'id', 'msi-select' ).change( 
function () {
+   var selection = this.options[ this.selectedIndex ].value;
+   msi_templateSelect( selection );
+   });
+   dropdownMenu.append( '' + mw.msg( 
'msi-in

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...MsInsert)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174934

Change subject: Initial commit
..

Initial commit

Change-Id: I0755fe91fafc613a3e643ecc17264df8feac0ec8
---
A .gitignore
A MsInsert.body.php
A MsInsert.i18n.php
A MsInsert.js
A MsInsert.php
A README.md
A i18n/de.json
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
10 files changed, 276 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsInsert 
refs/changes/34/174934/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MsInsert.body.php b/MsInsert.body.php
new file mode 100644
index 000..9e7524d
--- /dev/null
+++ b/MsInsert.body.php
@@ -0,0 +1,24 @@
+addModules( 'ext.MsInsert' );
+
+   $templates = array();
+   foreach ( $wgTemplates as $key => $template ) {
+   $title = Title::newFromText( htmlentities( $template ) 
);
+   $title2 = Title::newFromText( $template );
+   if ( $title and $title->exists() ) {
+   $templates[] = htmlentities( $template );
+   } elseif ( $title2 and $title2->exists() ) {
+   $templates[] = $template;
+   }
+   }
+   $templates = json_encode( $templates );
+   $wgOut->addScript( "var msi_templates = 
JSON.parse('$templates');" );
+   return true;
+   }
+}
\ No newline at end of file
diff --git a/MsInsert.i18n.php b/MsInsert.i18n.php
new file mode 100644
index 000..b64e7a0
--- /dev/null
+++ b/MsInsert.i18n.php
@@ -0,0 +1,35 @@
+https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
+ *
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
+ */
+$messages = array();
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . 
"/extensions/MsInsert/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
+   }
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
+   }
+
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
+   }
+
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
+}
\ No newline at end of file
diff --git a/MsInsert.js b/MsInsert.js
new file mode 100755
index 000..e19f412
--- /dev/null
+++ b/MsInsert.js
@@ -0,0 +1,121 @@
+if ( $.inArray( mw.config.get( 'wgAction' ), [ 'edit', 'submit' ] ) !== -1 ) {
+   mw.loader.using( 'user.options', function () {
+   if ( mw.user.options.get( 'usebetatoolbar' ) && 
mw.user.options.get( 'showtoolbar' ) ) {
+   mw.loader.using( 'ext.wikiEditor.toolbar', 
msi_modifyToolbar1 );
+   } else {
+   msi_modifyToolbar2();
+   }
+   });
+}
+
+function msi_modifyToolbar1() {
+   var dropdownMenu = $( '' ).attr( 'id', 'msi-select' ).css( 
'margin', '4px' ).change( function () {
+   var selection = this.options[ this.selectedIndex ].value;
+   msi_templateSelect( selection );
+   });
+   dropdownMenu.append( '' + mw.msg( 
'msi-insert-template' ) + '' );
+   for ( var i = 0; i < msi_templates.length; i++ ) {
+   dropdownMenu.append( '' + 
msi_templates[ i ] + '' );
+   }
+   $( '#editform' ).find( '.group-insert' ).append( dropdownMenu );
+}
+
+function msi_modifyToolbar2() {
+   var dropdownMenu = $( '' ).attr( 'id', 'msi-select' ).change( 
function () {
+   var selection = this.options[ this.selectedIndex ].value;
+   msi_templateSelect( selection );
+ 

[MediaWiki-commits] [Gerrit] Fix path to i18n - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fix path to i18n
..


Fix path to i18n

* This fixes the path to i18n the problem was introduced in the latest release.

* Renames msupload.php to MsUpload.php
* Renames msupload.i18n.php to MsUpload.i18n.php
* Renames msupload.body.php to MsUpload.body.php

Change-Id: I751ab3f5e187d55a6c89fc3ff580c0670e0cddf7
---
R MsUpload.body.php
R MsUpload.i18n.php
R MsUpload.php
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/msupload.body.php b/MsUpload.body.php
similarity index 100%
rename from msupload.body.php
rename to MsUpload.body.php
old mode 100755
new mode 100644
diff --git a/msupload.i18n.php b/MsUpload.i18n.php
similarity index 94%
rename from msupload.i18n.php
rename to MsUpload.i18n.php
old mode 100755
new mode 100644
index 5163cd3..dc970ba
--- a/msupload.i18n.php
+++ b/MsUpload.i18n.php
@@ -15,7 +15,7 @@
function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
$codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . 
"/extensions/MsUpload/i18n/$csCode.json";
+   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
if ( is_readable( $fileName ) ) {
$data = FormatJson::decode( file_get_contents( 
$fileName ), true );
foreach ( array_keys( $data ) as $key ) {
@@ -32,4 +32,4 @@
}
 
$GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
-}
\ No newline at end of file
+}
diff --git a/msupload.php b/MsUpload.php
similarity index 98%
rename from msupload.php
rename to MsUpload.php
old mode 100755
new mode 100644
index 9868704..e724188
--- a/msupload.php
+++ b/MsUpload.php
@@ -17,7 +17,7 @@
'dependencies' => 'jquery.ui.progressbar',
'styles' => 'MsUpload.css',
'messages' => array(
-   'msu-description',
+   'msu-desc',
'msu-button-title',
'msu-insert-link',
'msu-insert-gallery',

-- 
To view, visit https://gerrit.wikimedia.org/r/174071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I751ab3f5e187d55a6c89fc3ff580c0670e0cddf7
Gerrit-PatchSet: 21
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Nischayn22 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: Ratin 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix path - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fix path
..


Fix path

Change-Id: I4dd16a596d628fe744d13a2c1e7363bf916cc0c1
---
D msupload.i18n.php
1 file changed, 0 insertions(+), 35 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/msupload.i18n.php b/msupload.i18n.php
deleted file mode 100644
index bb63e53..000
--- a/msupload.i18n.php
+++ /dev/null
@@ -1,35 +0,0 @@
-https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
- *
- * Beginning with MediaWiki 1.23, translation strings are stored in json files,
- * and the EXTENSION.i18n.php file only exists to provide compatibility with
- * older releases of MediaWiki. For more information about this migration, see:
- * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
- *
- * This shim maintains compatibility back to MediaWiki 1.17.
- */
-$messages = array();
-if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
-   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
-   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
-   foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
-   if ( is_readable( $fileName ) ) {
-   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
-   foreach ( array_keys( $data ) as $key ) {
-   if ( $key === '' || $key[0] === '@' ) {
-   unset( $data[$key] );
-   }
-   }
-   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
-   }
-
-   $cachedData['deps'][] = new FileDependency( $fileName );
-   }
-   return true;
-   }
-
-   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
-}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/174872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4dd16a596d628fe744d13a2c1e7363bf916cc0c1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: REL1_23
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updating and debugging the extension - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updating and debugging the extension
..


Updating and debugging the extension

* Updates to 9.5.1

Languges added

* French (fr)
* Hebrew (he)
* Lithuanian (lt)
* Added qqq

Source of update is http://www.ratin.de/msupload.html

Change-Id: I889c627eb1ffc75e4bdc25a49beddacce56106bb
---
M .gitignore
A MsUpload.body.php
A MsUpload.css
A MsUpload.i18n.php
A MsUpload.js
A MsUpload.php
D README.TXT
A README.md
D css/images/ui-bg_flat_0_aa_40x100.png
D css/images/ui-bg_flat_75_ff_40x100.png
D css/images/ui-bg_glass_55_fbf9ee_1x400.png
D css/images/ui-bg_glass_65_ff_1x400.png
D css/images/ui-bg_glass_75_dadada_1x400.png
D css/images/ui-bg_glass_75_e6e6e6_1x400.png
D css/images/ui-bg_glass_95_fef1ec_1x400.png
D css/images/ui-bg_highlight-soft_75_cc_1x100.png
D css/jquery.css
D css/msupload.css
M i18n/de.json
M i18n/en.json
M i18n/es.json
A i18n/fr.json
A i18n/he.json
M i18n/it.json
M i18n/ja.json
A i18n/lt.json
M i18n/pt-br.json
A i18n/qqq.json
M i18n/ru.json
M i18n/zh-hans.json
M i18n/zh-hant.json
A images/msu_upload_button_old.gif
D js/msupload.insert.js
D js/msupload.js
D js/plupload/plupload.flash.js
D js/plupload/plupload.flash.swf
D js/plupload/plupload.full.js
D js/plupload/plupload.html4.js
D js/plupload/plupload.html5.js
D js/plupload/plupload.js
D js/plupload/plupload.silverlight.js
D js/plupload/plupload.silverlight.xap
D msupload.body.php
M msupload.i18n.php
D msupload.php
A plupload/Moxie.swf
A plupload/Moxie.xap
A plupload/plupload.full.min.js
48 files changed, 1,255 insertions(+), 1,541 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/174104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I889c627eb1ffc75e4bdc25a49beddacce56106bb
Gerrit-PatchSet: 9
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: REL1_23
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Ratin 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updating MsUpload to 9.5.1 - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updating MsUpload to 9.5.1
..


Updating MsUpload to 9.5.1

* Updates to 9.5.1

Languges added

* French (fr)
* Hebrew (he)
* Lithuanian (lt)
* Added qqq

Source of update is http://www.ratin.de/msupload.html

Change-Id: I07dc5fbc6d8480bdb8386cb1cea8f6b6b8942505
---
M README.TXT
M css/msupload.css
A images/msu_upload_button_old.gif
D js/msupload.insert.js
M js/msupload.js
A js/plupload/Moxie.swf
A js/plupload/Moxie.xap
A js/plupload/moxie.js
A js/plupload/moxie.min.js
D js/plupload/plupload.flash.js
D js/plupload/plupload.flash.swf
D js/plupload/plupload.full.js
A js/plupload/plupload.full.min.js
D js/plupload/plupload.html4.js
D js/plupload/plupload.html5.js
D js/plupload/plupload.js
D js/plupload/plupload.silverlight.js
D js/plupload/plupload.silverlight.xap
M msupload.body.php
M msupload.i18n.php
M msupload.php
21 files changed, 10,937 insertions(+), 413 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/174115
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07dc5fbc6d8480bdb8386cb1cea8f6b6b8942505
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: REL1_22
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Ratin 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update msupload.i18n.php and fix issue with .gitreview - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Update msupload.i18n.php and fix issue with .gitreview
..


Update msupload.i18n.php and fix issue with .gitreview

* Update msupload.i18.php

* Fixes issue with .gitreview the branch was master but should have been REL1_23

Change-Id: I9ad6f9077efecd369d268e51495f5340a6ef9044
---
M .gitreview
M msupload.i18n.php
2 files changed, 19 insertions(+), 15 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/.gitreview b/.gitreview
index e51b519..a1166a3 100644
--- a/.gitreview
+++ b/.gitreview
@@ -2,5 +2,5 @@
 host=gerrit.wikimedia.org
 port=29418
 project=mediawiki/extensions/MsUpload.git
-defaultbranch=master
+defaultbranch=REL1_23
 defaultrebase=0
diff --git a/msupload.i18n.php b/msupload.i18n.php
index eeb2776..dc970ba 100644
--- a/msupload.i18n.php
+++ b/msupload.i18n.php
@@ -11,21 +11,25 @@
  * This shim maintains compatibility back to MediaWiki 1.17.
  */
 $messages = array();
-$GLOBALS['wgHooks']['LocalisationCacheRecache'][] = function ( $cache, $code, 
&$cachedData ) {
-   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
-   foreach ( $codeSequence as $csCode ) {
-   $fileName = __DIR__ . "/i18n/$csCode.json";
-   if ( is_readable( $fileName ) ) {
-   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
-   foreach ( array_keys( $data ) as $key ) {
-   if ( $key === '' || $key[0] === '@' ) {
-   unset( $data[$key] );
+if ( !function_exists( 'wfJsonI18nShim9bfcb6d3a88a9ce0' ) ) {
+   function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
}
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
}
-   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
-   }
 
-   $cachedData['deps'][] = new FileDependency( $fileName );
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
}
-   return true;
-};
+
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9bfcb6d3a88a9ce0';
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/174102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ad6f9077efecd369d268e51495f5340a6ef9044
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: REL1_23
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Nemo bis 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Ratin 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix path to i18n - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fix path to i18n
..


Fix path to i18n

* This fixes the path to i18n the problem was introduced in the latest release.

* Renames msupload.php to MsUpload.php
* Renames msupload.i18n.php to MsUpload.i18n.php
* Renames msupload.body.php to MsUpload.body.php

Change-Id: I2ae068381e915f2b02378bef043ac767d27571f7
---
R MsUpload.body.php
R MsUpload.i18n.php
R MsUpload.php
3 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/msupload.body.php b/MsUpload.body.php
similarity index 100%
rename from msupload.body.php
rename to MsUpload.body.php
old mode 100755
new mode 100644
diff --git a/msupload.i18n.php b/MsUpload.i18n.php
similarity index 94%
rename from msupload.i18n.php
rename to MsUpload.i18n.php
index 5163cd3..bb63e53 100755
--- a/msupload.i18n.php
+++ b/MsUpload.i18n.php
@@ -15,7 +15,7 @@
function wfJsonI18nShim9bfcb6d3a88a9ce0( $cache, $code, &$cachedData ) {
$codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . 
"/extensions/MsUpload/i18n/$csCode.json";
+   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
if ( is_readable( $fileName ) ) {
$data = FormatJson::decode( file_get_contents( 
$fileName ), true );
foreach ( array_keys( $data ) as $key ) {
diff --git a/msupload.php b/MsUpload.php
similarity index 98%
rename from msupload.php
rename to MsUpload.php
old mode 100755
new mode 100644
index 9868704..e724188
--- a/msupload.php
+++ b/MsUpload.php
@@ -17,7 +17,7 @@
'dependencies' => 'jquery.ui.progressbar',
'styles' => 'MsUpload.css',
'messages' => array(
-   'msu-description',
+   'msu-desc',
'msu-button-title',
'msu-insert-link',
'msu-insert-gallery',

-- 
To view, visit https://gerrit.wikimedia.org/r/174079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ae068381e915f2b02378bef043ac767d27571f7
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: REL1_24
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Nischayn22 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Ratin 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Normalizing filenames - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Normalizing filenames
..


Normalizing filenames

Change-Id: I1bf126a9511a2c66d0bcc0f93e1b950c6c71001f
---
R MsCatSelect.body.php
R MsCatSelect.i18n.php
R MsCatSelect.php
3 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/mscatselect.body.php b/MsCatSelect.body.php
similarity index 100%
rename from mscatselect.body.php
rename to MsCatSelect.body.php
diff --git a/mscatselect.i18n.php b/MsCatSelect.i18n.php
similarity index 100%
rename from mscatselect.i18n.php
rename to MsCatSelect.i18n.php
diff --git a/mscatselect.php b/MsCatSelect.php
similarity index 100%
rename from mscatselect.php
rename to MsCatSelect.php

-- 
To view, visit https://gerrit.wikimedia.org/r/169984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf126a9511a2c66d0bcc0f93e1b950c6c71001f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Normalizing filenames - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169984

Change subject: Normalizing filenames
..

Normalizing filenames

Change-Id: I1bf126a9511a2c66d0bcc0f93e1b950c6c71001f
---
R MsCatSelect.body.php
R MsCatSelect.i18n.php
R MsCatSelect.php
3 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/84/169984/1

diff --git a/mscatselect.body.php b/MsCatSelect.body.php
similarity index 100%
rename from mscatselect.body.php
rename to MsCatSelect.body.php
diff --git a/mscatselect.i18n.php b/MsCatSelect.i18n.php
similarity index 100%
rename from mscatselect.i18n.php
rename to MsCatSelect.i18n.php
diff --git a/mscatselect.php b/MsCatSelect.php
similarity index 100%
rename from mscatselect.php
rename to MsCatSelect.php

-- 
To view, visit https://gerrit.wikimedia.org/r/169984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf126a9511a2c66d0bcc0f93e1b950c6c71001f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsCatSelect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updated, debugged and enhanced the extension - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updated, debugged and enhanced the extension
..


Updated, debugged and enhanced the extension

Change-Id: I9941e63c18d6e1d7fe3a158b983e1f9cf0802f8b
---
A .gitignore
A MsCatSelect.css
A MsCatSelect.js
M README.TXT
D css/mscatselect.css
M i18n/cs.json
M i18n/de.json
M i18n/en.json
M i18n/es.json
M i18n/nl.json
R images/node-no.png
R images/node.png
R images/node_2.png
R images/sortkey.png
D js/mscatselect.js
M mscatselect.body.php
M mscatselect.i18n.php
M mscatselect.php
18 files changed, 607 insertions(+), 703 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MsCatSelect.css b/MsCatSelect.css
new file mode 100755
index 000..9763616
--- /dev/null
+++ b/MsCatSelect.css
@@ -0,0 +1,138 @@
+#MsCatSelect {
+   width: 98%;
+   padding: .5em;
+   background: #ddd;
+   margin: 5px 0px;
+   clear: both;
+}
+
+#MsCatSelect div.row {
+   vertical-align: middle;
+   padding: 5px;
+}
+
+#MsCatSelect .row2 {
+   clear: both;
+}
+
+#MsCatSelect .row1 .subcat {
+   float: left;
+}
+
+#MsCatSelect .label {
+   font-weight: bold;
+   margin-right: 10px;
+}
+
+#MsCatSelect .maincat {
+   float: left;
+}
+
+#MsCatSelect .chzn-container {
+   float: left;
+}
+
+#MsCatSelect .row1 select {
+   float: left;
+}
+
+#MsCatSelect .chzn-container-single .chzn-single span {
+   text-overflow: clip;
+}
+
+#MsCatSelect .addcat {
+   background: #d8d8d8; /* Old browsers */
+   background: -moz-linear-gradient(top, #d8d8d8 20%, #d3d3d3 50%, #bfbfbf 
52%, #cecece 100%); /* FF3.6+ */
+   background: -webkit-gradient(linear, left top, left bottom, 
color-stop(20%,#d8d8d8), color-stop(50%,#d3d3d3), color-stop(52%,#bfbfbf), 
color-stop(100%,#cecece)); /* Chrome,Safari4+ */
+   background: -webkit-linear-gradient(top, #d8d8d8 20%,#d3d3d3 
50%,#bfbfbf 52%,#cecece 100%); /* Chrome10+,Safari5.1+ */
+   background: -o-linear-gradient(top, #d8d8d8 20%,#d3d3d3 50%,#bfbfbf 
52%,#cecece 100%); /* Opera 11.10+ */
+   background: -ms-linear-gradient(top, #d8d8d8 20%,#d3d3d3 50%,#bfbfbf 
52%,#cecece 100%); /* IE10+ */
+   background: linear-gradient(to bottom, #d8d8d8 20%,#d3d3d3 50%,#bfbfbf 
52%,#cecece 100%); /* W3C */
+   filter: progid:DXImageTransform.Microsoft.gradient( 
startColorstr='#d8d8d8', endColorstr='#cecece',GradientType=0 ); /* IE6-9 */
+   -webkit-border-radius: 5px;
+   -moz-border-radius: 5px;
+   border-radius: 5px;
+   -moz-background-clip: padding;
+   -webkit-background-clip: padding-box;
+   background-clip: padding-box;
+   border: 1px solid #aa;
+   -webkit-box-shadow: 0 0 3px #ff inset, 0 1px 1px rgba(0,0,0,0.1);
+   -moz-box-shadow: 0 0 3px #ff inset, 0 1px 1px rgba(0,0,0,0.1);
+   box-shadow: 0 0 3px #ff inset, 0 1px 1px rgba(0,0,0,0.1);
+   display: inline-block;
+   position: relative;
+   height: 20px;
+   line-height: 22px;
+   padding: 1px 8px 2px 8px;
+   color: #44;
+   text-decoration: none;
+   margin-left: 10px;
+   cursor: pointer;
+}
+
+#MsCatSelect .row1 .addcat {
+   float: left;
+}
+
+#MsCatSelect .addcat:hover {
+   color: #00;
+   border: 1px solid #5897FB;
+}
+
+#MsCatSelect .node, #MsCatSelect .no-node {
+   background: url('images/node.png') no-repeat 8px 5px;
+   padding: 12px 15px;
+   float: left;
+}
+
+#MsCatSelect .no-node {
+   background: url('images/node-no.png') no-repeat 8px 5px;
+}
+
+#MsCatSelect .subcat-dd select {
+   background: transparent;
+   border: 0;
+}
+
+#MsCatSelect .row2 input {
+   padding: 3px; 
+   outline: none; 
+   background: #ee; /* Old browsers */
+   background: -moz-linear-gradient(top, #ee 0%, #ff 23%); /* 
FF3.6+ */
+   background: -webkit-gradient(linear, left top, left bottom, 
color-stop(0%,#ee), color-stop(23%,#ff)); /* Chrome,Safari4+ */
+   background: -webkit-linear-gradient(top, #ee 0%,#ff 23%); /* 
Chrome10+,Safari5.1+ */
+   background: -o-linear-gradient(top, #ee 0%,#ff 23%); /* Opera 
11.10+ */
+   background: -ms-linear-gradient(top, #ee 0%,#ff 23%); /* IE10+ 
*/
+   background: linear-gradient(to bottom, #ee 0%,#ff 23%); /* W3C 
*/
+   filter: progid:DXImageTransform.Microsoft.gradient( 
startColorstr='#ee', endColorstr='#ff',GradientType=0 ); /* IE6-9 */
+   -webkit-border-radius: 3px; 
+   -moz-border-radius: 3px; 
+   border-radius: 3px; 
+   border: 1px solid #aa;
+}
+
+#MsCatSelect .untercat-hinw {
+   margin-left: 10px;
+   color: #a

[MediaWiki-commits] [Gerrit] Updated, debugged and enhanced the extension - change (mediawiki...MsCatSelect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/169946

Change subject: Updated, debugged and enhanced the extension
..

Updated, debugged and enhanced the extension

Change-Id: I9941e63c18d6e1d7fe3a158b983e1f9cf0802f8b
---
M README.TXT
D css/mscatselect.css
M i18n/cs.json
M i18n/de.json
M i18n/en.json
M i18n/es.json
M i18n/nl.json
D img/node-no.png
D img/node.png
D img/node_2.png
D img/sortkey.png
D js/mscatselect.js
M mscatselect.body.php
M mscatselect.i18n.php
M mscatselect.php
15 files changed, 207 insertions(+), 703 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsCatSelect 
refs/changes/46/169946/1

diff --git a/README.TXT b/README.TXT
old mode 100644
new mode 100755
index 8800d95..6bf36ef
--- a/README.TXT
+++ b/README.TXT
@@ -1,30 +1,28 @@
-
-#Author:
-#Martin Schwindl, mscatsel...@ratin.de
-#
-#Icons: 
-#Some icons by Yusuke Kamiyamane. All rights reserved. Licensed under a 
Creative Commons Attribution 3.0 License.
-#http://p.yusukekamiyamane.com
-#
-#Chosen, a Select Box Enhancer for jQuery and Protoype
-#by Patrick Filler for Harvest
-#Available for use under the MIT License
-#Copyright (c) 2011-2013 by Harvest
-#Permission is hereby granted, free of charge, to any person obtaining a copy 
of this software and associated documentation files (the "Software"), to deal 
in the Software without restriction, including without limitation the rights to 
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies 
of the Software, and to permit persons to whom the Software is furnished to do 
so, subject to the following conditions:
-#The above copyright notice and this permission notice shall be included in 
all copies or substantial portions of the Software.
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 
SOFTWARE.
-#http://harvesthq.github.com/chosen/
-#
-#Usage:
-#LocalSettings.php:
-#
-#//StartMsCatSelect
-#$wgMSCS_WarnNoCat = false;
-#$wgMSCS_MaxSubcategories = 500;
-#$wgMSCS_MainCategories = array("Category1","Category2");
-#require_once("$IP/extensions/MsCatSelect/mscatselect.php");
-#//End--MsCatSelect
-#
-#
-#
+
+#
+# Author: Martin Schwindl, mscatsel...@ratin.de
+#
+# Updated, debugged and normalised by Luis Felipe Schenone 
(scheno...@gmail.com) in 2014
+#
+# Some icons by Yusuke Kamiyamane. All rights reserved. Licensed under a 
Creative Commons Attribution 3.0 License.
+# http://p.yusukekamiyamane.com
+# 
+# Chosen, a Select Box Enhancer for jQuery and Protoype
+# by Patrick Filler for Harvest
+# Available for use under the MIT License
+# Copyright (c) 2011-2013 by Harvest
+# Permission is hereby granted, free of charge, to any person obtaining a copy 
of this software and associated documentation files (the "Software"), to deal 
in the Software without restriction, including without limitation the rights to 
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies 
of the Software, and to permit persons to whom the Software is furnished to do 
so, subject to the following conditions:
+# The above copyright notice and this permission notice shall be included in 
all copies or substantial portions of the Software.
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 
SOFTWARE.
+# http://harvesthq.github.com/chosen/
+#
+# To install, add the following to your LocalSettings.php:
+#
+# #StartMsCatSelect
+# require_once "$IP/extensions/MsCatSelect/MsCatSelect.php";
+# $wgMSCS_WarnNoCategories = false; //Default 'true'
+# $wgMSCS_MainCategories = array( 'Category1', 'Category2' ); //Defaults 'null'
+# $wgGroupPermissions['*']['apihighlimits'] = true; //Regular users will only 
be shown 500 subcategories by default, with this switch enabled all 
subcategories will be shown.
+# #End--MsCatSelect
+#
 
\ No newline at end of file
diff --git a/css

[MediaWiki-commits] [Gerrit] Updating and debugging the extension - change (mediawiki...MsUpload)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/166986

Change subject: Updating and debugging the extension
..

Updating and debugging the extension

Change-Id: I9ff37f40237ad4e77323f6ee728e4808d654ed4c
---
M .gitignore
A MsUpload.css
A MsUpload.js
M README.TXT
D css/images/ui-bg_flat_0_aa_40x100.png
D css/images/ui-bg_flat_75_ff_40x100.png
D css/images/ui-bg_glass_55_fbf9ee_1x400.png
D css/images/ui-bg_glass_65_ff_1x400.png
D css/images/ui-bg_glass_75_dadada_1x400.png
D css/images/ui-bg_glass_75_e6e6e6_1x400.png
D css/images/ui-bg_glass_95_fef1ec_1x400.png
D css/images/ui-bg_highlight-soft_75_cc_1x100.png
D css/jquery.css
D css/msupload.css
M i18n/de.json
M i18n/en.json
M i18n/es.json
A i18n/fr.json
A i18n/he.json
M i18n/it.json
M i18n/ja.json
A i18n/lt.json
M i18n/pt-br.json
M i18n/ru.json
M i18n/zh-hans.json
M i18n/zh-hant.json
M images/msu_close.png
M images/msu_document-film.png
M images/msu_document-globe.png
M images/msu_document-image.png
M images/msu_document-music.png
M images/msu_document-pdf.png
M images/msu_document.png
M images/msu_error-small.png
M images/msu_error.png
M images/msu_loading.png
M images/msu_progress_stripe.png
M images/msu_tick.png
M images/msu_upload_button.png
A images/msu_upload_button_old.gif
M images/msu_upload_icon.png
D js/msupload.insert.js
D js/msupload.js
D js/plupload/plupload.flash.js
D js/plupload/plupload.flash.swf
D js/plupload/plupload.full.js
D js/plupload/plupload.html4.js
D js/plupload/plupload.html5.js
D js/plupload/plupload.js
D js/plupload/plupload.silverlight.js
D js/plupload/plupload.silverlight.xap
M msupload.body.php
M msupload.i18n.php
M msupload.php
A plupload/Moxie.swf
A plupload/Moxie.xap
A plupload/plupload.full.min.js
57 files changed, 1,170 insertions(+), 1,514 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MsUpload 
refs/changes/86/166986/1


-- 
To view, visit https://gerrit.wikimedia.org/r/166986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ff37f40237ad4e77323f6ee728e4808d654ed4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MsUpload
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Convert i18n to JSON - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Convert i18n to JSON
..


Convert i18n to JSON

While I am at it: Remove . from end of sentence for consistency

Change-Id: I60fd92a690be3a2320c1c11b7de85feac55a1695
---
M MobileDetect.i18n.php
M MobileDetect.php
A i18n/en.json
A i18n/es.json
A i18n/qqq.json
5 files changed, 53 insertions(+), 23 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MobileDetect.i18n.php b/MobileDetect.i18n.php
index 8a227a1..3eaa541 100644
--- a/MobileDetect.i18n.php
+++ b/MobileDetect.i18n.php
@@ -1,30 +1,35 @@
 https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
  *
- * @file
- * @ingroup Extensions
+ * Beginning with MediaWiki 1.23, translation strings are stored in json files,
+ * and the EXTENSION.i18n.php file only exists to provide compatibility with
+ * older releases of MediaWiki. For more information about this migration, see:
+ * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
+ *
+ * This shim maintains compatibility back to MediaWiki 1.17.
  */
-
 $messages = array();
+if ( !function_exists( 'wfJsonI18nShim9f9518fdf44e8f14' ) ) {
+   function wfJsonI18nShim9f9518fdf44e8f14( $cache, $code, &$cachedData ) {
+   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
+   foreach ( $codeSequence as $csCode ) {
+   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
+   if ( is_readable( $fileName ) ) {
+   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
+   foreach ( array_keys( $data ) as $key ) {
+   if ( $key === '' || $key[0] === '@' ) {
+   unset( $data[$key] );
+   }
+   }
+   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
+   }
 
-/** English
- * @author Luis Felipe Schenone
- */
-$messages['en'] = array(
-   'mobiledetect-desc' => 'Detects mobile devices and allows to control 
the content visible in each case with the  and 
 tags.',
-);
+   $cachedData['deps'][] = new FileDependency( $fileName );
+   }
+   return true;
+   }
 
-/** Message documentation (Message documentation)
- * @author Luis Felipe Schenone
- */
-$messages['qqq'] = array(
-   'mobiledetect-desc' => 
'{{desc|name=MobileDetect|url=https://www.mediawiki.org/wiki/Extension:MobileDetect}}',
-);
-
-/** Spanish (español)
- * @author Luis Felipe Schenone
- */
-$messages['es'] = array(
-   'mobiledetect-desc' => 'Detecta dispositivos móbiles y permite 
controlar el contenido visible en cada caso con las etiquetas  
y ',
-);
\ No newline at end of file
+   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShim9f9518fdf44e8f14';
+}
diff --git a/MobileDetect.php b/MobileDetect.php
index 39e9126..6859c69 100644
--- a/MobileDetect.php
+++ b/MobileDetect.php
@@ -10,6 +10,7 @@
 );
 
 $wgExtensionMessagesFiles['MobileDetect'] = __DIR__ . '/MobileDetect.i18n.php';
+$wgMessagesDirs['MobileDetect'] = __DIR__ . '/i18n';
 
 $wgAutoloadClasses['MobileDetect'] = __DIR__ . '/MobileDetect.body.php';
 
diff --git a/i18n/en.json b/i18n/en.json
new file mode 100644
index 000..72b369f
--- /dev/null
+++ b/i18n/en.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "Luis Felipe Schenone"
+   ]
+   },
+   "mobiledetect-desc": "Detects mobile devices and allows to control the 
content visible in each case with the  and  
tags"
+}
diff --git a/i18n/es.json b/i18n/es.json
new file mode 100644
index 000..2cb1063
--- /dev/null
+++ b/i18n/es.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "Luis Felipe Schenone"
+   ]
+   },
+   "mobiledetect-desc": "Detecta dispositivos móbiles y permite controlar 
el contenido visible en cada caso con las etiquetas  y 
"
+}
diff --git a/i18n/qqq.json b/i18n/qqq.json
new file mode 100644
index 000..7bf8b3d
--- /dev/null
+++ b/i18n/qqq.json
@@ -0,0 +1,8 @@
+{
+   "@metadata": {
+   "authors": [
+   "Luis Felipe Schenone"
+   ]
+   },
+   "mobiledetect-desc": 
"{{desc|name=MobileDetect|url=https://www.mediawiki.org/wiki/Extension:MobileDetect}}";
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/163810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60fd92a690be3a2320c1c

[MediaWiki-commits] [Gerrit] Removing trailing whitespaces - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Removing trailing whitespaces
..


Removing trailing whitespaces

Change-Id: Ic104ab48e6bd645b20fc552ffca434785bfceb71
---
M MobileDetect.body.php
M MobileDetect.i18n.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/MobileDetect.body.php b/MobileDetect.body.php
index d9d7f0e..77dbc44 100644
--- a/MobileDetect.body.php
+++ b/MobileDetect.body.php
@@ -10,7 +10,7 @@
 
public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
if ( self::isMobile() ) {
-   return '';  
+   return '';
}
return $parser->recursiveTagParse( $input );
}
diff --git a/MobileDetect.i18n.php b/MobileDetect.i18n.php
index a6d0883..8a227a1 100644
--- a/MobileDetect.i18n.php
+++ b/MobileDetect.i18n.php
@@ -27,4 +27,4 @@
  */
 $messages['es'] = array(
'mobiledetect-desc' => 'Detecta dispositivos móbiles y permite 
controlar el contenido visible en cada caso con las etiquetas  
y ',
-);
+);
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/163799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic104ab48e6bd645b20fc552ffca434785bfceb71
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileDetect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Removing trailing whitespaces - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/163799

Change subject: Removing trailing whitespaces
..

Removing trailing whitespaces

Change-Id: Ic104ab48e6bd645b20fc552ffca434785bfceb71
---
M MobileDetect.body.php
M MobileDetect.i18n.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileDetect 
refs/changes/99/163799/1

diff --git a/MobileDetect.body.php b/MobileDetect.body.php
index d9d7f0e..77dbc44 100644
--- a/MobileDetect.body.php
+++ b/MobileDetect.body.php
@@ -10,7 +10,7 @@
 
public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
if ( self::isMobile() ) {
-   return '';  
+   return '';
}
return $parser->recursiveTagParse( $input );
}
diff --git a/MobileDetect.i18n.php b/MobileDetect.i18n.php
index a6d0883..8a227a1 100644
--- a/MobileDetect.i18n.php
+++ b/MobileDetect.i18n.php
@@ -27,4 +27,4 @@
  */
 $messages['es'] = array(
'mobiledetect-desc' => 'Detecta dispositivos móbiles y permite 
controlar el contenido visible en cada caso con las etiquetas  
y ',
-);
+);
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/163799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic104ab48e6bd645b20fc552ffca434785bfceb71
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileDetect
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updated and enhanced the extension - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Updated and enhanced the extension
..


Updated and enhanced the extension

This extension was only available in-wiki at
https://www.mediawiki.org/wiki/Extension:MobileDetect
I'm uploading it to Gerrit for the first time, after updating
its code structure, while keeping backwards compatibility,
and enhancing it with the tags  and 

Change-Id: I85cca8345fcbd27499508ad687028771f06766ca
---
A .gitignore
A MobileDetect.body.php
A MobileDetect.i18n.php
M MobileDetect.php
4 files changed, 138 insertions(+), 88 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MobileDetect.body.php b/MobileDetect.body.php
new file mode 100644
index 000..d9d7f0e
--- /dev/null
+++ b/MobileDetect.body.php
@@ -0,0 +1,89 @@
+setHook( 'nomobile', 'MobileDetect::nomobile' );
+   $parser->setHook( 'mobileonly', 'MobileDetect::mobileonly' );
+   return true;
+   }
+
+   public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
+   if ( self::isMobile() ) {
+   return '';  
+   }
+   return $parser->recursiveTagParse( $input );
+   }
+
+   public static function mobileonly( $input, array $args, Parser $parser, 
PPFrame $frame ) {
+   if ( self::isMobile() ) {
+   return $parser->recursiveTagParse( $input );
+   }
+   return '';
+   }
+
+   public static function isMobile() {
+   $user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? 
$_SERVER['HTTP_USER_AGENT'] : '';
+   $http_accept = isset( $_SERVER['HTTP_ACCEPT'] ) ? 
$_SERVER['HTTP_ACCEPT'] : '';
+
+   // iPad
+   if ( preg_match( '/ipad/i', $user_agent ) ) {
+   return false; // Not Mobile
+   }
+
+   // iPod/iPhone
+   if ( preg_match( '/ipod/i', $user_agent ) || preg_match( 
'/iphone/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Android
+   if ( preg_match( '/android/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Opera Mini/Mobile
+   if ( preg_match( '/opera mini/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Blackberry
+   if ( preg_match( '/blackberry/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Palm OS
+   if ( preg_match( '/(pre\/|palm 
os|palm|hiptop|avantgo|plucker|xiino|blazer|elaine)/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Windows Mobile
+   if ( preg_match( '/(iris|3g_t|windows ce|opera mobi|windows ce; 
smartphone;|windows ce; iemobile)/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Others
+   // Check if any of the values listed create a match on the user 
agent - these are some of the most common terms used in agents to identify them 
as being mobile devices - the i at the end makes it case insensitive
+   if ( preg_match( '/(mini 9.5|vx1000|lge 
|m800|e860|u940|ux840|compal|wireless| 
mobi|ahong|lg380|lgku|lgu900|lg210|lg47|lg920|lg840|lg370|sam-r|mg50|s55|g83|t66|vx400|mk99|d615|d763|el370|sl900|mp500|samu3|samu4|vx10|xda_|samu5|samu6|samu7|samu9|a615|b832|m881|s920|n210|s700|c-810|_h797|mob-x|sk16d|848b|mowser|s580|r800|471x|v120|rim8|c500foma:|160x|x160|480x|x640|t503|w839|i250|sprint|w398samr810|m5252|c7100|mt126|x225|s5330|s820|htil-g1|fly
 
v71|s302|-x113|novarra|k610i|-three|8325rc|8352rc|sanyo|vx54|c888|nx250|n120|mtk
 
|c5588|s710|t880|c5005|i;458x|p404i|s210|c5100|teleca|s940|c500|s590|foma|samsu|vx8|vx9|a1000|_mms|myx|a700|gu1100|bc831|e300|ems100|me701|me702m-three|sd588|s800|8325rc|ac831|mw200|brew
 
|d88|htc\/|htc_touch|355x|m50|km100|d736|p-9521|telco|sl74|ktouch|m4u\/|me702|8325rc|kddi|phone|lg
 |sonyericsson|samsung|240x|x320|vx10|nokia|sony 
cmd|motorola|up.browser|up.link|mmp|symbian|smartphone|midp|wap|vodafone|o2|pocket|kindle|mobile|psp|treo)/i',
 $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Detect WAP Support
+   if ( ( strpos( $http_accept, 'text/vnd.wap.wml') > 0 ) || ( 
strpos( $http_accept, 'application/vnd.wap.xhtml+xml' ) > 0 ) ) {
+   return true; // Mobile
+   }
+
+   // Detect WAP Header Support
+

[MediaWiki-commits] [Gerrit] Updated and enhanced the extension - change (mediawiki...MobileDetect)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/163539

Change subject: Updated and enhanced the extension
..

Updated and enhanced the extension

This extension was only available in-wiki at
https://www.mediawiki.org/wiki/Extension:MobileDetect
I'm uploading it to Gerrit for the first time, after updating
it's code structure, while keeping backwards compatibility,
and enhancing it with the tags  and 

Change-Id: I85cca8345fcbd27499508ad687028771f06766ca
---
A .gitignore
A MobileDetect.body.php
A MobileDetect.i18n.php
M MobileDetect.php
4 files changed, 138 insertions(+), 88 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileDetect 
refs/changes/39/163539/1

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..496ee2c
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.DS_Store
\ No newline at end of file
diff --git a/MobileDetect.body.php b/MobileDetect.body.php
new file mode 100644
index 000..6a68c6d
--- /dev/null
+++ b/MobileDetect.body.php
@@ -0,0 +1,89 @@
+setHook( 'nomobile', 'MobileTags::nomobile' );
+   $parser->setHook( 'mobileonly', 'MobileTags::mobileonly' );
+   return true;
+   }
+
+   public static function nomobile( $input, array $args, Parser $parser, 
PPFrame $frame ) {
+   if ( self::isMobile() ) {
+   return '';  
+   }
+   return $parser->recursiveTagParse( $input );
+   }
+
+   public static function mobileonly( $input, array $args, Parser $parser, 
PPFrame $frame ) {
+   if ( self::isMobile() ) {
+   return $parser->recursiveTagParse( $input );
+   }
+   return '';
+   }
+
+   public static function isMobile() {
+   $user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? 
$_SERVER['HTTP_USER_AGENT'] : '';
+   $http_accept = isset( $_SERVER['HTTP_ACCEPT'] ) ? 
$_SERVER['HTTP_ACCEPT'] : '';
+
+   // iPad
+   if ( preg_match( '/ipad/i', $user_agent ) ) {
+   return false; // Not Mobile
+   }
+
+   // iPod/iPhone
+   if ( preg_match( '/ipod/i', $user_agent ) || preg_match( 
'/iphone/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Android
+   if ( preg_match( '/android/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Opera Mini/Mobile
+   if ( preg_match( '/opera mini/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Blackberry
+   if ( preg_match( '/blackberry/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Palm OS
+   if ( preg_match( '/(pre\/|palm 
os|palm|hiptop|avantgo|plucker|xiino|blazer|elaine)/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Windows Mobile
+   if ( preg_match( '/(iris|3g_t|windows ce|opera mobi|windows ce; 
smartphone;|windows ce; iemobile)/i', $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Others
+   // Check if any of the values listed create a match on the user 
agent - these are some of the most common terms used in agents to identify them 
as being mobile devices - the i at the end makes it case insensitive
+   if ( preg_match( '/(mini 9.5|vx1000|lge 
|m800|e860|u940|ux840|compal|wireless| 
mobi|ahong|lg380|lgku|lgu900|lg210|lg47|lg920|lg840|lg370|sam-r|mg50|s55|g83|t66|vx400|mk99|d615|d763|el370|sl900|mp500|samu3|samu4|vx10|xda_|samu5|samu6|samu7|samu9|a615|b832|m881|s920|n210|s700|c-810|_h797|mob-x|sk16d|848b|mowser|s580|r800|471x|v120|rim8|c500foma:|160x|x160|480x|x640|t503|w839|i250|sprint|w398samr810|m5252|c7100|mt126|x225|s5330|s820|htil-g1|fly
 
v71|s302|-x113|novarra|k610i|-three|8325rc|8352rc|sanyo|vx54|c888|nx250|n120|mtk
 
|c5588|s710|t880|c5005|i;458x|p404i|s210|c5100|teleca|s940|c500|s590|foma|samsu|vx8|vx9|a1000|_mms|myx|a700|gu1100|bc831|e300|ems100|me701|me702m-three|sd588|s800|8325rc|ac831|mw200|brew
 
|d88|htc\/|htc_touch|355x|m50|km100|d736|p-9521|telco|sl74|ktouch|m4u\/|me702|8325rc|kddi|phone|lg
 |sonyericsson|samsung|240x|x320|vx10|nokia|sony 
cmd|motorola|up.browser|up.link|mmp|symbian|smartphone|midp|wap|vodafone|o2|pocket|kindle|mobile|psp|treo)/i',
 $user_agent ) ) {
+   return true; // Mobile
+   }
+
+   // Detect WAP Support
+   if ( ( strpos( $http_accept, 'text/vnd.wap.wml') > 0 ) || ( 
strpos( $http_accept, 'application/vnd.wap.xhtml+xml' ) > 0 ) ) {
+   return true; // Mobile
+

[MediaWiki-commits] [Gerrit] Watchlist: changed "all" for the max number of days available - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/163142

Change subject: Watchlist: changed "all" for the max number of days available
..

Watchlist: changed "all" for the max number of days available

Bug 26022

Continues the change Iffcbc837, which was abandoned for old.

Change-Id: I349c801d74dade093a64f17afa8f1d18e0249c3e
---
M includes/DefaultSettings.php
M includes/specials/SpecialWatchlist.php
M languages/i18n/en.json
M languages/i18n/qqq.json
4 files changed, 10 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/163142/1

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 28349e9..ea2242f 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -5731,9 +5731,9 @@
 /**
  * Recentchanges items are periodically purged; entries older than this many
  * seconds will go.
- * Default: 13 weeks = about three months
+ * Default: 90 days = about three months
  */
-$wgRCMaxAge = 13 * 7 * 24 * 3600;
+$wgRCMaxAge = 90 * 24 * 3600;
 
 /**
  * Filter $wgRCLinkDays by $wgRCMaxAge to avoid showing links for numbers
diff --git a/includes/specials/SpecialWatchlist.php 
b/includes/specials/SpecialWatchlist.php
index 8f2f86b..7becfaa 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -562,12 +562,10 @@
 
protected function daysLink( $d, $options = array() ) {
$options['days'] = $d;
-   $message = $d ? $this->getLanguage()->formatNum( $d )
-   : $this->msg( 'watchlistall2' )->escaped();
 
return Linker::linkKnown(
$this->getPageTitle(),
-   $message,
+   $this->getLanguage()->formatNum( $d ),
array(),
$options
);
@@ -581,8 +579,11 @@
 * @return string
 */
protected function cutoffLinks( $days, $options = array() ) {
+   global $wgRCMaxAge;
+   $watchlistMaxDays = ceil( $wgRCMaxAge / ( 3600 * 24 ) );
+
$hours = array( 1, 2, 6, 12 );
-   $days = array( 1, 3, 7 );
+   $days = array( 1, 3, 7, $watchlistMaxDays );
$i = 0;
foreach ( $hours as $h ) {
$hours[$i++] = $this->hoursLink( $h, $options );
@@ -594,8 +595,7 @@
 
return $this->msg( 'wlshowlast' )->rawParams(
$this->getLanguage()->pipeList( $hours ),
-   $this->getLanguage()->pipeList( $days ),
-   $this->daysLink( 0, $options ) )->parse();
+   $this->getLanguage()->pipeList( $days ) )->parse();
}
 
/**
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 12d1429..8cbbd2c 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1828,7 +1828,7 @@
"wlheader-enotif": "Email notification is enabled.",
"wlheader-showupdated": "Pages that have been changed since you last 
visited them are shown in bold.",
"wlnote": "Below {{PLURAL:$1|is the last change|are the last 
$1 changes}} in the last {{PLURAL:$2|hour|$2 
hours}}, as of $3, $4.",
-   "wlshowlast": "Show last $1 hours $2 days $3",
+   "wlshowlast": "Show last $1 hours $2 days",
"watchlist-options": "Watchlist options",
"watching": "Watching...",
"unwatching": "Unwatching...",
@@ -3050,7 +3050,6 @@
"exif-urgency-low": "Low ($1)",
"exif-urgency-high": "High ($1)",
"exif-urgency-other": "User-defined priority ($1)",
-   "watchlistall2": "all",
"namespacesall": "all",
"monthsall": "all",
"confirmemail": "Confirm email address",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index d480e2d..db3b894 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1990,7 +1990,7 @@
"wlheader-enotif": "Message at the top of [[Special:Watchlist]], after 
{{msg-mw|watchlist-details}}. Has to be a full sentence.\n\nSee also:\n* 
{{msg-mw|Watchlist-options|fieldset}}\n* {{msg-mw|enotif reset|Submit button 
text}}",
"wlheader-showupdated": "Message at the top of [[Special:Watchlist]], 
after {{msg-mw|watchlist-details}}. Has to be a full sentence.",
"wlnote": "Used on [[Special:Watchlist]] when a maximum number of hours 
or days is specified.\n\nParameters:\n* $1 - the number of changes shown\n* $2 
- the number of hours for which the changes are shown\n* $3 - a date alone\n* 
$4 - a time alone",
-   "wlshowlast": "Appears on [[Special:Watchlist]]. Parameters:\n* $1 - a 
choice of different numbers of hours (\"1 | 2 | 6 | 12\")\n* $2 - a choice of 
different numbers of days (\"1 | 3 | 7\")\n* $3 - 
{{msg-mw|watchlistall2}}\nClicking on you

[MediaWiki-commits] [Gerrit] Wrapped the brackets of the collapse buttons with spans - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/148013

Change subject: Wrapped the brackets of the collapse buttons with spans
..

Wrapped the brackets of the collapse buttons with spans

To make them accessible via CSS, similarly to what has been done with
the brackets of the edit buttons.

Change-Id: I6b961b5f11f81e6e8ef768ba43fe7f20b886051a
---
M resources/src/jquery/jquery.makeCollapsible.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/148013/1

diff --git a/resources/src/jquery/jquery.makeCollapsible.js 
b/resources/src/jquery/jquery.makeCollapsible.js
index a4dc33b..c4e2520 100644
--- a/resources/src/jquery/jquery.makeCollapsible.js
+++ b/resources/src/jquery/jquery.makeCollapsible.js
@@ -273,8 +273,8 @@
.text( collapseText )
.wrap( '' )
.parent()
-   .prepend( ' [' )
-   .append( '] ' )
+   .prepend( '[' )
+   .append( ']' )
.on( 'click.mw-collapsible 
keypress.mw-collapsible', actionHandler );
};
 

-- 
To view, visit https://gerrit.wikimedia.org/r/148013
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b961b5f11f81e6e8ef768ba43fe7f20b886051a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Changing deprecated getPageTitle() for getTitle() - change (mediawiki...Renameuser)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/141106

Change subject: Changing deprecated getPageTitle() for getTitle()
..

Changing deprecated getPageTitle() for getTitle()

Change-Id: Iaa11f776e518cb3863eac960cb10cc9268cea698
---
M specials/SpecialRenameuser.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser 
refs/changes/06/141106/1

diff --git a/specials/SpecialRenameuser.php b/specials/SpecialRenameuser.php
index f6b9bac..d869e2a 100644
--- a/specials/SpecialRenameuser.php
+++ b/specials/SpecialRenameuser.php
@@ -58,7 +58,7 @@
}
 
$out->addHTML(
-   Xml::openElement( 'form', array( 'method' => 'post', 
'action' => $this->getPageTitle()->getLocalUrl(), 'id' => 'renameuser' ) ) .
+   Xml::openElement( 'form', array( 'method' => 'post', 
'action' => $this->getTitle()->getLocalUrl(), 'id' => 'renameuser' ) ) .
Xml::openElement( 'fieldset' ) .
Xml::element( 'legend', null, $this->msg( 'renameuser' 
)->text() ) .
Xml::openElement( 'table', array( 'id' => 
'mw-renameuser-table' ) ) .

-- 
To view, visit https://gerrit.wikimedia.org/r/141106
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa11f776e518cb3863eac960cb10cc9268cea698
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Renameuser
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update because of an update by Yotpo - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Update because of an update by Yotpo
..


Update because of an update by Yotpo

Change-Id: I56c337b68929091d679947b89faafb8593d65f75
---
M YotpoReviews.body.php
M YotpoReviews.php
2 files changed, 14 insertions(+), 17 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/YotpoReviews.body.php b/YotpoReviews.body.php
index 87577f5..83fac50 100644
--- a/YotpoReviews.body.php
+++ b/YotpoReviews.body.php
@@ -9,13 +9,12 @@
 
public static function addYotpoScript( &$data ) {
global $wgYotpoAppKey;
-   $data .= '';
-   $data .= 'var yotpo_app_key = "' . $wgYotpoAppKey . 
'";';
+   $data .= '(function e(){var 
e=document.createElement("script");e.type="text/javascript",e.async=true,e.src="//staticw2.yotpo.com/'
 . $wgYotpoAppKey . '/widget.js";var 
t=document.getElementsByTagName("script")[0];t.parentNode.insertBefore(e,t)})();';
return true;
}
 
public static function renderReviews( $input, array $args, Parser 
$parser, PPFrame $frame ) {
-   global $wgLogo, $wgServer, $wgYotpoAppKey;
+   global $wgTitle, $wgLogo, $wgServer, $wgYotpoAppKey;
 
$width = '100%'; //Default
if ( array_key_exists( 'width', $args ) ) {
@@ -41,18 +40,17 @@
$margin = '0 auto 0 auto';
}
 
-   $title = $parser->getTitle();
+   $float = 'none'; //Default
+   if ( array_key_exists( 'float', $args ) ) {
+   $float = $args['float'];
+   }
 
-   $data_app_key = $wgYotpoAppKey;
-   $data_domain = $wgServer;
-   $data_product_id = $title->getDBKey();
-   $data_product_models = '';
-   $data_name = $title->getText();
-   $data_url = $title->getFullURL();
+   $data_product_id = $wgTitle->getDBKey();
+   $data_name = $wgTitle->getText();
+   $data_url = $wgTitle->getFullURL();
$data_image_url = '';
$data_description = '';
-   $data_bread_crumbs = '';
 
-   return '';
+   return '';
}
 }
\ No newline at end of file
diff --git a/YotpoReviews.php b/YotpoReviews.php
index 07934e5..c5a0abe 100644
--- a/YotpoReviews.php
+++ b/YotpoReviews.php
@@ -3,15 +3,14 @@
 $wgExtensionCredits['parserhook'][] = array(
'path'   => __FILE__,
'name'   => 'YotpoReviews',
-   'descriptionmsg' => 'yotporeviews-desc',
-   'version'=> '0.2.0',
+   'descriptionmsg' => 'yotpo-reviews-desc',
+   'version'=> 0.2,
'author' => 'Luis Felipe Schenone',
-   'url'=> 
'https://www.mediawiki.org/wiki/Extension:YotpoReviews'
+   'url'=> 
'http://www.mediawiki.org/wiki/Extension:YotpoReviews'
 );
 
-$wgMessagesDirs['YotpoReviews'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['YotpoReviews'] = __DIR__ . '/YotpoReviews.i18n.php';
 $wgAutoloadClasses['YotpoReviews'] = __DIR__ . '/YotpoReviews.body.php';
 
 $wgHooks['ParserFirstCallInit'][] = 'YotpoReviews::setParserHook';
-$wgHooks['SkinAfterContent'][] = 'YotpoReviews::addYotpoScript';
+$wgHooks['SkinAfterContent'][] = 'YotpoReviews::addYotpoScript';
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/141101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56c337b68929091d679947b89faafb8593d65f75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/YotpoReviews
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update because of an update by Yotpo - change (mediawiki...YotpoReviews)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/141101

Change subject: Update because of an update by Yotpo
..

Update because of an update by Yotpo

Change-Id: I56c337b68929091d679947b89faafb8593d65f75
---
M YotpoReviews.body.php
M YotpoReviews.php
2 files changed, 14 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/YotpoReviews 
refs/changes/01/141101/1

diff --git a/YotpoReviews.body.php b/YotpoReviews.body.php
index 87577f5..83fac50 100644
--- a/YotpoReviews.body.php
+++ b/YotpoReviews.body.php
@@ -9,13 +9,12 @@
 
public static function addYotpoScript( &$data ) {
global $wgYotpoAppKey;
-   $data .= '';
-   $data .= 'var yotpo_app_key = "' . $wgYotpoAppKey . 
'";';
+   $data .= '(function e(){var 
e=document.createElement("script");e.type="text/javascript",e.async=true,e.src="//staticw2.yotpo.com/'
 . $wgYotpoAppKey . '/widget.js";var 
t=document.getElementsByTagName("script")[0];t.parentNode.insertBefore(e,t)})();';
return true;
}
 
public static function renderReviews( $input, array $args, Parser 
$parser, PPFrame $frame ) {
-   global $wgLogo, $wgServer, $wgYotpoAppKey;
+   global $wgTitle, $wgLogo, $wgServer, $wgYotpoAppKey;
 
$width = '100%'; //Default
if ( array_key_exists( 'width', $args ) ) {
@@ -41,18 +40,17 @@
$margin = '0 auto 0 auto';
}
 
-   $title = $parser->getTitle();
+   $float = 'none'; //Default
+   if ( array_key_exists( 'float', $args ) ) {
+   $float = $args['float'];
+   }
 
-   $data_app_key = $wgYotpoAppKey;
-   $data_domain = $wgServer;
-   $data_product_id = $title->getDBKey();
-   $data_product_models = '';
-   $data_name = $title->getText();
-   $data_url = $title->getFullURL();
+   $data_product_id = $wgTitle->getDBKey();
+   $data_name = $wgTitle->getText();
+   $data_url = $wgTitle->getFullURL();
$data_image_url = '';
$data_description = '';
-   $data_bread_crumbs = '';
 
-   return '';
+   return '';
}
 }
\ No newline at end of file
diff --git a/YotpoReviews.php b/YotpoReviews.php
index 07934e5..c5a0abe 100644
--- a/YotpoReviews.php
+++ b/YotpoReviews.php
@@ -3,15 +3,14 @@
 $wgExtensionCredits['parserhook'][] = array(
'path'   => __FILE__,
'name'   => 'YotpoReviews',
-   'descriptionmsg' => 'yotporeviews-desc',
-   'version'=> '0.2.0',
+   'descriptionmsg' => 'yotpo-reviews-desc',
+   'version'=> 0.2,
'author' => 'Luis Felipe Schenone',
-   'url'=> 
'https://www.mediawiki.org/wiki/Extension:YotpoReviews'
+   'url'=> 
'http://www.mediawiki.org/wiki/Extension:YotpoReviews'
 );
 
-$wgMessagesDirs['YotpoReviews'] = __DIR__ . '/i18n';
 $wgExtensionMessagesFiles['YotpoReviews'] = __DIR__ . '/YotpoReviews.i18n.php';
 $wgAutoloadClasses['YotpoReviews'] = __DIR__ . '/YotpoReviews.body.php';
 
 $wgHooks['ParserFirstCallInit'][] = 'YotpoReviews::setParserHook';
-$wgHooks['SkinAfterContent'][] = 'YotpoReviews::addYotpoScript';
+$wgHooks['SkinAfterContent'][] = 'YotpoReviews::addYotpoScript';
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/141101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56c337b68929091d679947b89faafb8593d65f75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/YotpoReviews
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Making the Moder skin more self-contained - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/131997

Change subject: Making the Moder skin more self-contained
..

Making the Moder skin more self-contained

Most or all the following changes are guided by the conventions described in 
Manual:Skinning/Tutorial
* Moved skins/Modern.php to skins/modern/Modern.php
* Moved the Modern module declarations from Resources.php to Modern.php
* Moved the Modern classes autoloading from AutoLoader.php to Modern.php
* Moved the Modern classes from Modern.php to Modern.skin.php
* Moved the requiring of Modern.php to Setup.php - This becomes the only 
mention to the Modern skin in core

See bug 60453, bug 57801 and bug 43658
Also see a similar patch set for the MonoBook skin at 
https://gerrit.wikimedia.org/r/#/c/65319/7

Change-Id: I65898997e245144dc7ed36a9520850ea5a315824
---
M includes/AutoLoader.php
M includes/Setup.php
M resources/Resources.php
D skins/Modern.php
A skins/modern/Modern.php
5 files changed, 42 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/131997/1

diff --git a/includes/AutoLoader.php b/includes/AutoLoader.php
index bfee420..92900e4 100644
--- a/includes/AutoLoader.php
+++ b/includes/AutoLoader.php
@@ -1183,10 +1183,8 @@
 
# skins
'CologneBlueTemplate' => 'skins/CologneBlue.php',
-   'ModernTemplate' => 'skins/Modern.php',
'MonoBookTemplate' => 'skins/MonoBook.php',
'SkinCologneBlue' => 'skins/CologneBlue.php',
-   'SkinModern' => 'skins/Modern.php',
'SkinMonoBook' => 'skins/MonoBook.php',
'SkinVector' => 'skins/Vector.php',
'VectorTemplate' => 'skins/Vector.php',
diff --git a/includes/Setup.php b/includes/Setup.php
index b155f90..5bd1c20 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -417,6 +417,7 @@
 require_once "$IP/includes/normal/UtfNormalUtil.php";
 require_once "$IP/includes/GlobalFunctions.php";
 require_once "$IP/includes/normal/UtfNormalDefines.php";
+require_once "$IP/skins/modern/Modern.php";
 wfProfileOut( $fname . '-includes' );
 
 wfProfileIn( $fname . '-defaults2' );
diff --git a/resources/Resources.php b/resources/Resources.php
index 6057b39..93a1d9d 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -152,14 +152,6 @@
'remoteBasePath' => $GLOBALS['wgStylePath'],
'localBasePath' => $GLOBALS['wgStyleDirectory'],
),
-   'skins.modern' => array(
-   'styles' => array(
-   'modern/main.css' => array( 'media' => 'screen' ),
-   'modern/print.css' => array( 'media' => 'print' ),
-   ),
-   'remoteBasePath' => $GLOBALS['wgStylePath'],
-   'localBasePath' => $GLOBALS['wgStyleDirectory'],
-   ),
'skins.vector.styles' => array(
// Used in the web installer. Test it after modifying this 
definition!
'styles' => array(
diff --git a/skins/Modern.php b/skins/Modern.php
deleted file mode 100644
index d1d11c3..000
--- a/skins/Modern.php
+++ /dev/null
@@ -1,207 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @todo document
- * @file
- * @ingroup Skins
- */
-
-if ( !defined( 'MEDIAWIKI' ) ) {
-   die( -1 );
-}
-
-/**
- * Inherit main code from SkinTemplate, set the CSS and template filter.
- * @todo document
- * @ingroup Skins
- */
-class SkinModern extends SkinTemplate {
-   public $skinname = 'modern';
-   public $stylename = 'modern';
-   public $template = 'ModernTemplate';
-   public $useHeadElement = true;
-
-   /**
-* @param OutputPage $out
-*/
-   function setupSkinUserCss( OutputPage $out ) {
-   parent::setupSkinUserCss( $out );
-   $out->addModuleStyles( 'skins.modern' );
-   }
-}
-
-/**
- * @todo document
- * @ingroup Skins
- */
-class ModernTemplate extends MonoBookTemplate {
-
-   /**
-* Template filter callback for Modern skin.
-* Takes an associative array of data set from a SkinTemplate-based
-* class, and a wrapper for MediaWiki's localization database, and
-* outputs a formatted page.
-*
-* @access private
-*/
-   function execute() {
-   // Suppress warnings to prevent notices about missing indexes 
in $this->data
-   wfSuppressWarnings();
-
-   $this->html( 'headelement' );
-   ?>
-
-   
-   html( 'title' ) 
?>
-
-   
-   
-   
-   cactions(); ?>
-
-   
-   
-   
-   
-   
-  

[MediaWiki-commits] [Gerrit] Added the message for the Comment restriction type - change (mediawiki...Comments)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/129928

Change subject: Added the message for the Comment restriction type
..

Added the message for the Comment restriction type

Change-Id: I6756b83ddcef7b4feecdaa902d9a857ccabdb487
---
M i18n/en.json
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Comments 
refs/changes/28/129928/1

diff --git a/i18n/en.json b/i18n/en.json
index 85f2c53..5b0ba18 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -58,5 +58,6 @@
 "grouppage-commentadmin": "{{ns:project}}:Comment administrators",
 "right-comment": "Submit comments",
 "right-commentadmin": "Administrate user-submitted comments",
-"right-commentlinks": "Use external links in comments"
+"right-commentlinks": "Use external links in comments",
+"restriction-comment": "Comment"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/129928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6756b83ddcef7b4feecdaa902d9a857ccabdb487
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Comments
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed {{PLURAL...}} and other minor i18n things - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixed {{PLURAL...}} and other minor i18n things
..


Fixed {{PLURAL...}} and other minor i18n things

Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
---
M NukeDPL.i18n.php
M SpecialNukeDPL.php
2 files changed, 11 insertions(+), 8 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 62a5361..3ed123b 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -17,12 +17,12 @@
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
-   'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
+   'nukedpl-nopages' => "No pages to delete using DPL query: 
$1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL-query: $1
+   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL query: $2
 
-Hit "{{int:nukedpl-nuke}}" to delete them.',
-   'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+Hit "{{int:nukedpl-nuke}}" to delete {{PLURAL:$1|it|them}}.',
+   'nukedpl-defaultreason' => "Mass removal of pages selected by DPL 
query: $1",
'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
 );
 
@@ -51,6 +51,8 @@
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
'nukedpl-nuke' => 'Löschen!',
-   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
-   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$2
+
+Button drücken, um diese zu löschen.",
+   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: $1",
 );
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
index 292e3fb..900c96e 100644
--- a/SpecialNukeDPL.php
+++ b/SpecialNukeDPL.php
@@ -49,12 +49,13 @@
$output = $this->getOutput();
 
$pages = $this->getPages( $query );
-   if ( count( $pages ) == 0 ) {
+   $count = count( $pages );
+   if ( $count == 0 ) {
$output->addWikiText( $this->msg( 'nukedpl-nopages', 
$query )->text() );
return $this->queryForm();
}
 
-   $output->addWikiText( $this->msg( 'nukedpl-list', $query 
)->text() );
+   $output->addWikiText( $this->msg( 'nukedpl-list', $count, 
$query )->text() );
 
$output->addHTML( Xml::element( 'form', array( 'action' => 
$title->getLocalURL( 'action=delete' ), 'method' => 'post' ), null ) );
$output->addHTML( Xml::element( 'input', array( 'type' => 
'submit', 'value' => $this->msg( 'nukedpl-nuke' )->text() ) ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/121958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed {{PLURAL...}} and other minor i18n things - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121958

Change subject: Fixed {{PLURAL...}} and other minor i18n things
..

Fixed {{PLURAL...}} and other minor i18n things

Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
---
M NukeDPL.i18n.php
M SpecialNukeDPL.php
2 files changed, 15 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/58/121958/1

diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 62a5361..d1d3eb4 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -17,12 +17,12 @@
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
-   'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
+   'nukedpl-nopages' => "No pages to delete using DPL query: 
$1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL-query: $1
+   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL query: $2
 
-Hit "{{int:nukedpl-nuke}}" to delete them.',
-   'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+Hit "{{int:nukedpl-nuke}}" to delete {{PLURAL:$1|it|them}}.',
+   'nukedpl-defaultreason' => "Mass removal of pages selected by DPL 
query: $1",
'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
 );
 
@@ -40,17 +40,19 @@
 
 $messages['de'] = array(
'nukedpl' => 'Massenlöschung mittels DPL query',
-   'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL-Query ermöglicht',
-   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+   'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL query ermöglicht',
+   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL query ausgewählt wurden.
 
-Geben Sie unten eine DPL-Query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
+Geben Sie unten eine DPL query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
 * Seiten können aus der Liste der zu löschenden Seiten vor dem Löschen noch 
individuell entfernt werden
 * Seitentitel sind case-sensitive!
 * Queries werden nicht durch DPL Tags oder Klammern umschlossen!
 * Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
-   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
+   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL query: 
$1",
'nukedpl-nuke' => 'Löschen!',
-   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
-   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL query: 
$2
+
+Button drücken, um diese zu löschen.",
+   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels DPL 
query: $1",
 );
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
index 292e3fb..900c96e 100644
--- a/SpecialNukeDPL.php
+++ b/SpecialNukeDPL.php
@@ -49,12 +49,13 @@
$output = $this->getOutput();
 
$pages = $this->getPages( $query );
-   if ( count( $pages ) == 0 ) {
+   $count = count( $pages );
+   if ( $count == 0 ) {
$output->addWikiText( $this->msg( 'nukedpl-nopages', 
$query )->text() );
return $this->queryForm();
}
 
-   $output->addWikiText( $this->msg( 'nukedpl-list', $query 
)->text() );
+   $output->addWikiText( $this->msg( 'nukedpl-list', $count, 
$query )->text() );
 
$output->addHTML( Xml::element( 'form', array( 'action' => 
$title->getLocalURL( 'action=delete' ), 'method' => 'post' ), null ) );
$output->addHTML( Xml::element( 'input', array( 'type' => 
'submit', 'value' => $this->msg( 'nukedpl-nuke' )->text() ) ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/121958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikime

[MediaWiki-commits] [Gerrit] Added {{PLURAL...}} and changed s for s - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121955

Change subject: Added {{PLURAL...}} and changed s for s
..

Added {{PLURAL...}} and changed s for s

Change-Id: I8bbca7f62d708368fa2dbb87d8d00b7dcf796836
---
M NukeDPL.i18n.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/55/121955/1

diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 61746b7..62a5361 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -19,9 +19,9 @@
'nukedpl-candidatelist' => 'View candidate list',
'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => 'The following pages were selected by DPL-query: 
$1
-   
-Hit "{{int:nukedpl-nuke}}" to delete them.', // FIXME: Add PLURAL for 
'...pages were...' 
+   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL-query: $1
+
+Hit "{{int:nukedpl-nuke}}" to delete them.',
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
 );
@@ -49,8 +49,8 @@
 * Queries werden nicht durch DPL Tags oder Klammern umschlossen!
 * Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
-   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
+   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
'nukedpl-nuke' => 'Löschen!',
-   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
 );

-- 
To view, visit https://gerrit.wikimedia.org/r/121955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bbca7f62d708368fa2dbb87d8d00b7dcf796836
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Added {{PLURAL...}} and changed s for s - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Added {{PLURAL...}} and changed s for s
..


Added {{PLURAL...}} and changed s for s

Change-Id: I8bbca7f62d708368fa2dbb87d8d00b7dcf796836
---
M NukeDPL.i18n.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 61746b7..62a5361 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -19,9 +19,9 @@
'nukedpl-candidatelist' => 'View candidate list',
'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => 'The following pages were selected by DPL-query: 
$1
-   
-Hit "{{int:nukedpl-nuke}}" to delete them.', // FIXME: Add PLURAL for 
'...pages were...' 
+   'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL-query: $1
+
+Hit "{{int:nukedpl-nuke}}" to delete them.',
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
 );
@@ -49,8 +49,8 @@
 * Queries werden nicht durch DPL Tags oder Klammern umschlossen!
 * Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
-   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
+   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
'nukedpl-nuke' => 'Löschen!',
-   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
 );

-- 
To view, visit https://gerrit.wikimedia.org/r/121955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bbca7f62d708368fa2dbb87d8d00b7dcf796836
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Revert "Some more consistency tweaks" - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121954

Change subject: Revert "Some more consistency tweaks"
..

Revert "Some more consistency tweaks"

This reverts commit 07488ff1560c9919596841decaacb28c1fa6c83e.

Change-Id: Ibbec96e26b534160393d862da00c8dd25c079020
---
M NukeDPL.i18n.php
1 file changed, 16 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/54/121954/1

diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 61746b7..29521d5 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -1,14 +1,11 @@
  'Nuke pages by Dynamic Page List queries',
'nukedpl' => 'Mass delete by DPL query',
-   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|special page]] for mass 
deletion by DPL query',
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query',
'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
 
 Enter a query below to generate a list of titles to delete.
@@ -17,25 +14,10 @@
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
-   'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
+   'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => 'The following pages were selected by DPL-query: 
$1
-   
-Hit "{{int:nukedpl-nuke}}" to delete them.', // FIXME: Add PLURAL for 
'...pages were...' 
+   'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
-   'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
-);
-
-$messages['qqq'] = array(
-   'right-nukedpl' => '{{doc-right|nukedpl}}',
-   'nukedpl' => '{{doc-special|NukeDPL}}',
-   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=https://www.mediawiki.org/wiki/Extension:NukeDPL}}',
-   'nukedpl-intro' => 'Text explaining how to use the special page',
-   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
-   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
-   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
-   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
-   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
 );
 
 $messages['de'] = array(
@@ -54,3 +36,15 @@
'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
 );
+
+$messages['qqq'] = array(
+   'right-nukedpl' => '{{doc-right|nukedpl}}',
+   'nukedpl' => '{{doc-special|NukeDPL}}',
+   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=https://www.mediawiki.org/wiki/Extension:NukeDPL}}',
+   'nukedpl-intro' => 'Text explaining how to use the special page',
+   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
+   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
+   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
+   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
+   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
+);

-- 
To view, visit https://gerrit.wikimedia.org/r/121954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbec96e26b534160393d862da00c8dd25c079020
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add special page alias file - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Add special page alias file
..


Add special page alias file

Change-Id: I66eff4ffbb8c917793d353b9d322cf0b61da4929
---
A NukeDPL.alias.php
M NukeDPL.php
2 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.alias.php b/NukeDPL.alias.php
new file mode 100644
index 000..480ba2f
--- /dev/null
+++ b/NukeDPL.alias.php
@@ -0,0 +1,14 @@
+ array( 'NukeDPL', 'Nuke DPL' ),
+);
diff --git a/NukeDPL.php b/NukeDPL.php
index bf1f8d0..7327e55 100644
--- a/NukeDPL.php
+++ b/NukeDPL.php
@@ -1,6 +1,7 @@
  __FILE__,
'name' => 'NukeDPL',
'author' => array( '[[User:Nad|Nad]]', '[[User:Luis Felipe 
Schenone|LFS]]' ),
'version' => 1.3,
@@ -17,6 +18,7 @@
 $wgSpecialPageGroups['NukeDPL'] = 'pagetools';
 
 $wgExtensionMessagesFiles['NukeDPL'] = __DIR__ . '/NukeDPL.i18n.php';
+$wgExtensionMessagesFiles['NukeDPLAliases'] = __DIR__ . '/NukeDPL.alias.php';
 
 $wgAutoloadClasses['SpecialNukeDPL'] = __DIR__ . '/SpecialNukeDPL.php';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/121947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66eff4ffbb8c917793d353b9d322cf0b61da4929
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Some more consistency tweaks - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Some more consistency tweaks
..


Some more consistency tweaks

* use  instead of the depreceated 
* Sorint: 1. en, 2nd. qqq, 3. translations
* Use {{int:...}} syntax for the button text
* Add a FIXME for PLURAL usage

Change-Id: Ic57dbf88d064b9bbf48f76d08e8040942c271ccb
---
M NukeDPL.i18n.php
1 file changed, 22 insertions(+), 16 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 29521d5..61746b7 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -1,11 +1,14 @@
  'Nuke pages by Dynamic Page List queries',
'nukedpl' => 'Mass delete by DPL query',
-   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query',
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|special page]] for mass 
deletion by DPL query',
'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
 
 Enter a query below to generate a list of titles to delete.
@@ -14,10 +17,25 @@
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
-   'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
+   'nukedpl-nopages' => "No pages to delete using DPL-query: 
$1",
'nukedpl-nuke' => 'Nuke!',
-   'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
+   'nukedpl-list' => 'The following pages were selected by DPL-query: 
$1
+   
+Hit "{{int:nukedpl-nuke}}" to delete them.', // FIXME: Add PLURAL for 
'...pages were...' 
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+   'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
+);
+
+$messages['qqq'] = array(
+   'right-nukedpl' => '{{doc-right|nukedpl}}',
+   'nukedpl' => '{{doc-special|NukeDPL}}',
+   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=https://www.mediawiki.org/wiki/Extension:NukeDPL}}',
+   'nukedpl-intro' => 'Text explaining how to use the special page',
+   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
+   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
+   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
+   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
+   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
 );
 
 $messages['de'] = array(
@@ -35,16 +53,4 @@
'nukedpl-nuke' => 'Löschen!',
'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
-);
-
-$messages['qqq'] = array(
-   'right-nukedpl' => '{{doc-right|nukedpl}}',
-   'nukedpl' => '{{doc-special|NukeDPL}}',
-   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=https://www.mediawiki.org/wiki/Extension:NukeDPL}}',
-   'nukedpl-intro' => 'Text explaining how to use the special page',
-   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
-   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
-   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
-   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
-   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
 );

-- 
To view, visit https://gerrit.wikimedia.org/r/121941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic57dbf88d064b9bbf48f76d08e8040942c271ccb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Luis Felipe Schenone 
Gerrit-Reviewer: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Various changes based on comments to my initial commit - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Various changes based on comments to my initial commit
..


Various changes based on comments to my initial commit

* Fixed various i18n messages
* Added the qqq pseudolanguage
* Replaced wfMessage for $this->msg
* Updated right 'nukeDPL' to 'nukedpl', per convention for the rights

Change-Id: Ia2e19d95d4700351deca7b68d50278b01e3c9711
---
M NukeDPL.i18n.php
M NukeDPL.php
M SpecialNukeDPL.php
3 files changed, 34 insertions(+), 19 deletions(-)

Approvals:
  Siebrand: Looks good to me, but someone else must approve
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 5f55769..29521d5 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -3,17 +3,19 @@
 $messages = array();
  
 $messages['en'] = array(
+   'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
'nukedpl' => 'Mass delete by DPL query',
-   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query.',
-   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query',
+   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+
 Enter a query below to generate a list of titles to delete.
 * Titles can be individually removed before deleting.
-* Remember, article titles are case-sensitive.
+* Remember, page titles are case-sensitive.
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
-   'nukedpl-nuke' => "Nuke!",
+   'nukedpl-nuke' => 'Nuke!',
'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
 );
@@ -21,7 +23,8 @@
 $messages['de'] = array(
'nukedpl' => 'Massenlöschung mittels DPL query',
'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL-Query ermöglicht',
-   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+
 Geben Sie unten eine DPL-Query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
 * Seiten können aus der Liste der zu löschenden Seiten vor dem Löschen noch 
individuell entfernt werden
 * Seitentitel sind case-sensitive!
@@ -29,7 +32,19 @@
 * Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
-   'nukedpl-nuke' => "Löschen!",
+   'nukedpl-nuke' => 'Löschen!',
'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
-);
\ No newline at end of file
+);
+
+$messages['qqq'] = array(
+   'right-nukedpl' => '{{doc-right|nukedpl}}',
+   'nukedpl' => '{{doc-special|NukeDPL}}',
+   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=https://www.mediawiki.org/wiki/Extension:NukeDPL}}',
+   'nukedpl-intro' => 'Text explaining how to use the special page',
+   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
+   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
+   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
+   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
+   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
+);
diff --git a/NukeDPL.php b/NukeDPL.php
index 985329a..bf1f8d0 100644
--- a/NukeDPL.php
+++ b/NukeDPL.php
@@ -5,12 +5,12 @@
'author' => array( '[[User:Nad|Nad]]', '[[User:Luis Felipe 
Schenone|LFS]]' ),
'version' => 1.3,
'descriptionmsg' => 'nukedpl-desc',
-   'url' => 'http://www.mediawiki.org/wiki/Extension:NukeDPL',
+   'url' => 'https://www.mediawiki.org/wiki/Extension:NukeDPL',
 );
 
-$wgAvailableRights[] = 'nuke';
+$wgAvailableRights[] = 'nukedpl';
 
-$wgGroupPermissions['sysop']['nuke'] = true;
+$wgGroupPermissions['sysop']['nukedpl'] = true;
 
 $wgSpecialPages['NukeDPL'] = 'SpecialNukeDPL';
 
diff --git a/

[MediaWiki-commits] [Gerrit] Changed for - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121292

Change subject: Changed  for 
..

Changed  for 

For some reason, using  prevents the content of the tag from
inheriting the CSS, which makes stuff like QuestyCaptcha look
unnecessarily ugly.

Change-Id: Ib4f47986fd8dcc86eed10034a54f2608644d6382
---
M includes/templates/Usercreate.php
M includes/templates/Userlogin.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/121292/1

diff --git a/includes/templates/Usercreate.php 
b/includes/templates/Usercreate.php
index d1aef1d..ee34e41 100644
--- a/includes/templates/Usercreate.php
+++ b/includes/templates/Usercreate.php
@@ -55,9 +55,9 @@
msg( $this->data['loggedin'] ? 
'createacct-another-join' : 'createacct-join' ); ?>


-   
+   
html( 'header' ); /* extensions 
such as ConfirmEdit add form HTML here */ ?>
-   
+   

getMsg( 
'userlogin-loggedin' )->params( $this->data['loggedinuser'] )->parse(); ?>


-   
+   
html( 'header' ); /* extensions 
such as ConfirmEdit add form HTML here */ ?>
-   
+   
 
data['message'] ) { ?>


-- 
To view, visit https://gerrit.wikimedia.org/r/121292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4f47986fd8dcc86eed10034a54f2608644d6382
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Changed for - change (mediawiki/core)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121291

Change subject: Changed  for 
..

Changed  for 

For some reason, using  prevents the content of the tag from
inheriting the CSS, which makes stuff like QuestyCaptcha look
unnecessarily ugly.

Change-Id: I4f7f0330df9727f7f9286830129d94364e66f05f
---
M includes/templates/Usercreate.php
M includes/templates/Userlogin.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/121291/1

diff --git a/includes/templates/Usercreate.php 
b/includes/templates/Usercreate.php
index fcd492c..0a25f92 100644
--- a/includes/templates/Usercreate.php
+++ b/includes/templates/Usercreate.php
@@ -55,9 +55,9 @@
msg( $this->data['loggedin'] ? 
'createacct-another-join' : 'createacct-join' ); ?>


-   
+   
html( 'header' ); /* extensions 
such as ConfirmEdit add form HTML here */ ?>
-   
+   
data['message'] ) { ?>

data['messagetype'] 
== 'error' ) { ?>
diff --git a/includes/templates/Userlogin.php b/includes/templates/Userlogin.php
index 9aedd3c..85a2f46 100644
--- a/includes/templates/Userlogin.php
+++ b/includes/templates/Userlogin.php
@@ -40,9 +40,9 @@
getMsg( 
'userlogin-loggedin' )->params( $this->data['loggedinuser'] )->parse(); ?>


-   
+   
html( 'header' ); /* extensions 
such as ConfirmEdit add form HTML here */ ?>
-   
+   
 
data['message'] ) { ?>


-- 
To view, visit https://gerrit.wikimedia.org/r/121291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f7f0330df9727f7f9286830129d94364e66f05f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_22
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improved the QuestyCaptcha syntax for setting questions and ... - change (mediawiki...ConfirmEdit)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121286

Change subject: Improved the QuestyCaptcha syntax for setting questions and 
answers
..

Improved the QuestyCaptcha syntax for setting questions and answers

Simple change to one method, QuestyCaptcha::getCaptcha, that allows to
set questions and answers like so:

$wgCaptchaQuestions = array(
'The capital of England?' => 'London',
'The capital of France?' => 'Paris',
'The capital of Spain?' => 'Madrid',
);

Change-Id: Ife16bfb4c63864f8bc9117dad15136288564e2b0
---
M QuestyCaptcha.class.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ConfirmEdit 
refs/changes/86/121286/1

diff --git a/QuestyCaptcha.class.php b/QuestyCaptcha.class.php
index 3acfa46..a1c51ce 100644
--- a/QuestyCaptcha.class.php
+++ b/QuestyCaptcha.class.php
@@ -30,7 +30,9 @@
 
function getCaptcha() {
global $wgCaptchaQuestions;
-   return $wgCaptchaQuestions[mt_rand( 0, count( 
$wgCaptchaQuestions ) - 1 )]; // pick a question, any question
+   $question = array_rand( $wgCaptchaQuestions, 1 );
+   $answer = $wgCaptchaQuestions[ $question ];
+   return array( 'question' => $question, 'answer' => $answer );
}
 
function getForm() {

-- 
To view, visit https://gerrit.wikimedia.org/r/121286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife16bfb4c63864f8bc9117dad15136288564e2b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Various changes based on comments to my initial commit - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121055

Change subject: Various changes based on comments to my initial commit
..

Various changes based on comments to my initial commit

* Fixed various i18n messages
* Added the qqq pseudolanguage
* Replaced wfMessage for $this->msg
* Updated obsolete right 'nukeDPL' to 'nuke'

Change-Id: Ia2e19d95d4700351deca7b68d50278b01e3c9711
---
M NukeDPL.i18n.php
M SpecialNukeDPL.php
2 files changed, 29 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/55/121055/1

diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 5f55769..f9ee1b6 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -4,16 +4,17 @@
  
 $messages['en'] = array(
'nukedpl' => 'Mass delete by DPL query',
-   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query.',
-   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query',
+   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+
 Enter a query below to generate a list of titles to delete.
 * Titles can be individually removed before deleting.
-* Remember, article titles are case-sensitive.
+* Remember, page titles are case-sensitive.
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'View candidate list',
'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
-   'nukedpl-nuke' => "Nuke!",
+   'nukedpl-nuke' => 'Nuke!',
'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
 );
@@ -21,7 +22,8 @@
 $messages['de'] = array(
'nukedpl' => 'Massenlöschung mittels DPL query',
'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL-Query ermöglicht',
-   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+
 Geben Sie unten eine DPL-Query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
 * Seiten können aus der Liste der zu löschenden Seiten vor dem Löschen noch 
individuell entfernt werden
 * Seitentitel sind case-sensitive!
@@ -29,7 +31,18 @@
 * Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
-   'nukedpl-nuke' => "Löschen!",
+   'nukedpl-nuke' => 'Löschen!',
'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
-);
\ No newline at end of file
+);
+
+$messages['qqq'] = array(
+   'nukedpl' => '{{doc-special|NukeDPL}}',
+   'nukedpl-desc' => 
'{{desc|name=NukeDPL|url=http://www.mediawiki.org/wiki/Extension:NukeDPL}}',
+   'nukedpl-intro' => 'Text explaining how to use the special page',
+   'nukedpl-candidatelist' => 'Text in the button that generates the list 
of pages to be deleted',
+   'nukedpl-nopages' => 'Message when the query returns no pages to be 
deleted',
+   'nukedpl-nuke' => 'Text in the button to delete the selected pages',
+   'nukedpl-list' => 'Text preceding the list of pages to be deleted',
+   'nukedpl-defaultreason' => 'Default reason associated with the deleted 
pages',
+);
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
index 72f5ba1..2783192 100644
--- a/SpecialNukeDPL.php
+++ b/SpecialNukeDPL.php
@@ -3,7 +3,7 @@
 class SpecialNukeDPL extends SpecialPage {
 
function __construct() {
-   parent::__construct( 'NukeDPL', 'nukeDPL' );
+   parent::__construct( 'NukeDPL', 'nuke' );
}
 
function execute( $parser = null ) {
@@ -20,7 +20,7 @@
if ( $request->wasPosted() ) {
$ids = $request->getArray( 'ids' );
$query = $request->getText( 'query' );
-   $reason = $request->getText( 'reason', wfMessage( 
'nukedpl-defaultreason', $query )->inContentLanguage()->text() );
+   $reason = $request->getText( 'reason', $this->msg( 
'nukedpl-defaultreason', $qu

[MediaWiki-commits] [Gerrit] Changed right 'nukeDPL' for 'nuke' - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/120987

Change subject: Changed right 'nukeDPL' for 'nuke'
..

Changed right 'nukeDPL' for 'nuke'

Change-Id: I5161f3bc2212216ed67c5bfbcb69e0047890ce8a
---
M NukeDPL.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/87/120987/1

diff --git a/NukeDPL.php b/NukeDPL.php
index 225efc5..985329a 100644
--- a/NukeDPL.php
+++ b/NukeDPL.php
@@ -8,9 +8,9 @@
'url' => 'http://www.mediawiki.org/wiki/Extension:NukeDPL',
 );
 
-$wgAvailableRights[] = 'nukeDPL';
+$wgAvailableRights[] = 'nuke';
 
-$wgGroupPermissions['sysop']['nukeDPL'] = true;
+$wgGroupPermissions['sysop']['nuke'] = true;
 
 $wgSpecialPages['NukeDPL'] = 'SpecialNukeDPL';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/120987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5161f3bc2212216ed67c5bfbcb69e0047890ce8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Changed right 'nukeDPL' for 'nuke' - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Changed right 'nukeDPL' for 'nuke'
..


Changed right 'nukeDPL' for 'nuke'

Change-Id: I5161f3bc2212216ed67c5bfbcb69e0047890ce8a
---
M NukeDPL.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.php b/NukeDPL.php
index 225efc5..985329a 100644
--- a/NukeDPL.php
+++ b/NukeDPL.php
@@ -8,9 +8,9 @@
'url' => 'http://www.mediawiki.org/wiki/Extension:NukeDPL',
 );
 
-$wgAvailableRights[] = 'nukeDPL';
+$wgAvailableRights[] = 'nuke';
 
-$wgGroupPermissions['sysop']['nukeDPL'] = true;
+$wgGroupPermissions['sysop']['nuke'] = true;
 
 $wgSpecialPages['NukeDPL'] = 'SpecialNukeDPL';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/120987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5161f3bc2212216ed67c5bfbcb69e0047890ce8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone 
Gerrit-Reviewer: Luis Felipe Schenone 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Initial commit - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Initial commit
..


Initial commit

The code for this extensions was available at 
https://www.mediawiki.org/wiki/Extension:NukeDPL/Version_1.2.3

I've updated, organized, cleaned and generally improved the code, and I'm now 
uploading it to Gerrit.

Change-Id: Ic219cd1d930877bc7d7e003921772158e95ec9d3
---
A NukeDPL.i18n.php
A NukeDPL.php
A SpecialNukeDPL.php
3 files changed, 185 insertions(+), 0 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
new file mode 100644
index 000..5f55769
--- /dev/null
+++ b/NukeDPL.i18n.php
@@ -0,0 +1,35 @@
+ 'Mass delete by DPL query',
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query.',
+   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+Enter a query below to generate a list of titles to delete.
+* Titles can be individually removed before deleting.
+* Remember, article titles are case-sensitive.
+* Queries shouldn't be surrounded by any DPL tags or braces.
+* For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
+   'nukedpl-candidatelist' => 'View candidate list',
+   'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
+   'nukedpl-nuke' => "Nuke!",
+   'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
+   'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+);
+
+$messages['de'] = array(
+   'nukedpl' => 'Massenlöschung mittels DPL query',
+   'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL-Query ermöglicht',
+   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+Geben Sie unten eine DPL-Query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
+* Seiten können aus der Liste der zu löschenden Seiten vor dem Löschen noch 
individuell entfernt werden
+* Seitentitel sind case-sensitive!
+* Queries werden nicht durch DPL Tags oder Klammern umschlossen!
+* Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
+   'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
+   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
+   'nukedpl-nuke' => "Löschen!",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
+   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
+);
\ No newline at end of file
diff --git a/NukeDPL.php b/NukeDPL.php
new file mode 100644
index 000..225efc5
--- /dev/null
+++ b/NukeDPL.php
@@ -0,0 +1,55 @@
+ 'NukeDPL',
+   'author' => array( '[[User:Nad|Nad]]', '[[User:Luis Felipe 
Schenone|LFS]]' ),
+   'version' => 1.3,
+   'descriptionmsg' => 'nukedpl-desc',
+   'url' => 'http://www.mediawiki.org/wiki/Extension:NukeDPL',
+);
+
+$wgAvailableRights[] = 'nukeDPL';
+
+$wgGroupPermissions['sysop']['nukeDPL'] = true;
+
+$wgSpecialPages['NukeDPL'] = 'SpecialNukeDPL';
+
+$wgSpecialPageGroups['NukeDPL'] = 'pagetools';
+
+$wgExtensionMessagesFiles['NukeDPL'] = __DIR__ . '/NukeDPL.i18n.php';
+
+$wgAutoloadClasses['SpecialNukeDPL'] = __DIR__ . '/SpecialNukeDPL.php';
+
+$egNukeDPLDefaultText = '
+distinct  = true | false
+ignorecase= true | false
+title = Article
+nottitle  = Article
+titlematch= %fragment%
+nottitlematch = %fragment%
+titleregexp   = ^.+$
+nottitleregexp= ^.+$
+category  = Category1 | Category2
+notcategory   = Category1 | Category2
+categorymatch = %fragment%
+notcategorymatch  = %fragment%
+categoryregexp= ^.+$
+notcategoryregexp = ^.+$
+namespace = Namespace1 | Namespace2
+notnamespace  = Namespace1 | Namespace2
+linksfrom = Foo | Bar
+notlinksfrom  = Foo | Bar
+linksto   = Foo|Bar
+notlinksto= Foo|Bar
+imageused = Foo.jpg
+imagecontainer= Article1 | Article2
+uses  = Template1 | Template2
+notuses   = Template1 | Template2
+redirects = exclude | include | only
+createdby = User
+notcreatedby  = User
+modifiedby= User
+notmodifiedby = User
+lastmodifiedby= User
+notlastmodifiedby = User
+';
\ No newline at end of file
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
new file mode 100644
index 000..72f5ba1
--- /dev/null
+++ b/SpecialNukeDPL.php
@@ -0,0 +1,95 @@
+getUser();
+   if ( !$this->userCanExecute( $user ) ) {
+   $this->displayRestr

[MediaWiki-commits] [Gerrit] Updated, organized, cleaned and improved the code previously... - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/120983

Change subject: Updated, organized, cleaned and improved the code previously 
available only at mediawiki.org
..

Updated, organized, cleaned and improved the code previously available only at 
mediawiki.org

Change-Id: Ic219cd1d930877bc7d7e003921772158e95ec9d3
---
A NukeDPL.i18n.php
A NukeDPL.php
A SpecialNukeDPL.php
3 files changed, 185 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NukeDPL 
refs/changes/83/120983/1

diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
new file mode 100644
index 000..5f55769
--- /dev/null
+++ b/NukeDPL.i18n.php
@@ -0,0 +1,35 @@
+ 'Mass delete by DPL query',
+   'nukedpl-desc' => 'Adds a [[Special:NukeDPL|Special Page]] for mass 
deletion by DPL query.',
+   'nukedpl-intro' => "This tool allows for mass deletions of pages 
selected by a DPL query.
+Enter a query below to generate a list of titles to delete.
+* Titles can be individually removed before deleting.
+* Remember, article titles are case-sensitive.
+* Queries shouldn't be surrounded by any DPL tags or braces.
+* For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
+   'nukedpl-candidatelist' => 'View candidate list',
+   'nukedpl-nopages' => "No pages to delete using DPL-query: $1",
+   'nukedpl-nuke' => "Nuke!",
+   'nukedpl-list' => "The following pages were selected by DPL-query: 
$1 hit the button to delete them.",
+   'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+);
+
+$messages['de'] = array(
+   'nukedpl' => 'Massenlöschung mittels DPL query',
+   'nukedpl-desc' => 'Ergänzt eine [[Spezial:NukeDPL|Spezialseite]], die 
das massenhafte Löschen von Seiten per DPL-Query ermöglicht',
+   'nukedpl-intro' => "Diese Spezialseite erlaubt das Löschen von Seiten, 
die mittels einer DPL-Query ausgewählt wurden.
+Geben Sie unten eine DPL-Query ein, um eine Liste mit den zu löschenden Seiten 
zu generieren.
+* Seiten können aus der Liste der zu löschenden Seiten vor dem Löschen noch 
individuell entfernt werden
+* Seitentitel sind case-sensitive!
+* Queries werden nicht durch DPL Tags oder Klammern umschlossen!
+* Erklärungen zu den Parametern finden Sie auf der Seite 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
+   'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
+   'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
$1",
+   'nukedpl-nuke' => "Löschen!",
+   'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
$1Button drücken, um diese zu löschen.",
+   'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
+);
\ No newline at end of file
diff --git a/NukeDPL.php b/NukeDPL.php
new file mode 100644
index 000..225efc5
--- /dev/null
+++ b/NukeDPL.php
@@ -0,0 +1,55 @@
+ 'NukeDPL',
+   'author' => array( '[[User:Nad|Nad]]', '[[User:Luis Felipe 
Schenone|LFS]]' ),
+   'version' => 1.3,
+   'descriptionmsg' => 'nukedpl-desc',
+   'url' => 'http://www.mediawiki.org/wiki/Extension:NukeDPL',
+);
+
+$wgAvailableRights[] = 'nukeDPL';
+
+$wgGroupPermissions['sysop']['nukeDPL'] = true;
+
+$wgSpecialPages['NukeDPL'] = 'SpecialNukeDPL';
+
+$wgSpecialPageGroups['NukeDPL'] = 'pagetools';
+
+$wgExtensionMessagesFiles['NukeDPL'] = __DIR__ . '/NukeDPL.i18n.php';
+
+$wgAutoloadClasses['SpecialNukeDPL'] = __DIR__ . '/SpecialNukeDPL.php';
+
+$egNukeDPLDefaultText = '
+distinct  = true | false
+ignorecase= true | false
+title = Article
+nottitle  = Article
+titlematch= %fragment%
+nottitlematch = %fragment%
+titleregexp   = ^.+$
+nottitleregexp= ^.+$
+category  = Category1 | Category2
+notcategory   = Category1 | Category2
+categorymatch = %fragment%
+notcategorymatch  = %fragment%
+categoryregexp= ^.+$
+notcategoryregexp = ^.+$
+namespace = Namespace1 | Namespace2
+notnamespace  = Namespace1 | Namespace2
+linksfrom = Foo | Bar
+notlinksfrom  = Foo | Bar
+linksto   = Foo|Bar
+notlinksto= Foo|Bar
+imageused = Foo.jpg
+imagecontainer= Article1 | Article2
+uses  = Template1 | Template2
+notuses   = Template1 | Template2
+redirects = exclude | include | only
+createdby = User
+notcreatedby  = User
+modifiedby= User
+notmodifiedby = User
+lastmodifiedby= User
+notlastmodifiedby = User
+';
\ No newline at end of file
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
new file mode 100644
index 000..72f5ba1
--- /dev/null
+++ b/SpecialNukeDPL.php
@@ -0,0 +1,95 @@
+getUser();
+   if ( !$this->userCanExecute( $user ) ) {
+   $this->displayRes