[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: [WIP]Replacing target Arrays with Objects.
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405410 ) Change subject: [WIP]Replacing target Arrays with Objects. .. [WIP]Replacing target Arrays with Objects. Instead of passing targets as Arrays passing now but target Objects Bug: T178215 Bug: T178431 Change-Id: I680b49a9fda733b9f851f06a0d90e93bf2b03847 --- M MassMessage.hooks.php M extension.json M includes/ApiEditMassMessageList.php M includes/MassMessage.php M includes/MassMessageTargets.php M includes/SpecialCreateMassMessageList.php M includes/SpecialEditMassMessageList.php A includes/Target.php M includes/content/MassMessageListContent.php M includes/content/MassMessageListContentHandler.php 10 files changed, 127 insertions(+), 77 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/10/405410/1 diff --git a/MassMessage.hooks.php b/MassMessage.hooks.php index 15da813..ecebafd 100644 --- a/MassMessage.hooks.php +++ b/MassMessage.hooks.php @@ -40,17 +40,17 @@ $parser->addTrackingCategory( 'massmessage-list-category' ); - $data = MassMessage::processPFData( $page, $site ); - if ( isset( $data['error'] ) ) { + $data =(object) MassMessage::processPFData( $page, $site ); + if ( isset( $data->error ) ) { return $data; } // Use a message so wikis can customize the output if ( $wgAllowGlobalMessaging ) { $msg = wfMessage( 'massmessage-target' ) - ->params( $data['site'], $wgScript, $data['title'] )->plain(); + ->params( $data->site, $wgScript, $data->title )->plain(); } else { - $msg = wfMessage( 'massmessage-target-local' )->params( $data['title'] )->plain(); + $msg = wfMessage( 'massmessage-target-local' )->params( $data->title )->plain(); } return [ $msg, 'noparse' => false ]; @@ -65,16 +65,16 @@ */ public static function storeDataParserFunction( Parser $parser, $page, $site = '' ) { $data = MassMessage::processPFData( $page, $site ); - if ( isset( $data['error'] ) ) { + if ( isset( $data->error ) ) { return ''; // Output doesn't matter } $output = $parser->getOutput(); $current = $output->getExtensionData( 'massmessage-targets' ); if ( !$current ) { - $output->setExtensionData( 'massmessage-targets', [ $data ] ); + $output->setExtensionData( 'massmessage-targets', (array) $data ); } else { $output->setExtensionData( 'massmessage-targets', - array_merge( $current, [ $data ] ) ); + array_merge( $current, (array) $data ) ); } return ''; } diff --git a/extension.json b/extension.json index 6a1b354..e9d0a46 100644 --- a/extension.json +++ b/extension.json @@ -226,7 +226,8 @@ "MediaWiki\\MassMessage\\MassMessageListContentHandler": "includes/content/MassMessageListContentHandler.php", "MediaWiki\\MassMessage\\MassMessageListDiffEngine": "includes/content/MassMessageListDiffEngine.php", "MediaWiki\\MassMessage\\MassMessageTestCase": "tests/phpunit/MassMessageTestCase.php", - "MediaWiki\\MassMessage\\MassMessageApiTestCase": "tests/phpunit/MassMessageApiTestCase.php" + "MediaWiki\\MassMessage\\MassMessageApiTestCase": "tests/phpunit/MassMessageApiTestCase.php", + "MediaWiki\\MassMessage\\Target": "includes/Target.php" }, "manifest_version": 1 } diff --git a/includes/ApiEditMassMessageList.php b/includes/ApiEditMassMessageList.php index 9ffd8e7..ae5c5e7 100644 --- a/includes/ApiEditMassMessageList.php +++ b/includes/ApiEditMassMessageList.php @@ -44,9 +44,9 @@ foreach ( $data['add'] as $page ) { $target = MassMessageListContentHandler::extractTarget( $page ); - if ( isset( $target['errors'] ) ) { + if ( isset( $target->errors ) ) { $item = [ '*' => $page ]; - foreach ( $target['errors'] as $error ) { + foreach ( $target->errors as $error ) { $item[$error] = ''; } $invalidAdd[] = $item; @@ -66,7 +66,7 @@ foreach ( $data['remove'] as $page ) {
[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: [WIP]Replacing target Arrays with Objects.
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405222 ) Change subject: [WIP]Replacing target Arrays with Objects. .. [WIP]Replacing target Arrays with Objects. Instead of passing targets as Arrays passing now but target Objects Bug: T178215 Bug: T178431 Change-Id: I2c7fb5d30fd20bf06393cced73027089f2533b6e --- M extension.json M includes/ApiEditMassMessageList.php M includes/MassMessage.php M includes/MassMessageTargets.php A includes/Target.php M includes/content/MassMessageListContent.php M includes/content/MassMessageListContentHandler.php M tests/phpunit/content/MassMessageContentTest.php 8 files changed, 78 insertions(+), 62 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/22/405222/1 diff --git a/extension.json b/extension.json index 6a1b354..5d0ec41 100644 --- a/extension.json +++ b/extension.json @@ -225,6 +225,7 @@ "MediaWiki\\MassMessage\\MassMessageListContent": "includes/content/MassMessageListContent.php", "MediaWiki\\MassMessage\\MassMessageListContentHandler": "includes/content/MassMessageListContentHandler.php", "MediaWiki\\MassMessage\\MassMessageListDiffEngine": "includes/content/MassMessageListDiffEngine.php", + "MediaWiki\\MassMessage\\Target": "includes/Target.php", "MediaWiki\\MassMessage\\MassMessageTestCase": "tests/phpunit/MassMessageTestCase.php", "MediaWiki\\MassMessage\\MassMessageApiTestCase": "tests/phpunit/MassMessageApiTestCase.php" }, diff --git a/includes/ApiEditMassMessageList.php b/includes/ApiEditMassMessageList.php index 9ffd8e7..f53068e 100644 --- a/includes/ApiEditMassMessageList.php +++ b/includes/ApiEditMassMessageList.php @@ -44,14 +44,14 @@ foreach ( $data['add'] as $page ) { $target = MassMessageListContentHandler::extractTarget( $page ); - if ( isset( $target['errors'] ) ) { + if ( isset( $target->error ) ) { $item = [ '*' => $page ]; - foreach ( $target['errors'] as $error ) { + foreach ( $target->error as $error ) { $item[$error] = ''; } $invalidAdd[] = $item; } else { - $newTargets[] = $target; + $newTargets = $target; } } @@ -66,10 +66,10 @@ foreach ( $data['remove'] as $page ) { $target = MassMessageListContentHandler::extractTarget( $page ); - if ( isset( $target['errors'] ) || !in_array( $target, $newTargets ) ) { + if ( isset( $target->error ) || !in_array( $target, $newTargets ) ) { $invalidRemove[] = $page; } else { - $toRemove[] = $target; + $toRemove = $target; } } diff --git a/includes/MassMessage.php b/includes/MassMessage.php index 8a79902..86c890a 100644 --- a/includes/MassMessage.php +++ b/includes/MassMessage.php @@ -58,20 +58,20 @@ return self::parserError( 'massmessage-parse-badpage', $page ); } - $data = [ 'title' => $page, 'site' => trim( $site ) ]; - if ( $data['site'] === '' ) { - $data['site'] = UrlHelper::getBaseUrl( $wgCanonicalServer ); - $data['wiki'] = wfWikiID(); + $data = new Target(); + if ( $data->site === '' ) { + $data->site = UrlHelper::getBaseUrl( $wgCanonicalServer ); + $data->wiki = wfWikiID(); } else { - $data['wiki'] = DatabaseLookup::getDBName( $data['site'] ); - if ( $data['wiki'] === null ) { + $data->wiki = DatabaseLookup::getDBName( $data->site ); + if ( $data->wiki === null ) { return self::parserError( 'massmessage-parse-badurl', $site ); } - if ( !$wgAllowGlobalMessaging && $data['wiki'] !== wfWikiID() ) { + if ( !$wgAllowGlobalMessaging && $data->wiki !== wfWikiID() ) { return self::parserError( 'massmessage-global-disallowed' ); } } -
[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Breaking down the MassMessage class into three classes
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402143 ) Change subject: Breaking down the MassMessage class into three classes .. Breaking down the MassMessage class into three classes Second task of Outreachy/15 project (see here: T178431). Devided MassMessage class into MassMessage, MassMessageUrl and MassMessageGetDB Bug: T178215 Change-Id: I374decb1108530561851930c0c2d288ae612ff65 --- M extension.json M includes/ApiQueryMMSites.php M includes/MassMessage.php A includes/MassMessageGetDB.php M includes/MassMessageTargets.php A includes/MassMessageUrl.php M includes/SpecialEditMassMessageList.php M includes/content/MassMessageListContent.php M includes/content/MassMessageListContentHandler.php M includes/job/MassMessageJob.php M tests/phpunit/MassMessageTest.php 11 files changed, 128 insertions(+), 103 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/43/402143/1 diff --git a/extension.json b/extension.json index 91c79ec..117aaa0 100644 --- a/extension.json +++ b/extension.json @@ -211,6 +211,8 @@ "MediaWiki\\MassMessage\\ApiQueryMMSites": "includes/ApiQueryMMSites.php", "MediaWiki\\MassMessage\\MassMessage": "includes/MassMessage.php", "MediaWiki\\MassMessage\\MassMessageTargets": "includes/MassMessageTargets.php", + "MediaWiki\\MassMessage\\MassMessageGetDB": "includes/MassMessageGetDB.php", + "MediaWiki\\MassMessage\\MassMessageUrl": "includes/MassMessageUrl.php", "MediaWiki\\MassMessage\\SpecialMassMessage": "includes/SpecialMassMessage.php", "MediaWiki\\MassMessage\\SpecialCreateMassMessageList": "includes/SpecialCreateMassMessageList.php", "MediaWiki\\MassMessage\\SpecialEditMassMessageList": "includes/SpecialEditMassMessageList.php", diff --git a/includes/ApiQueryMMSites.php b/includes/ApiQueryMMSites.php index 050d74b..a48d901 100644 --- a/includes/ApiQueryMMSites.php +++ b/includes/ApiQueryMMSites.php @@ -16,7 +16,7 @@ $params = $this->extractRequestParams(); $term = strtolower( $params['term'] ); - $sites = array_keys( MassMessage::getDatabases() ); + $sites = array_keys( MassMessageGetDB::getDatabases() ); sort( $sites ); $matches = []; foreach ( $sites as $site ) { diff --git a/includes/MassMessage.php b/includes/MassMessage.php index 6bedf19..2e46044 100644 --- a/includes/MassMessage.php +++ b/includes/MassMessage.php @@ -26,25 +26,6 @@ class MassMessage { - /** -* Function to follow redirects -* -* @param Title $title -* @return Title|null null if the page is an interwiki redirect -*/ - public static function followRedirect( Title $title ) { - if ( !$title->isRedirect() ) { - return $title; - } - $wikipage = WikiPage::factory( $title ); - - $target = $wikipage->followRedirect(); - if ( $target instanceof Title ) { - return $target; - } else { - return null; // Interwiki redirect - } - } /** * Sets up the messenger account for our use if it hasn't been already. @@ -67,70 +48,6 @@ return $user; } - /** -* Returns the basic hostname and port using wfParseUrl -* @param string $url -* @return string -*/ - public static function getBaseUrl( $url ) { - static $mapping = []; - - if ( isset( $mapping[$url] ) ) { - return $mapping[$url]; - } - - $parse = wfParseUrl( $url ); - $mapping[$url] = $parse['host']; - if ( isset( $parse['port'] ) ) { - $mapping[$url] .= ':' . $parse['port']; - } - return $mapping[$url]; - } - - /** -* Get a mapping from site domains to database names -* Requires $wgConf to be set up properly -* Tries to read from cache if possible -* @return array -*/ - public static function getDatabases() { - global $wgConf, $wgMemc; - static $mapping = null; - if ( $mapping === null ) { - $key = wfGlobalCacheKey( 'massmessage:urltodb' ); - $data = $wgMemc->get( $key ); - if ( $data === false ) { - $dbs = $wgConf->getLocalDatabases(); - $mapping = []; - foreach ( $dbs as $dbname ) { - $url = WikiMap::getWiki( $dbname )->getCanonicalServer()
[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Putting MassMessage Extension in PHP namespace MediaWiki\Mas...
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399538 ) Change subject: Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage .. Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage Considering the Outreachy/15 project for refactoring MassMessage Extension (see here:T178431), putting the extension in a PHP namespace is one of the todos. Bug:T178215 Change-Id: I370f865f04571dccca52cc1edbc3d00cf003bc51 --- M MassMessage.hooks.php M extension.json M includes/ApiEditMassMessageList.php M includes/ApiMassMessage.php M includes/ApiQueryMMSites.php M includes/MassMessage.php M includes/MassMessageTargets.php M includes/SpecialCreateMassMessageList.php M includes/SpecialEditMassMessageList.php M includes/SpecialMassMessage.php M includes/content/MassMessageListContent.php M includes/content/MassMessageListContentHandler.php M includes/content/MassMessageListDiffEngine.php M includes/job/MassMessageJob.php M includes/job/MassMessageServerSideJob.php M includes/job/MassMessageSubmitJob.php M includes/logging/MassMessageFailureLogFormatter.php M includes/logging/MassMessageSendLogFormatter.php M includes/logging/MassMessageSkipLogFormatter.php M maintenance/sendMessages.php M tests/phpunit/MassMessageApiTestCase.php M tests/phpunit/MassMessageTargetsTest.php M tests/phpunit/MassMessageTest.php M tests/phpunit/MassMessageTestCase.php M tests/phpunit/api/ApiEditMassMessageListTest.php M tests/phpunit/api/ApiMassMessageTest.php M tests/phpunit/api/ApiQueryMMSitesTest.php M tests/phpunit/content/MassMessageContentHandlerTest.php M tests/phpunit/content/MassMessageContentTest.php M tests/phpunit/job/MassMessageJobTest.php M tests/phpunit/job/MassMessageSubmitJobTest.php 31 files changed, 319 insertions(+), 48 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/38/399538/1 diff --git a/MassMessage.hooks.php b/MassMessage.hooks.php index db2a4af..7d97941 100644 --- a/MassMessage.hooks.php +++ b/MassMessage.hooks.php @@ -4,6 +4,17 @@ * Hooks! */ +namespace MediaWiki\MassMessage; + +use MediaWiki\MassMessage\MassMessageListContent; +use MediaWiki\MassMessage\MassMessage; +use ParserOptions; +use ParserOutput; +use SpecialPage; +use OutputPage; +use Parser; +use Skin; + class MassMessageHooks { /** @@ -12,7 +23,7 @@ * @return bool */ public static function onParserFirstCallInit( Parser &$parser ) { - $parser->setFunctionHook( 'target', 'MassMessageHooks::outputParserFunction' ); + $parser->setFunctionHook( 'target', 'MediaWiki\\MassMessage\\MassMessageHooks::outputParserFunction' ); return true; } diff --git a/extension.json b/extension.json index eac1821..abdde15 100644 --- a/extension.json +++ b/extension.json @@ -31,8 +31,8 @@ "MassMessageMagic": "MassMessage.i18n.magic.php" }, "APIModules": { - "massmessage": "ApiMassMessage", - "editmassmessagelist": "ApiEditMassMessageList" + "massmessage": "MediaWiki\\MassMessage\\ApiMassMessage", + "editmassmessagelist": "MediaWiki\\MassMessage\\ApiEditMassMessageList" }, "LogTypes": [ "massmessage" @@ -52,38 +52,38 @@ }, "Hooks": { "ParserFirstCallInit": [ - "MassMessageHooks::onParserFirstCallInit" + "MediaWiki\\MassMessage\\MassMessageHooks::onParserFirstCallInit" ], "SpecialStatsAddExtra": [ - "MassMessageHooks::onSpecialStatsAddExtra" + "MediaWiki\\MassMessage\\MassMessageHooks::onSpecialStatsAddExtra" ], "APIQuerySiteInfoStatisticsInfo": [ - "MassMessageHooks::onAPIQuerySiteInfoStatisticsInfo" + "MediaWiki\\MassMessage\\MassMessageHooks::onAPIQuerySiteInfoStatisticsInfo" ], "RenameUserPreRename": [ - "MassMessageHooks::onRenameUserPreRename" + "MediaWiki\\MassMessage\\MassMessageHooks::onRenameUserPreRename" ], "UserGetReservedNames": [ - "MassMessageHooks::onUserGetReservedNames" + "MediaWiki\\MassMessage\\MassMessageHooks::onUserGetReservedNames" ], "BeforeEchoEventInsert": [ "MassMessageHooks::onBeforeEchoEventInsert" ], "SkinTemplateNavigation": [ - "MassMessageHooks::onSkinTemplateNavigation" + "MediaWiki\\MassMessage\\MassMessageHooks::onSkinTemplateNavigation" ], "BeforePageDisplay": [ - "MassMessageHooks:
[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Mass message log missing filter names
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384949 ) Change subject: Mass message log missing filter names .. Mass message log missing filter names fixed by Correcting a spelling mistake on the keys in en.json and qqq.json files Bug: T169824 Change-Id: I657e0c07a8f9b777daf3176484cef623d47bb60b --- M i18n/en.json M i18n/qqq.json 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/49/384949/1 diff --git a/i18n/en.json b/i18n/en.json index cfa08ca..6ad3369 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -131,9 +131,9 @@ "tag-massmessage-delivery": "MassMessage delivery", "tag-massmessage-delivery-description": "Message delivery using [[:mw:Extension:MassMessage|Extension:MassMessage]]", "log-action-filter-massmessage": "Type of log entry", - "log-action-filter-massmassage-send": "Mass message submission", - "log-action-filter-massmassage-failure": "Mass message delivery failure", - "log-action-filter-massmassage-skipoptout": "Target skip because of opt-out", - "log-action-filter-massmassage-skipnouser": "Target skip because of non-existing target user", - "log-action-filter-massmassage-skipbadns": "Target skip because of forbidden namespace" + "log-action-filter-massmessage-send": "Mass message submission", + "log-action-filter-massmessage-failure": "Mass message delivery failure", + "log-action-filter-massmessage-skipoptout": "Target skip because of opt-out", + "log-action-filter-massmessage-skipnouser": "Target skip because of non-existing target user", + "log-action-filter-massmessage-skipbadns": "Target skip because of forbidden namespace" } diff --git a/i18n/qqq.json b/i18n/qqq.json index 862539d..0f9bef5 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -137,9 +137,9 @@ "tag-massmessage-delivery": "Change tag for MassMessage delivery edits", "tag-massmessage-delivery-description": "Description for MassMessage delivery change tag", "log-action-filter-massmessage": "{{doc-log-action-filter-type|massmessage}}", - "log-action-filter-massmassage-send": "{{doc-log-action-filter-type|massmessage|send}}", - "log-action-filter-massmassage-failure": "{{doc-log-action-filter-type|massmessage|failure}}", - "log-action-filter-massmassage-skipoptout": "{{doc-log-action-filter-type|massmessage|skipoptout}}", - "log-action-filter-massmassage-skipnouser": "{{doc-log-action-filter-type|massmessage|skipnouser}}", - "log-action-filter-massmassage-skipbadns": "{{doc-log-action-filter-type|massmessage|skipbadns}}" + "log-action-filter-massmessage-send": "{{doc-log-action-filter-type|massmessage|send}}", + "log-action-filter-massmessage-failure": "{{doc-log-action-filter-type|massmessage|failure}}", + "log-action-filter-massmessage-skipoptout": "{{doc-log-action-filter-type|massmessage|skipoptout}}", + "log-action-filter-massmessage-skipnouser": "{{doc-log-action-filter-type|massmessage|skipnouser}}", + "log-action-filter-massmessage-skipbadns": "{{doc-log-action-filter-type|massmessage|skipbadns}}" } -- To view, visit https://gerrit.wikimedia.org/r/384949 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I657e0c07a8f9b777daf3176484cef623d47bb60b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MassMessage Gerrit-Branch: master Gerrit-Owner: Noella94 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Invalid argument supplied for foreach all over MassMessageLi...
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384199 ) Change subject: Invalid argument supplied for foreach all over MassMessageListContent .. Invalid argument supplied for foreach all over MassMessageListContent Supplied empty instead of null array to foreach for cases where ->targets is null. Bug: T162734 Change-Id: I81c207eee36654b684ce52ccdb2df744210976e7 --- M includes/content/MassMessageListContent.php 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage refs/changes/99/384199/1 diff --git a/includes/content/MassMessageListContent.php b/includes/content/MassMessageListContent.php index b74f544..f4f6e42 100644 --- a/includes/content/MassMessageListContent.php +++ b/includes/content/MassMessageListContent.php @@ -64,11 +64,14 @@ } /** -* @return array|null +* @return array */ public function getTargets() { $this->decode(); - return $this->targets; + if ( is_array($this->targets) ) + return $this->targets; + else + return $arr = []; // empty array } /** -- To view, visit https://gerrit.wikimedia.org/r/384199 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I81c207eee36654b684ce52ccdb2df744210976e7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MassMessage Gerrit-Branch: master Gerrit-Owner: Noella94 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly ...
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383564 ) Change subject: MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly applied to translatable pages .. MediaWikiMessageChecker::pagenameMessagesCheck, incorrectly applied to translatable pages When trying to translate the name of namespace "Help" via the translation interface the following error is issued and the translation get's fuzzied: "Namespace changed from the definition" Bug: T172382 Change-Id: I9f29eeb25d14db252aef03e34fbd49fc3b016494 --- M messagegroups/WikiPageMessageGroup.php 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/64/383564/1 diff --git a/messagegroups/WikiPageMessageGroup.php b/messagegroups/WikiPageMessageGroup.php index 230cd7c..a4e9ed1 100644 --- a/messagegroups/WikiPageMessageGroup.php +++ b/messagegroups/WikiPageMessageGroup.php @@ -148,7 +148,6 @@ $checker->setChecks( [ [ $checker, 'pluralCheck' ], [ $checker, 'braceBalanceCheck' ], - [ $checker, 'pagenameMessagesCheck' ], [ $checker, 'miscMWChecks' ] ] ); -- To view, visit https://gerrit.wikimedia.org/r/383564 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f29eeb25d14db252aef03e34fbd49fc3b016494 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Noella94 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Please remove Custom License Marker from Commons Upload Wizard
Noella94 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382145 ) Change subject: Please remove Custom License Marker from Commons Upload Wizard .. Please remove Custom License Marker from Commons Upload Wizard Removed Custom License Marker from UW config/code Bug: T177161 Change-Id: Ib2340a73d14c09c7dd64648b6e500841030a0eea --- M UploadWizard.config.php 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/45/382145/1 diff --git a/UploadWizard.config.php b/UploadWizard.config.php index cc9c3f6..d945415 100644 --- a/UploadWizard.config.php +++ b/UploadWizard.config.php @@ -428,11 +428,6 @@ 'msg' => 'mwe-upwiz-license-none', 'templates' => [ 'subst:uwl' ] ], - 'custom' => [ - 'msg' => 'mwe-upwiz-license-custom', - 'templates' => [ 'subst:Custom license marker added by UW' ], - 'url' => wfMessage( 'mwe-upwiz-license-custom-url' )->parse() - ], 'generic' => [ 'msg' => 'mwe-upwiz-license-generic', 'templates' => [ 'Generic' ] -- To view, visit https://gerrit.wikimedia.org/r/382145 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2340a73d14c09c7dd64648b6e500841030a0eea Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Noella94 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits