[MediaWiki-commits] [Gerrit] mediawiki...ParserFunctions[master]: Fix improper working of "round" operator

2018-01-23 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405870 )

Change subject: Fix improper working of "round" operator
..

Fix improper working of "round" operator

Fixed improper behaviour of round operator when integer values
are given for rounding off instead of float values.

Bug: T8529
Change-Id: I57d0034e162646ea09e572bf54f7f04f91d90c78
---
M Expr.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions 
refs/changes/70/405870/1

diff --git a/Expr.php b/Expr.php
index 18a2368..cf93853 100644
--- a/Expr.php
+++ b/Expr.php
@@ -508,7 +508,12 @@
}
$digits = (int)array_pop( $stack );
$value = array_pop( $stack );
-   $stack[] = round( $value, $digits );
+   if( ( is_numeric( $value ) && floor( $value ) 
!= $value || $digits < 0 ) ) {
+   $stack[] = round( $value, $digits );
+   }
+   else {
+   $stack[] = number_format( $value, 
$digits );
+   }
break;
case EXPR_LESS:
if ( count( $stack ) < 2 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/405870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57d0034e162646ea09e572bf54f7f04f91d90c78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserFunctions
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Pdfhandler: Error creating thumbnail for =0

2017-10-02 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381739 )

Change subject: Pdfhandler: Error creating thumbnail for =0
..

Pdfhandler: Error creating thumbnail for =0

Pdfhandler display page 1 for input page=0 and "next page" display
corresponding next to page 1

Bug: T163471
Change-Id: Icd6639190daf67572e8ddcd949a28c2d0e274dc5
---
M includes/page/ImagePage.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/381739/1

diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php
index 0e3eaa5..c0cf603 100644
--- a/includes/page/ImagePage.php
+++ b/includes/page/ImagePage.php
@@ -302,7 +302,7 @@
if ( $this->displayImg->exists() ) {
# image
$page = $request->getIntOrNull( 'page' );
-   if ( is_null( $page ) ) {
+   if ( is_null( $page ) || $page <= 0 ) {
$params = [];
$page = 1;
} else {
@@ -450,7 +450,7 @@
$this->getTitle(),
$label,
[],
-   [ 'page' => $page + 1 ]
+   ($page > 0)?[ 'page' => 
$page + 1 ]:['page' => 2 ]
);
$thumb2 = 
Linker::makeThumbLinkObj(
$this->getTitle(),
@@ -458,7 +458,7 @@
$link,
$label,
'none',
-   [ 'page' => $page + 1 ]
+   ($page > 0)?[ 'page' => 
$page + 1 ]:['page' => 2 ]
);
} else {
$thumb2 = '';

-- 
To view, visit https://gerrit.wikimedia.org/r/381739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd6639190daf67572e8ddcd949a28c2d0e274dc5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Vector: Tabs (Read / View Source / Search) collapse under mo...

2017-09-29 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381470 )

Change subject: Vector: Tabs (Read / View Source / Search) collapse under more 
in resolution < 700px
..

Vector: Tabs (Read / View Source / Search) collapse under more in resolution < 
700px

Tabs collapse also for logged in users for screen resolutions less than 700px

Bug: T56919

Change-Id: I678dbc0d41c5c9847579c1bdfd9b74a210709b27
---
M vector.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/70/381470/1

diff --git a/vector.js b/vector.js
index 9d4c48a..8284168 100644
--- a/vector.js
+++ b/vector.js
@@ -95,10 +95,9 @@
 
// If there's an overlap, collapse.
if ( $.collapsibleTabs.calculateTabDistance() < 
0 ) {
-   // But only if the width of the tab to 
collapse is smaller than the width of the dropdown
// we would have to insert. An example 
language where this happens is Lithuanian (lt).
if ( $cactions.hasClass( 'emptyPortlet' 
) ) {
-   return $tabContainer.children( 
'li.collapsible:last' ).width() > initialCactionsWidth();
+   return true;
} else {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/381470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I678dbc0d41c5c9847579c1bdfd9b74a210709b27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Vector: Page actions in dropdown expand if space allow

2017-09-29 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381409 )

Change subject: Vector: Page actions in dropdown expand if space allow
..

Vector: Page actions in dropdown expand if space allow

Page actions in dropdown expands if space allows and move back
to dropdown on screens with lesser resolutions

Bug: T24986
Change-Id: I3b2a9d0297a3d28309200e50bad6b275e42dd202
---
M VectorTemplate.php
M vector.js
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/09/381409/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 7ed0675..691a886 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -49,6 +49,8 @@
unset( $this->data['action_urls'][$mode] );
}
}
+   $this->data['view_urls'] = 
array_merge($this->data['view_urls'],$this->data['action_urls']);
+   unset($this->data['action_urls']);
$this->data['pageLanguage'] =

$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
 
diff --git a/vector.js b/vector.js
index 9d4c48a..8284168 100644
--- a/vector.js
+++ b/vector.js
@@ -95,10 +95,9 @@
 
// If there's an overlap, collapse.
if ( $.collapsibleTabs.calculateTabDistance() < 
0 ) {
-   // But only if the width of the tab to 
collapse is smaller than the width of the dropdown
// we would have to insert. An example 
language where this happens is Lithuanian (lt).
if ( $cactions.hasClass( 'emptyPortlet' 
) ) {
-   return $tabContainer.children( 
'li.collapsible:last' ).width() > initialCactionsWidth();
+   return true;
} else {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/381409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b2a9d0297a3d28309200e50bad6b275e42dd202
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Page actions in dropdown menu should expands if space allows...

2017-09-24 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/380321 )

Change subject: Page actions in dropdown menu should expands if space allows in 
Vector
..

Page actions in dropdown menu should expands if space allows in Vector

The items in dropdown expands if space allows so that all urls display in
navigation menu

Depending on the resolution the tabs moves under dropdown if there is
insuffieciency of space

Bug: T24986
Change-Id: Ibfd65db17e15afb494614a09d986f708f557092f
---
M VectorTemplate.php
M vector.js
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/21/380321/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index d109031..e29ea7c 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -49,7 +49,8 @@
unset( $this->data['action_urls'][$mode] );
}
}
-
+   $this->data['view_urls'] = 
array_merge($this->data['view_urls'],$this->data['action_urls']);
+   unset($this->data['action_urls']);
// Reverse horizontally rendered navigation elements
if ( $this->data['rtl'] ) {
$this->data['view_urls'] =
diff --git a/vector.js b/vector.js
index 9d4c48a..acfa780 100644
--- a/vector.js
+++ b/vector.js
@@ -98,7 +98,7 @@
// But only if the width of the tab to 
collapse is smaller than the width of the dropdown
// we would have to insert. An example 
language where this happens is Lithuanian (lt).
if ( $cactions.hasClass( 'emptyPortlet' 
) ) {
-   return $tabContainer.children( 
'li.collapsible:last' ).width() > initialCactionsWidth();
+   return $tabContainer.children( 
'li.collapsible:last' ).width() + 20 > initialCactionsWidth();
} else {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/380321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfd65db17e15afb494614a09d986f708f557092f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Vector: Horizontal nav elements should be flipped with CSS i...

2017-09-21 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379577 )

Change subject: Vector: Horizontal nav elements should be flipped with CSS 
instead of in HTML
..

Vector: Horizontal nav elements should be flipped with CSS instead of in HTML

horizontal nav elements in rtl mode
are flipped with css instead of html in skin vector

Bug: T48947
Change-Id: I30a5837f84bcdeab205760644bfa40b12cefbece
---
M VectorTemplate.php
M components/personalMenu.less
M components/tabs.less
3 files changed, 2 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/77/379577/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 408c347..7df553b 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -49,17 +49,6 @@
unset( $this->data['action_urls'][$mode] );
}
}
-
-   // Reverse horizontally rendered navigation elements
-   if ( $this->data['rtl'] ) {
-   $this->data['view_urls'] =
-   array_reverse( $this->data['view_urls'] );
-   $this->data['namespace_urls'] =
-   array_reverse( $this->data['namespace_urls'] );
-   $this->data['personal_urls'] =
-   array_reverse( $this->data['personal_urls'] );
-   }
-
$this->data['pageLanguage'] =

$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
 
@@ -308,7 +297,7 @@
}
 
/**
-* Render one or more navigations elements by name, automatically 
reveresed
+* Render one or more navigations elements by name, automatically 
reveresed by css
 * when UI is in RTL mode
 *
 * @param array $elements
@@ -318,9 +307,6 @@
// flexible arguments
if ( !is_array( $elements ) ) {
$elements = [ $elements ];
-   // If there's a series of elements, reverse them when 
in RTL mode
-   } elseif ( $this->data['rtl'] ) {
-   $elements = array_reverse( $elements );
}
// Render elements
foreach ( $elements as $name => $element ) {
@@ -536,6 +522,7 @@
) {
$item['class'] = rtrim( 'icon ' . $item['class'], ' ' );
$item['primary'] = true;
+   $item['alt'] = "watched";
}
 
// Add CSS class 'collapsible' to links which are not marked as 
"primary"
diff --git a/components/personalMenu.less b/components/personalMenu.less
index 7688e1c..979831f 100644
--- a/components/personalMenu.less
+++ b/components/personalMenu.less
@@ -19,7 +19,6 @@
 
li {
line-height: 1.125em;
-   /* @noflip */
float: left;
margin-left: 0.75em;
margin-top: 0.5em;
diff --git a/components/tabs.less b/components/tabs.less
index 803bab7..645d049 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -9,7 +9,6 @@
 
 /* Namespaces and Views */
 div.vectorTabs {
-   /* @noflip */
float: left;
height: 2.5em;
.background-image('images/tab-break.png');
@@ -18,7 +17,6 @@
padding-left: 1px;
 
ul {
-   /* @noflip */
float: left;
height: 100%;
list-style-type: none;
@@ -30,7 +28,6 @@
background-repeat: no-repeat;
 
li {
-   /* @noflip */
float: left;
line-height: 1.125em;
/* For IE6, overridden later to display:block by modern 
browsers */
@@ -107,7 +104,6 @@
 
/* Ignored by IE6 which doesn't support child selector */
> a {
-   /* @noflip */
float: left;
display: block;
}
@@ -116,9 +112,7 @@
 
 /* Variants and Actions */
 div.vectorMenu {
-   /* @noflip */
direction: ltr;
-   /* @noflip */
float: left;
cursor: pointer;
position: relative;
@@ -126,12 +120,10 @@
 }
 
 body.rtl div.vectorMenu {
-   /* @noflip */
direction: rtl;
 }
 
 div#mw-head div.vectorMenu h3 {
-   /* @noflip */
float: left;
.background-image('images/tab-break.png');
background-repeat: no-repeat;

-- 
To view, visit https://gerrit.wikimedia.org/r/379577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30a5837f84bcdeab205760644bfa40b12cefbece
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner:

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: Switched from GhostScript to MuPDF for thumbnailing PDFs

2017-09-21 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379573 )

Change subject: Switched from GhostScript to MuPDF for thumbnailing PDFs
..

Switched from GhostScript to MuPDF for thumbnailing PDFs

Updated the dependecy used by Pdfhandler from gs to mupdf by which
rendering of pdf to image is done

Bug: T38594
Change-Id: I88fdc5a9d65104f36521eb746e4b713419a9
---
M PdfHandler_body.php
M extension.json
2 files changed, 6 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PdfHandler 
refs/changes/73/379573/1

diff --git a/PdfHandler_body.php b/PdfHandler_body.php
index 0ff5aad..6e0c590 100644
--- a/PdfHandler_body.php
+++ b/PdfHandler_body.php
@@ -187,16 +187,11 @@
 
$cmd = '(' . wfEscapeShellArg(
$wgPdfProcessor,
-   "-sDEVICE=jpeg",
-   "-sOutputFile=-",
-   "-dFirstPage={$page}",
-   "-dLastPage={$page}",
-   "-dSAFER",
-   "-r{$wgPdfHandlerDpi}",
-   "-dBATCH",
-   "-dNOPAUSE",
-   "-q",
-   $srcPath
+   "-F",
+   "png",
+   "-o-",
+   $srcPath,
+   "{page}"
);
$cmd .= " | " . wfEscapeShellArg(
$wgPdfPostProcessor,
diff --git a/extension.json b/extension.json
index 73aa6f6..382731e 100644
--- a/extension.json
+++ b/extension.json
@@ -18,7 +18,7 @@
"PdfPostProcessor": "/usr/bin/convert",
"PdfHandlerJpegQuality": 95,
"PdftoText": "/usr/bin/pdftotext",
-   "PdfProcessor": "/usr/bin/gs",
+   "PdfProcessor": "mudraw",
"PdfInfo": "/usr/bin/pdfinfo"
},
"MessagesDirs": {

-- 
To view, visit https://gerrit.wikimedia.org/r/379573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88fdc5a9d65104f36521eb746e4b713419a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PdfHandler
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Tabs (Read / View Source / Search) collapsed under more in r...

2017-07-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368803 )

Change subject: Tabs (Read / View Source / Search) collapsed under more in 
resolution < 700px
..

Tabs (Read / View Source / Search) collapsed under more in resolution < 700px

tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
---
M VectorTemplate.php
M components/watchstar.less
2 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/03/368803/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 50c4439..71b1e10 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -538,9 +538,7 @@
 
// Add CSS class 'collapsible' to links which are not marked as 
"primary"
if (
-   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible']
-   && !( isset( $item['primary'] ) && $item['primary'] )
-   ) {
+   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible']) {
$item['class'] = rtrim( 'collapsible ' . 
$item['class'], ' ' );
}
 
diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/368803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Tabs (Read / View Source / Search) collapsed under more in r...

2017-07-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368799 )

Change subject: Tabs (Read / View Source / Search) collapsed under more in 
resolution < 700px
..

Tabs (Read / View Source / Search) collapsed under more in resolution < 700px

tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I0bec642cf382aabbc088ce99aa233b9020fc22c1
---
M components/watchstar.less
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/99/368799/1

diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/368799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bec642cf382aabbc088ce99aa233b9020fc22c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Vector: Horizontal nav elements should be flipped with CSS i...

2017-07-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368759 )

Change subject: Vector: Horizontal nav elements should be flipped with CSS 
instead of in HTML
..

Vector: Horizontal nav elements should be flipped with CSS instead of in HTML

horizontal nav elements in rtl mode in vector skin are flipped with
css instead of html

Bug: T48947
Change-Id: Ie955ca5a8fbb521213c1e294e4732d997041d85a
---
M VectorTemplate.php
M components/tabs.less
2 files changed, 4 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/59/368759/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index d3eb051..2d8e58c 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -79,15 +79,7 @@
$this->data['variant_urls'] = $nav['variants'];
 
// Reverse horizontally rendered navigation elements
-   if ( $this->data['rtl'] ) {
-   $this->data['view_urls'] =
-   array_reverse( $this->data['view_urls'] );
-   $this->data['namespace_urls'] =
-   array_reverse( $this->data['namespace_urls'] );
-   $this->data['personal_urls'] =
-   array_reverse( $this->data['personal_urls'] );
-   }
-
+   
$this->data['pageLanguage'] =

$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
 
@@ -345,8 +337,6 @@
if ( !is_array( $elements ) ) {
$elements = [ $elements ];
// If there's a series of elements, reverse them when 
in RTL mode
-   } elseif ( $this->data['rtl'] ) {
-   $elements = array_reverse( $elements );
}
// Render elements
foreach ( $elements as $name => $element ) {
diff --git a/components/tabs.less b/components/tabs.less
index 4cc4625..2288bd3 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -9,7 +9,7 @@
 
 /* Namespaces and Views */
 div.vectorTabs {
-   /* @noflip */
+   
float: left;
height: 2.5em;
.background-image('images/tab-break.png');
@@ -18,7 +18,7 @@
padding-left: 1px;
 
ul {
-   /* @noflip */
+   
float: left;
height: 100%;
list-style-type: none;
@@ -30,7 +30,7 @@
background-repeat: no-repeat;
 
li {
-   /* @noflip */
+   
float: left;
line-height: 1.125em;
/* For IE6, overridden later to display:block by modern 
browsers */

-- 
To view, visit https://gerrit.wikimedia.org/r/368759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie955ca5a8fbb521213c1e294e4732d997041d85a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Canged an if condition so that all collapsible class is appl...

2017-07-21 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366845 )

Change subject: Canged an if condition so that all collapsible class is applied 
to all the variables and also edited a css code to prevent the repeat of the 
image in the dropdown
..

Canged an if condition so that all collapsible class is applied
to all the variables and also edited a css code to prevent the repeat of the
image in the dropdown

Bug: T56919
Change-Id: I1b299f4d667fe63245e09a52e89796134f862124
---
M VectorTemplate.php
M components/watchstar.less
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/45/366845/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index d3eb051..ebd1d9f 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -52,7 +52,7 @@
$xmlID = '';
foreach ( $nav as $section => $links ) {
foreach ( $links as $key => $link ) {
-   if ( $section == 'views' && !( isset( 
$link['primary'] ) && $link['primary'] ) ) {
+   if ( $section == 'views') {
$link['class'] = rtrim( 'collapsible ' 
. $link['class'], ' ' );
}
 
diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/366845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b299f4d667fe63245e09a52e89796134f862124
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...api[master]: Ruby gem documentation should state license

2017-05-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356360 )

Change subject: Ruby gem documentation should state license
..

Ruby gem documentation should state license

Linked the License to the proper url to display the license

Bug:T94001
Change-Id: Ie275d2cbed1cf0711df5d2d01d0149d90d95d4d3
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/ruby/api 
refs/changes/60/356360/1

diff --git a/README.md b/README.md
index 82fe1ef..dbb6bff 100644
--- a/README.md
+++ b/README.md
@@ -138,6 +138,6 @@
 
 - Added MediawikiApi#create_article and #create_user.
 
-## [License](../LICENSE.txt)
+## [License]( 
https://phabricator.wikimedia.org/diffusion/MRUB/browse/master/LICENSE.txt)
 
 © Copyright 2013-2017, Wikimedia Foundation & Contributors. Released under the 
terms of the GNU General Public License, version 2 or later.

-- 
To view, visit https://gerrit.wikimedia.org/r/356360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie275d2cbed1cf0711df5d2d01d0149d90d95d4d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/selenium[master]: Ruby gem documentation should state license

2017-05-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356359 )

Change subject: Ruby gem documentation should state license
..

Ruby gem documentation should state license

Linked the License to the proper url to display the license

Bug:T94001
Change-Id: Ie275d2cbed1cf0711df5d2d01d0149d90d95d4d3
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/59/356359/1

diff --git a/README.md b/README.md
index 42cfcfb..c985c25 100644
--- a/README.md
+++ b/README.md
@@ -306,7 +306,7 @@
 
 See {file:RELEASES.md}.
 
-## [License](../LICENSE)
+## 
[License](https://phabricator.wikimedia.org/diffusion/MSEL/browse/master/LICENSE)
 
 © Copyright 2013-2017, Wikimedia Foundation & Contributors. Released under the 
terms of the GNU General Public License, version 2 or later.
 

-- 
To view, visit https://gerrit.wikimedia.org/r/356359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie275d2cbed1cf0711df5d2d01d0149d90d95d4d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: audit/update headers in files

2017-05-05 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352122 )

Change subject: audit/update headers in files
..

audit/update headers in files

Removed the license to the few of the files and updated the
license header of the files in the Wikibase directory to the License
headers of the other files in the extension

Bug: T69141
Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
---
M tests/browser/features/step_definitions/pdf_steps.rb
M tests/browser/features/support/pages/random_page.rb
2 files changed, 0 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PdfHandler 
refs/changes/22/352122/1

diff --git a/tests/browser/features/step_definitions/pdf_steps.rb 
b/tests/browser/features/step_definitions/pdf_steps.rb
index 25cf8ef..ce793b3 100644
--- a/tests/browser/features/step_definitions/pdf_steps.rb
+++ b/tests/browser/features/step_definitions/pdf_steps.rb
@@ -1,14 +1,3 @@
-#
-# This file is subject to the license terms in the LICENSE file found in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
-# qa-browsertests, including this file, may be copied, modified, propagated, or
-# distributed except according to the terms contained in the LICENSE file.
-#
-# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
-#
 Then(/^Download as PDF should be present$/) do
   on(PdfPage).download_as_pdf_element.should exist
 end
diff --git a/tests/browser/features/support/pages/random_page.rb 
b/tests/browser/features/support/pages/random_page.rb
index 8dc4e90..ceaff4c 100644
--- a/tests/browser/features/support/pages/random_page.rb
+++ b/tests/browser/features/support/pages/random_page.rb
@@ -1,14 +1,3 @@
-#
-# This file is subject to the license terms in the LICENSE file found in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
-# qa-browsertests, including this file, may be copied, modified, propagated, or
-# distributed except according to the terms contained in the LICENSE file.
-#
-# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
-#
 class PdfPage
   include PageObject
 

-- 
To view, visit https://gerrit.wikimedia.org/r/352122
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PdfHandler
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: audit/update headers in files

2017-05-05 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352121 )

Change subject: audit/update headers in files
..

audit/update headers in files

Removed the license to the few of the files and updated the license
header of the files in the Wikibase directory to the License headers
of the other files in the extension

Bug: T69141
Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
---
M tests/browser/features/support/env.rb
M tests/browser/features/support/modules/url_module.rb
2 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/21/352121/1

diff --git a/tests/browser/features/support/env.rb 
b/tests/browser/features/support/env.rb
index 3b42df2..1e2808d 100644
--- a/tests/browser/features/support/env.rb
+++ b/tests/browser/features/support/env.rb
@@ -4,11 +4,8 @@
 # Author:: Tobias Gritschacher (tobias.gritschac...@wikimedia.de)
 # License:: GNU GPL v2+
 #
-# Reused and modified from 
https://github.com/wikimedia/qa-browsertests/blob/master/features/support/env.rb
-#
 # setup & bootstrapping
 
-# before all
 require 'mediawiki_selenium/cucumber'
 require 'mediawiki_selenium/pages'
 require 'mediawiki_selenium/step_definitions'
diff --git a/tests/browser/features/support/modules/url_module.rb 
b/tests/browser/features/support/modules/url_module.rb
index bc0f379..160b35c 100644
--- a/tests/browser/features/support/modules/url_module.rb
+++ b/tests/browser/features/support/modules/url_module.rb
@@ -4,10 +4,7 @@
 # Author:: Tobias Gritschacher (tobias.gritschac...@wikimedia.de)
 # License:: GNU GPL v2+
 #
-# Reused and modified from 
https://github.com/wikimedia/qa-browsertests/blob/master/features/support/modules/url_module.rb
-#
 # module for URLs
-
 module URL
   def self.client_url(name)
 url = ENV['WIKIDATA_CLIENT_URL']

-- 
To view, visit https://gerrit.wikimedia.org/r/352121
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: audit/update headers in files

2017-05-05 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352120 )

Change subject: audit/update headers in files
..

audit/update headers in files

Removed the license to the few of the files and updated the license
header of the files in the Wikibase directory to the License headers
of the other files in the extension

Bug: T69141
Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
---
M tests/browser/features/page_triage.feature
M tests/browser/features/step_definitions/page_triage_steps.rb
M tests/browser/features/support/pages/page_triage_page.rb
3 files changed, 0 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/20/352120/1

diff --git a/tests/browser/features/page_triage.feature 
b/tests/browser/features/page_triage.feature
index 855a094..da7d2dd 100644
--- a/tests/browser/features/page_triage.feature
+++ b/tests/browser/features/page_triage.feature
@@ -1,14 +1,3 @@
-#
-# This file is subject to the license terms in the LICENSE file found in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
-# qa-browsertests, including this file, may be copied, modified, propagated, or
-# distributed except according to the terms contained in the LICENSE file.
-#
-# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
-#
 @chrome @en.wikipedia.beta.wmflabs.org @firefox @internet_explorer_8 
@internet_explorer_9 @internet_explorer_10 @phantomjs @test2.wikipedia.org
 Feature: PageTriage
 
diff --git a/tests/browser/features/step_definitions/page_triage_steps.rb 
b/tests/browser/features/step_definitions/page_triage_steps.rb
index 3681b7d..a76ac15 100644
--- a/tests/browser/features/step_definitions/page_triage_steps.rb
+++ b/tests/browser/features/step_definitions/page_triage_steps.rb
@@ -1,14 +1,3 @@
-#
-# This file is subject to the license terms in the LICENSE file found in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
-# qa-browsertests, including this file, may be copied, modified, propagated, or
-# distributed except according to the terms contained in the LICENSE file.
-#
-# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
-#
 Given(/^I am at the NewPagesFeed page$/) do
   visit PageTriagePage
 end
diff --git a/tests/browser/features/support/pages/page_triage_page.rb 
b/tests/browser/features/support/pages/page_triage_page.rb
index e3d3927..607de8f 100644
--- a/tests/browser/features/support/pages/page_triage_page.rb
+++ b/tests/browser/features/support/pages/page_triage_page.rb
@@ -1,14 +1,3 @@
-#
-# This file is subject to the license terms in the LICENSE file found in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
-# qa-browsertests, including this file, may be copied, modified, propagated, or
-# distributed except according to the terms contained in the LICENSE file.
-#
-# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
-# qa-browsertests top-level directory and at
-# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
-#
 class PageTriagePage
   include PageObject
 

-- 
To view, visit https://gerrit.wikimedia.org/r/352120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8352f976c870e347aa6be69752c84310b7d9db61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: h3 should not be more prominent than h2 headings.

2017-04-21 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349438 )

Change subject: h3 should not be more prominent than h2 headings.
..

h3 should not be more prominent than h2 headings.

Bug:T65844
Change-Id: Idded1f616b7c2a71f35bb4e824800e85df3a4490
---
M variables.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/38/349438/1

diff --git a/variables.less b/variables.less
index 98f9766..f185566 100755
--- a/variables.less
+++ b/variables.less
@@ -10,7 +10,7 @@
 @content-line-height: 1.6;
 @content-padding: 1em;
 @content-heading-font-size: 1.8em;
-@content-heading-font-family: 'Linux Libertine', 'Georgia', 'Times', serif;
+@content-heading-font-family: 'Linux Libertine', 'sans-serif', 'Times', ;
 @content-heading-font-family-generic: sans-serif;
 @body-background-color: #fff;
 @heading-line-height: 1.3;

-- 
To view, visit https://gerrit.wikimedia.org/r/349438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idded1f616b7c2a71f35bb4e824800e85df3a4490
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/selenium[master]: mediawiki_selenium should document SauceLabs usage

2017-04-19 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348935 )

Change subject: mediawiki_selenium should document SauceLabs usage
..

mediawiki_selenium should document SauceLabs usage

Provided link for the documentation of sauce labs in the documentation of
mediawiki_selenium and written an introduction paragraph of it

Bug:T98331
Change-Id: I8aad57fd281e1de86508a8417b550089175c7fcc
---
M README.md
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/35/348935/1

diff --git a/README.md b/README.md
index b30d527..815edd2 100644
--- a/README.md
+++ b/README.md
@@ -302,6 +302,6 @@
 
 See {file:RELEASES.md}.
 
-## [License](../LICENSE)
+## [Sauce 
Labs](https://www.mediawiki.org/wiki/Selenium/Ruby/Target_beta_cluster_using_Sauce_Labs)
 
-© Copyright 2013-2017, Wikimedia Foundation & Contributors. Released under the 
terms of the GNU General Public License, version 2 or later.
+Sauce Labs gives you access to a variety of browsers and platforms for 
testing. For a full list of browsers and OSes supported by Sauce Labs, see 
their platforms page (the specific Linux variant used by Sauce Labs is Ubuntu 
LTS[2]). If you don't already have a Sauce Labs account, you can get a free 
limited account at the Sauce Labs signup page (choose either a Free account or 
an Open Sauce account).

-- 
To view, visit https://gerrit.wikimedia.org/r/348935
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8aad57fd281e1de86508a8417b550089175c7fcc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...api[master]: Ruby gem documentation should state license

2017-04-14 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348225 )

Change subject: Ruby gem documentation should state license
..

Ruby gem documentation should state license

Applied a copyright text at the end of README.md and linked it to the license 
file

Bug:T94001
Change-Id: Icc487bc6932027e4652dc24743c664c245e0222b
---
M README.md
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/ruby/api 
refs/changes/25/348225/1

diff --git a/README.md b/README.md
index 8e3e7f3..f8b1458 100644
--- a/README.md
+++ b/README.md
@@ -137,3 +137,6 @@
 ### 0.0.1 2014-02-07
 
 - Added MediawikiApi#create_article and #create_user.
+
+
+#© Copyright 1989, Wikimedia Foundation & contributors Licensed 
[here](../LICENSE.txt).

-- 
To view, visit https://gerrit.wikimedia.org/r/348225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc487bc6932027e4652dc24743c664c245e0222b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/selenium[master]: Ruby gem documentation should state license

2017-04-14 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348222 )

Change subject: Ruby gem documentation should state license
..

Ruby gem documentation should state license

Change-Id: Icc487bc6932027e4652dc24743c664c245e0222b
---
M README.md
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/22/348222/1

diff --git a/README.md b/README.md
index ab192a5..4ebe478 100644
--- a/README.md
+++ b/README.md
@@ -301,3 +301,6 @@
 ## Release notes
 
 See {file:RELEASES.md}.
+
+
+#© Copyright 1981, Wikimedia Foundation & contributors  Licensed 
[here](../LICENSE).

-- 
To view, visit https://gerrit.wikimedia.org/r/348222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc487bc6932027e4652dc24743c664c245e0222b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Proper indentation applied to horizontal links in the vector...

2017-03-27 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344976 )

Change subject: Proper indentation applied to horizontal links in the vector 
skin Bug: T67444
..

Proper indentation applied to horizontal links in the vector skin
Bug: T67444

Change-Id: I5dc48995583a0e0bd3d8bee6e698effecc4d3f7f
---
M components/navigation.less
M variables.less
2 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/76/344976/1

diff --git a/components/navigation.less b/components/navigation.less
index b6e99f2..9335647 100644
--- a/components/navigation.less
+++ b/components/navigation.less
@@ -1,7 +1,7 @@
-@import 'mediawiki.mixins';
-@import 'personalMenu';
-@import 'search';
-@import 'tabs';
+@import "mediawiki.mixins";
+@import "personalMenu";
+@import "search";
+@import "tabs";
 
 /* Hide, but keep accessible for screen-readers */
 #mw-navigation h2 {
@@ -15,7 +15,7 @@
background-position: bottom left;
background-repeat: repeat-x;
/* This image is only a fallback (for IE 6-9), so we do not @embed it. 
*/
-   background-image: url( images/page-fade.png );
+   background-image: url('images/page-fade.png');
.vertical-gradient(@body-background-color, @menu-background-color, 50%, 
100%);
background-color: @body-background-color;
 }
@@ -91,21 +91,24 @@
direction: ltr;
background-position: top left;
background-repeat: no-repeat;
-   .background-image('images/portal-break.png');
+   
 
h3 {
font-size: @menu-main-heading-font-size;
color: @menu-main-heading-color;
font-weight: normal;
-   margin: 0;
+   margin: 0.5em 0 0 0;
padding: @menu-main-heading-padding;
cursor: default;
-   border: 0;
+   border: none;
+   
}
 
div.body {
margin: @menu-main-body-margin;
padding-top: 0;
+   .background-image('images/portal-break.png');
+   background-repeat: no-repeat;
 
ul {
list-style-type: none;
@@ -139,6 +142,7 @@
display: none;
}
div.body {
+   background-image: none;
margin-left: 0.5em;
}
}
diff --git a/variables.less b/variables.less
old mode 100644
new mode 100755
index 5789065..98f9766
--- a/variables.less
+++ b/variables.less
@@ -25,14 +25,14 @@
 @menu-main-font-size: inherit;
 
 @menu-main-heading-font-size: 0.75em;
-@menu-main-heading-padding: 0.25em 0 0.25em 0.25em;
+@menu-main-heading-padding: 0.25em 0 0.25em 0.7em;
 @menu-main-heading-color: #4d4d4d;
 
 @menu-main-body-font-size: 0.75em;
 @menu-main-body-link-color: #0645ad;
 @menu-main-body-link-visited-color: #0b0080;
-@menu-main-body-margin: 0 0 0 1.25em;
-@menu-main-body-padding: 0;
+@menu-main-body-margin: 0 0 0 0.6em;
+@menu-main-body-padding: 0.3em 0 0 0;
 
 @menu-main-logo-left: 0.5em;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dc48995583a0e0bd3d8bee6e698effecc4d3f7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits