[MediaWiki-commits] [Gerrit] Restore erroneously removed copyright notice from https://ge... - change (mediawiki...MobileFrontend)

2014-03-10 Thread preilly (Code Review)
preilly has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117918

Change subject: Restore erroneously removed copyright notice from 
https://gerrit.wikimedia.org/r/#/c/117013/3
..

Restore erroneously removed copyright notice from 
https://gerrit.wikimedia.org/r/#/c/117013/3

Change-Id: Ibe26628691f7f34c2612754102e0b7773adef505
---
M MobileFrontend.i18n.php
M MobileFrontend.php
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/18/117918/1

diff --git a/MobileFrontend.i18n.php b/MobileFrontend.i18n.php
index 0132ec1..f4445a2 100644
--- a/MobileFrontend.i18n.php
+++ b/MobileFrontend.i18n.php
@@ -5,6 +5,8 @@
  * @file
  * @ingroup Extensions
  * @licence GNU General Public Licence 2.0 or later
+ * @author Patrick Reilly
+ * @copyright © 2011 Patrick Reilly
  */
 
 $messages = array();
diff --git a/MobileFrontend.php b/MobileFrontend.php
index b87079a..7d3af8c 100644
--- a/MobileFrontend.php
+++ b/MobileFrontend.php
@@ -10,6 +10,7 @@
  * @author Max Semenik
  * @author Patrick Reilly
  * @author Ryan Kaldari
+ * @copyright © 2011 Patrick Reilly
  * @licence GNU General Public Licence 2.0 or later
  */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/117918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe26628691f7f34c2612754102e0b7773adef505
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add - ref to Git-Tools. - change (sartoris)

2013-10-27 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add - ref to Git-Tools.
..


add - ref to Git-Tools.

Change-Id: Idc3388aba8e0b1070e7074da62ee4937ebd33e36
---
M README.rst
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/README.rst b/README.rst
index 0fe1bf6..98c9f8a 100644
--- a/README.rst
+++ b/README.rst
@@ -1,8 +1,10 @@
 Sartoris
 
 
-This is the Sartoris project.
-It is a tool to manage using git as a deployment management tool
+This is the Sartoris project. It is a tool to manage using git as a deployment 
management tool.  Also see:
+
+https://github.com/Git-Tools/git-deploy
+
 
 **Sartoris**
 

-- 
To view, visit https://gerrit.wikimedia.org/r/92260
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc3388aba8e0b1070e7074da62ee4937ebd33e36
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. Popen call / ref to .deploy file / _sync call args. - change (sartoris)

2013-05-17 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. Popen call / ref to .deploy file / _sync call args.
..


fix. Popen call / ref to .deploy file / _sync call args.

Change-Id: I9b15aad890e95cdb690a361c63410af6f9ab0e75
---
M sartoris/sartoris.py
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index d5b45b8..af5e910 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -170,7 +170,8 @@
 log.error({0}::{1}.format(__name__, exit_codes[exit_code]))
 sys.exit(exit_code)
 
-self.config['deploy_file'] = self.config['top_dir'] + '/.git'
+self.config['deploy_file'] = self.config['top_dir'] + \
+'/.git/.deploy'
 
 try:
 self.config['hook_dir'] = sc.get('deploy', 'hook-dir')
@@ -351,7 +352,8 @@
 _tag = {0}-sync-{1}.format(repo_name,
  datetime.now().strftime(
  self.DATE_TIME_TAG_FORMAT))
-proc = subprocess.Popen(['/usr/bin/git tag', '-a', _tag])
+proc = subprocess.Popen(['/usr/bin/git', 'tag', '-a', _tag, 
+ '-m', 'test sync'])
 proc.communicate()
 
 if proc.returncode != 0:
@@ -367,7 +369,7 @@
 exit_code = 32
 log.error({0}::{1}.format(__name__, exit_codes[exit_code]))
 return exit_code
-return self._sync()
+return self._sync(_tag, None)
 
 def _sync(self, tag, force):
 repo_name = self.config['repo_name']

-- 
To view, visit https://gerrit.wikimedia.org/r/64032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b15aad890e95cdb690a361c63410af6f9ab0e75
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add. force action in args. - change (sartoris)

2013-05-17 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add. force action in args.
..


add. force action in args.

Change-Id: I85b83d0d146e7db7545b4cd021c7b930ece4e9e1
---
M sartoris/sartoris.py
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index af5e910..110cc09 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -28,7 +28,7 @@
 import subprocess
 from dulwich.config import StackedConfig
 from dulwich.repo import Repo
-from dulwich.objects import Blob, Tree, Commit, parse_timezone, Tag
+from dulwich.objects import Blob, Tree, Commit, parse_timezone
 from datetime import datetime
 import json
 from time import time
@@ -120,6 +120,9 @@
 parser.add_argument(-v, --verbose,
 default=defaults[verbose], action=count,
 help=increase the logging verbosity)
+parser.add_argument(-f, --force,
+action=store_true,
+help=force the action, bypass sanity checks.)
 
 args = parser.parse_args()
 return args
@@ -352,7 +355,7 @@
 _tag = {0}-sync-{1}.format(repo_name,
  datetime.now().strftime(
  self.DATE_TIME_TAG_FORMAT))
-proc = subprocess.Popen(['/usr/bin/git', 'tag', '-a', _tag, 
+proc = subprocess.Popen(['/usr/bin/git', 'tag', '-a', _tag,
  '-m', 'test sync'])
 proc.communicate()
 
@@ -369,7 +372,7 @@
 exit_code = 32
 log.error({0}::{1}.format(__name__, exit_codes[exit_code]))
 return exit_code
-return self._sync(_tag, None)
+return self._sync(_tag, args.force)
 
 def _sync(self, tag, force):
 repo_name = self.config['repo_name']

-- 
To view, visit https://gerrit.wikimedia.org/r/64033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85b83d0d146e7db7545b4cd021c7b930ece4e9e1
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. removal of deploy folder once sync completes. - change (sartoris)

2013-05-17 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. removal of deploy folder once sync completes.
..


fix. removal of deploy folder once sync completes.

Change-Id: I0b481935d5d47002f442cde15158a50be3606842
---
M sartoris/sartoris.py
1 file changed, 19 insertions(+), 1 deletion(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index 110cc09..2676700 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -23,6 +23,8 @@
 import logging
 import argparse
 import os
+import stat
+import shutil
 import sys
 from re import search
 import subprocess
@@ -75,6 +77,19 @@
 class NullHandler(logging.Handler):
 def emit(self, record):
 pass
+
+
+def remove_readonly(fn, path, excinfo):
+
+Modifies path to writable for recursive path removal.
+e.g. shutil.rmtree(path, onerror=remove_readonly)
+
+if fn is os.rmdir:
+os.chmod(path, stat.S_IWRITE)
+os.rmdir(path)
+elif fn is os.remove:
+os.chmod(path, stat.S_IWRITE)
+os.remove(path)
 
 # Add a do-nothing NullHandler to the module logger to prevent No handlers
 # could be found errors. The calling code can still add other, more useful
@@ -390,7 +405,10 @@
 exit_code = 40
 log.error({0}::{1}.format(__name__, exit_codes[exit_code]))
 return exit_code
-os.unlink('.git/deploy')
+
+os.remove(self.DEPLOY_DIR + self.LOCK_FILE_HANDLE)
+shutil.rmtree(self.DEPLOY_DIR, onerror=remove_readonly)
+
 return 0
 
 def resync(self, args):

-- 
To view, visit https://gerrit.wikimedia.org/r/64034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b481935d5d47002f442cde15158a50be3606842
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change debug log message - change (sartoris)

2013-05-17 Thread preilly (Code Review)
preilly has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64312


Change subject: change debug log message
..

change debug log message

Change-Id: Ib9493d7faebd107774e7b5096ff9082a8fd884da
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/12/64312/1

diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index 2676700..c0dcae9 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -572,7 +572,7 @@
 log.addHandler(handler)
 log.setLevel(level)
 
-log.debug(Ready to run)
+log.debug(Sartoris is ready to run)
 
 # Inline call to functionality - if Sartoris does not possess this
 #  attribute flag with logger

-- 
To view, visit https://gerrit.wikimedia.org/r/64312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9493d7faebd107774e7b5096ff9082a8fd884da
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change debug log message - change (sartoris)

2013-05-17 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: change debug log message
..


change debug log message

Change-Id: Ib9493d7faebd107774e7b5096ff9082a8fd884da
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index 2676700..c0dcae9 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -572,7 +572,7 @@
 log.addHandler(handler)
 log.setLevel(level)
 
-log.debug(Ready to run)
+log.debug(Sartoris is ready to run)
 
 # Inline call to functionality - if Sartoris does not possess this
 #  attribute flag with logger

-- 
To view, visit https://gerrit.wikimedia.org/r/64312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9493d7faebd107774e7b5096ff9082a8fd884da
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@php.net
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. abort method does not attempt reset to a start tag when... - change (sartoris)

2013-05-13 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. abort method does not attempt reset to a start tag when 
one does not exist.
..


fix. abort method does not attempt reset to a start tag when one does not exist.

Change-Id: I975b03bdba582d80318eafa9c3a36dcbc7ae3a34
---
M sartoris/sartoris.py
1 file changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index c20e246..98eec19 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -315,23 +315,29 @@
 
 
 # Get the commit hash of the current tag
-commit_sha = self._get_commit_sha_for_tag(self._tag)
+try:
+commit_sha = self._get_commit_sha_for_tag(self._tag)
+except SartorisError:
+   # No current tag 
+   commit_sha = None
 
 # 1. hard reset the index to the desired tree
 # 2. move the branch pointer back to the previous HEAD
 # 3. commit revert
 # @TODO replace with dulwich
-if subprocess.call(git reset --hard {0}.format(commit_sha).split()):
-raise SartorisError(message=exit_codes[5], exit_code=5)
-if subprocess.call(git reset --soft HEAD@{1}.split()):
-raise SartorisError(message=exit_codes[5], exit_code=5)
-if subprocess.call(git commit -m 'Revert to {0}'.format(commit_sha).
+
+if commit_sha:
+if subprocess.call(git reset --hard 
{0}.format(commit_sha).split()):
+raise SartorisError(message=exit_codes[5], exit_code=5)
+if subprocess.call(git reset --soft HEAD@{1}.split()):
+raise SartorisError(message=exit_codes[5], exit_code=5)
+if subprocess.call(git commit -m 'Revert to 
{0}'.format(commit_sha).
split()):
-raise SartorisError(message=exit_codes[5], exit_code=5)
+raise SartorisError(message=exit_codes[5], exit_code=5)
 
 # Remove lock file
 if os.listdir(self.DEPLOY_DIR).__contains__(self.LOCK_FILE_HANDLE):
-os.remove(self.LOCK_FILE_HANDLE)
+os.remove(self.DEPLOY_DIR + self.LOCK_FILE_HANDLE)
 else:
 raise SartorisError(message=exit_codes[4])
 return 0

-- 
To view, visit https://gerrit.wikimedia.org/r/63409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I975b03bdba582d80318eafa9c3a36dcbc7ae3a34
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. dulwich tagging. - change (sartoris)

2013-05-13 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. dulwich tagging.
..


fix. dulwich tagging.

Change-Id: I49a10a52b68e81db3c8c1569d70fab563c99004a
---
M sartoris/sartoris.py
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index 98eec19..902a217 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -263,17 +263,10 @@
 object_store.add_object(tree)
 object_store.add_object(commit)
 _repo.refs['refs/heads/' + master_branch] = commit.id
+import pdb; pdb.set_trace()
 
 # Build the tag object and tag
-tag = Tag()
-tag.tagger = author
-tag.message = message
-tag.name = tag
-tag.object = (Commit, commit.id)
-tag.tag_time = commit.author_time
-tag.tag_timezone = tz
-object_store.add_object(tag)
-_repo['refs/tags/' + tag] = tag.id
+_repo['refs/tags/' + tag] = commit.id
 
 def start(self, args):
 
@@ -303,7 +296,8 @@
 
 try:
 self._dulwich_tag(_tag, _author)
-except Exception:
+except Exception as e:
+logging.error(str(e))
 raise SartorisError(message=exit_codes[12], exit_code=12)
 
 return 0

-- 
To view, visit https://gerrit.wikimedia.org/r/63410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49a10a52b68e81db3c8c1569d70fab563c99004a
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. remove debugger statement + pep8. - change (sartoris)

2013-05-13 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. remove debugger statement + pep8.
..


fix. remove debugger statement + pep8.

Change-Id: Ib02124bc23d6e5df85ada06c34800e4fd2e79cac
---
M sartoris/sartoris.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sartoris/sartoris.py b/sartoris/sartoris.py
index 902a217..d5b45b8 100755
--- a/sartoris/sartoris.py
+++ b/sartoris/sartoris.py
@@ -263,7 +263,6 @@
 object_store.add_object(tree)
 object_store.add_object(commit)
 _repo.refs['refs/heads/' + master_branch] = commit.id
-import pdb; pdb.set_trace()
 
 # Build the tag object and tag
 _repo['refs/tags/' + tag] = commit.id
@@ -312,8 +311,8 @@
 try:
 commit_sha = self._get_commit_sha_for_tag(self._tag)
 except SartorisError:
-   # No current tag 
-   commit_sha = None
+# No current tag
+commit_sha = None
 
 # 1. hard reset the index to the desired tree
 # 2. move the branch pointer back to the previous HEAD
@@ -321,12 +320,13 @@
 # @TODO replace with dulwich
 
 if commit_sha:
-if subprocess.call(git reset --hard 
{0}.format(commit_sha).split()):
+if subprocess.call(git reset --hard {0}.
+   format(commit_sha).split()):
 raise SartorisError(message=exit_codes[5], exit_code=5)
 if subprocess.call(git reset --soft HEAD@{1}.split()):
 raise SartorisError(message=exit_codes[5], exit_code=5)
-if subprocess.call(git commit -m 'Revert to 
{0}'.format(commit_sha).
-   split()):
+if subprocess.call(git commit -m 'Revert to {0}'.
+   format(commit_sha).split()):
 raise SartorisError(message=exit_codes[5], exit_code=5)
 
 # Remove lock file

-- 
To view, visit https://gerrit.wikimedia.org/r/63411
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib02124bc23d6e5df85ada06c34800e4fd2e79cac
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@php.net

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update ArticleFeedback to master - change (mediawiki/core)

2013-02-19 Thread preilly (Code Review)
preilly has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/49931


Change subject: Update ArticleFeedback to master
..

Update ArticleFeedback to master

Change-Id: I86534d6c06a5f7e8ee108319f998a47bab2e3ff9
---
M extensions/ArticleFeedback
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/31/49931/1

diff --git a/extensions/ArticleFeedback b/extensions/ArticleFeedback
index 6cc8f39..a316734 16
--- a/extensions/ArticleFeedback
+++ b/extensions/ArticleFeedback
-Subproject commit 6cc8f390119e07b046843a954c72bd74dce8b38c
+Subproject commit a316734107720c6e3f02a56800c589c660f09d45

-- 
To view, visit https://gerrit.wikimedia.org/r/49931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I86534d6c06a5f7e8ee108319f998a47bab2e3ff9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf9
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update ArticleFeedback to master - change (mediawiki/core)

2013-02-19 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Update ArticleFeedback to master
..


Update ArticleFeedback to master

Change-Id: I86534d6c06a5f7e8ee108319f998a47bab2e3ff9
---
M extensions/ArticleFeedback
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/extensions/ArticleFeedback b/extensions/ArticleFeedback
index 6cc8f39..a316734 16
--- a/extensions/ArticleFeedback
+++ b/extensions/ArticleFeedback
-Subproject commit 6cc8f390119e07b046843a954c72bd74dce8b38c
+Subproject commit a316734107720c6e3f02a56800c589c660f09d45

-- 
To view, visit https://gerrit.wikimedia.org/r/49931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86534d6c06a5f7e8ee108319f998a47bab2e3ff9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf9
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] replace call to MAX with GREATEST - change (mediawiki...ArticleFeedback)

2013-02-19 Thread preilly (Code Review)
preilly has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/49942


Change subject: replace call to MAX with GREATEST
..

replace call to MAX with GREATEST

Change-Id: I9ff1b796d0da07918ed0cdb53b6355ddb6e5b884
---
M api/ApiArticleFeedback.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedback 
refs/changes/42/49942/1

diff --git a/api/ApiArticleFeedback.php b/api/ApiArticleFeedback.php
index 6f35b43..9967df0 100644
--- a/api/ApiArticleFeedback.php
+++ b/api/ApiArticleFeedback.php
@@ -142,7 +142,7 @@
$dbw-update(
'article_feedback_pages',
array(
-   aap_total = MAX( aap_total + $updateAddition, 
0 ),
+   aap_total = GREATEST( aap_total + 
$updateAddition, 0 ),
'aap_count = aap_count + ' . 
$this-getCountChange( $lastRating, $thisRating ),
),
array(
@@ -184,7 +184,7 @@
$dbw-update(
'article_feedback_revisions',
array(
-   afr_total = MAX( afr_total + $updateAddition, 
0 ),
+   afr_total = GREATEST( afr_total + 
$updateAddition, 0 ),
'afr_count = afr_count + ' . 
$this-getCountChange( $lastRating, $thisRating ),
),
array(

-- 
To view, visit https://gerrit.wikimedia.org/r/49942
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ff1b796d0da07918ed0cdb53b6355ddb6e5b884
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedback
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update ArticleFeedback to master - change (mediawiki/core)

2013-02-19 Thread preilly (Code Review)
preilly has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/49943


Change subject: Update ArticleFeedback to master
..

Update ArticleFeedback to master

Change-Id: Ie0f8f2d4f3215543a70abcdb7ea5dd0f2cb536ac
---
M extensions/ArticleFeedback
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/49943/1

diff --git a/extensions/ArticleFeedback b/extensions/ArticleFeedback
index a316734..33b5c13 16
--- a/extensions/ArticleFeedback
+++ b/extensions/ArticleFeedback
-Subproject commit a316734107720c6e3f02a56800c589c660f09d45
+Subproject commit 33b5c1327c4768b8c6d1d393bf343c373632b2e2

-- 
To view, visit https://gerrit.wikimedia.org/r/49943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0f8f2d4f3215543a70abcdb7ea5dd0f2cb536ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf9
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Update ArticleFeedback to master - change (mediawiki/core)

2013-02-19 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Update ArticleFeedback to master
..


Update ArticleFeedback to master

Change-Id: Ie0f8f2d4f3215543a70abcdb7ea5dd0f2cb536ac
---
M extensions/ArticleFeedback
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/extensions/ArticleFeedback b/extensions/ArticleFeedback
index a316734..33b5c13 16
--- a/extensions/ArticleFeedback
+++ b/extensions/ArticleFeedback
-Subproject commit a316734107720c6e3f02a56800c589c660f09d45
+Subproject commit 33b5c1327c4768b8c6d1d393bf343c373632b2e2

-- 
To view, visit https://gerrit.wikimedia.org/r/49943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0f8f2d4f3215543a70abcdb7ea5dd0f2cb536ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf9
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Include forceHTTPS cookies in list of mobile cookies passed ... - change (operations/puppet)

2013-02-13 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Include forceHTTPS cookies in list of mobile cookies passed to 
apaches
..


Include forceHTTPS cookies in list of mobile cookies passed to apaches

Change-Id: I53265123f61995b467f08578cb813e4aded11f6c
---
M templates/varnish/mobile-frontend.inc.vcl.erb
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  Jdlrobson: Looks good to me, but someone else must approve
  jenkins-bot: Verified



-- 
To view, visit https://gerrit.wikimedia.org/r/48854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53265123f61995b467f08578cb813e4aded11f6c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: awjrichards aricha...@wikimedia.org
Gerrit-Reviewer: Asher afeld...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mod. _create_lock(). File creation should be done with a ope... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: mod. _create_lock(). File creation should be done with a open 
write op.
..


mod. _create_lock(). File creation should be done with a open write op.

Change-Id: I8d543797d15d6018092ae9e7b458536a2225e456
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d543797d15d6018092ae9e7b458536a2225e456
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add. For all test envs run tests in sartoris/tests/sartoris.... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add. For all test envs run tests in sartoris/tests/sartoris.py 
via nosetests.
..


add. For all test envs run tests in sartoris/tests/sartoris.py via nosetests.

Change-Id: I015b58c9db9eeb8998e26143600fdaf56714bc26
---
M tox.ini
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48768
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I015b58c9db9eeb8998e26143600fdaf56714bc26
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. add envs to tox.ini to run unit tests in python2.6/7 en... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. add envs to tox.ini to run unit tests in python2.6/7 
environments.
..


fix. add envs to tox.ini to run unit tests in python2.6/7 environments.

Change-Id: If59a17bdcb405c875895e59302da8bb82d7552ee
---
M tox.ini
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If59a17bdcb405c875895e59302da8bb82d7552ee
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mod. name change to test.py to avoid package name conflict. ... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: mod. name change to test.py to avoid package name conflict.  
Imeplemented unit tests in TestSartorisInit.
..


mod. name change to test.py to avoid package name conflict.  Imeplemented unit 
tests in TestSartorisInit.

Change-Id: Ie0289a6ce8929045aa2a2eea73c2162e0e4dc0bd
---
A sartoris/tests/test.py
1 file changed, 102 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0289a6ce8929045aa2a2eea73c2162e0e4dc0bd
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] rm. redundant imports. - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: rm.  redundant imports.
..


rm.  redundant imports.

Change-Id: Ib0575a5f3006c2f8bcf34b424bde5ef7e27f36c7
---
M sartoris/__init__.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0575a5f3006c2f8bcf34b424bde5ef7e27f36c7
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix. reference to _tag and call to attribute in sync and res... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix. reference to _tag and call to attribute in sync and resync 
methods.
..


fix. reference to _tag and call to attribute in sync and resync methods.

Change-Id: I2481f810b823dcac3eed7566a397542b42ca9c6e
---
M sartoris/sartoris.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2481f810b823dcac3eed7566a397542b42ca9c6e
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mod. remove py26 env (argparse = py27). Nose call to test.p... - change (sartoris)

2013-02-12 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: mod. remove py26 env (argparse = py27). Nose call to test.py.
..


mod. remove py26 env (argparse = py27). Nose call to test.py.

Change-Id: Ibd94578df827750d81df9e9ad592eec8b861b4b3
---
M tox.ini
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked



-- 
To view, visit https://gerrit.wikimedia.org/r/48777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd94578df827750d81df9e9ad592eec8b861b4b3
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add. call to dulwich tag in start. - change (sartoris)

2013-02-11 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add. call to dulwich tag in start.
..


add. call to dulwich tag in start.

Change-Id: I182507985dc5d4a87fc135ab02964900d8ad61e4
---
M sartoris/sartoris.py
1 file changed, 13 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/47735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I182507985dc5d4a87fc135ab02964900d8ad61e4
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] make jquery.json module run on mobile - change (mediawiki/core)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: make jquery.json module run on mobile
..


make jquery.json module run on mobile

Currently needed by the EventLogging module

Change-Id: I78fc3d3937e1489f142abdb35793e616a8a18d2e
---
M resources/Resources.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  Jdlrobson: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/48066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78fc3d3937e1489f142abdb35793e616a8a18d2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.21wmf9
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Drop ClickTracking integration from mw.user.bucket - change (mediawiki...ArticleFeedback)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Drop ClickTracking integration from mw.user.bucket
..


Drop ClickTracking integration from mw.user.bucket

Support will be dropped per https://gerrit.wikimedia.org/r/#/c/46205/

The tracking has no functional implications  I don't really see any point in 
tracking the bucketing decisions (which are both at 100/0)

Change-Id: I920e8719c372fe3bac1003060411ca03a726a753
---
M ArticleFeedback.php
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I920e8719c372fe3bac1003060411ca03a726a753
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedback
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Drop ClickTracking integration from mw.user.bucket - change (mediawiki...ArticleFeedbackv5)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Drop ClickTracking integration from mw.user.bucket
..


Drop ClickTracking integration from mw.user.bucket

Support is being dropped per https://gerrit.wikimedia.org/r/#/c/46205/ - this 
was not actively being used in AFTv5

Change-Id: I774ce206564a04e2307d97bba17d48f9e24c5e80
---
M ArticleFeedbackv5.php
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I774ce206564a04e2307d97bba17d48f9e24c5e80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Correct capitalization of sidebar links - change (wikimedia...modifications)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Correct capitalization of sidebar links
..


Correct capitalization of sidebar links

Change-Id: I00f6248eaa4ca20ebc961cc055cde9fd0d1cf182
---
M bugzilla-4.2/template/en/custom/global/user-links.html.tmpl
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/44756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00f6248eaa4ca20ebc961cc055cde9fd0d1cf182
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bugzilla/modifications
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: MZMcBride w...@mzmcbride.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Imported Upstream version 0.8.0 - change (operations...python-jsonschema)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Imported Upstream version 0.8.0
..


Imported Upstream version 0.8.0

Change-Id: I03f55ec36a63b12c0668d75dd310a5c9068a570b
---
A .gitignore
A .travis.yml
A CHANGELOG.rst
A COPYING
A MANIFEST.in
A README.rst
A docs/Makefile
A docs/conf.py
A docs/creating.rst
A docs/errors.rst
A docs/index.rst
A docs/make.bat
A docs/references.rst
A docs/validate.rst
A json/.gitignore
A json/.travis.yml
A json/LICENSE
A json/README.md
A json/bin/suite_sanity_check
A json/tests/draft3/additionalItems.json
A json/tests/draft3/additionalProperties.json
A json/tests/draft3/dependencies.json
A json/tests/draft3/disallow.json
A json/tests/draft3/divisibleBy.json
A json/tests/draft3/enum.json
A json/tests/draft3/extends.json
A json/tests/draft3/items.json
A json/tests/draft3/maxItems.json
A json/tests/draft3/maxLength.json
A json/tests/draft3/maximum.json
A json/tests/draft3/minItems.json
A json/tests/draft3/minLength.json
A json/tests/draft3/minimum.json
A json/tests/draft3/optional/bignum.json
A json/tests/draft3/optional/format.json
A json/tests/draft3/pattern.json
A json/tests/draft3/patternProperties.json
A json/tests/draft3/properties.json
A json/tests/draft3/ref.json
A json/tests/draft3/required.json
A json/tests/draft3/type.json
A json/tests/draft3/uniqueItems.json
A jsonschema.py
A perftest
A setup.py
A tests.py
A tox.ini
47 files changed, 4,357 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/48043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03f55ec36a63b12c0668d75dd310a5c9068a570b
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/python-jsonschema
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Imported Upstream version 0.8.0 - change (operations...python-jsonschema)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Imported Upstream version 0.8.0
..


Imported Upstream version 0.8.0

Change-Id: I723fb2b704b2c7354d7255e9d4f8cb544ca8d6a0
---
A .gitignore
A .travis.yml
A CHANGELOG.rst
A COPYING
A MANIFEST.in
A README.rst
A docs/Makefile
A docs/conf.py
A docs/creating.rst
A docs/errors.rst
A docs/index.rst
A docs/make.bat
A docs/references.rst
A docs/validate.rst
A json/.gitignore
A json/.travis.yml
A json/LICENSE
A json/README.md
A json/bin/suite_sanity_check
A json/tests/draft3/additionalItems.json
A json/tests/draft3/additionalProperties.json
A json/tests/draft3/dependencies.json
A json/tests/draft3/disallow.json
A json/tests/draft3/divisibleBy.json
A json/tests/draft3/enum.json
A json/tests/draft3/extends.json
A json/tests/draft3/items.json
A json/tests/draft3/maxItems.json
A json/tests/draft3/maxLength.json
A json/tests/draft3/maximum.json
A json/tests/draft3/minItems.json
A json/tests/draft3/minLength.json
A json/tests/draft3/minimum.json
A json/tests/draft3/optional/bignum.json
A json/tests/draft3/optional/format.json
A json/tests/draft3/pattern.json
A json/tests/draft3/patternProperties.json
A json/tests/draft3/properties.json
A json/tests/draft3/ref.json
A json/tests/draft3/required.json
A json/tests/draft3/type.json
A json/tests/draft3/uniqueItems.json
A jsonschema.py
A perftest
A setup.py
A tests.py
A tox.ini
47 files changed, 4,357 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/48042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I723fb2b704b2c7354d7255e9d4f8cb544ca8d6a0
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/python-jsonschema
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Backported to precise-wikimedia. - change (operations...python-jsonschema)

2013-02-08 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Backported to precise-wikimedia.
..


Backported to precise-wikimedia.

Change-Id: Ie2243bd70cd03207efc7d4d759c3d1c58d4c5f4e
---
M debian/changelog
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/48045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2243bd70cd03207efc7d4d759c3d1c58d4c5f4e
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/python-jsonschema
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Faidon fai...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. revert() functionality. - change (sartoris[master])

2013-02-05 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. revert() functionality.
..


Add. revert() functionality.

Change-Id: I03f6e7ea504d7fa57800452a7f997ad32b8c0019
---
M sartoris/sartoris.py
1 file changed, 34 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/47061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03f6e7ea504d7fa57800452a7f997ad32b8c0019
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. method _get_latest_deploy_tag to fetch the latest deplo... - change (sartoris[master])

2013-02-05 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. method _get_latest_deploy_tag to fetch the latest deploy 
tag..
..


Add. method _get_latest_deploy_tag to fetch the latest deploy tag..

Change-Id: If58b873e429e6fa90603316662d07dfc36354488
---
M sartoris/sartoris.py
1 file changed, 24 insertions(+), 24 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/47062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If58b873e429e6fa90603316662d07dfc36354488
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Supply correct number of args to _sync. - change (sartoris[master])

2013-02-05 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Supply correct number of args to _sync.
..


Fix. Supply correct number of args to _sync.

Change-Id: I753bfb31c94a734b4cca8a3a80eb0fda0813e64b
---
M sartoris/sartoris.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/47063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I753bfb31c94a734b4cca8a3a80eb0fda0813e64b
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Mod. raise error for bad returncode in _get_latest_deploy_ta... - change (sartoris[master])

2013-02-05 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Mod. raise error for bad returncode in _get_latest_deploy_tag.
..


Mod. raise error for bad returncode in _get_latest_deploy_tag.

Change-Id: I0e9948112084b023dd086ee5c9cc2eae28c78405
---
M sartoris/sartoris.py
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/47064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e9948112084b023dd086ee5c9cc2eae28c78405
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. log_deploys() functionality. - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. log_deploys() functionality.
..


Add. log_deploys() functionality.

Change-Id: I581b0b2e4933fe67c6c17378f5b4dee29447efef
---
M sartoris/sartoris.py
1 file changed, 19 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I581b0b2e4933fe67c6c17378f5b4dee29447efef
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. log_deploys() functionality. - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. log_deploys() functionality.
..


Add. log_deploys() functionality.

Change-Id: I949ca6206bd1ab18c7f10b7a18bd8bc2c81ac64c
---
M sartoris/sartoris.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I949ca6206bd1ab18c7f10b7a18bd8bc2c81ac64c
Gerrit-PatchSet: 3
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] generated all the stubs - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: generated all the stubs
..

generated all the stubs

Change-Id: I3d86eabcf94ba6571590ed11acac9cd9e84aa895
---
A sartoris/tests/sartoris.py
D sartoris/testsuite/sartoris.py
2 files changed, 83 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/01/46901/1
--
To view, visit https://gerrit.wikimedia.org/r/46901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d86eabcf94ba6571590ed11acac9cd9e84aa895
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] generated all the stubs - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: generated all the stubs
..


generated all the stubs

Change-Id: I3d86eabcf94ba6571590ed11acac9cd9e84aa895
---
A sartoris/tests/sartoris.py
D sartoris/testsuite/sartoris.py
2 files changed, 83 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d86eabcf94ba6571590ed11acac9cd9e84aa895
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Conform to PEP 8
..

Conform to PEP 8

Change-Id: I660bfccea0b2a4c781464490d6905e8794cabcb9
---
M sartoris/tests/sartoris.py
1 file changed, 19 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/02/46902/1
--
To view, visit https://gerrit.wikimedia.org/r/46902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I660bfccea0b2a4c781464490d6905e8794cabcb9
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-30 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Conform to PEP 8
..


Conform to PEP 8

Change-Id: I660bfccea0b2a4c781464490d6905e8794cabcb9
---
M sartoris/tests/sartoris.py
1 file changed, 19 insertions(+), 14 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I660bfccea0b2a4c781464490d6905e8794cabcb9
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Pep-8 compliance. - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Pep-8 compliance.
..


Fix. Pep-8 compliance.

Change-Id: Ib89532afcb61f45c81d05bef6f24016097d0fd0b
---
M sartoris/sartoris.py
1 file changed, 8 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/46640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib89532afcb61f45c81d05bef6f24016097d0fd0b
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. stream for stdout, stderr in Popen call in show_tag. - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. stream for stdout, stderr in Popen call in show_tag.
..


Fix. stream for stdout, stderr in Popen call in show_tag.

Change-Id: I9205b6abe5b14cdb4ae18332f51afaa6b96d43a6
---
M sartoris/sartoris.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails


--
To view, visit https://gerrit.wikimedia.org/r/46637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9205b6abe5b14cdb4ae18332f51afaa6b96d43a6
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. import reference to json module. - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. import reference to json module.
..


Add. import reference to json module.

Change-Id: I69cdd4391f7aca53899dc0d9432c0d3e9595d499
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails


--
To view, visit https://gerrit.wikimedia.org/r/46636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I69cdd4391f7aca53899dc0d9432c0d3e9595d499
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Popen calls fail when commands contain pipes. Fixed in ... - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Popen calls fail when commands contain pipes. Fixed in 
show_tag().
..


Fix. Popen calls fail when commands contain pipes. Fixed in show_tag().

Change-Id: Idb8fcbdb76eb0666b37558296b81aad7268ddc4a
---
M sartoris/sartoris.py
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails


--
To view, visit https://gerrit.wikimedia.org/r/46635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb8fcbdb76eb0666b37558296b81aad7268ddc4a
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Popen calls fail when commands contain pipes. Fixed in ... - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Popen calls fail when commands contain pipes. Fixed in 
diff().
..


Fix. Popen calls fail when commands contain pipes. Fixed in diff().

Change-Id: I98bc4298fbc4ba924732533dcd9ad24ceef7327b
---
M sartoris/sartoris.py
1 file changed, 10 insertions(+), 11 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails


--
To view, visit https://gerrit.wikimedia.org/r/46634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98bc4298fbc4ba924732533dcd9ad24ceef7327b
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Call communicate() on Popen objects to block on preoces... - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Call communicate() on Popen objects to block on preocess 
completion.
..


Fix. Call communicate() on Popen objects to block on preocess completion.

Change-Id: I7ba86b3f9ba8b5e1c9f3ae6b5484dd1754bc54a2
---
M sartoris/sartoris.py
1 file changed, 37 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved

Objections:
  jenkins-bot: Fails


--
To view, visit https://gerrit.wikimedia.org/r/46633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ba86b3f9ba8b5e1c9f3ae6b5484dd1754bc54a2
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. show_tag() method. - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. show_tag() method.
..


Add. show_tag() method.

Change-Id: I38b04708330300b75ee1d32f5b799230a330
---
M sartoris/sartoris.py
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38b04708330300b75ee1d32f5b799230a330
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix development status classifiers - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: fix development status classifiers
..

fix development status classifiers

Change-Id: Id4e785143d8048ed302c058c8225846baee442aa
---
M setup.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/59/46659/1
--
To view, visit https://gerrit.wikimedia.org/r/46659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4e785143d8048ed302c058c8225846baee442aa
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix development status classifiers - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix development status classifiers
..


fix development status classifiers

Change-Id: Id4e785143d8048ed302c058c8225846baee442aa
---
M setup.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4e785143d8048ed302c058c8225846baee442aa
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add empty test suite directory - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: add empty test suite directory
..

add empty test suite directory

Change-Id: I4ea085bba56634e73a0ea0a01b5c545b91b077b5
---
A sartoris/testsuite/sartoris.py
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/64/46664/1
--
To view, visit https://gerrit.wikimedia.org/r/46664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ea085bba56634e73a0ea0a01b5c545b91b077b5
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add empty test suite directory - change (sartoris[master])

2013-01-29 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add empty test suite directory
..


add empty test suite directory

Change-Id: I4ea085bba56634e73a0ea0a01b5c545b91b077b5
---
A sartoris/testsuite/sartoris.py
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ea085bba56634e73a0ea0a01b5c545b91b077b5
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-28 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Conform to PEP 8
..

Conform to PEP 8

sartoris/sartoris$ pep8 sartoris.py
sartoris.py:52:1: E302 expected 2 blank lines, found 1
sartoris.py:54:51: E231 missing whitespace after ','
sartoris.py:59:24: E701 multiple statements on one line (colon)
sartoris.py:171:64: E701 multiple statements on one line (colon)
sartoris.py:171:58: E231 missing whitespace after ','
sartoris.py:180:13: E128 continuation line under-indented for visual indent
sartoris.py:181:13: E128 continuation line under-indented for visual indent
sartoris.py:231:13: E128 continuation line under-indented for visual indent
sartoris.py:231:13: E125 continuation line does not distinguish itself from 
next logical line
sartoris.py:354:13: E128 continuation line under-indented for visual indent

Change-Id: Ibea81aef5b7decba2bf44e591ffd7e00df35b9c2
---
M sartoris/sartoris.py
1 file changed, 12 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/72/46272/1
--
To view, visit https://gerrit.wikimedia.org/r/46272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibea81aef5b7decba2bf44e591ffd7e00df35b9c2
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-28 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Conform to PEP 8
..


Conform to PEP 8

sartoris/sartoris$ pep8 sartoris.py
sartoris.py:52:1: E302 expected 2 blank lines, found 1
sartoris.py:54:51: E231 missing whitespace after ','
sartoris.py:59:24: E701 multiple statements on one line (colon)
sartoris.py:171:64: E701 multiple statements on one line (colon)
sartoris.py:171:58: E231 missing whitespace after ','
sartoris.py:180:13: E128 continuation line under-indented for visual indent
sartoris.py:181:13: E128 continuation line under-indented for visual indent
sartoris.py:231:13: E128 continuation line under-indented for visual indent
sartoris.py:231:13: E125 continuation line does not distinguish itself from 
next logical line
sartoris.py:354:13: E128 continuation line under-indented for visual indent

Change-Id: Ibea81aef5b7decba2bf44e591ffd7e00df35b9c2
---
M sartoris/sartoris.py
1 file changed, 12 insertions(+), 10 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea81aef5b7decba2bf44e591ffd7e00df35b9c2
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] tox.ini file - change (sartoris[master])

2013-01-28 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: tox.ini file
..


tox.ini file

tox is a nice python utility to run tests, it let you define isolated
environnement which run specific list of commands.

This patches defines the pep8 and pyflakes env which are both linting
tools. To run then run:

 tox -v -epep8
 tox -v -epyflakes

Or simply:

 tox

You will need the python-tox packages to be installed or get it from
pip.

Change-Id: Ief41419a7aa6fd4d69808b097f1e6b3a0f1d4b37
---
M MANIFEST.in
A tox.ini
2 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Rfaulk: Looks good to me, but someone else must approve
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief41419a7aa6fd4d69808b097f1e6b3a0f1d4b37
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] console script now uses the new 'cli' entry point - change (sartoris[master])

2013-01-28 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: console script now uses the new 'cli' entry point
..


console script now uses the new 'cli' entry point

sartoris 'main' entry points require an argument which is not possible
using setuptools.  I am defining a new entry point named 'cli' which
takes no argument and in turn call 'main' with the system arguments.

The 'main' entry point is left unchanged and still require argument to
be passed to it.

Test plan:

$ sudo python setup.py develop
$ sartoris
usage: sartoris [-q --quiet] [-s --silent] [-v --verbose] [method]
sartoris: error: too few arguments
$

Change-Id: Ia805543d6e3718f253caa0f1c1f815bb0a085724
---
M sartoris/__init__.py
M sartoris/sartoris.py
M setup.py
3 files changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Rfaulk: Looks good to me, but someone else must approve
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia805543d6e3718f253caa0f1c1f815bb0a085724
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] misc minor fix up - change (sartoris[master])

2013-01-28 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: misc minor fix up
..


misc minor fix up

undefined hook_dir
undefined DATE_TIME_TAG_FORMAT
Redefining built-in 'format'

Change-Id: I86e1c078a9b621ef7bd712ae903082730df36b11
---
M sartoris/sartoris.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Checked


--
To view, visit https://gerrit.wikimedia.org/r/46472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86e1c078a9b621ef7bd712ae903082730df36b11
Gerrit-PatchSet: 2
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. Diff functionality. helper method _get_commit_sha_for_t... - change (sartoris[master])

2013-01-27 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. Diff functionality. helper method 
_get_commit_sha_for_tag().
..


Add. Diff functionality. helper method _get_commit_sha_for_tag().

Change-Id: I8c5715ac6119afb0b2dc10b35271272e21d5ad25
---
M sartoris/sartoris.py
1 file changed, 42 insertions(+), 11 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5715ac6119afb0b2dc10b35271272e21d5ad25
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Mod. Fix control on subprocess returncodes. Make commands cl... - change (sartoris[master])

2013-01-27 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Mod. Fix control on subprocess returncodes. Make commands 
clearer.
..


Mod. Fix control on subprocess returncodes. Make commands clearer.

Change-Id: Id8c876116b0222b5545183f8fd9a8cbd6b8af716
---
M sartoris/sartoris.py
1 file changed, 15 insertions(+), 17 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8c876116b0222b5545183f8fd9a8cbd6b8af716
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. Return with exit code from SartorisError. - change (sartoris[master])

2013-01-27 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. Return with exit code from SartorisError.
..


Add. Return with exit code from SartorisError.

Change-Id: If281b3fa708159f29e5f60f66f05096c80f46603
---
M sartoris/sartoris.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If281b3fa708159f29e5f60f66f05096c80f46603
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. fixing missing process call in diff. - change (sartoris[master])

2013-01-27 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. fixing missing process call in diff.
..


Fix. fixing missing process call in diff.

Change-Id: I0697541757a27b50b4c7c788705eb2cddb4fed95
---
M sartoris/sartoris.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0697541757a27b50b4c7c788705eb2cddb4fed95
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Mod. Use SartorisError to flag exceptional behaviour in star... - change (sartoris[master])

2013-01-26 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Mod. Use SartorisError to flag exceptional behaviour in start  
abort.
..


Mod. Use SartorisError to flag exceptional behaviour in start  abort.

Change-Id: I4717229ef47b469fdf3f656ca2a610f93f09760d
---
M sartoris/sartoris.py
1 file changed, 16 insertions(+), 12 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/46006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4717229ef47b469fdf3f656ca2a610f93f09760d
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] small fixes for distribution - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: small fixes for distribution
..

small fixes for distribution

Change-Id: If7d9bde27dac786476cb72e0996cf634ea6a830f
---
A AUTHORS
A CHANGES
A LICENSE
D LICENSE.txt
D __init__.py
A sartoris/__init__.py
6 files changed, 63 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/77/45777/1
--
To view, visit https://gerrit.wikimedia.org/r/45777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7d9bde27dac786476cb72e0996cf634ea6a830f
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] small fixes for distribution - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: small fixes for distribution
..


small fixes for distribution

Change-Id: If7d9bde27dac786476cb72e0996cf634ea6a830f
---
A AUTHORS
A CHANGES
A LICENSE
D LICENSE.txt
D __init__.py
A sartoris/__init__.py
6 files changed, 63 insertions(+), 13 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7d9bde27dac786476cb72e0996cf634ea6a830f
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add more files for distribution - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: add more files for distribution
..

add more files for distribution

Change-Id: Ie5f42e2527bbb5a189734b35740afbcd66ffbff0
---
A MANIFEST.in
A Makefile
A scripts/make-release.py
3 files changed, 177 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/79/45779/1
--
To view, visit https://gerrit.wikimedia.org/r/45779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5f42e2527bbb5a189734b35740afbcd66ffbff0
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] add more files for distribution - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: add more files for distribution
..


add more files for distribution

Change-Id: Ie5f42e2527bbb5a189734b35740afbcd66ffbff0
---
A MANIFEST.in
A Makefile
A scripts/make-release.py
3 files changed, 177 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5f42e2527bbb5a189734b35740afbcd66ffbff0
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix version and line continuation - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: fix version and line continuation
..

fix version and line continuation

Change-Id: I7f273ac7828307d6ccf7fb5d24e5f2a13ca57fbf
---
R README.rst
M setup.py
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/81/45781/1
--
To view, visit https://gerrit.wikimedia.org/r/45781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f273ac7828307d6ccf7fb5d24e5f2a13ca57fbf
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix version and line continuation - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix version and line continuation
..


fix version and line continuation

Change-Id: I7f273ac7828307d6ccf7fb5d24e5f2a13ca57fbf
---
R README.rst
M setup.py
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f273ac7828307d6ccf7fb5d24e5f2a13ca57fbf
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enabled date tagging - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: enabled date tagging
..

enabled date tagging

Change-Id: I62f0f46a3e74890d89b3999a1f2ad6e57df80bfb
---
A setup.cfg
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/82/45782/1
--
To view, visit https://gerrit.wikimedia.org/r/45782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62f0f46a3e74890d89b3999a1f2ad6e57df80bfb
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] enabled date tagging - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: enabled date tagging
..


enabled date tagging

Change-Id: I62f0f46a3e74890d89b3999a1f2ad6e57df80bfb
---
A setup.cfg
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62f0f46a3e74890d89b3999a1f2ad6e57df80bfb
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change readme for additional accuracy - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: change readme for additional accuracy
..

change readme for additional accuracy

Change-Id: Icb2a43525c9a12342a397b1fe3549094556affe0
---
M README.rst
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/93/45793/1
--
To view, visit https://gerrit.wikimedia.org/r/45793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb2a43525c9a12342a397b1fe3549094556affe0
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] change readme for additional accuracy - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: change readme for additional accuracy
..


change readme for additional accuracy

Change-Id: Icb2a43525c9a12342a397b1fe3549094556affe0
---
M README.rst
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb2a43525c9a12342a397b1fe3549094556affe0
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Mod. Utilize _check_lock function in Sartoris::start(). - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Mod. Utilize _check_lock function in Sartoris::start().
..


Mod. Utilize _check_lock function in Sartoris::start().

Change-Id: I8a27d207594894338e24cab7235f553465b952b4
---
M sartoris/sartoris.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a27d207594894338e24cab7235f553465b952b4
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add. Expose command line args to Sartoris git-deploy functio... - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add. Expose command line args to Sartoris git-deploy functions.
..


Add. Expose command line args to Sartoris git-deploy functions.

Change-Id: I88f04da67de7a6eaca2df1acf7b64925b678add6
---
M sartoris/sartoris.py
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88f04da67de7a6eaca2df1acf7b64925b678add6
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Indentation error in abort(). - change (sartoris[master])

2013-01-25 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Indentation error in abort().
..


Fix. Indentation error in abort().

Change-Id: I2ed03bcc60e255fb36902d0b8b4e76ac80a8110c
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ed03bcc60e255fb36902d0b8b4e76ac80a8110c
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Replace custom CS carrier codes with MCC-MNC mobile carrier ... - change (operations/puppet[production])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Replace custom CS carrier codes with MCC-MNC mobile carrier 
codes.
..


Replace custom CS carrier codes with MCC-MNC mobile carrier codes.

Change-Id: I7da99ef223c33696349a33dec03bd8d215293738
---
M templates/varnish/mobile-frontend.inc.vcl.erb
1 file changed, 26 insertions(+), 21 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/45353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7da99ef223c33696349a33dec03bd8d215293738
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Diederik dvanli...@wikimedia.org
Gerrit-Reviewer: Diederik dvanli...@wikimedia.org
Gerrit-Reviewer: Ottomata o...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix location of repo - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: fix location of repo
..

fix location of repo

Change-Id: I9ca424e0da36c93dbd05a7bb4cb74d7f2f0b7747
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/78/45678/1
--
To view, visit https://gerrit.wikimedia.org/r/45678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ca424e0da36c93dbd05a7bb4cb74d7f2f0b7747
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix location of repo - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix location of repo
..


fix location of repo

Change-Id: I9ca424e0da36c93dbd05a7bb4cb74d7f2f0b7747
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ca424e0da36c93dbd05a7bb4cb74d7f2f0b7747
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] remove Murder and Bittorrent dependencies - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: remove Murder and Bittorrent dependencies
..

remove Murder and Bittorrent dependencies

Change-Id: I126968784d81f705eff6dc0a650d7e8d65cdc3da
---
D debian/changelog
D debian/compat
D debian/control
D debian/copyright
D debian/rules
D debian/sartoris-common.dirs
D debian/sartoris-common.install
D debian/sartoris-common.links
D debian/sartoris-seeder.default
D debian/sartoris-seeder.dirs
D debian/sartoris-seeder.init
D debian/sartoris-seeder.install
D debian/sartoris-seeder.links
D sartoris/murder_client.py
D sartoris/seeder.py
15 files changed, 0 insertions(+), 702 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/80/45680/1
--
To view, visit https://gerrit.wikimedia.org/r/45680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I126968784d81f705eff6dc0a650d7e8d65cdc3da
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] remove Murder and Bittorrent dependencies - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: remove Murder and Bittorrent dependencies
..


remove Murder and Bittorrent dependencies

Change-Id: I126968784d81f705eff6dc0a650d7e8d65cdc3da
---
D debian/changelog
D debian/compat
D debian/control
D debian/copyright
D debian/rules
D debian/sartoris-common.dirs
D debian/sartoris-common.install
D debian/sartoris-common.links
D debian/sartoris-seeder.default
D debian/sartoris-seeder.dirs
D debian/sartoris-seeder.init
D debian/sartoris-seeder.install
D debian/sartoris-seeder.links
D sartoris/murder_client.py
D sartoris/seeder.py
15 files changed, 0 insertions(+), 702 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I126968784d81f705eff6dc0a650d7e8d65cdc3da
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix copyright - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: fix copyright
..

fix copyright

Change-Id: I3a58f0f447e27eae5cb4796d44db296d1379a79a
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/81/45681/1
--
To view, visit https://gerrit.wikimedia.org/r/45681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a58f0f447e27eae5cb4796d44db296d1379a79a
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] fix copyright - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: fix copyright
..


fix copyright

Change-Id: I3a58f0f447e27eae5cb4796d44db296d1379a79a
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a58f0f447e27eae5cb4796d44db296d1379a79a
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Conform to PEP 8
..

Conform to PEP 8

Change-Id: I9c47b0b6f5a25e35b0eaf3c074fe579f69529db4
---
M sartoris/sartoris.py
1 file changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/90/45690/1
--
To view, visit https://gerrit.wikimedia.org/r/45690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c47b0b6f5a25e35b0eaf3c074fe579f69529db4
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Conform to PEP 8
..


Conform to PEP 8

Change-Id: I9c47b0b6f5a25e35b0eaf3c074fe579f69529db4
---
M sartoris/sartoris.py
1 file changed, 17 insertions(+), 15 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c47b0b6f5a25e35b0eaf3c074fe579f69529db4
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. PEP-8 compliance. Replaced optparse with argparse. - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. PEP-8 compliance. Replaced optparse with argparse.
..


Fix. PEP-8 compliance. Replaced optparse with argparse.

Change-Id: I8d7948444898471f3b3b548496e9ce3cd1ce9a85
---
M sartoris/sartoris.py
1 file changed, 37 insertions(+), 24 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d7948444898471f3b3b548496e9ce3cd1ce9a85
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Conform to PEP 8
..

Conform to PEP 8

Change-Id: I2c1196183fc3bcf4a357ef8190ce766befa51050
---
M sartoris/sartoris.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/03/45703/1
--
To view, visit https://gerrit.wikimedia.org/r/45703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c1196183fc3bcf4a357ef8190ce766befa51050
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Conform to PEP 8
..


Conform to PEP 8

Change-Id: I2c1196183fc3bcf4a357ef8190ce766befa51050
---
M sartoris/sartoris.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c1196183fc3bcf4a357ef8190ce766befa51050
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Move configuration into a function + small fixes - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Move configuration into a function + small fixes
..


Move configuration into a function + small fixes

* Centralize configuration
* pep8 fixes for whitespace
* Add missing log messages for exit codes

Change-Id: I7f596f7507148e35e68f325a4bb6f88cd648207a
---
M sartoris/sartoris.py
1 file changed, 46 insertions(+), 20 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f596f7507148e35e68f325a4bb6f88cd648207a
Gerrit-PatchSet: 2
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Conform to PEP 8
..

Conform to PEP 8

Change-Id: I76020646215eee011d35f20da9c28d4aaab49e73
---
M sartoris/sartoris.py
1 file changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/05/45705/1
--
To view, visit https://gerrit.wikimedia.org/r/45705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76020646215eee011d35f20da9c28d4aaab49e73
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Conform to PEP 8 - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Conform to PEP 8
..


Conform to PEP 8

Change-Id: I76020646215eee011d35f20da9c28d4aaab49e73
---
M sartoris/sartoris.py
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45705
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76020646215eee011d35f20da9c28d4aaab49e73
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix. Missing after 3rd element in . - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Fix. Missing  after 3rd element in .
..


Fix. Missing  after 3rd element in .

Change-Id: I1dcef83ebb1a763ea743d126f62ca55a88b71e69
---
M sartoris/sartoris.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1dcef83ebb1a763ea743d126f62ca55a88b71e69
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk rfaulk...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] PEP8 fixes - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: PEP8 fixes
..


PEP8 fixes

Change-Id: Ifc2e0abf57308758702bce409935ac1f9ff88185
---
M sartoris/sartoris.py
1 file changed, 13 insertions(+), 24 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2e0abf57308758702bce409935ac1f9ff88185
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add a setup script - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Add a setup script
..

Add a setup script

Change-Id: Ic0c9afa5af1515c36021dd4e796812c7c0e50ab9
---
A sartoris/setup.py
1 file changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/12/45712/1
--
To view, visit https://gerrit.wikimedia.org/r/45712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0c9afa5af1515c36021dd4e796812c7c0e50ab9
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add a setup script - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add a setup script
..


Add a setup script

Change-Id: Ic0c9afa5af1515c36021dd4e796812c7c0e50ab9
---
A sartoris/setup.py
1 file changed, 33 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0c9afa5af1515c36021dd4e796812c7c0e50ab9
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add license - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Add license
..

Add license

Change-Id: I67431d1c5f1d747df0bc251710c8c946dcfe7df7
---
A LICENSE.txt
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/13/45713/1
--
To view, visit https://gerrit.wikimedia.org/r/45713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67431d1c5f1d747df0bc251710c8c946dcfe7df7
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add license - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Add license
..


Add license

Change-Id: I67431d1c5f1d747df0bc251710c8c946dcfe7df7
---
A LICENSE.txt
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67431d1c5f1d747df0bc251710c8c946dcfe7df7
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] move setup file - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: move setup file
..

move setup file

Change-Id: I9d3760dc40e8264ac473b1c0cb62eff25d4985ba
---
R setup.py
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/14/45714/1
--
To view, visit https://gerrit.wikimedia.org/r/45714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d3760dc40e8264ac473b1c0cb62eff25d4985ba
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] move setup file - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: move setup file
..


move setup file

Change-Id: I9d3760dc40e8264ac473b1c0cb62eff25d4985ba
---
R setup.py
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d3760dc40e8264ac473b1c0cb62eff25d4985ba
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updates packaging. Note the source file should move to the r... - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has submitted this change and it was merged.

Change subject: Updates packaging. Note the source file should move to the 
root, or become __init__.py
..


Updates packaging. Note the source file should move to the root, or become 
__init__.py

Change-Id: I4ce53f188315bc8f314dd3ef8b514da7f85d87dd
---
M setup.py
1 file changed, 23 insertions(+), 15 deletions(-)

Approvals:
  preilly: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/45716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ce53f188315bc8f314dd3ef8b514da7f85d87dd
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Dsc dschoono...@wikimedia.org
Gerrit-Reviewer: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add empty init - change (sartoris[master])

2013-01-24 Thread preilly (Code Review)
preilly has uploaded a new change for review.

Change subject: Add empty init
..

Add empty init

Change-Id: I96e5cf53d9db388539dc682cb52caaa9b66367a6
---
A __init__.py
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/sartoris refs/changes/18/45718/1
--
To view, visit https://gerrit.wikimedia.org/r/45718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96e5cf53d9db388539dc682cb52caaa9b66367a6
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: preilly prei...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


  1   2   3   4   5   6   >