[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Use camel case for statsd metric names

2016-12-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Use camel case for statsd metric names
..


Use camel case for statsd metric names

Change-Id: I947723fe2457a6fc720c1cf8458800882959f6e6
---
M includes/specials/SpecialCreateTopicPage.php
M 
modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
M 
modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialCreateTopicPage.php 
b/includes/specials/SpecialCreateTopicPage.php
index 167bd83..2288a40 100644
--- a/includes/specials/SpecialCreateTopicPage.php
+++ b/includes/specials/SpecialCreateTopicPage.php
@@ -28,7 +28,7 @@
$this->setHeaders();
if ( $this->getRequest()->getVal( 'ref' ) === 'button' ) {
$statsd = 
MediaWikiServices::getInstance()->getStatsdDataFactory();
-   $statsd->increment( 
'wikibase.articleplaceholder.button.create-article' );
+   $statsd->increment( 
'wikibase.articleplaceholder.button.createArticle' );
}
$page = $this->getRequest()->getVal( 'wptitleinput', $par );
if ( $page === '' || $page === null ) {
diff --git 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
index bd8f55d..7ed4baa 100644
--- 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
+++ 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
@@ -41,7 +41,7 @@
return 
CreateArticleTranslationDialog.super.prototype.onSubmit.apply( this );
}
 
-   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.translate-article' );
+   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.translateArticle' );
 
mw.loader.using( 'ext.cx.sitemapper' ).then( function () {
document.location.href = 
mw.cx.SiteMapper.prototype.getCXUrl(
diff --git 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
index 4ea6b57..b0264d4 100644
--- 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
+++ 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
@@ -19,7 +19,7 @@
windowManager.addWindows( [ dialog ] );
 
OO.ui.infuse( 'new-article-button' ).on( 'click', function () {
-   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.create-article' );
+   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.createArticle' );
windowManager.openWindow( dialog );
} );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/325282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I947723fe2457a6fc720c1cf8458800882959f6e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Addshore 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Use camel case for statsd metric names

2016-12-05 Thread Addshore (Code Review) 
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325282

Change subject: Use camel case for statsd metric names
..

Use camel case for statsd metric names

Change-Id: I947723fe2457a6fc720c1cf8458800882959f6e6
---
M includes/specials/SpecialCreateTopicPage.php
M 
modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
M 
modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder 
refs/changes/82/325282/1

diff --git a/includes/specials/SpecialCreateTopicPage.php 
b/includes/specials/SpecialCreateTopicPage.php
index 167bd83..2288a40 100644
--- a/includes/specials/SpecialCreateTopicPage.php
+++ b/includes/specials/SpecialCreateTopicPage.php
@@ -28,7 +28,7 @@
$this->setHeaders();
if ( $this->getRequest()->getVal( 'ref' ) === 'button' ) {
$statsd = 
MediaWikiServices::getInstance()->getStatsdDataFactory();
-   $statsd->increment( 
'wikibase.articleplaceholder.button.create-article' );
+   $statsd->increment( 
'wikibase.articleplaceholder.button.createArticle' );
}
$page = $this->getRequest()->getVal( 'wptitleinput', $par );
if ( $page === '' || $page === null ) {
diff --git 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
index bd8f55d..7ed4baa 100644
--- 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
+++ 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.createArticleTranslation.js
@@ -41,7 +41,7 @@
return 
CreateArticleTranslationDialog.super.prototype.onSubmit.apply( this );
}
 
-   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.translate-article' );
+   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.translateArticle' );
 
mw.loader.using( 'ext.cx.sitemapper' ).then( function () {
document.location.href = 
mw.cx.SiteMapper.prototype.getCXUrl(
diff --git 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
index 4ea6b57..b0264d4 100644
--- 
a/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
+++ 
b/modules/ext.articleplaceholder.createArticle/ext.articleplaceholder.newArticle.js
@@ -19,7 +19,7 @@
windowManager.addWindows( [ dialog ] );
 
OO.ui.infuse( 'new-article-button' ).on( 'click', function () {
-   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.create-article' );
+   mw.track( 
'counter.MediaWiki.wikibase.articleplaceholder.button.createArticle' );
windowManager.openWindow( dialog );
} );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/325282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I947723fe2457a6fc720c1cf8458800882959f6e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits