[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceExtendedSearch[master]: Remove &$this occurences

2017-12-11 Thread Pwirth (Code Review) 
Pwirth has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397268 )

Change subject: Remove &$this occurences
..


Remove &$this occurences

See T153505 for details.

Change-Id: I1f403daeb143f34e579842bcd9e5b36fa2a0f508
---
M src/Lookup.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pwirth: Verified; Looks good to me, approved



diff --git a/src/Lookup.php b/src/Lookup.php
index f1156de..79b08f4 100644
--- a/src/Lookup.php
+++ b/src/Lookup.php
@@ -342,7 +342,7 @@
 */
public function setBucketTermsAggregation( $sFieldName ) {
$aFieldNames = explode( '/', $sFieldName );
-   $aBase = &$this;
+   $aBase = $this;
foreach( $aFieldNames as $sFieldNamePart ) {
if( !isset( $aBase['aggs'] ) ) {
$aBase['aggs'] = [];
@@ -368,7 +368,7 @@
public function removeBucketTermsAggregation( $sFieldName ) {
$aFieldNames = explode( '/', $sFieldName );
 
-   $aBase = &$this;
+   $aBase = $this;
$aNode = [];
$sLeafFieldName = '';
foreach( $aFieldNames as $sFieldNamePart ) {
@@ -390,4 +390,4 @@
 
return $this;
}
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/397268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f403daeb143f34e579842bcd9e5b36fa2a0f508
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtendedSearch
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceExtendedSearch[master]: Remove &$this occurences

2017-12-10 Thread Robert Vogel (Code Review) 
Robert Vogel has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397268 )

Change subject: Remove &$this occurences
..

Remove &$this occurences

See T153505 for details.

Change-Id: I1f403daeb143f34e579842bcd9e5b36fa2a0f508
---
M src/Lookup.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtendedSearch 
refs/changes/68/397268/1

diff --git a/src/Lookup.php b/src/Lookup.php
index f1156de..79b08f4 100644
--- a/src/Lookup.php
+++ b/src/Lookup.php
@@ -342,7 +342,7 @@
 */
public function setBucketTermsAggregation( $sFieldName ) {
$aFieldNames = explode( '/', $sFieldName );
-   $aBase = &$this;
+   $aBase = $this;
foreach( $aFieldNames as $sFieldNamePart ) {
if( !isset( $aBase['aggs'] ) ) {
$aBase['aggs'] = [];
@@ -368,7 +368,7 @@
public function removeBucketTermsAggregation( $sFieldName ) {
$aFieldNames = explode( '/', $sFieldName );
 
-   $aBase = &$this;
+   $aBase = $this;
$aNode = [];
$sLeafFieldName = '';
foreach( $aFieldNames as $sFieldNamePart ) {
@@ -390,4 +390,4 @@
 
return $this;
}
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/397268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f403daeb143f34e579842bcd9e5b36fa2a0f508
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtendedSearch
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits