[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceExtensions[REL1_23]: Umlauts in URL were causing ExtendedSearch to fail showing t...

2017-01-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/333853 )

Change subject: Umlauts in URL were causing ExtendedSearch to fail showing the 
correct results. This encodes URI to overcome this limitation.
..


Umlauts in URL were causing ExtendedSearch to fail showing the correct
results. This encodes URI to overcome this limitation.

Needs to be cherry-picket to REL1_27 and master

Change-Id: Ia3e77c2557a824c4badcc965ea613bcea26a2881
---
M ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js 
b/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
index 99b6fb9..e519a17 100644
--- a/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
+++ b/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
@@ -77,7 +77,8 @@
 
for ( key2 in 
ExtendedSearchAjaxManager.oUrlParams[key] ){
if ( typeof( 
ExtendedSearchAjaxManager.oUrlParams[key][key2] ) != 'string' ) continue;
-   out.push( key + '[]=' + 
ExtendedSearchAjaxManager.oUrlParams[key][key2] );
+   var keyValue = 
encodeURI(ExtendedSearchAjaxManager.oUrlParams[key][key2] );
+   out.push( key + '[]=' + keyValue );
}
} else {
out.push( key + '=' + 
ExtendedSearchAjaxManager.oUrlParams[key] );

-- 
To view, visit https://gerrit.wikimedia.org/r/333853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3e77c2557a824c4badcc965ea613bcea26a2881
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: ItSpiderman 
Gerrit-Reviewer: Dvogel hallowelt 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceExtensions[REL1_23]: Umlauts in URL were causing ExtendedSearch to fail showing t...

2017-01-23 Thread ItSpiderman (Code Review) 
ItSpiderman has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/333853 )

Change subject: Umlauts in URL were causing ExtendedSearch to fail showing the 
correct results. This encodes URI to overcome this limitation.
..

Umlauts in URL were causing ExtendedSearch to fail showing the correct
results. This encodes URI to overcome this limitation.

Needs to be cherry-picket to REL1_27 and master

Change-Id: Ia3e77c2557a824c4badcc965ea613bcea26a2881
---
M ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/53/333853/1

diff --git a/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js 
b/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
index 99b6fb9..e519a17 100644
--- a/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
+++ b/ExtendedSearch/resources/bluespice.extendedSearch.specialpage.js
@@ -77,7 +77,8 @@
 
for ( key2 in 
ExtendedSearchAjaxManager.oUrlParams[key] ){
if ( typeof( 
ExtendedSearchAjaxManager.oUrlParams[key][key2] ) != 'string' ) continue;
-   out.push( key + '[]=' + 
ExtendedSearchAjaxManager.oUrlParams[key][key2] );
+   var keyValue = 
encodeURI(ExtendedSearchAjaxManager.oUrlParams[key][key2] );
+   out.push( key + '[]=' + keyValue );
}
} else {
out.push( key + '=' + 
ExtendedSearchAjaxManager.oUrlParams[key] );

-- 
To view, visit https://gerrit.wikimedia.org/r/333853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3e77c2557a824c4badcc965ea613bcea26a2881
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: ItSpiderman 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits