[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceFoundation[master]: BSFoundation: Removed unneeded reference

2017-08-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372812 )

Change subject: BSFoundation: Removed unneeded reference
..


BSFoundation: Removed unneeded reference

Change-Id: I1035dc3a9b742d9b50d449a56f899afbf161bc23
---
M src/Hook/BSEntitySetValuesByObject.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pwirth: Looks good to me, approved
  Nasty: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/Hook/BSEntitySetValuesByObject.php 
b/src/Hook/BSEntitySetValuesByObject.php
index 47d7814..a61546b 100644
--- a/src/Hook/BSEntitySetValuesByObject.php
+++ b/src/Hook/BSEntitySetValuesByObject.php
@@ -49,7 +49,7 @@
 * @param \stdClass $data
 * @return boolean
 */
-   public static function callback( $entity, &$data ) {
+   public static function callback( $entity, $data ) {
$className = static::class;
$hookHandler = new $className(
null,
@@ -66,10 +66,10 @@
 * @param Entity $entity
 * @param \stdClass $data
 */
-   public function __construct( $context, $config, $entity, &$data ) {
+   public function __construct( $context, $config, $entity, $data ) {
parent::__construct( $context, $config );
 
$this->entity = $entity;
-   $this->data = &$data;
+   $this->data = $data;
}
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/372812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1035dc3a9b742d9b50d449a56f899afbf161bc23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Pwirth 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Nasty 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceFoundation[master]: BSFoundation: Removed unneeded reference

2017-08-21 Thread Pwirth (Code Review) 
Pwirth has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372812 )

Change subject: BSFoundation: Removed unneeded reference
..

BSFoundation: Removed unneeded reference

Change-Id: I1035dc3a9b742d9b50d449a56f899afbf161bc23
---
M src/Hook/BSEntitySetValuesByObject.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceFoundation 
refs/changes/12/372812/1

diff --git a/src/Hook/BSEntitySetValuesByObject.php 
b/src/Hook/BSEntitySetValuesByObject.php
index 47d7814..a61546b 100644
--- a/src/Hook/BSEntitySetValuesByObject.php
+++ b/src/Hook/BSEntitySetValuesByObject.php
@@ -49,7 +49,7 @@
 * @param \stdClass $data
 * @return boolean
 */
-   public static function callback( $entity, &$data ) {
+   public static function callback( $entity, $data ) {
$className = static::class;
$hookHandler = new $className(
null,
@@ -66,10 +66,10 @@
 * @param Entity $entity
 * @param \stdClass $data
 */
-   public function __construct( $context, $config, $entity, &$data ) {
+   public function __construct( $context, $config, $entity, $data ) {
parent::__construct( $context, $config );
 
$this->entity = $entity;
-   $this->data = &$data;
+   $this->data = $data;
}
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/372812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1035dc3a9b742d9b50d449a56f899afbf161bc23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Pwirth 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits