[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.1]: Search .mw-body instead of #content to support all the skins

2016-11-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Search .mw-body instead of #content to support all the skins
..


Search .mw-body instead of #content to support all the skins

Bug: T150148
Change-Id: Id2368e38942e730a1b13942be238b09e6b1951f4
(cherry picked from commit 1d24b291f91ac4fb72774a464a658a3361514458)
---
M modules/maplink/maplink.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/maplink/maplink.js b/modules/maplink/maplink.js
index 2e7a3b3..0f5e522 100644
--- a/modules/maplink/maplink.js
+++ b/modules/maplink/maplink.js
@@ -66,8 +66,8 @@
 
// Some links might be displayed outside of $content, so we 
need to
// search outside. This is an anti-pattern and should be 
improved...
-   // Meanwhile #content is better than searching the full 
document.
-   $( '.mw-kartographer-maplink', '#content' ).each( function ( 
index ) {
+   // Meanwhile .mw-body is better than searching the full 
document.
+   $( '.mw-kartographer-maplink', '.mw-body' ).each( function ( 
index ) {
var data = getMapData( this ),
link;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/320345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2368e38942e730a1b13942be238b09e6b1951f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.1
Gerrit-Owner: Yurik 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: JGirault 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.1]: Search .mw-body instead of #content to support all the skins

2016-11-07 Thread Yurik (Code Review) 
Yurik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320345

Change subject: Search .mw-body instead of #content to support all the skins
..

Search .mw-body instead of #content to support all the skins

Bug: T150148
Change-Id: Id2368e38942e730a1b13942be238b09e6b1951f4
(cherry picked from commit 1d24b291f91ac4fb72774a464a658a3361514458)
---
M modules/maplink/maplink.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/45/320345/1

diff --git a/modules/maplink/maplink.js b/modules/maplink/maplink.js
index 2e7a3b3..0f5e522 100644
--- a/modules/maplink/maplink.js
+++ b/modules/maplink/maplink.js
@@ -66,8 +66,8 @@
 
// Some links might be displayed outside of $content, so we 
need to
// search outside. This is an anti-pattern and should be 
improved...
-   // Meanwhile #content is better than searching the full 
document.
-   $( '.mw-kartographer-maplink', '#content' ).each( function ( 
index ) {
+   // Meanwhile .mw-body is better than searching the full 
document.
+   $( '.mw-kartographer-maplink', '.mw-body' ).each( function ( 
index ) {
var data = getMapData( this ),
link;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/320345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2368e38942e730a1b13942be238b09e6b1951f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.1
Gerrit-Owner: Yurik 
Gerrit-Reviewer: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits