[MediaWiki-commits] [Gerrit] mediawiki...MoveToCommonsClient[master]: Consistency tweaks in preparation for translatewiki
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/334699 ) Change subject: Consistency tweaks in preparation for translatewiki .. Consistency tweaks in preparation for translatewiki * Make message keys lower case * Make description more descriptive. "Commons" alone is not clear enough * Fix MessagesDirs * Add namemag key Change-Id: I757320da7f14c7bca90773659f3b7c426b3fa515 --- M Hooks.php M extension.json M i18n/en.json M i18n/qqq.json 4 files changed, 11 insertions(+), 10 deletions(-) Approvals: Umherirrender: Looks good to me, but someone else must approve Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/Hooks.php b/Hooks.php index 58f5535..46c211a 100644 --- a/Hooks.php +++ b/Hooks.php @@ -19,7 +19,7 @@ $links['views']['moveToCommons'] = [ 'class' => '', - 'text' => Message::newFromKey( 'moveToCommonsClient-text' )->plain(), + 'text' => Message::newFromKey( 'movetocommonsclient-text' )->plain(), 'href' => $wgMoveToCommonsClientTarget, ]; } diff --git a/extension.json b/extension.json index d642dfd..13ad102 100644 --- a/extension.json +++ b/extension.json @@ -4,13 +4,14 @@ "author": [ "Addshore" ], - "url": "https://www.mediawiki.org/wiki/Extension:MoveToCommons";, - "descriptionmsg": "moveToCommonsClient-desc", + "url": "https://www.mediawiki.org/wiki/Extension:MoveToCommonsClient";, + "namemsg": "movetocommonsclient", + "descriptionmsg": "movetocommonsclient-desc", "license-name": "GPL-2.0+", "type": "other", "manifest_version": 1, "MessagesDirs": { -"TwoColConflict": [ +"MoveToCommonsClient": [ "i18n" ] }, diff --git a/i18n/en.json b/i18n/en.json index 6243097..9e75810 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -4,7 +4,7 @@ "WMDE" ] }, - "moveToCommonsClient": "MoveToCommonsClient", - "moveToCommonsClient-desc": "Easy moving of files to Commons", - "moveToCommonsClient-text": "Move to Commons" + "movetocommonsclient": "MoveToCommonsClient", + "movetocommonsclient-desc": "Easy moving of files to Wikimedia Commons", + "movetocommonsclient-text": "Move to Wikimedia Commons" } \ No newline at end of file diff --git a/i18n/qqq.json b/i18n/qqq.json index 19cfa78..abfbd7f 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -4,7 +4,7 @@ "WMDE" ] }, - "moveToCommonsClient": "MoveToCommonsClient", - "moveToCommonsClient-desc": "{{desc|name=MoveToCommonsClient|url=https://www.mediawiki.org/wiki/Extension:MoveToCommons}}";, - "moveToCommonsClient-text": "Text to be displayed on a button on a File page which will take the user to the page to move a file to Commons." + "movetocommonsclient": "MoveToCommonsClient", + "movetocommonsclient-desc": "{{desc|name=MoveToCommonsClient|url=https://www.mediawiki.org/wiki/Extension:MoveToCommonsClient}}";, + "movetocommonsclient-text": "Text to be displayed on a button on a File page which will take the user to the page to move a file to Wikimedia Commons." } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/334699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I757320da7f14c7bca90773659f3b7c426b3fa515 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MoveToCommonsClient Gerrit-Branch: master Gerrit-Owner: Raimond Spekking Gerrit-Reviewer: Addshore Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MoveToCommonsClient[master]: Consistency tweaks in preparation for translatewiki
Raimond Spekking has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334699 ) Change subject: Consistency tweaks in preparation for translatewiki .. Consistency tweaks in preparation for translatewiki * Make message keys lower case * Make description more descriptive. "Commons" alone is not clear enough * Fix MessagesDirs * Add namemag key Change-Id: I757320da7f14c7bca90773659f3b7c426b3fa515 --- M Hooks.php M extension.json M i18n/en.json M i18n/qqq.json 4 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoveToCommonsClient refs/changes/99/334699/1 diff --git a/Hooks.php b/Hooks.php index 58f5535..46c211a 100644 --- a/Hooks.php +++ b/Hooks.php @@ -19,7 +19,7 @@ $links['views']['moveToCommons'] = [ 'class' => '', - 'text' => Message::newFromKey( 'moveToCommonsClient-text' )->plain(), + 'text' => Message::newFromKey( 'movetocommonsclient-text' )->plain(), 'href' => $wgMoveToCommonsClientTarget, ]; } diff --git a/extension.json b/extension.json index d642dfd..13ad102 100644 --- a/extension.json +++ b/extension.json @@ -4,13 +4,14 @@ "author": [ "Addshore" ], - "url": "https://www.mediawiki.org/wiki/Extension:MoveToCommons";, - "descriptionmsg": "moveToCommonsClient-desc", + "url": "https://www.mediawiki.org/wiki/Extension:MoveToCommonsClient";, + "namemsg": "movetocommonsclient", + "descriptionmsg": "movetocommonsclient-desc", "license-name": "GPL-2.0+", "type": "other", "manifest_version": 1, "MessagesDirs": { -"TwoColConflict": [ +"MoveToCommonsClient": [ "i18n" ] }, diff --git a/i18n/en.json b/i18n/en.json index 6243097..9e75810 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -4,7 +4,7 @@ "WMDE" ] }, - "moveToCommonsClient": "MoveToCommonsClient", - "moveToCommonsClient-desc": "Easy moving of files to Commons", - "moveToCommonsClient-text": "Move to Commons" + "movetocommonsclient": "MoveToCommonsClient", + "movetocommonsclient-desc": "Easy moving of files to Wikimedia Commons", + "movetocommonsclient-text": "Move to Wikimedia Commons" } \ No newline at end of file diff --git a/i18n/qqq.json b/i18n/qqq.json index 19cfa78..96752dc 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -4,7 +4,7 @@ "WMDE" ] }, - "moveToCommonsClient": "MoveToCommonsClient", - "moveToCommonsClient-desc": "{{desc|name=MoveToCommonsClient|url=https://www.mediawiki.org/wiki/Extension:MoveToCommons}}";, - "moveToCommonsClient-text": "Text to be displayed on a button on a File page which will take the user to the page to move a file to Commons." + "movetocommonsclient": "MoveToCommonsClient", + "movetocommonsclient-desc": "{{desc|name=MoveToCommonsClient|url=https://www.mediawiki.org/wiki/Extension:MoveToCommons}}";, + "movetocommonsclient-text": "Text to be displayed on a button on a File page which will take the user to the page to move a file to Commons." } \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/334699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I757320da7f14c7bca90773659f3b7c426b3fa515 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MoveToCommonsClient Gerrit-Branch: master Gerrit-Owner: Raimond Spekking ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits