Paladox has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336736 )
Change subject: Only load necessary fields on Special:TimedMediaHandler lists ...................................................................... Only load necessary fields on Special:TimedMediaHandler lists Special:TimedMediaHandler's list of last 50 errors/etc was running out of memory due to loading every field, including sometimes very long error message dumps. When all 50 had large dumps, this caused failure of the request. Now only loading the two fields needed. Bug: T157621 Change-Id: I2a2067acbda0f57e9b3dd9014aab2fe806f27ae5 (cherry picked from commit 8a83a4a4cb25d40cabb3fb0ffe300e76050e3a19) --- M SpecialTimedMediaHandler.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/36/336736/1 diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php index d929d57..36f5929 100644 --- a/SpecialTimedMediaHandler.php +++ b/SpecialTimedMediaHandler.php @@ -114,7 +114,7 @@ $files = []; $res = $dbr->select( 'transcode', - '*', + [ 'transcode_image_name', 'transcode_key' ], $this->transcodeStates[ $state ], __METHOD__, [ 'LIMIT' => $limit, 'ORDER BY' => 'transcode_time_error DESC' ] -- To view, visit https://gerrit.wikimedia.org/r/336736 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a2067acbda0f57e9b3dd9014aab2fe806f27ae5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: wmf/1.29.0-wmf.10 Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits