[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Remove support for MediaWiki version 1.26
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/380330 ) Change subject: Remove support for MediaWiki version 1.26 .. Remove support for MediaWiki version 1.26 Change-Id: I9ad5e87fa335b2b94840c3b3da4e921a41c71d9c --- M extension.json M resources/js/ext.uls.interface.js 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Nikerabbit: Looks good to me, approved diff --git a/extension.json b/extension.json index 2f6e283..13b4a07 100644 --- a/extension.json +++ b/extension.json @@ -15,6 +15,9 @@ "url": "https://www.mediawiki.org/wiki/Extension:UniversalLanguageSelector;, "descriptionmsg": "uls-desc", "license-name": "GPL-2.0+", + "requires": { + "MediaWiki": ">= 1.27.0" + }, "Hooks": { "BeforePageDisplay": "UniversalLanguageSelectorHooks::addModules", "EnterMobileMode": "UniversalLanguageSelectorHooks::onEnterMobileMode", diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 77f92de..ea5726d 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -456,7 +456,7 @@ } function initTooltip() { - var module, previousLanguage, currentLanguage, previousAutonym, currentAutonym; + var previousLanguage, currentLanguage, previousAutonym, currentAutonym; if ( !userCanChangeLanguage() ) { return; @@ -476,9 +476,7 @@ } if ( previousLanguage !== currentLanguage ) { - // Use oojs-ui-core only after MediaWiki 1.26 is no longer supported - module = mw.loader.getState( 'oojs-ui-core' ) === null ? 'oojs-ui' : 'oojs-ui-core'; - mw.loader.using( module ).done( function () { + mw.loader.using( 'oojs-ui-core' ).done( function () { showUndoTooltip( previousLanguage, previousAutonym ); } ); mw.storage.set( 'uls-previous-language-code', currentLanguage ); -- To view, visit https://gerrit.wikimedia.org/r/380330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ad5e87fa335b2b94840c3b3da4e921a41c71d9c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: FomafixGerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Remove support for MediaWiki version 1.26
Fomafix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380330 ) Change subject: Remove support for MediaWiki version 1.26 .. Remove support for MediaWiki version 1.26 Change-Id: I9ad5e87fa335b2b94840c3b3da4e921a41c71d9c --- M extension.json M resources/js/ext.uls.interface.js 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/30/380330/1 diff --git a/extension.json b/extension.json index 2f6e283..13b4a07 100644 --- a/extension.json +++ b/extension.json @@ -15,6 +15,9 @@ "url": "https://www.mediawiki.org/wiki/Extension:UniversalLanguageSelector;, "descriptionmsg": "uls-desc", "license-name": "GPL-2.0+", + "requires": { + "MediaWiki": ">= 1.27.0" + }, "Hooks": { "BeforePageDisplay": "UniversalLanguageSelectorHooks::addModules", "EnterMobileMode": "UniversalLanguageSelectorHooks::onEnterMobileMode", diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index 77f92de..ea5726d 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -456,7 +456,7 @@ } function initTooltip() { - var module, previousLanguage, currentLanguage, previousAutonym, currentAutonym; + var previousLanguage, currentLanguage, previousAutonym, currentAutonym; if ( !userCanChangeLanguage() ) { return; @@ -476,9 +476,7 @@ } if ( previousLanguage !== currentLanguage ) { - // Use oojs-ui-core only after MediaWiki 1.26 is no longer supported - module = mw.loader.getState( 'oojs-ui-core' ) === null ? 'oojs-ui' : 'oojs-ui-core'; - mw.loader.using( module ).done( function () { + mw.loader.using( 'oojs-ui-core' ).done( function () { showUndoTooltip( previousLanguage, previousAutonym ); } ); mw.storage.set( 'uls-previous-language-code', currentLanguage ); -- To view, visit https://gerrit.wikimedia.org/r/380330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ad5e87fa335b2b94840c3b3da4e921a41c71d9c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Fomafix___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits