[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[wmf/1.31.0-wmf.17]: Fix javascript error on UploadWizard page

2018-01-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405661 )

Change subject: Fix javascript error on UploadWizard page
..


Fix javascript error on UploadWizard page

Javascript error on UploadWizard page was halting execution
of js on the page, which caused the bug.

Bug: T184380
Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
(cherry picked from commit d1ba9b68da812f1bb817756af80c87d1b911643e)
---
M resources/details/uw.DescriptionsDetailsWidget.js
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified
  Cparle: Looks good to me, but someone else must approve



diff --git a/resources/details/uw.DescriptionsDetailsWidget.js 
b/resources/details/uw.DescriptionsDetailsWidget.js
index 294ba47..38c18a5 100644
--- a/resources/details/uw.DescriptionsDetailsWidget.js
+++ b/resources/details/uw.DescriptionsDetailsWidget.js
@@ -56,14 +56,11 @@
 * @param {number} n Number of descriptions
 */
uw.DescriptionsDetailsWidget.prototype.addDescriptions = function ( n ) 
{
-   var i, items = [];
+   var items = [];
while ( n-- ) {
items.push( new uw.DescriptionDetailsWidget() );
}
this.addItems( items );
-   for ( i = 0; i < items.length; i++ ) {
-   items[ i ].initialiseUls();
-   }
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/405661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Cparle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[wmf/1.31.0-wmf.17]: Fix javascript error on UploadWizard page

2018-01-21 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405661 )

Change subject: Fix javascript error on UploadWizard page
..

Fix javascript error on UploadWizard page

Javascript error on UploadWizard page was halting execution
of js on the page, which caused the bug.

Bug: T184380
Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
(cherry picked from commit d1ba9b68da812f1bb817756af80c87d1b911643e)
---
M resources/details/uw.DescriptionsDetailsWidget.js
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/61/405661/1

diff --git a/resources/details/uw.DescriptionsDetailsWidget.js 
b/resources/details/uw.DescriptionsDetailsWidget.js
index 294ba47..38c18a5 100644
--- a/resources/details/uw.DescriptionsDetailsWidget.js
+++ b/resources/details/uw.DescriptionsDetailsWidget.js
@@ -56,14 +56,11 @@
 * @param {number} n Number of descriptions
 */
uw.DescriptionsDetailsWidget.prototype.addDescriptions = function ( n ) 
{
-   var i, items = [];
+   var items = [];
while ( n-- ) {
items.push( new uw.DescriptionDetailsWidget() );
}
this.addItems( items );
-   for ( i = 0; i < items.length; i++ ) {
-   items[ i ].initialiseUls();
-   }
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/405661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I603485550db18dd0459628b0525ef6b24bdd1ed1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Cparle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits