[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[wmf/1.30.0-wmf.18]: Temporarily disable use of client services in repo

2017-09-12 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/377428 )

Change subject: Temporarily disable use of client services in repo
..


Temporarily disable use of client services in repo

Change-Id: Ifb8b4f041458ec2f0f4b79243390ac5c8f860e85
(cherry picked from commit 376c0412eea6746c45c5981605e91438fea86a52)
(cherry picked from commit 54de93c9281f8ce55cae70d2644ad2fa0f10cf4e)
---
M repo/includes/WikibaseRepo.php
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php
index 1bfea12..0db6e3e 100644
--- a/repo/includes/WikibaseRepo.php
+++ b/repo/includes/WikibaseRepo.php
@@ -335,12 +335,6 @@
 
$dataRetrievalServices = null;
 
-   // If client functionality is enabled, use it to enable 
federation.
-   if ( WikibaseSettings::isClientEnabled() ) {
-   $dataRetrievalServices = 
WikibaseClient::getDefaultInstance()->getWikibaseServices();
-   $repositoryDefinitions = 
WikibaseClient::getDefaultInstance()->getRepositoryDefinitions();
-   }
-
return new self(
$settings,
new DataTypeDefinitions(

-- 
To view, visit https://gerrit.wikimedia.org/r/377428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb8b4f041458ec2f0f4b79243390ac5c8f860e85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.30.0-wmf.18
Gerrit-Owner: Aude 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[wmf/1.30.0-wmf.18]: Temporarily disable use of client services in repo

2017-09-12 Thread Aude (Code Review)
Aude has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/377428 )

Change subject: Temporarily disable use of client services in repo
..

Temporarily disable use of client services in repo

Change-Id: Ifb8b4f041458ec2f0f4b79243390ac5c8f860e85
(cherry picked from commit 376c0412eea6746c45c5981605e91438fea86a52)
(cherry picked from commit 54de93c9281f8ce55cae70d2644ad2fa0f10cf4e)
---
M repo/includes/WikibaseRepo.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/28/377428/1

diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php
index 1bfea12..0db6e3e 100644
--- a/repo/includes/WikibaseRepo.php
+++ b/repo/includes/WikibaseRepo.php
@@ -335,12 +335,6 @@
 
$dataRetrievalServices = null;
 
-   // If client functionality is enabled, use it to enable 
federation.
-   if ( WikibaseSettings::isClientEnabled() ) {
-   $dataRetrievalServices = 
WikibaseClient::getDefaultInstance()->getWikibaseServices();
-   $repositoryDefinitions = 
WikibaseClient::getDefaultInstance()->getRepositoryDefinitions();
-   }
-
return new self(
$settings,
new DataTypeDefinitions(

-- 
To view, visit https://gerrit.wikimedia.org/r/377428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb8b4f041458ec2f0f4b79243390ac5c8f860e85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.30.0-wmf.18
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits