[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix status parameter documentation
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404326 ) Change subject: Fix status parameter documentation .. Fix status parameter documentation Originally, I had planned to support caching for requests with e. g. only the violation|warning statuses as well. However, while implementing this, I realized that removing results from the response array structure is not trivial, and so I changed my mind and we now only cache results for requests which specify exactly the right three statuses. Unfortunately, I failed to update the commit message to account for this change. Bug: T183927 Change-Id: Id81382c35aa5cac5a995432673727bc53bff9eec --- M i18n/en.json 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/i18n/en.json b/i18n/en.json index 7bb971a..f10ed45 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -54,7 +54,7 @@ "apihelp-wbcheckconstraints-param-id": "ID list of the entities to get the data from. Separate values with '|' or alternative.", "apihelp-wbcheckconstraints-param-claimid": "GUID list identifying a claim to check a constraint report. Separate values with '|'.", "apihelp-wbcheckconstraints-param-constraintid": "Optional filter to return only the constraints that have the specified constraint ID.", - "apihelp-wbcheckconstraints-param-status": "Optional filter to return only check results with the selected statuses.\n\nNote that only results for the 'violation', 'warning' and 'bad-parameters' statuses are cached, so any request that is not limited to only those statuses (or a subset of them) does not benefit from caching.", + "apihelp-wbcheckconstraints-param-status": "Optional filter to return only check results with the selected statuses.\n\nNote that only results for the 'violation', 'warning' and 'bad-parameters' statuses are cached, so only requests that are limited to exactly those statuses benefit from caching.", "apihelp-wbcheckconstraints-paramvalue-status-compliance": "The statement satisfies the constraint.", "apihelp-wbcheckconstraints-paramvalue-status-violation": "The statement violates the constraint.", "apihelp-wbcheckconstraints-paramvalue-status-exception": "The subject entity of the statement is a known exception to the constraint.", -- To view, visit https://gerrit.wikimedia.org/r/404326 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id81382c35aa5cac5a995432673727bc53bff9eec Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints Gerrit-Branch: master Gerrit-Owner: Lucas Werkmeister (WMDE)Gerrit-Reviewer: Ladsgroup Gerrit-Reviewer: Siebrand Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix status parameter documentation
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404326 ) Change subject: Fix status parameter documentation .. Fix status parameter documentation Originally, I had planned to support caching for requests with e. g. only the violation|warning statuses as well. However, while implementing this, I realized that removing results from the response array structure is not trivial, and so I changed my mind and we now only cache results for requests which specify exactly the right three statuses. Unfortunately, I failed to update the commit message to account for this change. Bug: T183927 Change-Id: Id81382c35aa5cac5a995432673727bc53bff9eec --- M i18n/en.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints refs/changes/26/404326/1 diff --git a/i18n/en.json b/i18n/en.json index 7bb971a..f10ed45 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -54,7 +54,7 @@ "apihelp-wbcheckconstraints-param-id": "ID list of the entities to get the data from. Separate values with '|' or alternative.", "apihelp-wbcheckconstraints-param-claimid": "GUID list identifying a claim to check a constraint report. Separate values with '|'.", "apihelp-wbcheckconstraints-param-constraintid": "Optional filter to return only the constraints that have the specified constraint ID.", - "apihelp-wbcheckconstraints-param-status": "Optional filter to return only check results with the selected statuses.\n\nNote that only results for the 'violation', 'warning' and 'bad-parameters' statuses are cached, so any request that is not limited to only those statuses (or a subset of them) does not benefit from caching.", + "apihelp-wbcheckconstraints-param-status": "Optional filter to return only check results with the selected statuses.\n\nNote that only results for the 'violation', 'warning' and 'bad-parameters' statuses are cached, so only requests that are limited to exactly those statuses benefit from caching.", "apihelp-wbcheckconstraints-paramvalue-status-compliance": "The statement satisfies the constraint.", "apihelp-wbcheckconstraints-paramvalue-status-violation": "The statement violates the constraint.", "apihelp-wbcheckconstraints-paramvalue-status-exception": "The subject entity of the statement is a known exception to the constraint.", -- To view, visit https://gerrit.wikimedia.org/r/404326 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id81382c35aa5cac5a995432673727bc53bff9eec Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints Gerrit-Branch: master Gerrit-Owner: Lucas Werkmeister (WMDE)___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits