[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityExternalValidation[master]: Update deprecated UsageException to ApiUsageException
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330210 ) Change subject: Update deprecated UsageException to ApiUsageException .. Update deprecated UsageException to ApiUsageException Change-Id: Ic19e5377ebec94c0602f419e9ac01f3b5b9bc3d4 --- M specials/SpecialExternalDatabases.php M tests/phpunit/Api/RunCrossCheckTest.php 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/specials/SpecialExternalDatabases.php b/specials/SpecialExternalDatabases.php index 3466dd2..b467154 100644 --- a/specials/SpecialExternalDatabases.php +++ b/specials/SpecialExternalDatabases.php @@ -12,7 +12,6 @@ use Wikibase\Repo\WikibaseRepo; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformationLookup; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\SqlDumpMetaInformationRepo; use WikibaseQuality\ExternalValidation\ExternalValidationServices; use WikibaseQuality\Html\HtmlTableBuilder; use WikibaseQuality\Html\HtmlTableCellBuilder; @@ -25,7 +24,7 @@ private $entityIdLinkFormatter; /** -* @var SqlDumpMetaInformationRepo +* @var DumpMetaInformationLookup */ private $dumpMetaInformationRepo; diff --git a/tests/phpunit/Api/RunCrossCheckTest.php b/tests/phpunit/Api/RunCrossCheckTest.php index eb10f71..00dacfb 100644 --- a/tests/phpunit/Api/RunCrossCheckTest.php +++ b/tests/phpunit/Api/RunCrossCheckTest.php @@ -3,7 +3,7 @@ namespace WikibaseQuality\ExternalValidation\Tests\Api; use DataValues\StringValue; -use UsageException; +use ApiUsageException; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\EntityIdValue; use Wikibase\DataModel\Entity\Item; @@ -188,7 +188,7 @@ ); $this->setExpectedException( - UsageException::class, + ApiUsageException::class, 'Either provide the ids of entities or ids of claims, that should be cross-checked.' ); @@ -201,7 +201,7 @@ ); $this->setExpectedException( - UsageException::class, + ApiUsageException::class, 'A parameter that is required was missing. (Either provide the ids of entities or ' . 'ids of claims, that should be cross-checked.)' ); @@ -280,7 +280,7 @@ 'action' => 'wbqevcrosscheck', 'claims' => 'broken-claim-guid', ); - $this->setExpectedException( UsageException::class, 'Invalid claim guid.' ); + $this->setExpectedException( ApiUsageException::class, 'Invalid claim guid.' ); $this->doApiRequest( $params ); } -- To view, visit https://gerrit.wikimedia.org/r/330210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic19e5377ebec94c0602f419e9ac01f3b5b9bc3d4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) Gerrit-Reviewer: Addshore Gerrit-Reviewer: Aude Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityExternalValidation[master]: Update deprecated UsageException to ApiUsageException
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330210 ) Change subject: Update deprecated UsageException to ApiUsageException .. Update deprecated UsageException to ApiUsageException Change-Id: Ic19e5377ebec94c0602f419e9ac01f3b5b9bc3d4 --- M specials/SpecialExternalDatabases.php M tests/phpunit/Api/RunCrossCheckTest.php 2 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation refs/changes/10/330210/1 diff --git a/specials/SpecialExternalDatabases.php b/specials/SpecialExternalDatabases.php index 3466dd2..b467154 100644 --- a/specials/SpecialExternalDatabases.php +++ b/specials/SpecialExternalDatabases.php @@ -12,7 +12,6 @@ use Wikibase\Repo\WikibaseRepo; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformation; use WikibaseQuality\ExternalValidation\DumpMetaInformation\DumpMetaInformationLookup; -use WikibaseQuality\ExternalValidation\DumpMetaInformation\SqlDumpMetaInformationRepo; use WikibaseQuality\ExternalValidation\ExternalValidationServices; use WikibaseQuality\Html\HtmlTableBuilder; use WikibaseQuality\Html\HtmlTableCellBuilder; @@ -25,7 +24,7 @@ private $entityIdLinkFormatter; /** -* @var SqlDumpMetaInformationRepo +* @var DumpMetaInformationLookup */ private $dumpMetaInformationRepo; diff --git a/tests/phpunit/Api/RunCrossCheckTest.php b/tests/phpunit/Api/RunCrossCheckTest.php index eb10f71..00dacfb 100644 --- a/tests/phpunit/Api/RunCrossCheckTest.php +++ b/tests/phpunit/Api/RunCrossCheckTest.php @@ -3,7 +3,7 @@ namespace WikibaseQuality\ExternalValidation\Tests\Api; use DataValues\StringValue; -use UsageException; +use ApiUsageException; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\EntityIdValue; use Wikibase\DataModel\Entity\Item; @@ -188,7 +188,7 @@ ); $this->setExpectedException( - UsageException::class, + ApiUsageException::class, 'Either provide the ids of entities or ids of claims, that should be cross-checked.' ); @@ -201,7 +201,7 @@ ); $this->setExpectedException( - UsageException::class, + ApiUsageException::class, 'A parameter that is required was missing. (Either provide the ids of entities or ' . 'ids of claims, that should be cross-checked.)' ); @@ -280,7 +280,7 @@ 'action' => 'wbqevcrosscheck', 'claims' => 'broken-claim-guid', ); - $this->setExpectedException( UsageException::class, 'Invalid claim guid.' ); + $this->setExpectedException( ApiUsageException::class, 'Invalid claim guid.' ); $this->doApiRequest( $params ); } -- To view, visit https://gerrit.wikimedia.org/r/330210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic19e5377ebec94c0602f419e9ac01f3b5b9bc3d4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
