[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Temporary work-around: Do not test for bad source

2017-07-12 Thread Mobrovac (Code Review) 
Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364907 )

Change subject: Temporary work-around: Do not test for bad source
..


Temporary work-around: Do not test for bad source

In production this returns a 403 instead of a 504, because we call the
MW API end point regardless of the wiki domain we are after, while
outside of production we use the wiki's domain directly in the URI.
Therefore, we cannot set a unique status code, so disable this specific
check for now.

Bug: T165760
Change-Id: I979211772161190904289a1766616b674cff58cf
---
M spec.yaml
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/spec.yaml b/spec.yaml
index ffc925a..dfa7c22 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -107,15 +107,16 @@
 status: 200
 headers:
   content-type: application/json
-- title: bad source
-  request:
-params:
-  source: qqq
-  domain: de.wikipedia.org
-  response:
-status: 504
-headers:
-  content-type: application/json
+## TODO: Find a solution for this case
+#- title: bad source
+#  request:
+#params:
+#  source: qqq
+#  domain: de.wikipedia.org
+#  response:
+#status: 504
+#headers:
+#  content-type: application/json
 - title: bad seed
   request:
 params:

-- 
To view, visit https://gerrit.wikimedia.org/r/364907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I979211772161190904289a1766616b674cff58cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Temporary work-around: Do not test for bad source

2017-07-12 Thread Mobrovac (Code Review) 
Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364907 )

Change subject: Temporary work-around: Do not test for bad source
..

Temporary work-around: Do not test for bad source

In production this returns a 403 instead of a 504, because we call the
MW API end point regardless of the wiki domain we are after, while
outside of production we use the wiki's domain directly in the URI.
Therefore, we cannot set a unique status code, so disable this specific
check for now.

Bug: T165760
Change-Id: I979211772161190904289a1766616b674cff58cf
---
M spec.yaml
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api 
refs/changes/07/364907/1

diff --git a/spec.yaml b/spec.yaml
index ffc925a..dfa7c22 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -107,15 +107,16 @@
 status: 200
 headers:
   content-type: application/json
-- title: bad source
-  request:
-params:
-  source: qqq
-  domain: de.wikipedia.org
-  response:
-status: 504
-headers:
-  content-type: application/json
+## TODO: Find a solution for this case
+#- title: bad source
+#  request:
+#params:
+#  source: qqq
+#  domain: de.wikipedia.org
+#  response:
+#status: 504
+#headers:
+#  content-type: application/json
 - title: bad seed
   request:
 params:

-- 
To view, visit https://gerrit.wikimedia.org/r/364907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I979211772161190904289a1766616b674cff58cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits