[MediaWiki-commits] [Gerrit] (bug 47435) Fix problem with dismissing copyright notice - change (mediawiki...Wikibase)

2013-04-22 Thread Daniel Werner (Code Review) 
Daniel Werner has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60277


Change subject: (bug 47435) Fix problem with dismissing copyright notice
..

(bug 47435) Fix problem with dismissing copyright notice

Improvement of I010f7086fec45814c2715667f2d2056fdfd926b0 which lead to the 
copyright notice not to
be shown anymore. Instead of using a simple clone, we now clone data and events 
as well.

Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
---
M lib/resources/wikibase.ui.Tooltip.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/77/60277/1

diff --git a/lib/resources/wikibase.ui.Tooltip.js 
b/lib/resources/wikibase.ui.Tooltip.js
index 7a52903..0c20700 100644
--- a/lib/resources/wikibase.ui.Tooltip.js
+++ b/lib/resources/wikibase.ui.Tooltip.js
@@ -236,7 +236,7 @@
// The DOM content needs to be cloned since IE8 will 
lose the reference to the DOM
// content when the inner HTML is removed within 
tipsy's native show() method.
if ( this._DomContent ) {
-   this._DomContent = this._DomContent.clone();
+   this._DomContent = this._DomContent.clone( true 
);
}
this._tipsy.show();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 47435) Fix problem with dismissing copyright notice - change (mediawiki...Wikibase)

2013-04-22 Thread Tobias Gritschacher (Code Review) 
Tobias Gritschacher has submitted this change and it was merged.

Change subject: (bug 47435) Fix problem with dismissing copyright notice
..


(bug 47435) Fix problem with dismissing copyright notice

Improvement of I010f7086fec45814c2715667f2d2056fdfd926b0 which lead to the 
copyright notice not to
be shown anymore. Instead of using a simple clone, we now clone data and events 
as well.

Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
---
M lib/resources/wikibase.ui.Tooltip.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tobias Gritschacher: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/lib/resources/wikibase.ui.Tooltip.js 
b/lib/resources/wikibase.ui.Tooltip.js
index 7a52903..0c20700 100644
--- a/lib/resources/wikibase.ui.Tooltip.js
+++ b/lib/resources/wikibase.ui.Tooltip.js
@@ -236,7 +236,7 @@
// The DOM content needs to be cloned since IE8 will 
lose the reference to the DOM
// content when the inner HTML is removed within 
tipsy's native show() method.
if ( this._DomContent ) {
-   this._DomContent = this._DomContent.clone();
+   this._DomContent = this._DomContent.clone( true 
);
}
this._tipsy.show();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 47435) Fix problem with dismissing copyright notice - change (mediawiki...Wikibase)

2013-04-22 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60284


Change subject: (bug 47435) Fix problem with dismissing copyright notice
..

(bug 47435) Fix problem with dismissing copyright notice

Improvement of I010f7086fec45814c2715667f2d2056fdfd926b0 which lead to the 
copyright notice not to
be shown anymore. Instead of using a simple clone, we now clone data and events 
as well.

Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
---
M lib/resources/wikibase.ui.Tooltip.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/84/60284/1

diff --git a/lib/resources/wikibase.ui.Tooltip.js 
b/lib/resources/wikibase.ui.Tooltip.js
index 7a52903..0c20700 100644
--- a/lib/resources/wikibase.ui.Tooltip.js
+++ b/lib/resources/wikibase.ui.Tooltip.js
@@ -236,7 +236,7 @@
// The DOM content needs to be cloned since IE8 will 
lose the reference to the DOM
// content when the inner HTML is removed within 
tipsy's native show() method.
if ( this._DomContent ) {
-   this._DomContent = this._DomContent.clone();
+   this._DomContent = this._DomContent.clone( true 
);
}
this._tipsy.show();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf2
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 47435) Fix problem with dismissing copyright notice - change (mediawiki...Wikibase)

2013-04-22 Thread Aude (Code Review) 
Aude has submitted this change and it was merged.

Change subject: (bug 47435) Fix problem with dismissing copyright notice
..


(bug 47435) Fix problem with dismissing copyright notice

Improvement of I010f7086fec45814c2715667f2d2056fdfd926b0 which lead to the 
copyright notice not to
be shown anymore. Instead of using a simple clone, we now clone data and events 
as well.

Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
---
M lib/resources/wikibase.ui.Tooltip.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aude: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/lib/resources/wikibase.ui.Tooltip.js 
b/lib/resources/wikibase.ui.Tooltip.js
index 7a52903..0c20700 100644
--- a/lib/resources/wikibase.ui.Tooltip.js
+++ b/lib/resources/wikibase.ui.Tooltip.js
@@ -236,7 +236,7 @@
// The DOM content needs to be cloned since IE8 will 
lose the reference to the DOM
// content when the inner HTML is removed within 
tipsy's native show() method.
if ( this._DomContent ) {
-   this._DomContent = this._DomContent.clone();
+   this._DomContent = this._DomContent.clone( true 
);
}
this._tipsy.show();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf2
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 47435) Fix problem with dismissing copyright notice - change (mediawiki...Wikibase)

2013-04-20 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60133


Change subject: (bug 47435) Fix problem with dismissing copyright notice
..

(bug 47435) Fix problem with dismissing copyright notice

https://gerrit.wikimedia.org/r/#/c/58065/ to use
_DomContent.clone() for the tooltip to fix IE8 causes
the copyright notice tooltip to not be dismissable.

Not sure of a better solution that *both* fixes IE8 and this,
so removing the cloning for now.

Change-Id: I0d89bea59421883de5765e445666267adf02482d
---
M lib/resources/wikibase.ui.Tooltip.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/33/60133/1

diff --git a/lib/resources/wikibase.ui.Tooltip.js 
b/lib/resources/wikibase.ui.Tooltip.js
index 7a52903..06f7e93 100644
--- a/lib/resources/wikibase.ui.Tooltip.js
+++ b/lib/resources/wikibase.ui.Tooltip.js
@@ -233,11 +233,11 @@
// showing the tooltip before filling it with content 
and cache the initial position.
// TODO: This is not the most elegant solution since 
the $tip might reach out of the
// viewport.
-   // The DOM content needs to be cloned since IE8 will 
lose the reference to the DOM
+
+   // Note: The DOM content needs to be cloned since IE8 
will lose the reference to the DOM
// content when the inner HTML is removed within 
tipsy's native show() method.
-   if ( this._DomContent ) {
-   this._DomContent = this._DomContent.clone();
-   }
+   // However, this makes the copyright tooltip sticky in 
other browsers, so
+   // @todo find a way that works for IE8 and does not 
cause issues elsewhere.
this._tipsy.show();
 
var offset = this._tipsy.$tip.offset(),

-- 
To view, visit https://gerrit.wikimedia.org/r/60133
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d89bea59421883de5765e445666267adf02482d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude aude.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits