[MediaWiki-commits] [Gerrit] (testing) fix for selenium sitelinks tests - change (mediawiki...Wikibase)
Anja Jentzsch has uploaded a new change for review. https://gerrit.wikimedia.org/r/51651 Change subject: (testing) fix for selenium sitelinks tests .. (testing) fix for selenium sitelinks tests - we need a better way to get the suggestion list elements, since the serach-box may or may not be a ui-autocomplete element too. Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 --- M selenium/lib/modules/sitelink_module.rb 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/51/51651/1 diff --git a/selenium/lib/modules/sitelink_module.rb b/selenium/lib/modules/sitelink_module.rb index 1405056..020e70a 100644 --- a/selenium/lib/modules/sitelink_module.rb +++ b/selenium/lib/modules/sitelink_module.rb @@ -22,9 +22,10 @@ text_field(:pageInputField, :xpath = //table[contains(@class, 'wb-sitelinks')]/tfoot/tr/td[contains(@class, 'wb-sitelinks-link')]/input) text_field(:pageInputFieldExistingSiteLink, :xpath = //table[contains(@class, 'wb-sitelinks')]/tbody/tr/td[contains(@class, 'wb-sitelinks-link')]/input) span(:saveSitelinkLinkDisabled, :class = wb-ui-toolbar-button-disabled) - unordered_list(:siteIdAutocompleteList, :class = ui-autocomplete, :index = 0) - unordered_list(:pageAutocompleteList, :class = ui-autocomplete, :index = 1) - unordered_list(:editSitelinkAutocompleteList, :class = ui-autocomplete, :index = 0) + unordered_list(:siteIdAutocompleteList, :class = wikibase-siteselector-list) + #todo: this is not a nice way to get the suggestion list, we should find a better way + unordered_list(:pageAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) + unordered_list(:editSitelinkAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) link(:saveSitelinkLink, :text = save) link(:cancelSitelinkLink, :text = cancel) link(:removeSitelinkLink, :text = remove) -- To view, visit https://gerrit.wikimedia.org/r/51651 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.21-wmf11 Gerrit-Owner: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (testing) fix for selenium sitelinks tests - change (mediawiki...Wikibase)
Anja Jentzsch has submitted this change and it was merged. Change subject: (testing) fix for selenium sitelinks tests .. (testing) fix for selenium sitelinks tests - we need a better way to get the suggestion list elements, since the serach-box may or may not be a ui-autocomplete element too. Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 --- M selenium/lib/modules/sitelink_module.rb 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Anja Jentzsch: Verified; Looks good to me, approved diff --git a/selenium/lib/modules/sitelink_module.rb b/selenium/lib/modules/sitelink_module.rb index 1405056..020e70a 100644 --- a/selenium/lib/modules/sitelink_module.rb +++ b/selenium/lib/modules/sitelink_module.rb @@ -22,9 +22,10 @@ text_field(:pageInputField, :xpath = //table[contains(@class, 'wb-sitelinks')]/tfoot/tr/td[contains(@class, 'wb-sitelinks-link')]/input) text_field(:pageInputFieldExistingSiteLink, :xpath = //table[contains(@class, 'wb-sitelinks')]/tbody/tr/td[contains(@class, 'wb-sitelinks-link')]/input) span(:saveSitelinkLinkDisabled, :class = wb-ui-toolbar-button-disabled) - unordered_list(:siteIdAutocompleteList, :class = ui-autocomplete, :index = 0) - unordered_list(:pageAutocompleteList, :class = ui-autocomplete, :index = 1) - unordered_list(:editSitelinkAutocompleteList, :class = ui-autocomplete, :index = 0) + unordered_list(:siteIdAutocompleteList, :class = wikibase-siteselector-list) + #todo: this is not a nice way to get the suggestion list, we should find a better way + unordered_list(:pageAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) + unordered_list(:editSitelinkAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) link(:saveSitelinkLink, :text = save) link(:cancelSitelinkLink, :text = cancel) link(:removeSitelinkLink, :text = remove) -- To view, visit https://gerrit.wikimedia.org/r/51651 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.21-wmf11 Gerrit-Owner: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (testing) fix for selenium sitelinks tests - change (mediawiki...Wikibase)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/51360 Change subject: (testing) fix for selenium sitelinks tests .. (testing) fix for selenium sitelinks tests - we need a better way to get the suggestion list elements, since the serach-box may or may not be a ui-autocomplete element too. Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 --- M selenium/lib/modules/sitelink_module.rb 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/60/51360/1 diff --git a/selenium/lib/modules/sitelink_module.rb b/selenium/lib/modules/sitelink_module.rb index 1405056..020e70a 100644 --- a/selenium/lib/modules/sitelink_module.rb +++ b/selenium/lib/modules/sitelink_module.rb @@ -22,9 +22,10 @@ text_field(:pageInputField, :xpath = //table[contains(@class, 'wb-sitelinks')]/tfoot/tr/td[contains(@class, 'wb-sitelinks-link')]/input) text_field(:pageInputFieldExistingSiteLink, :xpath = //table[contains(@class, 'wb-sitelinks')]/tbody/tr/td[contains(@class, 'wb-sitelinks-link')]/input) span(:saveSitelinkLinkDisabled, :class = wb-ui-toolbar-button-disabled) - unordered_list(:siteIdAutocompleteList, :class = ui-autocomplete, :index = 0) - unordered_list(:pageAutocompleteList, :class = ui-autocomplete, :index = 1) - unordered_list(:editSitelinkAutocompleteList, :class = ui-autocomplete, :index = 0) + unordered_list(:siteIdAutocompleteList, :class = wikibase-siteselector-list) + #todo: this is not a nice way to get the suggestion list, we should find a better way + unordered_list(:pageAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) + unordered_list(:editSitelinkAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) link(:saveSitelinkLink, :text = save) link(:cancelSitelinkLink, :text = cancel) link(:removeSitelinkLink, :text = remove) -- To view, visit https://gerrit.wikimedia.org/r/51360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (testing) fix for selenium sitelinks tests - change (mediawiki...Wikibase)
Tobias Gritschacher has submitted this change and it was merged. Change subject: (testing) fix for selenium sitelinks tests .. (testing) fix for selenium sitelinks tests - we need a better way to get the suggestion list elements, since the serach-box may or may not be a ui-autocomplete element too. Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 --- M selenium/lib/modules/sitelink_module.rb 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/selenium/lib/modules/sitelink_module.rb b/selenium/lib/modules/sitelink_module.rb index 1405056..020e70a 100644 --- a/selenium/lib/modules/sitelink_module.rb +++ b/selenium/lib/modules/sitelink_module.rb @@ -22,9 +22,10 @@ text_field(:pageInputField, :xpath = //table[contains(@class, 'wb-sitelinks')]/tfoot/tr/td[contains(@class, 'wb-sitelinks-link')]/input) text_field(:pageInputFieldExistingSiteLink, :xpath = //table[contains(@class, 'wb-sitelinks')]/tbody/tr/td[contains(@class, 'wb-sitelinks-link')]/input) span(:saveSitelinkLinkDisabled, :class = wb-ui-toolbar-button-disabled) - unordered_list(:siteIdAutocompleteList, :class = ui-autocomplete, :index = 0) - unordered_list(:pageAutocompleteList, :class = ui-autocomplete, :index = 1) - unordered_list(:editSitelinkAutocompleteList, :class = ui-autocomplete, :index = 0) + unordered_list(:siteIdAutocompleteList, :class = wikibase-siteselector-list) + #todo: this is not a nice way to get the suggestion list, we should find a better way + unordered_list(:pageAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) + unordered_list(:editSitelinkAutocompleteList, :xpath = //ul[@class='ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all ui-suggester-list']) link(:saveSitelinkLink, :text = save) link(:cancelSitelinkLink, :text = cancel) link(:removeSitelinkLink, :text = remove) -- To view, visit https://gerrit.wikimedia.org/r/51360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf85a8319b4382145651c208d6caf913fa606d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
