[MediaWiki-commits] [Gerrit] [BrowserTest] Switching from VE to wikitext update workflow - change (mediawiki...VisualEditor)
jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Switching from VE to wikitext update workflow .. [BrowserTest] Switching from VE to wikitext update workflow It got a little more complicated that it had been Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798 --- M modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb M modules/ve-mw/tests/browser/features/switch_editing_mode.feature 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb index d17aa6b..d2ec825 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb @@ -5,6 +5,7 @@ When(/^I enter the wikitext editor$/) do on(VisualEditorPage) do |page| page.edit_wikitext_element.when_present.click +step 'I clear the confirm dialog by clicking Keep changes' page.wikitext_editor_element.when_present end end diff --git a/modules/ve-mw/tests/browser/features/switch_editing_mode.feature b/modules/ve-mw/tests/browser/features/switch_editing_mode.feature index 00784ac..616fce0 100644 --- a/modules/ve-mw/tests/browser/features/switch_editing_mode.feature +++ b/modules/ve-mw/tests/browser/features/switch_editing_mode.feature @@ -6,7 +6,7 @@ Background: Given I am logged in And I go to the browser specific edit page page -When I click Edit for VisualEditor +When I edit the page with Switch edit mode test Scenario: Switch editing modes via toolbar When I enter the wikitext editor -- To view, visit https://gerrit.wikimedia.org/r/148855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [BrowserTest] Switching from VE to wikitext update workflow - change (mediawiki...VisualEditor)
Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/148855 Change subject: [BrowserTest] Switching from VE to wikitext update workflow .. [BrowserTest] Switching from VE to wikitext update workflow It got a little more complicated that it had been Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798 --- M modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb M modules/ve-mw/tests/browser/features/switch_editing_mode.feature 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/55/148855/1 diff --git a/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb index d17aa6b..d2ec825 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb @@ -5,6 +5,7 @@ When(/^I enter the wikitext editor$/) do on(VisualEditorPage) do |page| page.edit_wikitext_element.when_present.click +step 'I clear the confirm dialog by clicking Keep changes' page.wikitext_editor_element.when_present end end diff --git a/modules/ve-mw/tests/browser/features/switch_editing_mode.feature b/modules/ve-mw/tests/browser/features/switch_editing_mode.feature index 00784ac..616fce0 100644 --- a/modules/ve-mw/tests/browser/features/switch_editing_mode.feature +++ b/modules/ve-mw/tests/browser/features/switch_editing_mode.feature @@ -6,7 +6,7 @@ Background: Given I am logged in And I go to the browser specific edit page page -When I click Edit for VisualEditor +When I edit the page with Switch edit mode test Scenario: Switch editing modes via toolbar When I enter the wikitext editor -- To view, visit https://gerrit.wikimedia.org/r/148855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I511aa1b6d5738f1c19d9ac395efccfef6b328798 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Cmcmahon cmcma...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
