[MediaWiki-commits] [Gerrit] [BrowserTest] rubocop updates to replace double quotes with ... - change (mediawiki...VisualEditor)

[Cmcmahon (Code Review)]

Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174959

Change subject: [BrowserTest] rubocop updates to replace double quotes with 
single
..

[BrowserTest] rubocop updates to replace double quotes with single

Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
---
M .rubocop_todo.yml
M modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb
M modules/ve-mw/tests/browser/features/support/env.rb
M modules/ve-mw/tests/browser/features/support/hooks.rb
M modules/ve-mw/tests/browser/features/support/language_screenshot.rb
M modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
M modules/ve-mw/tests/browser/features/support/pages/user_page.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
M modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
M modules/ve-mw/tests/browser/spec/rectangle_spec.rb
M modules/ve-mw/tests/browser/upload.rb
19 files changed, 258 insertions(+), 264 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/59/174959/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c35940b..e22b64b 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -50,9 +50,3 @@
 # Cop supports --auto-correct.
 Style/SpaceAfterComma:
   Enabled: false
-
-# Offense count: 281
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb 
b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
index e464fc3..b33bcfc 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
@@ -7,7 +7,7 @@
 
 When(/^I click Decrease indentation$/) do
   on(VisualEditorPage) do |page|
-step I click in the editable part
+step 'I click in the editable part'
 page.bullet_number_selector_element.when_present.click
 page.decrease_indentation_element.when_present.click
   end
diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb 
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index 18cbcc5..2b4ac7e 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -85,36 +85,36 @@
 Then(/^diff view should show the Book citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite book|title = Book title|last 
= Book author last name|first = Book author first name|publisher = Book 
publisher|year = 2014|isbn = 9780743273565|location = Location of 
publication|pages = 123|New book field = New book field contents}}/refCite 
VisualEditor Test
+expect(page.diff_view).to match 'ref{{Cite book|title = Book title|last 
= Book author last name|first = Book author first name|publisher = Book 
publisher|year = 2014|isbn = 9780743273565|location = Location of 
publication|pages = 123|New book field = New book field contents}}/refCite 
VisualEditor Test'
   end
 end
 
 Then(/^diff view should show the Journal citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite journal|title = Journal 
title|date = Journal Source date}}/refCite VisualEditor Test
+expect(page.diff_view).to match 'ref{{Cite journal|title = Journal 
title|date = Journal Source date}}/refCite VisualEditor Test'
   end
 end
 
 Then(/^diff view should show the News citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite news|url = News URL|title = 
News Source title|last = News Last name|first = News First name|date = News 
Source date|work = News 

[MediaWiki-commits] [Gerrit] [BrowserTest] rubocop updates to replace double quotes with ... - change (mediawiki...VisualEditor)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: [BrowserTest] rubocop updates to replace double quotes with 
single
..


[BrowserTest] rubocop updates to replace double quotes with single

Change-Id: I0608aea2bd634156bf800b3be47a5c2a6d9fadca
---
M .rubocop_todo.yml
M modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
M modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
M 
modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb
M modules/ve-mw/tests/browser/features/support/env.rb
M modules/ve-mw/tests/browser/features/support/hooks.rb
M modules/ve-mw/tests/browser/features/support/language_screenshot.rb
M modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
M modules/ve-mw/tests/browser/features/support/pages/user_page.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
M modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
M modules/ve-mw/tests/browser/spec/rectangle_spec.rb
M modules/ve-mw/tests/browser/upload.rb
19 files changed, 258 insertions(+), 264 deletions(-)

Approvals:
  Zfilipin: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c35940b..e22b64b 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -50,9 +50,3 @@
 # Cop supports --auto-correct.
 Style/SpaceAfterComma:
   Enabled: false
-
-# Offense count: 281
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb 
b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
index e464fc3..b33bcfc 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
@@ -7,7 +7,7 @@
 
 When(/^I click Decrease indentation$/) do
   on(VisualEditorPage) do |page|
-step I click in the editable part
+step 'I click in the editable part'
 page.bullet_number_selector_element.when_present.click
 page.decrease_indentation_element.when_present.click
   end
diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb 
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index 18cbcc5..2b4ac7e 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -85,36 +85,36 @@
 Then(/^diff view should show the Book citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite book|title = Book title|last 
= Book author last name|first = Book author first name|publisher = Book 
publisher|year = 2014|isbn = 9780743273565|location = Location of 
publication|pages = 123|New book field = New book field contents}}/refCite 
VisualEditor Test
+expect(page.diff_view).to match 'ref{{Cite book|title = Book title|last 
= Book author last name|first = Book author first name|publisher = Book 
publisher|year = 2014|isbn = 9780743273565|location = Location of 
publication|pages = 123|New book field = New book field contents}}/refCite 
VisualEditor Test'
   end
 end
 
 Then(/^diff view should show the Journal citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite journal|title = Journal 
title|date = Journal Source date}}/refCite VisualEditor Test
+expect(page.diff_view).to match 'ref{{Cite journal|title = Journal 
title|date = Journal Source date}}/refCite VisualEditor Test'
   end
 end
 
 Then(/^diff view should show the News citation added$/) do
   on(VisualEditorPage) do |page|
 page.wait_until(10) do
-  page.diff_view.include? Cite VisualEditor Test
+  page.diff_view.include? 'Cite VisualEditor Test'
 end
-expect(page.diff_view).to match ref{{Cite news|url = News URL|title = 
News Source title|last = News Last name|first = News First name|date = News 
Source date|work = News Work|accessdate = News URL access date}}/refCite