[MediaWiki-commits] [Gerrit] .unbind() -> .off() - change (VisualEditor/VisualEditor)

2014-05-22 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/134938

Change subject: .unbind() -> .off()
..

.unbind() -> .off()

Because .unbind() stopped being cool when jQuery 1.7 came out in 2011.

Change-Id: I55b260087104b680341810cb878c6d5003fdd163
---
M modules/ve/ce/ve.ce.ProtectedNode.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/38/134938/1

diff --git a/modules/ve/ce/ve.ce.ProtectedNode.js 
b/modules/ve/ce/ve.ce.ProtectedNode.js
index 68babdb..2d1194b 100644
--- a/modules/ve/ce/ve.ce.ProtectedNode.js
+++ b/modules/ve/ce/ve.ce.ProtectedNode.js
@@ -326,7 +326,7 @@
 ve.ce.ProtectedNode.prototype.clearPhantoms = function () {
var surface = this.root.getSurface();
surface.replacePhantoms( null );
-   surface.$element.unbind( '.ve-ce-protectedNode' );
+   surface.$element.off( '.ve-ce-protectedNode' );
surface.getModel().getDocument().disconnect( this, { 'transact': 
'positionPhantoms' } );
this.$phantoms = this.$( [] );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/134938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55b260087104b680341810cb878c6d5003fdd163
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] .unbind() -> .off() - change (VisualEditor/VisualEditor)

2014-05-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: .unbind() -> .off()
..


.unbind() -> .off()

Because .unbind() stopped being cool when jQuery 1.7 came out in 2011.

Change-Id: I55b260087104b680341810cb878c6d5003fdd163
---
M modules/ve/ce/ve.ce.ProtectedNode.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, but someone else must approve
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ce/ve.ce.ProtectedNode.js 
b/modules/ve/ce/ve.ce.ProtectedNode.js
index 68babdb..2d1194b 100644
--- a/modules/ve/ce/ve.ce.ProtectedNode.js
+++ b/modules/ve/ce/ve.ce.ProtectedNode.js
@@ -326,7 +326,7 @@
 ve.ce.ProtectedNode.prototype.clearPhantoms = function () {
var surface = this.root.getSurface();
surface.replacePhantoms( null );
-   surface.$element.unbind( '.ve-ce-protectedNode' );
+   surface.$element.off( '.ve-ce-protectedNode' );
surface.getModel().getDocument().disconnect( this, { 'transact': 
'positionPhantoms' } );
this.$phantoms = this.$( [] );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/134938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55b260087104b680341810cb878c6d5003fdd163
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits